Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "mutex.h" |
| 18 | |
| 19 | #include <errno.h> |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 20 | #include <sys/time.h> |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 21 | |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 22 | #include "atomic.h" |
Elliott Hughes | 07ed66b | 2012-12-12 18:34:25 -0800 | [diff] [blame] | 23 | #include "base/logging.h" |
Vladimir Marko | 80afd02 | 2015-05-19 18:08:00 +0100 | [diff] [blame] | 24 | #include "base/time_utils.h" |
Mathieu Chartier | 32ce2ad | 2016-03-04 14:58:03 -0800 | [diff] [blame] | 25 | #include "base/systrace.h" |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 26 | #include "base/value_object.h" |
Ian Rogers | 693ff61 | 2013-02-01 10:56:12 -0800 | [diff] [blame] | 27 | #include "mutex-inl.h" |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 28 | #include "runtime.h" |
Mathieu Chartier | 0795f23 | 2016-09-27 18:43:30 -0700 | [diff] [blame] | 29 | #include "scoped_thread_state_change-inl.h" |
Ian Rogers | 04d7aa9 | 2013-03-16 14:29:17 -0700 | [diff] [blame] | 30 | #include "thread-inl.h" |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 31 | |
| 32 | namespace art { |
| 33 | |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 34 | Mutex* Locks::abort_lock_ = nullptr; |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 35 | Mutex* Locks::alloc_tracker_lock_ = nullptr; |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 36 | Mutex* Locks::allocated_monitor_ids_lock_ = nullptr; |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 37 | Mutex* Locks::allocated_thread_ids_lock_ = nullptr; |
Sebastien Hertz | ed2be17 | 2014-08-19 15:33:43 +0200 | [diff] [blame] | 38 | ReaderWriterMutex* Locks::breakpoint_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 39 | ReaderWriterMutex* Locks::classlinker_classes_lock_ = nullptr; |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 40 | Mutex* Locks::deoptimization_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 41 | ReaderWriterMutex* Locks::heap_bitmap_lock_ = nullptr; |
Mathieu Chartier | 9ef78b5 | 2014-09-25 17:03:12 -0700 | [diff] [blame] | 42 | Mutex* Locks::instrument_entrypoints_lock_ = nullptr; |
Mathieu Chartier | a5a53ef | 2014-09-12 12:58:05 -0700 | [diff] [blame] | 43 | Mutex* Locks::intern_table_lock_ = nullptr; |
Jeff Hao | a2c3864 | 2015-09-17 17:29:01 -0700 | [diff] [blame] | 44 | Mutex* Locks::interpreter_string_init_map_lock_ = nullptr; |
Ian Rogers | 68d8b42 | 2014-07-17 11:09:10 -0700 | [diff] [blame] | 45 | Mutex* Locks::jni_libraries_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 46 | Mutex* Locks::logging_lock_ = nullptr; |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 47 | Mutex* Locks::mem_maps_lock_ = nullptr; |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 48 | Mutex* Locks::modify_ldt_lock_ = nullptr; |
Yu Li | eac4424 | 2015-06-29 10:50:03 +0800 | [diff] [blame] | 49 | MutatorMutex* Locks::mutator_lock_ = nullptr; |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 50 | Mutex* Locks::profiler_lock_ = nullptr; |
David Brazdil | ca3c8c3 | 2016-09-06 14:04:48 +0100 | [diff] [blame] | 51 | Mutex* Locks::verifier_deps_lock_ = nullptr; |
Mathieu Chartier | f9c6fc6 | 2015-10-07 11:44:05 -0700 | [diff] [blame] | 52 | ReaderWriterMutex* Locks::oat_file_manager_lock_ = nullptr; |
Richard Uhler | a206c74 | 2016-05-24 15:04:22 -0700 | [diff] [blame] | 53 | Mutex* Locks::host_dlopen_handles_lock_ = nullptr; |
Mathieu Chartier | a5a53ef | 2014-09-12 12:58:05 -0700 | [diff] [blame] | 54 | Mutex* Locks::reference_processor_lock_ = nullptr; |
| 55 | Mutex* Locks::reference_queue_cleared_references_lock_ = nullptr; |
| 56 | Mutex* Locks::reference_queue_finalizer_references_lock_ = nullptr; |
| 57 | Mutex* Locks::reference_queue_phantom_references_lock_ = nullptr; |
| 58 | Mutex* Locks::reference_queue_soft_references_lock_ = nullptr; |
| 59 | Mutex* Locks::reference_queue_weak_references_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 60 | Mutex* Locks::runtime_shutdown_lock_ = nullptr; |
| 61 | Mutex* Locks::thread_list_lock_ = nullptr; |
Mathieu Chartier | 91e5669 | 2015-03-03 13:51:04 -0800 | [diff] [blame] | 62 | ConditionVariable* Locks::thread_exit_cond_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 63 | Mutex* Locks::thread_suspend_count_lock_ = nullptr; |
| 64 | Mutex* Locks::trace_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 65 | Mutex* Locks::unexpected_signal_lock_ = nullptr; |
Andreas Gampe | 5bdb655 | 2015-07-22 23:44:55 -0700 | [diff] [blame] | 66 | Uninterruptible Roles::uninterruptible_; |
Andreas Gampe | 05a364c | 2016-10-14 13:27:12 -0700 | [diff] [blame] | 67 | ReaderWriterMutex* Locks::jni_globals_lock_ = nullptr; |
| 68 | Mutex* Locks::jni_weak_globals_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 69 | |
| 70 | struct AllMutexData { |
| 71 | // A guard for all_mutexes_ that's not a mutex (Mutexes must CAS to acquire and busy wait). |
| 72 | Atomic<const BaseMutex*> all_mutexes_guard; |
| 73 | // All created mutexes guarded by all_mutexes_guard_. |
| 74 | std::set<BaseMutex*>* all_mutexes; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 75 | AllMutexData() : all_mutexes(nullptr) {} |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 76 | }; |
| 77 | static struct AllMutexData gAllMutexData[kAllMutexDataSize]; |
| 78 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 79 | #if ART_USE_FUTEXES |
| 80 | static bool ComputeRelativeTimeSpec(timespec* result_ts, const timespec& lhs, const timespec& rhs) { |
Brian Carlstrom | fb6996f | 2013-07-18 18:21:14 -0700 | [diff] [blame] | 81 | const int32_t one_sec = 1000 * 1000 * 1000; // one second in nanoseconds. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 82 | result_ts->tv_sec = lhs.tv_sec - rhs.tv_sec; |
| 83 | result_ts->tv_nsec = lhs.tv_nsec - rhs.tv_nsec; |
| 84 | if (result_ts->tv_nsec < 0) { |
| 85 | result_ts->tv_sec--; |
| 86 | result_ts->tv_nsec += one_sec; |
| 87 | } else if (result_ts->tv_nsec > one_sec) { |
| 88 | result_ts->tv_sec++; |
| 89 | result_ts->tv_nsec -= one_sec; |
| 90 | } |
| 91 | return result_ts->tv_sec < 0; |
| 92 | } |
| 93 | #endif |
| 94 | |
Ian Rogers | 6f3dbba | 2014-10-14 17:41:57 -0700 | [diff] [blame] | 95 | class ScopedAllMutexesLock FINAL { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 96 | public: |
Brian Carlstrom | 93ba893 | 2013-07-17 21:31:49 -0700 | [diff] [blame] | 97 | explicit ScopedAllMutexesLock(const BaseMutex* mutex) : mutex_(mutex) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 98 | while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakAcquire(0, mutex)) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 99 | NanoSleep(100); |
| 100 | } |
| 101 | } |
Ian Rogers | 6f3dbba | 2014-10-14 17:41:57 -0700 | [diff] [blame] | 102 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 103 | ~ScopedAllMutexesLock() { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 104 | while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakRelease(mutex_, 0)) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 105 | NanoSleep(100); |
| 106 | } |
| 107 | } |
Ian Rogers | 6f3dbba | 2014-10-14 17:41:57 -0700 | [diff] [blame] | 108 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 109 | private: |
| 110 | const BaseMutex* const mutex_; |
| 111 | }; |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 112 | |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 113 | // Scoped class that generates events at the beginning and end of lock contention. |
| 114 | class ScopedContentionRecorder FINAL : public ValueObject { |
| 115 | public: |
| 116 | ScopedContentionRecorder(BaseMutex* mutex, uint64_t blocked_tid, uint64_t owner_tid) |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 117 | : mutex_(kLogLockContentions ? mutex : nullptr), |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 118 | blocked_tid_(kLogLockContentions ? blocked_tid : 0), |
| 119 | owner_tid_(kLogLockContentions ? owner_tid : 0), |
| 120 | start_nano_time_(kLogLockContentions ? NanoTime() : 0) { |
| 121 | if (ATRACE_ENABLED()) { |
| 122 | std::string msg = StringPrintf("Lock contention on %s (owner tid: %" PRIu64 ")", |
| 123 | mutex->GetName(), owner_tid); |
| 124 | ATRACE_BEGIN(msg.c_str()); |
| 125 | } |
| 126 | } |
| 127 | |
| 128 | ~ScopedContentionRecorder() { |
| 129 | ATRACE_END(); |
| 130 | if (kLogLockContentions) { |
| 131 | uint64_t end_nano_time = NanoTime(); |
| 132 | mutex_->RecordContention(blocked_tid_, owner_tid_, end_nano_time - start_nano_time_); |
| 133 | } |
| 134 | } |
| 135 | |
| 136 | private: |
| 137 | BaseMutex* const mutex_; |
| 138 | const uint64_t blocked_tid_; |
| 139 | const uint64_t owner_tid_; |
| 140 | const uint64_t start_nano_time_; |
| 141 | }; |
| 142 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 143 | BaseMutex::BaseMutex(const char* name, LockLevel level) : level_(level), name_(name) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 144 | if (kLogLockContentions) { |
| 145 | ScopedAllMutexesLock mu(this); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 146 | std::set<BaseMutex*>** all_mutexes_ptr = &gAllMutexData->all_mutexes; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 147 | if (*all_mutexes_ptr == nullptr) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 148 | // We leak the global set of all mutexes to avoid ordering issues in global variable |
| 149 | // construction/destruction. |
| 150 | *all_mutexes_ptr = new std::set<BaseMutex*>(); |
| 151 | } |
| 152 | (*all_mutexes_ptr)->insert(this); |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 153 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 154 | } |
| 155 | |
| 156 | BaseMutex::~BaseMutex() { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 157 | if (kLogLockContentions) { |
| 158 | ScopedAllMutexesLock mu(this); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 159 | gAllMutexData->all_mutexes->erase(this); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 160 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 161 | } |
| 162 | |
| 163 | void BaseMutex::DumpAll(std::ostream& os) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 164 | if (kLogLockContentions) { |
| 165 | os << "Mutex logging:\n"; |
| 166 | ScopedAllMutexesLock mu(reinterpret_cast<const BaseMutex*>(-1)); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 167 | std::set<BaseMutex*>* all_mutexes = gAllMutexData->all_mutexes; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 168 | if (all_mutexes == nullptr) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 169 | // No mutexes have been created yet during at startup. |
| 170 | return; |
| 171 | } |
| 172 | typedef std::set<BaseMutex*>::const_iterator It; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 173 | os << "(Contended)\n"; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 174 | for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) { |
| 175 | BaseMutex* mutex = *it; |
| 176 | if (mutex->HasEverContended()) { |
| 177 | mutex->Dump(os); |
| 178 | os << "\n"; |
| 179 | } |
| 180 | } |
| 181 | os << "(Never contented)\n"; |
| 182 | for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) { |
| 183 | BaseMutex* mutex = *it; |
| 184 | if (!mutex->HasEverContended()) { |
| 185 | mutex->Dump(os); |
| 186 | os << "\n"; |
| 187 | } |
| 188 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 189 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 190 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 191 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 192 | void BaseMutex::CheckSafeToWait(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 193 | if (self == nullptr) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 194 | CheckUnattachedThread(level_); |
| 195 | return; |
| 196 | } |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 197 | if (kDebugLocking) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 198 | CHECK(self->GetHeldMutex(level_) == this || level_ == kMonitorLock) |
| 199 | << "Waiting on unacquired mutex: " << name_; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 200 | bool bad_mutexes_held = false; |
Elliott Hughes | 0f82716 | 2013-02-26 12:12:58 -0800 | [diff] [blame] | 201 | for (int i = kLockLevelCount - 1; i >= 0; --i) { |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 202 | if (i != level_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 203 | BaseMutex* held_mutex = self->GetHeldMutex(static_cast<LockLevel>(i)); |
Ian Rogers | f3d874c | 2014-07-17 18:52:42 -0700 | [diff] [blame] | 204 | // We expect waits to happen while holding the thread list suspend thread lock. |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 205 | if (held_mutex != nullptr) { |
Elliott Hughes | 0f82716 | 2013-02-26 12:12:58 -0800 | [diff] [blame] | 206 | LOG(ERROR) << "Holding \"" << held_mutex->name_ << "\" " |
| 207 | << "(level " << LockLevel(i) << ") while performing wait on " |
| 208 | << "\"" << name_ << "\" (level " << level_ << ")"; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 209 | bad_mutexes_held = true; |
| 210 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 211 | } |
| 212 | } |
Nicolas Geoffray | db97871 | 2014-12-09 13:33:38 +0000 | [diff] [blame] | 213 | if (gAborting == 0) { // Avoid recursive aborts. |
| 214 | CHECK(!bad_mutexes_held); |
| 215 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 216 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 217 | } |
| 218 | |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame] | 219 | void BaseMutex::ContentionLogData::AddToWaitTime(uint64_t value) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 220 | if (kLogLockContentions) { |
| 221 | // Atomically add value to wait_time. |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame] | 222 | wait_time.FetchAndAddSequentiallyConsistent(value); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 223 | } |
| 224 | } |
| 225 | |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 226 | void BaseMutex::RecordContention(uint64_t blocked_tid, |
| 227 | uint64_t owner_tid, |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 228 | uint64_t nano_time_blocked) { |
| 229 | if (kLogLockContentions) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 230 | ContentionLogData* data = contention_log_data_; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 231 | ++(data->contention_count); |
| 232 | data->AddToWaitTime(nano_time_blocked); |
| 233 | ContentionLogEntry* log = data->contention_log; |
| 234 | // This code is intentionally racy as it is only used for diagnostics. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 235 | uint32_t slot = data->cur_content_log_entry.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 236 | if (log[slot].blocked_tid == blocked_tid && |
| 237 | log[slot].owner_tid == blocked_tid) { |
| 238 | ++log[slot].count; |
| 239 | } else { |
| 240 | uint32_t new_slot; |
| 241 | do { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 242 | slot = data->cur_content_log_entry.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 243 | new_slot = (slot + 1) % kContentionLogSize; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 244 | } while (!data->cur_content_log_entry.CompareExchangeWeakRelaxed(slot, new_slot)); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 245 | log[new_slot].blocked_tid = blocked_tid; |
| 246 | log[new_slot].owner_tid = owner_tid; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 247 | log[new_slot].count.StoreRelaxed(1); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 248 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 249 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 250 | } |
| 251 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 252 | void BaseMutex::DumpContention(std::ostream& os) const { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 253 | if (kLogLockContentions) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 254 | const ContentionLogData* data = contention_log_data_; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 255 | const ContentionLogEntry* log = data->contention_log; |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame] | 256 | uint64_t wait_time = data->wait_time.LoadRelaxed(); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 257 | uint32_t contention_count = data->contention_count.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 258 | if (contention_count == 0) { |
| 259 | os << "never contended"; |
| 260 | } else { |
| 261 | os << "contended " << contention_count |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 262 | << " total wait of contender " << PrettyDuration(wait_time) |
| 263 | << " average " << PrettyDuration(wait_time / contention_count); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 264 | SafeMap<uint64_t, size_t> most_common_blocker; |
| 265 | SafeMap<uint64_t, size_t> most_common_blocked; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 266 | for (size_t i = 0; i < kContentionLogSize; ++i) { |
| 267 | uint64_t blocked_tid = log[i].blocked_tid; |
| 268 | uint64_t owner_tid = log[i].owner_tid; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 269 | uint32_t count = log[i].count.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 270 | if (count > 0) { |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 271 | auto it = most_common_blocked.find(blocked_tid); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 272 | if (it != most_common_blocked.end()) { |
| 273 | most_common_blocked.Overwrite(blocked_tid, it->second + count); |
| 274 | } else { |
| 275 | most_common_blocked.Put(blocked_tid, count); |
| 276 | } |
| 277 | it = most_common_blocker.find(owner_tid); |
| 278 | if (it != most_common_blocker.end()) { |
| 279 | most_common_blocker.Overwrite(owner_tid, it->second + count); |
| 280 | } else { |
| 281 | most_common_blocker.Put(owner_tid, count); |
| 282 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 283 | } |
| 284 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 285 | uint64_t max_tid = 0; |
| 286 | size_t max_tid_count = 0; |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 287 | for (const auto& pair : most_common_blocked) { |
| 288 | if (pair.second > max_tid_count) { |
| 289 | max_tid = pair.first; |
| 290 | max_tid_count = pair.second; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 291 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 292 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 293 | if (max_tid != 0) { |
| 294 | os << " sample shows most blocked tid=" << max_tid; |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 295 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 296 | max_tid = 0; |
| 297 | max_tid_count = 0; |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 298 | for (const auto& pair : most_common_blocker) { |
| 299 | if (pair.second > max_tid_count) { |
| 300 | max_tid = pair.first; |
| 301 | max_tid_count = pair.second; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 302 | } |
| 303 | } |
| 304 | if (max_tid != 0) { |
| 305 | os << " sample shows tid=" << max_tid << " owning during this time"; |
| 306 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 307 | } |
| 308 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 309 | } |
| 310 | |
| 311 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 312 | Mutex::Mutex(const char* name, LockLevel level, bool recursive) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 313 | : BaseMutex(name, level), recursive_(recursive), recursion_count_(0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 314 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 315 | DCHECK_EQ(0, state_.LoadRelaxed()); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 316 | DCHECK_EQ(0, num_contenders_.LoadRelaxed()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 317 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 318 | CHECK_MUTEX_CALL(pthread_mutex_init, (&mutex_, nullptr)); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 319 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 320 | exclusive_owner_ = 0; |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 321 | } |
| 322 | |
Andreas Gampe | 8f1fa10 | 2015-01-22 19:48:51 -0800 | [diff] [blame] | 323 | // Helper to ignore the lock requirement. |
| 324 | static bool IsShuttingDown() NO_THREAD_SAFETY_ANALYSIS { |
| 325 | Runtime* runtime = Runtime::Current(); |
| 326 | return runtime == nullptr || runtime->IsShuttingDownLocked(); |
| 327 | } |
| 328 | |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 329 | Mutex::~Mutex() { |
Andreas Gampe | 8f1fa10 | 2015-01-22 19:48:51 -0800 | [diff] [blame] | 330 | bool shutting_down = IsShuttingDown(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 331 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 332 | if (state_.LoadRelaxed() != 0) { |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 333 | LOG(shutting_down |
| 334 | ? ::android::base::WARNING |
| 335 | : ::android::base::FATAL) << "destroying mutex with owner: " << exclusive_owner_; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 336 | } else { |
Andreas Gampe | 8f1fa10 | 2015-01-22 19:48:51 -0800 | [diff] [blame] | 337 | if (exclusive_owner_ != 0) { |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 338 | LOG(shutting_down |
| 339 | ? ::android::base::WARNING |
| 340 | : ::android::base::FATAL) << "unexpectedly found an owner on unlocked mutex " |
Andreas Gampe | 8f1fa10 | 2015-01-22 19:48:51 -0800 | [diff] [blame] | 341 | << name_; |
| 342 | } |
| 343 | if (num_contenders_.LoadSequentiallyConsistent() != 0) { |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 344 | LOG(shutting_down |
| 345 | ? ::android::base::WARNING |
| 346 | : ::android::base::FATAL) << "unexpectedly found a contender on mutex " << name_; |
Mathieu Chartier | cef50f0 | 2014-12-09 17:38:52 -0800 | [diff] [blame] | 347 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 348 | } |
| 349 | #else |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 350 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 351 | // may still be using locks. |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 352 | int rc = pthread_mutex_destroy(&mutex_); |
| 353 | if (rc != 0) { |
| 354 | errno = rc; |
Elliott Hughes | b3bd5f0 | 2012-03-08 21:05:27 -0800 | [diff] [blame] | 355 | // TODO: should we just not log at all if shutting down? this could be the logging mutex! |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 356 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 357 | PLOG(shutting_down |
| 358 | ? ::android::base::WARNING |
| 359 | : ::android::base::FATAL) << "pthread_mutex_destroy failed for " << name_; |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 360 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 361 | #endif |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 362 | } |
| 363 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 364 | void Mutex::ExclusiveLock(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 365 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 366 | if (kDebugLocking && !recursive_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 367 | AssertNotHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 368 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 369 | if (!recursive_ || !IsExclusiveHeld(self)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 370 | #if ART_USE_FUTEXES |
| 371 | bool done = false; |
| 372 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 373 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 374 | if (LIKELY(cur_state == 0)) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 375 | // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition. |
| 376 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 377 | } else { |
| 378 | // Failed to acquire, hang up. |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 379 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 380 | num_contenders_++; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 381 | if (futex(state_.Address(), FUTEX_WAIT, 1, nullptr, nullptr, 0) != 0) { |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 382 | // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning. |
| 383 | // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock. |
| 384 | if ((errno != EAGAIN) && (errno != EINTR)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 385 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 386 | } |
| 387 | } |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 388 | num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 389 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 390 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 391 | DCHECK_EQ(state_.LoadRelaxed(), 1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 392 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 393 | CHECK_MUTEX_CALL(pthread_mutex_lock, (&mutex_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 394 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 395 | DCHECK_EQ(exclusive_owner_, 0U); |
| 396 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 397 | RegisterAsLocked(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 398 | } |
| 399 | recursion_count_++; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 400 | if (kDebugLocking) { |
| 401 | CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: " |
| 402 | << name_ << " " << recursion_count_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 403 | AssertHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 404 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 405 | } |
| 406 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 407 | bool Mutex::ExclusiveTryLock(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 408 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 409 | if (kDebugLocking && !recursive_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 410 | AssertNotHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 411 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 412 | if (!recursive_ || !IsExclusiveHeld(self)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 413 | #if ART_USE_FUTEXES |
| 414 | bool done = false; |
| 415 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 416 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 417 | if (cur_state == 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 418 | // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition. |
| 419 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 420 | } else { |
| 421 | return false; |
| 422 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 423 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 424 | DCHECK_EQ(state_.LoadRelaxed(), 1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 425 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 426 | int result = pthread_mutex_trylock(&mutex_); |
| 427 | if (result == EBUSY) { |
| 428 | return false; |
| 429 | } |
| 430 | if (result != 0) { |
| 431 | errno = result; |
| 432 | PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_; |
| 433 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 434 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 435 | DCHECK_EQ(exclusive_owner_, 0U); |
| 436 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 437 | RegisterAsLocked(self); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 438 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 439 | recursion_count_++; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 440 | if (kDebugLocking) { |
| 441 | CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: " |
| 442 | << name_ << " " << recursion_count_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 443 | AssertHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 444 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 445 | return true; |
| 446 | } |
| 447 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 448 | void Mutex::ExclusiveUnlock(Thread* self) { |
Mathieu Chartier | eb0a179 | 2014-12-15 17:23:45 -0800 | [diff] [blame] | 449 | if (kIsDebugBuild && self != nullptr && self != Thread::Current()) { |
| 450 | std::string name1 = "<null>"; |
| 451 | std::string name2 = "<null>"; |
| 452 | if (self != nullptr) { |
| 453 | self->GetThreadName(name1); |
| 454 | } |
| 455 | if (Thread::Current() != nullptr) { |
| 456 | Thread::Current()->GetThreadName(name2); |
| 457 | } |
Mathieu Chartier | 4c10110 | 2015-01-27 17:14:16 -0800 | [diff] [blame] | 458 | LOG(FATAL) << GetName() << " level=" << level_ << " self=" << name1 |
| 459 | << " Thread::Current()=" << name2; |
Mathieu Chartier | eb0a179 | 2014-12-15 17:23:45 -0800 | [diff] [blame] | 460 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 461 | AssertHeld(self); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 462 | DCHECK_NE(exclusive_owner_, 0U); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 463 | recursion_count_--; |
| 464 | if (!recursive_ || recursion_count_ == 0) { |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 465 | if (kDebugLocking) { |
| 466 | CHECK(recursion_count_ == 0 || recursive_) << "Unexpected recursion count on mutex: " |
| 467 | << name_ << " " << recursion_count_; |
| 468 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 469 | RegisterAsUnlocked(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 470 | #if ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 471 | bool done = false; |
| 472 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 473 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 474 | if (LIKELY(cur_state == 1)) { |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 475 | // We're no longer the owner. |
| 476 | exclusive_owner_ = 0; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 477 | // Change state to 0 and impose load/store ordering appropriate for lock release. |
| 478 | // Note, the relaxed loads below musn't reorder before the CompareExchange. |
| 479 | // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing |
| 480 | // a status bit into the state on contention. |
| 481 | done = state_.CompareExchangeWeakSequentiallyConsistent(cur_state, 0 /* new state */); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 482 | if (LIKELY(done)) { // Spurious fail? |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 483 | // Wake a contender. |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 484 | if (UNLIKELY(num_contenders_.LoadRelaxed() > 0)) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 485 | futex(state_.Address(), FUTEX_WAKE, 1, nullptr, nullptr, 0); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 486 | } |
| 487 | } |
| 488 | } else { |
| 489 | // Logging acquires the logging lock, avoid infinite recursion in that case. |
| 490 | if (this != Locks::logging_lock_) { |
| 491 | LOG(FATAL) << "Unexpected state_ in unlock " << cur_state << " for " << name_; |
| 492 | } else { |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 493 | LogHelper::LogLineLowStack(__FILE__, |
| 494 | __LINE__, |
| 495 | ::android::base::FATAL_WITHOUT_ABORT, |
| 496 | StringPrintf("Unexpected state_ %d in unlock for %s", |
| 497 | cur_state, name_).c_str()); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 498 | _exit(1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 499 | } |
| 500 | } |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 501 | } while (!done); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 502 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 503 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 504 | CHECK_MUTEX_CALL(pthread_mutex_unlock, (&mutex_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 505 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 506 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 507 | } |
| 508 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 509 | void Mutex::Dump(std::ostream& os) const { |
| 510 | os << (recursive_ ? "recursive " : "non-recursive ") |
| 511 | << name_ |
| 512 | << " level=" << static_cast<int>(level_) |
| 513 | << " rec=" << recursion_count_ |
| 514 | << " owner=" << GetExclusiveOwnerTid() << " "; |
| 515 | DumpContention(os); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 516 | } |
| 517 | |
| 518 | std::ostream& operator<<(std::ostream& os, const Mutex& mu) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 519 | mu.Dump(os); |
| 520 | return os; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 521 | } |
| 522 | |
Brian Carlstrom | 02c8cc6 | 2013-07-18 15:54:44 -0700 | [diff] [blame] | 523 | ReaderWriterMutex::ReaderWriterMutex(const char* name, LockLevel level) |
| 524 | : BaseMutex(name, level) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 525 | #if ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 526 | , state_(0), num_pending_readers_(0), num_pending_writers_(0) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 527 | #endif |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 528 | { // NOLINT(whitespace/braces) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 529 | #if !ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 530 | CHECK_MUTEX_CALL(pthread_rwlock_init, (&rwlock_, nullptr)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 531 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 532 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 533 | } |
| 534 | |
| 535 | ReaderWriterMutex::~ReaderWriterMutex() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 536 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 537 | CHECK_EQ(state_.LoadRelaxed(), 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 538 | CHECK_EQ(exclusive_owner_, 0U); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 539 | CHECK_EQ(num_pending_readers_.LoadRelaxed(), 0); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 540 | CHECK_EQ(num_pending_writers_.LoadRelaxed(), 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 541 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 542 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 543 | // may still be using locks. |
| 544 | int rc = pthread_rwlock_destroy(&rwlock_); |
| 545 | if (rc != 0) { |
| 546 | errno = rc; |
| 547 | // TODO: should we just not log at all if shutting down? this could be the logging mutex! |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 548 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 549 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 550 | bool shutting_down = runtime == nullptr || runtime->IsShuttingDownLocked(); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 551 | PLOG(shutting_down ? WARNING : FATAL) << "pthread_rwlock_destroy failed for " << name_; |
Brian Carlstrom | cd74c4b | 2012-01-23 13:21:00 -0800 | [diff] [blame] | 552 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 553 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 554 | } |
| 555 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 556 | void ReaderWriterMutex::ExclusiveLock(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 557 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 558 | AssertNotExclusiveHeld(self); |
| 559 | #if ART_USE_FUTEXES |
| 560 | bool done = false; |
| 561 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 562 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 563 | if (LIKELY(cur_state == 0)) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 564 | // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition. |
| 565 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state*/, -1 /* new state */); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 566 | } else { |
| 567 | // Failed to acquire, hang up. |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 568 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 569 | ++num_pending_writers_; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 570 | if (futex(state_.Address(), FUTEX_WAIT, cur_state, nullptr, nullptr, 0) != 0) { |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 571 | // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning. |
| 572 | // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock. |
| 573 | if ((errno != EAGAIN) && (errno != EINTR)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 574 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 575 | } |
| 576 | } |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 577 | --num_pending_writers_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 578 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 579 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 580 | DCHECK_EQ(state_.LoadRelaxed(), -1); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 581 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 582 | CHECK_MUTEX_CALL(pthread_rwlock_wrlock, (&rwlock_)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 583 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 584 | DCHECK_EQ(exclusive_owner_, 0U); |
| 585 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 586 | RegisterAsLocked(self); |
| 587 | AssertExclusiveHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 588 | } |
| 589 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 590 | void ReaderWriterMutex::ExclusiveUnlock(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 591 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 592 | AssertExclusiveHeld(self); |
| 593 | RegisterAsUnlocked(self); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 594 | DCHECK_NE(exclusive_owner_, 0U); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 595 | #if ART_USE_FUTEXES |
| 596 | bool done = false; |
| 597 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 598 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 599 | if (LIKELY(cur_state == -1)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 600 | // We're no longer the owner. |
| 601 | exclusive_owner_ = 0; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 602 | // Change state from -1 to 0 and impose load/store ordering appropriate for lock release. |
| 603 | // Note, the relaxed loads below musn't reorder before the CompareExchange. |
| 604 | // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing |
| 605 | // a status bit into the state on contention. |
| 606 | done = state_.CompareExchangeWeakSequentiallyConsistent(-1 /* cur_state*/, 0 /* new state */); |
| 607 | if (LIKELY(done)) { // Weak CAS may fail spuriously. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 608 | // Wake any waiters. |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 609 | if (UNLIKELY(num_pending_readers_.LoadRelaxed() > 0 || |
| 610 | num_pending_writers_.LoadRelaxed() > 0)) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 611 | futex(state_.Address(), FUTEX_WAKE, -1, nullptr, nullptr, 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 612 | } |
| 613 | } |
| 614 | } else { |
| 615 | LOG(FATAL) << "Unexpected state_:" << cur_state << " for " << name_; |
| 616 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 617 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 618 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 619 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 620 | CHECK_MUTEX_CALL(pthread_rwlock_unlock, (&rwlock_)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 621 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 622 | } |
| 623 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 624 | #if HAVE_TIMED_RWLOCK |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 625 | bool ReaderWriterMutex::ExclusiveLockWithTimeout(Thread* self, int64_t ms, int32_t ns) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 626 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 627 | #if ART_USE_FUTEXES |
| 628 | bool done = false; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 629 | timespec end_abs_ts; |
tony.ys_liu | 071e48e | 2015-01-14 18:28:03 +0800 | [diff] [blame] | 630 | InitTimeSpec(true, CLOCK_MONOTONIC, ms, ns, &end_abs_ts); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 631 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 632 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 633 | if (cur_state == 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 634 | // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition. |
| 635 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, -1 /* new state */); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 636 | } else { |
| 637 | // Failed to acquire, hang up. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 638 | timespec now_abs_ts; |
tony.ys_liu | 071e48e | 2015-01-14 18:28:03 +0800 | [diff] [blame] | 639 | InitTimeSpec(true, CLOCK_MONOTONIC, 0, 0, &now_abs_ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 640 | timespec rel_ts; |
| 641 | if (ComputeRelativeTimeSpec(&rel_ts, end_abs_ts, now_abs_ts)) { |
| 642 | return false; // Timed out. |
| 643 | } |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 644 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 645 | ++num_pending_writers_; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 646 | if (futex(state_.Address(), FUTEX_WAIT, cur_state, &rel_ts, nullptr, 0) != 0) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 647 | if (errno == ETIMEDOUT) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 648 | --num_pending_writers_; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 649 | return false; // Timed out. |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 650 | } else if ((errno != EAGAIN) && (errno != EINTR)) { |
| 651 | // EAGAIN and EINTR both indicate a spurious failure, |
| 652 | // recompute the relative time out from now and try again. |
| 653 | // We don't use TEMP_FAILURE_RETRY so we can recompute rel_ts; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 654 | PLOG(FATAL) << "timed futex wait failed for " << name_; |
| 655 | } |
| 656 | } |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 657 | --num_pending_writers_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 658 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 659 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 660 | #else |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 661 | timespec ts; |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame] | 662 | InitTimeSpec(true, CLOCK_REALTIME, ms, ns, &ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 663 | int result = pthread_rwlock_timedwrlock(&rwlock_, &ts); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 664 | if (result == ETIMEDOUT) { |
| 665 | return false; |
| 666 | } |
| 667 | if (result != 0) { |
| 668 | errno = result; |
Ian Rogers | a5acfd3 | 2012-08-15 11:50:10 -0700 | [diff] [blame] | 669 | PLOG(FATAL) << "pthread_rwlock_timedwrlock failed for " << name_; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 670 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 671 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 672 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 673 | RegisterAsLocked(self); |
| 674 | AssertSharedHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 675 | return true; |
| 676 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 677 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 678 | |
Ian Rogers | 51d212e | 2014-10-23 17:48:20 -0700 | [diff] [blame] | 679 | #if ART_USE_FUTEXES |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 680 | void ReaderWriterMutex::HandleSharedLockContention(Thread* self, int32_t cur_state) { |
| 681 | // Owner holds it exclusively, hang up. |
| 682 | ScopedContentionRecorder scr(this, GetExclusiveOwnerTid(), SafeGetTid(self)); |
| 683 | ++num_pending_readers_; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 684 | if (futex(state_.Address(), FUTEX_WAIT, cur_state, nullptr, nullptr, 0) != 0) { |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 685 | if (errno != EAGAIN) { |
| 686 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 687 | } |
| 688 | } |
| 689 | --num_pending_readers_; |
| 690 | } |
Ian Rogers | 51d212e | 2014-10-23 17:48:20 -0700 | [diff] [blame] | 691 | #endif |
Ian Rogers | cf7f191 | 2014-10-22 22:06:39 -0700 | [diff] [blame] | 692 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 693 | bool ReaderWriterMutex::SharedTryLock(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 694 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 695 | #if ART_USE_FUTEXES |
| 696 | bool done = false; |
| 697 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 698 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 699 | if (cur_state >= 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 700 | // Add as an extra reader and impose load/store ordering appropriate for lock acquisition. |
| 701 | done = state_.CompareExchangeWeakAcquire(cur_state, cur_state + 1); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 702 | } else { |
| 703 | // Owner holds it exclusively. |
| 704 | return false; |
| 705 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 706 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 707 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 708 | int result = pthread_rwlock_tryrdlock(&rwlock_); |
| 709 | if (result == EBUSY) { |
| 710 | return false; |
| 711 | } |
| 712 | if (result != 0) { |
| 713 | errno = result; |
| 714 | PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_; |
| 715 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 716 | #endif |
| 717 | RegisterAsLocked(self); |
| 718 | AssertSharedHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 719 | return true; |
| 720 | } |
| 721 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 722 | bool ReaderWriterMutex::IsSharedHeld(const Thread* self) const { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 723 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 724 | bool result; |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 725 | if (UNLIKELY(self == nullptr)) { // Handle unattached threads. |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 726 | result = IsExclusiveHeld(self); // TODO: a better best effort here. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 727 | } else { |
| 728 | result = (self->GetHeldMutex(level_) == this); |
| 729 | } |
| 730 | return result; |
| 731 | } |
| 732 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 733 | void ReaderWriterMutex::Dump(std::ostream& os) const { |
| 734 | os << name_ |
| 735 | << " level=" << static_cast<int>(level_) |
Mathieu Chartier | 5869a2c | 2014-10-08 14:26:23 -0700 | [diff] [blame] | 736 | << " owner=" << GetExclusiveOwnerTid() |
| 737 | #if ART_USE_FUTEXES |
| 738 | << " state=" << state_.LoadSequentiallyConsistent() |
| 739 | << " num_pending_writers=" << num_pending_writers_.LoadSequentiallyConsistent() |
| 740 | << " num_pending_readers=" << num_pending_readers_.LoadSequentiallyConsistent() |
| 741 | #endif |
| 742 | << " "; |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 743 | DumpContention(os); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 744 | } |
| 745 | |
| 746 | std::ostream& operator<<(std::ostream& os, const ReaderWriterMutex& mu) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 747 | mu.Dump(os); |
| 748 | return os; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 749 | } |
| 750 | |
Yu Li | eac4424 | 2015-06-29 10:50:03 +0800 | [diff] [blame] | 751 | std::ostream& operator<<(std::ostream& os, const MutatorMutex& mu) { |
| 752 | mu.Dump(os); |
| 753 | return os; |
| 754 | } |
| 755 | |
Ian Rogers | 23055dc | 2013-04-18 16:29:16 -0700 | [diff] [blame] | 756 | ConditionVariable::ConditionVariable(const char* name, Mutex& guard) |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 757 | : name_(name), guard_(guard) { |
| 758 | #if ART_USE_FUTEXES |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 759 | DCHECK_EQ(0, sequence_.LoadRelaxed()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 760 | num_waiters_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 761 | #else |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 762 | pthread_condattr_t cond_attrs; |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 763 | CHECK_MUTEX_CALL(pthread_condattr_init, (&cond_attrs)); |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 764 | #if !defined(__APPLE__) |
| 765 | // Apple doesn't have CLOCK_MONOTONIC or pthread_condattr_setclock. |
Ian Rogers | 51d212e | 2014-10-23 17:48:20 -0700 | [diff] [blame] | 766 | CHECK_MUTEX_CALL(pthread_condattr_setclock, (&cond_attrs, CLOCK_MONOTONIC)); |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 767 | #endif |
| 768 | CHECK_MUTEX_CALL(pthread_cond_init, (&cond_, &cond_attrs)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 769 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 770 | } |
| 771 | |
| 772 | ConditionVariable::~ConditionVariable() { |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 773 | #if ART_USE_FUTEXES |
| 774 | if (num_waiters_!= 0) { |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 775 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 776 | bool shutting_down = runtime == nullptr || runtime->IsShuttingDown(Thread::Current()); |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 777 | LOG(shutting_down |
| 778 | ? ::android::base::WARNING |
| 779 | : ::android::base::FATAL) |
| 780 | << "ConditionVariable::~ConditionVariable for " << name_ |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 781 | << " called with " << num_waiters_ << " waiters."; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 782 | } |
| 783 | #else |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 784 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 785 | // may still be using condition variables. |
| 786 | int rc = pthread_cond_destroy(&cond_); |
| 787 | if (rc != 0) { |
| 788 | errno = rc; |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 789 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 790 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 791 | bool shutting_down = (runtime == nullptr) || runtime->IsShuttingDownLocked(); |
Andreas Gampe | 3fec9ac | 2016-09-13 10:47:28 -0700 | [diff] [blame] | 792 | PLOG(shutting_down |
| 793 | ? ::android::base::WARNING |
| 794 | : ::android::base::FATAL) << "pthread_cond_destroy failed for " << name_; |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 795 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 796 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 797 | } |
| 798 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 799 | void ConditionVariable::Broadcast(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 800 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 801 | // TODO: enable below, there's a race in thread creation that causes false failures currently. |
| 802 | // guard_.AssertExclusiveHeld(self); |
Mathieu Chartier | e46cd75 | 2012-10-31 16:56:18 -0700 | [diff] [blame] | 803 | DCHECK_EQ(guard_.GetExclusiveOwnerTid(), SafeGetTid(self)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 804 | #if ART_USE_FUTEXES |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 805 | if (num_waiters_ > 0) { |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 806 | sequence_++; // Indicate the broadcast occurred. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 807 | bool done = false; |
| 808 | do { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 809 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 810 | // Requeue waiters onto mutex. The waiter holds the contender count on the mutex high ensuring |
| 811 | // mutex unlocks will awaken the requeued waiter thread. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 812 | done = futex(sequence_.Address(), FUTEX_CMP_REQUEUE, 0, |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 813 | reinterpret_cast<const timespec*>(std::numeric_limits<int32_t>::max()), |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 814 | guard_.state_.Address(), cur_sequence) != -1; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 815 | if (!done) { |
| 816 | if (errno != EAGAIN) { |
| 817 | PLOG(FATAL) << "futex cmp requeue failed for " << name_; |
| 818 | } |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 819 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 820 | } while (!done); |
| 821 | } |
| 822 | #else |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 823 | CHECK_MUTEX_CALL(pthread_cond_broadcast, (&cond_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 824 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 825 | } |
| 826 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 827 | void ConditionVariable::Signal(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 828 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 829 | guard_.AssertExclusiveHeld(self); |
| 830 | #if ART_USE_FUTEXES |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 831 | if (num_waiters_ > 0) { |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 832 | sequence_++; // Indicate a signal occurred. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 833 | // Futex wake 1 waiter who will then come and in contend on mutex. It'd be nice to requeue them |
| 834 | // to avoid this, however, requeueing can only move all waiters. |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 835 | int num_woken = futex(sequence_.Address(), FUTEX_WAKE, 1, nullptr, nullptr, 0); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 836 | // Check something was woken or else we changed sequence_ before they had chance to wait. |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 837 | CHECK((num_woken == 0) || (num_woken == 1)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 838 | } |
| 839 | #else |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 840 | CHECK_MUTEX_CALL(pthread_cond_signal, (&cond_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 841 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 842 | } |
| 843 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 844 | void ConditionVariable::Wait(Thread* self) { |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 845 | guard_.CheckSafeToWait(self); |
| 846 | WaitHoldingLocks(self); |
| 847 | } |
| 848 | |
| 849 | void ConditionVariable::WaitHoldingLocks(Thread* self) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 850 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 851 | guard_.AssertExclusiveHeld(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 852 | unsigned int old_recursion_count = guard_.recursion_count_; |
| 853 | #if ART_USE_FUTEXES |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 854 | num_waiters_++; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 855 | // Ensure the Mutex is contended so that requeued threads are awoken. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 856 | guard_.num_contenders_++; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 857 | guard_.recursion_count_ = 1; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 858 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 859 | guard_.ExclusiveUnlock(self); |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 860 | if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, nullptr, nullptr, 0) != 0) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 861 | // Futex failed, check it is an expected error. |
| 862 | // EAGAIN == EWOULDBLK, so we let the caller try again. |
| 863 | // EINTR implies a signal was sent to this thread. |
| 864 | if ((errno != EINTR) && (errno != EAGAIN)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 865 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 866 | } |
| 867 | } |
Mathieu Chartier | 4d87df6 | 2016-01-07 15:14:19 -0800 | [diff] [blame] | 868 | if (self != nullptr) { |
| 869 | JNIEnvExt* const env = self->GetJniEnv(); |
| 870 | if (UNLIKELY(env != nullptr && env->runtime_deleted)) { |
| 871 | CHECK(self->IsDaemon()); |
| 872 | // If the runtime has been deleted, then we cannot proceed. Just sleep forever. This may |
| 873 | // occur for user daemon threads that get a spurious wakeup. This occurs for test 132 with |
| 874 | // --host and --gdb. |
| 875 | // After we wake up, the runtime may have been shutdown, which means that this condition may |
| 876 | // have been deleted. It is not safe to retry the wait. |
| 877 | SleepForever(); |
| 878 | } |
| 879 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 880 | guard_.ExclusiveLock(self); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 881 | CHECK_GE(num_waiters_, 0); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 882 | num_waiters_--; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 883 | // We awoke and so no longer require awakes from the guard_'s unlock. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 884 | CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 885 | guard_.num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 886 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 887 | uint64_t old_owner = guard_.exclusive_owner_; |
| 888 | guard_.exclusive_owner_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 889 | guard_.recursion_count_ = 0; |
| 890 | CHECK_MUTEX_CALL(pthread_cond_wait, (&cond_, &guard_.mutex_)); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 891 | guard_.exclusive_owner_ = old_owner; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 892 | #endif |
| 893 | guard_.recursion_count_ = old_recursion_count; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 894 | } |
| 895 | |
Ian Rogers | 7b078e8 | 2014-09-10 14:44:24 -0700 | [diff] [blame] | 896 | bool ConditionVariable::TimedWait(Thread* self, int64_t ms, int32_t ns) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 897 | DCHECK(self == nullptr || self == Thread::Current()); |
Ian Rogers | 7b078e8 | 2014-09-10 14:44:24 -0700 | [diff] [blame] | 898 | bool timed_out = false; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 899 | guard_.AssertExclusiveHeld(self); |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 900 | guard_.CheckSafeToWait(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 901 | unsigned int old_recursion_count = guard_.recursion_count_; |
| 902 | #if ART_USE_FUTEXES |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 903 | timespec rel_ts; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 904 | InitTimeSpec(false, CLOCK_REALTIME, ms, ns, &rel_ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 905 | num_waiters_++; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 906 | // Ensure the Mutex is contended so that requeued threads are awoken. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 907 | guard_.num_contenders_++; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 908 | guard_.recursion_count_ = 1; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 909 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 910 | guard_.ExclusiveUnlock(self); |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 911 | if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, &rel_ts, nullptr, 0) != 0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 912 | if (errno == ETIMEDOUT) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 913 | // Timed out we're done. |
Ian Rogers | 7b078e8 | 2014-09-10 14:44:24 -0700 | [diff] [blame] | 914 | timed_out = true; |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 915 | } else if ((errno == EAGAIN) || (errno == EINTR)) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 916 | // A signal or ConditionVariable::Signal/Broadcast has come in. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 917 | } else { |
| 918 | PLOG(FATAL) << "timed futex wait failed for " << name_; |
| 919 | } |
| 920 | } |
| 921 | guard_.ExclusiveLock(self); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 922 | CHECK_GE(num_waiters_, 0); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 923 | num_waiters_--; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 924 | // We awoke and so no longer require awakes from the guard_'s unlock. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 925 | CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 926 | guard_.num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 927 | #else |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 928 | #if !defined(__APPLE__) |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 929 | int clock = CLOCK_MONOTONIC; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 930 | #else |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 931 | int clock = CLOCK_REALTIME; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 932 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 933 | uint64_t old_owner = guard_.exclusive_owner_; |
| 934 | guard_.exclusive_owner_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 935 | guard_.recursion_count_ = 0; |
| 936 | timespec ts; |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame] | 937 | InitTimeSpec(true, clock, ms, ns, &ts); |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 938 | int rc = TEMP_FAILURE_RETRY(pthread_cond_timedwait(&cond_, &guard_.mutex_, &ts)); |
Ian Rogers | 7b078e8 | 2014-09-10 14:44:24 -0700 | [diff] [blame] | 939 | if (rc == ETIMEDOUT) { |
| 940 | timed_out = true; |
| 941 | } else if (rc != 0) { |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 942 | errno = rc; |
| 943 | PLOG(FATAL) << "TimedWait failed for " << name_; |
| 944 | } |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 945 | guard_.exclusive_owner_ = old_owner; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 946 | #endif |
| 947 | guard_.recursion_count_ = old_recursion_count; |
Ian Rogers | 7b078e8 | 2014-09-10 14:44:24 -0700 | [diff] [blame] | 948 | return timed_out; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 949 | } |
| 950 | |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 951 | void Locks::Init() { |
| 952 | if (logging_lock_ != nullptr) { |
| 953 | // Already initialized. |
Nicolas Geoffray | 7f0a6d6 | 2014-05-26 14:01:46 +0100 | [diff] [blame] | 954 | if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 955 | DCHECK(modify_ldt_lock_ != nullptr); |
| 956 | } else { |
| 957 | DCHECK(modify_ldt_lock_ == nullptr); |
| 958 | } |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 959 | DCHECK(abort_lock_ != nullptr); |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 960 | DCHECK(alloc_tracker_lock_ != nullptr); |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 961 | DCHECK(allocated_monitor_ids_lock_ != nullptr); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 962 | DCHECK(allocated_thread_ids_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 963 | DCHECK(breakpoint_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 964 | DCHECK(classlinker_classes_lock_ != nullptr); |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 965 | DCHECK(deoptimization_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 966 | DCHECK(heap_bitmap_lock_ != nullptr); |
Mathieu Chartier | f9c6fc6 | 2015-10-07 11:44:05 -0700 | [diff] [blame] | 967 | DCHECK(oat_file_manager_lock_ != nullptr); |
David Brazdil | ca3c8c3 | 2016-09-06 14:04:48 +0100 | [diff] [blame] | 968 | DCHECK(verifier_deps_lock_ != nullptr); |
Richard Uhler | a206c74 | 2016-05-24 15:04:22 -0700 | [diff] [blame] | 969 | DCHECK(host_dlopen_handles_lock_ != nullptr); |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 970 | DCHECK(intern_table_lock_ != nullptr); |
Ian Rogers | 68d8b42 | 2014-07-17 11:09:10 -0700 | [diff] [blame] | 971 | DCHECK(jni_libraries_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 972 | DCHECK(logging_lock_ != nullptr); |
| 973 | DCHECK(mutator_lock_ != nullptr); |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 974 | DCHECK(profiler_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 975 | DCHECK(thread_list_lock_ != nullptr); |
| 976 | DCHECK(thread_suspend_count_lock_ != nullptr); |
| 977 | DCHECK(trace_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 978 | DCHECK(unexpected_signal_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 979 | } else { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 980 | // Create global locks in level order from highest lock level to lowest. |
Ian Rogers | 4ad5cd3 | 2014-11-11 23:08:07 -0800 | [diff] [blame] | 981 | LockLevel current_lock_level = kInstrumentEntrypointsLock; |
| 982 | DCHECK(instrument_entrypoints_lock_ == nullptr); |
| 983 | instrument_entrypoints_lock_ = new Mutex("instrument entrypoint lock", current_lock_level); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 984 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 985 | #define UPDATE_CURRENT_LOCK_LEVEL(new_level) \ |
Chih-Hung Hsieh | fba3997 | 2016-05-11 11:26:48 -0700 | [diff] [blame] | 986 | if ((new_level) >= current_lock_level) { \ |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 987 | /* Do not use CHECKs or FATAL here, abort_lock_ is not setup yet. */ \ |
| 988 | fprintf(stderr, "New local level %d is not less than current level %d\n", \ |
| 989 | new_level, current_lock_level); \ |
| 990 | exit(1); \ |
| 991 | } \ |
Ian Rogers | f3d874c | 2014-07-17 18:52:42 -0700 | [diff] [blame] | 992 | current_lock_level = new_level; |
| 993 | |
| 994 | UPDATE_CURRENT_LOCK_LEVEL(kMutatorLock); |
| 995 | DCHECK(mutator_lock_ == nullptr); |
Yu Li | eac4424 | 2015-06-29 10:50:03 +0800 | [diff] [blame] | 996 | mutator_lock_ = new MutatorMutex("mutator lock", current_lock_level); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 997 | |
| 998 | UPDATE_CURRENT_LOCK_LEVEL(kHeapBitmapLock); |
| 999 | DCHECK(heap_bitmap_lock_ == nullptr); |
| 1000 | heap_bitmap_lock_ = new ReaderWriterMutex("heap bitmap lock", current_lock_level); |
| 1001 | |
Jeff Hao | 69dbec6 | 2014-09-15 18:03:41 -0700 | [diff] [blame] | 1002 | UPDATE_CURRENT_LOCK_LEVEL(kTraceLock); |
| 1003 | DCHECK(trace_lock_ == nullptr); |
| 1004 | trace_lock_ = new Mutex("trace lock", current_lock_level); |
| 1005 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1006 | UPDATE_CURRENT_LOCK_LEVEL(kRuntimeShutdownLock); |
| 1007 | DCHECK(runtime_shutdown_lock_ == nullptr); |
| 1008 | runtime_shutdown_lock_ = new Mutex("runtime shutdown lock", current_lock_level); |
| 1009 | |
| 1010 | UPDATE_CURRENT_LOCK_LEVEL(kProfilerLock); |
| 1011 | DCHECK(profiler_lock_ == nullptr); |
| 1012 | profiler_lock_ = new Mutex("profiler lock", current_lock_level); |
| 1013 | |
Brian Carlstrom | 306db81 | 2014-09-05 13:01:41 -0700 | [diff] [blame] | 1014 | UPDATE_CURRENT_LOCK_LEVEL(kDeoptimizationLock); |
| 1015 | DCHECK(deoptimization_lock_ == nullptr); |
| 1016 | deoptimization_lock_ = new Mutex("Deoptimization lock", current_lock_level); |
| 1017 | |
| 1018 | UPDATE_CURRENT_LOCK_LEVEL(kAllocTrackerLock); |
| 1019 | DCHECK(alloc_tracker_lock_ == nullptr); |
| 1020 | alloc_tracker_lock_ = new Mutex("AllocTracker lock", current_lock_level); |
| 1021 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1022 | UPDATE_CURRENT_LOCK_LEVEL(kThreadListLock); |
| 1023 | DCHECK(thread_list_lock_ == nullptr); |
| 1024 | thread_list_lock_ = new Mutex("thread list lock", current_lock_level); |
| 1025 | |
Ian Rogers | 68d8b42 | 2014-07-17 11:09:10 -0700 | [diff] [blame] | 1026 | UPDATE_CURRENT_LOCK_LEVEL(kJniLoadLibraryLock); |
| 1027 | DCHECK(jni_libraries_lock_ == nullptr); |
| 1028 | jni_libraries_lock_ = new Mutex("JNI shared libraries map lock", current_lock_level); |
| 1029 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1030 | UPDATE_CURRENT_LOCK_LEVEL(kBreakpointLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 1031 | DCHECK(breakpoint_lock_ == nullptr); |
Sebastien Hertz | ed2be17 | 2014-08-19 15:33:43 +0200 | [diff] [blame] | 1032 | breakpoint_lock_ = new ReaderWriterMutex("breakpoint lock", current_lock_level); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1033 | |
| 1034 | UPDATE_CURRENT_LOCK_LEVEL(kClassLinkerClassesLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 1035 | DCHECK(classlinker_classes_lock_ == nullptr); |
| 1036 | classlinker_classes_lock_ = new ReaderWriterMutex("ClassLinker classes lock", |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1037 | current_lock_level); |
| 1038 | |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 1039 | UPDATE_CURRENT_LOCK_LEVEL(kMonitorPoolLock); |
| 1040 | DCHECK(allocated_monitor_ids_lock_ == nullptr); |
| 1041 | allocated_monitor_ids_lock_ = new Mutex("allocated monitor ids lock", current_lock_level); |
| 1042 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1043 | UPDATE_CURRENT_LOCK_LEVEL(kAllocatedThreadIdsLock); |
| 1044 | DCHECK(allocated_thread_ids_lock_ == nullptr); |
| 1045 | allocated_thread_ids_lock_ = new Mutex("allocated thread ids lock", current_lock_level); |
| 1046 | |
Nicolas Geoffray | 7f0a6d6 | 2014-05-26 14:01:46 +0100 | [diff] [blame] | 1047 | if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1048 | UPDATE_CURRENT_LOCK_LEVEL(kModifyLdtLock); |
| 1049 | DCHECK(modify_ldt_lock_ == nullptr); |
| 1050 | modify_ldt_lock_ = new Mutex("modify_ldt lock", current_lock_level); |
| 1051 | } |
| 1052 | |
Mathieu Chartier | f9c6fc6 | 2015-10-07 11:44:05 -0700 | [diff] [blame] | 1053 | UPDATE_CURRENT_LOCK_LEVEL(kOatFileManagerLock); |
| 1054 | DCHECK(oat_file_manager_lock_ == nullptr); |
| 1055 | oat_file_manager_lock_ = new ReaderWriterMutex("OatFile manager lock", current_lock_level); |
| 1056 | |
David Brazdil | ca3c8c3 | 2016-09-06 14:04:48 +0100 | [diff] [blame] | 1057 | UPDATE_CURRENT_LOCK_LEVEL(kVerifierDepsLock); |
| 1058 | DCHECK(verifier_deps_lock_ == nullptr); |
| 1059 | verifier_deps_lock_ = new Mutex("verifier deps lock", current_lock_level); |
| 1060 | |
Richard Uhler | a206c74 | 2016-05-24 15:04:22 -0700 | [diff] [blame] | 1061 | UPDATE_CURRENT_LOCK_LEVEL(kHostDlOpenHandlesLock); |
| 1062 | DCHECK(host_dlopen_handles_lock_ == nullptr); |
| 1063 | host_dlopen_handles_lock_ = new Mutex("host dlopen handles lock", current_lock_level); |
Mathieu Chartier | e58991b | 2015-10-13 07:59:34 -0700 | [diff] [blame] | 1064 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1065 | UPDATE_CURRENT_LOCK_LEVEL(kInternTableLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 1066 | DCHECK(intern_table_lock_ == nullptr); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1067 | intern_table_lock_ = new Mutex("InternTable lock", current_lock_level); |
| 1068 | |
Mathieu Chartier | a5a53ef | 2014-09-12 12:58:05 -0700 | [diff] [blame] | 1069 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceProcessorLock); |
| 1070 | DCHECK(reference_processor_lock_ == nullptr); |
| 1071 | reference_processor_lock_ = new Mutex("ReferenceProcessor lock", current_lock_level); |
| 1072 | |
| 1073 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceQueueClearedReferencesLock); |
| 1074 | DCHECK(reference_queue_cleared_references_lock_ == nullptr); |
| 1075 | reference_queue_cleared_references_lock_ = new Mutex("ReferenceQueue cleared references lock", current_lock_level); |
| 1076 | |
| 1077 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceQueueWeakReferencesLock); |
| 1078 | DCHECK(reference_queue_weak_references_lock_ == nullptr); |
| 1079 | reference_queue_weak_references_lock_ = new Mutex("ReferenceQueue cleared references lock", current_lock_level); |
| 1080 | |
| 1081 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceQueueFinalizerReferencesLock); |
| 1082 | DCHECK(reference_queue_finalizer_references_lock_ == nullptr); |
| 1083 | reference_queue_finalizer_references_lock_ = new Mutex("ReferenceQueue finalizer references lock", current_lock_level); |
| 1084 | |
| 1085 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceQueuePhantomReferencesLock); |
| 1086 | DCHECK(reference_queue_phantom_references_lock_ == nullptr); |
| 1087 | reference_queue_phantom_references_lock_ = new Mutex("ReferenceQueue phantom references lock", current_lock_level); |
| 1088 | |
| 1089 | UPDATE_CURRENT_LOCK_LEVEL(kReferenceQueueSoftReferencesLock); |
| 1090 | DCHECK(reference_queue_soft_references_lock_ == nullptr); |
| 1091 | reference_queue_soft_references_lock_ = new Mutex("ReferenceQueue soft references lock", current_lock_level); |
| 1092 | |
Andreas Gampe | 05a364c | 2016-10-14 13:27:12 -0700 | [diff] [blame] | 1093 | UPDATE_CURRENT_LOCK_LEVEL(kJniGlobalsLock); |
| 1094 | DCHECK(jni_globals_lock_ == nullptr); |
| 1095 | jni_globals_lock_ = |
| 1096 | new ReaderWriterMutex("JNI global reference table lock", current_lock_level); |
| 1097 | |
| 1098 | UPDATE_CURRENT_LOCK_LEVEL(kJniWeakGlobalsLock); |
| 1099 | DCHECK(jni_weak_globals_lock_ == nullptr); |
| 1100 | jni_weak_globals_lock_ = new Mutex("JNI weak global reference table lock", current_lock_level); |
| 1101 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1102 | UPDATE_CURRENT_LOCK_LEVEL(kAbortLock); |
| 1103 | DCHECK(abort_lock_ == nullptr); |
| 1104 | abort_lock_ = new Mutex("abort lock", current_lock_level, true); |
| 1105 | |
| 1106 | UPDATE_CURRENT_LOCK_LEVEL(kThreadSuspendCountLock); |
| 1107 | DCHECK(thread_suspend_count_lock_ == nullptr); |
| 1108 | thread_suspend_count_lock_ = new Mutex("thread suspend count lock", current_lock_level); |
| 1109 | |
| 1110 | UPDATE_CURRENT_LOCK_LEVEL(kUnexpectedSignalLock); |
| 1111 | DCHECK(unexpected_signal_lock_ == nullptr); |
| 1112 | unexpected_signal_lock_ = new Mutex("unexpected signal lock", current_lock_level, true); |
| 1113 | |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 1114 | UPDATE_CURRENT_LOCK_LEVEL(kMemMapsLock); |
| 1115 | DCHECK(mem_maps_lock_ == nullptr); |
| 1116 | mem_maps_lock_ = new Mutex("mem maps lock", current_lock_level); |
| 1117 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 1118 | UPDATE_CURRENT_LOCK_LEVEL(kLoggingLock); |
| 1119 | DCHECK(logging_lock_ == nullptr); |
| 1120 | logging_lock_ = new Mutex("logging lock", current_lock_level, true); |
| 1121 | |
| 1122 | #undef UPDATE_CURRENT_LOCK_LEVEL |
Mathieu Chartier | 91e5669 | 2015-03-03 13:51:04 -0800 | [diff] [blame] | 1123 | |
| 1124 | InitConditions(); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 1125 | } |
| 1126 | } |
| 1127 | |
Mathieu Chartier | 91e5669 | 2015-03-03 13:51:04 -0800 | [diff] [blame] | 1128 | void Locks::InitConditions() { |
| 1129 | thread_exit_cond_ = new ConditionVariable("thread exit condition variable", *thread_list_lock_); |
| 1130 | } |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 1131 | |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 1132 | } // namespace art |