Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2013 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "verification_results.h" |
| 18 | |
Andreas Gampe | 5794381 | 2017-12-06 21:39:13 -0800 | [diff] [blame] | 19 | #include <android-base/logging.h> |
| 20 | |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 21 | #include "base/mutex-inl.h" |
Andreas Gampe | b486a98 | 2017-06-01 13:45:54 -0700 | [diff] [blame] | 22 | #include "base/stl_util.h" |
Brian Carlstrom | 6449c62 | 2014-02-10 23:48:36 -0800 | [diff] [blame] | 23 | #include "driver/compiler_driver.h" |
| 24 | #include "driver/compiler_options.h" |
Andreas Gampe | b486a98 | 2017-06-01 13:45:54 -0700 | [diff] [blame] | 25 | #include "runtime.h" |
Andreas Gampe | b486a98 | 2017-06-01 13:45:54 -0700 | [diff] [blame] | 26 | #include "thread-current-inl.h" |
Andreas Gampe | 8cf9cb3 | 2017-07-19 09:28:38 -0700 | [diff] [blame] | 27 | #include "thread.h" |
Mathieu Chartier | 93764b8 | 2017-07-17 14:51:53 -0700 | [diff] [blame] | 28 | #include "utils/atomic_dex_ref_map-inl.h" |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 29 | #include "verified_method.h" |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 30 | #include "verifier/method_verifier-inl.h" |
| 31 | |
| 32 | namespace art { |
| 33 | |
Brian Carlstrom | 6449c62 | 2014-02-10 23:48:36 -0800 | [diff] [blame] | 34 | VerificationResults::VerificationResults(const CompilerOptions* compiler_options) |
Ian Rogers | 1ff3c98 | 2014-08-12 02:30:58 -0700 | [diff] [blame] | 35 | : compiler_options_(compiler_options), |
| 36 | verified_methods_lock_("compiler verified methods lock"), |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 37 | rejected_classes_lock_("compiler rejected classes lock") {} |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 38 | |
| 39 | VerificationResults::~VerificationResults() { |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 40 | WriterMutexLock mu(Thread::Current(), verified_methods_lock_); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 41 | STLDeleteValues(&verified_methods_); |
Mathieu Chartier | 93764b8 | 2017-07-17 14:51:53 -0700 | [diff] [blame] | 42 | atomic_verified_methods_.Visit([](const DexFileReference& ref ATTRIBUTE_UNUSED, |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 43 | const VerifiedMethod* method) { |
| 44 | delete method; |
| 45 | }); |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 46 | } |
| 47 | |
Andreas Gampe | 53e32d1 | 2015-12-09 21:03:23 -0800 | [diff] [blame] | 48 | void VerificationResults::ProcessVerifiedMethod(verifier::MethodVerifier* method_verifier) { |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 49 | DCHECK(method_verifier != nullptr); |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 50 | MethodReference ref = method_verifier->GetMethodReference(); |
Nicolas Geoffray | c51c7ca | 2016-11-25 15:46:48 +0000 | [diff] [blame] | 51 | std::unique_ptr<const VerifiedMethod> verified_method(VerifiedMethod::Create(method_verifier)); |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 52 | if (verified_method == nullptr) { |
Andreas Gampe | 53e32d1 | 2015-12-09 21:03:23 -0800 | [diff] [blame] | 53 | // We'll punt this later. |
| 54 | return; |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 55 | } |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 56 | AtomicMap::InsertResult result = atomic_verified_methods_.Insert(ref, |
| 57 | /*expected*/ nullptr, |
| 58 | verified_method.get()); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 59 | const VerifiedMethod* existing = nullptr; |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 60 | bool inserted; |
| 61 | if (result != AtomicMap::kInsertResultInvalidDexFile) { |
| 62 | inserted = (result == AtomicMap::kInsertResultSuccess); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 63 | if (!inserted) { |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 64 | // Rare case. |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 65 | CHECK(atomic_verified_methods_.Get(ref, &existing)); |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 66 | CHECK_NE(verified_method.get(), existing); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 67 | } |
| 68 | } else { |
| 69 | WriterMutexLock mu(Thread::Current(), verified_methods_lock_); |
| 70 | auto it = verified_methods_.find(ref); |
| 71 | inserted = it == verified_methods_.end(); |
| 72 | if (inserted) { |
| 73 | verified_methods_.Put(ref, verified_method.get()); |
| 74 | DCHECK(verified_methods_.find(ref) != verified_methods_.end()); |
| 75 | } else { |
| 76 | existing = it->second; |
| 77 | } |
| 78 | } |
| 79 | if (inserted) { |
| 80 | // Successfully added, release the unique_ptr since we no longer have ownership. |
| 81 | DCHECK_EQ(GetVerifiedMethod(ref), verified_method.get()); |
| 82 | verified_method.release(); |
| 83 | } else { |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 84 | // TODO: Investigate why are we doing the work again for this method and try to avoid it. |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 85 | LOG(WARNING) << "Method processed more than once: " << ref.PrettyMethod(); |
Calin Juravle | ffc8707 | 2016-04-20 14:22:09 +0100 | [diff] [blame] | 86 | if (!Runtime::Current()->UseJitCompilation()) { |
Andreas Gampe | 26699c6 | 2017-05-12 08:19:28 -0700 | [diff] [blame] | 87 | if (kIsDebugBuild) { |
| 88 | auto ex_set = existing->GetSafeCastSet(); |
| 89 | auto ve_set = verified_method->GetSafeCastSet(); |
| 90 | CHECK_EQ(ex_set == nullptr, ve_set == nullptr); |
| 91 | CHECK((ex_set == nullptr) || (ex_set->size() == ve_set->size())); |
| 92 | } |
Mathieu Chartier | e5f13e5 | 2015-02-24 09:37:21 -0800 | [diff] [blame] | 93 | } |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 94 | // Let the unique_ptr delete the new verified method since there was already an existing one |
| 95 | // registered. It is unsafe to replace the existing one since the JIT may be using it to |
| 96 | // generate a native GC map. |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 97 | } |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 98 | } |
| 99 | |
| 100 | const VerifiedMethod* VerificationResults::GetVerifiedMethod(MethodReference ref) { |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 101 | const VerifiedMethod* ret = nullptr; |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 102 | if (atomic_verified_methods_.Get(ref, &ret)) { |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 103 | return ret; |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 104 | } |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 105 | ReaderMutexLock mu(Thread::Current(), verified_methods_lock_); |
| 106 | auto it = verified_methods_.find(ref); |
| 107 | return (it != verified_methods_.end()) ? it->second : nullptr; |
| 108 | } |
| 109 | |
Nicolas Geoffray | 51c17fa | 2016-11-25 15:56:12 +0000 | [diff] [blame] | 110 | void VerificationResults::CreateVerifiedMethodFor(MethodReference ref) { |
| 111 | // This method should only be called for classes verified at compile time, |
| 112 | // which have no verifier error, nor has methods that we know will throw |
| 113 | // at runtime. |
Andreas Gampe | f45d61c | 2017-06-07 10:29:33 -0700 | [diff] [blame] | 114 | std::unique_ptr<VerifiedMethod> verified_method = std::make_unique<VerifiedMethod>( |
| 115 | /* encountered_error_types */ 0, /* has_runtime_throw */ false); |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 116 | if (atomic_verified_methods_.Insert(ref, |
Mathieu Chartier | 93764b8 | 2017-07-17 14:51:53 -0700 | [diff] [blame] | 117 | /*expected*/ nullptr, |
| 118 | verified_method.get()) == |
Andreas Gampe | f45d61c | 2017-06-07 10:29:33 -0700 | [diff] [blame] | 119 | AtomicMap::InsertResult::kInsertResultSuccess) { |
| 120 | verified_method.release(); |
| 121 | } |
Nicolas Geoffray | 51c17fa | 2016-11-25 15:56:12 +0000 | [diff] [blame] | 122 | } |
| 123 | |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 124 | void VerificationResults::AddRejectedClass(ClassReference ref) { |
| 125 | { |
| 126 | WriterMutexLock mu(Thread::Current(), rejected_classes_lock_); |
| 127 | rejected_classes_.insert(ref); |
| 128 | } |
| 129 | DCHECK(IsClassRejected(ref)); |
| 130 | } |
| 131 | |
| 132 | bool VerificationResults::IsClassRejected(ClassReference ref) { |
| 133 | ReaderMutexLock mu(Thread::Current(), rejected_classes_lock_); |
| 134 | return (rejected_classes_.find(ref) != rejected_classes_.end()); |
| 135 | } |
| 136 | |
Elliott Hughes | 956af0f | 2014-12-11 14:34:28 -0800 | [diff] [blame] | 137 | bool VerificationResults::IsCandidateForCompilation(MethodReference&, |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 138 | const uint32_t access_flags) { |
Nicolas Geoffray | 49cda06 | 2017-04-21 13:08:25 +0100 | [diff] [blame] | 139 | if (!compiler_options_->IsAotCompilationEnabled()) { |
Ian Rogers | 1ff3c98 | 2014-08-12 02:30:58 -0700 | [diff] [blame] | 140 | return false; |
| 141 | } |
buzbee | c833299 | 2015-06-25 15:53:45 -0700 | [diff] [blame] | 142 | // Don't compile class initializers unless kEverything. |
Andreas Gampe | 29d38e7 | 2016-03-23 15:31:51 +0000 | [diff] [blame] | 143 | if ((compiler_options_->GetCompilerFilter() != CompilerFilter::kEverything) && |
buzbee | c833299 | 2015-06-25 15:53:45 -0700 | [diff] [blame] | 144 | ((access_flags & kAccConstructor) != 0) && ((access_flags & kAccStatic) != 0)) { |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 145 | return false; |
| 146 | } |
Dave Allison | 39c3bfb | 2014-01-28 18:33:52 -0800 | [diff] [blame] | 147 | return true; |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 148 | } |
| 149 | |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 150 | void VerificationResults::AddDexFile(const DexFile* dex_file) { |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 151 | atomic_verified_methods_.AddDexFile(dex_file); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 152 | WriterMutexLock mu(Thread::Current(), verified_methods_lock_); |
| 153 | // There can be some verified methods that are already registered for the dex_file since we set |
| 154 | // up well known classes earlier. Remove these and put them in the array so that we don't |
| 155 | // accidentally miss seeing them. |
| 156 | for (auto it = verified_methods_.begin(); it != verified_methods_.end(); ) { |
| 157 | MethodReference ref = it->first; |
| 158 | if (ref.dex_file == dex_file) { |
Mathieu Chartier | fc8b422 | 2017-09-17 13:44:24 -0700 | [diff] [blame] | 159 | CHECK(atomic_verified_methods_.Insert(ref, nullptr, it->second) == |
Mathieu Chartier | 9df8931 | 2016-11-23 13:28:16 -0800 | [diff] [blame] | 160 | AtomicMap::kInsertResultSuccess); |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 161 | it = verified_methods_.erase(it); |
| 162 | } else { |
| 163 | ++it; |
| 164 | } |
| 165 | } |
Mathieu Chartier | fc2dd61 | 2016-11-21 15:05:23 -0800 | [diff] [blame] | 166 | } |
| 167 | |
Vladimir Marko | c7f8320 | 2014-01-24 17:55:18 +0000 | [diff] [blame] | 168 | } // namespace art |