blob: 78a23fb72db3fbb1ec91315f881a8dd80a69be03 [file] [log] [blame]
Jiyong Parkae556382020-05-20 18:33:43 +09001#!/usr/bin/env python3
Joe Onorato9197a482011-06-08 16:04:14 -07002#
3# Copyright (C) 2009 The Android Open Source Project
4#
5# Licensed under the Apache License, Version 2.0 (the "License");
6# you may not use this file except in compliance with the License.
7# You may obtain a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS,
13# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14# See the License for the specific language governing permissions and
15# limitations under the License.
16
Jiyong Park0b4fccb2020-06-26 17:38:00 +090017import argparse
Joe Onorato9197a482011-06-08 16:04:14 -070018import sys
19
Jiyong Parkd721e872020-06-22 17:30:57 +090020# Usage: post_process_props.py file.prop [disallowed_key, ...]
21# Disallowed keys are removed from the property file, if present
Jeff Sharkey26d22f72014-03-18 17:20:10 -070022
Elliott Hughes05c1a2a2017-02-28 10:04:23 -080023# See PROP_VALUE_MAX in system_properties.h.
24# The constant in system_properties.h includes the terminating NUL,
25# so we decrease the value by 1 here.
Ying Wang35123212014-02-11 20:44:09 -080026PROP_VALUE_MAX = 91
27
Jiyong Parkae556382020-05-20 18:33:43 +090028# Put the modifications that you need to make into the */build.prop into this
29# function.
30def mangle_build_prop(prop_list):
Jerry Zhang16956532016-10-18 00:01:27 +000031 # If ro.debuggable is 1, then enable adb on USB by default
32 # (this is for userdebug builds)
Jiyong Parkd721e872020-06-22 17:30:57 +090033 if prop_list.get_value("ro.debuggable") == "1":
34 val = prop_list.get_value("persist.sys.usb.config")
Jerry Zhang16956532016-10-18 00:01:27 +000035 if "adb" not in val:
36 if val == "":
37 val = "adb"
38 else:
39 val = val + ",adb"
Jiyong Parkae556382020-05-20 18:33:43 +090040 prop_list.put("persist.sys.usb.config", val)
Joe Onorato8ad4bb12012-05-02 14:36:57 -070041 # UsbDeviceManager expects a value here. If it doesn't get it, it will
42 # default to "adb". That might not the right policy there, but it's better
43 # to be explicit.
Jiyong Parkd721e872020-06-22 17:30:57 +090044 if not prop_list.get_value("persist.sys.usb.config"):
Jiyong Parkae556382020-05-20 18:33:43 +090045 prop_list.put("persist.sys.usb.config", "none");
Joe Onorato9197a482011-06-08 16:04:14 -070046
Jiyong Parkae556382020-05-20 18:33:43 +090047def validate(prop_list):
Ying Wang35123212014-02-11 20:44:09 -080048 """Validate the properties.
49
Jiyong Parkd721e872020-06-22 17:30:57 +090050 If the value of a sysprop exceeds the max limit (91), it's an error, unless
51 the sysprop is a read-only one.
52
53 Checks if there is no optional prop assignments.
54
Ying Wang35123212014-02-11 20:44:09 -080055 Returns:
56 True if nothing is wrong.
57 """
58 check_pass = True
Jiyong Parkd721e872020-06-22 17:30:57 +090059 for p in prop_list.get_all_props():
Jiyong Parkae556382020-05-20 18:33:43 +090060 if len(p.value) > PROP_VALUE_MAX and not p.name.startswith("ro."):
Ying Wang38df1012015-02-04 15:10:59 -080061 check_pass = False
62 sys.stderr.write("error: %s cannot exceed %d bytes: " %
Jiyong Parkae556382020-05-20 18:33:43 +090063 (p.name, PROP_VALUE_MAX))
64 sys.stderr.write("%s (%d)\n" % (p.value, len(p.value)))
Jiyong Parkd721e872020-06-22 17:30:57 +090065
66 if p.is_optional():
67 check_pass = False
68 sys.stderr.write("error: found unresolved optional prop assignment:\n")
69 sys.stderr.write(str(p) + "\n")
70
Ying Wang35123212014-02-11 20:44:09 -080071 return check_pass
72
Jiyong Park0b4fccb2020-06-26 17:38:00 +090073def override_optional_props(prop_list, allow_dup=False):
Jiyong Parkd721e872020-06-22 17:30:57 +090074 """Override a?=b with a=c, if the latter exists
75
76 Overriding is done by deleting a?=b
77 When there are a?=b and a?=c, then only the last one survives
78 When there are a=b and a=c, then it's an error.
79
80 Returns:
81 True if the override was successful
82 """
83 success = True
84 for name in prop_list.get_all_names():
85 props = prop_list.get_props(name)
86 optional_props = [p for p in props if p.is_optional()]
87 overriding_props = [p for p in props if not p.is_optional()]
88 if len(overriding_props) > 1:
89 # duplicated props are allowed when the all have the same value
90 if all(overriding_props[0].value == p.value for p in overriding_props):
91 continue
Jiyong Park0b4fccb2020-06-26 17:38:00 +090092 # or if dup is explicitly allowed for compat reason
93 if allow_dup:
94 # this could left one or more optional props unresolved.
95 # Convert them into non-optional because init doesn't understand ?=
96 # syntax
97 for p in optional_props:
98 p.optional = False
99 continue
100
Jiyong Parkd721e872020-06-22 17:30:57 +0900101 success = False
102 sys.stderr.write("error: found duplicate sysprop assignments:\n")
103 for p in overriding_props:
104 sys.stderr.write("%s\n" % str(p))
105 elif len(overriding_props) == 1:
106 for p in optional_props:
107 p.delete("overridden by %s" % str(overriding_props[0]))
108 else:
109 if len(optional_props) > 1:
110 for p in optional_props[:-1]:
111 p.delete("overridden by %s" % str(optional_props[-1]))
112 # Make the last optional one as non-optional
113 optional_props[-1].optional = False
114
115 return success
116
Jiyong Parkae556382020-05-20 18:33:43 +0900117class Prop:
Yu Liu115c66b2014-02-10 19:20:36 -0800118
Jiyong Parkd721e872020-06-22 17:30:57 +0900119 def __init__(self, name, value, optional=False, comment=None):
Jiyong Parkae556382020-05-20 18:33:43 +0900120 self.name = name.strip()
121 self.value = value.strip()
Jiyong Parkd721e872020-06-22 17:30:57 +0900122 if comment != None:
123 self.comments = [comment]
124 else:
125 self.comments = []
126 self.optional = optional
Ying Wang35123212014-02-11 20:44:09 -0800127
Jiyong Parkae556382020-05-20 18:33:43 +0900128 @staticmethod
129 def from_line(line):
130 line = line.rstrip('\n')
131 if line.startswith("#"):
Jiyong Parkd721e872020-06-22 17:30:57 +0900132 return Prop("", "", comment=line)
133 elif "?=" in line:
134 name, value = line.split("?=", 1)
135 return Prop(name, value, optional=True)
Jiyong Parkae556382020-05-20 18:33:43 +0900136 elif "=" in line:
137 name, value = line.split("=", 1)
Jiyong Parkd721e872020-06-22 17:30:57 +0900138 return Prop(name, value, optional=False)
Jiyong Parkae556382020-05-20 18:33:43 +0900139 else:
140 # don't fail on invalid line
141 # TODO(jiyong) make this a hard error
Jiyong Parkd721e872020-06-22 17:30:57 +0900142 return Prop("", "", comment=line)
Jiyong Parkae556382020-05-20 18:33:43 +0900143
144 def is_comment(self):
Jiyong Parkd721e872020-06-22 17:30:57 +0900145 return bool(self.comments and not self.name)
146
147 def is_optional(self):
148 return (not self.is_comment()) and self.optional
149
150 def make_as_comment(self):
151 # Prepend "#" to the last line which is the prop assignment
152 if not self.is_comment():
153 assignment = str(self).rsplit("\n", 1)[-1]
154 self.comments.append("#" + assignment)
155 self.name = ""
156 self.value = ""
157
158 def delete(self, reason):
159 self.comments.append("# Removed by post_process_props.py because " + reason)
160 self.make_as_comment()
Jiyong Parkae556382020-05-20 18:33:43 +0900161
162 def __str__(self):
Jiyong Parkd721e872020-06-22 17:30:57 +0900163 assignment = []
164 if not self.is_comment():
165 operator = "?=" if self.is_optional() else "="
166 assignment.append(self.name + operator + self.value)
167 return "\n".join(self.comments + assignment)
Jiyong Parkae556382020-05-20 18:33:43 +0900168
169class PropList:
170
171 def __init__(self, filename):
172 with open(filename) as f:
173 self.props = [Prop.from_line(l)
174 for l in f.readlines() if l.strip() != ""]
175
Jiyong Parkd721e872020-06-22 17:30:57 +0900176 def get_all_props(self):
Jiyong Parkae556382020-05-20 18:33:43 +0900177 return [p for p in self.props if not p.is_comment()]
Joe Onorato9197a482011-06-08 16:04:14 -0700178
Jiyong Parkd721e872020-06-22 17:30:57 +0900179 def get_all_names(self):
180 return set([p.name for p in self.get_all_props()])
181
182 def get_props(self, name):
183 return [p for p in self.get_all_props() if p.name == name]
184
185 def get_value(self, name):
186 # Caution: only the value of the first sysprop having the name is returned.
Jiyong Parkae556382020-05-20 18:33:43 +0900187 return next((p.value for p in self.props if p.name == name), "")
Joe Onorato9197a482011-06-08 16:04:14 -0700188
189 def put(self, name, value):
Jiyong Parkd721e872020-06-22 17:30:57 +0900190 # Note: when there is an optional prop for the name, its value isn't changed.
191 # Instead a new non-optional prop is appended, which will override the
192 # optional prop. Otherwise, the new value might be overridden by an existing
193 # non-optional prop of the same name.
194 index = next((i for i,p in enumerate(self.props)
195 if p.name == name and not p.is_optional()), -1)
Jiyong Parkae556382020-05-20 18:33:43 +0900196 if index == -1:
Jiyong Parkd721e872020-06-22 17:30:57 +0900197 self.props.append(Prop(name, value,
198 comment="# Auto-added by post_process_props.py"))
Jiyong Parkae556382020-05-20 18:33:43 +0900199 else:
Jiyong Parkd721e872020-06-22 17:30:57 +0900200 self.props[index].comments.append(
201 "# Value overridden by post_process_props.py. Original value: %s" %
202 self.props[index].value)
Jiyong Parkae556382020-05-20 18:33:43 +0900203 self.props[index].value = value
Joe Onorato9197a482011-06-08 16:04:14 -0700204
Jiyong Parkae556382020-05-20 18:33:43 +0900205 def write(self, filename):
206 with open(filename, 'w+') as f:
207 for p in self.props:
208 f.write(str(p) + "\n")
Joe Onorato9197a482011-06-08 16:04:14 -0700209
210def main(argv):
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900211 parser = argparse.ArgumentParser(description="Post-process build.prop file")
212 parser.add_argument("--allow-dup", dest="allow_dup", action="store_true",
213 default=False)
214 parser.add_argument("filename")
215 parser.add_argument("disallowed_keys", metavar="KEY", type=str, nargs="*")
216 args = parser.parse_args()
Joe Onorato9197a482011-06-08 16:04:14 -0700217
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900218 if not args.filename.endswith("/build.prop"):
Joe Onorato9197a482011-06-08 16:04:14 -0700219 sys.stderr.write("bad command line: " + str(argv) + "\n")
220 sys.exit(1)
221
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900222 props = PropList(args.filename)
Jiyong Parkae556382020-05-20 18:33:43 +0900223 mangle_build_prop(props)
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900224 if not override_optional_props(props, args.allow_dup):
Jiyong Parkd721e872020-06-22 17:30:57 +0900225 sys.exit(1)
Jiyong Parkae556382020-05-20 18:33:43 +0900226 if not validate(props):
Ying Wang35123212014-02-11 20:44:09 -0800227 sys.exit(1)
228
Jiyong Parkd721e872020-06-22 17:30:57 +0900229 # Drop any disallowed keys
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900230 for key in args.disallowed_keys:
Jiyong Parkd721e872020-06-22 17:30:57 +0900231 for p in props.get_props(key):
232 p.delete("%s is a disallowed key" % key)
Jeff Sharkey26d22f72014-03-18 17:20:10 -0700233
Jiyong Park0b4fccb2020-06-26 17:38:00 +0900234 props.write(args.filename)
Joe Onorato9197a482011-06-08 16:04:14 -0700235
236if __name__ == "__main__":
237 main(sys.argv)