Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package android |
| 16 | |
| 17 | import ( |
Colin Cross | 41955e8 | 2019-05-29 14:40:35 -0700 | [diff] [blame] | 18 | "fmt" |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 19 | "testing" |
| 20 | |
| 21 | "github.com/google/blueprint" |
| 22 | ) |
| 23 | |
| 24 | var prebuiltsTests = []struct { |
| 25 | name string |
| 26 | modules string |
| 27 | prebuilt bool |
| 28 | }{ |
| 29 | { |
| 30 | name: "no prebuilt", |
| 31 | modules: ` |
| 32 | source { |
| 33 | name: "bar", |
| 34 | }`, |
| 35 | prebuilt: false, |
| 36 | }, |
| 37 | { |
| 38 | name: "no source prebuilt not preferred", |
| 39 | modules: ` |
| 40 | prebuilt { |
| 41 | name: "bar", |
| 42 | prefer: false, |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 43 | srcs: ["prebuilt_file"], |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 44 | }`, |
| 45 | prebuilt: true, |
| 46 | }, |
| 47 | { |
| 48 | name: "no source prebuilt preferred", |
| 49 | modules: ` |
| 50 | prebuilt { |
| 51 | name: "bar", |
| 52 | prefer: true, |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 53 | srcs: ["prebuilt_file"], |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 54 | }`, |
| 55 | prebuilt: true, |
| 56 | }, |
| 57 | { |
| 58 | name: "prebuilt not preferred", |
| 59 | modules: ` |
| 60 | source { |
| 61 | name: "bar", |
| 62 | } |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 63 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 64 | prebuilt { |
| 65 | name: "bar", |
| 66 | prefer: false, |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 67 | srcs: ["prebuilt_file"], |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 68 | }`, |
| 69 | prebuilt: false, |
| 70 | }, |
| 71 | { |
| 72 | name: "prebuilt preferred", |
| 73 | modules: ` |
| 74 | source { |
| 75 | name: "bar", |
| 76 | } |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 77 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 78 | prebuilt { |
| 79 | name: "bar", |
| 80 | prefer: true, |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 81 | srcs: ["prebuilt_file"], |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 82 | }`, |
| 83 | prebuilt: true, |
| 84 | }, |
Colin Cross | 0d614dd | 2016-10-14 15:38:43 -0700 | [diff] [blame] | 85 | { |
| 86 | name: "prebuilt no file not preferred", |
| 87 | modules: ` |
| 88 | source { |
| 89 | name: "bar", |
| 90 | } |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 91 | |
Colin Cross | 0d614dd | 2016-10-14 15:38:43 -0700 | [diff] [blame] | 92 | prebuilt { |
| 93 | name: "bar", |
| 94 | prefer: false, |
| 95 | }`, |
| 96 | prebuilt: false, |
| 97 | }, |
| 98 | { |
| 99 | name: "prebuilt no file preferred", |
| 100 | modules: ` |
| 101 | source { |
| 102 | name: "bar", |
| 103 | } |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 104 | |
Colin Cross | 0d614dd | 2016-10-14 15:38:43 -0700 | [diff] [blame] | 105 | prebuilt { |
| 106 | name: "bar", |
| 107 | prefer: true, |
| 108 | }`, |
| 109 | prebuilt: false, |
| 110 | }, |
Pirama Arumuga Nainar | 955dc49 | 2018-04-17 14:58:42 -0700 | [diff] [blame] | 111 | { |
| 112 | name: "prebuilt file from filegroup preferred", |
| 113 | modules: ` |
| 114 | filegroup { |
| 115 | name: "fg", |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 116 | srcs: ["prebuilt_file"], |
Pirama Arumuga Nainar | 955dc49 | 2018-04-17 14:58:42 -0700 | [diff] [blame] | 117 | } |
| 118 | prebuilt { |
| 119 | name: "bar", |
| 120 | prefer: true, |
| 121 | srcs: [":fg"], |
| 122 | }`, |
| 123 | prebuilt: true, |
| 124 | }, |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 125 | { |
| 126 | name: "prebuilt override not preferred", |
| 127 | modules: ` |
| 128 | source { |
| 129 | name: "baz", |
| 130 | } |
| 131 | |
| 132 | override_source { |
| 133 | name: "bar", |
| 134 | base: "baz", |
| 135 | } |
| 136 | |
| 137 | prebuilt { |
| 138 | name: "bar", |
| 139 | prefer: false, |
| 140 | srcs: ["prebuilt_file"], |
| 141 | }`, |
| 142 | prebuilt: false, |
| 143 | }, |
| 144 | { |
| 145 | name: "prebuilt override preferred", |
| 146 | modules: ` |
| 147 | source { |
| 148 | name: "baz", |
| 149 | } |
| 150 | |
| 151 | override_source { |
| 152 | name: "bar", |
| 153 | base: "baz", |
| 154 | } |
| 155 | |
| 156 | prebuilt { |
| 157 | name: "bar", |
| 158 | prefer: true, |
| 159 | srcs: ["prebuilt_file"], |
| 160 | }`, |
| 161 | prebuilt: true, |
| 162 | }, |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 163 | } |
| 164 | |
| 165 | func TestPrebuilts(t *testing.T) { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 166 | fs := map[string][]byte{ |
| 167 | "prebuilt_file": nil, |
| 168 | "source_file": nil, |
| 169 | } |
Colin Cross | 0d614dd | 2016-10-14 15:38:43 -0700 | [diff] [blame] | 170 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 171 | for _, test := range prebuiltsTests { |
| 172 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 173 | bp := ` |
| 174 | source { |
| 175 | name: "foo", |
| 176 | deps: [":bar"], |
| 177 | } |
| 178 | ` + test.modules |
| 179 | config := TestConfig(buildDir, nil, bp, fs) |
| 180 | |
Colin Cross | cec8171 | 2017-07-13 14:43:27 -0700 | [diff] [blame] | 181 | ctx := NewTestContext() |
Paul Duffin | 78ac5b9 | 2020-01-14 12:42:08 +0000 | [diff] [blame] | 182 | registerTestPrebuiltBuildComponents(ctx) |
Colin Cross | 4b49b76 | 2019-11-22 15:25:03 -0800 | [diff] [blame] | 183 | ctx.RegisterModuleType("filegroup", FileGroupFactory) |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 184 | ctx.Register(config) |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 185 | |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 186 | _, errs := ctx.ParseBlueprintsFiles("Android.bp") |
Logan Chien | 4203971 | 2018-03-12 16:29:17 +0800 | [diff] [blame] | 187 | FailIfErrored(t, errs) |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 188 | _, errs = ctx.PrepareBuildActions(config) |
Logan Chien | 4203971 | 2018-03-12 16:29:17 +0800 | [diff] [blame] | 189 | FailIfErrored(t, errs) |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 190 | |
Colin Cross | cec8171 | 2017-07-13 14:43:27 -0700 | [diff] [blame] | 191 | foo := ctx.ModuleForTests("foo", "") |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 192 | |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 193 | var dependsOnSourceModule, dependsOnPrebuiltModule bool |
Colin Cross | cec8171 | 2017-07-13 14:43:27 -0700 | [diff] [blame] | 194 | ctx.VisitDirectDeps(foo.Module(), func(m blueprint.Module) { |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 195 | if _, ok := m.(*sourceModule); ok { |
| 196 | dependsOnSourceModule = true |
| 197 | } |
| 198 | if p, ok := m.(*prebuiltModule); ok { |
| 199 | dependsOnPrebuiltModule = true |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 200 | if !p.Prebuilt().properties.UsePrebuilt { |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 201 | t.Errorf("dependency on prebuilt module not marked used") |
| 202 | } |
| 203 | } |
| 204 | }) |
| 205 | |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 206 | deps := foo.Module().(*sourceModule).deps |
| 207 | if deps == nil || len(deps) != 1 { |
| 208 | t.Errorf("deps does not have single path, but is %v", deps) |
| 209 | } |
| 210 | var usingSourceFile, usingPrebuiltFile bool |
| 211 | if deps[0].String() == "source_file" { |
| 212 | usingSourceFile = true |
| 213 | } |
| 214 | if deps[0].String() == "prebuilt_file" { |
| 215 | usingPrebuiltFile = true |
| 216 | } |
| 217 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 218 | if test.prebuilt { |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 219 | if !dependsOnPrebuiltModule { |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 220 | t.Errorf("doesn't depend on prebuilt module") |
| 221 | } |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 222 | if !usingPrebuiltFile { |
| 223 | t.Errorf("doesn't use prebuilt_file") |
| 224 | } |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 225 | |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 226 | if dependsOnSourceModule { |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 227 | t.Errorf("depends on source module") |
| 228 | } |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 229 | if usingSourceFile { |
| 230 | t.Errorf("using source_file") |
| 231 | } |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 232 | } else { |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 233 | if dependsOnPrebuiltModule { |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 234 | t.Errorf("depends on prebuilt module") |
| 235 | } |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 236 | if usingPrebuiltFile { |
| 237 | t.Errorf("using prebuilt_file") |
| 238 | } |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 239 | |
Colin Cross | c3e7fa6 | 2017-03-17 13:14:32 -0700 | [diff] [blame] | 240 | if !dependsOnSourceModule { |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 241 | t.Errorf("doesn't depend on source module") |
| 242 | } |
| 243 | if !usingSourceFile { |
| 244 | t.Errorf("doesn't use source_file") |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 245 | } |
| 246 | } |
| 247 | }) |
| 248 | } |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 249 | } |
| 250 | |
Paul Duffin | 78ac5b9 | 2020-01-14 12:42:08 +0000 | [diff] [blame] | 251 | func registerTestPrebuiltBuildComponents(ctx RegistrationContext) { |
| 252 | ctx.RegisterModuleType("prebuilt", newPrebuiltModule) |
| 253 | ctx.RegisterModuleType("source", newSourceModule) |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 254 | ctx.RegisterModuleType("override_source", newOverrideSourceModule) |
Paul Duffin | 78ac5b9 | 2020-01-14 12:42:08 +0000 | [diff] [blame] | 255 | |
| 256 | RegisterPrebuiltMutators(ctx) |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 257 | ctx.PostDepsMutators(RegisterOverridePostDepsMutators) |
Paul Duffin | 78ac5b9 | 2020-01-14 12:42:08 +0000 | [diff] [blame] | 258 | } |
| 259 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 260 | type prebuiltModule struct { |
| 261 | ModuleBase |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 262 | prebuilt Prebuilt |
| 263 | properties struct { |
Colin Cross | 27b922f | 2019-03-04 22:35:41 -0800 | [diff] [blame] | 264 | Srcs []string `android:"path"` |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 265 | } |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 266 | src Path |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 267 | } |
| 268 | |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 269 | func newPrebuiltModule() Module { |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 270 | m := &prebuiltModule{} |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 271 | m.AddProperties(&m.properties) |
| 272 | InitPrebuiltModule(m, &m.properties.Srcs) |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 273 | InitAndroidModule(m) |
| 274 | return m |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 275 | } |
| 276 | |
| 277 | func (p *prebuiltModule) Name() string { |
| 278 | return p.prebuilt.Name(p.ModuleBase.Name()) |
| 279 | } |
| 280 | |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 281 | func (p *prebuiltModule) GenerateAndroidBuildActions(ctx ModuleContext) { |
| 282 | if len(p.properties.Srcs) >= 1 { |
| 283 | p.src = p.prebuilt.SingleSourcePath(ctx) |
| 284 | } |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 285 | } |
| 286 | |
| 287 | func (p *prebuiltModule) Prebuilt() *Prebuilt { |
| 288 | return &p.prebuilt |
| 289 | } |
| 290 | |
Colin Cross | 41955e8 | 2019-05-29 14:40:35 -0700 | [diff] [blame] | 291 | func (p *prebuiltModule) OutputFiles(tag string) (Paths, error) { |
| 292 | switch tag { |
| 293 | case "": |
| 294 | return Paths{p.src}, nil |
| 295 | default: |
| 296 | return nil, fmt.Errorf("unsupported module reference tag %q", tag) |
| 297 | } |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 298 | } |
| 299 | |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 300 | type sourceModuleProperties struct { |
| 301 | Deps []string `android:"path"` |
| 302 | } |
| 303 | |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 304 | type sourceModule struct { |
| 305 | ModuleBase |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 306 | OverridableModuleBase |
| 307 | |
| 308 | properties sourceModuleProperties |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 309 | dependsOnSourceModule, dependsOnPrebuiltModule bool |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 310 | deps Paths |
| 311 | src Path |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 312 | } |
| 313 | |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 314 | func newSourceModule() Module { |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 315 | m := &sourceModule{} |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 316 | m.AddProperties(&m.properties) |
| 317 | InitAndroidModule(m) |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 318 | InitOverridableModule(m, nil) |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 319 | return m |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 320 | } |
| 321 | |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 322 | func (s *sourceModule) OverridablePropertiesDepsMutator(ctx BottomUpMutatorContext) { |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 323 | // s.properties.Deps are annotated with android:path, so they are |
| 324 | // automatically added to the dependency by pathDeps mutator |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 325 | } |
| 326 | |
| 327 | func (s *sourceModule) GenerateAndroidBuildActions(ctx ModuleContext) { |
Jiyong Park | d467111 | 2019-04-19 17:23:04 +0900 | [diff] [blame] | 328 | s.deps = PathsForModuleSrc(ctx, s.properties.Deps) |
| 329 | s.src = PathForModuleSrc(ctx, "source_file") |
| 330 | } |
| 331 | |
| 332 | func (s *sourceModule) Srcs() Paths { |
| 333 | return Paths{s.src} |
Colin Cross | ce75d2c | 2016-10-06 16:12:58 -0700 | [diff] [blame] | 334 | } |
Jaewoong Jung | e50fe61 | 2020-06-11 10:37:51 -0700 | [diff] [blame^] | 335 | |
| 336 | type overrideSourceModule struct { |
| 337 | ModuleBase |
| 338 | OverrideModuleBase |
| 339 | } |
| 340 | |
| 341 | func (o *overrideSourceModule) GenerateAndroidBuildActions(_ ModuleContext) { |
| 342 | } |
| 343 | |
| 344 | func newOverrideSourceModule() Module { |
| 345 | m := &overrideSourceModule{} |
| 346 | m.AddProperties(&sourceModuleProperties{}) |
| 347 | |
| 348 | InitAndroidModule(m) |
| 349 | InitOverrideModule(m) |
| 350 | return m |
| 351 | } |