Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 1 | //===- BranchFolding.cpp - Fold machine code branch instructions ----------===// |
Misha Brukman | edf128a | 2005-04-21 22:36:52 +0000 | [diff] [blame] | 2 | // |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 4ee451d | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Misha Brukman | edf128a | 2005-04-21 22:36:52 +0000 | [diff] [blame] | 7 | // |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This pass forwards branches to unconditional branches to make them branch |
| 11 | // directly to the target block. This pass often results in dead MBB's, which |
| 12 | // it then removes. |
| 13 | // |
| 14 | // Note that this pass must be run after register allocation, it cannot handle |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 15 | // SSA form. It also must handle virtual registers for targets that emit virtual |
| 16 | // ISA (e.g. NVPTX). |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 17 | // |
| 18 | //===----------------------------------------------------------------------===// |
| 19 | |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 20 | #include "BranchFolding.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 21 | #include "llvm/ADT/BitVector.h" |
Eugene Zelenko | 887aef7 | 2017-10-10 22:33:29 +0000 | [diff] [blame] | 22 | #include "llvm/ADT/DenseMap.h" |
| 23 | #include "llvm/ADT/STLExtras.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 24 | #include "llvm/ADT/SmallPtrSet.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 25 | #include "llvm/ADT/SmallSet.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/SmallVector.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/Statistic.h" |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 28 | #include "llvm/CodeGen/Analysis.h" |
Eugene Zelenko | 887aef7 | 2017-10-10 22:33:29 +0000 | [diff] [blame] | 29 | #include "llvm/CodeGen/LivePhysRegs.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 30 | #include "llvm/CodeGen/MachineBasicBlock.h" |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 31 | #include "llvm/CodeGen/MachineBlockFrequencyInfo.h" |
| 32 | #include "llvm/CodeGen/MachineBranchProbabilityInfo.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 33 | #include "llvm/CodeGen/MachineFunction.h" |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 34 | #include "llvm/CodeGen/MachineFunctionPass.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 35 | #include "llvm/CodeGen/MachineInstr.h" |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 36 | #include "llvm/CodeGen/MachineInstrBuilder.h" |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 37 | #include "llvm/CodeGen/MachineJumpTableInfo.h" |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 38 | #include "llvm/CodeGen/MachineLoopInfo.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 39 | #include "llvm/CodeGen/MachineModuleInfo.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 40 | #include "llvm/CodeGen/MachineOperand.h" |
Jakob Stoklund Olesen | 80799fb | 2012-03-27 17:06:09 +0000 | [diff] [blame] | 41 | #include "llvm/CodeGen/MachineRegisterInfo.h" |
David Blaikie | 4831923 | 2017-11-08 01:01:31 +0000 | [diff] [blame] | 42 | #include "llvm/CodeGen/TargetInstrInfo.h" |
David Blaikie | e3a9b4c | 2017-11-17 01:07:10 +0000 | [diff] [blame] | 43 | #include "llvm/CodeGen/TargetOpcodes.h" |
Matthias Braun | 6a6190d | 2016-05-10 03:21:59 +0000 | [diff] [blame] | 44 | #include "llvm/CodeGen/TargetPassConfig.h" |
David Blaikie | e3a9b4c | 2017-11-17 01:07:10 +0000 | [diff] [blame] | 45 | #include "llvm/CodeGen/TargetRegisterInfo.h" |
| 46 | #include "llvm/CodeGen/TargetSubtargetInfo.h" |
Taewook Oh | 5c08882 | 2017-03-15 05:44:59 +0000 | [diff] [blame] | 47 | #include "llvm/IR/DebugInfoMetadata.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 48 | #include "llvm/IR/DebugLoc.h" |
Chandler Carruth | 0b8c9a8 | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 49 | #include "llvm/IR/Function.h" |
Eugene Zelenko | 887aef7 | 2017-10-10 22:33:29 +0000 | [diff] [blame] | 50 | #include "llvm/MC/LaneBitmask.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 51 | #include "llvm/MC/MCRegisterInfo.h" |
| 52 | #include "llvm/Pass.h" |
| 53 | #include "llvm/Support/BlockFrequency.h" |
| 54 | #include "llvm/Support/BranchProbability.h" |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 55 | #include "llvm/Support/CommandLine.h" |
Chris Lattner | f10a56a | 2006-11-18 21:56:39 +0000 | [diff] [blame] | 56 | #include "llvm/Support/Debug.h" |
Torok Edwin | c25e758 | 2009-07-11 20:10:48 +0000 | [diff] [blame] | 57 | #include "llvm/Support/ErrorHandling.h" |
Bill Wendling | 3403bcd | 2009-08-22 20:03:00 +0000 | [diff] [blame] | 58 | #include "llvm/Support/raw_ostream.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 59 | #include "llvm/Target/TargetMachine.h" |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 60 | #include <cassert> |
| 61 | #include <cstddef> |
| 62 | #include <iterator> |
| 63 | #include <numeric> |
| 64 | #include <vector> |
| 65 | |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 66 | using namespace llvm; |
| 67 | |
Matthias Braun | 94c4904 | 2017-05-25 21:26:32 +0000 | [diff] [blame] | 68 | #define DEBUG_TYPE "branch-folder" |
Chandler Carruth | 8677f2f | 2014-04-22 02:02:50 +0000 | [diff] [blame] | 69 | |
Chris Lattner | cd3245a | 2006-12-19 22:41:21 +0000 | [diff] [blame] | 70 | STATISTIC(NumDeadBlocks, "Number of dead blocks removed"); |
| 71 | STATISTIC(NumBranchOpts, "Number of branches optimized"); |
| 72 | STATISTIC(NumTailMerge , "Number of block tails merged"); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 73 | STATISTIC(NumHoist , "Number of times common instructions are hoisted"); |
Hans Wennborg | b6ae6ad | 2017-02-16 00:04:05 +0000 | [diff] [blame] | 74 | STATISTIC(NumTailCalls, "Number of tail calls optimized"); |
Bob Wilson | 7cd5d3e | 2009-11-18 19:29:37 +0000 | [diff] [blame] | 75 | |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 76 | static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge", |
Dale Johannesen | 81da02b | 2007-05-22 17:14:46 +0000 | [diff] [blame] | 77 | cl::init(cl::BOU_UNSET), cl::Hidden); |
Bob Wilson | 7cd5d3e | 2009-11-18 19:29:37 +0000 | [diff] [blame] | 78 | |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 79 | // Throttle for huge numbers of predecessors (compile speed problems) |
| 80 | static cl::opt<unsigned> |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 81 | TailMergeThreshold("tail-merge-threshold", |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 82 | cl::desc("Max number of predecessors to consider tail merging"), |
Dale Johannesen | 622addb | 2008-10-27 02:10:21 +0000 | [diff] [blame] | 83 | cl::init(150), cl::Hidden); |
Dale Johannesen | 1a90a5a | 2007-06-08 01:08:52 +0000 | [diff] [blame] | 84 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 85 | // Heuristic for tail merging (and, inversely, tail duplication). |
| 86 | // TODO: This should be replaced with a target query. |
| 87 | static cl::opt<unsigned> |
Bob Wilson | 3cbc312 | 2009-11-16 17:56:13 +0000 | [diff] [blame] | 88 | TailMergeSize("tail-merge-size", |
Eugene Zelenko | 887aef7 | 2017-10-10 22:33:29 +0000 | [diff] [blame] | 89 | cl::desc("Min number of instructions to consider tail merging"), |
| 90 | cl::init(3), cl::Hidden); |
Devang Patel | 794fd75 | 2007-05-01 21:15:47 +0000 | [diff] [blame] | 91 | |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 92 | namespace { |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 93 | |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 94 | /// BranchFolderPass - Wrap branch folder in a machine function pass. |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 95 | class BranchFolderPass : public MachineFunctionPass { |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 96 | public: |
| 97 | static char ID; |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 98 | |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 99 | explicit BranchFolderPass(): MachineFunctionPass(ID) {} |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 100 | |
Craig Topper | 9f998de | 2014-03-07 09:26:03 +0000 | [diff] [blame] | 101 | bool runOnMachineFunction(MachineFunction &MF) override; |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 102 | |
Craig Topper | 9f998de | 2014-03-07 09:26:03 +0000 | [diff] [blame] | 103 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 104 | AU.addRequired<MachineBlockFrequencyInfo>(); |
| 105 | AU.addRequired<MachineBranchProbabilityInfo>(); |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 106 | AU.addRequired<TargetPassConfig>(); |
| 107 | MachineFunctionPass::getAnalysisUsage(AU); |
| 108 | } |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 109 | }; |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 110 | |
| 111 | } // end anonymous namespace |
Dan Gohman | 72b2990 | 2009-11-12 01:59:26 +0000 | [diff] [blame] | 112 | |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 113 | char BranchFolderPass::ID = 0; |
Eugene Zelenko | 887aef7 | 2017-10-10 22:33:29 +0000 | [diff] [blame] | 114 | |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 115 | char &llvm::BranchFolderPassID = BranchFolderPass::ID; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 116 | |
Matthias Braun | 94c4904 | 2017-05-25 21:26:32 +0000 | [diff] [blame] | 117 | INITIALIZE_PASS(BranchFolderPass, DEBUG_TYPE, |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 118 | "Control Flow Optimizer", false, false) |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 119 | |
| 120 | bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) { |
Matthias Braun | d318139 | 2017-12-15 22:22:58 +0000 | [diff] [blame] | 121 | if (skipFunction(MF.getFunction())) |
Paul Robinson | 5fa58a5 | 2014-03-31 17:43:35 +0000 | [diff] [blame] | 122 | return false; |
| 123 | |
Andrew Trick | 61f1e3d | 2012-02-08 21:22:48 +0000 | [diff] [blame] | 124 | TargetPassConfig *PassConfig = &getAnalysis<TargetPassConfig>(); |
Vincent Lejeune | d254d31 | 2013-12-07 01:49:19 +0000 | [diff] [blame] | 125 | // TailMerge can create jump into if branches that make CFG irreducible for |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 126 | // HW that requires structurized CFG. |
Vincent Lejeune | d254d31 | 2013-12-07 01:49:19 +0000 | [diff] [blame] | 127 | bool EnableTailMerge = !MF.getTarget().requiresStructuredCFG() && |
David Majnemer | 0955fc3 | 2015-10-01 21:04:13 +0000 | [diff] [blame] | 128 | PassConfig->getEnableTailMerge(); |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 129 | BranchFolder::MBFIWrapper MBBFreqInfo( |
| 130 | getAnalysis<MachineBlockFrequencyInfo>()); |
| 131 | BranchFolder Folder(EnableTailMerge, /*CommonHoist=*/true, MBBFreqInfo, |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 132 | getAnalysis<MachineBranchProbabilityInfo>()); |
Eric Christopher | 6035518 | 2014-08-05 02:39:49 +0000 | [diff] [blame] | 133 | return Folder.OptimizeFunction(MF, MF.getSubtarget().getInstrInfo(), |
| 134 | MF.getSubtarget().getRegisterInfo(), |
| 135 | getAnalysisIfAvailable<MachineModuleInfo>()); |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 136 | } |
| 137 | |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 138 | BranchFolder::BranchFolder(bool defaultEnableTailMerge, bool CommonHoist, |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 139 | MBFIWrapper &FreqInfo, |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 140 | const MachineBranchProbabilityInfo &ProbInfo, |
| 141 | unsigned MinTailLength) |
| 142 | : EnableHoistCommonCode(CommonHoist), MinCommonTailLength(MinTailLength), |
| 143 | MBBFreqInfo(FreqInfo), MBPI(ProbInfo) { |
| 144 | if (MinCommonTailLength == 0) |
| 145 | MinCommonTailLength = TailMergeSize; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 146 | switch (FlagEnableTailMerge) { |
| 147 | case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break; |
| 148 | case cl::BOU_TRUE: EnableTailMerge = true; break; |
| 149 | case cl::BOU_FALSE: EnableTailMerge = false; break; |
| 150 | } |
Evan Cheng | b3c2742 | 2009-09-03 23:54:22 +0000 | [diff] [blame] | 151 | } |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 152 | |
Chris Lattner | 683747a | 2006-10-17 23:17:27 +0000 | [diff] [blame] | 153 | void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) { |
Jim Laskey | 033c971 | 2007-02-22 16:39:03 +0000 | [diff] [blame] | 154 | assert(MBB->pred_empty() && "MBB must be dead!"); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 155 | LLVM_DEBUG(dbgs() << "\nRemoving MBB: " << *MBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 156 | |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 157 | MachineFunction *MF = MBB->getParent(); |
| 158 | // drop all successors. |
| 159 | while (!MBB->succ_empty()) |
| 160 | MBB->removeSuccessor(MBB->succ_end()-1); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 161 | |
Rafael Espindola | f924dea | 2011-06-14 15:31:54 +0000 | [diff] [blame] | 162 | // Avoid matching if this pointer gets reused. |
| 163 | TriedMerging.erase(MBB); |
| 164 | |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 165 | // Remove the block. |
Dan Gohman | 8e5f2c6 | 2008-07-07 23:14:23 +0000 | [diff] [blame] | 166 | MF->erase(MBB); |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 167 | EHScopeMembership.erase(MBB); |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 168 | if (MLI) |
| 169 | MLI->removeBlock(MBB); |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 170 | } |
| 171 | |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 172 | bool BranchFolder::OptimizeFunction(MachineFunction &MF, |
| 173 | const TargetInstrInfo *tii, |
| 174 | const TargetRegisterInfo *tri, |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 175 | MachineModuleInfo *mmi, |
| 176 | MachineLoopInfo *mli, bool AfterPlacement) { |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 177 | if (!tii) return false; |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 178 | |
Rafael Espindola | f924dea | 2011-06-14 15:31:54 +0000 | [diff] [blame] | 179 | TriedMerging.clear(); |
| 180 | |
Matthias Braun | b0e29ac | 2017-05-26 06:32:31 +0000 | [diff] [blame] | 181 | MachineRegisterInfo &MRI = MF.getRegInfo(); |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 182 | AfterBlockPlacement = AfterPlacement; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 183 | TII = tii; |
| 184 | TRI = tri; |
| 185 | MMI = mmi; |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 186 | MLI = mli; |
Matthias Braun | b0e29ac | 2017-05-26 06:32:31 +0000 | [diff] [blame] | 187 | this->MRI = &MRI; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 188 | |
Matthias Braun | 1efbc7f | 2016-07-12 18:44:33 +0000 | [diff] [blame] | 189 | UpdateLiveIns = MRI.tracksLiveness() && TRI->trackLivenessAfterRegAlloc(MF); |
| 190 | if (!UpdateLiveIns) |
Jakob Stoklund Olesen | 80799fb | 2012-03-27 17:06:09 +0000 | [diff] [blame] | 191 | MRI.invalidateLiveness(); |
Evan Cheng | 80b09fe | 2008-04-10 02:32:10 +0000 | [diff] [blame] | 192 | |
Dale Johannesen | 14ba0cc | 2007-05-15 21:19:17 +0000 | [diff] [blame] | 193 | // Fix CFG. The later algorithms expect it to be right. |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 194 | bool MadeChange = false; |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 195 | for (MachineBasicBlock &MBB : MF) { |
| 196 | MachineBasicBlock *TBB = nullptr, *FBB = nullptr; |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 197 | SmallVector<MachineOperand, 4> Cond; |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 198 | if (!TII->analyzeBranch(MBB, TBB, FBB, Cond, true)) |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 199 | MadeChange |= MBB.CorrectExtraCFGEdges(TBB, FBB, !Cond.empty()); |
Dale Johannesen | 14ba0cc | 2007-05-15 21:19:17 +0000 | [diff] [blame] | 200 | } |
| 201 | |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 202 | // Recalculate EH scope membership. |
| 203 | EHScopeMembership = getEHScopeMembership(MF); |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 204 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 205 | bool MadeChangeThisIteration = true; |
| 206 | while (MadeChangeThisIteration) { |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 207 | MadeChangeThisIteration = TailMergeBlocks(MF); |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 208 | // No need to clean up if tail merging does not change anything after the |
| 209 | // block placement. |
| 210 | if (!AfterBlockPlacement || MadeChangeThisIteration) |
| 211 | MadeChangeThisIteration |= OptimizeBranches(MF); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 212 | if (EnableHoistCommonCode) |
| 213 | MadeChangeThisIteration |= HoistCommonCode(MF); |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 214 | MadeChange |= MadeChangeThisIteration; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 215 | } |
| 216 | |
Bob Wilson | 80d2370 | 2010-03-19 19:05:41 +0000 | [diff] [blame] | 217 | // See if any jump tables have become dead as the code generator |
Chris Lattner | 6acfe12 | 2006-10-28 18:34:47 +0000 | [diff] [blame] | 218 | // did its thing. |
| 219 | MachineJumpTableInfo *JTI = MF.getJumpTableInfo(); |
Matthias Braun | 1efbc7f | 2016-07-12 18:44:33 +0000 | [diff] [blame] | 220 | if (!JTI) |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 221 | return MadeChange; |
Andrew Trick | 1df91b0 | 2012-02-08 21:22:43 +0000 | [diff] [blame] | 222 | |
Bob Wilson | 80d2370 | 2010-03-19 19:05:41 +0000 | [diff] [blame] | 223 | // Walk the function to find jump tables that are live. |
| 224 | BitVector JTIsLive(JTI->getJumpTables().size()); |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 225 | for (const MachineBasicBlock &BB : MF) { |
| 226 | for (const MachineInstr &I : BB) |
| 227 | for (const MachineOperand &Op : I.operands()) { |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 228 | if (!Op.isJTI()) continue; |
Chris Lattner | 6acfe12 | 2006-10-28 18:34:47 +0000 | [diff] [blame] | 229 | |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 230 | // Remember that this JT is live. |
Bob Wilson | 80d2370 | 2010-03-19 19:05:41 +0000 | [diff] [blame] | 231 | JTIsLive.set(Op.getIndex()); |
Chris Lattner | 6acfe12 | 2006-10-28 18:34:47 +0000 | [diff] [blame] | 232 | } |
| 233 | } |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 234 | |
Bob Wilson | 80d2370 | 2010-03-19 19:05:41 +0000 | [diff] [blame] | 235 | // Finally, remove dead jump tables. This happens when the |
| 236 | // indirect jump was unreachable (and thus deleted). |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 237 | for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i) |
| 238 | if (!JTIsLive.test(i)) { |
| 239 | JTI->RemoveJumpTable(i); |
| 240 | MadeChange = true; |
| 241 | } |
| 242 | |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 243 | return MadeChange; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 244 | } |
| 245 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 246 | //===----------------------------------------------------------------------===// |
| 247 | // Tail Merging of Blocks |
| 248 | //===----------------------------------------------------------------------===// |
| 249 | |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 250 | /// HashMachineInstr - Compute a hash value for MI and its operands. |
Duncan P. N. Exon Smith | 7dd408d | 2016-02-27 19:48:01 +0000 | [diff] [blame] | 251 | static unsigned HashMachineInstr(const MachineInstr &MI) { |
| 252 | unsigned Hash = MI.getOpcode(); |
| 253 | for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) { |
| 254 | const MachineOperand &Op = MI.getOperand(i); |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 255 | |
Benjamin Kramer | 530a616 | 2015-06-23 14:47:36 +0000 | [diff] [blame] | 256 | // Merge in bits from the operand if easy. We can't use MachineOperand's |
| 257 | // hash_code here because it's not deterministic and we sort by hash value |
| 258 | // later. |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 259 | unsigned OperandHash = 0; |
| 260 | switch (Op.getType()) { |
NAKAMURA Takumi | ac5e008 | 2015-06-20 06:22:04 +0000 | [diff] [blame] | 261 | case MachineOperand::MO_Register: |
| 262 | OperandHash = Op.getReg(); |
| 263 | break; |
| 264 | case MachineOperand::MO_Immediate: |
| 265 | OperandHash = Op.getImm(); |
| 266 | break; |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 267 | case MachineOperand::MO_MachineBasicBlock: |
| 268 | OperandHash = Op.getMBB()->getNumber(); |
| 269 | break; |
| 270 | case MachineOperand::MO_FrameIndex: |
| 271 | case MachineOperand::MO_ConstantPoolIndex: |
| 272 | case MachineOperand::MO_JumpTableIndex: |
| 273 | OperandHash = Op.getIndex(); |
| 274 | break; |
| 275 | case MachineOperand::MO_GlobalAddress: |
| 276 | case MachineOperand::MO_ExternalSymbol: |
| 277 | // Global address / external symbol are too hard, don't bother, but do |
| 278 | // pull in the offset. |
| 279 | OperandHash = Op.getOffset(); |
| 280 | break; |
NAKAMURA Takumi | ac5e008 | 2015-06-20 06:22:04 +0000 | [diff] [blame] | 281 | default: |
| 282 | break; |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 283 | } |
| 284 | |
NAKAMURA Takumi | ac5e008 | 2015-06-20 06:22:04 +0000 | [diff] [blame] | 285 | Hash += ((OperandHash << 3) | Op.getType()) << (i & 31); |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 286 | } |
| 287 | return Hash; |
| 288 | } |
| 289 | |
Dan Gohman | 30fc5bb | 2010-05-03 14:35:47 +0000 | [diff] [blame] | 290 | /// HashEndOfMBB - Hash the last instruction in the MBB. |
Duncan P. N. Exon Smith | 7dd408d | 2016-02-27 19:48:01 +0000 | [diff] [blame] | 291 | static unsigned HashEndOfMBB(const MachineBasicBlock &MBB) { |
| 292 | MachineBasicBlock::const_iterator I = MBB.getLastNonDebugInstr(); |
| 293 | if (I == MBB.end()) |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 294 | return 0; |
NAKAMURA Takumi | 3d378e6 | 2015-06-20 06:21:48 +0000 | [diff] [blame] | 295 | |
Duncan P. N. Exon Smith | 7dd408d | 2016-02-27 19:48:01 +0000 | [diff] [blame] | 296 | return HashMachineInstr(*I); |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 297 | } |
| 298 | |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 299 | /// Whether MI should be counted as an instruction when calculating common tail. |
| 300 | static bool countsAsInstruction(const MachineInstr &MI) { |
Hsiangkai Wang | 3c67822 | 2018-11-30 08:07:29 +0000 | [diff] [blame] | 301 | return !(MI.isDebugInstr() || MI.isCFIInstruction()); |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 302 | } |
| 303 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 304 | /// ComputeCommonTailLength - Given two machine basic blocks, compute the number |
| 305 | /// of instructions they actually have in common together at their end. Return |
| 306 | /// iterators for the first shared instruction in each block. |
| 307 | static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1, |
| 308 | MachineBasicBlock *MBB2, |
| 309 | MachineBasicBlock::iterator &I1, |
| 310 | MachineBasicBlock::iterator &I2) { |
| 311 | I1 = MBB1->end(); |
| 312 | I2 = MBB2->end(); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 313 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 314 | unsigned TailLen = 0; |
| 315 | while (I1 != MBB1->begin() && I2 != MBB2->begin()) { |
| 316 | --I1; --I2; |
Dale Johannesen | 84839da | 2010-03-08 05:38:13 +0000 | [diff] [blame] | 317 | // Skip debugging pseudos; necessary to avoid changing the code. |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 318 | while (!countsAsInstruction(*I1)) { |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 319 | if (I1==MBB1->begin()) { |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 320 | while (!countsAsInstruction(*I2)) { |
| 321 | if (I2==MBB2->begin()) { |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 322 | // I1==DBG at begin; I2==DBG at begin |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 323 | goto SkipTopCFIAndReturn; |
| 324 | } |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 325 | --I2; |
| 326 | } |
| 327 | ++I2; |
| 328 | // I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 329 | goto SkipTopCFIAndReturn; |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 330 | } |
Dale Johannesen | 84839da | 2010-03-08 05:38:13 +0000 | [diff] [blame] | 331 | --I1; |
| 332 | } |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 333 | // I1==first (untested) non-DBG preceding known match |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 334 | while (!countsAsInstruction(*I2)) { |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 335 | if (I2==MBB2->begin()) { |
| 336 | ++I1; |
| 337 | // I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 338 | goto SkipTopCFIAndReturn; |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 339 | } |
Dale Johannesen | 84839da | 2010-03-08 05:38:13 +0000 | [diff] [blame] | 340 | --I2; |
| 341 | } |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 342 | // I1, I2==first (untested) non-DBGs preceding known match |
Duncan P. N. Exon Smith | 1d75c8d | 2016-02-27 20:01:33 +0000 | [diff] [blame] | 343 | if (!I1->isIdenticalTo(*I2) || |
Bill Wendling | da6efc5 | 2007-10-25 19:49:32 +0000 | [diff] [blame] | 344 | // FIXME: This check is dubious. It's used to get around a problem where |
Bill Wendling | 0713a22 | 2007-10-25 18:23:45 +0000 | [diff] [blame] | 345 | // people incorrectly expect inline asm directives to remain in the same |
| 346 | // relative order. This is untenable because normal compiler |
| 347 | // optimizations (like this one) may reorder and/or merge these |
| 348 | // directives. |
Chris Lattner | 518bb53 | 2010-02-09 19:54:29 +0000 | [diff] [blame] | 349 | I1->isInlineAsm()) { |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 350 | ++I1; ++I2; |
| 351 | break; |
| 352 | } |
| 353 | ++TailLen; |
| 354 | } |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 355 | // Back past possible debugging pseudos at beginning of block. This matters |
| 356 | // when one block differs from the other only by whether debugging pseudos |
Junmo Park | d8ba62a | 2015-12-04 02:06:59 +0000 | [diff] [blame] | 357 | // are present at the beginning. (This way, the various checks later for |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 358 | // I1==MBB1->begin() work as expected.) |
| 359 | if (I1 == MBB1->begin() && I2 != MBB2->begin()) { |
| 360 | --I2; |
Shiva Chen | 24abe71 | 2018-05-09 02:42:00 +0000 | [diff] [blame] | 361 | while (I2->isDebugInstr()) { |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 362 | if (I2 == MBB2->begin()) |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 363 | return TailLen; |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 364 | --I2; |
| 365 | } |
| 366 | ++I2; |
| 367 | } |
| 368 | if (I2 == MBB2->begin() && I1 != MBB1->begin()) { |
| 369 | --I1; |
Shiva Chen | 24abe71 | 2018-05-09 02:42:00 +0000 | [diff] [blame] | 370 | while (I1->isDebugInstr()) { |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 371 | if (I1 == MBB1->begin()) |
| 372 | return TailLen; |
| 373 | --I1; |
| 374 | } |
| 375 | ++I1; |
| 376 | } |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 377 | |
| 378 | SkipTopCFIAndReturn: |
| 379 | // Ensure that I1 and I2 do not point to a CFI_INSTRUCTION. This can happen if |
| 380 | // I1 and I2 are non-identical when compared and then one or both of them ends |
| 381 | // up pointing to a CFI instruction after being incremented. For example: |
| 382 | /* |
| 383 | BB1: |
| 384 | ... |
| 385 | INSTRUCTION_A |
| 386 | ADD32ri8 <- last common instruction |
| 387 | ... |
| 388 | BB2: |
| 389 | ... |
| 390 | INSTRUCTION_B |
| 391 | CFI_INSTRUCTION |
| 392 | ADD32ri8 <- last common instruction |
| 393 | ... |
| 394 | */ |
| 395 | // When INSTRUCTION_A and INSTRUCTION_B are compared as not equal, after |
| 396 | // incrementing the iterators, I1 will point to ADD, however I2 will point to |
| 397 | // the CFI instruction. Later on, this leads to BB2 being 'hacked off' at the |
| 398 | // wrong place (in ReplaceTailWithBranchTo()) which results in losing this CFI |
| 399 | // instruction. |
| 400 | while (I1 != MBB1->end() && I1->isCFIInstruction()) { |
| 401 | ++I1; |
| 402 | } |
| 403 | |
| 404 | while (I2 != MBB2->end() && I2->isCFIInstruction()) { |
| 405 | ++I2; |
| 406 | } |
| 407 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 408 | return TailLen; |
| 409 | } |
| 410 | |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 411 | void BranchFolder::replaceTailWithBranchTo(MachineBasicBlock::iterator OldInst, |
| 412 | MachineBasicBlock &NewDest) { |
Matthias Braun | fe82f4a | 2016-12-16 23:55:37 +0000 | [diff] [blame] | 413 | if (UpdateLiveIns) { |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 414 | // OldInst should always point to an instruction. |
| 415 | MachineBasicBlock &OldMBB = *OldInst->getParent(); |
| 416 | LiveRegs.clear(); |
| 417 | LiveRegs.addLiveOuts(OldMBB); |
| 418 | // Move backward to the place where will insert the jump. |
| 419 | MachineBasicBlock::iterator I = OldMBB.end(); |
| 420 | do { |
| 421 | --I; |
| 422 | LiveRegs.stepBackward(*I); |
| 423 | } while (I != OldInst); |
| 424 | |
| 425 | // Merging the tails may have switched some undef operand to non-undef ones. |
| 426 | // Add IMPLICIT_DEFS into OldMBB as necessary to have a definition of the |
| 427 | // register. |
| 428 | for (MachineBasicBlock::RegisterMaskPair P : NewDest.liveins()) { |
| 429 | // We computed the liveins with computeLiveIn earlier and should only see |
| 430 | // full registers: |
| 431 | assert(P.LaneMask == LaneBitmask::getAll() && |
| 432 | "Can only handle full register."); |
| 433 | MCPhysReg Reg = P.PhysReg; |
| 434 | if (!LiveRegs.available(*MRI, Reg)) |
| 435 | continue; |
| 436 | DebugLoc DL; |
| 437 | BuildMI(OldMBB, OldInst, DL, TII->get(TargetOpcode::IMPLICIT_DEF), Reg); |
| 438 | } |
Matthias Braun | fe82f4a | 2016-12-16 23:55:37 +0000 | [diff] [blame] | 439 | } |
Eli Friedman | a38cfb2 | 2011-07-06 23:41:48 +0000 | [diff] [blame] | 440 | |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 441 | TII->ReplaceTailWithBranchTo(OldInst, &NewDest); |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 442 | ++NumTailMerge; |
| 443 | } |
| 444 | |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 445 | MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB, |
Andrew Trick | f7b5e01 | 2013-06-24 01:55:01 +0000 | [diff] [blame] | 446 | MachineBasicBlock::iterator BBI1, |
| 447 | const BasicBlock *BB) { |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 448 | if (!TII->isLegalToSplitMBBAt(CurMBB, BBI1)) |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 449 | return nullptr; |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 450 | |
Dan Gohman | 8e5f2c6 | 2008-07-07 23:14:23 +0000 | [diff] [blame] | 451 | MachineFunction &MF = *CurMBB.getParent(); |
| 452 | |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 453 | // Create the fall-through block. |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 454 | MachineFunction::iterator MBBI = CurMBB.getIterator(); |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 455 | MachineBasicBlock *NewMBB = MF.CreateMachineBasicBlock(BB); |
Dan Gohman | 8e5f2c6 | 2008-07-07 23:14:23 +0000 | [diff] [blame] | 456 | CurMBB.getParent()->insert(++MBBI, NewMBB); |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 457 | |
| 458 | // Move all the successors of this block to the specified block. |
Dan Gohman | 04478e5 | 2008-06-19 17:22:29 +0000 | [diff] [blame] | 459 | NewMBB->transferSuccessors(&CurMBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 460 | |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 461 | // Add an edge from CurMBB to NewMBB for the fall-through. |
| 462 | CurMBB.addSuccessor(NewMBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 463 | |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 464 | // Splice the code over. |
| 465 | NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end()); |
Dale Johannesen | 69cb9b7 | 2007-03-20 21:35:06 +0000 | [diff] [blame] | 466 | |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 467 | // NewMBB belongs to the same loop as CurMBB. |
Taewook Oh | f8bacbb | 2017-02-21 00:12:38 +0000 | [diff] [blame] | 468 | if (MLI) |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 469 | if (MachineLoop *ML = MLI->getLoopFor(&CurMBB)) |
| 470 | ML->addBasicBlockToLoop(NewMBB, MLI->getBase()); |
| 471 | |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 472 | // NewMBB inherits CurMBB's block frequency. |
| 473 | MBBFreqInfo.setBlockFreq(NewMBB, MBBFreqInfo.getBlockFreq(&CurMBB)); |
| 474 | |
Matthias Braun | fe82f4a | 2016-12-16 23:55:37 +0000 | [diff] [blame] | 475 | if (UpdateLiveIns) |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 476 | computeAndAddLiveIns(LiveRegs, *NewMBB); |
Dale Johannesen | 69cb9b7 | 2007-03-20 21:35:06 +0000 | [diff] [blame] | 477 | |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 478 | // Add the new block to the EH scope. |
| 479 | const auto &EHScopeI = EHScopeMembership.find(&CurMBB); |
| 480 | if (EHScopeI != EHScopeMembership.end()) { |
| 481 | auto n = EHScopeI->second; |
| 482 | EHScopeMembership[NewMBB] = n; |
Stephan Bergmann | 285cad0 | 2016-03-31 15:42:01 +0000 | [diff] [blame] | 483 | } |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 484 | |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 485 | return NewMBB; |
| 486 | } |
| 487 | |
Chris Lattner | d4bf3c2 | 2006-11-01 19:36:29 +0000 | [diff] [blame] | 488 | /// EstimateRuntime - Make a rough estimate for how long it will take to run |
| 489 | /// the specified code. |
| 490 | static unsigned EstimateRuntime(MachineBasicBlock::iterator I, |
Chris Lattner | 6924430 | 2008-01-07 01:56:04 +0000 | [diff] [blame] | 491 | MachineBasicBlock::iterator E) { |
Chris Lattner | d4bf3c2 | 2006-11-01 19:36:29 +0000 | [diff] [blame] | 492 | unsigned Time = 0; |
| 493 | for (; I != E; ++I) { |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 494 | if (!countsAsInstruction(*I)) |
Dale Johannesen | b0812f1 | 2010-03-05 00:02:59 +0000 | [diff] [blame] | 495 | continue; |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 496 | if (I->isCall()) |
Chris Lattner | d4bf3c2 | 2006-11-01 19:36:29 +0000 | [diff] [blame] | 497 | Time += 10; |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 498 | else if (I->mayLoad() || I->mayStore()) |
Chris Lattner | d4bf3c2 | 2006-11-01 19:36:29 +0000 | [diff] [blame] | 499 | Time += 2; |
| 500 | else |
| 501 | ++Time; |
| 502 | } |
| 503 | return Time; |
| 504 | } |
| 505 | |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 506 | // CurMBB needs to add an unconditional branch to SuccMBB (we removed these |
| 507 | // branches temporarily for tail merging). In the case where CurMBB ends |
| 508 | // with a conditional branch to the next block, optimize by reversing the |
| 509 | // test and conditionally branching to SuccMBB instead. |
Bob Wilson | d34f5d9 | 2009-11-16 18:08:46 +0000 | [diff] [blame] | 510 | static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB, |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 511 | const TargetInstrInfo *TII) { |
| 512 | MachineFunction *MF = CurMBB->getParent(); |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 513 | MachineFunction::iterator I = std::next(MachineFunction::iterator(CurMBB)); |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 514 | MachineBasicBlock *TBB = nullptr, *FBB = nullptr; |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 515 | SmallVector<MachineOperand, 4> Cond; |
Taewook Oh | f8bacbb | 2017-02-21 00:12:38 +0000 | [diff] [blame] | 516 | DebugLoc dl = CurMBB->findBranchDebugLoc(); |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 517 | if (I != MF->end() && !TII->analyzeBranch(*CurMBB, TBB, FBB, Cond, true)) { |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 518 | MachineBasicBlock *NextBB = &*I; |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 519 | if (TBB == NextBB && !Cond.empty() && !FBB) { |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 520 | if (!TII->reverseBranchCondition(Cond)) { |
| 521 | TII->removeBranch(*CurMBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 522 | TII->insertBranch(*CurMBB, SuccBB, nullptr, Cond, dl); |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 523 | return; |
| 524 | } |
| 525 | } |
| 526 | } |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 527 | TII->insertBranch(*CurMBB, SuccBB, nullptr, |
Stuart Hastings | 3bf9125 | 2010-06-17 22:43:56 +0000 | [diff] [blame] | 528 | SmallVector<MachineOperand, 0>(), dl); |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 529 | } |
| 530 | |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 531 | bool |
| 532 | BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const { |
| 533 | if (getHash() < o.getHash()) |
| 534 | return true; |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 535 | if (getHash() > o.getHash()) |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 536 | return false; |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 537 | if (getBlock()->getNumber() < o.getBlock()->getNumber()) |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 538 | return true; |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 539 | if (getBlock()->getNumber() > o.getBlock()->getNumber()) |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 540 | return false; |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 541 | // _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing |
| 542 | // an object with itself. |
Duncan Sands | 97b4ac8 | 2007-07-11 08:47:55 +0000 | [diff] [blame] | 543 | #ifndef _GLIBCXX_DEBUG |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 544 | llvm_unreachable("Predecessor appears twice"); |
David Blaikie | 4d6ccb5 | 2012-01-20 21:51:11 +0000 | [diff] [blame] | 545 | #else |
Craig Topper | 14ce91c | 2012-10-07 20:31:05 +0000 | [diff] [blame] | 546 | return false; |
David Blaikie | 4d6ccb5 | 2012-01-20 21:51:11 +0000 | [diff] [blame] | 547 | #endif |
Dale Johannesen | 95ef406 | 2007-05-29 23:47:50 +0000 | [diff] [blame] | 548 | } |
| 549 | |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 550 | BlockFrequency |
| 551 | BranchFolder::MBFIWrapper::getBlockFreq(const MachineBasicBlock *MBB) const { |
| 552 | auto I = MergedBBFreq.find(MBB); |
| 553 | |
| 554 | if (I != MergedBBFreq.end()) |
| 555 | return I->second; |
| 556 | |
| 557 | return MBFI.getBlockFreq(MBB); |
| 558 | } |
| 559 | |
| 560 | void BranchFolder::MBFIWrapper::setBlockFreq(const MachineBasicBlock *MBB, |
| 561 | BlockFrequency F) { |
| 562 | MergedBBFreq[MBB] = F; |
| 563 | } |
| 564 | |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 565 | raw_ostream & |
| 566 | BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS, |
| 567 | const MachineBasicBlock *MBB) const { |
| 568 | return MBFI.printBlockFreq(OS, getBlockFreq(MBB)); |
| 569 | } |
| 570 | |
| 571 | raw_ostream & |
| 572 | BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS, |
| 573 | const BlockFrequency Freq) const { |
| 574 | return MBFI.printBlockFreq(OS, Freq); |
| 575 | } |
| 576 | |
Xinliang David Li | 210c690 | 2017-02-15 19:21:04 +0000 | [diff] [blame] | 577 | void BranchFolder::MBFIWrapper::view(const Twine &Name, bool isSimple) { |
| 578 | MBFI.view(Name, isSimple); |
| 579 | } |
Xinliang David Li | 828b398 | 2017-01-29 01:57:02 +0000 | [diff] [blame] | 580 | |
Kyle Butt | 5818a51 | 2017-01-31 23:48:32 +0000 | [diff] [blame] | 581 | uint64_t |
| 582 | BranchFolder::MBFIWrapper::getEntryFreq() const { |
| 583 | return MBFI.getEntryFreq(); |
| 584 | } |
| 585 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 586 | /// CountTerminators - Count the number of terminators in the given |
| 587 | /// block and set I to the position of the first non-terminator, if there |
| 588 | /// is one, or MBB->end() otherwise. |
| 589 | static unsigned CountTerminators(MachineBasicBlock *MBB, |
| 590 | MachineBasicBlock::iterator &I) { |
| 591 | I = MBB->end(); |
| 592 | unsigned NumTerms = 0; |
Eugene Zelenko | e74c436 | 2017-06-06 22:22:41 +0000 | [diff] [blame] | 593 | while (true) { |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 594 | if (I == MBB->begin()) { |
| 595 | I = MBB->end(); |
| 596 | break; |
| 597 | } |
| 598 | --I; |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 599 | if (!I->isTerminator()) break; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 600 | ++NumTerms; |
| 601 | } |
| 602 | return NumTerms; |
| 603 | } |
| 604 | |
Reid Kleckner | f3470b1 | 2017-02-14 21:02:24 +0000 | [diff] [blame] | 605 | /// A no successor, non-return block probably ends in unreachable and is cold. |
| 606 | /// Also consider a block that ends in an indirect branch to be a return block, |
| 607 | /// since many targets use plain indirect branches to return. |
| 608 | static bool blockEndsInUnreachable(const MachineBasicBlock *MBB) { |
| 609 | if (!MBB->succ_empty()) |
| 610 | return false; |
| 611 | if (MBB->empty()) |
| 612 | return true; |
| 613 | return !(MBB->back().isReturn() || MBB->back().isIndirectBranch()); |
| 614 | } |
| 615 | |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 616 | /// ProfitableToMerge - Check if two machine basic blocks have a common tail |
| 617 | /// and decide if it would be profitable to merge those tails. Return the |
| 618 | /// length of the common tail and iterators to the first common instruction |
| 619 | /// in each block. |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 620 | /// MBB1, MBB2 The blocks to check |
| 621 | /// MinCommonTailLength Minimum size of tail block to be merged. |
| 622 | /// CommonTailLen Out parameter to record the size of the shared tail between |
| 623 | /// MBB1 and MBB2 |
| 624 | /// I1, I2 Iterator references that will be changed to point to the first |
| 625 | /// instruction in the common tail shared by MBB1,MBB2 |
| 626 | /// SuccBB A common successor of MBB1, MBB2 which are in a canonical form |
| 627 | /// relative to SuccBB |
| 628 | /// PredBB The layout predecessor of SuccBB, if any. |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 629 | /// EHScopeMembership map from block to EH scope #. |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 630 | /// AfterPlacement True if we are merging blocks after layout. Stricter |
| 631 | /// thresholds apply to prevent undoing tail-duplication. |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 632 | static bool |
| 633 | ProfitableToMerge(MachineBasicBlock *MBB1, MachineBasicBlock *MBB2, |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 634 | unsigned MinCommonTailLength, unsigned &CommonTailLen, |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 635 | MachineBasicBlock::iterator &I1, |
| 636 | MachineBasicBlock::iterator &I2, MachineBasicBlock *SuccBB, |
| 637 | MachineBasicBlock *PredBB, |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 638 | DenseMap<const MachineBasicBlock *, int> &EHScopeMembership, |
Kyle Butt | c04b985 | 2016-08-10 18:36:18 +0000 | [diff] [blame] | 639 | bool AfterPlacement) { |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 640 | // It is never profitable to tail-merge blocks from two different EH scopes. |
| 641 | if (!EHScopeMembership.empty()) { |
| 642 | auto EHScope1 = EHScopeMembership.find(MBB1); |
| 643 | assert(EHScope1 != EHScopeMembership.end()); |
| 644 | auto EHScope2 = EHScopeMembership.find(MBB2); |
| 645 | assert(EHScope2 != EHScopeMembership.end()); |
| 646 | if (EHScope1->second != EHScope2->second) |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 647 | return false; |
| 648 | } |
| 649 | |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 650 | CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2); |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 651 | if (CommonTailLen == 0) |
| 652 | return false; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 653 | LLVM_DEBUG(dbgs() << "Common tail length of " << printMBBReference(*MBB1) |
| 654 | << " and " << printMBBReference(*MBB2) << " is " |
| 655 | << CommonTailLen << '\n'); |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 656 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 657 | // It's almost always profitable to merge any number of non-terminator |
| 658 | // instructions with the block that falls through into the common successor. |
Kyle Butt | c04b985 | 2016-08-10 18:36:18 +0000 | [diff] [blame] | 659 | // This is true only for a single successor. For multiple successors, we are |
| 660 | // trading a conditional branch for an unconditional one. |
| 661 | // TODO: Re-visit successor size for non-layout tail merging. |
| 662 | if ((MBB1 == PredBB || MBB2 == PredBB) && |
| 663 | (!AfterPlacement || MBB1->succ_size() == 1)) { |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 664 | MachineBasicBlock::iterator I; |
| 665 | unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I); |
| 666 | if (CommonTailLen > NumTerms) |
| 667 | return true; |
| 668 | } |
| 669 | |
Reid Kleckner | f3470b1 | 2017-02-14 21:02:24 +0000 | [diff] [blame] | 670 | // If these are identical non-return blocks with no successors, merge them. |
| 671 | // Such blocks are typically cold calls to noreturn functions like abort, and |
| 672 | // are unlikely to become a fallthrough target after machine block placement. |
| 673 | // Tail merging these blocks is unlikely to create additional unconditional |
| 674 | // branches, and will reduce the size of this cold code. |
| 675 | if (I1 == MBB1->begin() && I2 == MBB2->begin() && |
| 676 | blockEndsInUnreachable(MBB1) && blockEndsInUnreachable(MBB2)) |
| 677 | return true; |
| 678 | |
Dan Gohman | ad6af45 | 2009-11-12 00:39:10 +0000 | [diff] [blame] | 679 | // If one of the blocks can be completely merged and happens to be in |
| 680 | // a position where the other could fall through into it, merge any number |
| 681 | // of instructions, because it can be done without a branch. |
| 682 | // TODO: If the blocks are not adjacent, move one of them so that they are? |
| 683 | if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin()) |
| 684 | return true; |
| 685 | if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin()) |
| 686 | return true; |
| 687 | |
Kyle Butt | ad1b74f | 2017-04-10 22:28:12 +0000 | [diff] [blame] | 688 | // If both blocks are identical and end in a branch, merge them unless they |
| 689 | // both have a fallthrough predecessor and successor. |
| 690 | // We can only do this after block placement because it depends on whether |
| 691 | // there are fallthroughs, and we don't know until after layout. |
| 692 | if (AfterPlacement && I1 == MBB1->begin() && I2 == MBB2->begin()) { |
| 693 | auto BothFallThrough = [](MachineBasicBlock *MBB) { |
| 694 | if (MBB->succ_size() != 0 && !MBB->canFallThrough()) |
| 695 | return false; |
| 696 | MachineFunction::iterator I(MBB); |
| 697 | MachineFunction *MF = MBB->getParent(); |
| 698 | return (MBB != &*MF->begin()) && std::prev(I)->canFallThrough(); |
| 699 | }; |
| 700 | if (!BothFallThrough(MBB1) || !BothFallThrough(MBB2)) |
| 701 | return true; |
| 702 | } |
| 703 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 704 | // If both blocks have an unconditional branch temporarily stripped out, |
Dan Gohman | c4c550c | 2009-11-13 21:02:15 +0000 | [diff] [blame] | 705 | // count that as an additional common instruction for the following |
Kyle Butt | c04b985 | 2016-08-10 18:36:18 +0000 | [diff] [blame] | 706 | // heuristics. This heuristic is only accurate for single-succ blocks, so to |
| 707 | // make sure that during layout merging and duplicating don't crash, we check |
| 708 | // for that when merging during layout. |
Dan Gohman | c4c550c | 2009-11-13 21:02:15 +0000 | [diff] [blame] | 709 | unsigned EffectiveTailLen = CommonTailLen; |
Bob Wilson | 3cbc312 | 2009-11-16 17:56:13 +0000 | [diff] [blame] | 710 | if (SuccBB && MBB1 != PredBB && MBB2 != PredBB && |
Kyle Butt | c04b985 | 2016-08-10 18:36:18 +0000 | [diff] [blame] | 711 | (MBB1->succ_size() == 1 || !AfterPlacement) && |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 712 | !MBB1->back().isBarrier() && |
| 713 | !MBB2->back().isBarrier()) |
Dan Gohman | c4c550c | 2009-11-13 21:02:15 +0000 | [diff] [blame] | 714 | ++EffectiveTailLen; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 715 | |
| 716 | // Check if the common tail is long enough to be worthwhile. |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 717 | if (EffectiveTailLen >= MinCommonTailLength) |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 718 | return true; |
| 719 | |
Dan Gohman | c4c550c | 2009-11-13 21:02:15 +0000 | [diff] [blame] | 720 | // If we are optimizing for code size, 2 instructions in common is enough if |
| 721 | // we don't have to split a block. At worst we will be introducing 1 new |
| 722 | // branch instruction, which is likely to be smaller than the 2 |
| 723 | // instructions that would be deleted in the merge. |
Evan Cheng | cf13af6 | 2011-02-21 23:39:48 +0000 | [diff] [blame] | 724 | MachineFunction *MF = MBB1->getParent(); |
Matthias Braun | d318139 | 2017-12-15 22:22:58 +0000 | [diff] [blame] | 725 | return EffectiveTailLen >= 2 && MF->getFunction().optForSize() && |
Rafael Espindola | 2fe94b6 | 2015-10-24 23:11:13 +0000 | [diff] [blame] | 726 | (I1 == MBB1->begin() || I2 == MBB2->begin()); |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 727 | } |
| 728 | |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 729 | unsigned BranchFolder::ComputeSameTails(unsigned CurHash, |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 730 | unsigned MinCommonTailLength, |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 731 | MachineBasicBlock *SuccBB, |
| 732 | MachineBasicBlock *PredBB) { |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 733 | unsigned maxCommonTailLength = 0U; |
| 734 | SameTails.clear(); |
| 735 | MachineBasicBlock::iterator TrialBBI1, TrialBBI2; |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 736 | MPIterator HighestMPIter = std::prev(MergePotentials.end()); |
| 737 | for (MPIterator CurMPIter = std::prev(MergePotentials.end()), |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 738 | B = MergePotentials.begin(); |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 739 | CurMPIter != B && CurMPIter->getHash() == CurHash; --CurMPIter) { |
| 740 | for (MPIterator I = std::prev(CurMPIter); I->getHash() == CurHash; --I) { |
Bob Wilson | 7b888b8 | 2009-10-29 18:40:06 +0000 | [diff] [blame] | 741 | unsigned CommonTailLen; |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 742 | if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(), |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 743 | MinCommonTailLength, |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 744 | CommonTailLen, TrialBBI1, TrialBBI2, |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 745 | SuccBB, PredBB, |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 746 | EHScopeMembership, |
Kyle Butt | c04b985 | 2016-08-10 18:36:18 +0000 | [diff] [blame] | 747 | AfterBlockPlacement)) { |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 748 | if (CommonTailLen > maxCommonTailLength) { |
| 749 | SameTails.clear(); |
| 750 | maxCommonTailLength = CommonTailLen; |
| 751 | HighestMPIter = CurMPIter; |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 752 | SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1)); |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 753 | } |
| 754 | if (HighestMPIter == CurMPIter && |
| 755 | CommonTailLen == maxCommonTailLength) |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 756 | SameTails.push_back(SameTailElt(I, TrialBBI2)); |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 757 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 758 | if (I == B) |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 759 | break; |
| 760 | } |
| 761 | } |
| 762 | return maxCommonTailLength; |
| 763 | } |
| 764 | |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 765 | void BranchFolder::RemoveBlocksWithHash(unsigned CurHash, |
Bob Wilson | d34f5d9 | 2009-11-16 18:08:46 +0000 | [diff] [blame] | 766 | MachineBasicBlock *SuccBB, |
| 767 | MachineBasicBlock *PredBB) { |
Dale Johannesen | 679860e | 2008-05-23 17:19:02 +0000 | [diff] [blame] | 768 | MPIterator CurMPIter, B; |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 769 | for (CurMPIter = std::prev(MergePotentials.end()), |
| 770 | B = MergePotentials.begin(); |
| 771 | CurMPIter->getHash() == CurHash; --CurMPIter) { |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 772 | // Put the unconditional branch back, if we need one. |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 773 | MachineBasicBlock *CurMBB = CurMPIter->getBlock(); |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 774 | if (SuccBB && CurMBB != PredBB) |
| 775 | FixTail(CurMBB, SuccBB, TII); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 776 | if (CurMPIter == B) |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 777 | break; |
| 778 | } |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 779 | if (CurMPIter->getHash() != CurHash) |
Dale Johannesen | 679860e | 2008-05-23 17:19:02 +0000 | [diff] [blame] | 780 | CurMPIter++; |
| 781 | MergePotentials.erase(CurMPIter, MergePotentials.end()); |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 782 | } |
| 783 | |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 784 | bool BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB, |
Andrew Trick | f7b5e01 | 2013-06-24 01:55:01 +0000 | [diff] [blame] | 785 | MachineBasicBlock *SuccBB, |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 786 | unsigned maxCommonTailLength, |
| 787 | unsigned &commonTailIndex) { |
| 788 | commonTailIndex = 0; |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 789 | unsigned TimeEstimate = ~0U; |
Dan Gohman | 8520149d | 2009-11-12 01:51:28 +0000 | [diff] [blame] | 790 | for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 791 | // Use PredBB if possible; that doesn't require a new branch. |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 792 | if (SameTails[i].getBlock() == PredBB) { |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 793 | commonTailIndex = i; |
| 794 | break; |
| 795 | } |
| 796 | // Otherwise, make a (fairly bogus) choice based on estimate of |
| 797 | // how long it will take the various blocks to execute. |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 798 | unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(), |
| 799 | SameTails[i].getTailStartPos()); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 800 | if (t <= TimeEstimate) { |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 801 | TimeEstimate = t; |
| 802 | commonTailIndex = i; |
| 803 | } |
| 804 | } |
| 805 | |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 806 | MachineBasicBlock::iterator BBI = |
| 807 | SameTails[commonTailIndex].getTailStartPos(); |
| 808 | MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 809 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 810 | LLVM_DEBUG(dbgs() << "\nSplitting " << printMBBReference(*MBB) << ", size " |
| 811 | << maxCommonTailLength); |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 812 | |
Andrew Trick | f7b5e01 | 2013-06-24 01:55:01 +0000 | [diff] [blame] | 813 | // If the split block unconditionally falls-thru to SuccBB, it will be |
| 814 | // merged. In control flow terms it should then take SuccBB's name. e.g. If |
| 815 | // SuccBB is an inner loop, the common tail is still part of the inner loop. |
| 816 | const BasicBlock *BB = (SuccBB && MBB->succ_size() == 1) ? |
| 817 | SuccBB->getBasicBlock() : MBB->getBasicBlock(); |
| 818 | MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI, BB); |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 819 | if (!newMBB) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 820 | LLVM_DEBUG(dbgs() << "... failed!"); |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 821 | return false; |
| 822 | } |
| 823 | |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 824 | SameTails[commonTailIndex].setBlock(newMBB); |
| 825 | SameTails[commonTailIndex].setTailStartPos(newMBB->begin()); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 826 | |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 827 | // If we split PredBB, newMBB is the new predecessor. |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 828 | if (PredBB == MBB) |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 829 | PredBB = newMBB; |
| 830 | |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 831 | return true; |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 832 | } |
| 833 | |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 834 | static void |
Matthias Braun | b72235f | 2016-09-20 01:14:42 +0000 | [diff] [blame] | 835 | mergeOperations(MachineBasicBlock::iterator MBBIStartPos, |
| 836 | MachineBasicBlock &MBBCommon) { |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 837 | MachineBasicBlock *MBB = MBBIStartPos->getParent(); |
| 838 | // Note CommonTailLen does not necessarily matches the size of |
| 839 | // the common BB nor all its instructions because of debug |
| 840 | // instructions differences. |
| 841 | unsigned CommonTailLen = 0; |
| 842 | for (auto E = MBB->end(); MBBIStartPos != E; ++MBBIStartPos) |
| 843 | ++CommonTailLen; |
| 844 | |
| 845 | MachineBasicBlock::reverse_iterator MBBI = MBB->rbegin(); |
Chad Rosier | 09fc12a | 2015-03-10 20:29:59 +0000 | [diff] [blame] | 846 | MachineBasicBlock::reverse_iterator MBBIE = MBB->rend(); |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 847 | MachineBasicBlock::reverse_iterator MBBICommon = MBBCommon.rbegin(); |
| 848 | MachineBasicBlock::reverse_iterator MBBIECommon = MBBCommon.rend(); |
| 849 | |
| 850 | while (CommonTailLen--) { |
Chad Rosier | 09fc12a | 2015-03-10 20:29:59 +0000 | [diff] [blame] | 851 | assert(MBBI != MBBIE && "Reached BB end within common tail length!"); |
| 852 | (void)MBBIE; |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 853 | |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 854 | if (!countsAsInstruction(*MBBI)) { |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 855 | ++MBBI; |
| 856 | continue; |
| 857 | } |
| 858 | |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 859 | while ((MBBICommon != MBBIECommon) && !countsAsInstruction(*MBBICommon)) |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 860 | ++MBBICommon; |
| 861 | |
| 862 | assert(MBBICommon != MBBIECommon && |
| 863 | "Reached BB end within common tail length!"); |
Duncan P. N. Exon Smith | 1d75c8d | 2016-02-27 20:01:33 +0000 | [diff] [blame] | 864 | assert(MBBICommon->isIdenticalTo(*MBBI) && "Expected matching MIIs!"); |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 865 | |
Matthias Braun | b72235f | 2016-09-20 01:14:42 +0000 | [diff] [blame] | 866 | // Merge MMOs from memory operations in the common block. |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 867 | if (MBBICommon->mayLoad() || MBBICommon->mayStore()) |
Chandler Carruth | 2a752bf | 2018-08-16 21:30:05 +0000 | [diff] [blame] | 868 | MBBICommon->cloneMergedMemRefs(*MBB->getParent(), {&*MBBICommon, &*MBBI}); |
Matthias Braun | b72235f | 2016-09-20 01:14:42 +0000 | [diff] [blame] | 869 | // Drop undef flags if they aren't present in all merged instructions. |
| 870 | for (unsigned I = 0, E = MBBICommon->getNumOperands(); I != E; ++I) { |
| 871 | MachineOperand &MO = MBBICommon->getOperand(I); |
| 872 | if (MO.isReg() && MO.isUndef()) { |
| 873 | const MachineOperand &OtherMO = MBBI->getOperand(I); |
| 874 | if (!OtherMO.isUndef()) |
| 875 | MO.setIsUndef(false); |
| 876 | } |
| 877 | } |
Chad Rosier | e891f49 | 2015-03-10 16:22:52 +0000 | [diff] [blame] | 878 | |
| 879 | ++MBBI; |
| 880 | ++MBBICommon; |
| 881 | } |
| 882 | } |
| 883 | |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 884 | void BranchFolder::mergeCommonTails(unsigned commonTailIndex) { |
| 885 | MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); |
| 886 | |
| 887 | std::vector<MachineBasicBlock::iterator> NextCommonInsts(SameTails.size()); |
| 888 | for (unsigned int i = 0 ; i != SameTails.size() ; ++i) { |
| 889 | if (i != commonTailIndex) { |
| 890 | NextCommonInsts[i] = SameTails[i].getTailStartPos(); |
| 891 | mergeOperations(SameTails[i].getTailStartPos(), *MBB); |
| 892 | } else { |
| 893 | assert(SameTails[i].getTailStartPos() == MBB->begin() && |
| 894 | "MBB is not a common tail only block"); |
| 895 | } |
| 896 | } |
| 897 | |
| 898 | for (auto &MI : *MBB) { |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 899 | if (!countsAsInstruction(MI)) |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 900 | continue; |
| 901 | DebugLoc DL = MI.getDebugLoc(); |
| 902 | for (unsigned int i = 0 ; i < NextCommonInsts.size() ; i++) { |
| 903 | if (i == commonTailIndex) |
| 904 | continue; |
| 905 | |
| 906 | auto &Pos = NextCommonInsts[i]; |
| 907 | assert(Pos != SameTails[i].getBlock()->end() && |
| 908 | "Reached BB end within common tail"); |
Petar Jovanovic | b6bee65 | 2018-04-24 10:32:08 +0000 | [diff] [blame] | 909 | while (!countsAsInstruction(*Pos)) { |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 910 | ++Pos; |
| 911 | assert(Pos != SameTails[i].getBlock()->end() && |
| 912 | "Reached BB end within common tail"); |
| 913 | } |
| 914 | assert(MI.isIdenticalTo(*Pos) && "Expected matching MIIs!"); |
| 915 | DL = DILocation::getMergedLocation(DL, Pos->getDebugLoc()); |
| 916 | NextCommonInsts[i] = ++Pos; |
| 917 | } |
| 918 | MI.setDebugLoc(DL); |
| 919 | } |
| 920 | |
| 921 | if (UpdateLiveIns) { |
| 922 | LivePhysRegs NewLiveIns(*TRI); |
| 923 | computeLiveIns(NewLiveIns, *MBB); |
Krzysztof Parzyszek | d407e55 | 2018-06-22 16:38:38 +0000 | [diff] [blame] | 924 | LiveRegs.init(*TRI); |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 925 | |
| 926 | // The flag merging may lead to some register uses no longer using the |
| 927 | // <undef> flag, add IMPLICIT_DEFs in the predecessors as necessary. |
| 928 | for (MachineBasicBlock *Pred : MBB->predecessors()) { |
Krzysztof Parzyszek | d407e55 | 2018-06-22 16:38:38 +0000 | [diff] [blame] | 929 | LiveRegs.clear(); |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 930 | LiveRegs.addLiveOuts(*Pred); |
| 931 | MachineBasicBlock::iterator InsertBefore = Pred->getFirstTerminator(); |
| 932 | for (unsigned Reg : NewLiveIns) { |
| 933 | if (!LiveRegs.available(*MRI, Reg)) |
| 934 | continue; |
| 935 | DebugLoc DL; |
| 936 | BuildMI(*Pred, InsertBefore, DL, TII->get(TargetOpcode::IMPLICIT_DEF), |
| 937 | Reg); |
| 938 | } |
| 939 | } |
| 940 | |
| 941 | MBB->clearLiveIns(); |
| 942 | addLiveIns(*MBB, NewLiveIns); |
| 943 | } |
| 944 | } |
| 945 | |
Kyle Butt | 9423d77 | 2016-07-11 21:37:03 +0000 | [diff] [blame] | 946 | // See if any of the blocks in MergePotentials (which all have SuccBB as a |
| 947 | // successor, or all have no successor if it is null) can be tail-merged. |
| 948 | // If there is a successor, any blocks in MergePotentials that are not |
| 949 | // tail-merged and are not immediately before Succ must have an unconditional |
| 950 | // branch to Succ added (but the predecessor/successor lists need no |
| 951 | // adjustment). The lone predecessor of Succ that falls through into Succ, |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 952 | // if any, is given in PredBB. |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 953 | // MinCommonTailLength - Except for the special cases below, tail-merge if |
| 954 | // there are at least this many instructions in common. |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 955 | bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB, |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 956 | MachineBasicBlock *PredBB, |
| 957 | unsigned MinCommonTailLength) { |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 958 | bool MadeChange = false; |
| 959 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 960 | LLVM_DEBUG( |
| 961 | dbgs() << "\nTryTailMergeBlocks: "; |
| 962 | for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) dbgs() |
| 963 | << printMBBReference(*MergePotentials[i].getBlock()) |
| 964 | << (i == e - 1 ? "" : ", "); |
| 965 | dbgs() << "\n"; if (SuccBB) { |
| 966 | dbgs() << " with successor " << printMBBReference(*SuccBB) << '\n'; |
| 967 | if (PredBB) |
| 968 | dbgs() << " which has fall-through from " |
| 969 | << printMBBReference(*PredBB) << "\n"; |
| 970 | } dbgs() << "Looking for common tails of at least " |
| 971 | << MinCommonTailLength << " instruction" |
| 972 | << (MinCommonTailLength == 1 ? "" : "s") << '\n';); |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 973 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 974 | // Sort by hash value so that blocks with identical end sequences sort |
| 975 | // together. |
Benjamin Kramer | fbbc2cc3 | 2015-03-13 21:17:02 +0000 | [diff] [blame] | 976 | array_pod_sort(MergePotentials.begin(), MergePotentials.end()); |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 977 | |
| 978 | // Walk through equivalence sets looking for actual exact matches. |
| 979 | while (MergePotentials.size() > 1) { |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 980 | unsigned CurHash = MergePotentials.back().getHash(); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 981 | |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 982 | // Build SameTails, identifying the set of blocks with this hash code |
| 983 | // and with the maximum number of instructions in common. |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 984 | unsigned maxCommonTailLength = ComputeSameTails(CurHash, |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 985 | MinCommonTailLength, |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 986 | SuccBB, PredBB); |
Dale Johannesen | 7aea832 | 2007-05-23 21:07:20 +0000 | [diff] [blame] | 987 | |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 988 | // If we didn't find any pair that has at least MinCommonTailLength |
Dale Johannesen | 6ae83fa | 2008-05-09 21:24:35 +0000 | [diff] [blame] | 989 | // instructions in common, remove all blocks with this hash code and retry. |
| 990 | if (SameTails.empty()) { |
Dale Johannesen | 6b8583c | 2008-05-09 23:28:24 +0000 | [diff] [blame] | 991 | RemoveBlocksWithHash(CurHash, SuccBB, PredBB); |
Dale Johannesen | 7aea832 | 2007-05-23 21:07:20 +0000 | [diff] [blame] | 992 | continue; |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 993 | } |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 994 | |
Dale Johannesen | 6ae83fa | 2008-05-09 21:24:35 +0000 | [diff] [blame] | 995 | // If one of the blocks is the entire common tail (and not the entry |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 996 | // block, which we can't jump to), we can treat all blocks with this same |
| 997 | // tail at once. Use PredBB if that is one of the possibilities, as that |
| 998 | // will not introduce any extra branches. |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 999 | MachineBasicBlock *EntryBB = |
| 1000 | &MergePotentials.front().getBlock()->getParent()->front(); |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 1001 | unsigned commonTailIndex = SameTails.size(); |
Dan Gohman | ad6af45 | 2009-11-12 00:39:10 +0000 | [diff] [blame] | 1002 | // If there are two blocks, check to see if one can be made to fall through |
| 1003 | // into the other. |
| 1004 | if (SameTails.size() == 2 && |
| 1005 | SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) && |
| 1006 | SameTails[1].tailIsWholeBlock()) |
| 1007 | commonTailIndex = 1; |
| 1008 | else if (SameTails.size() == 2 && |
| 1009 | SameTails[1].getBlock()->isLayoutSuccessor( |
| 1010 | SameTails[0].getBlock()) && |
| 1011 | SameTails[0].tailIsWholeBlock()) |
| 1012 | commonTailIndex = 0; |
| 1013 | else { |
| 1014 | // Otherwise just pick one, favoring the fall-through predecessor if |
| 1015 | // there is one. |
| 1016 | for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { |
| 1017 | MachineBasicBlock *MBB = SameTails[i].getBlock(); |
| 1018 | if (MBB == EntryBB && SameTails[i].tailIsWholeBlock()) |
| 1019 | continue; |
| 1020 | if (MBB == PredBB) { |
| 1021 | commonTailIndex = i; |
| 1022 | break; |
| 1023 | } |
| 1024 | if (SameTails[i].tailIsWholeBlock()) |
| 1025 | commonTailIndex = i; |
Dale Johannesen | 6ae83fa | 2008-05-09 21:24:35 +0000 | [diff] [blame] | 1026 | } |
Dale Johannesen | 6ae83fa | 2008-05-09 21:24:35 +0000 | [diff] [blame] | 1027 | } |
Dale Johannesen | a5a2117 | 2007-06-01 23:02:45 +0000 | [diff] [blame] | 1028 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1029 | if (commonTailIndex == SameTails.size() || |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 1030 | (SameTails[commonTailIndex].getBlock() == PredBB && |
| 1031 | !SameTails[commonTailIndex].tailIsWholeBlock())) { |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1032 | // None of the blocks consist entirely of the common tail. |
| 1033 | // Split a block so that one does. |
Andrew Trick | f7b5e01 | 2013-06-24 01:55:01 +0000 | [diff] [blame] | 1034 | if (!CreateCommonTailOnlyBlock(PredBB, SuccBB, |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 1035 | maxCommonTailLength, commonTailIndex)) { |
| 1036 | RemoveBlocksWithHash(CurHash, SuccBB, PredBB); |
| 1037 | continue; |
| 1038 | } |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 1039 | } |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1040 | |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 1041 | MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 1042 | |
Marianne Mailhot-Sarrasin | 578acc5 | 2016-03-10 21:54:25 +0000 | [diff] [blame] | 1043 | // Recompute common tail MBB's edge weights and block frequency. |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 1044 | setCommonTailEdgeWeights(*MBB); |
| 1045 | |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 1046 | // Merge debug locations, MMOs and undef flags across identical instructions |
| 1047 | // for common tail. |
| 1048 | mergeCommonTails(commonTailIndex); |
Robert Lougher | 72c8379 | 2016-10-26 17:01:47 +0000 | [diff] [blame] | 1049 | |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1050 | // MBB is common tail. Adjust all other BB's to jump to this one. |
| 1051 | // Traversal must be forwards so erases work. |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1052 | LLVM_DEBUG(dbgs() << "\nUsing common tail in " << printMBBReference(*MBB) |
| 1053 | << " for "); |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1054 | for (unsigned int i=0, e = SameTails.size(); i != e; ++i) { |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1055 | if (commonTailIndex == i) |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1056 | continue; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1057 | LLVM_DEBUG(dbgs() << printMBBReference(*SameTails[i].getBlock()) |
| 1058 | << (i == e - 1 ? "" : ", ")); |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1059 | // Hack the end off BB i, making it jump to BB commonTailIndex instead. |
Matthias Braun | 109c6e0 | 2017-09-06 20:45:24 +0000 | [diff] [blame] | 1060 | replaceTailWithBranchTo(SameTails[i].getTailStartPos(), *MBB); |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1061 | // BB i is no longer a predecessor of SuccBB; remove it from the worklist. |
Dan Gohman | ffe644e | 2009-11-11 21:57:02 +0000 | [diff] [blame] | 1062 | MergePotentials.erase(SameTails[i].getMPIter()); |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1063 | } |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1064 | LLVM_DEBUG(dbgs() << "\n"); |
Dale Johannesen | 51b2b9e | 2008-05-12 20:33:57 +0000 | [diff] [blame] | 1065 | // We leave commonTailIndex in the worklist in case there are other blocks |
| 1066 | // that match it with a smaller number of instructions. |
Chris Lattner | 1d08d83 | 2006-11-01 01:16:12 +0000 | [diff] [blame] | 1067 | MadeChange = true; |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1068 | } |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1069 | return MadeChange; |
| 1070 | } |
| 1071 | |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1072 | bool BranchFolder::TailMergeBlocks(MachineFunction &MF) { |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1073 | bool MadeChange = false; |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1074 | if (!EnableTailMerge) return MadeChange; |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 1075 | |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1076 | // First find blocks with no successors. |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 1077 | // Block placement does not create new tail merging opportunities for these |
| 1078 | // blocks. |
| 1079 | if (!AfterBlockPlacement) { |
| 1080 | MergePotentials.clear(); |
| 1081 | for (MachineBasicBlock &MBB : MF) { |
| 1082 | if (MergePotentials.size() == TailMergeThreshold) |
| 1083 | break; |
| 1084 | if (!TriedMerging.count(&MBB) && MBB.succ_empty()) |
| 1085 | MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(MBB), &MBB)); |
| 1086 | } |
| 1087 | |
| 1088 | // If this is a large problem, avoid visiting the same basic blocks |
| 1089 | // multiple times. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1090 | if (MergePotentials.size() == TailMergeThreshold) |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 1091 | for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) |
| 1092 | TriedMerging.insert(MergePotentials[i].getBlock()); |
| 1093 | |
| 1094 | // See if we can do any tail merging on those. |
| 1095 | if (MergePotentials.size() >= 2) |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 1096 | MadeChange |= TryTailMergeBlocks(nullptr, nullptr, MinCommonTailLength); |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1097 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1098 | |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 1099 | // Look at blocks (IBB) with multiple predecessors (PBB). |
| 1100 | // We change each predecessor to a canonical form, by |
| 1101 | // (1) temporarily removing any unconditional branch from the predecessor |
| 1102 | // to IBB, and |
| 1103 | // (2) alter conditional branches so they branch to the other block |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1104 | // not IBB; this may require adding back an unconditional branch to IBB |
Dale Johannesen | 76b38fc | 2007-05-10 01:01:49 +0000 | [diff] [blame] | 1105 | // later, where there wasn't one coming in. E.g. |
| 1106 | // Bcc IBB |
| 1107 | // fallthrough to QBB |
| 1108 | // here becomes |
| 1109 | // Bncc QBB |
| 1110 | // with a conceptual B to IBB after that, which never actually exists. |
| 1111 | // With those changes, we see whether the predecessors' tails match, |
| 1112 | // and merge them if so. We change things out of canonical form and |
| 1113 | // back to the way they were later in the process. (OptimizeBranches |
| 1114 | // would undo some of this, but we can't use it, because we'd get into |
| 1115 | // a compile-time infinite loop repeatedly doing and undoing the same |
| 1116 | // transformations.) |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1117 | |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 1118 | for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end(); |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1119 | I != E; ++I) { |
Bill Wendling | dbb4e57 | 2012-05-23 22:12:50 +0000 | [diff] [blame] | 1120 | if (I->pred_size() < 2) continue; |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1121 | SmallPtrSet<MachineBasicBlock *, 8> UniquePreds; |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1122 | MachineBasicBlock *IBB = &*I; |
| 1123 | MachineBasicBlock *PredBB = &*std::prev(I); |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1124 | MergePotentials.clear(); |
Haicheng Wu | 881b0b2 | 2016-08-12 23:13:38 +0000 | [diff] [blame] | 1125 | MachineLoop *ML; |
| 1126 | |
| 1127 | // Bail if merging after placement and IBB is the loop header because |
| 1128 | // -- If merging predecessors that belong to the same loop as IBB, the |
| 1129 | // common tail of merged predecessors may become the loop top if block |
| 1130 | // placement is called again and the predecessors may branch to this common |
| 1131 | // tail and require more branches. This can be relaxed if |
| 1132 | // MachineBlockPlacement::findBestLoopTop is more flexible. |
| 1133 | // --If merging predecessors that do not belong to the same loop as IBB, the |
| 1134 | // loop info of IBB's loop and the other loops may be affected. Calling the |
| 1135 | // block placement again may make big change to the layout and eliminate the |
| 1136 | // reason to do tail merging here. |
| 1137 | if (AfterBlockPlacement && MLI) { |
| 1138 | ML = MLI->getLoopFor(IBB); |
| 1139 | if (ML && IBB == ML->getHeader()) |
| 1140 | continue; |
| 1141 | } |
| 1142 | |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1143 | for (MachineBasicBlock *PBB : I->predecessors()) { |
| 1144 | if (MergePotentials.size() == TailMergeThreshold) |
| 1145 | break; |
| 1146 | |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1147 | if (TriedMerging.count(PBB)) |
| 1148 | continue; |
| 1149 | |
| 1150 | // Skip blocks that loop to themselves, can't tail merge these. |
| 1151 | if (PBB == IBB) |
| 1152 | continue; |
| 1153 | |
| 1154 | // Visit each predecessor only once. |
David Blaikie | 5401ba7 | 2014-11-19 07:49:26 +0000 | [diff] [blame] | 1155 | if (!UniquePreds.insert(PBB).second) |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1156 | continue; |
| 1157 | |
| 1158 | // Skip blocks which may jump to a landing pad. Can't tail merge these. |
Reid Kleckner | 7ad3e0e | 2015-09-17 17:19:40 +0000 | [diff] [blame] | 1159 | if (PBB->hasEHPadSuccessor()) |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1160 | continue; |
| 1161 | |
Haicheng Wu | 881b0b2 | 2016-08-12 23:13:38 +0000 | [diff] [blame] | 1162 | // After block placement, only consider predecessors that belong to the |
| 1163 | // same loop as IBB. The reason is the same as above when skipping loop |
| 1164 | // header. |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 1165 | if (AfterBlockPlacement && MLI) |
Haicheng Wu | 881b0b2 | 2016-08-12 23:13:38 +0000 | [diff] [blame] | 1166 | if (ML != MLI->getLoopFor(PBB)) |
| 1167 | continue; |
Haicheng Wu | c4f2258 | 2016-06-09 15:24:29 +0000 | [diff] [blame] | 1168 | |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1169 | MachineBasicBlock *TBB = nullptr, *FBB = nullptr; |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1170 | SmallVector<MachineOperand, 4> Cond; |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1171 | if (!TII->analyzeBranch(*PBB, TBB, FBB, Cond, true)) { |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1172 | // Failing case: IBB is the target of a cbr, and we cannot reverse the |
| 1173 | // branch. |
| 1174 | SmallVector<MachineOperand, 4> NewCond(Cond); |
| 1175 | if (!Cond.empty() && TBB == IBB) { |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1176 | if (TII->reverseBranchCondition(NewCond)) |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1177 | continue; |
| 1178 | // This is the QBB case described above |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1179 | if (!FBB) { |
| 1180 | auto Next = ++PBB->getIterator(); |
| 1181 | if (Next != MF.end()) |
| 1182 | FBB = &*Next; |
| 1183 | } |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1184 | } |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1185 | |
| 1186 | // Failing case: the only way IBB can be reached from PBB is via |
| 1187 | // exception handling. Happens for landing pads. Would be nice to have |
| 1188 | // a bit in the edge so we didn't have to do all this. |
Reid Kleckner | c0e64ad | 2015-08-27 23:27:47 +0000 | [diff] [blame] | 1189 | if (IBB->isEHPad()) { |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1190 | MachineFunction::iterator IP = ++PBB->getIterator(); |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1191 | MachineBasicBlock *PredNextBB = nullptr; |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1192 | if (IP != MF.end()) |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1193 | PredNextBB = &*IP; |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1194 | if (!TBB) { |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1195 | if (IBB != PredNextBB) // fallthrough |
| 1196 | continue; |
| 1197 | } else if (FBB) { |
| 1198 | if (TBB != IBB && FBB != IBB) // cbr then ubr |
| 1199 | continue; |
| 1200 | } else if (Cond.empty()) { |
| 1201 | if (TBB != IBB) // ubr |
| 1202 | continue; |
| 1203 | } else { |
| 1204 | if (TBB != IBB && IBB != PredNextBB) // cbr |
| 1205 | continue; |
| 1206 | } |
| 1207 | } |
| 1208 | |
| 1209 | // Remove the unconditional branch at the end, if any. |
| 1210 | if (TBB && (Cond.empty() || FBB)) { |
Taewook Oh | f8bacbb | 2017-02-21 00:12:38 +0000 | [diff] [blame] | 1211 | DebugLoc dl = PBB->findBranchDebugLoc(); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1212 | TII->removeBranch(*PBB); |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1213 | if (!Cond.empty()) |
| 1214 | // reinsert conditional branch only, for now |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1215 | TII->insertBranch(*PBB, (TBB == IBB) ? FBB : TBB, nullptr, |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1216 | NewCond, dl); |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1217 | } |
| 1218 | |
Duncan P. N. Exon Smith | 7dd408d | 2016-02-27 19:48:01 +0000 | [diff] [blame] | 1219 | MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(*PBB), PBB)); |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1220 | } |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1221 | } |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1222 | |
| 1223 | // If this is a large problem, avoid visiting the same basic blocks multiple |
| 1224 | // times. |
| 1225 | if (MergePotentials.size() == TailMergeThreshold) |
| 1226 | for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) |
| 1227 | TriedMerging.insert(MergePotentials[i].getBlock()); |
| 1228 | |
| 1229 | if (MergePotentials.size() >= 2) |
Kyle Butt | b1ee91e | 2016-08-18 18:57:29 +0000 | [diff] [blame] | 1230 | MadeChange |= TryTailMergeBlocks(IBB, PredBB, MinCommonTailLength); |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1231 | |
| 1232 | // Reinsert an unconditional branch if needed. The 1 below can occur as a |
| 1233 | // result of removing blocks in TryTailMergeBlocks. |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1234 | PredBB = &*std::prev(I); // this may have been changed in TryTailMergeBlocks |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1235 | if (MergePotentials.size() == 1 && |
| 1236 | MergePotentials.begin()->getBlock() != PredBB) |
| 1237 | FixTail(MergePotentials.begin()->getBlock(), IBB, TII); |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1238 | } |
Bill Wendling | 20350db | 2012-05-23 22:09:50 +0000 | [diff] [blame] | 1239 | |
Dale Johannesen | 7d33b4c | 2007-05-07 20:57:21 +0000 | [diff] [blame] | 1240 | return MadeChange; |
| 1241 | } |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1242 | |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 1243 | void BranchFolder::setCommonTailEdgeWeights(MachineBasicBlock &TailMBB) { |
| 1244 | SmallVector<BlockFrequency, 2> EdgeFreqLs(TailMBB.succ_size()); |
| 1245 | BlockFrequency AccumulatedMBBFreq; |
| 1246 | |
| 1247 | // Aggregate edge frequency of successor edge j: |
| 1248 | // edgeFreq(j) = sum (freq(bb) * edgeProb(bb, j)), |
| 1249 | // where bb is a basic block that is in SameTails. |
| 1250 | for (const auto &Src : SameTails) { |
| 1251 | const MachineBasicBlock *SrcMBB = Src.getBlock(); |
| 1252 | BlockFrequency BlockFreq = MBBFreqInfo.getBlockFreq(SrcMBB); |
| 1253 | AccumulatedMBBFreq += BlockFreq; |
| 1254 | |
| 1255 | // It is not necessary to recompute edge weights if TailBB has less than two |
| 1256 | // successors. |
| 1257 | if (TailMBB.succ_size() <= 1) |
| 1258 | continue; |
| 1259 | |
| 1260 | auto EdgeFreq = EdgeFreqLs.begin(); |
| 1261 | |
| 1262 | for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end(); |
| 1263 | SuccI != SuccE; ++SuccI, ++EdgeFreq) |
| 1264 | *EdgeFreq += BlockFreq * MBPI.getEdgeProbability(SrcMBB, *SuccI); |
| 1265 | } |
| 1266 | |
| 1267 | MBBFreqInfo.setBlockFreq(&TailMBB, AccumulatedMBBFreq); |
| 1268 | |
| 1269 | if (TailMBB.succ_size() <= 1) |
| 1270 | return; |
| 1271 | |
Cong Hou | 5155021 | 2015-12-01 05:29:22 +0000 | [diff] [blame] | 1272 | auto SumEdgeFreq = |
| 1273 | std::accumulate(EdgeFreqLs.begin(), EdgeFreqLs.end(), BlockFrequency(0)) |
| 1274 | .getFrequency(); |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 1275 | auto EdgeFreq = EdgeFreqLs.begin(); |
| 1276 | |
Cong Hou | 5155021 | 2015-12-01 05:29:22 +0000 | [diff] [blame] | 1277 | if (SumEdgeFreq > 0) { |
| 1278 | for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end(); |
| 1279 | SuccI != SuccE; ++SuccI, ++EdgeFreq) { |
| 1280 | auto Prob = BranchProbability::getBranchProbability( |
| 1281 | EdgeFreq->getFrequency(), SumEdgeFreq); |
| 1282 | TailMBB.setSuccProbability(SuccI, Prob); |
| 1283 | } |
| 1284 | } |
Akira Hatanaka | 70b5605 | 2014-08-07 19:30:13 +0000 | [diff] [blame] | 1285 | } |
| 1286 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1287 | //===----------------------------------------------------------------------===// |
| 1288 | // Branch Optimization |
| 1289 | //===----------------------------------------------------------------------===// |
| 1290 | |
| 1291 | bool BranchFolder::OptimizeBranches(MachineFunction &MF) { |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1292 | bool MadeChange = false; |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1293 | |
Dale Johannesen | 6b896ce | 2007-02-17 00:44:34 +0000 | [diff] [blame] | 1294 | // Make sure blocks are numbered in order |
| 1295 | MF.RenumberBlocks(); |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 1296 | // Renumbering blocks alters EH scope membership, recalculate it. |
| 1297 | EHScopeMembership = getEHScopeMembership(MF); |
Dale Johannesen | 6b896ce | 2007-02-17 00:44:34 +0000 | [diff] [blame] | 1298 | |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 1299 | for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end(); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1300 | I != E; ) { |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1301 | MachineBasicBlock *MBB = &*I++; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1302 | MadeChange |= OptimizeBlock(MBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1303 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1304 | // If it is dead, remove it. |
Jim Laskey | 033c971 | 2007-02-22 16:39:03 +0000 | [diff] [blame] | 1305 | if (MBB->pred_empty()) { |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1306 | RemoveDeadBlock(MBB); |
| 1307 | MadeChange = true; |
| 1308 | ++NumDeadBlocks; |
| 1309 | } |
| 1310 | } |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 1311 | |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1312 | return MadeChange; |
| 1313 | } |
| 1314 | |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 1315 | // Blocks should be considered empty if they contain only debug info; |
| 1316 | // else the debug info would affect codegen. |
| 1317 | static bool IsEmptyBlock(MachineBasicBlock *MBB) { |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1318 | return MBB->getFirstNonDebugInstr() == MBB->end(); |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 1319 | } |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1320 | |
Dale Johannesen | 2cd9ffe | 2010-03-10 19:57:56 +0000 | [diff] [blame] | 1321 | // Blocks with only debug info and branches should be considered the same |
| 1322 | // as blocks with only branches. |
| 1323 | static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) { |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1324 | MachineBasicBlock::iterator I = MBB->getFirstNonDebugInstr(); |
| 1325 | assert(I != MBB->end() && "empty block!"); |
| 1326 | return I->isBranch(); |
Dale Johannesen | 2cd9ffe | 2010-03-10 19:57:56 +0000 | [diff] [blame] | 1327 | } |
| 1328 | |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1329 | /// IsBetterFallthrough - Return true if it would be clearly better to |
| 1330 | /// fall-through to MBB1 than to fall through into MBB2. This has to return |
| 1331 | /// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will |
| 1332 | /// result in infinite loops. |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1333 | static bool IsBetterFallthrough(MachineBasicBlock *MBB1, |
Chris Lattner | 6924430 | 2008-01-07 01:56:04 +0000 | [diff] [blame] | 1334 | MachineBasicBlock *MBB2) { |
Chris Lattner | 154e104 | 2006-11-18 21:30:35 +0000 | [diff] [blame] | 1335 | // Right now, we use a simple heuristic. If MBB2 ends with a call, and |
| 1336 | // MBB1 doesn't, we prefer to fall through into MBB1. This allows us to |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1337 | // optimize branches that branch to either a return block or an assert block |
| 1338 | // into a fallthrough to the return. |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1339 | MachineBasicBlock::iterator MBB1I = MBB1->getLastNonDebugInstr(); |
| 1340 | MachineBasicBlock::iterator MBB2I = MBB2->getLastNonDebugInstr(); |
| 1341 | if (MBB1I == MBB1->end() || MBB2I == MBB2->end()) |
| 1342 | return false; |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1343 | |
Christopher Lamb | 11a4f64 | 2007-12-10 07:24:06 +0000 | [diff] [blame] | 1344 | // If there is a clear successor ordering we make sure that one block |
| 1345 | // will fall through to the next |
| 1346 | if (MBB1->isSuccessor(MBB2)) return true; |
| 1347 | if (MBB2->isSuccessor(MBB1)) return false; |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1348 | |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 1349 | return MBB2I->isCall() && !MBB1I->isCall(); |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1350 | } |
| 1351 | |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1352 | /// getBranchDebugLoc - Find and return, if any, the DebugLoc of the branch |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1353 | /// instructions on the block. |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1354 | static DebugLoc getBranchDebugLoc(MachineBasicBlock &MBB) { |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1355 | MachineBasicBlock::iterator I = MBB.getLastNonDebugInstr(); |
| 1356 | if (I != MBB.end() && I->isBranch()) |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1357 | return I->getDebugLoc(); |
| 1358 | return DebugLoc(); |
| 1359 | } |
| 1360 | |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1361 | static void copyDebugInfoToPredecessor(const TargetInstrInfo *TII, |
| 1362 | MachineBasicBlock &MBB, |
| 1363 | MachineBasicBlock &PredMBB) { |
| 1364 | auto InsertBefore = PredMBB.getFirstTerminator(); |
| 1365 | for (MachineInstr &MI : MBB.instrs()) |
Hsiangkai Wang | 3c67822 | 2018-11-30 08:07:29 +0000 | [diff] [blame] | 1366 | if (MI.isDebugInstr()) { |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1367 | TII->duplicate(PredMBB, InsertBefore, MI); |
Hsiangkai Wang | 3c67822 | 2018-11-30 08:07:29 +0000 | [diff] [blame] | 1368 | LLVM_DEBUG(dbgs() << "Copied debug entity from empty block to pred: " |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1369 | << MI); |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1370 | } |
| 1371 | } |
| 1372 | |
| 1373 | static void copyDebugInfoToSuccessor(const TargetInstrInfo *TII, |
| 1374 | MachineBasicBlock &MBB, |
| 1375 | MachineBasicBlock &SuccMBB) { |
| 1376 | auto InsertBefore = SuccMBB.SkipPHIsAndLabels(SuccMBB.begin()); |
| 1377 | for (MachineInstr &MI : MBB.instrs()) |
Hsiangkai Wang | 3c67822 | 2018-11-30 08:07:29 +0000 | [diff] [blame] | 1378 | if (MI.isDebugInstr()) { |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1379 | TII->duplicate(SuccMBB, InsertBefore, MI); |
Hsiangkai Wang | 3c67822 | 2018-11-30 08:07:29 +0000 | [diff] [blame] | 1380 | LLVM_DEBUG(dbgs() << "Copied debug entity from empty block to succ: " |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1381 | << MI); |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1382 | } |
| 1383 | } |
| 1384 | |
| 1385 | // Try to salvage DBG_VALUE instructions from an otherwise empty block. If such |
| 1386 | // a basic block is removed we would lose the debug information unless we have |
| 1387 | // copied the information to a predecessor/successor. |
| 1388 | // |
| 1389 | // TODO: This function only handles some simple cases. An alternative would be |
| 1390 | // to run a heavier analysis, such as the LiveDebugValues pass, before we do |
| 1391 | // branch folding. |
| 1392 | static void salvageDebugInfoFromEmptyBlock(const TargetInstrInfo *TII, |
| 1393 | MachineBasicBlock &MBB) { |
| 1394 | assert(IsEmptyBlock(&MBB) && "Expected an empty block (except debug info)."); |
| 1395 | // If this MBB is the only predecessor of a successor it is legal to copy |
| 1396 | // DBG_VALUE instructions to the beginning of the successor. |
| 1397 | for (MachineBasicBlock *SuccBB : MBB.successors()) |
| 1398 | if (SuccBB->pred_size() == 1) |
| 1399 | copyDebugInfoToSuccessor(TII, MBB, *SuccBB); |
| 1400 | // If this MBB is the only successor of a predecessor it is legal to copy the |
| 1401 | // DBG_VALUE instructions to the end of the predecessor (just before the |
| 1402 | // terminators, assuming that the terminator isn't affecting the DBG_VALUE). |
| 1403 | for (MachineBasicBlock *PredBB : MBB.predecessors()) |
| 1404 | if (PredBB->succ_size() == 1) |
| 1405 | copyDebugInfoToPredecessor(TII, MBB, *PredBB); |
| 1406 | } |
| 1407 | |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1408 | bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { |
| 1409 | bool MadeChange = false; |
Dan Gohman | d194498 | 2009-11-11 18:18:34 +0000 | [diff] [blame] | 1410 | MachineFunction &MF = *MBB->getParent(); |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1411 | ReoptimizeBlock: |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1412 | |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1413 | MachineFunction::iterator FallThrough = MBB->getIterator(); |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1414 | ++FallThrough; |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1415 | |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 1416 | // Make sure MBB and FallThrough belong to the same EH scope. |
| 1417 | bool SameEHScope = true; |
| 1418 | if (!EHScopeMembership.empty() && FallThrough != MF.end()) { |
| 1419 | auto MBBEHScope = EHScopeMembership.find(MBB); |
| 1420 | assert(MBBEHScope != EHScopeMembership.end()); |
| 1421 | auto FallThroughEHScope = EHScopeMembership.find(&*FallThrough); |
| 1422 | assert(FallThroughEHScope != EHScopeMembership.end()); |
| 1423 | SameEHScope = MBBEHScope->second == FallThroughEHScope->second; |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 1424 | } |
| 1425 | |
Chris Lattner | eb15eee | 2006-10-13 20:43:10 +0000 | [diff] [blame] | 1426 | // If this block is empty, make everyone use its fall-through, not the block |
Dale Johannesen | a52dd15 | 2007-05-31 21:54:00 +0000 | [diff] [blame] | 1427 | // explicitly. Landing pads should not do this since the landing-pad table |
Dan Gohman | ab91810 | 2009-10-30 02:13:27 +0000 | [diff] [blame] | 1428 | // points to this block. Blocks with their addresses taken shouldn't be |
| 1429 | // optimized away. |
David Majnemer | 492f1cf | 2015-10-04 02:22:52 +0000 | [diff] [blame] | 1430 | if (IsEmptyBlock(MBB) && !MBB->isEHPad() && !MBB->hasAddressTaken() && |
Heejin Ahn | 2522e34 | 2018-06-01 00:03:21 +0000 | [diff] [blame] | 1431 | SameEHScope) { |
Bjorn Pettersson | b0beac8 | 2018-04-30 14:37:46 +0000 | [diff] [blame] | 1432 | salvageDebugInfoFromEmptyBlock(TII, *MBB); |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1433 | // Dead block? Leave for cleanup later. |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1434 | if (MBB->pred_empty()) return MadeChange; |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1435 | |
Dan Gohman | d194498 | 2009-11-11 18:18:34 +0000 | [diff] [blame] | 1436 | if (FallThrough == MF.end()) { |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 1437 | // TODO: Simplify preds to not branch here if possible! |
Reid Kleckner | c0e64ad | 2015-08-27 23:27:47 +0000 | [diff] [blame] | 1438 | } else if (FallThrough->isEHPad()) { |
Pete Cooper | 1870668 | 2015-04-30 18:58:23 +0000 | [diff] [blame] | 1439 | // Don't rewrite to a landing pad fallthough. That could lead to the case |
| 1440 | // where a BB jumps to more than one landing pad. |
| 1441 | // TODO: Is it ever worth rewriting predecessors which don't already |
| 1442 | // jump to a landing pad, and so can safely jump to the fallthrough? |
Kyle Butt | 546c8eb | 2016-06-24 18:16:36 +0000 | [diff] [blame] | 1443 | } else if (MBB->isSuccessor(&*FallThrough)) { |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 1444 | // Rewrite all predecessors of the old block to go to the fallthrough |
| 1445 | // instead. |
Jim Laskey | 033c971 | 2007-02-22 16:39:03 +0000 | [diff] [blame] | 1446 | while (!MBB->pred_empty()) { |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1447 | MachineBasicBlock *Pred = *(MBB->pred_end()-1); |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1448 | Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough); |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1449 | } |
Chris Lattner | c50ffcb | 2006-10-17 17:13:52 +0000 | [diff] [blame] | 1450 | // If MBB was the target of a jump table, update jump tables to go to the |
| 1451 | // fallthrough instead. |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 1452 | if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1453 | MJTI->ReplaceMBBInJumpTables(MBB, &*FallThrough); |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1454 | MadeChange = true; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 1455 | } |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1456 | return MadeChange; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 1457 | } |
| 1458 | |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1459 | // Check to see if we can simplify the terminator of the block before this |
| 1460 | // one. |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 1461 | MachineBasicBlock &PrevBB = *std::prev(MachineFunction::iterator(MBB)); |
Chris Lattner | ffddf6b | 2006-10-17 18:16:40 +0000 | [diff] [blame] | 1462 | |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1463 | MachineBasicBlock *PriorTBB = nullptr, *PriorFBB = nullptr; |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 1464 | SmallVector<MachineOperand, 4> PriorCond; |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1465 | bool PriorUnAnalyzable = |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1466 | TII->analyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true); |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1467 | if (!PriorUnAnalyzable) { |
| 1468 | // If the CFG for the prior block has extra edges, remove them. |
Evan Cheng | 2bdb7d0 | 2007-06-18 22:43:58 +0000 | [diff] [blame] | 1469 | MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB, |
| 1470 | !PriorCond.empty()); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1471 | |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1472 | // If the previous branch is conditional and both conditions go to the same |
Chris Lattner | 2d47bd9 | 2006-10-21 05:43:30 +0000 | [diff] [blame] | 1473 | // destination, remove the branch, replacing it with an unconditional one or |
| 1474 | // a fall-through. |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1475 | if (PriorTBB && PriorTBB == PriorFBB) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1476 | DebugLoc dl = getBranchDebugLoc(PrevBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1477 | TII->removeBranch(PrevBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1478 | PriorCond.clear(); |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1479 | if (PriorTBB != MBB) |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1480 | TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl); |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1481 | MadeChange = true; |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1482 | ++NumBranchOpts; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1483 | goto ReoptimizeBlock; |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1484 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1485 | |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1486 | // If the previous block unconditionally falls through to this block and |
| 1487 | // this block has no other predecessors, move the contents of this block |
| 1488 | // into the prior block. This doesn't usually happen when SimplifyCFG |
Bob Wilson | 465c825 | 2009-11-17 17:40:31 +0000 | [diff] [blame] | 1489 | // has been used, but it can happen if tail merging splits a fall-through |
| 1490 | // predecessor of a block. |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1491 | // This has to check PrevBB->succ_size() because EH edges are ignored by |
| 1492 | // AnalyzeBranch. |
| 1493 | if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 && |
| 1494 | PrevBB.succ_size() == 1 && |
Reid Kleckner | c0e64ad | 2015-08-27 23:27:47 +0000 | [diff] [blame] | 1495 | !MBB->hasAddressTaken() && !MBB->isEHPad()) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1496 | LLVM_DEBUG(dbgs() << "\nMerging into block: " << PrevBB |
| 1497 | << "From MBB: " << *MBB); |
Devang Patel | 95ba669 | 2011-05-26 21:49:28 +0000 | [diff] [blame] | 1498 | // Remove redundant DBG_VALUEs first. |
Devang Patel | 785badb | 2011-05-26 21:47:59 +0000 | [diff] [blame] | 1499 | if (PrevBB.begin() != PrevBB.end()) { |
| 1500 | MachineBasicBlock::iterator PrevBBIter = PrevBB.end(); |
| 1501 | --PrevBBIter; |
| 1502 | MachineBasicBlock::iterator MBBIter = MBB->begin(); |
Andrew Trick | 1df91b0 | 2012-02-08 21:22:43 +0000 | [diff] [blame] | 1503 | // Check if DBG_VALUE at the end of PrevBB is identical to the |
Devang Patel | 95ba669 | 2011-05-26 21:49:28 +0000 | [diff] [blame] | 1504 | // DBG_VALUE at the beginning of MBB. |
Devang Patel | 785badb | 2011-05-26 21:47:59 +0000 | [diff] [blame] | 1505 | while (PrevBBIter != PrevBB.begin() && MBBIter != MBB->end() |
Shiva Chen | 24abe71 | 2018-05-09 02:42:00 +0000 | [diff] [blame] | 1506 | && PrevBBIter->isDebugInstr() && MBBIter->isDebugInstr()) { |
Duncan P. N. Exon Smith | 1d75c8d | 2016-02-27 20:01:33 +0000 | [diff] [blame] | 1507 | if (!MBBIter->isIdenticalTo(*PrevBBIter)) |
Devang Patel | 785badb | 2011-05-26 21:47:59 +0000 | [diff] [blame] | 1508 | break; |
Duncan P. N. Exon Smith | 88bff1c | 2016-02-27 20:27:44 +0000 | [diff] [blame] | 1509 | MachineInstr &DuplicateDbg = *MBBIter; |
Devang Patel | 785badb | 2011-05-26 21:47:59 +0000 | [diff] [blame] | 1510 | ++MBBIter; -- PrevBBIter; |
Duncan P. N. Exon Smith | 88bff1c | 2016-02-27 20:27:44 +0000 | [diff] [blame] | 1511 | DuplicateDbg.eraseFromParent(); |
Devang Patel | 785badb | 2011-05-26 21:47:59 +0000 | [diff] [blame] | 1512 | } |
| 1513 | } |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1514 | PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end()); |
Chad Rosier | 90f2004 | 2012-02-22 17:25:00 +0000 | [diff] [blame] | 1515 | PrevBB.removeSuccessor(PrevBB.succ_begin()); |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1516 | assert(PrevBB.succ_empty()); |
| 1517 | PrevBB.transferSuccessors(MBB); |
| 1518 | MadeChange = true; |
| 1519 | return MadeChange; |
| 1520 | } |
Bob Wilson | 3cbc312 | 2009-11-16 17:56:13 +0000 | [diff] [blame] | 1521 | |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1522 | // If the previous branch *only* branches to *this* block (conditional or |
| 1523 | // not) remove the branch. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1524 | if (PriorTBB == MBB && !PriorFBB) { |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1525 | TII->removeBranch(PrevBB); |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1526 | MadeChange = true; |
Chris Lattner | 1214305 | 2006-10-21 00:47:49 +0000 | [diff] [blame] | 1527 | ++NumBranchOpts; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1528 | goto ReoptimizeBlock; |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1529 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1530 | |
Chris Lattner | 2d47bd9 | 2006-10-21 05:43:30 +0000 | [diff] [blame] | 1531 | // If the prior block branches somewhere else on the condition and here if |
| 1532 | // the condition is false, remove the uncond second branch. |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1533 | if (PriorFBB == MBB) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1534 | DebugLoc dl = getBranchDebugLoc(PrevBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1535 | TII->removeBranch(PrevBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1536 | TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl); |
Chris Lattner | 2d47bd9 | 2006-10-21 05:43:30 +0000 | [diff] [blame] | 1537 | MadeChange = true; |
| 1538 | ++NumBranchOpts; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1539 | goto ReoptimizeBlock; |
Chris Lattner | 2d47bd9 | 2006-10-21 05:43:30 +0000 | [diff] [blame] | 1540 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1541 | |
Chris Lattner | a2d7995 | 2006-10-21 05:54:00 +0000 | [diff] [blame] | 1542 | // If the prior block branches here on true and somewhere else on false, and |
| 1543 | // if the branch condition is reversible, reverse the branch to create a |
| 1544 | // fall-through. |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1545 | if (PriorTBB == MBB) { |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 1546 | SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1547 | if (!TII->reverseBranchCondition(NewPriorCond)) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1548 | DebugLoc dl = getBranchDebugLoc(PrevBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1549 | TII->removeBranch(PrevBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1550 | TII->insertBranch(PrevBB, PriorFBB, nullptr, NewPriorCond, dl); |
Chris Lattner | a2d7995 | 2006-10-21 05:54:00 +0000 | [diff] [blame] | 1551 | MadeChange = true; |
| 1552 | ++NumBranchOpts; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1553 | goto ReoptimizeBlock; |
Chris Lattner | a2d7995 | 2006-10-21 05:54:00 +0000 | [diff] [blame] | 1554 | } |
| 1555 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1556 | |
Dan Gohman | 6d31268 | 2009-10-22 00:03:58 +0000 | [diff] [blame] | 1557 | // If this block has no successors (e.g. it is a return block or ends with |
| 1558 | // a call to a no-return function like abort or __cxa_throw) and if the pred |
| 1559 | // falls through into this block, and if it would otherwise fall through |
| 1560 | // into the block after this, move this block to the end of the function. |
Chris Lattner | 154e104 | 2006-11-18 21:30:35 +0000 | [diff] [blame] | 1561 | // |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1562 | // We consider it more likely that execution will stay in the function (e.g. |
| 1563 | // due to loops) than it is to exit it. This asserts in loops etc, moving |
| 1564 | // the assert condition out of the loop body. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1565 | if (MBB->succ_empty() && !PriorCond.empty() && !PriorFBB && |
Chris Lattner | 154e104 | 2006-11-18 21:30:35 +0000 | [diff] [blame] | 1566 | MachineFunction::iterator(PriorTBB) == FallThrough && |
Bob Wilson | 15acadd | 2009-11-26 00:32:21 +0000 | [diff] [blame] | 1567 | !MBB->canFallThrough()) { |
Chris Lattner | f10a56a | 2006-11-18 21:56:39 +0000 | [diff] [blame] | 1568 | bool DoTransform = true; |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1569 | |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1570 | // We have to be careful that the succs of PredBB aren't both no-successor |
| 1571 | // blocks. If neither have successors and if PredBB is the second from |
| 1572 | // last block in the function, we'd just keep swapping the two blocks for |
| 1573 | // last. Only do the swap if one is clearly better to fall through than |
| 1574 | // the other. |
Dan Gohman | d194498 | 2009-11-11 18:18:34 +0000 | [diff] [blame] | 1575 | if (FallThrough == --MF.end() && |
Chris Lattner | 6924430 | 2008-01-07 01:56:04 +0000 | [diff] [blame] | 1576 | !IsBetterFallthrough(PriorTBB, MBB)) |
Chris Lattner | f10a56a | 2006-11-18 21:56:39 +0000 | [diff] [blame] | 1577 | DoTransform = false; |
| 1578 | |
Chris Lattner | f10a56a | 2006-11-18 21:56:39 +0000 | [diff] [blame] | 1579 | if (DoTransform) { |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1580 | // Reverse the branch so we will fall through on the previous true cond. |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 1581 | SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1582 | if (!TII->reverseBranchCondition(NewPriorCond)) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1583 | LLVM_DEBUG(dbgs() << "\nMoving MBB: " << *MBB |
| 1584 | << "To make fallthrough to: " << *PriorTBB << "\n"); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1585 | |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1586 | DebugLoc dl = getBranchDebugLoc(PrevBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1587 | TII->removeBranch(PrevBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1588 | TII->insertBranch(PrevBB, MBB, nullptr, NewPriorCond, dl); |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1589 | |
| 1590 | // Move this block to the end of the function. |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1591 | MBB->moveAfter(&MF.back()); |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1592 | MadeChange = true; |
| 1593 | ++NumBranchOpts; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1594 | return MadeChange; |
Chris Lattner | a7bef4a | 2006-11-18 20:47:54 +0000 | [diff] [blame] | 1595 | } |
| 1596 | } |
| 1597 | } |
Chris Lattner | 7821a8a | 2006-10-14 00:21:48 +0000 | [diff] [blame] | 1598 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1599 | |
Hans Wennborg | b6ae6ad | 2017-02-16 00:04:05 +0000 | [diff] [blame] | 1600 | if (!IsEmptyBlock(MBB) && MBB->pred_size() == 1 && |
Matthias Braun | d318139 | 2017-12-15 22:22:58 +0000 | [diff] [blame] | 1601 | MF.getFunction().optForSize()) { |
Hans Wennborg | b6ae6ad | 2017-02-16 00:04:05 +0000 | [diff] [blame] | 1602 | // Changing "Jcc foo; foo: jmp bar;" into "Jcc bar;" might change the branch |
| 1603 | // direction, thereby defeating careful block placement and regressing |
| 1604 | // performance. Therefore, only consider this for optsize functions. |
| 1605 | MachineInstr &TailCall = *MBB->getFirstNonDebugInstr(); |
| 1606 | if (TII->isUnconditionalTailCall(TailCall)) { |
| 1607 | MachineBasicBlock *Pred = *MBB->pred_begin(); |
| 1608 | MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; |
| 1609 | SmallVector<MachineOperand, 4> PredCond; |
| 1610 | bool PredAnalyzable = |
| 1611 | !TII->analyzeBranch(*Pred, PredTBB, PredFBB, PredCond, true); |
| 1612 | |
Reid Kleckner | 71a1ea8 | 2017-07-28 19:48:40 +0000 | [diff] [blame] | 1613 | if (PredAnalyzable && !PredCond.empty() && PredTBB == MBB && |
| 1614 | PredTBB != PredFBB) { |
Hans Wennborg | b6ae6ad | 2017-02-16 00:04:05 +0000 | [diff] [blame] | 1615 | // The predecessor has a conditional branch to this block which consists |
| 1616 | // of only a tail call. Try to fold the tail call into the conditional |
| 1617 | // branch. |
| 1618 | if (TII->canMakeTailCallConditional(PredCond, TailCall)) { |
| 1619 | // TODO: It would be nice if analyzeBranch() could provide a pointer |
Reid Kleckner | 71a1ea8 | 2017-07-28 19:48:40 +0000 | [diff] [blame] | 1620 | // to the branch instruction so replaceBranchWithTailCall() doesn't |
Hans Wennborg | b6ae6ad | 2017-02-16 00:04:05 +0000 | [diff] [blame] | 1621 | // have to search for it. |
| 1622 | TII->replaceBranchWithTailCall(*Pred, PredCond, TailCall); |
| 1623 | ++NumTailCalls; |
| 1624 | Pred->removeSuccessor(MBB); |
| 1625 | MadeChange = true; |
| 1626 | return MadeChange; |
| 1627 | } |
| 1628 | } |
| 1629 | // If the predecessor is falling through to this block, we could reverse |
| 1630 | // the branch condition and fold the tail call into that. However, after |
| 1631 | // that we might have to re-arrange the CFG to fall through to the other |
| 1632 | // block and there is a high risk of regressing code size rather than |
| 1633 | // improving it. |
| 1634 | } |
| 1635 | } |
| 1636 | |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1637 | // Analyze the branch in the current block. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1638 | MachineBasicBlock *CurTBB = nullptr, *CurFBB = nullptr; |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 1639 | SmallVector<MachineOperand, 4> CurCond; |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1640 | bool CurUnAnalyzable = |
| 1641 | TII->analyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true); |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1642 | if (!CurUnAnalyzable) { |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1643 | // If the CFG for the prior block has extra edges, remove them. |
Evan Cheng | 2bdb7d0 | 2007-06-18 22:43:58 +0000 | [diff] [blame] | 1644 | MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty()); |
Chris Lattner | eb15eee | 2006-10-13 20:43:10 +0000 | [diff] [blame] | 1645 | |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1646 | // If this is a two-way branch, and the FBB branches to this block, reverse |
Chris Lattner | 5d05695 | 2006-11-08 01:03:21 +0000 | [diff] [blame] | 1647 | // the condition so the single-basic-block loop is faster. Instead of: |
| 1648 | // Loop: xxx; jcc Out; jmp Loop |
| 1649 | // we want: |
| 1650 | // Loop: xxx; jncc Loop; jmp Out |
| 1651 | if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) { |
Owen Anderson | 44eb65c | 2008-08-14 22:49:33 +0000 | [diff] [blame] | 1652 | SmallVector<MachineOperand, 4> NewCond(CurCond); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1653 | if (!TII->reverseBranchCondition(NewCond)) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1654 | DebugLoc dl = getBranchDebugLoc(*MBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1655 | TII->removeBranch(*MBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1656 | TII->insertBranch(*MBB, CurFBB, CurTBB, NewCond, dl); |
Chris Lattner | 5d05695 | 2006-11-08 01:03:21 +0000 | [diff] [blame] | 1657 | MadeChange = true; |
| 1658 | ++NumBranchOpts; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1659 | goto ReoptimizeBlock; |
Chris Lattner | 5d05695 | 2006-11-08 01:03:21 +0000 | [diff] [blame] | 1660 | } |
| 1661 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1662 | |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1663 | // If this branch is the only thing in its block, see if we can forward |
| 1664 | // other blocks across it. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1665 | if (CurTBB && CurCond.empty() && !CurFBB && |
Dale Johannesen | 2cd9ffe | 2010-03-10 19:57:56 +0000 | [diff] [blame] | 1666 | IsBranchOnlyBlock(MBB) && CurTBB != MBB && |
Reid Kleckner | 758cf89 | 2015-11-11 23:09:31 +0000 | [diff] [blame] | 1667 | !MBB->hasAddressTaken() && !MBB->isEHPad()) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1668 | DebugLoc dl = getBranchDebugLoc(*MBB); |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1669 | // This block may contain just an unconditional branch. Because there can |
| 1670 | // be 'non-branch terminators' in the block, try removing the branch and |
| 1671 | // then seeing if the block is empty. |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1672 | TII->removeBranch(*MBB); |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 1673 | // If the only things remaining in the block are debug info, remove these |
| 1674 | // as well, so this will behave the same as an empty block in non-debug |
| 1675 | // mode. |
Benjamin Kramer | 336ead0 | 2015-06-23 14:47:29 +0000 | [diff] [blame] | 1676 | if (IsEmptyBlock(MBB)) { |
| 1677 | // Make the block empty, losing the debug info (we could probably |
| 1678 | // improve this in some cases.) |
| 1679 | MBB->erase(MBB->begin(), MBB->end()); |
Dale Johannesen | c5cf227 | 2010-03-10 05:45:47 +0000 | [diff] [blame] | 1680 | } |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1681 | // If this block is just an unconditional branch to CurTBB, we can |
| 1682 | // usually completely eliminate the block. The only case we cannot |
| 1683 | // completely eliminate the block is when the block before this one |
| 1684 | // falls through into MBB and we can't understand the prior block's branch |
| 1685 | // condition. |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1686 | if (MBB->empty()) { |
Dan Gohman | 864e2ef | 2009-12-05 00:44:40 +0000 | [diff] [blame] | 1687 | bool PredHasNoFallThrough = !PrevBB.canFallThrough(); |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1688 | if (PredHasNoFallThrough || !PriorUnAnalyzable || |
| 1689 | !PrevBB.isSuccessor(MBB)) { |
| 1690 | // If the prior block falls through into us, turn it into an |
| 1691 | // explicit branch to us to make updates simpler. |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1692 | if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) && |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1693 | PriorTBB != MBB && PriorFBB != MBB) { |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1694 | if (!PriorTBB) { |
| 1695 | assert(PriorCond.empty() && !PriorFBB && |
Chris Lattner | 6acfe12 | 2006-10-28 18:34:47 +0000 | [diff] [blame] | 1696 | "Bad branch analysis"); |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1697 | PriorTBB = MBB; |
| 1698 | } else { |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1699 | assert(!PriorFBB && "Machine CFG out of date!"); |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1700 | PriorFBB = MBB; |
| 1701 | } |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1702 | DebugLoc pdl = getBranchDebugLoc(PrevBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1703 | TII->removeBranch(PrevBB); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1704 | TII->insertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, pdl); |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1705 | } |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1706 | |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1707 | // Iterate through all the predecessors, revectoring each in-turn. |
David Greene | 8a46d34 | 2007-06-29 02:45:24 +0000 | [diff] [blame] | 1708 | size_t PI = 0; |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1709 | bool DidChange = false; |
| 1710 | bool HasBranchToSelf = false; |
David Greene | 8a46d34 | 2007-06-29 02:45:24 +0000 | [diff] [blame] | 1711 | while(PI != MBB->pred_size()) { |
| 1712 | MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI); |
| 1713 | if (PMBB == MBB) { |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1714 | // If this block has an uncond branch to itself, leave it. |
| 1715 | ++PI; |
| 1716 | HasBranchToSelf = true; |
| 1717 | } else { |
| 1718 | DidChange = true; |
David Greene | 8a46d34 | 2007-06-29 02:45:24 +0000 | [diff] [blame] | 1719 | PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB); |
Dale Johannesen | bf06f6a | 2009-05-11 21:54:13 +0000 | [diff] [blame] | 1720 | // If this change resulted in PMBB ending in a conditional |
| 1721 | // branch where both conditions go to the same destination, |
| 1722 | // change this to an unconditional branch (and fix the CFG). |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1723 | MachineBasicBlock *NewCurTBB = nullptr, *NewCurFBB = nullptr; |
Dale Johannesen | bf06f6a | 2009-05-11 21:54:13 +0000 | [diff] [blame] | 1724 | SmallVector<MachineOperand, 4> NewCurCond; |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1725 | bool NewCurUnAnalyzable = TII->analyzeBranch( |
| 1726 | *PMBB, NewCurTBB, NewCurFBB, NewCurCond, true); |
Dale Johannesen | bf06f6a | 2009-05-11 21:54:13 +0000 | [diff] [blame] | 1727 | if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) { |
Bill Wendling | 5b2749a | 2012-03-07 08:49:42 +0000 | [diff] [blame] | 1728 | DebugLoc pdl = getBranchDebugLoc(*PMBB); |
Matt Arsenault | 93e6e54 | 2016-09-14 20:43:16 +0000 | [diff] [blame] | 1729 | TII->removeBranch(*PMBB); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1730 | NewCurCond.clear(); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1731 | TII->insertBranch(*PMBB, NewCurTBB, nullptr, NewCurCond, pdl); |
Dale Johannesen | bf06f6a | 2009-05-11 21:54:13 +0000 | [diff] [blame] | 1732 | MadeChange = true; |
| 1733 | ++NumBranchOpts; |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1734 | PMBB->CorrectExtraCFGEdges(NewCurTBB, nullptr, false); |
Dale Johannesen | bf06f6a | 2009-05-11 21:54:13 +0000 | [diff] [blame] | 1735 | } |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1736 | } |
Chris Lattner | 4bc135e | 2006-10-21 06:11:43 +0000 | [diff] [blame] | 1737 | } |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1738 | |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1739 | // Change any jumptables to go to the new MBB. |
Chris Lattner | 071c62f | 2010-01-25 23:26:13 +0000 | [diff] [blame] | 1740 | if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) |
| 1741 | MJTI->ReplaceMBBInJumpTables(MBB, CurTBB); |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1742 | if (DidChange) { |
| 1743 | ++NumBranchOpts; |
| 1744 | MadeChange = true; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1745 | if (!HasBranchToSelf) return MadeChange; |
Chris Lattner | cf420cc | 2006-10-28 17:32:47 +0000 | [diff] [blame] | 1746 | } |
Chris Lattner | 4bc135e | 2006-10-21 06:11:43 +0000 | [diff] [blame] | 1747 | } |
Chris Lattner | eb15eee | 2006-10-13 20:43:10 +0000 | [diff] [blame] | 1748 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1749 | |
Chris Lattner | 386e290 | 2006-10-21 05:08:28 +0000 | [diff] [blame] | 1750 | // Add the branch back if the block is more than just an uncond branch. |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1751 | TII->insertBranch(*MBB, CurTBB, nullptr, CurCond, dl); |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 1752 | } |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1753 | } |
| 1754 | |
Bill Wendling | 43cf6c3 | 2009-12-15 00:39:24 +0000 | [diff] [blame] | 1755 | // If the prior block doesn't fall through into this block, and if this |
| 1756 | // block doesn't fall through into some other block, see if we can find a |
| 1757 | // place to move this block where a fall-through will happen. |
| 1758 | if (!PrevBB.canFallThrough()) { |
Bob Wilson | 56ea69c | 2009-11-17 17:06:18 +0000 | [diff] [blame] | 1759 | // Now we know that there was no fall-through into this block, check to |
| 1760 | // see if it has a fall-through into its successor. |
Bob Wilson | 15acadd | 2009-11-26 00:32:21 +0000 | [diff] [blame] | 1761 | bool CurFallsThru = MBB->canFallThrough(); |
Bob Wilson | 56ea69c | 2009-11-17 17:06:18 +0000 | [diff] [blame] | 1762 | |
Reid Kleckner | c0e64ad | 2015-08-27 23:27:47 +0000 | [diff] [blame] | 1763 | if (!MBB->isEHPad()) { |
Jim Laskey | 02b3f5e | 2007-02-21 22:42:20 +0000 | [diff] [blame] | 1764 | // Check all the predecessors of this block. If one of them has no fall |
| 1765 | // throughs, move this block right after it. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1766 | for (MachineBasicBlock *PredBB : MBB->predecessors()) { |
Jim Laskey | 02b3f5e | 2007-02-21 22:42:20 +0000 | [diff] [blame] | 1767 | // Analyze the branch at the end of the pred. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1768 | MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1769 | SmallVector<MachineOperand, 4> PredCond; |
Bill Wendling | 43cf6c3 | 2009-12-15 00:39:24 +0000 | [diff] [blame] | 1770 | if (PredBB != MBB && !PredBB->canFallThrough() && |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1771 | !TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) && |
| 1772 | (!CurFallsThru || !CurTBB || !CurFBB) && |
| 1773 | (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) { |
Bill Wendling | 43cf6c3 | 2009-12-15 00:39:24 +0000 | [diff] [blame] | 1774 | // If the current block doesn't fall through, just move it. |
| 1775 | // If the current block can fall through and does not end with a |
| 1776 | // conditional branch, we need to append an unconditional jump to |
| 1777 | // the (current) next block. To avoid a possible compile-time |
| 1778 | // infinite loop, move blocks only backward in this case. |
| 1779 | // Also, if there are already 2 branches here, we cannot add a third; |
| 1780 | // this means we have the case |
| 1781 | // Bcc next |
| 1782 | // B elsewhere |
| 1783 | // next: |
Jim Laskey | 02b3f5e | 2007-02-21 22:42:20 +0000 | [diff] [blame] | 1784 | if (CurFallsThru) { |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1785 | MachineBasicBlock *NextBB = &*std::next(MBB->getIterator()); |
Jim Laskey | 02b3f5e | 2007-02-21 22:42:20 +0000 | [diff] [blame] | 1786 | CurCond.clear(); |
Matt Arsenault | b1a710d | 2016-09-14 17:24:15 +0000 | [diff] [blame] | 1787 | TII->insertBranch(*MBB, NextBB, nullptr, CurCond, DebugLoc()); |
Jim Laskey | 02b3f5e | 2007-02-21 22:42:20 +0000 | [diff] [blame] | 1788 | } |
| 1789 | MBB->moveAfter(PredBB); |
| 1790 | MadeChange = true; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1791 | goto ReoptimizeBlock; |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1792 | } |
| 1793 | } |
Dale Johannesen | 6b896ce | 2007-02-17 00:44:34 +0000 | [diff] [blame] | 1794 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1795 | |
Dale Johannesen | 6b896ce | 2007-02-17 00:44:34 +0000 | [diff] [blame] | 1796 | if (!CurFallsThru) { |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1797 | // Check all successors to see if we can move this block before it. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1798 | for (MachineBasicBlock *SuccBB : MBB->successors()) { |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1799 | // Analyze the branch at the end of the block before the succ. |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1800 | MachineFunction::iterator SuccPrev = --SuccBB->getIterator(); |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1801 | |
Chris Lattner | 77edc4b | 2007-04-30 23:35:00 +0000 | [diff] [blame] | 1802 | // If this block doesn't already fall-through to that successor, and if |
| 1803 | // the succ doesn't already have a block that can fall through into it, |
| 1804 | // and if the successor isn't an EH destination, we can arrange for the |
| 1805 | // fallthrough to happen. |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1806 | if (SuccBB != MBB && &*SuccPrev != MBB && |
Bob Wilson | 15acadd | 2009-11-26 00:32:21 +0000 | [diff] [blame] | 1807 | !SuccPrev->canFallThrough() && !CurUnAnalyzable && |
Reid Kleckner | c0e64ad | 2015-08-27 23:27:47 +0000 | [diff] [blame] | 1808 | !SuccBB->isEHPad()) { |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1809 | MBB->moveBefore(SuccBB); |
| 1810 | MadeChange = true; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1811 | goto ReoptimizeBlock; |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1812 | } |
| 1813 | } |
Dan Gohman | 4e3f125 | 2009-11-11 18:38:14 +0000 | [diff] [blame] | 1814 | |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1815 | // Okay, there is no really great place to put this block. If, however, |
| 1816 | // the block before this one would be a fall-through if this block were |
Andrew Kaylor | c24eb21 | 2016-12-12 23:05:38 +0000 | [diff] [blame] | 1817 | // removed, move this block to the end of the function. There is no real |
| 1818 | // advantage in "falling through" to an EH block, so we don't want to |
| 1819 | // perform this transformation for that case. |
| 1820 | // |
| 1821 | // Also, Windows EH introduced the possibility of an arbitrary number of |
| 1822 | // successors to a given block. The analyzeBranch call does not consider |
| 1823 | // exception handling and so we can get in a state where a block |
| 1824 | // containing a call is followed by multiple EH blocks that would be |
| 1825 | // rotated infinitely at the end of the function if the transformation |
| 1826 | // below were performed for EH "FallThrough" blocks. Therefore, even if |
| 1827 | // that appears not to be happening anymore, we should assume that it is |
| 1828 | // possible and not remove the "!FallThrough()->isEHPad" condition below. |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1829 | MachineBasicBlock *PrevTBB = nullptr, *PrevFBB = nullptr; |
Dan Gohman | 2210c0b | 2009-11-11 19:48:59 +0000 | [diff] [blame] | 1830 | SmallVector<MachineOperand, 4> PrevCond; |
Dan Gohman | d194498 | 2009-11-11 18:18:34 +0000 | [diff] [blame] | 1831 | if (FallThrough != MF.end() && |
Andrew Kaylor | c24eb21 | 2016-12-12 23:05:38 +0000 | [diff] [blame] | 1832 | !FallThrough->isEHPad() && |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1833 | !TII->analyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) && |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1834 | PrevBB.isSuccessor(&*FallThrough)) { |
| 1835 | MBB->moveAfter(&MF.back()); |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1836 | MadeChange = true; |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1837 | return MadeChange; |
Chris Lattner | 6b0e3f8 | 2006-10-29 21:05:41 +0000 | [diff] [blame] | 1838 | } |
Chris Lattner | 7d09784 | 2006-10-24 01:12:32 +0000 | [diff] [blame] | 1839 | } |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 1840 | } |
Evan Cheng | 030a0a0 | 2009-09-04 07:47:40 +0000 | [diff] [blame] | 1841 | |
| 1842 | return MadeChange; |
Chris Lattner | 21ab22e | 2004-07-31 10:01:27 +0000 | [diff] [blame] | 1843 | } |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1844 | |
| 1845 | //===----------------------------------------------------------------------===// |
| 1846 | // Hoist Common Code |
| 1847 | //===----------------------------------------------------------------------===// |
| 1848 | |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1849 | bool BranchFolder::HoistCommonCode(MachineFunction &MF) { |
| 1850 | bool MadeChange = false; |
| 1851 | for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ) { |
Duncan P. N. Exon Smith | aa464da | 2015-10-09 18:23:49 +0000 | [diff] [blame] | 1852 | MachineBasicBlock *MBB = &*I++; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1853 | MadeChange |= HoistCommonCodeInSuccs(MBB); |
| 1854 | } |
| 1855 | |
| 1856 | return MadeChange; |
| 1857 | } |
| 1858 | |
| 1859 | /// findFalseBlock - BB has a fallthrough. Find its 'false' successor given |
| 1860 | /// its 'true' successor. |
| 1861 | static MachineBasicBlock *findFalseBlock(MachineBasicBlock *BB, |
| 1862 | MachineBasicBlock *TrueBB) { |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1863 | for (MachineBasicBlock *SuccBB : BB->successors()) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1864 | if (SuccBB != TrueBB) |
| 1865 | return SuccBB; |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1866 | return nullptr; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1867 | } |
| 1868 | |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1869 | template <class Container> |
| 1870 | static void addRegAndItsAliases(unsigned Reg, const TargetRegisterInfo *TRI, |
| 1871 | Container &Set) { |
| 1872 | if (TargetRegisterInfo::isPhysicalRegister(Reg)) { |
| 1873 | for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) |
| 1874 | Set.insert(*AI); |
| 1875 | } else { |
| 1876 | Set.insert(Reg); |
| 1877 | } |
| 1878 | } |
| 1879 | |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1880 | /// findHoistingInsertPosAndDeps - Find the location to move common instructions |
Benjamin Kramer | d9b0b02 | 2012-06-02 10:20:22 +0000 | [diff] [blame] | 1881 | /// in successors to. The location is usually just before the terminator, |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1882 | /// however if the terminator is a conditional branch and its previous |
| 1883 | /// instruction is the flag setting instruction, the previous instruction is |
| 1884 | /// the preferred location. This function also gathers uses and defs of the |
| 1885 | /// instructions from the insertion point to the end of the block. The data is |
| 1886 | /// used by HoistCommonCodeInSuccs to ensure safety. |
| 1887 | static |
| 1888 | MachineBasicBlock::iterator findHoistingInsertPosAndDeps(MachineBasicBlock *MBB, |
| 1889 | const TargetInstrInfo *TII, |
| 1890 | const TargetRegisterInfo *TRI, |
| 1891 | SmallSet<unsigned,4> &Uses, |
| 1892 | SmallSet<unsigned,4> &Defs) { |
| 1893 | MachineBasicBlock::iterator Loc = MBB->getFirstTerminator(); |
Duncan P. N. Exon Smith | 5b9b80e | 2016-02-23 02:46:52 +0000 | [diff] [blame] | 1894 | if (!TII->isUnpredicatedTerminator(*Loc)) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1895 | return MBB->end(); |
| 1896 | |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1897 | for (const MachineOperand &MO : Loc->operands()) { |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1898 | if (!MO.isReg()) |
| 1899 | continue; |
| 1900 | unsigned Reg = MO.getReg(); |
| 1901 | if (!Reg) |
| 1902 | continue; |
| 1903 | if (MO.isUse()) { |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1904 | addRegAndItsAliases(Reg, TRI, Uses); |
Sasa Stankovic | 4421545 | 2014-06-05 13:42:48 +0000 | [diff] [blame] | 1905 | } else { |
| 1906 | if (!MO.isDead()) |
| 1907 | // Don't try to hoist code in the rare case the terminator defines a |
| 1908 | // register that is later used. |
| 1909 | return MBB->end(); |
| 1910 | |
| 1911 | // If the terminator defines a register, make sure we don't hoist |
| 1912 | // the instruction whose def might be clobbered by the terminator. |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1913 | addRegAndItsAliases(Reg, TRI, Defs); |
Sasa Stankovic | 4421545 | 2014-06-05 13:42:48 +0000 | [diff] [blame] | 1914 | } |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1915 | } |
| 1916 | |
| 1917 | if (Uses.empty()) |
| 1918 | return Loc; |
Geoff Berry | edf2f13 | 2018-05-14 17:31:18 +0000 | [diff] [blame] | 1919 | // If the terminator is the only instruction in the block and Uses is not |
| 1920 | // empty (or we would have returned above), we can still safely hoist |
| 1921 | // instructions just before the terminator as long as the Defs/Uses are not |
| 1922 | // violated (which is checked in HoistCommonCodeInSuccs). |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1923 | if (Loc == MBB->begin()) |
Geoff Berry | edf2f13 | 2018-05-14 17:31:18 +0000 | [diff] [blame] | 1924 | return Loc; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1925 | |
| 1926 | // The terminator is probably a conditional branch, try not to separate the |
| 1927 | // branch from condition setting instruction. |
Florian Hahn | f295c8c | 2016-12-16 11:10:26 +0000 | [diff] [blame] | 1928 | MachineBasicBlock::iterator PI = |
| 1929 | skipDebugInstructionsBackward(std::prev(Loc), MBB->begin()); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1930 | |
| 1931 | bool IsDef = false; |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1932 | for (const MachineOperand &MO : PI->operands()) { |
Jakob Stoklund Olesen | a230262 | 2012-02-15 23:42:54 +0000 | [diff] [blame] | 1933 | // If PI has a regmask operand, it is probably a call. Separate away. |
| 1934 | if (MO.isRegMask()) |
| 1935 | return Loc; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1936 | if (!MO.isReg() || MO.isUse()) |
| 1937 | continue; |
| 1938 | unsigned Reg = MO.getReg(); |
| 1939 | if (!Reg) |
| 1940 | continue; |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1941 | if (Uses.count(Reg)) { |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1942 | IsDef = true; |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1943 | break; |
| 1944 | } |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1945 | } |
| 1946 | if (!IsDef) |
| 1947 | // The condition setting instruction is not just before the conditional |
| 1948 | // branch. |
| 1949 | return Loc; |
| 1950 | |
| 1951 | // Be conservative, don't insert instruction above something that may have |
| 1952 | // side-effects. And since it's potentially bad to separate flag setting |
| 1953 | // instruction from the conditional branch, just abort the optimization |
| 1954 | // completely. |
| 1955 | // Also avoid moving code above predicated instruction since it's hard to |
| 1956 | // reason about register liveness with predicated instruction. |
| 1957 | bool DontMoveAcrossStore = true; |
Duncan P. N. Exon Smith | 5b9b80e | 2016-02-23 02:46:52 +0000 | [diff] [blame] | 1958 | if (!PI->isSafeToMove(nullptr, DontMoveAcrossStore) || TII->isPredicated(*PI)) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1959 | return MBB->end(); |
| 1960 | |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1961 | // Find out what registers are live. Note this routine is ignoring other live |
| 1962 | // registers which are only used by instructions in successor blocks. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 1963 | for (const MachineOperand &MO : PI->operands()) { |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1964 | if (!MO.isReg()) |
| 1965 | continue; |
| 1966 | unsigned Reg = MO.getReg(); |
| 1967 | if (!Reg) |
| 1968 | continue; |
| 1969 | if (MO.isUse()) { |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1970 | addRegAndItsAliases(Reg, TRI, Uses); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1971 | } else { |
Benjamin Kramer | 05d96f9 | 2012-08-22 15:37:57 +0000 | [diff] [blame] | 1972 | if (Uses.erase(Reg)) { |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1973 | if (TargetRegisterInfo::isPhysicalRegister(Reg)) { |
| 1974 | for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) |
| 1975 | Uses.erase(*SubRegs); // Use sub-registers to be conservative |
| 1976 | } |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1977 | } |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 1978 | addRegAndItsAliases(Reg, TRI, Defs); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1979 | } |
| 1980 | } |
| 1981 | |
| 1982 | return PI; |
| 1983 | } |
| 1984 | |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1985 | bool BranchFolder::HoistCommonCodeInSuccs(MachineBasicBlock *MBB) { |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1986 | MachineBasicBlock *TBB = nullptr, *FBB = nullptr; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1987 | SmallVector<MachineOperand, 4> Cond; |
Jacques Pienaar | 48ed4ab | 2016-07-15 14:41:04 +0000 | [diff] [blame] | 1988 | if (TII->analyzeBranch(*MBB, TBB, FBB, Cond, true) || !TBB || Cond.empty()) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 1989 | return false; |
| 1990 | |
| 1991 | if (!FBB) FBB = findFalseBlock(MBB, TBB); |
| 1992 | if (!FBB) |
| 1993 | // Malformed bcc? True and false blocks are the same? |
| 1994 | return false; |
| 1995 | |
| 1996 | // Restrict the optimization to cases where MBB is the only predecessor, |
| 1997 | // it is an obvious win. |
| 1998 | if (TBB->pred_size() > 1 || FBB->pred_size() > 1) |
| 1999 | return false; |
| 2000 | |
| 2001 | // Find a suitable position to hoist the common instructions to. Also figure |
| 2002 | // out which registers are used or defined by instructions from the insertion |
| 2003 | // point to the end of the block. |
| 2004 | SmallSet<unsigned, 4> Uses, Defs; |
| 2005 | MachineBasicBlock::iterator Loc = |
| 2006 | findHoistingInsertPosAndDeps(MBB, TII, TRI, Uses, Defs); |
| 2007 | if (Loc == MBB->end()) |
| 2008 | return false; |
| 2009 | |
| 2010 | bool HasDups = false; |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2011 | SmallSet<unsigned, 4> ActiveDefsSet, AllDefsSet; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2012 | MachineBasicBlock::iterator TIB = TBB->begin(); |
| 2013 | MachineBasicBlock::iterator FIB = FBB->begin(); |
| 2014 | MachineBasicBlock::iterator TIE = TBB->end(); |
| 2015 | MachineBasicBlock::iterator FIE = FBB->end(); |
| 2016 | while (TIB != TIE && FIB != FIE) { |
| 2017 | // Skip dbg_value instructions. These do not count. |
Florian Hahn | f295c8c | 2016-12-16 11:10:26 +0000 | [diff] [blame] | 2018 | TIB = skipDebugInstructionsForward(TIB, TIE); |
| 2019 | FIB = skipDebugInstructionsForward(FIB, FIE); |
| 2020 | if (TIB == TIE || FIB == FIE) |
| 2021 | break; |
| 2022 | |
Duncan P. N. Exon Smith | 1d75c8d | 2016-02-27 20:01:33 +0000 | [diff] [blame] | 2023 | if (!TIB->isIdenticalTo(*FIB, MachineInstr::CheckKillDead)) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2024 | break; |
| 2025 | |
Duncan P. N. Exon Smith | 5b9b80e | 2016-02-23 02:46:52 +0000 | [diff] [blame] | 2026 | if (TII->isPredicated(*TIB)) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2027 | // Hard to reason about register liveness with predicated instruction. |
| 2028 | break; |
| 2029 | |
| 2030 | bool IsSafe = true; |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 2031 | for (MachineOperand &MO : TIB->operands()) { |
Jakob Stoklund Olesen | a230262 | 2012-02-15 23:42:54 +0000 | [diff] [blame] | 2032 | // Don't attempt to hoist instructions with register masks. |
| 2033 | if (MO.isRegMask()) { |
| 2034 | IsSafe = false; |
| 2035 | break; |
| 2036 | } |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2037 | if (!MO.isReg()) |
| 2038 | continue; |
| 2039 | unsigned Reg = MO.getReg(); |
| 2040 | if (!Reg) |
| 2041 | continue; |
| 2042 | if (MO.isDef()) { |
| 2043 | if (Uses.count(Reg)) { |
| 2044 | // Avoid clobbering a register that's used by the instruction at |
| 2045 | // the point of insertion. |
| 2046 | IsSafe = false; |
| 2047 | break; |
| 2048 | } |
| 2049 | |
| 2050 | if (Defs.count(Reg) && !MO.isDead()) { |
| 2051 | // Don't hoist the instruction if the def would be clobber by the |
| 2052 | // instruction at the point insertion. FIXME: This is overly |
| 2053 | // conservative. It should be possible to hoist the instructions |
| 2054 | // in BB2 in the following example: |
| 2055 | // BB1: |
| 2056 | // r1, eflag = op1 r2, r3 |
| 2057 | // brcc eflag |
| 2058 | // |
| 2059 | // BB2: |
| 2060 | // r1 = op2, ... |
Francis Visoiu Mistrih | fd11bc0 | 2017-12-07 10:40:31 +0000 | [diff] [blame] | 2061 | // = op3, killed r1 |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2062 | IsSafe = false; |
| 2063 | break; |
| 2064 | } |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2065 | } else if (!ActiveDefsSet.count(Reg)) { |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2066 | if (Defs.count(Reg)) { |
| 2067 | // Use is defined by the instruction at the point of insertion. |
| 2068 | IsSafe = false; |
| 2069 | break; |
| 2070 | } |
Evan Cheng | c16c25f | 2012-01-12 20:31:24 +0000 | [diff] [blame] | 2071 | |
| 2072 | if (MO.isKill() && Uses.count(Reg)) |
| 2073 | // Kills a register that's read by the instruction at the point of |
| 2074 | // insertion. Remove the kill marker. |
| 2075 | MO.setIsKill(false); |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2076 | } |
| 2077 | } |
| 2078 | if (!IsSafe) |
| 2079 | break; |
| 2080 | |
| 2081 | bool DontMoveAcrossStore = true; |
Matthias Braun | dfc41db | 2015-05-19 21:22:20 +0000 | [diff] [blame] | 2082 | if (!TIB->isSafeToMove(nullptr, DontMoveAcrossStore)) |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2083 | break; |
| 2084 | |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2085 | // Remove kills from ActiveDefsSet, these registers had short live ranges. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 2086 | for (const MachineOperand &MO : TIB->operands()) { |
Jakob Stoklund Olesen | 54cfeda | 2011-08-05 18:47:07 +0000 | [diff] [blame] | 2087 | if (!MO.isReg() || !MO.isUse() || !MO.isKill()) |
| 2088 | continue; |
| 2089 | unsigned Reg = MO.getReg(); |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2090 | if (!Reg) |
Jakob Stoklund Olesen | 54cfeda | 2011-08-05 18:47:07 +0000 | [diff] [blame] | 2091 | continue; |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2092 | if (!AllDefsSet.count(Reg)) { |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2093 | continue; |
| 2094 | } |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 2095 | if (TargetRegisterInfo::isPhysicalRegister(Reg)) { |
| 2096 | for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2097 | ActiveDefsSet.erase(*AI); |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 2098 | } else { |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2099 | ActiveDefsSet.erase(Reg); |
Jingyue Wu | 7e90f69 | 2015-07-29 18:59:09 +0000 | [diff] [blame] | 2100 | } |
Jakob Stoklund Olesen | 54cfeda | 2011-08-05 18:47:07 +0000 | [diff] [blame] | 2101 | } |
| 2102 | |
Evan Cheng | 7139d35 | 2011-05-12 20:30:01 +0000 | [diff] [blame] | 2103 | // Track local defs so we can update liveins. |
Craig Topper | cdb417e | 2015-09-16 03:52:35 +0000 | [diff] [blame] | 2104 | for (const MachineOperand &MO : TIB->operands()) { |
Jakob Stoklund Olesen | 54cfeda | 2011-08-05 18:47:07 +0000 | [diff] [blame] | 2105 | if (!MO.isReg() || !MO.isDef() || MO.isDead()) |
Evan Cheng | 7139d35 | 2011-05-12 20:30:01 +0000 | [diff] [blame] | 2106 | continue; |
| 2107 | unsigned Reg = MO.getReg(); |
Dan Gohman | 01a5429 | 2016-05-10 04:24:02 +0000 | [diff] [blame] | 2108 | if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg)) |
Evan Cheng | 7139d35 | 2011-05-12 20:30:01 +0000 | [diff] [blame] | 2109 | continue; |
Krzysztof Parzyszek | 3da6edb | 2017-05-05 12:20:07 +0000 | [diff] [blame] | 2110 | addRegAndItsAliases(Reg, TRI, ActiveDefsSet); |
| 2111 | addRegAndItsAliases(Reg, TRI, AllDefsSet); |
Evan Cheng | 7139d35 | 2011-05-12 20:30:01 +0000 | [diff] [blame] | 2112 | } |
| 2113 | |
Chad Rosier | 90f2004 | 2012-02-22 17:25:00 +0000 | [diff] [blame] | 2114 | HasDups = true; |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2115 | ++TIB; |
| 2116 | ++FIB; |
| 2117 | } |
| 2118 | |
| 2119 | if (!HasDups) |
| 2120 | return false; |
| 2121 | |
| 2122 | MBB->splice(Loc, TBB, TBB->begin(), TIB); |
| 2123 | FBB->erase(FBB->begin(), FIB); |
Evan Cheng | 7139d35 | 2011-05-12 20:30:01 +0000 | [diff] [blame] | 2124 | |
Karl-Johan Karlsson | 1c7fca9 | 2018-06-07 07:20:33 +0000 | [diff] [blame] | 2125 | if (UpdateLiveIns) { |
| 2126 | recomputeLiveIns(*TBB); |
| 2127 | recomputeLiveIns(*FBB); |
Ahmed Bougacha | 59a2759 | 2016-09-12 16:05:31 +0000 | [diff] [blame] | 2128 | } |
| 2129 | |
Evan Cheng | cbc988b | 2011-05-12 00:56:58 +0000 | [diff] [blame] | 2130 | ++NumHoist; |
| 2131 | return true; |
| 2132 | } |