Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2021 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
| 8 | #include "fuzz/Fuzz.h" |
| 9 | #include "fuzz/FuzzCommon.h" |
| 10 | |
| 11 | #include "include/core/SkCanvas.h" |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 12 | #include "include/core/SkExecutor.h" |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 13 | #include "include/core/SkSize.h" |
| 14 | #include "include/core/SkSurface.h" |
| 15 | #include "include/gpu/GrDirectContext.h" |
Kevin Lubick | 77472bf | 2023-03-24 07:11:17 -0400 | [diff] [blame] | 16 | #include "include/gpu/ganesh/SkImageGanesh.h" |
Kevin Lubick | 5c93acf | 2023-05-09 12:11:43 -0400 | [diff] [blame] | 17 | #include "include/gpu/ganesh/SkSurfaceGanesh.h" |
Kevin Lubick | 19936eb | 2023-01-05 09:00:37 -0500 | [diff] [blame] | 18 | #include "include/private/base/SkDeque.h" |
| 19 | #include "include/private/base/SkMutex.h" |
Kevin Lubick | 46572b4 | 2023-01-18 13:11:06 -0500 | [diff] [blame] | 20 | #include "include/private/base/SkTemplates.h" |
Kevin Lubick | 19936eb | 2023-01-05 09:00:37 -0500 | [diff] [blame] | 21 | #include "include/private/base/SkThreadID.h" |
Kevin Lubick | 0bff57e | 2023-06-09 14:29:17 -0400 | [diff] [blame] | 22 | #include "include/private/chromium/GrDeferredDisplayList.h" |
| 23 | #include "include/private/chromium/GrDeferredDisplayListRecorder.h" |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 24 | #include "include/private/chromium/GrPromiseImageTexture.h" |
| 25 | #include "include/private/chromium/SkImageChromium.h" |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 26 | #include "src/core/SkTaskGroup.h" |
Kevin Lubick | bf174bc | 2023-03-27 11:24:20 -0400 | [diff] [blame] | 27 | #include "src/gpu/ganesh/image/SkImage_Ganesh.h" |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 28 | #include "tools/gpu/GrContextFactory.h" |
| 29 | |
| 30 | #include <atomic> |
| 31 | #include <memory> |
| 32 | #include <queue> |
| 33 | |
Herb Derby | 3b3bcf0 | 2023-01-17 15:12:15 -0500 | [diff] [blame] | 34 | using namespace skia_private; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 35 | using ContextType = sk_gpu_test::GrContextFactory::ContextType; |
| 36 | |
| 37 | // be careful: `foo(make_fuzz_t<T>(f), make_fuzz_t<U>(f))` is undefined. |
| 38 | // In fact, all make_fuzz_foo() functions have this potential problem. |
| 39 | // Use sequence points! |
| 40 | template <typename T> |
| 41 | inline T make_fuzz_t(Fuzz* fuzz) { |
| 42 | T t; |
| 43 | fuzz->next(&t); |
| 44 | return t; |
| 45 | } |
| 46 | |
| 47 | class DDLFuzzer; |
| 48 | |
| 49 | // This class stores the state of a given promise image owned by the fuzzer. It acts as the |
| 50 | // context for the callback procs of the promise image. |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 51 | class PromiseImageInfo : public SkNVRefCnt<PromiseImageInfo> { |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 52 | public: |
| 53 | enum class State : int { |
| 54 | kInitial, |
| 55 | kTriedToFulfill, |
| 56 | kDone |
| 57 | }; |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 58 | |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 59 | PromiseImageInfo() = default; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 60 | ~PromiseImageInfo() { |
| 61 | // If we hit this, then the image or the texture will outlive this object which is bad. |
John Stiles | 3ab1292 | 2022-01-21 14:41:00 -0500 | [diff] [blame] | 62 | SkASSERT_RELEASE(!fImage || fImage->unique()); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 63 | SkASSERT_RELEASE(!fTexture || fTexture->unique()); |
| 64 | fImage.reset(); |
| 65 | fTexture.reset(); |
| 66 | State s = fState; |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 67 | SkASSERT_RELEASE(!fDrawn || s == State::kDone); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 68 | } |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 69 | |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 70 | // Make noncopyable |
| 71 | PromiseImageInfo(PromiseImageInfo&) = delete; |
| 72 | PromiseImageInfo& operator=(PromiseImageInfo&) = delete; |
| 73 | |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 74 | DDLFuzzer* fFuzzer = nullptr; |
| 75 | sk_sp<SkImage> fImage; |
| 76 | // At the moment, the atomicity of this isn't used because all our promise image callbacks |
| 77 | // happen on the same thread. See the TODO below about them unreffing them off the GPU thread. |
| 78 | std::atomic<State> fState{State::kInitial}; |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 79 | std::atomic<bool> fDrawn{false}; |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 80 | |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 81 | sk_sp<GrPromiseImageTexture> fTexture; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 82 | }; |
| 83 | |
| 84 | static constexpr int kPromiseImageCount = 8; |
| 85 | static constexpr SkISize kPromiseImageSize{16, 16}; |
| 86 | static constexpr int kPromiseImagesPerDDL = 4; |
| 87 | static constexpr int kRecordingThreadCount = 4; |
| 88 | static constexpr int kIterationCount = 10000; |
| 89 | |
| 90 | // A one-shot runner object for fuzzing our DDL threading. It creates an array of promise images, |
| 91 | // and concurrently records DDLs that reference them, playing each DDL back on the GPU thread. |
| 92 | // The backing textures for promise images may be recycled into a pool, or not, for each case |
| 93 | // as determined by the fuzzing data. |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 94 | class DDLFuzzer { |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 95 | public: |
| 96 | DDLFuzzer(Fuzz*, ContextType); |
Jim Van Verth | 4cf8c75 | 2023-02-21 17:06:41 -0500 | [diff] [blame] | 97 | DDLFuzzer() = delete; |
| 98 | // Make noncopyable |
| 99 | DDLFuzzer(DDLFuzzer&) = delete; |
| 100 | DDLFuzzer& operator=(DDLFuzzer&) = delete; |
| 101 | |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 102 | void run(); |
| 103 | |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 104 | sk_sp<GrPromiseImageTexture> fulfillPromiseImage(PromiseImageInfo&); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 105 | void releasePromiseImage(PromiseImageInfo&); |
| 106 | private: |
| 107 | void initPromiseImage(int index); |
| 108 | void recordAndPlayDDL(); |
| 109 | bool isOnGPUThread() const { return SkGetThreadID() == fGpuThread; } |
| 110 | bool isOnMainThread() const { return SkGetThreadID() == fMainThread; } |
| 111 | |
| 112 | Fuzz* fFuzz = nullptr; |
| 113 | GrDirectContext* fContext = nullptr; |
Herb Derby | 3b3bcf0 | 2023-01-17 15:12:15 -0500 | [diff] [blame] | 114 | AutoTArray<PromiseImageInfo> fPromiseImages{kPromiseImageCount}; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 115 | sk_sp<SkSurface> fSurface; |
Kevin Lubick | 0bff57e | 2023-06-09 14:29:17 -0400 | [diff] [blame] | 116 | GrSurfaceCharacterization fSurfaceCharacterization; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 117 | std::unique_ptr<SkExecutor> fGpuExecutor = SkExecutor::MakeFIFOThreadPool(1, false); |
| 118 | std::unique_ptr<SkExecutor> fRecordingExecutor = |
| 119 | SkExecutor::MakeFIFOThreadPool(kRecordingThreadCount, false); |
| 120 | SkTaskGroup fGpuTaskGroup{*fGpuExecutor}; |
| 121 | SkTaskGroup fRecordingTaskGroup{*fRecordingExecutor}; |
| 122 | SkThreadID fGpuThread = kIllegalThreadID; |
| 123 | SkThreadID fMainThread = SkGetThreadID(); |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 124 | std::queue<sk_sp<GrPromiseImageTexture>> fReusableTextures; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 125 | sk_gpu_test::GrContextFactory fContextFactory; |
| 126 | }; |
| 127 | |
| 128 | DDLFuzzer::DDLFuzzer(Fuzz* fuzz, ContextType contextType) : fFuzz(fuzz) { |
| 129 | sk_gpu_test::ContextInfo ctxInfo = fContextFactory.getContextInfo(contextType); |
| 130 | sk_gpu_test::TestContext* testCtx = ctxInfo.testContext(); |
| 131 | fContext = ctxInfo.directContext(); |
Adlai Holler | 4db5726 | 2021-03-03 16:24:51 -0700 | [diff] [blame] | 132 | if (!fContext) { |
| 133 | return; |
| 134 | } |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 135 | SkISize canvasSize = kPromiseImageSize; |
| 136 | canvasSize.fWidth *= kPromiseImagesPerDDL; |
| 137 | SkImageInfo ii = SkImageInfo::Make(canvasSize, kRGBA_8888_SkColorType, kPremul_SkAlphaType); |
Kevin Lubick | 5c93acf | 2023-05-09 12:11:43 -0400 | [diff] [blame] | 138 | fSurface = SkSurfaces::RenderTarget(fContext, skgpu::Budgeted::kNo, ii); |
Adlai Holler | 4db5726 | 2021-03-03 16:24:51 -0700 | [diff] [blame] | 139 | if (!fSurface || !fSurface->characterize(&fSurfaceCharacterization)) { |
| 140 | return; |
| 141 | } |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 142 | |
| 143 | testCtx->makeNotCurrent(); |
| 144 | fGpuTaskGroup.add([&]{ |
| 145 | testCtx->makeCurrent(); |
| 146 | fGpuThread = SkGetThreadID(); |
| 147 | }); |
| 148 | fGpuTaskGroup.wait(); |
| 149 | for (int i = 0; i < kPromiseImageCount; ++i) { |
| 150 | this->initPromiseImage(i); |
| 151 | } |
| 152 | } |
| 153 | |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 154 | sk_sp<GrPromiseImageTexture> DDLFuzzer::fulfillPromiseImage(PromiseImageInfo& promiseImage) { |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 155 | using State = PromiseImageInfo::State; |
| 156 | if (!this->isOnGPUThread()) { |
| 157 | fFuzz->signalBug(); |
| 158 | } |
| 159 | bool success = make_fuzz_t<bool>(fFuzz); |
| 160 | State prior = promiseImage.fState.exchange(State::kTriedToFulfill, std::memory_order_relaxed); |
| 161 | if (prior != State::kInitial || promiseImage.fTexture != nullptr) { |
| 162 | fFuzz->signalBug(); |
| 163 | } |
| 164 | if (!success) { |
| 165 | return nullptr; |
| 166 | } |
| 167 | |
| 168 | // Try reusing an existing texture if we can and if the fuzzer wills it. |
| 169 | if (!fReusableTextures.empty() && make_fuzz_t<bool>(fFuzz)) { |
| 170 | promiseImage.fTexture = std::move(fReusableTextures.front()); |
| 171 | fReusableTextures.pop(); |
| 172 | return promiseImage.fTexture; |
| 173 | } |
| 174 | |
| 175 | bool finishedBECreate = false; |
| 176 | auto markFinished = [](void* context) { |
| 177 | *(bool*)context = true; |
| 178 | }; |
| 179 | |
Aditya Kushwah | 8acbc3c | 2022-08-24 09:31:11 -0700 | [diff] [blame] | 180 | GrBackendTexture backendTex = |
| 181 | fContext->createBackendTexture(kPromiseImageSize.width(), |
| 182 | kPromiseImageSize.height(), |
| 183 | kRGBA_8888_SkColorType, |
| 184 | SkColors::kRed, |
Kevin Lubick | df73d16 | 2023-09-11 11:56:53 -0400 | [diff] [blame] | 185 | skgpu::Mipmapped::kNo, |
Aditya Kushwah | 8acbc3c | 2022-08-24 09:31:11 -0700 | [diff] [blame] | 186 | GrRenderable::kYes, |
| 187 | GrProtected::kNo, |
| 188 | markFinished, |
| 189 | &finishedBECreate, |
| 190 | /*label=*/"DDLFuzzer_FulFillPromiseImage"); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 191 | SkASSERT_RELEASE(backendTex.isValid()); |
| 192 | while (!finishedBECreate) { |
| 193 | fContext->checkAsyncWorkCompletion(); |
| 194 | } |
| 195 | |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 196 | promiseImage.fTexture = GrPromiseImageTexture::Make(backendTex); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 197 | |
| 198 | return promiseImage.fTexture; |
| 199 | } |
| 200 | |
| 201 | void DDLFuzzer::releasePromiseImage(PromiseImageInfo& promiseImage) { |
| 202 | using State = PromiseImageInfo::State; |
| 203 | // TODO: This requirement will go away when we unref promise images off the GPU thread. |
| 204 | if (!this->isOnGPUThread()) { |
| 205 | fFuzz->signalBug(); |
| 206 | } |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 207 | |
| 208 | State old = promiseImage.fState.exchange(State::kDone, std::memory_order_relaxed); |
| 209 | if (promiseImage.fDrawn && old != State::kTriedToFulfill) { |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 210 | fFuzz->signalBug(); |
| 211 | } |
| 212 | |
| 213 | // If we failed to fulfill, then nothing to be done. |
| 214 | if (!promiseImage.fTexture) { |
| 215 | return; |
| 216 | } |
| 217 | |
| 218 | bool reuse = make_fuzz_t<bool>(fFuzz); |
| 219 | if (reuse) { |
| 220 | fReusableTextures.push(std::move(promiseImage.fTexture)); |
| 221 | } else { |
| 222 | fContext->deleteBackendTexture(promiseImage.fTexture->backendTexture()); |
| 223 | } |
| 224 | promiseImage.fTexture = nullptr; |
| 225 | } |
| 226 | |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 227 | static sk_sp<GrPromiseImageTexture> fuzz_promise_image_fulfill(void* ctxIn) { |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 228 | PromiseImageInfo& fuzzPromiseImage = *(PromiseImageInfo*)ctxIn; |
| 229 | return fuzzPromiseImage.fFuzzer->fulfillPromiseImage(fuzzPromiseImage); |
| 230 | } |
| 231 | |
| 232 | static void fuzz_promise_image_release(void* ctxIn) { |
| 233 | PromiseImageInfo& fuzzPromiseImage = *(PromiseImageInfo*)ctxIn; |
| 234 | fuzzPromiseImage.fFuzzer->releasePromiseImage(fuzzPromiseImage); |
| 235 | } |
| 236 | |
| 237 | void DDLFuzzer::initPromiseImage(int index) { |
| 238 | PromiseImageInfo& promiseImage = fPromiseImages[index]; |
| 239 | promiseImage.fFuzzer = this; |
| 240 | GrBackendFormat backendFmt = fContext->defaultBackendFormat(kRGBA_8888_SkColorType, |
| 241 | GrRenderable::kYes); |
Kevin Lubick | 77472bf | 2023-03-24 07:11:17 -0400 | [diff] [blame] | 242 | promiseImage.fImage = SkImages::PromiseTextureFrom(fContext->threadSafeProxy(), |
| 243 | backendFmt, |
| 244 | kPromiseImageSize, |
Kevin Lubick | df73d16 | 2023-09-11 11:56:53 -0400 | [diff] [blame] | 245 | skgpu::Mipmapped::kNo, |
Kevin Lubick | 77472bf | 2023-03-24 07:11:17 -0400 | [diff] [blame] | 246 | kTopLeft_GrSurfaceOrigin, |
| 247 | kRGBA_8888_SkColorType, |
| 248 | kUnpremul_SkAlphaType, |
| 249 | SkColorSpace::MakeSRGB(), |
| 250 | &fuzz_promise_image_fulfill, |
| 251 | &fuzz_promise_image_release, |
| 252 | &promiseImage); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 253 | } |
| 254 | |
| 255 | void DDLFuzzer::recordAndPlayDDL() { |
| 256 | SkASSERT(!this->isOnGPUThread() && !this->isOnMainThread()); |
Kevin Lubick | 0bff57e | 2023-06-09 14:29:17 -0400 | [diff] [blame] | 257 | GrDeferredDisplayListRecorder recorder(fSurfaceCharacterization); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 258 | SkCanvas* canvas = recorder.getCanvas(); |
| 259 | // Draw promise images in a strip |
| 260 | for (int i = 0; i < kPromiseImagesPerDDL; i++) { |
| 261 | int xOffset = i * kPromiseImageSize.width(); |
| 262 | int j; |
| 263 | // Pick random promise images to draw. |
| 264 | fFuzz->nextRange(&j, 0, kPromiseImageCount - 1); |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 265 | fPromiseImages[j].fDrawn = true; |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 266 | canvas->drawImage(fPromiseImages[j].fImage, xOffset, 0); |
| 267 | } |
Kevin Lubick | 0bff57e | 2023-06-09 14:29:17 -0400 | [diff] [blame] | 268 | sk_sp<GrDeferredDisplayList> ddl = recorder.detach(); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 269 | fGpuTaskGroup.add([=, ddl{std::move(ddl)}]{ |
Kevin Lubick | 0bff57e | 2023-06-09 14:29:17 -0400 | [diff] [blame] | 270 | bool success = skgpu::ganesh::DrawDDL(fSurface, std::move(ddl)); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 271 | if (!success) { |
| 272 | fFuzz->signalBug(); |
| 273 | } |
| 274 | }); |
| 275 | } |
| 276 | |
| 277 | void DDLFuzzer::run() { |
Adlai Holler | 4db5726 | 2021-03-03 16:24:51 -0700 | [diff] [blame] | 278 | if (!fSurface) { |
| 279 | return; |
| 280 | } |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 281 | fRecordingTaskGroup.batch(kIterationCount, [=](int i) { |
| 282 | this->recordAndPlayDDL(); |
| 283 | }); |
| 284 | fRecordingTaskGroup.wait(); |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 285 | |
Kevin Lubick | 99bcee2 | 2023-09-06 10:09:08 -0400 | [diff] [blame] | 286 | fGpuTaskGroup.add([=] { fContext->flushAndSubmit(fSurface.get(), GrSyncCpu::kYes); }); |
Robert Phillips | 4526b46 | 2023-02-14 14:22:12 -0500 | [diff] [blame] | 287 | |
| 288 | fGpuTaskGroup.wait(); |
| 289 | |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 290 | fGpuTaskGroup.add([=] { |
| 291 | while (!fReusableTextures.empty()) { |
Kevin Lubick | eb98125 | 2023-06-13 07:51:26 -0400 | [diff] [blame] | 292 | sk_sp<GrPromiseImageTexture> gpuTexture = std::move(fReusableTextures.front()); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 293 | fContext->deleteBackendTexture(gpuTexture->backendTexture()); |
| 294 | fReusableTextures.pop(); |
| 295 | } |
| 296 | fContextFactory.destroyContexts(); |
| 297 | // TODO: Release promise images not on the GPU thread. |
| 298 | fPromiseImages.reset(0); |
| 299 | }); |
| 300 | fGpuTaskGroup.wait(); |
| 301 | } |
| 302 | |
| 303 | DEF_FUZZ(DDLThreadingGL, fuzz) { |
John Stiles | ba7c525 | 2023-08-25 10:50:10 -0400 | [diff] [blame] | 304 | DDLFuzzer(fuzz, skgpu::ContextType::kGL).run(); |
Adlai Holler | ea8d197 | 2021-02-23 13:05:32 -0500 | [diff] [blame] | 305 | } |