blob: 74e2a0987c3f1ded3838a70924c79614099b8d4a [file] [log] [blame]
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080017#include "ResourceParser.h"
Adam Lesinskice5e56e2016-10-21 17:56:45 -070018
19#include <functional>
Adam Lesinski73bff1e2017-12-08 16:06:10 -080020#include <limits>
Adam Lesinskice5e56e2016-10-21 17:56:45 -070021#include <sstream>
22
23#include "android-base/logging.h"
24
Adam Lesinski1ab598f2015-08-14 14:26:04 -070025#include "ResourceTable.h"
26#include "ResourceUtils.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080027#include "ResourceValues.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070028#include "ValueVisitor.h"
Adam Lesinski2eed52e2018-02-21 15:55:58 -080029#include "text/Utf8Iterator.h"
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080030#include "util/ImmutableMap.h"
Adam Lesinski75421622017-01-06 15:20:04 -080031#include "util/Maybe.h"
Adam Lesinski9e10ac72015-10-16 14:37:48 -070032#include "util/Util.h"
Adam Lesinski467f1712015-11-16 17:35:44 -080033#include "xml/XmlPullParser.h"
Adam Lesinski9e10ac72015-10-16 14:37:48 -070034
Adam Lesinski2eed52e2018-02-21 15:55:58 -080035using ::aapt::ResourceUtils::StringBuilder;
36using ::aapt::text::Utf8Iterator;
MÃ¥rten Kongstad24c9aa62018-06-20 08:46:41 +020037using ::android::ConfigDescription;
Adam Lesinski71be7052017-12-12 16:48:07 -080038using ::android::StringPiece;
Adam Lesinskid5083f62017-01-16 15:07:21 -080039
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080040namespace aapt {
41
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070042constexpr const char* sXliffNamespaceUri = "urn:oasis:names:tc:xliff:document:1.2";
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080043
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070044// Returns true if the element is <skip> or <eat-comment> and can be safely ignored.
45static bool ShouldIgnoreElement(const StringPiece& ns, const StringPiece& name) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070046 return ns.empty() && (name == "skip" || name == "eat-comment");
Adam Lesinski27afb9e2015-11-06 18:25:04 -080047}
48
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070049static uint32_t ParseFormatTypeNoEnumsOrFlags(const StringPiece& piece) {
50 if (piece == "reference") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070051 return android::ResTable_map::TYPE_REFERENCE;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070052 } else if (piece == "string") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070053 return android::ResTable_map::TYPE_STRING;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070054 } else if (piece == "integer") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070055 return android::ResTable_map::TYPE_INTEGER;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070056 } else if (piece == "boolean") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070057 return android::ResTable_map::TYPE_BOOLEAN;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070058 } else if (piece == "color") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070059 return android::ResTable_map::TYPE_COLOR;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070060 } else if (piece == "float") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070061 return android::ResTable_map::TYPE_FLOAT;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070062 } else if (piece == "dimension") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070063 return android::ResTable_map::TYPE_DIMENSION;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070064 } else if (piece == "fraction") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070065 return android::ResTable_map::TYPE_FRACTION;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070066 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -070067 return 0;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080068}
69
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070070static uint32_t ParseFormatType(const StringPiece& piece) {
71 if (piece == "enum") {
72 return android::ResTable_map::TYPE_ENUM;
73 } else if (piece == "flags") {
74 return android::ResTable_map::TYPE_FLAGS;
75 }
76 return ParseFormatTypeNoEnumsOrFlags(piece);
77}
78
Adam Lesinskice5e56e2016-10-21 17:56:45 -070079static uint32_t ParseFormatAttribute(const StringPiece& str) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070080 uint32_t mask = 0;
Chih-Hung Hsieha1b644e2018-12-11 11:09:20 -080081 for (const StringPiece& part : util::Tokenize(str, '|')) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -070082 StringPiece trimmed_part = util::TrimWhitespace(part);
83 uint32_t type = ParseFormatType(trimmed_part);
Adam Lesinskicacb28f2016-10-19 12:18:14 -070084 if (type == 0) {
85 return 0;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080086 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -070087 mask |= type;
88 }
89 return mask;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080090}
91
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070092// A parsed resource ready to be added to the ResourceTable.
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080093struct ParsedResource {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070094 ResourceName name;
95 ConfigDescription config;
96 std::string product;
97 Source source;
Adam Lesinski71be7052017-12-12 16:48:07 -080098
Adam Lesinskicacb28f2016-10-19 12:18:14 -070099 ResourceId id;
Adam Lesinski71be7052017-12-12 16:48:07 -0800100 Visibility::Level visibility_level = Visibility::Level::kUndefined;
Adam Lesinski4488f1c2017-05-26 17:33:38 -0700101 bool allow_new = false;
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800102 Maybe<OverlayableItem> overlayable_item;
Adam Lesinski71be7052017-12-12 16:48:07 -0800103
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700104 std::string comment;
105 std::unique_ptr<Value> value;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700106 std::list<ParsedResource> child_resources;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800107};
108
109// Recursively adds resources to the ResourceTable.
Adam Lesinski4488f1c2017-05-26 17:33:38 -0700110static bool AddResourcesToTable(ResourceTable* table, IDiagnostics* diag, ParsedResource* res) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700111 StringPiece trimmed_comment = util::TrimWhitespace(res->comment);
112 if (trimmed_comment.size() != res->comment.size()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700113 // Only if there was a change do we re-assign.
Adam Lesinskid5083f62017-01-16 15:07:21 -0800114 res->comment = trimmed_comment.to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700115 }
Adam Lesinski7656554f2016-03-10 21:55:04 -0800116
Adam Lesinski71be7052017-12-12 16:48:07 -0800117 if (res->visibility_level != Visibility::Level::kUndefined) {
118 Visibility visibility;
119 visibility.level = res->visibility_level;
120 visibility.source = res->source;
121 visibility.comment = res->comment;
122 if (!table->SetVisibilityWithId(res->name, visibility, res->id, diag)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700123 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800124 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700125 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800126
Adam Lesinski71be7052017-12-12 16:48:07 -0800127 if (res->allow_new) {
128 AllowNew allow_new;
129 allow_new.source = res->source;
130 allow_new.comment = res->comment;
131 if (!table->SetAllowNew(res->name, allow_new, diag)) {
132 return false;
133 }
134 }
135
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800136 if (res->overlayable_item) {
137 if (!table->SetOverlayable(res->name, res->overlayable_item.value(), diag)) {
Adam Lesinski71be7052017-12-12 16:48:07 -0800138 return false;
139 }
140 }
141
142 if (res->value != nullptr) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700143 // Attach the comment, source and config to the value.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700144 res->value->SetComment(std::move(res->comment));
145 res->value->SetSource(std::move(res->source));
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800146
Adam Lesinski71be7052017-12-12 16:48:07 -0800147 if (!table->AddResourceWithId(res->name, res->id, res->config, res->product,
148 std::move(res->value), diag)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700149 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800150 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700151 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800152
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700153 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700154 for (ParsedResource& child : res->child_resources) {
155 error |= !AddResourcesToTable(table, diag, &child);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700156 }
157 return !error;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800158}
159
160// Convenient aliases for more readable function calls.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700161enum { kAllowRawString = true, kNoRawString = false };
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800162
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700163ResourceParser::ResourceParser(IDiagnostics* diag, ResourceTable* table,
164 const Source& source,
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700165 const ConfigDescription& config,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700166 const ResourceParserOptions& options)
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700167 : diag_(diag),
168 table_(table),
169 source_(source),
170 config_(config),
171 options_(options) {}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800172
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800173// Base class Node for representing the various Spans and UntranslatableSections of an XML string.
174// This will be used to traverse and flatten the XML string into a single std::string, with all
175// Span and Untranslatable data maintained in parallel, as indices into the string.
176class Node {
177 public:
178 virtual ~Node() = default;
179
180 // Adds the given child node to this parent node's set of child nodes, moving ownership to the
181 // parent node as well.
182 // Returns a pointer to the child node that was added as a convenience.
183 template <typename T>
184 T* AddChild(std::unique_ptr<T> node) {
185 T* raw_ptr = node.get();
186 children.push_back(std::move(node));
187 return raw_ptr;
188 }
189
190 virtual void Build(StringBuilder* builder) const {
191 for (const auto& child : children) {
192 child->Build(builder);
193 }
194 }
195
196 std::vector<std::unique_ptr<Node>> children;
197};
198
199// A chunk of text in the XML string. This lives between other tags, such as XLIFF tags and Spans.
200class SegmentNode : public Node {
201 public:
202 std::string data;
203
204 void Build(StringBuilder* builder) const override {
205 builder->AppendText(data);
206 }
207};
208
209// A tag that will be encoded into the final flattened string. Tags like <b> or <i>.
210class SpanNode : public Node {
211 public:
212 std::string name;
213
214 void Build(StringBuilder* builder) const override {
215 StringBuilder::SpanHandle span_handle = builder->StartSpan(name);
216 Node::Build(builder);
217 builder->EndSpan(span_handle);
218 }
219};
220
221// An XLIFF 'g' tag, which marks a section of the string as untranslatable.
222class UntranslatableNode : public Node {
223 public:
224 void Build(StringBuilder* builder) const override {
225 StringBuilder::UntranslatableHandle handle = builder->StartUntranslatable();
226 Node::Build(builder);
227 builder->EndUntranslatable(handle);
228 }
229};
230
231// Build a string from XML that converts nested elements into Span objects.
Adam Lesinski75421622017-01-06 15:20:04 -0800232bool ResourceParser::FlattenXmlSubtree(
233 xml::XmlPullParser* parser, std::string* out_raw_string, StyleString* out_style_string,
234 std::vector<UntranslatableSection>* out_untranslatable_sections) {
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800235 std::string raw_string;
236 std::string current_text;
Adam Lesinski75421622017-01-06 15:20:04 -0800237
238 // The first occurrence of a <xliff:g> tag. Nested <xliff:g> tags are illegal.
239 Maybe<size_t> untranslatable_start_depth;
240
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800241 Node root;
242 std::vector<Node*> node_stack;
243 node_stack.push_back(&root);
244
245 bool saw_span_node = false;
246 SegmentNode* first_segment = nullptr;
247 SegmentNode* last_segment = nullptr;
248
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700249 size_t depth = 1;
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800250 while (depth > 0 && xml::XmlPullParser::IsGoodEvent(parser->Next())) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700251 const xml::XmlPullParser::Event event = parser->event();
Adam Lesinski75421622017-01-06 15:20:04 -0800252
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800253 // First take care of any SegmentNodes that should be created.
Ryan Mitchellcb76d732018-06-05 10:15:04 -0700254 if (event == xml::XmlPullParser::Event::kStartElement
Ryan Mitchell1d358ff2019-03-06 15:06:49 -0800255 || event == xml::XmlPullParser::Event::kEndElement) {
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800256 if (!current_text.empty()) {
Ryan Mitchell1d358ff2019-03-06 15:06:49 -0800257 auto segment_node = util::make_unique<SegmentNode>();
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800258 segment_node->data = std::move(current_text);
Ryan Mitchellcb76d732018-06-05 10:15:04 -0700259
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800260 last_segment = node_stack.back()->AddChild(std::move(segment_node));
261 if (first_segment == nullptr) {
262 first_segment = last_segment;
Adam Lesinski75421622017-01-06 15:20:04 -0800263 }
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800264 current_text = {};
265 }
266 }
Adam Lesinski75421622017-01-06 15:20:04 -0800267
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800268 switch (event) {
269 case xml::XmlPullParser::Event::kText: {
270 current_text += parser->text();
271 raw_string += parser->text();
272 } break;
Adam Lesinski75421622017-01-06 15:20:04 -0800273
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800274 case xml::XmlPullParser::Event::kStartElement: {
275 if (parser->element_namespace().empty()) {
276 // This is an HTML tag which we encode as a span. Add it to the span stack.
277 std::unique_ptr<SpanNode> span_node = util::make_unique<SpanNode>();
278 span_node->name = parser->element_name();
279 const auto end_attr_iter = parser->end_attributes();
280 for (auto attr_iter = parser->begin_attributes(); attr_iter != end_attr_iter;
281 ++attr_iter) {
282 span_node->name += ";";
283 span_node->name += attr_iter->name;
284 span_node->name += "=";
285 span_node->name += attr_iter->value;
Adam Lesinski75421622017-01-06 15:20:04 -0800286 }
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800287
288 node_stack.push_back(node_stack.back()->AddChild(std::move(span_node)));
289 saw_span_node = true;
290 } else if (parser->element_namespace() == sXliffNamespaceUri) {
291 // This is an XLIFF tag, which is not encoded as a span.
292 if (parser->element_name() == "g") {
293 // Check that an 'untranslatable' tag is not already being processed. Nested
294 // <xliff:g> tags are illegal.
295 if (untranslatable_start_depth) {
296 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
297 << "illegal nested XLIFF 'g' tag");
298 return false;
299 } else {
300 // Mark the beginning of an 'untranslatable' section.
301 untranslatable_start_depth = depth;
302 node_stack.push_back(
303 node_stack.back()->AddChild(util::make_unique<UntranslatableNode>()));
304 }
305 } else {
306 // Ignore unknown XLIFF tags, but don't warn.
307 node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>()));
308 }
309 } else {
310 // Besides XLIFF, any other namespaced tag is unsupported and ignored.
311 diag_->Warn(DiagMessage(source_.WithLine(parser->line_number()))
312 << "ignoring element '" << parser->element_name()
313 << "' with unknown namespace '" << parser->element_namespace() << "'");
314 node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>()));
Adam Lesinski75421622017-01-06 15:20:04 -0800315 }
Adam Lesinski75421622017-01-06 15:20:04 -0800316
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800317 // Enter one level inside the element.
318 depth++;
319 } break;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700320
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800321 case xml::XmlPullParser::Event::kEndElement: {
322 // Return one level from within the element.
323 depth--;
324 if (depth == 0) {
325 break;
326 }
327
328 node_stack.pop_back();
329 if (untranslatable_start_depth == make_value(depth)) {
330 // This is the end of an untranslatable section.
331 untranslatable_start_depth = {};
332 }
333 } break;
334
335 default:
336 // ignore.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700337 break;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700338 }
339 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700340
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800341 // Sanity check to make sure we processed all the nodes.
342 CHECK(node_stack.size() == 1u);
343 CHECK(node_stack.back() == &root);
344
345 if (!saw_span_node) {
346 // If there were no spans, we must treat this string a little differently (according to AAPT).
347 // Find and strip the leading whitespace from the first segment, and the trailing whitespace
348 // from the last segment.
349 if (first_segment != nullptr) {
350 // Trim leading whitespace.
351 StringPiece trimmed = util::TrimLeadingWhitespace(first_segment->data);
352 if (trimmed.size() != first_segment->data.size()) {
353 first_segment->data = trimmed.to_string();
354 }
355 }
356
357 if (last_segment != nullptr) {
358 // Trim trailing whitespace.
359 StringPiece trimmed = util::TrimTrailingWhitespace(last_segment->data);
360 if (trimmed.size() != last_segment->data.size()) {
361 last_segment->data = trimmed.to_string();
362 }
363 }
364 }
365
366 // Have the XML structure flatten itself into the StringBuilder. The StringBuilder will take
367 // care of recording the correctly adjusted Spans and UntranslatableSections.
368 StringBuilder builder;
369 root.Build(&builder);
370 if (!builder) {
371 diag_->Error(DiagMessage(source_.WithLine(parser->line_number())) << builder.GetError());
372 return false;
373 }
374
375 ResourceUtils::FlattenedXmlString flattened_string = builder.GetFlattenedString();
376 *out_raw_string = std::move(raw_string);
377 *out_untranslatable_sections = std::move(flattened_string.untranslatable_sections);
378 out_style_string->str = std::move(flattened_string.text);
379 out_style_string->spans = std::move(flattened_string.spans);
Adam Lesinski75421622017-01-06 15:20:04 -0800380 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800381}
382
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700383bool ResourceParser::Parse(xml::XmlPullParser* parser) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700384 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700385 const size_t depth = parser->depth();
386 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
387 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700388 // Skip comments and text.
389 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800390 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700391
Adam Lesinski060b53d2017-07-28 17:10:35 -0700392 if (!parser->element_namespace().empty() || parser->element_name() != "resources") {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700393 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700394 << "root element must be <resources>");
395 return false;
396 }
397
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700398 error |= !ParseResources(parser);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700399 break;
400 };
401
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700402 if (parser->event() == xml::XmlPullParser::Event::kBadDocument) {
403 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
404 << "xml parser error: " << parser->error());
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700405 return false;
406 }
407 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800408}
409
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700410bool ResourceParser::ParseResources(xml::XmlPullParser* parser) {
411 std::set<ResourceName> stripped_resources;
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700412
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700413 bool error = false;
414 std::string comment;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700415 const size_t depth = parser->depth();
416 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
417 const xml::XmlPullParser::Event event = parser->event();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700418 if (event == xml::XmlPullParser::Event::kComment) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700419 comment = parser->comment();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700420 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800421 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700422
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700423 if (event == xml::XmlPullParser::Event::kText) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700424 if (!util::TrimWhitespace(parser->text()).empty()) {
425 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700426 << "plain text not allowed here");
427 error = true;
428 }
429 continue;
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700430 }
431
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700432 CHECK(event == xml::XmlPullParser::Event::kStartElement);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700433
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700434 if (!parser->element_namespace().empty()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700435 // Skip unknown namespace.
436 continue;
437 }
438
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700439 std::string element_name = parser->element_name();
440 if (element_name == "skip" || element_name == "eat-comment") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700441 comment = "";
442 continue;
443 }
444
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700445 ParsedResource parsed_resource;
446 parsed_resource.config = config_;
447 parsed_resource.source = source_.WithLine(parser->line_number());
448 parsed_resource.comment = std::move(comment);
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100449 if (options_.visibility) {
450 parsed_resource.visibility_level = options_.visibility.value();
451 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700452
453 // Extract the product name if it exists.
Adam Lesinski060b53d2017-07-28 17:10:35 -0700454 if (Maybe<StringPiece> maybe_product = xml::FindNonEmptyAttribute(parser, "product")) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800455 parsed_resource.product = maybe_product.value().to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700456 }
457
458 // Parse the resource regardless of product.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700459 if (!ParseResource(parser, &parsed_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700460 error = true;
461 continue;
462 }
463
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700464 if (!AddResourcesToTable(table_, diag_, &parsed_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700465 error = true;
466 }
467 }
468
469 // Check that we included at least one variant of each stripped resource.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700470 for (const ResourceName& stripped_resource : stripped_resources) {
471 if (!table_->FindResource(stripped_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700472 // Failed to find the resource.
Adam Lesinski060b53d2017-07-28 17:10:35 -0700473 diag_->Error(DiagMessage(source_) << "resource '" << stripped_resource
474 << "' was filtered out but no product variant remains");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700475 error = true;
476 }
477 }
478
479 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800480}
481
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700482bool ResourceParser::ParseResource(xml::XmlPullParser* parser,
483 ParsedResource* out_resource) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700484 struct ItemTypeFormat {
485 ResourceType type;
486 uint32_t format;
487 };
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800488
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700489 using BagParseFunc = std::function<bool(ResourceParser*, xml::XmlPullParser*,
490 ParsedResource*)>;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800491
Adam Lesinski86d67df2017-01-31 13:47:27 -0800492 static const auto elToItemMap = ImmutableMap<std::string, ItemTypeFormat>::CreatePreSorted({
493 {"bool", {ResourceType::kBool, android::ResTable_map::TYPE_BOOLEAN}},
494 {"color", {ResourceType::kColor, android::ResTable_map::TYPE_COLOR}},
495 {"configVarying", {ResourceType::kConfigVarying, android::ResTable_map::TYPE_ANY}},
496 {"dimen",
497 {ResourceType::kDimen,
498 android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION |
499 android::ResTable_map::TYPE_DIMENSION}},
500 {"drawable", {ResourceType::kDrawable, android::ResTable_map::TYPE_COLOR}},
501 {"fraction",
502 {ResourceType::kFraction,
503 android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION |
504 android::ResTable_map::TYPE_DIMENSION}},
505 {"integer", {ResourceType::kInteger, android::ResTable_map::TYPE_INTEGER}},
506 {"string", {ResourceType::kString, android::ResTable_map::TYPE_STRING}},
507 });
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800508
Adam Lesinski86d67df2017-01-31 13:47:27 -0800509 static const auto elToBagMap = ImmutableMap<std::string, BagParseFunc>::CreatePreSorted({
510 {"add-resource", std::mem_fn(&ResourceParser::ParseAddResource)},
511 {"array", std::mem_fn(&ResourceParser::ParseArray)},
512 {"attr", std::mem_fn(&ResourceParser::ParseAttr)},
513 {"configVarying",
514 std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kConfigVarying,
515 std::placeholders::_2, std::placeholders::_3)},
516 {"declare-styleable", std::mem_fn(&ResourceParser::ParseDeclareStyleable)},
517 {"integer-array", std::mem_fn(&ResourceParser::ParseIntegerArray)},
518 {"java-symbol", std::mem_fn(&ResourceParser::ParseSymbol)},
Adam Lesinski46c4d722017-08-23 13:03:56 -0700519 {"overlayable", std::mem_fn(&ResourceParser::ParseOverlayable)},
Adam Lesinski86d67df2017-01-31 13:47:27 -0800520 {"plurals", std::mem_fn(&ResourceParser::ParsePlural)},
521 {"public", std::mem_fn(&ResourceParser::ParsePublic)},
522 {"public-group", std::mem_fn(&ResourceParser::ParsePublicGroup)},
523 {"string-array", std::mem_fn(&ResourceParser::ParseStringArray)},
524 {"style", std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kStyle,
525 std::placeholders::_2, std::placeholders::_3)},
526 {"symbol", std::mem_fn(&ResourceParser::ParseSymbol)},
527 });
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800528
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700529 std::string resource_type = parser->element_name();
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800530
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700531 // The value format accepted for this resource.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700532 uint32_t resource_format = 0u;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800533
Adam Lesinski86d67df2017-01-31 13:47:27 -0800534 bool can_be_item = true;
535 bool can_be_bag = true;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700536 if (resource_type == "item") {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800537 can_be_bag = false;
538
Adam Lesinskie597d682017-06-01 17:16:44 -0700539 // The default format for <item> is any. If a format attribute is present, that one will
540 // override the default.
541 resource_format = android::ResTable_map::TYPE_ANY;
542
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700543 // Items have their type encoded in the type attribute.
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700544 if (Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800545 resource_type = maybe_type.value().to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700546 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700547 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700548 << "<item> must have a 'type' attribute");
549 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800550 }
551
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700552 if (Maybe<StringPiece> maybe_format = xml::FindNonEmptyAttribute(parser, "format")) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700553 // An explicit format for this resource was specified. The resource will
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700554 // retain its type in its name, but the accepted value for this type is
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700555 // overridden.
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700556 resource_format = ParseFormatTypeNoEnumsOrFlags(maybe_format.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700557 if (!resource_format) {
558 diag_->Error(DiagMessage(out_resource->source)
559 << "'" << maybe_format.value()
560 << "' is an invalid format");
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800561 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700562 }
563 }
Adam Lesinski86d67df2017-01-31 13:47:27 -0800564 } else if (resource_type == "bag") {
565 can_be_item = false;
566
567 // Bags have their type encoded in the type attribute.
568 if (Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) {
569 resource_type = maybe_type.value().to_string();
570 } else {
571 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
572 << "<bag> must have a 'type' attribute");
573 return false;
574 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700575 }
576
577 // Get the name of the resource. This will be checked later, because not all
578 // XML elements require a name.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700579 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700580
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700581 if (resource_type == "id") {
582 if (!maybe_name) {
583 diag_->Error(DiagMessage(out_resource->source)
584 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700585 << "> missing 'name' attribute");
586 return false;
587 }
588
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700589 out_resource->name.type = ResourceType::kId;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800590 out_resource->name.entry = maybe_name.value().to_string();
y9efbbef2018-04-18 11:29:09 -0700591
592 // Ids either represent a unique resource id or reference another resource id
593 auto item = ParseItem(parser, out_resource, resource_format);
594 if (!item) {
595 return false;
596 }
597
598 String* empty = ValueCast<String>(out_resource->value.get());
599 if (empty && *empty->value == "") {
600 // If no inner element exists, represent a unique identifier
601 out_resource->value = util::make_unique<Id>();
602 } else {
y9efbbef2018-04-18 11:29:09 -0700603 Reference* ref = ValueCast<Reference>(out_resource->value.get());
Ryan Mitchelleaf77e12018-04-25 15:00:50 -0700604 if (ref && !ref->name && !ref->id) {
605 // A null reference also means there is no inner element when ids are in the form:
606 // <id name="name"/>
607 out_resource->value = util::make_unique<Id>();
608 } else if (!ref || ref->name.value().type != ResourceType::kId) {
609 // If an inner element exists, the inner element must be a reference to another resource id
y9efbbef2018-04-18 11:29:09 -0700610 diag_->Error(DiagMessage(out_resource->source)
611 << "<" << parser->element_name()
612 << "> inner element must either be a resource reference or empty");
613 return false;
614 }
615 }
616
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700617 return true;
618 }
619
Adam Lesinski86d67df2017-01-31 13:47:27 -0800620 if (can_be_item) {
621 const auto item_iter = elToItemMap.find(resource_type);
622 if (item_iter != elToItemMap.end()) {
623 // This is an item, record its type and format and start parsing.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700624
Adam Lesinski86d67df2017-01-31 13:47:27 -0800625 if (!maybe_name) {
626 diag_->Error(DiagMessage(out_resource->source)
627 << "<" << parser->element_name() << "> missing 'name' attribute");
628 return false;
629 }
630
631 out_resource->name.type = item_iter->second.type;
632 out_resource->name.entry = maybe_name.value().to_string();
633
Adam Lesinskie597d682017-06-01 17:16:44 -0700634 // Only use the implied format of the type when there is no explicit format.
635 if (resource_format == 0u) {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800636 resource_format = item_iter->second.format;
637 }
638
639 if (!ParseItem(parser, out_resource, resource_format)) {
640 return false;
641 }
642 return true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700643 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700644 }
645
646 // This might be a bag or something.
Adam Lesinski86d67df2017-01-31 13:47:27 -0800647 if (can_be_bag) {
648 const auto bag_iter = elToBagMap.find(resource_type);
649 if (bag_iter != elToBagMap.end()) {
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700650 // Ensure we have a name (unless this is a <public-group> or <overlayable>).
Adam Lesinski46c4d722017-08-23 13:03:56 -0700651 if (resource_type != "public-group" && resource_type != "overlayable") {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800652 if (!maybe_name) {
653 diag_->Error(DiagMessage(out_resource->source)
654 << "<" << parser->element_name() << "> missing 'name' attribute");
655 return false;
656 }
657
658 out_resource->name.entry = maybe_name.value().to_string();
659 }
660
661 // Call the associated parse method. The type will be filled in by the
662 // parse func.
663 if (!bag_iter->second(this, parser, out_resource)) {
664 return false;
665 }
666 return true;
667 }
668 }
669
670 if (can_be_item) {
671 // Try parsing the elementName (or type) as a resource. These shall only be
672 // resources like 'layout' or 'xml' and they can only be references.
673 const ResourceType* parsed_type = ParseResourceType(resource_type);
674 if (parsed_type) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700675 if (!maybe_name) {
676 diag_->Error(DiagMessage(out_resource->source)
677 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700678 << "> missing 'name' attribute");
679 return false;
680 }
681
Adam Lesinski86d67df2017-01-31 13:47:27 -0800682 out_resource->name.type = *parsed_type;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800683 out_resource->name.entry = maybe_name.value().to_string();
Adam Lesinski86d67df2017-01-31 13:47:27 -0800684 out_resource->value = ParseXml(parser, android::ResTable_map::TYPE_REFERENCE, kNoRawString);
685 if (!out_resource->value) {
686 diag_->Error(DiagMessage(out_resource->source)
687 << "invalid value for type '" << *parsed_type << "'. Expected a reference");
688 return false;
689 }
690 return true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700691 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700692 }
693
Izabela Orlowskaa3ab21f2019-01-17 12:09:59 +0000694 // If the resource type was not recognized, write the error and return false.
695 diag_->Error(DiagMessage(out_resource->source)
Ryan Mitchell2e2c3b62019-04-26 01:16:52 -0700696 << "unknown resource type '" << resource_type << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700697 return false;
698}
699
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700700bool ResourceParser::ParseItem(xml::XmlPullParser* parser,
701 ParsedResource* out_resource,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700702 const uint32_t format) {
703 if (format == android::ResTable_map::TYPE_STRING) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700704 return ParseString(parser, out_resource);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700705 }
706
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700707 out_resource->value = ParseXml(parser, format, kNoRawString);
708 if (!out_resource->value) {
709 diag_->Error(DiagMessage(out_resource->source) << "invalid "
710 << out_resource->name.type);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700711 return false;
712 }
713 return true;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800714}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800715
716/**
717 * Reads the entire XML subtree and attempts to parse it as some Item,
718 * with typeMask denoting which items it can be. If allowRawValue is
719 * true, a RawString is returned if the XML couldn't be parsed as
720 * an Item. If allowRawValue is false, nullptr is returned in this
721 * case.
722 */
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700723std::unique_ptr<Item> ResourceParser::ParseXml(xml::XmlPullParser* parser,
724 const uint32_t type_mask,
725 const bool allow_raw_value) {
726 const size_t begin_xml_line = parser->line_number();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800727
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700728 std::string raw_value;
729 StyleString style_string;
Adam Lesinski75421622017-01-06 15:20:04 -0800730 std::vector<UntranslatableSection> untranslatable_sections;
731 if (!FlattenXmlSubtree(parser, &raw_value, &style_string, &untranslatable_sections)) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800732 return {};
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700733 }
734
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700735 if (!style_string.spans.empty()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700736 // This can only be a StyledString.
Adam Lesinski75421622017-01-06 15:20:04 -0800737 std::unique_ptr<StyledString> styled_string =
738 util::make_unique<StyledString>(table_->string_pool.MakeRef(
Adam Lesinski060b53d2017-07-28 17:10:35 -0700739 style_string, StringPool::Context(StringPool::Context::kNormalPriority, config_)));
Adam Lesinski75421622017-01-06 15:20:04 -0800740 styled_string->untranslatable_sections = std::move(untranslatable_sections);
741 return std::move(styled_string);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700742 }
743
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700744 auto on_create_reference = [&](const ResourceName& name) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700745 // name.package can be empty here, as it will assume the package name of the
746 // table.
747 std::unique_ptr<Id> id = util::make_unique<Id>();
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700748 id->SetSource(source_.WithLine(begin_xml_line));
749 table_->AddResource(name, {}, {}, std::move(id), diag_);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700750 };
751
752 // Process the raw value.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700753 std::unique_ptr<Item> processed_item =
Adam Lesinski71be7052017-12-12 16:48:07 -0800754 ResourceUtils::TryParseItemForAttribute(raw_value, type_mask, on_create_reference);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700755 if (processed_item) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700756 // Fix up the reference.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700757 if (Reference* ref = ValueCast<Reference>(processed_item.get())) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -0700758 ResolvePackage(parser, ref);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700759 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700760 return processed_item;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700761 }
762
763 // Try making a regular string.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700764 if (type_mask & android::ResTable_map::TYPE_STRING) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700765 // Use the trimmed, escaped string.
Adam Lesinski75421622017-01-06 15:20:04 -0800766 std::unique_ptr<String> string = util::make_unique<String>(
767 table_->string_pool.MakeRef(style_string.str, StringPool::Context(config_)));
768 string->untranslatable_sections = std::move(untranslatable_sections);
769 return std::move(string);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700770 }
771
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700772 if (allow_raw_value) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700773 // We can't parse this so return a RawString if we are allowed.
774 return util::make_unique<RawString>(
Ryan Mitchell633d7962018-06-11 15:29:21 -0700775 table_->string_pool.MakeRef(util::TrimWhitespace(raw_value),
776 StringPool::Context(config_)));
Ryan Mitchellfc3874a2019-05-28 16:30:17 -0700777 } else if (util::TrimWhitespace(raw_value).empty()) {
778 // If the text is empty, and the value is not allowed to be a string, encode it as a @null.
779 return ResourceUtils::MakeNull();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700780 }
781 return {};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800782}
783
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700784bool ResourceParser::ParseString(xml::XmlPullParser* parser,
785 ParsedResource* out_resource) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700786 bool formatted = true;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700787 if (Maybe<StringPiece> formatted_attr =
788 xml::FindAttribute(parser, "formatted")) {
789 Maybe<bool> maybe_formatted =
790 ResourceUtils::ParseBool(formatted_attr.value());
791 if (!maybe_formatted) {
792 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700793 << "invalid value for 'formatted'. Must be a boolean");
794 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800795 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700796 formatted = maybe_formatted.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700797 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800798
Adam Lesinski75421622017-01-06 15:20:04 -0800799 bool translatable = options_.translatable;
800 if (Maybe<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) {
801 Maybe<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value());
802 if (!maybe_translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700803 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700804 << "invalid value for 'translatable'. Must be a boolean");
805 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800806 }
Adam Lesinski75421622017-01-06 15:20:04 -0800807 translatable = maybe_translatable.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700808 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800809
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700810 out_resource->value =
811 ParseXml(parser, android::ResTable_map::TYPE_STRING, kNoRawString);
812 if (!out_resource->value) {
813 diag_->Error(DiagMessage(out_resource->source) << "not a valid string");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700814 return false;
815 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800816
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700817 if (String* string_value = ValueCast<String>(out_resource->value.get())) {
Adam Lesinski75421622017-01-06 15:20:04 -0800818 string_value->SetTranslatable(translatable);
Adam Lesinski393b5f02015-12-17 13:03:11 -0800819
Adam Lesinski75421622017-01-06 15:20:04 -0800820 if (formatted && translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700821 if (!util::VerifyJavaStringFormat(*string_value->value)) {
822 DiagMessage msg(out_resource->source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700823 msg << "multiple substitutions specified in non-positional format; "
824 "did you mean to add the formatted=\"false\" attribute?";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700825 if (options_.error_on_positional_arguments) {
826 diag_->Error(msg);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700827 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800828 }
Adam Lesinski393b5f02015-12-17 13:03:11 -0800829
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700830 diag_->Warn(msg);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700831 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800832 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700833
Adam Lesinski75421622017-01-06 15:20:04 -0800834 } else if (StyledString* string_value = ValueCast<StyledString>(out_resource->value.get())) {
835 string_value->SetTranslatable(translatable);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700836 }
837 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800838}
839
Adam Lesinski71be7052017-12-12 16:48:07 -0800840bool ResourceParser::ParsePublic(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100841 if (options_.visibility) {
842 diag_->Error(DiagMessage(out_resource->source)
843 << "<public> tag not allowed with --visibility flag");
844 return false;
845 }
846
Adam Lesinski46c4d722017-08-23 13:03:56 -0700847 if (out_resource->config != ConfigDescription::DefaultConfig()) {
848 diag_->Warn(DiagMessage(out_resource->source)
849 << "ignoring configuration '" << out_resource->config << "' for <public> tag");
850 }
851
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700852 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
853 if (!maybe_type) {
854 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700855 << "<public> must have a 'type' attribute");
856 return false;
857 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800858
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700859 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
860 if (!parsed_type) {
861 diag_->Error(DiagMessage(out_resource->source) << "invalid resource type '"
862 << maybe_type.value()
863 << "' in <public>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700864 return false;
865 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800866
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700867 out_resource->name.type = *parsed_type;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800868
Adam Lesinskiceb9b2f2017-02-16 12:05:42 -0800869 if (Maybe<StringPiece> maybe_id_str = xml::FindNonEmptyAttribute(parser, "id")) {
870 Maybe<ResourceId> maybe_id = ResourceUtils::ParseResourceId(maybe_id_str.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700871 if (!maybe_id) {
Adam Lesinskiceb9b2f2017-02-16 12:05:42 -0800872 diag_->Error(DiagMessage(out_resource->source)
873 << "invalid resource ID '" << maybe_id_str.value() << "' in <public>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700874 return false;
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800875 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700876 out_resource->id = maybe_id.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700877 }
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800878
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700879 if (*parsed_type == ResourceType::kId) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700880 // An ID marked as public is also the definition of an ID.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700881 out_resource->value = util::make_unique<Id>();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700882 }
Adam Lesinskibf0bd0f2016-06-01 15:31:50 -0700883
Adam Lesinski71be7052017-12-12 16:48:07 -0800884 out_resource->visibility_level = Visibility::Level::kPublic;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700885 return true;
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800886}
887
Adam Lesinski46c4d722017-08-23 13:03:56 -0700888bool ResourceParser::ParsePublicGroup(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100889 if (options_.visibility) {
890 diag_->Error(DiagMessage(out_resource->source)
891 << "<public-group> tag not allowed with --visibility flag");
892 return false;
893 }
894
Adam Lesinski46c4d722017-08-23 13:03:56 -0700895 if (out_resource->config != ConfigDescription::DefaultConfig()) {
896 diag_->Warn(DiagMessage(out_resource->source)
897 << "ignoring configuration '" << out_resource->config
898 << "' for <public-group> tag");
899 }
900
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700901 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
902 if (!maybe_type) {
903 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700904 << "<public-group> must have a 'type' attribute");
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800905 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700906 }
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800907
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700908 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
909 if (!parsed_type) {
910 diag_->Error(DiagMessage(out_resource->source) << "invalid resource type '"
911 << maybe_type.value()
912 << "' in <public-group>");
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800913 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700914 }
915
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700916 Maybe<StringPiece> maybe_id_str =
917 xml::FindNonEmptyAttribute(parser, "first-id");
918 if (!maybe_id_str) {
919 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700920 << "<public-group> must have a 'first-id' attribute");
921 return false;
922 }
923
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700924 Maybe<ResourceId> maybe_id =
925 ResourceUtils::ParseResourceId(maybe_id_str.value());
926 if (!maybe_id) {
927 diag_->Error(DiagMessage(out_resource->source) << "invalid resource ID '"
928 << maybe_id_str.value()
929 << "' in <public-group>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700930 return false;
931 }
932
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700933 ResourceId next_id = maybe_id.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700934
935 std::string comment;
936 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700937 const size_t depth = parser->depth();
938 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
939 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800940 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700941 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700942 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700943 // Skip text.
944 continue;
945 }
946
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700947 const Source item_source = source_.WithLine(parser->line_number());
948 const std::string& element_namespace = parser->element_namespace();
949 const std::string& element_name = parser->element_name();
950 if (element_namespace.empty() && element_name == "public") {
951 Maybe<StringPiece> maybe_name =
952 xml::FindNonEmptyAttribute(parser, "name");
953 if (!maybe_name) {
954 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700955 << "<public> must have a 'name' attribute");
956 error = true;
957 continue;
958 }
959
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700960 if (xml::FindNonEmptyAttribute(parser, "id")) {
961 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700962 << "'id' is ignored within <public-group>");
963 error = true;
964 continue;
965 }
966
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700967 if (xml::FindNonEmptyAttribute(parser, "type")) {
968 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700969 << "'type' is ignored within <public-group>");
970 error = true;
971 continue;
972 }
973
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700974 ParsedResource child_resource;
975 child_resource.name.type = *parsed_type;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800976 child_resource.name.entry = maybe_name.value().to_string();
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700977 child_resource.id = next_id;
978 child_resource.comment = std::move(comment);
979 child_resource.source = item_source;
Adam Lesinski71be7052017-12-12 16:48:07 -0800980 child_resource.visibility_level = Visibility::Level::kPublic;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700981 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700982
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700983 next_id.id += 1;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700984
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700985 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
986 diag_->Error(DiagMessage(item_source) << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700987 error = true;
988 }
989 }
990 return !error;
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800991}
992
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700993bool ResourceParser::ParseSymbolImpl(xml::XmlPullParser* parser,
994 ParsedResource* out_resource) {
995 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
996 if (!maybe_type) {
997 diag_->Error(DiagMessage(out_resource->source)
998 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700999 << "> must have a 'type' attribute");
1000 return false;
1001 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001002
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001003 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
1004 if (!parsed_type) {
1005 diag_->Error(DiagMessage(out_resource->source)
1006 << "invalid resource type '" << maybe_type.value() << "' in <"
1007 << parser->element_name() << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001008 return false;
1009 }
1010
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001011 out_resource->name.type = *parsed_type;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001012 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001013}
1014
Adam Lesinski46c4d722017-08-23 13:03:56 -07001015bool ResourceParser::ParseSymbol(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001016 if (options_.visibility) {
1017 diag_->Error(DiagMessage(out_resource->source)
1018 << "<java-symbol> and <symbol> tags not allowed with --visibility flag");
1019 return false;
1020 }
Adam Lesinski46c4d722017-08-23 13:03:56 -07001021 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1022 diag_->Warn(DiagMessage(out_resource->source)
1023 << "ignoring configuration '" << out_resource->config << "' for <"
1024 << parser->element_name() << "> tag");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001025 }
Adam Lesinski46c4d722017-08-23 13:03:56 -07001026
1027 if (!ParseSymbolImpl(parser, out_resource)) {
1028 return false;
1029 }
1030
Adam Lesinski71be7052017-12-12 16:48:07 -08001031 out_resource->visibility_level = Visibility::Level::kPrivate;
Adam Lesinski46c4d722017-08-23 13:03:56 -07001032 return true;
1033}
1034
1035bool ResourceParser::ParseOverlayable(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1036 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1037 diag_->Warn(DiagMessage(out_resource->source)
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001038 << "ignoring configuration '" << out_resource->config
1039 << "' for <overlayable> tag");
Adam Lesinski46c4d722017-08-23 13:03:56 -07001040 }
1041
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001042 Maybe<StringPiece> overlayable_name = xml::FindNonEmptyAttribute(parser, "name");
1043 if (!overlayable_name) {
1044 diag_->Error(DiagMessage(out_resource->source)
1045 << "<overlayable> tag must have a 'name' attribute");
1046 return false;
1047 }
1048
1049 const std::string kActorUriScheme =
1050 android::base::StringPrintf("%s://", Overlayable::kActorScheme);
1051 Maybe<StringPiece> overlayable_actor = xml::FindNonEmptyAttribute(parser, "actor");
1052 if (overlayable_actor && !util::StartsWith(overlayable_actor.value(), kActorUriScheme)) {
1053 diag_->Error(DiagMessage(out_resource->source)
1054 << "specified <overlayable> tag 'actor' attribute must use the scheme '"
1055 << Overlayable::kActorScheme << "'");
1056 return false;
1057 }
1058
1059 // Create a overlayable entry grouping that represents this <overlayable>
1060 auto overlayable = std::make_shared<Overlayable>(
1061 overlayable_name.value(), (overlayable_actor) ? overlayable_actor.value() : "",
Ryan Mitchellb5b162b2019-02-07 20:07:21 -08001062 source_);
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001063
Adam Lesinski46c4d722017-08-23 13:03:56 -07001064 bool error = false;
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001065 std::string comment;
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001066 OverlayableItem::PolicyFlags current_policies = OverlayableItem::Policy::kNone;
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001067 const size_t start_depth = parser->depth();
1068 while (xml::XmlPullParser::IsGoodEvent(parser->Next())) {
1069 xml::XmlPullParser::Event event = parser->event();
1070 if (event == xml::XmlPullParser::Event::kEndElement && parser->depth() == start_depth) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001071 // Break the loop when exiting the <overlayable>
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001072 break;
1073 } else if (event == xml::XmlPullParser::Event::kEndElement
1074 && parser->depth() == start_depth + 1) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001075 // Clear the current policies when exiting the <policy> tags
1076 current_policies = OverlayableItem::Policy::kNone;
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001077 continue;
1078 } else if (event == xml::XmlPullParser::Event::kComment) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001079 // Retrieve the comment of individual <item> tags
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001080 comment = parser->comment();
1081 continue;
1082 } else if (event != xml::XmlPullParser::Event::kStartElement) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001083 // Skip to the start of the next element
Adam Lesinski46c4d722017-08-23 13:03:56 -07001084 continue;
1085 }
1086
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001087 const Source element_source = source_.WithLine(parser->line_number());
Adam Lesinski46c4d722017-08-23 13:03:56 -07001088 const std::string& element_name = parser->element_name();
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001089 const std::string& element_namespace = parser->element_namespace();
Adam Lesinski46c4d722017-08-23 13:03:56 -07001090 if (element_namespace.empty() && element_name == "item") {
Winsonb2d7f532019-02-04 16:32:43 -08001091 if (current_policies == OverlayableItem::Policy::kNone) {
1092 diag_->Error(DiagMessage(element_source)
1093 << "<item> within an <overlayable> must be inside a <policy> block");
1094 error = true;
1095 continue;
1096 }
1097
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001098 // Items specify the name and type of resource that should be overlayable
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001099 Maybe<StringPiece> item_name = xml::FindNonEmptyAttribute(parser, "name");
1100 if (!item_name) {
1101 diag_->Error(DiagMessage(element_source)
1102 << "<item> within an <overlayable> must have a 'name' attribute");
Adam Lesinski46c4d722017-08-23 13:03:56 -07001103 error = true;
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001104 continue;
Adam Lesinski46c4d722017-08-23 13:03:56 -07001105 }
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001106
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001107 Maybe<StringPiece> item_type = xml::FindNonEmptyAttribute(parser, "type");
1108 if (!item_type) {
1109 diag_->Error(DiagMessage(element_source)
1110 << "<item> within an <overlayable> must have a 'type' attribute");
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001111 error = true;
1112 continue;
1113 }
1114
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001115 const ResourceType* type = ParseResourceType(item_type.value());
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001116 if (type == nullptr) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001117 diag_->Error(DiagMessage(element_source)
1118 << "invalid resource type '" << item_type.value()
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001119 << "' in <item> within an <overlayable>");
1120 error = true;
1121 continue;
1122 }
1123
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001124 OverlayableItem overlayable_item(overlayable);
1125 overlayable_item.policies = current_policies;
1126 overlayable_item.comment = comment;
1127 overlayable_item.source = element_source;
1128
1129 ParsedResource child_resource{};
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001130 child_resource.name.type = *type;
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001131 child_resource.name.entry = item_name.value().to_string();
1132 child_resource.overlayable_item = overlayable_item;
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001133 out_resource->child_resources.push_back(std::move(child_resource));
1134
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001135 } else if (element_namespace.empty() && element_name == "policy") {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001136 if (current_policies != OverlayableItem::Policy::kNone) {
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001137 // If the policy list is not empty, then we are currently inside a policy element
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001138 diag_->Error(DiagMessage(element_source) << "<policy> blocks cannot be recursively nested");
Adam Lesinski46c4d722017-08-23 13:03:56 -07001139 error = true;
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001140 break;
1141 } else if (Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) {
1142 // Parse the polices separated by vertical bar characters to allow for specifying multiple
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001143 // policies. Items within the policy tag will have the specified policy.
Ryan Mitchell939df092019-04-09 17:13:50 -07001144 static const auto kPolicyMap =
1145 ImmutableMap<StringPiece, OverlayableItem::Policy>::CreatePreSorted({
1146 {"odm", OverlayableItem::Policy::kOdm},
1147 {"oem", OverlayableItem::Policy::kOem},
1148 {"product", OverlayableItem::Policy::kProduct},
1149 {"public", OverlayableItem::Policy::kPublic},
1150 {"signature", OverlayableItem::Policy::kSignature},
1151 {"system", OverlayableItem::Policy::kSystem},
1152 {"vendor", OverlayableItem::Policy::kVendor},
1153 });
1154
1155 for (const StringPiece& part : util::Tokenize(maybe_type.value(), '|')) {
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001156 StringPiece trimmed_part = util::TrimWhitespace(part);
Ryan Mitchell939df092019-04-09 17:13:50 -07001157 const auto policy = kPolicyMap.find(trimmed_part);
1158 if (policy == kPolicyMap.end()) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001159 diag_->Error(DiagMessage(element_source)
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001160 << "<policy> has unsupported type '" << trimmed_part << "'");
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001161 error = true;
1162 continue;
1163 }
Ryan Mitchell939df092019-04-09 17:13:50 -07001164
1165 current_policies |= policy->second;
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001166 }
Winsonb2d7f532019-02-04 16:32:43 -08001167 } else {
1168 diag_->Error(DiagMessage(element_source)
Ryan Mitchell939df092019-04-09 17:13:50 -07001169 << "<policy> must have a 'type' attribute");
Winsonb2d7f532019-02-04 16:32:43 -08001170 error = true;
1171 continue;
Adam Lesinski46c4d722017-08-23 13:03:56 -07001172 }
Adam Lesinski46c4d722017-08-23 13:03:56 -07001173 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001174 diag_->Error(DiagMessage(element_source) << "invalid element <" << element_name << "> "
Ryan Mitchell939df092019-04-09 17:13:50 -07001175 << " in <overlayable>");
Adam Lesinski46c4d722017-08-23 13:03:56 -07001176 error = true;
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001177 break;
Adam Lesinski46c4d722017-08-23 13:03:56 -07001178 }
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001179
1180 comment.clear();
Adam Lesinski46c4d722017-08-23 13:03:56 -07001181 }
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001182
Adam Lesinski46c4d722017-08-23 13:03:56 -07001183 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001184}
1185
Adam Lesinski71be7052017-12-12 16:48:07 -08001186bool ResourceParser::ParseAddResource(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001187 if (ParseSymbolImpl(parser, out_resource)) {
Adam Lesinski71be7052017-12-12 16:48:07 -08001188 out_resource->visibility_level = Visibility::Level::kUndefined;
Adam Lesinski4488f1c2017-05-26 17:33:38 -07001189 out_resource->allow_new = true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001190 return true;
1191 }
1192 return false;
1193}
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001194
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001195bool ResourceParser::ParseAttr(xml::XmlPullParser* parser,
1196 ParsedResource* out_resource) {
1197 return ParseAttrImpl(parser, out_resource, false);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001198}
1199
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001200bool ResourceParser::ParseAttrImpl(xml::XmlPullParser* parser,
1201 ParsedResource* out_resource, bool weak) {
1202 out_resource->name.type = ResourceType::kAttr;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001203
1204 // Attributes only end up in default configuration.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001205 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1206 diag_->Warn(DiagMessage(out_resource->source)
1207 << "ignoring configuration '" << out_resource->config
1208 << "' for attribute " << out_resource->name);
1209 out_resource->config = ConfigDescription::DefaultConfig();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001210 }
1211
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001212 uint32_t type_mask = 0;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001213
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001214 Maybe<StringPiece> maybe_format = xml::FindAttribute(parser, "format");
1215 if (maybe_format) {
1216 type_mask = ParseFormatAttribute(maybe_format.value());
1217 if (type_mask == 0) {
1218 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001219 << "invalid attribute format '" << maybe_format.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001220 return false;
1221 }
1222 }
1223
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001224 Maybe<int32_t> maybe_min, maybe_max;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001225
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001226 if (Maybe<StringPiece> maybe_min_str = xml::FindAttribute(parser, "min")) {
1227 StringPiece min_str = util::TrimWhitespace(maybe_min_str.value());
1228 if (!min_str.empty()) {
1229 std::u16string min_str16 = util::Utf8ToUtf16(min_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001230 android::Res_value value;
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001231 if (android::ResTable::stringToInt(min_str16.data(), min_str16.size(), &value)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001232 maybe_min = static_cast<int32_t>(value.data);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001233 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001234 }
1235
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001236 if (!maybe_min) {
1237 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1238 << "invalid 'min' value '" << min_str << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001239 return false;
1240 }
1241 }
1242
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001243 if (Maybe<StringPiece> maybe_max_str = xml::FindAttribute(parser, "max")) {
1244 StringPiece max_str = util::TrimWhitespace(maybe_max_str.value());
1245 if (!max_str.empty()) {
1246 std::u16string max_str16 = util::Utf8ToUtf16(max_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001247 android::Res_value value;
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001248 if (android::ResTable::stringToInt(max_str16.data(), max_str16.size(), &value)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001249 maybe_max = static_cast<int32_t>(value.data);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001250 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001251 }
1252
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001253 if (!maybe_max) {
1254 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1255 << "invalid 'max' value '" << max_str << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001256 return false;
1257 }
1258 }
1259
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001260 if ((maybe_min || maybe_max) &&
1261 (type_mask & android::ResTable_map::TYPE_INTEGER) == 0) {
1262 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001263 << "'min' and 'max' can only be used when format='integer'");
1264 return false;
1265 }
1266
1267 struct SymbolComparator {
Yi Kong087e2d42017-05-02 12:49:25 -07001268 bool operator()(const Attribute::Symbol& a, const Attribute::Symbol& b) const {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001269 return a.symbol.name.value() < b.symbol.name.value();
1270 }
1271 };
1272
1273 std::set<Attribute::Symbol, SymbolComparator> items;
1274
1275 std::string comment;
1276 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001277 const size_t depth = parser->depth();
1278 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1279 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -08001280 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001281 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001282 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001283 // Skip text.
1284 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001285 }
1286
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001287 const Source item_source = source_.WithLine(parser->line_number());
1288 const std::string& element_namespace = parser->element_namespace();
1289 const std::string& element_name = parser->element_name();
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001290 if (element_namespace.empty() && (element_name == "flag" || element_name == "enum")) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001291 if (element_name == "enum") {
1292 if (type_mask & android::ResTable_map::TYPE_FLAGS) {
1293 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001294 << "can not define an <enum>; already defined a <flag>");
1295 error = true;
1296 continue;
1297 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001298 type_mask |= android::ResTable_map::TYPE_ENUM;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001299
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001300 } else if (element_name == "flag") {
1301 if (type_mask & android::ResTable_map::TYPE_ENUM) {
1302 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001303 << "can not define a <flag>; already defined an <enum>");
1304 error = true;
1305 continue;
1306 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001307 type_mask |= android::ResTable_map::TYPE_FLAGS;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001308 }
1309
1310 if (Maybe<Attribute::Symbol> s =
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001311 ParseEnumOrFlagItem(parser, element_name)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001312 Attribute::Symbol& symbol = s.value();
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001313 ParsedResource child_resource;
1314 child_resource.name = symbol.symbol.name.value();
1315 child_resource.source = item_source;
1316 child_resource.value = util::make_unique<Id>();
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001317 if (options_.visibility) {
1318 child_resource.visibility_level = options_.visibility.value();
1319 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001320 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001321
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001322 symbol.symbol.SetComment(std::move(comment));
1323 symbol.symbol.SetSource(item_source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001324
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001325 auto insert_result = items.insert(std::move(symbol));
1326 if (!insert_result.second) {
1327 const Attribute::Symbol& existing_symbol = *insert_result.first;
1328 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001329 << "duplicate symbol '"
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001330 << existing_symbol.symbol.name.value().entry << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001331
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001332 diag_->Note(DiagMessage(existing_symbol.symbol.GetSource())
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001333 << "first defined here");
1334 error = true;
1335 }
1336 } else {
1337 error = true;
1338 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001339 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1340 diag_->Error(DiagMessage(item_source) << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001341 error = true;
1342 }
1343
1344 comment = {};
1345 }
1346
1347 if (error) {
1348 return false;
1349 }
1350
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001351 std::unique_ptr<Attribute> attr = util::make_unique<Attribute>(
1352 type_mask ? type_mask : uint32_t{android::ResTable_map::TYPE_ANY});
1353 attr->SetWeak(weak);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001354 attr->symbols = std::vector<Attribute::Symbol>(items.begin(), items.end());
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001355 attr->min_int = maybe_min.value_or_default(std::numeric_limits<int32_t>::min());
1356 attr->max_int = maybe_max.value_or_default(std::numeric_limits<int32_t>::max());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001357 out_resource->value = std::move(attr);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001358 return true;
1359}
1360
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001361Maybe<Attribute::Symbol> ResourceParser::ParseEnumOrFlagItem(
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001362 xml::XmlPullParser* parser, const StringPiece& tag) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001363 const Source source = source_.WithLine(parser->line_number());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001364
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001365 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
1366 if (!maybe_name) {
1367 diag_->Error(DiagMessage(source) << "no attribute 'name' found for tag <"
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001368 << tag << ">");
1369 return {};
1370 }
1371
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001372 Maybe<StringPiece> maybe_value = xml::FindNonEmptyAttribute(parser, "value");
1373 if (!maybe_value) {
1374 diag_->Error(DiagMessage(source) << "no attribute 'value' found for tag <"
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001375 << tag << ">");
1376 return {};
1377 }
1378
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001379 std::u16string value16 = util::Utf8ToUtf16(maybe_value.value());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001380 android::Res_value val;
1381 if (!android::ResTable::stringToInt(value16.data(), value16.size(), &val)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001382 diag_->Error(DiagMessage(source) << "invalid value '" << maybe_value.value()
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001383 << "' for <" << tag
1384 << ">; must be an integer");
1385 return {};
1386 }
1387
1388 return Attribute::Symbol{
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001389 Reference(ResourceNameRef({}, ResourceType::kId, maybe_name.value())),
Ryan Mitchellc1676802019-05-20 16:47:08 -07001390 val.data, val.dataType};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001391}
1392
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001393bool ResourceParser::ParseStyleItem(xml::XmlPullParser* parser, Style* style) {
1394 const Source source = source_.WithLine(parser->line_number());
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001395
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001396 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
1397 if (!maybe_name) {
1398 diag_->Error(DiagMessage(source) << "<item> must have a 'name' attribute");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001399 return false;
1400 }
1401
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001402 Maybe<Reference> maybe_key = ResourceUtils::ParseXmlAttributeName(maybe_name.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001403 if (!maybe_key) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001404 diag_->Error(DiagMessage(source) << "invalid attribute name '" << maybe_name.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001405 return false;
1406 }
1407
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001408 ResolvePackage(parser, &maybe_key.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001409 maybe_key.value().SetSource(source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001410
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001411 std::unique_ptr<Item> value = ParseXml(parser, 0, kAllowRawString);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001412 if (!value) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001413 diag_->Error(DiagMessage(source) << "could not parse style item");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001414 return false;
1415 }
1416
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001417 style->entries.push_back(Style::Entry{std::move(maybe_key.value()), std::move(value)});
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001418 return true;
1419}
1420
Adam Lesinski86d67df2017-01-31 13:47:27 -08001421bool ResourceParser::ParseStyle(const ResourceType type, xml::XmlPullParser* parser,
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001422 ParsedResource* out_resource) {
Adam Lesinski86d67df2017-01-31 13:47:27 -08001423 out_resource->name.type = type;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001424
1425 std::unique_ptr<Style> style = util::make_unique<Style>();
1426
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001427 Maybe<StringPiece> maybe_parent = xml::FindAttribute(parser, "parent");
1428 if (maybe_parent) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001429 // If the parent is empty, we don't have a parent, but we also don't infer either.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001430 if (!maybe_parent.value().empty()) {
1431 std::string err_str;
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001432 style->parent = ResourceUtils::ParseStyleParentReference(maybe_parent.value(), &err_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001433 if (!style->parent) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001434 diag_->Error(DiagMessage(out_resource->source) << err_str);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001435 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001436 }
1437
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001438 // Transform the namespace prefix to the actual package name, and mark the reference as
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001439 // private if appropriate.
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001440 ResolvePackage(parser, &style->parent.value());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001441 }
1442
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001443 } else {
1444 // No parent was specified, so try inferring it from the style name.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001445 std::string style_name = out_resource->name.entry;
1446 size_t pos = style_name.find_last_of(u'.');
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001447 if (pos != std::string::npos) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001448 style->parent_inferred = true;
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001449 style->parent = Reference(ResourceName({}, ResourceType::kStyle, style_name.substr(0, pos)));
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001450 }
1451 }
1452
1453 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001454 const size_t depth = parser->depth();
1455 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1456 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001457 // Skip text and comments.
1458 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001459 }
1460
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001461 const std::string& element_namespace = parser->element_namespace();
1462 const std::string& element_name = parser->element_name();
1463 if (element_namespace == "" && element_name == "item") {
1464 error |= !ParseStyleItem(parser, style.get());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001465
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001466 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1467 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1468 << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001469 error = true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001470 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001471 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001472
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001473 if (error) {
1474 return false;
1475 }
1476
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001477 out_resource->value = std::move(style);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001478 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001479}
1480
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001481bool ResourceParser::ParseArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1482 uint32_t resource_format = android::ResTable_map::TYPE_ANY;
1483 if (Maybe<StringPiece> format_attr = xml::FindNonEmptyAttribute(parser, "format")) {
1484 resource_format = ParseFormatTypeNoEnumsOrFlags(format_attr.value());
1485 if (resource_format == 0u) {
1486 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1487 << "'" << format_attr.value() << "' is an invalid format");
1488 return false;
1489 }
1490 }
1491 return ParseArrayImpl(parser, out_resource, resource_format);
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001492}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001493
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001494bool ResourceParser::ParseIntegerArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1495 return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_INTEGER);
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001496}
1497
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001498bool ResourceParser::ParseStringArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1499 return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_STRING);
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001500}
1501
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001502bool ResourceParser::ParseArrayImpl(xml::XmlPullParser* parser,
1503 ParsedResource* out_resource,
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001504 const uint32_t typeMask) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001505 out_resource->name.type = ResourceType::kArray;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001506
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001507 std::unique_ptr<Array> array = util::make_unique<Array>();
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001508
Adam Lesinski75421622017-01-06 15:20:04 -08001509 bool translatable = options_.translatable;
1510 if (Maybe<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) {
1511 Maybe<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value());
1512 if (!maybe_translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001513 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001514 << "invalid value for 'translatable'. Must be a boolean");
1515 return false;
Adam Lesinski458b8772016-04-25 14:20:21 -07001516 }
Adam Lesinski75421622017-01-06 15:20:04 -08001517 translatable = maybe_translatable.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001518 }
Adam Lesinski75421622017-01-06 15:20:04 -08001519 array->SetTranslatable(translatable);
Adam Lesinski458b8772016-04-25 14:20:21 -07001520
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001521 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001522 const size_t depth = parser->depth();
1523 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1524 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001525 // Skip text and comments.
1526 continue;
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001527 }
1528
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001529 const Source item_source = source_.WithLine(parser->line_number());
1530 const std::string& element_namespace = parser->element_namespace();
1531 const std::string& element_name = parser->element_name();
1532 if (element_namespace.empty() && element_name == "item") {
1533 std::unique_ptr<Item> item = ParseXml(parser, typeMask, kNoRawString);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001534 if (!item) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001535 diag_->Error(DiagMessage(item_source) << "could not parse array item");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001536 error = true;
1537 continue;
1538 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001539 item->SetSource(item_source);
Adam Lesinski4ffea042017-08-10 15:37:28 -07001540 array->elements.emplace_back(std::move(item));
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001541
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001542 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1543 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1544 << "unknown tag <" << element_namespace << ":"
1545 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001546 error = true;
1547 }
1548 }
1549
1550 if (error) {
1551 return false;
1552 }
1553
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001554 out_resource->value = std::move(array);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001555 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001556}
1557
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001558bool ResourceParser::ParsePlural(xml::XmlPullParser* parser,
1559 ParsedResource* out_resource) {
1560 out_resource->name.type = ResourceType::kPlurals;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001561
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001562 std::unique_ptr<Plural> plural = util::make_unique<Plural>();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001563
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001564 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001565 const size_t depth = parser->depth();
1566 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1567 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001568 // Skip text and comments.
1569 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001570 }
1571
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001572 const Source item_source = source_.WithLine(parser->line_number());
1573 const std::string& element_namespace = parser->element_namespace();
1574 const std::string& element_name = parser->element_name();
1575 if (element_namespace.empty() && element_name == "item") {
1576 Maybe<StringPiece> maybe_quantity =
1577 xml::FindNonEmptyAttribute(parser, "quantity");
1578 if (!maybe_quantity) {
1579 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001580 << "<item> in <plurals> requires attribute "
1581 << "'quantity'");
1582 error = true;
1583 continue;
1584 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001585
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001586 StringPiece trimmed_quantity =
1587 util::TrimWhitespace(maybe_quantity.value());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001588 size_t index = 0;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001589 if (trimmed_quantity == "zero") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001590 index = Plural::Zero;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001591 } else if (trimmed_quantity == "one") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001592 index = Plural::One;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001593 } else if (trimmed_quantity == "two") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001594 index = Plural::Two;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001595 } else if (trimmed_quantity == "few") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001596 index = Plural::Few;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001597 } else if (trimmed_quantity == "many") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001598 index = Plural::Many;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001599 } else if (trimmed_quantity == "other") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001600 index = Plural::Other;
1601 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001602 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001603 << "<item> in <plural> has invalid value '"
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001604 << trimmed_quantity << "' for attribute 'quantity'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001605 error = true;
1606 continue;
1607 }
1608
1609 if (plural->values[index]) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001610 diag_->Error(DiagMessage(item_source) << "duplicate quantity '"
1611 << trimmed_quantity << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001612 error = true;
1613 continue;
1614 }
1615
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001616 if (!(plural->values[index] = ParseXml(
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001617 parser, android::ResTable_map::TYPE_STRING, kNoRawString))) {
1618 error = true;
Ryan Mitchell2f9077d2019-02-15 16:02:09 -08001619 continue;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001620 }
Ryan Mitchell2f9077d2019-02-15 16:02:09 -08001621
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001622 plural->values[index]->SetSource(item_source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001623
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001624 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1625 diag_->Error(DiagMessage(item_source) << "unknown tag <"
1626 << element_namespace << ":"
1627 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001628 error = true;
1629 }
1630 }
1631
1632 if (error) {
1633 return false;
1634 }
1635
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001636 out_resource->value = std::move(plural);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001637 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001638}
1639
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001640bool ResourceParser::ParseDeclareStyleable(xml::XmlPullParser* parser,
1641 ParsedResource* out_resource) {
1642 out_resource->name.type = ResourceType::kStyleable;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001643
Donald Chai94e4a012020-01-06 13:52:41 -08001644 if (!options_.preserve_visibility_of_styleables) {
1645 // This was added in change Idd21b5de4d20be06c6f8c8eb5a22ccd68afc4927 to mimic aapt1, but no one
1646 // knows exactly what for.
1647 //
1648 // FWIW, styleables only appear in generated R classes. For custom views these should always be
1649 // package-private (to be used only by the view class); themes are a different story.
1650 out_resource->visibility_level = Visibility::Level::kPublic;
1651 }
Adam Lesinski9f222042015-11-04 13:51:45 -08001652
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001653 // Declare-styleable only ends up in default config;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001654 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1655 diag_->Warn(DiagMessage(out_resource->source)
1656 << "ignoring configuration '" << out_resource->config
1657 << "' for styleable " << out_resource->name.entry);
1658 out_resource->config = ConfigDescription::DefaultConfig();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001659 }
1660
1661 std::unique_ptr<Styleable> styleable = util::make_unique<Styleable>();
1662
1663 std::string comment;
1664 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001665 const size_t depth = parser->depth();
1666 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1667 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -08001668 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001669 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001670 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001671 // Ignore text.
1672 continue;
Adam Lesinski52364f72016-01-11 13:10:24 -08001673 }
1674
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001675 const Source item_source = source_.WithLine(parser->line_number());
1676 const std::string& element_namespace = parser->element_namespace();
1677 const std::string& element_name = parser->element_name();
1678 if (element_namespace.empty() && element_name == "attr") {
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001679 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001680 if (!maybe_name) {
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001681 diag_->Error(DiagMessage(item_source) << "<attr> tag must have a 'name' attribute");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001682 error = true;
1683 continue;
1684 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001685
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001686 // If this is a declaration, the package name may be in the name. Separate
1687 // these out.
1688 // Eg. <attr name="android:text" />
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001689 Maybe<Reference> maybe_ref = ResourceUtils::ParseXmlAttributeName(maybe_name.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001690 if (!maybe_ref) {
1691 diag_->Error(DiagMessage(item_source) << "<attr> tag has invalid name '"
1692 << maybe_name.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001693 error = true;
1694 continue;
1695 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001696
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001697 Reference& child_ref = maybe_ref.value();
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001698 xml::ResolvePackage(parser, &child_ref);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001699
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001700 // Create the ParsedResource that will add the attribute to the table.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001701 ParsedResource child_resource;
1702 child_resource.name = child_ref.name.value();
1703 child_resource.source = item_source;
1704 child_resource.comment = std::move(comment);
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001705 if (options_.visibility) {
1706 child_resource.visibility_level = options_.visibility.value();
1707 }
Adam Lesinski467f1712015-11-16 17:35:44 -08001708
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001709 if (!ParseAttrImpl(parser, &child_resource, true)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001710 error = true;
1711 continue;
1712 }
Adam Lesinski467f1712015-11-16 17:35:44 -08001713
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001714 // Create the reference to this attribute.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001715 child_ref.SetComment(child_resource.comment);
1716 child_ref.SetSource(item_source);
1717 styleable->entries.push_back(std::move(child_ref));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001718
Ryan Mitchellacde95c32019-04-23 05:44:21 -07001719 // Do not add referenced attributes that do not define a format to the table.
1720 CHECK(child_resource.value != nullptr);
1721 Attribute* attr = ValueCast<Attribute>(child_resource.value.get());
1722
1723 CHECK(attr != nullptr);
1724 if (attr->type_mask != android::ResTable_map::TYPE_ANY) {
1725 out_resource->child_resources.push_back(std::move(child_resource));
1726 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001727
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001728 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1729 diag_->Error(DiagMessage(item_source) << "unknown tag <"
1730 << element_namespace << ":"
1731 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001732 error = true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001733 }
1734
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001735 comment = {};
1736 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001737
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001738 if (error) {
1739 return false;
1740 }
1741
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001742 out_resource->value = std::move(styleable);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001743 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001744}
1745
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001746} // namespace aapt