Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 17 | #include "ResourceParser.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 18 | #include "ResourceTable.h" |
| 19 | #include "ResourceUtils.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 20 | #include "ResourceValues.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 21 | #include "util/Util.h" |
| 22 | #include "ValueVisitor.h" |
| 23 | #include "XmlPullParser.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 24 | |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 25 | #include <sstream> |
| 26 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 27 | namespace aapt { |
| 28 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 29 | constexpr const char16_t* sXliffNamespaceUri = u"urn:oasis:names:tc:xliff:document:1.2"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 30 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 31 | static Maybe<StringPiece16> findAttribute(XmlPullParser* parser, const StringPiece16& name) { |
| 32 | auto iter = parser->findAttribute(u"", name); |
| 33 | if (iter != parser->endAttributes()) { |
| 34 | return StringPiece16(util::trimWhitespace(iter->value)); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 35 | } |
| 36 | return {}; |
| 37 | } |
| 38 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 39 | static Maybe<StringPiece16> findNonEmptyAttribute(XmlPullParser* parser, |
| 40 | const StringPiece16& name) { |
| 41 | auto iter = parser->findAttribute(u"", name); |
| 42 | if (iter != parser->endAttributes()) { |
| 43 | StringPiece16 trimmed = util::trimWhitespace(iter->value); |
| 44 | if (!trimmed.empty()) { |
| 45 | return trimmed; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 46 | } |
| 47 | } |
| 48 | return {}; |
| 49 | } |
| 50 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 51 | ResourceParser::ResourceParser(IDiagnostics* diag, ResourceTable* table, const Source& source, |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 52 | const ConfigDescription& config, |
| 53 | const ResourceParserOptions& options) : |
| 54 | mDiag(diag), mTable(table), mSource(source), mConfig(config), mOptions(options) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 55 | } |
| 56 | |
| 57 | /** |
| 58 | * Build a string from XML that converts nested elements into Span objects. |
| 59 | */ |
| 60 | bool ResourceParser::flattenXmlSubtree(XmlPullParser* parser, std::u16string* outRawString, |
| 61 | StyleString* outStyleString) { |
| 62 | std::vector<Span> spanStack; |
| 63 | |
| 64 | outRawString->clear(); |
| 65 | outStyleString->spans.clear(); |
| 66 | util::StringBuilder builder; |
| 67 | size_t depth = 1; |
| 68 | while (XmlPullParser::isGoodEvent(parser->next())) { |
| 69 | const XmlPullParser::Event event = parser->getEvent(); |
| 70 | if (event == XmlPullParser::Event::kEndElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 71 | if (!parser->getElementNamespace().empty()) { |
| 72 | // We already warned and skipped the start element, so just skip here too |
| 73 | continue; |
| 74 | } |
| 75 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 76 | depth--; |
| 77 | if (depth == 0) { |
| 78 | break; |
| 79 | } |
| 80 | |
| 81 | spanStack.back().lastChar = builder.str().size(); |
| 82 | outStyleString->spans.push_back(spanStack.back()); |
| 83 | spanStack.pop_back(); |
| 84 | |
| 85 | } else if (event == XmlPullParser::Event::kText) { |
| 86 | // TODO(adamlesinski): Verify format strings. |
| 87 | outRawString->append(parser->getText()); |
| 88 | builder.append(parser->getText()); |
| 89 | |
| 90 | } else if (event == XmlPullParser::Event::kStartElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 91 | if (!parser->getElementNamespace().empty()) { |
| 92 | if (parser->getElementNamespace() != sXliffNamespaceUri) { |
| 93 | // Only warn if this isn't an xliff namespace. |
| 94 | mDiag->warn(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 95 | << "skipping element '" |
| 96 | << parser->getElementName() |
| 97 | << "' with unknown namespace '" |
| 98 | << parser->getElementNamespace() |
| 99 | << "'"); |
| 100 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 101 | continue; |
| 102 | } |
| 103 | depth++; |
| 104 | |
| 105 | // Build a span object out of the nested element. |
| 106 | std::u16string spanName = parser->getElementName(); |
| 107 | const auto endAttrIter = parser->endAttributes(); |
| 108 | for (auto attrIter = parser->beginAttributes(); attrIter != endAttrIter; ++attrIter) { |
| 109 | spanName += u";"; |
| 110 | spanName += attrIter->name; |
| 111 | spanName += u"="; |
| 112 | spanName += attrIter->value; |
| 113 | } |
| 114 | |
| 115 | if (builder.str().size() > std::numeric_limits<uint32_t>::max()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 116 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 117 | << "style string '" << builder.str() << "' is too long"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 118 | return false; |
| 119 | } |
| 120 | spanStack.push_back(Span{ spanName, static_cast<uint32_t>(builder.str().size()) }); |
| 121 | |
| 122 | } else if (event == XmlPullParser::Event::kComment) { |
| 123 | // Skip |
| 124 | } else { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 125 | assert(false); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 126 | } |
| 127 | } |
| 128 | assert(spanStack.empty() && "spans haven't been fully processed"); |
| 129 | |
| 130 | outStyleString->str = builder.str(); |
| 131 | return true; |
| 132 | } |
| 133 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 134 | bool ResourceParser::parse(XmlPullParser* parser) { |
| 135 | bool error = false; |
| 136 | const size_t depth = parser->getDepth(); |
| 137 | while (XmlPullParser::nextChildNode(parser, depth)) { |
| 138 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
| 139 | // Skip comments and text. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 140 | continue; |
| 141 | } |
| 142 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 143 | if (!parser->getElementNamespace().empty() || parser->getElementName() != u"resources") { |
| 144 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 145 | << "root element must be <resources>"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 146 | return false; |
| 147 | } |
| 148 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 149 | error |= !parseResources(parser); |
| 150 | break; |
| 151 | }; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 152 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 153 | if (parser->getEvent() == XmlPullParser::Event::kBadDocument) { |
| 154 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 155 | << "xml parser error: " << parser->getLastError()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 156 | return false; |
| 157 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 158 | return !error; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 159 | } |
| 160 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 161 | static bool shouldStripResource(XmlPullParser* parser, const Maybe<std::u16string> productToMatch) { |
| 162 | assert(parser->getEvent() == XmlPullParser::Event::kStartElement); |
| 163 | |
| 164 | if (Maybe<StringPiece16> maybeProduct = findNonEmptyAttribute(parser, u"product")) { |
| 165 | if (!productToMatch) { |
| 166 | if (maybeProduct.value() != u"default" && maybeProduct.value() != u"phone") { |
| 167 | // We didn't specify a product and this is not a default product, so skip. |
| 168 | return true; |
| 169 | } |
| 170 | } else { |
| 171 | if (productToMatch && maybeProduct.value() != productToMatch.value()) { |
| 172 | // We specified a product, but they don't match. |
| 173 | return true; |
| 174 | } |
| 175 | } |
| 176 | } |
| 177 | return false; |
| 178 | } |
| 179 | |
| 180 | /** |
| 181 | * A parsed resource ready to be added to the ResourceTable. |
| 182 | */ |
| 183 | struct ParsedResource { |
| 184 | ResourceName name; |
| 185 | Source source; |
| 186 | ResourceId id; |
| 187 | bool markPublic = false; |
| 188 | std::unique_ptr<Value> value; |
| 189 | std::list<ParsedResource> childResources; |
| 190 | }; |
| 191 | |
| 192 | // Recursively adds resources to the ResourceTable. |
| 193 | static bool addResourcesToTable(ResourceTable* table, const ConfigDescription& config, |
| 194 | IDiagnostics* diag, ParsedResource* res) { |
| 195 | if (res->markPublic && !table->markPublic(res->name, res->id, res->source, diag)) { |
| 196 | return false; |
| 197 | } |
| 198 | |
| 199 | if (!res->value) { |
| 200 | return true; |
| 201 | } |
| 202 | |
| 203 | if (!table->addResource(res->name, res->id, config, res->source, std::move(res->value), diag)) { |
| 204 | return false; |
| 205 | } |
| 206 | |
| 207 | bool error = false; |
| 208 | for (ParsedResource& child : res->childResources) { |
| 209 | error |= !addResourcesToTable(table, config, diag, &child); |
| 210 | } |
| 211 | return !error; |
| 212 | } |
| 213 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 214 | bool ResourceParser::parseResources(XmlPullParser* parser) { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 215 | std::set<ResourceName> strippedResources; |
| 216 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 217 | bool error = false; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 218 | std::u16string comment; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 219 | const size_t depth = parser->getDepth(); |
| 220 | while (XmlPullParser::nextChildNode(parser, depth)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 221 | const XmlPullParser::Event event = parser->getEvent(); |
| 222 | if (event == XmlPullParser::Event::kComment) { |
| 223 | comment = parser->getComment(); |
| 224 | continue; |
| 225 | } |
| 226 | |
| 227 | if (event == XmlPullParser::Event::kText) { |
| 228 | if (!util::trimWhitespace(parser->getText()).empty()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 229 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 230 | << "plain text not allowed here"); |
| 231 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 232 | } |
| 233 | continue; |
| 234 | } |
| 235 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 236 | assert(event == XmlPullParser::Event::kStartElement); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 237 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 238 | if (!parser->getElementNamespace().empty()) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 239 | // Skip unknown namespace. |
| 240 | continue; |
| 241 | } |
| 242 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 243 | std::u16string elementName = parser->getElementName(); |
| 244 | if (elementName == u"skip" || elementName == u"eat-comment") { |
| 245 | comment = u""; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 246 | continue; |
| 247 | } |
| 248 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 249 | Maybe<StringPiece16> maybeName = findNonEmptyAttribute(parser, u"name"); |
| 250 | if (!maybeName) { |
| 251 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 252 | << "<" << elementName << "> tag must have a 'name' attribute"); |
| 253 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 254 | continue; |
| 255 | } |
| 256 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 257 | // Check if we should skip this product. |
| 258 | const bool stripResource = shouldStripResource(parser, mOptions.product); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 259 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 260 | if (elementName == u"item") { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 261 | // Items simply have their type encoded in the type attribute. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 262 | if (Maybe<StringPiece16> maybeType = findNonEmptyAttribute(parser, u"type")) { |
| 263 | elementName = maybeType.value().toString(); |
| 264 | } else { |
| 265 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 266 | << "<item> must have a 'type' attribute"); |
| 267 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 268 | continue; |
| 269 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 270 | } |
| 271 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 272 | ParsedResource parsedResource; |
| 273 | parsedResource.name.entry = maybeName.value().toString(); |
| 274 | parsedResource.source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 275 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 276 | bool result = true; |
| 277 | if (elementName == u"id") { |
| 278 | parsedResource.name.type = ResourceType::kId; |
| 279 | parsedResource.value = util::make_unique<Id>(); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 280 | } else if (elementName == u"string") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 281 | parsedResource.name.type = ResourceType::kString; |
| 282 | result = parseString(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 283 | } else if (elementName == u"color") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 284 | parsedResource.name.type = ResourceType::kColor; |
| 285 | result = parseColor(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 286 | } else if (elementName == u"drawable") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 287 | parsedResource.name.type = ResourceType::kDrawable; |
| 288 | result = parseColor(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 289 | } else if (elementName == u"bool") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 290 | parsedResource.name.type = ResourceType::kBool; |
| 291 | result = parsePrimitive(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 292 | } else if (elementName == u"integer") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 293 | parsedResource.name.type = ResourceType::kInteger; |
| 294 | result = parsePrimitive(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 295 | } else if (elementName == u"dimen") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 296 | parsedResource.name.type = ResourceType::kDimen; |
| 297 | result = parsePrimitive(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 298 | } else if (elementName == u"style") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 299 | parsedResource.name.type = ResourceType::kStyle; |
| 300 | result = parseStyle(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 301 | } else if (elementName == u"plurals") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 302 | parsedResource.name.type = ResourceType::kPlurals; |
| 303 | result = parsePlural(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 304 | } else if (elementName == u"array") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 305 | parsedResource.name.type = ResourceType::kArray; |
| 306 | result = parseArray(parser, &parsedResource, android::ResTable_map::TYPE_ANY); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 307 | } else if (elementName == u"string-array") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 308 | parsedResource.name.type = ResourceType::kArray; |
| 309 | result = parseArray(parser, &parsedResource, android::ResTable_map::TYPE_STRING); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 310 | } else if (elementName == u"integer-array") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 311 | parsedResource.name.type = ResourceType::kIntegerArray; |
| 312 | result = parseArray(parser, &parsedResource, android::ResTable_map::TYPE_INTEGER); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 313 | } else if (elementName == u"declare-styleable") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 314 | parsedResource.name.type = ResourceType::kStyleable; |
| 315 | result = parseDeclareStyleable(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 316 | } else if (elementName == u"attr") { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 317 | parsedResource.name.type = ResourceType::kAttr; |
| 318 | result = parseAttr(parser, &parsedResource); |
| 319 | } else if (elementName == u"public") { |
| 320 | result = parsePublic(parser, &parsedResource); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 321 | } else { |
| 322 | mDiag->warn(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 323 | << "unknown resource type '" << elementName << "'"); |
| 324 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 325 | |
| 326 | if (result) { |
| 327 | // We successfully parsed the resource. |
| 328 | |
| 329 | if (stripResource) { |
| 330 | // Record that we stripped out this resource name. |
| 331 | // We will check that at least one variant of this resource was included. |
| 332 | strippedResources.insert(parsedResource.name); |
| 333 | } else { |
| 334 | error |= !addResourcesToTable(mTable, mConfig, mDiag, &parsedResource); |
| 335 | } |
| 336 | } else { |
| 337 | error = true; |
| 338 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 339 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 340 | |
| 341 | // Check that we included at least one variant of each stripped resource. |
| 342 | for (const ResourceName& strippedResource : strippedResources) { |
| 343 | if (!mTable->findResource(strippedResource)) { |
| 344 | // Failed to find the resource. |
| 345 | mDiag->error(DiagMessage(mSource) << "resource '" << strippedResource << "' " |
| 346 | "was filtered out but no product variant remains"); |
| 347 | error = true; |
| 348 | } |
| 349 | } |
| 350 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 351 | return !error; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 352 | } |
| 353 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 354 | enum { |
| 355 | kAllowRawString = true, |
| 356 | kNoRawString = false |
| 357 | }; |
| 358 | |
| 359 | /** |
| 360 | * Reads the entire XML subtree and attempts to parse it as some Item, |
| 361 | * with typeMask denoting which items it can be. If allowRawValue is |
| 362 | * true, a RawString is returned if the XML couldn't be parsed as |
| 363 | * an Item. If allowRawValue is false, nullptr is returned in this |
| 364 | * case. |
| 365 | */ |
| 366 | std::unique_ptr<Item> ResourceParser::parseXml(XmlPullParser* parser, uint32_t typeMask, |
| 367 | bool allowRawValue) { |
| 368 | const size_t beginXmlLine = parser->getLineNumber(); |
| 369 | |
| 370 | std::u16string rawValue; |
| 371 | StyleString styleString; |
| 372 | if (!flattenXmlSubtree(parser, &rawValue, &styleString)) { |
| 373 | return {}; |
| 374 | } |
| 375 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 376 | if (!styleString.spans.empty()) { |
| 377 | // This can only be a StyledString. |
| 378 | return util::make_unique<StyledString>( |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 379 | mTable->stringPool.makeRef(styleString, StringPool::Context{ 1, mConfig })); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 380 | } |
| 381 | |
| 382 | auto onCreateReference = [&](const ResourceName& name) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 383 | // name.package can be empty here, as it will assume the package name of the table. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 384 | mTable->addResource(name, {}, mSource.withLine(beginXmlLine), util::make_unique<Id>(), |
| 385 | mDiag); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 386 | }; |
| 387 | |
| 388 | // Process the raw value. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 389 | std::unique_ptr<Item> processedItem = ResourceUtils::parseItemForAttribute(rawValue, typeMask, |
| 390 | onCreateReference); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 391 | if (processedItem) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 392 | // Fix up the reference. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 393 | if (Reference* ref = valueCast<Reference>(processedItem.get())) { |
| 394 | if (Maybe<ResourceName> transformedName = |
| 395 | parser->transformPackage(ref->name.value(), u"")) { |
| 396 | ref->name = std::move(transformedName); |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 397 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 398 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 399 | return processedItem; |
| 400 | } |
| 401 | |
| 402 | // Try making a regular string. |
| 403 | if (typeMask & android::ResTable_map::TYPE_STRING) { |
| 404 | // Use the trimmed, escaped string. |
| 405 | return util::make_unique<String>( |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 406 | mTable->stringPool.makeRef(styleString.str, StringPool::Context{ 1, mConfig })); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 407 | } |
| 408 | |
| 409 | // We can't parse this so return a RawString if we are allowed. |
| 410 | if (allowRawValue) { |
| 411 | return util::make_unique<RawString>( |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 412 | mTable->stringPool.makeRef(rawValue, StringPool::Context{ 1, mConfig })); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 413 | } |
| 414 | return {}; |
| 415 | } |
| 416 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 417 | bool ResourceParser::parseString(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 418 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 419 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 420 | // TODO(adamlesinski): Read "untranslateable" attribute. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 421 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 422 | outResource->value = parseXml(parser, android::ResTable_map::TYPE_STRING, kNoRawString); |
| 423 | if (!outResource->value) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 424 | mDiag->error(DiagMessage(source) << "not a valid string"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 425 | return false; |
| 426 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 427 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 428 | } |
| 429 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 430 | bool ResourceParser::parseColor(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 431 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 432 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 433 | outResource->value = parseXml(parser, android::ResTable_map::TYPE_COLOR, kNoRawString); |
| 434 | if (!outResource->value) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 435 | mDiag->error(DiagMessage(source) << "invalid color"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 436 | return false; |
| 437 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 438 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 439 | } |
| 440 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 441 | bool ResourceParser::parsePrimitive(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 442 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 443 | |
| 444 | uint32_t typeMask = 0; |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 445 | switch (outResource->name.type) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 446 | case ResourceType::kInteger: |
| 447 | typeMask |= android::ResTable_map::TYPE_INTEGER; |
| 448 | break; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 449 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 450 | case ResourceType::kDimen: |
| 451 | typeMask |= android::ResTable_map::TYPE_DIMENSION |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 452 | | android::ResTable_map::TYPE_FLOAT |
| 453 | | android::ResTable_map::TYPE_FRACTION; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 454 | break; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 455 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 456 | case ResourceType::kBool: |
| 457 | typeMask |= android::ResTable_map::TYPE_BOOLEAN; |
| 458 | break; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 459 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 460 | default: |
| 461 | assert(false); |
| 462 | break; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 463 | } |
| 464 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 465 | outResource->value = parseXml(parser, typeMask, kNoRawString); |
| 466 | if (!outResource->value) { |
| 467 | mDiag->error(DiagMessage(source) << "invalid " << outResource->name.type); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 468 | return false; |
| 469 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 470 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 471 | } |
| 472 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 473 | bool ResourceParser::parsePublic(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 474 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 475 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 476 | Maybe<StringPiece16> maybeType = findNonEmptyAttribute(parser, u"type"); |
| 477 | if (!maybeType) { |
| 478 | mDiag->error(DiagMessage(source) << "<public> must have a 'type' attribute"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 479 | return false; |
| 480 | } |
| 481 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 482 | const ResourceType* parsedType = parseResourceType(maybeType.value()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 483 | if (!parsedType) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 484 | mDiag->error(DiagMessage(source) << "invalid resource type '" << maybeType.value() |
| 485 | << "' in <public>"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 486 | return false; |
| 487 | } |
| 488 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 489 | outResource->name.type = *parsedType; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 490 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 491 | if (Maybe<StringPiece16> maybeId = findNonEmptyAttribute(parser, u"id")) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 492 | android::Res_value val; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 493 | bool result = android::ResTable::stringToInt(maybeId.value().data(), |
| 494 | maybeId.value().size(), &val); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 495 | ResourceId resourceId(val.data); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 496 | if (!result || !resourceId.isValid()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 497 | mDiag->error(DiagMessage(source) << "invalid resource ID '" << maybeId.value() |
| 498 | << "' in <public>"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 499 | return false; |
| 500 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 501 | outResource->id = resourceId; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 502 | } |
| 503 | |
| 504 | if (*parsedType == ResourceType::kId) { |
| 505 | // An ID marked as public is also the definition of an ID. |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 506 | outResource->value = util::make_unique<Id>(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 507 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 508 | |
| 509 | outResource->markPublic = true; |
| 510 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 511 | } |
| 512 | |
| 513 | static uint32_t parseFormatType(const StringPiece16& piece) { |
| 514 | if (piece == u"reference") return android::ResTable_map::TYPE_REFERENCE; |
| 515 | else if (piece == u"string") return android::ResTable_map::TYPE_STRING; |
| 516 | else if (piece == u"integer") return android::ResTable_map::TYPE_INTEGER; |
| 517 | else if (piece == u"boolean") return android::ResTable_map::TYPE_BOOLEAN; |
| 518 | else if (piece == u"color") return android::ResTable_map::TYPE_COLOR; |
| 519 | else if (piece == u"float") return android::ResTable_map::TYPE_FLOAT; |
| 520 | else if (piece == u"dimension") return android::ResTable_map::TYPE_DIMENSION; |
| 521 | else if (piece == u"fraction") return android::ResTable_map::TYPE_FRACTION; |
| 522 | else if (piece == u"enum") return android::ResTable_map::TYPE_ENUM; |
| 523 | else if (piece == u"flags") return android::ResTable_map::TYPE_FLAGS; |
| 524 | return 0; |
| 525 | } |
| 526 | |
| 527 | static uint32_t parseFormatAttribute(const StringPiece16& str) { |
| 528 | uint32_t mask = 0; |
| 529 | for (StringPiece16 part : util::tokenize(str, u'|')) { |
| 530 | StringPiece16 trimmedPart = util::trimWhitespace(part); |
| 531 | uint32_t type = parseFormatType(trimmedPart); |
| 532 | if (type == 0) { |
| 533 | return 0; |
| 534 | } |
| 535 | mask |= type; |
| 536 | } |
| 537 | return mask; |
| 538 | } |
| 539 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 540 | |
| 541 | bool ResourceParser::parseAttr(XmlPullParser* parser, ParsedResource* outResource) { |
| 542 | outResource->source = mSource.withLine(parser->getLineNumber()); |
| 543 | return parseAttrImpl(parser, outResource, false); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 544 | } |
| 545 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 546 | bool ResourceParser::parseAttrImpl(XmlPullParser* parser, ParsedResource* outResource, bool weak) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 547 | uint32_t typeMask = 0; |
| 548 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 549 | Maybe<StringPiece16> maybeFormat = findAttribute(parser, u"format"); |
| 550 | if (maybeFormat) { |
| 551 | typeMask = parseFormatAttribute(maybeFormat.value()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 552 | if (typeMask == 0) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 553 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 554 | << "invalid attribute format '" << maybeFormat.value() << "'"); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 555 | return false; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 556 | } |
| 557 | } |
| 558 | |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 559 | // If this is a declaration, the package name may be in the name. Separate these out. |
| 560 | // Eg. <attr name="android:text" /> |
| 561 | // No format attribute is allowed. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 562 | if (weak && !maybeFormat) { |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 563 | StringPiece16 package, type, name; |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 564 | ResourceUtils::extractResourceName(outResource->name.entry, &package, &type, &name); |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 565 | if (type.empty() && !package.empty()) { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 566 | outResource->name.package = package.toString(); |
| 567 | outResource->name.entry = name.toString(); |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 568 | } |
| 569 | } |
| 570 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 571 | std::vector<Attribute::Symbol> items; |
| 572 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 573 | std::u16string comment; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 574 | bool error = false; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 575 | const size_t depth = parser->getDepth(); |
| 576 | while (XmlPullParser::nextChildNode(parser, depth)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 577 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 578 | // Skip comments and text. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 579 | continue; |
| 580 | } |
| 581 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 582 | const std::u16string& elementNamespace = parser->getElementNamespace(); |
| 583 | const std::u16string& elementName = parser->getElementName(); |
| 584 | if (elementNamespace == u"" && (elementName == u"flag" || elementName == u"enum")) { |
| 585 | if (elementName == u"enum") { |
| 586 | if (typeMask & android::ResTable_map::TYPE_FLAGS) { |
| 587 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 588 | << "can not define an <enum>; already defined a <flag>"); |
| 589 | error = true; |
| 590 | continue; |
| 591 | } |
| 592 | typeMask |= android::ResTable_map::TYPE_ENUM; |
| 593 | } else if (elementName == u"flag") { |
| 594 | if (typeMask & android::ResTable_map::TYPE_ENUM) { |
| 595 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 596 | << "can not define a <flag>; already defined an <enum>"); |
| 597 | error = true; |
| 598 | continue; |
| 599 | } |
| 600 | typeMask |= android::ResTable_map::TYPE_FLAGS; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 601 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 602 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 603 | if (Maybe<Attribute::Symbol> s = parseEnumOrFlagItem(parser, elementName)) { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 604 | ParsedResource childResource; |
| 605 | childResource.name = s.value().symbol.name.value(); |
| 606 | childResource.source = mSource.withLine(parser->getLineNumber()); |
| 607 | childResource.value = util::make_unique<Id>(); |
| 608 | outResource->childResources.push_back(std::move(childResource)); |
| 609 | items.push_back(std::move(s.value())); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 610 | } else { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 611 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 612 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 613 | } else if (elementName == u"skip" || elementName == u"eat-comment") { |
| 614 | comment = u""; |
| 615 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 616 | } else { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 617 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 618 | << ":" << elementName << ">"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 619 | error = true; |
| 620 | } |
| 621 | } |
| 622 | |
| 623 | if (error) { |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 624 | return false; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 625 | } |
| 626 | |
| 627 | std::unique_ptr<Attribute> attr = util::make_unique<Attribute>(weak); |
| 628 | attr->symbols.swap(items); |
Adam Lesinski | ca2fc35 | 2015-04-03 12:08:26 -0700 | [diff] [blame] | 629 | attr->typeMask = typeMask ? typeMask : uint32_t(android::ResTable_map::TYPE_ANY); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 630 | outResource->value = std::move(attr); |
| 631 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 632 | } |
| 633 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 634 | Maybe<Attribute::Symbol> ResourceParser::parseEnumOrFlagItem(XmlPullParser* parser, |
| 635 | const StringPiece16& tag) { |
| 636 | const Source source = mSource.withLine(parser->getLineNumber()); |
| 637 | |
| 638 | Maybe<StringPiece16> maybeName = findNonEmptyAttribute(parser, u"name"); |
| 639 | if (!maybeName) { |
| 640 | mDiag->error(DiagMessage(source) << "no attribute 'name' found for tag <" << tag << ">"); |
| 641 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 642 | } |
| 643 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 644 | Maybe<StringPiece16> maybeValue = findNonEmptyAttribute(parser, u"value"); |
| 645 | if (!maybeValue) { |
| 646 | mDiag->error(DiagMessage(source) << "no attribute 'value' found for tag <" << tag << ">"); |
| 647 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 648 | } |
| 649 | |
| 650 | android::Res_value val; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 651 | if (!android::ResTable::stringToInt(maybeValue.value().data(), |
| 652 | maybeValue.value().size(), &val)) { |
| 653 | mDiag->error(DiagMessage(source) << "invalid value '" << maybeValue.value() |
| 654 | << "' for <" << tag << ">; must be an integer"); |
| 655 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 656 | } |
| 657 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 658 | return Attribute::Symbol{ |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 659 | Reference(ResourceName{ {}, ResourceType::kId, maybeName.value().toString() }), |
| 660 | val.data }; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 661 | } |
| 662 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 663 | static Maybe<ResourceName> parseXmlAttributeName(StringPiece16 str) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 664 | str = util::trimWhitespace(str); |
| 665 | const char16_t* const start = str.data(); |
| 666 | const char16_t* const end = start + str.size(); |
| 667 | const char16_t* p = start; |
| 668 | |
| 669 | StringPiece16 package; |
| 670 | StringPiece16 name; |
| 671 | while (p != end) { |
| 672 | if (*p == u':') { |
| 673 | package = StringPiece16(start, p - start); |
| 674 | name = StringPiece16(p + 1, end - (p + 1)); |
| 675 | break; |
| 676 | } |
| 677 | p++; |
| 678 | } |
| 679 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 680 | return ResourceName{ package.toString(), ResourceType::kAttr, |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 681 | name.empty() ? str.toString() : name.toString() }; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 682 | } |
| 683 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 684 | |
| 685 | bool ResourceParser::parseStyleItem(XmlPullParser* parser, Style* style) { |
| 686 | const Source source = mSource.withLine(parser->getLineNumber()); |
| 687 | |
| 688 | Maybe<StringPiece16> maybeName = findNonEmptyAttribute(parser, u"name"); |
| 689 | if (!maybeName) { |
| 690 | mDiag->error(DiagMessage(source) << "<item> must have a 'name' attribute"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 691 | return false; |
| 692 | } |
| 693 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 694 | Maybe<ResourceName> maybeKey = parseXmlAttributeName(maybeName.value()); |
| 695 | if (!maybeKey) { |
| 696 | mDiag->error(DiagMessage(source) << "invalid attribute name '" << maybeName.value() << "'"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 697 | return false; |
| 698 | } |
| 699 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 700 | if (Maybe<ResourceName> transformedName = parser->transformPackage(maybeKey.value(), u"")) { |
| 701 | maybeKey = std::move(transformedName); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 702 | } |
| 703 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 704 | std::unique_ptr<Item> value = parseXml(parser, 0, kAllowRawString); |
| 705 | if (!value) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 706 | mDiag->error(DiagMessage(source) << "could not parse style item"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 707 | return false; |
| 708 | } |
| 709 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 710 | style->entries.push_back(Style::Entry{ Reference(maybeKey.value()), std::move(value) }); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 711 | return true; |
| 712 | } |
| 713 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 714 | bool ResourceParser::parseStyle(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 715 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 716 | std::unique_ptr<Style> style = util::make_unique<Style>(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 717 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 718 | Maybe<StringPiece16> maybeParent = findAttribute(parser, u"parent"); |
| 719 | if (maybeParent) { |
| 720 | // If the parent is empty, we don't have a parent, but we also don't infer either. |
| 721 | if (!maybeParent.value().empty()) { |
| 722 | std::string errStr; |
| 723 | style->parent = ResourceUtils::parseStyleParentReference(maybeParent.value(), &errStr); |
| 724 | if (!style->parent) { |
| 725 | mDiag->error(DiagMessage(source) << errStr); |
| 726 | return false; |
| 727 | } |
| 728 | |
| 729 | if (Maybe<ResourceName> transformedName = |
| 730 | parser->transformPackage(style->parent.value().name.value(), u"")) { |
| 731 | style->parent.value().name = std::move(transformedName); |
| 732 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 733 | } |
| 734 | |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 735 | } else { |
| 736 | // No parent was specified, so try inferring it from the style name. |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 737 | std::u16string styleName = outResource->name.entry; |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 738 | size_t pos = styleName.find_last_of(u'.'); |
| 739 | if (pos != std::string::npos) { |
| 740 | style->parentInferred = true; |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 741 | style->parent = Reference( |
| 742 | ResourceName({}, ResourceType::kStyle, styleName.substr(0, pos))); |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 743 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 744 | } |
| 745 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 746 | bool error = false; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 747 | std::u16string comment; |
| 748 | const size_t depth = parser->getDepth(); |
| 749 | while (XmlPullParser::nextChildNode(parser, depth)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 750 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 751 | // Skip text and comments. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 752 | continue; |
| 753 | } |
| 754 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 755 | const std::u16string& elementNamespace = parser->getElementNamespace(); |
| 756 | const std::u16string& elementName = parser->getElementName(); |
| 757 | if (elementNamespace == u"" && elementName == u"item") { |
| 758 | error |= !parseStyleItem(parser, style.get()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 759 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 760 | } else if (elementNamespace.empty() && |
| 761 | (elementName == u"skip" || elementName == u"eat-comment")) { |
| 762 | comment = u""; |
| 763 | |
| 764 | } else { |
| 765 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 766 | << ":" << elementName << ">"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 767 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 768 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 769 | } |
| 770 | |
| 771 | if (error) { |
| 772 | return false; |
| 773 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 774 | |
| 775 | outResource->value = std::move(style); |
| 776 | return true; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 777 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 778 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 779 | bool ResourceParser::parseArray(XmlPullParser* parser, ParsedResource* outResource, |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 780 | uint32_t typeMask) { |
| 781 | const Source source = mSource.withLine(parser->getLineNumber()); |
| 782 | std::unique_ptr<Array> array = util::make_unique<Array>(); |
| 783 | |
| 784 | std::u16string comment; |
| 785 | bool error = false; |
| 786 | const size_t depth = parser->getDepth(); |
| 787 | while (XmlPullParser::nextChildNode(parser, depth)) { |
| 788 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
| 789 | // Skip text and comments. |
| 790 | continue; |
| 791 | } |
| 792 | |
| 793 | const Source itemSource = mSource.withLine(parser->getLineNumber()); |
| 794 | const std::u16string& elementNamespace = parser->getElementNamespace(); |
| 795 | const std::u16string& elementName = parser->getElementName(); |
| 796 | if (elementNamespace.empty() && elementName == u"item") { |
| 797 | std::unique_ptr<Item> item = parseXml(parser, typeMask, kNoRawString); |
| 798 | if (!item) { |
| 799 | mDiag->error(DiagMessage(itemSource) << "could not parse array item"); |
| 800 | error = true; |
| 801 | continue; |
| 802 | } |
| 803 | array->items.emplace_back(std::move(item)); |
| 804 | |
| 805 | } else if (elementNamespace.empty() && |
| 806 | (elementName == u"skip" || elementName == u"eat-comment")) { |
| 807 | comment = u""; |
| 808 | |
| 809 | } else { |
| 810 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 811 | << "unknown tag <" << elementNamespace << ":" << elementName << ">"); |
| 812 | error = true; |
| 813 | } |
| 814 | } |
| 815 | |
| 816 | if (error) { |
| 817 | return false; |
| 818 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 819 | |
| 820 | outResource->value = std::move(array); |
| 821 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 822 | } |
| 823 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 824 | bool ResourceParser::parsePlural(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 825 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 826 | std::unique_ptr<Plural> plural = util::make_unique<Plural>(); |
| 827 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 828 | std::u16string comment; |
| 829 | bool error = false; |
| 830 | const size_t depth = parser->getDepth(); |
| 831 | while (XmlPullParser::nextChildNode(parser, depth)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 832 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 833 | // Skip text and comments. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 834 | continue; |
| 835 | } |
| 836 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 837 | const std::u16string& elementNamespace = parser->getElementNamespace(); |
| 838 | const std::u16string& elementName = parser->getElementName(); |
| 839 | if (elementNamespace.empty() && elementName == u"item") { |
| 840 | const auto endAttrIter = parser->endAttributes(); |
| 841 | auto attrIter = parser->findAttribute(u"", u"quantity"); |
| 842 | if (attrIter == endAttrIter || attrIter->value.empty()) { |
| 843 | mDiag->error(DiagMessage(source) << "<item> in <plurals> requires attribute " |
| 844 | << "'quantity'"); |
| 845 | error = true; |
| 846 | continue; |
| 847 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 848 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 849 | StringPiece16 trimmedQuantity = util::trimWhitespace(attrIter->value); |
| 850 | size_t index = 0; |
| 851 | if (trimmedQuantity == u"zero") { |
| 852 | index = Plural::Zero; |
| 853 | } else if (trimmedQuantity == u"one") { |
| 854 | index = Plural::One; |
| 855 | } else if (trimmedQuantity == u"two") { |
| 856 | index = Plural::Two; |
| 857 | } else if (trimmedQuantity == u"few") { |
| 858 | index = Plural::Few; |
| 859 | } else if (trimmedQuantity == u"many") { |
| 860 | index = Plural::Many; |
| 861 | } else if (trimmedQuantity == u"other") { |
| 862 | index = Plural::Other; |
| 863 | } else { |
| 864 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 865 | << "<item> in <plural> has invalid value '" << trimmedQuantity |
| 866 | << "' for attribute 'quantity'"); |
| 867 | error = true; |
| 868 | continue; |
| 869 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 870 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 871 | if (plural->values[index]) { |
| 872 | mDiag->error(DiagMessage(mSource.withLine(parser->getLineNumber())) |
| 873 | << "duplicate quantity '" << trimmedQuantity << "'"); |
| 874 | error = true; |
| 875 | continue; |
| 876 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 877 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 878 | if (!(plural->values[index] = parseXml(parser, android::ResTable_map::TYPE_STRING, |
| 879 | kNoRawString))) { |
| 880 | error = true; |
| 881 | } |
| 882 | } else if (elementNamespace.empty() && |
| 883 | (elementName == u"skip" || elementName == u"eat-comment")) { |
| 884 | comment = u""; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 885 | } else { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 886 | mDiag->error(DiagMessage(source) << "unknown tag <" << elementNamespace << ":" |
| 887 | << elementName << ">"); |
| 888 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 889 | } |
| 890 | } |
| 891 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 892 | if (error) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 893 | return false; |
| 894 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 895 | |
| 896 | outResource->value = std::move(plural); |
| 897 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 898 | } |
| 899 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 900 | bool ResourceParser::parseDeclareStyleable(XmlPullParser* parser, ParsedResource* outResource) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 901 | const Source source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 902 | std::unique_ptr<Styleable> styleable = util::make_unique<Styleable>(); |
| 903 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 904 | std::u16string comment; |
| 905 | bool error = false; |
| 906 | const size_t depth = parser->getDepth(); |
| 907 | while (XmlPullParser::nextChildNode(parser, depth)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 908 | if (parser->getEvent() != XmlPullParser::Event::kStartElement) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 909 | // Ignore text and comments. |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 910 | continue; |
| 911 | } |
| 912 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 913 | const std::u16string& elementNamespace = parser->getElementNamespace(); |
| 914 | const std::u16string& elementName = parser->getElementName(); |
| 915 | if (elementNamespace.empty() && elementName == u"attr") { |
| 916 | const auto endAttrIter = parser->endAttributes(); |
| 917 | auto attrIter = parser->findAttribute(u"", u"name"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 918 | if (attrIter == endAttrIter || attrIter->value.empty()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 919 | mDiag->error(DiagMessage(source) << "<attr> tag must have a 'name' attribute"); |
| 920 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 921 | continue; |
| 922 | } |
| 923 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 924 | ParsedResource childResource; |
| 925 | childResource.name = ResourceName({}, ResourceType::kAttr, attrIter->value); |
| 926 | childResource.source = mSource.withLine(parser->getLineNumber()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 927 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 928 | if (!parseAttrImpl(parser, &childResource, true)) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 929 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 930 | continue; |
| 931 | } |
| 932 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 933 | styleable->entries.push_back(Reference(childResource.name)); |
| 934 | outResource->childResources.push_back(std::move(childResource)); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 935 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 936 | } else if (elementNamespace.empty() && |
| 937 | (elementName == u"skip" || elementName == u"eat-comment")) { |
| 938 | comment = u""; |
| 939 | |
| 940 | } else { |
| 941 | mDiag->error(DiagMessage(source) << "unknown tag <" << elementNamespace << ":" |
| 942 | << elementName << ">"); |
| 943 | error = true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 944 | } |
| 945 | } |
| 946 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 947 | if (error) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 948 | return false; |
| 949 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame^] | 950 | |
| 951 | outResource->value = std::move(styleable); |
| 952 | return true; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 953 | } |
| 954 | |
| 955 | } // namespace aapt |