Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "ConfigDescription.h" |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 18 | #include "NameMangler.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 19 | #include "ResourceTable.h" |
| 20 | #include "ResourceValues.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 21 | #include "ValueVisitor.h" |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 22 | |
| 23 | #include "util/Comparators.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 24 | #include "util/Util.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 25 | |
| 26 | #include <algorithm> |
| 27 | #include <androidfw/ResourceTypes.h> |
| 28 | #include <memory> |
| 29 | #include <string> |
| 30 | #include <tuple> |
| 31 | |
| 32 | namespace aapt { |
| 33 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 34 | static bool lessThanType(const std::unique_ptr<ResourceTableType>& lhs, ResourceType rhs) { |
| 35 | return lhs->type < rhs; |
| 36 | } |
| 37 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 38 | template <typename T> |
| 39 | static bool lessThanStructWithName(const std::unique_ptr<T>& lhs, |
| 40 | const StringPiece16& rhs) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 41 | return lhs->name.compare(0, lhs->name.size(), rhs.data(), rhs.size()) < 0; |
| 42 | } |
| 43 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 44 | ResourceTablePackage* ResourceTable::findPackage(const StringPiece16& name) { |
| 45 | const auto last = packages.end(); |
| 46 | auto iter = std::lower_bound(packages.begin(), last, name, |
| 47 | lessThanStructWithName<ResourceTablePackage>); |
| 48 | if (iter != last && name == (*iter)->name) { |
| 49 | return iter->get(); |
| 50 | } |
| 51 | return nullptr; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 52 | } |
| 53 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 54 | ResourceTablePackage* ResourceTable::findPackageById(uint8_t id) { |
| 55 | for (auto& package : packages) { |
| 56 | if (package->id && package->id.value() == id) { |
| 57 | return package.get(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 58 | } |
| 59 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 60 | return nullptr; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 61 | } |
| 62 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 63 | ResourceTablePackage* ResourceTable::createPackage(const StringPiece16& name, Maybe<uint8_t> id) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 64 | ResourceTablePackage* package = findOrCreatePackage(name); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 65 | if (id && !package->id) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 66 | package->id = id; |
| 67 | return package; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 68 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 69 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 70 | if (id && package->id && package->id.value() != id.value()) { |
| 71 | return nullptr; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 72 | } |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 73 | return package; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 74 | } |
| 75 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 76 | ResourceTablePackage* ResourceTable::findOrCreatePackage(const StringPiece16& name) { |
| 77 | const auto last = packages.end(); |
| 78 | auto iter = std::lower_bound(packages.begin(), last, name, |
| 79 | lessThanStructWithName<ResourceTablePackage>); |
| 80 | if (iter != last && name == (*iter)->name) { |
| 81 | return iter->get(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 82 | } |
| 83 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 84 | std::unique_ptr<ResourceTablePackage> newPackage = util::make_unique<ResourceTablePackage>(); |
| 85 | newPackage->name = name.toString(); |
| 86 | return packages.emplace(iter, std::move(newPackage))->get(); |
| 87 | } |
| 88 | |
| 89 | ResourceTableType* ResourceTablePackage::findType(ResourceType type) { |
| 90 | const auto last = types.end(); |
| 91 | auto iter = std::lower_bound(types.begin(), last, type, lessThanType); |
| 92 | if (iter != last && (*iter)->type == type) { |
| 93 | return iter->get(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 94 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 95 | return nullptr; |
| 96 | } |
| 97 | |
| 98 | ResourceTableType* ResourceTablePackage::findOrCreateType(ResourceType type) { |
| 99 | const auto last = types.end(); |
| 100 | auto iter = std::lower_bound(types.begin(), last, type, lessThanType); |
| 101 | if (iter != last && (*iter)->type == type) { |
| 102 | return iter->get(); |
| 103 | } |
| 104 | return types.emplace(iter, new ResourceTableType{ type })->get(); |
| 105 | } |
| 106 | |
| 107 | ResourceEntry* ResourceTableType::findEntry(const StringPiece16& name) { |
| 108 | const auto last = entries.end(); |
| 109 | auto iter = std::lower_bound(entries.begin(), last, name, |
| 110 | lessThanStructWithName<ResourceEntry>); |
| 111 | if (iter != last && name == (*iter)->name) { |
| 112 | return iter->get(); |
| 113 | } |
| 114 | return nullptr; |
| 115 | } |
| 116 | |
| 117 | ResourceEntry* ResourceTableType::findOrCreateEntry(const StringPiece16& name) { |
| 118 | auto last = entries.end(); |
| 119 | auto iter = std::lower_bound(entries.begin(), last, name, |
| 120 | lessThanStructWithName<ResourceEntry>); |
| 121 | if (iter != last && name == (*iter)->name) { |
| 122 | return iter->get(); |
| 123 | } |
| 124 | return entries.emplace(iter, new ResourceEntry{ name })->get(); |
| 125 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 126 | |
| 127 | /** |
| 128 | * The default handler for collisions. A return value of -1 means keep the |
| 129 | * existing value, 0 means fail, and +1 means take the incoming value. |
| 130 | */ |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 131 | int ResourceTable::resolveValueCollision(Value* existing, Value* incoming) { |
| 132 | Attribute* existingAttr = valueCast<Attribute>(existing); |
| 133 | Attribute* incomingAttr = valueCast<Attribute>(incoming); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 134 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 135 | if (!incomingAttr) { |
| 136 | if (incoming->isWeak()) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 137 | // We're trying to add a weak resource but a resource |
| 138 | // already exists. Keep the existing. |
| 139 | return -1; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 140 | } else if (existing->isWeak()) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 141 | // Override the weak resource with the new strong resource. |
| 142 | return 1; |
| 143 | } |
| 144 | // The existing and incoming values are strong, this is an error |
| 145 | // if the values are not both attributes. |
| 146 | return 0; |
| 147 | } |
| 148 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 149 | if (!existingAttr) { |
| 150 | if (existing->isWeak()) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 151 | // The existing value is not an attribute and it is weak, |
| 152 | // so take the incoming attribute value. |
| 153 | return 1; |
| 154 | } |
| 155 | // The existing value is not an attribute and it is strong, |
| 156 | // so the incoming attribute value is an error. |
| 157 | return 0; |
| 158 | } |
| 159 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 160 | assert(incomingAttr && existingAttr); |
| 161 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 162 | // |
| 163 | // Attribute specific handling. At this point we know both |
| 164 | // values are attributes. Since we can declare and define |
| 165 | // attributes all-over, we do special handling to see |
| 166 | // which definition sticks. |
| 167 | // |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 168 | if (existingAttr->typeMask == incomingAttr->typeMask) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 169 | // The two attributes are both DECLs, but they are plain attributes |
| 170 | // with the same formats. |
| 171 | // Keep the strongest one. |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 172 | return existingAttr->isWeak() ? 1 : -1; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 173 | } |
| 174 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 175 | if (existingAttr->isWeak() && existingAttr->typeMask == android::ResTable_map::TYPE_ANY) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 176 | // Any incoming attribute is better than this. |
| 177 | return 1; |
| 178 | } |
| 179 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 180 | if (incomingAttr->isWeak() && incomingAttr->typeMask == android::ResTable_map::TYPE_ANY) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 181 | // The incoming attribute may be a USE instead of a DECL. |
| 182 | // Keep the existing attribute. |
| 183 | return -1; |
| 184 | } |
| 185 | return 0; |
| 186 | } |
| 187 | |
| 188 | static constexpr const char16_t* kValidNameChars = u"._-"; |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 189 | static constexpr const char16_t* kValidNameMangledChars = u"._-$"; |
| 190 | |
| 191 | bool ResourceTable::addResource(const ResourceNameRef& name, const ConfigDescription& config, |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 192 | std::unique_ptr<Value> value, IDiagnostics* diag) { |
| 193 | return addResourceImpl(name, {}, config, std::move(value), kValidNameChars, diag); |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 194 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 195 | |
| 196 | bool ResourceTable::addResource(const ResourceNameRef& name, const ResourceId resId, |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 197 | const ConfigDescription& config, std::unique_ptr<Value> value, |
| 198 | IDiagnostics* diag) { |
| 199 | return addResourceImpl(name, resId, config, std::move(value), kValidNameChars, diag); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 200 | } |
| 201 | |
| 202 | bool ResourceTable::addFileReference(const ResourceNameRef& name, const ConfigDescription& config, |
| 203 | const Source& source, const StringPiece16& path, |
| 204 | IDiagnostics* diag) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 205 | std::unique_ptr<FileReference> fileRef = util::make_unique<FileReference>( |
| 206 | stringPool.makeRef(path)); |
| 207 | fileRef->setSource(source); |
| 208 | return addResourceImpl(name, ResourceId{}, config, std::move(fileRef), kValidNameChars, diag); |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 209 | } |
| 210 | |
| 211 | bool ResourceTable::addResourceAllowMangled(const ResourceNameRef& name, |
| 212 | const ConfigDescription& config, |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 213 | std::unique_ptr<Value> value, |
| 214 | IDiagnostics* diag) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 215 | return addResourceImpl(name, ResourceId{}, config, std::move(value), kValidNameMangledChars, |
| 216 | diag); |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 217 | } |
| 218 | |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 219 | bool ResourceTable::addResourceAllowMangled(const ResourceNameRef& name, |
| 220 | const ResourceId id, |
| 221 | const ConfigDescription& config, |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 222 | std::unique_ptr<Value> value, |
| 223 | IDiagnostics* diag) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 224 | return addResourceImpl(name, id, config, std::move(value), kValidNameMangledChars, diag); |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 225 | } |
| 226 | |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 227 | bool ResourceTable::addResourceImpl(const ResourceNameRef& name, const ResourceId resId, |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 228 | const ConfigDescription& config, std::unique_ptr<Value> value, |
| 229 | const char16_t* validChars, IDiagnostics* diag) { |
| 230 | assert(value && "value can't be nullptr"); |
| 231 | assert(diag && "diagnostics can't be nullptr"); |
| 232 | |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 233 | auto badCharIter = util::findNonAlphaNumericAndNotInSet(name.entry, validChars); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 234 | if (badCharIter != name.entry.end()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 235 | diag->error(DiagMessage(value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 236 | << "resource '" |
| 237 | << name |
| 238 | << "' has invalid entry name '" |
| 239 | << name.entry |
| 240 | << "'. Invalid character '" |
| 241 | << StringPiece16(badCharIter, 1) |
| 242 | << "'"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 243 | return false; |
| 244 | } |
| 245 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 246 | ResourceTablePackage* package = findOrCreatePackage(name.package); |
| 247 | if (resId.isValid() && package->id && package->id.value() != resId.packageId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 248 | diag->error(DiagMessage(value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 249 | << "trying to add resource '" |
| 250 | << name |
| 251 | << "' with ID " |
| 252 | << resId |
| 253 | << " but package '" |
| 254 | << package->name |
| 255 | << "' already has ID " |
| 256 | << std::hex << (int) package->id.value() << std::dec); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 257 | return false; |
| 258 | } |
| 259 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 260 | ResourceTableType* type = package->findOrCreateType(name.type); |
| 261 | if (resId.isValid() && type->id && type->id.value() != resId.typeId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 262 | diag->error(DiagMessage(value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 263 | << "trying to add resource '" |
| 264 | << name |
| 265 | << "' with ID " |
| 266 | << resId |
| 267 | << " but type '" |
| 268 | << type->type |
| 269 | << "' already has ID " |
| 270 | << std::hex << (int) type->id.value() << std::dec); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 271 | return false; |
| 272 | } |
| 273 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 274 | ResourceEntry* entry = type->findOrCreateEntry(name.entry); |
| 275 | if (resId.isValid() && entry->id && entry->id.value() != resId.entryId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 276 | diag->error(DiagMessage(value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 277 | << "trying to add resource '" |
| 278 | << name |
| 279 | << "' with ID " |
| 280 | << resId |
| 281 | << " but resource already has ID " |
| 282 | << ResourceId(package->id.value(), type->id.value(), entry->id.value())); |
| 283 | return false; |
| 284 | } |
| 285 | |
| 286 | const auto endIter = entry->values.end(); |
Adam Lesinski | b274e35 | 2015-11-06 15:14:35 -0800 | [diff] [blame^] | 287 | auto iter = std::lower_bound(entry->values.begin(), endIter, config, cmp::lessThanConfig); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 288 | if (iter == endIter || iter->config != config) { |
| 289 | // This resource did not exist before, add it. |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 290 | entry->values.insert(iter, ResourceConfigValue{ config, std::move(value) }); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 291 | } else { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 292 | int collisionResult = resolveValueCollision(iter->value.get(), value.get()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 293 | if (collisionResult > 0) { |
| 294 | // Take the incoming value. |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 295 | iter->value = std::move(value); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 296 | } else if (collisionResult == 0) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 297 | diag->error(DiagMessage(value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 298 | << "duplicate value for resource '" << name << "' " |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 299 | << "with config '" << config << "'"); |
| 300 | diag->error(DiagMessage(iter->value->getSource()) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 301 | << "resource previously defined here"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 302 | return false; |
| 303 | } |
| 304 | } |
| 305 | |
| 306 | if (resId.isValid()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 307 | package->id = resId.packageId(); |
| 308 | type->id = resId.typeId(); |
| 309 | entry->id = resId.entryId(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 310 | } |
| 311 | return true; |
| 312 | } |
| 313 | |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 314 | bool ResourceTable::setSymbolState(const ResourceNameRef& name, const ResourceId resId, |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 315 | const Symbol& symbol, IDiagnostics* diag) { |
| 316 | return setSymbolStateImpl(name, resId, symbol, kValidNameChars, diag); |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 317 | } |
| 318 | |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 319 | bool ResourceTable::setSymbolStateAllowMangled(const ResourceNameRef& name, |
| 320 | const ResourceId resId, |
| 321 | const Symbol& symbol, IDiagnostics* diag) { |
| 322 | return setSymbolStateImpl(name, resId, symbol, kValidNameMangledChars, diag); |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 323 | } |
| 324 | |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 325 | bool ResourceTable::setSymbolStateImpl(const ResourceNameRef& name, const ResourceId resId, |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 326 | const Symbol& symbol, const char16_t* validChars, |
| 327 | IDiagnostics* diag) { |
| 328 | assert(diag && "diagnostics can't be nullptr"); |
| 329 | |
| 330 | if (symbol.state == SymbolState::kUndefined) { |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 331 | // Nothing to do. |
| 332 | return true; |
| 333 | } |
| 334 | |
Adam Lesinski | 330edcd | 2015-05-04 17:40:56 -0700 | [diff] [blame] | 335 | auto badCharIter = util::findNonAlphaNumericAndNotInSet(name.entry, validChars); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 336 | if (badCharIter != name.entry.end()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 337 | diag->error(DiagMessage(symbol.source) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 338 | << "resource '" |
| 339 | << name |
| 340 | << "' has invalid entry name '" |
| 341 | << name.entry |
| 342 | << "'. Invalid character '" |
| 343 | << StringPiece16(badCharIter, 1) |
| 344 | << "'"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 345 | return false; |
| 346 | } |
| 347 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 348 | ResourceTablePackage* package = findOrCreatePackage(name.package); |
| 349 | if (resId.isValid() && package->id && package->id.value() != resId.packageId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 350 | diag->error(DiagMessage(symbol.source) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 351 | << "trying to add resource '" |
| 352 | << name |
| 353 | << "' with ID " |
| 354 | << resId |
| 355 | << " but package '" |
| 356 | << package->name |
| 357 | << "' already has ID " |
| 358 | << std::hex << (int) package->id.value() << std::dec); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 359 | return false; |
| 360 | } |
| 361 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 362 | ResourceTableType* type = package->findOrCreateType(name.type); |
| 363 | if (resId.isValid() && type->id && type->id.value() != resId.typeId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 364 | diag->error(DiagMessage(symbol.source) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 365 | << "trying to add resource '" |
| 366 | << name |
| 367 | << "' with ID " |
| 368 | << resId |
| 369 | << " but type '" |
| 370 | << type->type |
| 371 | << "' already has ID " |
| 372 | << std::hex << (int) type->id.value() << std::dec); |
| 373 | return false; |
| 374 | } |
| 375 | |
| 376 | ResourceEntry* entry = type->findOrCreateEntry(name.entry); |
| 377 | if (resId.isValid() && entry->id && entry->id.value() != resId.entryId()) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 378 | diag->error(DiagMessage(symbol.source) |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 379 | << "trying to add resource '" |
| 380 | << name |
| 381 | << "' with ID " |
| 382 | << resId |
| 383 | << " but resource already has ID " |
| 384 | << ResourceId(package->id.value(), type->id.value(), entry->id.value())); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 385 | return false; |
| 386 | } |
| 387 | |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 388 | // Only mark the type state as public, it doesn't care about being private. |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 389 | if (symbol.state == SymbolState::kPublic) { |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 390 | type->symbolStatus.state = SymbolState::kPublic; |
| 391 | } |
| 392 | |
| 393 | // Downgrading to a private symbol from a public one is not allowed. |
| 394 | if (entry->symbolStatus.state != SymbolState::kPublic) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 395 | if (entry->symbolStatus.state != symbol.state) { |
| 396 | entry->symbolStatus = std::move(symbol); |
Adam Lesinski | 9e10ac7 | 2015-10-16 14:37:48 -0700 | [diff] [blame] | 397 | } |
| 398 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 399 | |
| 400 | if (resId.isValid()) { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 401 | package->id = resId.packageId(); |
| 402 | type->id = resId.typeId(); |
| 403 | entry->id = resId.entryId(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 404 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 405 | return true; |
| 406 | } |
| 407 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 408 | Maybe<ResourceTable::SearchResult> |
| 409 | ResourceTable::findResource(const ResourceNameRef& name) { |
| 410 | ResourceTablePackage* package = findPackage(name.package); |
| 411 | if (!package) { |
Adam Lesinski | ca2fc35 | 2015-04-03 12:08:26 -0700 | [diff] [blame] | 412 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 413 | } |
| 414 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 415 | ResourceTableType* type = package->findType(name.type); |
| 416 | if (!type) { |
Adam Lesinski | ca2fc35 | 2015-04-03 12:08:26 -0700 | [diff] [blame] | 417 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 418 | } |
| 419 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 420 | ResourceEntry* entry = type->findEntry(name.entry); |
| 421 | if (!entry) { |
Adam Lesinski | ca2fc35 | 2015-04-03 12:08:26 -0700 | [diff] [blame] | 422 | return {}; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 423 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 424 | return SearchResult{ package, type, entry }; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 425 | } |
| 426 | |
| 427 | } // namespace aapt |