blob: be787b2727ad0a569a1bfb9c323858bd3a659acf [file] [log] [blame]
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Adam Lesinskice5e56e2016-10-21 17:56:45 -070017#include "link/ReferenceLinker.h"
18
19#include "android-base/logging.h"
20#include "androidfw/ResourceTypes.h"
21
Adam Lesinskicacb28f2016-10-19 12:18:14 -070022#include "Diagnostics.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070023#include "ResourceTable.h"
24#include "ResourceUtils.h"
25#include "ResourceValues.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070026#include "ValueVisitor.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070027#include "link/Linkers.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070028#include "process/IResourceTableConsumer.h"
29#include "process/SymbolTable.h"
Adam Lesinski467f1712015-11-16 17:35:44 -080030#include "util/Util.h"
31#include "xml/XmlUtil.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070032
Adam Lesinski1ab598f2015-08-14 14:26:04 -070033namespace aapt {
34
35namespace {
36
37/**
Adam Lesinskicacb28f2016-10-19 12:18:14 -070038 * The ReferenceLinkerVisitor will follow all references and make sure they
39 * point
40 * to resources that actually exist, either in the local resource table, or as
41 * external
42 * symbols. Once the target resource has been found, the ID of the resource will
43 * be assigned
Adam Lesinski1ab598f2015-08-14 14:26:04 -070044 * to the reference object.
45 *
46 * NOTE: All of the entries in the ResourceTable must be assigned IDs.
47 */
Adam Lesinski467f1712015-11-16 17:35:44 -080048class ReferenceLinkerVisitor : public ValueVisitor {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070049 public:
Adam Lesinskice5e56e2016-10-21 17:56:45 -070050 using ValueVisitor::Visit;
Adam Lesinski1ab598f2015-08-14 14:26:04 -070051
Adam Lesinskicacb28f2016-10-19 12:18:14 -070052 ReferenceLinkerVisitor(IAaptContext* context, SymbolTable* symbols,
Adam Lesinskice5e56e2016-10-21 17:56:45 -070053 StringPool* string_pool, xml::IPackageDeclStack* decl,
54 CallSite* callsite)
55 : context_(context),
56 symbols_(symbols),
57 package_decls_(decl),
58 string_pool_(string_pool),
59 callsite_(callsite) {}
Adam Lesinskicacb28f2016-10-19 12:18:14 -070060
Adam Lesinskice5e56e2016-10-21 17:56:45 -070061 void Visit(Reference* ref) override {
62 if (!ReferenceLinker::LinkReference(ref, context_, symbols_, package_decls_,
63 callsite_)) {
64 error_ = true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -070065 }
66 }
67
68 /**
69 * We visit the Style specially because during this phase, values of
70 * attributes are
71 * all RawString values. Now that we are expected to resolve all symbols, we
72 * can
73 * lookup the attributes to find out which types are allowed for the
74 * attributes' values.
75 */
Adam Lesinskice5e56e2016-10-21 17:56:45 -070076 void Visit(Style* style) override {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070077 if (style->parent) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -070078 Visit(&style->parent.value());
Adam Lesinski1ab598f2015-08-14 14:26:04 -070079 }
80
Adam Lesinskicacb28f2016-10-19 12:18:14 -070081 for (Style::Entry& entry : style->entries) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -070082 std::string err_str;
Adam Lesinski1ab598f2015-08-14 14:26:04 -070083
Adam Lesinskicacb28f2016-10-19 12:18:14 -070084 // Transform the attribute reference so that it is using the fully
85 // qualified package
86 // name. This will also mark the reference as being able to see private
87 // resources if
88 // there was a '*' in the reference or if the package came from the
89 // private namespace.
Adam Lesinskice5e56e2016-10-21 17:56:45 -070090 Reference transformed_reference = entry.key;
91 TransformReferenceFromNamespace(package_decls_,
92 context_->GetCompilationPackage(),
93 &transformed_reference);
Adam Lesinskicacb28f2016-10-19 12:18:14 -070094
95 // Find the attribute in the symbol table and check if it is visible from
96 // this callsite.
97 const SymbolTable::Symbol* symbol =
Adam Lesinskice5e56e2016-10-21 17:56:45 -070098 ReferenceLinker::ResolveAttributeCheckVisibility(
99 transformed_reference, context_->GetNameMangler(), symbols_,
100 callsite_, &err_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700101 if (symbol) {
102 // Assign our style key the correct ID.
103 // The ID may not exist.
104 entry.key.id = symbol->id;
105
106 // Try to convert the value to a more specific, typed value based on the
107 // attribute it is set to.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700108 entry.value = ParseValueWithAttribute(std::move(entry.value),
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700109 symbol->attribute.get());
110
111 // Link/resolve the final value (mostly if it's a reference).
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700112 entry.value->Accept(this);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700113
114 // Now verify that the type of this item is compatible with the
115 // attribute it
116 // is defined for. We pass `nullptr` as the DiagMessage so that this
117 // check is
118 // fast and we avoid creating a DiagMessage when the match is
119 // successful.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700120 if (!symbol->attribute->Matches(entry.value.get(), nullptr)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700121 // The actual type of this item is incompatible with the attribute.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700122 DiagMessage msg(entry.key.GetSource());
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700123
124 // Call the matches method again, this time with a DiagMessage so we
125 // fill
126 // in the actual error message.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700127 symbol->attribute->Matches(entry.value.get(), &msg);
128 context_->GetDiagnostics()->Error(msg);
129 error_ = true;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700130 }
131
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700132 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700133 DiagMessage msg(entry.key.GetSource());
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700134 msg << "style attribute '";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700135 ReferenceLinker::WriteResourceName(&msg, entry.key,
136 transformed_reference);
137 msg << "' " << err_str;
138 context_->GetDiagnostics()->Error(msg);
139 error_ = true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700140 }
141 }
142 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800143
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700144 bool HasError() { return error_; }
Adam Lesinski467f1712015-11-16 17:35:44 -0800145
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700146 private:
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700147 DISALLOW_COPY_AND_ASSIGN(ReferenceLinkerVisitor);
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700148
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700149 /**
150 * Transform a RawString value into a more specific, appropriate value, based
151 * on the
152 * Attribute. If a non RawString value is passed in, this is an identity
153 * transform.
154 */
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700155 std::unique_ptr<Item> ParseValueWithAttribute(std::unique_ptr<Item> value,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700156 const Attribute* attr) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700157 if (RawString* raw_string = ValueCast<RawString>(value.get())) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700158 std::unique_ptr<Item> transformed =
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700159 ResourceUtils::TryParseItemForAttribute(*raw_string->value, attr);
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700160
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700161 // If we could not parse as any specific type, try a basic STRING.
162 if (!transformed &&
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700163 (attr->type_mask & android::ResTable_map::TYPE_STRING)) {
164 util::StringBuilder string_builder;
165 string_builder.Append(*raw_string->value);
166 if (string_builder) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700167 transformed = util::make_unique<String>(
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700168 string_pool_->MakeRef(string_builder.ToString()));
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700169 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700170 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700171
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700172 if (transformed) {
173 return transformed;
174 }
175 };
176 return value;
177 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700178
179 IAaptContext* context_;
180 SymbolTable* symbols_;
181 xml::IPackageDeclStack* package_decls_;
182 StringPool* string_pool_;
183 CallSite* callsite_;
184 bool error_ = false;
185};
186
187class EmptyDeclStack : public xml::IPackageDeclStack {
188 public:
189 EmptyDeclStack() = default;
190
191 Maybe<xml::ExtractedPackage> TransformPackageAlias(
192 const StringPiece& alias,
193 const StringPiece& local_package) const override {
194 if (alias.empty()) {
195 return xml::ExtractedPackage{local_package.ToString(),
196 true /* private */};
197 }
198 return {};
199 }
200
201 private:
202 DISALLOW_COPY_AND_ASSIGN(EmptyDeclStack);
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700203};
204
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700205} // namespace
Adam Lesinski467f1712015-11-16 17:35:44 -0800206
207/**
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700208 * The symbol is visible if it is public, or if the reference to it is
209 * requesting private access
Adam Lesinski467f1712015-11-16 17:35:44 -0800210 * or if the callsite comes from the same package.
211 */
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700212bool ReferenceLinker::IsSymbolVisible(const SymbolTable::Symbol& symbol,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700213 const Reference& ref,
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700214 const CallSite& callsite) {
215 if (!symbol.is_public && !ref.private_reference) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700216 if (ref.name) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700217 return callsite.resource.package == ref.name.value().package;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700218 } else if (ref.id && symbol.id) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700219 return ref.id.value().package_id() == symbol.id.value().package_id();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700220 } else {
221 return false;
Adam Lesinski467f1712015-11-16 17:35:44 -0800222 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700223 }
224 return true;
Adam Lesinski467f1712015-11-16 17:35:44 -0800225}
226
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700227const SymbolTable::Symbol* ReferenceLinker::ResolveSymbol(
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700228 const Reference& reference, NameMangler* mangler, SymbolTable* symbols) {
229 if (reference.name) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700230 Maybe<ResourceName> mangled = mangler->MangleName(reference.name.value());
231 return symbols->FindByName(mangled ? mangled.value()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700232 : reference.name.value());
233 } else if (reference.id) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700234 return symbols->FindById(reference.id.value());
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700235 } else {
236 return nullptr;
237 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800238}
239
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700240const SymbolTable::Symbol* ReferenceLinker::ResolveSymbolCheckVisibility(
241 const Reference& reference, NameMangler* name_mangler, SymbolTable* symbols,
242 CallSite* callsite, std::string* out_error) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700243 const SymbolTable::Symbol* symbol =
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700244 ResolveSymbol(reference, name_mangler, symbols);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700245 if (!symbol) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700246 if (out_error) *out_error = "not found";
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700247 return nullptr;
248 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800249
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700250 if (!IsSymbolVisible(*symbol, reference, *callsite)) {
251 if (out_error) *out_error = "is private";
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700252 return nullptr;
253 }
254 return symbol;
Adam Lesinski467f1712015-11-16 17:35:44 -0800255}
256
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700257const SymbolTable::Symbol* ReferenceLinker::ResolveAttributeCheckVisibility(
258 const Reference& reference, NameMangler* name_mangler, SymbolTable* symbols,
259 CallSite* callsite, std::string* out_error) {
260 const SymbolTable::Symbol* symbol = ResolveSymbolCheckVisibility(
261 reference, name_mangler, symbols, callsite, out_error);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700262 if (!symbol) {
263 return nullptr;
264 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800265
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700266 if (!symbol->attribute) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700267 if (out_error) *out_error = "is not an attribute";
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700268 return nullptr;
269 }
270 return symbol;
Adam Lesinski467f1712015-11-16 17:35:44 -0800271}
272
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700273Maybe<xml::AaptAttribute> ReferenceLinker::CompileXmlAttribute(
274 const Reference& reference, NameMangler* name_mangler, SymbolTable* symbols,
275 CallSite* callsite, std::string* out_error) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700276 const SymbolTable::Symbol* symbol =
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700277 ResolveSymbol(reference, name_mangler, symbols);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700278 if (!symbol) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700279 if (out_error) *out_error = "not found";
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700280 return {};
281 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800282
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700283 if (!symbol->attribute) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700284 if (out_error) *out_error = "is not an attribute";
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700285 return {};
286 }
287 return xml::AaptAttribute{symbol->id, *symbol->attribute};
Adam Lesinski467f1712015-11-16 17:35:44 -0800288}
289
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700290void ReferenceLinker::WriteResourceName(DiagMessage* out_msg,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700291 const Reference& orig,
Adam Lesinski28cacf02015-11-23 14:22:47 -0800292 const Reference& transformed) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700293 CHECK(out_msg != nullptr);
Adam Lesinski28cacf02015-11-23 14:22:47 -0800294
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700295 if (orig.name) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700296 *out_msg << orig.name.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700297 if (transformed.name.value() != orig.name.value()) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700298 *out_msg << " (aka " << transformed.name.value() << ")";
Adam Lesinski28cacf02015-11-23 14:22:47 -0800299 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700300 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700301 *out_msg << orig.id.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700302 }
Adam Lesinski28cacf02015-11-23 14:22:47 -0800303}
304
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700305bool ReferenceLinker::LinkReference(Reference* reference, IAaptContext* context,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700306 SymbolTable* symbols,
307 xml::IPackageDeclStack* decls,
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700308 CallSite* callsite) {
309 CHECK(reference != nullptr);
310 CHECK(reference->name || reference->id);
Adam Lesinski467f1712015-11-16 17:35:44 -0800311
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700312 Reference transformed_reference = *reference;
313 TransformReferenceFromNamespace(decls, context->GetCompilationPackage(),
314 &transformed_reference);
Adam Lesinski467f1712015-11-16 17:35:44 -0800315
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700316 std::string err_str;
317 const SymbolTable::Symbol* s = ResolveSymbolCheckVisibility(
318 transformed_reference, context->GetNameMangler(), symbols, callsite,
319 &err_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700320 if (s) {
321 // The ID may not exist. This is fine because of the possibility of building
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700322 // against libraries without assigned IDs.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700323 // Ex: Linking against own resources when building a static library.
324 reference->id = s->id;
325 return true;
326 }
Adam Lesinski467f1712015-11-16 17:35:44 -0800327
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700328 DiagMessage error_msg(reference->GetSource());
329 error_msg << "resource ";
330 WriteResourceName(&error_msg, *reference, transformed_reference);
331 error_msg << " " << err_str;
332 context->GetDiagnostics()->Error(error_msg);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700333 return false;
Adam Lesinski467f1712015-11-16 17:35:44 -0800334}
335
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700336bool ReferenceLinker::Consume(IAaptContext* context, ResourceTable* table) {
337 EmptyDeclStack decl_stack;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700338 bool error = false;
339 for (auto& package : table->packages) {
340 for (auto& type : package->types) {
341 for (auto& entry : type->entries) {
342 // Symbol state information may be lost if there is no value for the
343 // resource.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700344 if (entry->symbol_status.state != SymbolState::kUndefined &&
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700345 entry->values.empty()) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700346 context->GetDiagnostics()->Error(
347 DiagMessage(entry->symbol_status.source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700348 << "no definition for declared symbol '"
349 << ResourceNameRef(package->name, type->type, entry->name)
350 << "'");
351 error = true;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700352 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700353
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700354 CallSite callsite = {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700355 ResourceNameRef(package->name, type->type, entry->name)};
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700356 ReferenceLinkerVisitor visitor(context, context->GetExternalSymbols(),
357 &table->string_pool, &decl_stack,
358 &callsite);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700359
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700360 for (auto& config_value : entry->values) {
361 config_value->value->Accept(&visitor);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700362 }
363
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700364 if (visitor.HasError()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700365 error = true;
366 }
367 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700368 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700369 }
370 return !error;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700371}
372
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700373} // namespace aapt