Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 1 | From 90443b5a5c607a9312f717b43dbd44b0b6bbb084 Mon Sep 17 00:00:00 2001 |
| 2 | From: Pierre-Hugues Husson <phh@phh.me> |
| 3 | Date: Mon, 20 Aug 2018 22:27:02 +0200 |
| 4 | Subject: [PATCH 19/27] It is okay not to have wifi in SystemUI (on FDE lock) |
| 5 | |
| 6 | Conflicts: |
| 7 | packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java |
| 8 | packages/SystemUI/src/com/android/systemui/statusbar/policy/WifiSignalController.java |
| 9 | |
| 10 | Change-Id: I567a4fc81a53a8d3a55acb6ee8aa979c5a38a4f8 |
| 11 | --- |
| 12 | .../src/com/android/settingslib/wifi/WifiTracker.java | 2 +- |
| 13 | .../statusbar/policy/HotspotControllerImpl.java | 1 + |
| 14 | .../statusbar/policy/WifiSignalController.java | 10 +++++----- |
| 15 | 3 files changed, 7 insertions(+), 6 deletions(-) |
| 16 | |
| 17 | diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java b/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java |
| 18 | index 11c22eef5ad..1ca952aaee3 100644 |
| 19 | --- a/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java |
| 20 | +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java |
| 21 | @@ -207,7 +207,7 @@ public class WifiTracker implements LifecycleObserver, OnStart, OnStop, OnDestro |
| 22 | mConnectivityManager = connectivityManager; |
| 23 | |
| 24 | // check if verbose logging developer option has been turned on or off |
| 25 | - sVerboseLogging = (mWifiManager == null) ? false : (mWifiManager.getVerboseLoggingLevel() > 0); |
| 26 | + sVerboseLogging = mWifiManager != null ? (mWifiManager.getVerboseLoggingLevel() > 0) : false; |
| 27 | |
| 28 | mFilter = filter; |
| 29 | |
| 30 | diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/policy/HotspotControllerImpl.java b/packages/SystemUI/src/com/android/systemui/statusbar/policy/HotspotControllerImpl.java |
| 31 | index c44b385f505..e5696edb9e0 100644 |
| 32 | --- a/packages/SystemUI/src/com/android/systemui/statusbar/policy/HotspotControllerImpl.java |
| 33 | +++ b/packages/SystemUI/src/com/android/systemui/statusbar/policy/HotspotControllerImpl.java |
| 34 | @@ -109,6 +109,7 @@ public class HotspotControllerImpl implements HotspotController, WifiManager.Sof |
| 35 | * @param shouldListen whether we should start listening to various wifi statuses |
| 36 | */ |
| 37 | private void updateWifiStateListeners(boolean shouldListen) { |
| 38 | + if(mWifiManager == null) return; |
| 39 | if (shouldListen) { |
| 40 | mWifiManager.registerSoftApCallback( |
| 41 | this, |
| 42 | diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/policy/WifiSignalController.java b/packages/SystemUI/src/com/android/systemui/statusbar/policy/WifiSignalController.java |
| 43 | index b83c6b88f8d..78b30500da7 100644 |
| 44 | --- a/packages/SystemUI/src/com/android/systemui/statusbar/policy/WifiSignalController.java |
| 45 | +++ b/packages/SystemUI/src/com/android/systemui/statusbar/policy/WifiSignalController.java |
| 46 | @@ -59,11 +59,11 @@ public class WifiSignalController extends |
| 47 | mHasMobileData = hasMobileData; |
| 48 | Handler handler = new WifiHandler(Looper.getMainLooper()); |
| 49 | mWifiChannel = new AsyncChannel(); |
| 50 | - if (wifiManager != null) { |
| 51 | - Messenger wifiMessenger = wifiManager.getWifiServiceMessenger(); |
| 52 | - if (wifiMessenger != null) { |
| 53 | - mWifiChannel.connect(context, handler, wifiMessenger); |
| 54 | - } |
| 55 | + Messenger wifiMessenger = null; |
| 56 | + if(wifiManager != null) |
| 57 | + wifiMessenger = wifiManager.getWifiServiceMessenger(); |
| 58 | + if (wifiMessenger != null) { |
| 59 | + mWifiChannel.connect(context, handler, wifiMessenger); |
| 60 | } |
| 61 | // WiFi only has one state. |
| 62 | mCurrentState.iconGroup = mLastState.iconGroup = new IconGroup( |
| 63 | -- |
| 64 | 2.17.1 |
| 65 | |