Pierre-Hugues Husson | 2acef1d | 2018-04-05 20:10:30 +0200 | [diff] [blame] | 1 | From edcb0cb74c66637f34746dbcc7f35d6c268dc56e Mon Sep 17 00:00:00 2001 |
Pierre-Hugues Husson | c0ca67e | 2018-03-22 20:31:17 +0100 | [diff] [blame] | 2 | From: Jaekyun Seok <jaekyun@google.com> |
| 3 | Date: Fri, 3 Nov 2017 15:33:10 +0900 |
Pierre-Hugues Husson | 2acef1d | 2018-04-05 20:10:30 +0200 | [diff] [blame] | 4 | Subject: [PATCH 2/4] Move ART default properties into system partition |
Pierre-Hugues Husson | c0ca67e | 2018-03-22 20:31:17 +0100 | [diff] [blame] | 5 | |
| 6 | Bug: 64661857 |
| 7 | Bug: 68755013 |
| 8 | Test: confirmed that ART default properties were stored in |
| 9 | /system/etc/prop.default on sailfish device |
| 10 | |
| 11 | Change-Id: Ie07d3049de5ac395cfb9105e208fe7825080fa15 |
| 12 | --- |
| 13 | core/dex_preopt_libart.mk | 4 +++- |
| 14 | target/product/runtime_libart.mk | 8 ++++---- |
| 15 | 2 files changed, 7 insertions(+), 5 deletions(-) |
| 16 | |
| 17 | diff --git a/core/dex_preopt_libart.mk b/core/dex_preopt_libart.mk |
Pierre-Hugues Husson | 2acef1d | 2018-04-05 20:10:30 +0200 | [diff] [blame] | 18 | index 9616036..15cb221 100644 |
Pierre-Hugues Husson | c0ca67e | 2018-03-22 20:31:17 +0100 | [diff] [blame] | 19 | --- a/core/dex_preopt_libart.mk |
| 20 | +++ b/core/dex_preopt_libart.mk |
| 21 | @@ -30,7 +30,9 @@ DIRTY_IMAGE_OBJECTS := $(call word-colon,1,$(firstword \ |
| 22 | $(filter %system/etc/dirty-image-objects,$(PRODUCT_COPY_FILES)))) |
| 23 | |
| 24 | define get-product-default-property |
| 25 | -$(strip $(patsubst $(1)=%,%,$(filter $(1)=%,$(PRODUCT_DEFAULT_PROPERTY_OVERRIDES)))) |
| 26 | +$(strip \ |
| 27 | + $(eval _prop := $(patsubst $(1)=%,%,$(filter $(1)=%,$(PRODUCT_DEFAULT_PROPERTY_OVERRIDES))))\ |
| 28 | + $(if $(_prop),$(_prop),$(patsubst $(1)=%,%,$(filter $(1)=%,$(PRODUCT_SYSTEM_DEFAULT_PROPERTIES))))) |
| 29 | endef |
| 30 | |
| 31 | DEX2OAT_IMAGE_XMS := $(call get-product-default-property,dalvik.vm.image-dex2oat-Xms) |
| 32 | diff --git a/target/product/runtime_libart.mk b/target/product/runtime_libart.mk |
Pierre-Hugues Husson | 2acef1d | 2018-04-05 20:10:30 +0200 | [diff] [blame] | 33 | index 8aedee7..f1b8f45 100644 |
Pierre-Hugues Husson | c0ca67e | 2018-03-22 20:31:17 +0100 | [diff] [blame] | 34 | --- a/target/product/runtime_libart.mk |
| 35 | +++ b/target/product/runtime_libart.mk |
| 36 | @@ -56,7 +56,7 @@ PRODUCT_PACKAGES += art-tools |
| 37 | PRODUCT_PACKAGES += \ |
| 38 | cacerts \ |
| 39 | |
| 40 | -PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \ |
| 41 | +PRODUCT_SYSTEM_DEFAULT_PROPERTIES += \ |
| 42 | dalvik.vm.image-dex2oat-Xms=64m \ |
| 43 | dalvik.vm.image-dex2oat-Xmx=64m \ |
| 44 | dalvik.vm.dex2oat-Xms=64m \ |
| 45 | @@ -70,16 +70,16 @@ PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \ |
| 46 | # Different dexopt types for different package update/install times. |
| 47 | # On eng builds, make "boot" reasons only extract for faster turnaround. |
| 48 | ifeq (eng,$(TARGET_BUILD_VARIANT)) |
| 49 | - PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \ |
| 50 | + PRODUCT_SYSTEM_DEFAULT_PROPERTIES += \ |
| 51 | pm.dexopt.first-boot=extract \ |
| 52 | pm.dexopt.boot=extract |
| 53 | else |
| 54 | - PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \ |
| 55 | + PRODUCT_SYSTEM_DEFAULT_PROPERTIES += \ |
| 56 | pm.dexopt.first-boot=quicken \ |
| 57 | pm.dexopt.boot=verify |
| 58 | endif |
| 59 | |
| 60 | -PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \ |
| 61 | +PRODUCT_SYSTEM_DEFAULT_PROPERTIES += \ |
| 62 | pm.dexopt.install=quicken \ |
| 63 | pm.dexopt.bg-dexopt=speed-profile \ |
| 64 | pm.dexopt.ab-ota=speed-profile \ |
| 65 | -- |
Pierre-Hugues Husson | 2acef1d | 2018-04-05 20:10:30 +0200 | [diff] [blame] | 66 | 2.7.4 |
Pierre-Hugues Husson | c0ca67e | 2018-03-22 20:31:17 +0100 | [diff] [blame] | 67 | |