blob: 13c7607cbb849e484348dd59c03efe7675f4c34e [file] [log] [blame]
Nicolas Geoffray3c049742014-09-24 18:10:46 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "instruction_simplifier.h"
18
Andreas Gampec6ea7d02017-02-01 16:46:28 -080019#include "art_method-inl.h"
20#include "class_linker-inl.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010021#include "data_type-inl.h"
Aart Bik71bf7b42016-11-16 10:17:46 -080022#include "escape.h"
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010023#include "intrinsics.h"
Calin Juravleacf735c2015-02-12 15:25:22 +000024#include "mirror/class-inl.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070025#include "scoped_thread_state_change-inl.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070026#include "sharpening.h"
Calin Juravleacf735c2015-02-12 15:25:22 +000027
Nicolas Geoffray3c049742014-09-24 18:10:46 +010028namespace art {
29
Artem Serovcced8ba2017-07-19 18:18:09 +010030// Whether to run an exhaustive test of individual HInstructions cloning when each instruction
31// is replaced with its copy if it is clonable.
32static constexpr bool kTestInstructionClonerExhaustively = false;
33
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010034class InstructionSimplifierVisitor : public HGraphDelegateVisitor {
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000035 public:
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000036 InstructionSimplifierVisitor(HGraph* graph,
37 CodeGenerator* codegen,
Vladimir Marko65979462017-05-19 17:25:12 +010038 CompilerDriver* compiler_driver,
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000039 OptimizingCompilerStats* stats)
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010040 : HGraphDelegateVisitor(graph),
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000041 codegen_(codegen),
Vladimir Marko65979462017-05-19 17:25:12 +010042 compiler_driver_(compiler_driver),
Alexandre Rames188d4312015-04-09 18:30:21 +010043 stats_(stats) {}
44
45 void Run();
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000046
47 private:
Alexandre Rames188d4312015-04-09 18:30:21 +010048 void RecordSimplification() {
49 simplification_occurred_ = true;
50 simplifications_at_current_position_++;
Vladimir Markocd09e1f2017-11-24 15:02:40 +000051 MaybeRecordStat(stats_, MethodCompilationStat::kInstructionSimplifications);
Alexandre Rames188d4312015-04-09 18:30:21 +010052 }
53
Scott Wakeling40a04bf2015-12-11 09:50:36 +000054 bool ReplaceRotateWithRor(HBinaryOperation* op, HUShr* ushr, HShl* shl);
55 bool TryReplaceWithRotate(HBinaryOperation* instruction);
56 bool TryReplaceWithRotateConstantPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
57 bool TryReplaceWithRotateRegisterNegPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
58 bool TryReplaceWithRotateRegisterSubPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
59
Alexandre Rames188d4312015-04-09 18:30:21 +010060 bool TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +000061 // `op` should be either HOr or HAnd.
62 // De Morgan's laws:
63 // ~a & ~b = ~(a | b) and ~a | ~b = ~(a & b)
64 bool TryDeMorganNegationFactoring(HBinaryOperation* op);
Anton Kirilove14dc862016-05-13 17:56:15 +010065 bool TryHandleAssociativeAndCommutativeOperation(HBinaryOperation* instruction);
66 bool TrySubtractionChainSimplification(HBinaryOperation* instruction);
Lena Djokicbc5460b2017-07-20 16:07:36 +020067 bool TryCombineVecMultiplyAccumulate(HVecMul* mul);
Anton Kirilove14dc862016-05-13 17:56:15 +010068
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000069 void VisitShift(HBinaryOperation* shift);
70
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000071 void VisitEqual(HEqual* equal) OVERRIDE;
David Brazdil0d13fee2015-04-17 14:52:19 +010072 void VisitNotEqual(HNotEqual* equal) OVERRIDE;
73 void VisitBooleanNot(HBooleanNot* bool_not) OVERRIDE;
Nicolas Geoffray07276db2015-05-18 14:22:09 +010074 void VisitInstanceFieldSet(HInstanceFieldSet* equal) OVERRIDE;
75 void VisitStaticFieldSet(HStaticFieldSet* equal) OVERRIDE;
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000076 void VisitArraySet(HArraySet* equal) OVERRIDE;
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +000077 void VisitTypeConversion(HTypeConversion* instruction) OVERRIDE;
Calin Juravle10e244f2015-01-26 18:54:32 +000078 void VisitNullCheck(HNullCheck* instruction) OVERRIDE;
Mingyao Yang0304e182015-01-30 16:41:29 -080079 void VisitArrayLength(HArrayLength* instruction) OVERRIDE;
Calin Juravleacf735c2015-02-12 15:25:22 +000080 void VisitCheckCast(HCheckCast* instruction) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000081 void VisitAdd(HAdd* instruction) OVERRIDE;
82 void VisitAnd(HAnd* instruction) OVERRIDE;
Mark Mendellc4701932015-04-10 13:18:51 -040083 void VisitCondition(HCondition* instruction) OVERRIDE;
84 void VisitGreaterThan(HGreaterThan* condition) OVERRIDE;
85 void VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) OVERRIDE;
86 void VisitLessThan(HLessThan* condition) OVERRIDE;
87 void VisitLessThanOrEqual(HLessThanOrEqual* condition) OVERRIDE;
Anton Shaminbdd79352016-02-15 12:48:36 +060088 void VisitBelow(HBelow* condition) OVERRIDE;
89 void VisitBelowOrEqual(HBelowOrEqual* condition) OVERRIDE;
90 void VisitAbove(HAbove* condition) OVERRIDE;
91 void VisitAboveOrEqual(HAboveOrEqual* condition) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000092 void VisitDiv(HDiv* instruction) OVERRIDE;
93 void VisitMul(HMul* instruction) OVERRIDE;
Alexandre Rames188d4312015-04-09 18:30:21 +010094 void VisitNeg(HNeg* instruction) OVERRIDE;
95 void VisitNot(HNot* instruction) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000096 void VisitOr(HOr* instruction) OVERRIDE;
97 void VisitShl(HShl* instruction) OVERRIDE;
98 void VisitShr(HShr* instruction) OVERRIDE;
99 void VisitSub(HSub* instruction) OVERRIDE;
100 void VisitUShr(HUShr* instruction) OVERRIDE;
101 void VisitXor(HXor* instruction) OVERRIDE;
David Brazdil74eb1b22015-12-14 11:44:01 +0000102 void VisitSelect(HSelect* select) OVERRIDE;
103 void VisitIf(HIf* instruction) OVERRIDE;
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100104 void VisitInstanceOf(HInstanceOf* instruction) OVERRIDE;
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +0100105 void VisitInvoke(HInvoke* invoke) OVERRIDE;
Aart Bikbb245d12015-10-19 11:05:03 -0700106 void VisitDeoptimize(HDeoptimize* deoptimize) OVERRIDE;
Lena Djokicbc5460b2017-07-20 16:07:36 +0200107 void VisitVecMul(HVecMul* instruction) OVERRIDE;
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100108
109 bool CanEnsureNotNullAt(HInstruction* instr, HInstruction* at) const;
Calin Juravleacf735c2015-02-12 15:25:22 +0000110
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100111 void SimplifyRotate(HInvoke* invoke, bool is_left, DataType::Type type);
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +0100112 void SimplifySystemArrayCopy(HInvoke* invoke);
113 void SimplifyStringEquals(HInvoke* invoke);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100114 void SimplifyCompare(HInvoke* invoke, bool is_signum, DataType::Type type);
Aart Bik75a38b22016-02-17 10:41:50 -0800115 void SimplifyIsNaN(HInvoke* invoke);
Aart Bik2a6aad92016-02-25 11:32:32 -0800116 void SimplifyFP2Int(HInvoke* invoke);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +0100117 void SimplifyStringCharAt(HInvoke* invoke);
Vladimir Markodce016e2016-04-28 13:10:02 +0100118 void SimplifyStringIsEmptyOrLength(HInvoke* invoke);
Aart Bikff7d89c2016-11-07 08:49:28 -0800119 void SimplifyNPEOnArgN(HInvoke* invoke, size_t);
Aart Bik71bf7b42016-11-16 10:17:46 -0800120 void SimplifyReturnThis(HInvoke* invoke);
121 void SimplifyAllocationIntrinsic(HInvoke* invoke);
Aart Bik11932592016-03-08 12:42:25 -0800122 void SimplifyMemBarrier(HInvoke* invoke, MemBarrierKind barrier_kind);
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +0100123
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000124 CodeGenerator* codegen_;
Vladimir Marko65979462017-05-19 17:25:12 +0100125 CompilerDriver* compiler_driver_;
Calin Juravleacf735c2015-02-12 15:25:22 +0000126 OptimizingCompilerStats* stats_;
Alexandre Rames188d4312015-04-09 18:30:21 +0100127 bool simplification_occurred_ = false;
128 int simplifications_at_current_position_ = 0;
Aart Bik2767f4b2016-10-28 15:03:53 -0700129 // We ensure we do not loop infinitely. The value should not be too high, since that
130 // would allow looping around the same basic block too many times. The value should
131 // not be too low either, however, since we want to allow revisiting a basic block
132 // with many statements and simplifications at least once.
133 static constexpr int kMaxSamePositionSimplifications = 50;
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000134};
135
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100136void InstructionSimplifier::Run() {
Artem Serovcced8ba2017-07-19 18:18:09 +0100137 if (kTestInstructionClonerExhaustively) {
138 CloneAndReplaceInstructionVisitor visitor(graph_);
139 visitor.VisitReversePostOrder();
140 }
141
Vladimir Marko65979462017-05-19 17:25:12 +0100142 InstructionSimplifierVisitor visitor(graph_, codegen_, compiler_driver_, stats_);
Alexandre Rames188d4312015-04-09 18:30:21 +0100143 visitor.Run();
144}
145
146void InstructionSimplifierVisitor::Run() {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100147 // Iterate in reverse post order to open up more simplifications to users
148 // of instructions that got simplified.
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100149 for (HBasicBlock* block : GetGraph()->GetReversePostOrder()) {
Alexandre Rames188d4312015-04-09 18:30:21 +0100150 // The simplification of an instruction to another instruction may yield
151 // possibilities for other simplifications. So although we perform a reverse
152 // post order visit, we sometimes need to revisit an instruction index.
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100153 do {
154 simplification_occurred_ = false;
155 VisitBasicBlock(block);
156 } while (simplification_occurred_ &&
157 (simplifications_at_current_position_ < kMaxSamePositionSimplifications));
Alexandre Rames188d4312015-04-09 18:30:21 +0100158 simplifications_at_current_position_ = 0;
Alexandre Rames188d4312015-04-09 18:30:21 +0100159 }
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100160}
161
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000162namespace {
163
164bool AreAllBitsSet(HConstant* constant) {
165 return Int64FromConstant(constant) == -1;
166}
167
168} // namespace
169
Alexandre Rames188d4312015-04-09 18:30:21 +0100170// Returns true if the code was simplified to use only one negation operation
171// after the binary operation instead of one on each of the inputs.
172bool InstructionSimplifierVisitor::TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop) {
173 DCHECK(binop->IsAdd() || binop->IsSub());
174 DCHECK(binop->GetLeft()->IsNeg() && binop->GetRight()->IsNeg());
175 HNeg* left_neg = binop->GetLeft()->AsNeg();
176 HNeg* right_neg = binop->GetRight()->AsNeg();
177 if (!left_neg->HasOnlyOneNonEnvironmentUse() ||
178 !right_neg->HasOnlyOneNonEnvironmentUse()) {
179 return false;
180 }
181 // Replace code looking like
182 // NEG tmp1, a
183 // NEG tmp2, b
184 // ADD dst, tmp1, tmp2
185 // with
186 // ADD tmp, a, b
187 // NEG dst, tmp
Serdjuk, Nikolay Yaae9e662015-08-21 13:26:34 +0600188 // Note that we cannot optimize `(-a) + (-b)` to `-(a + b)` for floating-point.
189 // When `a` is `-0.0` and `b` is `0.0`, the former expression yields `0.0`,
190 // while the later yields `-0.0`.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100191 if (!DataType::IsIntegralType(binop->GetType())) {
Serdjuk, Nikolay Yaae9e662015-08-21 13:26:34 +0600192 return false;
193 }
Alexandre Rames188d4312015-04-09 18:30:21 +0100194 binop->ReplaceInput(left_neg->GetInput(), 0);
195 binop->ReplaceInput(right_neg->GetInput(), 1);
196 left_neg->GetBlock()->RemoveInstruction(left_neg);
197 right_neg->GetBlock()->RemoveInstruction(right_neg);
Vladimir Markoca6fff82017-10-03 14:49:14 +0100198 HNeg* neg = new (GetGraph()->GetAllocator()) HNeg(binop->GetType(), binop);
Alexandre Rames188d4312015-04-09 18:30:21 +0100199 binop->GetBlock()->InsertInstructionBefore(neg, binop->GetNext());
200 binop->ReplaceWithExceptInReplacementAtIndex(neg, 0);
201 RecordSimplification();
202 return true;
203}
204
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000205bool InstructionSimplifierVisitor::TryDeMorganNegationFactoring(HBinaryOperation* op) {
206 DCHECK(op->IsAnd() || op->IsOr()) << op->DebugName();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100207 DataType::Type type = op->GetType();
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000208 HInstruction* left = op->GetLeft();
209 HInstruction* right = op->GetRight();
210
211 // We can apply De Morgan's laws if both inputs are Not's and are only used
212 // by `op`.
Alexandre Rames9f980252016-02-05 14:00:28 +0000213 if (((left->IsNot() && right->IsNot()) ||
214 (left->IsBooleanNot() && right->IsBooleanNot())) &&
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000215 left->HasOnlyOneNonEnvironmentUse() &&
216 right->HasOnlyOneNonEnvironmentUse()) {
217 // Replace code looking like
218 // NOT nota, a
219 // NOT notb, b
220 // AND dst, nota, notb (respectively OR)
221 // with
222 // OR or, a, b (respectively AND)
223 // NOT dest, or
Alexandre Rames9f980252016-02-05 14:00:28 +0000224 HInstruction* src_left = left->InputAt(0);
225 HInstruction* src_right = right->InputAt(0);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000226 uint32_t dex_pc = op->GetDexPc();
227
228 // Remove the negations on the inputs.
229 left->ReplaceWith(src_left);
230 right->ReplaceWith(src_right);
231 left->GetBlock()->RemoveInstruction(left);
232 right->GetBlock()->RemoveInstruction(right);
233
234 // Replace the `HAnd` or `HOr`.
235 HBinaryOperation* hbin;
236 if (op->IsAnd()) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100237 hbin = new (GetGraph()->GetAllocator()) HOr(type, src_left, src_right, dex_pc);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000238 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100239 hbin = new (GetGraph()->GetAllocator()) HAnd(type, src_left, src_right, dex_pc);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000240 }
Alexandre Rames9f980252016-02-05 14:00:28 +0000241 HInstruction* hnot;
242 if (left->IsBooleanNot()) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100243 hnot = new (GetGraph()->GetAllocator()) HBooleanNot(hbin, dex_pc);
Alexandre Rames9f980252016-02-05 14:00:28 +0000244 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100245 hnot = new (GetGraph()->GetAllocator()) HNot(type, hbin, dex_pc);
Alexandre Rames9f980252016-02-05 14:00:28 +0000246 }
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000247
248 op->GetBlock()->InsertInstructionBefore(hbin, op);
249 op->GetBlock()->ReplaceAndRemoveInstructionWith(op, hnot);
250
251 RecordSimplification();
252 return true;
253 }
254
255 return false;
256}
257
Lena Djokicbc5460b2017-07-20 16:07:36 +0200258bool InstructionSimplifierVisitor::TryCombineVecMultiplyAccumulate(HVecMul* mul) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100259 DataType::Type type = mul->GetPackedType();
Lena Djokicbc5460b2017-07-20 16:07:36 +0200260 InstructionSet isa = codegen_->GetInstructionSet();
261 switch (isa) {
Vladimir Marko33bff252017-11-01 14:35:42 +0000262 case InstructionSet::kArm64:
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100263 if (!(type == DataType::Type::kUint8 ||
264 type == DataType::Type::kInt8 ||
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100265 type == DataType::Type::kUint16 ||
266 type == DataType::Type::kInt16 ||
267 type == DataType::Type::kInt32)) {
Lena Djokicbc5460b2017-07-20 16:07:36 +0200268 return false;
269 }
270 break;
Vladimir Marko33bff252017-11-01 14:35:42 +0000271 case InstructionSet::kMips:
272 case InstructionSet::kMips64:
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100273 if (!(type == DataType::Type::kUint8 ||
274 type == DataType::Type::kInt8 ||
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100275 type == DataType::Type::kUint16 ||
276 type == DataType::Type::kInt16 ||
277 type == DataType::Type::kInt32 ||
278 type == DataType::Type::kInt64)) {
Lena Djokicbc5460b2017-07-20 16:07:36 +0200279 return false;
280 }
281 break;
282 default:
283 return false;
284 }
285
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100286 ArenaAllocator* allocator = mul->GetBlock()->GetGraph()->GetAllocator();
Lena Djokicbc5460b2017-07-20 16:07:36 +0200287
288 if (mul->HasOnlyOneNonEnvironmentUse()) {
289 HInstruction* use = mul->GetUses().front().GetUser();
290 if (use->IsVecAdd() || use->IsVecSub()) {
291 // Replace code looking like
292 // VECMUL tmp, x, y
293 // VECADD/SUB dst, acc, tmp
294 // with
295 // VECMULACC dst, acc, x, y
296 // Note that we do not want to (unconditionally) perform the merge when the
297 // multiplication has multiple uses and it can be merged in all of them.
298 // Multiple uses could happen on the same control-flow path, and we would
299 // then increase the amount of work. In the future we could try to evaluate
300 // whether all uses are on different control-flow paths (using dominance and
301 // reverse-dominance information) and only perform the merge when they are.
302 HInstruction* accumulator = nullptr;
303 HVecBinaryOperation* binop = use->AsVecBinaryOperation();
304 HInstruction* binop_left = binop->GetLeft();
305 HInstruction* binop_right = binop->GetRight();
306 // This is always true since the `HVecMul` has only one use (which is checked above).
307 DCHECK_NE(binop_left, binop_right);
308 if (binop_right == mul) {
309 accumulator = binop_left;
310 } else if (use->IsVecAdd()) {
311 DCHECK_EQ(binop_left, mul);
312 accumulator = binop_right;
313 }
314
315 HInstruction::InstructionKind kind =
316 use->IsVecAdd() ? HInstruction::kAdd : HInstruction::kSub;
317 if (accumulator != nullptr) {
318 HVecMultiplyAccumulate* mulacc =
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100319 new (allocator) HVecMultiplyAccumulate(allocator,
320 kind,
321 accumulator,
322 mul->GetLeft(),
323 mul->GetRight(),
324 binop->GetPackedType(),
325 binop->GetVectorLength(),
326 binop->GetDexPc());
Lena Djokicbc5460b2017-07-20 16:07:36 +0200327
328 binop->GetBlock()->ReplaceAndRemoveInstructionWith(binop, mulacc);
329 DCHECK(!mul->HasUses());
330 mul->GetBlock()->RemoveInstruction(mul);
331 return true;
332 }
333 }
334 }
335
336 return false;
337}
338
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000339void InstructionSimplifierVisitor::VisitShift(HBinaryOperation* instruction) {
340 DCHECK(instruction->IsShl() || instruction->IsShr() || instruction->IsUShr());
Alexandre Rames50518442016-06-27 11:39:19 +0100341 HInstruction* shift_amount = instruction->GetRight();
342 HInstruction* value = instruction->GetLeft();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000343
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100344 int64_t implicit_mask = (value->GetType() == DataType::Type::kInt64)
Alexandre Rames50518442016-06-27 11:39:19 +0100345 ? kMaxLongShiftDistance
346 : kMaxIntShiftDistance;
347
348 if (shift_amount->IsConstant()) {
349 int64_t cst = Int64FromConstant(shift_amount->AsConstant());
Aart Bik50e20d52017-05-05 14:07:29 -0700350 int64_t masked_cst = cst & implicit_mask;
351 if (masked_cst == 0) {
Mark Mendellba56d062015-05-05 21:34:03 -0400352 // Replace code looking like
Alexandre Rames50518442016-06-27 11:39:19 +0100353 // SHL dst, value, 0
Mark Mendellba56d062015-05-05 21:34:03 -0400354 // with
Alexandre Rames50518442016-06-27 11:39:19 +0100355 // value
356 instruction->ReplaceWith(value);
Mark Mendellba56d062015-05-05 21:34:03 -0400357 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +0100358 RecordSimplification();
Alexandre Rames50518442016-06-27 11:39:19 +0100359 return;
Aart Bik50e20d52017-05-05 14:07:29 -0700360 } else if (masked_cst != cst) {
361 // Replace code looking like
362 // SHL dst, value, cst
363 // where cst exceeds maximum distance with the equivalent
364 // SHL dst, value, cst & implicit_mask
365 // (as defined by shift semantics). This ensures other
366 // optimizations do not need to special case for such situations.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100367 DCHECK_EQ(shift_amount->GetType(), DataType::Type::kInt32);
Aart Bik50e20d52017-05-05 14:07:29 -0700368 instruction->ReplaceInput(GetGraph()->GetIntConstant(masked_cst), /* index */ 1);
369 RecordSimplification();
370 return;
Alexandre Rames50518442016-06-27 11:39:19 +0100371 }
372 }
373
374 // Shift operations implicitly mask the shift amount according to the type width. Get rid of
Vladimir Marko7033d492017-09-28 16:32:24 +0100375 // unnecessary And/Or/Xor/Add/Sub/TypeConversion operations on the shift amount that do not
376 // affect the relevant bits.
Alexandre Rames50518442016-06-27 11:39:19 +0100377 // Replace code looking like
Vladimir Marko7033d492017-09-28 16:32:24 +0100378 // AND adjusted_shift, shift, <superset of implicit mask>
379 // [OR/XOR/ADD/SUB adjusted_shift, shift, <value not overlapping with implicit mask>]
380 // [<conversion-from-integral-non-64-bit-type> adjusted_shift, shift]
381 // SHL dst, value, adjusted_shift
Alexandre Rames50518442016-06-27 11:39:19 +0100382 // with
383 // SHL dst, value, shift
Vladimir Marko7033d492017-09-28 16:32:24 +0100384 if (shift_amount->IsAnd() ||
385 shift_amount->IsOr() ||
386 shift_amount->IsXor() ||
387 shift_amount->IsAdd() ||
388 shift_amount->IsSub()) {
389 int64_t required_result = shift_amount->IsAnd() ? implicit_mask : 0;
390 HBinaryOperation* bin_op = shift_amount->AsBinaryOperation();
391 HConstant* mask = bin_op->GetConstantRight();
392 if (mask != nullptr && (Int64FromConstant(mask) & implicit_mask) == required_result) {
393 instruction->ReplaceInput(bin_op->GetLeastConstantLeft(), 1);
Alexandre Rames50518442016-06-27 11:39:19 +0100394 RecordSimplification();
Vladimir Marko7033d492017-09-28 16:32:24 +0100395 return;
396 }
397 } else if (shift_amount->IsTypeConversion()) {
398 DCHECK_NE(shift_amount->GetType(), DataType::Type::kBool); // We never convert to bool.
399 DataType::Type source_type = shift_amount->InputAt(0)->GetType();
400 // Non-integral and 64-bit source types require an explicit type conversion.
401 if (DataType::IsIntegralType(source_type) && !DataType::Is64BitType(source_type)) {
402 instruction->ReplaceInput(shift_amount->AsTypeConversion()->GetInput(), 1);
403 RecordSimplification();
404 return;
Mark Mendellba56d062015-05-05 21:34:03 -0400405 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000406 }
407}
408
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000409static bool IsSubRegBitsMinusOther(HSub* sub, size_t reg_bits, HInstruction* other) {
410 return (sub->GetRight() == other &&
411 sub->GetLeft()->IsConstant() &&
412 (Int64FromConstant(sub->GetLeft()->AsConstant()) & (reg_bits - 1)) == 0);
413}
414
415bool InstructionSimplifierVisitor::ReplaceRotateWithRor(HBinaryOperation* op,
416 HUShr* ushr,
417 HShl* shl) {
Roland Levillain22c49222016-03-18 14:04:28 +0000418 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr()) << op->DebugName();
Vladimir Markoca6fff82017-10-03 14:49:14 +0100419 HRor* ror =
420 new (GetGraph()->GetAllocator()) HRor(ushr->GetType(), ushr->GetLeft(), ushr->GetRight());
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000421 op->GetBlock()->ReplaceAndRemoveInstructionWith(op, ror);
422 if (!ushr->HasUses()) {
423 ushr->GetBlock()->RemoveInstruction(ushr);
424 }
425 if (!ushr->GetRight()->HasUses()) {
426 ushr->GetRight()->GetBlock()->RemoveInstruction(ushr->GetRight());
427 }
428 if (!shl->HasUses()) {
429 shl->GetBlock()->RemoveInstruction(shl);
430 }
431 if (!shl->GetRight()->HasUses()) {
432 shl->GetRight()->GetBlock()->RemoveInstruction(shl->GetRight());
433 }
Alexandre Ramesc5809c32016-05-25 15:01:06 +0100434 RecordSimplification();
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000435 return true;
436}
437
438// Try to replace a binary operation flanked by one UShr and one Shl with a bitfield rotation.
439bool InstructionSimplifierVisitor::TryReplaceWithRotate(HBinaryOperation* op) {
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000440 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
441 HInstruction* left = op->GetLeft();
442 HInstruction* right = op->GetRight();
443 // If we have an UShr and a Shl (in either order).
444 if ((left->IsUShr() && right->IsShl()) || (left->IsShl() && right->IsUShr())) {
445 HUShr* ushr = left->IsUShr() ? left->AsUShr() : right->AsUShr();
446 HShl* shl = left->IsShl() ? left->AsShl() : right->AsShl();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100447 DCHECK(DataType::IsIntOrLongType(ushr->GetType()));
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000448 if (ushr->GetType() == shl->GetType() &&
449 ushr->GetLeft() == shl->GetLeft()) {
450 if (ushr->GetRight()->IsConstant() && shl->GetRight()->IsConstant()) {
451 // Shift distances are both constant, try replacing with Ror if they
452 // add up to the register size.
453 return TryReplaceWithRotateConstantPattern(op, ushr, shl);
454 } else if (ushr->GetRight()->IsSub() || shl->GetRight()->IsSub()) {
455 // Shift distances are potentially of the form x and (reg_size - x).
456 return TryReplaceWithRotateRegisterSubPattern(op, ushr, shl);
457 } else if (ushr->GetRight()->IsNeg() || shl->GetRight()->IsNeg()) {
458 // Shift distances are potentially of the form d and -d.
459 return TryReplaceWithRotateRegisterNegPattern(op, ushr, shl);
460 }
461 }
462 }
463 return false;
464}
465
466// Try replacing code looking like (x >>> #rdist OP x << #ldist):
467// UShr dst, x, #rdist
468// Shl tmp, x, #ldist
469// OP dst, dst, tmp
470// or like (x >>> #rdist OP x << #-ldist):
471// UShr dst, x, #rdist
472// Shl tmp, x, #-ldist
473// OP dst, dst, tmp
474// with
475// Ror dst, x, #rdist
476bool InstructionSimplifierVisitor::TryReplaceWithRotateConstantPattern(HBinaryOperation* op,
477 HUShr* ushr,
478 HShl* shl) {
479 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100480 size_t reg_bits = DataType::Size(ushr->GetType()) * kBitsPerByte;
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000481 size_t rdist = Int64FromConstant(ushr->GetRight()->AsConstant());
482 size_t ldist = Int64FromConstant(shl->GetRight()->AsConstant());
483 if (((ldist + rdist) & (reg_bits - 1)) == 0) {
484 ReplaceRotateWithRor(op, ushr, shl);
485 return true;
486 }
487 return false;
488}
489
490// Replace code looking like (x >>> -d OP x << d):
491// Neg neg, d
492// UShr dst, x, neg
493// Shl tmp, x, d
494// OP dst, dst, tmp
495// with
496// Neg neg, d
497// Ror dst, x, neg
498// *** OR ***
499// Replace code looking like (x >>> d OP x << -d):
500// UShr dst, x, d
501// Neg neg, d
502// Shl tmp, x, neg
503// OP dst, dst, tmp
504// with
505// Ror dst, x, d
506bool InstructionSimplifierVisitor::TryReplaceWithRotateRegisterNegPattern(HBinaryOperation* op,
507 HUShr* ushr,
508 HShl* shl) {
509 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
510 DCHECK(ushr->GetRight()->IsNeg() || shl->GetRight()->IsNeg());
511 bool neg_is_left = shl->GetRight()->IsNeg();
512 HNeg* neg = neg_is_left ? shl->GetRight()->AsNeg() : ushr->GetRight()->AsNeg();
513 // And the shift distance being negated is the distance being shifted the other way.
514 if (neg->InputAt(0) == (neg_is_left ? ushr->GetRight() : shl->GetRight())) {
515 ReplaceRotateWithRor(op, ushr, shl);
516 }
517 return false;
518}
519
520// Try replacing code looking like (x >>> d OP x << (#bits - d)):
521// UShr dst, x, d
522// Sub ld, #bits, d
523// Shl tmp, x, ld
524// OP dst, dst, tmp
525// with
526// Ror dst, x, d
527// *** OR ***
528// Replace code looking like (x >>> (#bits - d) OP x << d):
529// Sub rd, #bits, d
530// UShr dst, x, rd
531// Shl tmp, x, d
532// OP dst, dst, tmp
533// with
534// Neg neg, d
535// Ror dst, x, neg
536bool InstructionSimplifierVisitor::TryReplaceWithRotateRegisterSubPattern(HBinaryOperation* op,
537 HUShr* ushr,
538 HShl* shl) {
539 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
540 DCHECK(ushr->GetRight()->IsSub() || shl->GetRight()->IsSub());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100541 size_t reg_bits = DataType::Size(ushr->GetType()) * kBitsPerByte;
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000542 HInstruction* shl_shift = shl->GetRight();
543 HInstruction* ushr_shift = ushr->GetRight();
544 if ((shl_shift->IsSub() && IsSubRegBitsMinusOther(shl_shift->AsSub(), reg_bits, ushr_shift)) ||
545 (ushr_shift->IsSub() && IsSubRegBitsMinusOther(ushr_shift->AsSub(), reg_bits, shl_shift))) {
546 return ReplaceRotateWithRor(op, ushr, shl);
547 }
548 return false;
549}
550
Calin Juravle10e244f2015-01-26 18:54:32 +0000551void InstructionSimplifierVisitor::VisitNullCheck(HNullCheck* null_check) {
552 HInstruction* obj = null_check->InputAt(0);
553 if (!obj->CanBeNull()) {
554 null_check->ReplaceWith(obj);
555 null_check->GetBlock()->RemoveInstruction(null_check);
Calin Juravleacf735c2015-02-12 15:25:22 +0000556 if (stats_ != nullptr) {
557 stats_->RecordStat(MethodCompilationStat::kRemovedNullCheck);
558 }
559 }
560}
561
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100562bool InstructionSimplifierVisitor::CanEnsureNotNullAt(HInstruction* input, HInstruction* at) const {
563 if (!input->CanBeNull()) {
564 return true;
565 }
566
Vladimir Marko46817b82016-03-29 12:21:58 +0100567 for (const HUseListNode<HInstruction*>& use : input->GetUses()) {
568 HInstruction* user = use.GetUser();
569 if (user->IsNullCheck() && user->StrictlyDominates(at)) {
Guillaume "Vermeille" Sanchez8909baf2015-04-23 21:35:11 +0100570 return true;
571 }
572 }
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100573
Guillaume "Vermeille" Sanchez8909baf2015-04-23 21:35:11 +0100574 return false;
575}
576
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100577// Returns whether doing a type test between the class of `object` against `klass` has
578// a statically known outcome. The result of the test is stored in `outcome`.
579static bool TypeCheckHasKnownOutcome(HLoadClass* klass, HInstruction* object, bool* outcome) {
Calin Juravle2e768302015-07-28 14:41:11 +0000580 DCHECK(!object->IsNullConstant()) << "Null constants should be special cased";
581 ReferenceTypeInfo obj_rti = object->GetReferenceTypeInfo();
582 ScopedObjectAccess soa(Thread::Current());
583 if (!obj_rti.IsValid()) {
584 // We run the simplifier before the reference type propagation so type info might not be
585 // available.
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100586 return false;
Calin Juravleacf735c2015-02-12 15:25:22 +0000587 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100588
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100589 ReferenceTypeInfo class_rti = klass->GetLoadedClassRTI();
Calin Juravle98893e12015-10-02 21:05:03 +0100590 if (!class_rti.IsValid()) {
591 // Happens when the loaded class is unresolved.
592 return false;
593 }
594 DCHECK(class_rti.IsExact());
Calin Juravleacf735c2015-02-12 15:25:22 +0000595 if (class_rti.IsSupertypeOf(obj_rti)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100596 *outcome = true;
597 return true;
598 } else if (obj_rti.IsExact()) {
599 // The test failed at compile time so will also fail at runtime.
600 *outcome = false;
601 return true;
Nicolas Geoffray7cb499b2015-06-17 11:35:11 +0100602 } else if (!class_rti.IsInterface()
603 && !obj_rti.IsInterface()
604 && !obj_rti.IsSupertypeOf(class_rti)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100605 // Different type hierarchy. The test will fail.
606 *outcome = false;
607 return true;
608 }
609 return false;
610}
611
612void InstructionSimplifierVisitor::VisitCheckCast(HCheckCast* check_cast) {
613 HInstruction* object = check_cast->InputAt(0);
Calin Juravlee53fb552015-10-07 17:51:52 +0100614 HLoadClass* load_class = check_cast->InputAt(1)->AsLoadClass();
615 if (load_class->NeedsAccessCheck()) {
616 // If we need to perform an access check we cannot remove the instruction.
617 return;
618 }
619
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100620 if (CanEnsureNotNullAt(object, check_cast)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100621 check_cast->ClearMustDoNullCheck();
622 }
623
624 if (object->IsNullConstant()) {
Calin Juravleacf735c2015-02-12 15:25:22 +0000625 check_cast->GetBlock()->RemoveInstruction(check_cast);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700626 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedCheckedCast);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100627 return;
628 }
629
Vladimir Markoa65ed302016-03-14 21:21:29 +0000630 // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
631 // the return value check with the `outcome` check, b/27651442 .
632 bool outcome = false;
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700633 if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100634 if (outcome) {
635 check_cast->GetBlock()->RemoveInstruction(check_cast);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700636 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedCheckedCast);
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700637 if (!load_class->HasUses()) {
638 // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw.
639 // However, here we know that it cannot because the checkcast was successfull, hence
640 // the class was already loaded.
641 load_class->GetBlock()->RemoveInstruction(load_class);
642 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100643 } else {
644 // Don't do anything for exceptional cases for now. Ideally we should remove
645 // all instructions and blocks this instruction dominates.
646 }
Calin Juravle10e244f2015-01-26 18:54:32 +0000647 }
648}
649
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100650void InstructionSimplifierVisitor::VisitInstanceOf(HInstanceOf* instruction) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100651 HInstruction* object = instruction->InputAt(0);
Calin Juravlee53fb552015-10-07 17:51:52 +0100652 HLoadClass* load_class = instruction->InputAt(1)->AsLoadClass();
653 if (load_class->NeedsAccessCheck()) {
654 // If we need to perform an access check we cannot remove the instruction.
655 return;
656 }
657
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100658 bool can_be_null = true;
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100659 if (CanEnsureNotNullAt(object, instruction)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100660 can_be_null = false;
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100661 instruction->ClearMustDoNullCheck();
662 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100663
664 HGraph* graph = GetGraph();
665 if (object->IsNullConstant()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000666 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedInstanceOf);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100667 instruction->ReplaceWith(graph->GetIntConstant(0));
668 instruction->GetBlock()->RemoveInstruction(instruction);
669 RecordSimplification();
670 return;
671 }
672
Vladimir Marko24bd8952016-03-15 10:40:33 +0000673 // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
674 // the return value check with the `outcome` check, b/27651442 .
675 bool outcome = false;
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700676 if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000677 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedInstanceOf);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100678 if (outcome && can_be_null) {
679 // Type test will succeed, we just need a null test.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100680 HNotEqual* test = new (graph->GetAllocator()) HNotEqual(graph->GetNullConstant(), object);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100681 instruction->GetBlock()->InsertInstructionBefore(test, instruction);
682 instruction->ReplaceWith(test);
683 } else {
684 // We've statically determined the result of the instanceof.
685 instruction->ReplaceWith(graph->GetIntConstant(outcome));
686 }
687 RecordSimplification();
688 instruction->GetBlock()->RemoveInstruction(instruction);
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700689 if (outcome && !load_class->HasUses()) {
690 // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw.
691 // However, here we know that it cannot because the instanceof check was successfull, hence
692 // the class was already loaded.
693 load_class->GetBlock()->RemoveInstruction(load_class);
694 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100695 }
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100696}
697
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100698void InstructionSimplifierVisitor::VisitInstanceFieldSet(HInstanceFieldSet* instruction) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100699 if ((instruction->GetValue()->GetType() == DataType::Type::kReference)
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100700 && CanEnsureNotNullAt(instruction->GetValue(), instruction)) {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100701 instruction->ClearValueCanBeNull();
702 }
703}
704
705void InstructionSimplifierVisitor::VisitStaticFieldSet(HStaticFieldSet* instruction) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100706 if ((instruction->GetValue()->GetType() == DataType::Type::kReference)
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100707 && CanEnsureNotNullAt(instruction->GetValue(), instruction)) {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100708 instruction->ClearValueCanBeNull();
709 }
710}
711
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100712static HCondition* GetOppositeConditionSwapOps(ArenaAllocator* allocator, HInstruction* cond) {
Anton Shaminbdd79352016-02-15 12:48:36 +0600713 HInstruction *lhs = cond->InputAt(0);
714 HInstruction *rhs = cond->InputAt(1);
715 switch (cond->GetKind()) {
716 case HInstruction::kEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100717 return new (allocator) HEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600718 case HInstruction::kNotEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100719 return new (allocator) HNotEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600720 case HInstruction::kLessThan:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100721 return new (allocator) HGreaterThan(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600722 case HInstruction::kLessThanOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100723 return new (allocator) HGreaterThanOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600724 case HInstruction::kGreaterThan:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100725 return new (allocator) HLessThan(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600726 case HInstruction::kGreaterThanOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100727 return new (allocator) HLessThanOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600728 case HInstruction::kBelow:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100729 return new (allocator) HAbove(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600730 case HInstruction::kBelowOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100731 return new (allocator) HAboveOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600732 case HInstruction::kAbove:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100733 return new (allocator) HBelow(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600734 case HInstruction::kAboveOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100735 return new (allocator) HBelowOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600736 default:
737 LOG(FATAL) << "Unknown ConditionType " << cond->GetKind();
738 }
739 return nullptr;
740}
741
Aart Bik2767f4b2016-10-28 15:03:53 -0700742static bool CmpHasBoolType(HInstruction* input, HInstruction* cmp) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100743 if (input->GetType() == DataType::Type::kBool) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700744 return true; // input has direct boolean type
745 } else if (cmp->GetUses().HasExactlyOneElement()) {
746 // Comparison also has boolean type if both its input and the instruction
747 // itself feed into the same phi node.
748 HInstruction* user = cmp->GetUses().front().GetUser();
749 return user->IsPhi() && user->HasInput(input) && user->HasInput(cmp);
750 }
751 return false;
752}
753
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000754void InstructionSimplifierVisitor::VisitEqual(HEqual* equal) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100755 HInstruction* input_const = equal->GetConstantRight();
756 if (input_const != nullptr) {
757 HInstruction* input_value = equal->GetLeastConstantLeft();
Aart Bik2767f4b2016-10-28 15:03:53 -0700758 if (CmpHasBoolType(input_value, equal) && input_const->IsIntConstant()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100759 HBasicBlock* block = equal->GetBlock();
Nicolas Geoffray3c4ab802015-06-19 11:42:07 +0100760 // We are comparing the boolean to a constant which is of type int and can
761 // be any constant.
Roland Levillain1a653882016-03-18 18:05:57 +0000762 if (input_const->AsIntConstant()->IsTrue()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100763 // Replace (bool_value == true) with bool_value
764 equal->ReplaceWith(input_value);
765 block->RemoveInstruction(equal);
766 RecordSimplification();
Roland Levillain1a653882016-03-18 18:05:57 +0000767 } else if (input_const->AsIntConstant()->IsFalse()) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700768 // Replace (bool_value == false) with !bool_value
Mark Mendellf6529172015-11-17 11:16:56 -0500769 equal->ReplaceWith(GetGraph()->InsertOppositeCondition(input_value, equal));
770 block->RemoveInstruction(equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100771 RecordSimplification();
David Brazdil1e9ec052015-06-22 10:26:45 +0100772 } else {
773 // Replace (bool_value == integer_not_zero_nor_one_constant) with false
774 equal->ReplaceWith(GetGraph()->GetIntConstant(0));
775 block->RemoveInstruction(equal);
776 RecordSimplification();
David Brazdil0d13fee2015-04-17 14:52:19 +0100777 }
Mark Mendellc4701932015-04-10 13:18:51 -0400778 } else {
779 VisitCondition(equal);
Nicolas Geoffray01ef3452014-10-01 11:32:17 +0100780 }
Mark Mendellc4701932015-04-10 13:18:51 -0400781 } else {
782 VisitCondition(equal);
Nicolas Geoffray01ef3452014-10-01 11:32:17 +0100783 }
784}
785
David Brazdil0d13fee2015-04-17 14:52:19 +0100786void InstructionSimplifierVisitor::VisitNotEqual(HNotEqual* not_equal) {
787 HInstruction* input_const = not_equal->GetConstantRight();
788 if (input_const != nullptr) {
789 HInstruction* input_value = not_equal->GetLeastConstantLeft();
Aart Bik2767f4b2016-10-28 15:03:53 -0700790 if (CmpHasBoolType(input_value, not_equal) && input_const->IsIntConstant()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100791 HBasicBlock* block = not_equal->GetBlock();
Nicolas Geoffray3c4ab802015-06-19 11:42:07 +0100792 // We are comparing the boolean to a constant which is of type int and can
793 // be any constant.
Roland Levillain1a653882016-03-18 18:05:57 +0000794 if (input_const->AsIntConstant()->IsTrue()) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700795 // Replace (bool_value != true) with !bool_value
Mark Mendellf6529172015-11-17 11:16:56 -0500796 not_equal->ReplaceWith(GetGraph()->InsertOppositeCondition(input_value, not_equal));
797 block->RemoveInstruction(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100798 RecordSimplification();
Roland Levillain1a653882016-03-18 18:05:57 +0000799 } else if (input_const->AsIntConstant()->IsFalse()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100800 // Replace (bool_value != false) with bool_value
David Brazdil0d13fee2015-04-17 14:52:19 +0100801 not_equal->ReplaceWith(input_value);
802 block->RemoveInstruction(not_equal);
803 RecordSimplification();
David Brazdil1e9ec052015-06-22 10:26:45 +0100804 } else {
805 // Replace (bool_value != integer_not_zero_nor_one_constant) with true
806 not_equal->ReplaceWith(GetGraph()->GetIntConstant(1));
807 block->RemoveInstruction(not_equal);
808 RecordSimplification();
David Brazdil0d13fee2015-04-17 14:52:19 +0100809 }
Mark Mendellc4701932015-04-10 13:18:51 -0400810 } else {
811 VisitCondition(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100812 }
Mark Mendellc4701932015-04-10 13:18:51 -0400813 } else {
814 VisitCondition(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100815 }
816}
817
818void InstructionSimplifierVisitor::VisitBooleanNot(HBooleanNot* bool_not) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000819 HInstruction* input = bool_not->InputAt(0);
820 HInstruction* replace_with = nullptr;
821
822 if (input->IsIntConstant()) {
823 // Replace !(true/false) with false/true.
Roland Levillain1a653882016-03-18 18:05:57 +0000824 if (input->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000825 replace_with = GetGraph()->GetIntConstant(0);
826 } else {
Roland Levillain1a653882016-03-18 18:05:57 +0000827 DCHECK(input->AsIntConstant()->IsFalse()) << input->AsIntConstant()->GetValue();
David Brazdil74eb1b22015-12-14 11:44:01 +0000828 replace_with = GetGraph()->GetIntConstant(1);
829 }
830 } else if (input->IsBooleanNot()) {
831 // Replace (!(!bool_value)) with bool_value.
832 replace_with = input->InputAt(0);
833 } else if (input->IsCondition() &&
834 // Don't change FP compares. The definition of compares involving
835 // NaNs forces the compares to be done as written by the user.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100836 !DataType::IsFloatingPointType(input->InputAt(0)->GetType())) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000837 // Replace condition with its opposite.
838 replace_with = GetGraph()->InsertOppositeCondition(input->AsCondition(), bool_not);
839 }
840
841 if (replace_with != nullptr) {
842 bool_not->ReplaceWith(replace_with);
David Brazdil0d13fee2015-04-17 14:52:19 +0100843 bool_not->GetBlock()->RemoveInstruction(bool_not);
David Brazdil74eb1b22015-12-14 11:44:01 +0000844 RecordSimplification();
845 }
846}
847
Aart Bik4f7dd342017-09-12 13:12:57 -0700848// Constructs a new ABS(x) node in the HIR.
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100849static HInstruction* NewIntegralAbs(ArenaAllocator* allocator,
850 HInstruction* x,
851 HInstruction* cursor) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100852 DataType::Type type = x->GetType();
853 DCHECK(type == DataType::Type::kInt32 || type == DataType::Type::kInt64);
Aart Bik4f7dd342017-09-12 13:12:57 -0700854 // Construct a fake intrinsic with as much context as is needed to allocate one.
855 // The intrinsic will always be lowered into code later anyway.
856 // TODO: b/65164101 : moving towards a real HAbs node makes more sense.
857 HInvokeStaticOrDirect::DispatchInfo dispatch_info = {
858 HInvokeStaticOrDirect::MethodLoadKind::kDirectAddress,
859 HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod,
860 0u
861 };
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100862 HInvokeStaticOrDirect* invoke = new (allocator) HInvokeStaticOrDirect(
863 allocator,
Aart Bik4f7dd342017-09-12 13:12:57 -0700864 1,
865 type,
866 x->GetDexPc(),
867 /*method_idx*/ -1,
868 /*resolved_method*/ nullptr,
869 dispatch_info,
870 kStatic,
871 MethodReference(nullptr, dex::kDexNoIndex),
872 HInvokeStaticOrDirect::ClinitCheckRequirement::kNone);
873 invoke->SetArgumentAt(0, x);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100874 invoke->SetIntrinsic(type == DataType::Type::kInt32 ? Intrinsics::kMathAbsInt
875 : Intrinsics::kMathAbsLong,
Aart Bik4f7dd342017-09-12 13:12:57 -0700876 kNoEnvironmentOrCache,
877 kNoSideEffects,
878 kNoThrow);
879 cursor->GetBlock()->InsertInstructionBefore(invoke, cursor);
880 return invoke;
881}
882
883// Returns true if operands a and b consists of widening type conversions
884// (either explicit or implicit) to the given to_type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100885static bool AreLowerPrecisionArgs(DataType::Type to_type, HInstruction* a, HInstruction* b) {
Aart Bik4f7dd342017-09-12 13:12:57 -0700886 if (a->IsTypeConversion() && a->GetType() == to_type) {
887 a = a->InputAt(0);
888 }
889 if (b->IsTypeConversion() && b->GetType() == to_type) {
890 b = b->InputAt(0);
891 }
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100892 DataType::Type type1 = a->GetType();
893 DataType::Type type2 = b->GetType();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100894 return (type1 == DataType::Type::kUint8 && type2 == DataType::Type::kUint8) ||
895 (type1 == DataType::Type::kInt8 && type2 == DataType::Type::kInt8) ||
896 (type1 == DataType::Type::kInt16 && type2 == DataType::Type::kInt16) ||
897 (type1 == DataType::Type::kUint16 && type2 == DataType::Type::kUint16) ||
898 (type1 == DataType::Type::kInt32 && type2 == DataType::Type::kInt32 &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100899 to_type == DataType::Type::kInt64);
Aart Bik4f7dd342017-09-12 13:12:57 -0700900}
901
David Brazdil74eb1b22015-12-14 11:44:01 +0000902void InstructionSimplifierVisitor::VisitSelect(HSelect* select) {
903 HInstruction* replace_with = nullptr;
904 HInstruction* condition = select->GetCondition();
905 HInstruction* true_value = select->GetTrueValue();
906 HInstruction* false_value = select->GetFalseValue();
907
908 if (condition->IsBooleanNot()) {
909 // Change ((!cond) ? x : y) to (cond ? y : x).
910 condition = condition->InputAt(0);
911 std::swap(true_value, false_value);
912 select->ReplaceInput(false_value, 0);
913 select->ReplaceInput(true_value, 1);
914 select->ReplaceInput(condition, 2);
915 RecordSimplification();
916 }
917
918 if (true_value == false_value) {
919 // Replace (cond ? x : x) with (x).
920 replace_with = true_value;
921 } else if (condition->IsIntConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +0000922 if (condition->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000923 // Replace (true ? x : y) with (x).
924 replace_with = true_value;
925 } else {
926 // Replace (false ? x : y) with (y).
Roland Levillain1a653882016-03-18 18:05:57 +0000927 DCHECK(condition->AsIntConstant()->IsFalse()) << condition->AsIntConstant()->GetValue();
David Brazdil74eb1b22015-12-14 11:44:01 +0000928 replace_with = false_value;
929 }
930 } else if (true_value->IsIntConstant() && false_value->IsIntConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +0000931 if (true_value->AsIntConstant()->IsTrue() && false_value->AsIntConstant()->IsFalse()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000932 // Replace (cond ? true : false) with (cond).
933 replace_with = condition;
Roland Levillain1a653882016-03-18 18:05:57 +0000934 } else if (true_value->AsIntConstant()->IsFalse() && false_value->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000935 // Replace (cond ? false : true) with (!cond).
936 replace_with = GetGraph()->InsertOppositeCondition(condition, select);
937 }
Aart Bik4f7dd342017-09-12 13:12:57 -0700938 } else if (condition->IsCondition()) {
939 IfCondition cmp = condition->AsCondition()->GetCondition();
940 HInstruction* a = condition->InputAt(0);
941 HInstruction* b = condition->InputAt(1);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100942 DataType::Type t_type = true_value->GetType();
943 DataType::Type f_type = false_value->GetType();
Aart Bik4f7dd342017-09-12 13:12:57 -0700944 // Here we have a <cmp> b ? true_value : false_value.
945 // Test if both values are same-typed int or long.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100946 if (t_type == f_type &&
947 (t_type == DataType::Type::kInt32 || t_type == DataType::Type::kInt64)) {
Aart Bik4f7dd342017-09-12 13:12:57 -0700948 // Try to replace typical integral ABS constructs.
949 if (true_value->IsNeg()) {
950 HInstruction* negated = true_value->InputAt(0);
951 if ((cmp == kCondLT || cmp == kCondLE) &&
952 (a == negated && a == false_value && IsInt64Value(b, 0))) {
953 // Found a < 0 ? -a : a which can be replaced by ABS(a).
Vladimir Markoca6fff82017-10-03 14:49:14 +0100954 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), false_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700955 }
956 } else if (false_value->IsNeg()) {
957 HInstruction* negated = false_value->InputAt(0);
958 if ((cmp == kCondGT || cmp == kCondGE) &&
959 (a == true_value && a == negated && IsInt64Value(b, 0))) {
960 // Found a > 0 ? a : -a which can be replaced by ABS(a).
Vladimir Markoca6fff82017-10-03 14:49:14 +0100961 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), true_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700962 }
963 } else if (true_value->IsSub() && false_value->IsSub()) {
964 HInstruction* true_sub1 = true_value->InputAt(0);
965 HInstruction* true_sub2 = true_value->InputAt(1);
966 HInstruction* false_sub1 = false_value->InputAt(0);
967 HInstruction* false_sub2 = false_value->InputAt(1);
968 if ((((cmp == kCondGT || cmp == kCondGE) &&
969 (a == true_sub1 && b == true_sub2 && a == false_sub2 && b == false_sub1)) ||
970 ((cmp == kCondLT || cmp == kCondLE) &&
971 (a == true_sub2 && b == true_sub1 && a == false_sub1 && b == false_sub2))) &&
972 AreLowerPrecisionArgs(t_type, a, b)) {
973 // Found a > b ? a - b : b - a or
974 // a < b ? b - a : a - b
975 // which can be replaced by ABS(a - b) for lower precision operands a, b.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100976 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), true_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700977 }
978 }
979 }
David Brazdil74eb1b22015-12-14 11:44:01 +0000980 }
981
982 if (replace_with != nullptr) {
983 select->ReplaceWith(replace_with);
984 select->GetBlock()->RemoveInstruction(select);
985 RecordSimplification();
986 }
987}
988
989void InstructionSimplifierVisitor::VisitIf(HIf* instruction) {
990 HInstruction* condition = instruction->InputAt(0);
991 if (condition->IsBooleanNot()) {
992 // Swap successors if input is negated.
993 instruction->ReplaceInput(condition->InputAt(0), 0);
994 instruction->GetBlock()->SwapSuccessors();
David Brazdil0d13fee2015-04-17 14:52:19 +0100995 RecordSimplification();
996 }
997}
998
Mingyao Yang0304e182015-01-30 16:41:29 -0800999void InstructionSimplifierVisitor::VisitArrayLength(HArrayLength* instruction) {
1000 HInstruction* input = instruction->InputAt(0);
1001 // If the array is a NewArray with constant size, replace the array length
1002 // with the constant instruction. This helps the bounds check elimination phase.
1003 if (input->IsNewArray()) {
Nicolas Geoffraye761bcc2017-01-19 08:59:37 +00001004 input = input->AsNewArray()->GetLength();
Mingyao Yang0304e182015-01-30 16:41:29 -08001005 if (input->IsIntConstant()) {
1006 instruction->ReplaceWith(input);
1007 }
1008 }
1009}
1010
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +00001011void InstructionSimplifierVisitor::VisitArraySet(HArraySet* instruction) {
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001012 HInstruction* value = instruction->GetValue();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001013 if (value->GetType() != DataType::Type::kReference) {
1014 return;
1015 }
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001016
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001017 if (CanEnsureNotNullAt(value, instruction)) {
1018 instruction->ClearValueCanBeNull();
1019 }
1020
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001021 if (value->IsArrayGet()) {
1022 if (value->AsArrayGet()->GetArray() == instruction->GetArray()) {
1023 // If the code is just swapping elements in the array, no need for a type check.
1024 instruction->ClearNeedsTypeCheck();
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001025 return;
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001026 }
1027 }
Nicolas Geoffray07276db2015-05-18 14:22:09 +01001028
Nicolas Geoffray9fdb31e2015-07-01 12:56:46 +01001029 if (value->IsNullConstant()) {
1030 instruction->ClearNeedsTypeCheck();
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001031 return;
Nicolas Geoffray9fdb31e2015-07-01 12:56:46 +01001032 }
1033
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001034 ScopedObjectAccess soa(Thread::Current());
1035 ReferenceTypeInfo array_rti = instruction->GetArray()->GetReferenceTypeInfo();
1036 ReferenceTypeInfo value_rti = value->GetReferenceTypeInfo();
1037 if (!array_rti.IsValid()) {
1038 return;
1039 }
1040
1041 if (value_rti.IsValid() && array_rti.CanArrayHold(value_rti)) {
1042 instruction->ClearNeedsTypeCheck();
1043 return;
1044 }
1045
1046 if (array_rti.IsObjectArray()) {
1047 if (array_rti.IsExact()) {
1048 instruction->ClearNeedsTypeCheck();
1049 return;
1050 }
1051 instruction->SetStaticTypeOfArrayIsObjectArray();
Nicolas Geoffray07276db2015-05-18 14:22:09 +01001052 }
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001053}
1054
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001055static bool IsTypeConversionLossless(DataType::Type input_type, DataType::Type result_type) {
Aart Bikdab69072017-10-23 13:30:39 -07001056 // Make sure all implicit conversions have been simplified and no new ones have been introduced.
1057 DCHECK(!DataType::IsTypeConversionImplicit(input_type, result_type))
1058 << input_type << "," << result_type;
Vladimir Markob52bbde2016-02-12 12:06:05 +00001059 // The conversion to a larger type is loss-less with the exception of two cases,
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001060 // - conversion to the unsigned type Uint16, where we may lose some bits, and
Vladimir Markob52bbde2016-02-12 12:06:05 +00001061 // - conversion from float to long, the only FP to integral conversion with smaller FP type.
1062 // For integral to FP conversions this holds because the FP mantissa is large enough.
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001063 // Note: The size check excludes Uint8 as the result type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001064 return DataType::Size(result_type) > DataType::Size(input_type) &&
1065 result_type != DataType::Type::kUint16 &&
1066 !(result_type == DataType::Type::kInt64 && input_type == DataType::Type::kFloat32);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001067}
1068
Vladimir Marko61b92282017-10-11 13:23:17 +01001069static inline bool TryReplaceFieldOrArrayGetType(HInstruction* maybe_get, DataType::Type new_type) {
1070 if (maybe_get->IsInstanceFieldGet()) {
1071 maybe_get->AsInstanceFieldGet()->SetType(new_type);
1072 return true;
1073 } else if (maybe_get->IsStaticFieldGet()) {
1074 maybe_get->AsStaticFieldGet()->SetType(new_type);
1075 return true;
1076 } else if (maybe_get->IsArrayGet() && !maybe_get->AsArrayGet()->IsStringCharAt()) {
1077 maybe_get->AsArrayGet()->SetType(new_type);
1078 return true;
1079 } else {
1080 return false;
1081 }
1082}
1083
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001084void InstructionSimplifierVisitor::VisitTypeConversion(HTypeConversion* instruction) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001085 HInstruction* input = instruction->GetInput();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001086 DataType::Type input_type = input->GetType();
1087 DataType::Type result_type = instruction->GetResultType();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001088 if (DataType::IsTypeConversionImplicit(input_type, result_type)) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001089 // Remove the implicit conversion; this includes conversion to the same type.
1090 instruction->ReplaceWith(input);
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001091 instruction->GetBlock()->RemoveInstruction(instruction);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001092 RecordSimplification();
1093 return;
1094 }
1095
1096 if (input->IsTypeConversion()) {
1097 HTypeConversion* input_conversion = input->AsTypeConversion();
1098 HInstruction* original_input = input_conversion->GetInput();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001099 DataType::Type original_type = original_input->GetType();
Vladimir Markob52bbde2016-02-12 12:06:05 +00001100
1101 // When the first conversion is lossless, a direct conversion from the original type
1102 // to the final type yields the same result, even for a lossy second conversion, for
1103 // example float->double->int or int->double->float.
1104 bool is_first_conversion_lossless = IsTypeConversionLossless(original_type, input_type);
1105
1106 // For integral conversions, see if the first conversion loses only bits that the second
1107 // doesn't need, i.e. the final type is no wider than the intermediate. If so, direct
1108 // conversion yields the same result, for example long->int->short or int->char->short.
1109 bool integral_conversions_with_non_widening_second =
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001110 DataType::IsIntegralType(input_type) &&
1111 DataType::IsIntegralType(original_type) &&
1112 DataType::IsIntegralType(result_type) &&
1113 DataType::Size(result_type) <= DataType::Size(input_type);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001114
1115 if (is_first_conversion_lossless || integral_conversions_with_non_widening_second) {
1116 // If the merged conversion is implicit, do the simplification unconditionally.
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001117 if (DataType::IsTypeConversionImplicit(original_type, result_type)) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001118 instruction->ReplaceWith(original_input);
1119 instruction->GetBlock()->RemoveInstruction(instruction);
1120 if (!input_conversion->HasUses()) {
1121 // Don't wait for DCE.
1122 input_conversion->GetBlock()->RemoveInstruction(input_conversion);
1123 }
1124 RecordSimplification();
1125 return;
1126 }
1127 // Otherwise simplify only if the first conversion has no other use.
1128 if (input_conversion->HasOnlyOneNonEnvironmentUse()) {
1129 input_conversion->ReplaceWith(original_input);
1130 input_conversion->GetBlock()->RemoveInstruction(input_conversion);
1131 RecordSimplification();
1132 return;
1133 }
1134 }
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001135 } else if (input->IsAnd() && DataType::IsIntegralType(result_type)) {
1136 DCHECK(DataType::IsIntegralType(input_type));
Vladimir Marko8428bd32016-02-12 16:53:57 +00001137 HAnd* input_and = input->AsAnd();
1138 HConstant* constant = input_and->GetConstantRight();
1139 if (constant != nullptr) {
1140 int64_t value = Int64FromConstant(constant);
1141 DCHECK_NE(value, -1); // "& -1" would have been optimized away in VisitAnd().
1142 size_t trailing_ones = CTZ(~static_cast<uint64_t>(value));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001143 if (trailing_ones >= kBitsPerByte * DataType::Size(result_type)) {
Vladimir Marko8428bd32016-02-12 16:53:57 +00001144 // The `HAnd` is useless, for example in `(byte) (x & 0xff)`, get rid of it.
Vladimir Marko625090f2016-03-14 18:00:05 +00001145 HInstruction* original_input = input_and->GetLeastConstantLeft();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001146 if (DataType::IsTypeConversionImplicit(original_input->GetType(), result_type)) {
Vladimir Marko625090f2016-03-14 18:00:05 +00001147 instruction->ReplaceWith(original_input);
1148 instruction->GetBlock()->RemoveInstruction(instruction);
1149 RecordSimplification();
1150 return;
1151 } else if (input->HasOnlyOneNonEnvironmentUse()) {
1152 input_and->ReplaceWith(original_input);
1153 input_and->GetBlock()->RemoveInstruction(input_and);
1154 RecordSimplification();
1155 return;
1156 }
Vladimir Marko8428bd32016-02-12 16:53:57 +00001157 }
1158 }
Vladimir Marko61b92282017-10-11 13:23:17 +01001159 } else if (input->HasOnlyOneNonEnvironmentUse() &&
1160 ((input_type == DataType::Type::kInt8 && result_type == DataType::Type::kUint8) ||
1161 (input_type == DataType::Type::kUint8 && result_type == DataType::Type::kInt8) ||
1162 (input_type == DataType::Type::kInt16 && result_type == DataType::Type::kUint16) ||
1163 (input_type == DataType::Type::kUint16 && result_type == DataType::Type::kInt16))) {
1164 // Try to modify the type of the load to `result_type` and remove the explicit type conversion.
1165 if (TryReplaceFieldOrArrayGetType(input, result_type)) {
1166 instruction->ReplaceWith(input);
1167 instruction->GetBlock()->RemoveInstruction(instruction);
1168 RecordSimplification();
1169 return;
1170 }
Mingyao Yangcebb5e72017-11-21 14:44:54 -08001171 } else if (input->IsIntConstant()) {
1172 // Try to eliminate type conversion on int constant whose value falls into
1173 // the range of the result type.
1174 int32_t value = input->AsIntConstant()->GetValue();
1175 if (DataType::IsTypeConversionImplicit(value, result_type)) {
1176 instruction->ReplaceWith(input);
1177 instruction->GetBlock()->RemoveInstruction(instruction);
1178 RecordSimplification();
1179 return;
1180 }
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001181 }
1182}
1183
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001184void InstructionSimplifierVisitor::VisitAdd(HAdd* instruction) {
1185 HConstant* input_cst = instruction->GetConstantRight();
1186 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001187 bool integral_type = DataType::IsIntegralType(instruction->GetType());
Roland Levillain1a653882016-03-18 18:05:57 +00001188 if ((input_cst != nullptr) && input_cst->IsArithmeticZero()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001189 // Replace code looking like
1190 // ADD dst, src, 0
1191 // with
1192 // src
Serguei Katkov115b53f2015-08-05 17:03:30 +06001193 // Note that we cannot optimize `x + 0.0` to `x` for floating-point. When
1194 // `x` is `-0.0`, the former expression yields `0.0`, while the later
1195 // yields `-0.0`.
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001196 if (integral_type) {
Serguei Katkov115b53f2015-08-05 17:03:30 +06001197 instruction->ReplaceWith(input_other);
1198 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001199 RecordSimplification();
Serguei Katkov115b53f2015-08-05 17:03:30 +06001200 return;
1201 }
Alexandre Rames188d4312015-04-09 18:30:21 +01001202 }
1203
1204 HInstruction* left = instruction->GetLeft();
1205 HInstruction* right = instruction->GetRight();
1206 bool left_is_neg = left->IsNeg();
1207 bool right_is_neg = right->IsNeg();
1208
1209 if (left_is_neg && right_is_neg) {
1210 if (TryMoveNegOnInputsAfterBinop(instruction)) {
1211 return;
1212 }
1213 }
1214
1215 HNeg* neg = left_is_neg ? left->AsNeg() : right->AsNeg();
1216 if ((left_is_neg ^ right_is_neg) && neg->HasOnlyOneNonEnvironmentUse()) {
1217 // Replace code looking like
1218 // NEG tmp, b
1219 // ADD dst, a, tmp
1220 // with
1221 // SUB dst, a, b
1222 // We do not perform the optimization if the input negation has environment
1223 // uses or multiple non-environment uses as it could lead to worse code. In
1224 // particular, we do not want the live range of `b` to be extended if we are
1225 // not sure the initial 'NEG' instruction can be removed.
1226 HInstruction* other = left_is_neg ? right : left;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001227 HSub* sub =
1228 new(GetGraph()->GetAllocator()) HSub(instruction->GetType(), other, neg->GetInput());
Alexandre Rames188d4312015-04-09 18:30:21 +01001229 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, sub);
1230 RecordSimplification();
1231 neg->GetBlock()->RemoveInstruction(neg);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001232 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001233 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001234
Anton Kirilove14dc862016-05-13 17:56:15 +01001235 if (TryReplaceWithRotate(instruction)) {
1236 return;
1237 }
1238
1239 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1240 // so no need to return.
1241 TryHandleAssociativeAndCommutativeOperation(instruction);
1242
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001243 if ((left->IsSub() || right->IsSub()) &&
Anton Kirilove14dc862016-05-13 17:56:15 +01001244 TrySubtractionChainSimplification(instruction)) {
1245 return;
1246 }
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001247
1248 if (integral_type) {
1249 // Replace code patterns looking like
1250 // SUB dst1, x, y SUB dst1, x, y
1251 // ADD dst2, dst1, y ADD dst2, y, dst1
1252 // with
1253 // SUB dst1, x, y
1254 // ADD instruction is not needed in this case, we may use
1255 // one of inputs of SUB instead.
1256 if (left->IsSub() && left->InputAt(1) == right) {
1257 instruction->ReplaceWith(left->InputAt(0));
1258 RecordSimplification();
1259 instruction->GetBlock()->RemoveInstruction(instruction);
1260 return;
1261 } else if (right->IsSub() && right->InputAt(1) == left) {
1262 instruction->ReplaceWith(right->InputAt(0));
1263 RecordSimplification();
1264 instruction->GetBlock()->RemoveInstruction(instruction);
1265 return;
1266 }
1267 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001268}
1269
1270void InstructionSimplifierVisitor::VisitAnd(HAnd* instruction) {
Vladimir Marko61b92282017-10-11 13:23:17 +01001271 DCHECK(DataType::IsIntegralType(instruction->GetType()));
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001272 HConstant* input_cst = instruction->GetConstantRight();
1273 HInstruction* input_other = instruction->GetLeastConstantLeft();
1274
Vladimir Marko452c1b62015-09-25 14:44:17 +01001275 if (input_cst != nullptr) {
1276 int64_t value = Int64FromConstant(input_cst);
Aart Bikdab69072017-10-23 13:30:39 -07001277 if (value == -1 ||
1278 // Similar cases under zero extension.
1279 (DataType::IsUnsignedType(input_other->GetType()) &&
1280 ((DataType::MaxValueOfIntegralType(input_other->GetType()) & ~value) == 0))) {
Vladimir Marko452c1b62015-09-25 14:44:17 +01001281 // Replace code looking like
1282 // AND dst, src, 0xFFF...FF
1283 // with
1284 // src
1285 instruction->ReplaceWith(input_other);
1286 instruction->GetBlock()->RemoveInstruction(instruction);
1287 RecordSimplification();
1288 return;
1289 }
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001290 if (input_other->IsTypeConversion() &&
1291 input_other->GetType() == DataType::Type::kInt64 &&
1292 DataType::IsIntegralType(input_other->InputAt(0)->GetType()) &&
1293 IsInt<32>(value) &&
1294 input_other->HasOnlyOneNonEnvironmentUse()) {
1295 // The AND can be reordered before the TypeConversion. Replace
1296 // LongConstant cst, <32-bit-constant-sign-extended-to-64-bits>
1297 // TypeConversion<Int64> tmp, src
1298 // AND dst, tmp, cst
1299 // with
1300 // IntConstant cst, <32-bit-constant>
1301 // AND tmp, src, cst
1302 // TypeConversion<Int64> dst, tmp
1303 // This helps 32-bit targets and does not hurt 64-bit targets.
1304 // This also simplifies detection of other patterns, such as Uint8 loads.
1305 HInstruction* new_and_input = input_other->InputAt(0);
1306 // Implicit conversion Int64->Int64 would have been removed previously.
1307 DCHECK_NE(new_and_input->GetType(), DataType::Type::kInt64);
1308 HConstant* new_const = GetGraph()->GetConstant(DataType::Type::kInt32, value);
1309 HAnd* new_and =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001310 new (GetGraph()->GetAllocator()) HAnd(DataType::Type::kInt32, new_and_input, new_const);
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001311 instruction->GetBlock()->InsertInstructionBefore(new_and, instruction);
1312 HTypeConversion* new_conversion =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001313 new (GetGraph()->GetAllocator()) HTypeConversion(DataType::Type::kInt64, new_and);
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001314 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, new_conversion);
1315 input_other->GetBlock()->RemoveInstruction(input_other);
1316 RecordSimplification();
1317 // Try to process the new And now, do not wait for the next round of simplifications.
1318 instruction = new_and;
1319 input_other = new_and_input;
1320 }
Vladimir Marko452c1b62015-09-25 14:44:17 +01001321 // Eliminate And from UShr+And if the And-mask contains all the bits that
1322 // can be non-zero after UShr. Transform Shr+And to UShr if the And-mask
1323 // precisely clears the shifted-in sign bits.
1324 if ((input_other->IsUShr() || input_other->IsShr()) && input_other->InputAt(1)->IsConstant()) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001325 size_t reg_bits = (instruction->GetResultType() == DataType::Type::kInt64) ? 64 : 32;
Vladimir Marko452c1b62015-09-25 14:44:17 +01001326 size_t shift = Int64FromConstant(input_other->InputAt(1)->AsConstant()) & (reg_bits - 1);
1327 size_t num_tail_bits_set = CTZ(value + 1);
1328 if ((num_tail_bits_set >= reg_bits - shift) && input_other->IsUShr()) {
1329 // This AND clears only bits known to be clear, for example "(x >>> 24) & 0xff".
1330 instruction->ReplaceWith(input_other);
1331 instruction->GetBlock()->RemoveInstruction(instruction);
1332 RecordSimplification();
1333 return;
1334 } else if ((num_tail_bits_set == reg_bits - shift) && IsPowerOfTwo(value + 1) &&
1335 input_other->HasOnlyOneNonEnvironmentUse()) {
1336 DCHECK(input_other->IsShr()); // For UShr, we would have taken the branch above.
1337 // Replace SHR+AND with USHR, for example "(x >> 24) & 0xff" -> "x >>> 24".
Vladimir Markoca6fff82017-10-03 14:49:14 +01001338 HUShr* ushr = new (GetGraph()->GetAllocator()) HUShr(instruction->GetType(),
Vladimir Marko69d310e2017-10-09 14:12:23 +01001339 input_other->InputAt(0),
1340 input_other->InputAt(1),
1341 input_other->GetDexPc());
Vladimir Marko452c1b62015-09-25 14:44:17 +01001342 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, ushr);
1343 input_other->GetBlock()->RemoveInstruction(input_other);
1344 RecordSimplification();
1345 return;
1346 }
1347 }
Vladimir Marko61b92282017-10-11 13:23:17 +01001348 if ((value == 0xff || value == 0xffff) && instruction->GetType() != DataType::Type::kInt64) {
1349 // Transform AND to a type conversion to Uint8/Uint16. If `input_other` is a field
1350 // or array Get with only a single use, short-circuit the subsequent simplification
1351 // of the Get+TypeConversion and change the Get's type to `new_type` instead.
1352 DataType::Type new_type = (value == 0xff) ? DataType::Type::kUint8 : DataType::Type::kUint16;
1353 DataType::Type find_type = (value == 0xff) ? DataType::Type::kInt8 : DataType::Type::kInt16;
1354 if (input_other->GetType() == find_type &&
1355 input_other->HasOnlyOneNonEnvironmentUse() &&
1356 TryReplaceFieldOrArrayGetType(input_other, new_type)) {
1357 instruction->ReplaceWith(input_other);
1358 instruction->GetBlock()->RemoveInstruction(instruction);
Aart Bikdab69072017-10-23 13:30:39 -07001359 } else if (DataType::IsTypeConversionImplicit(input_other->GetType(), new_type)) {
1360 instruction->ReplaceWith(input_other);
1361 instruction->GetBlock()->RemoveInstruction(instruction);
Vladimir Marko61b92282017-10-11 13:23:17 +01001362 } else {
1363 HTypeConversion* type_conversion = new (GetGraph()->GetAllocator()) HTypeConversion(
1364 new_type, input_other, instruction->GetDexPc());
1365 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, type_conversion);
1366 }
1367 RecordSimplification();
1368 return;
1369 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001370 }
1371
1372 // We assume that GVN has run before, so we only perform a pointer comparison.
1373 // If for some reason the values are equal but the pointers are different, we
Alexandre Rames188d4312015-04-09 18:30:21 +01001374 // are still correct and only miss an optimization opportunity.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001375 if (instruction->GetLeft() == instruction->GetRight()) {
1376 // Replace code looking like
1377 // AND dst, src, src
1378 // with
1379 // src
1380 instruction->ReplaceWith(instruction->GetLeft());
1381 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001382 RecordSimplification();
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001383 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001384 }
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001385
Anton Kirilove14dc862016-05-13 17:56:15 +01001386 if (TryDeMorganNegationFactoring(instruction)) {
1387 return;
1388 }
1389
1390 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1391 // so no need to return.
1392 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001393}
1394
Mark Mendellc4701932015-04-10 13:18:51 -04001395void InstructionSimplifierVisitor::VisitGreaterThan(HGreaterThan* condition) {
1396 VisitCondition(condition);
1397}
1398
1399void InstructionSimplifierVisitor::VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) {
1400 VisitCondition(condition);
1401}
1402
1403void InstructionSimplifierVisitor::VisitLessThan(HLessThan* condition) {
1404 VisitCondition(condition);
1405}
1406
1407void InstructionSimplifierVisitor::VisitLessThanOrEqual(HLessThanOrEqual* condition) {
1408 VisitCondition(condition);
1409}
1410
Anton Shaminbdd79352016-02-15 12:48:36 +06001411void InstructionSimplifierVisitor::VisitBelow(HBelow* condition) {
1412 VisitCondition(condition);
1413}
1414
1415void InstructionSimplifierVisitor::VisitBelowOrEqual(HBelowOrEqual* condition) {
1416 VisitCondition(condition);
1417}
1418
1419void InstructionSimplifierVisitor::VisitAbove(HAbove* condition) {
1420 VisitCondition(condition);
1421}
1422
1423void InstructionSimplifierVisitor::VisitAboveOrEqual(HAboveOrEqual* condition) {
1424 VisitCondition(condition);
1425}
Aart Bike9f37602015-10-09 11:15:55 -07001426
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001427// Recognize the following pattern:
1428// obj.getClass() ==/!= Foo.class
1429// And replace it with a constant value if the type of `obj` is statically known.
1430static bool RecognizeAndSimplifyClassCheck(HCondition* condition) {
1431 HInstruction* input_one = condition->InputAt(0);
1432 HInstruction* input_two = condition->InputAt(1);
1433 HLoadClass* load_class = input_one->IsLoadClass()
1434 ? input_one->AsLoadClass()
1435 : input_two->AsLoadClass();
1436 if (load_class == nullptr) {
1437 return false;
1438 }
1439
1440 ReferenceTypeInfo class_rti = load_class->GetLoadedClassRTI();
1441 if (!class_rti.IsValid()) {
1442 // Unresolved class.
1443 return false;
1444 }
1445
1446 HInstanceFieldGet* field_get = (load_class == input_one)
1447 ? input_two->AsInstanceFieldGet()
1448 : input_one->AsInstanceFieldGet();
1449 if (field_get == nullptr) {
1450 return false;
1451 }
1452
1453 HInstruction* receiver = field_get->InputAt(0);
1454 ReferenceTypeInfo receiver_type = receiver->GetReferenceTypeInfo();
1455 if (!receiver_type.IsExact()) {
1456 return false;
1457 }
1458
1459 {
1460 ScopedObjectAccess soa(Thread::Current());
1461 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1462 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
1463 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
1464 if (field_get->GetFieldInfo().GetField() != field) {
1465 return false;
1466 }
1467
1468 // We can replace the compare.
1469 int value = 0;
1470 if (receiver_type.IsEqual(class_rti)) {
1471 value = condition->IsEqual() ? 1 : 0;
1472 } else {
1473 value = condition->IsNotEqual() ? 1 : 0;
1474 }
1475 condition->ReplaceWith(condition->GetBlock()->GetGraph()->GetIntConstant(value));
1476 return true;
1477 }
1478}
1479
Mark Mendellc4701932015-04-10 13:18:51 -04001480void InstructionSimplifierVisitor::VisitCondition(HCondition* condition) {
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001481 if (condition->IsEqual() || condition->IsNotEqual()) {
1482 if (RecognizeAndSimplifyClassCheck(condition)) {
1483 return;
1484 }
1485 }
1486
Anton Shaminbdd79352016-02-15 12:48:36 +06001487 // Reverse condition if left is constant. Our code generators prefer constant
1488 // on the right hand side.
1489 if (condition->GetLeft()->IsConstant() && !condition->GetRight()->IsConstant()) {
1490 HBasicBlock* block = condition->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001491 HCondition* replacement =
1492 GetOppositeConditionSwapOps(block->GetGraph()->GetAllocator(), condition);
Anton Shaminbdd79352016-02-15 12:48:36 +06001493 // If it is a fp we must set the opposite bias.
1494 if (replacement != nullptr) {
1495 if (condition->IsLtBias()) {
1496 replacement->SetBias(ComparisonBias::kGtBias);
1497 } else if (condition->IsGtBias()) {
1498 replacement->SetBias(ComparisonBias::kLtBias);
1499 }
1500 block->ReplaceAndRemoveInstructionWith(condition, replacement);
1501 RecordSimplification();
1502
1503 condition = replacement;
1504 }
1505 }
Mark Mendellc4701932015-04-10 13:18:51 -04001506
Mark Mendellc4701932015-04-10 13:18:51 -04001507 HInstruction* left = condition->GetLeft();
1508 HInstruction* right = condition->GetRight();
Anton Shaminbdd79352016-02-15 12:48:36 +06001509
1510 // Try to fold an HCompare into this HCondition.
1511
Mark Mendellc4701932015-04-10 13:18:51 -04001512 // We can only replace an HCondition which compares a Compare to 0.
1513 // Both 'dx' and 'jack' generate a compare to 0 when compiling a
1514 // condition with a long, float or double comparison as input.
1515 if (!left->IsCompare() || !right->IsConstant() || right->AsIntConstant()->GetValue() != 0) {
1516 // Conversion is not possible.
1517 return;
1518 }
1519
1520 // Is the Compare only used for this purpose?
Vladimir Marko46817b82016-03-29 12:21:58 +01001521 if (!left->GetUses().HasExactlyOneElement()) {
Mark Mendellc4701932015-04-10 13:18:51 -04001522 // Someone else also wants the result of the compare.
1523 return;
1524 }
1525
Vladimir Marko46817b82016-03-29 12:21:58 +01001526 if (!left->GetEnvUses().empty()) {
Mark Mendellc4701932015-04-10 13:18:51 -04001527 // There is a reference to the compare result in an environment. Do we really need it?
1528 if (GetGraph()->IsDebuggable()) {
1529 return;
1530 }
1531
1532 // We have to ensure that there are no deopt points in the sequence.
1533 if (left->HasAnyEnvironmentUseBefore(condition)) {
1534 return;
1535 }
1536 }
1537
1538 // Clean up any environment uses from the HCompare, if any.
1539 left->RemoveEnvironmentUsers();
1540
1541 // We have decided to fold the HCompare into the HCondition. Transfer the information.
1542 condition->SetBias(left->AsCompare()->GetBias());
1543
1544 // Replace the operands of the HCondition.
1545 condition->ReplaceInput(left->InputAt(0), 0);
1546 condition->ReplaceInput(left->InputAt(1), 1);
1547
1548 // Remove the HCompare.
1549 left->GetBlock()->RemoveInstruction(left);
1550
1551 RecordSimplification();
1552}
1553
Andreas Gampe9186ced2016-12-12 14:28:21 -08001554// Return whether x / divisor == x * (1.0f / divisor), for every float x.
1555static constexpr bool CanDivideByReciprocalMultiplyFloat(int32_t divisor) {
1556 // True, if the most significant bits of divisor are 0.
1557 return ((divisor & 0x7fffff) == 0);
1558}
1559
1560// Return whether x / divisor == x * (1.0 / divisor), for every double x.
1561static constexpr bool CanDivideByReciprocalMultiplyDouble(int64_t divisor) {
1562 // True, if the most significant bits of divisor are 0.
1563 return ((divisor & ((UINT64_C(1) << 52) - 1)) == 0);
1564}
1565
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001566void InstructionSimplifierVisitor::VisitDiv(HDiv* instruction) {
1567 HConstant* input_cst = instruction->GetConstantRight();
1568 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001569 DataType::Type type = instruction->GetType();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001570
1571 if ((input_cst != nullptr) && input_cst->IsOne()) {
1572 // Replace code looking like
1573 // DIV dst, src, 1
1574 // with
1575 // src
1576 instruction->ReplaceWith(input_other);
1577 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001578 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001579 return;
1580 }
1581
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001582 if ((input_cst != nullptr) && input_cst->IsMinusOne()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001583 // Replace code looking like
1584 // DIV dst, src, -1
1585 // with
1586 // NEG dst, src
1587 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(
Vladimir Markoca6fff82017-10-03 14:49:14 +01001588 instruction, new (GetGraph()->GetAllocator()) HNeg(type, input_other));
Alexandre Rames188d4312015-04-09 18:30:21 +01001589 RecordSimplification();
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001590 return;
1591 }
1592
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001593 if ((input_cst != nullptr) && DataType::IsFloatingPointType(type)) {
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001594 // Try replacing code looking like
1595 // DIV dst, src, constant
1596 // with
1597 // MUL dst, src, 1 / constant
1598 HConstant* reciprocal = nullptr;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001599 if (type == DataType::Type::kFloat64) {
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001600 double value = input_cst->AsDoubleConstant()->GetValue();
1601 if (CanDivideByReciprocalMultiplyDouble(bit_cast<int64_t, double>(value))) {
1602 reciprocal = GetGraph()->GetDoubleConstant(1.0 / value);
1603 }
1604 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001605 DCHECK_EQ(type, DataType::Type::kFloat32);
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001606 float value = input_cst->AsFloatConstant()->GetValue();
1607 if (CanDivideByReciprocalMultiplyFloat(bit_cast<int32_t, float>(value))) {
1608 reciprocal = GetGraph()->GetFloatConstant(1.0f / value);
1609 }
1610 }
1611
1612 if (reciprocal != nullptr) {
1613 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(
Vladimir Markoca6fff82017-10-03 14:49:14 +01001614 instruction, new (GetGraph()->GetAllocator()) HMul(type, input_other, reciprocal));
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001615 RecordSimplification();
1616 return;
1617 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001618 }
1619}
1620
1621void InstructionSimplifierVisitor::VisitMul(HMul* instruction) {
1622 HConstant* input_cst = instruction->GetConstantRight();
1623 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001624 DataType::Type type = instruction->GetType();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001625 HBasicBlock* block = instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001626 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001627
1628 if (input_cst == nullptr) {
1629 return;
1630 }
1631
1632 if (input_cst->IsOne()) {
1633 // Replace code looking like
1634 // MUL dst, src, 1
1635 // with
1636 // src
1637 instruction->ReplaceWith(input_other);
1638 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001639 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001640 return;
1641 }
1642
1643 if (input_cst->IsMinusOne() &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001644 (DataType::IsFloatingPointType(type) || DataType::IsIntOrLongType(type))) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001645 // Replace code looking like
1646 // MUL dst, src, -1
1647 // with
1648 // NEG dst, src
1649 HNeg* neg = new (allocator) HNeg(type, input_other);
1650 block->ReplaceAndRemoveInstructionWith(instruction, neg);
Alexandre Rames188d4312015-04-09 18:30:21 +01001651 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001652 return;
1653 }
1654
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001655 if (DataType::IsFloatingPointType(type) &&
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001656 ((input_cst->IsFloatConstant() && input_cst->AsFloatConstant()->GetValue() == 2.0f) ||
1657 (input_cst->IsDoubleConstant() && input_cst->AsDoubleConstant()->GetValue() == 2.0))) {
1658 // Replace code looking like
1659 // FP_MUL dst, src, 2.0
1660 // with
1661 // FP_ADD dst, src, src
1662 // The 'int' and 'long' cases are handled below.
1663 block->ReplaceAndRemoveInstructionWith(instruction,
1664 new (allocator) HAdd(type, input_other, input_other));
Alexandre Rames188d4312015-04-09 18:30:21 +01001665 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001666 return;
1667 }
1668
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001669 if (DataType::IsIntOrLongType(type)) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001670 int64_t factor = Int64FromConstant(input_cst);
Serguei Katkov53849192015-04-20 14:22:27 +06001671 // Even though constant propagation also takes care of the zero case, other
1672 // optimizations can lead to having a zero multiplication.
1673 if (factor == 0) {
1674 // Replace code looking like
1675 // MUL dst, src, 0
1676 // with
1677 // 0
1678 instruction->ReplaceWith(input_cst);
1679 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001680 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001681 return;
Serguei Katkov53849192015-04-20 14:22:27 +06001682 } else if (IsPowerOfTwo(factor)) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001683 // Replace code looking like
1684 // MUL dst, src, pow_of_2
1685 // with
1686 // SHL dst, src, log2(pow_of_2)
David Brazdil8d5b8b22015-03-24 10:51:52 +00001687 HIntConstant* shift = GetGraph()->GetIntConstant(WhichPowerOf2(factor));
Roland Levillain22c49222016-03-18 14:04:28 +00001688 HShl* shl = new (allocator) HShl(type, input_other, shift);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001689 block->ReplaceAndRemoveInstructionWith(instruction, shl);
Alexandre Rames188d4312015-04-09 18:30:21 +01001690 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001691 return;
Alexandre Rames38db7852015-11-20 15:02:45 +00001692 } else if (IsPowerOfTwo(factor - 1)) {
1693 // Transform code looking like
1694 // MUL dst, src, (2^n + 1)
1695 // into
1696 // SHL tmp, src, n
1697 // ADD dst, src, tmp
1698 HShl* shl = new (allocator) HShl(type,
1699 input_other,
1700 GetGraph()->GetIntConstant(WhichPowerOf2(factor - 1)));
1701 HAdd* add = new (allocator) HAdd(type, input_other, shl);
1702
1703 block->InsertInstructionBefore(shl, instruction);
1704 block->ReplaceAndRemoveInstructionWith(instruction, add);
1705 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001706 return;
Alexandre Rames38db7852015-11-20 15:02:45 +00001707 } else if (IsPowerOfTwo(factor + 1)) {
1708 // Transform code looking like
1709 // MUL dst, src, (2^n - 1)
1710 // into
1711 // SHL tmp, src, n
1712 // SUB dst, tmp, src
1713 HShl* shl = new (allocator) HShl(type,
1714 input_other,
1715 GetGraph()->GetIntConstant(WhichPowerOf2(factor + 1)));
1716 HSub* sub = new (allocator) HSub(type, shl, input_other);
1717
1718 block->InsertInstructionBefore(shl, instruction);
1719 block->ReplaceAndRemoveInstructionWith(instruction, sub);
1720 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001721 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001722 }
1723 }
Anton Kirilove14dc862016-05-13 17:56:15 +01001724
1725 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1726 // so no need to return.
1727 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001728}
1729
Alexandre Rames188d4312015-04-09 18:30:21 +01001730void InstructionSimplifierVisitor::VisitNeg(HNeg* instruction) {
1731 HInstruction* input = instruction->GetInput();
1732 if (input->IsNeg()) {
1733 // Replace code looking like
1734 // NEG tmp, src
1735 // NEG dst, tmp
1736 // with
1737 // src
1738 HNeg* previous_neg = input->AsNeg();
1739 instruction->ReplaceWith(previous_neg->GetInput());
1740 instruction->GetBlock()->RemoveInstruction(instruction);
1741 // We perform the optimization even if the input negation has environment
1742 // uses since it allows removing the current instruction. But we only delete
1743 // the input negation only if it is does not have any uses left.
1744 if (!previous_neg->HasUses()) {
1745 previous_neg->GetBlock()->RemoveInstruction(previous_neg);
1746 }
1747 RecordSimplification();
1748 return;
1749 }
1750
Serguei Katkov339dfc22015-04-20 12:29:32 +06001751 if (input->IsSub() && input->HasOnlyOneNonEnvironmentUse() &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001752 !DataType::IsFloatingPointType(input->GetType())) {
Alexandre Rames188d4312015-04-09 18:30:21 +01001753 // Replace code looking like
1754 // SUB tmp, a, b
1755 // NEG dst, tmp
1756 // with
1757 // SUB dst, b, a
1758 // We do not perform the optimization if the input subtraction has
1759 // environment uses or multiple non-environment uses as it could lead to
1760 // worse code. In particular, we do not want the live ranges of `a` and `b`
1761 // to be extended if we are not sure the initial 'SUB' instruction can be
1762 // removed.
Serguei Katkov339dfc22015-04-20 12:29:32 +06001763 // We do not perform optimization for fp because we could lose the sign of zero.
Alexandre Rames188d4312015-04-09 18:30:21 +01001764 HSub* sub = input->AsSub();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001765 HSub* new_sub = new (GetGraph()->GetAllocator()) HSub(
1766 instruction->GetType(), sub->GetRight(), sub->GetLeft());
Alexandre Rames188d4312015-04-09 18:30:21 +01001767 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, new_sub);
1768 if (!sub->HasUses()) {
1769 sub->GetBlock()->RemoveInstruction(sub);
1770 }
1771 RecordSimplification();
1772 }
1773}
1774
1775void InstructionSimplifierVisitor::VisitNot(HNot* instruction) {
1776 HInstruction* input = instruction->GetInput();
1777 if (input->IsNot()) {
1778 // Replace code looking like
1779 // NOT tmp, src
1780 // NOT dst, tmp
1781 // with
1782 // src
1783 // We perform the optimization even if the input negation has environment
1784 // uses since it allows removing the current instruction. But we only delete
1785 // the input negation only if it is does not have any uses left.
1786 HNot* previous_not = input->AsNot();
1787 instruction->ReplaceWith(previous_not->GetInput());
1788 instruction->GetBlock()->RemoveInstruction(instruction);
1789 if (!previous_not->HasUses()) {
1790 previous_not->GetBlock()->RemoveInstruction(previous_not);
1791 }
1792 RecordSimplification();
1793 }
1794}
1795
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001796void InstructionSimplifierVisitor::VisitOr(HOr* instruction) {
1797 HConstant* input_cst = instruction->GetConstantRight();
1798 HInstruction* input_other = instruction->GetLeastConstantLeft();
1799
Roland Levillain1a653882016-03-18 18:05:57 +00001800 if ((input_cst != nullptr) && input_cst->IsZeroBitPattern()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001801 // Replace code looking like
1802 // OR dst, src, 0
1803 // with
1804 // src
1805 instruction->ReplaceWith(input_other);
1806 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001807 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001808 return;
1809 }
1810
1811 // We assume that GVN has run before, so we only perform a pointer comparison.
1812 // If for some reason the values are equal but the pointers are different, we
Alexandre Rames188d4312015-04-09 18:30:21 +01001813 // are still correct and only miss an optimization opportunity.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001814 if (instruction->GetLeft() == instruction->GetRight()) {
1815 // Replace code looking like
1816 // OR dst, src, src
1817 // with
1818 // src
1819 instruction->ReplaceWith(instruction->GetLeft());
1820 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001821 RecordSimplification();
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001822 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001823 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001824
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001825 if (TryDeMorganNegationFactoring(instruction)) return;
1826
Anton Kirilove14dc862016-05-13 17:56:15 +01001827 if (TryReplaceWithRotate(instruction)) {
1828 return;
1829 }
1830
1831 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1832 // so no need to return.
1833 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001834}
1835
1836void InstructionSimplifierVisitor::VisitShl(HShl* instruction) {
1837 VisitShift(instruction);
1838}
1839
1840void InstructionSimplifierVisitor::VisitShr(HShr* instruction) {
1841 VisitShift(instruction);
1842}
1843
1844void InstructionSimplifierVisitor::VisitSub(HSub* instruction) {
1845 HConstant* input_cst = instruction->GetConstantRight();
1846 HInstruction* input_other = instruction->GetLeastConstantLeft();
1847
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001848 DataType::Type type = instruction->GetType();
1849 if (DataType::IsFloatingPointType(type)) {
Serguei Katkov115b53f2015-08-05 17:03:30 +06001850 return;
1851 }
1852
Roland Levillain1a653882016-03-18 18:05:57 +00001853 if ((input_cst != nullptr) && input_cst->IsArithmeticZero()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001854 // Replace code looking like
1855 // SUB dst, src, 0
1856 // with
1857 // src
Serguei Katkov115b53f2015-08-05 17:03:30 +06001858 // Note that we cannot optimize `x - 0.0` to `x` for floating-point. When
1859 // `x` is `-0.0`, the former expression yields `0.0`, while the later
1860 // yields `-0.0`.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001861 instruction->ReplaceWith(input_other);
1862 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001863 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001864 return;
1865 }
1866
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001867 HBasicBlock* block = instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001868 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001869
Alexandre Rames188d4312015-04-09 18:30:21 +01001870 HInstruction* left = instruction->GetLeft();
1871 HInstruction* right = instruction->GetRight();
1872 if (left->IsConstant()) {
1873 if (Int64FromConstant(left->AsConstant()) == 0) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001874 // Replace code looking like
1875 // SUB dst, 0, src
1876 // with
1877 // NEG dst, src
Alexandre Rames188d4312015-04-09 18:30:21 +01001878 // Note that we cannot optimize `0.0 - x` to `-x` for floating-point. When
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001879 // `x` is `0.0`, the former expression yields `0.0`, while the later
1880 // yields `-0.0`.
Alexandre Rames188d4312015-04-09 18:30:21 +01001881 HNeg* neg = new (allocator) HNeg(type, right);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001882 block->ReplaceAndRemoveInstructionWith(instruction, neg);
Alexandre Rames188d4312015-04-09 18:30:21 +01001883 RecordSimplification();
1884 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001885 }
1886 }
Alexandre Rames188d4312015-04-09 18:30:21 +01001887
1888 if (left->IsNeg() && right->IsNeg()) {
1889 if (TryMoveNegOnInputsAfterBinop(instruction)) {
1890 return;
1891 }
1892 }
1893
1894 if (right->IsNeg() && right->HasOnlyOneNonEnvironmentUse()) {
1895 // Replace code looking like
1896 // NEG tmp, b
1897 // SUB dst, a, tmp
1898 // with
1899 // ADD dst, a, b
Vladimir Markoca6fff82017-10-03 14:49:14 +01001900 HAdd* add = new(GetGraph()->GetAllocator()) HAdd(type, left, right->AsNeg()->GetInput());
Alexandre Rames188d4312015-04-09 18:30:21 +01001901 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, add);
1902 RecordSimplification();
1903 right->GetBlock()->RemoveInstruction(right);
1904 return;
1905 }
1906
1907 if (left->IsNeg() && left->HasOnlyOneNonEnvironmentUse()) {
1908 // Replace code looking like
1909 // NEG tmp, a
1910 // SUB dst, tmp, b
1911 // with
1912 // ADD tmp, a, b
1913 // NEG dst, tmp
1914 // The second version is not intrinsically better, but enables more
1915 // transformations.
Vladimir Markoca6fff82017-10-03 14:49:14 +01001916 HAdd* add = new(GetGraph()->GetAllocator()) HAdd(type, left->AsNeg()->GetInput(), right);
Alexandre Rames188d4312015-04-09 18:30:21 +01001917 instruction->GetBlock()->InsertInstructionBefore(add, instruction);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001918 HNeg* neg = new (GetGraph()->GetAllocator()) HNeg(instruction->GetType(), add);
Alexandre Rames188d4312015-04-09 18:30:21 +01001919 instruction->GetBlock()->InsertInstructionBefore(neg, instruction);
1920 instruction->ReplaceWith(neg);
1921 instruction->GetBlock()->RemoveInstruction(instruction);
1922 RecordSimplification();
1923 left->GetBlock()->RemoveInstruction(left);
Anton Kirilove14dc862016-05-13 17:56:15 +01001924 return;
1925 }
1926
1927 if (TrySubtractionChainSimplification(instruction)) {
1928 return;
Alexandre Rames188d4312015-04-09 18:30:21 +01001929 }
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001930
1931 if (left->IsAdd()) {
1932 // Replace code patterns looking like
1933 // ADD dst1, x, y ADD dst1, x, y
1934 // SUB dst2, dst1, y SUB dst2, dst1, x
1935 // with
1936 // ADD dst1, x, y
1937 // SUB instruction is not needed in this case, we may use
1938 // one of inputs of ADD instead.
1939 // It is applicable to integral types only.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001940 DCHECK(DataType::IsIntegralType(type));
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001941 if (left->InputAt(1) == right) {
1942 instruction->ReplaceWith(left->InputAt(0));
1943 RecordSimplification();
1944 instruction->GetBlock()->RemoveInstruction(instruction);
1945 return;
1946 } else if (left->InputAt(0) == right) {
1947 instruction->ReplaceWith(left->InputAt(1));
1948 RecordSimplification();
1949 instruction->GetBlock()->RemoveInstruction(instruction);
1950 return;
1951 }
1952 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001953}
1954
1955void InstructionSimplifierVisitor::VisitUShr(HUShr* instruction) {
1956 VisitShift(instruction);
1957}
1958
1959void InstructionSimplifierVisitor::VisitXor(HXor* instruction) {
1960 HConstant* input_cst = instruction->GetConstantRight();
1961 HInstruction* input_other = instruction->GetLeastConstantLeft();
1962
Roland Levillain1a653882016-03-18 18:05:57 +00001963 if ((input_cst != nullptr) && input_cst->IsZeroBitPattern()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001964 // Replace code looking like
1965 // XOR dst, src, 0
1966 // with
1967 // src
1968 instruction->ReplaceWith(input_other);
1969 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001970 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001971 return;
1972 }
1973
Sebastien Hertz9837caf2016-08-01 11:09:50 +02001974 if ((input_cst != nullptr) && input_cst->IsOne()
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001975 && input_other->GetType() == DataType::Type::kBool) {
Sebastien Hertz9837caf2016-08-01 11:09:50 +02001976 // Replace code looking like
1977 // XOR dst, src, 1
1978 // with
1979 // BOOLEAN_NOT dst, src
Vladimir Markoca6fff82017-10-03 14:49:14 +01001980 HBooleanNot* boolean_not = new (GetGraph()->GetAllocator()) HBooleanNot(input_other);
Sebastien Hertz9837caf2016-08-01 11:09:50 +02001981 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, boolean_not);
1982 RecordSimplification();
1983 return;
1984 }
1985
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001986 if ((input_cst != nullptr) && AreAllBitsSet(input_cst)) {
1987 // Replace code looking like
1988 // XOR dst, src, 0xFFF...FF
1989 // with
1990 // NOT dst, src
Vladimir Markoca6fff82017-10-03 14:49:14 +01001991 HNot* bitwise_not = new (GetGraph()->GetAllocator()) HNot(instruction->GetType(), input_other);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001992 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, bitwise_not);
Alexandre Rames188d4312015-04-09 18:30:21 +01001993 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001994 return;
1995 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001996
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001997 HInstruction* left = instruction->GetLeft();
1998 HInstruction* right = instruction->GetRight();
Alexandre Rames9f980252016-02-05 14:00:28 +00001999 if (((left->IsNot() && right->IsNot()) ||
2000 (left->IsBooleanNot() && right->IsBooleanNot())) &&
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00002001 left->HasOnlyOneNonEnvironmentUse() &&
2002 right->HasOnlyOneNonEnvironmentUse()) {
2003 // Replace code looking like
2004 // NOT nota, a
2005 // NOT notb, b
2006 // XOR dst, nota, notb
2007 // with
2008 // XOR dst, a, b
Alexandre Rames9f980252016-02-05 14:00:28 +00002009 instruction->ReplaceInput(left->InputAt(0), 0);
2010 instruction->ReplaceInput(right->InputAt(0), 1);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00002011 left->GetBlock()->RemoveInstruction(left);
2012 right->GetBlock()->RemoveInstruction(right);
2013 RecordSimplification();
2014 return;
2015 }
2016
Anton Kirilove14dc862016-05-13 17:56:15 +01002017 if (TryReplaceWithRotate(instruction)) {
2018 return;
2019 }
2020
2021 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
2022 // so no need to return.
2023 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00002024}
2025
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002026void InstructionSimplifierVisitor::SimplifyStringEquals(HInvoke* instruction) {
2027 HInstruction* argument = instruction->InputAt(1);
2028 HInstruction* receiver = instruction->InputAt(0);
2029 if (receiver == argument) {
2030 // Because String.equals is an instance call, the receiver is
2031 // a null check if we don't know it's null. The argument however, will
2032 // be the actual object. So we cannot end up in a situation where both
2033 // are equal but could be null.
2034 DCHECK(CanEnsureNotNullAt(argument, instruction));
2035 instruction->ReplaceWith(GetGraph()->GetIntConstant(1));
2036 instruction->GetBlock()->RemoveInstruction(instruction);
2037 } else {
2038 StringEqualsOptimizations optimizations(instruction);
2039 if (CanEnsureNotNullAt(argument, instruction)) {
2040 optimizations.SetArgumentNotNull();
2041 }
2042 ScopedObjectAccess soa(Thread::Current());
2043 ReferenceTypeInfo argument_rti = argument->GetReferenceTypeInfo();
2044 if (argument_rti.IsValid() && argument_rti.IsStringClass()) {
2045 optimizations.SetArgumentIsString();
Vladimir Markoda283052017-11-07 21:17:24 +00002046 } else if (kUseReadBarrier) {
2047 DCHECK(instruction->GetResolvedMethod() != nullptr);
2048 DCHECK(instruction->GetResolvedMethod()->GetDeclaringClass()->IsStringClass());
2049 Runtime* runtime = Runtime::Current();
2050 // For AOT, we always assume that the boot image shall contain the String.class and
2051 // we do not need a read barrier for boot image classes as they are non-moveable.
2052 // For JIT, check if we actually have a boot image; if we do, the String.class
2053 // should also be non-moveable.
2054 if (runtime->IsAotCompiler() || runtime->GetHeap()->HasBootImageSpace()) {
2055 DCHECK(runtime->IsAotCompiler() ||
2056 !runtime->GetHeap()->IsMovableObject(
2057 instruction->GetResolvedMethod()->GetDeclaringClass()));
2058 optimizations.SetNoReadBarrierForStringClass();
2059 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002060 }
2061 }
2062}
2063
Roland Levillain22c49222016-03-18 14:04:28 +00002064void InstructionSimplifierVisitor::SimplifyRotate(HInvoke* invoke,
2065 bool is_left,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002066 DataType::Type type) {
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002067 DCHECK(invoke->IsInvokeStaticOrDirect());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01002068 DCHECK_EQ(invoke->GetInvokeType(), InvokeType::kStatic);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002069 HInstruction* value = invoke->InputAt(0);
2070 HInstruction* distance = invoke->InputAt(1);
2071 // Replace the invoke with an HRor.
2072 if (is_left) {
Roland Levillain937e6cd2016-03-22 11:54:37 +00002073 // Unconditionally set the type of the negated distance to `int`,
2074 // as shift and rotate operations expect a 32-bit (or narrower)
2075 // value for their distance input.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002076 distance = new (GetGraph()->GetAllocator()) HNeg(DataType::Type::kInt32, distance);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002077 invoke->GetBlock()->InsertInstructionBefore(distance, invoke);
2078 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01002079 HRor* ror = new (GetGraph()->GetAllocator()) HRor(type, value, distance);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002080 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, ror);
2081 // Remove ClinitCheck and LoadClass, if possible.
Vladimir Marko372f10e2016-05-17 16:30:10 +01002082 HInstruction* clinit = invoke->GetInputs().back();
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002083 if (clinit->IsClinitCheck() && !clinit->HasUses()) {
2084 clinit->GetBlock()->RemoveInstruction(clinit);
2085 HInstruction* ldclass = clinit->InputAt(0);
2086 if (ldclass->IsLoadClass() && !ldclass->HasUses()) {
2087 ldclass->GetBlock()->RemoveInstruction(ldclass);
2088 }
2089 }
2090}
2091
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002092static bool IsArrayLengthOf(HInstruction* potential_length, HInstruction* potential_array) {
2093 if (potential_length->IsArrayLength()) {
2094 return potential_length->InputAt(0) == potential_array;
2095 }
2096
2097 if (potential_array->IsNewArray()) {
Nicolas Geoffraye761bcc2017-01-19 08:59:37 +00002098 return potential_array->AsNewArray()->GetLength() == potential_length;
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002099 }
2100
2101 return false;
2102}
2103
2104void InstructionSimplifierVisitor::SimplifySystemArrayCopy(HInvoke* instruction) {
2105 HInstruction* source = instruction->InputAt(0);
2106 HInstruction* destination = instruction->InputAt(2);
2107 HInstruction* count = instruction->InputAt(4);
2108 SystemArrayCopyOptimizations optimizations(instruction);
2109 if (CanEnsureNotNullAt(source, instruction)) {
2110 optimizations.SetSourceIsNotNull();
2111 }
2112 if (CanEnsureNotNullAt(destination, instruction)) {
2113 optimizations.SetDestinationIsNotNull();
2114 }
2115 if (destination == source) {
2116 optimizations.SetDestinationIsSource();
2117 }
2118
2119 if (IsArrayLengthOf(count, source)) {
2120 optimizations.SetCountIsSourceLength();
2121 }
2122
2123 if (IsArrayLengthOf(count, destination)) {
2124 optimizations.SetCountIsDestinationLength();
2125 }
2126
2127 {
2128 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002129 DataType::Type source_component_type = DataType::Type::kVoid;
2130 DataType::Type destination_component_type = DataType::Type::kVoid;
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002131 ReferenceTypeInfo destination_rti = destination->GetReferenceTypeInfo();
2132 if (destination_rti.IsValid()) {
2133 if (destination_rti.IsObjectArray()) {
2134 if (destination_rti.IsExact()) {
2135 optimizations.SetDoesNotNeedTypeCheck();
2136 }
2137 optimizations.SetDestinationIsTypedObjectArray();
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002138 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002139 if (destination_rti.IsPrimitiveArrayClass()) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002140 destination_component_type = DataTypeFromPrimitive(
2141 destination_rti.GetTypeHandle()->GetComponentType()->GetPrimitiveType());
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002142 optimizations.SetDestinationIsPrimitiveArray();
2143 } else if (destination_rti.IsNonPrimitiveArrayClass()) {
2144 optimizations.SetDestinationIsNonPrimitiveArray();
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002145 }
2146 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002147 ReferenceTypeInfo source_rti = source->GetReferenceTypeInfo();
2148 if (source_rti.IsValid()) {
2149 if (destination_rti.IsValid() && destination_rti.CanArrayHoldValuesOf(source_rti)) {
2150 optimizations.SetDoesNotNeedTypeCheck();
2151 }
2152 if (source_rti.IsPrimitiveArrayClass()) {
2153 optimizations.SetSourceIsPrimitiveArray();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002154 source_component_type = DataTypeFromPrimitive(
2155 source_rti.GetTypeHandle()->GetComponentType()->GetPrimitiveType());
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002156 } else if (source_rti.IsNonPrimitiveArrayClass()) {
2157 optimizations.SetSourceIsNonPrimitiveArray();
2158 }
2159 }
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002160 // For primitive arrays, use their optimized ArtMethod implementations.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002161 if ((source_component_type != DataType::Type::kVoid) &&
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002162 (source_component_type == destination_component_type)) {
2163 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2164 PointerSize image_size = class_linker->GetImagePointerSize();
2165 HInvokeStaticOrDirect* invoke = instruction->AsInvokeStaticOrDirect();
2166 mirror::Class* system = invoke->GetResolvedMethod()->GetDeclaringClass();
2167 ArtMethod* method = nullptr;
2168 switch (source_component_type) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002169 case DataType::Type::kBool:
Vladimir Markoba118822017-06-12 15:41:56 +01002170 method = system->FindClassMethod("arraycopy", "([ZI[ZII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002171 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002172 case DataType::Type::kInt8:
Vladimir Markoba118822017-06-12 15:41:56 +01002173 method = system->FindClassMethod("arraycopy", "([BI[BII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002174 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002175 case DataType::Type::kUint16:
Vladimir Markoba118822017-06-12 15:41:56 +01002176 method = system->FindClassMethod("arraycopy", "([CI[CII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002177 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002178 case DataType::Type::kInt16:
Vladimir Markoba118822017-06-12 15:41:56 +01002179 method = system->FindClassMethod("arraycopy", "([SI[SII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002180 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002181 case DataType::Type::kInt32:
Vladimir Markoba118822017-06-12 15:41:56 +01002182 method = system->FindClassMethod("arraycopy", "([II[III)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002183 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002184 case DataType::Type::kFloat32:
Vladimir Markoba118822017-06-12 15:41:56 +01002185 method = system->FindClassMethod("arraycopy", "([FI[FII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002186 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002187 case DataType::Type::kInt64:
Vladimir Markoba118822017-06-12 15:41:56 +01002188 method = system->FindClassMethod("arraycopy", "([JI[JII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002189 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002190 case DataType::Type::kFloat64:
Vladimir Markoba118822017-06-12 15:41:56 +01002191 method = system->FindClassMethod("arraycopy", "([DI[DII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002192 break;
2193 default:
2194 LOG(FATAL) << "Unreachable";
2195 }
2196 DCHECK(method != nullptr);
Vladimir Markoba118822017-06-12 15:41:56 +01002197 DCHECK(method->IsStatic());
2198 DCHECK(method->GetDeclaringClass() == system);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002199 invoke->SetResolvedMethod(method);
2200 // Sharpen the new invoke. Note that we do not update the dex method index of
2201 // the invoke, as we would need to look it up in the current dex file, and it
2202 // is unlikely that it exists. The most usual situation for such typed
2203 // arraycopy methods is a direct pointer to the boot image.
Vladimir Marko65979462017-05-19 17:25:12 +01002204 HSharpening::SharpenInvokeStaticOrDirect(invoke, codegen_, compiler_driver_);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002205 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002206 }
2207}
2208
Roland Levillaina5c4a402016-03-15 15:02:50 +00002209void InstructionSimplifierVisitor::SimplifyCompare(HInvoke* invoke,
2210 bool is_signum,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002211 DataType::Type type) {
Aart Bika19616e2016-02-01 18:57:58 -08002212 DCHECK(invoke->IsInvokeStaticOrDirect());
2213 uint32_t dex_pc = invoke->GetDexPc();
2214 HInstruction* left = invoke->InputAt(0);
2215 HInstruction* right;
Aart Bika19616e2016-02-01 18:57:58 -08002216 if (!is_signum) {
2217 right = invoke->InputAt(1);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002218 } else if (type == DataType::Type::kInt64) {
Aart Bika19616e2016-02-01 18:57:58 -08002219 right = GetGraph()->GetLongConstant(0);
2220 } else {
2221 right = GetGraph()->GetIntConstant(0);
2222 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01002223 HCompare* compare = new (GetGraph()->GetAllocator())
Aart Bika19616e2016-02-01 18:57:58 -08002224 HCompare(type, left, right, ComparisonBias::kNoBias, dex_pc);
2225 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, compare);
2226}
2227
Aart Bik75a38b22016-02-17 10:41:50 -08002228void InstructionSimplifierVisitor::SimplifyIsNaN(HInvoke* invoke) {
2229 DCHECK(invoke->IsInvokeStaticOrDirect());
2230 uint32_t dex_pc = invoke->GetDexPc();
2231 // IsNaN(x) is the same as x != x.
2232 HInstruction* x = invoke->InputAt(0);
Vladimir Markoca6fff82017-10-03 14:49:14 +01002233 HCondition* condition = new (GetGraph()->GetAllocator()) HNotEqual(x, x, dex_pc);
Aart Bik8ffc1fa2016-02-17 15:13:56 -08002234 condition->SetBias(ComparisonBias::kLtBias);
Aart Bik75a38b22016-02-17 10:41:50 -08002235 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, condition);
2236}
2237
Aart Bik2a6aad92016-02-25 11:32:32 -08002238void InstructionSimplifierVisitor::SimplifyFP2Int(HInvoke* invoke) {
2239 DCHECK(invoke->IsInvokeStaticOrDirect());
2240 uint32_t dex_pc = invoke->GetDexPc();
2241 HInstruction* x = invoke->InputAt(0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002242 DataType::Type type = x->GetType();
Aart Bik2a6aad92016-02-25 11:32:32 -08002243 // Set proper bit pattern for NaN and replace intrinsic with raw version.
2244 HInstruction* nan;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002245 if (type == DataType::Type::kFloat64) {
Aart Bik2a6aad92016-02-25 11:32:32 -08002246 nan = GetGraph()->GetLongConstant(0x7ff8000000000000L);
2247 invoke->SetIntrinsic(Intrinsics::kDoubleDoubleToRawLongBits,
2248 kNeedsEnvironmentOrCache,
2249 kNoSideEffects,
2250 kNoThrow);
2251 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002252 DCHECK_EQ(type, DataType::Type::kFloat32);
Aart Bik2a6aad92016-02-25 11:32:32 -08002253 nan = GetGraph()->GetIntConstant(0x7fc00000);
2254 invoke->SetIntrinsic(Intrinsics::kFloatFloatToRawIntBits,
2255 kNeedsEnvironmentOrCache,
2256 kNoSideEffects,
2257 kNoThrow);
2258 }
2259 // Test IsNaN(x), which is the same as x != x.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002260 HCondition* condition = new (GetGraph()->GetAllocator()) HNotEqual(x, x, dex_pc);
Aart Bik2a6aad92016-02-25 11:32:32 -08002261 condition->SetBias(ComparisonBias::kLtBias);
2262 invoke->GetBlock()->InsertInstructionBefore(condition, invoke->GetNext());
2263 // Select between the two.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002264 HInstruction* select = new (GetGraph()->GetAllocator()) HSelect(condition, nan, invoke, dex_pc);
Aart Bik2a6aad92016-02-25 11:32:32 -08002265 invoke->GetBlock()->InsertInstructionBefore(select, condition->GetNext());
2266 invoke->ReplaceWithExceptInReplacementAtIndex(select, 0); // false at index 0
2267}
2268
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002269void InstructionSimplifierVisitor::SimplifyStringCharAt(HInvoke* invoke) {
2270 HInstruction* str = invoke->InputAt(0);
2271 HInstruction* index = invoke->InputAt(1);
2272 uint32_t dex_pc = invoke->GetDexPc();
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002273 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002274 // We treat String as an array to allow DCE and BCE to seamlessly work on strings,
2275 // so create the HArrayLength, HBoundsCheck and HArrayGet.
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002276 HArrayLength* length = new (allocator) HArrayLength(str, dex_pc, /* is_string_length */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002277 invoke->GetBlock()->InsertInstructionBefore(length, invoke);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002278 HBoundsCheck* bounds_check = new (allocator) HBoundsCheck(
Vladimir Marko0259c242017-12-04 11:27:47 +00002279 index, length, dex_pc, /* is_string_char_at */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002280 invoke->GetBlock()->InsertInstructionBefore(bounds_check, invoke);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002281 HArrayGet* array_get = new (allocator) HArrayGet(str,
2282 bounds_check,
2283 DataType::Type::kUint16,
2284 SideEffects::None(), // Strings are immutable.
2285 dex_pc,
2286 /* is_string_char_at */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002287 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, array_get);
2288 bounds_check->CopyEnvironmentFrom(invoke->GetEnvironment());
2289 GetGraph()->SetHasBoundsChecks(true);
2290}
2291
Vladimir Markodce016e2016-04-28 13:10:02 +01002292void InstructionSimplifierVisitor::SimplifyStringIsEmptyOrLength(HInvoke* invoke) {
2293 HInstruction* str = invoke->InputAt(0);
2294 uint32_t dex_pc = invoke->GetDexPc();
2295 // We treat String as an array to allow DCE and BCE to seamlessly work on strings,
2296 // so create the HArrayLength.
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002297 HArrayLength* length =
Vladimir Markoca6fff82017-10-03 14:49:14 +01002298 new (GetGraph()->GetAllocator()) HArrayLength(str, dex_pc, /* is_string_length */ true);
Vladimir Markodce016e2016-04-28 13:10:02 +01002299 HInstruction* replacement;
2300 if (invoke->GetIntrinsic() == Intrinsics::kStringIsEmpty) {
2301 // For String.isEmpty(), create the `HEqual` representing the `length == 0`.
2302 invoke->GetBlock()->InsertInstructionBefore(length, invoke);
2303 HIntConstant* zero = GetGraph()->GetIntConstant(0);
Vladimir Markoca6fff82017-10-03 14:49:14 +01002304 HEqual* equal = new (GetGraph()->GetAllocator()) HEqual(length, zero, dex_pc);
Vladimir Markodce016e2016-04-28 13:10:02 +01002305 replacement = equal;
2306 } else {
2307 DCHECK_EQ(invoke->GetIntrinsic(), Intrinsics::kStringLength);
2308 replacement = length;
2309 }
2310 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, replacement);
2311}
2312
Aart Bikff7d89c2016-11-07 08:49:28 -08002313// This method should only be used on intrinsics whose sole way of throwing an
2314// exception is raising a NPE when the nth argument is null. If that argument
2315// is provably non-null, we can clear the flag.
2316void InstructionSimplifierVisitor::SimplifyNPEOnArgN(HInvoke* invoke, size_t n) {
2317 HInstruction* arg = invoke->InputAt(n);
Aart Bik71bf7b42016-11-16 10:17:46 -08002318 if (invoke->CanThrow() && !arg->CanBeNull()) {
Aart Bikff7d89c2016-11-07 08:49:28 -08002319 invoke->SetCanThrow(false);
2320 }
2321}
2322
Aart Bik71bf7b42016-11-16 10:17:46 -08002323// Methods that return "this" can replace the returned value with the receiver.
2324void InstructionSimplifierVisitor::SimplifyReturnThis(HInvoke* invoke) {
2325 if (invoke->HasUses()) {
2326 HInstruction* receiver = invoke->InputAt(0);
2327 invoke->ReplaceWith(receiver);
2328 RecordSimplification();
2329 }
2330}
2331
2332// Helper method for StringBuffer escape analysis.
2333static bool NoEscapeForStringBufferReference(HInstruction* reference, HInstruction* user) {
2334 if (user->IsInvokeStaticOrDirect()) {
2335 // Any constructor on StringBuffer is okay.
Aart Bikab2270f2016-12-15 09:36:31 -08002336 return user->AsInvokeStaticOrDirect()->GetResolvedMethod() != nullptr &&
2337 user->AsInvokeStaticOrDirect()->GetResolvedMethod()->IsConstructor() &&
Aart Bik71bf7b42016-11-16 10:17:46 -08002338 user->InputAt(0) == reference;
2339 } else if (user->IsInvokeVirtual()) {
2340 switch (user->AsInvokeVirtual()->GetIntrinsic()) {
2341 case Intrinsics::kStringBufferLength:
2342 case Intrinsics::kStringBufferToString:
2343 DCHECK_EQ(user->InputAt(0), reference);
2344 return true;
2345 case Intrinsics::kStringBufferAppend:
2346 // Returns "this", so only okay if no further uses.
2347 DCHECK_EQ(user->InputAt(0), reference);
2348 DCHECK_NE(user->InputAt(1), reference);
2349 return !user->HasUses();
2350 default:
2351 break;
2352 }
2353 }
2354 return false;
2355}
2356
2357// Certain allocation intrinsics are not removed by dead code elimination
2358// because of potentially throwing an OOM exception or other side effects.
2359// This method removes such intrinsics when special circumstances allow.
2360void InstructionSimplifierVisitor::SimplifyAllocationIntrinsic(HInvoke* invoke) {
2361 if (!invoke->HasUses()) {
2362 // Instruction has no uses. If unsynchronized, we can remove right away, safely ignoring
2363 // the potential OOM of course. Otherwise, we must ensure the receiver object of this
2364 // call does not escape since only thread-local synchronization may be removed.
2365 bool is_synchronized = invoke->GetIntrinsic() == Intrinsics::kStringBufferToString;
2366 HInstruction* receiver = invoke->InputAt(0);
2367 if (!is_synchronized || DoesNotEscape(receiver, NoEscapeForStringBufferReference)) {
2368 invoke->GetBlock()->RemoveInstruction(invoke);
2369 RecordSimplification();
2370 }
2371 }
2372}
2373
Vladimir Markoca6fff82017-10-03 14:49:14 +01002374void InstructionSimplifierVisitor::SimplifyMemBarrier(HInvoke* invoke,
2375 MemBarrierKind barrier_kind) {
Aart Bik11932592016-03-08 12:42:25 -08002376 uint32_t dex_pc = invoke->GetDexPc();
Vladimir Markoca6fff82017-10-03 14:49:14 +01002377 HMemoryBarrier* mem_barrier =
2378 new (GetGraph()->GetAllocator()) HMemoryBarrier(barrier_kind, dex_pc);
Aart Bik11932592016-03-08 12:42:25 -08002379 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, mem_barrier);
2380}
2381
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002382void InstructionSimplifierVisitor::VisitInvoke(HInvoke* instruction) {
Aart Bik2a6aad92016-02-25 11:32:32 -08002383 switch (instruction->GetIntrinsic()) {
2384 case Intrinsics::kStringEquals:
2385 SimplifyStringEquals(instruction);
2386 break;
2387 case Intrinsics::kSystemArrayCopy:
2388 SimplifySystemArrayCopy(instruction);
2389 break;
2390 case Intrinsics::kIntegerRotateRight:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002391 SimplifyRotate(instruction, /* is_left */ false, DataType::Type::kInt32);
Roland Levillain22c49222016-03-18 14:04:28 +00002392 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002393 case Intrinsics::kLongRotateRight:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002394 SimplifyRotate(instruction, /* is_left */ false, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002395 break;
2396 case Intrinsics::kIntegerRotateLeft:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002397 SimplifyRotate(instruction, /* is_left */ true, DataType::Type::kInt32);
Roland Levillain22c49222016-03-18 14:04:28 +00002398 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002399 case Intrinsics::kLongRotateLeft:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002400 SimplifyRotate(instruction, /* is_left */ true, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002401 break;
2402 case Intrinsics::kIntegerCompare:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002403 SimplifyCompare(instruction, /* is_signum */ false, DataType::Type::kInt32);
Roland Levillaina5c4a402016-03-15 15:02:50 +00002404 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002405 case Intrinsics::kLongCompare:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002406 SimplifyCompare(instruction, /* is_signum */ false, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002407 break;
2408 case Intrinsics::kIntegerSignum:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002409 SimplifyCompare(instruction, /* is_signum */ true, DataType::Type::kInt32);
Roland Levillaina5c4a402016-03-15 15:02:50 +00002410 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002411 case Intrinsics::kLongSignum:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002412 SimplifyCompare(instruction, /* is_signum */ true, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002413 break;
2414 case Intrinsics::kFloatIsNaN:
2415 case Intrinsics::kDoubleIsNaN:
2416 SimplifyIsNaN(instruction);
2417 break;
2418 case Intrinsics::kFloatFloatToIntBits:
2419 case Intrinsics::kDoubleDoubleToLongBits:
2420 SimplifyFP2Int(instruction);
2421 break;
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002422 case Intrinsics::kStringCharAt:
2423 SimplifyStringCharAt(instruction);
2424 break;
Vladimir Markodce016e2016-04-28 13:10:02 +01002425 case Intrinsics::kStringIsEmpty:
2426 case Intrinsics::kStringLength:
2427 SimplifyStringIsEmptyOrLength(instruction);
2428 break;
Aart Bikff7d89c2016-11-07 08:49:28 -08002429 case Intrinsics::kStringStringIndexOf:
2430 case Intrinsics::kStringStringIndexOfAfter:
2431 SimplifyNPEOnArgN(instruction, 1); // 0th has own NullCheck
2432 break;
Aart Bik71bf7b42016-11-16 10:17:46 -08002433 case Intrinsics::kStringBufferAppend:
2434 case Intrinsics::kStringBuilderAppend:
2435 SimplifyReturnThis(instruction);
2436 break;
2437 case Intrinsics::kStringBufferToString:
2438 case Intrinsics::kStringBuilderToString:
2439 SimplifyAllocationIntrinsic(instruction);
2440 break;
Aart Bik11932592016-03-08 12:42:25 -08002441 case Intrinsics::kUnsafeLoadFence:
2442 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2443 break;
2444 case Intrinsics::kUnsafeStoreFence:
2445 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyStore);
2446 break;
2447 case Intrinsics::kUnsafeFullFence:
2448 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyAny);
2449 break;
Orion Hodson4a4610a2017-09-28 16:57:55 +01002450 case Intrinsics::kVarHandleFullFence:
2451 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyAny);
2452 break;
2453 case Intrinsics::kVarHandleAcquireFence:
2454 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2455 break;
2456 case Intrinsics::kVarHandleReleaseFence:
2457 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyStore);
2458 break;
2459 case Intrinsics::kVarHandleLoadLoadFence:
2460 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2461 break;
2462 case Intrinsics::kVarHandleStoreStoreFence:
2463 SimplifyMemBarrier(instruction, MemBarrierKind::kStoreStore);
2464 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002465 default:
2466 break;
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002467 }
2468}
2469
Aart Bikbb245d12015-10-19 11:05:03 -07002470void InstructionSimplifierVisitor::VisitDeoptimize(HDeoptimize* deoptimize) {
2471 HInstruction* cond = deoptimize->InputAt(0);
2472 if (cond->IsConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +00002473 if (cond->AsIntConstant()->IsFalse()) {
Aart Bikbb245d12015-10-19 11:05:03 -07002474 // Never deopt: instruction can be removed.
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00002475 if (deoptimize->GuardsAnInput()) {
2476 deoptimize->ReplaceWith(deoptimize->GuardedInput());
2477 }
Aart Bikbb245d12015-10-19 11:05:03 -07002478 deoptimize->GetBlock()->RemoveInstruction(deoptimize);
2479 } else {
2480 // Always deopt.
2481 }
2482 }
2483}
2484
Anton Kirilove14dc862016-05-13 17:56:15 +01002485// Replace code looking like
2486// OP y, x, const1
2487// OP z, y, const2
2488// with
2489// OP z, x, const3
2490// where OP is both an associative and a commutative operation.
2491bool InstructionSimplifierVisitor::TryHandleAssociativeAndCommutativeOperation(
2492 HBinaryOperation* instruction) {
2493 DCHECK(instruction->IsCommutative());
2494
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002495 if (!DataType::IsIntegralType(instruction->GetType())) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002496 return false;
2497 }
2498
2499 HInstruction* left = instruction->GetLeft();
2500 HInstruction* right = instruction->GetRight();
2501 // Variable names as described above.
2502 HConstant* const2;
2503 HBinaryOperation* y;
2504
2505 if (instruction->InstructionTypeEquals(left) && right->IsConstant()) {
2506 const2 = right->AsConstant();
2507 y = left->AsBinaryOperation();
2508 } else if (left->IsConstant() && instruction->InstructionTypeEquals(right)) {
2509 const2 = left->AsConstant();
2510 y = right->AsBinaryOperation();
2511 } else {
2512 // The node does not match the pattern.
2513 return false;
2514 }
2515
2516 // If `y` has more than one use, we do not perform the optimization
2517 // because it might increase code size (e.g. if the new constant is
2518 // no longer encodable as an immediate operand in the target ISA).
2519 if (!y->HasOnlyOneNonEnvironmentUse()) {
2520 return false;
2521 }
2522
2523 // GetConstantRight() can return both left and right constants
2524 // for commutative operations.
2525 HConstant* const1 = y->GetConstantRight();
2526 if (const1 == nullptr) {
2527 return false;
2528 }
2529
2530 instruction->ReplaceInput(const1, 0);
2531 instruction->ReplaceInput(const2, 1);
2532 HConstant* const3 = instruction->TryStaticEvaluation();
2533 DCHECK(const3 != nullptr);
2534 instruction->ReplaceInput(y->GetLeastConstantLeft(), 0);
2535 instruction->ReplaceInput(const3, 1);
2536 RecordSimplification();
2537 return true;
2538}
2539
2540static HBinaryOperation* AsAddOrSub(HInstruction* binop) {
2541 return (binop->IsAdd() || binop->IsSub()) ? binop->AsBinaryOperation() : nullptr;
2542}
2543
2544// Helper function that performs addition statically, considering the result type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002545static int64_t ComputeAddition(DataType::Type type, int64_t x, int64_t y) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002546 // Use the Compute() method for consistency with TryStaticEvaluation().
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002547 if (type == DataType::Type::kInt32) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002548 return HAdd::Compute<int32_t>(x, y);
2549 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002550 DCHECK_EQ(type, DataType::Type::kInt64);
Anton Kirilove14dc862016-05-13 17:56:15 +01002551 return HAdd::Compute<int64_t>(x, y);
2552 }
2553}
2554
2555// Helper function that handles the child classes of HConstant
2556// and returns an integer with the appropriate sign.
2557static int64_t GetValue(HConstant* constant, bool is_negated) {
2558 int64_t ret = Int64FromConstant(constant);
2559 return is_negated ? -ret : ret;
2560}
2561
2562// Replace code looking like
2563// OP1 y, x, const1
2564// OP2 z, y, const2
2565// with
2566// OP3 z, x, const3
2567// where OPx is either ADD or SUB, and at least one of OP{1,2} is SUB.
2568bool InstructionSimplifierVisitor::TrySubtractionChainSimplification(
2569 HBinaryOperation* instruction) {
2570 DCHECK(instruction->IsAdd() || instruction->IsSub()) << instruction->DebugName();
2571
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002572 DataType::Type type = instruction->GetType();
2573 if (!DataType::IsIntegralType(type)) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002574 return false;
2575 }
2576
2577 HInstruction* left = instruction->GetLeft();
2578 HInstruction* right = instruction->GetRight();
2579 // Variable names as described above.
2580 HConstant* const2 = right->IsConstant() ? right->AsConstant() : left->AsConstant();
2581 if (const2 == nullptr) {
2582 return false;
2583 }
2584
2585 HBinaryOperation* y = (AsAddOrSub(left) != nullptr)
2586 ? left->AsBinaryOperation()
2587 : AsAddOrSub(right);
2588 // If y has more than one use, we do not perform the optimization because
2589 // it might increase code size (e.g. if the new constant is no longer
2590 // encodable as an immediate operand in the target ISA).
2591 if ((y == nullptr) || !y->HasOnlyOneNonEnvironmentUse()) {
2592 return false;
2593 }
2594
2595 left = y->GetLeft();
2596 HConstant* const1 = left->IsConstant() ? left->AsConstant() : y->GetRight()->AsConstant();
2597 if (const1 == nullptr) {
2598 return false;
2599 }
2600
2601 HInstruction* x = (const1 == left) ? y->GetRight() : left;
2602 // If both inputs are constants, let the constant folding pass deal with it.
2603 if (x->IsConstant()) {
2604 return false;
2605 }
2606
2607 bool is_const2_negated = (const2 == right) && instruction->IsSub();
2608 int64_t const2_val = GetValue(const2, is_const2_negated);
2609 bool is_y_negated = (y == right) && instruction->IsSub();
2610 right = y->GetRight();
2611 bool is_const1_negated = is_y_negated ^ ((const1 == right) && y->IsSub());
2612 int64_t const1_val = GetValue(const1, is_const1_negated);
2613 bool is_x_negated = is_y_negated ^ ((x == right) && y->IsSub());
2614 int64_t const3_val = ComputeAddition(type, const1_val, const2_val);
2615 HBasicBlock* block = instruction->GetBlock();
2616 HConstant* const3 = block->GetGraph()->GetConstant(type, const3_val);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002617 ArenaAllocator* allocator = instruction->GetAllocator();
Anton Kirilove14dc862016-05-13 17:56:15 +01002618 HInstruction* z;
2619
2620 if (is_x_negated) {
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002621 z = new (allocator) HSub(type, const3, x, instruction->GetDexPc());
Anton Kirilove14dc862016-05-13 17:56:15 +01002622 } else {
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002623 z = new (allocator) HAdd(type, x, const3, instruction->GetDexPc());
Anton Kirilove14dc862016-05-13 17:56:15 +01002624 }
2625
2626 block->ReplaceAndRemoveInstructionWith(instruction, z);
2627 RecordSimplification();
2628 return true;
2629}
2630
Lena Djokicbc5460b2017-07-20 16:07:36 +02002631void InstructionSimplifierVisitor::VisitVecMul(HVecMul* instruction) {
2632 if (TryCombineVecMultiplyAccumulate(instruction)) {
2633 RecordSimplification();
2634 }
2635}
2636
Nicolas Geoffray3c049742014-09-24 18:10:46 +01002637} // namespace art