blob: 413b4e0f756f27211f719324899d02df32fc0aad [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "compiler_internals.h"
18#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko9820b7c2014-01-02 16:40:37 +000020#include "dex/quick/dex_file_method_inliner.h"
21#include "dex/quick/dex_file_to_method_inliner_map.h"
buzbee311ca162013-02-28 15:56:43 -080022
23namespace art {
24
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070025static unsigned int Predecessors(BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -070026 return bb->predecessors->Size();
buzbee311ca162013-02-28 15:56:43 -080027}
28
29/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030void MIRGraph::SetConstant(int32_t ssa_reg, int value) {
buzbee862a7602013-04-05 10:58:54 -070031 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080032 constant_values_[ssa_reg] = value;
33}
34
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070035void MIRGraph::SetConstantWide(int ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = Low32Bits(value);
38 constant_values_[ssa_reg + 1] = High32Bits(value);
39}
40
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080041void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080042 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080043
44 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070045 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070046 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070047 return;
48 }
49
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070050 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080051
Ian Rogers29a26482014-05-02 15:27:29 -070052 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080053
54 if (!(df_attributes & DF_HAS_DEFS)) continue;
55
56 /* Handle instructions that set up constants directly */
57 if (df_attributes & DF_SETS_CONST) {
58 if (df_attributes & DF_DA) {
59 int32_t vB = static_cast<int32_t>(d_insn->vB);
60 switch (d_insn->opcode) {
61 case Instruction::CONST_4:
62 case Instruction::CONST_16:
63 case Instruction::CONST:
64 SetConstant(mir->ssa_rep->defs[0], vB);
65 break;
66 case Instruction::CONST_HIGH16:
67 SetConstant(mir->ssa_rep->defs[0], vB << 16);
68 break;
69 case Instruction::CONST_WIDE_16:
70 case Instruction::CONST_WIDE_32:
71 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
72 break;
73 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070074 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080075 break;
76 case Instruction::CONST_WIDE_HIGH16:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
78 break;
79 default:
80 break;
81 }
82 }
83 /* Handle instructions that set up constants directly */
84 } else if (df_attributes & DF_IS_MOVE) {
85 int i;
86
87 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070088 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080089 }
90 /* Move a register holding a constant to another register */
91 if (i == mir->ssa_rep->num_uses) {
92 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
93 if (df_attributes & DF_A_WIDE) {
94 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
95 }
96 }
97 }
98 }
99 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800100}
101
buzbee311ca162013-02-28 15:56:43 -0800102/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700103MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800104 BasicBlock* bb = *p_bb;
105 if (mir != NULL) {
106 mir = mir->next;
107 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700108 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800109 if ((bb == NULL) || Predecessors(bb) != 1) {
110 mir = NULL;
111 } else {
112 *p_bb = bb;
113 mir = bb->first_mir_insn;
114 }
115 }
116 }
117 return mir;
118}
119
120/*
121 * To be used at an invoke mir. If the logically next mir node represents
122 * a move-result, return it. Else, return NULL. If a move-result exists,
123 * it is required to immediately follow the invoke with no intervening
124 * opcodes or incoming arcs. However, if the result of the invoke is not
125 * used, a move-result may not be present.
126 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700127MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800128 BasicBlock* tbb = bb;
129 mir = AdvanceMIR(&tbb, mir);
130 while (mir != NULL) {
131 int opcode = mir->dalvikInsn.opcode;
132 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
133 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
134 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
135 break;
136 }
137 // Keep going if pseudo op, otherwise terminate
138 if (opcode < kNumPackedOpcodes) {
139 mir = NULL;
140 } else {
141 mir = AdvanceMIR(&tbb, mir);
142 }
143 }
144 return mir;
145}
146
buzbee0d829482013-10-11 15:24:55 -0700147BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800148 if (bb->block_type == kDead) {
149 return NULL;
150 }
151 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
152 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700153 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
154 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800155 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700156 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700157 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700158 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700159 } else {
160 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700161 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700162 }
buzbee311ca162013-02-28 15:56:43 -0800163 if (bb == NULL || (Predecessors(bb) != 1)) {
164 return NULL;
165 }
166 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
167 return bb;
168}
169
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700170static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800171 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
172 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
173 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
174 if (mir->ssa_rep->uses[i] == ssa_name) {
175 return mir;
176 }
177 }
178 }
179 }
180 return NULL;
181}
182
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700183static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800184 switch (mir->dalvikInsn.opcode) {
185 case Instruction::MOVE:
186 case Instruction::MOVE_OBJECT:
187 case Instruction::MOVE_16:
188 case Instruction::MOVE_OBJECT_16:
189 case Instruction::MOVE_FROM16:
190 case Instruction::MOVE_OBJECT_FROM16:
191 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700192 case Instruction::CONST:
193 case Instruction::CONST_4:
194 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800195 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700196 case Instruction::GOTO:
197 case Instruction::GOTO_16:
198 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800199 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700200 default:
201 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800202 }
buzbee311ca162013-02-28 15:56:43 -0800203}
204
Vladimir Markoa1a70742014-03-03 10:28:05 +0000205static constexpr ConditionCode kIfCcZConditionCodes[] = {
206 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
207};
208
209COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
210 if_ccz_ccodes_size1);
211
212static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
213 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
214}
215
216static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
217 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
218}
219
220COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
221COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
222COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
223COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
224COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
225COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
226
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700227int MIRGraph::GetSSAUseCount(int s_reg) {
buzbee862a7602013-04-05 10:58:54 -0700228 return raw_use_counts_.Get(s_reg);
buzbee311ca162013-02-28 15:56:43 -0800229}
230
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800231size_t MIRGraph::GetNumAvailableNonSpecialCompilerTemps() {
232 if (num_non_special_compiler_temps_ >= max_available_non_special_compiler_temps_) {
233 return 0;
234 } else {
235 return max_available_non_special_compiler_temps_ - num_non_special_compiler_temps_;
236 }
237}
238
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000239
240// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700242 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000243 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800244
245CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
246 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
247 if (ct_type == kCompilerTempVR) {
248 size_t available_temps = GetNumAvailableNonSpecialCompilerTemps();
249 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
250 return 0;
251 }
252 }
253
254 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000255 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800256
257 // Create the type of temp requested. Special temps need special handling because
258 // they have a specific virtual register assignment.
259 if (ct_type == kCompilerTempSpecialMethodPtr) {
260 DCHECK_EQ(wide, false);
261 compiler_temp->v_reg = static_cast<int>(kVRegMethodPtrBaseReg);
262 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
263
264 // The MIR graph keeps track of the sreg for method pointer specially, so record that now.
265 method_sreg_ = compiler_temp->s_reg_low;
266 } else {
267 DCHECK_EQ(ct_type, kCompilerTempVR);
268
269 // The new non-special compiler temp must receive a unique v_reg with a negative value.
270 compiler_temp->v_reg = static_cast<int>(kVRegNonSpecialTempBaseReg) - num_non_special_compiler_temps_;
271 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
272 num_non_special_compiler_temps_++;
273
274 if (wide) {
275 // Ensure that the two registers are consecutive. Since the virtual registers used for temps grow in a
276 // negative fashion, we need the smaller to refer to the low part. Thus, we redefine the v_reg and s_reg_low.
277 compiler_temp->v_reg--;
278 int ssa_reg_high = compiler_temp->s_reg_low;
279 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
280 int ssa_reg_low = compiler_temp->s_reg_low;
281
282 // If needed initialize the register location for the high part.
283 // The low part is handled later in this method on a common path.
284 if (reg_location_ != nullptr) {
285 reg_location_[ssa_reg_high] = temp_loc;
286 reg_location_[ssa_reg_high].high_word = 1;
287 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
288 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800289 }
290
291 num_non_special_compiler_temps_++;
292 }
293 }
294
295 // Have we already allocated the register locations?
296 if (reg_location_ != nullptr) {
297 int ssa_reg_low = compiler_temp->s_reg_low;
298 reg_location_[ssa_reg_low] = temp_loc;
299 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
300 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 }
302
303 compiler_temps_.Insert(compiler_temp);
304 return compiler_temp;
305}
buzbee311ca162013-02-28 15:56:43 -0800306
307/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700308bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800309 if (bb->block_type == kDead) {
310 return true;
311 }
buzbee1da1e2f2013-11-15 13:37:01 -0800312 bool use_lvn = bb->use_lvn;
313 UniquePtr<LocalValueNumbering> local_valnum;
314 if (use_lvn) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000315 local_valnum.reset(LocalValueNumbering::Create(cu_));
buzbee1da1e2f2013-11-15 13:37:01 -0800316 }
buzbee311ca162013-02-28 15:56:43 -0800317 while (bb != NULL) {
318 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
319 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800320 if (use_lvn) {
321 local_valnum->GetValueNumber(mir);
322 }
buzbee311ca162013-02-28 15:56:43 -0800323 // Look for interesting opcodes, skip otherwise
324 Instruction::Code opcode = mir->dalvikInsn.opcode;
325 switch (opcode) {
326 case Instruction::CMPL_FLOAT:
327 case Instruction::CMPL_DOUBLE:
328 case Instruction::CMPG_FLOAT:
329 case Instruction::CMPG_DOUBLE:
330 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700331 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800332 // Bitcode doesn't allow this optimization.
333 break;
334 }
335 if (mir->next != NULL) {
336 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800337 // Make sure result of cmp is used by next insn and nowhere else
Vladimir Markoa1a70742014-03-03 10:28:05 +0000338 if (IsInstructionIfCcZ(mir->next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800339 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
340 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000341 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700342 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800343 case Instruction::CMPL_FLOAT:
344 mir_next->dalvikInsn.opcode =
345 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
346 break;
347 case Instruction::CMPL_DOUBLE:
348 mir_next->dalvikInsn.opcode =
349 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
350 break;
351 case Instruction::CMPG_FLOAT:
352 mir_next->dalvikInsn.opcode =
353 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
354 break;
355 case Instruction::CMPG_DOUBLE:
356 mir_next->dalvikInsn.opcode =
357 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
358 break;
359 case Instruction::CMP_LONG:
360 mir_next->dalvikInsn.opcode =
361 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
362 break;
363 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
364 }
365 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
366 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
367 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
368 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
369 mir_next->ssa_rep->num_defs = 0;
370 mir->ssa_rep->num_uses = 0;
371 mir->ssa_rep->num_defs = 0;
372 }
373 }
374 break;
375 case Instruction::GOTO:
376 case Instruction::GOTO_16:
377 case Instruction::GOTO_32:
378 case Instruction::IF_EQ:
379 case Instruction::IF_NE:
380 case Instruction::IF_LT:
381 case Instruction::IF_GE:
382 case Instruction::IF_GT:
383 case Instruction::IF_LE:
384 case Instruction::IF_EQZ:
385 case Instruction::IF_NEZ:
386 case Instruction::IF_LTZ:
387 case Instruction::IF_GEZ:
388 case Instruction::IF_GTZ:
389 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700390 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700391 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
392 (IsBackedge(bb, bb->fall_through) &&
393 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800394 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
395 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700396 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
397 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800398 }
399 }
400 break;
401 default:
402 break;
403 }
404 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800405 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800406 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000407 if (!cu_->compiler->IsPortable() &&
Dmitry Petrochenko6a58cb12014-04-02 17:27:59 +0700408 (cu_->instruction_set == kThumb2 || cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000409 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700410 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800411 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700412 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
413 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800414
buzbee0d829482013-10-11 15:24:55 -0700415 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800416 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700417 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
418 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800419
420 /*
421 * In the select pattern, the taken edge goes to a block that unconditionally
422 * transfers to the rejoin block and the fall_though edge goes to a block that
423 * unconditionally falls through to the rejoin block.
424 */
425 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
426 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
427 /*
428 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
429 * suspend check on the taken-taken branch back to the join point.
430 */
431 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
432 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
433 }
434 // Are the block bodies something we can handle?
435 if ((ft->first_mir_insn == ft->last_mir_insn) &&
436 (tk->first_mir_insn != tk->last_mir_insn) &&
437 (tk->first_mir_insn->next == tk->last_mir_insn) &&
438 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
439 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
440 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
441 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
442 // Almost there. Are the instructions targeting the same vreg?
443 MIR* if_true = tk->first_mir_insn;
444 MIR* if_false = ft->first_mir_insn;
445 // It's possible that the target of the select isn't used - skip those (rare) cases.
446 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
447 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
448 /*
449 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
450 * Phi node in the merge block and delete it (while using the SSA name
451 * of the merge as the target of the SELECT. Delete both taken and
452 * fallthrough blocks, and set fallthrough to merge block.
453 * NOTE: not updating other dataflow info (no longer used at this point).
454 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
455 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000456 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800457 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
458 bool const_form = (SelectKind(if_true) == kSelectConst);
459 if ((SelectKind(if_true) == kSelectMove)) {
460 if (IsConst(if_true->ssa_rep->uses[0]) &&
461 IsConst(if_false->ssa_rep->uses[0])) {
462 const_form = true;
463 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
464 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
465 }
466 }
467 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800468 /*
469 * TODO: If both constants are the same value, then instead of generating
470 * a select, we should simply generate a const bytecode. This should be
471 * considered after inlining which can lead to CFG of this form.
472 */
buzbee311ca162013-02-28 15:56:43 -0800473 // "true" set val in vB
474 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
475 // "false" set val in vC
476 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
477 } else {
478 DCHECK_EQ(SelectKind(if_true), kSelectMove);
479 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700480 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000481 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800482 src_ssa[0] = mir->ssa_rep->uses[0];
483 src_ssa[1] = if_true->ssa_rep->uses[0];
484 src_ssa[2] = if_false->ssa_rep->uses[0];
485 mir->ssa_rep->uses = src_ssa;
486 mir->ssa_rep->num_uses = 3;
487 }
488 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700489 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000490 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700491 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000492 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800493 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700494 // Match type of uses to def.
495 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700496 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000497 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700498 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
499 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
500 }
buzbee311ca162013-02-28 15:56:43 -0800501 /*
502 * There is usually a Phi node in the join block for our two cases. If the
503 * Phi node only contains our two cases as input, we will use the result
504 * SSA name of the Phi node as our select result and delete the Phi. If
505 * the Phi node has more than two operands, we will arbitrarily use the SSA
506 * name of the "true" path, delete the SSA name of the "false" path from the
507 * Phi node (and fix up the incoming arc list).
508 */
509 if (phi->ssa_rep->num_uses == 2) {
510 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
511 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
512 } else {
513 int dead_def = if_false->ssa_rep->defs[0];
514 int live_def = if_true->ssa_rep->defs[0];
515 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700516 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800517 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
518 if (phi->ssa_rep->uses[i] == live_def) {
519 incoming[i] = bb->id;
520 }
521 }
522 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
523 if (phi->ssa_rep->uses[i] == dead_def) {
524 int last_slot = phi->ssa_rep->num_uses - 1;
525 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
526 incoming[i] = incoming[last_slot];
527 }
528 }
529 }
530 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700531 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800532 tk->block_type = kDead;
533 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
534 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
535 }
536 }
537 }
538 }
539 }
540 }
buzbee1da1e2f2013-11-15 13:37:01 -0800541 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800542 }
543
buzbee311ca162013-02-28 15:56:43 -0800544 return true;
545}
546
buzbee311ca162013-02-28 15:56:43 -0800547/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700548void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700549 if (bb->data_flow_info != NULL) {
550 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
551 if (mir->ssa_rep == NULL) {
552 continue;
buzbee311ca162013-02-28 15:56:43 -0800553 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700554 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700555 if (df_attributes & DF_HAS_NULL_CHKS) {
556 checkstats_->null_checks++;
557 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
558 checkstats_->null_checks_eliminated++;
559 }
560 }
561 if (df_attributes & DF_HAS_RANGE_CHKS) {
562 checkstats_->range_checks++;
563 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
564 checkstats_->range_checks_eliminated++;
565 }
buzbee311ca162013-02-28 15:56:43 -0800566 }
567 }
568 }
buzbee311ca162013-02-28 15:56:43 -0800569}
570
571/* Try to make common case the fallthrough path */
buzbee0d829482013-10-11 15:24:55 -0700572bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800573 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback
574 if (!bb->explicit_throw) {
575 return false;
576 }
577 BasicBlock* walker = bb;
578 while (true) {
579 // Check termination conditions
580 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
581 break;
582 }
buzbee0d829482013-10-11 15:24:55 -0700583 BasicBlock* prev = GetBasicBlock(walker->predecessors->Get(0));
buzbee311ca162013-02-28 15:56:43 -0800584 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700585 if (GetBasicBlock(prev->fall_through) == walker) {
buzbee311ca162013-02-28 15:56:43 -0800586 // Already done - return
587 break;
588 }
buzbee0d829482013-10-11 15:24:55 -0700589 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
buzbee311ca162013-02-28 15:56:43 -0800590 // Got one. Flip it and exit
591 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
592 switch (opcode) {
593 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
594 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
595 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
596 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
597 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
598 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
599 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
600 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
601 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
602 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
603 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
604 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
605 default: LOG(FATAL) << "Unexpected opcode " << opcode;
606 }
607 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700608 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800609 prev->taken = prev->fall_through;
610 prev->fall_through = t_bb;
611 break;
612 }
613 walker = prev;
614 }
615 return false;
616}
617
618/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800619void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800620 // Loop here to allow combining a sequence of blocks
621 while (true) {
622 // Check termination conditions
623 if ((bb->first_mir_insn == NULL)
624 || (bb->data_flow_info == NULL)
625 || (bb->block_type == kExceptionHandling)
626 || (bb->block_type == kExitBlock)
627 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700628 || (bb->taken == NullBasicBlockId)
629 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
630 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800631 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
632 break;
633 }
634
635 // Test the kMirOpCheck instruction
636 MIR* mir = bb->last_mir_insn;
637 // Grab the attributes from the paired opcode
638 MIR* throw_insn = mir->meta.throw_insn;
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700639 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
buzbee311ca162013-02-28 15:56:43 -0800640 bool can_combine = true;
641 if (df_attributes & DF_HAS_NULL_CHKS) {
642 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
643 }
644 if (df_attributes & DF_HAS_RANGE_CHKS) {
645 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
646 }
647 if (!can_combine) {
648 break;
649 }
650 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700651 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800652 DCHECK(!bb_next->catch_entry);
653 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800654 // Overwrite the kOpCheck insn with the paired opcode
655 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
656 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800657 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700658 bb->successor_block_list_type = bb_next->successor_block_list_type;
659 bb->successor_blocks = bb_next->successor_blocks;
buzbee311ca162013-02-28 15:56:43 -0800660 // Use the ending block linkage from the next block
661 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700662 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800663 bb->taken = bb_next->taken;
664 // Include the rest of the instructions
665 bb->last_mir_insn = bb_next->last_mir_insn;
666 /*
667 * If lower-half of pair of blocks to combine contained a return, move the flag
668 * to the newly combined block.
669 */
670 bb->terminated_by_return = bb_next->terminated_by_return;
671
672 /*
673 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
674 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
675 */
676
677 // Kill bb_next and remap now-dead id to parent
678 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700679 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800680
681 // Now, loop back and see if we can keep going
682 }
buzbee311ca162013-02-28 15:56:43 -0800683}
684
Vladimir Markobfea9c22014-01-17 17:49:33 +0000685void MIRGraph::EliminateNullChecksAndInferTypesStart() {
686 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
687 if (kIsDebugBuild) {
688 AllNodesIterator iter(this);
689 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
690 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
691 }
692 }
693
694 DCHECK(temp_scoped_alloc_.get() == nullptr);
695 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
696 temp_bit_vector_size_ = GetNumSSARegs();
697 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
698 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
699 }
700}
701
buzbee1da1e2f2013-11-15 13:37:01 -0800702/*
703 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
704 * an iterative walk go ahead and perform type and size inference.
705 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800706bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800707 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800708 bool infer_changed = false;
709 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800710
Vladimir Markobfea9c22014-01-17 17:49:33 +0000711 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800712 if (do_nce) {
713 /*
714 * Set initial state. Be conservative with catch
715 * blocks and start with no assumptions about null check
716 * status (except for "this").
717 */
718 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000719 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800720 // Assume all ins are objects.
721 for (uint16_t in_reg = cu_->num_dalvik_registers - cu_->num_ins;
722 in_reg < cu_->num_dalvik_registers; in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000723 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800724 }
725 if ((cu_->access_flags & kAccStatic) == 0) {
726 // If non-static method, mark "this" as non-null
727 int this_reg = cu_->num_dalvik_registers - cu_->num_ins;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000728 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800729 }
730 } else if (bb->predecessors->Size() == 1) {
731 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
Vladimir Markobfea9c22014-01-17 17:49:33 +0000732 // pred_bb must have already been processed at least once.
733 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
734 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800735 if (pred_bb->block_type == kDalvikByteCode) {
736 // Check to see if predecessor had an explicit null-check.
737 MIR* last_insn = pred_bb->last_mir_insn;
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -0700738 if (last_insn != nullptr) {
739 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
740 if (last_opcode == Instruction::IF_EQZ) {
741 if (pred_bb->fall_through == bb->id) {
742 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
743 // it can't be null.
744 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
745 }
746 } else if (last_opcode == Instruction::IF_NEZ) {
747 if (pred_bb->taken == bb->id) {
748 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
749 // null.
750 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
751 }
buzbee1da1e2f2013-11-15 13:37:01 -0800752 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700753 }
754 }
buzbee1da1e2f2013-11-15 13:37:01 -0800755 } else {
756 // Starting state is union of all incoming arcs
757 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
758 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
Vladimir Markobfea9c22014-01-17 17:49:33 +0000759 CHECK(pred_bb != NULL);
760 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
761 pred_bb = GetBasicBlock(iter.Next());
762 // At least one predecessor must have been processed before this bb.
763 DCHECK(pred_bb != nullptr);
764 DCHECK(pred_bb->data_flow_info != nullptr);
765 }
766 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800767 while (true) {
768 pred_bb = GetBasicBlock(iter.Next());
769 if (!pred_bb) break;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000770 DCHECK(pred_bb->data_flow_info != nullptr);
771 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800772 continue;
773 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000774 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
buzbee311ca162013-02-28 15:56:43 -0800775 }
buzbee311ca162013-02-28 15:56:43 -0800776 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000777 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800778 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800779 }
780
781 // Walk through the instruction in the block, updating as necessary
782 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
783 if (mir->ssa_rep == NULL) {
784 continue;
785 }
buzbee1da1e2f2013-11-15 13:37:01 -0800786
787 // Propagate type info.
788 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
789 if (!do_nce) {
790 continue;
791 }
792
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700793 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800794
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000795 // Might need a null check?
796 if (df_attributes & DF_HAS_NULL_CHKS) {
797 int src_idx;
798 if (df_attributes & DF_NULL_CHK_1) {
799 src_idx = 1;
800 } else if (df_attributes & DF_NULL_CHK_2) {
801 src_idx = 2;
802 } else {
803 src_idx = 0;
804 }
805 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000806 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000807 // Eliminate the null check.
808 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
809 } else {
810 // Do the null check.
811 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
812 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000813 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000814 }
815 }
816
817 if ((df_attributes & DF_A_WIDE) ||
818 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
819 continue;
820 }
821
822 /*
823 * First, mark all object definitions as requiring null check.
824 * Note: we can't tell if a CONST definition might be used as an object, so treat
825 * them all as object definitions.
826 */
827 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
828 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000829 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700830 }
831
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000832 // Now, remove mark from all object definitions we know are non-null.
833 if (df_attributes & DF_NON_NULL_DST) {
834 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000835 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000836 }
837
buzbee311ca162013-02-28 15:56:43 -0800838 // Mark non-null returns from invoke-style NEW*
839 if (df_attributes & DF_NON_NULL_RET) {
840 MIR* next_mir = mir->next;
841 // Next should be an MOVE_RESULT_OBJECT
842 if (next_mir &&
843 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
844 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000845 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800846 } else {
847 if (next_mir) {
848 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700849 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800850 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700851 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800852 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
853 tmir =tmir->next) {
854 if (static_cast<int>(tmir->dalvikInsn.opcode) >= static_cast<int>(kMirOpFirst)) {
855 continue;
856 }
857 // First non-pseudo should be MOVE_RESULT_OBJECT
858 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
859 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000860 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800861 } else {
862 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
863 }
864 break;
865 }
866 }
867 }
868 }
869
870 /*
871 * Propagate nullcheck state on register copies (including
872 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000873 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -0800874 */
875 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
876 int tgt_sreg = mir->ssa_rep->defs[0];
877 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
878 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000879 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -0800880 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000881 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -0800882 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000883 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000884 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000885 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000886 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -0800887 }
888 }
buzbee311ca162013-02-28 15:56:43 -0800889 }
890
891 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +0000892 bool nce_changed = false;
893 if (do_nce) {
894 if (bb->data_flow_info->ending_check_v == nullptr) {
895 DCHECK(temp_scoped_alloc_.get() != nullptr);
896 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
897 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
898 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
899 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -0700900 } else if (!ssa_regs_to_check->SameBitsSet(bb->data_flow_info->ending_check_v)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000901 nce_changed = true;
902 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
903 }
buzbee311ca162013-02-28 15:56:43 -0800904 }
buzbee1da1e2f2013-11-15 13:37:01 -0800905 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -0800906}
907
Vladimir Markobfea9c22014-01-17 17:49:33 +0000908void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
909 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
910 // Clean up temporaries.
911 temp_bit_vector_size_ = 0u;
912 temp_bit_vector_ = nullptr;
913 AllNodesIterator iter(this);
914 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
915 if (bb->data_flow_info != nullptr) {
916 bb->data_flow_info->ending_check_v = nullptr;
917 }
918 }
919 DCHECK(temp_scoped_alloc_.get() != nullptr);
920 temp_scoped_alloc_.reset();
921 }
922}
923
924bool MIRGraph::EliminateClassInitChecksGate() {
925 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
926 !cu_->mir_graph->HasStaticFieldAccess()) {
927 return false;
928 }
929
930 if (kIsDebugBuild) {
931 AllNodesIterator iter(this);
932 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
933 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
934 }
935 }
936
937 DCHECK(temp_scoped_alloc_.get() == nullptr);
938 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
939
940 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
941 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
942 temp_insn_data_ = static_cast<uint16_t*>(
943 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
944
945 uint32_t unique_class_count = 0u;
946 {
947 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
948 // ScopedArenaAllocator.
949
950 // Embed the map value in the entry to save space.
951 struct MapEntry {
952 // Map key: the class identified by the declaring dex file and type index.
953 const DexFile* declaring_dex_file;
954 uint16_t declaring_class_idx;
955 // Map value: index into bit vectors of classes requiring initialization checks.
956 uint16_t index;
957 };
958 struct MapEntryComparator {
959 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
960 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
961 return lhs.declaring_class_idx < rhs.declaring_class_idx;
962 }
963 return lhs.declaring_dex_file < rhs.declaring_dex_file;
964 }
965 };
966
967 typedef std::set<MapEntry, MapEntryComparator, ScopedArenaAllocatorAdapter<MapEntry> >
968 ClassToIndexMap;
969
970 ScopedArenaAllocator allocator(&cu_->arena_stack);
971 ClassToIndexMap class_to_index_map(MapEntryComparator(), allocator.Adapter());
972
973 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
974 AllNodesIterator iter(this);
975 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
976 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
977 DCHECK(bb->data_flow_info != nullptr);
978 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
979 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
980 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
981 uint16_t index = 0xffffu;
982 if (field_info.IsResolved() && !field_info.IsInitialized()) {
983 DCHECK_LT(class_to_index_map.size(), 0xffffu);
984 MapEntry entry = {
985 field_info.DeclaringDexFile(),
986 field_info.DeclaringClassIndex(),
987 static_cast<uint16_t>(class_to_index_map.size())
988 };
989 index = class_to_index_map.insert(entry).first->index;
990 }
991 // Using offset/2 for index into temp_insn_data_.
992 temp_insn_data_[mir->offset / 2u] = index;
993 }
994 }
995 }
996 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
997 }
998
999 if (unique_class_count == 0u) {
1000 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1001 temp_insn_data_ = nullptr;
1002 temp_scoped_alloc_.reset();
1003 return false;
1004 }
1005
1006 temp_bit_vector_size_ = unique_class_count;
1007 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1008 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1009 DCHECK_GT(temp_bit_vector_size_, 0u);
1010 return true;
1011}
1012
1013/*
1014 * Eliminate unnecessary class initialization checks for a basic block.
1015 */
1016bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1017 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1018 if (bb->data_flow_info == NULL) {
1019 return false;
1020 }
1021
1022 /*
1023 * Set initial state. Be conservative with catch
1024 * blocks and start with no assumptions about class init check status.
1025 */
1026 ArenaBitVector* classes_to_check = temp_bit_vector_;
1027 DCHECK(classes_to_check != nullptr);
1028 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
1029 classes_to_check->SetInitialBits(temp_bit_vector_size_);
1030 } else if (bb->predecessors->Size() == 1) {
1031 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
1032 // pred_bb must have already been processed at least once.
1033 DCHECK(pred_bb != nullptr);
1034 DCHECK(pred_bb->data_flow_info != nullptr);
1035 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1036 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1037 } else {
1038 // Starting state is union of all incoming arcs
1039 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
1040 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
1041 DCHECK(pred_bb != NULL);
1042 DCHECK(pred_bb->data_flow_info != NULL);
1043 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
1044 pred_bb = GetBasicBlock(iter.Next());
1045 // At least one predecessor must have been processed before this bb.
1046 DCHECK(pred_bb != nullptr);
1047 DCHECK(pred_bb->data_flow_info != nullptr);
1048 }
1049 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1050 while (true) {
1051 pred_bb = GetBasicBlock(iter.Next());
1052 if (!pred_bb) break;
1053 DCHECK(pred_bb->data_flow_info != nullptr);
1054 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1055 continue;
1056 }
1057 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1058 }
1059 }
1060 // At this point, classes_to_check shows which classes need clinit checks.
1061
1062 // Walk through the instruction in the block, updating as necessary
1063 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1064 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1065 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1066 uint16_t index = temp_insn_data_[mir->offset / 2u];
1067 if (index != 0xffffu) {
1068 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1069 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1070 if (!classes_to_check->IsBitSet(index)) {
1071 // Eliminate the class init check.
1072 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1073 } else {
1074 // Do the class init check.
1075 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1076 }
1077 }
1078 // Mark the class as initialized.
1079 classes_to_check->ClearBit(index);
1080 }
1081 }
1082 }
1083
1084 // Did anything change?
1085 bool changed = false;
1086 if (bb->data_flow_info->ending_check_v == nullptr) {
1087 DCHECK(temp_scoped_alloc_.get() != nullptr);
1088 DCHECK(bb->data_flow_info != nullptr);
1089 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1090 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1091 changed = classes_to_check->GetHighestBitSet() != -1;
1092 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1093 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1094 changed = true;
1095 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1096 }
1097 return changed;
1098}
1099
1100void MIRGraph::EliminateClassInitChecksEnd() {
1101 // Clean up temporaries.
1102 temp_bit_vector_size_ = 0u;
1103 temp_bit_vector_ = nullptr;
1104 AllNodesIterator iter(this);
1105 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1106 if (bb->data_flow_info != nullptr) {
1107 bb->data_flow_info->ending_check_v = nullptr;
1108 }
1109 }
1110
1111 DCHECK(temp_insn_data_ != nullptr);
1112 temp_insn_data_ = nullptr;
1113 DCHECK(temp_scoped_alloc_.get() != nullptr);
1114 temp_scoped_alloc_.reset();
1115}
1116
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001117void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1118 uint32_t method_index = invoke->meta.method_lowering_info;
1119 if (temp_bit_vector_->IsBitSet(method_index)) {
1120 iget_or_iput->meta.ifield_lowering_info = temp_insn_data_[method_index];
1121 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1122 return;
1123 }
1124
1125 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1126 MethodReference target = method_info.GetTargetMethod();
1127 DexCompilationUnit inlined_unit(
1128 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1129 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1130 0u /* access_flags not used */, nullptr /* verified_method not used */);
1131 MirIFieldLoweringInfo inlined_field_info(field_idx);
1132 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1133 DCHECK(inlined_field_info.IsResolved());
1134
1135 uint32_t field_info_index = ifield_lowering_infos_.Size();
1136 ifield_lowering_infos_.Insert(inlined_field_info);
1137 temp_bit_vector_->SetBit(method_index);
1138 temp_insn_data_[method_index] = field_info_index;
1139 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1140}
1141
1142bool MIRGraph::InlineCallsGate() {
1143 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
1144 method_lowering_infos_.Size() == 0u) {
1145 return false;
1146 }
1147 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1148 // This isn't the Quick compiler.
1149 return false;
1150 }
1151 return true;
1152}
1153
1154void MIRGraph::InlineCallsStart() {
1155 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1156 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1157
1158 DCHECK(temp_scoped_alloc_.get() == nullptr);
1159 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1160 temp_bit_vector_size_ = method_lowering_infos_.Size();
1161 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1162 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapMisc);
1163 temp_bit_vector_->ClearAllBits();
1164 temp_insn_data_ = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1165 temp_bit_vector_size_ * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1166}
1167
1168void MIRGraph::InlineCalls(BasicBlock* bb) {
1169 if (bb->block_type != kDalvikByteCode) {
1170 return;
1171 }
1172 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1173 if (!(Instruction::FlagsOf(mir->dalvikInsn.opcode) & Instruction::kInvoke)) {
1174 continue;
1175 }
1176 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1177 if (!method_info.FastPath()) {
1178 continue;
1179 }
1180 InvokeType sharp_type = method_info.GetSharpType();
1181 if ((sharp_type != kDirect) &&
1182 (sharp_type != kStatic || method_info.NeedsClassInitialization())) {
1183 continue;
1184 }
1185 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1186 MethodReference target = method_info.GetTargetMethod();
1187 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1188 ->GenInline(this, bb, mir, target.dex_method_index)) {
1189 if (cu_->verbose) {
1190 LOG(INFO) << "In \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1191 << "\" @0x" << std::hex << mir->offset
1192 << " inlined " << method_info.GetInvokeType() << " (" << sharp_type << ") call to \""
1193 << PrettyMethod(target.dex_method_index, *target.dex_file) << "\"";
1194 }
1195 }
1196 }
1197}
1198
1199void MIRGraph::InlineCallsEnd() {
1200 DCHECK(temp_insn_data_ != nullptr);
1201 temp_insn_data_ = nullptr;
1202 DCHECK(temp_bit_vector_ != nullptr);
1203 temp_bit_vector_ = nullptr;
1204 DCHECK(temp_scoped_alloc_.get() != nullptr);
1205 temp_scoped_alloc_.reset();
1206}
1207
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001208void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001209 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001210 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001211 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001212 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001213 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1214 CountChecks(bb);
1215 }
1216 if (stats->null_checks > 0) {
1217 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1218 float checks = static_cast<float>(stats->null_checks);
1219 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1220 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1221 << (eliminated/checks) * 100.0 << "%";
1222 }
1223 if (stats->range_checks > 0) {
1224 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1225 float checks = static_cast<float>(stats->range_checks);
1226 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1227 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1228 << (eliminated/checks) * 100.0 << "%";
1229 }
1230}
1231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001232bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001233 if (bb->visited) return false;
1234 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1235 || (bb->block_type == kExitBlock))) {
1236 // Ignore special blocks
1237 bb->visited = true;
1238 return false;
1239 }
1240 // Must be head of extended basic block.
1241 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001242 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001243 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001244 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001245 // Visit blocks strictly dominated by this head.
1246 while (bb != NULL) {
1247 bb->visited = true;
1248 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001249 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001250 bb = NextDominatedBlock(bb);
1251 }
buzbee1da1e2f2013-11-15 13:37:01 -08001252 if (terminated_by_return || do_local_value_numbering) {
1253 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001254 bb = start_bb;
1255 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001256 bb->use_lvn = do_local_value_numbering;
1257 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001258 bb = NextDominatedBlock(bb);
1259 }
1260 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001261 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001262}
1263
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001264void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001265 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1266 ClearAllVisitedFlags();
1267 PreOrderDfsIterator iter2(this);
1268 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1269 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001270 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001271 // Perform extended basic block optimizations.
1272 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1273 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1274 }
1275 } else {
1276 PreOrderDfsIterator iter(this);
1277 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1278 BasicBlockOpt(bb);
1279 }
buzbee311ca162013-02-28 15:56:43 -08001280 }
1281}
1282
1283} // namespace art