blob: 51419f45869303dbfbef7e655bd24d508fd141f8 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "compiler_internals.h"
18#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko9820b7c2014-01-02 16:40:37 +000020#include "dex/quick/dex_file_method_inliner.h"
21#include "dex/quick/dex_file_to_method_inliner_map.h"
buzbee311ca162013-02-28 15:56:43 -080022
23namespace art {
24
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070025static unsigned int Predecessors(BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -070026 return bb->predecessors->Size();
buzbee311ca162013-02-28 15:56:43 -080027}
28
29/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030void MIRGraph::SetConstant(int32_t ssa_reg, int value) {
buzbee862a7602013-04-05 10:58:54 -070031 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080032 constant_values_[ssa_reg] = value;
33}
34
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070035void MIRGraph::SetConstantWide(int ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = Low32Bits(value);
38 constant_values_[ssa_reg + 1] = High32Bits(value);
39}
40
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080041void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080042 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080043
44 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
buzbee1da1e2f2013-11-15 13:37:01 -080045 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -080046
47 DecodedInstruction *d_insn = &mir->dalvikInsn;
48
49 if (!(df_attributes & DF_HAS_DEFS)) continue;
50
51 /* Handle instructions that set up constants directly */
52 if (df_attributes & DF_SETS_CONST) {
53 if (df_attributes & DF_DA) {
54 int32_t vB = static_cast<int32_t>(d_insn->vB);
55 switch (d_insn->opcode) {
56 case Instruction::CONST_4:
57 case Instruction::CONST_16:
58 case Instruction::CONST:
59 SetConstant(mir->ssa_rep->defs[0], vB);
60 break;
61 case Instruction::CONST_HIGH16:
62 SetConstant(mir->ssa_rep->defs[0], vB << 16);
63 break;
64 case Instruction::CONST_WIDE_16:
65 case Instruction::CONST_WIDE_32:
66 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
67 break;
68 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070069 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080070 break;
71 case Instruction::CONST_WIDE_HIGH16:
72 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
73 break;
74 default:
75 break;
76 }
77 }
78 /* Handle instructions that set up constants directly */
79 } else if (df_attributes & DF_IS_MOVE) {
80 int i;
81
82 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070083 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080084 }
85 /* Move a register holding a constant to another register */
86 if (i == mir->ssa_rep->num_uses) {
87 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
88 if (df_attributes & DF_A_WIDE) {
89 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
90 }
91 }
92 }
93 }
94 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -080095}
96
buzbee311ca162013-02-28 15:56:43 -080097/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -070098MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -080099 BasicBlock* bb = *p_bb;
100 if (mir != NULL) {
101 mir = mir->next;
102 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700103 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800104 if ((bb == NULL) || Predecessors(bb) != 1) {
105 mir = NULL;
106 } else {
107 *p_bb = bb;
108 mir = bb->first_mir_insn;
109 }
110 }
111 }
112 return mir;
113}
114
115/*
116 * To be used at an invoke mir. If the logically next mir node represents
117 * a move-result, return it. Else, return NULL. If a move-result exists,
118 * it is required to immediately follow the invoke with no intervening
119 * opcodes or incoming arcs. However, if the result of the invoke is not
120 * used, a move-result may not be present.
121 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700122MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800123 BasicBlock* tbb = bb;
124 mir = AdvanceMIR(&tbb, mir);
125 while (mir != NULL) {
126 int opcode = mir->dalvikInsn.opcode;
127 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
128 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
129 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
130 break;
131 }
132 // Keep going if pseudo op, otherwise terminate
133 if (opcode < kNumPackedOpcodes) {
134 mir = NULL;
135 } else {
136 mir = AdvanceMIR(&tbb, mir);
137 }
138 }
139 return mir;
140}
141
buzbee0d829482013-10-11 15:24:55 -0700142BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800143 if (bb->block_type == kDead) {
144 return NULL;
145 }
146 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
147 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700148 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
149 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800150 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700151 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700152 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700153 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700154 } else {
155 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700156 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700157 }
buzbee311ca162013-02-28 15:56:43 -0800158 if (bb == NULL || (Predecessors(bb) != 1)) {
159 return NULL;
160 }
161 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
162 return bb;
163}
164
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700165static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800166 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
167 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
168 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
169 if (mir->ssa_rep->uses[i] == ssa_name) {
170 return mir;
171 }
172 }
173 }
174 }
175 return NULL;
176}
177
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700178static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800179 switch (mir->dalvikInsn.opcode) {
180 case Instruction::MOVE:
181 case Instruction::MOVE_OBJECT:
182 case Instruction::MOVE_16:
183 case Instruction::MOVE_OBJECT_16:
184 case Instruction::MOVE_FROM16:
185 case Instruction::MOVE_OBJECT_FROM16:
186 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700187 case Instruction::CONST:
188 case Instruction::CONST_4:
189 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800190 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700191 case Instruction::GOTO:
192 case Instruction::GOTO_16:
193 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800194 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700195 default:
196 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800197 }
buzbee311ca162013-02-28 15:56:43 -0800198}
199
Vladimir Markoa1a70742014-03-03 10:28:05 +0000200static constexpr ConditionCode kIfCcZConditionCodes[] = {
201 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
202};
203
204COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
205 if_ccz_ccodes_size1);
206
207static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
208 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
209}
210
211static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
212 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
213}
214
215COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
216COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
217COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
218COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
219COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
220COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
221
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700222int MIRGraph::GetSSAUseCount(int s_reg) {
buzbee862a7602013-04-05 10:58:54 -0700223 return raw_use_counts_.Get(s_reg);
buzbee311ca162013-02-28 15:56:43 -0800224}
225
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800226size_t MIRGraph::GetNumAvailableNonSpecialCompilerTemps() {
227 if (num_non_special_compiler_temps_ >= max_available_non_special_compiler_temps_) {
228 return 0;
229 } else {
230 return max_available_non_special_compiler_temps_ - num_non_special_compiler_temps_;
231 }
232}
233
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000234
235// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800236static const RegLocation temp_loc = {kLocCompilerTemp,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000237 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/, kVectorNotUsed,
238 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800239
240CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
241 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
242 if (ct_type == kCompilerTempVR) {
243 size_t available_temps = GetNumAvailableNonSpecialCompilerTemps();
244 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
245 return 0;
246 }
247 }
248
249 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000250 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800251
252 // Create the type of temp requested. Special temps need special handling because
253 // they have a specific virtual register assignment.
254 if (ct_type == kCompilerTempSpecialMethodPtr) {
255 DCHECK_EQ(wide, false);
256 compiler_temp->v_reg = static_cast<int>(kVRegMethodPtrBaseReg);
257 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
258
259 // The MIR graph keeps track of the sreg for method pointer specially, so record that now.
260 method_sreg_ = compiler_temp->s_reg_low;
261 } else {
262 DCHECK_EQ(ct_type, kCompilerTempVR);
263
264 // The new non-special compiler temp must receive a unique v_reg with a negative value.
265 compiler_temp->v_reg = static_cast<int>(kVRegNonSpecialTempBaseReg) - num_non_special_compiler_temps_;
266 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
267 num_non_special_compiler_temps_++;
268
269 if (wide) {
270 // Ensure that the two registers are consecutive. Since the virtual registers used for temps grow in a
271 // negative fashion, we need the smaller to refer to the low part. Thus, we redefine the v_reg and s_reg_low.
272 compiler_temp->v_reg--;
273 int ssa_reg_high = compiler_temp->s_reg_low;
274 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
275 int ssa_reg_low = compiler_temp->s_reg_low;
276
277 // If needed initialize the register location for the high part.
278 // The low part is handled later in this method on a common path.
279 if (reg_location_ != nullptr) {
280 reg_location_[ssa_reg_high] = temp_loc;
281 reg_location_[ssa_reg_high].high_word = 1;
282 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
283 reg_location_[ssa_reg_high].wide = true;
284
285 // A new SSA needs new use counts.
286 use_counts_.Insert(0);
287 raw_use_counts_.Insert(0);
288 }
289
290 num_non_special_compiler_temps_++;
291 }
292 }
293
294 // Have we already allocated the register locations?
295 if (reg_location_ != nullptr) {
296 int ssa_reg_low = compiler_temp->s_reg_low;
297 reg_location_[ssa_reg_low] = temp_loc;
298 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
299 reg_location_[ssa_reg_low].wide = wide;
300
301 // A new SSA needs new use counts.
302 use_counts_.Insert(0);
303 raw_use_counts_.Insert(0);
304 }
305
306 compiler_temps_.Insert(compiler_temp);
307 return compiler_temp;
308}
buzbee311ca162013-02-28 15:56:43 -0800309
310/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700311bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800312 if (bb->block_type == kDead) {
313 return true;
314 }
buzbee1da1e2f2013-11-15 13:37:01 -0800315 bool use_lvn = bb->use_lvn;
316 UniquePtr<LocalValueNumbering> local_valnum;
317 if (use_lvn) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000318 local_valnum.reset(LocalValueNumbering::Create(cu_));
buzbee1da1e2f2013-11-15 13:37:01 -0800319 }
buzbee311ca162013-02-28 15:56:43 -0800320 while (bb != NULL) {
321 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
322 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800323 if (use_lvn) {
324 local_valnum->GetValueNumber(mir);
325 }
buzbee311ca162013-02-28 15:56:43 -0800326 // Look for interesting opcodes, skip otherwise
327 Instruction::Code opcode = mir->dalvikInsn.opcode;
328 switch (opcode) {
329 case Instruction::CMPL_FLOAT:
330 case Instruction::CMPL_DOUBLE:
331 case Instruction::CMPG_FLOAT:
332 case Instruction::CMPG_DOUBLE:
333 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700334 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800335 // Bitcode doesn't allow this optimization.
336 break;
337 }
338 if (mir->next != NULL) {
339 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800340 // Make sure result of cmp is used by next insn and nowhere else
Vladimir Markoa1a70742014-03-03 10:28:05 +0000341 if (IsInstructionIfCcZ(mir->next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800342 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
343 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000344 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700345 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800346 case Instruction::CMPL_FLOAT:
347 mir_next->dalvikInsn.opcode =
348 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
349 break;
350 case Instruction::CMPL_DOUBLE:
351 mir_next->dalvikInsn.opcode =
352 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
353 break;
354 case Instruction::CMPG_FLOAT:
355 mir_next->dalvikInsn.opcode =
356 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
357 break;
358 case Instruction::CMPG_DOUBLE:
359 mir_next->dalvikInsn.opcode =
360 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
361 break;
362 case Instruction::CMP_LONG:
363 mir_next->dalvikInsn.opcode =
364 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
365 break;
366 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
367 }
368 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
369 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
370 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
371 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
372 mir_next->ssa_rep->num_defs = 0;
373 mir->ssa_rep->num_uses = 0;
374 mir->ssa_rep->num_defs = 0;
375 }
376 }
377 break;
378 case Instruction::GOTO:
379 case Instruction::GOTO_16:
380 case Instruction::GOTO_32:
381 case Instruction::IF_EQ:
382 case Instruction::IF_NE:
383 case Instruction::IF_LT:
384 case Instruction::IF_GE:
385 case Instruction::IF_GT:
386 case Instruction::IF_LE:
387 case Instruction::IF_EQZ:
388 case Instruction::IF_NEZ:
389 case Instruction::IF_LTZ:
390 case Instruction::IF_GEZ:
391 case Instruction::IF_GTZ:
392 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700393 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700394 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
395 (IsBackedge(bb, bb->fall_through) &&
396 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800397 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
398 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700399 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
400 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800401 }
402 }
403 break;
404 default:
405 break;
406 }
407 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800408 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800409 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000410 if (!cu_->compiler->IsPortable() &&
Dmitry Petrochenko6a58cb12014-04-02 17:27:59 +0700411 (cu_->instruction_set == kThumb2 || cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000412 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700413 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800414 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700415 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
416 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800417
buzbee0d829482013-10-11 15:24:55 -0700418 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800419 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700420 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
421 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800422
423 /*
424 * In the select pattern, the taken edge goes to a block that unconditionally
425 * transfers to the rejoin block and the fall_though edge goes to a block that
426 * unconditionally falls through to the rejoin block.
427 */
428 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
429 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
430 /*
431 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
432 * suspend check on the taken-taken branch back to the join point.
433 */
434 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
435 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
436 }
437 // Are the block bodies something we can handle?
438 if ((ft->first_mir_insn == ft->last_mir_insn) &&
439 (tk->first_mir_insn != tk->last_mir_insn) &&
440 (tk->first_mir_insn->next == tk->last_mir_insn) &&
441 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
442 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
443 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
444 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
445 // Almost there. Are the instructions targeting the same vreg?
446 MIR* if_true = tk->first_mir_insn;
447 MIR* if_false = ft->first_mir_insn;
448 // It's possible that the target of the select isn't used - skip those (rare) cases.
449 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
450 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
451 /*
452 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
453 * Phi node in the merge block and delete it (while using the SSA name
454 * of the merge as the target of the SELECT. Delete both taken and
455 * fallthrough blocks, and set fallthrough to merge block.
456 * NOTE: not updating other dataflow info (no longer used at this point).
457 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
458 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000459 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800460 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
461 bool const_form = (SelectKind(if_true) == kSelectConst);
462 if ((SelectKind(if_true) == kSelectMove)) {
463 if (IsConst(if_true->ssa_rep->uses[0]) &&
464 IsConst(if_false->ssa_rep->uses[0])) {
465 const_form = true;
466 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
467 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
468 }
469 }
470 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800471 /*
472 * TODO: If both constants are the same value, then instead of generating
473 * a select, we should simply generate a const bytecode. This should be
474 * considered after inlining which can lead to CFG of this form.
475 */
buzbee311ca162013-02-28 15:56:43 -0800476 // "true" set val in vB
477 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
478 // "false" set val in vC
479 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
480 } else {
481 DCHECK_EQ(SelectKind(if_true), kSelectMove);
482 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700483 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000484 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800485 src_ssa[0] = mir->ssa_rep->uses[0];
486 src_ssa[1] = if_true->ssa_rep->uses[0];
487 src_ssa[2] = if_false->ssa_rep->uses[0];
488 mir->ssa_rep->uses = src_ssa;
489 mir->ssa_rep->num_uses = 3;
490 }
491 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700492 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000493 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700494 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000495 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800496 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700497 // Match type of uses to def.
498 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700499 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000500 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700501 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
502 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
503 }
buzbee311ca162013-02-28 15:56:43 -0800504 /*
505 * There is usually a Phi node in the join block for our two cases. If the
506 * Phi node only contains our two cases as input, we will use the result
507 * SSA name of the Phi node as our select result and delete the Phi. If
508 * the Phi node has more than two operands, we will arbitrarily use the SSA
509 * name of the "true" path, delete the SSA name of the "false" path from the
510 * Phi node (and fix up the incoming arc list).
511 */
512 if (phi->ssa_rep->num_uses == 2) {
513 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
514 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
515 } else {
516 int dead_def = if_false->ssa_rep->defs[0];
517 int live_def = if_true->ssa_rep->defs[0];
518 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700519 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800520 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
521 if (phi->ssa_rep->uses[i] == live_def) {
522 incoming[i] = bb->id;
523 }
524 }
525 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
526 if (phi->ssa_rep->uses[i] == dead_def) {
527 int last_slot = phi->ssa_rep->num_uses - 1;
528 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
529 incoming[i] = incoming[last_slot];
530 }
531 }
532 }
533 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700534 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800535 tk->block_type = kDead;
536 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
537 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
538 }
539 }
540 }
541 }
542 }
543 }
buzbee1da1e2f2013-11-15 13:37:01 -0800544 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800545 }
546
buzbee311ca162013-02-28 15:56:43 -0800547 return true;
548}
549
buzbee311ca162013-02-28 15:56:43 -0800550/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700551void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700552 if (bb->data_flow_info != NULL) {
553 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
554 if (mir->ssa_rep == NULL) {
555 continue;
buzbee311ca162013-02-28 15:56:43 -0800556 }
buzbee1da1e2f2013-11-15 13:37:01 -0800557 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee862a7602013-04-05 10:58:54 -0700558 if (df_attributes & DF_HAS_NULL_CHKS) {
559 checkstats_->null_checks++;
560 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
561 checkstats_->null_checks_eliminated++;
562 }
563 }
564 if (df_attributes & DF_HAS_RANGE_CHKS) {
565 checkstats_->range_checks++;
566 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
567 checkstats_->range_checks_eliminated++;
568 }
buzbee311ca162013-02-28 15:56:43 -0800569 }
570 }
571 }
buzbee311ca162013-02-28 15:56:43 -0800572}
573
574/* Try to make common case the fallthrough path */
buzbee0d829482013-10-11 15:24:55 -0700575bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800576 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback
577 if (!bb->explicit_throw) {
578 return false;
579 }
580 BasicBlock* walker = bb;
581 while (true) {
582 // Check termination conditions
583 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
584 break;
585 }
buzbee0d829482013-10-11 15:24:55 -0700586 BasicBlock* prev = GetBasicBlock(walker->predecessors->Get(0));
buzbee311ca162013-02-28 15:56:43 -0800587 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700588 if (GetBasicBlock(prev->fall_through) == walker) {
buzbee311ca162013-02-28 15:56:43 -0800589 // Already done - return
590 break;
591 }
buzbee0d829482013-10-11 15:24:55 -0700592 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
buzbee311ca162013-02-28 15:56:43 -0800593 // Got one. Flip it and exit
594 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
595 switch (opcode) {
596 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
597 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
598 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
599 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
600 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
601 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
602 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
603 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
604 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
605 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
606 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
607 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
608 default: LOG(FATAL) << "Unexpected opcode " << opcode;
609 }
610 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700611 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800612 prev->taken = prev->fall_through;
613 prev->fall_through = t_bb;
614 break;
615 }
616 walker = prev;
617 }
618 return false;
619}
620
621/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800622void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800623 // Loop here to allow combining a sequence of blocks
624 while (true) {
625 // Check termination conditions
626 if ((bb->first_mir_insn == NULL)
627 || (bb->data_flow_info == NULL)
628 || (bb->block_type == kExceptionHandling)
629 || (bb->block_type == kExitBlock)
630 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700631 || (bb->taken == NullBasicBlockId)
632 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
633 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800634 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
635 break;
636 }
637
638 // Test the kMirOpCheck instruction
639 MIR* mir = bb->last_mir_insn;
640 // Grab the attributes from the paired opcode
641 MIR* throw_insn = mir->meta.throw_insn;
buzbee1da1e2f2013-11-15 13:37:01 -0800642 uint64_t df_attributes = oat_data_flow_attributes_[throw_insn->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800643 bool can_combine = true;
644 if (df_attributes & DF_HAS_NULL_CHKS) {
645 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
646 }
647 if (df_attributes & DF_HAS_RANGE_CHKS) {
648 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
649 }
650 if (!can_combine) {
651 break;
652 }
653 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700654 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800655 DCHECK(!bb_next->catch_entry);
656 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800657 // Overwrite the kOpCheck insn with the paired opcode
658 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
659 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800660 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700661 bb->successor_block_list_type = bb_next->successor_block_list_type;
662 bb->successor_blocks = bb_next->successor_blocks;
buzbee311ca162013-02-28 15:56:43 -0800663 // Use the ending block linkage from the next block
664 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700665 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800666 bb->taken = bb_next->taken;
667 // Include the rest of the instructions
668 bb->last_mir_insn = bb_next->last_mir_insn;
669 /*
670 * If lower-half of pair of blocks to combine contained a return, move the flag
671 * to the newly combined block.
672 */
673 bb->terminated_by_return = bb_next->terminated_by_return;
674
675 /*
676 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
677 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
678 */
679
680 // Kill bb_next and remap now-dead id to parent
681 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700682 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800683
684 // Now, loop back and see if we can keep going
685 }
buzbee311ca162013-02-28 15:56:43 -0800686}
687
Vladimir Markobfea9c22014-01-17 17:49:33 +0000688void MIRGraph::EliminateNullChecksAndInferTypesStart() {
689 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
690 if (kIsDebugBuild) {
691 AllNodesIterator iter(this);
692 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
693 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
694 }
695 }
696
697 DCHECK(temp_scoped_alloc_.get() == nullptr);
698 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
699 temp_bit_vector_size_ = GetNumSSARegs();
700 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
701 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
702 }
703}
704
buzbee1da1e2f2013-11-15 13:37:01 -0800705/*
706 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
707 * an iterative walk go ahead and perform type and size inference.
708 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800709bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800710 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800711 bool infer_changed = false;
712 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800713
Vladimir Markobfea9c22014-01-17 17:49:33 +0000714 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800715 if (do_nce) {
716 /*
717 * Set initial state. Be conservative with catch
718 * blocks and start with no assumptions about null check
719 * status (except for "this").
720 */
721 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000722 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800723 // Assume all ins are objects.
724 for (uint16_t in_reg = cu_->num_dalvik_registers - cu_->num_ins;
725 in_reg < cu_->num_dalvik_registers; in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000726 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800727 }
728 if ((cu_->access_flags & kAccStatic) == 0) {
729 // If non-static method, mark "this" as non-null
730 int this_reg = cu_->num_dalvik_registers - cu_->num_ins;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000731 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800732 }
733 } else if (bb->predecessors->Size() == 1) {
734 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
Vladimir Markobfea9c22014-01-17 17:49:33 +0000735 // pred_bb must have already been processed at least once.
736 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
737 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800738 if (pred_bb->block_type == kDalvikByteCode) {
739 // Check to see if predecessor had an explicit null-check.
740 MIR* last_insn = pred_bb->last_mir_insn;
741 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
742 if (last_opcode == Instruction::IF_EQZ) {
743 if (pred_bb->fall_through == bb->id) {
744 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
745 // it can't be null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000746 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800747 }
748 } else if (last_opcode == Instruction::IF_NEZ) {
749 if (pred_bb->taken == bb->id) {
750 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
751 // null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000752 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800753 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700754 }
755 }
buzbee1da1e2f2013-11-15 13:37:01 -0800756 } else {
757 // Starting state is union of all incoming arcs
758 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
759 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
Vladimir Markobfea9c22014-01-17 17:49:33 +0000760 CHECK(pred_bb != NULL);
761 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
762 pred_bb = GetBasicBlock(iter.Next());
763 // At least one predecessor must have been processed before this bb.
764 DCHECK(pred_bb != nullptr);
765 DCHECK(pred_bb->data_flow_info != nullptr);
766 }
767 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800768 while (true) {
769 pred_bb = GetBasicBlock(iter.Next());
770 if (!pred_bb) break;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000771 DCHECK(pred_bb->data_flow_info != nullptr);
772 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800773 continue;
774 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000775 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
buzbee311ca162013-02-28 15:56:43 -0800776 }
buzbee311ca162013-02-28 15:56:43 -0800777 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000778 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800779 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800780 }
781
782 // Walk through the instruction in the block, updating as necessary
783 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
784 if (mir->ssa_rep == NULL) {
785 continue;
786 }
buzbee1da1e2f2013-11-15 13:37:01 -0800787
788 // Propagate type info.
789 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
790 if (!do_nce) {
791 continue;
792 }
793
794 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800795
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000796 // Might need a null check?
797 if (df_attributes & DF_HAS_NULL_CHKS) {
798 int src_idx;
799 if (df_attributes & DF_NULL_CHK_1) {
800 src_idx = 1;
801 } else if (df_attributes & DF_NULL_CHK_2) {
802 src_idx = 2;
803 } else {
804 src_idx = 0;
805 }
806 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000807 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000808 // Eliminate the null check.
809 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
810 } else {
811 // Do the null check.
812 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
813 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000814 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000815 }
816 }
817
818 if ((df_attributes & DF_A_WIDE) ||
819 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
820 continue;
821 }
822
823 /*
824 * First, mark all object definitions as requiring null check.
825 * Note: we can't tell if a CONST definition might be used as an object, so treat
826 * them all as object definitions.
827 */
828 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
829 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000830 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700831 }
832
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000833 // Now, remove mark from all object definitions we know are non-null.
834 if (df_attributes & DF_NON_NULL_DST) {
835 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000836 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000837 }
838
buzbee311ca162013-02-28 15:56:43 -0800839 // Mark non-null returns from invoke-style NEW*
840 if (df_attributes & DF_NON_NULL_RET) {
841 MIR* next_mir = mir->next;
842 // Next should be an MOVE_RESULT_OBJECT
843 if (next_mir &&
844 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
845 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000846 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800847 } else {
848 if (next_mir) {
849 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700850 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800851 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700852 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800853 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
854 tmir =tmir->next) {
855 if (static_cast<int>(tmir->dalvikInsn.opcode) >= static_cast<int>(kMirOpFirst)) {
856 continue;
857 }
858 // First non-pseudo should be MOVE_RESULT_OBJECT
859 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
860 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000861 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800862 } else {
863 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
864 }
865 break;
866 }
867 }
868 }
869 }
870
871 /*
872 * Propagate nullcheck state on register copies (including
873 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000874 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -0800875 */
876 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
877 int tgt_sreg = mir->ssa_rep->defs[0];
878 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
879 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000880 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -0800881 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000882 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -0800883 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000884 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000885 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000886 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000887 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -0800888 }
889 }
buzbee311ca162013-02-28 15:56:43 -0800890 }
891
892 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +0000893 bool nce_changed = false;
894 if (do_nce) {
895 if (bb->data_flow_info->ending_check_v == nullptr) {
896 DCHECK(temp_scoped_alloc_.get() != nullptr);
897 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
898 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
899 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
900 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
901 } else if (!ssa_regs_to_check->Equal(bb->data_flow_info->ending_check_v)) {
902 nce_changed = true;
903 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
904 }
buzbee311ca162013-02-28 15:56:43 -0800905 }
buzbee1da1e2f2013-11-15 13:37:01 -0800906 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -0800907}
908
Vladimir Markobfea9c22014-01-17 17:49:33 +0000909void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
910 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
911 // Clean up temporaries.
912 temp_bit_vector_size_ = 0u;
913 temp_bit_vector_ = nullptr;
914 AllNodesIterator iter(this);
915 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
916 if (bb->data_flow_info != nullptr) {
917 bb->data_flow_info->ending_check_v = nullptr;
918 }
919 }
920 DCHECK(temp_scoped_alloc_.get() != nullptr);
921 temp_scoped_alloc_.reset();
922 }
923}
924
925bool MIRGraph::EliminateClassInitChecksGate() {
926 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
927 !cu_->mir_graph->HasStaticFieldAccess()) {
928 return false;
929 }
930
931 if (kIsDebugBuild) {
932 AllNodesIterator iter(this);
933 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
934 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
935 }
936 }
937
938 DCHECK(temp_scoped_alloc_.get() == nullptr);
939 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
940
941 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
942 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
943 temp_insn_data_ = static_cast<uint16_t*>(
944 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
945
946 uint32_t unique_class_count = 0u;
947 {
948 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
949 // ScopedArenaAllocator.
950
951 // Embed the map value in the entry to save space.
952 struct MapEntry {
953 // Map key: the class identified by the declaring dex file and type index.
954 const DexFile* declaring_dex_file;
955 uint16_t declaring_class_idx;
956 // Map value: index into bit vectors of classes requiring initialization checks.
957 uint16_t index;
958 };
959 struct MapEntryComparator {
960 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
961 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
962 return lhs.declaring_class_idx < rhs.declaring_class_idx;
963 }
964 return lhs.declaring_dex_file < rhs.declaring_dex_file;
965 }
966 };
967
968 typedef std::set<MapEntry, MapEntryComparator, ScopedArenaAllocatorAdapter<MapEntry> >
969 ClassToIndexMap;
970
971 ScopedArenaAllocator allocator(&cu_->arena_stack);
972 ClassToIndexMap class_to_index_map(MapEntryComparator(), allocator.Adapter());
973
974 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
975 AllNodesIterator iter(this);
976 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
977 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
978 DCHECK(bb->data_flow_info != nullptr);
979 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
980 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
981 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
982 uint16_t index = 0xffffu;
983 if (field_info.IsResolved() && !field_info.IsInitialized()) {
984 DCHECK_LT(class_to_index_map.size(), 0xffffu);
985 MapEntry entry = {
986 field_info.DeclaringDexFile(),
987 field_info.DeclaringClassIndex(),
988 static_cast<uint16_t>(class_to_index_map.size())
989 };
990 index = class_to_index_map.insert(entry).first->index;
991 }
992 // Using offset/2 for index into temp_insn_data_.
993 temp_insn_data_[mir->offset / 2u] = index;
994 }
995 }
996 }
997 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
998 }
999
1000 if (unique_class_count == 0u) {
1001 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1002 temp_insn_data_ = nullptr;
1003 temp_scoped_alloc_.reset();
1004 return false;
1005 }
1006
1007 temp_bit_vector_size_ = unique_class_count;
1008 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1009 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1010 DCHECK_GT(temp_bit_vector_size_, 0u);
1011 return true;
1012}
1013
1014/*
1015 * Eliminate unnecessary class initialization checks for a basic block.
1016 */
1017bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1018 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1019 if (bb->data_flow_info == NULL) {
1020 return false;
1021 }
1022
1023 /*
1024 * Set initial state. Be conservative with catch
1025 * blocks and start with no assumptions about class init check status.
1026 */
1027 ArenaBitVector* classes_to_check = temp_bit_vector_;
1028 DCHECK(classes_to_check != nullptr);
1029 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
1030 classes_to_check->SetInitialBits(temp_bit_vector_size_);
1031 } else if (bb->predecessors->Size() == 1) {
1032 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
1033 // pred_bb must have already been processed at least once.
1034 DCHECK(pred_bb != nullptr);
1035 DCHECK(pred_bb->data_flow_info != nullptr);
1036 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1037 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1038 } else {
1039 // Starting state is union of all incoming arcs
1040 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
1041 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
1042 DCHECK(pred_bb != NULL);
1043 DCHECK(pred_bb->data_flow_info != NULL);
1044 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
1045 pred_bb = GetBasicBlock(iter.Next());
1046 // At least one predecessor must have been processed before this bb.
1047 DCHECK(pred_bb != nullptr);
1048 DCHECK(pred_bb->data_flow_info != nullptr);
1049 }
1050 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1051 while (true) {
1052 pred_bb = GetBasicBlock(iter.Next());
1053 if (!pred_bb) break;
1054 DCHECK(pred_bb->data_flow_info != nullptr);
1055 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1056 continue;
1057 }
1058 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1059 }
1060 }
1061 // At this point, classes_to_check shows which classes need clinit checks.
1062
1063 // Walk through the instruction in the block, updating as necessary
1064 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1065 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1066 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1067 uint16_t index = temp_insn_data_[mir->offset / 2u];
1068 if (index != 0xffffu) {
1069 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1070 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1071 if (!classes_to_check->IsBitSet(index)) {
1072 // Eliminate the class init check.
1073 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1074 } else {
1075 // Do the class init check.
1076 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1077 }
1078 }
1079 // Mark the class as initialized.
1080 classes_to_check->ClearBit(index);
1081 }
1082 }
1083 }
1084
1085 // Did anything change?
1086 bool changed = false;
1087 if (bb->data_flow_info->ending_check_v == nullptr) {
1088 DCHECK(temp_scoped_alloc_.get() != nullptr);
1089 DCHECK(bb->data_flow_info != nullptr);
1090 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1091 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1092 changed = classes_to_check->GetHighestBitSet() != -1;
1093 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1094 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1095 changed = true;
1096 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1097 }
1098 return changed;
1099}
1100
1101void MIRGraph::EliminateClassInitChecksEnd() {
1102 // Clean up temporaries.
1103 temp_bit_vector_size_ = 0u;
1104 temp_bit_vector_ = nullptr;
1105 AllNodesIterator iter(this);
1106 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1107 if (bb->data_flow_info != nullptr) {
1108 bb->data_flow_info->ending_check_v = nullptr;
1109 }
1110 }
1111
1112 DCHECK(temp_insn_data_ != nullptr);
1113 temp_insn_data_ = nullptr;
1114 DCHECK(temp_scoped_alloc_.get() != nullptr);
1115 temp_scoped_alloc_.reset();
1116}
1117
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001118void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1119 uint32_t method_index = invoke->meta.method_lowering_info;
1120 if (temp_bit_vector_->IsBitSet(method_index)) {
1121 iget_or_iput->meta.ifield_lowering_info = temp_insn_data_[method_index];
1122 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1123 return;
1124 }
1125
1126 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1127 MethodReference target = method_info.GetTargetMethod();
1128 DexCompilationUnit inlined_unit(
1129 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1130 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1131 0u /* access_flags not used */, nullptr /* verified_method not used */);
1132 MirIFieldLoweringInfo inlined_field_info(field_idx);
1133 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1134 DCHECK(inlined_field_info.IsResolved());
1135
1136 uint32_t field_info_index = ifield_lowering_infos_.Size();
1137 ifield_lowering_infos_.Insert(inlined_field_info);
1138 temp_bit_vector_->SetBit(method_index);
1139 temp_insn_data_[method_index] = field_info_index;
1140 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1141}
1142
1143bool MIRGraph::InlineCallsGate() {
1144 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
1145 method_lowering_infos_.Size() == 0u) {
1146 return false;
1147 }
1148 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1149 // This isn't the Quick compiler.
1150 return false;
1151 }
1152 return true;
1153}
1154
1155void MIRGraph::InlineCallsStart() {
1156 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1157 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1158
1159 DCHECK(temp_scoped_alloc_.get() == nullptr);
1160 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1161 temp_bit_vector_size_ = method_lowering_infos_.Size();
1162 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1163 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapMisc);
1164 temp_bit_vector_->ClearAllBits();
1165 temp_insn_data_ = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1166 temp_bit_vector_size_ * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1167}
1168
1169void MIRGraph::InlineCalls(BasicBlock* bb) {
1170 if (bb->block_type != kDalvikByteCode) {
1171 return;
1172 }
1173 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1174 if (!(Instruction::FlagsOf(mir->dalvikInsn.opcode) & Instruction::kInvoke)) {
1175 continue;
1176 }
1177 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1178 if (!method_info.FastPath()) {
1179 continue;
1180 }
1181 InvokeType sharp_type = method_info.GetSharpType();
1182 if ((sharp_type != kDirect) &&
1183 (sharp_type != kStatic || method_info.NeedsClassInitialization())) {
1184 continue;
1185 }
1186 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1187 MethodReference target = method_info.GetTargetMethod();
1188 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1189 ->GenInline(this, bb, mir, target.dex_method_index)) {
1190 if (cu_->verbose) {
1191 LOG(INFO) << "In \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1192 << "\" @0x" << std::hex << mir->offset
1193 << " inlined " << method_info.GetInvokeType() << " (" << sharp_type << ") call to \""
1194 << PrettyMethod(target.dex_method_index, *target.dex_file) << "\"";
1195 }
1196 }
1197 }
1198}
1199
1200void MIRGraph::InlineCallsEnd() {
1201 DCHECK(temp_insn_data_ != nullptr);
1202 temp_insn_data_ = nullptr;
1203 DCHECK(temp_bit_vector_ != nullptr);
1204 temp_bit_vector_ = nullptr;
1205 DCHECK(temp_scoped_alloc_.get() != nullptr);
1206 temp_scoped_alloc_.reset();
1207}
1208
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001209void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001210 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001211 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001212 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001213 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001214 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1215 CountChecks(bb);
1216 }
1217 if (stats->null_checks > 0) {
1218 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1219 float checks = static_cast<float>(stats->null_checks);
1220 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1221 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1222 << (eliminated/checks) * 100.0 << "%";
1223 }
1224 if (stats->range_checks > 0) {
1225 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1226 float checks = static_cast<float>(stats->range_checks);
1227 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1228 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1229 << (eliminated/checks) * 100.0 << "%";
1230 }
1231}
1232
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001233bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001234 if (bb->visited) return false;
1235 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1236 || (bb->block_type == kExitBlock))) {
1237 // Ignore special blocks
1238 bb->visited = true;
1239 return false;
1240 }
1241 // Must be head of extended basic block.
1242 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001243 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001244 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001245 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001246 // Visit blocks strictly dominated by this head.
1247 while (bb != NULL) {
1248 bb->visited = true;
1249 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001250 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001251 bb = NextDominatedBlock(bb);
1252 }
buzbee1da1e2f2013-11-15 13:37:01 -08001253 if (terminated_by_return || do_local_value_numbering) {
1254 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001255 bb = start_bb;
1256 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001257 bb->use_lvn = do_local_value_numbering;
1258 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001259 bb = NextDominatedBlock(bb);
1260 }
1261 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001262 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001263}
1264
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001265void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001266 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1267 ClearAllVisitedFlags();
1268 PreOrderDfsIterator iter2(this);
1269 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1270 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001271 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001272 // Perform extended basic block optimizations.
1273 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1274 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1275 }
1276 } else {
1277 PreOrderDfsIterator iter(this);
1278 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1279 BasicBlockOpt(bb);
1280 }
buzbee311ca162013-02-28 15:56:43 -08001281 }
1282}
1283
1284} // namespace art