blob: be4ea200a9786ddbc47c043ead6abe3230beff3a [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000024#include "dex/verified_method.h"
25#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010027#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000028#include "driver/dex_compilation_unit.h"
29#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010030#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000031#include "jit/jit.h"
32#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000033#include "mirror/class_loader.h"
34#include "mirror/dex_cache.h"
35#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010036#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010037#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000038#include "register_allocator.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000039#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010040#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000041#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000042#include "ssa_phi_elimination.h"
43#include "scoped_thread_state_change.h"
44#include "thread.h"
45
46namespace art {
47
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000048static constexpr size_t kMaximumNumberOfHInstructions = 32;
49
50// Limit the number of dex registers that we accumulate while inlining
51// to avoid creating large amount of nested environments.
52static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
53
54// Avoid inlining within a huge method due to memory pressure.
55static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070056
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000057void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010058 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
59 if ((compiler_options.GetInlineDepthLimit() == 0)
60 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
61 return;
62 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000063 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
64 return;
65 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000066 if (graph_->IsDebuggable()) {
67 // For simplicity, we currently never inline when the graph is debuggable. This avoids
68 // doing some logic in the runtime to discover if a method could have been inlined.
69 return;
70 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010071 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
72 DCHECK(!blocks.empty());
73 HBasicBlock* next_block = blocks[0];
74 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010075 // Because we are changing the graph when inlining, we need to remember the next block.
76 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010077 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010078 continue;
79 }
80 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010081 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000082 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
83 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010084 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070085 // As long as the call is not intrinsified, it is worth trying to inline.
86 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000087 // We use the original invoke type to ensure the resolution of the called method
88 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000089 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010090 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000091 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000092 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000093 bool should_inline = callee_name.find("$inline$") != std::string::npos;
94 CHECK(!should_inline) << "Could not inline " << callee_name;
95 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010096 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010097 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010098 std::string callee_name =
99 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
100 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
101 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
102 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000103 }
104 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000105 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000106 }
107 }
108}
109
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100110static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700111 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100112 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
113}
114
115/**
116 * Given the `resolved_method` looked up in the dex cache, try to find
117 * the actual runtime target of an interface or virtual call.
118 * Return nullptr if the runtime target cannot be proven.
119 */
120static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700121 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100122 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
123 // No need to lookup further, the resolved method will be the target.
124 return resolved_method;
125 }
126
127 HInstruction* receiver = invoke->InputAt(0);
128 if (receiver->IsNullCheck()) {
129 // Due to multiple levels of inlining within the same pass, it might be that
130 // null check does not have the reference type of the actual receiver.
131 receiver = receiver->InputAt(0);
132 }
133 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000134 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
135 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100136 // We currently only support inlining with known receivers.
137 // TODO: Remove this check, we should be able to inline final methods
138 // on unknown receivers.
139 return nullptr;
140 } else if (info.GetTypeHandle()->IsInterface()) {
141 // Statically knowing that the receiver has an interface type cannot
142 // help us find what is the target method.
143 return nullptr;
144 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
145 // The method that we're trying to call is not in the receiver's class or super classes.
146 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000147 } else if (info.GetTypeHandle()->IsErroneous()) {
148 // If the type is erroneous, do not go further, as we are going to query the vtable or
149 // imt table, that we can only safely do on non-erroneous classes.
150 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100151 }
152
153 ClassLinker* cl = Runtime::Current()->GetClassLinker();
154 size_t pointer_size = cl->GetImagePointerSize();
155 if (invoke->IsInvokeInterface()) {
156 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
157 resolved_method, pointer_size);
158 } else {
159 DCHECK(invoke->IsInvokeVirtual());
160 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
161 resolved_method, pointer_size);
162 }
163
164 if (resolved_method == nullptr) {
165 // The information we had on the receiver was not enough to find
166 // the target method. Since we check above the exact type of the receiver,
167 // the only reason this can happen is an IncompatibleClassChangeError.
168 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700169 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100170 // The information we had on the receiver was not enough to find
171 // the target method. Since we check above the exact type of the receiver,
172 // the only reason this can happen is an IncompatibleClassChangeError.
173 return nullptr;
174 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
175 // A final method has to be the target method.
176 return resolved_method;
177 } else if (info.IsExact()) {
178 // If we found a method and the receiver's concrete type is statically
179 // known, we know for sure the target.
180 return resolved_method;
181 } else {
182 // Even if we did find a method, the receiver type was not enough to
183 // statically find the runtime target.
184 return nullptr;
185 }
186}
187
188static uint32_t FindMethodIndexIn(ArtMethod* method,
189 const DexFile& dex_file,
190 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700191 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100192 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100193 return method->GetDexMethodIndex();
194 } else {
195 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
196 }
197}
198
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000199static uint32_t FindClassIndexIn(mirror::Class* cls,
200 const DexFile& dex_file,
201 Handle<mirror::DexCache> dex_cache)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100202 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000203 uint32_t index = DexFile::kDexNoIndex;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100204 if (cls->GetDexCache() == nullptr) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000205 DCHECK(cls->IsArrayClass()) << PrettyClass(cls);
206 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100207 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000208 DCHECK(cls->IsProxyClass()) << PrettyClass(cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100209 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100210 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000211 index = cls->GetDexTypeIndex();
212 } else {
213 index = cls->FindTypeIndexInOtherDexFile(dex_file);
214 }
215
216 if (index != DexFile::kDexNoIndex) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100217 // Update the dex cache to ensure the class is in. The generated code will
218 // consider it is. We make it safe by updating the dex cache, as other
219 // dex files might also load the class, and there is no guarantee the dex
220 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000221 if (dex_cache->GetResolvedType(index) == nullptr) {
222 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100223 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100224 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000225
226 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100227}
228
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000229class ScopedProfilingInfoInlineUse {
230 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000231 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
232 : method_(method),
233 self_(self),
234 // Fetch the profiling info ahead of using it. If it's null when fetching,
235 // we should not call JitCodeCache::DoneInlining.
236 profiling_info_(
237 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000238 }
239
240 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000241 if (profiling_info_ != nullptr) {
242 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
243 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
244 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
245 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000246 }
247
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000248 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
249
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000250 private:
251 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000252 Thread* const self_;
253 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000254};
255
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700256bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100257 if (invoke_instruction->IsInvokeUnresolved()) {
258 return false; // Don't bother to move further if we know the method is unresolved.
259 }
260
Vladimir Marko58155012015-08-19 12:49:41 +0000261 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000262 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000263 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
264 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000265
Nicolas Geoffray35071052015-06-09 15:43:38 +0100266 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
267 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000268 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800269 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000270 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000271 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
272 VLOG(compiler) << "Not inlining a String.<init> method";
273 return false;
274 }
Vladimir Marko58155012015-08-19 12:49:41 +0000275 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700276 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
277 ? caller_compilation_unit_.GetDexCache().Get()
278 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
279 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000280 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800281 // actual_method == resolved_method for direct or static calls.
282 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000283 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700284 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000285 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800286 if (resolved_method != nullptr) {
287 // Check if we can statically find the method.
288 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
289 }
Vladimir Marko58155012015-08-19 12:49:41 +0000290 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000291
Mathieu Chartiere401d142015-04-22 13:56:20 -0700292 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100293 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100294 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000295 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000296 return false;
297 }
298
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100299 if (actual_method != nullptr) {
Calin Juravle69158982016-03-16 11:53:41 +0000300 bool result = TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true);
301 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
302 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
303 }
304 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100305 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000306
Andreas Gampefd2140f2015-12-23 16:30:44 -0800307 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100308
309 // Check if we can use an inline cache.
310 ArtMethod* caller = graph_->GetArtMethod();
Calin Juravleffc87072016-04-20 14:22:09 +0100311 if (Runtime::Current()->UseJitCompilation()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000312 // Under JIT, we should always know the caller.
313 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000314 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
315 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000316 if (profiling_info != nullptr) {
317 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000318 if (ic.IsUninitialized()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000319 VLOG(compiler) << "Interface or virtual call to "
320 << PrettyMethod(method_index, caller_dex_file)
321 << " is not hit and not inlined";
322 return false;
323 } else if (ic.IsMonomorphic()) {
324 MaybeRecordStat(kMonomorphicCall);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100325 if (outermost_graph_->IsCompilingOsr()) {
326 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
327 // interpreter and it may have seen different receiver types.
328 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
329 } else {
330 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
331 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000332 } else if (ic.IsPolymorphic()) {
333 MaybeRecordStat(kPolymorphicCall);
334 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
335 } else {
336 DCHECK(ic.IsMegamorphic());
337 VLOG(compiler) << "Interface or virtual call to "
338 << PrettyMethod(method_index, caller_dex_file)
339 << " is megamorphic and not inlined";
340 MaybeRecordStat(kMegamorphicCall);
341 return false;
342 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100343 }
344 }
345
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100346 VLOG(compiler) << "Interface or virtual call to "
347 << PrettyMethod(method_index, caller_dex_file)
348 << " could not be statically determined";
349 return false;
350}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000351
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000352HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
353 HInstruction* receiver,
354 uint32_t dex_pc) const {
355 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
356 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000357 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000358 receiver,
359 Primitive::kPrimNot,
360 field->GetOffset(),
361 field->IsVolatile(),
362 field->GetDexFieldIndex(),
363 field->GetDeclaringClass()->GetDexClassDefIndex(),
364 *field->GetDexFile(),
365 handles_->NewHandle(field->GetDexCache()),
366 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000367 // The class of a field is effectively final, and does not have any memory dependencies.
368 result->SetSideEffects(SideEffects::None());
369 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000370}
371
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100372bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
373 ArtMethod* resolved_method,
374 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000375 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
376 << invoke_instruction->DebugName();
377
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100378 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000379 uint32_t class_index = FindClassIndexIn(
380 ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100381 if (class_index == DexFile::kDexNoIndex) {
382 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
383 << " from inline cache is not inlined because its class is not"
384 << " accessible to the caller";
385 return false;
386 }
387
388 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
389 size_t pointer_size = class_linker->GetImagePointerSize();
390 if (invoke_instruction->IsInvokeInterface()) {
391 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
392 resolved_method, pointer_size);
393 } else {
394 DCHECK(invoke_instruction->IsInvokeVirtual());
395 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
396 resolved_method, pointer_size);
397 }
398 DCHECK(resolved_method != nullptr);
399 HInstruction* receiver = invoke_instruction->InputAt(0);
400 HInstruction* cursor = invoke_instruction->GetPrevious();
401 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
402
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000403 if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100404 return false;
405 }
406
407 // We successfully inlined, now add a guard.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100408 bool is_referrer =
409 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000410 AddTypeGuard(receiver,
411 cursor,
412 bb_cursor,
413 class_index,
414 is_referrer,
415 invoke_instruction,
416 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100417
418 // Run type propagation to get the guard typed, and eventually propagate the
419 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000420 ReferenceTypePropagation rtp_fixup(graph_,
421 outer_compilation_unit_.GetDexCache(),
422 handles_,
423 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100424 rtp_fixup.Run();
425
426 MaybeRecordStat(kInlinedMonomorphicCall);
427 return true;
428}
429
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000430HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
431 HInstruction* cursor,
432 HBasicBlock* bb_cursor,
433 uint32_t class_index,
434 bool is_referrer,
435 HInstruction* invoke_instruction,
436 bool with_deoptimization) {
437 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
438 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
439 class_linker, receiver, invoke_instruction->GetDexPc());
440
441 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
442 // Note that we will just compare the classes, so we don't need Java semantics access checks.
443 // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache.
444 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
445 class_index,
446 caller_dex_file,
447 is_referrer,
448 invoke_instruction->GetDexPc(),
449 /* needs_access_check */ false,
450 /* is_in_dex_cache */ true);
451
452 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
453 // TODO: Extend reference type propagation to understand the guard.
454 if (cursor != nullptr) {
455 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
456 } else {
457 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
458 }
459 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
460 bb_cursor->InsertInstructionAfter(compare, load_class);
461 if (with_deoptimization) {
462 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
463 compare, invoke_instruction->GetDexPc());
464 bb_cursor->InsertInstructionAfter(deoptimize, compare);
465 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
466 }
467 return compare;
468}
469
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000470bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100471 ArtMethod* resolved_method,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000472 const InlineCache& ic) {
473 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
474 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000475
476 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) {
477 return true;
478 }
479
480 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
481 size_t pointer_size = class_linker->GetImagePointerSize();
482 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
483
484 bool all_targets_inlined = true;
485 bool one_target_inlined = false;
486 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
487 if (ic.GetTypeAt(i) == nullptr) {
488 break;
489 }
490 ArtMethod* method = nullptr;
491 if (invoke_instruction->IsInvokeInterface()) {
492 method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
493 resolved_method, pointer_size);
494 } else {
495 DCHECK(invoke_instruction->IsInvokeVirtual());
496 method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
497 resolved_method, pointer_size);
498 }
499
500 HInstruction* receiver = invoke_instruction->InputAt(0);
501 HInstruction* cursor = invoke_instruction->GetPrevious();
502 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
503
Nicolas Geoffray1fe26e12016-02-18 16:55:42 +0000504 uint32_t class_index = FindClassIndexIn(
505 ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000506 HInstruction* return_replacement = nullptr;
507 if (class_index == DexFile::kDexNoIndex ||
508 !TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
509 all_targets_inlined = false;
510 } else {
511 one_target_inlined = true;
512 bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass());
513
514 // If we have inlined all targets before, and this receiver is the last seen,
515 // we deoptimize instead of keeping the original invoke instruction.
516 bool deoptimize = all_targets_inlined &&
517 (i != InlineCache::kIndividualCacheSize - 1) &&
518 (ic.GetTypeAt(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100519
520 if (outermost_graph_->IsCompilingOsr()) {
521 // We do not support HDeoptimize in OSR methods.
522 deoptimize = false;
523 }
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000524 HInstruction* compare = AddTypeGuard(
525 receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize);
526 if (deoptimize) {
527 if (return_replacement != nullptr) {
528 invoke_instruction->ReplaceWith(return_replacement);
529 }
530 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
531 // Because the inline cache data can be populated concurrently, we force the end of the
532 // iteration. Otherhwise, we could see a new receiver type.
533 break;
534 } else {
535 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
536 }
537 }
538 }
539
540 if (!one_target_inlined) {
541 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
542 << " from inline cache is not inlined because none"
543 << " of its targets could be inlined";
544 return false;
545 }
546 MaybeRecordStat(kInlinedPolymorphicCall);
547
548 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000549 ReferenceTypePropagation rtp_fixup(graph_,
550 outer_compilation_unit_.GetDexCache(),
551 handles_,
552 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000553 rtp_fixup.Run();
554 return true;
555}
556
557void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
558 HInstruction* return_replacement,
559 HInstruction* invoke_instruction) {
560 uint32_t dex_pc = invoke_instruction->GetDexPc();
561 HBasicBlock* cursor_block = compare->GetBlock();
562 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
563 ArenaAllocator* allocator = graph_->GetArena();
564
565 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
566 // and the returned block is the start of the then branch (that could contain multiple blocks).
567 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
568
569 // Split the block containing the invoke before and after the invoke. The returned block
570 // of the split before will contain the invoke and will be the otherwise branch of
571 // the diamond. The returned block of the split after will be the merge block
572 // of the diamond.
573 HBasicBlock* end_then = invoke_instruction->GetBlock();
574 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
575 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
576
577 // If the methods we are inlining return a value, we create a phi in the merge block
578 // that will have the `invoke_instruction and the `return_replacement` as inputs.
579 if (return_replacement != nullptr) {
580 HPhi* phi = new (allocator) HPhi(
581 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
582 merge->AddPhi(phi);
583 invoke_instruction->ReplaceWith(phi);
584 phi->AddInput(return_replacement);
585 phi->AddInput(invoke_instruction);
586 }
587
588 // Add the control flow instructions.
589 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
590 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
591 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
592
593 // Add the newly created blocks to the graph.
594 graph_->AddBlock(then);
595 graph_->AddBlock(otherwise);
596 graph_->AddBlock(merge);
597
598 // Set up successor (and implictly predecessor) relations.
599 cursor_block->AddSuccessor(otherwise);
600 cursor_block->AddSuccessor(then);
601 end_then->AddSuccessor(merge);
602 otherwise->AddSuccessor(merge);
603
604 // Set up dominance information.
605 then->SetDominator(cursor_block);
606 cursor_block->AddDominatedBlock(then);
607 otherwise->SetDominator(cursor_block);
608 cursor_block->AddDominatedBlock(otherwise);
609 merge->SetDominator(cursor_block);
610 cursor_block->AddDominatedBlock(merge);
611
612 // Update the revert post order.
613 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
614 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
615 graph_->reverse_post_order_[++index] = then;
616 index = IndexOfElement(graph_->reverse_post_order_, end_then);
617 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
618 graph_->reverse_post_order_[++index] = otherwise;
619 graph_->reverse_post_order_[++index] = merge;
620
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000621
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000622 graph_->UpdateLoopAndTryInformationOfNewBlock(
623 then, original_invoke_block, /* replace_if_back_edge */ false);
624 graph_->UpdateLoopAndTryInformationOfNewBlock(
625 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
626
627 // In case the original invoke location was a back edge, we need to update
628 // the loop to now have the merge block as a back edge.
629 graph_->UpdateLoopAndTryInformationOfNewBlock(
630 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000631}
632
633bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction,
634 ArtMethod* resolved_method,
635 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000636 // This optimization only works under JIT for now.
Calin Juravleffc87072016-04-20 14:22:09 +0100637 DCHECK(Runtime::Current()->UseJitCompilation());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000638 if (graph_->GetInstructionSet() == kMips64) {
639 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000640 return false;
641 }
642 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
643 size_t pointer_size = class_linker->GetImagePointerSize();
644
645 DCHECK(resolved_method != nullptr);
646 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000647 size_t method_index = invoke_instruction->IsInvokeVirtual()
648 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
649 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
650
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000651 // Check whether we are actually calling the same method among
652 // the different types seen.
653 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
654 if (ic.GetTypeAt(i) == nullptr) {
655 break;
656 }
657 ArtMethod* new_method = nullptr;
658 if (invoke_instruction->IsInvokeInterface()) {
Nelli Kimbadee982016-05-13 13:08:53 +0300659 new_method = ic.GetTypeAt(i)->GetImt(pointer_size)->Get(
Matthew Gharrity50706432016-06-14 11:31:04 -0700660 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000661 if (new_method->IsRuntimeMethod()) {
662 // Bail out as soon as we see a conflict trampoline in one of the target's
663 // interface table.
664 return false;
665 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000666 } else {
667 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000668 new_method = ic.GetTypeAt(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000669 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000670 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000671 if (actual_method == nullptr) {
672 actual_method = new_method;
673 } else if (actual_method != new_method) {
674 // Different methods, bailout.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000675 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
676 << " from inline cache is not inlined because it resolves"
677 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000678 return false;
679 }
680 }
681
682 HInstruction* receiver = invoke_instruction->InputAt(0);
683 HInstruction* cursor = invoke_instruction->GetPrevious();
684 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
685
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100686 HInstruction* return_replacement = nullptr;
687 if (!TryBuildAndInline(invoke_instruction, actual_method, &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000688 return false;
689 }
690
691 // We successfully inlined, now add a guard.
692 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
693 class_linker, receiver, invoke_instruction->GetDexPc());
694
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000695 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
696 ? Primitive::kPrimLong
697 : Primitive::kPrimInt;
698 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
699 receiver_class,
700 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000701 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
702 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000703 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000704 invoke_instruction->GetDexPc());
705
706 HConstant* constant;
707 if (type == Primitive::kPrimLong) {
708 constant = graph_->GetLongConstant(
709 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
710 } else {
711 constant = graph_->GetIntConstant(
712 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
713 }
714
715 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000716 if (cursor != nullptr) {
717 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
718 } else {
719 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
720 }
721 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
722 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100723
724 if (outermost_graph_->IsCompilingOsr()) {
725 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
726 } else {
727 // TODO: Extend reference type propagation to understand the guard.
728 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
729 compare, invoke_instruction->GetDexPc());
730 bb_cursor->InsertInstructionAfter(deoptimize, compare);
731 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
732 if (return_replacement != nullptr) {
733 invoke_instruction->ReplaceWith(return_replacement);
734 }
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +0100735 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100736 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000737
738 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000739 ReferenceTypePropagation rtp_fixup(graph_,
740 outer_compilation_unit_.GetDexCache(),
741 handles_,
742 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000743 rtp_fixup.Run();
744
745 MaybeRecordStat(kInlinedPolymorphicCall);
746
747 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100748}
749
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000750bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
751 HInstruction* return_replacement = nullptr;
752 if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
753 return false;
754 }
755 if (return_replacement != nullptr) {
756 invoke_instruction->ReplaceWith(return_replacement);
757 }
758 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +0100759 FixUpReturnReferenceType(method, return_replacement);
760 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
761 // Actual return value has a more specific type than the method's declared
762 // return type. Run RTP again on the outer graph to propagate it.
763 ReferenceTypePropagation(graph_,
764 outer_compilation_unit_.GetDexCache(),
765 handles_,
766 /* is_first_run */ false).Run();
767 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000768 return true;
769}
770
771bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
772 ArtMethod* method,
773 HInstruction** return_replacement) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100774 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800775
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100776 if (method->IsProxyMethod()) {
777 VLOG(compiler) << "Method " << PrettyMethod(method)
778 << " is not inlined because of unimplemented inline support for proxy methods.";
779 return false;
780 }
781
Jeff Haodcdc85b2015-12-04 14:06:18 -0800782 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
783 // dex file here (though the transitivity of an inline chain would allow checking the calller).
784 if (!compiler_driver_->MayInline(method->GetDexFile(),
785 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000786 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000787 VLOG(compiler) << "Successfully replaced pattern of invoke " << PrettyMethod(method);
788 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
789 return true;
790 }
Jeff Haodcdc85b2015-12-04 14:06:18 -0800791 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
792 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
793 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
794 << method->GetDexFile()->GetLocation();
795 return false;
796 }
797
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100798 uint32_t method_index = FindMethodIndexIn(
799 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
800 if (method_index == DexFile::kDexNoIndex) {
801 VLOG(compiler) << "Call to "
802 << PrettyMethod(method)
803 << " cannot be inlined because unaccessible to caller";
804 return false;
805 }
806
807 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
808
809 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000810
811 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100812 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000813 << " is not inlined because it is native";
814 return false;
815 }
816
Calin Juravleec748352015-07-29 13:52:12 +0100817 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
818 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100819 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000820 << " is too big to inline: "
821 << code_item->insns_size_in_code_units_
822 << " > "
823 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000824 return false;
825 }
826
827 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100828 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000829 << " is not inlined because of try block";
830 return false;
831 }
832
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100833 if (!method->IsCompilable()) {
834 VLOG(compiler) << "Method " << PrettyMethod(method)
835 << " has soft failures un-handled by the compiler, so it cannot be inlined";
836 }
837
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100838 if (!method->GetDeclaringClass()->IsVerified()) {
839 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +0100840 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000841 !compiler_driver_->IsMethodVerifiedWithoutFailures(
842 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100843 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
844 << " couldn't be verified, so it cannot be inlined";
845 return false;
846 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000847 }
848
Roland Levillain4c0eb422015-04-24 16:43:49 +0100849 if (invoke_instruction->IsInvokeStaticOrDirect() &&
850 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
851 // Case of a static method that cannot be inlined because it implicitly
852 // requires an initialization check of its declaring class.
853 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
854 << " is not inlined because it is static and requires a clinit"
855 << " check that cannot be emitted due to Dex cache limitations";
856 return false;
857 }
858
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000859 if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000860 return false;
861 }
862
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000863 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000864 MaybeRecordStat(kInlinedInvoke);
865 return true;
866}
867
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000868static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
869 size_t arg_vreg_index)
870 SHARED_REQUIRES(Locks::mutator_lock_) {
871 size_t input_index = 0;
872 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
873 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
874 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
875 ++i;
876 DCHECK_NE(i, arg_vreg_index);
877 }
878 }
879 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
880 return invoke_instruction->InputAt(input_index);
881}
882
883// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
884bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
885 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000886 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000887 InlineMethod inline_method;
888 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
889 return false;
890 }
891
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000892 switch (inline_method.opcode) {
893 case kInlineOpNop:
894 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000895 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000896 break;
897 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000898 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
899 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000900 break;
901 case kInlineOpNonWideConst:
902 if (resolved_method->GetShorty()[0] == 'L') {
903 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000904 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000905 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000906 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000907 }
908 break;
909 case kInlineOpIGet: {
910 const InlineIGetIPutData& data = inline_method.d.ifield_data;
911 if (data.method_is_static || data.object_arg != 0u) {
912 // TODO: Needs null check.
913 return false;
914 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000915 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000916 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000917 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000918 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
919 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
920 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000921 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000922 break;
923 }
924 case kInlineOpIPut: {
925 const InlineIGetIPutData& data = inline_method.d.ifield_data;
926 if (data.method_is_static || data.object_arg != 0u) {
927 // TODO: Needs null check.
928 return false;
929 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000930 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000931 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
932 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000933 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000934 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
935 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
936 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
937 if (data.return_arg_plus1 != 0u) {
938 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000939 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000940 }
941 break;
942 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000943 case kInlineOpConstructor: {
944 const InlineConstructorData& data = inline_method.d.constructor_data;
945 // Get the indexes to arrays for easier processing.
946 uint16_t iput_field_indexes[] = {
947 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
948 };
949 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
950 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
951 // Count valid field indexes.
952 size_t number_of_iputs = 0u;
953 while (number_of_iputs != arraysize(iput_field_indexes) &&
954 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
955 // Check that there are no duplicate valid field indexes.
956 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
957 iput_field_indexes + arraysize(iput_field_indexes),
958 iput_field_indexes[number_of_iputs]));
959 ++number_of_iputs;
960 }
961 // Check that there are no valid field indexes in the rest of the array.
962 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
963 iput_field_indexes + arraysize(iput_field_indexes),
964 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
965
966 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
967 Handle<mirror::DexCache> dex_cache;
968 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
969 bool needs_constructor_barrier = false;
970 for (size_t i = 0; i != number_of_iputs; ++i) {
971 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +0000972 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +0000973 if (dex_cache.GetReference() == nullptr) {
974 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
975 }
976 uint16_t field_index = iput_field_indexes[i];
977 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
978 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
979
980 // Check whether the field is final. If it is, we need to add a barrier.
981 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
982 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
983 DCHECK(resolved_field != nullptr);
984 if (resolved_field->IsFinal()) {
985 needs_constructor_barrier = true;
986 }
987 }
988 }
989 if (needs_constructor_barrier) {
990 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
991 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
992 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000993 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +0000994 break;
995 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000996 default:
997 LOG(FATAL) << "UNREACHABLE";
998 UNREACHABLE();
999 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001000 return true;
1001}
1002
Vladimir Marko354efa62016-02-04 19:46:56 +00001003HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001004 uint32_t field_index,
1005 HInstruction* obj)
1006 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001007 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
1008 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1009 DCHECK(resolved_field != nullptr);
1010 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1011 obj,
1012 resolved_field->GetTypeAsPrimitiveType(),
1013 resolved_field->GetOffset(),
1014 resolved_field->IsVolatile(),
1015 field_index,
1016 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001017 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001018 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +00001019 // Read barrier generates a runtime call in slow path and we need a valid
1020 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1021 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001022 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001023 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
1024 ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001025 rtp.Visit(iget);
1026 }
1027 return iget;
1028}
1029
Vladimir Marko354efa62016-02-04 19:46:56 +00001030HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001031 uint32_t field_index,
1032 HInstruction* obj,
1033 HInstruction* value)
1034 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001035 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
1036 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1037 DCHECK(resolved_field != nullptr);
1038 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1039 obj,
1040 value,
1041 resolved_field->GetTypeAsPrimitiveType(),
1042 resolved_field->GetOffset(),
1043 resolved_field->IsVolatile(),
1044 field_index,
1045 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001046 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001047 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +00001048 // Read barrier generates a runtime call in slow path and we need a valid
1049 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1050 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001051 return iput;
1052}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001053
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001054bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1055 ArtMethod* resolved_method,
1056 bool same_dex_file,
1057 HInstruction** return_replacement) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001058 ScopedObjectAccess soa(Thread::Current());
1059 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001060 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1061 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001062 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001063 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001064 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001065 caller_compilation_unit_.GetClassLoader(),
1066 class_linker,
1067 callee_dex_file,
1068 code_item,
1069 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1070 method_index,
1071 resolved_method->GetAccessFlags(),
1072 /* verified_method */ nullptr,
1073 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001074
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001075 bool requires_ctor_barrier = false;
1076
1077 if (dex_compilation_unit.IsConstructor()) {
1078 // If it's a super invocation and we already generate a barrier there's no need
1079 // to generate another one.
1080 // We identify super calls by looking at the "this" pointer. If its value is the
1081 // same as the local "this" pointer then we must have a super invocation.
1082 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1083 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1084 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1085 requires_ctor_barrier = false;
1086 } else {
1087 Thread* self = Thread::Current();
1088 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1089 dex_compilation_unit.GetDexFile(),
1090 dex_compilation_unit.GetClassDefIndex());
1091 }
1092 }
1093
Nicolas Geoffray35071052015-06-09 15:43:38 +01001094 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
1095 if (invoke_type == kInterface) {
1096 // We have statically resolved the dispatch. To please the class linker
1097 // at runtime, we change this call as if it was a virtual call.
1098 invoke_type = kVirtual;
1099 }
David Brazdil3f523062016-02-29 16:53:33 +00001100
1101 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001102 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001103 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001104 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001105 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001106 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001107 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001108 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001109 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001110 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001111 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001112 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001113
Roland Levillaina8013fd2016-04-04 15:34:31 +01001114 // When they are needed, allocate `inline_stats` on the heap instead
1115 // of on the stack, as Clang might produce a stack frame too large
1116 // for this function, that would not fit the requirements of the
1117 // `-Wframe-larger-than` option.
1118 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1119 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001120 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001121 &dex_compilation_unit,
1122 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001123 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001124 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001125 compiler_driver_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001126 inline_stats.get(),
Mathieu Chartier736b5602015-09-02 14:54:11 -07001127 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001128 dex_cache,
1129 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001130
David Brazdildee58d62016-04-07 09:54:26 +00001131 if (builder.BuildGraph() != kAnalysisSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001132 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001133 << " could not be built, so cannot be inlined";
1134 return false;
1135 }
1136
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001137 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1138 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001139 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001140 << " cannot be inlined because of the register allocator";
1141 return false;
1142 }
1143
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001144 size_t parameter_index = 0;
1145 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1146 !instructions.Done();
1147 instructions.Advance()) {
1148 HInstruction* current = instructions.Current();
1149 if (current->IsParameterValue()) {
1150 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
1151 if (argument->IsNullConstant()) {
1152 current->ReplaceWith(callee_graph->GetNullConstant());
1153 } else if (argument->IsIntConstant()) {
1154 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1155 } else if (argument->IsLongConstant()) {
1156 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1157 } else if (argument->IsFloatConstant()) {
1158 current->ReplaceWith(
1159 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1160 } else if (argument->IsDoubleConstant()) {
1161 current->ReplaceWith(
1162 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1163 } else if (argument->GetType() == Primitive::kPrimNot) {
1164 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1165 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1166 }
1167 }
1168 }
1169
David Brazdil94ab38f2016-06-21 17:48:19 +01001170 // We have replaced formal arguments with actual arguments. If actual types
1171 // are more specific than the declared ones, run RTP again on the inner graph.
1172 if (ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
1173 ReferenceTypePropagation(callee_graph,
1174 dex_compilation_unit.GetDexCache(),
1175 handles_,
1176 /* is_first_run */ false).Run();
1177 }
1178
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001179 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001180 size_t number_of_inlined_instructions =
1181 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1182 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001183
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001184 // TODO: We should abort only if all predecessors throw. However,
1185 // HGraph::InlineInto currently does not handle an exit block with
1186 // a throw predecessor.
1187 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1188 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001189 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001190 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001191 return false;
1192 }
1193
1194 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001195 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1196 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001197 has_throw_predecessor = true;
1198 break;
1199 }
1200 }
1201 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001202 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001203 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001204 return false;
1205 }
1206
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001207 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001208 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001209 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001210
1211 bool can_inline_environment =
1212 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1213
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001214 for (; !it.Done(); it.Advance()) {
1215 HBasicBlock* block = it.Current();
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001216
1217 if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) {
1218 // Don't inline methods with irreducible loops, they could prevent some
1219 // optimizations to run.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001220 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001221 << " could not be inlined because it contains an irreducible loop";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001222 return false;
1223 }
1224
1225 for (HInstructionIterator instr_it(block->GetInstructions());
1226 !instr_it.Done();
1227 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001228 if (number_of_instructions++ == number_of_instructions_budget) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001229 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001230 << " is not inlined because its caller has reached"
1231 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001232 return false;
1233 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001234 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001235 if (!can_inline_environment && current->NeedsEnvironment()) {
1236 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1237 << " is not inlined because its caller has reached"
1238 << " its environment budget limit.";
1239 return false;
1240 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001241
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001242 if (current->IsInvokeInterface()) {
1243 // Disable inlining of interface calls. The cost in case of entering the
1244 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001245 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001246 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001247 return false;
1248 }
1249
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001250 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001251 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001252 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001253 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001254 return false;
1255 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001256
Vladimir Markodc151b22015-10-15 18:02:30 +01001257 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001258 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001259 << " could not be inlined because " << current->DebugName()
1260 << " it is in a different dex file and requires access to the dex cache";
1261 return false;
1262 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001263
1264 if (current->IsNewInstance() &&
1265 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001266 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1267 << " could not be inlined because it is using an entrypoint"
1268 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001269 // Allocation entrypoint does not handle inlined frames.
1270 return false;
1271 }
1272
1273 if (current->IsNewArray() &&
1274 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001275 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1276 << " could not be inlined because it is using an entrypoint"
1277 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001278 // Allocation entrypoint does not handle inlined frames.
1279 return false;
1280 }
1281
1282 if (current->IsUnresolvedStaticFieldGet() ||
1283 current->IsUnresolvedInstanceFieldGet() ||
1284 current->IsUnresolvedStaticFieldSet() ||
1285 current->IsUnresolvedInstanceFieldSet()) {
1286 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001287 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1288 << " could not be inlined because it is using an unresolved"
1289 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001290 return false;
1291 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001292 }
1293 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001294 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001295
David Brazdil3f523062016-02-29 16:53:33 +00001296 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1297 << "No instructions can be added to the outer graph while inner graph is being built";
1298
1299 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1300 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001301 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001302
1303 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1304 << "No instructions can be added to the inner graph during inlining into the outer graph";
1305
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001306 return true;
1307}
Calin Juravle2e768302015-07-28 14:41:11 +00001308
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001309size_t HInliner::RunOptimizations(HGraph* callee_graph,
1310 const DexFile::CodeItem* code_item,
1311 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001312 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1313 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001314 HDeadCodeElimination dce(callee_graph, stats_);
1315 HConstantFolding fold(callee_graph);
1316 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
1317 InstructionSimplifier simplify(callee_graph, stats_);
1318 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_, stats_);
1319
1320 HOptimization* optimizations[] = {
1321 &intrinsics,
1322 &sharpening,
1323 &simplify,
1324 &fold,
1325 &dce,
1326 };
1327
1328 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1329 HOptimization* optimization = optimizations[i];
1330 optimization->Run();
1331 }
1332
1333 size_t number_of_inlined_instructions = 0u;
1334 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1335 HInliner inliner(callee_graph,
1336 outermost_graph_,
1337 codegen_,
1338 outer_compilation_unit_,
1339 dex_compilation_unit,
1340 compiler_driver_,
1341 handles_,
1342 stats_,
1343 total_number_of_dex_registers_ + code_item->registers_size_,
1344 depth_ + 1);
1345 inliner.Run();
1346 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1347 }
1348
1349 return number_of_inlined_instructions;
1350}
1351
David Brazdil94ab38f2016-06-21 17:48:19 +01001352static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1353 bool declared_can_be_null,
1354 HInstruction* actual_obj)
1355 SHARED_REQUIRES(Locks::mutator_lock_) {
1356 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1357 return true;
1358 }
1359
1360 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1361 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
1362 declared_rti.IsStrictSupertypeOf(actual_rti);
1363}
1364
1365ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1366 return ReferenceTypePropagation::IsAdmissible(klass)
1367 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1368 : graph_->GetInexactObjectRti();
1369}
1370
1371bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1372 // If this is an instance call, test whether the type of the `this` argument
1373 // is more specific than the class which declares the method.
1374 if (!resolved_method->IsStatic()) {
1375 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1376 /* declared_can_be_null */ false,
1377 invoke_instruction->InputAt(0u))) {
1378 return true;
1379 }
1380 }
1381
1382 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
1383
1384 // Iterate over the list of parameter types and test whether any of the
1385 // actual inputs has a more specific reference type than the type declared in
1386 // the signature.
1387 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1388 for (size_t param_idx = 0,
1389 input_idx = resolved_method->IsStatic() ? 0 : 1,
1390 e = (param_list == nullptr ? 0 : param_list->Size());
1391 param_idx < e;
1392 ++param_idx, ++input_idx) {
1393 HInstruction* input = invoke_instruction->InputAt(input_idx);
1394 if (input->GetType() == Primitive::kPrimNot) {
1395 mirror::Class* param_cls = resolved_method->GetDexCacheResolvedType(
1396 param_list->GetTypeItem(param_idx).type_idx_,
1397 pointer_size);
1398 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1399 /* declared_can_be_null */ true,
1400 input)) {
1401 return true;
1402 }
1403 }
1404 }
1405
1406 return false;
1407}
1408
1409bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1410 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001411 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001412 if (return_replacement != nullptr) {
1413 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001414 // Test if the return type is a refinement of the declared return type.
1415 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1416 /* declared_can_be_null */ true,
1417 return_replacement)) {
1418 return true;
1419 }
1420 } else if (return_replacement->IsInstanceOf()) {
1421 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1422 return true;
1423 }
1424 }
1425
1426 return false;
1427}
1428
1429void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1430 HInstruction* return_replacement) {
1431 if (return_replacement != nullptr) {
1432 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001433 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1434 // Make sure that we have a valid type for the return. We may get an invalid one when
1435 // we inline invokes with multiple branches and create a Phi for the result.
1436 // TODO: we could be more precise by merging the phi inputs but that requires
1437 // some functionality from the reference type propagation.
1438 DCHECK(return_replacement->IsPhi());
1439 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001440 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */, pointer_size);
David Brazdil94ab38f2016-06-21 17:48:19 +01001441 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001442 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001443 }
Calin Juravle2e768302015-07-28 14:41:11 +00001444 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001445}
1446
1447} // namespace art