blob: d1c3a6b4ba3b5de6dd877c612e264bbb2b38d0a9 [file] [log] [blame]
Vladimir Markof59f18b2014-02-17 15:53:57 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Vladimir Markoaf6925b2014-10-31 16:37:32 +000017#include "dex/mir_field_info.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010018#include "global_value_numbering.h"
19#include "local_value_numbering.h"
Vladimir Markof59f18b2014-02-17 15:53:57 +000020#include "gtest/gtest.h"
21
22namespace art {
23
24class LocalValueNumberingTest : public testing::Test {
25 protected:
26 struct IFieldDef {
27 uint16_t field_idx;
28 uintptr_t declaring_dex_file;
29 uint16_t declaring_field_idx;
30 bool is_volatile;
Vladimir Markoaf6925b2014-10-31 16:37:32 +000031 DexMemAccessType type;
Vladimir Markof59f18b2014-02-17 15:53:57 +000032 };
33
34 struct SFieldDef {
35 uint16_t field_idx;
36 uintptr_t declaring_dex_file;
37 uint16_t declaring_field_idx;
38 bool is_volatile;
Vladimir Markoaf6925b2014-10-31 16:37:32 +000039 DexMemAccessType type;
Vladimir Markof59f18b2014-02-17 15:53:57 +000040 };
41
42 struct MIRDef {
43 static constexpr size_t kMaxSsaDefs = 2;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010044 static constexpr size_t kMaxSsaUses = 4;
Vladimir Markof59f18b2014-02-17 15:53:57 +000045
46 Instruction::Code opcode;
47 int64_t value;
Vladimir Markobe0e5462014-02-26 11:24:15 +000048 uint32_t field_info;
Vladimir Markof59f18b2014-02-17 15:53:57 +000049 size_t num_uses;
50 int32_t uses[kMaxSsaUses];
51 size_t num_defs;
52 int32_t defs[kMaxSsaDefs];
53 };
54
55#define DEF_CONST(opcode, reg, value) \
56 { opcode, value, 0u, 0, { }, 1, { reg } }
57#define DEF_CONST_WIDE(opcode, reg, value) \
58 { opcode, value, 0u, 0, { }, 2, { reg, reg + 1 } }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010059#define DEF_CONST_STRING(opcode, reg, index) \
60 { opcode, index, 0u, 0, { }, 1, { reg } }
Vladimir Markobe0e5462014-02-26 11:24:15 +000061#define DEF_IGET(opcode, reg, obj, field_info) \
62 { opcode, 0u, field_info, 1, { obj }, 1, { reg } }
63#define DEF_IGET_WIDE(opcode, reg, obj, field_info) \
64 { opcode, 0u, field_info, 1, { obj }, 2, { reg, reg + 1 } }
65#define DEF_IPUT(opcode, reg, obj, field_info) \
66 { opcode, 0u, field_info, 2, { reg, obj }, 0, { } }
67#define DEF_IPUT_WIDE(opcode, reg, obj, field_info) \
68 { opcode, 0u, field_info, 3, { reg, reg + 1, obj }, 0, { } }
69#define DEF_SGET(opcode, reg, field_info) \
70 { opcode, 0u, field_info, 0, { }, 1, { reg } }
71#define DEF_SGET_WIDE(opcode, reg, field_info) \
72 { opcode, 0u, field_info, 0, { }, 2, { reg, reg + 1 } }
73#define DEF_SPUT(opcode, reg, field_info) \
74 { opcode, 0u, field_info, 1, { reg }, 0, { } }
75#define DEF_SPUT_WIDE(opcode, reg, field_info) \
76 { opcode, 0u, field_info, 2, { reg, reg + 1 }, 0, { } }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010077#define DEF_AGET(opcode, reg, obj, idx) \
78 { opcode, 0u, 0u, 2, { obj, idx }, 1, { reg } }
79#define DEF_AGET_WIDE(opcode, reg, obj, idx) \
80 { opcode, 0u, 0u, 2, { obj, idx }, 2, { reg, reg + 1 } }
81#define DEF_APUT(opcode, reg, obj, idx) \
82 { opcode, 0u, 0u, 3, { reg, obj, idx }, 0, { } }
83#define DEF_APUT_WIDE(opcode, reg, obj, idx) \
84 { opcode, 0u, 0u, 4, { reg, reg + 1, obj, idx }, 0, { } }
Vladimir Markof59f18b2014-02-17 15:53:57 +000085#define DEF_INVOKE1(opcode, reg) \
86 { opcode, 0u, 0u, 1, { reg }, 0, { } }
87#define DEF_UNIQUE_REF(opcode, reg) \
88 { opcode, 0u, 0u, 0, { }, 1, { reg } } // CONST_CLASS, CONST_STRING, NEW_ARRAY, ...
Razvan A Lupusorue0951142014-11-14 14:36:55 -080089#define DEF_DIV_REM(opcode, result, dividend, divisor) \
90 { opcode, 0u, 0u, 2, { dividend, divisor }, 1, { result } }
91#define DEF_DIV_REM_WIDE(opcode, result, dividend, divisor) \
92 { opcode, 0u, 0u, 4, { dividend, dividend + 1, divisor, divisor + 1 }, 2, { result, result + 1 } }
Vladimir Markof59f18b2014-02-17 15:53:57 +000093
94 void DoPrepareIFields(const IFieldDef* defs, size_t count) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010095 cu_.mir_graph->ifield_lowering_infos_.clear();
96 cu_.mir_graph->ifield_lowering_infos_.reserve(count);
Vladimir Markobe0e5462014-02-26 11:24:15 +000097 for (size_t i = 0u; i != count; ++i) {
98 const IFieldDef* def = &defs[i];
Nicolas Geoffraya5ca8882015-02-24 08:10:57 +000099 MirIFieldLoweringInfo field_info(def->field_idx, def->type);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000100 if (def->declaring_dex_file != 0u) {
101 field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file);
102 field_info.declaring_field_idx_ = def->declaring_field_idx;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000103 field_info.flags_ &= ~(def->is_volatile ? 0u : MirSFieldLoweringInfo::kFlagIsVolatile);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000104 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100105 cu_.mir_graph->ifield_lowering_infos_.push_back(field_info);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000106 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000107 }
108
109 template <size_t count>
110 void PrepareIFields(const IFieldDef (&defs)[count]) {
111 DoPrepareIFields(defs, count);
112 }
113
114 void DoPrepareSFields(const SFieldDef* defs, size_t count) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100115 cu_.mir_graph->sfield_lowering_infos_.clear();
116 cu_.mir_graph->sfield_lowering_infos_.reserve(count);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000117 for (size_t i = 0u; i != count; ++i) {
118 const SFieldDef* def = &defs[i];
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000119 MirSFieldLoweringInfo field_info(def->field_idx, def->type);
Vladimir Markof418f322014-07-09 14:45:36 +0100120 // Mark even unresolved fields as initialized.
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000121 field_info.flags_ |= MirSFieldLoweringInfo::kFlagClassIsInitialized;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100122 // NOTE: MirSFieldLoweringInfo::kFlagClassIsInDexCache isn't used by LVN.
Vladimir Markobe0e5462014-02-26 11:24:15 +0000123 if (def->declaring_dex_file != 0u) {
124 field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file);
125 field_info.declaring_field_idx_ = def->declaring_field_idx;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000126 field_info.flags_ &= ~(def->is_volatile ? 0u : MirSFieldLoweringInfo::kFlagIsVolatile);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000127 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100128 cu_.mir_graph->sfield_lowering_infos_.push_back(field_info);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000129 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000130 }
131
132 template <size_t count>
133 void PrepareSFields(const SFieldDef (&defs)[count]) {
134 DoPrepareSFields(defs, count);
135 }
136
137 void DoPrepareMIRs(const MIRDef* defs, size_t count) {
138 mir_count_ = count;
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000139 mirs_ = cu_.arena.AllocArray<MIR>(count, kArenaAllocMIR);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000140 ssa_reps_.resize(count);
141 for (size_t i = 0u; i != count; ++i) {
142 const MIRDef* def = &defs[i];
143 MIR* mir = &mirs_[i];
144 mir->dalvikInsn.opcode = def->opcode;
145 mir->dalvikInsn.vB = static_cast<int32_t>(def->value);
146 mir->dalvikInsn.vB_wide = def->value;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000147 if (IsInstructionIGetOrIPut(def->opcode)) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100148 ASSERT_LT(def->field_info, cu_.mir_graph->ifield_lowering_infos_.size());
Vladimir Markobe0e5462014-02-26 11:24:15 +0000149 mir->meta.ifield_lowering_info = def->field_info;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000150 ASSERT_EQ(cu_.mir_graph->ifield_lowering_infos_[def->field_info].MemAccessType(),
151 IGetOrIPutMemAccessType(def->opcode));
152 } else if (IsInstructionSGetOrSPut(def->opcode)) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100153 ASSERT_LT(def->field_info, cu_.mir_graph->sfield_lowering_infos_.size());
Vladimir Markobe0e5462014-02-26 11:24:15 +0000154 mir->meta.sfield_lowering_info = def->field_info;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000155 ASSERT_EQ(cu_.mir_graph->sfield_lowering_infos_[def->field_info].MemAccessType(),
156 SGetOrSPutMemAccessType(def->opcode));
Vladimir Markobe0e5462014-02-26 11:24:15 +0000157 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000158 mir->ssa_rep = &ssa_reps_[i];
159 mir->ssa_rep->num_uses = def->num_uses;
160 mir->ssa_rep->uses = const_cast<int32_t*>(def->uses); // Not modified by LVN.
161 mir->ssa_rep->fp_use = nullptr; // Not used by LVN.
162 mir->ssa_rep->num_defs = def->num_defs;
163 mir->ssa_rep->defs = const_cast<int32_t*>(def->defs); // Not modified by LVN.
164 mir->ssa_rep->fp_def = nullptr; // Not used by LVN.
165 mir->dalvikInsn.opcode = def->opcode;
166 mir->offset = i; // LVN uses offset only for debug output
Vladimir Markof59f18b2014-02-17 15:53:57 +0000167 mir->optimization_flags = 0u;
168
169 if (i != 0u) {
170 mirs_[i - 1u].next = mir;
171 }
172 }
173 mirs_[count - 1u].next = nullptr;
174 }
175
176 template <size_t count>
177 void PrepareMIRs(const MIRDef (&defs)[count]) {
178 DoPrepareMIRs(defs, count);
179 }
180
Vladimir Markof418f322014-07-09 14:45:36 +0100181 void MakeSFieldUninitialized(uint32_t sfield_index) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100182 CHECK_LT(sfield_index, cu_.mir_graph->sfield_lowering_infos_.size());
183 cu_.mir_graph->sfield_lowering_infos_[sfield_index].flags_ &=
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100184 ~MirSFieldLoweringInfo::kFlagClassIsInitialized;
Vladimir Markof418f322014-07-09 14:45:36 +0100185 }
186
Vladimir Markof59f18b2014-02-17 15:53:57 +0000187 void PerformLVN() {
Vladimir Marko7a01dc22015-01-02 17:00:44 +0000188 cu_.mir_graph->temp_.gvn.ifield_ids = GlobalValueNumbering::PrepareGvnFieldIds(
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000189 allocator_.get(), cu_.mir_graph->ifield_lowering_infos_);
Vladimir Marko7a01dc22015-01-02 17:00:44 +0000190 cu_.mir_graph->temp_.gvn.sfield_ids = GlobalValueNumbering::PrepareGvnFieldIds(
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000191 allocator_.get(), cu_.mir_graph->sfield_lowering_infos_);
192 gvn_.reset(new (allocator_.get()) GlobalValueNumbering(&cu_, allocator_.get(),
193 GlobalValueNumbering::kModeLvn));
194 lvn_.reset(new (allocator_.get()) LocalValueNumbering(gvn_.get(), 0u, allocator_.get()));
Vladimir Markof59f18b2014-02-17 15:53:57 +0000195 value_names_.resize(mir_count_);
196 for (size_t i = 0; i != mir_count_; ++i) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000197 value_names_[i] = lvn_->GetValueNumber(&mirs_[i]);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000198 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100199 EXPECT_TRUE(gvn_->Good());
Vladimir Markof59f18b2014-02-17 15:53:57 +0000200 }
201
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000202 LocalValueNumberingTest()
203 : pool_(),
Andreas Gampe0b9203e2015-01-22 20:39:27 -0800204 cu_(&pool_, kRuntimeISA, nullptr, nullptr),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000205 mir_count_(0u),
206 mirs_(nullptr),
Vladimir Marko95a05972014-05-30 10:01:32 +0100207 ssa_reps_(),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100208 allocator_(),
Vladimir Marko95a05972014-05-30 10:01:32 +0100209 gvn_(),
210 lvn_(),
211 value_names_() {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000212 cu_.mir_graph.reset(new MIRGraph(&cu_, &cu_.arena));
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100213 allocator_.reset(ScopedArenaAllocator::Create(&cu_.arena_stack));
Vladimir Marko7a01dc22015-01-02 17:00:44 +0000214 // By default, the zero-initialized reg_location_[.] with ref == false tells LVN that
215 // 0 constants are integral, not references. Nothing else is used by LVN/GVN.
216 cu_.mir_graph->reg_location_ = static_cast<RegLocation*>(cu_.arena.Alloc(
217 kMaxSsaRegs * sizeof(cu_.mir_graph->reg_location_[0]), kArenaAllocRegAlloc));
Vladimir Markof59f18b2014-02-17 15:53:57 +0000218 }
219
Vladimir Marko7a01dc22015-01-02 17:00:44 +0000220 static constexpr size_t kMaxSsaRegs = 16384u;
221
Vladimir Markof59f18b2014-02-17 15:53:57 +0000222 ArenaPool pool_;
223 CompilationUnit cu_;
224 size_t mir_count_;
225 MIR* mirs_;
226 std::vector<SSARepresentation> ssa_reps_;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100227 std::unique_ptr<ScopedArenaAllocator> allocator_;
Vladimir Marko95a05972014-05-30 10:01:32 +0100228 std::unique_ptr<GlobalValueNumbering> gvn_;
Ian Rogers700a4022014-05-19 16:49:03 -0700229 std::unique_ptr<LocalValueNumbering> lvn_;
Vladimir Marko95a05972014-05-30 10:01:32 +0100230 std::vector<uint16_t> value_names_;
Vladimir Markof59f18b2014-02-17 15:53:57 +0000231};
232
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100233TEST_F(LocalValueNumberingTest, IGetIGetInvokeIGet) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000234 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000235 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000236 };
237 static const MIRDef mirs[] = {
238 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
239 DEF_IGET(Instruction::IGET, 1u, 10u, 0u),
240 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u),
241 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
242 };
243
244 PrepareIFields(ifields);
245 PrepareMIRs(mirs);
246 PerformLVN();
247 ASSERT_EQ(value_names_.size(), 4u);
248 EXPECT_EQ(value_names_[0], value_names_[1]);
249 EXPECT_NE(value_names_[0], value_names_[3]);
250 EXPECT_EQ(mirs_[0].optimization_flags, 0u);
251 EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK);
252 EXPECT_EQ(mirs_[2].optimization_flags, 0u);
253 EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK);
254}
255
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100256TEST_F(LocalValueNumberingTest, IGetIPutIGetIGetIGet) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000257 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000258 { 1u, 1u, 1u, false, kDexMemAccessObject },
259 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000260 };
261 static const MIRDef mirs[] = {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100262 DEF_IGET(Instruction::IGET_OBJECT, 0u, 10u, 0u),
263 DEF_IPUT(Instruction::IPUT_OBJECT, 1u, 11u, 0u), // May alias.
264 DEF_IGET(Instruction::IGET_OBJECT, 2u, 10u, 0u),
Vladimir Markof59f18b2014-02-17 15:53:57 +0000265 DEF_IGET(Instruction::IGET, 3u, 0u, 1u),
266 DEF_IGET(Instruction::IGET, 4u, 2u, 1u),
267 };
268
269 PrepareIFields(ifields);
270 PrepareMIRs(mirs);
271 PerformLVN();
272 ASSERT_EQ(value_names_.size(), 5u);
273 EXPECT_NE(value_names_[0], value_names_[2]);
274 EXPECT_NE(value_names_[3], value_names_[4]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100275 for (size_t i = 0; i != arraysize(mirs); ++i) {
276 EXPECT_EQ((i == 2u) ? MIR_IGNORE_NULL_CHECK : 0,
277 mirs_[i].optimization_flags) << i;
278 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000279}
280
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100281TEST_F(LocalValueNumberingTest, UniquePreserve1) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000282 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000283 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000284 };
285 static const MIRDef mirs[] = {
286 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u),
287 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
288 DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 10u is unique.
289 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
290 };
291
292 PrepareIFields(ifields);
293 PrepareMIRs(mirs);
294 PerformLVN();
295 ASSERT_EQ(value_names_.size(), 4u);
296 EXPECT_EQ(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100297 for (size_t i = 0; i != arraysize(mirs); ++i) {
298 EXPECT_EQ((i == 1u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0,
299 mirs_[i].optimization_flags) << i;
300 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000301}
302
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100303TEST_F(LocalValueNumberingTest, UniquePreserve2) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000304 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000305 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000306 };
307 static const MIRDef mirs[] = {
308 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 11u),
309 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
310 DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 11u is unique.
311 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
312 };
313
314 PrepareIFields(ifields);
315 PrepareMIRs(mirs);
316 PerformLVN();
317 ASSERT_EQ(value_names_.size(), 4u);
318 EXPECT_EQ(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100319 for (size_t i = 0; i != arraysize(mirs); ++i) {
320 EXPECT_EQ((i == 2u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0,
321 mirs_[i].optimization_flags) << i;
322 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000323}
324
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100325TEST_F(LocalValueNumberingTest, UniquePreserveAndEscape) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000326 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000327 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000328 };
329 static const MIRDef mirs[] = {
330 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u),
331 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
332 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u), // 10u still unique.
333 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
334 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 10u), // 10u not unique anymore.
335 DEF_IGET(Instruction::IGET, 3u, 10u, 0u),
336 };
337
338 PrepareIFields(ifields);
339 PrepareMIRs(mirs);
340 PerformLVN();
341 ASSERT_EQ(value_names_.size(), 6u);
342 EXPECT_EQ(value_names_[1], value_names_[3]);
343 EXPECT_NE(value_names_[1], value_names_[5]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100344 for (size_t i = 0; i != arraysize(mirs); ++i) {
345 EXPECT_EQ((i == 1u || i == 3u || i == 4u || i == 5u) ? MIR_IGNORE_NULL_CHECK : 0,
346 mirs_[i].optimization_flags) << i;
347 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000348}
Vladimir Markof59f18b2014-02-17 15:53:57 +0000349
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100350TEST_F(LocalValueNumberingTest, Volatile) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000351 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000352 { 1u, 1u, 1u, false, kDexMemAccessWord },
353 { 2u, 1u, 2u, true, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000354 };
355 static const MIRDef mirs[] = {
356 DEF_IGET(Instruction::IGET, 0u, 10u, 1u), // Volatile.
357 DEF_IGET(Instruction::IGET, 1u, 0u, 0u), // Non-volatile.
358 DEF_IGET(Instruction::IGET, 2u, 10u, 1u), // Volatile.
359 DEF_IGET(Instruction::IGET, 3u, 2u, 1u), // Non-volatile.
Vladimir Markofa236452014-09-29 17:58:10 +0100360 DEF_IGET(Instruction::IGET, 4u, 0u, 0u), // Non-volatile.
Vladimir Markof59f18b2014-02-17 15:53:57 +0000361 };
362
363 PrepareIFields(ifields);
364 PrepareMIRs(mirs);
365 PerformLVN();
Vladimir Markofa236452014-09-29 17:58:10 +0100366 ASSERT_EQ(value_names_.size(), 5u);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000367 EXPECT_NE(value_names_[0], value_names_[2]); // Volatile has always different value name.
368 EXPECT_NE(value_names_[1], value_names_[3]); // Used different base because of volatile.
Vladimir Markofa236452014-09-29 17:58:10 +0100369 EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire".
370
Vladimir Marko95a05972014-05-30 10:01:32 +0100371 for (size_t i = 0; i != arraysize(mirs); ++i) {
Vladimir Markofa236452014-09-29 17:58:10 +0100372 EXPECT_EQ((i == 2u || i == 4u) ? MIR_IGNORE_NULL_CHECK : 0,
Vladimir Marko95a05972014-05-30 10:01:32 +0100373 mirs_[i].optimization_flags) << i;
374 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000375}
376
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100377TEST_F(LocalValueNumberingTest, UnresolvedIField) {
378 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000379 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
380 { 2u, 1u, 2u, false, kDexMemAccessWide }, // Resolved field #2.
381 { 3u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100382 };
383 static const MIRDef mirs[] = {
384 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u),
385 DEF_IGET(Instruction::IGET, 1u, 20u, 0u), // Resolved field #1, unique object.
386 DEF_IGET(Instruction::IGET, 2u, 21u, 0u), // Resolved field #1.
387 DEF_IGET_WIDE(Instruction::IGET_WIDE, 3u, 21u, 1u), // Resolved field #2.
Vladimir Markofa236452014-09-29 17:58:10 +0100388 DEF_IGET(Instruction::IGET, 4u, 22u, 2u), // Unresolved IGET can be "acquire".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100389 DEF_IGET(Instruction::IGET, 5u, 20u, 0u), // Resolved field #1, unique object.
390 DEF_IGET(Instruction::IGET, 6u, 21u, 0u), // Resolved field #1.
391 DEF_IGET_WIDE(Instruction::IGET_WIDE, 7u, 21u, 1u), // Resolved field #2.
Vladimir Marko95a05972014-05-30 10:01:32 +0100392 DEF_IPUT(Instruction::IPUT, 8u, 22u, 2u), // IPUT clobbers field #1 (#2 is wide).
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100393 DEF_IGET(Instruction::IGET, 9u, 20u, 0u), // Resolved field #1, unique object.
394 DEF_IGET(Instruction::IGET, 10u, 21u, 0u), // Resolved field #1, new value name.
395 DEF_IGET_WIDE(Instruction::IGET_WIDE, 11u, 21u, 1u), // Resolved field #2.
Vladimir Marko95a05972014-05-30 10:01:32 +0100396 DEF_IGET_WIDE(Instruction::IGET_WIDE, 12u, 20u, 1u), // Resolved field #2, unique object.
397 DEF_IPUT(Instruction::IPUT, 13u, 20u, 2u), // IPUT clobbers field #1 (#2 is wide).
398 DEF_IGET(Instruction::IGET, 14u, 20u, 0u), // Resolved field #1, unique object.
399 DEF_IGET_WIDE(Instruction::IGET_WIDE, 15u, 20u, 1u), // Resolved field #2, unique object.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100400 };
401
402 PrepareIFields(ifields);
403 PrepareMIRs(mirs);
404 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100405 ASSERT_EQ(value_names_.size(), 16u);
Vladimir Markofa236452014-09-29 17:58:10 +0100406 // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics.
407 EXPECT_EQ(value_names_[1], value_names_[5]); // Unique object.
408 EXPECT_NE(value_names_[2], value_names_[6]); // Not guaranteed to be the same after "acquire".
409 EXPECT_NE(value_names_[3], value_names_[7]); // Not guaranteed to be the same after "acquire".
410 EXPECT_EQ(value_names_[1], value_names_[9]); // Unique object.
411 EXPECT_NE(value_names_[6], value_names_[10]); // This aliased with unresolved IPUT.
412 EXPECT_EQ(value_names_[7], value_names_[11]); // Still the same after "release".
413 EXPECT_EQ(value_names_[12], value_names_[15]); // Still the same after "release".
414 EXPECT_NE(value_names_[1], value_names_[14]); // This aliased with unresolved IPUT.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100415 EXPECT_EQ(mirs_[0].optimization_flags, 0u);
416 EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK);
417 EXPECT_EQ(mirs_[2].optimization_flags, 0u);
418 EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK);
419 EXPECT_EQ(mirs_[4].optimization_flags, 0u);
420 for (size_t i = 5u; i != mir_count_; ++i) {
Vladimir Marko95a05972014-05-30 10:01:32 +0100421 EXPECT_EQ((i == 1u || i == 3u || i >=5u) ? MIR_IGNORE_NULL_CHECK : 0,
422 mirs_[i].optimization_flags) << i;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100423 }
424}
425
426TEST_F(LocalValueNumberingTest, UnresolvedSField) {
427 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000428 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
429 { 2u, 1u, 2u, false, kDexMemAccessWide }, // Resolved field #2.
430 { 3u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100431 };
432 static const MIRDef mirs[] = {
433 DEF_SGET(Instruction::SGET, 0u, 0u), // Resolved field #1.
434 DEF_SGET_WIDE(Instruction::SGET_WIDE, 1u, 1u), // Resolved field #2.
Vladimir Markofa236452014-09-29 17:58:10 +0100435 DEF_SGET(Instruction::SGET, 2u, 2u), // Unresolved SGET can be "acquire".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100436 DEF_SGET(Instruction::SGET, 3u, 0u), // Resolved field #1.
437 DEF_SGET_WIDE(Instruction::SGET_WIDE, 4u, 1u), // Resolved field #2.
438 DEF_SPUT(Instruction::SPUT, 5u, 2u), // SPUT clobbers field #1 (#2 is wide).
439 DEF_SGET(Instruction::SGET, 6u, 0u), // Resolved field #1.
440 DEF_SGET_WIDE(Instruction::SGET_WIDE, 7u, 1u), // Resolved field #2.
441 };
442
443 PrepareSFields(sfields);
444 PrepareMIRs(mirs);
445 PerformLVN();
446 ASSERT_EQ(value_names_.size(), 8u);
Vladimir Markofa236452014-09-29 17:58:10 +0100447 // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics.
448 EXPECT_NE(value_names_[0], value_names_[3]); // Not guaranteed to be the same after "acquire".
449 EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire".
450 EXPECT_NE(value_names_[3], value_names_[6]); // This aliased with unresolved IPUT.
451 EXPECT_EQ(value_names_[4], value_names_[7]); // Still the same after "release".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100452 for (size_t i = 0u; i != mir_count_; ++i) {
Vladimir Marko95a05972014-05-30 10:01:32 +0100453 EXPECT_EQ(0, mirs_[i].optimization_flags) << i;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100454 }
455}
456
Vladimir Marko95a05972014-05-30 10:01:32 +0100457TEST_F(LocalValueNumberingTest, UninitializedSField) {
458 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000459 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
Vladimir Marko95a05972014-05-30 10:01:32 +0100460 };
461 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000462 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
463 { 2u, 1u, 2u, false, kDexMemAccessWord }, // Resolved field #2; uninitialized.
Vladimir Marko95a05972014-05-30 10:01:32 +0100464 };
465 static const MIRDef mirs[] = {
466 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 200u),
467 DEF_IGET(Instruction::IGET, 1u, 100u, 0u),
468 DEF_IGET(Instruction::IGET, 2u, 200u, 0u),
469 DEF_SGET(Instruction::SGET, 3u, 0u),
470 DEF_SGET(Instruction::SGET, 4u, 1u), // Can call <clinit>().
471 DEF_IGET(Instruction::IGET, 5u, 100u, 0u), // Differs from 1u.
472 DEF_IGET(Instruction::IGET, 6u, 200u, 0u), // Same as 2u.
473 DEF_SGET(Instruction::SGET, 7u, 0u), // Differs from 3u.
474 };
475
476 PrepareIFields(ifields);
477 PrepareSFields(sfields);
478 MakeSFieldUninitialized(1u);
479 PrepareMIRs(mirs);
480 PerformLVN();
481 ASSERT_EQ(value_names_.size(), 8u);
482 EXPECT_NE(value_names_[1], value_names_[5]);
483 EXPECT_EQ(value_names_[2], value_names_[6]);
484 EXPECT_NE(value_names_[3], value_names_[7]);
485}
486
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100487TEST_F(LocalValueNumberingTest, ConstString) {
488 static const MIRDef mirs[] = {
489 DEF_CONST_STRING(Instruction::CONST_STRING, 0u, 0u),
490 DEF_CONST_STRING(Instruction::CONST_STRING, 1u, 0u),
491 DEF_CONST_STRING(Instruction::CONST_STRING, 2u, 2u),
492 DEF_CONST_STRING(Instruction::CONST_STRING, 3u, 0u),
493 DEF_INVOKE1(Instruction::INVOKE_DIRECT, 2u),
494 DEF_CONST_STRING(Instruction::CONST_STRING, 4u, 2u),
495 };
496
497 PrepareMIRs(mirs);
498 PerformLVN();
499 ASSERT_EQ(value_names_.size(), 6u);
500 EXPECT_EQ(value_names_[1], value_names_[0]);
501 EXPECT_NE(value_names_[2], value_names_[0]);
502 EXPECT_EQ(value_names_[3], value_names_[0]);
503 EXPECT_EQ(value_names_[5], value_names_[2]);
504}
505
506TEST_F(LocalValueNumberingTest, SameValueInDifferentMemoryLocations) {
507 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000508 { 1u, 1u, 1u, false, kDexMemAccessWord },
509 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100510 };
511 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000512 { 3u, 1u, 3u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100513 };
514 static const MIRDef mirs[] = {
Vladimir Marko95a05972014-05-30 10:01:32 +0100515 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 201u),
516 DEF_IGET(Instruction::IGET, 0u, 100u, 0u),
517 DEF_IPUT(Instruction::IPUT, 0u, 100u, 1u),
518 DEF_IPUT(Instruction::IPUT, 0u, 101u, 1u),
519 DEF_APUT(Instruction::APUT, 0u, 200u, 300u),
520 DEF_APUT(Instruction::APUT, 0u, 200u, 301u),
521 DEF_APUT(Instruction::APUT, 0u, 201u, 300u),
522 DEF_APUT(Instruction::APUT, 0u, 201u, 301u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100523 DEF_SPUT(Instruction::SPUT, 0u, 0u),
Vladimir Marko95a05972014-05-30 10:01:32 +0100524 DEF_IGET(Instruction::IGET, 9u, 100u, 0u),
525 DEF_IGET(Instruction::IGET, 10u, 100u, 1u),
526 DEF_IGET(Instruction::IGET, 11u, 101u, 1u),
527 DEF_AGET(Instruction::AGET, 12u, 200u, 300u),
528 DEF_AGET(Instruction::AGET, 13u, 200u, 301u),
529 DEF_AGET(Instruction::AGET, 14u, 201u, 300u),
530 DEF_AGET(Instruction::AGET, 15u, 201u, 301u),
531 DEF_SGET(Instruction::SGET, 16u, 0u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100532 };
533
534 PrepareIFields(ifields);
535 PrepareSFields(sfields);
536 PrepareMIRs(mirs);
537 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100538 ASSERT_EQ(value_names_.size(), 17u);
539 for (size_t i = 9; i != arraysize(mirs); ++i) {
540 EXPECT_EQ(value_names_[1], value_names_[i]) << i;
541 }
542 for (size_t i = 0; i != arraysize(mirs); ++i) {
543 int expected_flags =
544 ((i == 2u || (i >= 5u && i <= 7u) || (i >= 9u && i <= 15u)) ? MIR_IGNORE_NULL_CHECK : 0) |
545 ((i >= 12u && i <= 15u) ? MIR_IGNORE_RANGE_CHECK : 0);
546 EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i;
547 }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100548}
549
550TEST_F(LocalValueNumberingTest, UniqueArrayAliasing) {
551 static const MIRDef mirs[] = {
552 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u),
553 DEF_AGET(Instruction::AGET, 1u, 20u, 40u),
554 DEF_APUT(Instruction::APUT, 2u, 20u, 41u), // May alias with index for sreg 40u.
555 DEF_AGET(Instruction::AGET, 3u, 20u, 40u),
556 };
557
558 PrepareMIRs(mirs);
559 PerformLVN();
560 ASSERT_EQ(value_names_.size(), 4u);
561 EXPECT_NE(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100562 for (size_t i = 0; i != arraysize(mirs); ++i) {
563 int expected_flags =
564 ((i >= 1u) ? MIR_IGNORE_NULL_CHECK : 0) |
565 ((i == 3u) ? MIR_IGNORE_RANGE_CHECK : 0);
566 EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i;
567 }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100568}
569
570TEST_F(LocalValueNumberingTest, EscapingRefs) {
571 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000572 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Field #1.
573 { 2u, 1u, 2u, false, kDexMemAccessWord }, // Field #2.
574 { 3u, 1u, 3u, false, kDexMemAccessObject }, // For storing escaping refs.
575 { 4u, 1u, 4u, false, kDexMemAccessWide }, // Wide.
576 { 5u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field, int.
577 { 6u, 0u, 0u, false, kDexMemAccessWide }, // Unresolved field, wide.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100578 };
579 static const MIRDef mirs[] = {
580 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u),
581 DEF_IGET(Instruction::IGET, 1u, 20u, 0u),
582 DEF_IGET(Instruction::IGET, 2u, 20u, 1u),
583 DEF_IPUT(Instruction::IPUT_OBJECT, 20u, 30u, 2u), // Ref escapes.
584 DEF_IGET(Instruction::IGET, 4u, 20u, 0u),
585 DEF_IGET(Instruction::IGET, 5u, 20u, 1u),
586 DEF_IPUT(Instruction::IPUT, 6u, 31u, 0u), // May alias with field #1.
587 DEF_IGET(Instruction::IGET, 7u, 20u, 0u), // New value.
588 DEF_IGET(Instruction::IGET, 8u, 20u, 1u), // Still the same.
589 DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 9u, 31u, 3u), // No aliasing, different type.
590 DEF_IGET(Instruction::IGET, 10u, 20u, 0u),
591 DEF_IGET(Instruction::IGET, 11u, 20u, 1u),
592 DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 12u, 31u, 5u), // No aliasing, different type.
593 DEF_IGET(Instruction::IGET, 13u, 20u, 0u),
594 DEF_IGET(Instruction::IGET, 14u, 20u, 1u),
595 DEF_IPUT(Instruction::IPUT, 15u, 31u, 4u), // Aliasing, same type.
596 DEF_IGET(Instruction::IGET, 16u, 20u, 0u),
597 DEF_IGET(Instruction::IGET, 17u, 20u, 1u),
598 };
599
600 PrepareIFields(ifields);
601 PrepareMIRs(mirs);
602 PerformLVN();
603 ASSERT_EQ(value_names_.size(), 18u);
604 EXPECT_EQ(value_names_[1], value_names_[4]);
605 EXPECT_EQ(value_names_[2], value_names_[5]);
606 EXPECT_NE(value_names_[4], value_names_[7]); // New value.
607 EXPECT_EQ(value_names_[5], value_names_[8]);
608 EXPECT_EQ(value_names_[7], value_names_[10]);
609 EXPECT_EQ(value_names_[8], value_names_[11]);
610 EXPECT_EQ(value_names_[10], value_names_[13]);
611 EXPECT_EQ(value_names_[11], value_names_[14]);
612 EXPECT_NE(value_names_[13], value_names_[16]); // New value.
613 EXPECT_NE(value_names_[14], value_names_[17]); // New value.
614 for (size_t i = 0u; i != mir_count_; ++i) {
Vladimir Marko743b98c2014-11-24 19:45:41 +0000615 int expected =
616 ((i != 0u && i != 3u && i != 6u) ? MIR_IGNORE_NULL_CHECK : 0) |
617 ((i == 3u) ? MIR_STORE_NON_NULL_VALUE: 0);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100618 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
619 }
620}
621
622TEST_F(LocalValueNumberingTest, EscapingArrayRefs) {
623 static const MIRDef mirs[] = {
624 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u),
625 DEF_AGET(Instruction::AGET, 1u, 20u, 40u),
626 DEF_AGET(Instruction::AGET, 2u, 20u, 41u),
627 DEF_APUT(Instruction::APUT_OBJECT, 20u, 30u, 42u), // Array ref escapes.
628 DEF_AGET(Instruction::AGET, 4u, 20u, 40u),
629 DEF_AGET(Instruction::AGET, 5u, 20u, 41u),
630 DEF_APUT_WIDE(Instruction::APUT_WIDE, 6u, 31u, 43u), // No aliasing, different type.
631 DEF_AGET(Instruction::AGET, 7u, 20u, 40u),
632 DEF_AGET(Instruction::AGET, 8u, 20u, 41u),
633 DEF_APUT(Instruction::APUT, 9u, 32u, 40u), // May alias with all elements.
634 DEF_AGET(Instruction::AGET, 10u, 20u, 40u), // New value (same index name).
635 DEF_AGET(Instruction::AGET, 11u, 20u, 41u), // New value (different index name).
636 };
637
638 PrepareMIRs(mirs);
639 PerformLVN();
640 ASSERT_EQ(value_names_.size(), 12u);
641 EXPECT_EQ(value_names_[1], value_names_[4]);
642 EXPECT_EQ(value_names_[2], value_names_[5]);
643 EXPECT_EQ(value_names_[4], value_names_[7]);
644 EXPECT_EQ(value_names_[5], value_names_[8]);
645 EXPECT_NE(value_names_[7], value_names_[10]); // New value.
646 EXPECT_NE(value_names_[8], value_names_[11]); // New value.
647 for (size_t i = 0u; i != mir_count_; ++i) {
648 int expected =
649 ((i != 0u && i != 3u && i != 6u && i != 9u) ? MIR_IGNORE_NULL_CHECK : 0u) |
Vladimir Marko743b98c2014-11-24 19:45:41 +0000650 ((i >= 4 && i != 6u && i != 9u) ? MIR_IGNORE_RANGE_CHECK : 0u) |
651 ((i == 3u) ? MIR_STORE_NON_NULL_VALUE: 0);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100652 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
653 }
654}
655
656TEST_F(LocalValueNumberingTest, StoringSameValueKeepsMemoryVersion) {
657 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000658 { 1u, 1u, 1u, false, kDexMemAccessWord },
659 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko95a05972014-05-30 10:01:32 +0100660 };
661 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000662 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100663 };
664 static const MIRDef mirs[] = {
Vladimir Marko95a05972014-05-30 10:01:32 +0100665 DEF_IGET(Instruction::IGET, 0u, 30u, 0u),
666 DEF_IGET(Instruction::IGET, 1u, 31u, 0u),
667 DEF_IPUT(Instruction::IPUT, 1u, 31u, 0u), // Store the same value.
668 DEF_IGET(Instruction::IGET, 3u, 30u, 0u),
669 DEF_AGET(Instruction::AGET, 4u, 32u, 40u),
670 DEF_AGET(Instruction::AGET, 5u, 33u, 40u),
671 DEF_APUT(Instruction::APUT, 5u, 33u, 40u), // Store the same value.
672 DEF_AGET(Instruction::AGET, 7u, 32u, 40u),
673 DEF_SGET(Instruction::SGET, 8u, 0u),
674 DEF_SPUT(Instruction::SPUT, 8u, 0u), // Store the same value.
675 DEF_SGET(Instruction::SGET, 10u, 0u),
676 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 50u), // Test with unique references.
677 { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 12u, 13u }, 0, { } },
678 DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 51u),
679 DEF_IGET(Instruction::IGET, 14u, 50u, 0u),
680 DEF_IGET(Instruction::IGET, 15u, 50u, 1u),
681 DEF_IPUT(Instruction::IPUT, 15u, 50u, 1u), // Store the same value.
682 DEF_IGET(Instruction::IGET, 17u, 50u, 0u),
683 DEF_AGET(Instruction::AGET, 18u, 51u, 40u),
684 DEF_AGET(Instruction::AGET, 19u, 51u, 41u),
685 DEF_APUT(Instruction::APUT, 19u, 51u, 41u), // Store the same value.
686 DEF_AGET(Instruction::AGET, 21u, 51u, 40u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100687 };
688
689 PrepareIFields(ifields);
Vladimir Marko95a05972014-05-30 10:01:32 +0100690 PrepareSFields(sfields);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100691 PrepareMIRs(mirs);
692 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100693 ASSERT_EQ(value_names_.size(), 22u);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100694 EXPECT_NE(value_names_[0], value_names_[1]);
695 EXPECT_EQ(value_names_[0], value_names_[3]);
696 EXPECT_NE(value_names_[4], value_names_[5]);
697 EXPECT_EQ(value_names_[4], value_names_[7]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100698 EXPECT_EQ(value_names_[8], value_names_[10]);
699 EXPECT_NE(value_names_[14], value_names_[15]);
700 EXPECT_EQ(value_names_[14], value_names_[17]);
701 EXPECT_NE(value_names_[18], value_names_[19]);
702 EXPECT_EQ(value_names_[18], value_names_[21]);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100703 for (size_t i = 0u; i != mir_count_; ++i) {
704 int expected =
Vladimir Marko95a05972014-05-30 10:01:32 +0100705 ((i == 2u || i == 3u || i == 6u || i == 7u || (i >= 14u)) ? MIR_IGNORE_NULL_CHECK : 0u) |
706 ((i == 6u || i == 7u || i >= 20u) ? MIR_IGNORE_RANGE_CHECK : 0u);
707 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
708 }
709}
710
711TEST_F(LocalValueNumberingTest, FilledNewArrayTracking) {
712 if (!kLocalValueNumberingEnableFilledNewArrayTracking) {
713 // Feature disabled.
714 return;
715 }
716 static const MIRDef mirs[] = {
717 DEF_CONST(Instruction::CONST, 0u, 100),
718 DEF_CONST(Instruction::CONST, 1u, 200),
719 { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 0u, 1u }, 0, { } },
720 DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 10u),
721 DEF_CONST(Instruction::CONST, 20u, 0),
722 DEF_CONST(Instruction::CONST, 21u, 1),
723 DEF_AGET(Instruction::AGET, 6u, 10u, 20u),
724 DEF_AGET(Instruction::AGET, 7u, 10u, 21u),
725 };
726
727 PrepareMIRs(mirs);
728 PerformLVN();
729 ASSERT_EQ(value_names_.size(), 8u);
730 EXPECT_EQ(value_names_[0], value_names_[6]);
731 EXPECT_EQ(value_names_[1], value_names_[7]);
732 for (size_t i = 0u; i != mir_count_; ++i) {
733 int expected = (i == 6u || i == 7u) ? (MIR_IGNORE_NULL_CHECK | MIR_IGNORE_RANGE_CHECK) : 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100734 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
735 }
736}
737
Vladimir Markof418f322014-07-09 14:45:36 +0100738TEST_F(LocalValueNumberingTest, ClInitOnSget) {
739 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000740 { 0u, 1u, 0u, false, kDexMemAccessObject },
741 { 1u, 2u, 1u, false, kDexMemAccessObject },
Vladimir Markof418f322014-07-09 14:45:36 +0100742 };
743 static const MIRDef mirs[] = {
744 DEF_SGET(Instruction::SGET_OBJECT, 0u, 0u),
745 DEF_AGET(Instruction::AGET, 1u, 0u, 100u),
746 DEF_SGET(Instruction::SGET_OBJECT, 2u, 1u),
747 DEF_SGET(Instruction::SGET_OBJECT, 3u, 0u),
748 DEF_AGET(Instruction::AGET, 4u, 3u, 100u),
749 };
750
751 PrepareSFields(sfields);
752 MakeSFieldUninitialized(1u);
753 PrepareMIRs(mirs);
754 PerformLVN();
755 ASSERT_EQ(value_names_.size(), 5u);
756 EXPECT_NE(value_names_[0], value_names_[3]);
757}
758
Razvan A Lupusorue0951142014-11-14 14:36:55 -0800759TEST_F(LocalValueNumberingTest, DivZeroCheck) {
760 static const MIRDef mirs[] = {
761 DEF_DIV_REM(Instruction::DIV_INT, 1u, 10u, 20u),
762 DEF_DIV_REM(Instruction::DIV_INT, 2u, 20u, 20u),
763 DEF_DIV_REM(Instruction::DIV_INT_2ADDR, 3u, 10u, 1u),
764 DEF_DIV_REM(Instruction::REM_INT, 4u, 30u, 20u),
765 DEF_DIV_REM_WIDE(Instruction::REM_LONG, 5u, 12u, 14u),
766 DEF_DIV_REM_WIDE(Instruction::DIV_LONG_2ADDR, 7u, 16u, 14u),
767 };
768
769 static const bool expected_ignore_div_zero_check[] = {
770 false, true, false, true, false, true,
771 };
772
773 PrepareMIRs(mirs);
774 PerformLVN();
775 for (size_t i = 0u; i != mir_count_; ++i) {
776 int expected = expected_ignore_div_zero_check[i] ? MIR_IGNORE_DIV_ZERO_CHECK : 0u;
777 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
778 }
779}
780
Vladimir Markod532f002015-02-13 19:47:13 +0000781TEST_F(LocalValueNumberingTest, ConstWide) {
782 static const MIRDef mirs[] = {
Vladimir Marko22c7f5b2015-02-18 17:52:39 +0000783 // Core reg constants.
Vladimir Markod532f002015-02-13 19:47:13 +0000784 DEF_CONST(Instruction::CONST_WIDE_16, 0u, 0),
785 DEF_CONST(Instruction::CONST_WIDE_16, 1u, 1),
786 DEF_CONST(Instruction::CONST_WIDE_16, 2u, -1),
787 DEF_CONST(Instruction::CONST_WIDE_32, 3u, 1 << 16),
788 DEF_CONST(Instruction::CONST_WIDE_32, 4u, -1 << 16),
789 DEF_CONST(Instruction::CONST_WIDE_32, 5u, (1 << 16) + 1),
790 DEF_CONST(Instruction::CONST_WIDE_32, 6u, (1 << 16) - 1),
791 DEF_CONST(Instruction::CONST_WIDE_32, 7u, -(1 << 16) + 1),
792 DEF_CONST(Instruction::CONST_WIDE_32, 8u, -(1 << 16) - 1),
793 DEF_CONST(Instruction::CONST_WIDE, 9u, INT64_C(1) << 32),
794 DEF_CONST(Instruction::CONST_WIDE, 10u, INT64_C(-1) << 32),
795 DEF_CONST(Instruction::CONST_WIDE, 11u, (INT64_C(1) << 32) + 1),
796 DEF_CONST(Instruction::CONST_WIDE, 12u, (INT64_C(1) << 32) - 1),
797 DEF_CONST(Instruction::CONST_WIDE, 13u, (INT64_C(-1) << 32) + 1),
798 DEF_CONST(Instruction::CONST_WIDE, 14u, (INT64_C(-1) << 32) - 1),
799 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 15u, 1), // Effectively 1 << 48.
800 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 16u, 0xffff), // Effectively -1 << 48.
801 DEF_CONST(Instruction::CONST_WIDE, 17u, (INT64_C(1) << 48) + 1),
802 DEF_CONST(Instruction::CONST_WIDE, 18u, (INT64_C(1) << 48) - 1),
803 DEF_CONST(Instruction::CONST_WIDE, 19u, (INT64_C(-1) << 48) + 1),
804 DEF_CONST(Instruction::CONST_WIDE, 20u, (INT64_C(-1) << 48) - 1),
Vladimir Marko22c7f5b2015-02-18 17:52:39 +0000805 // FP reg constants.
806 DEF_CONST(Instruction::CONST_WIDE_16, 21u, 0),
807 DEF_CONST(Instruction::CONST_WIDE_16, 22u, 1),
808 DEF_CONST(Instruction::CONST_WIDE_16, 23u, -1),
809 DEF_CONST(Instruction::CONST_WIDE_32, 24u, 1 << 16),
810 DEF_CONST(Instruction::CONST_WIDE_32, 25u, -1 << 16),
811 DEF_CONST(Instruction::CONST_WIDE_32, 26u, (1 << 16) + 1),
812 DEF_CONST(Instruction::CONST_WIDE_32, 27u, (1 << 16) - 1),
813 DEF_CONST(Instruction::CONST_WIDE_32, 28u, -(1 << 16) + 1),
814 DEF_CONST(Instruction::CONST_WIDE_32, 29u, -(1 << 16) - 1),
815 DEF_CONST(Instruction::CONST_WIDE, 30u, INT64_C(1) << 32),
816 DEF_CONST(Instruction::CONST_WIDE, 31u, INT64_C(-1) << 32),
817 DEF_CONST(Instruction::CONST_WIDE, 32u, (INT64_C(1) << 32) + 1),
818 DEF_CONST(Instruction::CONST_WIDE, 33u, (INT64_C(1) << 32) - 1),
819 DEF_CONST(Instruction::CONST_WIDE, 34u, (INT64_C(-1) << 32) + 1),
820 DEF_CONST(Instruction::CONST_WIDE, 35u, (INT64_C(-1) << 32) - 1),
821 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 36u, 1), // Effectively 1 << 48.
822 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 37u, 0xffff), // Effectively -1 << 48.
823 DEF_CONST(Instruction::CONST_WIDE, 38u, (INT64_C(1) << 48) + 1),
824 DEF_CONST(Instruction::CONST_WIDE, 39u, (INT64_C(1) << 48) - 1),
825 DEF_CONST(Instruction::CONST_WIDE, 40u, (INT64_C(-1) << 48) + 1),
826 DEF_CONST(Instruction::CONST_WIDE, 41u, (INT64_C(-1) << 48) - 1),
Vladimir Markod532f002015-02-13 19:47:13 +0000827 };
828
829 PrepareMIRs(mirs);
Vladimir Marko22c7f5b2015-02-18 17:52:39 +0000830 for (size_t i = arraysize(mirs) / 2u; i != arraysize(mirs); ++i) {
831 cu_.mir_graph->reg_location_[mirs_[i].ssa_rep->defs[0]].fp = true;
832 }
833 PerformLVN();
834 for (size_t i = 0u; i != mir_count_; ++i) {
835 for (size_t j = i + 1u; j != mir_count_; ++j) {
836 EXPECT_NE(value_names_[i], value_names_[j]) << i << " " << j;
837 }
838 }
839}
840
841TEST_F(LocalValueNumberingTest, Const) {
842 static const MIRDef mirs[] = {
843 // Core reg constants.
844 DEF_CONST(Instruction::CONST_4, 0u, 0),
845 DEF_CONST(Instruction::CONST_4, 1u, 1),
846 DEF_CONST(Instruction::CONST_4, 2u, -1),
847 DEF_CONST(Instruction::CONST_16, 3u, 1 << 4),
848 DEF_CONST(Instruction::CONST_16, 4u, -1 << 4),
849 DEF_CONST(Instruction::CONST_16, 5u, (1 << 4) + 1),
850 DEF_CONST(Instruction::CONST_16, 6u, (1 << 4) - 1),
851 DEF_CONST(Instruction::CONST_16, 7u, -(1 << 4) + 1),
852 DEF_CONST(Instruction::CONST_16, 8u, -(1 << 4) - 1),
853 DEF_CONST(Instruction::CONST_HIGH16, 9u, 1), // Effectively 1 << 16.
854 DEF_CONST(Instruction::CONST_HIGH16, 10u, 0xffff), // Effectively -1 << 16.
855 DEF_CONST(Instruction::CONST, 11u, (1 << 16) + 1),
856 DEF_CONST(Instruction::CONST, 12u, (1 << 16) - 1),
857 DEF_CONST(Instruction::CONST, 13u, (-1 << 16) + 1),
858 DEF_CONST(Instruction::CONST, 14u, (-1 << 16) - 1),
859 // FP reg constants.
860 DEF_CONST(Instruction::CONST_4, 15u, 0),
861 DEF_CONST(Instruction::CONST_4, 16u, 1),
862 DEF_CONST(Instruction::CONST_4, 17u, -1),
863 DEF_CONST(Instruction::CONST_16, 18u, 1 << 4),
864 DEF_CONST(Instruction::CONST_16, 19u, -1 << 4),
865 DEF_CONST(Instruction::CONST_16, 20u, (1 << 4) + 1),
866 DEF_CONST(Instruction::CONST_16, 21u, (1 << 4) - 1),
867 DEF_CONST(Instruction::CONST_16, 22u, -(1 << 4) + 1),
868 DEF_CONST(Instruction::CONST_16, 23u, -(1 << 4) - 1),
869 DEF_CONST(Instruction::CONST_HIGH16, 24u, 1), // Effectively 1 << 16.
870 DEF_CONST(Instruction::CONST_HIGH16, 25u, 0xffff), // Effectively -1 << 16.
871 DEF_CONST(Instruction::CONST, 26u, (1 << 16) + 1),
872 DEF_CONST(Instruction::CONST, 27u, (1 << 16) - 1),
873 DEF_CONST(Instruction::CONST, 28u, (-1 << 16) + 1),
874 DEF_CONST(Instruction::CONST, 29u, (-1 << 16) - 1),
875 // null reference constant.
876 DEF_CONST(Instruction::CONST_4, 30u, 0),
877 };
878
879 PrepareMIRs(mirs);
880 static_assert((arraysize(mirs) & 1) != 0, "missing null or unmatched fp/core");
881 cu_.mir_graph->reg_location_[arraysize(mirs) - 1].ref = true;
882 for (size_t i = arraysize(mirs) / 2u; i != arraysize(mirs) - 1; ++i) {
883 cu_.mir_graph->reg_location_[mirs_[i].ssa_rep->defs[0]].fp = true;
884 }
Vladimir Markod532f002015-02-13 19:47:13 +0000885 PerformLVN();
886 for (size_t i = 0u; i != mir_count_; ++i) {
887 for (size_t j = i + 1u; j != mir_count_; ++j) {
888 EXPECT_NE(value_names_[i], value_names_[j]) << i << " " << j;
889 }
890 }
891}
892
Vladimir Markof59f18b2014-02-17 15:53:57 +0000893} // namespace art