blob: 7ef79ec111a8f701c384254f484146d7d38acbee [file] [log] [blame]
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001/*
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Nicolas Geoffraye5038322014-07-04 09:41:32 +010017#include "builder.h"
18
Mathieu Chartierc7853442015-03-27 14:35:38 -070019#include "art_field-inl.h"
Andreas Gamped881df52014-11-24 23:28:39 -080020#include "base/logging.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010021#include "class_linker.h"
Jeff Hao848f70a2014-01-15 13:49:50 -080022#include "dex/verified_method.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000023#include "dex_file-inl.h"
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +000024#include "dex_instruction-inl.h"
Roland Levillain4c0eb422015-04-24 16:43:49 +010025#include "dex/verified_method.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010026#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000027#include "driver/compiler_options.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010028#include "mirror/class_loader.h"
29#include "mirror/dex_cache.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000030#include "nodes.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000031#include "primitive.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010032#include "scoped_thread_state_change.h"
33#include "thread.h"
Vladimir Marko58155012015-08-19 12:49:41 +000034#include "utils/dex_cache_arrays_layout-inl.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000035
36namespace art {
37
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010038/**
39 * Helper class to add HTemporary instructions. This class is used when
40 * converting a DEX instruction to multiple HInstruction, and where those
41 * instructions do not die at the following instruction, but instead spans
42 * multiple instructions.
43 */
44class Temporaries : public ValueObject {
45 public:
Calin Juravlef97f9fb2014-11-11 15:38:19 +000046 explicit Temporaries(HGraph* graph) : graph_(graph), index_(0) {}
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010047
48 void Add(HInstruction* instruction) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +060049 HInstruction* temp = new (graph_->GetArena()) HTemporary(index_, instruction->GetDexPc());
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010050 instruction->GetBlock()->AddInstruction(temp);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000051
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010052 DCHECK(temp->GetPrevious() == instruction);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000053
54 size_t offset;
55 if (instruction->GetType() == Primitive::kPrimLong
56 || instruction->GetType() == Primitive::kPrimDouble) {
57 offset = 2;
58 } else {
59 offset = 1;
60 }
61 index_ += offset;
62
63 graph_->UpdateTemporariesVRegSlots(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010064 }
65
66 private:
67 HGraph* const graph_;
68
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010069 // Current index in the temporary stack, updated by `Add`.
70 size_t index_;
71};
72
Andreas Gamped881df52014-11-24 23:28:39 -080073class SwitchTable : public ValueObject {
74 public:
75 SwitchTable(const Instruction& instruction, uint32_t dex_pc, bool sparse)
76 : instruction_(instruction), dex_pc_(dex_pc), sparse_(sparse) {
77 int32_t table_offset = instruction.VRegB_31t();
78 const uint16_t* table = reinterpret_cast<const uint16_t*>(&instruction) + table_offset;
79 if (sparse) {
80 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kSparseSwitchSignature));
81 } else {
82 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kPackedSwitchSignature));
83 }
84 num_entries_ = table[1];
85 values_ = reinterpret_cast<const int32_t*>(&table[2]);
86 }
87
88 uint16_t GetNumEntries() const {
89 return num_entries_;
90 }
91
Andreas Gampee4d4d322014-12-04 09:09:57 -080092 void CheckIndex(size_t index) const {
93 if (sparse_) {
94 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
95 DCHECK_LT(index, 2 * static_cast<size_t>(num_entries_));
96 } else {
97 // In a packed table, we have the starting key and num_entries_ values.
98 DCHECK_LT(index, 1 + static_cast<size_t>(num_entries_));
99 }
100 }
101
Andreas Gamped881df52014-11-24 23:28:39 -0800102 int32_t GetEntryAt(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800103 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800104 return values_[index];
105 }
106
107 uint32_t GetDexPcForIndex(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800108 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800109 return dex_pc_ +
110 (reinterpret_cast<const int16_t*>(values_ + index) -
111 reinterpret_cast<const int16_t*>(&instruction_));
112 }
113
Andreas Gampee4d4d322014-12-04 09:09:57 -0800114 // Index of the first value in the table.
115 size_t GetFirstValueIndex() const {
116 if (sparse_) {
117 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
118 return num_entries_;
119 } else {
120 // In a packed table, we have the starting key and num_entries_ values.
121 return 1;
122 }
123 }
124
Andreas Gamped881df52014-11-24 23:28:39 -0800125 private:
126 const Instruction& instruction_;
127 const uint32_t dex_pc_;
128
129 // Whether this is a sparse-switch table (or a packed-switch one).
130 const bool sparse_;
131
132 // This can't be const as it needs to be computed off of the given instruction, and complicated
133 // expressions in the initializer list seemed very ugly.
134 uint16_t num_entries_;
135
136 const int32_t* values_;
137
138 DISALLOW_COPY_AND_ASSIGN(SwitchTable);
139};
140
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100141void HGraphBuilder::InitializeLocals(uint16_t count) {
142 graph_->SetNumberOfVRegs(count);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100143 locals_.resize(count);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000144 for (int i = 0; i < count; i++) {
145 HLocal* local = new (arena_) HLocal(i);
146 entry_block_->AddInstruction(local);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100147 locals_[i] = local;
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000148 }
149}
150
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000151void HGraphBuilder::InitializeParameters(uint16_t number_of_parameters) {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100152 // dex_compilation_unit_ is null only when unit testing.
153 if (dex_compilation_unit_ == nullptr) {
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000154 return;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100155 }
156
157 graph_->SetNumberOfInVRegs(number_of_parameters);
158 const char* shorty = dex_compilation_unit_->GetShorty();
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100159 int locals_index = locals_.size() - number_of_parameters;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100160 int parameter_index = 0;
161
162 if (!dex_compilation_unit_->IsStatic()) {
163 // Add the implicit 'this' argument, not expressed in the signature.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600164 HParameterValue* parameter = new (arena_) HParameterValue(parameter_index++,
165 Primitive::kPrimNot,
166 true);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100167 entry_block_->AddInstruction(parameter);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100168 HLocal* local = GetLocalAt(locals_index++);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600169 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter, local->GetDexPc()));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100170 number_of_parameters--;
171 }
172
173 uint32_t pos = 1;
174 for (int i = 0; i < number_of_parameters; i++) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600175 HParameterValue* parameter = new (arena_) HParameterValue(parameter_index++,
176 Primitive::GetType(shorty[pos++]),
177 false);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100178 entry_block_->AddInstruction(parameter);
179 HLocal* local = GetLocalAt(locals_index++);
180 // Store the parameter value in the local that the dex code will use
181 // to reference that parameter.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600182 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter, local->GetDexPc()));
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100183 bool is_wide = (parameter->GetType() == Primitive::kPrimLong)
184 || (parameter->GetType() == Primitive::kPrimDouble);
185 if (is_wide) {
186 i++;
187 locals_index++;
188 parameter_index++;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100189 }
190 }
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100191}
192
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100193template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000194void HGraphBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000195 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000196 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
197 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
198 DCHECK(branch_target != nullptr);
199 DCHECK(fallthrough_target != nullptr);
200 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600201 HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
202 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
203 T* comparison = new (arena_) T(first, second, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700204 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600205 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700206 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000207 current_block_->AddSuccessor(branch_target);
208 current_block_->AddSuccessor(fallthrough_target);
Dave Allison20dfc792014-06-16 20:44:29 -0700209 current_block_ = nullptr;
210}
211
212template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000213void HGraphBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000214 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000215 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
216 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
217 DCHECK(branch_target != nullptr);
218 DCHECK(fallthrough_target != nullptr);
219 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600220 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
221 T* comparison = new (arena_) T(value, graph_->GetIntConstant(0, dex_pc), dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700222 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600223 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700224 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000225 current_block_->AddSuccessor(branch_target);
226 current_block_->AddSuccessor(fallthrough_target);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100227 current_block_ = nullptr;
228}
229
Calin Juravle48c2b032014-12-09 18:11:36 +0000230void HGraphBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) {
231 if (compilation_stats_ != nullptr) {
232 compilation_stats_->RecordStat(compilation_stat);
233 }
234}
235
David Brazdil1b498722015-03-31 11:37:18 +0100236bool HGraphBuilder::SkipCompilation(const DexFile::CodeItem& code_item,
Calin Juravle48c2b032014-12-09 18:11:36 +0000237 size_t number_of_branches) {
238 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000239 CompilerOptions::CompilerFilter compiler_filter = compiler_options.GetCompilerFilter();
240 if (compiler_filter == CompilerOptions::kEverything) {
241 return false;
242 }
243
David Brazdil1b498722015-03-31 11:37:18 +0100244 if (compiler_options.IsHugeMethod(code_item.insns_size_in_code_units_)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000245 VLOG(compiler) << "Skip compilation of huge method "
246 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100247 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000248 MaybeRecordStat(MethodCompilationStat::kNotCompiledHugeMethod);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000249 return true;
250 }
251
252 // If it's large and contains no branches, it's likely to be machine generated initialization.
David Brazdil1b498722015-03-31 11:37:18 +0100253 if (compiler_options.IsLargeMethod(code_item.insns_size_in_code_units_)
254 && (number_of_branches == 0)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000255 VLOG(compiler) << "Skip compilation of large method with no branch "
256 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100257 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000258 MaybeRecordStat(MethodCompilationStat::kNotCompiledLargeMethodNoBranches);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000259 return true;
260 }
261
262 return false;
263}
264
David Brazdilfc6a86a2015-06-26 10:33:45 +0000265void HGraphBuilder::CreateBlocksForTryCatch(const DexFile::CodeItem& code_item) {
266 if (code_item.tries_size_ == 0) {
267 return;
268 }
269
270 // Create branch targets at the start/end of the TryItem range. These are
271 // places where the program might fall through into/out of the a block and
272 // where TryBoundary instructions will be inserted later. Other edges which
273 // enter/exit the try blocks are a result of branches/switches.
274 for (size_t idx = 0; idx < code_item.tries_size_; ++idx) {
275 const DexFile::TryItem* try_item = DexFile::GetTryItems(code_item, idx);
276 uint32_t dex_pc_start = try_item->start_addr_;
277 uint32_t dex_pc_end = dex_pc_start + try_item->insn_count_;
278 FindOrCreateBlockStartingAt(dex_pc_start);
279 if (dex_pc_end < code_item.insns_size_in_code_units_) {
280 // TODO: Do not create block if the last instruction cannot fall through.
281 FindOrCreateBlockStartingAt(dex_pc_end);
282 } else {
283 // The TryItem spans until the very end of the CodeItem (or beyond if
284 // invalid) and therefore cannot have any code afterwards.
285 }
286 }
287
288 // Create branch targets for exception handlers.
289 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(code_item, 0);
290 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr);
291 for (uint32_t idx = 0; idx < handlers_size; ++idx) {
292 CatchHandlerIterator iterator(handlers_ptr);
293 for (; iterator.HasNext(); iterator.Next()) {
294 uint32_t address = iterator.GetHandlerAddress();
295 HBasicBlock* block = FindOrCreateBlockStartingAt(address);
David Brazdilec16f792015-08-19 15:04:01 +0100296 block->SetTryCatchInformation(
297 new (arena_) TryCatchInformation(iterator.GetHandlerTypeIndex(), *dex_file_));
David Brazdilfc6a86a2015-06-26 10:33:45 +0000298 }
299 handlers_ptr = iterator.EndDataPointer();
300 }
301}
302
David Brazdild7558da2015-09-22 13:04:14 +0100303// Returns the TryItem stored for `block` or nullptr if there is no info for it.
304static const DexFile::TryItem* GetTryItem(
305 HBasicBlock* block,
306 const ArenaSafeMap<uint32_t, const DexFile::TryItem*>& try_block_info) {
307 auto iterator = try_block_info.find(block->GetBlockId());
308 return (iterator == try_block_info.end()) ? nullptr : iterator->second;
309}
David Brazdil56e1acc2015-06-30 15:41:36 +0100310
David Brazdild7558da2015-09-22 13:04:14 +0100311void HGraphBuilder::LinkToCatchBlocks(HTryBoundary* try_boundary,
312 const DexFile::CodeItem& code_item,
313 const DexFile::TryItem* try_item) {
314 for (CatchHandlerIterator it(code_item, *try_item); it.HasNext(); it.Next()) {
David Brazdil56e1acc2015-06-30 15:41:36 +0100315 try_boundary->AddExceptionHandler(FindBlockStartingAt(it.GetHandlerAddress()));
316 }
317}
318
David Brazdilfc6a86a2015-06-26 10:33:45 +0000319void HGraphBuilder::InsertTryBoundaryBlocks(const DexFile::CodeItem& code_item) {
320 if (code_item.tries_size_ == 0) {
321 return;
322 }
323
David Brazdild7558da2015-09-22 13:04:14 +0100324 // Keep a map of all try blocks and their respective TryItems. We do not use
325 // the block's pointer but rather its id to ensure deterministic iteration.
326 ArenaSafeMap<uint32_t, const DexFile::TryItem*> try_block_info(
Vladimir Marko5233f932015-09-29 19:01:15 +0100327 std::less<uint32_t>(), arena_->Adapter(kArenaAllocGraphBuilder));
David Brazdilbff75032015-07-08 17:26:51 +0000328
David Brazdild7558da2015-09-22 13:04:14 +0100329 // Obtain TryItem information for blocks with throwing instructions, and split
330 // blocks which are both try & catch to simplify the graph.
331 // NOTE: We are appending new blocks inside the loop, so we need to use index
332 // because iterators can be invalidated. We remember the initial size to avoid
333 // iterating over the new blocks which cannot throw.
334 for (size_t i = 0, e = graph_->GetBlocks().size(); i < e; ++i) {
335 HBasicBlock* block = graph_->GetBlocks()[i];
David Brazdil72783ff2015-07-09 14:36:05 +0100336
David Brazdild7558da2015-09-22 13:04:14 +0100337 // Do not bother creating exceptional edges for try blocks which have no
338 // throwing instructions. In that case we simply assume that the block is
339 // not covered by a TryItem. This prevents us from creating a throw-catch
340 // loop for synchronized blocks.
341 if (block->HasThrowingInstructions()) {
342 // Try to find a TryItem covering the block.
343 DCHECK_NE(block->GetDexPc(), kNoDexPc) << "Block must have a dec_pc to find its TryItem.";
344 const int32_t try_item_idx = DexFile::FindTryItem(code_item, block->GetDexPc());
345 if (try_item_idx != -1) {
346 // Block throwing and in a TryItem. Store the try block information.
347 HBasicBlock* throwing_block = block;
348 if (block->IsCatchBlock()) {
349 // Simplify blocks which are both try and catch, otherwise we would
350 // need a strategy for splitting exceptional edges. We split the block
351 // after the move-exception (if present) and mark the first part not
352 // throwing. The normal-flow edge between them will be split later.
353 HInstruction* first_insn = block->GetFirstInstruction();
354 if (first_insn->IsLoadException()) {
355 // Catch block starts with a LoadException. Split the block after
356 // the StoreLocal and ClearException which must come after the load.
357 DCHECK(first_insn->GetNext()->IsStoreLocal());
358 DCHECK(first_insn->GetNext()->GetNext()->IsClearException());
359 throwing_block = block->SplitBefore(first_insn->GetNext()->GetNext()->GetNext());
360 } else {
361 // Catch block does not load the exception. Split at the beginning
362 // to create an empty catch block.
363 throwing_block = block->SplitBefore(first_insn);
364 }
David Brazdil72783ff2015-07-09 14:36:05 +0100365 }
David Brazdild7558da2015-09-22 13:04:14 +0100366
367 try_block_info.Put(throwing_block->GetBlockId(),
368 DexFile::GetTryItems(code_item, try_item_idx));
David Brazdil72783ff2015-07-09 14:36:05 +0100369 }
David Brazdil72783ff2015-07-09 14:36:05 +0100370 }
David Brazdilbff75032015-07-08 17:26:51 +0000371 }
372
David Brazdild7558da2015-09-22 13:04:14 +0100373 // Do a pass over the try blocks and insert entering TryBoundaries where at
374 // least one predecessor is not covered by the same TryItem as the try block.
375 // We do not split each edge separately, but rather create one boundary block
376 // that all predecessors are relinked to. This preserves loop headers (b/23895756).
377 for (auto entry : try_block_info) {
378 HBasicBlock* try_block = graph_->GetBlock(entry.first);
379 for (HBasicBlock* predecessor : try_block->GetPredecessors()) {
380 if (GetTryItem(predecessor, try_block_info) != entry.second) {
381 // Found a predecessor not covered by the same TryItem. Insert entering
382 // boundary block.
383 HTryBoundary* try_entry =
384 new (arena_) HTryBoundary(HTryBoundary::kEntry, try_block->GetDexPc());
385 try_block->CreateImmediateDominator()->AddInstruction(try_entry);
386 LinkToCatchBlocks(try_entry, code_item, entry.second);
387 break;
388 }
David Brazdil281a6322015-07-03 10:34:57 +0100389 }
David Brazdild7558da2015-09-22 13:04:14 +0100390 }
David Brazdil281a6322015-07-03 10:34:57 +0100391
David Brazdild7558da2015-09-22 13:04:14 +0100392 // Do a second pass over the try blocks and insert exit TryBoundaries where
393 // the successor is not in the same TryItem.
394 for (auto entry : try_block_info) {
395 HBasicBlock* try_block = graph_->GetBlock(entry.first);
396 // NOTE: Do not use iterators because SplitEdge would invalidate them.
397 for (size_t i = 0, e = try_block->GetSuccessors().size(); i < e; ++i) {
398 HBasicBlock* successor = try_block->GetSuccessor(i);
David Brazdil72783ff2015-07-09 14:36:05 +0100399
David Brazdild7558da2015-09-22 13:04:14 +0100400 // If the successor is a try block, all of its predecessors must be
401 // covered by the same TryItem. Otherwise the previous pass would have
402 // created a non-throwing boundary block.
403 if (GetTryItem(successor, try_block_info) != nullptr) {
404 DCHECK_EQ(entry.second, GetTryItem(successor, try_block_info));
David Brazdil72783ff2015-07-09 14:36:05 +0100405 continue;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000406 }
David Brazdil281a6322015-07-03 10:34:57 +0100407
David Brazdild7558da2015-09-22 13:04:14 +0100408 // Preserve the invariant that Return(Void) always jumps to Exit by moving
409 // it outside the try block if necessary.
410 HInstruction* last_instruction = try_block->GetLastInstruction();
411 if (last_instruction->IsReturn() || last_instruction->IsReturnVoid()) {
412 DCHECK_EQ(successor, exit_block_);
413 successor = try_block->SplitBefore(last_instruction);
David Brazdil281a6322015-07-03 10:34:57 +0100414 }
David Brazdild7558da2015-09-22 13:04:14 +0100415
416 // Insert TryBoundary and link to catch blocks.
417 HTryBoundary* try_exit =
418 new (arena_) HTryBoundary(HTryBoundary::kExit, successor->GetDexPc());
419 graph_->SplitEdge(try_block, successor)->AddInstruction(try_exit);
420 LinkToCatchBlocks(try_exit, code_item, entry.second);
David Brazdil281a6322015-07-03 10:34:57 +0100421 }
David Brazdilfc6a86a2015-06-26 10:33:45 +0000422 }
423}
424
David Brazdil5e8b1372015-01-23 14:39:08 +0000425bool HGraphBuilder::BuildGraph(const DexFile::CodeItem& code_item) {
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100426 DCHECK(graph_->GetBlocks().empty());
David Brazdil5e8b1372015-01-23 14:39:08 +0000427
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000428 const uint16_t* code_ptr = code_item.insns_;
429 const uint16_t* code_end = code_item.insns_ + code_item.insns_size_in_code_units_;
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100430 code_start_ = code_ptr;
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000431
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000432 // Setup the graph with the entry block and exit block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100433 entry_block_ = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000434 graph_->AddBlock(entry_block_);
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100435 exit_block_ = new (arena_) HBasicBlock(graph_, kNoDexPc);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000436 graph_->SetEntryBlock(entry_block_);
437 graph_->SetExitBlock(exit_block_);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000438
David Brazdil77a48ae2015-09-15 12:34:04 +0000439 graph_->SetHasTryCatch(code_item.tries_size_ != 0);
440
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000441 InitializeLocals(code_item.registers_size_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000442 graph_->SetMaximumNumberOfOutVRegs(code_item.outs_size_);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000443
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000444 // Compute the number of dex instructions, blocks, and branches. We will
445 // check these values against limits given to the compiler.
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000446 size_t number_of_branches = 0;
447
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000448 // To avoid splitting blocks, we compute ahead of time the instructions that
449 // start a new block, and create these blocks.
Calin Juravle702d2602015-04-30 19:28:21 +0100450 if (!ComputeBranchTargets(code_ptr, code_end, &number_of_branches)) {
451 MaybeRecordStat(MethodCompilationStat::kNotCompiledBranchOutsideMethodCode);
452 return false;
453 }
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000454
455 // Note that the compiler driver is null when unit testing.
David Brazdil1b498722015-03-31 11:37:18 +0100456 if ((compiler_driver_ != nullptr) && SkipCompilation(code_item, number_of_branches)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000457 return false;
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000458 }
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000459
David Brazdilfc6a86a2015-06-26 10:33:45 +0000460 CreateBlocksForTryCatch(code_item);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +0000461
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000462 InitializeParameters(code_item.ins_size_);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100463
Calin Juravle225ff812014-11-13 16:46:39 +0000464 size_t dex_pc = 0;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000465 while (code_ptr < code_end) {
Calin Juravle225ff812014-11-13 16:46:39 +0000466 // Update the current block if dex_pc starts a new block.
467 MaybeUpdateCurrentBlock(dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000468 const Instruction& instruction = *Instruction::At(code_ptr);
Calin Juravle48c2b032014-12-09 18:11:36 +0000469 if (!AnalyzeDexInstruction(instruction, dex_pc)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000470 return false;
Calin Juravle48c2b032014-12-09 18:11:36 +0000471 }
Calin Juravle225ff812014-11-13 16:46:39 +0000472 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000473 code_ptr += instruction.SizeInCodeUnits();
474 }
475
David Brazdilfc6a86a2015-06-26 10:33:45 +0000476 // Add Exit to the exit block.
David Brazdil3e187382015-06-26 09:59:52 +0000477 exit_block_->AddInstruction(new (arena_) HExit());
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000478 // Add the suspend check to the entry block.
479 entry_block_->AddInstruction(new (arena_) HSuspendCheck(0));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000480 entry_block_->AddInstruction(new (arena_) HGoto());
David Brazdilbff75032015-07-08 17:26:51 +0000481 // Add the exit block at the end.
482 graph_->AddBlock(exit_block_);
David Brazdil5e8b1372015-01-23 14:39:08 +0000483
David Brazdilfc6a86a2015-06-26 10:33:45 +0000484 // Iterate over blocks covered by TryItems and insert TryBoundaries at entry
485 // and exit points. This requires all control-flow instructions and
486 // non-exceptional edges to have been created.
487 InsertTryBoundaryBlocks(code_item);
488
David Brazdil5e8b1372015-01-23 14:39:08 +0000489 return true;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000490}
491
David Brazdilfc6a86a2015-06-26 10:33:45 +0000492void HGraphBuilder::MaybeUpdateCurrentBlock(size_t dex_pc) {
493 HBasicBlock* block = FindBlockStartingAt(dex_pc);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000494 if (block == nullptr) {
495 return;
496 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000497
498 if (current_block_ != nullptr) {
499 // Branching instructions clear current_block, so we know
500 // the last instruction of the current block is not a branching
501 // instruction. We add an unconditional goto to the found block.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600502 current_block_->AddInstruction(new (arena_) HGoto(dex_pc));
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000503 current_block_->AddSuccessor(block);
504 }
505 graph_->AddBlock(block);
506 current_block_ = block;
507}
508
Calin Juravle702d2602015-04-30 19:28:21 +0100509bool HGraphBuilder::ComputeBranchTargets(const uint16_t* code_ptr,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000510 const uint16_t* code_end,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000511 size_t* number_of_branches) {
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100512 branch_targets_.resize(code_end - code_ptr, nullptr);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000513
514 // Create the first block for the dex instructions, single successor of the entry block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100515 HBasicBlock* block = new (arena_) HBasicBlock(graph_, 0);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100516 branch_targets_[0] = block;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000517 entry_block_->AddSuccessor(block);
518
519 // Iterate over all instructions and find branching instructions. Create blocks for
520 // the locations these instructions branch to.
Andreas Gamped881df52014-11-24 23:28:39 -0800521 uint32_t dex_pc = 0;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000522 while (code_ptr < code_end) {
523 const Instruction& instruction = *Instruction::At(code_ptr);
524 if (instruction.IsBranch()) {
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000525 (*number_of_branches)++;
Calin Juravle225ff812014-11-13 16:46:39 +0000526 int32_t target = instruction.GetTargetOffset() + dex_pc;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000527 // Create a block for the target instruction.
David Brazdilfc6a86a2015-06-26 10:33:45 +0000528 FindOrCreateBlockStartingAt(target);
529
Calin Juravle225ff812014-11-13 16:46:39 +0000530 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000531 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100532
David Brazdilfe659462015-06-24 14:23:56 +0100533 if (instruction.CanFlowThrough()) {
534 if (code_ptr >= code_end) {
Calin Juravle702d2602015-04-30 19:28:21 +0100535 // In the normal case we should never hit this but someone can artificially forge a dex
536 // file to fall-through out the method code. In this case we bail out compilation.
537 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000538 } else {
539 FindOrCreateBlockStartingAt(dex_pc);
Calin Juravle702d2602015-04-30 19:28:21 +0100540 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000541 }
Andreas Gampee4d4d322014-12-04 09:09:57 -0800542 } else if (instruction.IsSwitch()) {
543 SwitchTable table(instruction, dex_pc, instruction.Opcode() == Instruction::SPARSE_SWITCH);
Andreas Gamped881df52014-11-24 23:28:39 -0800544
545 uint16_t num_entries = table.GetNumEntries();
546
Andreas Gampee4d4d322014-12-04 09:09:57 -0800547 // In a packed-switch, the entry at index 0 is the starting key. In a sparse-switch, the
548 // entry at index 0 is the first key, and values are after *all* keys.
549 size_t offset = table.GetFirstValueIndex();
550
551 // Use a larger loop counter type to avoid overflow issues.
552 for (size_t i = 0; i < num_entries; ++i) {
Andreas Gamped881df52014-11-24 23:28:39 -0800553 // The target of the case.
Andreas Gampee4d4d322014-12-04 09:09:57 -0800554 uint32_t target = dex_pc + table.GetEntryAt(i + offset);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000555 FindOrCreateBlockStartingAt(target);
Andreas Gamped881df52014-11-24 23:28:39 -0800556
David Brazdil281a6322015-07-03 10:34:57 +0100557 // Create a block for the switch-case logic. The block gets the dex_pc
558 // of the SWITCH instruction because it is part of its semantics.
559 block = new (arena_) HBasicBlock(graph_, dex_pc);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100560 branch_targets_[table.GetDexPcForIndex(i)] = block;
Andreas Gamped881df52014-11-24 23:28:39 -0800561 }
562
563 // Fall-through. Add a block if there is more code afterwards.
564 dex_pc += instruction.SizeInCodeUnits();
565 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100566 if (code_ptr >= code_end) {
567 // In the normal case we should never hit this but someone can artificially forge a dex
568 // file to fall-through out the method code. In this case we bail out compilation.
569 // (A switch can fall-through so we don't need to check CanFlowThrough().)
570 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000571 } else {
572 FindOrCreateBlockStartingAt(dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -0800573 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000574 } else {
575 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle225ff812014-11-13 16:46:39 +0000576 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000577 }
578 }
Calin Juravle702d2602015-04-30 19:28:21 +0100579 return true;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000580}
581
David Brazdilfc6a86a2015-06-26 10:33:45 +0000582HBasicBlock* HGraphBuilder::FindBlockStartingAt(int32_t dex_pc) const {
583 DCHECK_GE(dex_pc, 0);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100584 DCHECK_LT(static_cast<size_t>(dex_pc), branch_targets_.size());
585 return branch_targets_[dex_pc];
David Brazdilfc6a86a2015-06-26 10:33:45 +0000586}
587
588HBasicBlock* HGraphBuilder::FindOrCreateBlockStartingAt(int32_t dex_pc) {
589 HBasicBlock* block = FindBlockStartingAt(dex_pc);
590 if (block == nullptr) {
591 block = new (arena_) HBasicBlock(graph_, dex_pc);
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100592 branch_targets_[dex_pc] = block;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000593 }
594 return block;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000595}
596
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100597template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600598void HGraphBuilder::Unop_12x(const Instruction& instruction,
599 Primitive::Type type,
600 uint32_t dex_pc) {
601 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
602 current_block_->AddInstruction(new (arena_) T(type, first, dex_pc));
603 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Roland Levillain88cb1752014-10-20 16:36:47 +0100604}
605
Roland Levillaindff1f282014-11-05 14:15:05 +0000606void HGraphBuilder::Conversion_12x(const Instruction& instruction,
607 Primitive::Type input_type,
Roland Levillain624279f2014-12-04 11:54:28 +0000608 Primitive::Type result_type,
609 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600610 HInstruction* first = LoadLocal(instruction.VRegB(), input_type, dex_pc);
Roland Levillain624279f2014-12-04 11:54:28 +0000611 current_block_->AddInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600612 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100613}
614
615template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000616void HGraphBuilder::Binop_23x(const Instruction& instruction,
617 Primitive::Type type,
618 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600619 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
620 HInstruction* second = LoadLocal(instruction.VRegC(), type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000621 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600622 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000623}
624
625template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000626void HGraphBuilder::Binop_23x_shift(const Instruction& instruction,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600627 Primitive::Type type,
628 uint32_t dex_pc) {
629 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
630 HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt, dex_pc);
631 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
632 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +0000633}
634
Calin Juravleddb7df22014-11-25 20:56:51 +0000635void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction,
636 Primitive::Type type,
Mark Mendellc4701932015-04-10 13:18:51 -0400637 ComparisonBias bias,
Alexey Frunze4dda3372015-06-01 18:31:49 -0700638 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600639 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
640 HInstruction* second = LoadLocal(instruction.VRegC(), type, dex_pc);
Alexey Frunze4dda3372015-06-01 18:31:49 -0700641 current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600642 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +0000643}
644
Calin Juravle9aec02f2014-11-18 23:06:35 +0000645template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600646void HGraphBuilder::Binop_12x_shift(const Instruction& instruction, Primitive::Type type,
647 uint32_t dex_pc) {
648 HInstruction* first = LoadLocal(instruction.VRegA(), type, dex_pc);
649 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
650 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
651 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +0000652}
653
654template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000655void HGraphBuilder::Binop_12x(const Instruction& instruction,
656 Primitive::Type type,
657 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600658 HInstruction* first = LoadLocal(instruction.VRegA(), type, dex_pc);
659 HInstruction* second = LoadLocal(instruction.VRegB(), type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000660 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600661 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000662}
663
664template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600665void HGraphBuilder::Binop_22s(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
666 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
667 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100668 if (reverse) {
669 std::swap(first, second);
670 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600671 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
672 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100673}
674
675template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600676void HGraphBuilder::Binop_22b(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
677 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
678 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100679 if (reverse) {
680 std::swap(first, second);
681 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600682 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
683 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100684}
685
Calin Juravle0c25d102015-04-20 14:49:09 +0100686static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, const CompilerDriver& driver) {
Calin Juravle27df7582015-04-17 19:12:31 +0100687 Thread* self = Thread::Current();
Calin Juravle0c25d102015-04-20 14:49:09 +0100688 return cu->IsConstructor()
689 && driver.RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex());
Calin Juravle27df7582015-04-17 19:12:31 +0100690}
691
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600692void HGraphBuilder::BuildReturn(const Instruction& instruction,
693 Primitive::Type type,
694 uint32_t dex_pc) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100695 if (type == Primitive::kPrimVoid) {
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100696 if (graph_->ShouldGenerateConstructorBarrier()) {
697 // The compilation unit is null during testing.
698 if (dex_compilation_unit_ != nullptr) {
699 DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, *compiler_driver_))
700 << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier.";
701 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600702 current_block_->AddInstruction(new (arena_) HMemoryBarrier(kStoreStore, dex_pc));
Calin Juravle27df7582015-04-17 19:12:31 +0100703 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600704 current_block_->AddInstruction(new (arena_) HReturnVoid(dex_pc));
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100705 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600706 HInstruction* value = LoadLocal(instruction.VRegA(), type, dex_pc);
707 current_block_->AddInstruction(new (arena_) HReturn(value, dex_pc));
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100708 }
709 current_block_->AddSuccessor(exit_block_);
710 current_block_ = nullptr;
711}
712
Calin Juravle68ad6492015-08-18 17:08:12 +0100713static InvokeType GetInvokeTypeFromOpCode(Instruction::Code opcode) {
714 switch (opcode) {
715 case Instruction::INVOKE_STATIC:
716 case Instruction::INVOKE_STATIC_RANGE:
717 return kStatic;
718 case Instruction::INVOKE_DIRECT:
719 case Instruction::INVOKE_DIRECT_RANGE:
720 return kDirect;
721 case Instruction::INVOKE_VIRTUAL:
722 case Instruction::INVOKE_VIRTUAL_QUICK:
723 case Instruction::INVOKE_VIRTUAL_RANGE:
724 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK:
725 return kVirtual;
726 case Instruction::INVOKE_INTERFACE:
727 case Instruction::INVOKE_INTERFACE_RANGE:
728 return kInterface;
729 case Instruction::INVOKE_SUPER_RANGE:
730 case Instruction::INVOKE_SUPER:
731 return kSuper;
732 default:
733 LOG(FATAL) << "Unexpected invoke opcode: " << opcode;
734 UNREACHABLE();
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100735 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100736}
737
738bool HGraphBuilder::BuildInvoke(const Instruction& instruction,
739 uint32_t dex_pc,
740 uint32_t method_idx,
741 uint32_t number_of_vreg_arguments,
742 bool is_range,
743 uint32_t* args,
744 uint32_t register_index) {
745 InvokeType original_invoke_type = GetInvokeTypeFromOpCode(instruction.Opcode());
746 InvokeType optimized_invoke_type = original_invoke_type;
747 const char* descriptor = dex_file_->GetMethodShorty(method_idx);
748 Primitive::Type return_type = Primitive::GetType(descriptor[0]);
749
750 // Remove the return type from the 'proto'.
751 size_t number_of_arguments = strlen(descriptor) - 1;
752 if (original_invoke_type != kStatic) { // instance call
753 // One extra argument for 'this'.
754 number_of_arguments++;
755 }
756
757 MethodReference target_method(dex_file_, method_idx);
Calin Juravle5d01db12015-08-25 15:02:42 +0100758 int32_t table_index = 0;
759 uintptr_t direct_code = 0;
760 uintptr_t direct_method = 0;
Calin Juravle68ad6492015-08-18 17:08:12 +0100761
Calin Juravle5d01db12015-08-25 15:02:42 +0100762 // Special handling for string init.
763 int32_t string_init_offset = 0;
764 bool is_string_init = compiler_driver_->IsStringInit(method_idx,
765 dex_file_,
766 &string_init_offset);
767 // Replace calls to String.<init> with StringFactory.
768 if (is_string_init) {
769 HInvokeStaticOrDirect::DispatchInfo dispatch_info = ComputeDispatchInfo(is_string_init,
770 string_init_offset,
771 target_method,
772 direct_method,
773 direct_code);
774 HInvoke* invoke = new (arena_) HInvokeStaticOrDirect(
775 arena_,
776 number_of_arguments - 1,
777 Primitive::kPrimNot /*return_type */,
778 dex_pc,
779 method_idx,
780 target_method,
781 dispatch_info,
782 original_invoke_type,
783 kStatic /* optimized_invoke_type */,
784 HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit);
785 return HandleStringInit(invoke,
786 number_of_vreg_arguments,
787 args,
788 register_index,
789 is_range,
790 descriptor);
791 }
792
793 // Handle unresolved methods.
Calin Juravle68ad6492015-08-18 17:08:12 +0100794 if (!compiler_driver_->ComputeInvokeInfo(dex_compilation_unit_,
795 dex_pc,
796 true /* update_stats */,
797 true /* enable_devirtualization */,
798 &optimized_invoke_type,
799 &target_method,
800 &table_index,
801 &direct_code,
802 &direct_method)) {
Calin Juravle175dc732015-08-25 15:42:32 +0100803 MaybeRecordStat(MethodCompilationStat::kUnresolvedMethod);
804 HInvoke* invoke = new (arena_) HInvokeUnresolved(arena_,
805 number_of_arguments,
806 return_type,
807 dex_pc,
808 method_idx,
809 original_invoke_type);
810 return HandleInvoke(invoke,
811 number_of_vreg_arguments,
812 args,
813 register_index,
814 is_range,
815 descriptor,
816 nullptr /* clinit_check */);
Calin Juravle68ad6492015-08-18 17:08:12 +0100817 }
818
Calin Juravle5d01db12015-08-25 15:02:42 +0100819 // Handle resolved methods (non string init).
Calin Juravle68ad6492015-08-18 17:08:12 +0100820
Calin Juravle5d01db12015-08-25 15:02:42 +0100821 DCHECK(optimized_invoke_type != kSuper);
Calin Juravle68ad6492015-08-18 17:08:12 +0100822
823 // Potential class initialization check, in the case of a static method call.
824 HClinitCheck* clinit_check = nullptr;
825 HInvoke* invoke = nullptr;
826
Calin Juravle5d01db12015-08-25 15:02:42 +0100827 if (optimized_invoke_type == kDirect || optimized_invoke_type == kStatic) {
Calin Juravle68ad6492015-08-18 17:08:12 +0100828 // By default, consider that the called method implicitly requires
829 // an initialization check of its declaring method.
830 HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement
831 = HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit;
Calin Juravle5d01db12015-08-25 15:02:42 +0100832 if (optimized_invoke_type == kStatic) {
Calin Juravle68ad6492015-08-18 17:08:12 +0100833 clinit_check = ProcessClinitCheckForInvoke(dex_pc, method_idx, &clinit_check_requirement);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100834 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100835
Calin Juravle68ad6492015-08-18 17:08:12 +0100836 HInvokeStaticOrDirect::DispatchInfo dispatch_info = ComputeDispatchInfo(is_string_init,
837 string_init_offset,
838 target_method,
839 direct_method,
840 direct_code);
841 invoke = new (arena_) HInvokeStaticOrDirect(arena_,
842 number_of_arguments,
843 return_type,
844 dex_pc,
845 method_idx,
846 target_method,
847 dispatch_info,
848 original_invoke_type,
849 optimized_invoke_type,
850 clinit_check_requirement);
851 } else if (optimized_invoke_type == kVirtual) {
852 invoke = new (arena_) HInvokeVirtual(arena_,
853 number_of_arguments,
854 return_type,
855 dex_pc,
856 method_idx,
857 table_index);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100858 } else {
Calin Juravle68ad6492015-08-18 17:08:12 +0100859 DCHECK_EQ(optimized_invoke_type, kInterface);
860 invoke = new (arena_) HInvokeInterface(arena_,
861 number_of_arguments,
862 return_type,
863 dex_pc,
864 method_idx,
865 table_index);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100866 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100867
Calin Juravle5d01db12015-08-25 15:02:42 +0100868 return HandleInvoke(invoke,
869 number_of_vreg_arguments,
870 args,
871 register_index,
872 is_range,
873 descriptor,
874 clinit_check);
Calin Juravle68ad6492015-08-18 17:08:12 +0100875}
876
877HClinitCheck* HGraphBuilder::ProcessClinitCheckForInvoke(
878 uint32_t dex_pc,
879 uint32_t method_idx,
880 HInvokeStaticOrDirect::ClinitCheckRequirement* clinit_check_requirement) {
881 ScopedObjectAccess soa(Thread::Current());
882 StackHandleScope<4> hs(soa.Self());
883 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
884 dex_compilation_unit_->GetClassLinker()->FindDexCache(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -0700885 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Calin Juravle68ad6492015-08-18 17:08:12 +0100886 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
887 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
888 ArtMethod* resolved_method = compiler_driver_->ResolveMethod(
889 soa, dex_cache, class_loader, dex_compilation_unit_, method_idx, InvokeType::kStatic);
890
891 DCHECK(resolved_method != nullptr);
892
893 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
894 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -0700895 outer_compilation_unit_->GetClassLinker()->FindDexCache(soa.Self(), outer_dex_file)));
Calin Juravle68ad6492015-08-18 17:08:12 +0100896 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
897
898 // The index at which the method's class is stored in the DexCache's type array.
899 uint32_t storage_index = DexFile::kDexNoIndex;
900 bool is_outer_class = (resolved_method->GetDeclaringClass() == outer_class.Get());
901 if (is_outer_class) {
902 storage_index = outer_class->GetDexTypeIndex();
903 } else if (outer_dex_cache.Get() == dex_cache.Get()) {
904 // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer.
905 compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(),
906 GetCompilingClass(),
907 resolved_method,
908 method_idx,
909 &storage_index);
910 }
911
912 HClinitCheck* clinit_check = nullptr;
913
914 if (!outer_class->IsInterface()
915 && outer_class->IsSubClass(resolved_method->GetDeclaringClass())) {
916 // If the outer class is the declaring class or a subclass
917 // of the declaring class, no class initialization is needed
918 // before the static method call.
919 // Note that in case of inlining, we do not need to add clinit checks
920 // to calls that satisfy this subclass check with any inlined methods. This
921 // will be detected by the optimization passes.
922 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
923 } else if (storage_index != DexFile::kDexNoIndex) {
924 // If the method's class type index is available, check
925 // whether we should add an explicit class initialization
926 // check for its declaring class before the static method call.
927
928 // TODO: find out why this check is needed.
929 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
930 *outer_compilation_unit_->GetDexFile(), storage_index);
931 bool is_initialized =
932 resolved_method->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
933
934 if (is_initialized) {
935 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
936 } else {
937 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit;
938 HLoadClass* load_class = new (arena_) HLoadClass(
939 graph_->GetCurrentMethod(),
940 storage_index,
941 *dex_compilation_unit_->GetDexFile(),
942 is_outer_class,
943 dex_pc);
944 current_block_->AddInstruction(load_class);
945 clinit_check = new (arena_) HClinitCheck(load_class, dex_pc);
946 current_block_->AddInstruction(clinit_check);
947 }
948 }
949 return clinit_check;
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100950}
951
Vladimir Marko58155012015-08-19 12:49:41 +0000952HInvokeStaticOrDirect::DispatchInfo HGraphBuilder::ComputeDispatchInfo(
953 bool is_string_init,
954 int32_t string_init_offset,
955 MethodReference target_method,
956 uintptr_t direct_method,
957 uintptr_t direct_code) {
958 HInvokeStaticOrDirect::MethodLoadKind method_load_kind;
959 HInvokeStaticOrDirect::CodePtrLocation code_ptr_location;
960 uint64_t method_load_data = 0u;
961 uint64_t direct_code_ptr = 0u;
962
963 if (is_string_init) {
964 // TODO: Use direct_method and direct_code for the appropriate StringFactory method.
965 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kStringInit;
966 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
967 method_load_data = string_init_offset;
968 } else if (target_method.dex_file == outer_compilation_unit_->GetDexFile() &&
969 target_method.dex_method_index == outer_compilation_unit_->GetDexMethodIndex()) {
970 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kRecursive;
971 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallSelf;
972 } else {
973 if (direct_method != 0u) { // Should we use a direct pointer to the method?
974 if (direct_method != static_cast<uintptr_t>(-1)) { // Is the method pointer known now?
975 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDirectAddress;
976 method_load_data = direct_method;
977 } else { // The direct pointer will be known at link time.
978 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDirectAddressWithFixup;
979 }
980 } else { // Use dex cache.
981 DCHECK(target_method.dex_file == dex_compilation_unit_->GetDexFile());
982 DexCacheArraysLayout layout =
983 compiler_driver_->GetDexCacheArraysLayout(target_method.dex_file);
984 if (layout.Valid()) { // Can we use PC-relative access to the dex cache arrays?
985 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDexCachePcRelative;
986 method_load_data = layout.MethodOffset(target_method.dex_method_index);
987 } else { // We must go through the ArtMethod's pointer to resolved methods.
988 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDexCacheViaMethod;
989 }
990 }
991 if (direct_code != 0u) { // Should we use a direct pointer to the code?
992 if (direct_code != static_cast<uintptr_t>(-1)) { // Is the code pointer known now?
993 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallDirect;
994 direct_code_ptr = direct_code;
995 } else if (compiler_driver_->IsImage() ||
996 target_method.dex_file == dex_compilation_unit_->GetDexFile()) {
997 // Use PC-relative calls for invokes within a multi-dex oat file.
998 // TODO: Recognize when the target dex file is within the current oat file for
999 // app compilation. At the moment we recognize only the boot image as multi-dex.
1000 // NOTE: This will require changing the ARM backend which currently falls
1001 // through from kCallPCRelative to kDirectCodeFixup for different dex files.
1002 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallPCRelative;
1003 } else { // The direct pointer will be known at link time.
1004 // NOTE: This is used for app->boot calls when compiling an app against
1005 // a relocatable but not yet relocated image.
1006 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallDirectWithFixup;
1007 }
1008 } else { // We must use the code pointer from the ArtMethod.
1009 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
1010 }
1011 }
1012
1013 if (graph_->IsDebuggable()) {
1014 // For debuggable apps always use the code pointer from ArtMethod
1015 // so that we don't circumvent instrumentation stubs if installed.
1016 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
1017 }
1018
1019 return HInvokeStaticOrDirect::DispatchInfo {
1020 method_load_kind, code_ptr_location, method_load_data, direct_code_ptr };
1021}
1022
Calin Juravle5d01db12015-08-25 15:02:42 +01001023bool HGraphBuilder::SetupInvokeArguments(HInvoke* invoke,
1024 uint32_t number_of_vreg_arguments,
1025 uint32_t* args,
1026 uint32_t register_index,
1027 bool is_range,
1028 const char* descriptor,
1029 size_t start_index,
1030 size_t* argument_index) {
Calin Juravle68ad6492015-08-18 17:08:12 +01001031 uint32_t descriptor_index = 1; // Skip the return type.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001032 uint32_t dex_pc = invoke->GetDexPc();
Calin Juravle68ad6492015-08-18 17:08:12 +01001033
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001034 for (size_t i = start_index;
1035 // Make sure we don't go over the expected arguments or over the number of
1036 // dex registers given. If the instruction was seen as dead by the verifier,
1037 // it hasn't been properly checked.
Calin Juravle5d01db12015-08-25 15:02:42 +01001038 (i < number_of_vreg_arguments) && (*argument_index < invoke->GetNumberOfArguments());
1039 i++, (*argument_index)++) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001040 Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001041 bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble);
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001042 if (!is_range
1043 && is_wide
1044 && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) {
1045 // Longs and doubles should be in pairs, that is, sequential registers. The verifier should
1046 // reject any class where this is violated. However, the verifier only does these checks
1047 // on non trivially dead instructions, so we just bailout the compilation.
1048 VLOG(compiler) << "Did not compile "
1049 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1050 << " because of non-sequential dex register pair in wide argument";
1051 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1052 return false;
1053 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001054 HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type, dex_pc);
Calin Juravle5d01db12015-08-25 15:02:42 +01001055 invoke->SetArgumentAt(*argument_index, arg);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001056 if (is_wide) {
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001057 i++;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001058 }
1059 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001060
Calin Juravle5d01db12015-08-25 15:02:42 +01001061 if (*argument_index != invoke->GetNumberOfArguments()) {
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001062 VLOG(compiler) << "Did not compile "
1063 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1064 << " because of wrong number of arguments in invoke instruction";
1065 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1066 return false;
1067 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001068
Nicolas Geoffray38207af2015-06-01 15:46:22 +01001069 if (invoke->IsInvokeStaticOrDirect()) {
Calin Juravle5d01db12015-08-25 15:02:42 +01001070 invoke->SetArgumentAt(*argument_index, graph_->GetCurrentMethod());
1071 (*argument_index)++;
1072 }
1073
1074 return true;
1075}
1076
1077bool HGraphBuilder::HandleInvoke(HInvoke* invoke,
1078 uint32_t number_of_vreg_arguments,
1079 uint32_t* args,
1080 uint32_t register_index,
1081 bool is_range,
1082 const char* descriptor,
1083 HClinitCheck* clinit_check) {
1084 DCHECK(!invoke->IsInvokeStaticOrDirect() || !invoke->AsInvokeStaticOrDirect()->IsStringInit());
1085
1086 size_t start_index = 0;
1087 size_t argument_index = 0;
1088 if (invoke->GetOriginalInvokeType() != InvokeType::kStatic) { // Instance call.
1089 Temporaries temps(graph_);
1090 HInstruction* arg = LoadLocal(
1091 is_range ? register_index : args[0], Primitive::kPrimNot, invoke->GetDexPc());
1092 HNullCheck* null_check = new (arena_) HNullCheck(arg, invoke->GetDexPc());
1093 current_block_->AddInstruction(null_check);
1094 temps.Add(null_check);
1095 invoke->SetArgumentAt(0, null_check);
1096 start_index = 1;
1097 argument_index = 1;
1098 }
1099
1100 if (!SetupInvokeArguments(invoke,
1101 number_of_vreg_arguments,
1102 args,
1103 register_index,
1104 is_range,
1105 descriptor,
1106 start_index,
1107 &argument_index)) {
1108 return false;
Nicolas Geoffray38207af2015-06-01 15:46:22 +01001109 }
1110
Calin Juravle68ad6492015-08-18 17:08:12 +01001111 if (clinit_check != nullptr) {
Roland Levillain4c0eb422015-04-24 16:43:49 +01001112 // Add the class initialization check as last input of `invoke`.
Calin Juravle68ad6492015-08-18 17:08:12 +01001113 DCHECK(invoke->IsInvokeStaticOrDirect());
1114 DCHECK(invoke->AsInvokeStaticOrDirect()->GetClinitCheckRequirement()
1115 == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit);
Roland Levillain3e3d7332015-04-28 11:00:54 +01001116 invoke->SetArgumentAt(argument_index, clinit_check);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +01001117 argument_index++;
Roland Levillain4c0eb422015-04-24 16:43:49 +01001118 }
1119
Calin Juravle5d01db12015-08-25 15:02:42 +01001120 current_block_->AddInstruction(invoke);
1121 latest_result_ = invoke;
1122
1123 return true;
1124}
1125
1126bool HGraphBuilder::HandleStringInit(HInvoke* invoke,
1127 uint32_t number_of_vreg_arguments,
1128 uint32_t* args,
1129 uint32_t register_index,
1130 bool is_range,
1131 const char* descriptor) {
1132 DCHECK(invoke->IsInvokeStaticOrDirect());
1133 DCHECK(invoke->AsInvokeStaticOrDirect()->IsStringInit());
1134
1135 size_t start_index = 1;
1136 size_t argument_index = 0;
1137 if (!SetupInvokeArguments(invoke,
1138 number_of_vreg_arguments,
1139 args,
1140 register_index,
1141 is_range,
1142 descriptor,
1143 start_index,
1144 &argument_index)) {
1145 return false;
Jeff Hao848f70a2014-01-15 13:49:50 -08001146 }
Calin Juravle0eedd7e2015-08-20 14:48:00 +01001147
Calin Juravle5d01db12015-08-25 15:02:42 +01001148 // Add move-result for StringFactory method.
1149 uint32_t orig_this_reg = is_range ? register_index : args[0];
1150 HInstruction* fake_string = LoadLocal(orig_this_reg, Primitive::kPrimNot, invoke->GetDexPc());
1151 invoke->SetArgumentAt(argument_index, fake_string);
1152 current_block_->AddInstruction(invoke);
1153 PotentiallySimplifyFakeString(orig_this_reg, invoke->GetDexPc(), invoke);
1154
Calin Juravle0eedd7e2015-08-20 14:48:00 +01001155 latest_result_ = invoke;
1156
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001157 return true;
1158}
1159
Calin Juravle68ad6492015-08-18 17:08:12 +01001160void HGraphBuilder::PotentiallySimplifyFakeString(uint16_t original_dex_register,
1161 uint32_t dex_pc,
1162 HInvoke* actual_string) {
1163 if (!graph_->IsDebuggable()) {
1164 // Notify that we cannot compile with baseline. The dex registers aliasing
1165 // with `original_dex_register` will be handled when we optimize
1166 // (see HInstructionSimplifer::VisitFakeString).
1167 can_use_baseline_for_string_init_ = false;
1168 return;
1169 }
1170 const VerifiedMethod* verified_method =
1171 compiler_driver_->GetVerifiedMethod(dex_file_, dex_compilation_unit_->GetDexMethodIndex());
1172 if (verified_method != nullptr) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001173 UpdateLocal(original_dex_register, actual_string, dex_pc);
Calin Juravle68ad6492015-08-18 17:08:12 +01001174 const SafeMap<uint32_t, std::set<uint32_t>>& string_init_map =
1175 verified_method->GetStringInitPcRegMap();
1176 auto map_it = string_init_map.find(dex_pc);
1177 if (map_it != string_init_map.end()) {
1178 std::set<uint32_t> reg_set = map_it->second;
1179 for (auto set_it = reg_set.begin(); set_it != reg_set.end(); ++set_it) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001180 HInstruction* load_local = LoadLocal(original_dex_register, Primitive::kPrimNot, dex_pc);
1181 UpdateLocal(*set_it, load_local, dex_pc);
Calin Juravle68ad6492015-08-18 17:08:12 +01001182 }
1183 }
1184 } else {
1185 can_use_baseline_for_string_init_ = false;
1186 }
1187}
1188
Calin Juravlee460d1d2015-09-29 04:52:17 +01001189static Primitive::Type GetFieldAccessType(const DexFile& dex_file, uint16_t field_index) {
1190 const DexFile::FieldId& field_id = dex_file.GetFieldId(field_index);
1191 const char* type = dex_file.GetFieldTypeDescriptor(field_id);
1192 return Primitive::GetType(type[0]);
1193}
1194
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001195bool HGraphBuilder::BuildInstanceFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001196 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001197 bool is_put) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001198 uint32_t source_or_dest_reg = instruction.VRegA_22c();
1199 uint32_t obj_reg = instruction.VRegB_22c();
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001200 uint16_t field_index;
1201 if (instruction.IsQuickened()) {
1202 if (!CanDecodeQuickenedInfo()) {
1203 return false;
1204 }
1205 field_index = LookupQuickenedInfo(dex_pc);
1206 } else {
1207 field_index = instruction.VRegC_22c();
1208 }
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001209
1210 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001211 ArtField* resolved_field =
1212 compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001213
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001214
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001215 HInstruction* object = LoadLocal(obj_reg, Primitive::kPrimNot, dex_pc);
Calin Juravlee460d1d2015-09-29 04:52:17 +01001216 HInstruction* null_check = new (arena_) HNullCheck(object, dex_pc);
1217 current_block_->AddInstruction(null_check);
1218
1219 Primitive::Type field_type = (resolved_field == nullptr)
1220 ? GetFieldAccessType(*dex_file_, field_index)
1221 : resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001222 if (is_put) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001223 Temporaries temps(graph_);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001224 // We need one temporary for the null check.
1225 temps.Add(null_check);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001226 HInstruction* value = LoadLocal(source_or_dest_reg, field_type, dex_pc);
Calin Juravlee460d1d2015-09-29 04:52:17 +01001227 HInstruction* field_set = nullptr;
1228 if (resolved_field == nullptr) {
1229 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
1230 field_set = new (arena_) HUnresolvedInstanceFieldSet(null_check,
1231 value,
1232 field_type,
1233 field_index,
1234 dex_pc);
1235 } else {
1236 field_set = new (arena_) HInstanceFieldSet(null_check,
1237 value,
1238 field_type,
1239 resolved_field->GetOffset(),
1240 resolved_field->IsVolatile(),
1241 field_index,
1242 *dex_file_,
1243 dex_compilation_unit_->GetDexCache(),
1244 dex_pc);
1245 }
1246 current_block_->AddInstruction(field_set);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001247 } else {
Calin Juravlee460d1d2015-09-29 04:52:17 +01001248 HInstruction* field_get = nullptr;
1249 if (resolved_field == nullptr) {
1250 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
1251 field_get = new (arena_) HUnresolvedInstanceFieldGet(null_check,
1252 field_type,
1253 field_index,
1254 dex_pc);
1255 } else {
1256 field_get = new (arena_) HInstanceFieldGet(null_check,
1257 field_type,
1258 resolved_field->GetOffset(),
1259 resolved_field->IsVolatile(),
1260 field_index,
1261 *dex_file_,
1262 dex_compilation_unit_->GetDexCache(),
1263 dex_pc);
1264 }
1265 current_block_->AddInstruction(field_get);
1266 UpdateLocal(source_or_dest_reg, field_get, dex_pc);
Calin Juravlee6f49b42015-09-17 14:04:33 +00001267 }
Calin Juravlee460d1d2015-09-29 04:52:17 +01001268
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001269 return true;
1270}
1271
Nicolas Geoffray30451742015-06-19 13:32:41 +01001272static mirror::Class* GetClassFrom(CompilerDriver* driver,
1273 const DexCompilationUnit& compilation_unit) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001274 ScopedObjectAccess soa(Thread::Current());
1275 StackHandleScope<2> hs(soa.Self());
Nicolas Geoffray30451742015-06-19 13:32:41 +01001276 const DexFile& dex_file = *compilation_unit.GetDexFile();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001277 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
Nicolas Geoffray30451742015-06-19 13:32:41 +01001278 soa.Decode<mirror::ClassLoader*>(compilation_unit.GetClassLoader())));
1279 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001280 compilation_unit.GetClassLinker()->FindDexCache(soa.Self(), dex_file)));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001281
Nicolas Geoffray30451742015-06-19 13:32:41 +01001282 return driver->ResolveCompilingMethodsClass(soa, dex_cache, class_loader, &compilation_unit);
1283}
1284
1285mirror::Class* HGraphBuilder::GetOutermostCompilingClass() const {
1286 return GetClassFrom(compiler_driver_, *outer_compilation_unit_);
1287}
1288
1289mirror::Class* HGraphBuilder::GetCompilingClass() const {
1290 return GetClassFrom(compiler_driver_, *dex_compilation_unit_);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001291}
1292
1293bool HGraphBuilder::IsOutermostCompilingClass(uint16_t type_index) const {
1294 ScopedObjectAccess soa(Thread::Current());
1295 StackHandleScope<4> hs(soa.Self());
1296 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001297 dex_compilation_unit_->GetClassLinker()->FindDexCache(
1298 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001299 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1300 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
1301 Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass(
1302 soa, dex_cache, class_loader, type_index, dex_compilation_unit_)));
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001303 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001304
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001305 return outer_class.Get() == cls.Get();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001306}
1307
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001308bool HGraphBuilder::BuildStaticFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001309 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001310 bool is_put) {
1311 uint32_t source_or_dest_reg = instruction.VRegA_21c();
1312 uint16_t field_index = instruction.VRegB_21c();
1313
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001314 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001315 StackHandleScope<4> hs(soa.Self());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001316 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001317 dex_compilation_unit_->GetClassLinker()->FindDexCache(
1318 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001319 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1320 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartierc7853442015-03-27 14:35:38 -07001321 ArtField* resolved_field = compiler_driver_->ResolveField(
1322 soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001323
Mathieu Chartierc7853442015-03-27 14:35:38 -07001324 if (resolved_field == nullptr) {
Calin Juravlee460d1d2015-09-29 04:52:17 +01001325 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
1326 Primitive::Type field_type = GetFieldAccessType(*dex_file_, field_index);
1327 if (is_put) {
1328 HInstruction* value = LoadLocal(source_or_dest_reg, field_type, dex_pc);
1329 current_block_->AddInstruction(
1330 new (arena_) HUnresolvedStaticFieldSet(value, field_type, field_index, dex_pc));
1331 } else {
1332 current_block_->AddInstruction(
1333 new (arena_) HUnresolvedStaticFieldGet(field_type, field_index, dex_pc));
1334 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
1335 }
1336 return true;
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001337 }
1338
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001339 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
1340 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001341 outer_compilation_unit_->GetClassLinker()->FindDexCache(soa.Self(), outer_dex_file)));
Nicolas Geoffray30451742015-06-19 13:32:41 +01001342 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001343
1344 // The index at which the field's class is stored in the DexCache's type array.
1345 uint32_t storage_index;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001346 bool is_outer_class = (outer_class.Get() == resolved_field->GetDeclaringClass());
1347 if (is_outer_class) {
1348 storage_index = outer_class->GetDexTypeIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001349 } else if (outer_dex_cache.Get() != dex_cache.Get()) {
Roland Levillain4c0eb422015-04-24 16:43:49 +01001350 // The compiler driver cannot currently understand multiple dex caches involved. Just bailout.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001351 return false;
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001352 } else {
1353 std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField(
1354 outer_dex_cache.Get(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001355 GetCompilingClass(),
Mathieu Chartierc7853442015-03-27 14:35:38 -07001356 resolved_field,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001357 field_index,
1358 &storage_index);
1359 bool can_easily_access = is_put ? pair.second : pair.first;
1360 if (!can_easily_access) {
1361 return false;
1362 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001363 }
1364
1365 // TODO: find out why this check is needed.
1366 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
Nicolas Geoffray6a816cf2015-03-24 16:17:56 +00001367 *outer_compilation_unit_->GetDexFile(), storage_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001368 bool is_initialized = resolved_field->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001369
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001370 HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(),
1371 storage_index,
1372 *dex_compilation_unit_->GetDexFile(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001373 is_outer_class,
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001374 dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001375 current_block_->AddInstruction(constant);
1376
1377 HInstruction* cls = constant;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001378 if (!is_initialized && !is_outer_class) {
Calin Juravle225ff812014-11-13 16:46:39 +00001379 cls = new (arena_) HClinitCheck(constant, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001380 current_block_->AddInstruction(cls);
1381 }
1382
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001383 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001384 if (is_put) {
1385 // We need to keep the class alive before loading the value.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001386 Temporaries temps(graph_);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001387 temps.Add(cls);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001388 HInstruction* value = LoadLocal(source_or_dest_reg, field_type, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001389 DCHECK_EQ(value->GetType(), field_type);
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001390 current_block_->AddInstruction(new (arena_) HStaticFieldSet(cls,
1391 value,
1392 field_type,
1393 resolved_field->GetOffset(),
1394 resolved_field->IsVolatile(),
1395 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001396 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001397 dex_cache_,
1398 dex_pc));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001399 } else {
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001400 current_block_->AddInstruction(new (arena_) HStaticFieldGet(cls,
1401 field_type,
1402 resolved_field->GetOffset(),
1403 resolved_field->IsVolatile(),
1404 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001405 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001406 dex_cache_,
1407 dex_pc));
1408 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001409 }
1410 return true;
1411}
1412
Calin Juravlebacfec32014-11-14 15:54:36 +00001413void HGraphBuilder::BuildCheckedDivRem(uint16_t out_vreg,
1414 uint16_t first_vreg,
1415 int64_t second_vreg_or_constant,
1416 uint32_t dex_pc,
1417 Primitive::Type type,
1418 bool second_is_constant,
1419 bool isDiv) {
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001420 DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong);
Calin Juravled0d48522014-11-04 16:40:20 +00001421
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001422 HInstruction* first = LoadLocal(first_vreg, type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001423 HInstruction* second = nullptr;
1424 if (second_is_constant) {
1425 if (type == Primitive::kPrimInt) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001426 second = graph_->GetIntConstant(second_vreg_or_constant, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001427 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001428 second = graph_->GetLongConstant(second_vreg_or_constant, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001429 }
1430 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001431 second = LoadLocal(second_vreg_or_constant, type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001432 }
1433
1434 if (!second_is_constant
1435 || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0)
1436 || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) {
1437 second = new (arena_) HDivZeroCheck(second, dex_pc);
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001438 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001439 current_block_->AddInstruction(second);
1440 temps.Add(current_block_->GetLastInstruction());
1441 }
1442
Calin Juravlebacfec32014-11-14 15:54:36 +00001443 if (isDiv) {
1444 current_block_->AddInstruction(new (arena_) HDiv(type, first, second, dex_pc));
1445 } else {
1446 current_block_->AddInstruction(new (arena_) HRem(type, first, second, dex_pc));
1447 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001448 UpdateLocal(out_vreg, current_block_->GetLastInstruction(), dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001449}
1450
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001451void HGraphBuilder::BuildArrayAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001452 uint32_t dex_pc,
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001453 bool is_put,
1454 Primitive::Type anticipated_type) {
1455 uint8_t source_or_dest_reg = instruction.VRegA_23x();
1456 uint8_t array_reg = instruction.VRegB_23x();
1457 uint8_t index_reg = instruction.VRegC_23x();
1458
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001459 // We need one temporary for the null check, one for the index, and one for the length.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001460 Temporaries temps(graph_);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001461
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001462 HInstruction* object = LoadLocal(array_reg, Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001463 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001464 current_block_->AddInstruction(object);
1465 temps.Add(object);
1466
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001467 HInstruction* length = new (arena_) HArrayLength(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001468 current_block_->AddInstruction(length);
1469 temps.Add(length);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001470 HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001471 index = new (arena_) HBoundsCheck(index, length, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001472 current_block_->AddInstruction(index);
1473 temps.Add(index);
1474 if (is_put) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001475 HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001476 // TODO: Insert a type check node if the type is Object.
Nicolas Geoffray39468442014-09-02 15:17:15 +01001477 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001478 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001479 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001480 current_block_->AddInstruction(new (arena_) HArrayGet(object, index, anticipated_type, dex_pc));
1481 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001482 }
Mark Mendell1152c922015-04-24 17:06:35 -04001483 graph_->SetHasBoundsChecks(true);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001484}
1485
Calin Juravle225ff812014-11-13 16:46:39 +00001486void HGraphBuilder::BuildFilledNewArray(uint32_t dex_pc,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001487 uint32_t type_index,
1488 uint32_t number_of_vreg_arguments,
1489 bool is_range,
1490 uint32_t* args,
1491 uint32_t register_index) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001492 HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments, dex_pc);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001493 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
1494 ? kQuickAllocArrayWithAccessCheck
1495 : kQuickAllocArray;
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001496 HInstruction* object = new (arena_) HNewArray(length,
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01001497 graph_->GetCurrentMethod(),
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001498 dex_pc,
1499 type_index,
1500 *dex_compilation_unit_->GetDexFile(),
1501 entrypoint);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001502 current_block_->AddInstruction(object);
1503
1504 const char* descriptor = dex_file_->StringByTypeIdx(type_index);
1505 DCHECK_EQ(descriptor[0], '[') << descriptor;
1506 char primitive = descriptor[1];
1507 DCHECK(primitive == 'I'
1508 || primitive == 'L'
1509 || primitive == '[') << descriptor;
1510 bool is_reference_array = (primitive == 'L') || (primitive == '[');
1511 Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt;
1512
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001513 Temporaries temps(graph_);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001514 temps.Add(object);
1515 for (size_t i = 0; i < number_of_vreg_arguments; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001516 HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type, dex_pc);
1517 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001518 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001519 new (arena_) HArraySet(object, index, value, type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001520 }
1521 latest_result_ = object;
1522}
1523
1524template <typename T>
1525void HGraphBuilder::BuildFillArrayData(HInstruction* object,
1526 const T* data,
1527 uint32_t element_count,
1528 Primitive::Type anticipated_type,
Calin Juravle225ff812014-11-13 16:46:39 +00001529 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001530 for (uint32_t i = 0; i < element_count; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001531 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1532 HInstruction* value = graph_->GetIntConstant(data[i], dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001533 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001534 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001535 }
1536}
1537
Calin Juravle225ff812014-11-13 16:46:39 +00001538void HGraphBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001539 Temporaries temps(graph_);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001540 HInstruction* array = LoadLocal(instruction.VRegA_31t(), Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001541 HNullCheck* null_check = new (arena_) HNullCheck(array, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001542 current_block_->AddInstruction(null_check);
1543 temps.Add(null_check);
1544
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001545 HInstruction* length = new (arena_) HArrayLength(null_check, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001546 current_block_->AddInstruction(length);
1547
Calin Juravle225ff812014-11-13 16:46:39 +00001548 int32_t payload_offset = instruction.VRegB_31t() + dex_pc;
Calin Juravled0d48522014-11-04 16:40:20 +00001549 const Instruction::ArrayDataPayload* payload =
1550 reinterpret_cast<const Instruction::ArrayDataPayload*>(code_start_ + payload_offset);
1551 const uint8_t* data = payload->data;
1552 uint32_t element_count = payload->element_count;
1553
1554 // Implementation of this DEX instruction seems to be that the bounds check is
1555 // done before doing any stores.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001556 HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001557 current_block_->AddInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc));
Calin Juravled0d48522014-11-04 16:40:20 +00001558
1559 switch (payload->element_width) {
1560 case 1:
1561 BuildFillArrayData(null_check,
1562 reinterpret_cast<const int8_t*>(data),
1563 element_count,
1564 Primitive::kPrimByte,
Calin Juravle225ff812014-11-13 16:46:39 +00001565 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001566 break;
1567 case 2:
1568 BuildFillArrayData(null_check,
1569 reinterpret_cast<const int16_t*>(data),
1570 element_count,
1571 Primitive::kPrimShort,
Calin Juravle225ff812014-11-13 16:46:39 +00001572 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001573 break;
1574 case 4:
1575 BuildFillArrayData(null_check,
1576 reinterpret_cast<const int32_t*>(data),
1577 element_count,
1578 Primitive::kPrimInt,
Calin Juravle225ff812014-11-13 16:46:39 +00001579 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001580 break;
1581 case 8:
1582 BuildFillWideArrayData(null_check,
1583 reinterpret_cast<const int64_t*>(data),
1584 element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001585 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001586 break;
1587 default:
1588 LOG(FATAL) << "Unknown element width for " << payload->element_width;
1589 }
Mark Mendell1152c922015-04-24 17:06:35 -04001590 graph_->SetHasBoundsChecks(true);
Calin Juravled0d48522014-11-04 16:40:20 +00001591}
1592
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001593void HGraphBuilder::BuildFillWideArrayData(HInstruction* object,
Nicolas Geoffray8d6ae522014-10-23 18:32:13 +01001594 const int64_t* data,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001595 uint32_t element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001596 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001597 for (uint32_t i = 0; i < element_count; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001598 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1599 HInstruction* value = graph_->GetLongConstant(data[i], dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001600 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001601 object, index, value, Primitive::kPrimLong, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001602 }
1603}
1604
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001605static TypeCheckKind ComputeTypeCheckKind(Handle<mirror::Class> cls)
1606 SHARED_REQUIRES(Locks::mutator_lock_) {
1607 if (cls->IsInterface()) {
1608 return TypeCheckKind::kInterfaceCheck;
1609 } else if (cls->IsArrayClass()) {
1610 if (cls->GetComponentType()->IsObjectClass()) {
1611 return TypeCheckKind::kArrayObjectCheck;
1612 } else if (cls->CannotBeAssignedFromOtherTypes()) {
1613 return TypeCheckKind::kExactCheck;
1614 } else {
1615 return TypeCheckKind::kArrayCheck;
1616 }
1617 } else if (cls->IsFinal()) {
1618 return TypeCheckKind::kExactCheck;
1619 } else if (cls->IsAbstract()) {
1620 return TypeCheckKind::kAbstractClassCheck;
1621 } else {
1622 return TypeCheckKind::kClassHierarchyCheck;
1623 }
1624}
1625
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001626bool HGraphBuilder::BuildTypeCheck(const Instruction& instruction,
1627 uint8_t destination,
1628 uint8_t reference,
1629 uint16_t type_index,
Calin Juravle225ff812014-11-13 16:46:39 +00001630 uint32_t dex_pc) {
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001631 ScopedObjectAccess soa(Thread::Current());
1632 StackHandleScope<2> hs(soa.Self());
1633 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
1634 dex_compilation_unit_->GetClassLinker()->FindDexCache(
1635 soa.Self(), *dex_compilation_unit_->GetDexFile())));
1636 Handle<mirror::Class> resolved_class(hs.NewHandle(dex_cache->GetResolvedType(type_index)));
1637
1638 if ((resolved_class.Get() == nullptr) ||
1639 // TODO: Remove this check once the compiler actually knows which
1640 // ArtMethod it is compiling.
1641 (GetCompilingClass() == nullptr) ||
1642 !GetCompilingClass()->CanAccess(resolved_class.Get())) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001643 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001644 return false;
1645 }
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001646
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001647 HInstruction* object = LoadLocal(reference, Primitive::kPrimNot, dex_pc);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001648 HLoadClass* cls = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001649 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01001650 type_index,
1651 *dex_compilation_unit_->GetDexFile(),
1652 IsOutermostCompilingClass(type_index),
1653 dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001654 current_block_->AddInstruction(cls);
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001655
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001656 // The class needs a temporary before being used by the type check.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001657 Temporaries temps(graph_);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001658 temps.Add(cls);
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001659
1660 TypeCheckKind check_kind = ComputeTypeCheckKind(resolved_class);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001661 if (instruction.Opcode() == Instruction::INSTANCE_OF) {
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001662 current_block_->AddInstruction(new (arena_) HInstanceOf(object, cls, check_kind, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001663 UpdateLocal(destination, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001664 } else {
1665 DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST);
Nicolas Geoffray85c7bab2015-09-18 13:40:46 +00001666 current_block_->AddInstruction(new (arena_) HCheckCast(object, cls, check_kind, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001667 }
1668 return true;
1669}
1670
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001671bool HGraphBuilder::NeedsAccessCheck(uint32_t type_index) const {
1672 return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks(
1673 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index);
1674}
1675
Mark Mendellfe57faa2015-09-18 09:26:15 -04001676void HGraphBuilder::BuildSwitchJumpTable(const SwitchTable& table,
1677 const Instruction& instruction,
1678 HInstruction* value,
1679 uint32_t dex_pc) {
1680 // Add the successor blocks to the current block.
1681 uint16_t num_entries = table.GetNumEntries();
1682 for (size_t i = 1; i <= num_entries; i++) {
1683 int32_t target_offset = table.GetEntryAt(i);
1684 HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset);
1685 DCHECK(case_target != nullptr);
1686
1687 // Add the target block as a successor.
1688 current_block_->AddSuccessor(case_target);
1689 }
1690
1691 // Add the default target block as the last successor.
1692 HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
1693 DCHECK(default_target != nullptr);
1694 current_block_->AddSuccessor(default_target);
1695
1696 // Now add the Switch instruction.
1697 int32_t starting_key = table.GetEntryAt(0);
1698 current_block_->AddInstruction(
1699 new (arena_) HPackedSwitch(starting_key, num_entries, value, dex_pc));
1700 // This block ends with control flow.
1701 current_block_ = nullptr;
1702}
1703
Calin Juravle48c2b032014-12-09 18:11:36 +00001704void HGraphBuilder::BuildPackedSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001705 // Verifier guarantees that the payload for PackedSwitch contains:
1706 // (a) number of entries (may be zero)
1707 // (b) first and lowest switch case value (entry 0, always present)
1708 // (c) list of target pcs (entries 1 <= i <= N)
Andreas Gamped881df52014-11-24 23:28:39 -08001709 SwitchTable table(instruction, dex_pc, false);
1710
1711 // Value to test against.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001712 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08001713
Mark Mendellfe57faa2015-09-18 09:26:15 -04001714 // Starting key value.
1715 int32_t starting_key = table.GetEntryAt(0);
1716
David Brazdil2ef645b2015-06-17 18:20:52 +01001717 // Retrieve number of entries.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001718 uint16_t num_entries = table.GetNumEntries();
David Brazdil2ef645b2015-06-17 18:20:52 +01001719 if (num_entries == 0) {
1720 return;
1721 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001722
Mark Mendellfe57faa2015-09-18 09:26:15 -04001723 // Don't use a packed switch if there are very few entries.
1724 if (num_entries > kSmallSwitchThreshold) {
1725 BuildSwitchJumpTable(table, instruction, value, dex_pc);
1726 } else {
1727 // Chained cmp-and-branch, starting from starting_key.
1728 for (size_t i = 1; i <= num_entries; i++) {
Mark Mendell3b9f3042015-09-24 08:43:40 -04001729 BuildSwitchCaseHelper(instruction,
1730 i,
1731 i == num_entries,
1732 table,
1733 value,
1734 starting_key + i - 1,
1735 table.GetEntryAt(i),
1736 dex_pc);
Mark Mendellfe57faa2015-09-18 09:26:15 -04001737 }
Andreas Gamped881df52014-11-24 23:28:39 -08001738 }
Andreas Gamped881df52014-11-24 23:28:39 -08001739}
1740
Calin Juravle48c2b032014-12-09 18:11:36 +00001741void HGraphBuilder::BuildSparseSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001742 // Verifier guarantees that the payload for SparseSwitch contains:
1743 // (a) number of entries (may be zero)
1744 // (b) sorted key values (entries 0 <= i < N)
1745 // (c) target pcs corresponding to the switch values (entries N <= i < 2*N)
Andreas Gampee4d4d322014-12-04 09:09:57 -08001746 SwitchTable table(instruction, dex_pc, true);
1747
1748 // Value to test against.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001749 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001750
1751 uint16_t num_entries = table.GetNumEntries();
Andreas Gampee4d4d322014-12-04 09:09:57 -08001752
1753 for (size_t i = 0; i < num_entries; i++) {
1754 BuildSwitchCaseHelper(instruction, i, i == static_cast<size_t>(num_entries) - 1, table, value,
1755 table.GetEntryAt(i), table.GetEntryAt(i + num_entries), dex_pc);
1756 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001757}
1758
1759void HGraphBuilder::BuildSwitchCaseHelper(const Instruction& instruction, size_t index,
1760 bool is_last_case, const SwitchTable& table,
1761 HInstruction* value, int32_t case_value_int,
1762 int32_t target_offset, uint32_t dex_pc) {
David Brazdil852eaff2015-02-02 15:23:05 +00001763 HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset);
1764 DCHECK(case_target != nullptr);
1765 PotentiallyAddSuspendCheck(case_target, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001766
1767 // The current case's value.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001768 HInstruction* this_case_value = graph_->GetIntConstant(case_value_int, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001769
1770 // Compare value and this_case_value.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001771 HEqual* comparison = new (arena_) HEqual(value, this_case_value, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001772 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001773 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001774 current_block_->AddInstruction(ifinst);
1775
1776 // Case hit: use the target offset to determine where to go.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001777 current_block_->AddSuccessor(case_target);
1778
1779 // Case miss: go to the next case (or default fall-through).
1780 // When there is a next case, we use the block stored with the table offset representing this
1781 // case (that is where we registered them in ComputeBranchTargets).
1782 // When there is no next case, we use the following instruction.
1783 // TODO: Find a good way to peel the last iteration to avoid conditional, but still have re-use.
1784 if (!is_last_case) {
1785 HBasicBlock* next_case_target = FindBlockStartingAt(table.GetDexPcForIndex(index));
1786 DCHECK(next_case_target != nullptr);
1787 current_block_->AddSuccessor(next_case_target);
1788
1789 // Need to manually add the block, as there is no dex-pc transition for the cases.
1790 graph_->AddBlock(next_case_target);
1791
1792 current_block_ = next_case_target;
1793 } else {
1794 HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
1795 DCHECK(default_target != nullptr);
1796 current_block_->AddSuccessor(default_target);
1797 current_block_ = nullptr;
1798 }
1799}
1800
David Brazdil852eaff2015-02-02 15:23:05 +00001801void HGraphBuilder::PotentiallyAddSuspendCheck(HBasicBlock* target, uint32_t dex_pc) {
1802 int32_t target_offset = target->GetDexPc() - dex_pc;
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001803 if (target_offset <= 0) {
David Brazdil852eaff2015-02-02 15:23:05 +00001804 // DX generates back edges to the first encountered return. We can save
1805 // time of later passes by not adding redundant suspend checks.
David Brazdil2fd6aa52015-02-02 18:58:27 +00001806 HInstruction* last_in_target = target->GetLastInstruction();
1807 if (last_in_target != nullptr &&
1808 (last_in_target->IsReturn() || last_in_target->IsReturnVoid())) {
1809 return;
David Brazdil852eaff2015-02-02 15:23:05 +00001810 }
1811
1812 // Add a suspend check to backward branches which may potentially loop. We
1813 // can remove them after we recognize loops in the graph.
Calin Juravle225ff812014-11-13 16:46:39 +00001814 current_block_->AddInstruction(new (arena_) HSuspendCheck(dex_pc));
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001815 }
1816}
1817
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001818bool HGraphBuilder::CanDecodeQuickenedInfo() const {
1819 return interpreter_metadata_ != nullptr;
1820}
1821
1822uint16_t HGraphBuilder::LookupQuickenedInfo(uint32_t dex_pc) {
1823 DCHECK(interpreter_metadata_ != nullptr);
1824 uint32_t dex_pc_in_map = DecodeUnsignedLeb128(&interpreter_metadata_);
1825 DCHECK_EQ(dex_pc, dex_pc_in_map);
1826 return DecodeUnsignedLeb128(&interpreter_metadata_);
1827}
1828
Calin Juravle225ff812014-11-13 16:46:39 +00001829bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001830 if (current_block_ == nullptr) {
1831 return true; // Dead code
1832 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001833
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001834 switch (instruction.Opcode()) {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001835 case Instruction::CONST_4: {
1836 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001837 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n(), dex_pc);
1838 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001839 break;
1840 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001841
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001842 case Instruction::CONST_16: {
1843 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001844 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s(), dex_pc);
1845 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001846 break;
1847 }
1848
Dave Allison20dfc792014-06-16 20:44:29 -07001849 case Instruction::CONST: {
1850 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001851 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i(), dex_pc);
1852 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001853 break;
1854 }
1855
1856 case Instruction::CONST_HIGH16: {
1857 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001858 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16, dex_pc);
1859 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001860 break;
1861 }
1862
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001863 case Instruction::CONST_WIDE_16: {
1864 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001865 // Get 16 bits of constant value, sign extended to 64 bits.
1866 int64_t value = instruction.VRegB_21s();
1867 value <<= 48;
1868 value >>= 48;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001869 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1870 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001871 break;
1872 }
1873
1874 case Instruction::CONST_WIDE_32: {
1875 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001876 // Get 32 bits of constant value, sign extended to 64 bits.
1877 int64_t value = instruction.VRegB_31i();
1878 value <<= 32;
1879 value >>= 32;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001880 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1881 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001882 break;
1883 }
1884
1885 case Instruction::CONST_WIDE: {
1886 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001887 HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l(), dex_pc);
1888 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001889 break;
1890 }
1891
Dave Allison20dfc792014-06-16 20:44:29 -07001892 case Instruction::CONST_WIDE_HIGH16: {
1893 int32_t register_index = instruction.VRegA();
1894 int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001895 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1896 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001897 break;
1898 }
1899
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001900 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001901 case Instruction::MOVE:
1902 case Instruction::MOVE_FROM16:
1903 case Instruction::MOVE_16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001904 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
1905 UpdateLocal(instruction.VRegA(), value, dex_pc);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001906 break;
1907 }
1908
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001909 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001910 case Instruction::MOVE_WIDE:
1911 case Instruction::MOVE_WIDE_FROM16:
1912 case Instruction::MOVE_WIDE_16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001913 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong, dex_pc);
1914 UpdateLocal(instruction.VRegA(), value, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001915 break;
1916 }
1917
1918 case Instruction::MOVE_OBJECT:
1919 case Instruction::MOVE_OBJECT_16:
1920 case Instruction::MOVE_OBJECT_FROM16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001921 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot, dex_pc);
1922 UpdateLocal(instruction.VRegA(), value, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001923 break;
1924 }
1925
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001926 case Instruction::RETURN_VOID_NO_BARRIER:
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001927 case Instruction::RETURN_VOID: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001928 BuildReturn(instruction, Primitive::kPrimVoid, dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001929 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001930 }
1931
Dave Allison20dfc792014-06-16 20:44:29 -07001932#define IF_XX(comparison, cond) \
Calin Juravle225ff812014-11-13 16:46:39 +00001933 case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \
1934 case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001935
Dave Allison20dfc792014-06-16 20:44:29 -07001936 IF_XX(HEqual, EQ);
1937 IF_XX(HNotEqual, NE);
1938 IF_XX(HLessThan, LT);
1939 IF_XX(HLessThanOrEqual, LE);
1940 IF_XX(HGreaterThan, GT);
1941 IF_XX(HGreaterThanOrEqual, GE);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001942
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001943 case Instruction::GOTO:
1944 case Instruction::GOTO_16:
1945 case Instruction::GOTO_32: {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001946 int32_t offset = instruction.GetTargetOffset();
Calin Juravle225ff812014-11-13 16:46:39 +00001947 HBasicBlock* target = FindBlockStartingAt(offset + dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001948 DCHECK(target != nullptr);
David Brazdil852eaff2015-02-02 15:23:05 +00001949 PotentiallyAddSuspendCheck(target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001950 current_block_->AddInstruction(new (arena_) HGoto(dex_pc));
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001951 current_block_->AddSuccessor(target);
1952 current_block_ = nullptr;
1953 break;
1954 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001955
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001956 case Instruction::RETURN: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001957 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001958 break;
1959 }
1960
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001961 case Instruction::RETURN_OBJECT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001962 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001963 break;
1964 }
1965
1966 case Instruction::RETURN_WIDE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001967 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001968 break;
1969 }
1970
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001971 case Instruction::INVOKE_DIRECT:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001972 case Instruction::INVOKE_INTERFACE:
1973 case Instruction::INVOKE_STATIC:
1974 case Instruction::INVOKE_SUPER:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001975 case Instruction::INVOKE_VIRTUAL:
1976 case Instruction::INVOKE_VIRTUAL_QUICK: {
1977 uint16_t method_idx;
1978 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_QUICK) {
1979 if (!CanDecodeQuickenedInfo()) {
1980 return false;
1981 }
1982 method_idx = LookupQuickenedInfo(dex_pc);
1983 } else {
1984 method_idx = instruction.VRegB_35c();
1985 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001986 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001987 uint32_t args[5];
Ian Rogers29a26482014-05-02 15:27:29 -07001988 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00001989 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001990 number_of_vreg_arguments, false, args, -1)) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001991 return false;
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001992 }
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001993 break;
1994 }
1995
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001996 case Instruction::INVOKE_DIRECT_RANGE:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001997 case Instruction::INVOKE_INTERFACE_RANGE:
1998 case Instruction::INVOKE_STATIC_RANGE:
1999 case Instruction::INVOKE_SUPER_RANGE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002000 case Instruction::INVOKE_VIRTUAL_RANGE:
2001 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK: {
2002 uint16_t method_idx;
2003 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK) {
2004 if (!CanDecodeQuickenedInfo()) {
2005 return false;
2006 }
2007 method_idx = LookupQuickenedInfo(dex_pc);
2008 } else {
2009 method_idx = instruction.VRegB_3rc();
2010 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002011 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2012 uint32_t register_index = instruction.VRegC();
Calin Juravle225ff812014-11-13 16:46:39 +00002013 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002014 number_of_vreg_arguments, true, nullptr, register_index)) {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01002015 return false;
2016 }
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00002017 break;
2018 }
2019
Roland Levillain88cb1752014-10-20 16:36:47 +01002020 case Instruction::NEG_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002021 Unop_12x<HNeg>(instruction, Primitive::kPrimInt, dex_pc);
Roland Levillain88cb1752014-10-20 16:36:47 +01002022 break;
2023 }
2024
Roland Levillain2e07b4f2014-10-23 18:12:09 +01002025 case Instruction::NEG_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002026 Unop_12x<HNeg>(instruction, Primitive::kPrimLong, dex_pc);
Roland Levillain2e07b4f2014-10-23 18:12:09 +01002027 break;
2028 }
2029
Roland Levillain3dbcb382014-10-28 17:30:07 +00002030 case Instruction::NEG_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002031 Unop_12x<HNeg>(instruction, Primitive::kPrimFloat, dex_pc);
Roland Levillain3dbcb382014-10-28 17:30:07 +00002032 break;
2033 }
2034
2035 case Instruction::NEG_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002036 Unop_12x<HNeg>(instruction, Primitive::kPrimDouble, dex_pc);
Roland Levillain3dbcb382014-10-28 17:30:07 +00002037 break;
2038 }
2039
Roland Levillain1cc5f2512014-10-22 18:06:21 +01002040 case Instruction::NOT_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002041 Unop_12x<HNot>(instruction, Primitive::kPrimInt, dex_pc);
Roland Levillain1cc5f2512014-10-22 18:06:21 +01002042 break;
2043 }
2044
Roland Levillain70566432014-10-24 16:20:17 +01002045 case Instruction::NOT_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002046 Unop_12x<HNot>(instruction, Primitive::kPrimLong, dex_pc);
Roland Levillain70566432014-10-24 16:20:17 +01002047 break;
2048 }
2049
Roland Levillaindff1f282014-11-05 14:15:05 +00002050 case Instruction::INT_TO_LONG: {
Roland Levillain624279f2014-12-04 11:54:28 +00002051 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc);
Roland Levillaindff1f282014-11-05 14:15:05 +00002052 break;
2053 }
2054
Roland Levillaincff13742014-11-17 14:32:17 +00002055 case Instruction::INT_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002056 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00002057 break;
2058 }
2059
2060 case Instruction::INT_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002061 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00002062 break;
2063 }
2064
Roland Levillain946e1432014-11-11 17:35:19 +00002065 case Instruction::LONG_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002066 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc);
Roland Levillain946e1432014-11-11 17:35:19 +00002067 break;
2068 }
2069
Roland Levillain6d0e4832014-11-27 18:31:21 +00002070 case Instruction::LONG_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002071 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc);
Roland Levillain6d0e4832014-11-27 18:31:21 +00002072 break;
2073 }
2074
Roland Levillain647b9ed2014-11-27 12:06:00 +00002075 case Instruction::LONG_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002076 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc);
Roland Levillain647b9ed2014-11-27 12:06:00 +00002077 break;
2078 }
2079
Roland Levillain3f8f9362014-12-02 17:45:01 +00002080 case Instruction::FLOAT_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002081 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc);
2082 break;
2083 }
2084
2085 case Instruction::FLOAT_TO_LONG: {
2086 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc);
Roland Levillain3f8f9362014-12-02 17:45:01 +00002087 break;
2088 }
2089
Roland Levillain8964e2b2014-12-04 12:10:50 +00002090 case Instruction::FLOAT_TO_DOUBLE: {
2091 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc);
2092 break;
2093 }
2094
Roland Levillain4c0b61f2014-12-05 12:06:01 +00002095 case Instruction::DOUBLE_TO_INT: {
2096 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc);
2097 break;
2098 }
2099
2100 case Instruction::DOUBLE_TO_LONG: {
2101 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc);
2102 break;
2103 }
2104
Roland Levillain8964e2b2014-12-04 12:10:50 +00002105 case Instruction::DOUBLE_TO_FLOAT: {
2106 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc);
2107 break;
2108 }
2109
Roland Levillain51d3fc42014-11-13 14:11:42 +00002110 case Instruction::INT_TO_BYTE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002111 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc);
Roland Levillain51d3fc42014-11-13 14:11:42 +00002112 break;
2113 }
2114
Roland Levillain01a8d712014-11-14 16:27:39 +00002115 case Instruction::INT_TO_SHORT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002116 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc);
Roland Levillain01a8d712014-11-14 16:27:39 +00002117 break;
2118 }
2119
Roland Levillain981e4542014-11-14 11:47:14 +00002120 case Instruction::INT_TO_CHAR: {
Roland Levillain624279f2014-12-04 11:54:28 +00002121 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc);
Roland Levillain981e4542014-11-14 11:47:14 +00002122 break;
2123 }
2124
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002125 case Instruction::ADD_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002126 Binop_23x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002127 break;
2128 }
2129
2130 case Instruction::ADD_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002131 Binop_23x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002132 break;
2133 }
2134
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002135 case Instruction::ADD_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002136 Binop_23x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002137 break;
2138 }
2139
2140 case Instruction::ADD_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002141 Binop_23x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002142 break;
2143 }
2144
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002145 case Instruction::SUB_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002146 Binop_23x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002147 break;
2148 }
2149
2150 case Instruction::SUB_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002151 Binop_23x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002152 break;
2153 }
2154
Calin Juravle096cc022014-10-23 17:01:13 +01002155 case Instruction::SUB_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002156 Binop_23x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002157 break;
2158 }
2159
2160 case Instruction::SUB_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002161 Binop_23x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002162 break;
2163 }
2164
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002165 case Instruction::ADD_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002166 Binop_12x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002167 break;
2168 }
2169
Calin Juravle34bacdf2014-10-07 20:23:36 +01002170 case Instruction::MUL_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002171 Binop_23x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002172 break;
2173 }
2174
2175 case Instruction::MUL_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002176 Binop_23x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002177 break;
2178 }
2179
Calin Juravleb5bfa962014-10-21 18:02:24 +01002180 case Instruction::MUL_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002181 Binop_23x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002182 break;
2183 }
2184
2185 case Instruction::MUL_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002186 Binop_23x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002187 break;
2188 }
2189
Calin Juravled0d48522014-11-04 16:40:20 +00002190 case Instruction::DIV_INT: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002191 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2192 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravled0d48522014-11-04 16:40:20 +00002193 break;
2194 }
2195
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002196 case Instruction::DIV_LONG: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002197 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2198 dex_pc, Primitive::kPrimLong, false, true);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002199 break;
2200 }
2201
Calin Juravle7c4954d2014-10-28 16:57:40 +00002202 case Instruction::DIV_FLOAT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002203 Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002204 break;
2205 }
2206
2207 case Instruction::DIV_DOUBLE: {
Calin Juravle225ff812014-11-13 16:46:39 +00002208 Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002209 break;
2210 }
2211
Calin Juravlebacfec32014-11-14 15:54:36 +00002212 case Instruction::REM_INT: {
2213 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2214 dex_pc, Primitive::kPrimInt, false, false);
2215 break;
2216 }
2217
2218 case Instruction::REM_LONG: {
2219 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2220 dex_pc, Primitive::kPrimLong, false, false);
2221 break;
2222 }
2223
Calin Juravled2ec87d2014-12-08 14:24:46 +00002224 case Instruction::REM_FLOAT: {
2225 Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2226 break;
2227 }
2228
2229 case Instruction::REM_DOUBLE: {
2230 Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2231 break;
2232 }
2233
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002234 case Instruction::AND_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002235 Binop_23x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002236 break;
2237 }
2238
2239 case Instruction::AND_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002240 Binop_23x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002241 break;
2242 }
2243
Calin Juravle9aec02f2014-11-18 23:06:35 +00002244 case Instruction::SHL_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002245 Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002246 break;
2247 }
2248
2249 case Instruction::SHL_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002250 Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002251 break;
2252 }
2253
2254 case Instruction::SHR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002255 Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002256 break;
2257 }
2258
2259 case Instruction::SHR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002260 Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002261 break;
2262 }
2263
2264 case Instruction::USHR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002265 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002266 break;
2267 }
2268
2269 case Instruction::USHR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002270 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002271 break;
2272 }
2273
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002274 case Instruction::OR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002275 Binop_23x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002276 break;
2277 }
2278
2279 case Instruction::OR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002280 Binop_23x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002281 break;
2282 }
2283
2284 case Instruction::XOR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002285 Binop_23x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002286 break;
2287 }
2288
2289 case Instruction::XOR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002290 Binop_23x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002291 break;
2292 }
2293
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002294 case Instruction::ADD_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002295 Binop_12x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002296 break;
2297 }
2298
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002299 case Instruction::ADD_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002300 Binop_12x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002301 break;
2302 }
2303
2304 case Instruction::ADD_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002305 Binop_12x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002306 break;
2307 }
2308
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002309 case Instruction::SUB_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002310 Binop_12x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002311 break;
2312 }
2313
2314 case Instruction::SUB_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002315 Binop_12x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002316 break;
2317 }
2318
Calin Juravle096cc022014-10-23 17:01:13 +01002319 case Instruction::SUB_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002320 Binop_12x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002321 break;
2322 }
2323
2324 case Instruction::SUB_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002325 Binop_12x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002326 break;
2327 }
2328
Calin Juravle34bacdf2014-10-07 20:23:36 +01002329 case Instruction::MUL_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002330 Binop_12x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002331 break;
2332 }
2333
2334 case Instruction::MUL_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002335 Binop_12x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002336 break;
2337 }
2338
Calin Juravleb5bfa962014-10-21 18:02:24 +01002339 case Instruction::MUL_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002340 Binop_12x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002341 break;
2342 }
2343
2344 case Instruction::MUL_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002345 Binop_12x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002346 break;
2347 }
2348
Calin Juravle865fc882014-11-06 17:09:03 +00002349 case Instruction::DIV_INT_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002350 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2351 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravle865fc882014-11-06 17:09:03 +00002352 break;
2353 }
2354
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002355 case Instruction::DIV_LONG_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002356 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2357 dex_pc, Primitive::kPrimLong, false, true);
2358 break;
2359 }
2360
2361 case Instruction::REM_INT_2ADDR: {
2362 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2363 dex_pc, Primitive::kPrimInt, false, false);
2364 break;
2365 }
2366
2367 case Instruction::REM_LONG_2ADDR: {
2368 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2369 dex_pc, Primitive::kPrimLong, false, false);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002370 break;
2371 }
2372
Calin Juravled2ec87d2014-12-08 14:24:46 +00002373 case Instruction::REM_FLOAT_2ADDR: {
2374 Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2375 break;
2376 }
2377
2378 case Instruction::REM_DOUBLE_2ADDR: {
2379 Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2380 break;
2381 }
2382
Calin Juravle9aec02f2014-11-18 23:06:35 +00002383 case Instruction::SHL_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002384 Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002385 break;
2386 }
2387
2388 case Instruction::SHL_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002389 Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002390 break;
2391 }
2392
2393 case Instruction::SHR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002394 Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002395 break;
2396 }
2397
2398 case Instruction::SHR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002399 Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002400 break;
2401 }
2402
2403 case Instruction::USHR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002404 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002405 break;
2406 }
2407
2408 case Instruction::USHR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002409 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002410 break;
2411 }
2412
Calin Juravle7c4954d2014-10-28 16:57:40 +00002413 case Instruction::DIV_FLOAT_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002414 Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002415 break;
2416 }
2417
2418 case Instruction::DIV_DOUBLE_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002419 Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002420 break;
2421 }
2422
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002423 case Instruction::AND_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002424 Binop_12x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002425 break;
2426 }
2427
2428 case Instruction::AND_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002429 Binop_12x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002430 break;
2431 }
2432
2433 case Instruction::OR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002434 Binop_12x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002435 break;
2436 }
2437
2438 case Instruction::OR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002439 Binop_12x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002440 break;
2441 }
2442
2443 case Instruction::XOR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002444 Binop_12x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002445 break;
2446 }
2447
2448 case Instruction::XOR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002449 Binop_12x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002450 break;
2451 }
2452
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002453 case Instruction::ADD_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002454 Binop_22s<HAdd>(instruction, false, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002455 break;
2456 }
2457
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002458 case Instruction::AND_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002459 Binop_22s<HAnd>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002460 break;
2461 }
2462
2463 case Instruction::OR_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002464 Binop_22s<HOr>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002465 break;
2466 }
2467
2468 case Instruction::XOR_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002469 Binop_22s<HXor>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002470 break;
2471 }
2472
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002473 case Instruction::RSUB_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002474 Binop_22s<HSub>(instruction, true, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002475 break;
2476 }
2477
Calin Juravle34bacdf2014-10-07 20:23:36 +01002478 case Instruction::MUL_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002479 Binop_22s<HMul>(instruction, false, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002480 break;
2481 }
2482
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002483 case Instruction::ADD_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002484 Binop_22b<HAdd>(instruction, false, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002485 break;
2486 }
2487
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002488 case Instruction::AND_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002489 Binop_22b<HAnd>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002490 break;
2491 }
2492
2493 case Instruction::OR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002494 Binop_22b<HOr>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002495 break;
2496 }
2497
2498 case Instruction::XOR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002499 Binop_22b<HXor>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002500 break;
2501 }
2502
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002503 case Instruction::RSUB_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002504 Binop_22b<HSub>(instruction, true, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002505 break;
2506 }
2507
Calin Juravle34bacdf2014-10-07 20:23:36 +01002508 case Instruction::MUL_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002509 Binop_22b<HMul>(instruction, false, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002510 break;
2511 }
2512
Calin Juravled0d48522014-11-04 16:40:20 +00002513 case Instruction::DIV_INT_LIT16:
2514 case Instruction::DIV_INT_LIT8: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002515 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2516 dex_pc, Primitive::kPrimInt, true, true);
2517 break;
2518 }
2519
2520 case Instruction::REM_INT_LIT16:
2521 case Instruction::REM_INT_LIT8: {
2522 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2523 dex_pc, Primitive::kPrimInt, true, false);
Calin Juravled0d48522014-11-04 16:40:20 +00002524 break;
2525 }
2526
Calin Juravle9aec02f2014-11-18 23:06:35 +00002527 case Instruction::SHL_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002528 Binop_22b<HShl>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002529 break;
2530 }
2531
2532 case Instruction::SHR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002533 Binop_22b<HShr>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002534 break;
2535 }
2536
2537 case Instruction::USHR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002538 Binop_22b<HUShr>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002539 break;
2540 }
2541
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002542 case Instruction::NEW_INSTANCE: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002543 uint16_t type_index = instruction.VRegB_21c();
Jeff Hao848f70a2014-01-15 13:49:50 -08002544 if (compiler_driver_->IsStringTypeIndex(type_index, dex_file_)) {
Jeff Hao848f70a2014-01-15 13:49:50 -08002545 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002546 HFakeString* fake_string = new (arena_) HFakeString(dex_pc);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +01002547 current_block_->AddInstruction(fake_string);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002548 UpdateLocal(register_index, fake_string, dex_pc);
Jeff Hao848f70a2014-01-15 13:49:50 -08002549 } else {
2550 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2551 ? kQuickAllocObjectWithAccessCheck
2552 : kQuickAllocObject;
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002553
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002554 current_block_->AddInstruction(new (arena_) HNewInstance(
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002555 graph_->GetCurrentMethod(),
2556 dex_pc,
2557 type_index,
2558 *dex_compilation_unit_->GetDexFile(),
2559 entrypoint));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002560 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Jeff Hao848f70a2014-01-15 13:49:50 -08002561 }
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002562 break;
2563 }
2564
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002565 case Instruction::NEW_ARRAY: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002566 uint16_t type_index = instruction.VRegC_22c();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002567 HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt, dex_pc);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002568 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2569 ? kQuickAllocArrayWithAccessCheck
2570 : kQuickAllocArray;
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002571 current_block_->AddInstruction(new (arena_) HNewArray(length,
2572 graph_->GetCurrentMethod(),
2573 dex_pc,
2574 type_index,
2575 *dex_compilation_unit_->GetDexFile(),
2576 entrypoint));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002577 UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002578 break;
2579 }
2580
2581 case Instruction::FILLED_NEW_ARRAY: {
2582 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
2583 uint32_t type_index = instruction.VRegB_35c();
2584 uint32_t args[5];
2585 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00002586 BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002587 break;
2588 }
2589
2590 case Instruction::FILLED_NEW_ARRAY_RANGE: {
2591 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2592 uint32_t type_index = instruction.VRegB_3rc();
2593 uint32_t register_index = instruction.VRegC_3rc();
2594 BuildFilledNewArray(
Calin Juravle225ff812014-11-13 16:46:39 +00002595 dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002596 break;
2597 }
2598
2599 case Instruction::FILL_ARRAY_DATA: {
Calin Juravle225ff812014-11-13 16:46:39 +00002600 BuildFillArrayData(instruction, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002601 break;
2602 }
2603
Nicolas Geoffrayddb311f2014-05-16 09:28:54 +01002604 case Instruction::MOVE_RESULT:
Dave Allison20dfc792014-06-16 20:44:29 -07002605 case Instruction::MOVE_RESULT_WIDE:
David Brazdilfc6a86a2015-06-26 10:33:45 +00002606 case Instruction::MOVE_RESULT_OBJECT: {
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002607 if (latest_result_ == nullptr) {
2608 // Only dead code can lead to this situation, where the verifier
2609 // does not reject the method.
2610 } else {
David Brazdilfc6a86a2015-06-26 10:33:45 +00002611 // An Invoke/FilledNewArray and its MoveResult could have landed in
2612 // different blocks if there was a try/catch block boundary between
2613 // them. For Invoke, we insert a StoreLocal after the instruction. For
2614 // FilledNewArray, the local needs to be updated after the array was
2615 // filled, otherwise we might overwrite an input vreg.
2616 HStoreLocal* update_local =
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002617 new (arena_) HStoreLocal(GetLocalAt(instruction.VRegA()), latest_result_, dex_pc);
David Brazdilfc6a86a2015-06-26 10:33:45 +00002618 HBasicBlock* block = latest_result_->GetBlock();
2619 if (block == current_block_) {
2620 // MoveResult and the previous instruction are in the same block.
2621 current_block_->AddInstruction(update_local);
2622 } else {
2623 // The two instructions are in different blocks. Insert the MoveResult
2624 // before the final control-flow instruction of the previous block.
2625 DCHECK(block->EndsWithControlFlowInstruction());
2626 DCHECK(current_block_->GetInstructions().IsEmpty());
2627 block->InsertInstructionBefore(update_local, block->GetLastInstruction());
2628 }
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002629 latest_result_ = nullptr;
2630 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002631 break;
David Brazdilfc6a86a2015-06-26 10:33:45 +00002632 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002633
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002634 case Instruction::CMP_LONG: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002635 Binop_23x_cmp(instruction, Primitive::kPrimLong, ComparisonBias::kNoBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002636 break;
2637 }
2638
2639 case Instruction::CMPG_FLOAT: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002640 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002641 break;
2642 }
2643
2644 case Instruction::CMPG_DOUBLE: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002645 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002646 break;
2647 }
2648
2649 case Instruction::CMPL_FLOAT: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002650 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kLtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002651 break;
2652 }
2653
2654 case Instruction::CMPL_DOUBLE: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002655 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kLtBias, dex_pc);
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002656 break;
2657 }
2658
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00002659 case Instruction::NOP:
2660 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00002661
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002662 case Instruction::IGET:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002663 case Instruction::IGET_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002664 case Instruction::IGET_WIDE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002665 case Instruction::IGET_WIDE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002666 case Instruction::IGET_OBJECT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002667 case Instruction::IGET_OBJECT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002668 case Instruction::IGET_BOOLEAN:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002669 case Instruction::IGET_BOOLEAN_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002670 case Instruction::IGET_BYTE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002671 case Instruction::IGET_BYTE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002672 case Instruction::IGET_CHAR:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002673 case Instruction::IGET_CHAR_QUICK:
2674 case Instruction::IGET_SHORT:
2675 case Instruction::IGET_SHORT_QUICK: {
Calin Juravle225ff812014-11-13 16:46:39 +00002676 if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002677 return false;
2678 }
2679 break;
2680 }
2681
2682 case Instruction::IPUT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002683 case Instruction::IPUT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002684 case Instruction::IPUT_WIDE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002685 case Instruction::IPUT_WIDE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002686 case Instruction::IPUT_OBJECT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002687 case Instruction::IPUT_OBJECT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002688 case Instruction::IPUT_BOOLEAN:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002689 case Instruction::IPUT_BOOLEAN_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002690 case Instruction::IPUT_BYTE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002691 case Instruction::IPUT_BYTE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002692 case Instruction::IPUT_CHAR:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002693 case Instruction::IPUT_CHAR_QUICK:
2694 case Instruction::IPUT_SHORT:
2695 case Instruction::IPUT_SHORT_QUICK: {
Calin Juravle225ff812014-11-13 16:46:39 +00002696 if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002697 return false;
2698 }
2699 break;
2700 }
2701
2702 case Instruction::SGET:
2703 case Instruction::SGET_WIDE:
2704 case Instruction::SGET_OBJECT:
2705 case Instruction::SGET_BOOLEAN:
2706 case Instruction::SGET_BYTE:
2707 case Instruction::SGET_CHAR:
2708 case Instruction::SGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002709 if (!BuildStaticFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002710 return false;
2711 }
2712 break;
2713 }
2714
2715 case Instruction::SPUT:
2716 case Instruction::SPUT_WIDE:
2717 case Instruction::SPUT_OBJECT:
2718 case Instruction::SPUT_BOOLEAN:
2719 case Instruction::SPUT_BYTE:
2720 case Instruction::SPUT_CHAR:
2721 case Instruction::SPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002722 if (!BuildStaticFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002723 return false;
2724 }
2725 break;
2726 }
2727
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002728#define ARRAY_XX(kind, anticipated_type) \
2729 case Instruction::AGET##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002730 BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002731 break; \
2732 } \
2733 case Instruction::APUT##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002734 BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002735 break; \
2736 }
2737
2738 ARRAY_XX(, Primitive::kPrimInt);
2739 ARRAY_XX(_WIDE, Primitive::kPrimLong);
2740 ARRAY_XX(_OBJECT, Primitive::kPrimNot);
2741 ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean);
2742 ARRAY_XX(_BYTE, Primitive::kPrimByte);
2743 ARRAY_XX(_CHAR, Primitive::kPrimChar);
2744 ARRAY_XX(_SHORT, Primitive::kPrimShort);
2745
Nicolas Geoffray39468442014-09-02 15:17:15 +01002746 case Instruction::ARRAY_LENGTH: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002747 HInstruction* object = LoadLocal(instruction.VRegB_12x(), Primitive::kPrimNot, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002748 // No need for a temporary for the null check, it is the only input of the following
2749 // instruction.
Calin Juravle225ff812014-11-13 16:46:39 +00002750 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002751 current_block_->AddInstruction(object);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002752 current_block_->AddInstruction(new (arena_) HArrayLength(object, dex_pc));
2753 UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray39468442014-09-02 15:17:15 +01002754 break;
2755 }
2756
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002757 case Instruction::CONST_STRING: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002758 current_block_->AddInstruction(
2759 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_21c(), dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002760 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002761 break;
2762 }
2763
2764 case Instruction::CONST_STRING_JUMBO: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002765 current_block_->AddInstruction(
2766 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_31c(), dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002767 UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002768 break;
2769 }
2770
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002771 case Instruction::CONST_CLASS: {
2772 uint16_t type_index = instruction.VRegB_21c();
2773 bool type_known_final;
2774 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002775 bool dont_use_is_referrers_class;
2776 // `CanAccessTypeWithoutChecks` will tell whether the method being
2777 // built is trying to access its own class, so that the generated
2778 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002779 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002780 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
2781 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002782 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002783 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00002784 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002785 return false;
2786 }
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002787 current_block_->AddInstruction(new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01002788 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002789 type_index,
2790 *dex_compilation_unit_->GetDexFile(),
2791 IsOutermostCompilingClass(type_index),
2792 dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002793 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002794 break;
2795 }
2796
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002797 case Instruction::MOVE_EXCEPTION: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002798 current_block_->AddInstruction(new (arena_) HLoadException(dex_pc));
2799 UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction(), dex_pc);
2800 current_block_->AddInstruction(new (arena_) HClearException(dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002801 break;
2802 }
2803
2804 case Instruction::THROW: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002805 HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00002806 current_block_->AddInstruction(new (arena_) HThrow(exception, dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002807 // A throw instruction must branch to the exit block.
2808 current_block_->AddSuccessor(exit_block_);
2809 // We finished building this block. Set the current block to null to avoid
2810 // adding dead instructions to it.
2811 current_block_ = nullptr;
2812 break;
2813 }
2814
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002815 case Instruction::INSTANCE_OF: {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002816 uint8_t destination = instruction.VRegA_22c();
2817 uint8_t reference = instruction.VRegB_22c();
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002818 uint16_t type_index = instruction.VRegC_22c();
Calin Juravle225ff812014-11-13 16:46:39 +00002819 if (!BuildTypeCheck(instruction, destination, reference, type_index, dex_pc)) {
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002820 return false;
2821 }
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002822 break;
2823 }
2824
2825 case Instruction::CHECK_CAST: {
2826 uint8_t reference = instruction.VRegA_21c();
2827 uint16_t type_index = instruction.VRegB_21c();
Calin Juravle225ff812014-11-13 16:46:39 +00002828 if (!BuildTypeCheck(instruction, -1, reference, type_index, dex_pc)) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002829 return false;
2830 }
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002831 break;
2832 }
2833
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002834 case Instruction::MONITOR_ENTER: {
2835 current_block_->AddInstruction(new (arena_) HMonitorOperation(
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002836 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc),
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002837 HMonitorOperation::kEnter,
Calin Juravle225ff812014-11-13 16:46:39 +00002838 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002839 break;
2840 }
2841
2842 case Instruction::MONITOR_EXIT: {
2843 current_block_->AddInstruction(new (arena_) HMonitorOperation(
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002844 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc),
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002845 HMonitorOperation::kExit,
Calin Juravle225ff812014-11-13 16:46:39 +00002846 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002847 break;
2848 }
2849
Andreas Gamped881df52014-11-24 23:28:39 -08002850 case Instruction::PACKED_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002851 BuildPackedSwitch(instruction, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08002852 break;
2853 }
2854
Andreas Gampee4d4d322014-12-04 09:09:57 -08002855 case Instruction::SPARSE_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002856 BuildSparseSwitch(instruction, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08002857 break;
2858 }
2859
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002860 default:
Calin Juravle48c2b032014-12-09 18:11:36 +00002861 VLOG(compiler) << "Did not compile "
2862 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
2863 << " because of unhandled instruction "
2864 << instruction.Name();
2865 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002866 return false;
2867 }
2868 return true;
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00002869} // NOLINT(readability/fn_size)
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002870
Vladimir Marko2aaa4b52015-09-17 17:03:26 +01002871HLocal* HGraphBuilder::GetLocalAt(uint32_t register_index) const {
2872 DCHECK_LT(register_index, locals_.size());
2873 return locals_[register_index];
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002874}
2875
Vladimir Marko2aaa4b52015-09-17 17:03:26 +01002876void HGraphBuilder::UpdateLocal(uint32_t register_index,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002877 HInstruction* instruction,
2878 uint32_t dex_pc) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002879 HLocal* local = GetLocalAt(register_index);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002880 current_block_->AddInstruction(new (arena_) HStoreLocal(local, instruction, dex_pc));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002881}
2882
Vladimir Marko2aaa4b52015-09-17 17:03:26 +01002883HInstruction* HGraphBuilder::LoadLocal(uint32_t register_index,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002884 Primitive::Type type,
2885 uint32_t dex_pc) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002886 HLocal* local = GetLocalAt(register_index);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002887 current_block_->AddInstruction(new (arena_) HLoadLocal(local, type, dex_pc));
Nicolas Geoffray787c3072014-03-17 10:20:19 +00002888 return current_block_->GetLastInstruction();
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002889}
2890
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002891} // namespace art