blob: 007e9283d833d22709957f80a054250672f45370 [file] [log] [blame]
Eugene Zelenko7cf6af52017-08-29 22:32:07 +00001//===- InlineSpiller.cpp - Insert spills and restores inline --------------===//
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// The inline spiller modifies the machine function directly instead of
11// inserting spills and restores in VirtRegMap.
12//
13//===----------------------------------------------------------------------===//
14
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000015#include "LiveRangeCalc.h"
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000016#include "Spiller.h"
Wei Mi825e5aa2016-05-11 22:37:43 +000017#include "SplitKit.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000018#include "llvm/ADT/ArrayRef.h"
19#include "llvm/ADT/DenseMap.h"
Wei Mi815b02e2016-04-13 03:08:27 +000020#include "llvm/ADT/MapVector.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000021#include "llvm/ADT/None.h"
22#include "llvm/ADT/STLExtras.h"
Benjamin Kramer2db14ba2013-05-23 15:42:57 +000023#include "llvm/ADT/SetVector.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000024#include "llvm/ADT/SmallPtrSet.h"
25#include "llvm/ADT/SmallVector.h"
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000026#include "llvm/ADT/Statistic.h"
Jakob Stoklund Olesene93198a2010-11-10 23:55:56 +000027#include "llvm/Analysis/AliasAnalysis.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000028#include "llvm/CodeGen/LiveInterval.h"
Matthias Braunfa621d22017-12-13 02:51:04 +000029#include "llvm/CodeGen/LiveIntervals.h"
Pete Cooper789d5d82012-04-02 22:44:18 +000030#include "llvm/CodeGen/LiveRangeEdit.h"
Matthias Braun209f0482017-12-18 23:19:44 +000031#include "llvm/CodeGen/LiveStacks.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000032#include "llvm/CodeGen/MachineBasicBlock.h"
Benjamin Kramer4eed7562013-06-17 19:00:36 +000033#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
Chandler Carruth974a4452014-01-07 11:48:04 +000034#include "llvm/CodeGen/MachineDominators.h"
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000035#include "llvm/CodeGen/MachineFunction.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000036#include "llvm/CodeGen/MachineFunctionPass.h"
37#include "llvm/CodeGen/MachineInstr.h"
David Blaikie6d9dbd52013-06-16 20:34:15 +000038#include "llvm/CodeGen/MachineInstrBuilder.h"
Chandler Carruthd04a8d42012-12-03 16:50:05 +000039#include "llvm/CodeGen/MachineInstrBundle.h"
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +000040#include "llvm/CodeGen/MachineLoopInfo.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000041#include "llvm/CodeGen/MachineOperand.h"
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000042#include "llvm/CodeGen/MachineRegisterInfo.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000043#include "llvm/CodeGen/SlotIndexes.h"
David Blaikie48319232017-11-08 01:01:31 +000044#include "llvm/CodeGen/TargetInstrInfo.h"
David Blaikiee3a9b4c2017-11-17 01:07:10 +000045#include "llvm/CodeGen/TargetOpcodes.h"
46#include "llvm/CodeGen/TargetRegisterInfo.h"
47#include "llvm/CodeGen/TargetSubtargetInfo.h"
Jakob Stoklund Olesen1ead68d2012-11-28 19:13:06 +000048#include "llvm/CodeGen/VirtRegMap.h"
Nico Weber0f38c602018-04-30 14:59:11 +000049#include "llvm/Config/llvm-config.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000050#include "llvm/Support/BlockFrequency.h"
51#include "llvm/Support/BranchProbability.h"
Jakob Stoklund Olesenb9edad02011-09-15 21:06:00 +000052#include "llvm/Support/CommandLine.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000053#include "llvm/Support/Compiler.h"
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000054#include "llvm/Support/Debug.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000055#include "llvm/Support/ErrorHandling.h"
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000056#include "llvm/Support/raw_ostream.h"
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000057#include <cassert>
58#include <iterator>
59#include <tuple>
60#include <utility>
61#include <vector>
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000062
63using namespace llvm;
64
Chandler Carruth8677f2f2014-04-22 02:02:50 +000065#define DEBUG_TYPE "regalloc"
66
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000067STATISTIC(NumSpilledRanges, "Number of spilled live ranges");
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +000068STATISTIC(NumSnippets, "Number of spilled snippets");
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000069STATISTIC(NumSpills, "Number of spills inserted");
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +000070STATISTIC(NumSpillsRemoved, "Number of spills removed");
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000071STATISTIC(NumReloads, "Number of reloads inserted");
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +000072STATISTIC(NumReloadsRemoved, "Number of reloads removed");
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000073STATISTIC(NumFolded, "Number of folded stack accesses");
74STATISTIC(NumFoldedLoads, "Number of folded loads");
75STATISTIC(NumRemats, "Number of rematerialized defs for spilling");
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +000076
Jakob Stoklund Olesenb9edad02011-09-15 21:06:00 +000077static cl::opt<bool> DisableHoisting("disable-spill-hoist", cl::Hidden,
78 cl::desc("Disable inline spill hoisting"));
79
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +000080namespace {
Eugene Zelenko7cf6af52017-08-29 22:32:07 +000081
Wei Mi1f5a2c32016-04-15 23:16:44 +000082class HoistSpillHelper : private LiveRangeEdit::Delegate {
83 MachineFunction &MF;
Wei Mi815b02e2016-04-13 03:08:27 +000084 LiveIntervals &LIS;
85 LiveStacks &LSS;
86 AliasAnalysis *AA;
87 MachineDominatorTree &MDT;
88 MachineLoopInfo &Loops;
89 VirtRegMap &VRM;
Wei Mi815b02e2016-04-13 03:08:27 +000090 MachineRegisterInfo &MRI;
91 const TargetInstrInfo &TII;
92 const TargetRegisterInfo &TRI;
93 const MachineBlockFrequencyInfo &MBFI;
94
Wei Mi825e5aa2016-05-11 22:37:43 +000095 InsertPointAnalysis IPA;
96
Wei Mi57d83cb2017-09-13 21:41:30 +000097 // Map from StackSlot to the LiveInterval of the original register.
98 // Note the LiveInterval of the original register may have been deleted
99 // after it is spilled. We keep a copy here to track the range where
100 // spills can be moved.
101 DenseMap<int, std::unique_ptr<LiveInterval>> StackSlotToOrigLI;
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000102
Wei Mi815b02e2016-04-13 03:08:27 +0000103 // Map from pair of (StackSlot and Original VNI) to a set of spills which
104 // have the same stackslot and have equal values defined by Original VNI.
105 // These spills are mergeable and are hoist candiates.
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000106 using MergeableSpillsMap =
107 MapVector<std::pair<int, VNInfo *>, SmallPtrSet<MachineInstr *, 16>>;
Wei Mi815b02e2016-04-13 03:08:27 +0000108 MergeableSpillsMap MergeableSpills;
109
110 /// This is the map from original register to a set containing all its
111 /// siblings. To hoist a spill to another BB, we need to find out a live
112 /// sibling there and use it as the source of the new spill.
113 DenseMap<unsigned, SmallSetVector<unsigned, 16>> Virt2SiblingsMap;
114
Wei Mi57d83cb2017-09-13 21:41:30 +0000115 bool isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI,
116 MachineBasicBlock &BB, unsigned &LiveReg);
Wei Mi815b02e2016-04-13 03:08:27 +0000117
118 void rmRedundantSpills(
119 SmallPtrSet<MachineInstr *, 16> &Spills,
120 SmallVectorImpl<MachineInstr *> &SpillsToRm,
121 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill);
122
123 void getVisitOrders(
124 MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills,
125 SmallVectorImpl<MachineDomTreeNode *> &Orders,
126 SmallVectorImpl<MachineInstr *> &SpillsToRm,
127 DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep,
128 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill);
129
Wei Mi57d83cb2017-09-13 21:41:30 +0000130 void runHoistSpills(LiveInterval &OrigLI, VNInfo &OrigVNI,
Wei Mi815b02e2016-04-13 03:08:27 +0000131 SmallPtrSet<MachineInstr *, 16> &Spills,
132 SmallVectorImpl<MachineInstr *> &SpillsToRm,
133 DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns);
134
135public:
136 HoistSpillHelper(MachineFunctionPass &pass, MachineFunction &mf,
137 VirtRegMap &vrm)
Wei Mi1f5a2c32016-04-15 23:16:44 +0000138 : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()),
Wei Mi815b02e2016-04-13 03:08:27 +0000139 LSS(pass.getAnalysis<LiveStacks>()),
140 AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()),
141 MDT(pass.getAnalysis<MachineDominatorTree>()),
142 Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm),
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000143 MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()),
Wei Mi815b02e2016-04-13 03:08:27 +0000144 TRI(*mf.getSubtarget().getRegisterInfo()),
Wei Mi825e5aa2016-05-11 22:37:43 +0000145 MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()),
146 IPA(LIS, mf.getNumBlockIDs()) {}
Wei Mi815b02e2016-04-13 03:08:27 +0000147
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000148 void addToMergeableSpills(MachineInstr &Spill, int StackSlot,
Wei Mi815b02e2016-04-13 03:08:27 +0000149 unsigned Original);
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000150 bool rmFromMergeableSpills(MachineInstr &Spill, int StackSlot);
Wei Mi1f5a2c32016-04-15 23:16:44 +0000151 void hoistAllSpills();
152 void LRE_DidCloneVirtReg(unsigned, unsigned) override;
Wei Mi815b02e2016-04-13 03:08:27 +0000153};
154
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000155class InlineSpiller : public Spiller {
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000156 MachineFunction &MF;
157 LiveIntervals &LIS;
158 LiveStacks &LSS;
159 AliasAnalysis *AA;
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +0000160 MachineDominatorTree &MDT;
161 MachineLoopInfo &Loops;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000162 VirtRegMap &VRM;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000163 MachineRegisterInfo &MRI;
164 const TargetInstrInfo &TII;
165 const TargetRegisterInfo &TRI;
Benjamin Kramer4eed7562013-06-17 19:00:36 +0000166 const MachineBlockFrequencyInfo &MBFI;
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000167
168 // Variables that are valid during spill(), but used by multiple methods.
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000169 LiveRangeEdit *Edit;
Jakob Stoklund Olesene9c50732011-03-26 22:16:41 +0000170 LiveInterval *StackInt;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000171 int StackSlot;
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +0000172 unsigned Original;
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000173
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000174 // All registers to spill to StackSlot, including the main register.
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000175 SmallVector<unsigned, 8> RegsToSpill;
176
177 // All COPY instructions to/from snippets.
178 // They are ignored since both operands refer to the same stack slot.
179 SmallPtrSet<MachineInstr*, 8> SnippetCopies;
180
Jakob Stoklund Olesen080c3162010-10-20 22:00:51 +0000181 // Values that failed to remat at some point.
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000182 SmallPtrSet<VNInfo*, 8> UsedValues;
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000183
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000184 // Dead defs generated during spilling.
185 SmallVector<MachineInstr*, 8> DeadDefs;
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +0000186
Wei Mi815b02e2016-04-13 03:08:27 +0000187 // Object records spills information and does the hoisting.
188 HoistSpillHelper HSpiller;
189
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000190 ~InlineSpiller() override = default;
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000191
192public:
Eric Christopher9f85dcc2014-08-04 21:25:23 +0000193 InlineSpiller(MachineFunctionPass &pass, MachineFunction &mf, VirtRegMap &vrm)
194 : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()),
195 LSS(pass.getAnalysis<LiveStacks>()),
Chandler Carruth91468332015-09-09 17:55:00 +0000196 AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()),
Eric Christopher9f85dcc2014-08-04 21:25:23 +0000197 MDT(pass.getAnalysis<MachineDominatorTree>()),
198 Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm),
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000199 MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()),
Eric Christopher60355182014-08-05 02:39:49 +0000200 TRI(*mf.getSubtarget().getRegisterInfo()),
Wei Mi815b02e2016-04-13 03:08:27 +0000201 MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()),
202 HSpiller(pass, mf, vrm) {}
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000203
Craig Topper9f998de2014-03-07 09:26:03 +0000204 void spill(LiveRangeEdit &) override;
Wei Mi815b02e2016-04-13 03:08:27 +0000205 void postOptimization() override;
Jakob Stoklund Olesena17768f2010-10-14 23:49:52 +0000206
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000207private:
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000208 bool isSnippet(const LiveInterval &SnipLI);
209 void collectRegsToSpill();
210
David Majnemer2d62ce62016-08-12 03:55:06 +0000211 bool isRegToSpill(unsigned Reg) { return is_contained(RegsToSpill, Reg); }
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000212
213 bool isSibling(unsigned Reg);
Wei Mi815b02e2016-04-13 03:08:27 +0000214 bool hoistSpillInsideBB(LiveInterval &SpillLI, MachineInstr &CopyMI);
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000215 void eliminateRedundantSpills(LiveInterval &LI, VNInfo *VNI);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000216
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000217 void markValueUsed(LiveInterval*, VNInfo*);
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000218 bool reMaterializeFor(LiveInterval &, MachineInstr &MI);
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000219 void reMaterializeAll();
220
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000221 bool coalesceStackAccess(MachineInstr *MI, unsigned Reg);
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000222 bool foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>>,
Craig Topper4ba84432014-04-14 00:51:57 +0000223 MachineInstr *LoadMI = nullptr);
Mark Laceye742d682013-08-14 23:50:16 +0000224 void insertReload(unsigned VReg, SlotIndex, MachineBasicBlock::iterator MI);
225 void insertSpill(unsigned VReg, bool isKill, MachineBasicBlock::iterator MI);
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000226
227 void spillAroundUses(unsigned Reg);
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +0000228 void spillAll();
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000229};
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000230
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000231} // end anonymous namespace
Lang Hames4e2cbd52014-11-06 19:12:38 +0000232
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000233Spiller::~Spiller() = default;
Lang Hames4e2cbd52014-11-06 19:12:38 +0000234
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000235void Spiller::anchor() {}
236
237Spiller *llvm::createInlineSpiller(MachineFunctionPass &pass,
238 MachineFunction &mf,
239 VirtRegMap &vrm) {
Jakob Stoklund Olesenf2c6e362010-07-20 23:50:15 +0000240 return new InlineSpiller(pass, mf, vrm);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000241}
Lang Hames4e2cbd52014-11-06 19:12:38 +0000242
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000243//===----------------------------------------------------------------------===//
244// Snippets
245//===----------------------------------------------------------------------===//
246
247// When spilling a virtual register, we also spill any snippets it is connected
248// to. The snippets are small live ranges that only have a single real use,
249// leftovers from live range splitting. Spilling them enables memory operand
250// folding or tightens the live range around the single use.
251//
252// This minimizes register pressure and maximizes the store-to-load distance for
253// spill slots which can be important in tight loops.
254
255/// isFullCopyOf - If MI is a COPY to or from Reg, return the other register,
256/// otherwise return 0.
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000257static unsigned isFullCopyOf(const MachineInstr &MI, unsigned Reg) {
258 if (!MI.isFullCopy())
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000259 return 0;
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000260 if (MI.getOperand(0).getReg() == Reg)
261 return MI.getOperand(1).getReg();
262 if (MI.getOperand(1).getReg() == Reg)
263 return MI.getOperand(0).getReg();
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000264 return 0;
265}
266
267/// isSnippet - Identify if a live interval is a snippet that should be spilled.
268/// It is assumed that SnipLI is a virtual register with the same original as
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000269/// Edit->getReg().
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000270bool InlineSpiller::isSnippet(const LiveInterval &SnipLI) {
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000271 unsigned Reg = Edit->getReg();
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000272
273 // A snippet is a tiny live range with only a single instruction using it
274 // besides copies to/from Reg or spills/fills. We accept:
275 //
276 // %snip = COPY %Reg / FILL fi#
277 // %snip = USE %snip
278 // %Reg = COPY %snip / SPILL %snip, fi#
279 //
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000280 if (SnipLI.getNumValNums() > 2 || !LIS.intervalIsInOneMBB(SnipLI))
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000281 return false;
282
Craig Topper4ba84432014-04-14 00:51:57 +0000283 MachineInstr *UseMI = nullptr;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000284
285 // Check that all uses satisfy our criteria.
Owen Anderson76604af2014-03-13 06:02:25 +0000286 for (MachineRegisterInfo::reg_instr_nodbg_iterator
287 RI = MRI.reg_instr_nodbg_begin(SnipLI.reg),
288 E = MRI.reg_instr_nodbg_end(); RI != E; ) {
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000289 MachineInstr &MI = *RI++;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000290
291 // Allow copies to/from Reg.
292 if (isFullCopyOf(MI, Reg))
293 continue;
294
295 // Allow stack slot loads.
296 int FI;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000297 if (SnipLI.reg == TII.isLoadFromStackSlot(MI, FI) && FI == StackSlot)
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000298 continue;
299
300 // Allow stack slot stores.
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000301 if (SnipLI.reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot)
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000302 continue;
303
304 // Allow a single additional instruction.
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000305 if (UseMI && &MI != UseMI)
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000306 return false;
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000307 UseMI = &MI;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000308 }
309 return true;
310}
311
312/// collectRegsToSpill - Collect live range snippets that only have a single
313/// real use.
314void InlineSpiller::collectRegsToSpill() {
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000315 unsigned Reg = Edit->getReg();
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000316
317 // Main register always spills.
318 RegsToSpill.assign(1, Reg);
319 SnippetCopies.clear();
320
321 // Snippets all have the same original, so there can't be any for an original
322 // register.
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +0000323 if (Original == Reg)
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000324 return;
325
Owen Anderson76604af2014-03-13 06:02:25 +0000326 for (MachineRegisterInfo::reg_instr_iterator
327 RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end(); RI != E; ) {
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000328 MachineInstr &MI = *RI++;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000329 unsigned SnipReg = isFullCopyOf(MI, Reg);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000330 if (!isSibling(SnipReg))
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000331 continue;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000332 LiveInterval &SnipLI = LIS.getInterval(SnipReg);
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000333 if (!isSnippet(SnipLI))
334 continue;
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000335 SnippetCopies.insert(&MI);
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000336 if (isRegToSpill(SnipReg))
337 continue;
338 RegsToSpill.push_back(SnipReg);
Nicola Zaghen0818e782018-05-14 12:53:11 +0000339 LLVM_DEBUG(dbgs() << "\talso spill snippet " << SnipLI << '\n');
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000340 ++NumSnippets;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000341 }
342}
343
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000344bool InlineSpiller::isSibling(unsigned Reg) {
345 return TargetRegisterInfo::isVirtualRegister(Reg) &&
346 VRM.getOriginal(Reg) == Original;
347}
348
Wei Mi815b02e2016-04-13 03:08:27 +0000349/// It is beneficial to spill to earlier place in the same BB in case
350/// as follows:
351/// There is an alternative def earlier in the same MBB.
352/// Hoist the spill as far as possible in SpillMBB. This can ease
353/// register pressure:
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000354///
Wei Mi815b02e2016-04-13 03:08:27 +0000355/// x = def
356/// y = use x
357/// s = copy x
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000358///
Wei Mi815b02e2016-04-13 03:08:27 +0000359/// Hoisting the spill of s to immediately after the def removes the
360/// interference between x and y:
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000361///
Wei Mi815b02e2016-04-13 03:08:27 +0000362/// x = def
363/// spill x
Francis Visoiu Mistrihfd11bc02017-12-07 10:40:31 +0000364/// y = use killed x
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000365///
Wei Mi815b02e2016-04-13 03:08:27 +0000366/// This hoist only helps when the copy kills its source.
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000367///
Wei Mi815b02e2016-04-13 03:08:27 +0000368bool InlineSpiller::hoistSpillInsideBB(LiveInterval &SpillLI,
369 MachineInstr &CopyMI) {
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000370 SlotIndex Idx = LIS.getInstructionIndex(CopyMI);
Wei Mi815b02e2016-04-13 03:08:27 +0000371#ifndef NDEBUG
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000372 VNInfo *VNI = SpillLI.getVNInfoAt(Idx.getRegSlot());
373 assert(VNI && VNI->def == Idx.getRegSlot() && "Not defined by copy");
Wei Mi815b02e2016-04-13 03:08:27 +0000374#endif
Wei Mie19a68b2016-04-04 17:45:03 +0000375
Wei Mi815b02e2016-04-13 03:08:27 +0000376 unsigned SrcReg = CopyMI.getOperand(1).getReg();
377 LiveInterval &SrcLI = LIS.getInterval(SrcReg);
378 VNInfo *SrcVNI = SrcLI.getVNInfoAt(Idx);
379 LiveQueryResult SrcQ = SrcLI.Query(Idx);
380 MachineBasicBlock *DefMBB = LIS.getMBBFromIndex(SrcVNI->def);
381 if (DefMBB != CopyMI.getParent() || !SrcQ.isKill())
Hans Wennborgd8b70fb2016-04-08 15:17:43 +0000382 return false;
383
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000384 // Conservatively extend the stack slot range to the range of the original
385 // value. We may be able to do better with stack slot coloring by being more
386 // careful here.
Jakob Stoklund Olesene9c50732011-03-26 22:16:41 +0000387 assert(StackInt && "No stack slot assigned yet.");
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000388 LiveInterval &OrigLI = LIS.getInterval(Original);
389 VNInfo *OrigVNI = OrigLI.getVNInfoAt(Idx);
Jakob Stoklund Olesene9c50732011-03-26 22:16:41 +0000390 StackInt->MergeValueInAsValue(OrigLI, OrigVNI, StackInt->getValNumInfo(0));
Nicola Zaghen0818e782018-05-14 12:53:11 +0000391 LLVM_DEBUG(dbgs() << "\tmerged orig valno " << OrigVNI->id << ": "
392 << *StackInt << '\n');
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000393
Wei Mi815b02e2016-04-13 03:08:27 +0000394 // We are going to spill SrcVNI immediately after its def, so clear out
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000395 // any later spills of the same value.
Wei Mi815b02e2016-04-13 03:08:27 +0000396 eliminateRedundantSpills(SrcLI, SrcVNI);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000397
Wei Mi815b02e2016-04-13 03:08:27 +0000398 MachineBasicBlock *MBB = LIS.getMBBFromIndex(SrcVNI->def);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000399 MachineBasicBlock::iterator MII;
Wei Mi815b02e2016-04-13 03:08:27 +0000400 if (SrcVNI->isPHIDef())
Keith Walker7435b282016-09-16 14:07:29 +0000401 MII = MBB->SkipPHIsLabelsAndDebug(MBB->begin());
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000402 else {
Wei Mi815b02e2016-04-13 03:08:27 +0000403 MachineInstr *DefMI = LIS.getInstructionFromIndex(SrcVNI->def);
Jakob Stoklund Olesen6ee56e62011-04-30 06:42:21 +0000404 assert(DefMI && "Defining instruction disappeared");
405 MII = DefMI;
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000406 ++MII;
407 }
408 // Insert spill without kill flag immediately after def.
Wei Mi815b02e2016-04-13 03:08:27 +0000409 TII.storeRegToStackSlot(*MBB, MII, SrcReg, false, StackSlot,
410 MRI.getRegClass(SrcReg), &TRI);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000411 --MII; // Point to store instruction.
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000412 LIS.InsertMachineInstrInMaps(*MII);
Nicola Zaghen0818e782018-05-14 12:53:11 +0000413 LLVM_DEBUG(dbgs() << "\thoisted: " << SrcVNI->def << '\t' << *MII);
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000414
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000415 HSpiller.addToMergeableSpills(*MII, StackSlot, Original);
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +0000416 ++NumSpills;
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000417 return true;
418}
419
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000420/// eliminateRedundantSpills - SLI:VNI is known to be on the stack. Remove any
421/// redundant spills of this value in SLI.reg and sibling copies.
422void InlineSpiller::eliminateRedundantSpills(LiveInterval &SLI, VNInfo *VNI) {
Jakob Stoklund Olesen682eed02011-03-20 05:44:58 +0000423 assert(VNI && "Missing value");
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000424 SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList;
425 WorkList.push_back(std::make_pair(&SLI, VNI));
Jakob Stoklund Olesene9c50732011-03-26 22:16:41 +0000426 assert(StackInt && "No stack slot assigned yet.");
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000427
428 do {
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000429 LiveInterval *LI;
Benjamin Kramera4f0aad2014-03-02 13:30:33 +0000430 std::tie(LI, VNI) = WorkList.pop_back_val();
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000431 unsigned Reg = LI->reg;
Nicola Zaghen0818e782018-05-14 12:53:11 +0000432 LLVM_DEBUG(dbgs() << "Checking redundant spills for " << VNI->id << '@'
433 << VNI->def << " in " << *LI << '\n');
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000434
435 // Regs to spill are taken care of.
436 if (isRegToSpill(Reg))
437 continue;
438
439 // Add all of VNI's live range to StackInt.
Jakob Stoklund Olesene9c50732011-03-26 22:16:41 +0000440 StackInt->MergeValueInAsValue(*LI, VNI, StackInt->getValNumInfo(0));
Nicola Zaghen0818e782018-05-14 12:53:11 +0000441 LLVM_DEBUG(dbgs() << "Merged to stack int: " << *StackInt << '\n');
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000442
443 // Find all spills and copies of VNI.
Owen Anderson76604af2014-03-13 06:02:25 +0000444 for (MachineRegisterInfo::use_instr_nodbg_iterator
445 UI = MRI.use_instr_nodbg_begin(Reg), E = MRI.use_instr_nodbg_end();
446 UI != E; ) {
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000447 MachineInstr &MI = *UI++;
448 if (!MI.isCopy() && !MI.mayStore())
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000449 continue;
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000450 SlotIndex Idx = LIS.getInstructionIndex(MI);
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000451 if (LI->getVNInfoAt(Idx) != VNI)
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000452 continue;
453
454 // Follow sibling copies down the dominator tree.
455 if (unsigned DstReg = isFullCopyOf(MI, Reg)) {
456 if (isSibling(DstReg)) {
457 LiveInterval &DstLI = LIS.getInterval(DstReg);
Jakob Stoklund Olesen2debd482011-11-13 20:45:27 +0000458 VNInfo *DstVNI = DstLI.getVNInfoAt(Idx.getRegSlot());
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000459 assert(DstVNI && "Missing defined value");
Jakob Stoklund Olesen2debd482011-11-13 20:45:27 +0000460 assert(DstVNI->def == Idx.getRegSlot() && "Wrong copy def slot");
Jakob Stoklund Olesen01a46c82011-03-20 05:44:55 +0000461 WorkList.push_back(std::make_pair(&DstLI, DstVNI));
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000462 }
463 continue;
464 }
465
466 // Erase spills.
467 int FI;
468 if (Reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot) {
Nicola Zaghen0818e782018-05-14 12:53:11 +0000469 LLVM_DEBUG(dbgs() << "Redundant spill " << Idx << '\t' << MI);
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000470 // eliminateDeadDefs won't normally remove stores, so switch opcode.
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000471 MI.setDesc(TII.get(TargetOpcode::KILL));
472 DeadDefs.push_back(&MI);
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +0000473 ++NumSpillsRemoved;
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000474 if (HSpiller.rmFromMergeableSpills(MI, StackSlot))
Wei Mi815b02e2016-04-13 03:08:27 +0000475 --NumSpills;
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000476 }
477 }
478 } while (!WorkList.empty());
479}
480
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000481//===----------------------------------------------------------------------===//
482// Rematerialization
483//===----------------------------------------------------------------------===//
484
485/// markValueUsed - Remember that VNI failed to rematerialize, so its defining
486/// instruction cannot be eliminated. See through snippet copies
487void InlineSpiller::markValueUsed(LiveInterval *LI, VNInfo *VNI) {
488 SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList;
489 WorkList.push_back(std::make_pair(LI, VNI));
490 do {
Benjamin Kramera4f0aad2014-03-02 13:30:33 +0000491 std::tie(LI, VNI) = WorkList.pop_back_val();
David Blaikie5401ba72014-11-19 07:49:26 +0000492 if (!UsedValues.insert(VNI).second)
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000493 continue;
494
495 if (VNI->isPHIDef()) {
496 MachineBasicBlock *MBB = LIS.getMBBFromIndex(VNI->def);
Craig Topper25192392015-12-24 05:20:40 +0000497 for (MachineBasicBlock *P : MBB->predecessors()) {
498 VNInfo *PVNI = LI->getVNInfoBefore(LIS.getMBBEndIdx(P));
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000499 if (PVNI)
500 WorkList.push_back(std::make_pair(LI, PVNI));
501 }
502 continue;
503 }
504
505 // Follow snippet copies.
506 MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def);
507 if (!SnippetCopies.count(MI))
508 continue;
509 LiveInterval &SnipLI = LIS.getInterval(MI->getOperand(1).getReg());
510 assert(isRegToSpill(SnipLI.reg) && "Unexpected register in copy");
Jakob Stoklund Olesen2debd482011-11-13 20:45:27 +0000511 VNInfo *SnipVNI = SnipLI.getVNInfoAt(VNI->def.getRegSlot(true));
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000512 assert(SnipVNI && "Snippet undefined before copy");
513 WorkList.push_back(std::make_pair(&SnipLI, SnipVNI));
514 } while (!WorkList.empty());
515}
516
517/// reMaterializeFor - Attempt to rematerialize before MI instead of reloading.
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000518bool InlineSpiller::reMaterializeFor(LiveInterval &VirtReg, MachineInstr &MI) {
Patrik Hagglund79482902014-09-01 11:04:07 +0000519 // Analyze instruction
520 SmallVector<std::pair<MachineInstr *, unsigned>, 8> Ops;
521 MIBundleOperands::VirtRegInfo RI =
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000522 MIBundleOperands(MI).analyzeVirtReg(VirtReg.reg, &Ops);
Patrik Hagglund79482902014-09-01 11:04:07 +0000523
524 if (!RI.Reads)
525 return false;
526
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000527 SlotIndex UseIdx = LIS.getInstructionIndex(MI).getRegSlot(true);
Jakob Stoklund Olesen79413502011-07-18 05:31:59 +0000528 VNInfo *ParentVNI = VirtReg.getVNInfoAt(UseIdx.getBaseIndex());
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000529
530 if (!ParentVNI) {
Nicola Zaghen0818e782018-05-14 12:53:11 +0000531 LLVM_DEBUG(dbgs() << "\tadding <undef> flags: ");
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000532 for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) {
533 MachineOperand &MO = MI.getOperand(i);
Jakob Stoklund Olesencf610d02011-03-29 17:47:02 +0000534 if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg)
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000535 MO.setIsUndef();
536 }
Nicola Zaghen0818e782018-05-14 12:53:11 +0000537 LLVM_DEBUG(dbgs() << UseIdx << '\t' << MI);
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000538 return true;
539 }
Jakob Stoklund Olesen080c3162010-10-20 22:00:51 +0000540
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000541 if (SnippetCopies.count(&MI))
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000542 return false;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000543
Wei Mi815b02e2016-04-13 03:08:27 +0000544 LiveInterval &OrigLI = LIS.getInterval(Original);
545 VNInfo *OrigVNI = OrigLI.getVNInfoAt(UseIdx);
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000546 LiveRangeEdit::Remat RM(ParentVNI);
Wei Mi815b02e2016-04-13 03:08:27 +0000547 RM.OrigMI = LIS.getInstructionFromIndex(OrigVNI->def);
548
549 if (!Edit->canRematerializeAt(RM, OrigVNI, UseIdx, false)) {
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000550 markValueUsed(&VirtReg, ParentVNI);
Nicola Zaghen0818e782018-05-14 12:53:11 +0000551 LLVM_DEBUG(dbgs() << "\tcannot remat for " << UseIdx << '\t' << MI);
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000552 return false;
553 }
554
Jakob Stoklund Olesencf610d02011-03-29 17:47:02 +0000555 // If the instruction also writes VirtReg.reg, it had better not require the
556 // same register for uses and defs.
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000557 if (RI.Tied) {
558 markValueUsed(&VirtReg, ParentVNI);
Nicola Zaghen0818e782018-05-14 12:53:11 +0000559 LLVM_DEBUG(dbgs() << "\tcannot remat tied reg: " << UseIdx << '\t' << MI);
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000560 return false;
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000561 }
562
Jakob Stoklund Olesen83d1ba52010-12-18 03:04:14 +0000563 // Before rematerializing into a register for a single instruction, try to
564 // fold a load into the instruction. That avoids allocating a new register.
Evan Cheng5a96b3d2011-12-07 07:15:52 +0000565 if (RM.OrigMI->canFoldAsLoad() &&
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000566 foldMemoryOperand(Ops, RM.OrigMI)) {
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000567 Edit->markRematerialized(RM.ParentVNI);
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000568 ++NumFoldedLoads;
Jakob Stoklund Olesen83d1ba52010-12-18 03:04:14 +0000569 return true;
570 }
571
Wolfgang Pieb659db1f2016-08-16 17:12:50 +0000572 // Allocate a new register for the remat.
Mark Laceye742d682013-08-14 23:50:16 +0000573 unsigned NewVReg = Edit->createFrom(Original);
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000574
575 // Finally we can rematerialize OrigMI before MI.
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000576 SlotIndex DefIdx =
577 Edit->rematerializeAt(*MI.getParent(), MI, NewVReg, RM, TRI);
Wolfgang Pieb659db1f2016-08-16 17:12:50 +0000578
579 // We take the DebugLoc from MI, since OrigMI may be attributed to a
Junmo Parkc236d012017-02-25 01:50:45 +0000580 // different source location.
Wolfgang Pieb659db1f2016-08-16 17:12:50 +0000581 auto *NewMI = LIS.getInstructionFromIndex(DefIdx);
582 NewMI->setDebugLoc(MI.getDebugLoc());
583
Mark Laceye742d682013-08-14 23:50:16 +0000584 (void)DefIdx;
Nicola Zaghen0818e782018-05-14 12:53:11 +0000585 LLVM_DEBUG(dbgs() << "\tremat: " << DefIdx << '\t'
586 << *LIS.getInstructionFromIndex(DefIdx));
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000587
588 // Replace operands
Craig Topper25192392015-12-24 05:20:40 +0000589 for (const auto &OpPair : Ops) {
590 MachineOperand &MO = OpPair.first->getOperand(OpPair.second);
Jakob Stoklund Olesencf610d02011-03-29 17:47:02 +0000591 if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg) {
Mark Laceye742d682013-08-14 23:50:16 +0000592 MO.setReg(NewVReg);
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000593 MO.setIsKill();
594 }
595 }
Nicola Zaghen0818e782018-05-14 12:53:11 +0000596 LLVM_DEBUG(dbgs() << "\t " << UseIdx << '\t' << MI << '\n');
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000597
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000598 ++NumRemats;
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000599 return true;
600}
601
Jakob Stoklund Olesena17768f2010-10-14 23:49:52 +0000602/// reMaterializeAll - Try to rematerialize as many uses as possible,
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000603/// and trim the live ranges after.
604void InlineSpiller::reMaterializeAll() {
Pete Cooper8a06af92012-04-02 22:22:53 +0000605 if (!Edit->anyRematerializable(AA))
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000606 return;
607
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000608 UsedValues.clear();
Jakob Stoklund Olesen080c3162010-10-20 22:00:51 +0000609
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000610 // Try to remat before all uses of snippets.
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000611 bool anyRemat = false;
Craig Topper25192392015-12-24 05:20:40 +0000612 for (unsigned Reg : RegsToSpill) {
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000613 LiveInterval &LI = LIS.getInterval(Reg);
Patrik Hagglund79482902014-09-01 11:04:07 +0000614 for (MachineRegisterInfo::reg_bundle_iterator
615 RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end();
616 RegI != E; ) {
Duncan P. N. Exon Smithcc3610d2016-02-27 20:23:14 +0000617 MachineInstr &MI = *RegI++;
Patrik Hagglund79482902014-09-01 11:04:07 +0000618
619 // Debug values are not allowed to affect codegen.
Shiva Chen1187b9b2018-05-16 02:57:26 +0000620 if (MI.isDebugValue())
Patrik Hagglund79482902014-09-01 11:04:07 +0000621 continue;
622
Shiva Chen1187b9b2018-05-16 02:57:26 +0000623 assert(!MI.isDebugInstr() && "Did not expect to find a use in debug "
624 "instruction that isn't a DBG_VALUE");
625
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000626 anyRemat |= reMaterializeFor(LI, MI);
Owen Anderson76604af2014-03-13 06:02:25 +0000627 }
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000628 }
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000629 if (!anyRemat)
630 return;
631
632 // Remove any values that were completely rematted.
Craig Topper25192392015-12-24 05:20:40 +0000633 for (unsigned Reg : RegsToSpill) {
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000634 LiveInterval &LI = LIS.getInterval(Reg);
635 for (LiveInterval::vni_iterator I = LI.vni_begin(), E = LI.vni_end();
636 I != E; ++I) {
637 VNInfo *VNI = *I;
Jakob Stoklund Olesenc1d22d82011-03-29 17:47:00 +0000638 if (VNI->isUnused() || VNI->isPHIDef() || UsedValues.count(VNI))
Jakob Stoklund Olesen3b9c7eb2010-07-02 19:54:40 +0000639 continue;
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000640 MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def);
641 MI->addRegisterDead(Reg, &TRI);
642 if (!MI->allDefsAreDead())
643 continue;
Nicola Zaghen0818e782018-05-14 12:53:11 +0000644 LLVM_DEBUG(dbgs() << "All defs dead: " << *MI);
Jakob Stoklund Olesen2ef661b2011-03-29 03:12:02 +0000645 DeadDefs.push_back(MI);
Jakob Stoklund Olesen3b9c7eb2010-07-02 19:54:40 +0000646 }
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000647 }
Jakob Stoklund Olesenc1d22d82011-03-29 17:47:00 +0000648
649 // Eliminate dead code after remat. Note that some snippet copies may be
650 // deleted here.
651 if (DeadDefs.empty())
652 return;
Nicola Zaghen0818e782018-05-14 12:53:11 +0000653 LLVM_DEBUG(dbgs() << "Remat created " << DeadDefs.size() << " dead defs.\n");
Wei Mi4eae2782016-07-08 21:08:09 +0000654 Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA);
Jakob Stoklund Olesenc1d22d82011-03-29 17:47:00 +0000655
Wei Mif2ca0312016-02-05 18:14:24 +0000656 // LiveRangeEdit::eliminateDeadDef is used to remove dead define instructions
657 // after rematerialization. To remove a VNI for a vreg from its LiveInterval,
658 // LiveIntervals::removeVRegDefAt is used. However, after non-PHI VNIs are all
659 // removed, PHI VNI are still left in the LiveInterval.
660 // So to get rid of unused reg, we need to check whether it has non-dbg
661 // reference instead of whether it has non-empty interval.
Benjamin Kramere210df22013-05-05 11:29:14 +0000662 unsigned ResultPos = 0;
Craig Topper25192392015-12-24 05:20:40 +0000663 for (unsigned Reg : RegsToSpill) {
Wei Mif2ca0312016-02-05 18:14:24 +0000664 if (MRI.reg_nodbg_empty(Reg)) {
Benjamin Kramere210df22013-05-05 11:29:14 +0000665 Edit->eraseVirtReg(Reg);
Jakob Stoklund Olesenc1d22d82011-03-29 17:47:00 +0000666 continue;
667 }
Matt Arsenaultf3c728a2017-07-22 00:24:01 +0000668
Matt Arsenault07713762017-07-24 18:07:55 +0000669 assert(LIS.hasInterval(Reg) &&
670 (!LIS.getInterval(Reg).empty() || !MRI.reg_nodbg_empty(Reg)) &&
671 "Empty and not used live-range?!");
672
Benjamin Kramere210df22013-05-05 11:29:14 +0000673 RegsToSpill[ResultPos++] = Reg;
Jakob Stoklund Olesenc1d22d82011-03-29 17:47:00 +0000674 }
Benjamin Kramere210df22013-05-05 11:29:14 +0000675 RegsToSpill.erase(RegsToSpill.begin() + ResultPos, RegsToSpill.end());
Nicola Zaghen0818e782018-05-14 12:53:11 +0000676 LLVM_DEBUG(dbgs() << RegsToSpill.size()
677 << " registers to spill after remat.\n");
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000678}
679
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +0000680//===----------------------------------------------------------------------===//
681// Spilling
682//===----------------------------------------------------------------------===//
683
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000684/// If MI is a load or store of StackSlot, it can be removed.
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000685bool InlineSpiller::coalesceStackAccess(MachineInstr *MI, unsigned Reg) {
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000686 int FI = 0;
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000687 unsigned InstrReg = TII.isLoadFromStackSlot(*MI, FI);
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +0000688 bool IsLoad = InstrReg;
689 if (!IsLoad)
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000690 InstrReg = TII.isStoreToStackSlot(*MI, FI);
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000691
692 // We have a stack access. Is it the right register and slot?
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000693 if (InstrReg != Reg || FI != StackSlot)
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000694 return false;
695
Wei Mi815b02e2016-04-13 03:08:27 +0000696 if (!IsLoad)
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000697 HSpiller.rmFromMergeableSpills(*MI, StackSlot);
Wei Mi815b02e2016-04-13 03:08:27 +0000698
Nicola Zaghen0818e782018-05-14 12:53:11 +0000699 LLVM_DEBUG(dbgs() << "Coalescing stack access: " << *MI);
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000700 LIS.RemoveMachineInstrFromMaps(*MI);
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000701 MI->eraseFromParent();
Jakob Stoklund Olesen79c40a02011-09-15 17:54:28 +0000702
703 if (IsLoad) {
704 ++NumReloadsRemoved;
705 --NumReloads;
706 } else {
707 ++NumSpillsRemoved;
708 --NumSpills;
709 }
710
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000711 return true;
712}
713
Aaron Ballman1d03d382017-10-15 14:32:27 +0000714#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
Junmo Parkc0fa0b72017-03-28 04:14:25 +0000715LLVM_DUMP_METHOD
Mark Laceye742d682013-08-14 23:50:16 +0000716// Dump the range of instructions from B to E with their slot indexes.
717static void dumpMachineInstrRangeWithSlotIndex(MachineBasicBlock::iterator B,
718 MachineBasicBlock::iterator E,
719 LiveIntervals const &LIS,
720 const char *const header,
721 unsigned VReg =0) {
722 char NextLine = '\n';
723 char SlotIndent = '\t';
724
Benjamin Kramerd628f192014-03-02 12:27:27 +0000725 if (std::next(B) == E) {
Mark Laceye742d682013-08-14 23:50:16 +0000726 NextLine = ' ';
727 SlotIndent = ' ';
728 }
729
730 dbgs() << '\t' << header << ": " << NextLine;
731
732 for (MachineBasicBlock::iterator I = B; I != E; ++I) {
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000733 SlotIndex Idx = LIS.getInstructionIndex(*I).getRegSlot();
Mark Laceye742d682013-08-14 23:50:16 +0000734
735 // If a register was passed in and this instruction has it as a
736 // destination that is marked as an early clobber, print the
737 // early-clobber slot index.
738 if (VReg) {
739 MachineOperand *MO = I->findRegisterDefOperand(VReg);
740 if (MO && MO->isEarlyClobber())
741 Idx = Idx.getRegSlot(true);
742 }
743
744 dbgs() << SlotIndent << Idx << '\t' << *I;
745 }
746}
747#endif
748
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000749/// foldMemoryOperand - Try folding stack slot references in Ops into their
750/// instructions.
751///
752/// @param Ops Operand indices from analyzeVirtReg().
Jakob Stoklund Olesen83d1ba52010-12-18 03:04:14 +0000753/// @param LoadMI Load instruction to use instead of stack slot when non-null.
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000754/// @return True on success.
755bool InlineSpiller::
Eugene Zelenko7cf6af52017-08-29 22:32:07 +0000756foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>> Ops,
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000757 MachineInstr *LoadMI) {
758 if (Ops.empty())
759 return false;
760 // Don't attempt folding in bundles.
761 MachineInstr *MI = Ops.front().first;
762 if (Ops.back().first != MI || MI->isBundled())
763 return false;
764
Jakob Stoklund Olesend205f7a2011-09-15 18:22:52 +0000765 bool WasCopy = MI->isCopy();
Jakob Stoklund Olesen17afb062011-11-10 00:17:03 +0000766 unsigned ImpReg = 0;
767
Michael Kuperstein4f548472016-11-23 18:33:49 +0000768 // Spill subregs if the target allows it.
769 // We always want to spill subregs for stackmap/patchpoint pseudos.
770 bool SpillSubRegs = TII.isSubregFoldable() ||
771 MI->getOpcode() == TargetOpcode::STATEPOINT ||
772 MI->getOpcode() == TargetOpcode::PATCHPOINT ||
773 MI->getOpcode() == TargetOpcode::STACKMAP;
Andrew Trickbb756ca2013-11-17 01:36:23 +0000774
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000775 // TargetInstrInfo::foldMemoryOperand only expects explicit, non-tied
776 // operands.
777 SmallVector<unsigned, 8> FoldOps;
Craig Topper25192392015-12-24 05:20:40 +0000778 for (const auto &OpPair : Ops) {
779 unsigned Idx = OpPair.second;
780 assert(MI == OpPair.first && "Instruction conflict during operand folding");
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000781 MachineOperand &MO = MI->getOperand(Idx);
Jakob Stoklund Olesen17afb062011-11-10 00:17:03 +0000782 if (MO.isImplicit()) {
783 ImpReg = MO.getReg();
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000784 continue;
Jakob Stoklund Olesen17afb062011-11-10 00:17:03 +0000785 }
Michael Kuperstein4f548472016-11-23 18:33:49 +0000786
Andrew Trickbb756ca2013-11-17 01:36:23 +0000787 if (!SpillSubRegs && MO.getSubReg())
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000788 return false;
Jakob Stoklund Olesen7b1f4982011-02-08 19:33:55 +0000789 // We cannot fold a load instruction into a def.
790 if (LoadMI && MO.isDef())
791 return false;
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000792 // Tied use operands should not be passed to foldMemoryOperand.
793 if (!MI->isRegTiedToDefOperand(Idx))
794 FoldOps.push_back(Idx);
795 }
796
Quentin Colombetaff0cae2016-12-08 00:06:51 +0000797 // If we only have implicit uses, we won't be able to fold that.
798 // Moreover, TargetInstrInfo::foldMemoryOperand will assert if we try!
799 if (FoldOps.empty())
800 return false;
801
Mark Laceye742d682013-08-14 23:50:16 +0000802 MachineInstrSpan MIS(MI);
803
Jakob Stoklund Olesen83d1ba52010-12-18 03:04:14 +0000804 MachineInstr *FoldMI =
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000805 LoadMI ? TII.foldMemoryOperand(*MI, FoldOps, *LoadMI, &LIS)
806 : TII.foldMemoryOperand(*MI, FoldOps, StackSlot, &LIS);
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000807 if (!FoldMI)
808 return false;
Andrew Trickc12c8802013-06-21 18:33:26 +0000809
810 // Remove LIS for any dead defs in the original MI not in FoldMI.
Duncan P. N. Exon Smith63ec7f02016-02-27 17:05:33 +0000811 for (MIBundleOperands MO(*MI); MO.isValid(); ++MO) {
Andrew Trickc12c8802013-06-21 18:33:26 +0000812 if (!MO->isReg())
813 continue;
814 unsigned Reg = MO->getReg();
815 if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg) ||
816 MRI.isReserved(Reg)) {
817 continue;
818 }
Andrew Trick9c15f4c2014-01-07 07:31:10 +0000819 // Skip non-Defs, including undef uses and internal reads.
820 if (MO->isUse())
821 continue;
Andrew Trickc12c8802013-06-21 18:33:26 +0000822 MIBundleOperands::PhysRegInfo RI =
Duncan P. N. Exon Smith63ec7f02016-02-27 17:05:33 +0000823 MIBundleOperands(*FoldMI).analyzePhysReg(Reg, &TRI);
Matthias Braunf43272c2015-12-11 19:42:09 +0000824 if (RI.FullyDefined)
Andrew Trickc12c8802013-06-21 18:33:26 +0000825 continue;
826 // FoldMI does not define this physreg. Remove the LI segment.
827 assert(MO->isDead() && "Cannot fold physreg def");
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000828 SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot();
Matthias Braun1458e052015-01-21 18:50:21 +0000829 LIS.removePhysRegDefAt(Reg, Idx);
Andrew Trickc12c8802013-06-21 18:33:26 +0000830 }
Mark Laceye742d682013-08-14 23:50:16 +0000831
Wei Mi815b02e2016-04-13 03:08:27 +0000832 int FI;
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000833 if (TII.isStoreToStackSlot(*MI, FI) &&
834 HSpiller.rmFromMergeableSpills(*MI, FI))
Wei Mi815b02e2016-04-13 03:08:27 +0000835 --NumSpills;
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000836 LIS.ReplaceMachineInstrInMaps(*MI, *FoldMI);
Jakob Stoklund Olesene05442d2010-07-09 17:29:08 +0000837 MI->eraseFromParent();
Jakob Stoklund Olesen17afb062011-11-10 00:17:03 +0000838
Mark Laceye742d682013-08-14 23:50:16 +0000839 // Insert any new instructions other than FoldMI into the LIS maps.
840 assert(!MIS.empty() && "Unexpected empty span of instructions!");
Craig Topper25192392015-12-24 05:20:40 +0000841 for (MachineInstr &MI : MIS)
842 if (&MI != FoldMI)
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000843 LIS.InsertMachineInstrInMaps(MI);
Mark Laceye742d682013-08-14 23:50:16 +0000844
Jakob Stoklund Olesen17afb062011-11-10 00:17:03 +0000845 // TII.foldMemoryOperand may have left some implicit operands on the
846 // instruction. Strip them.
847 if (ImpReg)
848 for (unsigned i = FoldMI->getNumOperands(); i; --i) {
849 MachineOperand &MO = FoldMI->getOperand(i - 1);
850 if (!MO.isReg() || !MO.isImplicit())
851 break;
852 if (MO.getReg() == ImpReg)
853 FoldMI->RemoveOperand(i - 1);
854 }
855
Nicola Zaghen0818e782018-05-14 12:53:11 +0000856 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MIS.end(), LIS,
857 "folded"));
Mark Laceye742d682013-08-14 23:50:16 +0000858
Jakob Stoklund Olesend205f7a2011-09-15 18:22:52 +0000859 if (!WasCopy)
860 ++NumFolded;
Wei Mi815b02e2016-04-13 03:08:27 +0000861 else if (Ops.front().second == 0) {
Jakob Stoklund Olesend205f7a2011-09-15 18:22:52 +0000862 ++NumSpills;
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +0000863 HSpiller.addToMergeableSpills(*FoldMI, StackSlot, Original);
Wei Mi815b02e2016-04-13 03:08:27 +0000864 } else
Jakob Stoklund Olesend205f7a2011-09-15 18:22:52 +0000865 ++NumReloads;
Jakob Stoklund Olesene72a5c52010-07-01 00:13:04 +0000866 return true;
867}
868
Mark Laceye742d682013-08-14 23:50:16 +0000869void InlineSpiller::insertReload(unsigned NewVReg,
Jakob Stoklund Olesen5d5ef4a2011-04-18 20:23:27 +0000870 SlotIndex Idx,
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000871 MachineBasicBlock::iterator MI) {
872 MachineBasicBlock &MBB = *MI->getParent();
Mark Laceye742d682013-08-14 23:50:16 +0000873
874 MachineInstrSpan MIS(MI);
875 TII.loadRegFromStackSlot(MBB, MI, NewVReg, StackSlot,
876 MRI.getRegClass(NewVReg), &TRI);
877
878 LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MI);
879
Nicola Zaghen0818e782018-05-14 12:53:11 +0000880 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MI, LIS, "reload",
881 NewVReg));
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000882 ++NumReloads;
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000883}
884
Quentin Colombetde1ece92017-06-05 23:51:27 +0000885/// Check if \p Def fully defines a VReg with an undefined value.
886/// If that's the case, that means the value of VReg is actually
887/// not relevant.
888static bool isFullUndefDef(const MachineInstr &Def) {
889 if (!Def.isImplicitDef())
890 return false;
891 assert(Def.getNumOperands() == 1 &&
892 "Implicit def with more than one definition");
893 // We can say that the VReg defined by Def is undef, only if it is
894 // fully defined by Def. Otherwise, some of the lanes may not be
895 // undef and the value of the VReg matters.
896 return !Def.getOperand(0).getSubReg();
897}
898
Mark Laceye742d682013-08-14 23:50:16 +0000899/// insertSpill - Insert a spill of NewVReg after MI.
900void InlineSpiller::insertSpill(unsigned NewVReg, bool isKill,
901 MachineBasicBlock::iterator MI) {
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000902 MachineBasicBlock &MBB = *MI->getParent();
Mark Laceye742d682013-08-14 23:50:16 +0000903
904 MachineInstrSpan MIS(MI);
Quentin Colombete8e2b8a2017-06-07 00:22:07 +0000905 bool IsRealSpill = true;
906 if (isFullUndefDef(*MI)) {
Quentin Colombetde1ece92017-06-05 23:51:27 +0000907 // Don't spill undef value.
908 // Anything works for undef, in particular keeping the memory
909 // uninitialized is a viable option and it saves code size and
910 // run time.
911 BuildMI(MBB, std::next(MI), MI->getDebugLoc(), TII.get(TargetOpcode::KILL))
912 .addReg(NewVReg, getKillRegState(isKill));
Quentin Colombete8e2b8a2017-06-07 00:22:07 +0000913 IsRealSpill = false;
914 } else
Quentin Colombetde1ece92017-06-05 23:51:27 +0000915 TII.storeRegToStackSlot(MBB, std::next(MI), NewVReg, isKill, StackSlot,
916 MRI.getRegClass(NewVReg), &TRI);
Mark Laceye742d682013-08-14 23:50:16 +0000917
Benjamin Kramerd628f192014-03-02 12:27:27 +0000918 LIS.InsertMachineInstrRangeInMaps(std::next(MI), MIS.end());
Mark Laceye742d682013-08-14 23:50:16 +0000919
Nicola Zaghen0818e782018-05-14 12:53:11 +0000920 LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(std::next(MI), MIS.end(), LIS,
921 "spill"));
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +0000922 ++NumSpills;
Quentin Colombete8e2b8a2017-06-07 00:22:07 +0000923 if (IsRealSpill)
924 HSpiller.addToMergeableSpills(*std::next(MI), StackSlot, Original);
Jakob Stoklund Olesen9e55afb2010-06-30 23:03:52 +0000925}
926
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000927/// spillAroundUses - insert spill code around each use of Reg.
928void InlineSpiller::spillAroundUses(unsigned Reg) {
Nicola Zaghen0818e782018-05-14 12:53:11 +0000929 LLVM_DEBUG(dbgs() << "spillAroundUses " << printReg(Reg) << '\n');
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +0000930 LiveInterval &OldLI = LIS.getInterval(Reg);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000931
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000932 // Iterate over instructions using Reg.
Owen Anderson76604af2014-03-13 06:02:25 +0000933 for (MachineRegisterInfo::reg_bundle_iterator
934 RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end();
935 RegI != E; ) {
Owen Andersonb6f478a2014-03-14 05:02:18 +0000936 MachineInstr *MI = &*(RegI++);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000937
Jakob Stoklund Olesen3b9c7eb2010-07-02 19:54:40 +0000938 // Debug values are not allowed to affect codegen.
Shiva Chen1187b9b2018-05-16 02:57:26 +0000939 if (MI->isDebugValue()) {
Jakob Stoklund Olesen3b9c7eb2010-07-02 19:54:40 +0000940 // Modify DBG_VALUE now that the value is in a spill slot.
David Blaikie6d9dbd52013-06-16 20:34:15 +0000941 MachineBasicBlock *MBB = MI->getParent();
Nicola Zaghen0818e782018-05-14 12:53:11 +0000942 LLVM_DEBUG(dbgs() << "Modifying debug info due to spill:\t" << *MI);
Adrian Prantlb560ea72017-04-18 01:21:53 +0000943 buildDbgValueForSpill(*MBB, MI, *MI, StackSlot);
944 MBB->erase(MI);
Jakob Stoklund Olesen3b9c7eb2010-07-02 19:54:40 +0000945 continue;
946 }
947
Shiva Chen1187b9b2018-05-16 02:57:26 +0000948 assert(!MI->isDebugInstr() && "Did not expect to find a use in debug "
949 "instruction that isn't a DBG_VALUE");
950
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000951 // Ignore copies to/from snippets. We'll delete them.
952 if (SnippetCopies.count(MI))
953 continue;
954
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000955 // Stack slot accesses may coalesce away.
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +0000956 if (coalesceStackAccess(MI, Reg))
Jakob Stoklund Olesen1a0f91b2010-08-04 22:35:11 +0000957 continue;
958
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000959 // Analyze instruction.
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000960 SmallVector<std::pair<MachineInstr*, unsigned>, 8> Ops;
James Molloyb17cf292012-09-12 10:03:31 +0000961 MIBundleOperands::VirtRegInfo RI =
Duncan P. N. Exon Smith63ec7f02016-02-27 17:05:33 +0000962 MIBundleOperands(*MI).analyzeVirtReg(Reg, &Ops);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +0000963
Jakob Stoklund Olesen5d5ef4a2011-04-18 20:23:27 +0000964 // Find the slot index where this instruction reads and writes OldLI.
965 // This is usually the def slot, except for tied early clobbers.
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +0000966 SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot();
Jakob Stoklund Olesen2debd482011-11-13 20:45:27 +0000967 if (VNInfo *VNI = OldLI.getVNInfoAt(Idx.getRegSlot(true)))
Jakob Stoklund Olesen5d5ef4a2011-04-18 20:23:27 +0000968 if (SlotIndex::isSameInstr(Idx, VNI->def))
969 Idx = VNI->def;
970
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000971 // Check for a sibling copy.
Duncan P. N. Exon Smith567409d2016-06-30 00:01:54 +0000972 unsigned SibReg = isFullCopyOf(*MI, Reg);
Jakob Stoklund Olesen682eed02011-03-20 05:44:58 +0000973 if (SibReg && isSibling(SibReg)) {
Jakob Stoklund Olesen443443c2011-05-11 18:25:10 +0000974 // This may actually be a copy between snippets.
975 if (isRegToSpill(SibReg)) {
Nicola Zaghen0818e782018-05-14 12:53:11 +0000976 LLVM_DEBUG(dbgs() << "Found new snippet copy: " << *MI);
Jakob Stoklund Olesen443443c2011-05-11 18:25:10 +0000977 SnippetCopies.insert(MI);
978 continue;
979 }
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000980 if (RI.Writes) {
Wei Mi815b02e2016-04-13 03:08:27 +0000981 if (hoistSpillInsideBB(OldLI, *MI)) {
Jakob Stoklund Olesen682eed02011-03-20 05:44:58 +0000982 // This COPY is now dead, the value is already in the stack slot.
983 MI->getOperand(0).setIsDead();
984 DeadDefs.push_back(MI);
985 continue;
986 }
987 } else {
988 // This is a reload for a sib-reg copy. Drop spills downstream.
Jakob Stoklund Olesen682eed02011-03-20 05:44:58 +0000989 LiveInterval &SibLI = LIS.getInterval(SibReg);
990 eliminateRedundantSpills(SibLI, SibLI.getVNInfoAt(Idx));
991 // The COPY will fold to a reload below.
992 }
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +0000993 }
994
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000995 // Attempt to fold memory ops.
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +0000996 if (foldMemoryOperand(Ops))
Jakob Stoklund Olesen8de3b1e2010-07-02 17:44:57 +0000997 continue;
998
Mark Laceye742d682013-08-14 23:50:16 +0000999 // Create a new virtual register for spill/fill.
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001000 // FIXME: Infer regclass from instruction alone.
Mark Laceye742d682013-08-14 23:50:16 +00001001 unsigned NewVReg = Edit->createFrom(Reg);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001002
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +00001003 if (RI.Reads)
Mark Laceye742d682013-08-14 23:50:16 +00001004 insertReload(NewVReg, Idx, MI);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001005
1006 // Rewrite instruction operands.
1007 bool hasLiveDef = false;
Craig Topper25192392015-12-24 05:20:40 +00001008 for (const auto &OpPair : Ops) {
1009 MachineOperand &MO = OpPair.first->getOperand(OpPair.second);
Mark Laceye742d682013-08-14 23:50:16 +00001010 MO.setReg(NewVReg);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001011 if (MO.isUse()) {
Craig Topper25192392015-12-24 05:20:40 +00001012 if (!OpPair.first->isRegTiedToDefOperand(OpPair.second))
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001013 MO.setIsKill();
1014 } else {
1015 if (!MO.isDead())
1016 hasLiveDef = true;
1017 }
1018 }
Nicola Zaghen0818e782018-05-14 12:53:11 +00001019 LLVM_DEBUG(dbgs() << "\trewrite: " << Idx << '\t' << *MI << '\n');
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001020
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001021 // FIXME: Use a second vreg if instruction has no tied ops.
Mark Laceye742d682013-08-14 23:50:16 +00001022 if (RI.Writes)
Jakob Stoklund Olesen66c994c2012-03-01 01:43:25 +00001023 if (hasLiveDef)
Mark Laceye742d682013-08-14 23:50:16 +00001024 insertSpill(NewVReg, true, MI);
Jakob Stoklund Olesen914f2ff2010-06-29 23:58:39 +00001025 }
1026}
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001027
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001028/// spillAll - Spill all registers remaining after rematerialization.
1029void InlineSpiller::spillAll() {
1030 // Update LiveStacks now that we are committed to spilling.
1031 if (StackSlot == VirtRegMap::NO_STACK_SLOT) {
1032 StackSlot = VRM.assignVirt2StackSlot(Original);
1033 StackInt = &LSS.getOrCreateInterval(StackSlot, MRI.getRegClass(Original));
Jakob Stoklund Olesen3b1088a2012-02-04 05:20:49 +00001034 StackInt->getNextValue(SlotIndex(), LSS.getVNInfoAllocator());
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001035 } else
1036 StackInt = &LSS.getInterval(StackSlot);
1037
1038 if (Original != Edit->getReg())
1039 VRM.assignVirt2StackSlot(Edit->getReg(), StackSlot);
1040
1041 assert(StackInt->getNumValNums() == 1 && "Bad stack interval values");
Craig Topper25192392015-12-24 05:20:40 +00001042 for (unsigned Reg : RegsToSpill)
1043 StackInt->MergeSegmentsInAsValue(LIS.getInterval(Reg),
Matthias Braun331de112013-10-10 21:28:43 +00001044 StackInt->getValNumInfo(0));
Nicola Zaghen0818e782018-05-14 12:53:11 +00001045 LLVM_DEBUG(dbgs() << "Merged spilled regs: " << *StackInt << '\n');
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001046
1047 // Spill around uses of all RegsToSpill.
Craig Topper25192392015-12-24 05:20:40 +00001048 for (unsigned Reg : RegsToSpill)
1049 spillAroundUses(Reg);
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001050
1051 // Hoisted spills may cause dead code.
1052 if (!DeadDefs.empty()) {
Nicola Zaghen0818e782018-05-14 12:53:11 +00001053 LLVM_DEBUG(dbgs() << "Eliminating " << DeadDefs.size() << " dead defs\n");
Wei Mi4eae2782016-07-08 21:08:09 +00001054 Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA);
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001055 }
1056
1057 // Finally delete the SnippetCopies.
Craig Topper25192392015-12-24 05:20:40 +00001058 for (unsigned Reg : RegsToSpill) {
Owen Anderson76604af2014-03-13 06:02:25 +00001059 for (MachineRegisterInfo::reg_instr_iterator
Craig Topper25192392015-12-24 05:20:40 +00001060 RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end();
Owen Anderson76604af2014-03-13 06:02:25 +00001061 RI != E; ) {
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +00001062 MachineInstr &MI = *(RI++);
1063 assert(SnippetCopies.count(&MI) && "Remaining use wasn't a snippet copy");
Jakob Stoklund Olesen443443c2011-05-11 18:25:10 +00001064 // FIXME: Do this with a LiveRangeEdit callback.
Jakob Stoklund Olesen443443c2011-05-11 18:25:10 +00001065 LIS.RemoveMachineInstrFromMaps(MI);
Duncan P. N. Exon Smith42e18352016-02-27 06:40:41 +00001066 MI.eraseFromParent();
Jakob Stoklund Olesen443443c2011-05-11 18:25:10 +00001067 }
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001068 }
1069
1070 // Delete all spilled registers.
Craig Topper25192392015-12-24 05:20:40 +00001071 for (unsigned Reg : RegsToSpill)
1072 Edit->eraseVirtReg(Reg);
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001073}
1074
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001075void InlineSpiller::spill(LiveRangeEdit &edit) {
Jakob Stoklund Olesene9bd4ea2011-05-05 17:22:53 +00001076 ++NumSpilledRanges;
Jakob Stoklund Olesen766faf42011-03-14 19:56:43 +00001077 Edit = &edit;
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001078 assert(!TargetRegisterInfo::isStackSlot(edit.getReg())
1079 && "Trying to spill a stack slot.");
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +00001080 // Share a stack slot among all descendants of Original.
1081 Original = VRM.getOriginal(edit.getReg());
1082 StackSlot = VRM.getStackSlot(Original);
Craig Topper4ba84432014-04-14 00:51:57 +00001083 StackInt = nullptr;
Jakob Stoklund Olesen13ba2522011-03-15 21:13:25 +00001084
Nicola Zaghen0818e782018-05-14 12:53:11 +00001085 LLVM_DEBUG(dbgs() << "Inline spilling "
1086 << TRI.getRegClassName(MRI.getRegClass(edit.getReg()))
1087 << ':' << edit.getParent() << "\nFrom original "
1088 << printReg(Original) << '\n');
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001089 assert(edit.getParent().isSpillable() &&
1090 "Attempting to spill already spilled value.");
Jakob Stoklund Olesen2a72bfa2011-03-18 04:23:06 +00001091 assert(DeadDefs.empty() && "Previous spill didn't remove dead defs");
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001092
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001093 collectRegsToSpill();
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001094 reMaterializeAll();
1095
1096 // Remat may handle everything.
Jakob Stoklund Olesen6094bd82011-03-29 21:20:19 +00001097 if (!RegsToSpill.empty())
1098 spillAll();
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001099
Benjamin Kramer4eed7562013-06-17 19:00:36 +00001100 Edit->calculateRegClassAndHint(MF, Loops, MBFI);
Jakob Stoklund Olesen10a43322011-03-12 04:17:20 +00001101}
Wei Mi815b02e2016-04-13 03:08:27 +00001102
1103/// Optimizations after all the reg selections and spills are done.
Wei Mi1f5a2c32016-04-15 23:16:44 +00001104void InlineSpiller::postOptimization() { HSpiller.hoistAllSpills(); }
Wei Mi815b02e2016-04-13 03:08:27 +00001105
1106/// When a spill is inserted, add the spill to MergeableSpills map.
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001107void HoistSpillHelper::addToMergeableSpills(MachineInstr &Spill, int StackSlot,
Wei Mi815b02e2016-04-13 03:08:27 +00001108 unsigned Original) {
Wei Mi57d83cb2017-09-13 21:41:30 +00001109 BumpPtrAllocator &Allocator = LIS.getVNInfoAllocator();
1110 LiveInterval &OrigLI = LIS.getInterval(Original);
1111 // save a copy of LiveInterval in StackSlotToOrigLI because the original
1112 // LiveInterval may be cleared after all its references are spilled.
1113 if (StackSlotToOrigLI.find(StackSlot) == StackSlotToOrigLI.end()) {
1114 auto LI = llvm::make_unique<LiveInterval>(OrigLI.reg, OrigLI.weight);
1115 LI->assign(OrigLI, Allocator);
1116 StackSlotToOrigLI[StackSlot] = std::move(LI);
1117 }
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001118 SlotIndex Idx = LIS.getInstructionIndex(Spill);
Wei Mi57d83cb2017-09-13 21:41:30 +00001119 VNInfo *OrigVNI = StackSlotToOrigLI[StackSlot]->getVNInfoAt(Idx.getRegSlot());
Wei Mi815b02e2016-04-13 03:08:27 +00001120 std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI);
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001121 MergeableSpills[MIdx].insert(&Spill);
Wei Mi815b02e2016-04-13 03:08:27 +00001122}
1123
1124/// When a spill is removed, remove the spill from MergeableSpills map.
1125/// Return true if the spill is removed successfully.
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001126bool HoistSpillHelper::rmFromMergeableSpills(MachineInstr &Spill,
Wei Mi815b02e2016-04-13 03:08:27 +00001127 int StackSlot) {
Wei Mi57d83cb2017-09-13 21:41:30 +00001128 auto It = StackSlotToOrigLI.find(StackSlot);
1129 if (It == StackSlotToOrigLI.end())
Wei Mi815b02e2016-04-13 03:08:27 +00001130 return false;
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001131 SlotIndex Idx = LIS.getInstructionIndex(Spill);
Wei Mi57d83cb2017-09-13 21:41:30 +00001132 VNInfo *OrigVNI = It->second->getVNInfoAt(Idx.getRegSlot());
Wei Mi815b02e2016-04-13 03:08:27 +00001133 std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI);
Duncan P. N. Exon Smith6feb5c92016-06-30 23:28:15 +00001134 return MergeableSpills[MIdx].erase(&Spill);
Wei Mi815b02e2016-04-13 03:08:27 +00001135}
1136
1137/// Check BB to see if it is a possible target BB to place a hoisted spill,
1138/// i.e., there should be a living sibling of OrigReg at the insert point.
Wei Mi57d83cb2017-09-13 21:41:30 +00001139bool HoistSpillHelper::isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI,
Wei Mi815b02e2016-04-13 03:08:27 +00001140 MachineBasicBlock &BB, unsigned &LiveReg) {
1141 SlotIndex Idx;
Wei Mi57d83cb2017-09-13 21:41:30 +00001142 unsigned OrigReg = OrigLI.reg;
Wei Mi14a29ca2016-05-23 19:39:19 +00001143 MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, BB);
Wei Mi815b02e2016-04-13 03:08:27 +00001144 if (MI != BB.end())
1145 Idx = LIS.getInstructionIndex(*MI);
1146 else
1147 Idx = LIS.getMBBEndIdx(&BB).getPrevSlot();
1148 SmallSetVector<unsigned, 16> &Siblings = Virt2SiblingsMap[OrigReg];
Wei Mi57d83cb2017-09-13 21:41:30 +00001149 assert(OrigLI.getVNInfoAt(Idx) == &OrigVNI && "Unexpected VNI");
Wei Mi815b02e2016-04-13 03:08:27 +00001150
1151 for (auto const SibReg : Siblings) {
1152 LiveInterval &LI = LIS.getInterval(SibReg);
1153 VNInfo *VNI = LI.getVNInfoAt(Idx);
1154 if (VNI) {
1155 LiveReg = SibReg;
1156 return true;
1157 }
1158 }
1159 return false;
1160}
1161
Eric Christopher4449a752016-05-04 21:45:36 +00001162/// Remove redundant spills in the same BB. Save those redundant spills in
Wei Mi815b02e2016-04-13 03:08:27 +00001163/// SpillsToRm, and save the spill to keep and its BB in SpillBBToSpill map.
Wei Mi815b02e2016-04-13 03:08:27 +00001164void HoistSpillHelper::rmRedundantSpills(
1165 SmallPtrSet<MachineInstr *, 16> &Spills,
1166 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1167 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) {
1168 // For each spill saw, check SpillBBToSpill[] and see if its BB already has
1169 // another spill inside. If a BB contains more than one spill, only keep the
1170 // earlier spill with smaller SlotIndex.
1171 for (const auto CurrentSpill : Spills) {
1172 MachineBasicBlock *Block = CurrentSpill->getParent();
Bjorn Petterssoncd91cb12017-01-04 09:41:56 +00001173 MachineDomTreeNode *Node = MDT.getBase().getNode(Block);
Wei Mi815b02e2016-04-13 03:08:27 +00001174 MachineInstr *PrevSpill = SpillBBToSpill[Node];
1175 if (PrevSpill) {
1176 SlotIndex PIdx = LIS.getInstructionIndex(*PrevSpill);
1177 SlotIndex CIdx = LIS.getInstructionIndex(*CurrentSpill);
1178 MachineInstr *SpillToRm = (CIdx > PIdx) ? CurrentSpill : PrevSpill;
1179 MachineInstr *SpillToKeep = (CIdx > PIdx) ? PrevSpill : CurrentSpill;
1180 SpillsToRm.push_back(SpillToRm);
Bjorn Petterssoncd91cb12017-01-04 09:41:56 +00001181 SpillBBToSpill[MDT.getBase().getNode(Block)] = SpillToKeep;
Wei Mi815b02e2016-04-13 03:08:27 +00001182 } else {
Bjorn Petterssoncd91cb12017-01-04 09:41:56 +00001183 SpillBBToSpill[MDT.getBase().getNode(Block)] = CurrentSpill;
Wei Mi815b02e2016-04-13 03:08:27 +00001184 }
1185 }
1186 for (const auto SpillToRm : SpillsToRm)
1187 Spills.erase(SpillToRm);
1188}
1189
1190/// Starting from \p Root find a top-down traversal order of the dominator
1191/// tree to visit all basic blocks containing the elements of \p Spills.
1192/// Redundant spills will be found and put into \p SpillsToRm at the same
1193/// time. \p SpillBBToSpill will be populated as part of the process and
1194/// maps a basic block to the first store occurring in the basic block.
1195/// \post SpillsToRm.union(Spills\@post) == Spills\@pre
Wei Mi815b02e2016-04-13 03:08:27 +00001196void HoistSpillHelper::getVisitOrders(
1197 MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills,
1198 SmallVectorImpl<MachineDomTreeNode *> &Orders,
1199 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1200 DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep,
1201 DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) {
1202 // The set contains all the possible BB nodes to which we may hoist
1203 // original spills.
1204 SmallPtrSet<MachineDomTreeNode *, 8> WorkSet;
1205 // Save the BB nodes on the path from the first BB node containing
Eric Christopher4449a752016-05-04 21:45:36 +00001206 // non-redundant spill to the Root node.
Wei Mi815b02e2016-04-13 03:08:27 +00001207 SmallPtrSet<MachineDomTreeNode *, 8> NodesOnPath;
1208 // All the spills to be hoisted must originate from a single def instruction
1209 // to the OrigReg. It means the def instruction should dominate all the spills
1210 // to be hoisted. We choose the BB where the def instruction is located as
1211 // the Root.
1212 MachineDomTreeNode *RootIDomNode = MDT[Root]->getIDom();
1213 // For every node on the dominator tree with spill, walk up on the dominator
1214 // tree towards the Root node until it is reached. If there is other node
1215 // containing spill in the middle of the path, the previous spill saw will
Eric Christopher4449a752016-05-04 21:45:36 +00001216 // be redundant and the node containing it will be removed. All the nodes on
1217 // the path starting from the first node with non-redundant spill to the Root
Wei Mi815b02e2016-04-13 03:08:27 +00001218 // node will be added to the WorkSet, which will contain all the possible
1219 // locations where spills may be hoisted to after the loop below is done.
1220 for (const auto Spill : Spills) {
1221 MachineBasicBlock *Block = Spill->getParent();
1222 MachineDomTreeNode *Node = MDT[Block];
1223 MachineInstr *SpillToRm = nullptr;
1224 while (Node != RootIDomNode) {
1225 // If Node dominates Block, and it already contains a spill, the spill in
Eric Christopher4449a752016-05-04 21:45:36 +00001226 // Block will be redundant.
Wei Mi815b02e2016-04-13 03:08:27 +00001227 if (Node != MDT[Block] && SpillBBToSpill[Node]) {
1228 SpillToRm = SpillBBToSpill[MDT[Block]];
1229 break;
1230 /// If we see the Node already in WorkSet, the path from the Node to
1231 /// the Root node must already be traversed by another spill.
1232 /// Then no need to repeat.
1233 } else if (WorkSet.count(Node)) {
1234 break;
1235 } else {
1236 NodesOnPath.insert(Node);
1237 }
1238 Node = Node->getIDom();
1239 }
1240 if (SpillToRm) {
1241 SpillsToRm.push_back(SpillToRm);
1242 } else {
1243 // Add a BB containing the original spills to SpillsToKeep -- i.e.,
1244 // set the initial status before hoisting start. The value of BBs
1245 // containing original spills is set to 0, in order to descriminate
1246 // with BBs containing hoisted spills which will be inserted to
1247 // SpillsToKeep later during hoisting.
1248 SpillsToKeep[MDT[Block]] = 0;
1249 WorkSet.insert(NodesOnPath.begin(), NodesOnPath.end());
1250 }
1251 NodesOnPath.clear();
1252 }
1253
1254 // Sort the nodes in WorkSet in top-down order and save the nodes
1255 // in Orders. Orders will be used for hoisting in runHoistSpills.
1256 unsigned idx = 0;
Bjorn Petterssoncd91cb12017-01-04 09:41:56 +00001257 Orders.push_back(MDT.getBase().getNode(Root));
Wei Mi815b02e2016-04-13 03:08:27 +00001258 do {
1259 MachineDomTreeNode *Node = Orders[idx++];
1260 const std::vector<MachineDomTreeNode *> &Children = Node->getChildren();
1261 unsigned NumChildren = Children.size();
1262 for (unsigned i = 0; i != NumChildren; ++i) {
1263 MachineDomTreeNode *Child = Children[i];
1264 if (WorkSet.count(Child))
1265 Orders.push_back(Child);
1266 }
1267 } while (idx != Orders.size());
1268 assert(Orders.size() == WorkSet.size() &&
1269 "Orders have different size with WorkSet");
1270
1271#ifndef NDEBUG
Nicola Zaghen0818e782018-05-14 12:53:11 +00001272 LLVM_DEBUG(dbgs() << "Orders size is " << Orders.size() << "\n");
Wei Mi815b02e2016-04-13 03:08:27 +00001273 SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin();
1274 for (; RIt != Orders.rend(); RIt++)
Nicola Zaghen0818e782018-05-14 12:53:11 +00001275 LLVM_DEBUG(dbgs() << "BB" << (*RIt)->getBlock()->getNumber() << ",");
1276 LLVM_DEBUG(dbgs() << "\n");
Wei Mi815b02e2016-04-13 03:08:27 +00001277#endif
1278}
1279
1280/// Try to hoist spills according to BB hotness. The spills to removed will
1281/// be saved in \p SpillsToRm. The spills to be inserted will be saved in
1282/// \p SpillsToIns.
Wei Mi815b02e2016-04-13 03:08:27 +00001283void HoistSpillHelper::runHoistSpills(
Wei Mi57d83cb2017-09-13 21:41:30 +00001284 LiveInterval &OrigLI, VNInfo &OrigVNI,
1285 SmallPtrSet<MachineInstr *, 16> &Spills,
Wei Mi815b02e2016-04-13 03:08:27 +00001286 SmallVectorImpl<MachineInstr *> &SpillsToRm,
1287 DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns) {
1288 // Visit order of dominator tree nodes.
1289 SmallVector<MachineDomTreeNode *, 32> Orders;
1290 // SpillsToKeep contains all the nodes where spills are to be inserted
1291 // during hoisting. If the spill to be inserted is an original spill
1292 // (not a hoisted one), the value of the map entry is 0. If the spill
1293 // is a hoisted spill, the value of the map entry is the VReg to be used
1294 // as the source of the spill.
1295 DenseMap<MachineDomTreeNode *, unsigned> SpillsToKeep;
1296 // Map from BB to the first spill inside of it.
1297 DenseMap<MachineDomTreeNode *, MachineInstr *> SpillBBToSpill;
1298
1299 rmRedundantSpills(Spills, SpillsToRm, SpillBBToSpill);
1300
1301 MachineBasicBlock *Root = LIS.getMBBFromIndex(OrigVNI.def);
1302 getVisitOrders(Root, Spills, Orders, SpillsToRm, SpillsToKeep,
1303 SpillBBToSpill);
1304
1305 // SpillsInSubTreeMap keeps the map from a dom tree node to a pair of
1306 // nodes set and the cost of all the spills inside those nodes.
1307 // The nodes set are the locations where spills are to be inserted
1308 // in the subtree of current node.
Eugene Zelenko7cf6af52017-08-29 22:32:07 +00001309 using NodesCostPair =
1310 std::pair<SmallPtrSet<MachineDomTreeNode *, 16>, BlockFrequency>;
Wei Mi815b02e2016-04-13 03:08:27 +00001311 DenseMap<MachineDomTreeNode *, NodesCostPair> SpillsInSubTreeMap;
Eugene Zelenko7cf6af52017-08-29 22:32:07 +00001312
Wei Mi815b02e2016-04-13 03:08:27 +00001313 // Iterate Orders set in reverse order, which will be a bottom-up order
1314 // in the dominator tree. Once we visit a dom tree node, we know its
1315 // children have already been visited and the spill locations in the
1316 // subtrees of all the children have been determined.
1317 SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin();
1318 for (; RIt != Orders.rend(); RIt++) {
1319 MachineBasicBlock *Block = (*RIt)->getBlock();
1320
1321 // If Block contains an original spill, simply continue.
1322 if (SpillsToKeep.find(*RIt) != SpillsToKeep.end() && !SpillsToKeep[*RIt]) {
1323 SpillsInSubTreeMap[*RIt].first.insert(*RIt);
1324 // SpillsInSubTreeMap[*RIt].second contains the cost of spill.
1325 SpillsInSubTreeMap[*RIt].second = MBFI.getBlockFreq(Block);
1326 continue;
1327 }
1328
1329 // Collect spills in subtree of current node (*RIt) to
1330 // SpillsInSubTreeMap[*RIt].first.
1331 const std::vector<MachineDomTreeNode *> &Children = (*RIt)->getChildren();
1332 unsigned NumChildren = Children.size();
1333 for (unsigned i = 0; i != NumChildren; ++i) {
1334 MachineDomTreeNode *Child = Children[i];
1335 if (SpillsInSubTreeMap.find(Child) == SpillsInSubTreeMap.end())
1336 continue;
1337 // The stmt "SpillsInSubTree = SpillsInSubTreeMap[*RIt].first" below
1338 // should be placed before getting the begin and end iterators of
1339 // SpillsInSubTreeMap[Child].first, or else the iterators may be
1340 // invalidated when SpillsInSubTreeMap[*RIt] is seen the first time
1341 // and the map grows and then the original buckets in the map are moved.
1342 SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree =
1343 SpillsInSubTreeMap[*RIt].first;
1344 BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second;
1345 SubTreeCost += SpillsInSubTreeMap[Child].second;
1346 auto BI = SpillsInSubTreeMap[Child].first.begin();
1347 auto EI = SpillsInSubTreeMap[Child].first.end();
1348 SpillsInSubTree.insert(BI, EI);
1349 SpillsInSubTreeMap.erase(Child);
1350 }
1351
1352 SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree =
1353 SpillsInSubTreeMap[*RIt].first;
1354 BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second;
1355 // No spills in subtree, simply continue.
1356 if (SpillsInSubTree.empty())
1357 continue;
1358
1359 // Check whether Block is a possible candidate to insert spill.
1360 unsigned LiveReg = 0;
Wei Mi57d83cb2017-09-13 21:41:30 +00001361 if (!isSpillCandBB(OrigLI, OrigVNI, *Block, LiveReg))
Wei Mi815b02e2016-04-13 03:08:27 +00001362 continue;
1363
1364 // If there are multiple spills that could be merged, bias a little
1365 // to hoist the spill.
1366 BranchProbability MarginProb = (SpillsInSubTree.size() > 1)
1367 ? BranchProbability(9, 10)
1368 : BranchProbability(1, 1);
1369 if (SubTreeCost > MBFI.getBlockFreq(Block) * MarginProb) {
1370 // Hoist: Move spills to current Block.
1371 for (const auto SpillBB : SpillsInSubTree) {
1372 // When SpillBB is a BB contains original spill, insert the spill
1373 // to SpillsToRm.
1374 if (SpillsToKeep.find(SpillBB) != SpillsToKeep.end() &&
1375 !SpillsToKeep[SpillBB]) {
1376 MachineInstr *SpillToRm = SpillBBToSpill[SpillBB];
1377 SpillsToRm.push_back(SpillToRm);
1378 }
1379 // SpillBB will not contain spill anymore, remove it from SpillsToKeep.
1380 SpillsToKeep.erase(SpillBB);
1381 }
1382 // Current Block is the BB containing the new hoisted spill. Add it to
1383 // SpillsToKeep. LiveReg is the source of the new spill.
1384 SpillsToKeep[*RIt] = LiveReg;
Nicola Zaghen0818e782018-05-14 12:53:11 +00001385 LLVM_DEBUG({
Wei Mi815b02e2016-04-13 03:08:27 +00001386 dbgs() << "spills in BB: ";
1387 for (const auto Rspill : SpillsInSubTree)
1388 dbgs() << Rspill->getBlock()->getNumber() << " ";
1389 dbgs() << "were promoted to BB" << (*RIt)->getBlock()->getNumber()
1390 << "\n";
1391 });
1392 SpillsInSubTree.clear();
1393 SpillsInSubTree.insert(*RIt);
1394 SubTreeCost = MBFI.getBlockFreq(Block);
1395 }
1396 }
1397 // For spills in SpillsToKeep with LiveReg set (i.e., not original spill),
1398 // save them to SpillsToIns.
1399 for (const auto Ent : SpillsToKeep) {
1400 if (Ent.second)
1401 SpillsToIns[Ent.first->getBlock()] = Ent.second;
1402 }
1403}
1404
Eric Christopher4449a752016-05-04 21:45:36 +00001405/// For spills with equal values, remove redundant spills and hoist those left
Wei Mi815b02e2016-04-13 03:08:27 +00001406/// to less hot spots.
1407///
1408/// Spills with equal values will be collected into the same set in
1409/// MergeableSpills when spill is inserted. These equal spills are originated
Eric Christopher4449a752016-05-04 21:45:36 +00001410/// from the same defining instruction and are dominated by the instruction.
1411/// Before hoisting all the equal spills, redundant spills inside in the same
1412/// BB are first marked to be deleted. Then starting from the spills left, walk
1413/// up on the dominator tree towards the Root node where the define instruction
Wei Mi815b02e2016-04-13 03:08:27 +00001414/// is located, mark the dominated spills to be deleted along the way and
1415/// collect the BB nodes on the path from non-dominated spills to the define
1416/// instruction into a WorkSet. The nodes in WorkSet are the candidate places
Eric Christopher4449a752016-05-04 21:45:36 +00001417/// where we are considering to hoist the spills. We iterate the WorkSet in
1418/// bottom-up order, and for each node, we will decide whether to hoist spills
1419/// inside its subtree to that node. In this way, we can get benefit locally
1420/// even if hoisting all the equal spills to one cold place is impossible.
Wei Mi1f5a2c32016-04-15 23:16:44 +00001421void HoistSpillHelper::hoistAllSpills() {
1422 SmallVector<unsigned, 4> NewVRegs;
1423 LiveRangeEdit Edit(nullptr, NewVRegs, MF, LIS, &VRM, this);
1424
Wei Mi815b02e2016-04-13 03:08:27 +00001425 for (unsigned i = 0, e = MRI.getNumVirtRegs(); i != e; ++i) {
1426 unsigned Reg = TargetRegisterInfo::index2VirtReg(i);
Wei Mi815b02e2016-04-13 03:08:27 +00001427 unsigned Original = VRM.getPreSplitReg(Reg);
1428 if (!MRI.def_empty(Reg))
1429 Virt2SiblingsMap[Original].insert(Reg);
1430 }
1431
1432 // Each entry in MergeableSpills contains a spill set with equal values.
1433 for (auto &Ent : MergeableSpills) {
1434 int Slot = Ent.first.first;
Wei Mi57d83cb2017-09-13 21:41:30 +00001435 LiveInterval &OrigLI = *StackSlotToOrigLI[Slot];
Wei Mi815b02e2016-04-13 03:08:27 +00001436 VNInfo *OrigVNI = Ent.first.second;
1437 SmallPtrSet<MachineInstr *, 16> &EqValSpills = Ent.second;
1438 if (Ent.second.empty())
1439 continue;
1440
Nicola Zaghen0818e782018-05-14 12:53:11 +00001441 LLVM_DEBUG({
Wei Mi815b02e2016-04-13 03:08:27 +00001442 dbgs() << "\nFor Slot" << Slot << " and VN" << OrigVNI->id << ":\n"
1443 << "Equal spills in BB: ";
1444 for (const auto spill : EqValSpills)
1445 dbgs() << spill->getParent()->getNumber() << " ";
1446 dbgs() << "\n";
1447 });
1448
1449 // SpillsToRm is the spill set to be removed from EqValSpills.
1450 SmallVector<MachineInstr *, 16> SpillsToRm;
1451 // SpillsToIns is the spill set to be newly inserted after hoisting.
1452 DenseMap<MachineBasicBlock *, unsigned> SpillsToIns;
1453
Wei Mi57d83cb2017-09-13 21:41:30 +00001454 runHoistSpills(OrigLI, *OrigVNI, EqValSpills, SpillsToRm, SpillsToIns);
Wei Mi815b02e2016-04-13 03:08:27 +00001455
Nicola Zaghen0818e782018-05-14 12:53:11 +00001456 LLVM_DEBUG({
Wei Mi815b02e2016-04-13 03:08:27 +00001457 dbgs() << "Finally inserted spills in BB: ";
1458 for (const auto Ispill : SpillsToIns)
1459 dbgs() << Ispill.first->getNumber() << " ";
1460 dbgs() << "\nFinally removed spills in BB: ";
1461 for (const auto Rspill : SpillsToRm)
1462 dbgs() << Rspill->getParent()->getNumber() << " ";
1463 dbgs() << "\n";
1464 });
1465
1466 // Stack live range update.
1467 LiveInterval &StackIntvl = LSS.getInterval(Slot);
Wei Mi825e5aa2016-05-11 22:37:43 +00001468 if (!SpillsToIns.empty() || !SpillsToRm.empty())
Wei Mi815b02e2016-04-13 03:08:27 +00001469 StackIntvl.MergeValueInAsValue(OrigLI, OrigVNI,
1470 StackIntvl.getValNumInfo(0));
Wei Mi815b02e2016-04-13 03:08:27 +00001471
1472 // Insert hoisted spills.
1473 for (auto const Insert : SpillsToIns) {
1474 MachineBasicBlock *BB = Insert.first;
1475 unsigned LiveReg = Insert.second;
Wei Mi14a29ca2016-05-23 19:39:19 +00001476 MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB);
Wei Mi815b02e2016-04-13 03:08:27 +00001477 TII.storeRegToStackSlot(*BB, MI, LiveReg, false, Slot,
1478 MRI.getRegClass(LiveReg), &TRI);
1479 LIS.InsertMachineInstrRangeInMaps(std::prev(MI), MI);
1480 ++NumSpills;
1481 }
1482
Eric Christopher4449a752016-05-04 21:45:36 +00001483 // Remove redundant spills or change them to dead instructions.
Wei Mi815b02e2016-04-13 03:08:27 +00001484 NumSpills -= SpillsToRm.size();
1485 for (auto const RMEnt : SpillsToRm) {
1486 RMEnt->setDesc(TII.get(TargetOpcode::KILL));
1487 for (unsigned i = RMEnt->getNumOperands(); i; --i) {
1488 MachineOperand &MO = RMEnt->getOperand(i - 1);
1489 if (MO.isReg() && MO.isImplicit() && MO.isDef() && !MO.isDead())
1490 RMEnt->RemoveOperand(i - 1);
1491 }
1492 }
Wei Mi4eae2782016-07-08 21:08:09 +00001493 Edit.eliminateDeadDefs(SpillsToRm, None, AA);
Wei Mi815b02e2016-04-13 03:08:27 +00001494 }
1495}
Wei Mi1f5a2c32016-04-15 23:16:44 +00001496
1497/// For VirtReg clone, the \p New register should have the same physreg or
1498/// stackslot as the \p old register.
1499void HoistSpillHelper::LRE_DidCloneVirtReg(unsigned New, unsigned Old) {
1500 if (VRM.hasPhys(Old))
1501 VRM.assignVirt2Phys(New, VRM.getPhys(Old));
1502 else if (VRM.getStackSlot(Old) != VirtRegMap::NO_STACK_SLOT)
1503 VRM.assignVirt2StackSlot(New, VRM.getStackSlot(Old));
1504 else
1505 llvm_unreachable("VReg should be assigned either physreg or stackslot");
1506}