Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 1 | //===- InlineSpiller.cpp - Insert spills and restores inline --------------===// |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // The inline spiller modifies the machine function directly instead of |
| 11 | // inserting spills and restores in VirtRegMap. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 15 | #include "LiveRangeCalc.h" |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 16 | #include "Spiller.h" |
Wei Mi | 825e5aa | 2016-05-11 22:37:43 +0000 | [diff] [blame] | 17 | #include "SplitKit.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 18 | #include "llvm/ADT/ArrayRef.h" |
| 19 | #include "llvm/ADT/DenseMap.h" |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 20 | #include "llvm/ADT/MapVector.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 21 | #include "llvm/ADT/None.h" |
| 22 | #include "llvm/ADT/STLExtras.h" |
Benjamin Kramer | 2db14ba | 2013-05-23 15:42:57 +0000 | [diff] [blame] | 23 | #include "llvm/ADT/SetVector.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 24 | #include "llvm/ADT/SmallPtrSet.h" |
| 25 | #include "llvm/ADT/SmallVector.h" |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/Statistic.h" |
Jakob Stoklund Olesen | e93198a | 2010-11-10 23:55:56 +0000 | [diff] [blame] | 27 | #include "llvm/Analysis/AliasAnalysis.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 28 | #include "llvm/CodeGen/LiveInterval.h" |
Matthias Braun | fa621d2 | 2017-12-13 02:51:04 +0000 | [diff] [blame] | 29 | #include "llvm/CodeGen/LiveIntervals.h" |
Pete Cooper | 789d5d8 | 2012-04-02 22:44:18 +0000 | [diff] [blame] | 30 | #include "llvm/CodeGen/LiveRangeEdit.h" |
Matthias Braun | 209f048 | 2017-12-18 23:19:44 +0000 | [diff] [blame] | 31 | #include "llvm/CodeGen/LiveStacks.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 32 | #include "llvm/CodeGen/MachineBasicBlock.h" |
Benjamin Kramer | 4eed756 | 2013-06-17 19:00:36 +0000 | [diff] [blame] | 33 | #include "llvm/CodeGen/MachineBlockFrequencyInfo.h" |
Chandler Carruth | 974a445 | 2014-01-07 11:48:04 +0000 | [diff] [blame] | 34 | #include "llvm/CodeGen/MachineDominators.h" |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 35 | #include "llvm/CodeGen/MachineFunction.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 36 | #include "llvm/CodeGen/MachineFunctionPass.h" |
| 37 | #include "llvm/CodeGen/MachineInstr.h" |
David Blaikie | 6d9dbd5 | 2013-06-16 20:34:15 +0000 | [diff] [blame] | 38 | #include "llvm/CodeGen/MachineInstrBuilder.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 39 | #include "llvm/CodeGen/MachineInstrBundle.h" |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 40 | #include "llvm/CodeGen/MachineLoopInfo.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 41 | #include "llvm/CodeGen/MachineOperand.h" |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 42 | #include "llvm/CodeGen/MachineRegisterInfo.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 43 | #include "llvm/CodeGen/SlotIndexes.h" |
David Blaikie | 4831923 | 2017-11-08 01:01:31 +0000 | [diff] [blame] | 44 | #include "llvm/CodeGen/TargetInstrInfo.h" |
David Blaikie | e3a9b4c | 2017-11-17 01:07:10 +0000 | [diff] [blame] | 45 | #include "llvm/CodeGen/TargetOpcodes.h" |
| 46 | #include "llvm/CodeGen/TargetRegisterInfo.h" |
| 47 | #include "llvm/CodeGen/TargetSubtargetInfo.h" |
Jakob Stoklund Olesen | 1ead68d | 2012-11-28 19:13:06 +0000 | [diff] [blame] | 48 | #include "llvm/CodeGen/VirtRegMap.h" |
Nico Weber | 0f38c60 | 2018-04-30 14:59:11 +0000 | [diff] [blame] | 49 | #include "llvm/Config/llvm-config.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 50 | #include "llvm/Support/BlockFrequency.h" |
| 51 | #include "llvm/Support/BranchProbability.h" |
Jakob Stoklund Olesen | b9edad0 | 2011-09-15 21:06:00 +0000 | [diff] [blame] | 52 | #include "llvm/Support/CommandLine.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 53 | #include "llvm/Support/Compiler.h" |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 54 | #include "llvm/Support/Debug.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 55 | #include "llvm/Support/ErrorHandling.h" |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 56 | #include "llvm/Support/raw_ostream.h" |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 57 | #include <cassert> |
| 58 | #include <iterator> |
| 59 | #include <tuple> |
| 60 | #include <utility> |
| 61 | #include <vector> |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 62 | |
| 63 | using namespace llvm; |
| 64 | |
Chandler Carruth | 8677f2f | 2014-04-22 02:02:50 +0000 | [diff] [blame] | 65 | #define DEBUG_TYPE "regalloc" |
| 66 | |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 67 | STATISTIC(NumSpilledRanges, "Number of spilled live ranges"); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 68 | STATISTIC(NumSnippets, "Number of spilled snippets"); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 69 | STATISTIC(NumSpills, "Number of spills inserted"); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 70 | STATISTIC(NumSpillsRemoved, "Number of spills removed"); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 71 | STATISTIC(NumReloads, "Number of reloads inserted"); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 72 | STATISTIC(NumReloadsRemoved, "Number of reloads removed"); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 73 | STATISTIC(NumFolded, "Number of folded stack accesses"); |
| 74 | STATISTIC(NumFoldedLoads, "Number of folded loads"); |
| 75 | STATISTIC(NumRemats, "Number of rematerialized defs for spilling"); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 76 | |
Jakob Stoklund Olesen | b9edad0 | 2011-09-15 21:06:00 +0000 | [diff] [blame] | 77 | static cl::opt<bool> DisableHoisting("disable-spill-hoist", cl::Hidden, |
| 78 | cl::desc("Disable inline spill hoisting")); |
| 79 | |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 80 | namespace { |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 81 | |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 82 | class HoistSpillHelper : private LiveRangeEdit::Delegate { |
| 83 | MachineFunction &MF; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 84 | LiveIntervals &LIS; |
| 85 | LiveStacks &LSS; |
| 86 | AliasAnalysis *AA; |
| 87 | MachineDominatorTree &MDT; |
| 88 | MachineLoopInfo &Loops; |
| 89 | VirtRegMap &VRM; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 90 | MachineRegisterInfo &MRI; |
| 91 | const TargetInstrInfo &TII; |
| 92 | const TargetRegisterInfo &TRI; |
| 93 | const MachineBlockFrequencyInfo &MBFI; |
| 94 | |
Wei Mi | 825e5aa | 2016-05-11 22:37:43 +0000 | [diff] [blame] | 95 | InsertPointAnalysis IPA; |
| 96 | |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 97 | // Map from StackSlot to the LiveInterval of the original register. |
| 98 | // Note the LiveInterval of the original register may have been deleted |
| 99 | // after it is spilled. We keep a copy here to track the range where |
| 100 | // spills can be moved. |
| 101 | DenseMap<int, std::unique_ptr<LiveInterval>> StackSlotToOrigLI; |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 102 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 103 | // Map from pair of (StackSlot and Original VNI) to a set of spills which |
| 104 | // have the same stackslot and have equal values defined by Original VNI. |
| 105 | // These spills are mergeable and are hoist candiates. |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 106 | using MergeableSpillsMap = |
| 107 | MapVector<std::pair<int, VNInfo *>, SmallPtrSet<MachineInstr *, 16>>; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 108 | MergeableSpillsMap MergeableSpills; |
| 109 | |
| 110 | /// This is the map from original register to a set containing all its |
| 111 | /// siblings. To hoist a spill to another BB, we need to find out a live |
| 112 | /// sibling there and use it as the source of the new spill. |
| 113 | DenseMap<unsigned, SmallSetVector<unsigned, 16>> Virt2SiblingsMap; |
| 114 | |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 115 | bool isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI, |
| 116 | MachineBasicBlock &BB, unsigned &LiveReg); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 117 | |
| 118 | void rmRedundantSpills( |
| 119 | SmallPtrSet<MachineInstr *, 16> &Spills, |
| 120 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 121 | DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill); |
| 122 | |
| 123 | void getVisitOrders( |
| 124 | MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills, |
| 125 | SmallVectorImpl<MachineDomTreeNode *> &Orders, |
| 126 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 127 | DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep, |
| 128 | DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill); |
| 129 | |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 130 | void runHoistSpills(LiveInterval &OrigLI, VNInfo &OrigVNI, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 131 | SmallPtrSet<MachineInstr *, 16> &Spills, |
| 132 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 133 | DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns); |
| 134 | |
| 135 | public: |
| 136 | HoistSpillHelper(MachineFunctionPass &pass, MachineFunction &mf, |
| 137 | VirtRegMap &vrm) |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 138 | : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()), |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 139 | LSS(pass.getAnalysis<LiveStacks>()), |
| 140 | AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()), |
| 141 | MDT(pass.getAnalysis<MachineDominatorTree>()), |
| 142 | Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm), |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 143 | MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()), |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 144 | TRI(*mf.getSubtarget().getRegisterInfo()), |
Wei Mi | 825e5aa | 2016-05-11 22:37:43 +0000 | [diff] [blame] | 145 | MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()), |
| 146 | IPA(LIS, mf.getNumBlockIDs()) {} |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 147 | |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 148 | void addToMergeableSpills(MachineInstr &Spill, int StackSlot, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 149 | unsigned Original); |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 150 | bool rmFromMergeableSpills(MachineInstr &Spill, int StackSlot); |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 151 | void hoistAllSpills(); |
| 152 | void LRE_DidCloneVirtReg(unsigned, unsigned) override; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 153 | }; |
| 154 | |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 155 | class InlineSpiller : public Spiller { |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 156 | MachineFunction &MF; |
| 157 | LiveIntervals &LIS; |
| 158 | LiveStacks &LSS; |
| 159 | AliasAnalysis *AA; |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 160 | MachineDominatorTree &MDT; |
| 161 | MachineLoopInfo &Loops; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 162 | VirtRegMap &VRM; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 163 | MachineRegisterInfo &MRI; |
| 164 | const TargetInstrInfo &TII; |
| 165 | const TargetRegisterInfo &TRI; |
Benjamin Kramer | 4eed756 | 2013-06-17 19:00:36 +0000 | [diff] [blame] | 166 | const MachineBlockFrequencyInfo &MBFI; |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 167 | |
| 168 | // Variables that are valid during spill(), but used by multiple methods. |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 169 | LiveRangeEdit *Edit; |
Jakob Stoklund Olesen | e9c5073 | 2011-03-26 22:16:41 +0000 | [diff] [blame] | 170 | LiveInterval *StackInt; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 171 | int StackSlot; |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 172 | unsigned Original; |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 173 | |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 174 | // All registers to spill to StackSlot, including the main register. |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 175 | SmallVector<unsigned, 8> RegsToSpill; |
| 176 | |
| 177 | // All COPY instructions to/from snippets. |
| 178 | // They are ignored since both operands refer to the same stack slot. |
| 179 | SmallPtrSet<MachineInstr*, 8> SnippetCopies; |
| 180 | |
Jakob Stoklund Olesen | 080c316 | 2010-10-20 22:00:51 +0000 | [diff] [blame] | 181 | // Values that failed to remat at some point. |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 182 | SmallPtrSet<VNInfo*, 8> UsedValues; |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 183 | |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 184 | // Dead defs generated during spilling. |
| 185 | SmallVector<MachineInstr*, 8> DeadDefs; |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 186 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 187 | // Object records spills information and does the hoisting. |
| 188 | HoistSpillHelper HSpiller; |
| 189 | |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 190 | ~InlineSpiller() override = default; |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 191 | |
| 192 | public: |
Eric Christopher | 9f85dcc | 2014-08-04 21:25:23 +0000 | [diff] [blame] | 193 | InlineSpiller(MachineFunctionPass &pass, MachineFunction &mf, VirtRegMap &vrm) |
| 194 | : MF(mf), LIS(pass.getAnalysis<LiveIntervals>()), |
| 195 | LSS(pass.getAnalysis<LiveStacks>()), |
Chandler Carruth | 9146833 | 2015-09-09 17:55:00 +0000 | [diff] [blame] | 196 | AA(&pass.getAnalysis<AAResultsWrapperPass>().getAAResults()), |
Eric Christopher | 9f85dcc | 2014-08-04 21:25:23 +0000 | [diff] [blame] | 197 | MDT(pass.getAnalysis<MachineDominatorTree>()), |
| 198 | Loops(pass.getAnalysis<MachineLoopInfo>()), VRM(vrm), |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 199 | MRI(mf.getRegInfo()), TII(*mf.getSubtarget().getInstrInfo()), |
Eric Christopher | 6035518 | 2014-08-05 02:39:49 +0000 | [diff] [blame] | 200 | TRI(*mf.getSubtarget().getRegisterInfo()), |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 201 | MBFI(pass.getAnalysis<MachineBlockFrequencyInfo>()), |
| 202 | HSpiller(pass, mf, vrm) {} |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 203 | |
Craig Topper | 9f998de | 2014-03-07 09:26:03 +0000 | [diff] [blame] | 204 | void spill(LiveRangeEdit &) override; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 205 | void postOptimization() override; |
Jakob Stoklund Olesen | a17768f | 2010-10-14 23:49:52 +0000 | [diff] [blame] | 206 | |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 207 | private: |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 208 | bool isSnippet(const LiveInterval &SnipLI); |
| 209 | void collectRegsToSpill(); |
| 210 | |
David Majnemer | 2d62ce6 | 2016-08-12 03:55:06 +0000 | [diff] [blame] | 211 | bool isRegToSpill(unsigned Reg) { return is_contained(RegsToSpill, Reg); } |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 212 | |
| 213 | bool isSibling(unsigned Reg); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 214 | bool hoistSpillInsideBB(LiveInterval &SpillLI, MachineInstr &CopyMI); |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 215 | void eliminateRedundantSpills(LiveInterval &LI, VNInfo *VNI); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 216 | |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 217 | void markValueUsed(LiveInterval*, VNInfo*); |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 218 | bool reMaterializeFor(LiveInterval &, MachineInstr &MI); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 219 | void reMaterializeAll(); |
| 220 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 221 | bool coalesceStackAccess(MachineInstr *MI, unsigned Reg); |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 222 | bool foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>>, |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 223 | MachineInstr *LoadMI = nullptr); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 224 | void insertReload(unsigned VReg, SlotIndex, MachineBasicBlock::iterator MI); |
| 225 | void insertSpill(unsigned VReg, bool isKill, MachineBasicBlock::iterator MI); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 226 | |
| 227 | void spillAroundUses(unsigned Reg); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 228 | void spillAll(); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 229 | }; |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 230 | |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 231 | } // end anonymous namespace |
Lang Hames | 4e2cbd5 | 2014-11-06 19:12:38 +0000 | [diff] [blame] | 232 | |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 233 | Spiller::~Spiller() = default; |
Lang Hames | 4e2cbd5 | 2014-11-06 19:12:38 +0000 | [diff] [blame] | 234 | |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 235 | void Spiller::anchor() {} |
| 236 | |
| 237 | Spiller *llvm::createInlineSpiller(MachineFunctionPass &pass, |
| 238 | MachineFunction &mf, |
| 239 | VirtRegMap &vrm) { |
Jakob Stoklund Olesen | f2c6e36 | 2010-07-20 23:50:15 +0000 | [diff] [blame] | 240 | return new InlineSpiller(pass, mf, vrm); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 241 | } |
Lang Hames | 4e2cbd5 | 2014-11-06 19:12:38 +0000 | [diff] [blame] | 242 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 243 | //===----------------------------------------------------------------------===// |
| 244 | // Snippets |
| 245 | //===----------------------------------------------------------------------===// |
| 246 | |
| 247 | // When spilling a virtual register, we also spill any snippets it is connected |
| 248 | // to. The snippets are small live ranges that only have a single real use, |
| 249 | // leftovers from live range splitting. Spilling them enables memory operand |
| 250 | // folding or tightens the live range around the single use. |
| 251 | // |
| 252 | // This minimizes register pressure and maximizes the store-to-load distance for |
| 253 | // spill slots which can be important in tight loops. |
| 254 | |
| 255 | /// isFullCopyOf - If MI is a COPY to or from Reg, return the other register, |
| 256 | /// otherwise return 0. |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 257 | static unsigned isFullCopyOf(const MachineInstr &MI, unsigned Reg) { |
| 258 | if (!MI.isFullCopy()) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 259 | return 0; |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 260 | if (MI.getOperand(0).getReg() == Reg) |
| 261 | return MI.getOperand(1).getReg(); |
| 262 | if (MI.getOperand(1).getReg() == Reg) |
| 263 | return MI.getOperand(0).getReg(); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 264 | return 0; |
| 265 | } |
| 266 | |
| 267 | /// isSnippet - Identify if a live interval is a snippet that should be spilled. |
| 268 | /// It is assumed that SnipLI is a virtual register with the same original as |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 269 | /// Edit->getReg(). |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 270 | bool InlineSpiller::isSnippet(const LiveInterval &SnipLI) { |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 271 | unsigned Reg = Edit->getReg(); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 272 | |
| 273 | // A snippet is a tiny live range with only a single instruction using it |
| 274 | // besides copies to/from Reg or spills/fills. We accept: |
| 275 | // |
| 276 | // %snip = COPY %Reg / FILL fi# |
| 277 | // %snip = USE %snip |
| 278 | // %Reg = COPY %snip / SPILL %snip, fi# |
| 279 | // |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 280 | if (SnipLI.getNumValNums() > 2 || !LIS.intervalIsInOneMBB(SnipLI)) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 281 | return false; |
| 282 | |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 283 | MachineInstr *UseMI = nullptr; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 284 | |
| 285 | // Check that all uses satisfy our criteria. |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 286 | for (MachineRegisterInfo::reg_instr_nodbg_iterator |
| 287 | RI = MRI.reg_instr_nodbg_begin(SnipLI.reg), |
| 288 | E = MRI.reg_instr_nodbg_end(); RI != E; ) { |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 289 | MachineInstr &MI = *RI++; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 290 | |
| 291 | // Allow copies to/from Reg. |
| 292 | if (isFullCopyOf(MI, Reg)) |
| 293 | continue; |
| 294 | |
| 295 | // Allow stack slot loads. |
| 296 | int FI; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 297 | if (SnipLI.reg == TII.isLoadFromStackSlot(MI, FI) && FI == StackSlot) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 298 | continue; |
| 299 | |
| 300 | // Allow stack slot stores. |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 301 | if (SnipLI.reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 302 | continue; |
| 303 | |
| 304 | // Allow a single additional instruction. |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 305 | if (UseMI && &MI != UseMI) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 306 | return false; |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 307 | UseMI = &MI; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 308 | } |
| 309 | return true; |
| 310 | } |
| 311 | |
| 312 | /// collectRegsToSpill - Collect live range snippets that only have a single |
| 313 | /// real use. |
| 314 | void InlineSpiller::collectRegsToSpill() { |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 315 | unsigned Reg = Edit->getReg(); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 316 | |
| 317 | // Main register always spills. |
| 318 | RegsToSpill.assign(1, Reg); |
| 319 | SnippetCopies.clear(); |
| 320 | |
| 321 | // Snippets all have the same original, so there can't be any for an original |
| 322 | // register. |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 323 | if (Original == Reg) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 324 | return; |
| 325 | |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 326 | for (MachineRegisterInfo::reg_instr_iterator |
| 327 | RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end(); RI != E; ) { |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 328 | MachineInstr &MI = *RI++; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 329 | unsigned SnipReg = isFullCopyOf(MI, Reg); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 330 | if (!isSibling(SnipReg)) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 331 | continue; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 332 | LiveInterval &SnipLI = LIS.getInterval(SnipReg); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 333 | if (!isSnippet(SnipLI)) |
| 334 | continue; |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 335 | SnippetCopies.insert(&MI); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 336 | if (isRegToSpill(SnipReg)) |
| 337 | continue; |
| 338 | RegsToSpill.push_back(SnipReg); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 339 | LLVM_DEBUG(dbgs() << "\talso spill snippet " << SnipLI << '\n'); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 340 | ++NumSnippets; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 341 | } |
| 342 | } |
| 343 | |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 344 | bool InlineSpiller::isSibling(unsigned Reg) { |
| 345 | return TargetRegisterInfo::isVirtualRegister(Reg) && |
| 346 | VRM.getOriginal(Reg) == Original; |
| 347 | } |
| 348 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 349 | /// It is beneficial to spill to earlier place in the same BB in case |
| 350 | /// as follows: |
| 351 | /// There is an alternative def earlier in the same MBB. |
| 352 | /// Hoist the spill as far as possible in SpillMBB. This can ease |
| 353 | /// register pressure: |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 354 | /// |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 355 | /// x = def |
| 356 | /// y = use x |
| 357 | /// s = copy x |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 358 | /// |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 359 | /// Hoisting the spill of s to immediately after the def removes the |
| 360 | /// interference between x and y: |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 361 | /// |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 362 | /// x = def |
| 363 | /// spill x |
Francis Visoiu Mistrih | fd11bc0 | 2017-12-07 10:40:31 +0000 | [diff] [blame] | 364 | /// y = use killed x |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 365 | /// |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 366 | /// This hoist only helps when the copy kills its source. |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 367 | /// |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 368 | bool InlineSpiller::hoistSpillInsideBB(LiveInterval &SpillLI, |
| 369 | MachineInstr &CopyMI) { |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 370 | SlotIndex Idx = LIS.getInstructionIndex(CopyMI); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 371 | #ifndef NDEBUG |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 372 | VNInfo *VNI = SpillLI.getVNInfoAt(Idx.getRegSlot()); |
| 373 | assert(VNI && VNI->def == Idx.getRegSlot() && "Not defined by copy"); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 374 | #endif |
Wei Mi | e19a68b | 2016-04-04 17:45:03 +0000 | [diff] [blame] | 375 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 376 | unsigned SrcReg = CopyMI.getOperand(1).getReg(); |
| 377 | LiveInterval &SrcLI = LIS.getInterval(SrcReg); |
| 378 | VNInfo *SrcVNI = SrcLI.getVNInfoAt(Idx); |
| 379 | LiveQueryResult SrcQ = SrcLI.Query(Idx); |
| 380 | MachineBasicBlock *DefMBB = LIS.getMBBFromIndex(SrcVNI->def); |
| 381 | if (DefMBB != CopyMI.getParent() || !SrcQ.isKill()) |
Hans Wennborg | d8b70fb | 2016-04-08 15:17:43 +0000 | [diff] [blame] | 382 | return false; |
| 383 | |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 384 | // Conservatively extend the stack slot range to the range of the original |
| 385 | // value. We may be able to do better with stack slot coloring by being more |
| 386 | // careful here. |
Jakob Stoklund Olesen | e9c5073 | 2011-03-26 22:16:41 +0000 | [diff] [blame] | 387 | assert(StackInt && "No stack slot assigned yet."); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 388 | LiveInterval &OrigLI = LIS.getInterval(Original); |
| 389 | VNInfo *OrigVNI = OrigLI.getVNInfoAt(Idx); |
Jakob Stoklund Olesen | e9c5073 | 2011-03-26 22:16:41 +0000 | [diff] [blame] | 390 | StackInt->MergeValueInAsValue(OrigLI, OrigVNI, StackInt->getValNumInfo(0)); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 391 | LLVM_DEBUG(dbgs() << "\tmerged orig valno " << OrigVNI->id << ": " |
| 392 | << *StackInt << '\n'); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 393 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 394 | // We are going to spill SrcVNI immediately after its def, so clear out |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 395 | // any later spills of the same value. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 396 | eliminateRedundantSpills(SrcLI, SrcVNI); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 397 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 398 | MachineBasicBlock *MBB = LIS.getMBBFromIndex(SrcVNI->def); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 399 | MachineBasicBlock::iterator MII; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 400 | if (SrcVNI->isPHIDef()) |
Keith Walker | 7435b28 | 2016-09-16 14:07:29 +0000 | [diff] [blame] | 401 | MII = MBB->SkipPHIsLabelsAndDebug(MBB->begin()); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 402 | else { |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 403 | MachineInstr *DefMI = LIS.getInstructionFromIndex(SrcVNI->def); |
Jakob Stoklund Olesen | 6ee56e6 | 2011-04-30 06:42:21 +0000 | [diff] [blame] | 404 | assert(DefMI && "Defining instruction disappeared"); |
| 405 | MII = DefMI; |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 406 | ++MII; |
| 407 | } |
| 408 | // Insert spill without kill flag immediately after def. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 409 | TII.storeRegToStackSlot(*MBB, MII, SrcReg, false, StackSlot, |
| 410 | MRI.getRegClass(SrcReg), &TRI); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 411 | --MII; // Point to store instruction. |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 412 | LIS.InsertMachineInstrInMaps(*MII); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 413 | LLVM_DEBUG(dbgs() << "\thoisted: " << SrcVNI->def << '\t' << *MII); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 414 | |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 415 | HSpiller.addToMergeableSpills(*MII, StackSlot, Original); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 416 | ++NumSpills; |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 417 | return true; |
| 418 | } |
| 419 | |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 420 | /// eliminateRedundantSpills - SLI:VNI is known to be on the stack. Remove any |
| 421 | /// redundant spills of this value in SLI.reg and sibling copies. |
| 422 | void InlineSpiller::eliminateRedundantSpills(LiveInterval &SLI, VNInfo *VNI) { |
Jakob Stoklund Olesen | 682eed0 | 2011-03-20 05:44:58 +0000 | [diff] [blame] | 423 | assert(VNI && "Missing value"); |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 424 | SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList; |
| 425 | WorkList.push_back(std::make_pair(&SLI, VNI)); |
Jakob Stoklund Olesen | e9c5073 | 2011-03-26 22:16:41 +0000 | [diff] [blame] | 426 | assert(StackInt && "No stack slot assigned yet."); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 427 | |
| 428 | do { |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 429 | LiveInterval *LI; |
Benjamin Kramer | a4f0aad | 2014-03-02 13:30:33 +0000 | [diff] [blame] | 430 | std::tie(LI, VNI) = WorkList.pop_back_val(); |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 431 | unsigned Reg = LI->reg; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 432 | LLVM_DEBUG(dbgs() << "Checking redundant spills for " << VNI->id << '@' |
| 433 | << VNI->def << " in " << *LI << '\n'); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 434 | |
| 435 | // Regs to spill are taken care of. |
| 436 | if (isRegToSpill(Reg)) |
| 437 | continue; |
| 438 | |
| 439 | // Add all of VNI's live range to StackInt. |
Jakob Stoklund Olesen | e9c5073 | 2011-03-26 22:16:41 +0000 | [diff] [blame] | 440 | StackInt->MergeValueInAsValue(*LI, VNI, StackInt->getValNumInfo(0)); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 441 | LLVM_DEBUG(dbgs() << "Merged to stack int: " << *StackInt << '\n'); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 442 | |
| 443 | // Find all spills and copies of VNI. |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 444 | for (MachineRegisterInfo::use_instr_nodbg_iterator |
| 445 | UI = MRI.use_instr_nodbg_begin(Reg), E = MRI.use_instr_nodbg_end(); |
| 446 | UI != E; ) { |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 447 | MachineInstr &MI = *UI++; |
| 448 | if (!MI.isCopy() && !MI.mayStore()) |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 449 | continue; |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 450 | SlotIndex Idx = LIS.getInstructionIndex(MI); |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 451 | if (LI->getVNInfoAt(Idx) != VNI) |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 452 | continue; |
| 453 | |
| 454 | // Follow sibling copies down the dominator tree. |
| 455 | if (unsigned DstReg = isFullCopyOf(MI, Reg)) { |
| 456 | if (isSibling(DstReg)) { |
| 457 | LiveInterval &DstLI = LIS.getInterval(DstReg); |
Jakob Stoklund Olesen | 2debd48 | 2011-11-13 20:45:27 +0000 | [diff] [blame] | 458 | VNInfo *DstVNI = DstLI.getVNInfoAt(Idx.getRegSlot()); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 459 | assert(DstVNI && "Missing defined value"); |
Jakob Stoklund Olesen | 2debd48 | 2011-11-13 20:45:27 +0000 | [diff] [blame] | 460 | assert(DstVNI->def == Idx.getRegSlot() && "Wrong copy def slot"); |
Jakob Stoklund Olesen | 01a46c8 | 2011-03-20 05:44:55 +0000 | [diff] [blame] | 461 | WorkList.push_back(std::make_pair(&DstLI, DstVNI)); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 462 | } |
| 463 | continue; |
| 464 | } |
| 465 | |
| 466 | // Erase spills. |
| 467 | int FI; |
| 468 | if (Reg == TII.isStoreToStackSlot(MI, FI) && FI == StackSlot) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 469 | LLVM_DEBUG(dbgs() << "Redundant spill " << Idx << '\t' << MI); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 470 | // eliminateDeadDefs won't normally remove stores, so switch opcode. |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 471 | MI.setDesc(TII.get(TargetOpcode::KILL)); |
| 472 | DeadDefs.push_back(&MI); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 473 | ++NumSpillsRemoved; |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 474 | if (HSpiller.rmFromMergeableSpills(MI, StackSlot)) |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 475 | --NumSpills; |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 476 | } |
| 477 | } |
| 478 | } while (!WorkList.empty()); |
| 479 | } |
| 480 | |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 481 | //===----------------------------------------------------------------------===// |
| 482 | // Rematerialization |
| 483 | //===----------------------------------------------------------------------===// |
| 484 | |
| 485 | /// markValueUsed - Remember that VNI failed to rematerialize, so its defining |
| 486 | /// instruction cannot be eliminated. See through snippet copies |
| 487 | void InlineSpiller::markValueUsed(LiveInterval *LI, VNInfo *VNI) { |
| 488 | SmallVector<std::pair<LiveInterval*, VNInfo*>, 8> WorkList; |
| 489 | WorkList.push_back(std::make_pair(LI, VNI)); |
| 490 | do { |
Benjamin Kramer | a4f0aad | 2014-03-02 13:30:33 +0000 | [diff] [blame] | 491 | std::tie(LI, VNI) = WorkList.pop_back_val(); |
David Blaikie | 5401ba7 | 2014-11-19 07:49:26 +0000 | [diff] [blame] | 492 | if (!UsedValues.insert(VNI).second) |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 493 | continue; |
| 494 | |
| 495 | if (VNI->isPHIDef()) { |
| 496 | MachineBasicBlock *MBB = LIS.getMBBFromIndex(VNI->def); |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 497 | for (MachineBasicBlock *P : MBB->predecessors()) { |
| 498 | VNInfo *PVNI = LI->getVNInfoBefore(LIS.getMBBEndIdx(P)); |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 499 | if (PVNI) |
| 500 | WorkList.push_back(std::make_pair(LI, PVNI)); |
| 501 | } |
| 502 | continue; |
| 503 | } |
| 504 | |
| 505 | // Follow snippet copies. |
| 506 | MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def); |
| 507 | if (!SnippetCopies.count(MI)) |
| 508 | continue; |
| 509 | LiveInterval &SnipLI = LIS.getInterval(MI->getOperand(1).getReg()); |
| 510 | assert(isRegToSpill(SnipLI.reg) && "Unexpected register in copy"); |
Jakob Stoklund Olesen | 2debd48 | 2011-11-13 20:45:27 +0000 | [diff] [blame] | 511 | VNInfo *SnipVNI = SnipLI.getVNInfoAt(VNI->def.getRegSlot(true)); |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 512 | assert(SnipVNI && "Snippet undefined before copy"); |
| 513 | WorkList.push_back(std::make_pair(&SnipLI, SnipVNI)); |
| 514 | } while (!WorkList.empty()); |
| 515 | } |
| 516 | |
| 517 | /// reMaterializeFor - Attempt to rematerialize before MI instead of reloading. |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 518 | bool InlineSpiller::reMaterializeFor(LiveInterval &VirtReg, MachineInstr &MI) { |
Patrik Hagglund | 7948290 | 2014-09-01 11:04:07 +0000 | [diff] [blame] | 519 | // Analyze instruction |
| 520 | SmallVector<std::pair<MachineInstr *, unsigned>, 8> Ops; |
| 521 | MIBundleOperands::VirtRegInfo RI = |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 522 | MIBundleOperands(MI).analyzeVirtReg(VirtReg.reg, &Ops); |
Patrik Hagglund | 7948290 | 2014-09-01 11:04:07 +0000 | [diff] [blame] | 523 | |
| 524 | if (!RI.Reads) |
| 525 | return false; |
| 526 | |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 527 | SlotIndex UseIdx = LIS.getInstructionIndex(MI).getRegSlot(true); |
Jakob Stoklund Olesen | 7941350 | 2011-07-18 05:31:59 +0000 | [diff] [blame] | 528 | VNInfo *ParentVNI = VirtReg.getVNInfoAt(UseIdx.getBaseIndex()); |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 529 | |
| 530 | if (!ParentVNI) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 531 | LLVM_DEBUG(dbgs() << "\tadding <undef> flags: "); |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 532 | for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) { |
| 533 | MachineOperand &MO = MI.getOperand(i); |
Jakob Stoklund Olesen | cf610d0 | 2011-03-29 17:47:02 +0000 | [diff] [blame] | 534 | if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg) |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 535 | MO.setIsUndef(); |
| 536 | } |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 537 | LLVM_DEBUG(dbgs() << UseIdx << '\t' << MI); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 538 | return true; |
| 539 | } |
Jakob Stoklund Olesen | 080c316 | 2010-10-20 22:00:51 +0000 | [diff] [blame] | 540 | |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 541 | if (SnippetCopies.count(&MI)) |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 542 | return false; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 543 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 544 | LiveInterval &OrigLI = LIS.getInterval(Original); |
| 545 | VNInfo *OrigVNI = OrigLI.getVNInfoAt(UseIdx); |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 546 | LiveRangeEdit::Remat RM(ParentVNI); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 547 | RM.OrigMI = LIS.getInstructionFromIndex(OrigVNI->def); |
| 548 | |
| 549 | if (!Edit->canRematerializeAt(RM, OrigVNI, UseIdx, false)) { |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 550 | markValueUsed(&VirtReg, ParentVNI); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 551 | LLVM_DEBUG(dbgs() << "\tcannot remat for " << UseIdx << '\t' << MI); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 552 | return false; |
| 553 | } |
| 554 | |
Jakob Stoklund Olesen | cf610d0 | 2011-03-29 17:47:02 +0000 | [diff] [blame] | 555 | // If the instruction also writes VirtReg.reg, it had better not require the |
| 556 | // same register for uses and defs. |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 557 | if (RI.Tied) { |
| 558 | markValueUsed(&VirtReg, ParentVNI); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 559 | LLVM_DEBUG(dbgs() << "\tcannot remat tied reg: " << UseIdx << '\t' << MI); |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 560 | return false; |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 561 | } |
| 562 | |
Jakob Stoklund Olesen | 83d1ba5 | 2010-12-18 03:04:14 +0000 | [diff] [blame] | 563 | // Before rematerializing into a register for a single instruction, try to |
| 564 | // fold a load into the instruction. That avoids allocating a new register. |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 565 | if (RM.OrigMI->canFoldAsLoad() && |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 566 | foldMemoryOperand(Ops, RM.OrigMI)) { |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 567 | Edit->markRematerialized(RM.ParentVNI); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 568 | ++NumFoldedLoads; |
Jakob Stoklund Olesen | 83d1ba5 | 2010-12-18 03:04:14 +0000 | [diff] [blame] | 569 | return true; |
| 570 | } |
| 571 | |
Wolfgang Pieb | 659db1f | 2016-08-16 17:12:50 +0000 | [diff] [blame] | 572 | // Allocate a new register for the remat. |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 573 | unsigned NewVReg = Edit->createFrom(Original); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 574 | |
| 575 | // Finally we can rematerialize OrigMI before MI. |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 576 | SlotIndex DefIdx = |
| 577 | Edit->rematerializeAt(*MI.getParent(), MI, NewVReg, RM, TRI); |
Wolfgang Pieb | 659db1f | 2016-08-16 17:12:50 +0000 | [diff] [blame] | 578 | |
| 579 | // We take the DebugLoc from MI, since OrigMI may be attributed to a |
Junmo Park | c236d01 | 2017-02-25 01:50:45 +0000 | [diff] [blame] | 580 | // different source location. |
Wolfgang Pieb | 659db1f | 2016-08-16 17:12:50 +0000 | [diff] [blame] | 581 | auto *NewMI = LIS.getInstructionFromIndex(DefIdx); |
| 582 | NewMI->setDebugLoc(MI.getDebugLoc()); |
| 583 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 584 | (void)DefIdx; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 585 | LLVM_DEBUG(dbgs() << "\tremat: " << DefIdx << '\t' |
| 586 | << *LIS.getInstructionFromIndex(DefIdx)); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 587 | |
| 588 | // Replace operands |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 589 | for (const auto &OpPair : Ops) { |
| 590 | MachineOperand &MO = OpPair.first->getOperand(OpPair.second); |
Jakob Stoklund Olesen | cf610d0 | 2011-03-29 17:47:02 +0000 | [diff] [blame] | 591 | if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg) { |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 592 | MO.setReg(NewVReg); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 593 | MO.setIsKill(); |
| 594 | } |
| 595 | } |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 596 | LLVM_DEBUG(dbgs() << "\t " << UseIdx << '\t' << MI << '\n'); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 597 | |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 598 | ++NumRemats; |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 599 | return true; |
| 600 | } |
| 601 | |
Jakob Stoklund Olesen | a17768f | 2010-10-14 23:49:52 +0000 | [diff] [blame] | 602 | /// reMaterializeAll - Try to rematerialize as many uses as possible, |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 603 | /// and trim the live ranges after. |
| 604 | void InlineSpiller::reMaterializeAll() { |
Pete Cooper | 8a06af9 | 2012-04-02 22:22:53 +0000 | [diff] [blame] | 605 | if (!Edit->anyRematerializable(AA)) |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 606 | return; |
| 607 | |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 608 | UsedValues.clear(); |
Jakob Stoklund Olesen | 080c316 | 2010-10-20 22:00:51 +0000 | [diff] [blame] | 609 | |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 610 | // Try to remat before all uses of snippets. |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 611 | bool anyRemat = false; |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 612 | for (unsigned Reg : RegsToSpill) { |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 613 | LiveInterval &LI = LIS.getInterval(Reg); |
Patrik Hagglund | 7948290 | 2014-09-01 11:04:07 +0000 | [diff] [blame] | 614 | for (MachineRegisterInfo::reg_bundle_iterator |
| 615 | RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end(); |
| 616 | RegI != E; ) { |
Duncan P. N. Exon Smith | cc3610d | 2016-02-27 20:23:14 +0000 | [diff] [blame] | 617 | MachineInstr &MI = *RegI++; |
Patrik Hagglund | 7948290 | 2014-09-01 11:04:07 +0000 | [diff] [blame] | 618 | |
| 619 | // Debug values are not allowed to affect codegen. |
Shiva Chen | 1187b9b | 2018-05-16 02:57:26 +0000 | [diff] [blame] | 620 | if (MI.isDebugValue()) |
Patrik Hagglund | 7948290 | 2014-09-01 11:04:07 +0000 | [diff] [blame] | 621 | continue; |
| 622 | |
Shiva Chen | 1187b9b | 2018-05-16 02:57:26 +0000 | [diff] [blame] | 623 | assert(!MI.isDebugInstr() && "Did not expect to find a use in debug " |
| 624 | "instruction that isn't a DBG_VALUE"); |
| 625 | |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 626 | anyRemat |= reMaterializeFor(LI, MI); |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 627 | } |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 628 | } |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 629 | if (!anyRemat) |
| 630 | return; |
| 631 | |
| 632 | // Remove any values that were completely rematted. |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 633 | for (unsigned Reg : RegsToSpill) { |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 634 | LiveInterval &LI = LIS.getInterval(Reg); |
| 635 | for (LiveInterval::vni_iterator I = LI.vni_begin(), E = LI.vni_end(); |
| 636 | I != E; ++I) { |
| 637 | VNInfo *VNI = *I; |
Jakob Stoklund Olesen | c1d22d8 | 2011-03-29 17:47:00 +0000 | [diff] [blame] | 638 | if (VNI->isUnused() || VNI->isPHIDef() || UsedValues.count(VNI)) |
Jakob Stoklund Olesen | 3b9c7eb | 2010-07-02 19:54:40 +0000 | [diff] [blame] | 639 | continue; |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 640 | MachineInstr *MI = LIS.getInstructionFromIndex(VNI->def); |
| 641 | MI->addRegisterDead(Reg, &TRI); |
| 642 | if (!MI->allDefsAreDead()) |
| 643 | continue; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 644 | LLVM_DEBUG(dbgs() << "All defs dead: " << *MI); |
Jakob Stoklund Olesen | 2ef661b | 2011-03-29 03:12:02 +0000 | [diff] [blame] | 645 | DeadDefs.push_back(MI); |
Jakob Stoklund Olesen | 3b9c7eb | 2010-07-02 19:54:40 +0000 | [diff] [blame] | 646 | } |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 647 | } |
Jakob Stoklund Olesen | c1d22d8 | 2011-03-29 17:47:00 +0000 | [diff] [blame] | 648 | |
| 649 | // Eliminate dead code after remat. Note that some snippet copies may be |
| 650 | // deleted here. |
| 651 | if (DeadDefs.empty()) |
| 652 | return; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 653 | LLVM_DEBUG(dbgs() << "Remat created " << DeadDefs.size() << " dead defs.\n"); |
Wei Mi | 4eae278 | 2016-07-08 21:08:09 +0000 | [diff] [blame] | 654 | Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA); |
Jakob Stoklund Olesen | c1d22d8 | 2011-03-29 17:47:00 +0000 | [diff] [blame] | 655 | |
Wei Mi | f2ca031 | 2016-02-05 18:14:24 +0000 | [diff] [blame] | 656 | // LiveRangeEdit::eliminateDeadDef is used to remove dead define instructions |
| 657 | // after rematerialization. To remove a VNI for a vreg from its LiveInterval, |
| 658 | // LiveIntervals::removeVRegDefAt is used. However, after non-PHI VNIs are all |
| 659 | // removed, PHI VNI are still left in the LiveInterval. |
| 660 | // So to get rid of unused reg, we need to check whether it has non-dbg |
| 661 | // reference instead of whether it has non-empty interval. |
Benjamin Kramer | e210df2 | 2013-05-05 11:29:14 +0000 | [diff] [blame] | 662 | unsigned ResultPos = 0; |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 663 | for (unsigned Reg : RegsToSpill) { |
Wei Mi | f2ca031 | 2016-02-05 18:14:24 +0000 | [diff] [blame] | 664 | if (MRI.reg_nodbg_empty(Reg)) { |
Benjamin Kramer | e210df2 | 2013-05-05 11:29:14 +0000 | [diff] [blame] | 665 | Edit->eraseVirtReg(Reg); |
Jakob Stoklund Olesen | c1d22d8 | 2011-03-29 17:47:00 +0000 | [diff] [blame] | 666 | continue; |
| 667 | } |
Matt Arsenault | f3c728a | 2017-07-22 00:24:01 +0000 | [diff] [blame] | 668 | |
Matt Arsenault | 0771376 | 2017-07-24 18:07:55 +0000 | [diff] [blame] | 669 | assert(LIS.hasInterval(Reg) && |
| 670 | (!LIS.getInterval(Reg).empty() || !MRI.reg_nodbg_empty(Reg)) && |
| 671 | "Empty and not used live-range?!"); |
| 672 | |
Benjamin Kramer | e210df2 | 2013-05-05 11:29:14 +0000 | [diff] [blame] | 673 | RegsToSpill[ResultPos++] = Reg; |
Jakob Stoklund Olesen | c1d22d8 | 2011-03-29 17:47:00 +0000 | [diff] [blame] | 674 | } |
Benjamin Kramer | e210df2 | 2013-05-05 11:29:14 +0000 | [diff] [blame] | 675 | RegsToSpill.erase(RegsToSpill.begin() + ResultPos, RegsToSpill.end()); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 676 | LLVM_DEBUG(dbgs() << RegsToSpill.size() |
| 677 | << " registers to spill after remat.\n"); |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 678 | } |
| 679 | |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 680 | //===----------------------------------------------------------------------===// |
| 681 | // Spilling |
| 682 | //===----------------------------------------------------------------------===// |
| 683 | |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 684 | /// If MI is a load or store of StackSlot, it can be removed. |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 685 | bool InlineSpiller::coalesceStackAccess(MachineInstr *MI, unsigned Reg) { |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 686 | int FI = 0; |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 687 | unsigned InstrReg = TII.isLoadFromStackSlot(*MI, FI); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 688 | bool IsLoad = InstrReg; |
| 689 | if (!IsLoad) |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 690 | InstrReg = TII.isStoreToStackSlot(*MI, FI); |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 691 | |
| 692 | // We have a stack access. Is it the right register and slot? |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 693 | if (InstrReg != Reg || FI != StackSlot) |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 694 | return false; |
| 695 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 696 | if (!IsLoad) |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 697 | HSpiller.rmFromMergeableSpills(*MI, StackSlot); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 698 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 699 | LLVM_DEBUG(dbgs() << "Coalescing stack access: " << *MI); |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 700 | LIS.RemoveMachineInstrFromMaps(*MI); |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 701 | MI->eraseFromParent(); |
Jakob Stoklund Olesen | 79c40a0 | 2011-09-15 17:54:28 +0000 | [diff] [blame] | 702 | |
| 703 | if (IsLoad) { |
| 704 | ++NumReloadsRemoved; |
| 705 | --NumReloads; |
| 706 | } else { |
| 707 | ++NumSpillsRemoved; |
| 708 | --NumSpills; |
| 709 | } |
| 710 | |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 711 | return true; |
| 712 | } |
| 713 | |
Aaron Ballman | 1d03d38 | 2017-10-15 14:32:27 +0000 | [diff] [blame] | 714 | #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) |
Junmo Park | c0fa0b7 | 2017-03-28 04:14:25 +0000 | [diff] [blame] | 715 | LLVM_DUMP_METHOD |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 716 | // Dump the range of instructions from B to E with their slot indexes. |
| 717 | static void dumpMachineInstrRangeWithSlotIndex(MachineBasicBlock::iterator B, |
| 718 | MachineBasicBlock::iterator E, |
| 719 | LiveIntervals const &LIS, |
| 720 | const char *const header, |
| 721 | unsigned VReg =0) { |
| 722 | char NextLine = '\n'; |
| 723 | char SlotIndent = '\t'; |
| 724 | |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 725 | if (std::next(B) == E) { |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 726 | NextLine = ' '; |
| 727 | SlotIndent = ' '; |
| 728 | } |
| 729 | |
| 730 | dbgs() << '\t' << header << ": " << NextLine; |
| 731 | |
| 732 | for (MachineBasicBlock::iterator I = B; I != E; ++I) { |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 733 | SlotIndex Idx = LIS.getInstructionIndex(*I).getRegSlot(); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 734 | |
| 735 | // If a register was passed in and this instruction has it as a |
| 736 | // destination that is marked as an early clobber, print the |
| 737 | // early-clobber slot index. |
| 738 | if (VReg) { |
| 739 | MachineOperand *MO = I->findRegisterDefOperand(VReg); |
| 740 | if (MO && MO->isEarlyClobber()) |
| 741 | Idx = Idx.getRegSlot(true); |
| 742 | } |
| 743 | |
| 744 | dbgs() << SlotIndent << Idx << '\t' << *I; |
| 745 | } |
| 746 | } |
| 747 | #endif |
| 748 | |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 749 | /// foldMemoryOperand - Try folding stack slot references in Ops into their |
| 750 | /// instructions. |
| 751 | /// |
| 752 | /// @param Ops Operand indices from analyzeVirtReg(). |
Jakob Stoklund Olesen | 83d1ba5 | 2010-12-18 03:04:14 +0000 | [diff] [blame] | 753 | /// @param LoadMI Load instruction to use instead of stack slot when non-null. |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 754 | /// @return True on success. |
| 755 | bool InlineSpiller:: |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 756 | foldMemoryOperand(ArrayRef<std::pair<MachineInstr *, unsigned>> Ops, |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 757 | MachineInstr *LoadMI) { |
| 758 | if (Ops.empty()) |
| 759 | return false; |
| 760 | // Don't attempt folding in bundles. |
| 761 | MachineInstr *MI = Ops.front().first; |
| 762 | if (Ops.back().first != MI || MI->isBundled()) |
| 763 | return false; |
| 764 | |
Jakob Stoklund Olesen | d205f7a | 2011-09-15 18:22:52 +0000 | [diff] [blame] | 765 | bool WasCopy = MI->isCopy(); |
Jakob Stoklund Olesen | 17afb06 | 2011-11-10 00:17:03 +0000 | [diff] [blame] | 766 | unsigned ImpReg = 0; |
| 767 | |
Michael Kuperstein | 4f54847 | 2016-11-23 18:33:49 +0000 | [diff] [blame] | 768 | // Spill subregs if the target allows it. |
| 769 | // We always want to spill subregs for stackmap/patchpoint pseudos. |
| 770 | bool SpillSubRegs = TII.isSubregFoldable() || |
| 771 | MI->getOpcode() == TargetOpcode::STATEPOINT || |
| 772 | MI->getOpcode() == TargetOpcode::PATCHPOINT || |
| 773 | MI->getOpcode() == TargetOpcode::STACKMAP; |
Andrew Trick | bb756ca | 2013-11-17 01:36:23 +0000 | [diff] [blame] | 774 | |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 775 | // TargetInstrInfo::foldMemoryOperand only expects explicit, non-tied |
| 776 | // operands. |
| 777 | SmallVector<unsigned, 8> FoldOps; |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 778 | for (const auto &OpPair : Ops) { |
| 779 | unsigned Idx = OpPair.second; |
| 780 | assert(MI == OpPair.first && "Instruction conflict during operand folding"); |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 781 | MachineOperand &MO = MI->getOperand(Idx); |
Jakob Stoklund Olesen | 17afb06 | 2011-11-10 00:17:03 +0000 | [diff] [blame] | 782 | if (MO.isImplicit()) { |
| 783 | ImpReg = MO.getReg(); |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 784 | continue; |
Jakob Stoklund Olesen | 17afb06 | 2011-11-10 00:17:03 +0000 | [diff] [blame] | 785 | } |
Michael Kuperstein | 4f54847 | 2016-11-23 18:33:49 +0000 | [diff] [blame] | 786 | |
Andrew Trick | bb756ca | 2013-11-17 01:36:23 +0000 | [diff] [blame] | 787 | if (!SpillSubRegs && MO.getSubReg()) |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 788 | return false; |
Jakob Stoklund Olesen | 7b1f498 | 2011-02-08 19:33:55 +0000 | [diff] [blame] | 789 | // We cannot fold a load instruction into a def. |
| 790 | if (LoadMI && MO.isDef()) |
| 791 | return false; |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 792 | // Tied use operands should not be passed to foldMemoryOperand. |
| 793 | if (!MI->isRegTiedToDefOperand(Idx)) |
| 794 | FoldOps.push_back(Idx); |
| 795 | } |
| 796 | |
Quentin Colombet | aff0cae | 2016-12-08 00:06:51 +0000 | [diff] [blame] | 797 | // If we only have implicit uses, we won't be able to fold that. |
| 798 | // Moreover, TargetInstrInfo::foldMemoryOperand will assert if we try! |
| 799 | if (FoldOps.empty()) |
| 800 | return false; |
| 801 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 802 | MachineInstrSpan MIS(MI); |
| 803 | |
Jakob Stoklund Olesen | 83d1ba5 | 2010-12-18 03:04:14 +0000 | [diff] [blame] | 804 | MachineInstr *FoldMI = |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 805 | LoadMI ? TII.foldMemoryOperand(*MI, FoldOps, *LoadMI, &LIS) |
| 806 | : TII.foldMemoryOperand(*MI, FoldOps, StackSlot, &LIS); |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 807 | if (!FoldMI) |
| 808 | return false; |
Andrew Trick | c12c880 | 2013-06-21 18:33:26 +0000 | [diff] [blame] | 809 | |
| 810 | // Remove LIS for any dead defs in the original MI not in FoldMI. |
Duncan P. N. Exon Smith | 63ec7f0 | 2016-02-27 17:05:33 +0000 | [diff] [blame] | 811 | for (MIBundleOperands MO(*MI); MO.isValid(); ++MO) { |
Andrew Trick | c12c880 | 2013-06-21 18:33:26 +0000 | [diff] [blame] | 812 | if (!MO->isReg()) |
| 813 | continue; |
| 814 | unsigned Reg = MO->getReg(); |
| 815 | if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg) || |
| 816 | MRI.isReserved(Reg)) { |
| 817 | continue; |
| 818 | } |
Andrew Trick | 9c15f4c | 2014-01-07 07:31:10 +0000 | [diff] [blame] | 819 | // Skip non-Defs, including undef uses and internal reads. |
| 820 | if (MO->isUse()) |
| 821 | continue; |
Andrew Trick | c12c880 | 2013-06-21 18:33:26 +0000 | [diff] [blame] | 822 | MIBundleOperands::PhysRegInfo RI = |
Duncan P. N. Exon Smith | 63ec7f0 | 2016-02-27 17:05:33 +0000 | [diff] [blame] | 823 | MIBundleOperands(*FoldMI).analyzePhysReg(Reg, &TRI); |
Matthias Braun | f43272c | 2015-12-11 19:42:09 +0000 | [diff] [blame] | 824 | if (RI.FullyDefined) |
Andrew Trick | c12c880 | 2013-06-21 18:33:26 +0000 | [diff] [blame] | 825 | continue; |
| 826 | // FoldMI does not define this physreg. Remove the LI segment. |
| 827 | assert(MO->isDead() && "Cannot fold physreg def"); |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 828 | SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot(); |
Matthias Braun | 1458e05 | 2015-01-21 18:50:21 +0000 | [diff] [blame] | 829 | LIS.removePhysRegDefAt(Reg, Idx); |
Andrew Trick | c12c880 | 2013-06-21 18:33:26 +0000 | [diff] [blame] | 830 | } |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 831 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 832 | int FI; |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 833 | if (TII.isStoreToStackSlot(*MI, FI) && |
| 834 | HSpiller.rmFromMergeableSpills(*MI, FI)) |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 835 | --NumSpills; |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 836 | LIS.ReplaceMachineInstrInMaps(*MI, *FoldMI); |
Jakob Stoklund Olesen | e05442d | 2010-07-09 17:29:08 +0000 | [diff] [blame] | 837 | MI->eraseFromParent(); |
Jakob Stoklund Olesen | 17afb06 | 2011-11-10 00:17:03 +0000 | [diff] [blame] | 838 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 839 | // Insert any new instructions other than FoldMI into the LIS maps. |
| 840 | assert(!MIS.empty() && "Unexpected empty span of instructions!"); |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 841 | for (MachineInstr &MI : MIS) |
| 842 | if (&MI != FoldMI) |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 843 | LIS.InsertMachineInstrInMaps(MI); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 844 | |
Jakob Stoklund Olesen | 17afb06 | 2011-11-10 00:17:03 +0000 | [diff] [blame] | 845 | // TII.foldMemoryOperand may have left some implicit operands on the |
| 846 | // instruction. Strip them. |
| 847 | if (ImpReg) |
| 848 | for (unsigned i = FoldMI->getNumOperands(); i; --i) { |
| 849 | MachineOperand &MO = FoldMI->getOperand(i - 1); |
| 850 | if (!MO.isReg() || !MO.isImplicit()) |
| 851 | break; |
| 852 | if (MO.getReg() == ImpReg) |
| 853 | FoldMI->RemoveOperand(i - 1); |
| 854 | } |
| 855 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 856 | LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MIS.end(), LIS, |
| 857 | "folded")); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 858 | |
Jakob Stoklund Olesen | d205f7a | 2011-09-15 18:22:52 +0000 | [diff] [blame] | 859 | if (!WasCopy) |
| 860 | ++NumFolded; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 861 | else if (Ops.front().second == 0) { |
Jakob Stoklund Olesen | d205f7a | 2011-09-15 18:22:52 +0000 | [diff] [blame] | 862 | ++NumSpills; |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 863 | HSpiller.addToMergeableSpills(*FoldMI, StackSlot, Original); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 864 | } else |
Jakob Stoklund Olesen | d205f7a | 2011-09-15 18:22:52 +0000 | [diff] [blame] | 865 | ++NumReloads; |
Jakob Stoklund Olesen | e72a5c5 | 2010-07-01 00:13:04 +0000 | [diff] [blame] | 866 | return true; |
| 867 | } |
| 868 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 869 | void InlineSpiller::insertReload(unsigned NewVReg, |
Jakob Stoklund Olesen | 5d5ef4a | 2011-04-18 20:23:27 +0000 | [diff] [blame] | 870 | SlotIndex Idx, |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 871 | MachineBasicBlock::iterator MI) { |
| 872 | MachineBasicBlock &MBB = *MI->getParent(); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 873 | |
| 874 | MachineInstrSpan MIS(MI); |
| 875 | TII.loadRegFromStackSlot(MBB, MI, NewVReg, StackSlot, |
| 876 | MRI.getRegClass(NewVReg), &TRI); |
| 877 | |
| 878 | LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MI); |
| 879 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 880 | LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(MIS.begin(), MI, LIS, "reload", |
| 881 | NewVReg)); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 882 | ++NumReloads; |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 883 | } |
| 884 | |
Quentin Colombet | de1ece9 | 2017-06-05 23:51:27 +0000 | [diff] [blame] | 885 | /// Check if \p Def fully defines a VReg with an undefined value. |
| 886 | /// If that's the case, that means the value of VReg is actually |
| 887 | /// not relevant. |
| 888 | static bool isFullUndefDef(const MachineInstr &Def) { |
| 889 | if (!Def.isImplicitDef()) |
| 890 | return false; |
| 891 | assert(Def.getNumOperands() == 1 && |
| 892 | "Implicit def with more than one definition"); |
| 893 | // We can say that the VReg defined by Def is undef, only if it is |
| 894 | // fully defined by Def. Otherwise, some of the lanes may not be |
| 895 | // undef and the value of the VReg matters. |
| 896 | return !Def.getOperand(0).getSubReg(); |
| 897 | } |
| 898 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 899 | /// insertSpill - Insert a spill of NewVReg after MI. |
| 900 | void InlineSpiller::insertSpill(unsigned NewVReg, bool isKill, |
| 901 | MachineBasicBlock::iterator MI) { |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 902 | MachineBasicBlock &MBB = *MI->getParent(); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 903 | |
| 904 | MachineInstrSpan MIS(MI); |
Quentin Colombet | e8e2b8a | 2017-06-07 00:22:07 +0000 | [diff] [blame] | 905 | bool IsRealSpill = true; |
| 906 | if (isFullUndefDef(*MI)) { |
Quentin Colombet | de1ece9 | 2017-06-05 23:51:27 +0000 | [diff] [blame] | 907 | // Don't spill undef value. |
| 908 | // Anything works for undef, in particular keeping the memory |
| 909 | // uninitialized is a viable option and it saves code size and |
| 910 | // run time. |
| 911 | BuildMI(MBB, std::next(MI), MI->getDebugLoc(), TII.get(TargetOpcode::KILL)) |
| 912 | .addReg(NewVReg, getKillRegState(isKill)); |
Quentin Colombet | e8e2b8a | 2017-06-07 00:22:07 +0000 | [diff] [blame] | 913 | IsRealSpill = false; |
| 914 | } else |
Quentin Colombet | de1ece9 | 2017-06-05 23:51:27 +0000 | [diff] [blame] | 915 | TII.storeRegToStackSlot(MBB, std::next(MI), NewVReg, isKill, StackSlot, |
| 916 | MRI.getRegClass(NewVReg), &TRI); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 917 | |
Benjamin Kramer | d628f19 | 2014-03-02 12:27:27 +0000 | [diff] [blame] | 918 | LIS.InsertMachineInstrRangeInMaps(std::next(MI), MIS.end()); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 919 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 920 | LLVM_DEBUG(dumpMachineInstrRangeWithSlotIndex(std::next(MI), MIS.end(), LIS, |
| 921 | "spill")); |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 922 | ++NumSpills; |
Quentin Colombet | e8e2b8a | 2017-06-07 00:22:07 +0000 | [diff] [blame] | 923 | if (IsRealSpill) |
| 924 | HSpiller.addToMergeableSpills(*std::next(MI), StackSlot, Original); |
Jakob Stoklund Olesen | 9e55afb | 2010-06-30 23:03:52 +0000 | [diff] [blame] | 925 | } |
| 926 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 927 | /// spillAroundUses - insert spill code around each use of Reg. |
| 928 | void InlineSpiller::spillAroundUses(unsigned Reg) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 929 | LLVM_DEBUG(dbgs() << "spillAroundUses " << printReg(Reg) << '\n'); |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 930 | LiveInterval &OldLI = LIS.getInterval(Reg); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 931 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 932 | // Iterate over instructions using Reg. |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 933 | for (MachineRegisterInfo::reg_bundle_iterator |
| 934 | RegI = MRI.reg_bundle_begin(Reg), E = MRI.reg_bundle_end(); |
| 935 | RegI != E; ) { |
Owen Anderson | b6f478a | 2014-03-14 05:02:18 +0000 | [diff] [blame] | 936 | MachineInstr *MI = &*(RegI++); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 937 | |
Jakob Stoklund Olesen | 3b9c7eb | 2010-07-02 19:54:40 +0000 | [diff] [blame] | 938 | // Debug values are not allowed to affect codegen. |
Shiva Chen | 1187b9b | 2018-05-16 02:57:26 +0000 | [diff] [blame] | 939 | if (MI->isDebugValue()) { |
Jakob Stoklund Olesen | 3b9c7eb | 2010-07-02 19:54:40 +0000 | [diff] [blame] | 940 | // Modify DBG_VALUE now that the value is in a spill slot. |
David Blaikie | 6d9dbd5 | 2013-06-16 20:34:15 +0000 | [diff] [blame] | 941 | MachineBasicBlock *MBB = MI->getParent(); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 942 | LLVM_DEBUG(dbgs() << "Modifying debug info due to spill:\t" << *MI); |
Adrian Prantl | b560ea7 | 2017-04-18 01:21:53 +0000 | [diff] [blame] | 943 | buildDbgValueForSpill(*MBB, MI, *MI, StackSlot); |
| 944 | MBB->erase(MI); |
Jakob Stoklund Olesen | 3b9c7eb | 2010-07-02 19:54:40 +0000 | [diff] [blame] | 945 | continue; |
| 946 | } |
| 947 | |
Shiva Chen | 1187b9b | 2018-05-16 02:57:26 +0000 | [diff] [blame] | 948 | assert(!MI->isDebugInstr() && "Did not expect to find a use in debug " |
| 949 | "instruction that isn't a DBG_VALUE"); |
| 950 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 951 | // Ignore copies to/from snippets. We'll delete them. |
| 952 | if (SnippetCopies.count(MI)) |
| 953 | continue; |
| 954 | |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 955 | // Stack slot accesses may coalesce away. |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 956 | if (coalesceStackAccess(MI, Reg)) |
Jakob Stoklund Olesen | 1a0f91b | 2010-08-04 22:35:11 +0000 | [diff] [blame] | 957 | continue; |
| 958 | |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 959 | // Analyze instruction. |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 960 | SmallVector<std::pair<MachineInstr*, unsigned>, 8> Ops; |
James Molloy | b17cf29 | 2012-09-12 10:03:31 +0000 | [diff] [blame] | 961 | MIBundleOperands::VirtRegInfo RI = |
Duncan P. N. Exon Smith | 63ec7f0 | 2016-02-27 17:05:33 +0000 | [diff] [blame] | 962 | MIBundleOperands(*MI).analyzeVirtReg(Reg, &Ops); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 963 | |
Jakob Stoklund Olesen | 5d5ef4a | 2011-04-18 20:23:27 +0000 | [diff] [blame] | 964 | // Find the slot index where this instruction reads and writes OldLI. |
| 965 | // This is usually the def slot, except for tied early clobbers. |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 966 | SlotIndex Idx = LIS.getInstructionIndex(*MI).getRegSlot(); |
Jakob Stoklund Olesen | 2debd48 | 2011-11-13 20:45:27 +0000 | [diff] [blame] | 967 | if (VNInfo *VNI = OldLI.getVNInfoAt(Idx.getRegSlot(true))) |
Jakob Stoklund Olesen | 5d5ef4a | 2011-04-18 20:23:27 +0000 | [diff] [blame] | 968 | if (SlotIndex::isSameInstr(Idx, VNI->def)) |
| 969 | Idx = VNI->def; |
| 970 | |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 971 | // Check for a sibling copy. |
Duncan P. N. Exon Smith | 567409d | 2016-06-30 00:01:54 +0000 | [diff] [blame] | 972 | unsigned SibReg = isFullCopyOf(*MI, Reg); |
Jakob Stoklund Olesen | 682eed0 | 2011-03-20 05:44:58 +0000 | [diff] [blame] | 973 | if (SibReg && isSibling(SibReg)) { |
Jakob Stoklund Olesen | 443443c | 2011-05-11 18:25:10 +0000 | [diff] [blame] | 974 | // This may actually be a copy between snippets. |
| 975 | if (isRegToSpill(SibReg)) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 976 | LLVM_DEBUG(dbgs() << "Found new snippet copy: " << *MI); |
Jakob Stoklund Olesen | 443443c | 2011-05-11 18:25:10 +0000 | [diff] [blame] | 977 | SnippetCopies.insert(MI); |
| 978 | continue; |
| 979 | } |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 980 | if (RI.Writes) { |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 981 | if (hoistSpillInsideBB(OldLI, *MI)) { |
Jakob Stoklund Olesen | 682eed0 | 2011-03-20 05:44:58 +0000 | [diff] [blame] | 982 | // This COPY is now dead, the value is already in the stack slot. |
| 983 | MI->getOperand(0).setIsDead(); |
| 984 | DeadDefs.push_back(MI); |
| 985 | continue; |
| 986 | } |
| 987 | } else { |
| 988 | // This is a reload for a sib-reg copy. Drop spills downstream. |
Jakob Stoklund Olesen | 682eed0 | 2011-03-20 05:44:58 +0000 | [diff] [blame] | 989 | LiveInterval &SibLI = LIS.getInterval(SibReg); |
| 990 | eliminateRedundantSpills(SibLI, SibLI.getVNInfoAt(Idx)); |
| 991 | // The COPY will fold to a reload below. |
| 992 | } |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 993 | } |
| 994 | |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 995 | // Attempt to fold memory ops. |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 996 | if (foldMemoryOperand(Ops)) |
Jakob Stoklund Olesen | 8de3b1e | 2010-07-02 17:44:57 +0000 | [diff] [blame] | 997 | continue; |
| 998 | |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 999 | // Create a new virtual register for spill/fill. |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1000 | // FIXME: Infer regclass from instruction alone. |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 1001 | unsigned NewVReg = Edit->createFrom(Reg); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1002 | |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 1003 | if (RI.Reads) |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 1004 | insertReload(NewVReg, Idx, MI); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1005 | |
| 1006 | // Rewrite instruction operands. |
| 1007 | bool hasLiveDef = false; |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1008 | for (const auto &OpPair : Ops) { |
| 1009 | MachineOperand &MO = OpPair.first->getOperand(OpPair.second); |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 1010 | MO.setReg(NewVReg); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1011 | if (MO.isUse()) { |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1012 | if (!OpPair.first->isRegTiedToDefOperand(OpPair.second)) |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1013 | MO.setIsKill(); |
| 1014 | } else { |
| 1015 | if (!MO.isDead()) |
| 1016 | hasLiveDef = true; |
| 1017 | } |
| 1018 | } |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1019 | LLVM_DEBUG(dbgs() << "\trewrite: " << Idx << '\t' << *MI << '\n'); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1020 | |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1021 | // FIXME: Use a second vreg if instruction has no tied ops. |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 1022 | if (RI.Writes) |
Jakob Stoklund Olesen | 66c994c | 2012-03-01 01:43:25 +0000 | [diff] [blame] | 1023 | if (hasLiveDef) |
Mark Lacey | e742d68 | 2013-08-14 23:50:16 +0000 | [diff] [blame] | 1024 | insertSpill(NewVReg, true, MI); |
Jakob Stoklund Olesen | 914f2ff | 2010-06-29 23:58:39 +0000 | [diff] [blame] | 1025 | } |
| 1026 | } |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1027 | |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1028 | /// spillAll - Spill all registers remaining after rematerialization. |
| 1029 | void InlineSpiller::spillAll() { |
| 1030 | // Update LiveStacks now that we are committed to spilling. |
| 1031 | if (StackSlot == VirtRegMap::NO_STACK_SLOT) { |
| 1032 | StackSlot = VRM.assignVirt2StackSlot(Original); |
| 1033 | StackInt = &LSS.getOrCreateInterval(StackSlot, MRI.getRegClass(Original)); |
Jakob Stoklund Olesen | 3b1088a | 2012-02-04 05:20:49 +0000 | [diff] [blame] | 1034 | StackInt->getNextValue(SlotIndex(), LSS.getVNInfoAllocator()); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1035 | } else |
| 1036 | StackInt = &LSS.getInterval(StackSlot); |
| 1037 | |
| 1038 | if (Original != Edit->getReg()) |
| 1039 | VRM.assignVirt2StackSlot(Edit->getReg(), StackSlot); |
| 1040 | |
| 1041 | assert(StackInt->getNumValNums() == 1 && "Bad stack interval values"); |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1042 | for (unsigned Reg : RegsToSpill) |
| 1043 | StackInt->MergeSegmentsInAsValue(LIS.getInterval(Reg), |
Matthias Braun | 331de11 | 2013-10-10 21:28:43 +0000 | [diff] [blame] | 1044 | StackInt->getValNumInfo(0)); |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1045 | LLVM_DEBUG(dbgs() << "Merged spilled regs: " << *StackInt << '\n'); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1046 | |
| 1047 | // Spill around uses of all RegsToSpill. |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1048 | for (unsigned Reg : RegsToSpill) |
| 1049 | spillAroundUses(Reg); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1050 | |
| 1051 | // Hoisted spills may cause dead code. |
| 1052 | if (!DeadDefs.empty()) { |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1053 | LLVM_DEBUG(dbgs() << "Eliminating " << DeadDefs.size() << " dead defs\n"); |
Wei Mi | 4eae278 | 2016-07-08 21:08:09 +0000 | [diff] [blame] | 1054 | Edit->eliminateDeadDefs(DeadDefs, RegsToSpill, AA); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1055 | } |
| 1056 | |
| 1057 | // Finally delete the SnippetCopies. |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1058 | for (unsigned Reg : RegsToSpill) { |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 1059 | for (MachineRegisterInfo::reg_instr_iterator |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1060 | RI = MRI.reg_instr_begin(Reg), E = MRI.reg_instr_end(); |
Owen Anderson | 76604af | 2014-03-13 06:02:25 +0000 | [diff] [blame] | 1061 | RI != E; ) { |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 1062 | MachineInstr &MI = *(RI++); |
| 1063 | assert(SnippetCopies.count(&MI) && "Remaining use wasn't a snippet copy"); |
Jakob Stoklund Olesen | 443443c | 2011-05-11 18:25:10 +0000 | [diff] [blame] | 1064 | // FIXME: Do this with a LiveRangeEdit callback. |
Jakob Stoklund Olesen | 443443c | 2011-05-11 18:25:10 +0000 | [diff] [blame] | 1065 | LIS.RemoveMachineInstrFromMaps(MI); |
Duncan P. N. Exon Smith | 42e1835 | 2016-02-27 06:40:41 +0000 | [diff] [blame] | 1066 | MI.eraseFromParent(); |
Jakob Stoklund Olesen | 443443c | 2011-05-11 18:25:10 +0000 | [diff] [blame] | 1067 | } |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1068 | } |
| 1069 | |
| 1070 | // Delete all spilled registers. |
Craig Topper | 2519239 | 2015-12-24 05:20:40 +0000 | [diff] [blame] | 1071 | for (unsigned Reg : RegsToSpill) |
| 1072 | Edit->eraseVirtReg(Reg); |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1073 | } |
| 1074 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1075 | void InlineSpiller::spill(LiveRangeEdit &edit) { |
Jakob Stoklund Olesen | e9bd4ea | 2011-05-05 17:22:53 +0000 | [diff] [blame] | 1076 | ++NumSpilledRanges; |
Jakob Stoklund Olesen | 766faf4 | 2011-03-14 19:56:43 +0000 | [diff] [blame] | 1077 | Edit = &edit; |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1078 | assert(!TargetRegisterInfo::isStackSlot(edit.getReg()) |
| 1079 | && "Trying to spill a stack slot."); |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 1080 | // Share a stack slot among all descendants of Original. |
| 1081 | Original = VRM.getOriginal(edit.getReg()); |
| 1082 | StackSlot = VRM.getStackSlot(Original); |
Craig Topper | 4ba8443 | 2014-04-14 00:51:57 +0000 | [diff] [blame] | 1083 | StackInt = nullptr; |
Jakob Stoklund Olesen | 13ba252 | 2011-03-15 21:13:25 +0000 | [diff] [blame] | 1084 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1085 | LLVM_DEBUG(dbgs() << "Inline spilling " |
| 1086 | << TRI.getRegClassName(MRI.getRegClass(edit.getReg())) |
| 1087 | << ':' << edit.getParent() << "\nFrom original " |
| 1088 | << printReg(Original) << '\n'); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1089 | assert(edit.getParent().isSpillable() && |
| 1090 | "Attempting to spill already spilled value."); |
Jakob Stoklund Olesen | 2a72bfa | 2011-03-18 04:23:06 +0000 | [diff] [blame] | 1091 | assert(DeadDefs.empty() && "Previous spill didn't remove dead defs"); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1092 | |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1093 | collectRegsToSpill(); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1094 | reMaterializeAll(); |
| 1095 | |
| 1096 | // Remat may handle everything. |
Jakob Stoklund Olesen | 6094bd8 | 2011-03-29 21:20:19 +0000 | [diff] [blame] | 1097 | if (!RegsToSpill.empty()) |
| 1098 | spillAll(); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1099 | |
Benjamin Kramer | 4eed756 | 2013-06-17 19:00:36 +0000 | [diff] [blame] | 1100 | Edit->calculateRegClassAndHint(MF, Loops, MBFI); |
Jakob Stoklund Olesen | 10a4332 | 2011-03-12 04:17:20 +0000 | [diff] [blame] | 1101 | } |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1102 | |
| 1103 | /// Optimizations after all the reg selections and spills are done. |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 1104 | void InlineSpiller::postOptimization() { HSpiller.hoistAllSpills(); } |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1105 | |
| 1106 | /// When a spill is inserted, add the spill to MergeableSpills map. |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1107 | void HoistSpillHelper::addToMergeableSpills(MachineInstr &Spill, int StackSlot, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1108 | unsigned Original) { |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1109 | BumpPtrAllocator &Allocator = LIS.getVNInfoAllocator(); |
| 1110 | LiveInterval &OrigLI = LIS.getInterval(Original); |
| 1111 | // save a copy of LiveInterval in StackSlotToOrigLI because the original |
| 1112 | // LiveInterval may be cleared after all its references are spilled. |
| 1113 | if (StackSlotToOrigLI.find(StackSlot) == StackSlotToOrigLI.end()) { |
| 1114 | auto LI = llvm::make_unique<LiveInterval>(OrigLI.reg, OrigLI.weight); |
| 1115 | LI->assign(OrigLI, Allocator); |
| 1116 | StackSlotToOrigLI[StackSlot] = std::move(LI); |
| 1117 | } |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1118 | SlotIndex Idx = LIS.getInstructionIndex(Spill); |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1119 | VNInfo *OrigVNI = StackSlotToOrigLI[StackSlot]->getVNInfoAt(Idx.getRegSlot()); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1120 | std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI); |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1121 | MergeableSpills[MIdx].insert(&Spill); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1122 | } |
| 1123 | |
| 1124 | /// When a spill is removed, remove the spill from MergeableSpills map. |
| 1125 | /// Return true if the spill is removed successfully. |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1126 | bool HoistSpillHelper::rmFromMergeableSpills(MachineInstr &Spill, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1127 | int StackSlot) { |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1128 | auto It = StackSlotToOrigLI.find(StackSlot); |
| 1129 | if (It == StackSlotToOrigLI.end()) |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1130 | return false; |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1131 | SlotIndex Idx = LIS.getInstructionIndex(Spill); |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1132 | VNInfo *OrigVNI = It->second->getVNInfoAt(Idx.getRegSlot()); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1133 | std::pair<int, VNInfo *> MIdx = std::make_pair(StackSlot, OrigVNI); |
Duncan P. N. Exon Smith | 6feb5c9 | 2016-06-30 23:28:15 +0000 | [diff] [blame] | 1134 | return MergeableSpills[MIdx].erase(&Spill); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1135 | } |
| 1136 | |
| 1137 | /// Check BB to see if it is a possible target BB to place a hoisted spill, |
| 1138 | /// i.e., there should be a living sibling of OrigReg at the insert point. |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1139 | bool HoistSpillHelper::isSpillCandBB(LiveInterval &OrigLI, VNInfo &OrigVNI, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1140 | MachineBasicBlock &BB, unsigned &LiveReg) { |
| 1141 | SlotIndex Idx; |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1142 | unsigned OrigReg = OrigLI.reg; |
Wei Mi | 14a29ca | 2016-05-23 19:39:19 +0000 | [diff] [blame] | 1143 | MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, BB); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1144 | if (MI != BB.end()) |
| 1145 | Idx = LIS.getInstructionIndex(*MI); |
| 1146 | else |
| 1147 | Idx = LIS.getMBBEndIdx(&BB).getPrevSlot(); |
| 1148 | SmallSetVector<unsigned, 16> &Siblings = Virt2SiblingsMap[OrigReg]; |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1149 | assert(OrigLI.getVNInfoAt(Idx) == &OrigVNI && "Unexpected VNI"); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1150 | |
| 1151 | for (auto const SibReg : Siblings) { |
| 1152 | LiveInterval &LI = LIS.getInterval(SibReg); |
| 1153 | VNInfo *VNI = LI.getVNInfoAt(Idx); |
| 1154 | if (VNI) { |
| 1155 | LiveReg = SibReg; |
| 1156 | return true; |
| 1157 | } |
| 1158 | } |
| 1159 | return false; |
| 1160 | } |
| 1161 | |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1162 | /// Remove redundant spills in the same BB. Save those redundant spills in |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1163 | /// SpillsToRm, and save the spill to keep and its BB in SpillBBToSpill map. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1164 | void HoistSpillHelper::rmRedundantSpills( |
| 1165 | SmallPtrSet<MachineInstr *, 16> &Spills, |
| 1166 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 1167 | DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) { |
| 1168 | // For each spill saw, check SpillBBToSpill[] and see if its BB already has |
| 1169 | // another spill inside. If a BB contains more than one spill, only keep the |
| 1170 | // earlier spill with smaller SlotIndex. |
| 1171 | for (const auto CurrentSpill : Spills) { |
| 1172 | MachineBasicBlock *Block = CurrentSpill->getParent(); |
Bjorn Pettersson | cd91cb1 | 2017-01-04 09:41:56 +0000 | [diff] [blame] | 1173 | MachineDomTreeNode *Node = MDT.getBase().getNode(Block); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1174 | MachineInstr *PrevSpill = SpillBBToSpill[Node]; |
| 1175 | if (PrevSpill) { |
| 1176 | SlotIndex PIdx = LIS.getInstructionIndex(*PrevSpill); |
| 1177 | SlotIndex CIdx = LIS.getInstructionIndex(*CurrentSpill); |
| 1178 | MachineInstr *SpillToRm = (CIdx > PIdx) ? CurrentSpill : PrevSpill; |
| 1179 | MachineInstr *SpillToKeep = (CIdx > PIdx) ? PrevSpill : CurrentSpill; |
| 1180 | SpillsToRm.push_back(SpillToRm); |
Bjorn Pettersson | cd91cb1 | 2017-01-04 09:41:56 +0000 | [diff] [blame] | 1181 | SpillBBToSpill[MDT.getBase().getNode(Block)] = SpillToKeep; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1182 | } else { |
Bjorn Pettersson | cd91cb1 | 2017-01-04 09:41:56 +0000 | [diff] [blame] | 1183 | SpillBBToSpill[MDT.getBase().getNode(Block)] = CurrentSpill; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1184 | } |
| 1185 | } |
| 1186 | for (const auto SpillToRm : SpillsToRm) |
| 1187 | Spills.erase(SpillToRm); |
| 1188 | } |
| 1189 | |
| 1190 | /// Starting from \p Root find a top-down traversal order of the dominator |
| 1191 | /// tree to visit all basic blocks containing the elements of \p Spills. |
| 1192 | /// Redundant spills will be found and put into \p SpillsToRm at the same |
| 1193 | /// time. \p SpillBBToSpill will be populated as part of the process and |
| 1194 | /// maps a basic block to the first store occurring in the basic block. |
| 1195 | /// \post SpillsToRm.union(Spills\@post) == Spills\@pre |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1196 | void HoistSpillHelper::getVisitOrders( |
| 1197 | MachineBasicBlock *Root, SmallPtrSet<MachineInstr *, 16> &Spills, |
| 1198 | SmallVectorImpl<MachineDomTreeNode *> &Orders, |
| 1199 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 1200 | DenseMap<MachineDomTreeNode *, unsigned> &SpillsToKeep, |
| 1201 | DenseMap<MachineDomTreeNode *, MachineInstr *> &SpillBBToSpill) { |
| 1202 | // The set contains all the possible BB nodes to which we may hoist |
| 1203 | // original spills. |
| 1204 | SmallPtrSet<MachineDomTreeNode *, 8> WorkSet; |
| 1205 | // Save the BB nodes on the path from the first BB node containing |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1206 | // non-redundant spill to the Root node. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1207 | SmallPtrSet<MachineDomTreeNode *, 8> NodesOnPath; |
| 1208 | // All the spills to be hoisted must originate from a single def instruction |
| 1209 | // to the OrigReg. It means the def instruction should dominate all the spills |
| 1210 | // to be hoisted. We choose the BB where the def instruction is located as |
| 1211 | // the Root. |
| 1212 | MachineDomTreeNode *RootIDomNode = MDT[Root]->getIDom(); |
| 1213 | // For every node on the dominator tree with spill, walk up on the dominator |
| 1214 | // tree towards the Root node until it is reached. If there is other node |
| 1215 | // containing spill in the middle of the path, the previous spill saw will |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1216 | // be redundant and the node containing it will be removed. All the nodes on |
| 1217 | // the path starting from the first node with non-redundant spill to the Root |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1218 | // node will be added to the WorkSet, which will contain all the possible |
| 1219 | // locations where spills may be hoisted to after the loop below is done. |
| 1220 | for (const auto Spill : Spills) { |
| 1221 | MachineBasicBlock *Block = Spill->getParent(); |
| 1222 | MachineDomTreeNode *Node = MDT[Block]; |
| 1223 | MachineInstr *SpillToRm = nullptr; |
| 1224 | while (Node != RootIDomNode) { |
| 1225 | // If Node dominates Block, and it already contains a spill, the spill in |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1226 | // Block will be redundant. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1227 | if (Node != MDT[Block] && SpillBBToSpill[Node]) { |
| 1228 | SpillToRm = SpillBBToSpill[MDT[Block]]; |
| 1229 | break; |
| 1230 | /// If we see the Node already in WorkSet, the path from the Node to |
| 1231 | /// the Root node must already be traversed by another spill. |
| 1232 | /// Then no need to repeat. |
| 1233 | } else if (WorkSet.count(Node)) { |
| 1234 | break; |
| 1235 | } else { |
| 1236 | NodesOnPath.insert(Node); |
| 1237 | } |
| 1238 | Node = Node->getIDom(); |
| 1239 | } |
| 1240 | if (SpillToRm) { |
| 1241 | SpillsToRm.push_back(SpillToRm); |
| 1242 | } else { |
| 1243 | // Add a BB containing the original spills to SpillsToKeep -- i.e., |
| 1244 | // set the initial status before hoisting start. The value of BBs |
| 1245 | // containing original spills is set to 0, in order to descriminate |
| 1246 | // with BBs containing hoisted spills which will be inserted to |
| 1247 | // SpillsToKeep later during hoisting. |
| 1248 | SpillsToKeep[MDT[Block]] = 0; |
| 1249 | WorkSet.insert(NodesOnPath.begin(), NodesOnPath.end()); |
| 1250 | } |
| 1251 | NodesOnPath.clear(); |
| 1252 | } |
| 1253 | |
| 1254 | // Sort the nodes in WorkSet in top-down order and save the nodes |
| 1255 | // in Orders. Orders will be used for hoisting in runHoistSpills. |
| 1256 | unsigned idx = 0; |
Bjorn Pettersson | cd91cb1 | 2017-01-04 09:41:56 +0000 | [diff] [blame] | 1257 | Orders.push_back(MDT.getBase().getNode(Root)); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1258 | do { |
| 1259 | MachineDomTreeNode *Node = Orders[idx++]; |
| 1260 | const std::vector<MachineDomTreeNode *> &Children = Node->getChildren(); |
| 1261 | unsigned NumChildren = Children.size(); |
| 1262 | for (unsigned i = 0; i != NumChildren; ++i) { |
| 1263 | MachineDomTreeNode *Child = Children[i]; |
| 1264 | if (WorkSet.count(Child)) |
| 1265 | Orders.push_back(Child); |
| 1266 | } |
| 1267 | } while (idx != Orders.size()); |
| 1268 | assert(Orders.size() == WorkSet.size() && |
| 1269 | "Orders have different size with WorkSet"); |
| 1270 | |
| 1271 | #ifndef NDEBUG |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1272 | LLVM_DEBUG(dbgs() << "Orders size is " << Orders.size() << "\n"); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1273 | SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin(); |
| 1274 | for (; RIt != Orders.rend(); RIt++) |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1275 | LLVM_DEBUG(dbgs() << "BB" << (*RIt)->getBlock()->getNumber() << ","); |
| 1276 | LLVM_DEBUG(dbgs() << "\n"); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1277 | #endif |
| 1278 | } |
| 1279 | |
| 1280 | /// Try to hoist spills according to BB hotness. The spills to removed will |
| 1281 | /// be saved in \p SpillsToRm. The spills to be inserted will be saved in |
| 1282 | /// \p SpillsToIns. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1283 | void HoistSpillHelper::runHoistSpills( |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1284 | LiveInterval &OrigLI, VNInfo &OrigVNI, |
| 1285 | SmallPtrSet<MachineInstr *, 16> &Spills, |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1286 | SmallVectorImpl<MachineInstr *> &SpillsToRm, |
| 1287 | DenseMap<MachineBasicBlock *, unsigned> &SpillsToIns) { |
| 1288 | // Visit order of dominator tree nodes. |
| 1289 | SmallVector<MachineDomTreeNode *, 32> Orders; |
| 1290 | // SpillsToKeep contains all the nodes where spills are to be inserted |
| 1291 | // during hoisting. If the spill to be inserted is an original spill |
| 1292 | // (not a hoisted one), the value of the map entry is 0. If the spill |
| 1293 | // is a hoisted spill, the value of the map entry is the VReg to be used |
| 1294 | // as the source of the spill. |
| 1295 | DenseMap<MachineDomTreeNode *, unsigned> SpillsToKeep; |
| 1296 | // Map from BB to the first spill inside of it. |
| 1297 | DenseMap<MachineDomTreeNode *, MachineInstr *> SpillBBToSpill; |
| 1298 | |
| 1299 | rmRedundantSpills(Spills, SpillsToRm, SpillBBToSpill); |
| 1300 | |
| 1301 | MachineBasicBlock *Root = LIS.getMBBFromIndex(OrigVNI.def); |
| 1302 | getVisitOrders(Root, Spills, Orders, SpillsToRm, SpillsToKeep, |
| 1303 | SpillBBToSpill); |
| 1304 | |
| 1305 | // SpillsInSubTreeMap keeps the map from a dom tree node to a pair of |
| 1306 | // nodes set and the cost of all the spills inside those nodes. |
| 1307 | // The nodes set are the locations where spills are to be inserted |
| 1308 | // in the subtree of current node. |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 1309 | using NodesCostPair = |
| 1310 | std::pair<SmallPtrSet<MachineDomTreeNode *, 16>, BlockFrequency>; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1311 | DenseMap<MachineDomTreeNode *, NodesCostPair> SpillsInSubTreeMap; |
Eugene Zelenko | 7cf6af5 | 2017-08-29 22:32:07 +0000 | [diff] [blame] | 1312 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1313 | // Iterate Orders set in reverse order, which will be a bottom-up order |
| 1314 | // in the dominator tree. Once we visit a dom tree node, we know its |
| 1315 | // children have already been visited and the spill locations in the |
| 1316 | // subtrees of all the children have been determined. |
| 1317 | SmallVector<MachineDomTreeNode *, 32>::reverse_iterator RIt = Orders.rbegin(); |
| 1318 | for (; RIt != Orders.rend(); RIt++) { |
| 1319 | MachineBasicBlock *Block = (*RIt)->getBlock(); |
| 1320 | |
| 1321 | // If Block contains an original spill, simply continue. |
| 1322 | if (SpillsToKeep.find(*RIt) != SpillsToKeep.end() && !SpillsToKeep[*RIt]) { |
| 1323 | SpillsInSubTreeMap[*RIt].first.insert(*RIt); |
| 1324 | // SpillsInSubTreeMap[*RIt].second contains the cost of spill. |
| 1325 | SpillsInSubTreeMap[*RIt].second = MBFI.getBlockFreq(Block); |
| 1326 | continue; |
| 1327 | } |
| 1328 | |
| 1329 | // Collect spills in subtree of current node (*RIt) to |
| 1330 | // SpillsInSubTreeMap[*RIt].first. |
| 1331 | const std::vector<MachineDomTreeNode *> &Children = (*RIt)->getChildren(); |
| 1332 | unsigned NumChildren = Children.size(); |
| 1333 | for (unsigned i = 0; i != NumChildren; ++i) { |
| 1334 | MachineDomTreeNode *Child = Children[i]; |
| 1335 | if (SpillsInSubTreeMap.find(Child) == SpillsInSubTreeMap.end()) |
| 1336 | continue; |
| 1337 | // The stmt "SpillsInSubTree = SpillsInSubTreeMap[*RIt].first" below |
| 1338 | // should be placed before getting the begin and end iterators of |
| 1339 | // SpillsInSubTreeMap[Child].first, or else the iterators may be |
| 1340 | // invalidated when SpillsInSubTreeMap[*RIt] is seen the first time |
| 1341 | // and the map grows and then the original buckets in the map are moved. |
| 1342 | SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree = |
| 1343 | SpillsInSubTreeMap[*RIt].first; |
| 1344 | BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second; |
| 1345 | SubTreeCost += SpillsInSubTreeMap[Child].second; |
| 1346 | auto BI = SpillsInSubTreeMap[Child].first.begin(); |
| 1347 | auto EI = SpillsInSubTreeMap[Child].first.end(); |
| 1348 | SpillsInSubTree.insert(BI, EI); |
| 1349 | SpillsInSubTreeMap.erase(Child); |
| 1350 | } |
| 1351 | |
| 1352 | SmallPtrSet<MachineDomTreeNode *, 16> &SpillsInSubTree = |
| 1353 | SpillsInSubTreeMap[*RIt].first; |
| 1354 | BlockFrequency &SubTreeCost = SpillsInSubTreeMap[*RIt].second; |
| 1355 | // No spills in subtree, simply continue. |
| 1356 | if (SpillsInSubTree.empty()) |
| 1357 | continue; |
| 1358 | |
| 1359 | // Check whether Block is a possible candidate to insert spill. |
| 1360 | unsigned LiveReg = 0; |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1361 | if (!isSpillCandBB(OrigLI, OrigVNI, *Block, LiveReg)) |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1362 | continue; |
| 1363 | |
| 1364 | // If there are multiple spills that could be merged, bias a little |
| 1365 | // to hoist the spill. |
| 1366 | BranchProbability MarginProb = (SpillsInSubTree.size() > 1) |
| 1367 | ? BranchProbability(9, 10) |
| 1368 | : BranchProbability(1, 1); |
| 1369 | if (SubTreeCost > MBFI.getBlockFreq(Block) * MarginProb) { |
| 1370 | // Hoist: Move spills to current Block. |
| 1371 | for (const auto SpillBB : SpillsInSubTree) { |
| 1372 | // When SpillBB is a BB contains original spill, insert the spill |
| 1373 | // to SpillsToRm. |
| 1374 | if (SpillsToKeep.find(SpillBB) != SpillsToKeep.end() && |
| 1375 | !SpillsToKeep[SpillBB]) { |
| 1376 | MachineInstr *SpillToRm = SpillBBToSpill[SpillBB]; |
| 1377 | SpillsToRm.push_back(SpillToRm); |
| 1378 | } |
| 1379 | // SpillBB will not contain spill anymore, remove it from SpillsToKeep. |
| 1380 | SpillsToKeep.erase(SpillBB); |
| 1381 | } |
| 1382 | // Current Block is the BB containing the new hoisted spill. Add it to |
| 1383 | // SpillsToKeep. LiveReg is the source of the new spill. |
| 1384 | SpillsToKeep[*RIt] = LiveReg; |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1385 | LLVM_DEBUG({ |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1386 | dbgs() << "spills in BB: "; |
| 1387 | for (const auto Rspill : SpillsInSubTree) |
| 1388 | dbgs() << Rspill->getBlock()->getNumber() << " "; |
| 1389 | dbgs() << "were promoted to BB" << (*RIt)->getBlock()->getNumber() |
| 1390 | << "\n"; |
| 1391 | }); |
| 1392 | SpillsInSubTree.clear(); |
| 1393 | SpillsInSubTree.insert(*RIt); |
| 1394 | SubTreeCost = MBFI.getBlockFreq(Block); |
| 1395 | } |
| 1396 | } |
| 1397 | // For spills in SpillsToKeep with LiveReg set (i.e., not original spill), |
| 1398 | // save them to SpillsToIns. |
| 1399 | for (const auto Ent : SpillsToKeep) { |
| 1400 | if (Ent.second) |
| 1401 | SpillsToIns[Ent.first->getBlock()] = Ent.second; |
| 1402 | } |
| 1403 | } |
| 1404 | |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1405 | /// For spills with equal values, remove redundant spills and hoist those left |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1406 | /// to less hot spots. |
| 1407 | /// |
| 1408 | /// Spills with equal values will be collected into the same set in |
| 1409 | /// MergeableSpills when spill is inserted. These equal spills are originated |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1410 | /// from the same defining instruction and are dominated by the instruction. |
| 1411 | /// Before hoisting all the equal spills, redundant spills inside in the same |
| 1412 | /// BB are first marked to be deleted. Then starting from the spills left, walk |
| 1413 | /// up on the dominator tree towards the Root node where the define instruction |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1414 | /// is located, mark the dominated spills to be deleted along the way and |
| 1415 | /// collect the BB nodes on the path from non-dominated spills to the define |
| 1416 | /// instruction into a WorkSet. The nodes in WorkSet are the candidate places |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1417 | /// where we are considering to hoist the spills. We iterate the WorkSet in |
| 1418 | /// bottom-up order, and for each node, we will decide whether to hoist spills |
| 1419 | /// inside its subtree to that node. In this way, we can get benefit locally |
| 1420 | /// even if hoisting all the equal spills to one cold place is impossible. |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 1421 | void HoistSpillHelper::hoistAllSpills() { |
| 1422 | SmallVector<unsigned, 4> NewVRegs; |
| 1423 | LiveRangeEdit Edit(nullptr, NewVRegs, MF, LIS, &VRM, this); |
| 1424 | |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1425 | for (unsigned i = 0, e = MRI.getNumVirtRegs(); i != e; ++i) { |
| 1426 | unsigned Reg = TargetRegisterInfo::index2VirtReg(i); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1427 | unsigned Original = VRM.getPreSplitReg(Reg); |
| 1428 | if (!MRI.def_empty(Reg)) |
| 1429 | Virt2SiblingsMap[Original].insert(Reg); |
| 1430 | } |
| 1431 | |
| 1432 | // Each entry in MergeableSpills contains a spill set with equal values. |
| 1433 | for (auto &Ent : MergeableSpills) { |
| 1434 | int Slot = Ent.first.first; |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1435 | LiveInterval &OrigLI = *StackSlotToOrigLI[Slot]; |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1436 | VNInfo *OrigVNI = Ent.first.second; |
| 1437 | SmallPtrSet<MachineInstr *, 16> &EqValSpills = Ent.second; |
| 1438 | if (Ent.second.empty()) |
| 1439 | continue; |
| 1440 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1441 | LLVM_DEBUG({ |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1442 | dbgs() << "\nFor Slot" << Slot << " and VN" << OrigVNI->id << ":\n" |
| 1443 | << "Equal spills in BB: "; |
| 1444 | for (const auto spill : EqValSpills) |
| 1445 | dbgs() << spill->getParent()->getNumber() << " "; |
| 1446 | dbgs() << "\n"; |
| 1447 | }); |
| 1448 | |
| 1449 | // SpillsToRm is the spill set to be removed from EqValSpills. |
| 1450 | SmallVector<MachineInstr *, 16> SpillsToRm; |
| 1451 | // SpillsToIns is the spill set to be newly inserted after hoisting. |
| 1452 | DenseMap<MachineBasicBlock *, unsigned> SpillsToIns; |
| 1453 | |
Wei Mi | 57d83cb | 2017-09-13 21:41:30 +0000 | [diff] [blame] | 1454 | runHoistSpills(OrigLI, *OrigVNI, EqValSpills, SpillsToRm, SpillsToIns); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1455 | |
Nicola Zaghen | 0818e78 | 2018-05-14 12:53:11 +0000 | [diff] [blame] | 1456 | LLVM_DEBUG({ |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1457 | dbgs() << "Finally inserted spills in BB: "; |
| 1458 | for (const auto Ispill : SpillsToIns) |
| 1459 | dbgs() << Ispill.first->getNumber() << " "; |
| 1460 | dbgs() << "\nFinally removed spills in BB: "; |
| 1461 | for (const auto Rspill : SpillsToRm) |
| 1462 | dbgs() << Rspill->getParent()->getNumber() << " "; |
| 1463 | dbgs() << "\n"; |
| 1464 | }); |
| 1465 | |
| 1466 | // Stack live range update. |
| 1467 | LiveInterval &StackIntvl = LSS.getInterval(Slot); |
Wei Mi | 825e5aa | 2016-05-11 22:37:43 +0000 | [diff] [blame] | 1468 | if (!SpillsToIns.empty() || !SpillsToRm.empty()) |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1469 | StackIntvl.MergeValueInAsValue(OrigLI, OrigVNI, |
| 1470 | StackIntvl.getValNumInfo(0)); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1471 | |
| 1472 | // Insert hoisted spills. |
| 1473 | for (auto const Insert : SpillsToIns) { |
| 1474 | MachineBasicBlock *BB = Insert.first; |
| 1475 | unsigned LiveReg = Insert.second; |
Wei Mi | 14a29ca | 2016-05-23 19:39:19 +0000 | [diff] [blame] | 1476 | MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1477 | TII.storeRegToStackSlot(*BB, MI, LiveReg, false, Slot, |
| 1478 | MRI.getRegClass(LiveReg), &TRI); |
| 1479 | LIS.InsertMachineInstrRangeInMaps(std::prev(MI), MI); |
| 1480 | ++NumSpills; |
| 1481 | } |
| 1482 | |
Eric Christopher | 4449a75 | 2016-05-04 21:45:36 +0000 | [diff] [blame] | 1483 | // Remove redundant spills or change them to dead instructions. |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1484 | NumSpills -= SpillsToRm.size(); |
| 1485 | for (auto const RMEnt : SpillsToRm) { |
| 1486 | RMEnt->setDesc(TII.get(TargetOpcode::KILL)); |
| 1487 | for (unsigned i = RMEnt->getNumOperands(); i; --i) { |
| 1488 | MachineOperand &MO = RMEnt->getOperand(i - 1); |
| 1489 | if (MO.isReg() && MO.isImplicit() && MO.isDef() && !MO.isDead()) |
| 1490 | RMEnt->RemoveOperand(i - 1); |
| 1491 | } |
| 1492 | } |
Wei Mi | 4eae278 | 2016-07-08 21:08:09 +0000 | [diff] [blame] | 1493 | Edit.eliminateDeadDefs(SpillsToRm, None, AA); |
Wei Mi | 815b02e | 2016-04-13 03:08:27 +0000 | [diff] [blame] | 1494 | } |
| 1495 | } |
Wei Mi | 1f5a2c3 | 2016-04-15 23:16:44 +0000 | [diff] [blame] | 1496 | |
| 1497 | /// For VirtReg clone, the \p New register should have the same physreg or |
| 1498 | /// stackslot as the \p old register. |
| 1499 | void HoistSpillHelper::LRE_DidCloneVirtReg(unsigned New, unsigned Old) { |
| 1500 | if (VRM.hasPhys(Old)) |
| 1501 | VRM.assignVirt2Phys(New, VRM.getPhys(Old)); |
| 1502 | else if (VRM.getStackSlot(Old) != VirtRegMap::NO_STACK_SLOT) |
| 1503 | VRM.assignVirt2StackSlot(New, VRM.getStackSlot(Old)); |
| 1504 | else |
| 1505 | llvm_unreachable("VReg should be assigned either physreg or stackslot"); |
| 1506 | } |