blob: 089c9e284570197a99cd999d24d08a8b4134f563 [file] [log] [blame]
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080017#include "ResourceParser.h"
Adam Lesinskice5e56e2016-10-21 17:56:45 -070018
19#include <functional>
Adam Lesinski73bff1e2017-12-08 16:06:10 -080020#include <limits>
Adam Lesinskice5e56e2016-10-21 17:56:45 -070021#include <sstream>
22
23#include "android-base/logging.h"
24
Adam Lesinski1ab598f2015-08-14 14:26:04 -070025#include "ResourceTable.h"
26#include "ResourceUtils.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080027#include "ResourceValues.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070028#include "ValueVisitor.h"
Adam Lesinski2eed52e2018-02-21 15:55:58 -080029#include "text/Utf8Iterator.h"
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080030#include "util/ImmutableMap.h"
Adam Lesinski75421622017-01-06 15:20:04 -080031#include "util/Maybe.h"
Adam Lesinski9e10ac72015-10-16 14:37:48 -070032#include "util/Util.h"
Adam Lesinski467f1712015-11-16 17:35:44 -080033#include "xml/XmlPullParser.h"
Adam Lesinski9e10ac72015-10-16 14:37:48 -070034
Adam Lesinski2eed52e2018-02-21 15:55:58 -080035using ::aapt::ResourceUtils::StringBuilder;
36using ::aapt::text::Utf8Iterator;
Adam Lesinski71be7052017-12-12 16:48:07 -080037using ::android::StringPiece;
Adam Lesinskid5083f62017-01-16 15:07:21 -080038
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080039namespace aapt {
40
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070041constexpr const char* sXliffNamespaceUri = "urn:oasis:names:tc:xliff:document:1.2";
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080042
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070043// Returns true if the element is <skip> or <eat-comment> and can be safely ignored.
44static bool ShouldIgnoreElement(const StringPiece& ns, const StringPiece& name) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070045 return ns.empty() && (name == "skip" || name == "eat-comment");
Adam Lesinski27afb9e2015-11-06 18:25:04 -080046}
47
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070048static uint32_t ParseFormatTypeNoEnumsOrFlags(const StringPiece& piece) {
49 if (piece == "reference") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070050 return android::ResTable_map::TYPE_REFERENCE;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070051 } else if (piece == "string") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070052 return android::ResTable_map::TYPE_STRING;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070053 } else if (piece == "integer") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070054 return android::ResTable_map::TYPE_INTEGER;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070055 } else if (piece == "boolean") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070056 return android::ResTable_map::TYPE_BOOLEAN;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070057 } else if (piece == "color") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070058 return android::ResTable_map::TYPE_COLOR;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070059 } else if (piece == "float") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070060 return android::ResTable_map::TYPE_FLOAT;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070061 } else if (piece == "dimension") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070062 return android::ResTable_map::TYPE_DIMENSION;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070063 } else if (piece == "fraction") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070064 return android::ResTable_map::TYPE_FRACTION;
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070065 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -070066 return 0;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080067}
68
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070069static uint32_t ParseFormatType(const StringPiece& piece) {
70 if (piece == "enum") {
71 return android::ResTable_map::TYPE_ENUM;
72 } else if (piece == "flags") {
73 return android::ResTable_map::TYPE_FLAGS;
74 }
75 return ParseFormatTypeNoEnumsOrFlags(piece);
76}
77
Adam Lesinskice5e56e2016-10-21 17:56:45 -070078static uint32_t ParseFormatAttribute(const StringPiece& str) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070079 uint32_t mask = 0;
Adam Lesinskice5e56e2016-10-21 17:56:45 -070080 for (StringPiece part : util::Tokenize(str, '|')) {
81 StringPiece trimmed_part = util::TrimWhitespace(part);
82 uint32_t type = ParseFormatType(trimmed_part);
Adam Lesinskicacb28f2016-10-19 12:18:14 -070083 if (type == 0) {
84 return 0;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080085 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -070086 mask |= type;
87 }
88 return mask;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080089}
90
Adam Lesinskid5fd76a2017-05-16 12:18:08 -070091// A parsed resource ready to be added to the ResourceTable.
Adam Lesinski7ff3ee12015-12-14 16:08:50 -080092struct ParsedResource {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070093 ResourceName name;
94 ConfigDescription config;
95 std::string product;
96 Source source;
Adam Lesinski71be7052017-12-12 16:48:07 -080097
Adam Lesinskicacb28f2016-10-19 12:18:14 -070098 ResourceId id;
Adam Lesinski71be7052017-12-12 16:48:07 -080099 Visibility::Level visibility_level = Visibility::Level::kUndefined;
Adam Lesinski4488f1c2017-05-26 17:33:38 -0700100 bool allow_new = false;
Adam Lesinski71be7052017-12-12 16:48:07 -0800101 bool overlayable = false;
102
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700103 std::string comment;
104 std::unique_ptr<Value> value;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700105 std::list<ParsedResource> child_resources;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800106};
107
108// Recursively adds resources to the ResourceTable.
Adam Lesinski4488f1c2017-05-26 17:33:38 -0700109static bool AddResourcesToTable(ResourceTable* table, IDiagnostics* diag, ParsedResource* res) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700110 StringPiece trimmed_comment = util::TrimWhitespace(res->comment);
111 if (trimmed_comment.size() != res->comment.size()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700112 // Only if there was a change do we re-assign.
Adam Lesinskid5083f62017-01-16 15:07:21 -0800113 res->comment = trimmed_comment.to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700114 }
Adam Lesinski7656554f2016-03-10 21:55:04 -0800115
Adam Lesinski71be7052017-12-12 16:48:07 -0800116 if (res->visibility_level != Visibility::Level::kUndefined) {
117 Visibility visibility;
118 visibility.level = res->visibility_level;
119 visibility.source = res->source;
120 visibility.comment = res->comment;
121 if (!table->SetVisibilityWithId(res->name, visibility, res->id, diag)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700122 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800123 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700124 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800125
Adam Lesinski71be7052017-12-12 16:48:07 -0800126 if (res->allow_new) {
127 AllowNew allow_new;
128 allow_new.source = res->source;
129 allow_new.comment = res->comment;
130 if (!table->SetAllowNew(res->name, allow_new, diag)) {
131 return false;
132 }
133 }
134
135 if (res->overlayable) {
136 Overlayable overlayable;
137 overlayable.source = res->source;
138 overlayable.comment = res->comment;
139 if (!table->SetOverlayable(res->name, overlayable, diag)) {
140 return false;
141 }
142 }
143
144 if (res->value != nullptr) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700145 // Attach the comment, source and config to the value.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700146 res->value->SetComment(std::move(res->comment));
147 res->value->SetSource(std::move(res->source));
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800148
Adam Lesinski71be7052017-12-12 16:48:07 -0800149 if (!table->AddResourceWithId(res->name, res->id, res->config, res->product,
150 std::move(res->value), diag)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700151 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800152 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700153 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800154
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700155 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700156 for (ParsedResource& child : res->child_resources) {
157 error |= !AddResourcesToTable(table, diag, &child);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700158 }
159 return !error;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800160}
161
162// Convenient aliases for more readable function calls.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700163enum { kAllowRawString = true, kNoRawString = false };
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800164
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700165ResourceParser::ResourceParser(IDiagnostics* diag, ResourceTable* table,
166 const Source& source,
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700167 const ConfigDescription& config,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700168 const ResourceParserOptions& options)
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700169 : diag_(diag),
170 table_(table),
171 source_(source),
172 config_(config),
173 options_(options) {}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800174
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800175// Base class Node for representing the various Spans and UntranslatableSections of an XML string.
176// This will be used to traverse and flatten the XML string into a single std::string, with all
177// Span and Untranslatable data maintained in parallel, as indices into the string.
178class Node {
179 public:
180 virtual ~Node() = default;
181
182 // Adds the given child node to this parent node's set of child nodes, moving ownership to the
183 // parent node as well.
184 // Returns a pointer to the child node that was added as a convenience.
185 template <typename T>
186 T* AddChild(std::unique_ptr<T> node) {
187 T* raw_ptr = node.get();
188 children.push_back(std::move(node));
189 return raw_ptr;
190 }
191
192 virtual void Build(StringBuilder* builder) const {
193 for (const auto& child : children) {
194 child->Build(builder);
195 }
196 }
197
198 std::vector<std::unique_ptr<Node>> children;
199};
200
201// A chunk of text in the XML string. This lives between other tags, such as XLIFF tags and Spans.
202class SegmentNode : public Node {
203 public:
204 std::string data;
205
206 void Build(StringBuilder* builder) const override {
207 builder->AppendText(data);
208 }
209};
210
211// A tag that will be encoded into the final flattened string. Tags like <b> or <i>.
212class SpanNode : public Node {
213 public:
214 std::string name;
215
216 void Build(StringBuilder* builder) const override {
217 StringBuilder::SpanHandle span_handle = builder->StartSpan(name);
218 Node::Build(builder);
219 builder->EndSpan(span_handle);
220 }
221};
222
223// An XLIFF 'g' tag, which marks a section of the string as untranslatable.
224class UntranslatableNode : public Node {
225 public:
226 void Build(StringBuilder* builder) const override {
227 StringBuilder::UntranslatableHandle handle = builder->StartUntranslatable();
228 Node::Build(builder);
229 builder->EndUntranslatable(handle);
230 }
231};
232
233// Build a string from XML that converts nested elements into Span objects.
Adam Lesinski75421622017-01-06 15:20:04 -0800234bool ResourceParser::FlattenXmlSubtree(
235 xml::XmlPullParser* parser, std::string* out_raw_string, StyleString* out_style_string,
236 std::vector<UntranslatableSection>* out_untranslatable_sections) {
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800237 std::string raw_string;
238 std::string current_text;
Adam Lesinski75421622017-01-06 15:20:04 -0800239
240 // The first occurrence of a <xliff:g> tag. Nested <xliff:g> tags are illegal.
241 Maybe<size_t> untranslatable_start_depth;
242
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800243 Node root;
244 std::vector<Node*> node_stack;
245 node_stack.push_back(&root);
246
247 bool saw_span_node = false;
248 SegmentNode* first_segment = nullptr;
249 SegmentNode* last_segment = nullptr;
250
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700251 size_t depth = 1;
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800252 while (depth > 0 && xml::XmlPullParser::IsGoodEvent(parser->Next())) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700253 const xml::XmlPullParser::Event event = parser->event();
Adam Lesinski75421622017-01-06 15:20:04 -0800254
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800255 // First take care of any SegmentNodes that should be created.
256 if (event == xml::XmlPullParser::Event::kStartElement ||
257 event == xml::XmlPullParser::Event::kEndElement) {
258 if (!current_text.empty()) {
259 std::unique_ptr<SegmentNode> segment_node = util::make_unique<SegmentNode>();
260 segment_node->data = std::move(current_text);
261 last_segment = node_stack.back()->AddChild(std::move(segment_node));
262 if (first_segment == nullptr) {
263 first_segment = last_segment;
Adam Lesinski75421622017-01-06 15:20:04 -0800264 }
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800265 current_text = {};
266 }
267 }
Adam Lesinski75421622017-01-06 15:20:04 -0800268
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800269 switch (event) {
270 case xml::XmlPullParser::Event::kText: {
271 current_text += parser->text();
272 raw_string += parser->text();
273 } break;
Adam Lesinski75421622017-01-06 15:20:04 -0800274
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800275 case xml::XmlPullParser::Event::kStartElement: {
276 if (parser->element_namespace().empty()) {
277 // This is an HTML tag which we encode as a span. Add it to the span stack.
278 std::unique_ptr<SpanNode> span_node = util::make_unique<SpanNode>();
279 span_node->name = parser->element_name();
280 const auto end_attr_iter = parser->end_attributes();
281 for (auto attr_iter = parser->begin_attributes(); attr_iter != end_attr_iter;
282 ++attr_iter) {
283 span_node->name += ";";
284 span_node->name += attr_iter->name;
285 span_node->name += "=";
286 span_node->name += attr_iter->value;
Adam Lesinski75421622017-01-06 15:20:04 -0800287 }
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800288
289 node_stack.push_back(node_stack.back()->AddChild(std::move(span_node)));
290 saw_span_node = true;
291 } else if (parser->element_namespace() == sXliffNamespaceUri) {
292 // This is an XLIFF tag, which is not encoded as a span.
293 if (parser->element_name() == "g") {
294 // Check that an 'untranslatable' tag is not already being processed. Nested
295 // <xliff:g> tags are illegal.
296 if (untranslatable_start_depth) {
297 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
298 << "illegal nested XLIFF 'g' tag");
299 return false;
300 } else {
301 // Mark the beginning of an 'untranslatable' section.
302 untranslatable_start_depth = depth;
303 node_stack.push_back(
304 node_stack.back()->AddChild(util::make_unique<UntranslatableNode>()));
305 }
306 } else {
307 // Ignore unknown XLIFF tags, but don't warn.
308 node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>()));
309 }
310 } else {
311 // Besides XLIFF, any other namespaced tag is unsupported and ignored.
312 diag_->Warn(DiagMessage(source_.WithLine(parser->line_number()))
313 << "ignoring element '" << parser->element_name()
314 << "' with unknown namespace '" << parser->element_namespace() << "'");
315 node_stack.push_back(node_stack.back()->AddChild(util::make_unique<Node>()));
Adam Lesinski75421622017-01-06 15:20:04 -0800316 }
Adam Lesinski75421622017-01-06 15:20:04 -0800317
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800318 // Enter one level inside the element.
319 depth++;
320 } break;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700321
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800322 case xml::XmlPullParser::Event::kEndElement: {
323 // Return one level from within the element.
324 depth--;
325 if (depth == 0) {
326 break;
327 }
328
329 node_stack.pop_back();
330 if (untranslatable_start_depth == make_value(depth)) {
331 // This is the end of an untranslatable section.
332 untranslatable_start_depth = {};
333 }
334 } break;
335
336 default:
337 // ignore.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700338 break;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700339 }
340 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700341
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800342 // Sanity check to make sure we processed all the nodes.
343 CHECK(node_stack.size() == 1u);
344 CHECK(node_stack.back() == &root);
345
346 if (!saw_span_node) {
347 // If there were no spans, we must treat this string a little differently (according to AAPT).
348 // Find and strip the leading whitespace from the first segment, and the trailing whitespace
349 // from the last segment.
350 if (first_segment != nullptr) {
351 // Trim leading whitespace.
352 StringPiece trimmed = util::TrimLeadingWhitespace(first_segment->data);
353 if (trimmed.size() != first_segment->data.size()) {
354 first_segment->data = trimmed.to_string();
355 }
356 }
357
358 if (last_segment != nullptr) {
359 // Trim trailing whitespace.
360 StringPiece trimmed = util::TrimTrailingWhitespace(last_segment->data);
361 if (trimmed.size() != last_segment->data.size()) {
362 last_segment->data = trimmed.to_string();
363 }
364 }
365 }
366
367 // Have the XML structure flatten itself into the StringBuilder. The StringBuilder will take
368 // care of recording the correctly adjusted Spans and UntranslatableSections.
369 StringBuilder builder;
370 root.Build(&builder);
371 if (!builder) {
372 diag_->Error(DiagMessage(source_.WithLine(parser->line_number())) << builder.GetError());
373 return false;
374 }
375
376 ResourceUtils::FlattenedXmlString flattened_string = builder.GetFlattenedString();
377 *out_raw_string = std::move(raw_string);
378 *out_untranslatable_sections = std::move(flattened_string.untranslatable_sections);
379 out_style_string->str = std::move(flattened_string.text);
380 out_style_string->spans = std::move(flattened_string.spans);
Adam Lesinski75421622017-01-06 15:20:04 -0800381 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800382}
383
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700384bool ResourceParser::Parse(xml::XmlPullParser* parser) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700385 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700386 const size_t depth = parser->depth();
387 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
388 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700389 // Skip comments and text.
390 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800391 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700392
Adam Lesinski060b53d2017-07-28 17:10:35 -0700393 if (!parser->element_namespace().empty() || parser->element_name() != "resources") {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700394 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700395 << "root element must be <resources>");
396 return false;
397 }
398
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700399 error |= !ParseResources(parser);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700400 break;
401 };
402
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700403 if (parser->event() == xml::XmlPullParser::Event::kBadDocument) {
404 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
405 << "xml parser error: " << parser->error());
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700406 return false;
407 }
408 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800409}
410
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700411bool ResourceParser::ParseResources(xml::XmlPullParser* parser) {
412 std::set<ResourceName> stripped_resources;
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700413
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700414 bool error = false;
415 std::string comment;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700416 const size_t depth = parser->depth();
417 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
418 const xml::XmlPullParser::Event event = parser->event();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700419 if (event == xml::XmlPullParser::Event::kComment) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700420 comment = parser->comment();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700421 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800422 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700423
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700424 if (event == xml::XmlPullParser::Event::kText) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700425 if (!util::TrimWhitespace(parser->text()).empty()) {
426 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700427 << "plain text not allowed here");
428 error = true;
429 }
430 continue;
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700431 }
432
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700433 CHECK(event == xml::XmlPullParser::Event::kStartElement);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700434
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700435 if (!parser->element_namespace().empty()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700436 // Skip unknown namespace.
437 continue;
438 }
439
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700440 std::string element_name = parser->element_name();
441 if (element_name == "skip" || element_name == "eat-comment") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700442 comment = "";
443 continue;
444 }
445
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700446 ParsedResource parsed_resource;
447 parsed_resource.config = config_;
448 parsed_resource.source = source_.WithLine(parser->line_number());
449 parsed_resource.comment = std::move(comment);
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100450 if (options_.visibility) {
451 parsed_resource.visibility_level = options_.visibility.value();
452 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700453
454 // Extract the product name if it exists.
Adam Lesinski060b53d2017-07-28 17:10:35 -0700455 if (Maybe<StringPiece> maybe_product = xml::FindNonEmptyAttribute(parser, "product")) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800456 parsed_resource.product = maybe_product.value().to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700457 }
458
459 // Parse the resource regardless of product.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700460 if (!ParseResource(parser, &parsed_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700461 error = true;
462 continue;
463 }
464
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700465 if (!AddResourcesToTable(table_, diag_, &parsed_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700466 error = true;
467 }
468 }
469
470 // Check that we included at least one variant of each stripped resource.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700471 for (const ResourceName& stripped_resource : stripped_resources) {
472 if (!table_->FindResource(stripped_resource)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700473 // Failed to find the resource.
Adam Lesinski060b53d2017-07-28 17:10:35 -0700474 diag_->Error(DiagMessage(source_) << "resource '" << stripped_resource
475 << "' was filtered out but no product variant remains");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700476 error = true;
477 }
478 }
479
480 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800481}
482
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700483bool ResourceParser::ParseResource(xml::XmlPullParser* parser,
484 ParsedResource* out_resource) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700485 struct ItemTypeFormat {
486 ResourceType type;
487 uint32_t format;
488 };
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800489
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700490 using BagParseFunc = std::function<bool(ResourceParser*, xml::XmlPullParser*,
491 ParsedResource*)>;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800492
Adam Lesinski86d67df2017-01-31 13:47:27 -0800493 static const auto elToItemMap = ImmutableMap<std::string, ItemTypeFormat>::CreatePreSorted({
494 {"bool", {ResourceType::kBool, android::ResTable_map::TYPE_BOOLEAN}},
495 {"color", {ResourceType::kColor, android::ResTable_map::TYPE_COLOR}},
496 {"configVarying", {ResourceType::kConfigVarying, android::ResTable_map::TYPE_ANY}},
497 {"dimen",
498 {ResourceType::kDimen,
499 android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION |
500 android::ResTable_map::TYPE_DIMENSION}},
501 {"drawable", {ResourceType::kDrawable, android::ResTable_map::TYPE_COLOR}},
502 {"fraction",
503 {ResourceType::kFraction,
504 android::ResTable_map::TYPE_FLOAT | android::ResTable_map::TYPE_FRACTION |
505 android::ResTable_map::TYPE_DIMENSION}},
506 {"integer", {ResourceType::kInteger, android::ResTable_map::TYPE_INTEGER}},
507 {"string", {ResourceType::kString, android::ResTable_map::TYPE_STRING}},
508 });
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800509
Adam Lesinski86d67df2017-01-31 13:47:27 -0800510 static const auto elToBagMap = ImmutableMap<std::string, BagParseFunc>::CreatePreSorted({
511 {"add-resource", std::mem_fn(&ResourceParser::ParseAddResource)},
512 {"array", std::mem_fn(&ResourceParser::ParseArray)},
513 {"attr", std::mem_fn(&ResourceParser::ParseAttr)},
514 {"configVarying",
515 std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kConfigVarying,
516 std::placeholders::_2, std::placeholders::_3)},
517 {"declare-styleable", std::mem_fn(&ResourceParser::ParseDeclareStyleable)},
518 {"integer-array", std::mem_fn(&ResourceParser::ParseIntegerArray)},
519 {"java-symbol", std::mem_fn(&ResourceParser::ParseSymbol)},
Adam Lesinski46c4d722017-08-23 13:03:56 -0700520 {"overlayable", std::mem_fn(&ResourceParser::ParseOverlayable)},
Adam Lesinski86d67df2017-01-31 13:47:27 -0800521 {"plurals", std::mem_fn(&ResourceParser::ParsePlural)},
522 {"public", std::mem_fn(&ResourceParser::ParsePublic)},
523 {"public-group", std::mem_fn(&ResourceParser::ParsePublicGroup)},
524 {"string-array", std::mem_fn(&ResourceParser::ParseStringArray)},
525 {"style", std::bind(&ResourceParser::ParseStyle, std::placeholders::_1, ResourceType::kStyle,
526 std::placeholders::_2, std::placeholders::_3)},
527 {"symbol", std::mem_fn(&ResourceParser::ParseSymbol)},
528 });
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800529
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700530 std::string resource_type = parser->element_name();
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800531
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700532 // The value format accepted for this resource.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700533 uint32_t resource_format = 0u;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800534
Adam Lesinski86d67df2017-01-31 13:47:27 -0800535 bool can_be_item = true;
536 bool can_be_bag = true;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700537 if (resource_type == "item") {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800538 can_be_bag = false;
539
Adam Lesinskie597d682017-06-01 17:16:44 -0700540 // The default format for <item> is any. If a format attribute is present, that one will
541 // override the default.
542 resource_format = android::ResTable_map::TYPE_ANY;
543
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700544 // Items have their type encoded in the type attribute.
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700545 if (Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800546 resource_type = maybe_type.value().to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700547 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700548 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700549 << "<item> must have a 'type' attribute");
550 return false;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800551 }
552
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700553 if (Maybe<StringPiece> maybe_format = xml::FindNonEmptyAttribute(parser, "format")) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700554 // An explicit format for this resource was specified. The resource will
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700555 // retain its type in its name, but the accepted value for this type is
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700556 // overridden.
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700557 resource_format = ParseFormatTypeNoEnumsOrFlags(maybe_format.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700558 if (!resource_format) {
559 diag_->Error(DiagMessage(out_resource->source)
560 << "'" << maybe_format.value()
561 << "' is an invalid format");
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800562 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700563 }
564 }
Adam Lesinski86d67df2017-01-31 13:47:27 -0800565 } else if (resource_type == "bag") {
566 can_be_item = false;
567
568 // Bags have their type encoded in the type attribute.
569 if (Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type")) {
570 resource_type = maybe_type.value().to_string();
571 } else {
572 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
573 << "<bag> must have a 'type' attribute");
574 return false;
575 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700576 }
577
578 // Get the name of the resource. This will be checked later, because not all
579 // XML elements require a name.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700580 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700581
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700582 if (resource_type == "id") {
583 if (!maybe_name) {
584 diag_->Error(DiagMessage(out_resource->source)
585 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700586 << "> missing 'name' attribute");
587 return false;
588 }
589
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700590 out_resource->name.type = ResourceType::kId;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800591 out_resource->name.entry = maybe_name.value().to_string();
y9efbbef2018-04-18 11:29:09 -0700592
593 // Ids either represent a unique resource id or reference another resource id
594 auto item = ParseItem(parser, out_resource, resource_format);
595 if (!item) {
596 return false;
597 }
598
599 String* empty = ValueCast<String>(out_resource->value.get());
600 if (empty && *empty->value == "") {
601 // If no inner element exists, represent a unique identifier
602 out_resource->value = util::make_unique<Id>();
603 } else {
y9efbbef2018-04-18 11:29:09 -0700604 Reference* ref = ValueCast<Reference>(out_resource->value.get());
Ryan Mitchelleaf77e12018-04-25 15:00:50 -0700605 if (ref && !ref->name && !ref->id) {
606 // A null reference also means there is no inner element when ids are in the form:
607 // <id name="name"/>
608 out_resource->value = util::make_unique<Id>();
609 } else if (!ref || ref->name.value().type != ResourceType::kId) {
610 // If an inner element exists, the inner element must be a reference to another resource id
y9efbbef2018-04-18 11:29:09 -0700611 diag_->Error(DiagMessage(out_resource->source)
612 << "<" << parser->element_name()
613 << "> inner element must either be a resource reference or empty");
614 return false;
615 }
616 }
617
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700618 return true;
619 }
620
Adam Lesinski86d67df2017-01-31 13:47:27 -0800621 if (can_be_item) {
622 const auto item_iter = elToItemMap.find(resource_type);
623 if (item_iter != elToItemMap.end()) {
624 // This is an item, record its type and format and start parsing.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700625
Adam Lesinski86d67df2017-01-31 13:47:27 -0800626 if (!maybe_name) {
627 diag_->Error(DiagMessage(out_resource->source)
628 << "<" << parser->element_name() << "> missing 'name' attribute");
629 return false;
630 }
631
632 out_resource->name.type = item_iter->second.type;
633 out_resource->name.entry = maybe_name.value().to_string();
634
Adam Lesinskie597d682017-06-01 17:16:44 -0700635 // Only use the implied format of the type when there is no explicit format.
636 if (resource_format == 0u) {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800637 resource_format = item_iter->second.format;
638 }
639
640 if (!ParseItem(parser, out_resource, resource_format)) {
641 return false;
642 }
643 return true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700644 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700645 }
646
647 // This might be a bag or something.
Adam Lesinski86d67df2017-01-31 13:47:27 -0800648 if (can_be_bag) {
649 const auto bag_iter = elToBagMap.find(resource_type);
650 if (bag_iter != elToBagMap.end()) {
651 // Ensure we have a name (unless this is a <public-group>).
Adam Lesinski46c4d722017-08-23 13:03:56 -0700652 if (resource_type != "public-group" && resource_type != "overlayable") {
Adam Lesinski86d67df2017-01-31 13:47:27 -0800653 if (!maybe_name) {
654 diag_->Error(DiagMessage(out_resource->source)
655 << "<" << parser->element_name() << "> missing 'name' attribute");
656 return false;
657 }
658
659 out_resource->name.entry = maybe_name.value().to_string();
660 }
661
662 // Call the associated parse method. The type will be filled in by the
663 // parse func.
664 if (!bag_iter->second(this, parser, out_resource)) {
665 return false;
666 }
667 return true;
668 }
669 }
670
671 if (can_be_item) {
672 // Try parsing the elementName (or type) as a resource. These shall only be
673 // resources like 'layout' or 'xml' and they can only be references.
674 const ResourceType* parsed_type = ParseResourceType(resource_type);
675 if (parsed_type) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700676 if (!maybe_name) {
677 diag_->Error(DiagMessage(out_resource->source)
678 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700679 << "> missing 'name' attribute");
680 return false;
681 }
682
Adam Lesinski86d67df2017-01-31 13:47:27 -0800683 out_resource->name.type = *parsed_type;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800684 out_resource->name.entry = maybe_name.value().to_string();
Adam Lesinski86d67df2017-01-31 13:47:27 -0800685 out_resource->value = ParseXml(parser, android::ResTable_map::TYPE_REFERENCE, kNoRawString);
686 if (!out_resource->value) {
687 diag_->Error(DiagMessage(out_resource->source)
688 << "invalid value for type '" << *parsed_type << "'. Expected a reference");
689 return false;
690 }
691 return true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700692 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700693 }
694
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700695 diag_->Warn(DiagMessage(out_resource->source)
696 << "unknown resource type '" << parser->element_name() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700697 return false;
698}
699
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700700bool ResourceParser::ParseItem(xml::XmlPullParser* parser,
701 ParsedResource* out_resource,
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700702 const uint32_t format) {
703 if (format == android::ResTable_map::TYPE_STRING) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700704 return ParseString(parser, out_resource);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700705 }
706
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700707 out_resource->value = ParseXml(parser, format, kNoRawString);
708 if (!out_resource->value) {
709 diag_->Error(DiagMessage(out_resource->source) << "invalid "
710 << out_resource->name.type);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700711 return false;
712 }
713 return true;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800714}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800715
716/**
717 * Reads the entire XML subtree and attempts to parse it as some Item,
718 * with typeMask denoting which items it can be. If allowRawValue is
719 * true, a RawString is returned if the XML couldn't be parsed as
720 * an Item. If allowRawValue is false, nullptr is returned in this
721 * case.
722 */
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700723std::unique_ptr<Item> ResourceParser::ParseXml(xml::XmlPullParser* parser,
724 const uint32_t type_mask,
725 const bool allow_raw_value) {
726 const size_t begin_xml_line = parser->line_number();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800727
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700728 std::string raw_value;
729 StyleString style_string;
Adam Lesinski75421622017-01-06 15:20:04 -0800730 std::vector<UntranslatableSection> untranslatable_sections;
731 if (!FlattenXmlSubtree(parser, &raw_value, &style_string, &untranslatable_sections)) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800732 return {};
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700733 }
734
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700735 if (!style_string.spans.empty()) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700736 // This can only be a StyledString.
Adam Lesinski75421622017-01-06 15:20:04 -0800737 std::unique_ptr<StyledString> styled_string =
738 util::make_unique<StyledString>(table_->string_pool.MakeRef(
Adam Lesinski060b53d2017-07-28 17:10:35 -0700739 style_string, StringPool::Context(StringPool::Context::kNormalPriority, config_)));
Adam Lesinski75421622017-01-06 15:20:04 -0800740 styled_string->untranslatable_sections = std::move(untranslatable_sections);
741 return std::move(styled_string);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700742 }
743
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700744 auto on_create_reference = [&](const ResourceName& name) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700745 // name.package can be empty here, as it will assume the package name of the
746 // table.
747 std::unique_ptr<Id> id = util::make_unique<Id>();
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700748 id->SetSource(source_.WithLine(begin_xml_line));
749 table_->AddResource(name, {}, {}, std::move(id), diag_);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700750 };
751
752 // Process the raw value.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700753 std::unique_ptr<Item> processed_item =
Adam Lesinski71be7052017-12-12 16:48:07 -0800754 ResourceUtils::TryParseItemForAttribute(raw_value, type_mask, on_create_reference);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700755 if (processed_item) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700756 // Fix up the reference.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700757 if (Reference* ref = ValueCast<Reference>(processed_item.get())) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -0700758 ResolvePackage(parser, ref);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700759 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700760 return processed_item;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700761 }
762
763 // Try making a regular string.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700764 if (type_mask & android::ResTable_map::TYPE_STRING) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700765 // Use the trimmed, escaped string.
Adam Lesinski75421622017-01-06 15:20:04 -0800766 std::unique_ptr<String> string = util::make_unique<String>(
767 table_->string_pool.MakeRef(style_string.str, StringPool::Context(config_)));
768 string->untranslatable_sections = std::move(untranslatable_sections);
769 return std::move(string);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700770 }
771
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700772 // If the text is empty, and the value is not allowed to be a string, encode it as a @null.
773 if (util::TrimWhitespace(raw_value).empty()) {
774 return ResourceUtils::MakeNull();
775 }
776
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700777 if (allow_raw_value) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700778 // We can't parse this so return a RawString if we are allowed.
779 return util::make_unique<RawString>(
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700780 table_->string_pool.MakeRef(raw_value, StringPool::Context(config_)));
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700781 }
782 return {};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800783}
784
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700785bool ResourceParser::ParseString(xml::XmlPullParser* parser,
786 ParsedResource* out_resource) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700787 bool formatted = true;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700788 if (Maybe<StringPiece> formatted_attr =
789 xml::FindAttribute(parser, "formatted")) {
790 Maybe<bool> maybe_formatted =
791 ResourceUtils::ParseBool(formatted_attr.value());
792 if (!maybe_formatted) {
793 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700794 << "invalid value for 'formatted'. Must be a boolean");
795 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800796 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700797 formatted = maybe_formatted.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700798 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800799
Adam Lesinski75421622017-01-06 15:20:04 -0800800 bool translatable = options_.translatable;
801 if (Maybe<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) {
802 Maybe<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value());
803 if (!maybe_translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700804 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700805 << "invalid value for 'translatable'. Must be a boolean");
806 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800807 }
Adam Lesinski75421622017-01-06 15:20:04 -0800808 translatable = maybe_translatable.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700809 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800810
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700811 out_resource->value =
812 ParseXml(parser, android::ResTable_map::TYPE_STRING, kNoRawString);
813 if (!out_resource->value) {
814 diag_->Error(DiagMessage(out_resource->source) << "not a valid string");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700815 return false;
816 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800817
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700818 if (String* string_value = ValueCast<String>(out_resource->value.get())) {
Adam Lesinski75421622017-01-06 15:20:04 -0800819 string_value->SetTranslatable(translatable);
Adam Lesinski393b5f02015-12-17 13:03:11 -0800820
Adam Lesinski75421622017-01-06 15:20:04 -0800821 if (formatted && translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700822 if (!util::VerifyJavaStringFormat(*string_value->value)) {
823 DiagMessage msg(out_resource->source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700824 msg << "multiple substitutions specified in non-positional format; "
825 "did you mean to add the formatted=\"false\" attribute?";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700826 if (options_.error_on_positional_arguments) {
827 diag_->Error(msg);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700828 return false;
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800829 }
Adam Lesinski393b5f02015-12-17 13:03:11 -0800830
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700831 diag_->Warn(msg);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700832 }
Adam Lesinskib23f1e02015-11-03 12:24:17 -0800833 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700834
Adam Lesinski75421622017-01-06 15:20:04 -0800835 } else if (StyledString* string_value = ValueCast<StyledString>(out_resource->value.get())) {
836 string_value->SetTranslatable(translatable);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700837 }
838 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800839}
840
Adam Lesinski71be7052017-12-12 16:48:07 -0800841bool ResourceParser::ParsePublic(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100842 if (options_.visibility) {
843 diag_->Error(DiagMessage(out_resource->source)
844 << "<public> tag not allowed with --visibility flag");
845 return false;
846 }
847
Adam Lesinski46c4d722017-08-23 13:03:56 -0700848 if (out_resource->config != ConfigDescription::DefaultConfig()) {
849 diag_->Warn(DiagMessage(out_resource->source)
850 << "ignoring configuration '" << out_resource->config << "' for <public> tag");
851 }
852
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700853 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
854 if (!maybe_type) {
855 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700856 << "<public> must have a 'type' attribute");
857 return false;
858 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800859
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700860 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
861 if (!parsed_type) {
862 diag_->Error(DiagMessage(out_resource->source) << "invalid resource type '"
863 << maybe_type.value()
864 << "' in <public>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700865 return false;
866 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800867
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700868 out_resource->name.type = *parsed_type;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800869
Adam Lesinskiceb9b2f2017-02-16 12:05:42 -0800870 if (Maybe<StringPiece> maybe_id_str = xml::FindNonEmptyAttribute(parser, "id")) {
871 Maybe<ResourceId> maybe_id = ResourceUtils::ParseResourceId(maybe_id_str.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700872 if (!maybe_id) {
Adam Lesinskiceb9b2f2017-02-16 12:05:42 -0800873 diag_->Error(DiagMessage(out_resource->source)
874 << "invalid resource ID '" << maybe_id_str.value() << "' in <public>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700875 return false;
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800876 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700877 out_resource->id = maybe_id.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700878 }
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800879
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700880 if (*parsed_type == ResourceType::kId) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700881 // An ID marked as public is also the definition of an ID.
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700882 out_resource->value = util::make_unique<Id>();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700883 }
Adam Lesinskibf0bd0f2016-06-01 15:31:50 -0700884
Adam Lesinski71be7052017-12-12 16:48:07 -0800885 out_resource->visibility_level = Visibility::Level::kPublic;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700886 return true;
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800887}
888
Adam Lesinski46c4d722017-08-23 13:03:56 -0700889bool ResourceParser::ParsePublicGroup(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +0100890 if (options_.visibility) {
891 diag_->Error(DiagMessage(out_resource->source)
892 << "<public-group> tag not allowed with --visibility flag");
893 return false;
894 }
895
Adam Lesinski46c4d722017-08-23 13:03:56 -0700896 if (out_resource->config != ConfigDescription::DefaultConfig()) {
897 diag_->Warn(DiagMessage(out_resource->source)
898 << "ignoring configuration '" << out_resource->config
899 << "' for <public-group> tag");
900 }
901
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700902 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
903 if (!maybe_type) {
904 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700905 << "<public-group> must have a 'type' attribute");
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800906 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700907 }
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800908
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700909 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
910 if (!parsed_type) {
911 diag_->Error(DiagMessage(out_resource->source) << "invalid resource type '"
912 << maybe_type.value()
913 << "' in <public-group>");
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800914 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700915 }
916
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700917 Maybe<StringPiece> maybe_id_str =
918 xml::FindNonEmptyAttribute(parser, "first-id");
919 if (!maybe_id_str) {
920 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700921 << "<public-group> must have a 'first-id' attribute");
922 return false;
923 }
924
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700925 Maybe<ResourceId> maybe_id =
926 ResourceUtils::ParseResourceId(maybe_id_str.value());
927 if (!maybe_id) {
928 diag_->Error(DiagMessage(out_resource->source) << "invalid resource ID '"
929 << maybe_id_str.value()
930 << "' in <public-group>");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700931 return false;
932 }
933
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700934 ResourceId next_id = maybe_id.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700935
936 std::string comment;
937 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700938 const size_t depth = parser->depth();
939 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
940 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -0800941 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700942 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700943 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700944 // Skip text.
945 continue;
946 }
947
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700948 const Source item_source = source_.WithLine(parser->line_number());
949 const std::string& element_namespace = parser->element_namespace();
950 const std::string& element_name = parser->element_name();
951 if (element_namespace.empty() && element_name == "public") {
952 Maybe<StringPiece> maybe_name =
953 xml::FindNonEmptyAttribute(parser, "name");
954 if (!maybe_name) {
955 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700956 << "<public> must have a 'name' attribute");
957 error = true;
958 continue;
959 }
960
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700961 if (xml::FindNonEmptyAttribute(parser, "id")) {
962 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700963 << "'id' is ignored within <public-group>");
964 error = true;
965 continue;
966 }
967
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700968 if (xml::FindNonEmptyAttribute(parser, "type")) {
969 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700970 << "'type' is ignored within <public-group>");
971 error = true;
972 continue;
973 }
974
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700975 ParsedResource child_resource;
976 child_resource.name.type = *parsed_type;
Adam Lesinskid5083f62017-01-16 15:07:21 -0800977 child_resource.name.entry = maybe_name.value().to_string();
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700978 child_resource.id = next_id;
979 child_resource.comment = std::move(comment);
980 child_resource.source = item_source;
Adam Lesinski71be7052017-12-12 16:48:07 -0800981 child_resource.visibility_level = Visibility::Level::kPublic;
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700982 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700983
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700984 next_id.id += 1;
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700985
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700986 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
987 diag_->Error(DiagMessage(item_source) << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700988 error = true;
989 }
990 }
991 return !error;
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800992}
993
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700994bool ResourceParser::ParseSymbolImpl(xml::XmlPullParser* parser,
995 ParsedResource* out_resource) {
996 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
997 if (!maybe_type) {
998 diag_->Error(DiagMessage(out_resource->source)
999 << "<" << parser->element_name()
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001000 << "> must have a 'type' attribute");
1001 return false;
1002 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001003
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001004 const ResourceType* parsed_type = ParseResourceType(maybe_type.value());
1005 if (!parsed_type) {
1006 diag_->Error(DiagMessage(out_resource->source)
1007 << "invalid resource type '" << maybe_type.value() << "' in <"
1008 << parser->element_name() << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001009 return false;
1010 }
1011
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001012 out_resource->name.type = *parsed_type;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001013 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001014}
1015
Adam Lesinski46c4d722017-08-23 13:03:56 -07001016bool ResourceParser::ParseSymbol(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001017 if (options_.visibility) {
1018 diag_->Error(DiagMessage(out_resource->source)
1019 << "<java-symbol> and <symbol> tags not allowed with --visibility flag");
1020 return false;
1021 }
Adam Lesinski46c4d722017-08-23 13:03:56 -07001022 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1023 diag_->Warn(DiagMessage(out_resource->source)
1024 << "ignoring configuration '" << out_resource->config << "' for <"
1025 << parser->element_name() << "> tag");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001026 }
Adam Lesinski46c4d722017-08-23 13:03:56 -07001027
1028 if (!ParseSymbolImpl(parser, out_resource)) {
1029 return false;
1030 }
1031
Adam Lesinski71be7052017-12-12 16:48:07 -08001032 out_resource->visibility_level = Visibility::Level::kPrivate;
Adam Lesinski46c4d722017-08-23 13:03:56 -07001033 return true;
1034}
1035
1036bool ResourceParser::ParseOverlayable(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1037 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1038 diag_->Warn(DiagMessage(out_resource->source)
1039 << "ignoring configuration '" << out_resource->config << "' for <overlayable> tag");
1040 }
1041
1042 if (Maybe<StringPiece> maybe_policy = xml::FindNonEmptyAttribute(parser, "policy")) {
1043 const StringPiece& policy = maybe_policy.value();
1044 if (policy != "system") {
1045 diag_->Error(DiagMessage(out_resource->source)
1046 << "<overlayable> has invalid policy '" << policy << "'");
1047 return false;
1048 }
1049 }
1050
1051 bool error = false;
1052 const size_t depth = parser->depth();
1053 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1054 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
1055 // Skip text/comments.
1056 continue;
1057 }
1058
1059 const Source item_source = source_.WithLine(parser->line_number());
1060 const std::string& element_namespace = parser->element_namespace();
1061 const std::string& element_name = parser->element_name();
1062 if (element_namespace.empty() && element_name == "item") {
1063 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
1064 if (!maybe_name) {
1065 diag_->Error(DiagMessage(item_source)
1066 << "<item> within an <overlayable> tag must have a 'name' attribute");
1067 error = true;
1068 continue;
1069 }
1070
1071 Maybe<StringPiece> maybe_type = xml::FindNonEmptyAttribute(parser, "type");
1072 if (!maybe_type) {
1073 diag_->Error(DiagMessage(item_source)
1074 << "<item> within an <overlayable> tag must have a 'type' attribute");
1075 error = true;
1076 continue;
1077 }
1078
1079 const ResourceType* type = ParseResourceType(maybe_type.value());
1080 if (type == nullptr) {
1081 diag_->Error(DiagMessage(out_resource->source)
1082 << "invalid resource type '" << maybe_type.value()
1083 << "' in <item> within an <overlayable>");
1084 error = true;
1085 continue;
1086 }
1087
Adam Lesinski71be7052017-12-12 16:48:07 -08001088 ParsedResource child_resource;
1089 child_resource.name.type = *type;
1090 child_resource.name.entry = maybe_name.value().to_string();
1091 child_resource.source = item_source;
1092 child_resource.overlayable = true;
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001093 if (options_.visibility) {
1094 child_resource.visibility_level = options_.visibility.value();
1095 }
Adam Lesinski71be7052017-12-12 16:48:07 -08001096 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinski46c4d722017-08-23 13:03:56 -07001097
1098 xml::XmlPullParser::SkipCurrentElement(parser);
1099 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1100 diag_->Error(DiagMessage(item_source) << ":" << element_name << ">");
1101 error = true;
1102 }
1103 }
1104 return !error;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001105}
1106
Adam Lesinski71be7052017-12-12 16:48:07 -08001107bool ResourceParser::ParseAddResource(xml::XmlPullParser* parser, ParsedResource* out_resource) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001108 if (ParseSymbolImpl(parser, out_resource)) {
Adam Lesinski71be7052017-12-12 16:48:07 -08001109 out_resource->visibility_level = Visibility::Level::kUndefined;
Adam Lesinski4488f1c2017-05-26 17:33:38 -07001110 out_resource->allow_new = true;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001111 return true;
1112 }
1113 return false;
1114}
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001115
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001116bool ResourceParser::ParseAttr(xml::XmlPullParser* parser,
1117 ParsedResource* out_resource) {
1118 return ParseAttrImpl(parser, out_resource, false);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001119}
1120
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001121bool ResourceParser::ParseAttrImpl(xml::XmlPullParser* parser,
1122 ParsedResource* out_resource, bool weak) {
1123 out_resource->name.type = ResourceType::kAttr;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001124
1125 // Attributes only end up in default configuration.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001126 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1127 diag_->Warn(DiagMessage(out_resource->source)
1128 << "ignoring configuration '" << out_resource->config
1129 << "' for attribute " << out_resource->name);
1130 out_resource->config = ConfigDescription::DefaultConfig();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001131 }
1132
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001133 uint32_t type_mask = 0;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001134
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001135 Maybe<StringPiece> maybe_format = xml::FindAttribute(parser, "format");
1136 if (maybe_format) {
1137 type_mask = ParseFormatAttribute(maybe_format.value());
1138 if (type_mask == 0) {
1139 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001140 << "invalid attribute format '" << maybe_format.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001141 return false;
1142 }
1143 }
1144
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001145 Maybe<int32_t> maybe_min, maybe_max;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001146
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001147 if (Maybe<StringPiece> maybe_min_str = xml::FindAttribute(parser, "min")) {
1148 StringPiece min_str = util::TrimWhitespace(maybe_min_str.value());
1149 if (!min_str.empty()) {
1150 std::u16string min_str16 = util::Utf8ToUtf16(min_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001151 android::Res_value value;
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001152 if (android::ResTable::stringToInt(min_str16.data(), min_str16.size(), &value)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001153 maybe_min = static_cast<int32_t>(value.data);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001154 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001155 }
1156
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001157 if (!maybe_min) {
1158 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1159 << "invalid 'min' value '" << min_str << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001160 return false;
1161 }
1162 }
1163
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001164 if (Maybe<StringPiece> maybe_max_str = xml::FindAttribute(parser, "max")) {
1165 StringPiece max_str = util::TrimWhitespace(maybe_max_str.value());
1166 if (!max_str.empty()) {
1167 std::u16string max_str16 = util::Utf8ToUtf16(max_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001168 android::Res_value value;
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001169 if (android::ResTable::stringToInt(max_str16.data(), max_str16.size(), &value)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001170 maybe_max = static_cast<int32_t>(value.data);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001171 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001172 }
1173
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001174 if (!maybe_max) {
1175 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1176 << "invalid 'max' value '" << max_str << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001177 return false;
1178 }
1179 }
1180
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001181 if ((maybe_min || maybe_max) &&
1182 (type_mask & android::ResTable_map::TYPE_INTEGER) == 0) {
1183 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001184 << "'min' and 'max' can only be used when format='integer'");
1185 return false;
1186 }
1187
1188 struct SymbolComparator {
Yi Kong087e2d42017-05-02 12:49:25 -07001189 bool operator()(const Attribute::Symbol& a, const Attribute::Symbol& b) const {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001190 return a.symbol.name.value() < b.symbol.name.value();
1191 }
1192 };
1193
1194 std::set<Attribute::Symbol, SymbolComparator> items;
1195
1196 std::string comment;
1197 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001198 const size_t depth = parser->depth();
1199 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1200 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -08001201 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001202 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001203 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001204 // Skip text.
1205 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001206 }
1207
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001208 const Source item_source = source_.WithLine(parser->line_number());
1209 const std::string& element_namespace = parser->element_namespace();
1210 const std::string& element_name = parser->element_name();
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001211 if (element_namespace.empty() && (element_name == "flag" || element_name == "enum")) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001212 if (element_name == "enum") {
1213 if (type_mask & android::ResTable_map::TYPE_FLAGS) {
1214 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001215 << "can not define an <enum>; already defined a <flag>");
1216 error = true;
1217 continue;
1218 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001219 type_mask |= android::ResTable_map::TYPE_ENUM;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001220
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001221 } else if (element_name == "flag") {
1222 if (type_mask & android::ResTable_map::TYPE_ENUM) {
1223 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001224 << "can not define a <flag>; already defined an <enum>");
1225 error = true;
1226 continue;
1227 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001228 type_mask |= android::ResTable_map::TYPE_FLAGS;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001229 }
1230
1231 if (Maybe<Attribute::Symbol> s =
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001232 ParseEnumOrFlagItem(parser, element_name)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001233 Attribute::Symbol& symbol = s.value();
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001234 ParsedResource child_resource;
1235 child_resource.name = symbol.symbol.name.value();
1236 child_resource.source = item_source;
1237 child_resource.value = util::make_unique<Id>();
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001238 if (options_.visibility) {
1239 child_resource.visibility_level = options_.visibility.value();
1240 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001241 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001242
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001243 symbol.symbol.SetComment(std::move(comment));
1244 symbol.symbol.SetSource(item_source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001245
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001246 auto insert_result = items.insert(std::move(symbol));
1247 if (!insert_result.second) {
1248 const Attribute::Symbol& existing_symbol = *insert_result.first;
1249 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001250 << "duplicate symbol '"
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001251 << existing_symbol.symbol.name.value().entry << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001252
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001253 diag_->Note(DiagMessage(existing_symbol.symbol.GetSource())
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001254 << "first defined here");
1255 error = true;
1256 }
1257 } else {
1258 error = true;
1259 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001260 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1261 diag_->Error(DiagMessage(item_source) << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001262 error = true;
1263 }
1264
1265 comment = {};
1266 }
1267
1268 if (error) {
1269 return false;
1270 }
1271
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001272 std::unique_ptr<Attribute> attr = util::make_unique<Attribute>(
1273 type_mask ? type_mask : uint32_t{android::ResTable_map::TYPE_ANY});
1274 attr->SetWeak(weak);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001275 attr->symbols = std::vector<Attribute::Symbol>(items.begin(), items.end());
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001276 attr->min_int = maybe_min.value_or_default(std::numeric_limits<int32_t>::min());
1277 attr->max_int = maybe_max.value_or_default(std::numeric_limits<int32_t>::max());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001278 out_resource->value = std::move(attr);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001279 return true;
1280}
1281
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001282Maybe<Attribute::Symbol> ResourceParser::ParseEnumOrFlagItem(
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001283 xml::XmlPullParser* parser, const StringPiece& tag) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001284 const Source source = source_.WithLine(parser->line_number());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001285
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001286 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
1287 if (!maybe_name) {
1288 diag_->Error(DiagMessage(source) << "no attribute 'name' found for tag <"
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001289 << tag << ">");
1290 return {};
1291 }
1292
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001293 Maybe<StringPiece> maybe_value = xml::FindNonEmptyAttribute(parser, "value");
1294 if (!maybe_value) {
1295 diag_->Error(DiagMessage(source) << "no attribute 'value' found for tag <"
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001296 << tag << ">");
1297 return {};
1298 }
1299
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001300 std::u16string value16 = util::Utf8ToUtf16(maybe_value.value());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001301 android::Res_value val;
1302 if (!android::ResTable::stringToInt(value16.data(), value16.size(), &val)) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001303 diag_->Error(DiagMessage(source) << "invalid value '" << maybe_value.value()
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001304 << "' for <" << tag
1305 << ">; must be an integer");
1306 return {};
1307 }
1308
1309 return Attribute::Symbol{
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001310 Reference(ResourceNameRef({}, ResourceType::kId, maybe_name.value())),
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001311 val.data};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001312}
1313
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001314bool ResourceParser::ParseStyleItem(xml::XmlPullParser* parser, Style* style) {
1315 const Source source = source_.WithLine(parser->line_number());
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001316
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001317 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
1318 if (!maybe_name) {
1319 diag_->Error(DiagMessage(source) << "<item> must have a 'name' attribute");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001320 return false;
1321 }
1322
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001323 Maybe<Reference> maybe_key = ResourceUtils::ParseXmlAttributeName(maybe_name.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001324 if (!maybe_key) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001325 diag_->Error(DiagMessage(source) << "invalid attribute name '" << maybe_name.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001326 return false;
1327 }
1328
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001329 ResolvePackage(parser, &maybe_key.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001330 maybe_key.value().SetSource(source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001331
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001332 std::unique_ptr<Item> value = ParseXml(parser, 0, kAllowRawString);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001333 if (!value) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001334 diag_->Error(DiagMessage(source) << "could not parse style item");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001335 return false;
1336 }
1337
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001338 style->entries.push_back(Style::Entry{std::move(maybe_key.value()), std::move(value)});
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001339 return true;
1340}
1341
Adam Lesinski86d67df2017-01-31 13:47:27 -08001342bool ResourceParser::ParseStyle(const ResourceType type, xml::XmlPullParser* parser,
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001343 ParsedResource* out_resource) {
Adam Lesinski86d67df2017-01-31 13:47:27 -08001344 out_resource->name.type = type;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001345
1346 std::unique_ptr<Style> style = util::make_unique<Style>();
1347
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001348 Maybe<StringPiece> maybe_parent = xml::FindAttribute(parser, "parent");
1349 if (maybe_parent) {
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001350 // If the parent is empty, we don't have a parent, but we also don't infer either.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001351 if (!maybe_parent.value().empty()) {
1352 std::string err_str;
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001353 style->parent = ResourceUtils::ParseStyleParentReference(maybe_parent.value(), &err_str);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001354 if (!style->parent) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001355 diag_->Error(DiagMessage(out_resource->source) << err_str);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001356 return false;
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001357 }
1358
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001359 // Transform the namespace prefix to the actual package name, and mark the reference as
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001360 // private if appropriate.
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001361 ResolvePackage(parser, &style->parent.value());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001362 }
1363
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001364 } else {
1365 // No parent was specified, so try inferring it from the style name.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001366 std::string style_name = out_resource->name.entry;
1367 size_t pos = style_name.find_last_of(u'.');
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001368 if (pos != std::string::npos) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001369 style->parent_inferred = true;
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001370 style->parent = Reference(ResourceName({}, ResourceType::kStyle, style_name.substr(0, pos)));
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001371 }
1372 }
1373
1374 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001375 const size_t depth = parser->depth();
1376 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1377 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001378 // Skip text and comments.
1379 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001380 }
1381
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001382 const std::string& element_namespace = parser->element_namespace();
1383 const std::string& element_name = parser->element_name();
1384 if (element_namespace == "" && element_name == "item") {
1385 error |= !ParseStyleItem(parser, style.get());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001386
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001387 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1388 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1389 << ":" << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001390 error = true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001391 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001392 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001393
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001394 if (error) {
1395 return false;
1396 }
1397
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001398 out_resource->value = std::move(style);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001399 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001400}
1401
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001402bool ResourceParser::ParseArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1403 uint32_t resource_format = android::ResTable_map::TYPE_ANY;
1404 if (Maybe<StringPiece> format_attr = xml::FindNonEmptyAttribute(parser, "format")) {
1405 resource_format = ParseFormatTypeNoEnumsOrFlags(format_attr.value());
1406 if (resource_format == 0u) {
1407 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1408 << "'" << format_attr.value() << "' is an invalid format");
1409 return false;
1410 }
1411 }
1412 return ParseArrayImpl(parser, out_resource, resource_format);
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001413}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001414
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001415bool ResourceParser::ParseIntegerArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1416 return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_INTEGER);
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001417}
1418
Adam Lesinskid5fd76a2017-05-16 12:18:08 -07001419bool ResourceParser::ParseStringArray(xml::XmlPullParser* parser, ParsedResource* out_resource) {
1420 return ParseArrayImpl(parser, out_resource, android::ResTable_map::TYPE_STRING);
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001421}
1422
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001423bool ResourceParser::ParseArrayImpl(xml::XmlPullParser* parser,
1424 ParsedResource* out_resource,
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001425 const uint32_t typeMask) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001426 out_resource->name.type = ResourceType::kArray;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001427
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001428 std::unique_ptr<Array> array = util::make_unique<Array>();
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001429
Adam Lesinski75421622017-01-06 15:20:04 -08001430 bool translatable = options_.translatable;
1431 if (Maybe<StringPiece> translatable_attr = xml::FindAttribute(parser, "translatable")) {
1432 Maybe<bool> maybe_translatable = ResourceUtils::ParseBool(translatable_attr.value());
1433 if (!maybe_translatable) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001434 diag_->Error(DiagMessage(out_resource->source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001435 << "invalid value for 'translatable'. Must be a boolean");
1436 return false;
Adam Lesinski458b8772016-04-25 14:20:21 -07001437 }
Adam Lesinski75421622017-01-06 15:20:04 -08001438 translatable = maybe_translatable.value();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001439 }
Adam Lesinski75421622017-01-06 15:20:04 -08001440 array->SetTranslatable(translatable);
Adam Lesinski458b8772016-04-25 14:20:21 -07001441
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001442 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001443 const size_t depth = parser->depth();
1444 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1445 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001446 // Skip text and comments.
1447 continue;
Adam Lesinski1ab598f2015-08-14 14:26:04 -07001448 }
1449
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001450 const Source item_source = source_.WithLine(parser->line_number());
1451 const std::string& element_namespace = parser->element_namespace();
1452 const std::string& element_name = parser->element_name();
1453 if (element_namespace.empty() && element_name == "item") {
1454 std::unique_ptr<Item> item = ParseXml(parser, typeMask, kNoRawString);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001455 if (!item) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001456 diag_->Error(DiagMessage(item_source) << "could not parse array item");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001457 error = true;
1458 continue;
1459 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001460 item->SetSource(item_source);
Adam Lesinski4ffea042017-08-10 15:37:28 -07001461 array->elements.emplace_back(std::move(item));
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001462
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001463 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1464 diag_->Error(DiagMessage(source_.WithLine(parser->line_number()))
1465 << "unknown tag <" << element_namespace << ":"
1466 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001467 error = true;
1468 }
1469 }
1470
1471 if (error) {
1472 return false;
1473 }
1474
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001475 out_resource->value = std::move(array);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001476 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001477}
1478
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001479bool ResourceParser::ParsePlural(xml::XmlPullParser* parser,
1480 ParsedResource* out_resource) {
1481 out_resource->name.type = ResourceType::kPlurals;
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001482
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001483 std::unique_ptr<Plural> plural = util::make_unique<Plural>();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001484
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001485 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001486 const size_t depth = parser->depth();
1487 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1488 if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001489 // Skip text and comments.
1490 continue;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001491 }
1492
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001493 const Source item_source = source_.WithLine(parser->line_number());
1494 const std::string& element_namespace = parser->element_namespace();
1495 const std::string& element_name = parser->element_name();
1496 if (element_namespace.empty() && element_name == "item") {
1497 Maybe<StringPiece> maybe_quantity =
1498 xml::FindNonEmptyAttribute(parser, "quantity");
1499 if (!maybe_quantity) {
1500 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001501 << "<item> in <plurals> requires attribute "
1502 << "'quantity'");
1503 error = true;
1504 continue;
1505 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001506
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001507 StringPiece trimmed_quantity =
1508 util::TrimWhitespace(maybe_quantity.value());
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001509 size_t index = 0;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001510 if (trimmed_quantity == "zero") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001511 index = Plural::Zero;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001512 } else if (trimmed_quantity == "one") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001513 index = Plural::One;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001514 } else if (trimmed_quantity == "two") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001515 index = Plural::Two;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001516 } else if (trimmed_quantity == "few") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001517 index = Plural::Few;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001518 } else if (trimmed_quantity == "many") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001519 index = Plural::Many;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001520 } else if (trimmed_quantity == "other") {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001521 index = Plural::Other;
1522 } else {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001523 diag_->Error(DiagMessage(item_source)
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001524 << "<item> in <plural> has invalid value '"
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001525 << trimmed_quantity << "' for attribute 'quantity'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001526 error = true;
1527 continue;
1528 }
1529
1530 if (plural->values[index]) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001531 diag_->Error(DiagMessage(item_source) << "duplicate quantity '"
1532 << trimmed_quantity << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001533 error = true;
1534 continue;
1535 }
1536
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001537 if (!(plural->values[index] = ParseXml(
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001538 parser, android::ResTable_map::TYPE_STRING, kNoRawString))) {
1539 error = true;
1540 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001541 plural->values[index]->SetSource(item_source);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001542
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001543 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1544 diag_->Error(DiagMessage(item_source) << "unknown tag <"
1545 << element_namespace << ":"
1546 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001547 error = true;
1548 }
1549 }
1550
1551 if (error) {
1552 return false;
1553 }
1554
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001555 out_resource->value = std::move(plural);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001556 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001557}
1558
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001559bool ResourceParser::ParseDeclareStyleable(xml::XmlPullParser* parser,
1560 ParsedResource* out_resource) {
1561 out_resource->name.type = ResourceType::kStyleable;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001562
Adam Lesinski71be7052017-12-12 16:48:07 -08001563 // Declare-styleable is kPrivate by default, because it technically only exists in R.java.
1564 out_resource->visibility_level = Visibility::Level::kPublic;
Adam Lesinski9f222042015-11-04 13:51:45 -08001565
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001566 // Declare-styleable only ends up in default config;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001567 if (out_resource->config != ConfigDescription::DefaultConfig()) {
1568 diag_->Warn(DiagMessage(out_resource->source)
1569 << "ignoring configuration '" << out_resource->config
1570 << "' for styleable " << out_resource->name.entry);
1571 out_resource->config = ConfigDescription::DefaultConfig();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001572 }
1573
1574 std::unique_ptr<Styleable> styleable = util::make_unique<Styleable>();
1575
1576 std::string comment;
1577 bool error = false;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001578 const size_t depth = parser->depth();
1579 while (xml::XmlPullParser::NextChildNode(parser, depth)) {
1580 if (parser->event() == xml::XmlPullParser::Event::kComment) {
Adam Lesinskid5083f62017-01-16 15:07:21 -08001581 comment = util::TrimWhitespace(parser->comment()).to_string();
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001582 continue;
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001583 } else if (parser->event() != xml::XmlPullParser::Event::kStartElement) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001584 // Ignore text.
1585 continue;
Adam Lesinski52364f72016-01-11 13:10:24 -08001586 }
1587
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001588 const Source item_source = source_.WithLine(parser->line_number());
1589 const std::string& element_namespace = parser->element_namespace();
1590 const std::string& element_name = parser->element_name();
1591 if (element_namespace.empty() && element_name == "attr") {
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001592 Maybe<StringPiece> maybe_name = xml::FindNonEmptyAttribute(parser, "name");
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001593 if (!maybe_name) {
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001594 diag_->Error(DiagMessage(item_source) << "<attr> tag must have a 'name' attribute");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001595 error = true;
1596 continue;
1597 }
Adam Lesinski7ff3ee12015-12-14 16:08:50 -08001598
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001599 // If this is a declaration, the package name may be in the name. Separate
1600 // these out.
1601 // Eg. <attr name="android:text" />
Adam Lesinski73bff1e2017-12-08 16:06:10 -08001602 Maybe<Reference> maybe_ref = ResourceUtils::ParseXmlAttributeName(maybe_name.value());
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001603 if (!maybe_ref) {
1604 diag_->Error(DiagMessage(item_source) << "<attr> tag has invalid name '"
1605 << maybe_name.value() << "'");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001606 error = true;
1607 continue;
1608 }
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001609
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001610 Reference& child_ref = maybe_ref.value();
Adam Lesinski1ef0fa92017-08-15 21:32:49 -07001611 xml::ResolvePackage(parser, &child_ref);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001612
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001613 // Create the ParsedResource that will add the attribute to the table.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001614 ParsedResource child_resource;
1615 child_resource.name = child_ref.name.value();
1616 child_resource.source = item_source;
1617 child_resource.comment = std::move(comment);
Izabela Orlowskac7ac3a12018-03-27 14:46:52 +01001618 if (options_.visibility) {
1619 child_resource.visibility_level = options_.visibility.value();
1620 }
Adam Lesinski467f1712015-11-16 17:35:44 -08001621
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001622 if (!ParseAttrImpl(parser, &child_resource, true)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001623 error = true;
1624 continue;
1625 }
Adam Lesinski467f1712015-11-16 17:35:44 -08001626
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001627 // Create the reference to this attribute.
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001628 child_ref.SetComment(child_resource.comment);
1629 child_ref.SetSource(item_source);
1630 styleable->entries.push_back(std::move(child_ref));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001631
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001632 out_resource->child_resources.push_back(std::move(child_resource));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001633
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001634 } else if (!ShouldIgnoreElement(element_namespace, element_name)) {
1635 diag_->Error(DiagMessage(item_source) << "unknown tag <"
1636 << element_namespace << ":"
1637 << element_name << ">");
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001638 error = true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001639 }
1640
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001641 comment = {};
1642 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -07001643
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001644 if (error) {
1645 return false;
1646 }
1647
Adam Lesinskice5e56e2016-10-21 17:56:45 -07001648 out_resource->value = std::move(styleable);
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001649 return true;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001650}
1651
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001652} // namespace aapt