blob: 34837700a29e396f57fc262e3c099c5c43bcb3dc [file] [log] [blame]
Nicolas Geoffray3c049742014-09-24 18:10:46 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "instruction_simplifier.h"
18
Andreas Gampec6ea7d02017-02-01 16:46:28 -080019#include "art_method-inl.h"
20#include "class_linker-inl.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010021#include "data_type-inl.h"
Aart Bik71bf7b42016-11-16 10:17:46 -080022#include "escape.h"
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010023#include "intrinsics.h"
Calin Juravleacf735c2015-02-12 15:25:22 +000024#include "mirror/class-inl.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070025#include "scoped_thread_state_change-inl.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070026#include "sharpening.h"
Calin Juravleacf735c2015-02-12 15:25:22 +000027
Nicolas Geoffray3c049742014-09-24 18:10:46 +010028namespace art {
29
Artem Serovcced8ba2017-07-19 18:18:09 +010030// Whether to run an exhaustive test of individual HInstructions cloning when each instruction
31// is replaced with its copy if it is clonable.
32static constexpr bool kTestInstructionClonerExhaustively = false;
33
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010034class InstructionSimplifierVisitor : public HGraphDelegateVisitor {
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000035 public:
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000036 InstructionSimplifierVisitor(HGraph* graph,
37 CodeGenerator* codegen,
Vladimir Marko65979462017-05-19 17:25:12 +010038 CompilerDriver* compiler_driver,
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000039 OptimizingCompilerStats* stats)
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +010040 : HGraphDelegateVisitor(graph),
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +000041 codegen_(codegen),
Vladimir Marko65979462017-05-19 17:25:12 +010042 compiler_driver_(compiler_driver),
Alexandre Rames188d4312015-04-09 18:30:21 +010043 stats_(stats) {}
44
45 void Run();
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000046
47 private:
Alexandre Rames188d4312015-04-09 18:30:21 +010048 void RecordSimplification() {
49 simplification_occurred_ = true;
50 simplifications_at_current_position_++;
Vladimir Markocd09e1f2017-11-24 15:02:40 +000051 MaybeRecordStat(stats_, MethodCompilationStat::kInstructionSimplifications);
Alexandre Rames188d4312015-04-09 18:30:21 +010052 }
53
Scott Wakeling40a04bf2015-12-11 09:50:36 +000054 bool ReplaceRotateWithRor(HBinaryOperation* op, HUShr* ushr, HShl* shl);
55 bool TryReplaceWithRotate(HBinaryOperation* instruction);
56 bool TryReplaceWithRotateConstantPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
57 bool TryReplaceWithRotateRegisterNegPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
58 bool TryReplaceWithRotateRegisterSubPattern(HBinaryOperation* op, HUShr* ushr, HShl* shl);
59
Alexandre Rames188d4312015-04-09 18:30:21 +010060 bool TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +000061 // `op` should be either HOr or HAnd.
62 // De Morgan's laws:
63 // ~a & ~b = ~(a | b) and ~a | ~b = ~(a & b)
64 bool TryDeMorganNegationFactoring(HBinaryOperation* op);
Anton Kirilove14dc862016-05-13 17:56:15 +010065 bool TryHandleAssociativeAndCommutativeOperation(HBinaryOperation* instruction);
66 bool TrySubtractionChainSimplification(HBinaryOperation* instruction);
Lena Djokicbc5460b2017-07-20 16:07:36 +020067 bool TryCombineVecMultiplyAccumulate(HVecMul* mul);
Anton Kirilove14dc862016-05-13 17:56:15 +010068
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000069 void VisitShift(HBinaryOperation* shift);
70
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000071 void VisitEqual(HEqual* equal) OVERRIDE;
David Brazdil0d13fee2015-04-17 14:52:19 +010072 void VisitNotEqual(HNotEqual* equal) OVERRIDE;
73 void VisitBooleanNot(HBooleanNot* bool_not) OVERRIDE;
Nicolas Geoffray07276db2015-05-18 14:22:09 +010074 void VisitInstanceFieldSet(HInstanceFieldSet* equal) OVERRIDE;
75 void VisitStaticFieldSet(HStaticFieldSet* equal) OVERRIDE;
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +000076 void VisitArraySet(HArraySet* equal) OVERRIDE;
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +000077 void VisitTypeConversion(HTypeConversion* instruction) OVERRIDE;
Calin Juravle10e244f2015-01-26 18:54:32 +000078 void VisitNullCheck(HNullCheck* instruction) OVERRIDE;
Mingyao Yang0304e182015-01-30 16:41:29 -080079 void VisitArrayLength(HArrayLength* instruction) OVERRIDE;
Calin Juravleacf735c2015-02-12 15:25:22 +000080 void VisitCheckCast(HCheckCast* instruction) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000081 void VisitAdd(HAdd* instruction) OVERRIDE;
82 void VisitAnd(HAnd* instruction) OVERRIDE;
Mark Mendellc4701932015-04-10 13:18:51 -040083 void VisitCondition(HCondition* instruction) OVERRIDE;
84 void VisitGreaterThan(HGreaterThan* condition) OVERRIDE;
85 void VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) OVERRIDE;
86 void VisitLessThan(HLessThan* condition) OVERRIDE;
87 void VisitLessThanOrEqual(HLessThanOrEqual* condition) OVERRIDE;
Anton Shaminbdd79352016-02-15 12:48:36 +060088 void VisitBelow(HBelow* condition) OVERRIDE;
89 void VisitBelowOrEqual(HBelowOrEqual* condition) OVERRIDE;
90 void VisitAbove(HAbove* condition) OVERRIDE;
91 void VisitAboveOrEqual(HAboveOrEqual* condition) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000092 void VisitDiv(HDiv* instruction) OVERRIDE;
93 void VisitMul(HMul* instruction) OVERRIDE;
Alexandre Rames188d4312015-04-09 18:30:21 +010094 void VisitNeg(HNeg* instruction) OVERRIDE;
95 void VisitNot(HNot* instruction) OVERRIDE;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +000096 void VisitOr(HOr* instruction) OVERRIDE;
97 void VisitShl(HShl* instruction) OVERRIDE;
98 void VisitShr(HShr* instruction) OVERRIDE;
99 void VisitSub(HSub* instruction) OVERRIDE;
100 void VisitUShr(HUShr* instruction) OVERRIDE;
101 void VisitXor(HXor* instruction) OVERRIDE;
David Brazdil74eb1b22015-12-14 11:44:01 +0000102 void VisitSelect(HSelect* select) OVERRIDE;
103 void VisitIf(HIf* instruction) OVERRIDE;
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100104 void VisitInstanceOf(HInstanceOf* instruction) OVERRIDE;
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +0100105 void VisitInvoke(HInvoke* invoke) OVERRIDE;
Aart Bikbb245d12015-10-19 11:05:03 -0700106 void VisitDeoptimize(HDeoptimize* deoptimize) OVERRIDE;
Lena Djokicbc5460b2017-07-20 16:07:36 +0200107 void VisitVecMul(HVecMul* instruction) OVERRIDE;
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100108
109 bool CanEnsureNotNullAt(HInstruction* instr, HInstruction* at) const;
Calin Juravleacf735c2015-02-12 15:25:22 +0000110
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100111 void SimplifyRotate(HInvoke* invoke, bool is_left, DataType::Type type);
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +0100112 void SimplifySystemArrayCopy(HInvoke* invoke);
113 void SimplifyStringEquals(HInvoke* invoke);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100114 void SimplifyCompare(HInvoke* invoke, bool is_signum, DataType::Type type);
Aart Bik75a38b22016-02-17 10:41:50 -0800115 void SimplifyIsNaN(HInvoke* invoke);
Aart Bik2a6aad92016-02-25 11:32:32 -0800116 void SimplifyFP2Int(HInvoke* invoke);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +0100117 void SimplifyStringCharAt(HInvoke* invoke);
Vladimir Markodce016e2016-04-28 13:10:02 +0100118 void SimplifyStringIsEmptyOrLength(HInvoke* invoke);
Aart Bikff7d89c2016-11-07 08:49:28 -0800119 void SimplifyNPEOnArgN(HInvoke* invoke, size_t);
Aart Bik71bf7b42016-11-16 10:17:46 -0800120 void SimplifyReturnThis(HInvoke* invoke);
121 void SimplifyAllocationIntrinsic(HInvoke* invoke);
Aart Bik11932592016-03-08 12:42:25 -0800122 void SimplifyMemBarrier(HInvoke* invoke, MemBarrierKind barrier_kind);
Aart Bik1f8d51b2018-02-15 10:42:37 -0800123 void SimplifyMin(HInvoke* invoke, DataType::Type type);
124 void SimplifyMax(HInvoke* invoke, DataType::Type type);
Aart Bik3dad3412018-02-28 12:01:46 -0800125 void SimplifyAbs(HInvoke* invoke, DataType::Type type);
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +0100126
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000127 CodeGenerator* codegen_;
Vladimir Marko65979462017-05-19 17:25:12 +0100128 CompilerDriver* compiler_driver_;
Calin Juravleacf735c2015-02-12 15:25:22 +0000129 OptimizingCompilerStats* stats_;
Alexandre Rames188d4312015-04-09 18:30:21 +0100130 bool simplification_occurred_ = false;
131 int simplifications_at_current_position_ = 0;
Aart Bik2767f4b2016-10-28 15:03:53 -0700132 // We ensure we do not loop infinitely. The value should not be too high, since that
133 // would allow looping around the same basic block too many times. The value should
134 // not be too low either, however, since we want to allow revisiting a basic block
135 // with many statements and simplifications at least once.
136 static constexpr int kMaxSamePositionSimplifications = 50;
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000137};
138
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100139void InstructionSimplifier::Run() {
Artem Serovcced8ba2017-07-19 18:18:09 +0100140 if (kTestInstructionClonerExhaustively) {
141 CloneAndReplaceInstructionVisitor visitor(graph_);
142 visitor.VisitReversePostOrder();
143 }
144
Vladimir Marko65979462017-05-19 17:25:12 +0100145 InstructionSimplifierVisitor visitor(graph_, codegen_, compiler_driver_, stats_);
Alexandre Rames188d4312015-04-09 18:30:21 +0100146 visitor.Run();
147}
148
149void InstructionSimplifierVisitor::Run() {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100150 // Iterate in reverse post order to open up more simplifications to users
151 // of instructions that got simplified.
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100152 for (HBasicBlock* block : GetGraph()->GetReversePostOrder()) {
Alexandre Rames188d4312015-04-09 18:30:21 +0100153 // The simplification of an instruction to another instruction may yield
154 // possibilities for other simplifications. So although we perform a reverse
155 // post order visit, we sometimes need to revisit an instruction index.
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100156 do {
157 simplification_occurred_ = false;
158 VisitBasicBlock(block);
159 } while (simplification_occurred_ &&
160 (simplifications_at_current_position_ < kMaxSamePositionSimplifications));
Alexandre Rames188d4312015-04-09 18:30:21 +0100161 simplifications_at_current_position_ = 0;
Alexandre Rames188d4312015-04-09 18:30:21 +0100162 }
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100163}
164
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000165namespace {
166
167bool AreAllBitsSet(HConstant* constant) {
168 return Int64FromConstant(constant) == -1;
169}
170
171} // namespace
172
Alexandre Rames188d4312015-04-09 18:30:21 +0100173// Returns true if the code was simplified to use only one negation operation
174// after the binary operation instead of one on each of the inputs.
175bool InstructionSimplifierVisitor::TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop) {
176 DCHECK(binop->IsAdd() || binop->IsSub());
177 DCHECK(binop->GetLeft()->IsNeg() && binop->GetRight()->IsNeg());
178 HNeg* left_neg = binop->GetLeft()->AsNeg();
179 HNeg* right_neg = binop->GetRight()->AsNeg();
180 if (!left_neg->HasOnlyOneNonEnvironmentUse() ||
181 !right_neg->HasOnlyOneNonEnvironmentUse()) {
182 return false;
183 }
184 // Replace code looking like
185 // NEG tmp1, a
186 // NEG tmp2, b
187 // ADD dst, tmp1, tmp2
188 // with
189 // ADD tmp, a, b
190 // NEG dst, tmp
Serdjuk, Nikolay Yaae9e662015-08-21 13:26:34 +0600191 // Note that we cannot optimize `(-a) + (-b)` to `-(a + b)` for floating-point.
192 // When `a` is `-0.0` and `b` is `0.0`, the former expression yields `0.0`,
193 // while the later yields `-0.0`.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100194 if (!DataType::IsIntegralType(binop->GetType())) {
Serdjuk, Nikolay Yaae9e662015-08-21 13:26:34 +0600195 return false;
196 }
Alexandre Rames188d4312015-04-09 18:30:21 +0100197 binop->ReplaceInput(left_neg->GetInput(), 0);
198 binop->ReplaceInput(right_neg->GetInput(), 1);
199 left_neg->GetBlock()->RemoveInstruction(left_neg);
200 right_neg->GetBlock()->RemoveInstruction(right_neg);
Vladimir Markoca6fff82017-10-03 14:49:14 +0100201 HNeg* neg = new (GetGraph()->GetAllocator()) HNeg(binop->GetType(), binop);
Alexandre Rames188d4312015-04-09 18:30:21 +0100202 binop->GetBlock()->InsertInstructionBefore(neg, binop->GetNext());
203 binop->ReplaceWithExceptInReplacementAtIndex(neg, 0);
204 RecordSimplification();
205 return true;
206}
207
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000208bool InstructionSimplifierVisitor::TryDeMorganNegationFactoring(HBinaryOperation* op) {
209 DCHECK(op->IsAnd() || op->IsOr()) << op->DebugName();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100210 DataType::Type type = op->GetType();
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000211 HInstruction* left = op->GetLeft();
212 HInstruction* right = op->GetRight();
213
214 // We can apply De Morgan's laws if both inputs are Not's and are only used
215 // by `op`.
Alexandre Rames9f980252016-02-05 14:00:28 +0000216 if (((left->IsNot() && right->IsNot()) ||
217 (left->IsBooleanNot() && right->IsBooleanNot())) &&
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000218 left->HasOnlyOneNonEnvironmentUse() &&
219 right->HasOnlyOneNonEnvironmentUse()) {
220 // Replace code looking like
221 // NOT nota, a
222 // NOT notb, b
223 // AND dst, nota, notb (respectively OR)
224 // with
225 // OR or, a, b (respectively AND)
226 // NOT dest, or
Alexandre Rames9f980252016-02-05 14:00:28 +0000227 HInstruction* src_left = left->InputAt(0);
228 HInstruction* src_right = right->InputAt(0);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000229 uint32_t dex_pc = op->GetDexPc();
230
231 // Remove the negations on the inputs.
232 left->ReplaceWith(src_left);
233 right->ReplaceWith(src_right);
234 left->GetBlock()->RemoveInstruction(left);
235 right->GetBlock()->RemoveInstruction(right);
236
237 // Replace the `HAnd` or `HOr`.
238 HBinaryOperation* hbin;
239 if (op->IsAnd()) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100240 hbin = new (GetGraph()->GetAllocator()) HOr(type, src_left, src_right, dex_pc);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000241 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100242 hbin = new (GetGraph()->GetAllocator()) HAnd(type, src_left, src_right, dex_pc);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000243 }
Alexandre Rames9f980252016-02-05 14:00:28 +0000244 HInstruction* hnot;
245 if (left->IsBooleanNot()) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100246 hnot = new (GetGraph()->GetAllocator()) HBooleanNot(hbin, dex_pc);
Alexandre Rames9f980252016-02-05 14:00:28 +0000247 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100248 hnot = new (GetGraph()->GetAllocator()) HNot(type, hbin, dex_pc);
Alexandre Rames9f980252016-02-05 14:00:28 +0000249 }
Alexandre Ramesca0e3a02016-02-03 10:54:07 +0000250
251 op->GetBlock()->InsertInstructionBefore(hbin, op);
252 op->GetBlock()->ReplaceAndRemoveInstructionWith(op, hnot);
253
254 RecordSimplification();
255 return true;
256 }
257
258 return false;
259}
260
Lena Djokicbc5460b2017-07-20 16:07:36 +0200261bool InstructionSimplifierVisitor::TryCombineVecMultiplyAccumulate(HVecMul* mul) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100262 DataType::Type type = mul->GetPackedType();
Lena Djokicbc5460b2017-07-20 16:07:36 +0200263 InstructionSet isa = codegen_->GetInstructionSet();
264 switch (isa) {
Vladimir Marko33bff252017-11-01 14:35:42 +0000265 case InstructionSet::kArm64:
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100266 if (!(type == DataType::Type::kUint8 ||
267 type == DataType::Type::kInt8 ||
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100268 type == DataType::Type::kUint16 ||
269 type == DataType::Type::kInt16 ||
270 type == DataType::Type::kInt32)) {
Lena Djokicbc5460b2017-07-20 16:07:36 +0200271 return false;
272 }
273 break;
Vladimir Marko33bff252017-11-01 14:35:42 +0000274 case InstructionSet::kMips:
275 case InstructionSet::kMips64:
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100276 if (!(type == DataType::Type::kUint8 ||
277 type == DataType::Type::kInt8 ||
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100278 type == DataType::Type::kUint16 ||
279 type == DataType::Type::kInt16 ||
280 type == DataType::Type::kInt32 ||
281 type == DataType::Type::kInt64)) {
Lena Djokicbc5460b2017-07-20 16:07:36 +0200282 return false;
283 }
284 break;
285 default:
286 return false;
287 }
288
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100289 ArenaAllocator* allocator = mul->GetBlock()->GetGraph()->GetAllocator();
Lena Djokicbc5460b2017-07-20 16:07:36 +0200290
291 if (mul->HasOnlyOneNonEnvironmentUse()) {
292 HInstruction* use = mul->GetUses().front().GetUser();
293 if (use->IsVecAdd() || use->IsVecSub()) {
294 // Replace code looking like
295 // VECMUL tmp, x, y
296 // VECADD/SUB dst, acc, tmp
297 // with
298 // VECMULACC dst, acc, x, y
299 // Note that we do not want to (unconditionally) perform the merge when the
300 // multiplication has multiple uses and it can be merged in all of them.
301 // Multiple uses could happen on the same control-flow path, and we would
302 // then increase the amount of work. In the future we could try to evaluate
303 // whether all uses are on different control-flow paths (using dominance and
304 // reverse-dominance information) and only perform the merge when they are.
305 HInstruction* accumulator = nullptr;
306 HVecBinaryOperation* binop = use->AsVecBinaryOperation();
307 HInstruction* binop_left = binop->GetLeft();
308 HInstruction* binop_right = binop->GetRight();
309 // This is always true since the `HVecMul` has only one use (which is checked above).
310 DCHECK_NE(binop_left, binop_right);
311 if (binop_right == mul) {
312 accumulator = binop_left;
313 } else if (use->IsVecAdd()) {
314 DCHECK_EQ(binop_left, mul);
315 accumulator = binop_right;
316 }
317
318 HInstruction::InstructionKind kind =
319 use->IsVecAdd() ? HInstruction::kAdd : HInstruction::kSub;
320 if (accumulator != nullptr) {
321 HVecMultiplyAccumulate* mulacc =
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100322 new (allocator) HVecMultiplyAccumulate(allocator,
323 kind,
324 accumulator,
325 mul->GetLeft(),
326 mul->GetRight(),
327 binop->GetPackedType(),
328 binop->GetVectorLength(),
329 binop->GetDexPc());
Lena Djokicbc5460b2017-07-20 16:07:36 +0200330
331 binop->GetBlock()->ReplaceAndRemoveInstructionWith(binop, mulacc);
332 DCHECK(!mul->HasUses());
333 mul->GetBlock()->RemoveInstruction(mul);
334 return true;
335 }
336 }
337 }
338
339 return false;
340}
341
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000342void InstructionSimplifierVisitor::VisitShift(HBinaryOperation* instruction) {
343 DCHECK(instruction->IsShl() || instruction->IsShr() || instruction->IsUShr());
Alexandre Rames50518442016-06-27 11:39:19 +0100344 HInstruction* shift_amount = instruction->GetRight();
345 HInstruction* value = instruction->GetLeft();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000346
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100347 int64_t implicit_mask = (value->GetType() == DataType::Type::kInt64)
Alexandre Rames50518442016-06-27 11:39:19 +0100348 ? kMaxLongShiftDistance
349 : kMaxIntShiftDistance;
350
351 if (shift_amount->IsConstant()) {
352 int64_t cst = Int64FromConstant(shift_amount->AsConstant());
Aart Bik50e20d52017-05-05 14:07:29 -0700353 int64_t masked_cst = cst & implicit_mask;
354 if (masked_cst == 0) {
Mark Mendellba56d062015-05-05 21:34:03 -0400355 // Replace code looking like
Alexandre Rames50518442016-06-27 11:39:19 +0100356 // SHL dst, value, 0
Mark Mendellba56d062015-05-05 21:34:03 -0400357 // with
Alexandre Rames50518442016-06-27 11:39:19 +0100358 // value
359 instruction->ReplaceWith(value);
Mark Mendellba56d062015-05-05 21:34:03 -0400360 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +0100361 RecordSimplification();
Alexandre Rames50518442016-06-27 11:39:19 +0100362 return;
Aart Bik50e20d52017-05-05 14:07:29 -0700363 } else if (masked_cst != cst) {
364 // Replace code looking like
365 // SHL dst, value, cst
366 // where cst exceeds maximum distance with the equivalent
367 // SHL dst, value, cst & implicit_mask
368 // (as defined by shift semantics). This ensures other
369 // optimizations do not need to special case for such situations.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100370 DCHECK_EQ(shift_amount->GetType(), DataType::Type::kInt32);
Aart Bik50e20d52017-05-05 14:07:29 -0700371 instruction->ReplaceInput(GetGraph()->GetIntConstant(masked_cst), /* index */ 1);
372 RecordSimplification();
373 return;
Alexandre Rames50518442016-06-27 11:39:19 +0100374 }
375 }
376
377 // Shift operations implicitly mask the shift amount according to the type width. Get rid of
Vladimir Marko7033d492017-09-28 16:32:24 +0100378 // unnecessary And/Or/Xor/Add/Sub/TypeConversion operations on the shift amount that do not
379 // affect the relevant bits.
Alexandre Rames50518442016-06-27 11:39:19 +0100380 // Replace code looking like
Vladimir Marko7033d492017-09-28 16:32:24 +0100381 // AND adjusted_shift, shift, <superset of implicit mask>
382 // [OR/XOR/ADD/SUB adjusted_shift, shift, <value not overlapping with implicit mask>]
383 // [<conversion-from-integral-non-64-bit-type> adjusted_shift, shift]
384 // SHL dst, value, adjusted_shift
Alexandre Rames50518442016-06-27 11:39:19 +0100385 // with
386 // SHL dst, value, shift
Vladimir Marko7033d492017-09-28 16:32:24 +0100387 if (shift_amount->IsAnd() ||
388 shift_amount->IsOr() ||
389 shift_amount->IsXor() ||
390 shift_amount->IsAdd() ||
391 shift_amount->IsSub()) {
392 int64_t required_result = shift_amount->IsAnd() ? implicit_mask : 0;
393 HBinaryOperation* bin_op = shift_amount->AsBinaryOperation();
394 HConstant* mask = bin_op->GetConstantRight();
395 if (mask != nullptr && (Int64FromConstant(mask) & implicit_mask) == required_result) {
396 instruction->ReplaceInput(bin_op->GetLeastConstantLeft(), 1);
Alexandre Rames50518442016-06-27 11:39:19 +0100397 RecordSimplification();
Vladimir Marko7033d492017-09-28 16:32:24 +0100398 return;
399 }
400 } else if (shift_amount->IsTypeConversion()) {
401 DCHECK_NE(shift_amount->GetType(), DataType::Type::kBool); // We never convert to bool.
402 DataType::Type source_type = shift_amount->InputAt(0)->GetType();
403 // Non-integral and 64-bit source types require an explicit type conversion.
404 if (DataType::IsIntegralType(source_type) && !DataType::Is64BitType(source_type)) {
405 instruction->ReplaceInput(shift_amount->AsTypeConversion()->GetInput(), 1);
406 RecordSimplification();
407 return;
Mark Mendellba56d062015-05-05 21:34:03 -0400408 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +0000409 }
410}
411
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000412static bool IsSubRegBitsMinusOther(HSub* sub, size_t reg_bits, HInstruction* other) {
413 return (sub->GetRight() == other &&
414 sub->GetLeft()->IsConstant() &&
415 (Int64FromConstant(sub->GetLeft()->AsConstant()) & (reg_bits - 1)) == 0);
416}
417
418bool InstructionSimplifierVisitor::ReplaceRotateWithRor(HBinaryOperation* op,
419 HUShr* ushr,
420 HShl* shl) {
Roland Levillain22c49222016-03-18 14:04:28 +0000421 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr()) << op->DebugName();
Vladimir Markoca6fff82017-10-03 14:49:14 +0100422 HRor* ror =
423 new (GetGraph()->GetAllocator()) HRor(ushr->GetType(), ushr->GetLeft(), ushr->GetRight());
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000424 op->GetBlock()->ReplaceAndRemoveInstructionWith(op, ror);
425 if (!ushr->HasUses()) {
426 ushr->GetBlock()->RemoveInstruction(ushr);
427 }
428 if (!ushr->GetRight()->HasUses()) {
429 ushr->GetRight()->GetBlock()->RemoveInstruction(ushr->GetRight());
430 }
431 if (!shl->HasUses()) {
432 shl->GetBlock()->RemoveInstruction(shl);
433 }
434 if (!shl->GetRight()->HasUses()) {
435 shl->GetRight()->GetBlock()->RemoveInstruction(shl->GetRight());
436 }
Alexandre Ramesc5809c32016-05-25 15:01:06 +0100437 RecordSimplification();
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000438 return true;
439}
440
441// Try to replace a binary operation flanked by one UShr and one Shl with a bitfield rotation.
442bool InstructionSimplifierVisitor::TryReplaceWithRotate(HBinaryOperation* op) {
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000443 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
444 HInstruction* left = op->GetLeft();
445 HInstruction* right = op->GetRight();
446 // If we have an UShr and a Shl (in either order).
447 if ((left->IsUShr() && right->IsShl()) || (left->IsShl() && right->IsUShr())) {
448 HUShr* ushr = left->IsUShr() ? left->AsUShr() : right->AsUShr();
449 HShl* shl = left->IsShl() ? left->AsShl() : right->AsShl();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100450 DCHECK(DataType::IsIntOrLongType(ushr->GetType()));
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000451 if (ushr->GetType() == shl->GetType() &&
452 ushr->GetLeft() == shl->GetLeft()) {
453 if (ushr->GetRight()->IsConstant() && shl->GetRight()->IsConstant()) {
454 // Shift distances are both constant, try replacing with Ror if they
455 // add up to the register size.
456 return TryReplaceWithRotateConstantPattern(op, ushr, shl);
457 } else if (ushr->GetRight()->IsSub() || shl->GetRight()->IsSub()) {
458 // Shift distances are potentially of the form x and (reg_size - x).
459 return TryReplaceWithRotateRegisterSubPattern(op, ushr, shl);
460 } else if (ushr->GetRight()->IsNeg() || shl->GetRight()->IsNeg()) {
461 // Shift distances are potentially of the form d and -d.
462 return TryReplaceWithRotateRegisterNegPattern(op, ushr, shl);
463 }
464 }
465 }
466 return false;
467}
468
469// Try replacing code looking like (x >>> #rdist OP x << #ldist):
470// UShr dst, x, #rdist
471// Shl tmp, x, #ldist
472// OP dst, dst, tmp
473// or like (x >>> #rdist OP x << #-ldist):
474// UShr dst, x, #rdist
475// Shl tmp, x, #-ldist
476// OP dst, dst, tmp
477// with
478// Ror dst, x, #rdist
479bool InstructionSimplifierVisitor::TryReplaceWithRotateConstantPattern(HBinaryOperation* op,
480 HUShr* ushr,
481 HShl* shl) {
482 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100483 size_t reg_bits = DataType::Size(ushr->GetType()) * kBitsPerByte;
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000484 size_t rdist = Int64FromConstant(ushr->GetRight()->AsConstant());
485 size_t ldist = Int64FromConstant(shl->GetRight()->AsConstant());
486 if (((ldist + rdist) & (reg_bits - 1)) == 0) {
487 ReplaceRotateWithRor(op, ushr, shl);
488 return true;
489 }
490 return false;
491}
492
493// Replace code looking like (x >>> -d OP x << d):
494// Neg neg, d
495// UShr dst, x, neg
496// Shl tmp, x, d
497// OP dst, dst, tmp
498// with
499// Neg neg, d
500// Ror dst, x, neg
501// *** OR ***
502// Replace code looking like (x >>> d OP x << -d):
503// UShr dst, x, d
504// Neg neg, d
505// Shl tmp, x, neg
506// OP dst, dst, tmp
507// with
508// Ror dst, x, d
509bool InstructionSimplifierVisitor::TryReplaceWithRotateRegisterNegPattern(HBinaryOperation* op,
510 HUShr* ushr,
511 HShl* shl) {
512 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
513 DCHECK(ushr->GetRight()->IsNeg() || shl->GetRight()->IsNeg());
514 bool neg_is_left = shl->GetRight()->IsNeg();
515 HNeg* neg = neg_is_left ? shl->GetRight()->AsNeg() : ushr->GetRight()->AsNeg();
516 // And the shift distance being negated is the distance being shifted the other way.
517 if (neg->InputAt(0) == (neg_is_left ? ushr->GetRight() : shl->GetRight())) {
518 ReplaceRotateWithRor(op, ushr, shl);
519 }
520 return false;
521}
522
523// Try replacing code looking like (x >>> d OP x << (#bits - d)):
524// UShr dst, x, d
525// Sub ld, #bits, d
526// Shl tmp, x, ld
527// OP dst, dst, tmp
528// with
529// Ror dst, x, d
530// *** OR ***
531// Replace code looking like (x >>> (#bits - d) OP x << d):
532// Sub rd, #bits, d
533// UShr dst, x, rd
534// Shl tmp, x, d
535// OP dst, dst, tmp
536// with
537// Neg neg, d
538// Ror dst, x, neg
539bool InstructionSimplifierVisitor::TryReplaceWithRotateRegisterSubPattern(HBinaryOperation* op,
540 HUShr* ushr,
541 HShl* shl) {
542 DCHECK(op->IsAdd() || op->IsXor() || op->IsOr());
543 DCHECK(ushr->GetRight()->IsSub() || shl->GetRight()->IsSub());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100544 size_t reg_bits = DataType::Size(ushr->GetType()) * kBitsPerByte;
Scott Wakeling40a04bf2015-12-11 09:50:36 +0000545 HInstruction* shl_shift = shl->GetRight();
546 HInstruction* ushr_shift = ushr->GetRight();
547 if ((shl_shift->IsSub() && IsSubRegBitsMinusOther(shl_shift->AsSub(), reg_bits, ushr_shift)) ||
548 (ushr_shift->IsSub() && IsSubRegBitsMinusOther(ushr_shift->AsSub(), reg_bits, shl_shift))) {
549 return ReplaceRotateWithRor(op, ushr, shl);
550 }
551 return false;
552}
553
Calin Juravle10e244f2015-01-26 18:54:32 +0000554void InstructionSimplifierVisitor::VisitNullCheck(HNullCheck* null_check) {
555 HInstruction* obj = null_check->InputAt(0);
556 if (!obj->CanBeNull()) {
557 null_check->ReplaceWith(obj);
558 null_check->GetBlock()->RemoveInstruction(null_check);
Calin Juravleacf735c2015-02-12 15:25:22 +0000559 if (stats_ != nullptr) {
560 stats_->RecordStat(MethodCompilationStat::kRemovedNullCheck);
561 }
562 }
563}
564
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100565bool InstructionSimplifierVisitor::CanEnsureNotNullAt(HInstruction* input, HInstruction* at) const {
566 if (!input->CanBeNull()) {
567 return true;
568 }
569
Vladimir Marko46817b82016-03-29 12:21:58 +0100570 for (const HUseListNode<HInstruction*>& use : input->GetUses()) {
571 HInstruction* user = use.GetUser();
572 if (user->IsNullCheck() && user->StrictlyDominates(at)) {
Guillaume "Vermeille" Sanchez8909baf2015-04-23 21:35:11 +0100573 return true;
574 }
575 }
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100576
Guillaume "Vermeille" Sanchez8909baf2015-04-23 21:35:11 +0100577 return false;
578}
579
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100580// Returns whether doing a type test between the class of `object` against `klass` has
581// a statically known outcome. The result of the test is stored in `outcome`.
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000582static bool TypeCheckHasKnownOutcome(HLoadClass* klass, HInstruction* object, bool* outcome) {
Calin Juravle2e768302015-07-28 14:41:11 +0000583 DCHECK(!object->IsNullConstant()) << "Null constants should be special cased";
584 ReferenceTypeInfo obj_rti = object->GetReferenceTypeInfo();
585 ScopedObjectAccess soa(Thread::Current());
586 if (!obj_rti.IsValid()) {
587 // We run the simplifier before the reference type propagation so type info might not be
588 // available.
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100589 return false;
Calin Juravleacf735c2015-02-12 15:25:22 +0000590 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100591
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000592 ReferenceTypeInfo class_rti = klass->GetLoadedClassRTI();
Calin Juravle98893e12015-10-02 21:05:03 +0100593 if (!class_rti.IsValid()) {
594 // Happens when the loaded class is unresolved.
595 return false;
596 }
597 DCHECK(class_rti.IsExact());
Calin Juravleacf735c2015-02-12 15:25:22 +0000598 if (class_rti.IsSupertypeOf(obj_rti)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100599 *outcome = true;
600 return true;
601 } else if (obj_rti.IsExact()) {
602 // The test failed at compile time so will also fail at runtime.
603 *outcome = false;
604 return true;
Nicolas Geoffray7cb499b2015-06-17 11:35:11 +0100605 } else if (!class_rti.IsInterface()
606 && !obj_rti.IsInterface()
607 && !obj_rti.IsSupertypeOf(class_rti)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100608 // Different type hierarchy. The test will fail.
609 *outcome = false;
610 return true;
611 }
612 return false;
613}
614
615void InstructionSimplifierVisitor::VisitCheckCast(HCheckCast* check_cast) {
616 HInstruction* object = check_cast->InputAt(0);
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000617 HLoadClass* load_class = check_cast->InputAt(1)->AsLoadClass();
618 if (load_class->NeedsAccessCheck()) {
Calin Juravlee53fb552015-10-07 17:51:52 +0100619 // If we need to perform an access check we cannot remove the instruction.
620 return;
621 }
622
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100623 if (CanEnsureNotNullAt(object, check_cast)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100624 check_cast->ClearMustDoNullCheck();
625 }
626
627 if (object->IsNullConstant()) {
Calin Juravleacf735c2015-02-12 15:25:22 +0000628 check_cast->GetBlock()->RemoveInstruction(check_cast);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700629 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedCheckedCast);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100630 return;
631 }
632
Vladimir Markoa65ed302016-03-14 21:21:29 +0000633 // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
634 // the return value check with the `outcome` check, b/27651442 .
635 bool outcome = false;
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000636 if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100637 if (outcome) {
638 check_cast->GetBlock()->RemoveInstruction(check_cast);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700639 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedCheckedCast);
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000640 if (!load_class->HasUses()) {
641 // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw.
642 // However, here we know that it cannot because the checkcast was successfull, hence
643 // the class was already loaded.
644 load_class->GetBlock()->RemoveInstruction(load_class);
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700645 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100646 } else {
647 // Don't do anything for exceptional cases for now. Ideally we should remove
648 // all instructions and blocks this instruction dominates.
649 }
Calin Juravle10e244f2015-01-26 18:54:32 +0000650 }
651}
652
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100653void InstructionSimplifierVisitor::VisitInstanceOf(HInstanceOf* instruction) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100654 HInstruction* object = instruction->InputAt(0);
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000655 HLoadClass* load_class = instruction->InputAt(1)->AsLoadClass();
656 if (load_class->NeedsAccessCheck()) {
Calin Juravlee53fb552015-10-07 17:51:52 +0100657 // If we need to perform an access check we cannot remove the instruction.
658 return;
659 }
660
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100661 bool can_be_null = true;
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100662 if (CanEnsureNotNullAt(object, instruction)) {
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100663 can_be_null = false;
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100664 instruction->ClearMustDoNullCheck();
665 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100666
667 HGraph* graph = GetGraph();
668 if (object->IsNullConstant()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000669 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedInstanceOf);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100670 instruction->ReplaceWith(graph->GetIntConstant(0));
671 instruction->GetBlock()->RemoveInstruction(instruction);
672 RecordSimplification();
673 return;
674 }
675
Vladimir Marko24bd8952016-03-15 10:40:33 +0000676 // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
677 // the return value check with the `outcome` check, b/27651442 .
678 bool outcome = false;
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000679 if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000680 MaybeRecordStat(stats_, MethodCompilationStat::kRemovedInstanceOf);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100681 if (outcome && can_be_null) {
682 // Type test will succeed, we just need a null test.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100683 HNotEqual* test = new (graph->GetAllocator()) HNotEqual(graph->GetNullConstant(), object);
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100684 instruction->GetBlock()->InsertInstructionBefore(test, instruction);
685 instruction->ReplaceWith(test);
686 } else {
687 // We've statically determined the result of the instanceof.
688 instruction->ReplaceWith(graph->GetIntConstant(outcome));
689 }
690 RecordSimplification();
691 instruction->GetBlock()->RemoveInstruction(instruction);
Nicolas Geoffraybff7a522018-01-25 13:33:07 +0000692 if (outcome && !load_class->HasUses()) {
693 // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw.
694 // However, here we know that it cannot because the instanceof check was successfull, hence
695 // the class was already loaded.
696 load_class->GetBlock()->RemoveInstruction(load_class);
Nicolas Geoffrayefa84682015-08-12 18:28:14 -0700697 }
Guillaume Sanchez222862c2015-06-09 18:33:02 +0100698 }
Guillaume "Vermeille" Sanchezaf888352015-04-20 14:41:30 +0100699}
700
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100701void InstructionSimplifierVisitor::VisitInstanceFieldSet(HInstanceFieldSet* instruction) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100702 if ((instruction->GetValue()->GetType() == DataType::Type::kReference)
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100703 && CanEnsureNotNullAt(instruction->GetValue(), instruction)) {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100704 instruction->ClearValueCanBeNull();
705 }
706}
707
708void InstructionSimplifierVisitor::VisitStaticFieldSet(HStaticFieldSet* instruction) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100709 if ((instruction->GetValue()->GetType() == DataType::Type::kReference)
Nicolas Geoffray6e7455e2015-09-28 16:25:37 +0100710 && CanEnsureNotNullAt(instruction->GetValue(), instruction)) {
Nicolas Geoffray07276db2015-05-18 14:22:09 +0100711 instruction->ClearValueCanBeNull();
712 }
713}
714
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100715static HCondition* GetOppositeConditionSwapOps(ArenaAllocator* allocator, HInstruction* cond) {
Anton Shaminbdd79352016-02-15 12:48:36 +0600716 HInstruction *lhs = cond->InputAt(0);
717 HInstruction *rhs = cond->InputAt(1);
718 switch (cond->GetKind()) {
719 case HInstruction::kEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100720 return new (allocator) HEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600721 case HInstruction::kNotEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100722 return new (allocator) HNotEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600723 case HInstruction::kLessThan:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100724 return new (allocator) HGreaterThan(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600725 case HInstruction::kLessThanOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100726 return new (allocator) HGreaterThanOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600727 case HInstruction::kGreaterThan:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100728 return new (allocator) HLessThan(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600729 case HInstruction::kGreaterThanOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100730 return new (allocator) HLessThanOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600731 case HInstruction::kBelow:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100732 return new (allocator) HAbove(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600733 case HInstruction::kBelowOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100734 return new (allocator) HAboveOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600735 case HInstruction::kAbove:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100736 return new (allocator) HBelow(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600737 case HInstruction::kAboveOrEqual:
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100738 return new (allocator) HBelowOrEqual(rhs, lhs);
Anton Shaminbdd79352016-02-15 12:48:36 +0600739 default:
740 LOG(FATAL) << "Unknown ConditionType " << cond->GetKind();
741 }
742 return nullptr;
743}
744
Aart Bik2767f4b2016-10-28 15:03:53 -0700745static bool CmpHasBoolType(HInstruction* input, HInstruction* cmp) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100746 if (input->GetType() == DataType::Type::kBool) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700747 return true; // input has direct boolean type
748 } else if (cmp->GetUses().HasExactlyOneElement()) {
749 // Comparison also has boolean type if both its input and the instruction
750 // itself feed into the same phi node.
751 HInstruction* user = cmp->GetUses().front().GetUser();
752 return user->IsPhi() && user->HasInput(input) && user->HasInput(cmp);
753 }
754 return false;
755}
756
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000757void InstructionSimplifierVisitor::VisitEqual(HEqual* equal) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100758 HInstruction* input_const = equal->GetConstantRight();
759 if (input_const != nullptr) {
760 HInstruction* input_value = equal->GetLeastConstantLeft();
Aart Bik2767f4b2016-10-28 15:03:53 -0700761 if (CmpHasBoolType(input_value, equal) && input_const->IsIntConstant()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100762 HBasicBlock* block = equal->GetBlock();
Nicolas Geoffray3c4ab802015-06-19 11:42:07 +0100763 // We are comparing the boolean to a constant which is of type int and can
764 // be any constant.
Roland Levillain1a653882016-03-18 18:05:57 +0000765 if (input_const->AsIntConstant()->IsTrue()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100766 // Replace (bool_value == true) with bool_value
767 equal->ReplaceWith(input_value);
768 block->RemoveInstruction(equal);
769 RecordSimplification();
Roland Levillain1a653882016-03-18 18:05:57 +0000770 } else if (input_const->AsIntConstant()->IsFalse()) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700771 // Replace (bool_value == false) with !bool_value
Mark Mendellf6529172015-11-17 11:16:56 -0500772 equal->ReplaceWith(GetGraph()->InsertOppositeCondition(input_value, equal));
773 block->RemoveInstruction(equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100774 RecordSimplification();
David Brazdil1e9ec052015-06-22 10:26:45 +0100775 } else {
776 // Replace (bool_value == integer_not_zero_nor_one_constant) with false
777 equal->ReplaceWith(GetGraph()->GetIntConstant(0));
778 block->RemoveInstruction(equal);
779 RecordSimplification();
David Brazdil0d13fee2015-04-17 14:52:19 +0100780 }
Mark Mendellc4701932015-04-10 13:18:51 -0400781 } else {
782 VisitCondition(equal);
Nicolas Geoffray01ef3452014-10-01 11:32:17 +0100783 }
Mark Mendellc4701932015-04-10 13:18:51 -0400784 } else {
785 VisitCondition(equal);
Nicolas Geoffray01ef3452014-10-01 11:32:17 +0100786 }
787}
788
David Brazdil0d13fee2015-04-17 14:52:19 +0100789void InstructionSimplifierVisitor::VisitNotEqual(HNotEqual* not_equal) {
790 HInstruction* input_const = not_equal->GetConstantRight();
791 if (input_const != nullptr) {
792 HInstruction* input_value = not_equal->GetLeastConstantLeft();
Aart Bik2767f4b2016-10-28 15:03:53 -0700793 if (CmpHasBoolType(input_value, not_equal) && input_const->IsIntConstant()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100794 HBasicBlock* block = not_equal->GetBlock();
Nicolas Geoffray3c4ab802015-06-19 11:42:07 +0100795 // We are comparing the boolean to a constant which is of type int and can
796 // be any constant.
Roland Levillain1a653882016-03-18 18:05:57 +0000797 if (input_const->AsIntConstant()->IsTrue()) {
Aart Bik2767f4b2016-10-28 15:03:53 -0700798 // Replace (bool_value != true) with !bool_value
Mark Mendellf6529172015-11-17 11:16:56 -0500799 not_equal->ReplaceWith(GetGraph()->InsertOppositeCondition(input_value, not_equal));
800 block->RemoveInstruction(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100801 RecordSimplification();
Roland Levillain1a653882016-03-18 18:05:57 +0000802 } else if (input_const->AsIntConstant()->IsFalse()) {
David Brazdil0d13fee2015-04-17 14:52:19 +0100803 // Replace (bool_value != false) with bool_value
David Brazdil0d13fee2015-04-17 14:52:19 +0100804 not_equal->ReplaceWith(input_value);
805 block->RemoveInstruction(not_equal);
806 RecordSimplification();
David Brazdil1e9ec052015-06-22 10:26:45 +0100807 } else {
808 // Replace (bool_value != integer_not_zero_nor_one_constant) with true
809 not_equal->ReplaceWith(GetGraph()->GetIntConstant(1));
810 block->RemoveInstruction(not_equal);
811 RecordSimplification();
David Brazdil0d13fee2015-04-17 14:52:19 +0100812 }
Mark Mendellc4701932015-04-10 13:18:51 -0400813 } else {
814 VisitCondition(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100815 }
Mark Mendellc4701932015-04-10 13:18:51 -0400816 } else {
817 VisitCondition(not_equal);
David Brazdil0d13fee2015-04-17 14:52:19 +0100818 }
819}
820
821void InstructionSimplifierVisitor::VisitBooleanNot(HBooleanNot* bool_not) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000822 HInstruction* input = bool_not->InputAt(0);
823 HInstruction* replace_with = nullptr;
824
825 if (input->IsIntConstant()) {
826 // Replace !(true/false) with false/true.
Roland Levillain1a653882016-03-18 18:05:57 +0000827 if (input->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000828 replace_with = GetGraph()->GetIntConstant(0);
829 } else {
Roland Levillain1a653882016-03-18 18:05:57 +0000830 DCHECK(input->AsIntConstant()->IsFalse()) << input->AsIntConstant()->GetValue();
David Brazdil74eb1b22015-12-14 11:44:01 +0000831 replace_with = GetGraph()->GetIntConstant(1);
832 }
833 } else if (input->IsBooleanNot()) {
834 // Replace (!(!bool_value)) with bool_value.
835 replace_with = input->InputAt(0);
836 } else if (input->IsCondition() &&
837 // Don't change FP compares. The definition of compares involving
838 // NaNs forces the compares to be done as written by the user.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100839 !DataType::IsFloatingPointType(input->InputAt(0)->GetType())) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000840 // Replace condition with its opposite.
841 replace_with = GetGraph()->InsertOppositeCondition(input->AsCondition(), bool_not);
842 }
843
844 if (replace_with != nullptr) {
845 bool_not->ReplaceWith(replace_with);
David Brazdil0d13fee2015-04-17 14:52:19 +0100846 bool_not->GetBlock()->RemoveInstruction(bool_not);
David Brazdil74eb1b22015-12-14 11:44:01 +0000847 RecordSimplification();
848 }
849}
850
Aart Bik4f7dd342017-09-12 13:12:57 -0700851// Constructs a new ABS(x) node in the HIR.
Vladimir Markoe764d2e2017-10-05 14:35:55 +0100852static HInstruction* NewIntegralAbs(ArenaAllocator* allocator,
853 HInstruction* x,
854 HInstruction* cursor) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100855 DataType::Type type = x->GetType();
Aart Bik3dad3412018-02-28 12:01:46 -0800856 DCHECK(type == DataType::Type::kInt32 || type == DataType::Type::kInt64);
857 HAbs* abs = new (allocator) HAbs(type, x, x->GetDexPc());
858 cursor->GetBlock()->InsertInstructionBefore(abs, cursor);
859 return abs;
Aart Bik4f7dd342017-09-12 13:12:57 -0700860}
861
862// Returns true if operands a and b consists of widening type conversions
863// (either explicit or implicit) to the given to_type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100864static bool AreLowerPrecisionArgs(DataType::Type to_type, HInstruction* a, HInstruction* b) {
Aart Bik4f7dd342017-09-12 13:12:57 -0700865 if (a->IsTypeConversion() && a->GetType() == to_type) {
866 a = a->InputAt(0);
867 }
868 if (b->IsTypeConversion() && b->GetType() == to_type) {
869 b = b->InputAt(0);
870 }
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100871 DataType::Type type1 = a->GetType();
872 DataType::Type type2 = b->GetType();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100873 return (type1 == DataType::Type::kUint8 && type2 == DataType::Type::kUint8) ||
874 (type1 == DataType::Type::kInt8 && type2 == DataType::Type::kInt8) ||
875 (type1 == DataType::Type::kInt16 && type2 == DataType::Type::kInt16) ||
876 (type1 == DataType::Type::kUint16 && type2 == DataType::Type::kUint16) ||
877 (type1 == DataType::Type::kInt32 && type2 == DataType::Type::kInt32 &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100878 to_type == DataType::Type::kInt64);
Aart Bik4f7dd342017-09-12 13:12:57 -0700879}
880
David Brazdil74eb1b22015-12-14 11:44:01 +0000881void InstructionSimplifierVisitor::VisitSelect(HSelect* select) {
882 HInstruction* replace_with = nullptr;
883 HInstruction* condition = select->GetCondition();
884 HInstruction* true_value = select->GetTrueValue();
885 HInstruction* false_value = select->GetFalseValue();
886
887 if (condition->IsBooleanNot()) {
888 // Change ((!cond) ? x : y) to (cond ? y : x).
889 condition = condition->InputAt(0);
890 std::swap(true_value, false_value);
891 select->ReplaceInput(false_value, 0);
892 select->ReplaceInput(true_value, 1);
893 select->ReplaceInput(condition, 2);
894 RecordSimplification();
895 }
896
897 if (true_value == false_value) {
898 // Replace (cond ? x : x) with (x).
899 replace_with = true_value;
900 } else if (condition->IsIntConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +0000901 if (condition->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000902 // Replace (true ? x : y) with (x).
903 replace_with = true_value;
904 } else {
905 // Replace (false ? x : y) with (y).
Roland Levillain1a653882016-03-18 18:05:57 +0000906 DCHECK(condition->AsIntConstant()->IsFalse()) << condition->AsIntConstant()->GetValue();
David Brazdil74eb1b22015-12-14 11:44:01 +0000907 replace_with = false_value;
908 }
909 } else if (true_value->IsIntConstant() && false_value->IsIntConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +0000910 if (true_value->AsIntConstant()->IsTrue() && false_value->AsIntConstant()->IsFalse()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000911 // Replace (cond ? true : false) with (cond).
912 replace_with = condition;
Roland Levillain1a653882016-03-18 18:05:57 +0000913 } else if (true_value->AsIntConstant()->IsFalse() && false_value->AsIntConstant()->IsTrue()) {
David Brazdil74eb1b22015-12-14 11:44:01 +0000914 // Replace (cond ? false : true) with (!cond).
915 replace_with = GetGraph()->InsertOppositeCondition(condition, select);
916 }
Aart Bik4f7dd342017-09-12 13:12:57 -0700917 } else if (condition->IsCondition()) {
918 IfCondition cmp = condition->AsCondition()->GetCondition();
919 HInstruction* a = condition->InputAt(0);
920 HInstruction* b = condition->InputAt(1);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100921 DataType::Type t_type = true_value->GetType();
922 DataType::Type f_type = false_value->GetType();
Aart Bik4f7dd342017-09-12 13:12:57 -0700923 // Here we have a <cmp> b ? true_value : false_value.
924 // Test if both values are same-typed int or long.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100925 if (t_type == f_type &&
926 (t_type == DataType::Type::kInt32 || t_type == DataType::Type::kInt64)) {
Aart Bik4f7dd342017-09-12 13:12:57 -0700927 // Try to replace typical integral ABS constructs.
928 if (true_value->IsNeg()) {
929 HInstruction* negated = true_value->InputAt(0);
930 if ((cmp == kCondLT || cmp == kCondLE) &&
931 (a == negated && a == false_value && IsInt64Value(b, 0))) {
932 // Found a < 0 ? -a : a which can be replaced by ABS(a).
Vladimir Markoca6fff82017-10-03 14:49:14 +0100933 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), false_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700934 }
935 } else if (false_value->IsNeg()) {
936 HInstruction* negated = false_value->InputAt(0);
937 if ((cmp == kCondGT || cmp == kCondGE) &&
938 (a == true_value && a == negated && IsInt64Value(b, 0))) {
939 // Found a > 0 ? a : -a which can be replaced by ABS(a).
Vladimir Markoca6fff82017-10-03 14:49:14 +0100940 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), true_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700941 }
942 } else if (true_value->IsSub() && false_value->IsSub()) {
943 HInstruction* true_sub1 = true_value->InputAt(0);
944 HInstruction* true_sub2 = true_value->InputAt(1);
945 HInstruction* false_sub1 = false_value->InputAt(0);
946 HInstruction* false_sub2 = false_value->InputAt(1);
947 if ((((cmp == kCondGT || cmp == kCondGE) &&
948 (a == true_sub1 && b == true_sub2 && a == false_sub2 && b == false_sub1)) ||
949 ((cmp == kCondLT || cmp == kCondLE) &&
950 (a == true_sub2 && b == true_sub1 && a == false_sub1 && b == false_sub2))) &&
951 AreLowerPrecisionArgs(t_type, a, b)) {
952 // Found a > b ? a - b : b - a or
953 // a < b ? b - a : a - b
954 // which can be replaced by ABS(a - b) for lower precision operands a, b.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100955 replace_with = NewIntegralAbs(GetGraph()->GetAllocator(), true_value, select);
Aart Bik4f7dd342017-09-12 13:12:57 -0700956 }
957 }
958 }
David Brazdil74eb1b22015-12-14 11:44:01 +0000959 }
960
961 if (replace_with != nullptr) {
962 select->ReplaceWith(replace_with);
963 select->GetBlock()->RemoveInstruction(select);
964 RecordSimplification();
965 }
966}
967
968void InstructionSimplifierVisitor::VisitIf(HIf* instruction) {
969 HInstruction* condition = instruction->InputAt(0);
970 if (condition->IsBooleanNot()) {
971 // Swap successors if input is negated.
972 instruction->ReplaceInput(condition->InputAt(0), 0);
973 instruction->GetBlock()->SwapSuccessors();
David Brazdil0d13fee2015-04-17 14:52:19 +0100974 RecordSimplification();
975 }
976}
977
Mingyao Yang0304e182015-01-30 16:41:29 -0800978void InstructionSimplifierVisitor::VisitArrayLength(HArrayLength* instruction) {
979 HInstruction* input = instruction->InputAt(0);
980 // If the array is a NewArray with constant size, replace the array length
981 // with the constant instruction. This helps the bounds check elimination phase.
982 if (input->IsNewArray()) {
Nicolas Geoffraye761bcc2017-01-19 08:59:37 +0000983 input = input->AsNewArray()->GetLength();
Mingyao Yang0304e182015-01-30 16:41:29 -0800984 if (input->IsIntConstant()) {
985 instruction->ReplaceWith(input);
986 }
987 }
988}
989
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000990void InstructionSimplifierVisitor::VisitArraySet(HArraySet* instruction) {
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +0000991 HInstruction* value = instruction->GetValue();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100992 if (value->GetType() != DataType::Type::kReference) {
993 return;
994 }
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +0000995
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +0100996 if (CanEnsureNotNullAt(value, instruction)) {
997 instruction->ClearValueCanBeNull();
998 }
999
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001000 if (value->IsArrayGet()) {
1001 if (value->AsArrayGet()->GetArray() == instruction->GetArray()) {
1002 // If the code is just swapping elements in the array, no need for a type check.
1003 instruction->ClearNeedsTypeCheck();
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001004 return;
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001005 }
1006 }
Nicolas Geoffray07276db2015-05-18 14:22:09 +01001007
Nicolas Geoffray9fdb31e2015-07-01 12:56:46 +01001008 if (value->IsNullConstant()) {
1009 instruction->ClearNeedsTypeCheck();
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001010 return;
Nicolas Geoffray9fdb31e2015-07-01 12:56:46 +01001011 }
1012
Nicolas Geoffraye0395dd2015-09-25 11:04:45 +01001013 ScopedObjectAccess soa(Thread::Current());
1014 ReferenceTypeInfo array_rti = instruction->GetArray()->GetReferenceTypeInfo();
1015 ReferenceTypeInfo value_rti = value->GetReferenceTypeInfo();
1016 if (!array_rti.IsValid()) {
1017 return;
1018 }
1019
1020 if (value_rti.IsValid() && array_rti.CanArrayHold(value_rti)) {
1021 instruction->ClearNeedsTypeCheck();
1022 return;
1023 }
1024
1025 if (array_rti.IsObjectArray()) {
1026 if (array_rti.IsExact()) {
1027 instruction->ClearNeedsTypeCheck();
1028 return;
1029 }
1030 instruction->SetStaticTypeOfArrayIsObjectArray();
Nicolas Geoffray07276db2015-05-18 14:22:09 +01001031 }
Nicolas Geoffrayaf07bc12014-11-12 18:08:09 +00001032}
1033
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001034static bool IsTypeConversionLossless(DataType::Type input_type, DataType::Type result_type) {
Aart Bikdab69072017-10-23 13:30:39 -07001035 // Make sure all implicit conversions have been simplified and no new ones have been introduced.
1036 DCHECK(!DataType::IsTypeConversionImplicit(input_type, result_type))
1037 << input_type << "," << result_type;
Vladimir Markob52bbde2016-02-12 12:06:05 +00001038 // The conversion to a larger type is loss-less with the exception of two cases,
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001039 // - conversion to the unsigned type Uint16, where we may lose some bits, and
Vladimir Markob52bbde2016-02-12 12:06:05 +00001040 // - conversion from float to long, the only FP to integral conversion with smaller FP type.
1041 // For integral to FP conversions this holds because the FP mantissa is large enough.
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001042 // Note: The size check excludes Uint8 as the result type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001043 return DataType::Size(result_type) > DataType::Size(input_type) &&
1044 result_type != DataType::Type::kUint16 &&
1045 !(result_type == DataType::Type::kInt64 && input_type == DataType::Type::kFloat32);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001046}
1047
Vladimir Marko61b92282017-10-11 13:23:17 +01001048static inline bool TryReplaceFieldOrArrayGetType(HInstruction* maybe_get, DataType::Type new_type) {
1049 if (maybe_get->IsInstanceFieldGet()) {
1050 maybe_get->AsInstanceFieldGet()->SetType(new_type);
1051 return true;
1052 } else if (maybe_get->IsStaticFieldGet()) {
1053 maybe_get->AsStaticFieldGet()->SetType(new_type);
1054 return true;
1055 } else if (maybe_get->IsArrayGet() && !maybe_get->AsArrayGet()->IsStringCharAt()) {
1056 maybe_get->AsArrayGet()->SetType(new_type);
1057 return true;
1058 } else {
1059 return false;
1060 }
1061}
1062
Mingyao Yang3bcb7512017-11-16 15:40:46 -08001063// The type conversion is only used for storing into a field/element of the
1064// same/narrower size.
1065static bool IsTypeConversionForStoringIntoNoWiderFieldOnly(HTypeConversion* type_conversion) {
1066 if (type_conversion->HasEnvironmentUses()) {
1067 return false;
1068 }
1069 DataType::Type input_type = type_conversion->GetInputType();
1070 DataType::Type result_type = type_conversion->GetResultType();
1071 if (!DataType::IsIntegralType(input_type) ||
1072 !DataType::IsIntegralType(result_type) ||
1073 input_type == DataType::Type::kInt64 ||
1074 result_type == DataType::Type::kInt64) {
1075 // Type conversion is needed if non-integer types are involved, or 64-bit
1076 // types are involved, which may use different number of registers.
1077 return false;
1078 }
1079 if (DataType::Size(input_type) >= DataType::Size(result_type)) {
1080 // Type conversion is not necessary when storing to a field/element of the
1081 // same/smaller size.
1082 } else {
1083 // We do not handle this case here.
1084 return false;
1085 }
1086
1087 // Check if the converted value is only used for storing into heap.
1088 for (const HUseListNode<HInstruction*>& use : type_conversion->GetUses()) {
1089 HInstruction* instruction = use.GetUser();
1090 if (instruction->IsInstanceFieldSet() &&
1091 instruction->AsInstanceFieldSet()->GetFieldType() == result_type) {
1092 DCHECK_EQ(instruction->AsInstanceFieldSet()->GetValue(), type_conversion);
1093 continue;
1094 }
1095 if (instruction->IsStaticFieldSet() &&
1096 instruction->AsStaticFieldSet()->GetFieldType() == result_type) {
1097 DCHECK_EQ(instruction->AsStaticFieldSet()->GetValue(), type_conversion);
1098 continue;
1099 }
1100 if (instruction->IsArraySet() &&
1101 instruction->AsArraySet()->GetComponentType() == result_type &&
1102 // not index use.
1103 instruction->AsArraySet()->GetIndex() != type_conversion) {
1104 DCHECK_EQ(instruction->AsArraySet()->GetValue(), type_conversion);
1105 continue;
1106 }
1107 // The use is not as a store value, or the field/element type is not the
1108 // same as the result_type, keep the type conversion.
1109 return false;
1110 }
1111 // Codegen automatically handles the type conversion during the store.
1112 return true;
1113}
1114
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001115void InstructionSimplifierVisitor::VisitTypeConversion(HTypeConversion* instruction) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001116 HInstruction* input = instruction->GetInput();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001117 DataType::Type input_type = input->GetType();
1118 DataType::Type result_type = instruction->GetResultType();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001119 if (DataType::IsTypeConversionImplicit(input_type, result_type)) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001120 // Remove the implicit conversion; this includes conversion to the same type.
1121 instruction->ReplaceWith(input);
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001122 instruction->GetBlock()->RemoveInstruction(instruction);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001123 RecordSimplification();
1124 return;
1125 }
1126
1127 if (input->IsTypeConversion()) {
1128 HTypeConversion* input_conversion = input->AsTypeConversion();
1129 HInstruction* original_input = input_conversion->GetInput();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001130 DataType::Type original_type = original_input->GetType();
Vladimir Markob52bbde2016-02-12 12:06:05 +00001131
1132 // When the first conversion is lossless, a direct conversion from the original type
1133 // to the final type yields the same result, even for a lossy second conversion, for
1134 // example float->double->int or int->double->float.
1135 bool is_first_conversion_lossless = IsTypeConversionLossless(original_type, input_type);
1136
1137 // For integral conversions, see if the first conversion loses only bits that the second
1138 // doesn't need, i.e. the final type is no wider than the intermediate. If so, direct
1139 // conversion yields the same result, for example long->int->short or int->char->short.
1140 bool integral_conversions_with_non_widening_second =
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001141 DataType::IsIntegralType(input_type) &&
1142 DataType::IsIntegralType(original_type) &&
1143 DataType::IsIntegralType(result_type) &&
1144 DataType::Size(result_type) <= DataType::Size(input_type);
Vladimir Markob52bbde2016-02-12 12:06:05 +00001145
1146 if (is_first_conversion_lossless || integral_conversions_with_non_widening_second) {
1147 // If the merged conversion is implicit, do the simplification unconditionally.
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001148 if (DataType::IsTypeConversionImplicit(original_type, result_type)) {
Vladimir Markob52bbde2016-02-12 12:06:05 +00001149 instruction->ReplaceWith(original_input);
1150 instruction->GetBlock()->RemoveInstruction(instruction);
1151 if (!input_conversion->HasUses()) {
1152 // Don't wait for DCE.
1153 input_conversion->GetBlock()->RemoveInstruction(input_conversion);
1154 }
1155 RecordSimplification();
1156 return;
1157 }
1158 // Otherwise simplify only if the first conversion has no other use.
1159 if (input_conversion->HasOnlyOneNonEnvironmentUse()) {
1160 input_conversion->ReplaceWith(original_input);
1161 input_conversion->GetBlock()->RemoveInstruction(input_conversion);
1162 RecordSimplification();
1163 return;
1164 }
1165 }
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001166 } else if (input->IsAnd() && DataType::IsIntegralType(result_type)) {
1167 DCHECK(DataType::IsIntegralType(input_type));
Vladimir Marko8428bd32016-02-12 16:53:57 +00001168 HAnd* input_and = input->AsAnd();
1169 HConstant* constant = input_and->GetConstantRight();
1170 if (constant != nullptr) {
1171 int64_t value = Int64FromConstant(constant);
1172 DCHECK_NE(value, -1); // "& -1" would have been optimized away in VisitAnd().
1173 size_t trailing_ones = CTZ(~static_cast<uint64_t>(value));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001174 if (trailing_ones >= kBitsPerByte * DataType::Size(result_type)) {
Vladimir Marko8428bd32016-02-12 16:53:57 +00001175 // The `HAnd` is useless, for example in `(byte) (x & 0xff)`, get rid of it.
Vladimir Marko625090f2016-03-14 18:00:05 +00001176 HInstruction* original_input = input_and->GetLeastConstantLeft();
Vladimir Markod5d2f2c2017-09-26 12:37:26 +01001177 if (DataType::IsTypeConversionImplicit(original_input->GetType(), result_type)) {
Vladimir Marko625090f2016-03-14 18:00:05 +00001178 instruction->ReplaceWith(original_input);
1179 instruction->GetBlock()->RemoveInstruction(instruction);
1180 RecordSimplification();
1181 return;
1182 } else if (input->HasOnlyOneNonEnvironmentUse()) {
1183 input_and->ReplaceWith(original_input);
1184 input_and->GetBlock()->RemoveInstruction(input_and);
1185 RecordSimplification();
1186 return;
1187 }
Vladimir Marko8428bd32016-02-12 16:53:57 +00001188 }
1189 }
Vladimir Marko61b92282017-10-11 13:23:17 +01001190 } else if (input->HasOnlyOneNonEnvironmentUse() &&
1191 ((input_type == DataType::Type::kInt8 && result_type == DataType::Type::kUint8) ||
1192 (input_type == DataType::Type::kUint8 && result_type == DataType::Type::kInt8) ||
1193 (input_type == DataType::Type::kInt16 && result_type == DataType::Type::kUint16) ||
1194 (input_type == DataType::Type::kUint16 && result_type == DataType::Type::kInt16))) {
1195 // Try to modify the type of the load to `result_type` and remove the explicit type conversion.
1196 if (TryReplaceFieldOrArrayGetType(input, result_type)) {
1197 instruction->ReplaceWith(input);
1198 instruction->GetBlock()->RemoveInstruction(instruction);
1199 RecordSimplification();
1200 return;
1201 }
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001202 }
Mingyao Yang3bcb7512017-11-16 15:40:46 -08001203
1204 if (IsTypeConversionForStoringIntoNoWiderFieldOnly(instruction)) {
1205 instruction->ReplaceWith(input);
1206 instruction->GetBlock()->RemoveInstruction(instruction);
1207 RecordSimplification();
1208 return;
1209 }
Nicolas Geoffray01fcc9e2014-12-01 14:16:20 +00001210}
1211
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001212void InstructionSimplifierVisitor::VisitAdd(HAdd* instruction) {
1213 HConstant* input_cst = instruction->GetConstantRight();
1214 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001215 bool integral_type = DataType::IsIntegralType(instruction->GetType());
Roland Levillain1a653882016-03-18 18:05:57 +00001216 if ((input_cst != nullptr) && input_cst->IsArithmeticZero()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001217 // Replace code looking like
1218 // ADD dst, src, 0
1219 // with
1220 // src
Serguei Katkov115b53f2015-08-05 17:03:30 +06001221 // Note that we cannot optimize `x + 0.0` to `x` for floating-point. When
1222 // `x` is `-0.0`, the former expression yields `0.0`, while the later
1223 // yields `-0.0`.
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001224 if (integral_type) {
Serguei Katkov115b53f2015-08-05 17:03:30 +06001225 instruction->ReplaceWith(input_other);
1226 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001227 RecordSimplification();
Serguei Katkov115b53f2015-08-05 17:03:30 +06001228 return;
1229 }
Alexandre Rames188d4312015-04-09 18:30:21 +01001230 }
1231
1232 HInstruction* left = instruction->GetLeft();
1233 HInstruction* right = instruction->GetRight();
1234 bool left_is_neg = left->IsNeg();
1235 bool right_is_neg = right->IsNeg();
1236
1237 if (left_is_neg && right_is_neg) {
1238 if (TryMoveNegOnInputsAfterBinop(instruction)) {
1239 return;
1240 }
1241 }
1242
1243 HNeg* neg = left_is_neg ? left->AsNeg() : right->AsNeg();
1244 if ((left_is_neg ^ right_is_neg) && neg->HasOnlyOneNonEnvironmentUse()) {
1245 // Replace code looking like
1246 // NEG tmp, b
1247 // ADD dst, a, tmp
1248 // with
1249 // SUB dst, a, b
1250 // We do not perform the optimization if the input negation has environment
1251 // uses or multiple non-environment uses as it could lead to worse code. In
1252 // particular, we do not want the live range of `b` to be extended if we are
1253 // not sure the initial 'NEG' instruction can be removed.
1254 HInstruction* other = left_is_neg ? right : left;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001255 HSub* sub =
1256 new(GetGraph()->GetAllocator()) HSub(instruction->GetType(), other, neg->GetInput());
Alexandre Rames188d4312015-04-09 18:30:21 +01001257 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, sub);
1258 RecordSimplification();
1259 neg->GetBlock()->RemoveInstruction(neg);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001260 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001261 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001262
Anton Kirilove14dc862016-05-13 17:56:15 +01001263 if (TryReplaceWithRotate(instruction)) {
1264 return;
1265 }
1266
1267 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1268 // so no need to return.
1269 TryHandleAssociativeAndCommutativeOperation(instruction);
1270
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001271 if ((left->IsSub() || right->IsSub()) &&
Anton Kirilove14dc862016-05-13 17:56:15 +01001272 TrySubtractionChainSimplification(instruction)) {
1273 return;
1274 }
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001275
1276 if (integral_type) {
1277 // Replace code patterns looking like
1278 // SUB dst1, x, y SUB dst1, x, y
1279 // ADD dst2, dst1, y ADD dst2, y, dst1
1280 // with
1281 // SUB dst1, x, y
1282 // ADD instruction is not needed in this case, we may use
1283 // one of inputs of SUB instead.
1284 if (left->IsSub() && left->InputAt(1) == right) {
1285 instruction->ReplaceWith(left->InputAt(0));
1286 RecordSimplification();
1287 instruction->GetBlock()->RemoveInstruction(instruction);
1288 return;
1289 } else if (right->IsSub() && right->InputAt(1) == left) {
1290 instruction->ReplaceWith(right->InputAt(0));
1291 RecordSimplification();
1292 instruction->GetBlock()->RemoveInstruction(instruction);
1293 return;
1294 }
1295 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001296}
1297
1298void InstructionSimplifierVisitor::VisitAnd(HAnd* instruction) {
Vladimir Marko61b92282017-10-11 13:23:17 +01001299 DCHECK(DataType::IsIntegralType(instruction->GetType()));
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001300 HConstant* input_cst = instruction->GetConstantRight();
1301 HInstruction* input_other = instruction->GetLeastConstantLeft();
1302
Vladimir Marko452c1b62015-09-25 14:44:17 +01001303 if (input_cst != nullptr) {
1304 int64_t value = Int64FromConstant(input_cst);
Aart Bikdab69072017-10-23 13:30:39 -07001305 if (value == -1 ||
1306 // Similar cases under zero extension.
1307 (DataType::IsUnsignedType(input_other->GetType()) &&
1308 ((DataType::MaxValueOfIntegralType(input_other->GetType()) & ~value) == 0))) {
Vladimir Marko452c1b62015-09-25 14:44:17 +01001309 // Replace code looking like
1310 // AND dst, src, 0xFFF...FF
1311 // with
1312 // src
1313 instruction->ReplaceWith(input_other);
1314 instruction->GetBlock()->RemoveInstruction(instruction);
1315 RecordSimplification();
1316 return;
1317 }
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001318 if (input_other->IsTypeConversion() &&
1319 input_other->GetType() == DataType::Type::kInt64 &&
1320 DataType::IsIntegralType(input_other->InputAt(0)->GetType()) &&
1321 IsInt<32>(value) &&
1322 input_other->HasOnlyOneNonEnvironmentUse()) {
1323 // The AND can be reordered before the TypeConversion. Replace
1324 // LongConstant cst, <32-bit-constant-sign-extended-to-64-bits>
1325 // TypeConversion<Int64> tmp, src
1326 // AND dst, tmp, cst
1327 // with
1328 // IntConstant cst, <32-bit-constant>
1329 // AND tmp, src, cst
1330 // TypeConversion<Int64> dst, tmp
1331 // This helps 32-bit targets and does not hurt 64-bit targets.
1332 // This also simplifies detection of other patterns, such as Uint8 loads.
1333 HInstruction* new_and_input = input_other->InputAt(0);
1334 // Implicit conversion Int64->Int64 would have been removed previously.
1335 DCHECK_NE(new_and_input->GetType(), DataType::Type::kInt64);
1336 HConstant* new_const = GetGraph()->GetConstant(DataType::Type::kInt32, value);
1337 HAnd* new_and =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001338 new (GetGraph()->GetAllocator()) HAnd(DataType::Type::kInt32, new_and_input, new_const);
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001339 instruction->GetBlock()->InsertInstructionBefore(new_and, instruction);
1340 HTypeConversion* new_conversion =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001341 new (GetGraph()->GetAllocator()) HTypeConversion(DataType::Type::kInt64, new_and);
Vladimir Markoc8fb2112017-10-03 11:37:52 +01001342 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, new_conversion);
1343 input_other->GetBlock()->RemoveInstruction(input_other);
1344 RecordSimplification();
1345 // Try to process the new And now, do not wait for the next round of simplifications.
1346 instruction = new_and;
1347 input_other = new_and_input;
1348 }
Vladimir Marko452c1b62015-09-25 14:44:17 +01001349 // Eliminate And from UShr+And if the And-mask contains all the bits that
1350 // can be non-zero after UShr. Transform Shr+And to UShr if the And-mask
1351 // precisely clears the shifted-in sign bits.
1352 if ((input_other->IsUShr() || input_other->IsShr()) && input_other->InputAt(1)->IsConstant()) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001353 size_t reg_bits = (instruction->GetResultType() == DataType::Type::kInt64) ? 64 : 32;
Vladimir Marko452c1b62015-09-25 14:44:17 +01001354 size_t shift = Int64FromConstant(input_other->InputAt(1)->AsConstant()) & (reg_bits - 1);
1355 size_t num_tail_bits_set = CTZ(value + 1);
1356 if ((num_tail_bits_set >= reg_bits - shift) && input_other->IsUShr()) {
1357 // This AND clears only bits known to be clear, for example "(x >>> 24) & 0xff".
1358 instruction->ReplaceWith(input_other);
1359 instruction->GetBlock()->RemoveInstruction(instruction);
1360 RecordSimplification();
1361 return;
1362 } else if ((num_tail_bits_set == reg_bits - shift) && IsPowerOfTwo(value + 1) &&
1363 input_other->HasOnlyOneNonEnvironmentUse()) {
1364 DCHECK(input_other->IsShr()); // For UShr, we would have taken the branch above.
1365 // Replace SHR+AND with USHR, for example "(x >> 24) & 0xff" -> "x >>> 24".
Vladimir Markoca6fff82017-10-03 14:49:14 +01001366 HUShr* ushr = new (GetGraph()->GetAllocator()) HUShr(instruction->GetType(),
Vladimir Marko69d310e2017-10-09 14:12:23 +01001367 input_other->InputAt(0),
1368 input_other->InputAt(1),
1369 input_other->GetDexPc());
Vladimir Marko452c1b62015-09-25 14:44:17 +01001370 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, ushr);
1371 input_other->GetBlock()->RemoveInstruction(input_other);
1372 RecordSimplification();
1373 return;
1374 }
1375 }
Vladimir Marko61b92282017-10-11 13:23:17 +01001376 if ((value == 0xff || value == 0xffff) && instruction->GetType() != DataType::Type::kInt64) {
1377 // Transform AND to a type conversion to Uint8/Uint16. If `input_other` is a field
1378 // or array Get with only a single use, short-circuit the subsequent simplification
1379 // of the Get+TypeConversion and change the Get's type to `new_type` instead.
1380 DataType::Type new_type = (value == 0xff) ? DataType::Type::kUint8 : DataType::Type::kUint16;
1381 DataType::Type find_type = (value == 0xff) ? DataType::Type::kInt8 : DataType::Type::kInt16;
1382 if (input_other->GetType() == find_type &&
1383 input_other->HasOnlyOneNonEnvironmentUse() &&
1384 TryReplaceFieldOrArrayGetType(input_other, new_type)) {
1385 instruction->ReplaceWith(input_other);
1386 instruction->GetBlock()->RemoveInstruction(instruction);
Aart Bikdab69072017-10-23 13:30:39 -07001387 } else if (DataType::IsTypeConversionImplicit(input_other->GetType(), new_type)) {
1388 instruction->ReplaceWith(input_other);
1389 instruction->GetBlock()->RemoveInstruction(instruction);
Vladimir Marko61b92282017-10-11 13:23:17 +01001390 } else {
1391 HTypeConversion* type_conversion = new (GetGraph()->GetAllocator()) HTypeConversion(
1392 new_type, input_other, instruction->GetDexPc());
1393 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, type_conversion);
1394 }
1395 RecordSimplification();
1396 return;
1397 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001398 }
1399
1400 // We assume that GVN has run before, so we only perform a pointer comparison.
1401 // If for some reason the values are equal but the pointers are different, we
Alexandre Rames188d4312015-04-09 18:30:21 +01001402 // are still correct and only miss an optimization opportunity.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001403 if (instruction->GetLeft() == instruction->GetRight()) {
1404 // Replace code looking like
1405 // AND dst, src, src
1406 // with
1407 // src
1408 instruction->ReplaceWith(instruction->GetLeft());
1409 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001410 RecordSimplification();
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001411 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001412 }
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001413
Anton Kirilove14dc862016-05-13 17:56:15 +01001414 if (TryDeMorganNegationFactoring(instruction)) {
1415 return;
1416 }
1417
1418 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1419 // so no need to return.
1420 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001421}
1422
Mark Mendellc4701932015-04-10 13:18:51 -04001423void InstructionSimplifierVisitor::VisitGreaterThan(HGreaterThan* condition) {
1424 VisitCondition(condition);
1425}
1426
1427void InstructionSimplifierVisitor::VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) {
1428 VisitCondition(condition);
1429}
1430
1431void InstructionSimplifierVisitor::VisitLessThan(HLessThan* condition) {
1432 VisitCondition(condition);
1433}
1434
1435void InstructionSimplifierVisitor::VisitLessThanOrEqual(HLessThanOrEqual* condition) {
1436 VisitCondition(condition);
1437}
1438
Anton Shaminbdd79352016-02-15 12:48:36 +06001439void InstructionSimplifierVisitor::VisitBelow(HBelow* condition) {
1440 VisitCondition(condition);
1441}
1442
1443void InstructionSimplifierVisitor::VisitBelowOrEqual(HBelowOrEqual* condition) {
1444 VisitCondition(condition);
1445}
1446
1447void InstructionSimplifierVisitor::VisitAbove(HAbove* condition) {
1448 VisitCondition(condition);
1449}
1450
1451void InstructionSimplifierVisitor::VisitAboveOrEqual(HAboveOrEqual* condition) {
1452 VisitCondition(condition);
1453}
Aart Bike9f37602015-10-09 11:15:55 -07001454
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001455// Recognize the following pattern:
1456// obj.getClass() ==/!= Foo.class
1457// And replace it with a constant value if the type of `obj` is statically known.
1458static bool RecognizeAndSimplifyClassCheck(HCondition* condition) {
1459 HInstruction* input_one = condition->InputAt(0);
1460 HInstruction* input_two = condition->InputAt(1);
1461 HLoadClass* load_class = input_one->IsLoadClass()
1462 ? input_one->AsLoadClass()
1463 : input_two->AsLoadClass();
1464 if (load_class == nullptr) {
1465 return false;
1466 }
1467
1468 ReferenceTypeInfo class_rti = load_class->GetLoadedClassRTI();
1469 if (!class_rti.IsValid()) {
1470 // Unresolved class.
1471 return false;
1472 }
1473
1474 HInstanceFieldGet* field_get = (load_class == input_one)
1475 ? input_two->AsInstanceFieldGet()
1476 : input_one->AsInstanceFieldGet();
1477 if (field_get == nullptr) {
1478 return false;
1479 }
1480
1481 HInstruction* receiver = field_get->InputAt(0);
1482 ReferenceTypeInfo receiver_type = receiver->GetReferenceTypeInfo();
1483 if (!receiver_type.IsExact()) {
1484 return false;
1485 }
1486
1487 {
1488 ScopedObjectAccess soa(Thread::Current());
1489 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1490 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
1491 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
1492 if (field_get->GetFieldInfo().GetField() != field) {
1493 return false;
1494 }
1495
1496 // We can replace the compare.
1497 int value = 0;
1498 if (receiver_type.IsEqual(class_rti)) {
1499 value = condition->IsEqual() ? 1 : 0;
1500 } else {
1501 value = condition->IsNotEqual() ? 1 : 0;
1502 }
1503 condition->ReplaceWith(condition->GetBlock()->GetGraph()->GetIntConstant(value));
1504 return true;
1505 }
1506}
1507
Mark Mendellc4701932015-04-10 13:18:51 -04001508void InstructionSimplifierVisitor::VisitCondition(HCondition* condition) {
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001509 if (condition->IsEqual() || condition->IsNotEqual()) {
1510 if (RecognizeAndSimplifyClassCheck(condition)) {
1511 return;
1512 }
1513 }
1514
Anton Shaminbdd79352016-02-15 12:48:36 +06001515 // Reverse condition if left is constant. Our code generators prefer constant
1516 // on the right hand side.
1517 if (condition->GetLeft()->IsConstant() && !condition->GetRight()->IsConstant()) {
1518 HBasicBlock* block = condition->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001519 HCondition* replacement =
1520 GetOppositeConditionSwapOps(block->GetGraph()->GetAllocator(), condition);
Anton Shaminbdd79352016-02-15 12:48:36 +06001521 // If it is a fp we must set the opposite bias.
1522 if (replacement != nullptr) {
1523 if (condition->IsLtBias()) {
1524 replacement->SetBias(ComparisonBias::kGtBias);
1525 } else if (condition->IsGtBias()) {
1526 replacement->SetBias(ComparisonBias::kLtBias);
1527 }
1528 block->ReplaceAndRemoveInstructionWith(condition, replacement);
1529 RecordSimplification();
1530
1531 condition = replacement;
1532 }
1533 }
Mark Mendellc4701932015-04-10 13:18:51 -04001534
Mark Mendellc4701932015-04-10 13:18:51 -04001535 HInstruction* left = condition->GetLeft();
1536 HInstruction* right = condition->GetRight();
Anton Shaminbdd79352016-02-15 12:48:36 +06001537
1538 // Try to fold an HCompare into this HCondition.
1539
Mark Mendellc4701932015-04-10 13:18:51 -04001540 // We can only replace an HCondition which compares a Compare to 0.
1541 // Both 'dx' and 'jack' generate a compare to 0 when compiling a
1542 // condition with a long, float or double comparison as input.
1543 if (!left->IsCompare() || !right->IsConstant() || right->AsIntConstant()->GetValue() != 0) {
1544 // Conversion is not possible.
1545 return;
1546 }
1547
1548 // Is the Compare only used for this purpose?
Vladimir Marko46817b82016-03-29 12:21:58 +01001549 if (!left->GetUses().HasExactlyOneElement()) {
Mark Mendellc4701932015-04-10 13:18:51 -04001550 // Someone else also wants the result of the compare.
1551 return;
1552 }
1553
Vladimir Marko46817b82016-03-29 12:21:58 +01001554 if (!left->GetEnvUses().empty()) {
Mark Mendellc4701932015-04-10 13:18:51 -04001555 // There is a reference to the compare result in an environment. Do we really need it?
1556 if (GetGraph()->IsDebuggable()) {
1557 return;
1558 }
1559
1560 // We have to ensure that there are no deopt points in the sequence.
1561 if (left->HasAnyEnvironmentUseBefore(condition)) {
1562 return;
1563 }
1564 }
1565
1566 // Clean up any environment uses from the HCompare, if any.
1567 left->RemoveEnvironmentUsers();
1568
1569 // We have decided to fold the HCompare into the HCondition. Transfer the information.
1570 condition->SetBias(left->AsCompare()->GetBias());
1571
1572 // Replace the operands of the HCondition.
1573 condition->ReplaceInput(left->InputAt(0), 0);
1574 condition->ReplaceInput(left->InputAt(1), 1);
1575
1576 // Remove the HCompare.
1577 left->GetBlock()->RemoveInstruction(left);
1578
1579 RecordSimplification();
1580}
1581
Andreas Gampe9186ced2016-12-12 14:28:21 -08001582// Return whether x / divisor == x * (1.0f / divisor), for every float x.
1583static constexpr bool CanDivideByReciprocalMultiplyFloat(int32_t divisor) {
1584 // True, if the most significant bits of divisor are 0.
1585 return ((divisor & 0x7fffff) == 0);
1586}
1587
1588// Return whether x / divisor == x * (1.0 / divisor), for every double x.
1589static constexpr bool CanDivideByReciprocalMultiplyDouble(int64_t divisor) {
1590 // True, if the most significant bits of divisor are 0.
1591 return ((divisor & ((UINT64_C(1) << 52) - 1)) == 0);
1592}
1593
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001594void InstructionSimplifierVisitor::VisitDiv(HDiv* instruction) {
1595 HConstant* input_cst = instruction->GetConstantRight();
1596 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001597 DataType::Type type = instruction->GetType();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001598
1599 if ((input_cst != nullptr) && input_cst->IsOne()) {
1600 // Replace code looking like
1601 // DIV dst, src, 1
1602 // with
1603 // src
1604 instruction->ReplaceWith(input_other);
1605 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001606 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001607 return;
1608 }
1609
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001610 if ((input_cst != nullptr) && input_cst->IsMinusOne()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001611 // Replace code looking like
1612 // DIV dst, src, -1
1613 // with
1614 // NEG dst, src
1615 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(
Vladimir Markoca6fff82017-10-03 14:49:14 +01001616 instruction, new (GetGraph()->GetAllocator()) HNeg(type, input_other));
Alexandre Rames188d4312015-04-09 18:30:21 +01001617 RecordSimplification();
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001618 return;
1619 }
1620
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001621 if ((input_cst != nullptr) && DataType::IsFloatingPointType(type)) {
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001622 // Try replacing code looking like
1623 // DIV dst, src, constant
1624 // with
1625 // MUL dst, src, 1 / constant
1626 HConstant* reciprocal = nullptr;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001627 if (type == DataType::Type::kFloat64) {
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001628 double value = input_cst->AsDoubleConstant()->GetValue();
1629 if (CanDivideByReciprocalMultiplyDouble(bit_cast<int64_t, double>(value))) {
1630 reciprocal = GetGraph()->GetDoubleConstant(1.0 / value);
1631 }
1632 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001633 DCHECK_EQ(type, DataType::Type::kFloat32);
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001634 float value = input_cst->AsFloatConstant()->GetValue();
1635 if (CanDivideByReciprocalMultiplyFloat(bit_cast<int32_t, float>(value))) {
1636 reciprocal = GetGraph()->GetFloatConstant(1.0f / value);
1637 }
1638 }
1639
1640 if (reciprocal != nullptr) {
1641 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(
Vladimir Markoca6fff82017-10-03 14:49:14 +01001642 instruction, new (GetGraph()->GetAllocator()) HMul(type, input_other, reciprocal));
Nicolas Geoffray0d221842015-04-27 08:53:46 +00001643 RecordSimplification();
1644 return;
1645 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001646 }
1647}
1648
1649void InstructionSimplifierVisitor::VisitMul(HMul* instruction) {
1650 HConstant* input_cst = instruction->GetConstantRight();
1651 HInstruction* input_other = instruction->GetLeastConstantLeft();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001652 DataType::Type type = instruction->GetType();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001653 HBasicBlock* block = instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001654 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001655
1656 if (input_cst == nullptr) {
1657 return;
1658 }
1659
1660 if (input_cst->IsOne()) {
1661 // Replace code looking like
1662 // MUL dst, src, 1
1663 // with
1664 // src
1665 instruction->ReplaceWith(input_other);
1666 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001667 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001668 return;
1669 }
1670
1671 if (input_cst->IsMinusOne() &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001672 (DataType::IsFloatingPointType(type) || DataType::IsIntOrLongType(type))) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001673 // Replace code looking like
1674 // MUL dst, src, -1
1675 // with
1676 // NEG dst, src
1677 HNeg* neg = new (allocator) HNeg(type, input_other);
1678 block->ReplaceAndRemoveInstructionWith(instruction, neg);
Alexandre Rames188d4312015-04-09 18:30:21 +01001679 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001680 return;
1681 }
1682
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001683 if (DataType::IsFloatingPointType(type) &&
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001684 ((input_cst->IsFloatConstant() && input_cst->AsFloatConstant()->GetValue() == 2.0f) ||
1685 (input_cst->IsDoubleConstant() && input_cst->AsDoubleConstant()->GetValue() == 2.0))) {
1686 // Replace code looking like
1687 // FP_MUL dst, src, 2.0
1688 // with
1689 // FP_ADD dst, src, src
1690 // The 'int' and 'long' cases are handled below.
1691 block->ReplaceAndRemoveInstructionWith(instruction,
1692 new (allocator) HAdd(type, input_other, input_other));
Alexandre Rames188d4312015-04-09 18:30:21 +01001693 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001694 return;
1695 }
1696
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001697 if (DataType::IsIntOrLongType(type)) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001698 int64_t factor = Int64FromConstant(input_cst);
Serguei Katkov53849192015-04-20 14:22:27 +06001699 // Even though constant propagation also takes care of the zero case, other
1700 // optimizations can lead to having a zero multiplication.
1701 if (factor == 0) {
1702 // Replace code looking like
1703 // MUL dst, src, 0
1704 // with
1705 // 0
1706 instruction->ReplaceWith(input_cst);
1707 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001708 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001709 return;
Serguei Katkov53849192015-04-20 14:22:27 +06001710 } else if (IsPowerOfTwo(factor)) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001711 // Replace code looking like
1712 // MUL dst, src, pow_of_2
1713 // with
1714 // SHL dst, src, log2(pow_of_2)
David Brazdil8d5b8b22015-03-24 10:51:52 +00001715 HIntConstant* shift = GetGraph()->GetIntConstant(WhichPowerOf2(factor));
Roland Levillain22c49222016-03-18 14:04:28 +00001716 HShl* shl = new (allocator) HShl(type, input_other, shift);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001717 block->ReplaceAndRemoveInstructionWith(instruction, shl);
Alexandre Rames188d4312015-04-09 18:30:21 +01001718 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001719 return;
Alexandre Rames38db7852015-11-20 15:02:45 +00001720 } else if (IsPowerOfTwo(factor - 1)) {
1721 // Transform code looking like
1722 // MUL dst, src, (2^n + 1)
1723 // into
1724 // SHL tmp, src, n
1725 // ADD dst, src, tmp
1726 HShl* shl = new (allocator) HShl(type,
1727 input_other,
1728 GetGraph()->GetIntConstant(WhichPowerOf2(factor - 1)));
1729 HAdd* add = new (allocator) HAdd(type, input_other, shl);
1730
1731 block->InsertInstructionBefore(shl, instruction);
1732 block->ReplaceAndRemoveInstructionWith(instruction, add);
1733 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001734 return;
Alexandre Rames38db7852015-11-20 15:02:45 +00001735 } else if (IsPowerOfTwo(factor + 1)) {
1736 // Transform code looking like
1737 // MUL dst, src, (2^n - 1)
1738 // into
1739 // SHL tmp, src, n
1740 // SUB dst, tmp, src
1741 HShl* shl = new (allocator) HShl(type,
1742 input_other,
1743 GetGraph()->GetIntConstant(WhichPowerOf2(factor + 1)));
1744 HSub* sub = new (allocator) HSub(type, shl, input_other);
1745
1746 block->InsertInstructionBefore(shl, instruction);
1747 block->ReplaceAndRemoveInstructionWith(instruction, sub);
1748 RecordSimplification();
Anton Kirilove14dc862016-05-13 17:56:15 +01001749 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001750 }
1751 }
Anton Kirilove14dc862016-05-13 17:56:15 +01001752
1753 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1754 // so no need to return.
1755 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001756}
1757
Alexandre Rames188d4312015-04-09 18:30:21 +01001758void InstructionSimplifierVisitor::VisitNeg(HNeg* instruction) {
1759 HInstruction* input = instruction->GetInput();
1760 if (input->IsNeg()) {
1761 // Replace code looking like
1762 // NEG tmp, src
1763 // NEG dst, tmp
1764 // with
1765 // src
1766 HNeg* previous_neg = input->AsNeg();
1767 instruction->ReplaceWith(previous_neg->GetInput());
1768 instruction->GetBlock()->RemoveInstruction(instruction);
1769 // We perform the optimization even if the input negation has environment
1770 // uses since it allows removing the current instruction. But we only delete
1771 // the input negation only if it is does not have any uses left.
1772 if (!previous_neg->HasUses()) {
1773 previous_neg->GetBlock()->RemoveInstruction(previous_neg);
1774 }
1775 RecordSimplification();
1776 return;
1777 }
1778
Serguei Katkov339dfc22015-04-20 12:29:32 +06001779 if (input->IsSub() && input->HasOnlyOneNonEnvironmentUse() &&
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001780 !DataType::IsFloatingPointType(input->GetType())) {
Alexandre Rames188d4312015-04-09 18:30:21 +01001781 // Replace code looking like
1782 // SUB tmp, a, b
1783 // NEG dst, tmp
1784 // with
1785 // SUB dst, b, a
1786 // We do not perform the optimization if the input subtraction has
1787 // environment uses or multiple non-environment uses as it could lead to
1788 // worse code. In particular, we do not want the live ranges of `a` and `b`
1789 // to be extended if we are not sure the initial 'SUB' instruction can be
1790 // removed.
Serguei Katkov339dfc22015-04-20 12:29:32 +06001791 // We do not perform optimization for fp because we could lose the sign of zero.
Alexandre Rames188d4312015-04-09 18:30:21 +01001792 HSub* sub = input->AsSub();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001793 HSub* new_sub = new (GetGraph()->GetAllocator()) HSub(
1794 instruction->GetType(), sub->GetRight(), sub->GetLeft());
Alexandre Rames188d4312015-04-09 18:30:21 +01001795 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, new_sub);
1796 if (!sub->HasUses()) {
1797 sub->GetBlock()->RemoveInstruction(sub);
1798 }
1799 RecordSimplification();
1800 }
1801}
1802
1803void InstructionSimplifierVisitor::VisitNot(HNot* instruction) {
1804 HInstruction* input = instruction->GetInput();
1805 if (input->IsNot()) {
1806 // Replace code looking like
1807 // NOT tmp, src
1808 // NOT dst, tmp
1809 // with
1810 // src
1811 // We perform the optimization even if the input negation has environment
1812 // uses since it allows removing the current instruction. But we only delete
1813 // the input negation only if it is does not have any uses left.
1814 HNot* previous_not = input->AsNot();
1815 instruction->ReplaceWith(previous_not->GetInput());
1816 instruction->GetBlock()->RemoveInstruction(instruction);
1817 if (!previous_not->HasUses()) {
1818 previous_not->GetBlock()->RemoveInstruction(previous_not);
1819 }
1820 RecordSimplification();
1821 }
1822}
1823
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001824void InstructionSimplifierVisitor::VisitOr(HOr* instruction) {
1825 HConstant* input_cst = instruction->GetConstantRight();
1826 HInstruction* input_other = instruction->GetLeastConstantLeft();
1827
Roland Levillain1a653882016-03-18 18:05:57 +00001828 if ((input_cst != nullptr) && input_cst->IsZeroBitPattern()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001829 // Replace code looking like
1830 // OR dst, src, 0
1831 // with
1832 // src
1833 instruction->ReplaceWith(input_other);
1834 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001835 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001836 return;
1837 }
1838
1839 // We assume that GVN has run before, so we only perform a pointer comparison.
1840 // If for some reason the values are equal but the pointers are different, we
Alexandre Rames188d4312015-04-09 18:30:21 +01001841 // are still correct and only miss an optimization opportunity.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001842 if (instruction->GetLeft() == instruction->GetRight()) {
1843 // Replace code looking like
1844 // OR dst, src, src
1845 // with
1846 // src
1847 instruction->ReplaceWith(instruction->GetLeft());
1848 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001849 RecordSimplification();
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001850 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001851 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00001852
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00001853 if (TryDeMorganNegationFactoring(instruction)) return;
1854
Anton Kirilove14dc862016-05-13 17:56:15 +01001855 if (TryReplaceWithRotate(instruction)) {
1856 return;
1857 }
1858
1859 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
1860 // so no need to return.
1861 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001862}
1863
1864void InstructionSimplifierVisitor::VisitShl(HShl* instruction) {
1865 VisitShift(instruction);
1866}
1867
1868void InstructionSimplifierVisitor::VisitShr(HShr* instruction) {
1869 VisitShift(instruction);
1870}
1871
1872void InstructionSimplifierVisitor::VisitSub(HSub* instruction) {
1873 HConstant* input_cst = instruction->GetConstantRight();
1874 HInstruction* input_other = instruction->GetLeastConstantLeft();
1875
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001876 DataType::Type type = instruction->GetType();
1877 if (DataType::IsFloatingPointType(type)) {
Serguei Katkov115b53f2015-08-05 17:03:30 +06001878 return;
1879 }
1880
Roland Levillain1a653882016-03-18 18:05:57 +00001881 if ((input_cst != nullptr) && input_cst->IsArithmeticZero()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001882 // Replace code looking like
1883 // SUB dst, src, 0
1884 // with
1885 // src
Serguei Katkov115b53f2015-08-05 17:03:30 +06001886 // Note that we cannot optimize `x - 0.0` to `x` for floating-point. When
1887 // `x` is `-0.0`, the former expression yields `0.0`, while the later
1888 // yields `-0.0`.
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001889 instruction->ReplaceWith(input_other);
1890 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001891 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001892 return;
1893 }
1894
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001895 HBasicBlock* block = instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001896 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001897
Alexandre Rames188d4312015-04-09 18:30:21 +01001898 HInstruction* left = instruction->GetLeft();
1899 HInstruction* right = instruction->GetRight();
1900 if (left->IsConstant()) {
1901 if (Int64FromConstant(left->AsConstant()) == 0) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001902 // Replace code looking like
1903 // SUB dst, 0, src
1904 // with
1905 // NEG dst, src
Alexandre Rames188d4312015-04-09 18:30:21 +01001906 // Note that we cannot optimize `0.0 - x` to `-x` for floating-point. When
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001907 // `x` is `0.0`, the former expression yields `0.0`, while the later
1908 // yields `-0.0`.
Alexandre Rames188d4312015-04-09 18:30:21 +01001909 HNeg* neg = new (allocator) HNeg(type, right);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001910 block->ReplaceAndRemoveInstructionWith(instruction, neg);
Alexandre Rames188d4312015-04-09 18:30:21 +01001911 RecordSimplification();
1912 return;
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001913 }
1914 }
Alexandre Rames188d4312015-04-09 18:30:21 +01001915
1916 if (left->IsNeg() && right->IsNeg()) {
1917 if (TryMoveNegOnInputsAfterBinop(instruction)) {
1918 return;
1919 }
1920 }
1921
1922 if (right->IsNeg() && right->HasOnlyOneNonEnvironmentUse()) {
1923 // Replace code looking like
1924 // NEG tmp, b
1925 // SUB dst, a, tmp
1926 // with
1927 // ADD dst, a, b
Vladimir Markoca6fff82017-10-03 14:49:14 +01001928 HAdd* add = new(GetGraph()->GetAllocator()) HAdd(type, left, right->AsNeg()->GetInput());
Alexandre Rames188d4312015-04-09 18:30:21 +01001929 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, add);
1930 RecordSimplification();
1931 right->GetBlock()->RemoveInstruction(right);
1932 return;
1933 }
1934
1935 if (left->IsNeg() && left->HasOnlyOneNonEnvironmentUse()) {
1936 // Replace code looking like
1937 // NEG tmp, a
1938 // SUB dst, tmp, b
1939 // with
1940 // ADD tmp, a, b
1941 // NEG dst, tmp
1942 // The second version is not intrinsically better, but enables more
1943 // transformations.
Vladimir Markoca6fff82017-10-03 14:49:14 +01001944 HAdd* add = new(GetGraph()->GetAllocator()) HAdd(type, left->AsNeg()->GetInput(), right);
Alexandre Rames188d4312015-04-09 18:30:21 +01001945 instruction->GetBlock()->InsertInstructionBefore(add, instruction);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001946 HNeg* neg = new (GetGraph()->GetAllocator()) HNeg(instruction->GetType(), add);
Alexandre Rames188d4312015-04-09 18:30:21 +01001947 instruction->GetBlock()->InsertInstructionBefore(neg, instruction);
1948 instruction->ReplaceWith(neg);
1949 instruction->GetBlock()->RemoveInstruction(instruction);
1950 RecordSimplification();
1951 left->GetBlock()->RemoveInstruction(left);
Anton Kirilove14dc862016-05-13 17:56:15 +01001952 return;
1953 }
1954
1955 if (TrySubtractionChainSimplification(instruction)) {
1956 return;
Alexandre Rames188d4312015-04-09 18:30:21 +01001957 }
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001958
1959 if (left->IsAdd()) {
1960 // Replace code patterns looking like
1961 // ADD dst1, x, y ADD dst1, x, y
1962 // SUB dst2, dst1, y SUB dst2, dst1, x
1963 // with
1964 // ADD dst1, x, y
1965 // SUB instruction is not needed in this case, we may use
1966 // one of inputs of ADD instead.
1967 // It is applicable to integral types only.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001968 DCHECK(DataType::IsIntegralType(type));
Maxim Kazantsevd3278bd2016-07-12 15:55:33 +06001969 if (left->InputAt(1) == right) {
1970 instruction->ReplaceWith(left->InputAt(0));
1971 RecordSimplification();
1972 instruction->GetBlock()->RemoveInstruction(instruction);
1973 return;
1974 } else if (left->InputAt(0) == right) {
1975 instruction->ReplaceWith(left->InputAt(1));
1976 RecordSimplification();
1977 instruction->GetBlock()->RemoveInstruction(instruction);
1978 return;
1979 }
1980 }
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001981}
1982
1983void InstructionSimplifierVisitor::VisitUShr(HUShr* instruction) {
1984 VisitShift(instruction);
1985}
1986
1987void InstructionSimplifierVisitor::VisitXor(HXor* instruction) {
1988 HConstant* input_cst = instruction->GetConstantRight();
1989 HInstruction* input_other = instruction->GetLeastConstantLeft();
1990
Roland Levillain1a653882016-03-18 18:05:57 +00001991 if ((input_cst != nullptr) && input_cst->IsZeroBitPattern()) {
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001992 // Replace code looking like
1993 // XOR dst, src, 0
1994 // with
1995 // src
1996 instruction->ReplaceWith(input_other);
1997 instruction->GetBlock()->RemoveInstruction(instruction);
Alexandre Ramesc5809c32016-05-25 15:01:06 +01001998 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00001999 return;
2000 }
2001
Sebastien Hertz9837caf2016-08-01 11:09:50 +02002002 if ((input_cst != nullptr) && input_cst->IsOne()
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002003 && input_other->GetType() == DataType::Type::kBool) {
Sebastien Hertz9837caf2016-08-01 11:09:50 +02002004 // Replace code looking like
2005 // XOR dst, src, 1
2006 // with
2007 // BOOLEAN_NOT dst, src
Vladimir Markoca6fff82017-10-03 14:49:14 +01002008 HBooleanNot* boolean_not = new (GetGraph()->GetAllocator()) HBooleanNot(input_other);
Sebastien Hertz9837caf2016-08-01 11:09:50 +02002009 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, boolean_not);
2010 RecordSimplification();
2011 return;
2012 }
2013
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00002014 if ((input_cst != nullptr) && AreAllBitsSet(input_cst)) {
2015 // Replace code looking like
2016 // XOR dst, src, 0xFFF...FF
2017 // with
2018 // NOT dst, src
Vladimir Markoca6fff82017-10-03 14:49:14 +01002019 HNot* bitwise_not = new (GetGraph()->GetAllocator()) HNot(instruction->GetType(), input_other);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00002020 instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, bitwise_not);
Alexandre Rames188d4312015-04-09 18:30:21 +01002021 RecordSimplification();
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00002022 return;
2023 }
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002024
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00002025 HInstruction* left = instruction->GetLeft();
2026 HInstruction* right = instruction->GetRight();
Alexandre Rames9f980252016-02-05 14:00:28 +00002027 if (((left->IsNot() && right->IsNot()) ||
2028 (left->IsBooleanNot() && right->IsBooleanNot())) &&
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00002029 left->HasOnlyOneNonEnvironmentUse() &&
2030 right->HasOnlyOneNonEnvironmentUse()) {
2031 // Replace code looking like
2032 // NOT nota, a
2033 // NOT notb, b
2034 // XOR dst, nota, notb
2035 // with
2036 // XOR dst, a, b
Alexandre Rames9f980252016-02-05 14:00:28 +00002037 instruction->ReplaceInput(left->InputAt(0), 0);
2038 instruction->ReplaceInput(right->InputAt(0), 1);
Alexandre Ramesca0e3a02016-02-03 10:54:07 +00002039 left->GetBlock()->RemoveInstruction(left);
2040 right->GetBlock()->RemoveInstruction(right);
2041 RecordSimplification();
2042 return;
2043 }
2044
Anton Kirilove14dc862016-05-13 17:56:15 +01002045 if (TryReplaceWithRotate(instruction)) {
2046 return;
2047 }
2048
2049 // TryHandleAssociativeAndCommutativeOperation() does not remove its input,
2050 // so no need to return.
2051 TryHandleAssociativeAndCommutativeOperation(instruction);
Alexandre Ramesb2fd7bc2015-03-11 16:48:16 +00002052}
2053
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002054void InstructionSimplifierVisitor::SimplifyStringEquals(HInvoke* instruction) {
2055 HInstruction* argument = instruction->InputAt(1);
2056 HInstruction* receiver = instruction->InputAt(0);
2057 if (receiver == argument) {
2058 // Because String.equals is an instance call, the receiver is
2059 // a null check if we don't know it's null. The argument however, will
2060 // be the actual object. So we cannot end up in a situation where both
2061 // are equal but could be null.
2062 DCHECK(CanEnsureNotNullAt(argument, instruction));
2063 instruction->ReplaceWith(GetGraph()->GetIntConstant(1));
2064 instruction->GetBlock()->RemoveInstruction(instruction);
2065 } else {
2066 StringEqualsOptimizations optimizations(instruction);
2067 if (CanEnsureNotNullAt(argument, instruction)) {
2068 optimizations.SetArgumentNotNull();
2069 }
2070 ScopedObjectAccess soa(Thread::Current());
2071 ReferenceTypeInfo argument_rti = argument->GetReferenceTypeInfo();
2072 if (argument_rti.IsValid() && argument_rti.IsStringClass()) {
2073 optimizations.SetArgumentIsString();
Vladimir Markoda283052017-11-07 21:17:24 +00002074 } else if (kUseReadBarrier) {
2075 DCHECK(instruction->GetResolvedMethod() != nullptr);
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08002076 DCHECK(instruction->GetResolvedMethod()->GetDeclaringClass()->IsStringClass() ||
2077 // Object.equals() can be devirtualized to String.equals().
2078 instruction->GetResolvedMethod()->GetDeclaringClass()->IsObjectClass());
Vladimir Markoda283052017-11-07 21:17:24 +00002079 Runtime* runtime = Runtime::Current();
2080 // For AOT, we always assume that the boot image shall contain the String.class and
2081 // we do not need a read barrier for boot image classes as they are non-moveable.
2082 // For JIT, check if we actually have a boot image; if we do, the String.class
2083 // should also be non-moveable.
2084 if (runtime->IsAotCompiler() || runtime->GetHeap()->HasBootImageSpace()) {
2085 DCHECK(runtime->IsAotCompiler() ||
2086 !runtime->GetHeap()->IsMovableObject(
2087 instruction->GetResolvedMethod()->GetDeclaringClass()));
2088 optimizations.SetNoReadBarrierForStringClass();
2089 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002090 }
2091 }
2092}
2093
Roland Levillain22c49222016-03-18 14:04:28 +00002094void InstructionSimplifierVisitor::SimplifyRotate(HInvoke* invoke,
2095 bool is_left,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002096 DataType::Type type) {
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002097 DCHECK(invoke->IsInvokeStaticOrDirect());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01002098 DCHECK_EQ(invoke->GetInvokeType(), InvokeType::kStatic);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002099 HInstruction* value = invoke->InputAt(0);
2100 HInstruction* distance = invoke->InputAt(1);
2101 // Replace the invoke with an HRor.
2102 if (is_left) {
Roland Levillain937e6cd2016-03-22 11:54:37 +00002103 // Unconditionally set the type of the negated distance to `int`,
2104 // as shift and rotate operations expect a 32-bit (or narrower)
2105 // value for their distance input.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002106 distance = new (GetGraph()->GetAllocator()) HNeg(DataType::Type::kInt32, distance);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002107 invoke->GetBlock()->InsertInstructionBefore(distance, invoke);
2108 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01002109 HRor* ror = new (GetGraph()->GetAllocator()) HRor(type, value, distance);
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002110 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, ror);
2111 // Remove ClinitCheck and LoadClass, if possible.
Vladimir Marko372f10e2016-05-17 16:30:10 +01002112 HInstruction* clinit = invoke->GetInputs().back();
Scott Wakeling40a04bf2015-12-11 09:50:36 +00002113 if (clinit->IsClinitCheck() && !clinit->HasUses()) {
2114 clinit->GetBlock()->RemoveInstruction(clinit);
2115 HInstruction* ldclass = clinit->InputAt(0);
2116 if (ldclass->IsLoadClass() && !ldclass->HasUses()) {
2117 ldclass->GetBlock()->RemoveInstruction(ldclass);
2118 }
2119 }
2120}
2121
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002122static bool IsArrayLengthOf(HInstruction* potential_length, HInstruction* potential_array) {
2123 if (potential_length->IsArrayLength()) {
2124 return potential_length->InputAt(0) == potential_array;
2125 }
2126
2127 if (potential_array->IsNewArray()) {
Nicolas Geoffraye761bcc2017-01-19 08:59:37 +00002128 return potential_array->AsNewArray()->GetLength() == potential_length;
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002129 }
2130
2131 return false;
2132}
2133
2134void InstructionSimplifierVisitor::SimplifySystemArrayCopy(HInvoke* instruction) {
2135 HInstruction* source = instruction->InputAt(0);
2136 HInstruction* destination = instruction->InputAt(2);
2137 HInstruction* count = instruction->InputAt(4);
2138 SystemArrayCopyOptimizations optimizations(instruction);
2139 if (CanEnsureNotNullAt(source, instruction)) {
2140 optimizations.SetSourceIsNotNull();
2141 }
2142 if (CanEnsureNotNullAt(destination, instruction)) {
2143 optimizations.SetDestinationIsNotNull();
2144 }
2145 if (destination == source) {
2146 optimizations.SetDestinationIsSource();
2147 }
2148
2149 if (IsArrayLengthOf(count, source)) {
2150 optimizations.SetCountIsSourceLength();
2151 }
2152
2153 if (IsArrayLengthOf(count, destination)) {
2154 optimizations.SetCountIsDestinationLength();
2155 }
2156
2157 {
2158 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002159 DataType::Type source_component_type = DataType::Type::kVoid;
2160 DataType::Type destination_component_type = DataType::Type::kVoid;
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002161 ReferenceTypeInfo destination_rti = destination->GetReferenceTypeInfo();
2162 if (destination_rti.IsValid()) {
2163 if (destination_rti.IsObjectArray()) {
2164 if (destination_rti.IsExact()) {
2165 optimizations.SetDoesNotNeedTypeCheck();
2166 }
2167 optimizations.SetDestinationIsTypedObjectArray();
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002168 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002169 if (destination_rti.IsPrimitiveArrayClass()) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002170 destination_component_type = DataTypeFromPrimitive(
2171 destination_rti.GetTypeHandle()->GetComponentType()->GetPrimitiveType());
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002172 optimizations.SetDestinationIsPrimitiveArray();
2173 } else if (destination_rti.IsNonPrimitiveArrayClass()) {
2174 optimizations.SetDestinationIsNonPrimitiveArray();
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002175 }
2176 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002177 ReferenceTypeInfo source_rti = source->GetReferenceTypeInfo();
2178 if (source_rti.IsValid()) {
2179 if (destination_rti.IsValid() && destination_rti.CanArrayHoldValuesOf(source_rti)) {
2180 optimizations.SetDoesNotNeedTypeCheck();
2181 }
2182 if (source_rti.IsPrimitiveArrayClass()) {
2183 optimizations.SetSourceIsPrimitiveArray();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002184 source_component_type = DataTypeFromPrimitive(
2185 source_rti.GetTypeHandle()->GetComponentType()->GetPrimitiveType());
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002186 } else if (source_rti.IsNonPrimitiveArrayClass()) {
2187 optimizations.SetSourceIsNonPrimitiveArray();
2188 }
2189 }
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002190 // For primitive arrays, use their optimized ArtMethod implementations.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002191 if ((source_component_type != DataType::Type::kVoid) &&
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002192 (source_component_type == destination_component_type)) {
2193 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2194 PointerSize image_size = class_linker->GetImagePointerSize();
2195 HInvokeStaticOrDirect* invoke = instruction->AsInvokeStaticOrDirect();
2196 mirror::Class* system = invoke->GetResolvedMethod()->GetDeclaringClass();
2197 ArtMethod* method = nullptr;
2198 switch (source_component_type) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002199 case DataType::Type::kBool:
Vladimir Markoba118822017-06-12 15:41:56 +01002200 method = system->FindClassMethod("arraycopy", "([ZI[ZII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002201 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002202 case DataType::Type::kInt8:
Vladimir Markoba118822017-06-12 15:41:56 +01002203 method = system->FindClassMethod("arraycopy", "([BI[BII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002204 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002205 case DataType::Type::kUint16:
Vladimir Markoba118822017-06-12 15:41:56 +01002206 method = system->FindClassMethod("arraycopy", "([CI[CII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002207 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002208 case DataType::Type::kInt16:
Vladimir Markoba118822017-06-12 15:41:56 +01002209 method = system->FindClassMethod("arraycopy", "([SI[SII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002210 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002211 case DataType::Type::kInt32:
Vladimir Markoba118822017-06-12 15:41:56 +01002212 method = system->FindClassMethod("arraycopy", "([II[III)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002213 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002214 case DataType::Type::kFloat32:
Vladimir Markoba118822017-06-12 15:41:56 +01002215 method = system->FindClassMethod("arraycopy", "([FI[FII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002216 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002217 case DataType::Type::kInt64:
Vladimir Markoba118822017-06-12 15:41:56 +01002218 method = system->FindClassMethod("arraycopy", "([JI[JII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002219 break;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002220 case DataType::Type::kFloat64:
Vladimir Markoba118822017-06-12 15:41:56 +01002221 method = system->FindClassMethod("arraycopy", "([DI[DII)V", image_size);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002222 break;
2223 default:
2224 LOG(FATAL) << "Unreachable";
2225 }
2226 DCHECK(method != nullptr);
Vladimir Markoba118822017-06-12 15:41:56 +01002227 DCHECK(method->IsStatic());
2228 DCHECK(method->GetDeclaringClass() == system);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002229 invoke->SetResolvedMethod(method);
2230 // Sharpen the new invoke. Note that we do not update the dex method index of
2231 // the invoke, as we would need to look it up in the current dex file, and it
2232 // is unlikely that it exists. The most usual situation for such typed
2233 // arraycopy methods is a direct pointer to the boot image.
Vladimir Marko65979462017-05-19 17:25:12 +01002234 HSharpening::SharpenInvokeStaticOrDirect(invoke, codegen_, compiler_driver_);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00002235 }
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002236 }
2237}
2238
Roland Levillaina5c4a402016-03-15 15:02:50 +00002239void InstructionSimplifierVisitor::SimplifyCompare(HInvoke* invoke,
2240 bool is_signum,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002241 DataType::Type type) {
Aart Bika19616e2016-02-01 18:57:58 -08002242 DCHECK(invoke->IsInvokeStaticOrDirect());
2243 uint32_t dex_pc = invoke->GetDexPc();
2244 HInstruction* left = invoke->InputAt(0);
2245 HInstruction* right;
Aart Bika19616e2016-02-01 18:57:58 -08002246 if (!is_signum) {
2247 right = invoke->InputAt(1);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002248 } else if (type == DataType::Type::kInt64) {
Aart Bika19616e2016-02-01 18:57:58 -08002249 right = GetGraph()->GetLongConstant(0);
2250 } else {
2251 right = GetGraph()->GetIntConstant(0);
2252 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01002253 HCompare* compare = new (GetGraph()->GetAllocator())
Aart Bika19616e2016-02-01 18:57:58 -08002254 HCompare(type, left, right, ComparisonBias::kNoBias, dex_pc);
2255 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, compare);
2256}
2257
Aart Bik75a38b22016-02-17 10:41:50 -08002258void InstructionSimplifierVisitor::SimplifyIsNaN(HInvoke* invoke) {
2259 DCHECK(invoke->IsInvokeStaticOrDirect());
2260 uint32_t dex_pc = invoke->GetDexPc();
2261 // IsNaN(x) is the same as x != x.
2262 HInstruction* x = invoke->InputAt(0);
Vladimir Markoca6fff82017-10-03 14:49:14 +01002263 HCondition* condition = new (GetGraph()->GetAllocator()) HNotEqual(x, x, dex_pc);
Aart Bik8ffc1fa2016-02-17 15:13:56 -08002264 condition->SetBias(ComparisonBias::kLtBias);
Aart Bik75a38b22016-02-17 10:41:50 -08002265 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, condition);
2266}
2267
Aart Bik2a6aad92016-02-25 11:32:32 -08002268void InstructionSimplifierVisitor::SimplifyFP2Int(HInvoke* invoke) {
2269 DCHECK(invoke->IsInvokeStaticOrDirect());
2270 uint32_t dex_pc = invoke->GetDexPc();
2271 HInstruction* x = invoke->InputAt(0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002272 DataType::Type type = x->GetType();
Aart Bik2a6aad92016-02-25 11:32:32 -08002273 // Set proper bit pattern for NaN and replace intrinsic with raw version.
2274 HInstruction* nan;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002275 if (type == DataType::Type::kFloat64) {
Aart Bik2a6aad92016-02-25 11:32:32 -08002276 nan = GetGraph()->GetLongConstant(0x7ff8000000000000L);
2277 invoke->SetIntrinsic(Intrinsics::kDoubleDoubleToRawLongBits,
2278 kNeedsEnvironmentOrCache,
2279 kNoSideEffects,
2280 kNoThrow);
2281 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002282 DCHECK_EQ(type, DataType::Type::kFloat32);
Aart Bik2a6aad92016-02-25 11:32:32 -08002283 nan = GetGraph()->GetIntConstant(0x7fc00000);
2284 invoke->SetIntrinsic(Intrinsics::kFloatFloatToRawIntBits,
2285 kNeedsEnvironmentOrCache,
2286 kNoSideEffects,
2287 kNoThrow);
2288 }
2289 // Test IsNaN(x), which is the same as x != x.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002290 HCondition* condition = new (GetGraph()->GetAllocator()) HNotEqual(x, x, dex_pc);
Aart Bik2a6aad92016-02-25 11:32:32 -08002291 condition->SetBias(ComparisonBias::kLtBias);
2292 invoke->GetBlock()->InsertInstructionBefore(condition, invoke->GetNext());
2293 // Select between the two.
Vladimir Markoca6fff82017-10-03 14:49:14 +01002294 HInstruction* select = new (GetGraph()->GetAllocator()) HSelect(condition, nan, invoke, dex_pc);
Aart Bik2a6aad92016-02-25 11:32:32 -08002295 invoke->GetBlock()->InsertInstructionBefore(select, condition->GetNext());
2296 invoke->ReplaceWithExceptInReplacementAtIndex(select, 0); // false at index 0
2297}
2298
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002299void InstructionSimplifierVisitor::SimplifyStringCharAt(HInvoke* invoke) {
2300 HInstruction* str = invoke->InputAt(0);
2301 HInstruction* index = invoke->InputAt(1);
2302 uint32_t dex_pc = invoke->GetDexPc();
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002303 ArenaAllocator* allocator = GetGraph()->GetAllocator();
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002304 // We treat String as an array to allow DCE and BCE to seamlessly work on strings,
2305 // so create the HArrayLength, HBoundsCheck and HArrayGet.
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002306 HArrayLength* length = new (allocator) HArrayLength(str, dex_pc, /* is_string_length */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002307 invoke->GetBlock()->InsertInstructionBefore(length, invoke);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002308 HBoundsCheck* bounds_check = new (allocator) HBoundsCheck(
Vladimir Marko0259c242017-12-04 11:27:47 +00002309 index, length, dex_pc, /* is_string_char_at */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002310 invoke->GetBlock()->InsertInstructionBefore(bounds_check, invoke);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002311 HArrayGet* array_get = new (allocator) HArrayGet(str,
2312 bounds_check,
2313 DataType::Type::kUint16,
2314 SideEffects::None(), // Strings are immutable.
2315 dex_pc,
2316 /* is_string_char_at */ true);
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002317 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, array_get);
2318 bounds_check->CopyEnvironmentFrom(invoke->GetEnvironment());
2319 GetGraph()->SetHasBoundsChecks(true);
2320}
2321
Vladimir Markodce016e2016-04-28 13:10:02 +01002322void InstructionSimplifierVisitor::SimplifyStringIsEmptyOrLength(HInvoke* invoke) {
2323 HInstruction* str = invoke->InputAt(0);
2324 uint32_t dex_pc = invoke->GetDexPc();
2325 // We treat String as an array to allow DCE and BCE to seamlessly work on strings,
2326 // so create the HArrayLength.
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002327 HArrayLength* length =
Vladimir Markoca6fff82017-10-03 14:49:14 +01002328 new (GetGraph()->GetAllocator()) HArrayLength(str, dex_pc, /* is_string_length */ true);
Vladimir Markodce016e2016-04-28 13:10:02 +01002329 HInstruction* replacement;
2330 if (invoke->GetIntrinsic() == Intrinsics::kStringIsEmpty) {
2331 // For String.isEmpty(), create the `HEqual` representing the `length == 0`.
2332 invoke->GetBlock()->InsertInstructionBefore(length, invoke);
2333 HIntConstant* zero = GetGraph()->GetIntConstant(0);
Vladimir Markoca6fff82017-10-03 14:49:14 +01002334 HEqual* equal = new (GetGraph()->GetAllocator()) HEqual(length, zero, dex_pc);
Vladimir Markodce016e2016-04-28 13:10:02 +01002335 replacement = equal;
2336 } else {
2337 DCHECK_EQ(invoke->GetIntrinsic(), Intrinsics::kStringLength);
2338 replacement = length;
2339 }
2340 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, replacement);
2341}
2342
Aart Bikff7d89c2016-11-07 08:49:28 -08002343// This method should only be used on intrinsics whose sole way of throwing an
2344// exception is raising a NPE when the nth argument is null. If that argument
2345// is provably non-null, we can clear the flag.
2346void InstructionSimplifierVisitor::SimplifyNPEOnArgN(HInvoke* invoke, size_t n) {
2347 HInstruction* arg = invoke->InputAt(n);
Aart Bik71bf7b42016-11-16 10:17:46 -08002348 if (invoke->CanThrow() && !arg->CanBeNull()) {
Aart Bikff7d89c2016-11-07 08:49:28 -08002349 invoke->SetCanThrow(false);
2350 }
2351}
2352
Aart Bik71bf7b42016-11-16 10:17:46 -08002353// Methods that return "this" can replace the returned value with the receiver.
2354void InstructionSimplifierVisitor::SimplifyReturnThis(HInvoke* invoke) {
2355 if (invoke->HasUses()) {
2356 HInstruction* receiver = invoke->InputAt(0);
2357 invoke->ReplaceWith(receiver);
2358 RecordSimplification();
2359 }
2360}
2361
2362// Helper method for StringBuffer escape analysis.
2363static bool NoEscapeForStringBufferReference(HInstruction* reference, HInstruction* user) {
2364 if (user->IsInvokeStaticOrDirect()) {
2365 // Any constructor on StringBuffer is okay.
Aart Bikab2270f2016-12-15 09:36:31 -08002366 return user->AsInvokeStaticOrDirect()->GetResolvedMethod() != nullptr &&
2367 user->AsInvokeStaticOrDirect()->GetResolvedMethod()->IsConstructor() &&
Aart Bik71bf7b42016-11-16 10:17:46 -08002368 user->InputAt(0) == reference;
2369 } else if (user->IsInvokeVirtual()) {
2370 switch (user->AsInvokeVirtual()->GetIntrinsic()) {
2371 case Intrinsics::kStringBufferLength:
2372 case Intrinsics::kStringBufferToString:
2373 DCHECK_EQ(user->InputAt(0), reference);
2374 return true;
2375 case Intrinsics::kStringBufferAppend:
2376 // Returns "this", so only okay if no further uses.
2377 DCHECK_EQ(user->InputAt(0), reference);
2378 DCHECK_NE(user->InputAt(1), reference);
2379 return !user->HasUses();
2380 default:
2381 break;
2382 }
2383 }
2384 return false;
2385}
2386
2387// Certain allocation intrinsics are not removed by dead code elimination
2388// because of potentially throwing an OOM exception or other side effects.
2389// This method removes such intrinsics when special circumstances allow.
2390void InstructionSimplifierVisitor::SimplifyAllocationIntrinsic(HInvoke* invoke) {
2391 if (!invoke->HasUses()) {
2392 // Instruction has no uses. If unsynchronized, we can remove right away, safely ignoring
2393 // the potential OOM of course. Otherwise, we must ensure the receiver object of this
2394 // call does not escape since only thread-local synchronization may be removed.
2395 bool is_synchronized = invoke->GetIntrinsic() == Intrinsics::kStringBufferToString;
2396 HInstruction* receiver = invoke->InputAt(0);
2397 if (!is_synchronized || DoesNotEscape(receiver, NoEscapeForStringBufferReference)) {
2398 invoke->GetBlock()->RemoveInstruction(invoke);
2399 RecordSimplification();
2400 }
2401 }
2402}
2403
Vladimir Markoca6fff82017-10-03 14:49:14 +01002404void InstructionSimplifierVisitor::SimplifyMemBarrier(HInvoke* invoke,
2405 MemBarrierKind barrier_kind) {
Aart Bik11932592016-03-08 12:42:25 -08002406 uint32_t dex_pc = invoke->GetDexPc();
Vladimir Markoca6fff82017-10-03 14:49:14 +01002407 HMemoryBarrier* mem_barrier =
2408 new (GetGraph()->GetAllocator()) HMemoryBarrier(barrier_kind, dex_pc);
Aart Bik11932592016-03-08 12:42:25 -08002409 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, mem_barrier);
2410}
2411
Aart Bik1f8d51b2018-02-15 10:42:37 -08002412void InstructionSimplifierVisitor::SimplifyMin(HInvoke* invoke, DataType::Type type) {
2413 DCHECK(invoke->IsInvokeStaticOrDirect());
2414 HMin* min = new (GetGraph()->GetAllocator())
2415 HMin(type, invoke->InputAt(0), invoke->InputAt(1), invoke->GetDexPc());
2416 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, min);
2417}
2418
2419void InstructionSimplifierVisitor::SimplifyMax(HInvoke* invoke, DataType::Type type) {
2420 DCHECK(invoke->IsInvokeStaticOrDirect());
2421 HMax* max = new (GetGraph()->GetAllocator())
2422 HMax(type, invoke->InputAt(0), invoke->InputAt(1), invoke->GetDexPc());
2423 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, max);
2424}
2425
Aart Bik3dad3412018-02-28 12:01:46 -08002426void InstructionSimplifierVisitor::SimplifyAbs(HInvoke* invoke, DataType::Type type) {
2427 DCHECK(invoke->IsInvokeStaticOrDirect());
2428 HAbs* abs = new (GetGraph()->GetAllocator())
2429 HAbs(type, invoke->InputAt(0), invoke->GetDexPc());
2430 invoke->GetBlock()->ReplaceAndRemoveInstructionWith(invoke, abs);
2431}
2432
Nicolas Geoffrayee3cf072015-10-06 11:45:02 +01002433void InstructionSimplifierVisitor::VisitInvoke(HInvoke* instruction) {
Aart Bik2a6aad92016-02-25 11:32:32 -08002434 switch (instruction->GetIntrinsic()) {
2435 case Intrinsics::kStringEquals:
2436 SimplifyStringEquals(instruction);
2437 break;
2438 case Intrinsics::kSystemArrayCopy:
2439 SimplifySystemArrayCopy(instruction);
2440 break;
2441 case Intrinsics::kIntegerRotateRight:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002442 SimplifyRotate(instruction, /* is_left */ false, DataType::Type::kInt32);
Roland Levillain22c49222016-03-18 14:04:28 +00002443 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002444 case Intrinsics::kLongRotateRight:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002445 SimplifyRotate(instruction, /* is_left */ false, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002446 break;
2447 case Intrinsics::kIntegerRotateLeft:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002448 SimplifyRotate(instruction, /* is_left */ true, DataType::Type::kInt32);
Roland Levillain22c49222016-03-18 14:04:28 +00002449 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002450 case Intrinsics::kLongRotateLeft:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002451 SimplifyRotate(instruction, /* is_left */ true, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002452 break;
2453 case Intrinsics::kIntegerCompare:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002454 SimplifyCompare(instruction, /* is_signum */ false, DataType::Type::kInt32);
Roland Levillaina5c4a402016-03-15 15:02:50 +00002455 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002456 case Intrinsics::kLongCompare:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002457 SimplifyCompare(instruction, /* is_signum */ false, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002458 break;
2459 case Intrinsics::kIntegerSignum:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002460 SimplifyCompare(instruction, /* is_signum */ true, DataType::Type::kInt32);
Roland Levillaina5c4a402016-03-15 15:02:50 +00002461 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002462 case Intrinsics::kLongSignum:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002463 SimplifyCompare(instruction, /* is_signum */ true, DataType::Type::kInt64);
Aart Bik2a6aad92016-02-25 11:32:32 -08002464 break;
2465 case Intrinsics::kFloatIsNaN:
2466 case Intrinsics::kDoubleIsNaN:
2467 SimplifyIsNaN(instruction);
2468 break;
2469 case Intrinsics::kFloatFloatToIntBits:
2470 case Intrinsics::kDoubleDoubleToLongBits:
2471 SimplifyFP2Int(instruction);
2472 break;
Vladimir Marko87f3fcb2016-04-28 15:52:11 +01002473 case Intrinsics::kStringCharAt:
2474 SimplifyStringCharAt(instruction);
2475 break;
Vladimir Markodce016e2016-04-28 13:10:02 +01002476 case Intrinsics::kStringIsEmpty:
2477 case Intrinsics::kStringLength:
2478 SimplifyStringIsEmptyOrLength(instruction);
2479 break;
Aart Bikff7d89c2016-11-07 08:49:28 -08002480 case Intrinsics::kStringStringIndexOf:
2481 case Intrinsics::kStringStringIndexOfAfter:
2482 SimplifyNPEOnArgN(instruction, 1); // 0th has own NullCheck
2483 break;
Aart Bik71bf7b42016-11-16 10:17:46 -08002484 case Intrinsics::kStringBufferAppend:
2485 case Intrinsics::kStringBuilderAppend:
2486 SimplifyReturnThis(instruction);
2487 break;
2488 case Intrinsics::kStringBufferToString:
2489 case Intrinsics::kStringBuilderToString:
2490 SimplifyAllocationIntrinsic(instruction);
2491 break;
Aart Bik11932592016-03-08 12:42:25 -08002492 case Intrinsics::kUnsafeLoadFence:
2493 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2494 break;
2495 case Intrinsics::kUnsafeStoreFence:
2496 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyStore);
2497 break;
2498 case Intrinsics::kUnsafeFullFence:
2499 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyAny);
2500 break;
Orion Hodson4a4610a2017-09-28 16:57:55 +01002501 case Intrinsics::kVarHandleFullFence:
2502 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyAny);
2503 break;
2504 case Intrinsics::kVarHandleAcquireFence:
2505 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2506 break;
2507 case Intrinsics::kVarHandleReleaseFence:
2508 SimplifyMemBarrier(instruction, MemBarrierKind::kAnyStore);
2509 break;
2510 case Intrinsics::kVarHandleLoadLoadFence:
2511 SimplifyMemBarrier(instruction, MemBarrierKind::kLoadAny);
2512 break;
2513 case Intrinsics::kVarHandleStoreStoreFence:
2514 SimplifyMemBarrier(instruction, MemBarrierKind::kStoreStore);
2515 break;
Aart Bik1f8d51b2018-02-15 10:42:37 -08002516 case Intrinsics::kMathMinIntInt:
2517 SimplifyMin(instruction, DataType::Type::kInt32);
2518 break;
2519 case Intrinsics::kMathMinLongLong:
2520 SimplifyMin(instruction, DataType::Type::kInt64);
2521 break;
2522 case Intrinsics::kMathMinFloatFloat:
2523 SimplifyMin(instruction, DataType::Type::kFloat32);
2524 break;
2525 case Intrinsics::kMathMinDoubleDouble:
2526 SimplifyMin(instruction, DataType::Type::kFloat64);
2527 break;
2528 case Intrinsics::kMathMaxIntInt:
2529 SimplifyMax(instruction, DataType::Type::kInt32);
2530 break;
2531 case Intrinsics::kMathMaxLongLong:
2532 SimplifyMax(instruction, DataType::Type::kInt64);
2533 break;
2534 case Intrinsics::kMathMaxFloatFloat:
2535 SimplifyMax(instruction, DataType::Type::kFloat32);
2536 break;
2537 case Intrinsics::kMathMaxDoubleDouble:
2538 SimplifyMax(instruction, DataType::Type::kFloat64);
2539 break;
Aart Bik3dad3412018-02-28 12:01:46 -08002540 case Intrinsics::kMathAbsInt:
2541 SimplifyAbs(instruction, DataType::Type::kInt32);
2542 break;
2543 case Intrinsics::kMathAbsLong:
2544 SimplifyAbs(instruction, DataType::Type::kInt64);
2545 break;
2546 case Intrinsics::kMathAbsFloat:
2547 SimplifyAbs(instruction, DataType::Type::kFloat32);
2548 break;
2549 case Intrinsics::kMathAbsDouble:
2550 SimplifyAbs(instruction, DataType::Type::kFloat64);
2551 break;
Aart Bik2a6aad92016-02-25 11:32:32 -08002552 default:
2553 break;
Nicolas Geoffraya83a54d2015-10-02 17:30:26 +01002554 }
2555}
2556
Aart Bikbb245d12015-10-19 11:05:03 -07002557void InstructionSimplifierVisitor::VisitDeoptimize(HDeoptimize* deoptimize) {
2558 HInstruction* cond = deoptimize->InputAt(0);
2559 if (cond->IsConstant()) {
Roland Levillain1a653882016-03-18 18:05:57 +00002560 if (cond->AsIntConstant()->IsFalse()) {
Aart Bikbb245d12015-10-19 11:05:03 -07002561 // Never deopt: instruction can be removed.
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00002562 if (deoptimize->GuardsAnInput()) {
2563 deoptimize->ReplaceWith(deoptimize->GuardedInput());
2564 }
Aart Bikbb245d12015-10-19 11:05:03 -07002565 deoptimize->GetBlock()->RemoveInstruction(deoptimize);
2566 } else {
2567 // Always deopt.
2568 }
2569 }
2570}
2571
Anton Kirilove14dc862016-05-13 17:56:15 +01002572// Replace code looking like
2573// OP y, x, const1
2574// OP z, y, const2
2575// with
2576// OP z, x, const3
2577// where OP is both an associative and a commutative operation.
2578bool InstructionSimplifierVisitor::TryHandleAssociativeAndCommutativeOperation(
2579 HBinaryOperation* instruction) {
2580 DCHECK(instruction->IsCommutative());
2581
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002582 if (!DataType::IsIntegralType(instruction->GetType())) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002583 return false;
2584 }
2585
2586 HInstruction* left = instruction->GetLeft();
2587 HInstruction* right = instruction->GetRight();
2588 // Variable names as described above.
2589 HConstant* const2;
2590 HBinaryOperation* y;
2591
2592 if (instruction->InstructionTypeEquals(left) && right->IsConstant()) {
2593 const2 = right->AsConstant();
2594 y = left->AsBinaryOperation();
2595 } else if (left->IsConstant() && instruction->InstructionTypeEquals(right)) {
2596 const2 = left->AsConstant();
2597 y = right->AsBinaryOperation();
2598 } else {
2599 // The node does not match the pattern.
2600 return false;
2601 }
2602
2603 // If `y` has more than one use, we do not perform the optimization
2604 // because it might increase code size (e.g. if the new constant is
2605 // no longer encodable as an immediate operand in the target ISA).
2606 if (!y->HasOnlyOneNonEnvironmentUse()) {
2607 return false;
2608 }
2609
2610 // GetConstantRight() can return both left and right constants
2611 // for commutative operations.
2612 HConstant* const1 = y->GetConstantRight();
2613 if (const1 == nullptr) {
2614 return false;
2615 }
2616
2617 instruction->ReplaceInput(const1, 0);
2618 instruction->ReplaceInput(const2, 1);
2619 HConstant* const3 = instruction->TryStaticEvaluation();
2620 DCHECK(const3 != nullptr);
2621 instruction->ReplaceInput(y->GetLeastConstantLeft(), 0);
2622 instruction->ReplaceInput(const3, 1);
2623 RecordSimplification();
2624 return true;
2625}
2626
2627static HBinaryOperation* AsAddOrSub(HInstruction* binop) {
2628 return (binop->IsAdd() || binop->IsSub()) ? binop->AsBinaryOperation() : nullptr;
2629}
2630
2631// Helper function that performs addition statically, considering the result type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002632static int64_t ComputeAddition(DataType::Type type, int64_t x, int64_t y) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002633 // Use the Compute() method for consistency with TryStaticEvaluation().
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002634 if (type == DataType::Type::kInt32) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002635 return HAdd::Compute<int32_t>(x, y);
2636 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002637 DCHECK_EQ(type, DataType::Type::kInt64);
Anton Kirilove14dc862016-05-13 17:56:15 +01002638 return HAdd::Compute<int64_t>(x, y);
2639 }
2640}
2641
2642// Helper function that handles the child classes of HConstant
2643// and returns an integer with the appropriate sign.
2644static int64_t GetValue(HConstant* constant, bool is_negated) {
2645 int64_t ret = Int64FromConstant(constant);
2646 return is_negated ? -ret : ret;
2647}
2648
2649// Replace code looking like
2650// OP1 y, x, const1
2651// OP2 z, y, const2
2652// with
2653// OP3 z, x, const3
2654// where OPx is either ADD or SUB, and at least one of OP{1,2} is SUB.
2655bool InstructionSimplifierVisitor::TrySubtractionChainSimplification(
2656 HBinaryOperation* instruction) {
2657 DCHECK(instruction->IsAdd() || instruction->IsSub()) << instruction->DebugName();
2658
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002659 DataType::Type type = instruction->GetType();
2660 if (!DataType::IsIntegralType(type)) {
Anton Kirilove14dc862016-05-13 17:56:15 +01002661 return false;
2662 }
2663
2664 HInstruction* left = instruction->GetLeft();
2665 HInstruction* right = instruction->GetRight();
2666 // Variable names as described above.
2667 HConstant* const2 = right->IsConstant() ? right->AsConstant() : left->AsConstant();
2668 if (const2 == nullptr) {
2669 return false;
2670 }
2671
2672 HBinaryOperation* y = (AsAddOrSub(left) != nullptr)
2673 ? left->AsBinaryOperation()
2674 : AsAddOrSub(right);
2675 // If y has more than one use, we do not perform the optimization because
2676 // it might increase code size (e.g. if the new constant is no longer
2677 // encodable as an immediate operand in the target ISA).
2678 if ((y == nullptr) || !y->HasOnlyOneNonEnvironmentUse()) {
2679 return false;
2680 }
2681
2682 left = y->GetLeft();
2683 HConstant* const1 = left->IsConstant() ? left->AsConstant() : y->GetRight()->AsConstant();
2684 if (const1 == nullptr) {
2685 return false;
2686 }
2687
2688 HInstruction* x = (const1 == left) ? y->GetRight() : left;
2689 // If both inputs are constants, let the constant folding pass deal with it.
2690 if (x->IsConstant()) {
2691 return false;
2692 }
2693
2694 bool is_const2_negated = (const2 == right) && instruction->IsSub();
2695 int64_t const2_val = GetValue(const2, is_const2_negated);
2696 bool is_y_negated = (y == right) && instruction->IsSub();
2697 right = y->GetRight();
2698 bool is_const1_negated = is_y_negated ^ ((const1 == right) && y->IsSub());
2699 int64_t const1_val = GetValue(const1, is_const1_negated);
2700 bool is_x_negated = is_y_negated ^ ((x == right) && y->IsSub());
2701 int64_t const3_val = ComputeAddition(type, const1_val, const2_val);
2702 HBasicBlock* block = instruction->GetBlock();
2703 HConstant* const3 = block->GetGraph()->GetConstant(type, const3_val);
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002704 ArenaAllocator* allocator = instruction->GetAllocator();
Anton Kirilove14dc862016-05-13 17:56:15 +01002705 HInstruction* z;
2706
2707 if (is_x_negated) {
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002708 z = new (allocator) HSub(type, const3, x, instruction->GetDexPc());
Anton Kirilove14dc862016-05-13 17:56:15 +01002709 } else {
Vladimir Markoe764d2e2017-10-05 14:35:55 +01002710 z = new (allocator) HAdd(type, x, const3, instruction->GetDexPc());
Anton Kirilove14dc862016-05-13 17:56:15 +01002711 }
2712
2713 block->ReplaceAndRemoveInstructionWith(instruction, z);
2714 RecordSimplification();
2715 return true;
2716}
2717
Lena Djokicbc5460b2017-07-20 16:07:36 +02002718void InstructionSimplifierVisitor::VisitVecMul(HVecMul* instruction) {
2719 if (TryCombineVecMultiplyAccumulate(instruction)) {
2720 RecordSimplification();
2721 }
2722}
2723
Nicolas Geoffray3c049742014-09-24 18:10:46 +01002724} // namespace art