blob: 31cf29aa4ad126adf7a0b7e163e3155807b1d0f9 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
24#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000025#include "dex/verified_method.h"
26#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010028#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/dex_compilation_unit.h"
30#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010031#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000032#include "jit/jit.h"
33#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000034#include "mirror/class_loader.h"
35#include "mirror/dex_cache.h"
36#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010037#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010038#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070039#include "register_allocator_linear_scan.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000040#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010041#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000042#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000043#include "ssa_phi_elimination.h"
44#include "scoped_thread_state_change.h"
45#include "thread.h"
46
47namespace art {
48
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000049static constexpr size_t kMaximumNumberOfHInstructions = 32;
50
51// Limit the number of dex registers that we accumulate while inlining
52// to avoid creating large amount of nested environments.
53static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
54
55// Avoid inlining within a huge method due to memory pressure.
56static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070057
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000058void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010059 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
60 if ((compiler_options.GetInlineDepthLimit() == 0)
61 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
62 return;
63 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000064 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
65 return;
66 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000067 if (graph_->IsDebuggable()) {
68 // For simplicity, we currently never inline when the graph is debuggable. This avoids
69 // doing some logic in the runtime to discover if a method could have been inlined.
70 return;
71 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010072 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
73 DCHECK(!blocks.empty());
74 HBasicBlock* next_block = blocks[0];
75 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010076 // Because we are changing the graph when inlining, we need to remember the next block.
77 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010078 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010079 continue;
80 }
81 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010082 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000083 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
84 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010085 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070086 // As long as the call is not intrinsified, it is worth trying to inline.
87 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000088 // We use the original invoke type to ensure the resolution of the called method
89 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000090 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010091 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000092 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000093 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000094 bool should_inline = callee_name.find("$inline$") != std::string::npos;
95 CHECK(!should_inline) << "Could not inline " << callee_name;
96 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010097 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010098 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010099 std::string callee_name =
100 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
101 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
102 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
103 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000104 }
105 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000106 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000107 }
108 }
109}
110
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100111static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700112 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100113 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
114}
115
116/**
117 * Given the `resolved_method` looked up in the dex cache, try to find
118 * the actual runtime target of an interface or virtual call.
119 * Return nullptr if the runtime target cannot be proven.
120 */
121static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700122 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100123 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
124 // No need to lookup further, the resolved method will be the target.
125 return resolved_method;
126 }
127
128 HInstruction* receiver = invoke->InputAt(0);
129 if (receiver->IsNullCheck()) {
130 // Due to multiple levels of inlining within the same pass, it might be that
131 // null check does not have the reference type of the actual receiver.
132 receiver = receiver->InputAt(0);
133 }
134 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000135 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
136 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100137 // We currently only support inlining with known receivers.
138 // TODO: Remove this check, we should be able to inline final methods
139 // on unknown receivers.
140 return nullptr;
141 } else if (info.GetTypeHandle()->IsInterface()) {
142 // Statically knowing that the receiver has an interface type cannot
143 // help us find what is the target method.
144 return nullptr;
145 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
146 // The method that we're trying to call is not in the receiver's class or super classes.
147 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000148 } else if (info.GetTypeHandle()->IsErroneous()) {
149 // If the type is erroneous, do not go further, as we are going to query the vtable or
150 // imt table, that we can only safely do on non-erroneous classes.
151 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100152 }
153
154 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700155 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100156 if (invoke->IsInvokeInterface()) {
157 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
158 resolved_method, pointer_size);
159 } else {
160 DCHECK(invoke->IsInvokeVirtual());
161 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
162 resolved_method, pointer_size);
163 }
164
165 if (resolved_method == nullptr) {
166 // The information we had on the receiver was not enough to find
167 // the target method. Since we check above the exact type of the receiver,
168 // the only reason this can happen is an IncompatibleClassChangeError.
169 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700170 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100171 // The information we had on the receiver was not enough to find
172 // the target method. Since we check above the exact type of the receiver,
173 // the only reason this can happen is an IncompatibleClassChangeError.
174 return nullptr;
175 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
176 // A final method has to be the target method.
177 return resolved_method;
178 } else if (info.IsExact()) {
179 // If we found a method and the receiver's concrete type is statically
180 // known, we know for sure the target.
181 return resolved_method;
182 } else {
183 // Even if we did find a method, the receiver type was not enough to
184 // statically find the runtime target.
185 return nullptr;
186 }
187}
188
189static uint32_t FindMethodIndexIn(ArtMethod* method,
190 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000191 uint32_t name_and_signature_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700192 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100193 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100194 return method->GetDexMethodIndex();
195 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000196 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100197 }
198}
199
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000200static uint32_t FindClassIndexIn(mirror::Class* cls,
201 const DexFile& dex_file,
202 Handle<mirror::DexCache> dex_cache)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100203 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000204 uint32_t index = DexFile::kDexNoIndex;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100205 if (cls->GetDexCache() == nullptr) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000206 DCHECK(cls->IsArrayClass()) << PrettyClass(cls);
207 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100208 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000209 DCHECK(cls->IsProxyClass()) << PrettyClass(cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100210 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100211 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100212 DCHECK_EQ(cls->GetDexCache(), dex_cache.Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000213 index = cls->GetDexTypeIndex();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100214 // Update the dex cache to ensure the class is in. The generated code will
215 // consider it is. We make it safe by updating the dex cache, as other
216 // dex files might also load the class, and there is no guarantee the dex
217 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000218 if (dex_cache->GetResolvedType(index) == nullptr) {
219 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100220 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100221 } else {
222 index = cls->FindTypeIndexInOtherDexFile(dex_file);
223 // We cannot guarantee the entry in the dex cache will resolve to the same class,
224 // as there may be different class loaders. So only return the index if it's
225 // the right class in the dex cache already.
226 if (index != DexFile::kDexNoIndex && dex_cache->GetResolvedType(index) != cls) {
227 index = DexFile::kDexNoIndex;
228 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100229 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000230
231 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100232}
233
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000234class ScopedProfilingInfoInlineUse {
235 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000236 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
237 : method_(method),
238 self_(self),
239 // Fetch the profiling info ahead of using it. If it's null when fetching,
240 // we should not call JitCodeCache::DoneInlining.
241 profiling_info_(
242 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000243 }
244
245 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000246 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700247 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000248 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
249 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
250 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000251 }
252
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000253 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
254
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000255 private:
256 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000257 Thread* const self_;
258 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000259};
260
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700261bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100262 if (invoke_instruction->IsInvokeUnresolved()) {
263 return false; // Don't bother to move further if we know the method is unresolved.
264 }
265
Vladimir Marko58155012015-08-19 12:49:41 +0000266 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000267 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000268 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
269 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000270
Nicolas Geoffray35071052015-06-09 15:43:38 +0100271 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
272 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000273 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800274 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000275 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000276 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
277 VLOG(compiler) << "Not inlining a String.<init> method";
278 return false;
279 }
Vladimir Marko58155012015-08-19 12:49:41 +0000280 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100281 mirror::DexCache* const dex_cache = IsSameDexFile(caller_dex_file, *ref.dex_file)
Mathieu Chartier736b5602015-09-02 14:54:11 -0700282 ? caller_compilation_unit_.GetDexCache().Get()
283 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
284 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000285 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800286 // actual_method == resolved_method for direct or static calls.
287 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000288 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700289 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000290 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800291 if (resolved_method != nullptr) {
292 // Check if we can statically find the method.
293 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
294 }
Vladimir Marko58155012015-08-19 12:49:41 +0000295 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000296
Mathieu Chartiere401d142015-04-22 13:56:20 -0700297 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100298 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100299 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000300 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000301 return false;
302 }
303
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100304 if (actual_method != nullptr) {
Calin Juravle69158982016-03-16 11:53:41 +0000305 bool result = TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true);
306 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
307 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
308 }
309 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100310 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000311
Andreas Gampefd2140f2015-12-23 16:30:44 -0800312 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100313
314 // Check if we can use an inline cache.
315 ArtMethod* caller = graph_->GetArtMethod();
Calin Juravleffc87072016-04-20 14:22:09 +0100316 if (Runtime::Current()->UseJitCompilation()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000317 // Under JIT, we should always know the caller.
318 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000319 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
320 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000321 if (profiling_info != nullptr) {
322 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000323 if (ic.IsUninitialized()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000324 VLOG(compiler) << "Interface or virtual call to "
325 << PrettyMethod(method_index, caller_dex_file)
326 << " is not hit and not inlined";
327 return false;
328 } else if (ic.IsMonomorphic()) {
329 MaybeRecordStat(kMonomorphicCall);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100330 if (outermost_graph_->IsCompilingOsr()) {
331 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
332 // interpreter and it may have seen different receiver types.
333 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
334 } else {
335 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
336 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000337 } else if (ic.IsPolymorphic()) {
338 MaybeRecordStat(kPolymorphicCall);
339 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
340 } else {
341 DCHECK(ic.IsMegamorphic());
342 VLOG(compiler) << "Interface or virtual call to "
343 << PrettyMethod(method_index, caller_dex_file)
344 << " is megamorphic and not inlined";
345 MaybeRecordStat(kMegamorphicCall);
346 return false;
347 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100348 }
349 }
350
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100351 VLOG(compiler) << "Interface or virtual call to "
352 << PrettyMethod(method_index, caller_dex_file)
353 << " could not be statically determined";
354 return false;
355}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000356
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000357HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
358 HInstruction* receiver,
359 uint32_t dex_pc) const {
360 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
361 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000362 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000363 receiver,
364 Primitive::kPrimNot,
365 field->GetOffset(),
366 field->IsVolatile(),
367 field->GetDexFieldIndex(),
368 field->GetDeclaringClass()->GetDexClassDefIndex(),
369 *field->GetDexFile(),
370 handles_->NewHandle(field->GetDexCache()),
371 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000372 // The class of a field is effectively final, and does not have any memory dependencies.
373 result->SetSideEffects(SideEffects::None());
374 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000375}
376
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100377bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
378 ArtMethod* resolved_method,
379 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000380 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
381 << invoke_instruction->DebugName();
382
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100383 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000384 uint32_t class_index = FindClassIndexIn(
385 ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100386 if (class_index == DexFile::kDexNoIndex) {
387 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
388 << " from inline cache is not inlined because its class is not"
389 << " accessible to the caller";
390 return false;
391 }
392
393 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700394 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100395 if (invoke_instruction->IsInvokeInterface()) {
396 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
397 resolved_method, pointer_size);
398 } else {
399 DCHECK(invoke_instruction->IsInvokeVirtual());
400 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
401 resolved_method, pointer_size);
402 }
403 DCHECK(resolved_method != nullptr);
404 HInstruction* receiver = invoke_instruction->InputAt(0);
405 HInstruction* cursor = invoke_instruction->GetPrevious();
406 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
407
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000408 if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100409 return false;
410 }
411
412 // We successfully inlined, now add a guard.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100413 bool is_referrer =
414 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000415 AddTypeGuard(receiver,
416 cursor,
417 bb_cursor,
418 class_index,
419 is_referrer,
420 invoke_instruction,
421 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100422
423 // Run type propagation to get the guard typed, and eventually propagate the
424 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000425 ReferenceTypePropagation rtp_fixup(graph_,
426 outer_compilation_unit_.GetDexCache(),
427 handles_,
428 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100429 rtp_fixup.Run();
430
431 MaybeRecordStat(kInlinedMonomorphicCall);
432 return true;
433}
434
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000435HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
436 HInstruction* cursor,
437 HBasicBlock* bb_cursor,
438 uint32_t class_index,
439 bool is_referrer,
440 HInstruction* invoke_instruction,
441 bool with_deoptimization) {
442 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
443 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
444 class_linker, receiver, invoke_instruction->GetDexPc());
445
446 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
447 // Note that we will just compare the classes, so we don't need Java semantics access checks.
448 // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache.
449 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
450 class_index,
451 caller_dex_file,
452 is_referrer,
453 invoke_instruction->GetDexPc(),
454 /* needs_access_check */ false,
455 /* is_in_dex_cache */ true);
456
457 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
458 // TODO: Extend reference type propagation to understand the guard.
459 if (cursor != nullptr) {
460 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
461 } else {
462 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
463 }
464 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
465 bb_cursor->InsertInstructionAfter(compare, load_class);
466 if (with_deoptimization) {
467 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
468 compare, invoke_instruction->GetDexPc());
469 bb_cursor->InsertInstructionAfter(deoptimize, compare);
470 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
471 }
472 return compare;
473}
474
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000475bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100476 ArtMethod* resolved_method,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000477 const InlineCache& ic) {
478 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
479 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000480
481 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) {
482 return true;
483 }
484
485 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700486 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000487 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
488
489 bool all_targets_inlined = true;
490 bool one_target_inlined = false;
491 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
492 if (ic.GetTypeAt(i) == nullptr) {
493 break;
494 }
495 ArtMethod* method = nullptr;
496 if (invoke_instruction->IsInvokeInterface()) {
497 method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
498 resolved_method, pointer_size);
499 } else {
500 DCHECK(invoke_instruction->IsInvokeVirtual());
501 method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
502 resolved_method, pointer_size);
503 }
504
505 HInstruction* receiver = invoke_instruction->InputAt(0);
506 HInstruction* cursor = invoke_instruction->GetPrevious();
507 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
508
Nicolas Geoffray1fe26e12016-02-18 16:55:42 +0000509 uint32_t class_index = FindClassIndexIn(
510 ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000511 HInstruction* return_replacement = nullptr;
512 if (class_index == DexFile::kDexNoIndex ||
513 !TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
514 all_targets_inlined = false;
515 } else {
516 one_target_inlined = true;
517 bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass());
518
519 // If we have inlined all targets before, and this receiver is the last seen,
520 // we deoptimize instead of keeping the original invoke instruction.
521 bool deoptimize = all_targets_inlined &&
522 (i != InlineCache::kIndividualCacheSize - 1) &&
523 (ic.GetTypeAt(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100524
525 if (outermost_graph_->IsCompilingOsr()) {
526 // We do not support HDeoptimize in OSR methods.
527 deoptimize = false;
528 }
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000529 HInstruction* compare = AddTypeGuard(
530 receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize);
531 if (deoptimize) {
532 if (return_replacement != nullptr) {
533 invoke_instruction->ReplaceWith(return_replacement);
534 }
535 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
536 // Because the inline cache data can be populated concurrently, we force the end of the
537 // iteration. Otherhwise, we could see a new receiver type.
538 break;
539 } else {
540 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
541 }
542 }
543 }
544
545 if (!one_target_inlined) {
546 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
547 << " from inline cache is not inlined because none"
548 << " of its targets could be inlined";
549 return false;
550 }
551 MaybeRecordStat(kInlinedPolymorphicCall);
552
553 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000554 ReferenceTypePropagation rtp_fixup(graph_,
555 outer_compilation_unit_.GetDexCache(),
556 handles_,
557 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000558 rtp_fixup.Run();
559 return true;
560}
561
562void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
563 HInstruction* return_replacement,
564 HInstruction* invoke_instruction) {
565 uint32_t dex_pc = invoke_instruction->GetDexPc();
566 HBasicBlock* cursor_block = compare->GetBlock();
567 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
568 ArenaAllocator* allocator = graph_->GetArena();
569
570 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
571 // and the returned block is the start of the then branch (that could contain multiple blocks).
572 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
573
574 // Split the block containing the invoke before and after the invoke. The returned block
575 // of the split before will contain the invoke and will be the otherwise branch of
576 // the diamond. The returned block of the split after will be the merge block
577 // of the diamond.
578 HBasicBlock* end_then = invoke_instruction->GetBlock();
579 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
580 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
581
582 // If the methods we are inlining return a value, we create a phi in the merge block
583 // that will have the `invoke_instruction and the `return_replacement` as inputs.
584 if (return_replacement != nullptr) {
585 HPhi* phi = new (allocator) HPhi(
586 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
587 merge->AddPhi(phi);
588 invoke_instruction->ReplaceWith(phi);
589 phi->AddInput(return_replacement);
590 phi->AddInput(invoke_instruction);
591 }
592
593 // Add the control flow instructions.
594 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
595 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
596 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
597
598 // Add the newly created blocks to the graph.
599 graph_->AddBlock(then);
600 graph_->AddBlock(otherwise);
601 graph_->AddBlock(merge);
602
603 // Set up successor (and implictly predecessor) relations.
604 cursor_block->AddSuccessor(otherwise);
605 cursor_block->AddSuccessor(then);
606 end_then->AddSuccessor(merge);
607 otherwise->AddSuccessor(merge);
608
609 // Set up dominance information.
610 then->SetDominator(cursor_block);
611 cursor_block->AddDominatedBlock(then);
612 otherwise->SetDominator(cursor_block);
613 cursor_block->AddDominatedBlock(otherwise);
614 merge->SetDominator(cursor_block);
615 cursor_block->AddDominatedBlock(merge);
616
617 // Update the revert post order.
618 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
619 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
620 graph_->reverse_post_order_[++index] = then;
621 index = IndexOfElement(graph_->reverse_post_order_, end_then);
622 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
623 graph_->reverse_post_order_[++index] = otherwise;
624 graph_->reverse_post_order_[++index] = merge;
625
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000626
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000627 graph_->UpdateLoopAndTryInformationOfNewBlock(
628 then, original_invoke_block, /* replace_if_back_edge */ false);
629 graph_->UpdateLoopAndTryInformationOfNewBlock(
630 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
631
632 // In case the original invoke location was a back edge, we need to update
633 // the loop to now have the merge block as a back edge.
634 graph_->UpdateLoopAndTryInformationOfNewBlock(
635 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000636}
637
638bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction,
639 ArtMethod* resolved_method,
640 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000641 // This optimization only works under JIT for now.
Calin Juravleffc87072016-04-20 14:22:09 +0100642 DCHECK(Runtime::Current()->UseJitCompilation());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000643 if (graph_->GetInstructionSet() == kMips64) {
644 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000645 return false;
646 }
647 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700648 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000649
650 DCHECK(resolved_method != nullptr);
651 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000652 size_t method_index = invoke_instruction->IsInvokeVirtual()
653 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
654 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
655
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000656 // Check whether we are actually calling the same method among
657 // the different types seen.
658 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
659 if (ic.GetTypeAt(i) == nullptr) {
660 break;
661 }
662 ArtMethod* new_method = nullptr;
663 if (invoke_instruction->IsInvokeInterface()) {
Artem Udovichenkoa62cb9b2016-06-30 09:18:25 +0000664 new_method = ic.GetTypeAt(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +0000665 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000666 if (new_method->IsRuntimeMethod()) {
667 // Bail out as soon as we see a conflict trampoline in one of the target's
668 // interface table.
669 return false;
670 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000671 } else {
672 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000673 new_method = ic.GetTypeAt(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000674 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000675 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000676 if (actual_method == nullptr) {
677 actual_method = new_method;
678 } else if (actual_method != new_method) {
679 // Different methods, bailout.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000680 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
681 << " from inline cache is not inlined because it resolves"
682 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000683 return false;
684 }
685 }
686
687 HInstruction* receiver = invoke_instruction->InputAt(0);
688 HInstruction* cursor = invoke_instruction->GetPrevious();
689 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
690
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100691 HInstruction* return_replacement = nullptr;
692 if (!TryBuildAndInline(invoke_instruction, actual_method, &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000693 return false;
694 }
695
696 // We successfully inlined, now add a guard.
697 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
698 class_linker, receiver, invoke_instruction->GetDexPc());
699
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000700 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
701 ? Primitive::kPrimLong
702 : Primitive::kPrimInt;
703 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
704 receiver_class,
705 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000706 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
707 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000708 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000709 invoke_instruction->GetDexPc());
710
711 HConstant* constant;
712 if (type == Primitive::kPrimLong) {
713 constant = graph_->GetLongConstant(
714 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
715 } else {
716 constant = graph_->GetIntConstant(
717 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
718 }
719
720 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000721 if (cursor != nullptr) {
722 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
723 } else {
724 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
725 }
726 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
727 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100728
729 if (outermost_graph_->IsCompilingOsr()) {
730 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
731 } else {
732 // TODO: Extend reference type propagation to understand the guard.
733 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
734 compare, invoke_instruction->GetDexPc());
735 bb_cursor->InsertInstructionAfter(deoptimize, compare);
736 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
737 if (return_replacement != nullptr) {
738 invoke_instruction->ReplaceWith(return_replacement);
739 }
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +0100740 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100741 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000742
743 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000744 ReferenceTypePropagation rtp_fixup(graph_,
745 outer_compilation_unit_.GetDexCache(),
746 handles_,
747 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000748 rtp_fixup.Run();
749
750 MaybeRecordStat(kInlinedPolymorphicCall);
751
752 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100753}
754
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000755bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
756 HInstruction* return_replacement = nullptr;
757 if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000758 if (invoke_instruction->IsInvokeInterface()) {
759 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
760 // better than an invoke-interface because:
761 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
762 // 2) We will not go to the conflict trampoline with an invoke-virtual.
763 // TODO: Consider sharpening once it is not dependent on the compiler driver.
764 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
765 uint32_t method_index = FindMethodIndexIn(
766 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
767 if (method_index == DexFile::kDexNoIndex) {
768 return false;
769 }
770 HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual(
771 graph_->GetArena(),
772 invoke_instruction->GetNumberOfArguments(),
773 invoke_instruction->GetType(),
774 invoke_instruction->GetDexPc(),
775 method_index,
776 method->GetMethodIndex());
777 HInputsRef inputs = invoke_instruction->GetInputs();
778 for (size_t index = 0; index != inputs.size(); ++index) {
779 new_invoke->SetArgumentAt(index, inputs[index]);
780 }
781 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
782 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
783 if (invoke_instruction->GetType() == Primitive::kPrimNot) {
784 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
785 }
786 return_replacement = new_invoke;
787 } else {
788 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
789 // compiler driver.
790 return false;
791 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000792 }
793 if (return_replacement != nullptr) {
794 invoke_instruction->ReplaceWith(return_replacement);
795 }
796 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +0100797 FixUpReturnReferenceType(method, return_replacement);
798 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
799 // Actual return value has a more specific type than the method's declared
800 // return type. Run RTP again on the outer graph to propagate it.
801 ReferenceTypePropagation(graph_,
802 outer_compilation_unit_.GetDexCache(),
803 handles_,
804 /* is_first_run */ false).Run();
805 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000806 return true;
807}
808
809bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
810 ArtMethod* method,
811 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100812 if (method->IsProxyMethod()) {
813 VLOG(compiler) << "Method " << PrettyMethod(method)
814 << " is not inlined because of unimplemented inline support for proxy methods.";
815 return false;
816 }
817
Jeff Haodcdc85b2015-12-04 14:06:18 -0800818 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
819 // dex file here (though the transitivity of an inline chain would allow checking the calller).
820 if (!compiler_driver_->MayInline(method->GetDexFile(),
821 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000822 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000823 VLOG(compiler) << "Successfully replaced pattern of invoke " << PrettyMethod(method);
824 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
825 return true;
826 }
Jeff Haodcdc85b2015-12-04 14:06:18 -0800827 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
828 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
829 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
830 << method->GetDexFile()->GetLocation();
831 return false;
832 }
833
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100834 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
835
836 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000837
838 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100839 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000840 << " is not inlined because it is native";
841 return false;
842 }
843
Calin Juravleec748352015-07-29 13:52:12 +0100844 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
845 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100846 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000847 << " is too big to inline: "
848 << code_item->insns_size_in_code_units_
849 << " > "
850 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000851 return false;
852 }
853
854 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100855 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000856 << " is not inlined because of try block";
857 return false;
858 }
859
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100860 if (!method->IsCompilable()) {
861 VLOG(compiler) << "Method " << PrettyMethod(method)
862 << " has soft failures un-handled by the compiler, so it cannot be inlined";
863 }
864
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100865 if (!method->GetDeclaringClass()->IsVerified()) {
866 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +0100867 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000868 !compiler_driver_->IsMethodVerifiedWithoutFailures(
869 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100870 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100871 << " couldn't be verified, so it cannot be inlined";
872 return false;
873 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000874 }
875
Roland Levillain4c0eb422015-04-24 16:43:49 +0100876 if (invoke_instruction->IsInvokeStaticOrDirect() &&
877 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
878 // Case of a static method that cannot be inlined because it implicitly
879 // requires an initialization check of its declaring class.
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100880 VLOG(compiler) << "Method " << PrettyMethod(method)
Roland Levillain4c0eb422015-04-24 16:43:49 +0100881 << " is not inlined because it is static and requires a clinit"
882 << " check that cannot be emitted due to Dex cache limitations";
883 return false;
884 }
885
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000886 if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000887 return false;
888 }
889
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100890 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000891 MaybeRecordStat(kInlinedInvoke);
892 return true;
893}
894
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000895static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
896 size_t arg_vreg_index)
897 SHARED_REQUIRES(Locks::mutator_lock_) {
898 size_t input_index = 0;
899 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
900 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
901 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
902 ++i;
903 DCHECK_NE(i, arg_vreg_index);
904 }
905 }
906 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
907 return invoke_instruction->InputAt(input_index);
908}
909
910// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
911bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
912 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000913 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000914 InlineMethod inline_method;
915 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
916 return false;
917 }
918
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000919 switch (inline_method.opcode) {
920 case kInlineOpNop:
921 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000922 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000923 break;
924 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000925 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
926 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000927 break;
928 case kInlineOpNonWideConst:
929 if (resolved_method->GetShorty()[0] == 'L') {
930 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000931 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000932 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000933 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000934 }
935 break;
936 case kInlineOpIGet: {
937 const InlineIGetIPutData& data = inline_method.d.ifield_data;
938 if (data.method_is_static || data.object_arg != 0u) {
939 // TODO: Needs null check.
940 return false;
941 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000942 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000943 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000944 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000945 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
946 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
947 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000948 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000949 break;
950 }
951 case kInlineOpIPut: {
952 const InlineIGetIPutData& data = inline_method.d.ifield_data;
953 if (data.method_is_static || data.object_arg != 0u) {
954 // TODO: Needs null check.
955 return false;
956 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000957 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000958 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
959 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000960 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000961 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
962 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
963 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
964 if (data.return_arg_plus1 != 0u) {
965 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000966 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000967 }
968 break;
969 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000970 case kInlineOpConstructor: {
971 const InlineConstructorData& data = inline_method.d.constructor_data;
972 // Get the indexes to arrays for easier processing.
973 uint16_t iput_field_indexes[] = {
974 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
975 };
976 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
977 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
978 // Count valid field indexes.
979 size_t number_of_iputs = 0u;
980 while (number_of_iputs != arraysize(iput_field_indexes) &&
981 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
982 // Check that there are no duplicate valid field indexes.
983 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
984 iput_field_indexes + arraysize(iput_field_indexes),
985 iput_field_indexes[number_of_iputs]));
986 ++number_of_iputs;
987 }
988 // Check that there are no valid field indexes in the rest of the array.
989 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
990 iput_field_indexes + arraysize(iput_field_indexes),
991 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
992
993 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
994 Handle<mirror::DexCache> dex_cache;
995 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
996 bool needs_constructor_barrier = false;
997 for (size_t i = 0; i != number_of_iputs; ++i) {
998 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +0000999 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001000 if (dex_cache.GetReference() == nullptr) {
1001 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
1002 }
1003 uint16_t field_index = iput_field_indexes[i];
1004 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
1005 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1006
1007 // Check whether the field is final. If it is, we need to add a barrier.
Andreas Gampe542451c2016-07-26 09:02:02 -07001008 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Marko354efa62016-02-04 19:46:56 +00001009 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1010 DCHECK(resolved_field != nullptr);
1011 if (resolved_field->IsFinal()) {
1012 needs_constructor_barrier = true;
1013 }
1014 }
1015 }
1016 if (needs_constructor_barrier) {
1017 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
1018 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
1019 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001020 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001021 break;
1022 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001023 default:
1024 LOG(FATAL) << "UNREACHABLE";
1025 UNREACHABLE();
1026 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001027 return true;
1028}
1029
Vladimir Marko354efa62016-02-04 19:46:56 +00001030HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001031 uint32_t field_index,
1032 HInstruction* obj)
1033 SHARED_REQUIRES(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001034 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001035 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1036 DCHECK(resolved_field != nullptr);
1037 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1038 obj,
1039 resolved_field->GetTypeAsPrimitiveType(),
1040 resolved_field->GetOffset(),
1041 resolved_field->IsVolatile(),
1042 field_index,
1043 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001044 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001045 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +00001046 // Read barrier generates a runtime call in slow path and we need a valid
1047 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1048 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001049 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001050 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
1051 ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001052 rtp.Visit(iget);
1053 }
1054 return iget;
1055}
1056
Vladimir Marko354efa62016-02-04 19:46:56 +00001057HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001058 uint32_t field_index,
1059 HInstruction* obj,
1060 HInstruction* value)
1061 SHARED_REQUIRES(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001062 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001063 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1064 DCHECK(resolved_field != nullptr);
1065 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1066 obj,
1067 value,
1068 resolved_field->GetTypeAsPrimitiveType(),
1069 resolved_field->GetOffset(),
1070 resolved_field->IsVolatile(),
1071 field_index,
1072 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001073 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001074 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +00001075 // Read barrier generates a runtime call in slow path and we need a valid
1076 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1077 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001078 return iput;
1079}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001080
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001081bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1082 ArtMethod* resolved_method,
1083 bool same_dex_file,
1084 HInstruction** return_replacement) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001085 ScopedObjectAccess soa(Thread::Current());
1086 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001087 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1088 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001089 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001090 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001091 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001092 caller_compilation_unit_.GetClassLoader(),
1093 class_linker,
1094 callee_dex_file,
1095 code_item,
1096 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1097 method_index,
1098 resolved_method->GetAccessFlags(),
1099 /* verified_method */ nullptr,
1100 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001101
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001102 bool requires_ctor_barrier = false;
1103
1104 if (dex_compilation_unit.IsConstructor()) {
1105 // If it's a super invocation and we already generate a barrier there's no need
1106 // to generate another one.
1107 // We identify super calls by looking at the "this" pointer. If its value is the
1108 // same as the local "this" pointer then we must have a super invocation.
1109 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1110 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1111 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1112 requires_ctor_barrier = false;
1113 } else {
1114 Thread* self = Thread::Current();
1115 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1116 dex_compilation_unit.GetDexFile(),
1117 dex_compilation_unit.GetClassDefIndex());
1118 }
1119 }
1120
Nicolas Geoffray35071052015-06-09 15:43:38 +01001121 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
1122 if (invoke_type == kInterface) {
1123 // We have statically resolved the dispatch. To please the class linker
1124 // at runtime, we change this call as if it was a virtual call.
1125 invoke_type = kVirtual;
1126 }
David Brazdil3f523062016-02-29 16:53:33 +00001127
1128 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001129 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001130 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001131 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001132 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001133 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001134 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001135 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001136 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001137 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001138 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001139 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001140
Roland Levillaina8013fd2016-04-04 15:34:31 +01001141 // When they are needed, allocate `inline_stats` on the heap instead
1142 // of on the stack, as Clang might produce a stack frame too large
1143 // for this function, that would not fit the requirements of the
1144 // `-Wframe-larger-than` option.
1145 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1146 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001147 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001148 &dex_compilation_unit,
1149 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001150 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001151 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001152 compiler_driver_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001153 inline_stats.get(),
Mathieu Chartier736b5602015-09-02 14:54:11 -07001154 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001155 dex_cache,
1156 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001157
David Brazdildee58d62016-04-07 09:54:26 +00001158 if (builder.BuildGraph() != kAnalysisSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001159 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001160 << " could not be built, so cannot be inlined";
1161 return false;
1162 }
1163
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001164 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1165 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001166 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001167 << " cannot be inlined because of the register allocator";
1168 return false;
1169 }
1170
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001171 size_t parameter_index = 0;
1172 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1173 !instructions.Done();
1174 instructions.Advance()) {
1175 HInstruction* current = instructions.Current();
1176 if (current->IsParameterValue()) {
1177 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
1178 if (argument->IsNullConstant()) {
1179 current->ReplaceWith(callee_graph->GetNullConstant());
1180 } else if (argument->IsIntConstant()) {
1181 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1182 } else if (argument->IsLongConstant()) {
1183 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1184 } else if (argument->IsFloatConstant()) {
1185 current->ReplaceWith(
1186 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1187 } else if (argument->IsDoubleConstant()) {
1188 current->ReplaceWith(
1189 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1190 } else if (argument->GetType() == Primitive::kPrimNot) {
1191 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1192 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1193 }
1194 }
1195 }
1196
David Brazdil94ab38f2016-06-21 17:48:19 +01001197 // We have replaced formal arguments with actual arguments. If actual types
1198 // are more specific than the declared ones, run RTP again on the inner graph.
1199 if (ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
1200 ReferenceTypePropagation(callee_graph,
1201 dex_compilation_unit.GetDexCache(),
1202 handles_,
1203 /* is_first_run */ false).Run();
1204 }
1205
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001206 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001207 size_t number_of_inlined_instructions =
1208 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1209 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001210
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001211 // TODO: We should abort only if all predecessors throw. However,
1212 // HGraph::InlineInto currently does not handle an exit block with
1213 // a throw predecessor.
1214 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1215 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001216 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001217 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001218 return false;
1219 }
1220
1221 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001222 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1223 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001224 has_throw_predecessor = true;
1225 break;
1226 }
1227 }
1228 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001229 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001230 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001231 return false;
1232 }
1233
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001234 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001235 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001236 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001237
1238 bool can_inline_environment =
1239 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1240
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001241 for (; !it.Done(); it.Advance()) {
1242 HBasicBlock* block = it.Current();
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001243
1244 if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) {
1245 // Don't inline methods with irreducible loops, they could prevent some
1246 // optimizations to run.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001247 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001248 << " could not be inlined because it contains an irreducible loop";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001249 return false;
1250 }
1251
1252 for (HInstructionIterator instr_it(block->GetInstructions());
1253 !instr_it.Done();
1254 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001255 if (number_of_instructions++ == number_of_instructions_budget) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001256 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001257 << " is not inlined because its caller has reached"
1258 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001259 return false;
1260 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001261 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001262 if (!can_inline_environment && current->NeedsEnvironment()) {
1263 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1264 << " is not inlined because its caller has reached"
1265 << " its environment budget limit.";
1266 return false;
1267 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001268
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001269 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001270 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001271 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001272 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001273 return false;
1274 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001275
Vladimir Markodc151b22015-10-15 18:02:30 +01001276 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001277 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001278 << " could not be inlined because " << current->DebugName()
1279 << " it is in a different dex file and requires access to the dex cache";
1280 return false;
1281 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001282
1283 if (current->IsNewInstance() &&
1284 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001285 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1286 << " could not be inlined because it is using an entrypoint"
1287 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001288 // Allocation entrypoint does not handle inlined frames.
1289 return false;
1290 }
1291
1292 if (current->IsNewArray() &&
1293 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001294 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1295 << " could not be inlined because it is using an entrypoint"
1296 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001297 // Allocation entrypoint does not handle inlined frames.
1298 return false;
1299 }
1300
1301 if (current->IsUnresolvedStaticFieldGet() ||
1302 current->IsUnresolvedInstanceFieldGet() ||
1303 current->IsUnresolvedStaticFieldSet() ||
1304 current->IsUnresolvedInstanceFieldSet()) {
1305 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001306 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1307 << " could not be inlined because it is using an unresolved"
1308 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001309 return false;
1310 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001311 }
1312 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001313 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001314
David Brazdil3f523062016-02-29 16:53:33 +00001315 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1316 << "No instructions can be added to the outer graph while inner graph is being built";
1317
1318 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1319 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001320 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001321
1322 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1323 << "No instructions can be added to the inner graph during inlining into the outer graph";
1324
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001325 return true;
1326}
Calin Juravle2e768302015-07-28 14:41:11 +00001327
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001328size_t HInliner::RunOptimizations(HGraph* callee_graph,
1329 const DexFile::CodeItem* code_item,
1330 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001331 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1332 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001333 HDeadCodeElimination dce(callee_graph, stats_);
1334 HConstantFolding fold(callee_graph);
1335 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
1336 InstructionSimplifier simplify(callee_graph, stats_);
1337 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_, stats_);
1338
1339 HOptimization* optimizations[] = {
1340 &intrinsics,
1341 &sharpening,
1342 &simplify,
1343 &fold,
1344 &dce,
1345 };
1346
1347 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1348 HOptimization* optimization = optimizations[i];
1349 optimization->Run();
1350 }
1351
1352 size_t number_of_inlined_instructions = 0u;
1353 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1354 HInliner inliner(callee_graph,
1355 outermost_graph_,
1356 codegen_,
1357 outer_compilation_unit_,
1358 dex_compilation_unit,
1359 compiler_driver_,
1360 handles_,
1361 stats_,
1362 total_number_of_dex_registers_ + code_item->registers_size_,
1363 depth_ + 1);
1364 inliner.Run();
1365 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1366 }
1367
1368 return number_of_inlined_instructions;
1369}
1370
David Brazdil94ab38f2016-06-21 17:48:19 +01001371static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1372 bool declared_can_be_null,
1373 HInstruction* actual_obj)
1374 SHARED_REQUIRES(Locks::mutator_lock_) {
1375 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1376 return true;
1377 }
1378
1379 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1380 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
1381 declared_rti.IsStrictSupertypeOf(actual_rti);
1382}
1383
1384ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1385 return ReferenceTypePropagation::IsAdmissible(klass)
1386 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1387 : graph_->GetInexactObjectRti();
1388}
1389
1390bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1391 // If this is an instance call, test whether the type of the `this` argument
1392 // is more specific than the class which declares the method.
1393 if (!resolved_method->IsStatic()) {
1394 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1395 /* declared_can_be_null */ false,
1396 invoke_instruction->InputAt(0u))) {
1397 return true;
1398 }
1399 }
1400
Andreas Gampe542451c2016-07-26 09:02:02 -07001401 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
David Brazdil94ab38f2016-06-21 17:48:19 +01001402
1403 // Iterate over the list of parameter types and test whether any of the
1404 // actual inputs has a more specific reference type than the type declared in
1405 // the signature.
1406 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1407 for (size_t param_idx = 0,
1408 input_idx = resolved_method->IsStatic() ? 0 : 1,
1409 e = (param_list == nullptr ? 0 : param_list->Size());
1410 param_idx < e;
1411 ++param_idx, ++input_idx) {
1412 HInstruction* input = invoke_instruction->InputAt(input_idx);
1413 if (input->GetType() == Primitive::kPrimNot) {
1414 mirror::Class* param_cls = resolved_method->GetDexCacheResolvedType(
1415 param_list->GetTypeItem(param_idx).type_idx_,
1416 pointer_size);
1417 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1418 /* declared_can_be_null */ true,
1419 input)) {
1420 return true;
1421 }
1422 }
1423 }
1424
1425 return false;
1426}
1427
1428bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1429 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001430 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001431 if (return_replacement != nullptr) {
1432 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001433 // Test if the return type is a refinement of the declared return type.
1434 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1435 /* declared_can_be_null */ true,
1436 return_replacement)) {
1437 return true;
1438 }
1439 } else if (return_replacement->IsInstanceOf()) {
1440 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1441 return true;
1442 }
1443 }
1444
1445 return false;
1446}
1447
1448void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1449 HInstruction* return_replacement) {
1450 if (return_replacement != nullptr) {
1451 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001452 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1453 // Make sure that we have a valid type for the return. We may get an invalid one when
1454 // we inline invokes with multiple branches and create a Phi for the result.
1455 // TODO: we could be more precise by merging the phi inputs but that requires
1456 // some functionality from the reference type propagation.
1457 DCHECK(return_replacement->IsPhi());
Andreas Gampe542451c2016-07-26 09:02:02 -07001458 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001459 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */, pointer_size);
David Brazdil94ab38f2016-06-21 17:48:19 +01001460 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001461 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001462 }
Calin Juravle2e768302015-07-28 14:41:11 +00001463 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001464}
1465
1466} // namespace art