blob: 5d7cbed7e616bf668827209fbc41ab704f04a384 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010019#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080020#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070021#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010022#include "dex/global_value_numbering.h"
Vladimir Marko9820b7c2014-01-02 16:40:37 +000023#include "dex/quick/dex_file_method_inliner.h"
24#include "dex/quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -070031 return bb->predecessors->Size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800189 switch (mir->dalvikInsn.opcode) {
190 case Instruction::MOVE:
191 case Instruction::MOVE_OBJECT:
192 case Instruction::MOVE_16:
193 case Instruction::MOVE_OBJECT_16:
194 case Instruction::MOVE_FROM16:
195 case Instruction::MOVE_OBJECT_FROM16:
196 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700197 case Instruction::CONST:
198 case Instruction::CONST_4:
199 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800200 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::GOTO:
202 case Instruction::GOTO_16:
203 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700205 default:
206 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800207 }
buzbee311ca162013-02-28 15:56:43 -0800208}
209
Vladimir Markoa1a70742014-03-03 10:28:05 +0000210static constexpr ConditionCode kIfCcZConditionCodes[] = {
211 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
212};
213
214COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
215 if_ccz_ccodes_size1);
216
217static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
218 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
219}
220
221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
225COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
226COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
227COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
228COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
229COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
230COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
buzbee862a7602013-04-05 10:58:54 -0700233 return raw_use_counts_.Get(s_reg);
buzbee311ca162013-02-28 15:56:43 -0800234}
235
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700236size_t MIRGraph::GetNumBytesForSpecialTemps() const {
237 // This logic is written with assumption that Method* is only special temp.
238 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
239 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800240}
241
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700242size_t MIRGraph::GetNumAvailableVRTemps() {
243 // First take into account all temps reserved for backend.
244 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
245 return 0;
246 }
247
248 // Calculate remaining ME temps available.
249 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
250
251 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
252 return 0;
253 } else {
254 return remaining_me_temps - num_non_special_compiler_temps_;
255 }
256}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000257
258// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800259static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700260 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000261 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800262
263CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700264 // Once the compiler temps have been committed, new ones cannot be requested anymore.
265 DCHECK_EQ(compiler_temps_committed_, false);
266 // Make sure that reserved for BE set is sane.
267 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
268
269 bool verbose = cu_->verbose;
270 const char* ct_type_str = nullptr;
271
272 if (verbose) {
273 switch (ct_type) {
274 case kCompilerTempBackend:
275 ct_type_str = "backend";
276 break;
277 case kCompilerTempSpecialMethodPtr:
278 ct_type_str = "method*";
279 break;
280 case kCompilerTempVR:
281 ct_type_str = "VR";
282 break;
283 default:
284 ct_type_str = "unknown";
285 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800286 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700287 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
288 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800289 }
290
291 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000292 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800293
294 // Create the type of temp requested. Special temps need special handling because
295 // they have a specific virtual register assignment.
296 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700297 // This has a special location on stack which is 32-bit or 64-bit depending
298 // on mode. However, we don't want to overlap with non-special section
299 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800300 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700302 // The vreg is always the first special temp for method ptr.
303 compiler_temp->v_reg = GetFirstSpecialTempVR();
304
305 } else if (ct_type == kCompilerTempBackend) {
306 requested_backend_temp_ = true;
307
308 // Make sure that we are not exceeding temps reserved for BE.
309 // Since VR temps cannot be requested once the BE temps are requested, we
310 // allow reservation of VR temps as well for BE. We
311 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
312 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
313 if (verbose) {
314 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
315 }
316 return nullptr;
317 }
318
319 // Update the remaining reserved temps since we have now used them.
320 // Note that the code below is actually subtracting to remove them from reserve
321 // once they have been claimed. It is careful to not go below zero.
322 if (reserved_temps_for_backend_ >= 1) {
323 reserved_temps_for_backend_--;
324 }
325 if (wide && reserved_temps_for_backend_ >= 1) {
326 reserved_temps_for_backend_--;
327 }
328
329 // The new non-special compiler temp must receive a unique v_reg.
330 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
331 num_non_special_compiler_temps_++;
332 } else if (ct_type == kCompilerTempVR) {
333 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
334 // This is done in order to prevent problems with ssa since these structures are allocated
335 // and managed by the ME.
336 DCHECK_EQ(requested_backend_temp_, false);
337
338 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
339 size_t available_temps = GetNumAvailableVRTemps();
340 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
341 if (verbose) {
342 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
343 }
344 return nullptr;
345 }
346
347 // The new non-special compiler temp must receive a unique v_reg.
348 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
349 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800350 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700351 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
352 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800353
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700354 // We allocate an sreg as well to make developer life easier.
355 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
356 // this sreg is no longer valid. The caller should be aware of this.
357 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
358
359 if (verbose) {
360 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
361 << " and s" << compiler_temp->s_reg_low << " has been created.";
362 }
363
364 if (wide) {
365 // Only non-special temps are handled as wide for now.
366 // Note that the number of non special temps is incremented below.
367 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
368
369 // Ensure that the two registers are consecutive.
370 int ssa_reg_low = compiler_temp->s_reg_low;
371 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800372 num_non_special_compiler_temps_++;
373
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700374 if (verbose) {
375 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
376 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
377 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700378
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700379 if (reg_location_ != nullptr) {
380 reg_location_[ssa_reg_high] = temp_loc;
381 reg_location_[ssa_reg_high].high_word = true;
382 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
383 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800384 }
385 }
386
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700387 // If the register locations have already been allocated, add the information
388 // about the temp. We will not overflow because they have been initialized
389 // to support the maximum number of temps. For ME temps that have multiple
390 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800391 if (reg_location_ != nullptr) {
392 int ssa_reg_low = compiler_temp->s_reg_low;
393 reg_location_[ssa_reg_low] = temp_loc;
394 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
395 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800396 }
397
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800398 return compiler_temp;
399}
buzbee311ca162013-02-28 15:56:43 -0800400
401/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700402bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800403 if (bb->block_type == kDead) {
404 return true;
405 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100406 // Don't do a separate LVN if we did the GVN.
Vladimir Marko55fff042014-07-10 12:42:52 +0100407 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kGlobalValueNumbering)) != 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100408 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100409 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700410 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800411 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100412 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko95a05972014-05-30 10:01:32 +0100413 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get()));
Vladimir Markob19955d2014-07-29 12:04:10 +0100414 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
415 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800416 }
buzbee311ca162013-02-28 15:56:43 -0800417 while (bb != NULL) {
418 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
419 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800420 if (use_lvn) {
421 local_valnum->GetValueNumber(mir);
422 }
buzbee311ca162013-02-28 15:56:43 -0800423 // Look for interesting opcodes, skip otherwise
424 Instruction::Code opcode = mir->dalvikInsn.opcode;
425 switch (opcode) {
426 case Instruction::CMPL_FLOAT:
427 case Instruction::CMPL_DOUBLE:
428 case Instruction::CMPG_FLOAT:
429 case Instruction::CMPG_DOUBLE:
430 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700431 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800432 // Bitcode doesn't allow this optimization.
433 break;
434 }
435 if (mir->next != NULL) {
436 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800437 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700438 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800439 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
440 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000441 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700442 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800443 case Instruction::CMPL_FLOAT:
444 mir_next->dalvikInsn.opcode =
445 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
446 break;
447 case Instruction::CMPL_DOUBLE:
448 mir_next->dalvikInsn.opcode =
449 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
450 break;
451 case Instruction::CMPG_FLOAT:
452 mir_next->dalvikInsn.opcode =
453 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
454 break;
455 case Instruction::CMPG_DOUBLE:
456 mir_next->dalvikInsn.opcode =
457 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
458 break;
459 case Instruction::CMP_LONG:
460 mir_next->dalvikInsn.opcode =
461 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
462 break;
463 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
464 }
465 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700466 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800467 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
468 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
469 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
470 mir_next->ssa_rep->num_defs = 0;
471 mir->ssa_rep->num_uses = 0;
472 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700473 // Copy in the decoded instruction information for potential SSA re-creation.
474 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
475 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800476 }
477 }
478 break;
479 case Instruction::GOTO:
480 case Instruction::GOTO_16:
481 case Instruction::GOTO_32:
482 case Instruction::IF_EQ:
483 case Instruction::IF_NE:
484 case Instruction::IF_LT:
485 case Instruction::IF_GE:
486 case Instruction::IF_GT:
487 case Instruction::IF_LE:
488 case Instruction::IF_EQZ:
489 case Instruction::IF_NEZ:
490 case Instruction::IF_LTZ:
491 case Instruction::IF_GEZ:
492 case Instruction::IF_GTZ:
493 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700494 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700495 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
496 (IsBackedge(bb, bb->fall_through) &&
497 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800498 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
499 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700500 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
501 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800502 }
503 }
504 break;
505 default:
506 break;
507 }
508 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800509 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800510 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000511 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100512 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
513 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000514 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700515 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800516 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700517 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
518 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800519
buzbee0d829482013-10-11 15:24:55 -0700520 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800521 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700522 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
523 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800524
525 /*
526 * In the select pattern, the taken edge goes to a block that unconditionally
527 * transfers to the rejoin block and the fall_though edge goes to a block that
528 * unconditionally falls through to the rejoin block.
529 */
530 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
531 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
532 /*
533 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
534 * suspend check on the taken-taken branch back to the join point.
535 */
536 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
537 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
538 }
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100539
540 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800541 // Are the block bodies something we can handle?
542 if ((ft->first_mir_insn == ft->last_mir_insn) &&
543 (tk->first_mir_insn != tk->last_mir_insn) &&
544 (tk->first_mir_insn->next == tk->last_mir_insn) &&
545 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
546 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
547 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
548 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
549 // Almost there. Are the instructions targeting the same vreg?
550 MIR* if_true = tk->first_mir_insn;
551 MIR* if_false = ft->first_mir_insn;
552 // It's possible that the target of the select isn't used - skip those (rare) cases.
553 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
554 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
555 /*
556 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
557 * Phi node in the merge block and delete it (while using the SSA name
558 * of the merge as the target of the SELECT. Delete both taken and
559 * fallthrough blocks, and set fallthrough to merge block.
560 * NOTE: not updating other dataflow info (no longer used at this point).
561 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
562 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000563 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800564 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
565 bool const_form = (SelectKind(if_true) == kSelectConst);
566 if ((SelectKind(if_true) == kSelectMove)) {
567 if (IsConst(if_true->ssa_rep->uses[0]) &&
568 IsConst(if_false->ssa_rep->uses[0])) {
569 const_form = true;
570 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
571 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
572 }
573 }
574 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800575 /*
576 * TODO: If both constants are the same value, then instead of generating
577 * a select, we should simply generate a const bytecode. This should be
578 * considered after inlining which can lead to CFG of this form.
579 */
buzbee311ca162013-02-28 15:56:43 -0800580 // "true" set val in vB
581 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
582 // "false" set val in vC
583 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
584 } else {
585 DCHECK_EQ(SelectKind(if_true), kSelectMove);
586 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700587 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000588 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800589 src_ssa[0] = mir->ssa_rep->uses[0];
590 src_ssa[1] = if_true->ssa_rep->uses[0];
591 src_ssa[2] = if_false->ssa_rep->uses[0];
592 mir->ssa_rep->uses = src_ssa;
593 mir->ssa_rep->num_uses = 3;
594 }
595 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700596 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000597 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700598 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000599 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800600 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700601 // Match type of uses to def.
602 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700603 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000604 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700605 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
606 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
607 }
buzbee311ca162013-02-28 15:56:43 -0800608 /*
609 * There is usually a Phi node in the join block for our two cases. If the
610 * Phi node only contains our two cases as input, we will use the result
611 * SSA name of the Phi node as our select result and delete the Phi. If
612 * the Phi node has more than two operands, we will arbitrarily use the SSA
613 * name of the "true" path, delete the SSA name of the "false" path from the
614 * Phi node (and fix up the incoming arc list).
615 */
616 if (phi->ssa_rep->num_uses == 2) {
617 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
618 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
619 } else {
620 int dead_def = if_false->ssa_rep->defs[0];
621 int live_def = if_true->ssa_rep->defs[0];
622 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700623 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800624 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
625 if (phi->ssa_rep->uses[i] == live_def) {
626 incoming[i] = bb->id;
627 }
628 }
629 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
630 if (phi->ssa_rep->uses[i] == dead_def) {
631 int last_slot = phi->ssa_rep->num_uses - 1;
632 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
633 incoming[i] = incoming[last_slot];
634 }
635 }
636 }
637 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700638 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800639 tk->block_type = kDead;
640 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
641 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
642 }
643 }
644 }
645 }
646 }
647 }
buzbee1da1e2f2013-11-15 13:37:01 -0800648 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800649 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100650 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100651 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
652 }
buzbee311ca162013-02-28 15:56:43 -0800653
buzbee311ca162013-02-28 15:56:43 -0800654 return true;
655}
656
buzbee311ca162013-02-28 15:56:43 -0800657/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700658void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700659 if (bb->data_flow_info != NULL) {
660 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
661 if (mir->ssa_rep == NULL) {
662 continue;
buzbee311ca162013-02-28 15:56:43 -0800663 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700664 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700665 if (df_attributes & DF_HAS_NULL_CHKS) {
666 checkstats_->null_checks++;
667 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
668 checkstats_->null_checks_eliminated++;
669 }
670 }
671 if (df_attributes & DF_HAS_RANGE_CHKS) {
672 checkstats_->range_checks++;
673 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
674 checkstats_->range_checks_eliminated++;
675 }
buzbee311ca162013-02-28 15:56:43 -0800676 }
677 }
678 }
buzbee311ca162013-02-28 15:56:43 -0800679}
680
681/* Try to make common case the fallthrough path */
buzbee0d829482013-10-11 15:24:55 -0700682bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800683 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback
684 if (!bb->explicit_throw) {
685 return false;
686 }
687 BasicBlock* walker = bb;
688 while (true) {
689 // Check termination conditions
690 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
691 break;
692 }
buzbee0d829482013-10-11 15:24:55 -0700693 BasicBlock* prev = GetBasicBlock(walker->predecessors->Get(0));
buzbee311ca162013-02-28 15:56:43 -0800694 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700695 if (GetBasicBlock(prev->fall_through) == walker) {
buzbee311ca162013-02-28 15:56:43 -0800696 // Already done - return
697 break;
698 }
buzbee0d829482013-10-11 15:24:55 -0700699 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
buzbee311ca162013-02-28 15:56:43 -0800700 // Got one. Flip it and exit
701 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
702 switch (opcode) {
703 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
704 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
705 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
706 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
707 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
708 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
709 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
710 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
711 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
712 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
713 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
714 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
715 default: LOG(FATAL) << "Unexpected opcode " << opcode;
716 }
717 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700718 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800719 prev->taken = prev->fall_through;
720 prev->fall_through = t_bb;
721 break;
722 }
723 walker = prev;
724 }
725 return false;
726}
727
728/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800729void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800730 // Loop here to allow combining a sequence of blocks
731 while (true) {
732 // Check termination conditions
733 if ((bb->first_mir_insn == NULL)
734 || (bb->data_flow_info == NULL)
735 || (bb->block_type == kExceptionHandling)
736 || (bb->block_type == kExitBlock)
737 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700738 || (bb->taken == NullBasicBlockId)
739 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
740 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800741 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
742 break;
743 }
744
745 // Test the kMirOpCheck instruction
746 MIR* mir = bb->last_mir_insn;
747 // Grab the attributes from the paired opcode
748 MIR* throw_insn = mir->meta.throw_insn;
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700749 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
buzbee311ca162013-02-28 15:56:43 -0800750 bool can_combine = true;
751 if (df_attributes & DF_HAS_NULL_CHKS) {
752 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
753 }
754 if (df_attributes & DF_HAS_RANGE_CHKS) {
755 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
756 }
757 if (!can_combine) {
758 break;
759 }
760 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700761 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800762 DCHECK(!bb_next->catch_entry);
763 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800764 // Overwrite the kOpCheck insn with the paired opcode
765 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
766 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800767 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700768 bb->successor_block_list_type = bb_next->successor_block_list_type;
769 bb->successor_blocks = bb_next->successor_blocks;
buzbee311ca162013-02-28 15:56:43 -0800770 // Use the ending block linkage from the next block
771 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700772 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800773 bb->taken = bb_next->taken;
774 // Include the rest of the instructions
775 bb->last_mir_insn = bb_next->last_mir_insn;
776 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900777 * If lower-half of pair of blocks to combine contained
778 * a return or a conditional branch or an explicit throw,
779 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800780 */
781 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900782 bb->conditional_branch = bb_next->conditional_branch;
783 bb->explicit_throw = bb_next->explicit_throw;
buzbee311ca162013-02-28 15:56:43 -0800784
785 /*
786 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
787 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
788 */
789
790 // Kill bb_next and remap now-dead id to parent
791 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700792 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800793
794 // Now, loop back and see if we can keep going
795 }
buzbee311ca162013-02-28 15:56:43 -0800796}
797
Vladimir Markobfea9c22014-01-17 17:49:33 +0000798void MIRGraph::EliminateNullChecksAndInferTypesStart() {
799 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
800 if (kIsDebugBuild) {
801 AllNodesIterator iter(this);
802 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
803 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
804 }
805 }
806
807 DCHECK(temp_scoped_alloc_.get() == nullptr);
808 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
809 temp_bit_vector_size_ = GetNumSSARegs();
810 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
811 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
812 }
813}
814
buzbee1da1e2f2013-11-15 13:37:01 -0800815/*
816 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
817 * an iterative walk go ahead and perform type and size inference.
818 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800819bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800820 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800821 bool infer_changed = false;
822 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800823
Vladimir Markobfea9c22014-01-17 17:49:33 +0000824 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800825 if (do_nce) {
826 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +0100827 * Set initial state. Catch blocks don't need any special treatment.
buzbee1da1e2f2013-11-15 13:37:01 -0800828 */
Vladimir Marko0a810d22014-07-11 14:44:36 +0100829 if (bb->block_type == kEntryBlock) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000830 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800831 // Assume all ins are objects.
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700832 for (uint16_t in_reg = GetFirstInVR();
833 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000834 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800835 }
836 if ((cu_->access_flags & kAccStatic) == 0) {
837 // If non-static method, mark "this" as non-null
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700838 int this_reg = GetFirstInVR();
Vladimir Markobfea9c22014-01-17 17:49:33 +0000839 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800840 }
841 } else if (bb->predecessors->Size() == 1) {
842 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
Vladimir Markobfea9c22014-01-17 17:49:33 +0000843 // pred_bb must have already been processed at least once.
844 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
845 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800846 if (pred_bb->block_type == kDalvikByteCode) {
847 // Check to see if predecessor had an explicit null-check.
848 MIR* last_insn = pred_bb->last_mir_insn;
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -0700849 if (last_insn != nullptr) {
850 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
851 if (last_opcode == Instruction::IF_EQZ) {
852 if (pred_bb->fall_through == bb->id) {
853 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
854 // it can't be null.
855 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
856 }
857 } else if (last_opcode == Instruction::IF_NEZ) {
858 if (pred_bb->taken == bb->id) {
859 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
860 // null.
861 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
862 }
buzbee1da1e2f2013-11-15 13:37:01 -0800863 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700864 }
865 }
buzbee1da1e2f2013-11-15 13:37:01 -0800866 } else {
867 // Starting state is union of all incoming arcs
868 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
869 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
Vladimir Markobfea9c22014-01-17 17:49:33 +0000870 CHECK(pred_bb != NULL);
871 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
872 pred_bb = GetBasicBlock(iter.Next());
873 // At least one predecessor must have been processed before this bb.
874 DCHECK(pred_bb != nullptr);
875 DCHECK(pred_bb->data_flow_info != nullptr);
876 }
877 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800878 while (true) {
879 pred_bb = GetBasicBlock(iter.Next());
880 if (!pred_bb) break;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000881 DCHECK(pred_bb->data_flow_info != nullptr);
882 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800883 continue;
884 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000885 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
buzbee311ca162013-02-28 15:56:43 -0800886 }
buzbee311ca162013-02-28 15:56:43 -0800887 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000888 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800889 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800890 }
891
892 // Walk through the instruction in the block, updating as necessary
893 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
894 if (mir->ssa_rep == NULL) {
895 continue;
896 }
buzbee1da1e2f2013-11-15 13:37:01 -0800897
898 // Propagate type info.
899 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
900 if (!do_nce) {
901 continue;
902 }
903
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700904 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800905
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000906 // Might need a null check?
907 if (df_attributes & DF_HAS_NULL_CHKS) {
908 int src_idx;
909 if (df_attributes & DF_NULL_CHK_1) {
910 src_idx = 1;
911 } else if (df_attributes & DF_NULL_CHK_2) {
912 src_idx = 2;
913 } else {
914 src_idx = 0;
915 }
916 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000917 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000918 // Eliminate the null check.
919 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
920 } else {
921 // Do the null check.
922 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
923 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000924 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000925 }
926 }
927
928 if ((df_attributes & DF_A_WIDE) ||
929 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
930 continue;
931 }
932
933 /*
934 * First, mark all object definitions as requiring null check.
935 * Note: we can't tell if a CONST definition might be used as an object, so treat
936 * them all as object definitions.
937 */
938 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
939 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000940 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700941 }
942
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000943 // Now, remove mark from all object definitions we know are non-null.
944 if (df_attributes & DF_NON_NULL_DST) {
945 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000946 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000947 }
948
buzbee311ca162013-02-28 15:56:43 -0800949 // Mark non-null returns from invoke-style NEW*
950 if (df_attributes & DF_NON_NULL_RET) {
951 MIR* next_mir = mir->next;
952 // Next should be an MOVE_RESULT_OBJECT
953 if (next_mir &&
954 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
955 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000956 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800957 } else {
958 if (next_mir) {
959 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700960 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800961 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700962 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800963 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
964 tmir =tmir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700965 if (MIR::DecodedInstruction::IsPseudoMirOp(tmir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800966 continue;
967 }
968 // First non-pseudo should be MOVE_RESULT_OBJECT
969 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
970 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000971 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800972 } else {
973 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
974 }
975 break;
976 }
977 }
978 }
979 }
980
981 /*
982 * Propagate nullcheck state on register copies (including
983 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000984 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -0800985 */
986 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
987 int tgt_sreg = mir->ssa_rep->defs[0];
988 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
989 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000990 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -0800991 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000992 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -0800993 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000994 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000995 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000996 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000997 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -0800998 }
999 }
buzbee311ca162013-02-28 15:56:43 -08001000 }
1001
1002 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001003 bool nce_changed = false;
1004 if (do_nce) {
1005 if (bb->data_flow_info->ending_check_v == nullptr) {
1006 DCHECK(temp_scoped_alloc_.get() != nullptr);
1007 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1008 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
1009 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
1010 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -07001011 } else if (!ssa_regs_to_check->SameBitsSet(bb->data_flow_info->ending_check_v)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001012 nce_changed = true;
1013 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
1014 }
buzbee311ca162013-02-28 15:56:43 -08001015 }
buzbee1da1e2f2013-11-15 13:37:01 -08001016 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001017}
1018
Vladimir Markobfea9c22014-01-17 17:49:33 +00001019void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
1020 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
1021 // Clean up temporaries.
1022 temp_bit_vector_size_ = 0u;
1023 temp_bit_vector_ = nullptr;
1024 AllNodesIterator iter(this);
1025 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1026 if (bb->data_flow_info != nullptr) {
1027 bb->data_flow_info->ending_check_v = nullptr;
1028 }
1029 }
1030 DCHECK(temp_scoped_alloc_.get() != nullptr);
1031 temp_scoped_alloc_.reset();
1032 }
1033}
1034
1035bool MIRGraph::EliminateClassInitChecksGate() {
1036 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
1037 !cu_->mir_graph->HasStaticFieldAccess()) {
1038 return false;
1039 }
1040
1041 if (kIsDebugBuild) {
1042 AllNodesIterator iter(this);
1043 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1044 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
1045 }
1046 }
1047
1048 DCHECK(temp_scoped_alloc_.get() == nullptr);
1049 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1050
1051 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
1052 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
1053 temp_insn_data_ = static_cast<uint16_t*>(
1054 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1055
1056 uint32_t unique_class_count = 0u;
1057 {
1058 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1059 // ScopedArenaAllocator.
1060
1061 // Embed the map value in the entry to save space.
1062 struct MapEntry {
1063 // Map key: the class identified by the declaring dex file and type index.
1064 const DexFile* declaring_dex_file;
1065 uint16_t declaring_class_idx;
1066 // Map value: index into bit vectors of classes requiring initialization checks.
1067 uint16_t index;
1068 };
1069 struct MapEntryComparator {
1070 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1071 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1072 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1073 }
1074 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1075 }
1076 };
1077
Vladimir Markobfea9c22014-01-17 17:49:33 +00001078 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001079 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1080 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001081
1082 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1083 AllNodesIterator iter(this);
1084 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1085 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1086 DCHECK(bb->data_flow_info != nullptr);
1087 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1088 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1089 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
1090 uint16_t index = 0xffffu;
Vladimir Markof418f322014-07-09 14:45:36 +01001091 if (!field_info.IsInitialized()) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001092 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1093 MapEntry entry = {
Vladimir Markof418f322014-07-09 14:45:36 +01001094 // Treat unresolved fields as if each had its own class.
1095 field_info.IsResolved() ? field_info.DeclaringDexFile()
1096 : nullptr,
1097 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1098 : field_info.FieldIndex(),
Vladimir Markobfea9c22014-01-17 17:49:33 +00001099 static_cast<uint16_t>(class_to_index_map.size())
1100 };
1101 index = class_to_index_map.insert(entry).first->index;
1102 }
1103 // Using offset/2 for index into temp_insn_data_.
1104 temp_insn_data_[mir->offset / 2u] = index;
1105 }
1106 }
1107 }
1108 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1109 }
1110
1111 if (unique_class_count == 0u) {
1112 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1113 temp_insn_data_ = nullptr;
1114 temp_scoped_alloc_.reset();
1115 return false;
1116 }
1117
1118 temp_bit_vector_size_ = unique_class_count;
1119 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1120 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1121 DCHECK_GT(temp_bit_vector_size_, 0u);
1122 return true;
1123}
1124
1125/*
1126 * Eliminate unnecessary class initialization checks for a basic block.
1127 */
1128bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1129 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1130 if (bb->data_flow_info == NULL) {
1131 return false;
1132 }
1133
1134 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001135 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001136 */
1137 ArenaBitVector* classes_to_check = temp_bit_vector_;
1138 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001139 if (bb->block_type == kEntryBlock) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001140 classes_to_check->SetInitialBits(temp_bit_vector_size_);
1141 } else if (bb->predecessors->Size() == 1) {
1142 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
1143 // pred_bb must have already been processed at least once.
1144 DCHECK(pred_bb != nullptr);
1145 DCHECK(pred_bb->data_flow_info != nullptr);
1146 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1147 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1148 } else {
1149 // Starting state is union of all incoming arcs
1150 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
1151 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
1152 DCHECK(pred_bb != NULL);
1153 DCHECK(pred_bb->data_flow_info != NULL);
1154 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
1155 pred_bb = GetBasicBlock(iter.Next());
1156 // At least one predecessor must have been processed before this bb.
1157 DCHECK(pred_bb != nullptr);
1158 DCHECK(pred_bb->data_flow_info != nullptr);
1159 }
1160 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1161 while (true) {
1162 pred_bb = GetBasicBlock(iter.Next());
1163 if (!pred_bb) break;
1164 DCHECK(pred_bb->data_flow_info != nullptr);
1165 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1166 continue;
1167 }
1168 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1169 }
1170 }
1171 // At this point, classes_to_check shows which classes need clinit checks.
1172
1173 // Walk through the instruction in the block, updating as necessary
1174 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1175 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1176 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1177 uint16_t index = temp_insn_data_[mir->offset / 2u];
1178 if (index != 0xffffu) {
1179 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1180 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1181 if (!classes_to_check->IsBitSet(index)) {
1182 // Eliminate the class init check.
1183 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1184 } else {
1185 // Do the class init check.
1186 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1187 }
1188 }
1189 // Mark the class as initialized.
1190 classes_to_check->ClearBit(index);
1191 }
1192 }
1193 }
1194
1195 // Did anything change?
1196 bool changed = false;
1197 if (bb->data_flow_info->ending_check_v == nullptr) {
1198 DCHECK(temp_scoped_alloc_.get() != nullptr);
1199 DCHECK(bb->data_flow_info != nullptr);
1200 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1201 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1202 changed = classes_to_check->GetHighestBitSet() != -1;
1203 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1204 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1205 changed = true;
1206 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1207 }
1208 return changed;
1209}
1210
1211void MIRGraph::EliminateClassInitChecksEnd() {
1212 // Clean up temporaries.
1213 temp_bit_vector_size_ = 0u;
1214 temp_bit_vector_ = nullptr;
1215 AllNodesIterator iter(this);
1216 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1217 if (bb->data_flow_info != nullptr) {
1218 bb->data_flow_info->ending_check_v = nullptr;
1219 }
1220 }
1221
1222 DCHECK(temp_insn_data_ != nullptr);
1223 temp_insn_data_ = nullptr;
1224 DCHECK(temp_scoped_alloc_.get() != nullptr);
1225 temp_scoped_alloc_.reset();
1226}
1227
Vladimir Marko95a05972014-05-30 10:01:32 +01001228bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko55fff042014-07-10 12:42:52 +01001229 if ((cu_->disable_opt & (1u << kGlobalValueNumbering)) != 0u) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001230 return false;
1231 }
1232
1233 DCHECK(temp_scoped_alloc_ == nullptr);
1234 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1235 DCHECK(temp_gvn_ == nullptr);
1236 temp_gvn_.reset(
1237 new (temp_scoped_alloc_.get()) GlobalValueNumbering(cu_, temp_scoped_alloc_.get()));
1238 return true;
1239}
1240
1241bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
1242 DCHECK(temp_gvn_ != nullptr);
1243 LocalValueNumbering* lvn = temp_gvn_->PrepareBasicBlock(bb);
1244 if (lvn != nullptr) {
1245 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1246 lvn->GetValueNumber(mir);
1247 }
1248 }
1249 bool change = (lvn != nullptr) && temp_gvn_->FinishBasicBlock(bb);
1250 return change;
1251}
1252
1253void MIRGraph::ApplyGlobalValueNumberingEnd() {
1254 // Perform modifications.
1255 if (temp_gvn_->Good()) {
1256 temp_gvn_->AllowModifications();
1257 PreOrderDfsIterator iter(this);
1258 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Markob19955d2014-07-29 12:04:10 +01001259 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
1260 LocalValueNumbering* lvn = temp_gvn_->PrepareBasicBlock(bb, &allocator);
Vladimir Marko95a05972014-05-30 10:01:32 +01001261 if (lvn != nullptr) {
1262 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1263 lvn->GetValueNumber(mir);
1264 }
1265 bool change = temp_gvn_->FinishBasicBlock(bb);
Vladimir Marko55fff042014-07-10 12:42:52 +01001266 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001267 }
1268 }
1269 } else {
1270 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1271 }
1272
1273 DCHECK(temp_gvn_ != nullptr);
1274 temp_gvn_.reset();
1275 DCHECK(temp_scoped_alloc_ != nullptr);
1276 temp_scoped_alloc_.reset();
1277}
1278
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001279void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1280 uint32_t method_index = invoke->meta.method_lowering_info;
1281 if (temp_bit_vector_->IsBitSet(method_index)) {
1282 iget_or_iput->meta.ifield_lowering_info = temp_insn_data_[method_index];
1283 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1284 return;
1285 }
1286
1287 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1288 MethodReference target = method_info.GetTargetMethod();
1289 DexCompilationUnit inlined_unit(
1290 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1291 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1292 0u /* access_flags not used */, nullptr /* verified_method not used */);
1293 MirIFieldLoweringInfo inlined_field_info(field_idx);
1294 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1295 DCHECK(inlined_field_info.IsResolved());
1296
1297 uint32_t field_info_index = ifield_lowering_infos_.Size();
1298 ifield_lowering_infos_.Insert(inlined_field_info);
1299 temp_bit_vector_->SetBit(method_index);
1300 temp_insn_data_[method_index] = field_info_index;
1301 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1302}
1303
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001304bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001305 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
1306 method_lowering_infos_.Size() == 0u) {
1307 return false;
1308 }
1309 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1310 // This isn't the Quick compiler.
1311 return false;
1312 }
1313 return true;
1314}
1315
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001316void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001317 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1318 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1319
1320 DCHECK(temp_scoped_alloc_.get() == nullptr);
1321 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1322 temp_bit_vector_size_ = method_lowering_infos_.Size();
1323 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1324 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapMisc);
1325 temp_bit_vector_->ClearAllBits();
1326 temp_insn_data_ = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1327 temp_bit_vector_size_ * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1328}
1329
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001330void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001331 if (bb->block_type != kDalvikByteCode) {
1332 return;
1333 }
1334 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001335 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001336 continue;
1337 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001338 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001339 continue;
1340 }
1341 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1342 if (!method_info.FastPath()) {
1343 continue;
1344 }
1345 InvokeType sharp_type = method_info.GetSharpType();
1346 if ((sharp_type != kDirect) &&
1347 (sharp_type != kStatic || method_info.NeedsClassInitialization())) {
1348 continue;
1349 }
1350 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1351 MethodReference target = method_info.GetTargetMethod();
1352 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1353 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001354 if (cu_->verbose || cu_->print_pass) {
1355 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1356 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1357 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1358 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001359 }
1360 }
1361 }
1362}
1363
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001364void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001365 DCHECK(temp_insn_data_ != nullptr);
1366 temp_insn_data_ = nullptr;
1367 DCHECK(temp_bit_vector_ != nullptr);
1368 temp_bit_vector_ = nullptr;
1369 DCHECK(temp_scoped_alloc_.get() != nullptr);
1370 temp_scoped_alloc_.reset();
1371}
1372
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001373void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001374 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001375 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001376 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001377 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001378 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1379 CountChecks(bb);
1380 }
1381 if (stats->null_checks > 0) {
1382 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1383 float checks = static_cast<float>(stats->null_checks);
1384 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1385 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1386 << (eliminated/checks) * 100.0 << "%";
1387 }
1388 if (stats->range_checks > 0) {
1389 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1390 float checks = static_cast<float>(stats->range_checks);
1391 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1392 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1393 << (eliminated/checks) * 100.0 << "%";
1394 }
1395}
1396
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001397bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001398 if (bb->visited) return false;
1399 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1400 || (bb->block_type == kExitBlock))) {
1401 // Ignore special blocks
1402 bb->visited = true;
1403 return false;
1404 }
1405 // Must be head of extended basic block.
1406 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001407 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001408 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001409 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001410 // Visit blocks strictly dominated by this head.
1411 while (bb != NULL) {
1412 bb->visited = true;
1413 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001414 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001415 bb = NextDominatedBlock(bb);
1416 }
buzbee1da1e2f2013-11-15 13:37:01 -08001417 if (terminated_by_return || do_local_value_numbering) {
1418 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001419 bb = start_bb;
1420 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001421 bb->use_lvn = do_local_value_numbering;
1422 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001423 bb = NextDominatedBlock(bb);
1424 }
1425 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001426 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001427}
1428
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001429void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001430 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1431 ClearAllVisitedFlags();
1432 PreOrderDfsIterator iter2(this);
1433 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1434 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001435 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001436 // Perform extended basic block optimizations.
1437 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1438 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1439 }
1440 } else {
1441 PreOrderDfsIterator iter(this);
1442 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1443 BasicBlockOpt(bb);
1444 }
buzbee311ca162013-02-28 15:56:43 -08001445 }
1446}
1447
1448} // namespace art