blob: 2444e43d64fb6c9da99416c53f9fb74c9f65f7dc [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010024#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070026#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000027#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070028#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010030#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "driver/dex_compilation_unit.h"
32#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010033#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000034#include "jit/jit.h"
35#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "mirror/class_loader.h"
37#include "mirror/dex_cache.h"
38#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010039#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010040#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070041#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070042#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010043#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000044#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "thread.h"
47
48namespace art {
49
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000050// Instruction limit to control memory.
51static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
52
53// Maximum number of instructions for considering a method small,
54// which we will always try to inline if the other non-instruction limits
55// are not reached.
56static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000057
58// Limit the number of dex registers that we accumulate while inlining
59// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010060static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000062// Limit recursive call inlining, which do not benefit from too
63// much inlining compared to code locality.
64static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070065
Calin Juravlee2492d42017-03-20 11:42:13 -070066// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070067static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070068
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000069// We check for line numbers to make sure the DepthString implementation
70// aligns the output nicely.
71#define LOG_INTERNAL(msg) \
72 static_assert(__LINE__ > 10, "Unhandled line number"); \
73 static_assert(__LINE__ < 10000, "Unhandled line number"); \
74 VLOG(compiler) << DepthString(__LINE__) << msg
75
76#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
77#define LOG_NOTE() LOG_INTERNAL("Note: ")
78#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070079#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000080#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
81
82std::string HInliner::DepthString(int line) const {
83 std::string value;
84 // Indent according to the inlining depth.
85 size_t count = depth_;
86 // Line numbers get printed in the log, so add a space if the log's line is less
87 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
88 if (!kIsTargetBuild) {
89 if (line < 100) {
90 value += " ";
91 }
92 if (line < 1000) {
93 value += " ";
94 }
95 // Safeguard if this file reaches more than 10000 lines.
96 DCHECK_LT(line, 10000);
97 }
98 for (size_t i = 0; i < count; ++i) {
99 value += " ";
100 }
101 return value;
102}
103
104static size_t CountNumberOfInstructions(HGraph* graph) {
105 size_t number_of_instructions = 0;
106 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
107 for (HInstructionIterator instr_it(block->GetInstructions());
108 !instr_it.Done();
109 instr_it.Advance()) {
110 ++number_of_instructions;
111 }
112 }
113 return number_of_instructions;
114}
115
116void HInliner::UpdateInliningBudget() {
117 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
118 // Always try to inline small methods.
119 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
120 } else {
121 inlining_budget_ = std::max(
122 kMaximumNumberOfInstructionsForSmallMethod,
123 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
124 }
125}
126
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000127void HInliner::Run() {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000128 if (graph_->IsDebuggable()) {
129 // For simplicity, we currently never inline when the graph is debuggable. This avoids
130 // doing some logic in the runtime to discover if a method could have been inlined.
131 return;
132 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000133
134 // Initialize the number of instructions for the method being compiled. Recursive calls
135 // to HInliner::Run have already updated the instruction count.
136 if (outermost_graph_ == graph_) {
137 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
138 }
139
140 UpdateInliningBudget();
141 DCHECK_NE(total_number_of_instructions_, 0u);
142 DCHECK_NE(inlining_budget_, 0u);
143
Roland Levillain6c3af162017-04-27 11:18:56 +0100144 // If we're compiling with a core image (which is only used for
145 // test purposes), honor inlining directives in method names:
146 // - if a method's name contains the substring "$inline$", ensure
147 // that this method is actually inlined;
148 // - if a method's name contains the substring "$noinline$", do not
149 // inline that method.
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100150 // We limit this to AOT compilation, as the JIT may or may not inline
151 // depending on the state of classes at runtime.
152 const bool honor_inlining_directives =
153 IsCompilingWithCoreImage() && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100154
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000155 // Keep a copy of all blocks when starting the visit.
156 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100157 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000158 // Because we are changing the graph when inlining,
159 // we just iterate over the blocks of the outer method.
160 // This avoids doing the inlining work again on the inlined blocks.
161 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000162 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
163 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100164 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700165 // As long as the call is not intrinsified, it is worth trying to inline.
166 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Roland Levillain6c3af162017-04-27 11:18:56 +0100167 if (honor_inlining_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000168 // Debugging case: directives in method names control or assert on inlining.
169 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
170 call->GetDexMethodIndex(), /* with_signature */ false);
171 // Tests prevent inlining by having $noinline$ in their method names.
172 if (callee_name.find("$noinline$") == std::string::npos) {
173 if (!TryInline(call)) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000174 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
175 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000176 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000177 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100178 } else {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000179 // Normal case: try to inline.
180 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000181 }
182 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000183 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000184 }
185 }
186}
187
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100188static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700189 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100190 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
191}
192
193/**
194 * Given the `resolved_method` looked up in the dex cache, try to find
195 * the actual runtime target of an interface or virtual call.
196 * Return nullptr if the runtime target cannot be proven.
197 */
198static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700199 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100200 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
201 // No need to lookup further, the resolved method will be the target.
202 return resolved_method;
203 }
204
205 HInstruction* receiver = invoke->InputAt(0);
206 if (receiver->IsNullCheck()) {
207 // Due to multiple levels of inlining within the same pass, it might be that
208 // null check does not have the reference type of the actual receiver.
209 receiver = receiver->InputAt(0);
210 }
211 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000212 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
213 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100214 // We currently only support inlining with known receivers.
215 // TODO: Remove this check, we should be able to inline final methods
216 // on unknown receivers.
217 return nullptr;
218 } else if (info.GetTypeHandle()->IsInterface()) {
219 // Statically knowing that the receiver has an interface type cannot
220 // help us find what is the target method.
221 return nullptr;
222 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
223 // The method that we're trying to call is not in the receiver's class or super classes.
224 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000225 } else if (info.GetTypeHandle()->IsErroneous()) {
226 // If the type is erroneous, do not go further, as we are going to query the vtable or
227 // imt table, that we can only safely do on non-erroneous classes.
228 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 }
230
231 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700232 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100233 if (invoke->IsInvokeInterface()) {
234 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
235 resolved_method, pointer_size);
236 } else {
237 DCHECK(invoke->IsInvokeVirtual());
238 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
239 resolved_method, pointer_size);
240 }
241
242 if (resolved_method == nullptr) {
243 // The information we had on the receiver was not enough to find
244 // the target method. Since we check above the exact type of the receiver,
245 // the only reason this can happen is an IncompatibleClassChangeError.
246 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700247 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100248 // The information we had on the receiver was not enough to find
249 // the target method. Since we check above the exact type of the receiver,
250 // the only reason this can happen is an IncompatibleClassChangeError.
251 return nullptr;
252 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
253 // A final method has to be the target method.
254 return resolved_method;
255 } else if (info.IsExact()) {
256 // If we found a method and the receiver's concrete type is statically
257 // known, we know for sure the target.
258 return resolved_method;
259 } else {
260 // Even if we did find a method, the receiver type was not enough to
261 // statically find the runtime target.
262 return nullptr;
263 }
264}
265
266static uint32_t FindMethodIndexIn(ArtMethod* method,
267 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000268 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700269 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100270 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100271 return method->GetDexMethodIndex();
272 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000273 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100274 }
275}
276
Andreas Gampea5b09a62016-11-17 15:21:22 -0800277static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000278 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700279 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000280 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800281 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100282 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700283 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000284 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800285 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700286 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100287 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100288 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000289 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000290 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100291 } else {
292 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100294 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 // the right class already resolved with the class loader.
296 if (index.IsValid()) {
297 ObjPtr<mirror::Class> resolved = ClassLinker::LookupResolvedType(
298 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
299 if (resolved != cls) {
300 index = dex::TypeIndex::Invalid();
301 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100302 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100303 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000304
305 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100306}
307
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000308class ScopedProfilingInfoInlineUse {
309 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000310 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
311 : method_(method),
312 self_(self),
313 // Fetch the profiling info ahead of using it. If it's null when fetching,
314 // we should not call JitCodeCache::DoneInlining.
315 profiling_info_(
316 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000317 }
318
319 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000320 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700321 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000322 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
323 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
324 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000325 }
326
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000327 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
328
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000329 private:
330 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000331 Thread* const self_;
332 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000333};
334
Calin Juravle13439f02017-02-21 01:17:21 -0800335HInliner::InlineCacheType HInliner::GetInlineCacheType(
336 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
337 REQUIRES_SHARED(Locks::mutator_lock_) {
338 uint8_t number_of_types = 0;
339 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
340 if (classes->Get(number_of_types) == nullptr) {
341 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000342 }
343 }
Calin Juravle13439f02017-02-21 01:17:21 -0800344
345 if (number_of_types == 0) {
346 return kInlineCacheUninitialized;
347 } else if (number_of_types == 1) {
348 return kInlineCacheMonomorphic;
349 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
350 return kInlineCacheMegamorphic;
351 } else {
352 return kInlineCachePolymorphic;
353 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000354}
355
356static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
357 REQUIRES_SHARED(Locks::mutator_lock_) {
358 DCHECK(classes->Get(0) != nullptr);
359 return classes->Get(0);
360}
361
Mingyao Yang063fc772016-08-02 11:02:54 -0700362ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
363 if (!resolved_method->HasSingleImplementation()) {
364 return nullptr;
365 }
366 if (Runtime::Current()->IsAotCompiler()) {
367 // No CHA-based devirtulization for AOT compiler (yet).
368 return nullptr;
369 }
370 if (outermost_graph_->IsCompilingOsr()) {
371 // We do not support HDeoptimize in OSR methods.
372 return nullptr;
373 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800374 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000375 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
376 if (single_impl == nullptr) {
377 return nullptr;
378 }
379 if (single_impl->IsProxyMethod()) {
380 // Proxy method is a generic invoker that's not worth
381 // devirtualizing/inlining. It also causes issues when the proxy
382 // method is in another dex file if we try to rewrite invoke-interface to
383 // invoke-virtual because a proxy method doesn't have a real dex file.
384 return nullptr;
385 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100386 if (!single_impl->GetDeclaringClass()->IsResolved()) {
387 // There's a race with the class loading, which updates the CHA info
388 // before setting the class to resolved. So we just bail for this
389 // rare occurence.
390 return nullptr;
391 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000392 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700393}
394
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700395bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000396 if (invoke_instruction->IsInvokeUnresolved() ||
397 invoke_instruction->IsInvokePolymorphic()) {
398 return false; // Don't bother to move further if we know the method is unresolved or an
399 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100400 }
401
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000402 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100403 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000404 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000405 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000406
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100407 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100408 if (resolved_method == nullptr) {
409 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
410 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000411 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100412 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000413 }
414 ArtMethod* actual_method = nullptr;
415
416 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800417 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000418 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100419 // Check if we can statically find the method.
420 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000421 }
422
Mingyao Yang063fc772016-08-02 11:02:54 -0700423 bool cha_devirtualize = false;
424 if (actual_method == nullptr) {
425 ArtMethod* method = TryCHADevirtualization(resolved_method);
426 if (method != nullptr) {
427 cha_devirtualize = true;
428 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000429 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700430 }
431 }
432
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100433 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700434 bool result = TryInlineAndReplace(invoke_instruction,
435 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000436 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700437 /* do_rtp */ true,
438 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000439 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700440 if (cha_devirtualize) {
441 // Add dependency due to devirtulization. We've assumed resolved_method
442 // has single implementation.
443 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000444 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
Mingyao Yang063fc772016-08-02 11:02:54 -0700445 } else {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000446 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
Mingyao Yang063fc772016-08-02 11:02:54 -0700447 }
Calin Juravle69158982016-03-16 11:53:41 +0000448 }
449 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100450 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800451 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100452
Calin Juravle13439f02017-02-21 01:17:21 -0800453 // Try using inline caches.
454 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
455}
456
457static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
458 const DexCompilationUnit& compilation_unit,
459 StackHandleScope<1>* hs)
460 REQUIRES_SHARED(Locks::mutator_lock_) {
461 Thread* self = Thread::Current();
462 ClassLinker* class_linker = compilation_unit.GetClassLinker();
463 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
464 mirror::ObjectArray<mirror::Class>::Alloc(
465 self,
466 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
467 InlineCache::kIndividualCacheSize));
468 if (inline_cache == nullptr) {
469 // We got an OOME. Just clear the exception, and don't inline.
470 DCHECK(self->IsExceptionPending());
471 self->ClearException();
472 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
473 }
474 return inline_cache;
475}
476
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700477bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
478 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
479 // do not generate a deopt.
480 //
481 // For AOT:
482 // Generating a deopt does not ensure that we will actually capture the new types;
483 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
484 // Take for example the following scenario:
485 // - we capture the inline cache in one run
486 // - the next run, we deoptimize because we miss a type check, but the method
487 // never becomes hot again
488 // In this case, the inline cache will not be updated in the profile and the AOT code
489 // will keep deoptimizing.
490 // Another scenario is if we use profile compilation for a process which is not allowed
491 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
492 // rest of the lifetime.
493 // TODO(calin):
494 // This is a compromise because we will most likely never update the inline cache
495 // in the profile (unless there's another reason to deopt). So we might be stuck with
496 // a sub-optimal inline cache.
497 // We could be smarter when capturing inline caches to mitigate this.
498 // (e.g. by having different thresholds for new and old methods).
499 //
500 // For OSR:
501 // We may come from the interpreter and it may have seen different receiver types.
502 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
503}
Calin Juravle13439f02017-02-21 01:17:21 -0800504bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
505 HInvoke* invoke_instruction,
506 ArtMethod* resolved_method)
507 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700508 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
509 return false;
510 }
511
Calin Juravle13439f02017-02-21 01:17:21 -0800512 StackHandleScope<1> hs(Thread::Current());
513 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
514 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
515 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
516 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
517
518 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000519 case kInlineCacheNoData: {
520 LOG_FAIL_NO_STAT()
521 << "Interface or virtual call to "
522 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
523 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800524 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000525 }
Calin Juravle13439f02017-02-21 01:17:21 -0800526
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000527 case kInlineCacheUninitialized: {
528 LOG_FAIL_NO_STAT()
529 << "Interface or virtual call to "
530 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
531 << " is not hit and not inlined";
532 return false;
533 }
534
535 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000536 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700537 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800538 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000539 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800540 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000541 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000542 }
Calin Juravle13439f02017-02-21 01:17:21 -0800543
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000544 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000545 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800546 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000547 }
Calin Juravle13439f02017-02-21 01:17:21 -0800548
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000549 case kInlineCacheMegamorphic: {
550 LOG_FAIL_NO_STAT()
551 << "Interface or virtual call to "
552 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
553 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000554 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800555 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000556 }
Calin Juravle13439f02017-02-21 01:17:21 -0800557
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000558 case kInlineCacheMissingTypes: {
559 LOG_FAIL_NO_STAT()
560 << "Interface or virtual call to "
561 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
562 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800563 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000564 }
Calin Juravle13439f02017-02-21 01:17:21 -0800565 }
566 UNREACHABLE();
567}
568
569HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
570 HInvoke* invoke_instruction,
571 StackHandleScope<1>* hs,
572 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
573 REQUIRES_SHARED(Locks::mutator_lock_) {
574 DCHECK(Runtime::Current()->UseJitCompilation());
575
576 ArtMethod* caller = graph_->GetArtMethod();
577 // Under JIT, we should always know the caller.
578 DCHECK(caller != nullptr);
579 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
580 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
581
582 if (profiling_info == nullptr) {
583 return kInlineCacheNoData;
584 }
585
586 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
587 if (inline_cache->Get() == nullptr) {
588 // We can't extract any data if we failed to allocate;
589 return kInlineCacheNoData;
590 } else {
591 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
592 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
593 *inline_cache);
594 return GetInlineCacheType(*inline_cache);
595 }
596}
597
598HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
599 const DexFile& caller_dex_file,
600 HInvoke* invoke_instruction,
601 StackHandleScope<1>* hs,
602 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
603 REQUIRES_SHARED(Locks::mutator_lock_) {
604 DCHECK(Runtime::Current()->IsAotCompiler());
605 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
606 if (pci == nullptr) {
607 return kInlineCacheNoData;
608 }
609
Calin Juravlecc3171a2017-05-19 16:47:53 -0700610 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
611 pci->GetMethod(caller_dex_file.GetLocation(),
612 caller_dex_file.GetLocationChecksum(),
613 caller_compilation_unit_.GetDexMethodIndex());
614 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800615 return kInlineCacheNoData; // no profile information for this invocation.
616 }
617
618 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
619 if (inline_cache == nullptr) {
620 // We can't extract any data if we failed to allocate;
621 return kInlineCacheNoData;
622 } else {
623 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700624 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800625 *inline_cache);
626 }
627}
628
629HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
630 const HInvoke* invoke_instruction,
631 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
632 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
633 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700634 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
635 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800636 return kInlineCacheUninitialized;
637 }
638
639 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
640
641 if (dex_pc_data.is_missing_types) {
642 return kInlineCacheMissingTypes;
643 }
644 if (dex_pc_data.is_megamorphic) {
645 return kInlineCacheMegamorphic;
646 }
647
648 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
649 Thread* self = Thread::Current();
650 // We need to resolve the class relative to the containing dex file.
651 // So first, build a mapping from the index of dex file in the profile to
652 // its dex cache. This will avoid repeating the lookup when walking over
653 // the inline cache types.
654 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
655 offline_profile.dex_references.size());
656 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
657 bool found = false;
658 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
659 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
660 dex_profile_index_to_dex_cache[i] =
661 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
662 found = true;
663 }
664 }
665 if (!found) {
666 VLOG(compiler) << "Could not find profiled dex file: "
667 << offline_profile.dex_references[i].dex_location;
668 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100669 }
670 }
671
Calin Juravle13439f02017-02-21 01:17:21 -0800672 // Walk over the classes and resolve them. If we cannot find a type we return
673 // kInlineCacheMissingTypes.
674 int ic_index = 0;
675 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
676 ObjPtr<mirror::DexCache> dex_cache =
677 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
678 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700679
680 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
681 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
682 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
683 return kInlineCacheNoData;
684 }
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000685 ObjPtr<mirror::Class> clazz = ClassLinker::LookupResolvedType(
686 class_ref.type_index,
687 dex_cache,
688 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800689 if (clazz != nullptr) {
690 inline_cache->Set(ic_index++, clazz);
691 } else {
692 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
693 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
694 invoke_instruction->GetDexMethodIndex()) << " : "
695 << caller_compilation_unit_
696 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
697 return kInlineCacheMissingTypes;
698 }
699 }
700 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100701}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000702
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000703HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
704 HInstruction* receiver,
705 uint32_t dex_pc) const {
706 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
707 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100708 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000709 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000710 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100711 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000712 field->GetOffset(),
713 field->IsVolatile(),
714 field->GetDexFieldIndex(),
715 field->GetDeclaringClass()->GetDexClassDefIndex(),
716 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000717 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000718 // The class of a field is effectively final, and does not have any memory dependencies.
719 result->SetSideEffects(SideEffects::None());
720 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000721}
722
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000723static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
724 ArtMethod* resolved_method,
725 HInstruction* invoke_instruction,
726 PointerSize pointer_size)
727 REQUIRES_SHARED(Locks::mutator_lock_) {
728 if (Runtime::Current()->IsAotCompiler()) {
729 // We can get unrelated types when working with profiles (corruption,
730 // systme updates, or anyone can write to it). So first check if the class
731 // actually implements the declaring class of the method that is being
732 // called in bytecode.
733 // Note: the lookup methods used below require to have assignable types.
734 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
735 return nullptr;
736 }
737 }
738
739 if (invoke_instruction->IsInvokeInterface()) {
740 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
741 } else {
742 DCHECK(invoke_instruction->IsInvokeVirtual());
743 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
744 }
745 DCHECK(resolved_method != nullptr);
746 return resolved_method;
747}
748
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100749bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
750 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000751 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000752 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
753 << invoke_instruction->DebugName();
754
Andreas Gampea5b09a62016-11-17 15:21:22 -0800755 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000756 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800757 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000758 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000759 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
760 << " from inline cache is not inlined because its class is not"
761 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100762 return false;
763 }
764
765 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700766 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000767 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
768 resolved_method = ResolveMethodFromInlineCache(
769 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
770
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000771 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000772 if (resolved_method == nullptr) {
773 // Bogus AOT profile, bail.
774 DCHECK(Runtime::Current()->IsAotCompiler());
775 return false;
776 }
777
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100778 HInstruction* receiver = invoke_instruction->InputAt(0);
779 HInstruction* cursor = invoke_instruction->GetPrevious();
780 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700781 if (!TryInlineAndReplace(invoke_instruction,
782 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000783 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700784 /* do_rtp */ false,
785 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100786 return false;
787 }
788
789 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000790 AddTypeGuard(receiver,
791 cursor,
792 bb_cursor,
793 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000794 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000795 invoke_instruction,
796 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100797
798 // Run type propagation to get the guard typed, and eventually propagate the
799 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000800 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000801 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000802 outer_compilation_unit_.GetDexCache(),
803 handles_,
804 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100805 rtp_fixup.Run();
806
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000807 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100808 return true;
809}
810
Mingyao Yang063fc772016-08-02 11:02:54 -0700811void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
812 uint32_t dex_pc,
813 HInstruction* cursor,
814 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100815 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
816 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
817 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700818 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100819 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
820 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700821
822 if (cursor != nullptr) {
823 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
824 } else {
825 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
826 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800827 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
828 bb_cursor->InsertInstructionAfter(deopt, compare);
829
830 // Add receiver as input to aid CHA guard optimization later.
831 deopt_flag->AddInput(invoke_instruction->InputAt(0));
832 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700833 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800834 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700835}
836
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000837HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
838 HInstruction* cursor,
839 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800840 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000841 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000842 HInstruction* invoke_instruction,
843 bool with_deoptimization) {
844 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
845 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
846 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000847 if (cursor != nullptr) {
848 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
849 } else {
850 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
851 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000852
853 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700854 bool is_referrer;
855 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
856 if (outermost_art_method == nullptr) {
857 DCHECK(Runtime::Current()->IsAotCompiler());
858 // We are in AOT mode and we don't have an ART method to determine
859 // if the inlined method belongs to the referrer. Assume it doesn't.
860 is_referrer = false;
861 } else {
862 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
863 }
864
Nicolas Geoffray56876342016-12-16 16:09:08 +0000865 // Note that we will just compare the classes, so we don't need Java semantics access checks.
866 // Note that the type index and the dex file are relative to the method this type guard is
867 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100868 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
869 class_index,
870 caller_dex_file,
871 klass,
872 is_referrer,
873 invoke_instruction->GetDexPc(),
874 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000875 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000876 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
877 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
878 << "We should always be able to reference a class for inline caches";
879 // Insert before setting the kind, as setting the kind affects the inputs.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000880 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000881 load_class->SetLoadKind(kind);
Calin Juravle13439f02017-02-21 01:17:21 -0800882 // In AOT mode, we will most likely load the class from BSS, which will involve a call
883 // to the runtime. In this case, the load instruction will need an environment so copy
884 // it from the invoke instruction.
885 if (load_class->NeedsEnvironment()) {
886 DCHECK(Runtime::Current()->IsAotCompiler());
887 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
888 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000889
Vladimir Markoca6fff82017-10-03 14:49:14 +0100890 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000891 bb_cursor->InsertInstructionAfter(compare, load_class);
892 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100893 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
894 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000895 compare,
896 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100897 Runtime::Current()->IsAotCompiler()
898 ? DeoptimizationKind::kAotInlineCache
899 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000900 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000901 bb_cursor->InsertInstructionAfter(deoptimize, compare);
902 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000903 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
904 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
905 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000906 }
907 return compare;
908}
909
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000910bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100911 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000912 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000913 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
914 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000915
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000916 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000917 return true;
918 }
919
920 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700921 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000922
923 bool all_targets_inlined = true;
924 bool one_target_inlined = false;
925 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000926 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000927 break;
928 }
929 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000930
931 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000932 method = ResolveMethodFromInlineCache(
933 handle, resolved_method, invoke_instruction, pointer_size);
934 if (method == nullptr) {
935 DCHECK(Runtime::Current()->IsAotCompiler());
936 // AOT profile is bogus. This loop expects to iterate over all entries,
937 // so just just continue.
938 all_targets_inlined = false;
939 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000940 }
941
942 HInstruction* receiver = invoke_instruction->InputAt(0);
943 HInstruction* cursor = invoke_instruction->GetPrevious();
944 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
945
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000946 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000947 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000948 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800949 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000950 !TryBuildAndInline(invoke_instruction,
951 method,
952 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
953 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000954 all_targets_inlined = false;
955 } else {
956 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000957
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000958 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
959 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000960
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000961 // If we have inlined all targets before, and this receiver is the last seen,
962 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700963 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
964 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000965 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000966 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100967
Nicolas Geoffray56876342016-12-16 16:09:08 +0000968 HInstruction* compare = AddTypeGuard(receiver,
969 cursor,
970 bb_cursor,
971 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000972 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000973 invoke_instruction,
974 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000975 if (deoptimize) {
976 if (return_replacement != nullptr) {
977 invoke_instruction->ReplaceWith(return_replacement);
978 }
979 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
980 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000981 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000982 break;
983 } else {
984 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
985 }
986 }
987 }
988
989 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000990 LOG_FAIL_NO_STAT()
991 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
992 << " from inline cache is not inlined because none"
993 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000994 return false;
995 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000996
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000997 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000998
999 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001000 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001001 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001002 outer_compilation_unit_.GetDexCache(),
1003 handles_,
1004 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001005 rtp_fixup.Run();
1006 return true;
1007}
1008
1009void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1010 HInstruction* return_replacement,
1011 HInstruction* invoke_instruction) {
1012 uint32_t dex_pc = invoke_instruction->GetDexPc();
1013 HBasicBlock* cursor_block = compare->GetBlock();
1014 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001015 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001016
1017 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1018 // and the returned block is the start of the then branch (that could contain multiple blocks).
1019 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1020
1021 // Split the block containing the invoke before and after the invoke. The returned block
1022 // of the split before will contain the invoke and will be the otherwise branch of
1023 // the diamond. The returned block of the split after will be the merge block
1024 // of the diamond.
1025 HBasicBlock* end_then = invoke_instruction->GetBlock();
1026 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1027 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1028
1029 // If the methods we are inlining return a value, we create a phi in the merge block
1030 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1031 if (return_replacement != nullptr) {
1032 HPhi* phi = new (allocator) HPhi(
1033 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1034 merge->AddPhi(phi);
1035 invoke_instruction->ReplaceWith(phi);
1036 phi->AddInput(return_replacement);
1037 phi->AddInput(invoke_instruction);
1038 }
1039
1040 // Add the control flow instructions.
1041 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1042 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1043 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1044
1045 // Add the newly created blocks to the graph.
1046 graph_->AddBlock(then);
1047 graph_->AddBlock(otherwise);
1048 graph_->AddBlock(merge);
1049
1050 // Set up successor (and implictly predecessor) relations.
1051 cursor_block->AddSuccessor(otherwise);
1052 cursor_block->AddSuccessor(then);
1053 end_then->AddSuccessor(merge);
1054 otherwise->AddSuccessor(merge);
1055
1056 // Set up dominance information.
1057 then->SetDominator(cursor_block);
1058 cursor_block->AddDominatedBlock(then);
1059 otherwise->SetDominator(cursor_block);
1060 cursor_block->AddDominatedBlock(otherwise);
1061 merge->SetDominator(cursor_block);
1062 cursor_block->AddDominatedBlock(merge);
1063
1064 // Update the revert post order.
1065 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1066 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1067 graph_->reverse_post_order_[++index] = then;
1068 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1069 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1070 graph_->reverse_post_order_[++index] = otherwise;
1071 graph_->reverse_post_order_[++index] = merge;
1072
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001073
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001074 graph_->UpdateLoopAndTryInformationOfNewBlock(
1075 then, original_invoke_block, /* replace_if_back_edge */ false);
1076 graph_->UpdateLoopAndTryInformationOfNewBlock(
1077 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1078
1079 // In case the original invoke location was a back edge, we need to update
1080 // the loop to now have the merge block as a back edge.
1081 graph_->UpdateLoopAndTryInformationOfNewBlock(
1082 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001083}
1084
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001085bool HInliner::TryInlinePolymorphicCallToSameTarget(
1086 HInvoke* invoke_instruction,
1087 ArtMethod* resolved_method,
1088 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001089 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001090 if (!Runtime::Current()->UseJitCompilation()) {
1091 return false;
1092 }
1093
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001094 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001095 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001096
1097 DCHECK(resolved_method != nullptr);
1098 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001099 size_t method_index = invoke_instruction->IsInvokeVirtual()
1100 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1101 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1102
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001103 // Check whether we are actually calling the same method among
1104 // the different types seen.
1105 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001106 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001107 break;
1108 }
1109 ArtMethod* new_method = nullptr;
1110 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001111 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001112 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001113 if (new_method->IsRuntimeMethod()) {
1114 // Bail out as soon as we see a conflict trampoline in one of the target's
1115 // interface table.
1116 return false;
1117 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001118 } else {
1119 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001120 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001121 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001122 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001123 if (actual_method == nullptr) {
1124 actual_method = new_method;
1125 } else if (actual_method != new_method) {
1126 // Different methods, bailout.
1127 return false;
1128 }
1129 }
1130
1131 HInstruction* receiver = invoke_instruction->InputAt(0);
1132 HInstruction* cursor = invoke_instruction->GetPrevious();
1133 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1134
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001135 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001136 if (!TryBuildAndInline(invoke_instruction,
1137 actual_method,
1138 ReferenceTypeInfo::CreateInvalid(),
1139 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001140 return false;
1141 }
1142
1143 // We successfully inlined, now add a guard.
1144 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1145 class_linker, receiver, invoke_instruction->GetDexPc());
1146
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001147 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1148 ? DataType::Type::kInt64
1149 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001150 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001151 receiver_class,
1152 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001153 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1154 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001155 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001156 invoke_instruction->GetDexPc());
1157
1158 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001159 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001160 constant = graph_->GetLongConstant(
1161 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1162 } else {
1163 constant = graph_->GetIntConstant(
1164 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1165 }
1166
Vladimir Markoca6fff82017-10-03 14:49:14 +01001167 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001168 if (cursor != nullptr) {
1169 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1170 } else {
1171 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1172 }
1173 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1174 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001175
1176 if (outermost_graph_->IsCompilingOsr()) {
1177 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1178 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001179 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1180 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001181 compare,
1182 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001183 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001184 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001185 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1186 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1187 if (return_replacement != nullptr) {
1188 invoke_instruction->ReplaceWith(return_replacement);
1189 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001190 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001191 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001192 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001193 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001194
1195 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001196 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001197 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001198 outer_compilation_unit_.GetDexCache(),
1199 handles_,
1200 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001201 rtp_fixup.Run();
1202
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001203 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001204
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001205 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001206 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001207}
1208
Mingyao Yang063fc772016-08-02 11:02:54 -07001209bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1210 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001211 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001212 bool do_rtp,
1213 bool cha_devirtualize) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001214 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001215 uint32_t dex_pc = invoke_instruction->GetDexPc();
1216 HInstruction* cursor = invoke_instruction->GetPrevious();
1217 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001218 if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001219 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001220 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001221 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1222 // better than an invoke-interface because:
1223 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1224 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1225 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001226
1227 if (method->IsDefault() && !method->IsCopied()) {
1228 // Changing to invoke-virtual cannot be done on an original default method
1229 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1230 // always uses a method in the iftable which is never an original default
1231 // method.
1232 // On the other hand, inlining an original default method by CHA is fine.
1233 DCHECK(cha_devirtualize);
1234 return false;
1235 }
1236
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001237 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001238 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001239 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001240 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001241 return false;
1242 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001243 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1244 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001245 invoke_instruction->GetNumberOfArguments(),
1246 invoke_instruction->GetType(),
1247 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001248 dex_method_index,
1249 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001250 method->GetMethodIndex());
1251 HInputsRef inputs = invoke_instruction->GetInputs();
1252 for (size_t index = 0; index != inputs.size(); ++index) {
1253 new_invoke->SetArgumentAt(index, inputs[index]);
1254 }
1255 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1256 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001257 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001258 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1259 }
1260 return_replacement = new_invoke;
Aart Bikf0010dd2017-11-21 16:31:53 -08001261 // Directly check if the new virtual can be recognized as an intrinsic.
1262 // This way, we avoid running a full recognition pass just to detect
1263 // these relative rare cases.
1264 bool wrong_invoke_type = false;
1265 if (IntrinsicsRecognizer::Recognize(new_invoke, &wrong_invoke_type)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001266 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
Aart Bikf0010dd2017-11-21 16:31:53 -08001267 }
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001268 } else {
1269 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1270 // compiler driver.
1271 return false;
1272 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001273 }
Mingyao Yang063fc772016-08-02 11:02:54 -07001274 if (cha_devirtualize) {
1275 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1276 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001277 if (return_replacement != nullptr) {
1278 invoke_instruction->ReplaceWith(return_replacement);
1279 }
1280 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +01001281 FixUpReturnReferenceType(method, return_replacement);
1282 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1283 // Actual return value has a more specific type than the method's declared
1284 // return type. Run RTP again on the outer graph to propagate it.
1285 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001286 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001287 outer_compilation_unit_.GetDexCache(),
1288 handles_,
1289 /* is_first_run */ false).Run();
1290 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001291 return true;
1292}
1293
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001294size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1295 const HInliner* current = this;
1296 size_t count = 0;
1297 do {
1298 if (current->graph_->GetArtMethod() == method) {
1299 ++count;
1300 }
1301 current = current->parent_;
1302 } while (current != nullptr);
1303 return count;
1304}
1305
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001306bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1307 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001308 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001309 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001310 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001311 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001312 << "Method " << method->PrettyMethod()
1313 << " is not inlined because of unimplemented inline support for proxy methods.";
1314 return false;
1315 }
1316
1317 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001318 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001319 << "Method "
1320 << method->PrettyMethod()
1321 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001322 return false;
1323 }
1324
Jeff Haodcdc85b2015-12-04 14:06:18 -08001325 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1326 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1327 if (!compiler_driver_->MayInline(method->GetDexFile(),
1328 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001329 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001330 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1331 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001332 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001333 return true;
1334 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001335 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001336 << "Won't inline " << method->PrettyMethod() << " in "
1337 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1338 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1339 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001340 return false;
1341 }
1342
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001343 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1344
1345 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001346
1347 if (code_item == nullptr) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001348 LOG_FAIL_NO_STAT()
1349 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001350 return false;
1351 }
1352
Calin Juravleec748352015-07-29 13:52:12 +01001353 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
1354 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001355 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001356 << "Method " << method->PrettyMethod()
1357 << " is not inlined because its code item is too big: "
1358 << code_item->insns_size_in_code_units_
1359 << " > "
1360 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001361 return false;
1362 }
1363
1364 if (code_item->tries_size_ != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001365 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001366 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001367 return false;
1368 }
1369
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001370 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001371 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001372 << "Method " << method->PrettyMethod()
1373 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001374 }
1375
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001376 if (!method->GetDeclaringClass()->IsVerified()) {
1377 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +01001378 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001379 !compiler_driver_->IsMethodVerifiedWithoutFailures(
1380 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001381 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001382 << "Method " << method->PrettyMethod()
1383 << " couldn't be verified, so it cannot be inlined";
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001384 return false;
1385 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001386 }
1387
Roland Levillain4c0eb422015-04-24 16:43:49 +01001388 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1389 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1390 // Case of a static method that cannot be inlined because it implicitly
1391 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001392 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1393 << "Method " << method->PrettyMethod()
1394 << " is not inlined because it is static and requires a clinit"
1395 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001396 return false;
1397 }
1398
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001399 if (!TryBuildAndInlineHelper(
1400 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001401 return false;
1402 }
1403
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001404 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001405 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001406 return true;
1407}
1408
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001409static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1410 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001411 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001412 size_t input_index = 0;
1413 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1414 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001415 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001416 ++i;
1417 DCHECK_NE(i, arg_vreg_index);
1418 }
1419 }
1420 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1421 return invoke_instruction->InputAt(input_index);
1422}
1423
1424// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1425bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1426 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001427 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001428 InlineMethod inline_method;
1429 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1430 return false;
1431 }
1432
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001433 switch (inline_method.opcode) {
1434 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001435 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001436 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001437 break;
1438 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001439 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1440 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001441 break;
1442 case kInlineOpNonWideConst:
1443 if (resolved_method->GetShorty()[0] == 'L') {
1444 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001445 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001446 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001447 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001448 }
1449 break;
1450 case kInlineOpIGet: {
1451 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1452 if (data.method_is_static || data.object_arg != 0u) {
1453 // TODO: Needs null check.
1454 return false;
1455 }
1456 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001457 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001458 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1459 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1460 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001461 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001462 break;
1463 }
1464 case kInlineOpIPut: {
1465 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1466 if (data.method_is_static || data.object_arg != 0u) {
1467 // TODO: Needs null check.
1468 return false;
1469 }
1470 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1471 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001472 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001473 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1474 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1475 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1476 if (data.return_arg_plus1 != 0u) {
1477 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001478 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001479 }
1480 break;
1481 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001482 case kInlineOpConstructor: {
1483 const InlineConstructorData& data = inline_method.d.constructor_data;
1484 // Get the indexes to arrays for easier processing.
1485 uint16_t iput_field_indexes[] = {
1486 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1487 };
1488 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1489 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1490 // Count valid field indexes.
1491 size_t number_of_iputs = 0u;
1492 while (number_of_iputs != arraysize(iput_field_indexes) &&
1493 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1494 // Check that there are no duplicate valid field indexes.
1495 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1496 iput_field_indexes + arraysize(iput_field_indexes),
1497 iput_field_indexes[number_of_iputs]));
1498 ++number_of_iputs;
1499 }
1500 // Check that there are no valid field indexes in the rest of the array.
1501 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1502 iput_field_indexes + arraysize(iput_field_indexes),
1503 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1504
1505 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001506 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1507 bool needs_constructor_barrier = false;
1508 for (size_t i = 0; i != number_of_iputs; ++i) {
1509 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001510 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001511 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001512 bool is_final;
1513 HInstanceFieldSet* iput =
1514 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001515 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1516
1517 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001518 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001519 needs_constructor_barrier = true;
1520 }
1521 }
1522 }
1523 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001524 // See CompilerDriver::RequiresConstructorBarrier for more details.
1525 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1526
1527 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001528 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001529 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1530 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001531 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001532 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001533 break;
1534 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001535 default:
1536 LOG(FATAL) << "UNREACHABLE";
1537 UNREACHABLE();
1538 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001539 return true;
1540}
1541
Vladimir Markof44d36c2017-03-14 14:18:46 +00001542HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1543 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001544 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001545 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001546 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1547 ArtField* resolved_field =
1548 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001549 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001550 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001551 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001552 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001553 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001554 resolved_field->GetOffset(),
1555 resolved_field->IsVolatile(),
1556 field_index,
1557 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001558 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001559 // Read barrier generates a runtime call in slow path and we need a valid
1560 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1561 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001562 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001563 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001564 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001565 ReferenceTypePropagation rtp(graph_,
1566 outer_compilation_unit_.GetClassLoader(),
1567 dex_cache,
1568 handles_,
1569 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001570 rtp.Visit(iget);
1571 }
1572 return iget;
1573}
1574
Vladimir Markof44d36c2017-03-14 14:18:46 +00001575HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1576 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001577 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001578 HInstruction* value,
1579 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001580 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001581 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1582 ArtField* resolved_field =
1583 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001584 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001585 if (is_final != nullptr) {
1586 // This information is needed only for constructors.
1587 DCHECK(referrer->IsConstructor());
1588 *is_final = resolved_field->IsFinal();
1589 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001590 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001591 obj,
1592 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001593 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001594 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001595 resolved_field->GetOffset(),
1596 resolved_field->IsVolatile(),
1597 field_index,
1598 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001599 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001600 // Read barrier generates a runtime call in slow path and we need a valid
1601 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1602 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001603 return iput;
1604}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001605
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001606template <typename T>
1607static inline Handle<T> NewHandleIfDifferent(T* object,
1608 Handle<T> hint,
1609 VariableSizedHandleScope* handles)
1610 REQUIRES_SHARED(Locks::mutator_lock_) {
1611 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1612}
1613
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001614bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1615 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001616 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001617 bool same_dex_file,
1618 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001619 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001620 ScopedObjectAccess soa(Thread::Current());
1621 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001622 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1623 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001624 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001625 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1626 caller_compilation_unit_.GetDexCache(),
1627 handles_);
1628 Handle<mirror::ClassLoader> class_loader =
1629 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1630 caller_compilation_unit_.GetClassLoader(),
1631 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001632
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001633 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001634 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001635 class_linker,
1636 callee_dex_file,
1637 code_item,
1638 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1639 method_index,
1640 resolved_method->GetAccessFlags(),
1641 /* verified_method */ nullptr,
1642 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001643
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001644 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001645 if (invoke_type == kInterface) {
1646 // We have statically resolved the dispatch. To please the class linker
1647 // at runtime, we change this call as if it was a virtual call.
1648 invoke_type = kVirtual;
1649 }
David Brazdil3f523062016-02-29 16:53:33 +00001650
1651 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001652 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1653 graph_->GetAllocator(),
1654 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001655 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001656 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001657 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001658 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001659 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001660 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001661 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001662 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001663
Vladimir Marko438709f2017-02-23 18:56:13 +00001664 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001665 // of on the stack, as Clang might produce a stack frame too large
1666 // for this function, that would not fit the requirements of the
1667 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001668 if (stats_ != nullptr) {
1669 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1670 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001671 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001672 inline_stats_ = new (storage) OptimizingCompilerStats;
1673 } else {
1674 inline_stats_->Reset();
1675 }
1676 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001677 HGraphBuilder builder(callee_graph,
Vladimir Marko92f7f3c2017-10-31 11:38:30 +00001678 code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001679 &dex_compilation_unit,
1680 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001681 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001682 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001683 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001684 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001685 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001686
David Brazdildee58d62016-04-07 09:54:26 +00001687 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001688 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001689 << "Method " << callee_dex_file.PrettyMethod(method_index)
1690 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001691 return false;
1692 }
1693
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001694 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1695 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001696 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001697 << "Method " << callee_dex_file.PrettyMethod(method_index)
1698 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001699 return false;
1700 }
1701
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001702 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001703 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001704 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1705 !instructions.Done();
1706 instructions.Advance()) {
1707 HInstruction* current = instructions.Current();
1708 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001709 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001710 if (argument->IsNullConstant()) {
1711 current->ReplaceWith(callee_graph->GetNullConstant());
1712 } else if (argument->IsIntConstant()) {
1713 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1714 } else if (argument->IsLongConstant()) {
1715 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1716 } else if (argument->IsFloatConstant()) {
1717 current->ReplaceWith(
1718 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1719 } else if (argument->IsDoubleConstant()) {
1720 current->ReplaceWith(
1721 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001722 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001723 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1724 run_rtp = true;
1725 current->SetReferenceTypeInfo(receiver_type);
1726 } else {
1727 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1728 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001729 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1730 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001731 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001732 }
1733 }
1734
David Brazdil94ab38f2016-06-21 17:48:19 +01001735 // We have replaced formal arguments with actual arguments. If actual types
1736 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001737 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001738 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001739 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001740 dex_compilation_unit.GetDexCache(),
1741 handles_,
1742 /* is_first_run */ false).Run();
1743 }
1744
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001745 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001746
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001747 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1748 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001749 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001750 << "Method " << callee_dex_file.PrettyMethod(method_index)
1751 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001752 return false;
1753 }
1754
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001755 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001756 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1757 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001758 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1759 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001760 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001761 << "Method " << callee_dex_file.PrettyMethod(method_index)
1762 << " could not be inlined because one branch always throws and"
1763 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001764 return false;
1765 } else if (graph_->GetExitBlock() == nullptr) {
1766 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001767 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001768 << "Method " << callee_dex_file.PrettyMethod(method_index)
1769 << " could not be inlined because one branch always throws and"
1770 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001771 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001772 } else if (graph_->HasIrreducibleLoops()) {
1773 // TODO(ngeoffray): Support re-computing loop information to graphs with
1774 // irreducible loops?
1775 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1776 << " could not be inlined because one branch always throws and"
1777 << " caller has irreducible loops";
1778 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001779 }
1780 } else {
1781 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001782 }
1783 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001784
1785 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001786 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001787 << "Method " << callee_dex_file.PrettyMethod(method_index)
1788 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001789 return false;
1790 }
1791
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001792 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001793 // Skip the entry block, it does not contain instructions that prevent inlining.
1794 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001795 if (block->IsLoopHeader()) {
1796 if (block->GetLoopInformation()->IsIrreducible()) {
1797 // Don't inline methods with irreducible loops, they could prevent some
1798 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001799 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001800 << "Method " << callee_dex_file.PrettyMethod(method_index)
1801 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001802 return false;
1803 }
1804 if (!block->GetLoopInformation()->HasExitEdge()) {
1805 // Don't inline methods with loops without exit, since they cause the
1806 // loop information to be computed incorrectly when updating after
1807 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001808 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001809 << "Method " << callee_dex_file.PrettyMethod(method_index)
1810 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001811 return false;
1812 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001813 }
1814
1815 for (HInstructionIterator instr_it(block->GetInstructions());
1816 !instr_it.Done();
1817 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001818 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001819 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001820 << "Method " << callee_dex_file.PrettyMethod(method_index)
1821 << " is not inlined because the outer method has reached"
1822 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001823 return false;
1824 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001825 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001826 if (current->NeedsEnvironment() &&
1827 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001828 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001829 << "Method " << callee_dex_file.PrettyMethod(method_index)
1830 << " is not inlined because its caller has reached"
1831 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001832 return false;
1833 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001834
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001835 if (current->NeedsEnvironment() &&
1836 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1837 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001838 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001839 << "Method " << callee_dex_file.PrettyMethod(method_index)
1840 << " could not be inlined because " << current->DebugName()
1841 << " needs an environment, is in a different dex file"
1842 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001843 return false;
1844 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001845
Vladimir Markodc151b22015-10-15 18:02:30 +01001846 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001847 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001848 << "Method " << callee_dex_file.PrettyMethod(method_index)
1849 << " could not be inlined because " << current->DebugName()
1850 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001851 return false;
1852 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001853
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001854 if (current->IsUnresolvedStaticFieldGet() ||
1855 current->IsUnresolvedInstanceFieldGet() ||
1856 current->IsUnresolvedStaticFieldSet() ||
1857 current->IsUnresolvedInstanceFieldSet()) {
1858 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001859 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001860 << "Method " << callee_dex_file.PrettyMethod(method_index)
1861 << " could not be inlined because it is using an unresolved"
1862 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001863 return false;
1864 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001865 }
1866 }
David Brazdil3f523062016-02-29 16:53:33 +00001867 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1868 << "No instructions can be added to the outer graph while inner graph is being built";
1869
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001870 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001871 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1872 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001873 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001874 // Update our budget for other inlining attempts in `caller_graph`.
1875 total_number_of_instructions_ += number_of_instructions;
1876 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001877
1878 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1879 << "No instructions can be added to the inner graph during inlining into the outer graph";
1880
Vladimir Marko438709f2017-02-23 18:56:13 +00001881 if (stats_ != nullptr) {
1882 DCHECK(inline_stats_ != nullptr);
1883 inline_stats_->AddTo(stats_);
1884 }
1885
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001886 return true;
1887}
Calin Juravle2e768302015-07-28 14:41:11 +00001888
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001889void HInliner::RunOptimizations(HGraph* callee_graph,
1890 const DexFile::CodeItem* code_item,
1891 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001892 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1893 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00001894 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08001895 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001896 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_, handles_);
Vladimir Marko65979462017-05-19 17:25:12 +01001897 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00001898 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001899
1900 HOptimization* optimizations[] = {
1901 &intrinsics,
1902 &sharpening,
1903 &simplify,
1904 &fold,
1905 &dce,
1906 };
1907
1908 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1909 HOptimization* optimization = optimizations[i];
1910 optimization->Run();
1911 }
1912
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001913 // Bail early for pathological cases on the environment (for example recursive calls,
1914 // or too large environment).
1915 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
1916 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1917 << " will not be inlined because the outer method has reached"
1918 << " its environment budget limit.";
1919 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001920 }
1921
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001922 // Bail early if we know we already are over the limit.
1923 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
1924 if (number_of_instructions > inlining_budget_) {
1925 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1926 << " will not be inlined because the outer method has reached"
1927 << " its instruction budget limit. " << number_of_instructions;
1928 return;
1929 }
1930
1931 HInliner inliner(callee_graph,
1932 outermost_graph_,
1933 codegen_,
1934 outer_compilation_unit_,
1935 dex_compilation_unit,
1936 compiler_driver_,
1937 handles_,
1938 inline_stats_,
1939 total_number_of_dex_registers_ + code_item->registers_size_,
1940 total_number_of_instructions_ + number_of_instructions,
1941 this,
1942 depth_ + 1);
1943 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001944}
1945
David Brazdil94ab38f2016-06-21 17:48:19 +01001946static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1947 bool declared_can_be_null,
1948 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001949 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001950 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1951 return true;
1952 }
1953
1954 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1955 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001956 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01001957}
1958
Vladimir Markob45528c2017-07-27 14:14:28 +01001959ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001960 return ReferenceTypePropagation::IsAdmissible(klass)
1961 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1962 : graph_->GetInexactObjectRti();
1963}
1964
1965bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1966 // If this is an instance call, test whether the type of the `this` argument
1967 // is more specific than the class which declares the method.
1968 if (!resolved_method->IsStatic()) {
1969 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1970 /* declared_can_be_null */ false,
1971 invoke_instruction->InputAt(0u))) {
1972 return true;
1973 }
1974 }
1975
David Brazdil94ab38f2016-06-21 17:48:19 +01001976 // Iterate over the list of parameter types and test whether any of the
1977 // actual inputs has a more specific reference type than the type declared in
1978 // the signature.
1979 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1980 for (size_t param_idx = 0,
1981 input_idx = resolved_method->IsStatic() ? 0 : 1,
1982 e = (param_list == nullptr ? 0 : param_list->Size());
1983 param_idx < e;
1984 ++param_idx, ++input_idx) {
1985 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001986 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01001987 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
1988 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01001989 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1990 /* declared_can_be_null */ true,
1991 input)) {
1992 return true;
1993 }
1994 }
1995 }
1996
1997 return false;
1998}
1999
2000bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2001 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002002 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002003 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002004 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002005 // Test if the return type is a refinement of the declared return type.
2006 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2007 /* declared_can_be_null */ true,
2008 return_replacement)) {
2009 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002010 } else if (return_replacement->IsInstanceFieldGet()) {
2011 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
2012 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2013 if (field_get->GetFieldInfo().GetField() ==
2014 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
2015 return true;
2016 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002017 }
2018 } else if (return_replacement->IsInstanceOf()) {
2019 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2020 return true;
2021 }
2022 }
2023
2024 return false;
2025}
2026
2027void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2028 HInstruction* return_replacement) {
2029 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002030 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002031 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2032 // Make sure that we have a valid type for the return. We may get an invalid one when
2033 // we inline invokes with multiple branches and create a Phi for the result.
2034 // TODO: we could be more precise by merging the phi inputs but that requires
2035 // some functionality from the reference type propagation.
2036 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002037 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002038 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002039 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002040 }
Calin Juravle2e768302015-07-28 14:41:11 +00002041 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002042}
2043
2044} // namespace art