blob: 1380355603f3795b5e42551b4fd0c9f3b5ff1bc2 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
24#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000025#include "dex/verified_method.h"
26#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010028#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/dex_compilation_unit.h"
30#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010031#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000032#include "jit/jit.h"
33#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000034#include "mirror/class_loader.h"
35#include "mirror/dex_cache.h"
36#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010037#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010038#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070039#include "register_allocator_linear_scan.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000040#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010041#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000042#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000043#include "ssa_phi_elimination.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070044#include "scoped_thread_state_change-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "thread.h"
46
47namespace art {
48
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000049static constexpr size_t kMaximumNumberOfHInstructions = 32;
50
51// Limit the number of dex registers that we accumulate while inlining
52// to avoid creating large amount of nested environments.
53static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
54
55// Avoid inlining within a huge method due to memory pressure.
56static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070057
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000058void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010059 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
60 if ((compiler_options.GetInlineDepthLimit() == 0)
61 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
62 return;
63 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000064 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
65 return;
66 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000067 if (graph_->IsDebuggable()) {
68 // For simplicity, we currently never inline when the graph is debuggable. This avoids
69 // doing some logic in the runtime to discover if a method could have been inlined.
70 return;
71 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010072 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
73 DCHECK(!blocks.empty());
74 HBasicBlock* next_block = blocks[0];
75 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010076 // Because we are changing the graph when inlining, we need to remember the next block.
77 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010078 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010079 continue;
80 }
81 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010082 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000083 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
84 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010085 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070086 // As long as the call is not intrinsified, it is worth trying to inline.
87 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +000088 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
89 // Debugging case: directives in method names control or assert on inlining.
90 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
91 call->GetDexMethodIndex(), /* with_signature */ false);
92 // Tests prevent inlining by having $noinline$ in their method names.
93 if (callee_name.find("$noinline$") == std::string::npos) {
94 if (!TryInline(call)) {
95 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
96 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
97 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000098 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010099 } else {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000100 // Normal case: try to inline.
101 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000102 }
103 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000104 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000105 }
106 }
107}
108
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100109static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700110 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100111 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
112}
113
114/**
115 * Given the `resolved_method` looked up in the dex cache, try to find
116 * the actual runtime target of an interface or virtual call.
117 * Return nullptr if the runtime target cannot be proven.
118 */
119static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700120 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100121 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
122 // No need to lookup further, the resolved method will be the target.
123 return resolved_method;
124 }
125
126 HInstruction* receiver = invoke->InputAt(0);
127 if (receiver->IsNullCheck()) {
128 // Due to multiple levels of inlining within the same pass, it might be that
129 // null check does not have the reference type of the actual receiver.
130 receiver = receiver->InputAt(0);
131 }
132 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000133 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
134 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100135 // We currently only support inlining with known receivers.
136 // TODO: Remove this check, we should be able to inline final methods
137 // on unknown receivers.
138 return nullptr;
139 } else if (info.GetTypeHandle()->IsInterface()) {
140 // Statically knowing that the receiver has an interface type cannot
141 // help us find what is the target method.
142 return nullptr;
143 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
144 // The method that we're trying to call is not in the receiver's class or super classes.
145 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000146 } else if (info.GetTypeHandle()->IsErroneous()) {
147 // If the type is erroneous, do not go further, as we are going to query the vtable or
148 // imt table, that we can only safely do on non-erroneous classes.
149 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100150 }
151
152 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700153 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100154 if (invoke->IsInvokeInterface()) {
155 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
156 resolved_method, pointer_size);
157 } else {
158 DCHECK(invoke->IsInvokeVirtual());
159 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
160 resolved_method, pointer_size);
161 }
162
163 if (resolved_method == nullptr) {
164 // The information we had on the receiver was not enough to find
165 // the target method. Since we check above the exact type of the receiver,
166 // the only reason this can happen is an IncompatibleClassChangeError.
167 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700168 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100169 // The information we had on the receiver was not enough to find
170 // the target method. Since we check above the exact type of the receiver,
171 // the only reason this can happen is an IncompatibleClassChangeError.
172 return nullptr;
173 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
174 // A final method has to be the target method.
175 return resolved_method;
176 } else if (info.IsExact()) {
177 // If we found a method and the receiver's concrete type is statically
178 // known, we know for sure the target.
179 return resolved_method;
180 } else {
181 // Even if we did find a method, the receiver type was not enough to
182 // statically find the runtime target.
183 return nullptr;
184 }
185}
186
187static uint32_t FindMethodIndexIn(ArtMethod* method,
188 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000189 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700190 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100191 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100192 return method->GetDexMethodIndex();
193 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000194 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100195 }
196}
197
Andreas Gampea5b09a62016-11-17 15:21:22 -0800198static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Mathieu Chartier5812e202017-02-13 18:32:04 -0800199 const DexFile& dex_file,
200 Handle<mirror::DexCache> dex_cache)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700201 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampea5b09a62016-11-17 15:21:22 -0800202 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100203 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700204 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000205 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800206 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700207 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100208 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100209 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Mathieu Chartier5812e202017-02-13 18:32:04 -0800210 DCHECK_EQ(cls->GetDexCache(), dex_cache.Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000211 index = cls->GetDexTypeIndex();
Mathieu Chartier5812e202017-02-13 18:32:04 -0800212 // Update the dex cache to ensure the class is in. The generated code will
213 // consider it is. We make it safe by updating the dex cache, as other
214 // dex files might also load the class, and there is no guarantee the dex
215 // cache of the dex file of the class will be updated.
216 if (dex_cache->GetResolvedType(index) == nullptr) {
217 dex_cache->SetResolvedType(index, cls);
218 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100219 } else {
220 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Mathieu Chartier5812e202017-02-13 18:32:04 -0800221 // We cannot guarantee the entry in the dex cache will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100222 // as there may be different class loaders. So only return the index if it's
Mathieu Chartier5812e202017-02-13 18:32:04 -0800223 // the right class in the dex cache already.
224 if (index.IsValid() && dex_cache->GetResolvedType(index) != cls) {
225 index = dex::TypeIndex::Invalid();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100226 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100227 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000228
229 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100230}
231
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000232class ScopedProfilingInfoInlineUse {
233 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000234 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
235 : method_(method),
236 self_(self),
237 // Fetch the profiling info ahead of using it. If it's null when fetching,
238 // we should not call JitCodeCache::DoneInlining.
239 profiling_info_(
240 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000241 }
242
243 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000244 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700245 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000246 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
247 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
248 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000249 }
250
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000251 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
252
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000253 private:
254 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000255 Thread* const self_;
256 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000257};
258
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000259static bool IsMonomorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
260 REQUIRES_SHARED(Locks::mutator_lock_) {
261 DCHECK_GE(InlineCache::kIndividualCacheSize, 2);
262 return classes->Get(0) != nullptr && classes->Get(1) == nullptr;
263}
264
265static bool IsMegamorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
266 REQUIRES_SHARED(Locks::mutator_lock_) {
267 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
268 if (classes->Get(i) == nullptr) {
269 return false;
270 }
271 }
272 return true;
273}
274
275static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
276 REQUIRES_SHARED(Locks::mutator_lock_) {
277 DCHECK(classes->Get(0) != nullptr);
278 return classes->Get(0);
279}
280
281static bool IsUninitialized(Handle<mirror::ObjectArray<mirror::Class>> classes)
282 REQUIRES_SHARED(Locks::mutator_lock_) {
283 return classes->Get(0) == nullptr;
284}
285
286static bool IsPolymorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
287 REQUIRES_SHARED(Locks::mutator_lock_) {
288 DCHECK_GE(InlineCache::kIndividualCacheSize, 3);
289 return classes->Get(1) != nullptr &&
290 classes->Get(InlineCache::kIndividualCacheSize - 1) == nullptr;
291}
292
Mingyao Yang063fc772016-08-02 11:02:54 -0700293ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
294 if (!resolved_method->HasSingleImplementation()) {
295 return nullptr;
296 }
297 if (Runtime::Current()->IsAotCompiler()) {
298 // No CHA-based devirtulization for AOT compiler (yet).
299 return nullptr;
300 }
301 if (outermost_graph_->IsCompilingOsr()) {
302 // We do not support HDeoptimize in OSR methods.
303 return nullptr;
304 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800305 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
306 return resolved_method->GetSingleImplementation(pointer_size);
Mingyao Yang063fc772016-08-02 11:02:54 -0700307}
308
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700309bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000310 if (invoke_instruction->IsInvokeUnresolved() ||
311 invoke_instruction->IsInvokePolymorphic()) {
312 return false; // Don't bother to move further if we know the method is unresolved or an
313 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100314 }
315
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000316 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100317 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000318 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
David Sehr709b0702016-10-13 09:12:37 -0700319 VLOG(compiler) << "Try inlining " << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000320
Nicolas Geoffray35071052015-06-09 15:43:38 +0100321 // We can query the dex cache directly. The verifier has populated it already.
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100322 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Andreas Gampefd2140f2015-12-23 16:30:44 -0800323 ArtMethod* actual_method = nullptr;
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100324 if (resolved_method == nullptr) {
325 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
326 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
327 VLOG(compiler) << "Not inlining a String.<init> method";
328 return false;
329 } else if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800330 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000331 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100332 // Check if we can statically find the method.
333 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000334 }
335
Mingyao Yang063fc772016-08-02 11:02:54 -0700336 bool cha_devirtualize = false;
337 if (actual_method == nullptr) {
338 ArtMethod* method = TryCHADevirtualization(resolved_method);
339 if (method != nullptr) {
340 cha_devirtualize = true;
341 actual_method = method;
342 }
343 }
344
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100345 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700346 bool result = TryInlineAndReplace(invoke_instruction,
347 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000348 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700349 /* do_rtp */ true,
350 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000351 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700352 if (cha_devirtualize) {
353 // Add dependency due to devirtulization. We've assumed resolved_method
354 // has single implementation.
355 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
356 MaybeRecordStat(kCHAInline);
357 } else {
358 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
359 }
Calin Juravle69158982016-03-16 11:53:41 +0000360 }
361 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100362 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000363
Andreas Gampefd2140f2015-12-23 16:30:44 -0800364 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100365
366 // Check if we can use an inline cache.
367 ArtMethod* caller = graph_->GetArtMethod();
Calin Juravleffc87072016-04-20 14:22:09 +0100368 if (Runtime::Current()->UseJitCompilation()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000369 // Under JIT, we should always know the caller.
370 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000371 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
372 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000373 if (profiling_info != nullptr) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000374 StackHandleScope<1> hs(soa.Self());
375 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
376 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs.NewHandle(
377 mirror::ObjectArray<mirror::Class>::Alloc(
378 soa.Self(),
379 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
380 InlineCache::kIndividualCacheSize));
381 if (inline_cache.Get() == nullptr) {
382 // We got an OOME. Just clear the exception, and don't inline.
383 DCHECK(soa.Self()->IsExceptionPending());
384 soa.Self()->ClearException();
385 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000386 return false;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000387 } else {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000388 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
389 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
390 inline_cache);
391 if (IsUninitialized(inline_cache)) {
392 VLOG(compiler) << "Interface or virtual call to "
393 << caller_dex_file.PrettyMethod(method_index)
394 << " is not hit and not inlined";
395 return false;
396 } else if (IsMonomorphic(inline_cache)) {
397 MaybeRecordStat(kMonomorphicCall);
398 if (outermost_graph_->IsCompilingOsr()) {
399 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
400 // interpreter and it may have seen different receiver types.
401 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
402 } else {
403 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
404 }
405 } else if (IsPolymorphic(inline_cache)) {
406 MaybeRecordStat(kPolymorphicCall);
407 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
408 } else {
409 DCHECK(IsMegamorphic(inline_cache));
410 VLOG(compiler) << "Interface or virtual call to "
411 << caller_dex_file.PrettyMethod(method_index)
412 << " is megamorphic and not inlined";
413 MaybeRecordStat(kMegamorphicCall);
414 return false;
415 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000416 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100417 }
418 }
419
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100420 VLOG(compiler) << "Interface or virtual call to "
David Sehr709b0702016-10-13 09:12:37 -0700421 << caller_dex_file.PrettyMethod(method_index)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100422 << " could not be statically determined";
423 return false;
424}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000425
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000426HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
427 HInstruction* receiver,
428 uint32_t dex_pc) const {
429 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
430 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000431 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000432 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000433 field,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000434 Primitive::kPrimNot,
435 field->GetOffset(),
436 field->IsVolatile(),
437 field->GetDexFieldIndex(),
438 field->GetDeclaringClass()->GetDexClassDefIndex(),
439 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000440 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000441 // The class of a field is effectively final, and does not have any memory dependencies.
442 result->SetSideEffects(SideEffects::None());
443 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000444}
445
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100446bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
447 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000448 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000449 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
450 << invoke_instruction->DebugName();
451
Mathieu Chartier5812e202017-02-13 18:32:04 -0800452 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800453 dex::TypeIndex class_index = FindClassIndexIn(
Mathieu Chartier5812e202017-02-13 18:32:04 -0800454 GetMonomorphicType(classes), caller_dex_file, caller_compilation_unit_.GetDexCache());
Andreas Gampea5b09a62016-11-17 15:21:22 -0800455 if (!class_index.IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700456 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100457 << " from inline cache is not inlined because its class is not"
458 << " accessible to the caller";
459 return false;
460 }
461
462 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700463 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100464 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000465 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForInterface(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100466 resolved_method, pointer_size);
467 } else {
468 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000469 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForVirtual(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100470 resolved_method, pointer_size);
471 }
472 DCHECK(resolved_method != nullptr);
473 HInstruction* receiver = invoke_instruction->InputAt(0);
474 HInstruction* cursor = invoke_instruction->GetPrevious();
475 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000476 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
Mingyao Yang063fc772016-08-02 11:02:54 -0700477 if (!TryInlineAndReplace(invoke_instruction,
478 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000479 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700480 /* do_rtp */ false,
481 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100482 return false;
483 }
484
485 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000486 AddTypeGuard(receiver,
487 cursor,
488 bb_cursor,
489 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000490 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000491 invoke_instruction,
492 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100493
494 // Run type propagation to get the guard typed, and eventually propagate the
495 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000496 ReferenceTypePropagation rtp_fixup(graph_,
497 outer_compilation_unit_.GetDexCache(),
498 handles_,
499 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100500 rtp_fixup.Run();
501
502 MaybeRecordStat(kInlinedMonomorphicCall);
503 return true;
504}
505
Mingyao Yang063fc772016-08-02 11:02:54 -0700506void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
507 uint32_t dex_pc,
508 HInstruction* cursor,
509 HBasicBlock* bb_cursor) {
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800510 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetArena())
511 HShouldDeoptimizeFlag(graph_->GetArena(), dex_pc);
512 HInstruction* compare = new (graph_->GetArena()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700513 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800514 HInstruction* deopt = new (graph_->GetArena()) HDeoptimize(compare, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700515
516 if (cursor != nullptr) {
517 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
518 } else {
519 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
520 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800521 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
522 bb_cursor->InsertInstructionAfter(deopt, compare);
523
524 // Add receiver as input to aid CHA guard optimization later.
525 deopt_flag->AddInput(invoke_instruction->InputAt(0));
526 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700527 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800528 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700529}
530
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000531HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
532 HInstruction* cursor,
533 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800534 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000535 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000536 HInstruction* invoke_instruction,
537 bool with_deoptimization) {
538 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
539 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
540 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000541 if (cursor != nullptr) {
542 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
543 } else {
544 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
545 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000546
547 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000548 bool is_referrer = (klass.Get() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray56876342016-12-16 16:09:08 +0000549 // Note that we will just compare the classes, so we don't need Java semantics access checks.
550 // Note that the type index and the dex file are relative to the method this type guard is
551 // inlined into.
552 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
553 class_index,
554 caller_dex_file,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000555 klass,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000556 is_referrer,
557 invoke_instruction->GetDexPc(),
558 /* needs_access_check */ false);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000559 HLoadClass::LoadKind kind = HSharpening::SharpenClass(
560 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
561 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
562 << "We should always be able to reference a class for inline caches";
563 // Insert before setting the kind, as setting the kind affects the inputs.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000564 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000565 load_class->SetLoadKind(kind);
Nicolas Geoffray56876342016-12-16 16:09:08 +0000566
567 // TODO: Extend reference type propagation to understand the guard.
568 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000569 bb_cursor->InsertInstructionAfter(compare, load_class);
570 if (with_deoptimization) {
571 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
572 compare, invoke_instruction->GetDexPc());
573 bb_cursor->InsertInstructionAfter(deoptimize, compare);
574 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
575 }
576 return compare;
577}
578
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000579bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100580 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000581 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000582 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
583 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000584
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000585 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000586 return true;
587 }
588
589 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700590 PointerSize pointer_size = class_linker->GetImagePointerSize();
Mathieu Chartier5812e202017-02-13 18:32:04 -0800591 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000592
593 bool all_targets_inlined = true;
594 bool one_target_inlined = false;
595 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000596 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000597 break;
598 }
599 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000600
601 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000602 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000603 method = handle->FindVirtualMethodForInterface(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000604 } else {
605 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000606 method = handle->FindVirtualMethodForVirtual(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000607 }
608
609 HInstruction* receiver = invoke_instruction->InputAt(0);
610 HInstruction* cursor = invoke_instruction->GetPrevious();
611 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
612
Mathieu Chartier5812e202017-02-13 18:32:04 -0800613 dex::TypeIndex class_index = FindClassIndexIn(
614 handle.Get(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000615 HInstruction* return_replacement = nullptr;
Andreas Gampea5b09a62016-11-17 15:21:22 -0800616 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000617 !TryBuildAndInline(invoke_instruction,
618 method,
619 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
620 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000621 all_targets_inlined = false;
622 } else {
623 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000624
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000625 VLOG(compiler) << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
626 << " has inlined " << ArtMethod::PrettyMethod(method);
627
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000628 // If we have inlined all targets before, and this receiver is the last seen,
629 // we deoptimize instead of keeping the original invoke instruction.
630 bool deoptimize = all_targets_inlined &&
631 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000632 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100633
634 if (outermost_graph_->IsCompilingOsr()) {
635 // We do not support HDeoptimize in OSR methods.
636 deoptimize = false;
637 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000638 HInstruction* compare = AddTypeGuard(receiver,
639 cursor,
640 bb_cursor,
641 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000642 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000643 invoke_instruction,
644 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000645 if (deoptimize) {
646 if (return_replacement != nullptr) {
647 invoke_instruction->ReplaceWith(return_replacement);
648 }
649 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
650 // Because the inline cache data can be populated concurrently, we force the end of the
651 // iteration. Otherhwise, we could see a new receiver type.
652 break;
653 } else {
654 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
655 }
656 }
657 }
658
659 if (!one_target_inlined) {
David Sehr709b0702016-10-13 09:12:37 -0700660 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000661 << " from inline cache is not inlined because none"
662 << " of its targets could be inlined";
663 return false;
664 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000665
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000666 MaybeRecordStat(kInlinedPolymorphicCall);
667
668 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000669 ReferenceTypePropagation rtp_fixup(graph_,
670 outer_compilation_unit_.GetDexCache(),
671 handles_,
672 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000673 rtp_fixup.Run();
674 return true;
675}
676
677void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
678 HInstruction* return_replacement,
679 HInstruction* invoke_instruction) {
680 uint32_t dex_pc = invoke_instruction->GetDexPc();
681 HBasicBlock* cursor_block = compare->GetBlock();
682 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
683 ArenaAllocator* allocator = graph_->GetArena();
684
685 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
686 // and the returned block is the start of the then branch (that could contain multiple blocks).
687 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
688
689 // Split the block containing the invoke before and after the invoke. The returned block
690 // of the split before will contain the invoke and will be the otherwise branch of
691 // the diamond. The returned block of the split after will be the merge block
692 // of the diamond.
693 HBasicBlock* end_then = invoke_instruction->GetBlock();
694 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
695 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
696
697 // If the methods we are inlining return a value, we create a phi in the merge block
698 // that will have the `invoke_instruction and the `return_replacement` as inputs.
699 if (return_replacement != nullptr) {
700 HPhi* phi = new (allocator) HPhi(
701 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
702 merge->AddPhi(phi);
703 invoke_instruction->ReplaceWith(phi);
704 phi->AddInput(return_replacement);
705 phi->AddInput(invoke_instruction);
706 }
707
708 // Add the control flow instructions.
709 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
710 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
711 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
712
713 // Add the newly created blocks to the graph.
714 graph_->AddBlock(then);
715 graph_->AddBlock(otherwise);
716 graph_->AddBlock(merge);
717
718 // Set up successor (and implictly predecessor) relations.
719 cursor_block->AddSuccessor(otherwise);
720 cursor_block->AddSuccessor(then);
721 end_then->AddSuccessor(merge);
722 otherwise->AddSuccessor(merge);
723
724 // Set up dominance information.
725 then->SetDominator(cursor_block);
726 cursor_block->AddDominatedBlock(then);
727 otherwise->SetDominator(cursor_block);
728 cursor_block->AddDominatedBlock(otherwise);
729 merge->SetDominator(cursor_block);
730 cursor_block->AddDominatedBlock(merge);
731
732 // Update the revert post order.
733 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
734 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
735 graph_->reverse_post_order_[++index] = then;
736 index = IndexOfElement(graph_->reverse_post_order_, end_then);
737 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
738 graph_->reverse_post_order_[++index] = otherwise;
739 graph_->reverse_post_order_[++index] = merge;
740
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000741
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000742 graph_->UpdateLoopAndTryInformationOfNewBlock(
743 then, original_invoke_block, /* replace_if_back_edge */ false);
744 graph_->UpdateLoopAndTryInformationOfNewBlock(
745 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
746
747 // In case the original invoke location was a back edge, we need to update
748 // the loop to now have the merge block as a back edge.
749 graph_->UpdateLoopAndTryInformationOfNewBlock(
750 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000751}
752
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000753bool HInliner::TryInlinePolymorphicCallToSameTarget(
754 HInvoke* invoke_instruction,
755 ArtMethod* resolved_method,
756 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000757 // This optimization only works under JIT for now.
Calin Juravleffc87072016-04-20 14:22:09 +0100758 DCHECK(Runtime::Current()->UseJitCompilation());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000759 if (graph_->GetInstructionSet() == kMips64) {
760 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000761 return false;
762 }
763 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700764 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000765
766 DCHECK(resolved_method != nullptr);
767 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000768 size_t method_index = invoke_instruction->IsInvokeVirtual()
769 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
770 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
771
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000772 // Check whether we are actually calling the same method among
773 // the different types seen.
774 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000775 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000776 break;
777 }
778 ArtMethod* new_method = nullptr;
779 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000780 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +0000781 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000782 if (new_method->IsRuntimeMethod()) {
783 // Bail out as soon as we see a conflict trampoline in one of the target's
784 // interface table.
785 return false;
786 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000787 } else {
788 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000789 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000790 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000791 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000792 if (actual_method == nullptr) {
793 actual_method = new_method;
794 } else if (actual_method != new_method) {
795 // Different methods, bailout.
David Sehr709b0702016-10-13 09:12:37 -0700796 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000797 << " from inline cache is not inlined because it resolves"
798 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000799 return false;
800 }
801 }
802
803 HInstruction* receiver = invoke_instruction->InputAt(0);
804 HInstruction* cursor = invoke_instruction->GetPrevious();
805 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
806
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100807 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000808 if (!TryBuildAndInline(invoke_instruction,
809 actual_method,
810 ReferenceTypeInfo::CreateInvalid(),
811 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000812 return false;
813 }
814
815 // We successfully inlined, now add a guard.
816 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
817 class_linker, receiver, invoke_instruction->GetDexPc());
818
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000819 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
820 ? Primitive::kPrimLong
821 : Primitive::kPrimInt;
822 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
823 receiver_class,
824 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000825 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
826 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000827 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000828 invoke_instruction->GetDexPc());
829
830 HConstant* constant;
831 if (type == Primitive::kPrimLong) {
832 constant = graph_->GetLongConstant(
833 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
834 } else {
835 constant = graph_->GetIntConstant(
836 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
837 }
838
839 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000840 if (cursor != nullptr) {
841 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
842 } else {
843 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
844 }
845 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
846 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100847
848 if (outermost_graph_->IsCompilingOsr()) {
849 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
850 } else {
851 // TODO: Extend reference type propagation to understand the guard.
852 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
853 compare, invoke_instruction->GetDexPc());
854 bb_cursor->InsertInstructionAfter(deoptimize, compare);
855 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
856 if (return_replacement != nullptr) {
857 invoke_instruction->ReplaceWith(return_replacement);
858 }
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +0100859 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100860 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000861
862 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000863 ReferenceTypePropagation rtp_fixup(graph_,
864 outer_compilation_unit_.GetDexCache(),
865 handles_,
866 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000867 rtp_fixup.Run();
868
869 MaybeRecordStat(kInlinedPolymorphicCall);
870
871 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100872}
873
Mingyao Yang063fc772016-08-02 11:02:54 -0700874bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
875 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000876 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -0700877 bool do_rtp,
878 bool cha_devirtualize) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000879 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -0700880 uint32_t dex_pc = invoke_instruction->GetDexPc();
881 HInstruction* cursor = invoke_instruction->GetPrevious();
882 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000883 if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000884 if (invoke_instruction->IsInvokeInterface()) {
885 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
886 // better than an invoke-interface because:
887 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
888 // 2) We will not go to the conflict trampoline with an invoke-virtual.
889 // TODO: Consider sharpening once it is not dependent on the compiler driver.
890 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100891 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000892 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100893 if (dex_method_index == DexFile::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000894 return false;
895 }
896 HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual(
897 graph_->GetArena(),
898 invoke_instruction->GetNumberOfArguments(),
899 invoke_instruction->GetType(),
900 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100901 dex_method_index,
902 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000903 method->GetMethodIndex());
904 HInputsRef inputs = invoke_instruction->GetInputs();
905 for (size_t index = 0; index != inputs.size(); ++index) {
906 new_invoke->SetArgumentAt(index, inputs[index]);
907 }
908 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
909 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
910 if (invoke_instruction->GetType() == Primitive::kPrimNot) {
911 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
912 }
913 return_replacement = new_invoke;
914 } else {
915 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
916 // compiler driver.
917 return false;
918 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000919 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700920 if (cha_devirtualize) {
921 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
922 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000923 if (return_replacement != nullptr) {
924 invoke_instruction->ReplaceWith(return_replacement);
925 }
926 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +0100927 FixUpReturnReferenceType(method, return_replacement);
928 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
929 // Actual return value has a more specific type than the method's declared
930 // return type. Run RTP again on the outer graph to propagate it.
931 ReferenceTypePropagation(graph_,
932 outer_compilation_unit_.GetDexCache(),
933 handles_,
934 /* is_first_run */ false).Run();
935 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000936 return true;
937}
938
939bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
940 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000941 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000942 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100943 if (method->IsProxyMethod()) {
David Sehr709b0702016-10-13 09:12:37 -0700944 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100945 << " is not inlined because of unimplemented inline support for proxy methods.";
946 return false;
947 }
948
Jeff Haodcdc85b2015-12-04 14:06:18 -0800949 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
950 // dex file here (though the transitivity of an inline chain would allow checking the calller).
951 if (!compiler_driver_->MayInline(method->GetDexFile(),
952 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000953 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
David Sehr709b0702016-10-13 09:12:37 -0700954 VLOG(compiler) << "Successfully replaced pattern of invoke "
955 << method->PrettyMethod();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000956 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
957 return true;
958 }
David Sehr709b0702016-10-13 09:12:37 -0700959 VLOG(compiler) << "Won't inline " << method->PrettyMethod() << " in "
Jeff Haodcdc85b2015-12-04 14:06:18 -0800960 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
961 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
962 << method->GetDexFile()->GetLocation();
963 return false;
964 }
965
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100966 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
967
968 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000969
970 if (code_item == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700971 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000972 << " is not inlined because it is native";
973 return false;
974 }
975
Calin Juravleec748352015-07-29 13:52:12 +0100976 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
977 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
David Sehr709b0702016-10-13 09:12:37 -0700978 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000979 << " is too big to inline: "
980 << code_item->insns_size_in_code_units_
981 << " > "
982 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000983 return false;
984 }
985
986 if (code_item->tries_size_ != 0) {
David Sehr709b0702016-10-13 09:12:37 -0700987 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000988 << " is not inlined because of try block";
989 return false;
990 }
991
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100992 if (!method->IsCompilable()) {
David Sehr709b0702016-10-13 09:12:37 -0700993 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100994 << " has soft failures un-handled by the compiler, so it cannot be inlined";
995 }
996
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100997 if (!method->GetDeclaringClass()->IsVerified()) {
998 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +0100999 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001000 !compiler_driver_->IsMethodVerifiedWithoutFailures(
1001 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
David Sehr709b0702016-10-13 09:12:37 -07001002 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001003 << " couldn't be verified, so it cannot be inlined";
1004 return false;
1005 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001006 }
1007
Roland Levillain4c0eb422015-04-24 16:43:49 +01001008 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1009 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1010 // Case of a static method that cannot be inlined because it implicitly
1011 // requires an initialization check of its declaring class.
David Sehr709b0702016-10-13 09:12:37 -07001012 VLOG(compiler) << "Method " << method->PrettyMethod()
Roland Levillain4c0eb422015-04-24 16:43:49 +01001013 << " is not inlined because it is static and requires a clinit"
1014 << " check that cannot be emitted due to Dex cache limitations";
1015 return false;
1016 }
1017
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001018 if (!TryBuildAndInlineHelper(
1019 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001020 return false;
1021 }
1022
David Sehr709b0702016-10-13 09:12:37 -07001023 VLOG(compiler) << "Successfully inlined " << method->PrettyMethod();
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001024 MaybeRecordStat(kInlinedInvoke);
1025 return true;
1026}
1027
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001028static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1029 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001030 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001031 size_t input_index = 0;
1032 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1033 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1034 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
1035 ++i;
1036 DCHECK_NE(i, arg_vreg_index);
1037 }
1038 }
1039 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1040 return invoke_instruction->InputAt(input_index);
1041}
1042
1043// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1044bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1045 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001046 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001047 InlineMethod inline_method;
1048 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1049 return false;
1050 }
1051
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001052 switch (inline_method.opcode) {
1053 case kInlineOpNop:
1054 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001055 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001056 break;
1057 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001058 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1059 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001060 break;
1061 case kInlineOpNonWideConst:
1062 if (resolved_method->GetShorty()[0] == 'L') {
1063 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001064 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001065 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001066 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001067 }
1068 break;
1069 case kInlineOpIGet: {
1070 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1071 if (data.method_is_static || data.object_arg != 0u) {
1072 // TODO: Needs null check.
1073 return false;
1074 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001075 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001076 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001077 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001078 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1079 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1080 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001081 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001082 break;
1083 }
1084 case kInlineOpIPut: {
1085 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1086 if (data.method_is_static || data.object_arg != 0u) {
1087 // TODO: Needs null check.
1088 return false;
1089 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001090 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001091 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1092 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001093 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001094 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1095 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1096 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1097 if (data.return_arg_plus1 != 0u) {
1098 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001099 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001100 }
1101 break;
1102 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001103 case kInlineOpConstructor: {
1104 const InlineConstructorData& data = inline_method.d.constructor_data;
1105 // Get the indexes to arrays for easier processing.
1106 uint16_t iput_field_indexes[] = {
1107 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1108 };
1109 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1110 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1111 // Count valid field indexes.
1112 size_t number_of_iputs = 0u;
1113 while (number_of_iputs != arraysize(iput_field_indexes) &&
1114 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1115 // Check that there are no duplicate valid field indexes.
1116 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1117 iput_field_indexes + arraysize(iput_field_indexes),
1118 iput_field_indexes[number_of_iputs]));
1119 ++number_of_iputs;
1120 }
1121 // Check that there are no valid field indexes in the rest of the array.
1122 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1123 iput_field_indexes + arraysize(iput_field_indexes),
1124 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1125
1126 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
1127 Handle<mirror::DexCache> dex_cache;
1128 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1129 bool needs_constructor_barrier = false;
1130 for (size_t i = 0; i != number_of_iputs; ++i) {
1131 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001132 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001133 if (dex_cache.GetReference() == nullptr) {
1134 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
1135 }
1136 uint16_t field_index = iput_field_indexes[i];
1137 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
1138 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1139
1140 // Check whether the field is final. If it is, we need to add a barrier.
Andreas Gampe542451c2016-07-26 09:02:02 -07001141 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Marko354efa62016-02-04 19:46:56 +00001142 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1143 DCHECK(resolved_field != nullptr);
1144 if (resolved_field->IsFinal()) {
1145 needs_constructor_barrier = true;
1146 }
1147 }
1148 }
1149 if (needs_constructor_barrier) {
1150 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
1151 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
1152 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001153 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001154 break;
1155 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001156 default:
1157 LOG(FATAL) << "UNREACHABLE";
1158 UNREACHABLE();
1159 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001160 return true;
1161}
1162
Vladimir Marko354efa62016-02-04 19:46:56 +00001163HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001164 uint32_t field_index,
1165 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001166 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001167 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001168 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1169 DCHECK(resolved_field != nullptr);
1170 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1171 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001172 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001173 resolved_field->GetTypeAsPrimitiveType(),
1174 resolved_field->GetOffset(),
1175 resolved_field->IsVolatile(),
1176 field_index,
1177 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001178 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001179 // Read barrier generates a runtime call in slow path and we need a valid
1180 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1181 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001182 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001183 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Mathieu Chartier5812e202017-02-13 18:32:04 -08001184 ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001185 rtp.Visit(iget);
1186 }
1187 return iget;
1188}
1189
Vladimir Marko354efa62016-02-04 19:46:56 +00001190HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001191 uint32_t field_index,
1192 HInstruction* obj,
1193 HInstruction* value)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001194 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001195 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001196 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1197 DCHECK(resolved_field != nullptr);
1198 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1199 obj,
1200 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001201 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001202 resolved_field->GetTypeAsPrimitiveType(),
1203 resolved_field->GetOffset(),
1204 resolved_field->IsVolatile(),
1205 field_index,
1206 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001207 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001208 // Read barrier generates a runtime call in slow path and we need a valid
1209 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1210 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001211 return iput;
1212}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001213
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001214bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1215 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001216 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001217 bool same_dex_file,
1218 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001219 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001220 ScopedObjectAccess soa(Thread::Current());
1221 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001222 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1223 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001224 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001225 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001226 Handle<mirror::ClassLoader> class_loader(handles_->NewHandle(
1227 resolved_method->GetDeclaringClass()->GetClassLoader()));
1228
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001229 DexCompilationUnit dex_compilation_unit(
Mathieu Chartier5812e202017-02-13 18:32:04 -08001230 class_loader.ToJObject(),
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001231 class_linker,
1232 callee_dex_file,
1233 code_item,
1234 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1235 method_index,
1236 resolved_method->GetAccessFlags(),
1237 /* verified_method */ nullptr,
1238 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001239
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001240 bool requires_ctor_barrier = false;
1241
1242 if (dex_compilation_unit.IsConstructor()) {
1243 // If it's a super invocation and we already generate a barrier there's no need
1244 // to generate another one.
1245 // We identify super calls by looking at the "this" pointer. If its value is the
1246 // same as the local "this" pointer then we must have a super invocation.
1247 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1248 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1249 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1250 requires_ctor_barrier = false;
1251 } else {
1252 Thread* self = Thread::Current();
1253 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1254 dex_compilation_unit.GetDexFile(),
1255 dex_compilation_unit.GetClassDefIndex());
1256 }
1257 }
1258
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001259 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001260 if (invoke_type == kInterface) {
1261 // We have statically resolved the dispatch. To please the class linker
1262 // at runtime, we change this call as if it was a virtual call.
1263 invoke_type = kVirtual;
1264 }
David Brazdil3f523062016-02-29 16:53:33 +00001265
1266 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001267 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001268 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001269 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001270 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001271 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001272 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001273 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001274 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001275 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001276 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001277 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001278
Roland Levillaina8013fd2016-04-04 15:34:31 +01001279 // When they are needed, allocate `inline_stats` on the heap instead
1280 // of on the stack, as Clang might produce a stack frame too large
1281 // for this function, that would not fit the requirements of the
1282 // `-Wframe-larger-than` option.
1283 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1284 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001285 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001286 &dex_compilation_unit,
1287 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001288 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001289 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001290 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001291 codegen_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001292 inline_stats.get(),
Vladimir Marko97d7e1c2016-10-04 14:44:28 +01001293 resolved_method->GetQuickenedInfo(class_linker->GetImagePointerSize()),
David Brazdildee58d62016-04-07 09:54:26 +00001294 dex_cache,
1295 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001296
David Brazdildee58d62016-04-07 09:54:26 +00001297 if (builder.BuildGraph() != kAnalysisSuccess) {
David Sehr709b0702016-10-13 09:12:37 -07001298 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001299 << " could not be built, so cannot be inlined";
1300 return false;
1301 }
1302
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001303 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1304 compiler_driver_->GetInstructionSet())) {
David Sehr709b0702016-10-13 09:12:37 -07001305 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001306 << " cannot be inlined because of the register allocator";
1307 return false;
1308 }
1309
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001310 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001311 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001312 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1313 !instructions.Done();
1314 instructions.Advance()) {
1315 HInstruction* current = instructions.Current();
1316 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001317 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001318 if (argument->IsNullConstant()) {
1319 current->ReplaceWith(callee_graph->GetNullConstant());
1320 } else if (argument->IsIntConstant()) {
1321 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1322 } else if (argument->IsLongConstant()) {
1323 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1324 } else if (argument->IsFloatConstant()) {
1325 current->ReplaceWith(
1326 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1327 } else if (argument->IsDoubleConstant()) {
1328 current->ReplaceWith(
1329 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1330 } else if (argument->GetType() == Primitive::kPrimNot) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001331 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1332 run_rtp = true;
1333 current->SetReferenceTypeInfo(receiver_type);
1334 } else {
1335 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1336 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001337 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1338 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001339 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001340 }
1341 }
1342
David Brazdil94ab38f2016-06-21 17:48:19 +01001343 // We have replaced formal arguments with actual arguments. If actual types
1344 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001345 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001346 ReferenceTypePropagation(callee_graph,
1347 dex_compilation_unit.GetDexCache(),
1348 handles_,
1349 /* is_first_run */ false).Run();
1350 }
1351
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001352 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001353 size_t number_of_inlined_instructions =
1354 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1355 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001356
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001357 // TODO: We should abort only if all predecessors throw. However,
1358 // HGraph::InlineInto currently does not handle an exit block with
1359 // a throw predecessor.
1360 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1361 if (exit_block == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -07001362 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001363 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001364 return false;
1365 }
1366
1367 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001368 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1369 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001370 has_throw_predecessor = true;
1371 break;
1372 }
1373 }
1374 if (has_throw_predecessor) {
David Sehr709b0702016-10-13 09:12:37 -07001375 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001376 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001377 return false;
1378 }
1379
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001380 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001381
1382 bool can_inline_environment =
1383 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1384
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001385 // Skip the entry block, it does not contain instructions that prevent inlining.
1386 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001387 if (block->IsLoopHeader()) {
1388 if (block->GetLoopInformation()->IsIrreducible()) {
1389 // Don't inline methods with irreducible loops, they could prevent some
1390 // optimizations to run.
1391 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1392 << " could not be inlined because it contains an irreducible loop";
1393 return false;
1394 }
1395 if (!block->GetLoopInformation()->HasExitEdge()) {
1396 // Don't inline methods with loops without exit, since they cause the
1397 // loop information to be computed incorrectly when updating after
1398 // inlining.
1399 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1400 << " could not be inlined because it contains a loop with no exit";
1401 return false;
1402 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001403 }
1404
1405 for (HInstructionIterator instr_it(block->GetInstructions());
1406 !instr_it.Done();
1407 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001408 if (number_of_instructions++ == number_of_instructions_budget) {
David Sehr709b0702016-10-13 09:12:37 -07001409 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001410 << " is not inlined because its caller has reached"
1411 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001412 return false;
1413 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001414 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001415 if (!can_inline_environment && current->NeedsEnvironment()) {
David Sehr709b0702016-10-13 09:12:37 -07001416 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001417 << " is not inlined because its caller has reached"
1418 << " its environment budget limit.";
1419 return false;
1420 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001421
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001422 if (current->NeedsEnvironment() &&
1423 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1424 resolved_method)) {
David Sehr709b0702016-10-13 09:12:37 -07001425 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001426 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001427 << " needs an environment, is in a different dex file"
1428 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001429 return false;
1430 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001431
Vladimir Markodc151b22015-10-15 18:02:30 +01001432 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
David Sehr709b0702016-10-13 09:12:37 -07001433 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001434 << " could not be inlined because " << current->DebugName()
1435 << " it is in a different dex file and requires access to the dex cache";
1436 return false;
1437 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001438
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001439 if (current->IsUnresolvedStaticFieldGet() ||
1440 current->IsUnresolvedInstanceFieldGet() ||
1441 current->IsUnresolvedStaticFieldSet() ||
1442 current->IsUnresolvedInstanceFieldSet()) {
1443 // Entrypoint for unresolved fields does not handle inlined frames.
David Sehr709b0702016-10-13 09:12:37 -07001444 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001445 << " could not be inlined because it is using an unresolved"
1446 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001447 return false;
1448 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001449 }
1450 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001451 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001452
David Brazdil3f523062016-02-29 16:53:33 +00001453 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1454 << "No instructions can be added to the outer graph while inner graph is being built";
1455
1456 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1457 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001458 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001459
1460 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1461 << "No instructions can be added to the inner graph during inlining into the outer graph";
1462
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001463 return true;
1464}
Calin Juravle2e768302015-07-28 14:41:11 +00001465
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001466size_t HInliner::RunOptimizations(HGraph* callee_graph,
1467 const DexFile::CodeItem* code_item,
1468 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001469 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1470 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Andreas Gampeca620d72016-11-08 08:09:33 -08001471 HDeadCodeElimination dce(callee_graph, stats_, "dead_code_elimination$inliner");
1472 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001473 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_, handles_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001474 InstructionSimplifier simplify(callee_graph, stats_);
Nicolas Geoffray762869d2016-07-15 15:28:35 +01001475 IntrinsicsRecognizer intrinsics(callee_graph, stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001476
1477 HOptimization* optimizations[] = {
1478 &intrinsics,
1479 &sharpening,
1480 &simplify,
1481 &fold,
1482 &dce,
1483 };
1484
1485 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1486 HOptimization* optimization = optimizations[i];
1487 optimization->Run();
1488 }
1489
1490 size_t number_of_inlined_instructions = 0u;
1491 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1492 HInliner inliner(callee_graph,
1493 outermost_graph_,
1494 codegen_,
1495 outer_compilation_unit_,
1496 dex_compilation_unit,
1497 compiler_driver_,
1498 handles_,
1499 stats_,
1500 total_number_of_dex_registers_ + code_item->registers_size_,
1501 depth_ + 1);
1502 inliner.Run();
1503 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1504 }
1505
1506 return number_of_inlined_instructions;
1507}
1508
David Brazdil94ab38f2016-06-21 17:48:19 +01001509static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1510 bool declared_can_be_null,
1511 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001512 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001513 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1514 return true;
1515 }
1516
1517 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1518 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001519 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01001520}
1521
1522ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1523 return ReferenceTypePropagation::IsAdmissible(klass)
1524 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1525 : graph_->GetInexactObjectRti();
1526}
1527
1528bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1529 // If this is an instance call, test whether the type of the `this` argument
1530 // is more specific than the class which declares the method.
1531 if (!resolved_method->IsStatic()) {
1532 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1533 /* declared_can_be_null */ false,
1534 invoke_instruction->InputAt(0u))) {
1535 return true;
1536 }
1537 }
1538
David Brazdil94ab38f2016-06-21 17:48:19 +01001539 // Iterate over the list of parameter types and test whether any of the
1540 // actual inputs has a more specific reference type than the type declared in
1541 // the signature.
1542 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1543 for (size_t param_idx = 0,
1544 input_idx = resolved_method->IsStatic() ? 0 : 1,
1545 e = (param_list == nullptr ? 0 : param_list->Size());
1546 param_idx < e;
1547 ++param_idx, ++input_idx) {
1548 HInstruction* input = invoke_instruction->InputAt(input_idx);
1549 if (input->GetType() == Primitive::kPrimNot) {
Vladimir Marko942fd312017-01-16 20:52:19 +00001550 mirror::Class* param_cls = resolved_method->GetClassFromTypeIndex(
David Brazdil94ab38f2016-06-21 17:48:19 +01001551 param_list->GetTypeItem(param_idx).type_idx_,
Vladimir Marko942fd312017-01-16 20:52:19 +00001552 /* resolve */ false);
David Brazdil94ab38f2016-06-21 17:48:19 +01001553 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1554 /* declared_can_be_null */ true,
1555 input)) {
1556 return true;
1557 }
1558 }
1559 }
1560
1561 return false;
1562}
1563
1564bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1565 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001566 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001567 if (return_replacement != nullptr) {
1568 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001569 // Test if the return type is a refinement of the declared return type.
1570 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1571 /* declared_can_be_null */ true,
1572 return_replacement)) {
1573 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001574 } else if (return_replacement->IsInstanceFieldGet()) {
1575 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
1576 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1577 if (field_get->GetFieldInfo().GetField() ==
1578 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
1579 return true;
1580 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001581 }
1582 } else if (return_replacement->IsInstanceOf()) {
1583 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1584 return true;
1585 }
1586 }
1587
1588 return false;
1589}
1590
1591void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1592 HInstruction* return_replacement) {
1593 if (return_replacement != nullptr) {
1594 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001595 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1596 // Make sure that we have a valid type for the return. We may get an invalid one when
1597 // we inline invokes with multiple branches and create a Phi for the result.
1598 // TODO: we could be more precise by merging the phi inputs but that requires
1599 // some functionality from the reference type propagation.
1600 DCHECK(return_replacement->IsPhi());
Vladimir Marko942fd312017-01-16 20:52:19 +00001601 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */);
David Brazdil94ab38f2016-06-21 17:48:19 +01001602 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001603 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001604 }
Calin Juravle2e768302015-07-28 14:41:11 +00001605 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001606}
1607
1608} // namespace art