blob: 22f0646fd001791ac3611295de78e277efda61aa [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
24#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000025#include "dex/verified_method.h"
26#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010028#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/dex_compilation_unit.h"
30#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010031#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000032#include "jit/jit.h"
33#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000034#include "mirror/class_loader.h"
35#include "mirror/dex_cache.h"
36#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010037#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010038#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070039#include "register_allocator_linear_scan.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000040#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010041#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000042#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000043#include "ssa_phi_elimination.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070044#include "scoped_thread_state_change-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "thread.h"
46
47namespace art {
48
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000049static constexpr size_t kMaximumNumberOfHInstructions = 32;
50
51// Limit the number of dex registers that we accumulate while inlining
52// to avoid creating large amount of nested environments.
53static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
54
55// Avoid inlining within a huge method due to memory pressure.
56static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070057
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000058void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010059 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
60 if ((compiler_options.GetInlineDepthLimit() == 0)
61 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
62 return;
63 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000064 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
65 return;
66 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000067 if (graph_->IsDebuggable()) {
68 // For simplicity, we currently never inline when the graph is debuggable. This avoids
69 // doing some logic in the runtime to discover if a method could have been inlined.
70 return;
71 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010072 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
73 DCHECK(!blocks.empty());
74 HBasicBlock* next_block = blocks[0];
75 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010076 // Because we are changing the graph when inlining, we need to remember the next block.
77 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010078 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010079 continue;
80 }
81 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010082 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000083 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
84 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010085 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070086 // As long as the call is not intrinsified, it is worth trying to inline.
87 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000088 // We use the original invoke type to ensure the resolution of the called method
89 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000090 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010091 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000092 std::string callee_name =
David Sehr709b0702016-10-13 09:12:37 -070093 outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000094 bool should_inline = callee_name.find("$inline$") != std::string::npos;
95 CHECK(!should_inline) << "Could not inline " << callee_name;
96 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010097 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010098 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010099 std::string callee_name =
David Sehr709b0702016-10-13 09:12:37 -0700100 outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex());
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100101 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
102 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
103 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000104 }
105 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000106 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000107 }
108 }
109}
110
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100111static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700112 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100113 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
114}
115
116/**
117 * Given the `resolved_method` looked up in the dex cache, try to find
118 * the actual runtime target of an interface or virtual call.
119 * Return nullptr if the runtime target cannot be proven.
120 */
121static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700122 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100123 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
124 // No need to lookup further, the resolved method will be the target.
125 return resolved_method;
126 }
127
128 HInstruction* receiver = invoke->InputAt(0);
129 if (receiver->IsNullCheck()) {
130 // Due to multiple levels of inlining within the same pass, it might be that
131 // null check does not have the reference type of the actual receiver.
132 receiver = receiver->InputAt(0);
133 }
134 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000135 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
136 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100137 // We currently only support inlining with known receivers.
138 // TODO: Remove this check, we should be able to inline final methods
139 // on unknown receivers.
140 return nullptr;
141 } else if (info.GetTypeHandle()->IsInterface()) {
142 // Statically knowing that the receiver has an interface type cannot
143 // help us find what is the target method.
144 return nullptr;
145 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
146 // The method that we're trying to call is not in the receiver's class or super classes.
147 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000148 } else if (info.GetTypeHandle()->IsErroneous()) {
149 // If the type is erroneous, do not go further, as we are going to query the vtable or
150 // imt table, that we can only safely do on non-erroneous classes.
151 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100152 }
153
154 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700155 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100156 if (invoke->IsInvokeInterface()) {
157 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
158 resolved_method, pointer_size);
159 } else {
160 DCHECK(invoke->IsInvokeVirtual());
161 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
162 resolved_method, pointer_size);
163 }
164
165 if (resolved_method == nullptr) {
166 // The information we had on the receiver was not enough to find
167 // the target method. Since we check above the exact type of the receiver,
168 // the only reason this can happen is an IncompatibleClassChangeError.
169 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700170 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100171 // The information we had on the receiver was not enough to find
172 // the target method. Since we check above the exact type of the receiver,
173 // the only reason this can happen is an IncompatibleClassChangeError.
174 return nullptr;
175 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
176 // A final method has to be the target method.
177 return resolved_method;
178 } else if (info.IsExact()) {
179 // If we found a method and the receiver's concrete type is statically
180 // known, we know for sure the target.
181 return resolved_method;
182 } else {
183 // Even if we did find a method, the receiver type was not enough to
184 // statically find the runtime target.
185 return nullptr;
186 }
187}
188
189static uint32_t FindMethodIndexIn(ArtMethod* method,
190 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000191 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700192 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100193 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100194 return method->GetDexMethodIndex();
195 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000196 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100197 }
198}
199
Andreas Gampea5b09a62016-11-17 15:21:22 -0800200static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Markoec786222016-12-20 16:24:13 +0000201 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700202 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markoec786222016-12-20 16:24:13 +0000203 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800204 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100205 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700206 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000207 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800208 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700209 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100210 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100211 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Markoec786222016-12-20 16:24:13 +0000212 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000213 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100214 } else {
215 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Markoec786222016-12-20 16:24:13 +0000216 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100217 // as there may be different class loaders. So only return the index if it's
Vladimir Markoec786222016-12-20 16:24:13 +0000218 // the right class already resolved with the class loader.
219 if (index.IsValid()) {
220 ObjPtr<mirror::Class> resolved = ClassLinker::LookupResolvedType(
221 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
222 if (resolved != cls) {
223 index = dex::TypeIndex::Invalid();
224 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100225 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100226 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000227
228 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100229}
230
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000231class ScopedProfilingInfoInlineUse {
232 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000233 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
234 : method_(method),
235 self_(self),
236 // Fetch the profiling info ahead of using it. If it's null when fetching,
237 // we should not call JitCodeCache::DoneInlining.
238 profiling_info_(
239 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000240 }
241
242 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000243 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700244 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000245 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
246 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
247 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000248 }
249
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000250 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
251
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000252 private:
253 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000254 Thread* const self_;
255 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000256};
257
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000258static bool IsMonomorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
259 REQUIRES_SHARED(Locks::mutator_lock_) {
260 DCHECK_GE(InlineCache::kIndividualCacheSize, 2);
261 return classes->Get(0) != nullptr && classes->Get(1) == nullptr;
262}
263
264static bool IsMegamorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
265 REQUIRES_SHARED(Locks::mutator_lock_) {
266 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
267 if (classes->Get(i) == nullptr) {
268 return false;
269 }
270 }
271 return true;
272}
273
274static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
275 REQUIRES_SHARED(Locks::mutator_lock_) {
276 DCHECK(classes->Get(0) != nullptr);
277 return classes->Get(0);
278}
279
280static bool IsUninitialized(Handle<mirror::ObjectArray<mirror::Class>> classes)
281 REQUIRES_SHARED(Locks::mutator_lock_) {
282 return classes->Get(0) == nullptr;
283}
284
285static bool IsPolymorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
286 REQUIRES_SHARED(Locks::mutator_lock_) {
287 DCHECK_GE(InlineCache::kIndividualCacheSize, 3);
288 return classes->Get(1) != nullptr &&
289 classes->Get(InlineCache::kIndividualCacheSize - 1) == nullptr;
290}
291
Mingyao Yang063fc772016-08-02 11:02:54 -0700292ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
293 if (!resolved_method->HasSingleImplementation()) {
294 return nullptr;
295 }
296 if (Runtime::Current()->IsAotCompiler()) {
297 // No CHA-based devirtulization for AOT compiler (yet).
298 return nullptr;
299 }
300 if (outermost_graph_->IsCompilingOsr()) {
301 // We do not support HDeoptimize in OSR methods.
302 return nullptr;
303 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800304 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
305 return resolved_method->GetSingleImplementation(pointer_size);
Mingyao Yang063fc772016-08-02 11:02:54 -0700306}
307
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700308bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000309 if (invoke_instruction->IsInvokeUnresolved() ||
310 invoke_instruction->IsInvokePolymorphic()) {
311 return false; // Don't bother to move further if we know the method is unresolved or an
312 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100313 }
314
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000315 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100316 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000317 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
David Sehr709b0702016-10-13 09:12:37 -0700318 VLOG(compiler) << "Try inlining " << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000319
Nicolas Geoffray35071052015-06-09 15:43:38 +0100320 // We can query the dex cache directly. The verifier has populated it already.
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100321 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Andreas Gampefd2140f2015-12-23 16:30:44 -0800322 ArtMethod* actual_method = nullptr;
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100323 if (resolved_method == nullptr) {
324 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
325 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
326 VLOG(compiler) << "Not inlining a String.<init> method";
327 return false;
328 } else if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800329 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000330 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100331 // Check if we can statically find the method.
332 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000333 }
334
Mingyao Yang063fc772016-08-02 11:02:54 -0700335 bool cha_devirtualize = false;
336 if (actual_method == nullptr) {
337 ArtMethod* method = TryCHADevirtualization(resolved_method);
338 if (method != nullptr) {
339 cha_devirtualize = true;
340 actual_method = method;
341 }
342 }
343
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100344 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700345 bool result = TryInlineAndReplace(invoke_instruction,
346 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000347 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700348 /* do_rtp */ true,
349 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000350 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700351 if (cha_devirtualize) {
352 // Add dependency due to devirtulization. We've assumed resolved_method
353 // has single implementation.
354 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
355 MaybeRecordStat(kCHAInline);
356 } else {
357 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
358 }
Calin Juravle69158982016-03-16 11:53:41 +0000359 }
360 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100361 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000362
Andreas Gampefd2140f2015-12-23 16:30:44 -0800363 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100364
365 // Check if we can use an inline cache.
366 ArtMethod* caller = graph_->GetArtMethod();
Calin Juravleffc87072016-04-20 14:22:09 +0100367 if (Runtime::Current()->UseJitCompilation()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000368 // Under JIT, we should always know the caller.
369 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000370 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
371 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000372 if (profiling_info != nullptr) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000373 StackHandleScope<1> hs(soa.Self());
374 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
375 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs.NewHandle(
376 mirror::ObjectArray<mirror::Class>::Alloc(
377 soa.Self(),
378 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
379 InlineCache::kIndividualCacheSize));
380 if (inline_cache.Get() == nullptr) {
381 // We got an OOME. Just clear the exception, and don't inline.
382 DCHECK(soa.Self()->IsExceptionPending());
383 soa.Self()->ClearException();
384 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000385 return false;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000386 } else {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000387 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
388 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
389 inline_cache);
390 if (IsUninitialized(inline_cache)) {
391 VLOG(compiler) << "Interface or virtual call to "
392 << caller_dex_file.PrettyMethod(method_index)
393 << " is not hit and not inlined";
394 return false;
395 } else if (IsMonomorphic(inline_cache)) {
396 MaybeRecordStat(kMonomorphicCall);
397 if (outermost_graph_->IsCompilingOsr()) {
398 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
399 // interpreter and it may have seen different receiver types.
400 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
401 } else {
402 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
403 }
404 } else if (IsPolymorphic(inline_cache)) {
405 MaybeRecordStat(kPolymorphicCall);
406 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
407 } else {
408 DCHECK(IsMegamorphic(inline_cache));
409 VLOG(compiler) << "Interface or virtual call to "
410 << caller_dex_file.PrettyMethod(method_index)
411 << " is megamorphic and not inlined";
412 MaybeRecordStat(kMegamorphicCall);
413 return false;
414 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000415 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100416 }
417 }
418
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100419 VLOG(compiler) << "Interface or virtual call to "
David Sehr709b0702016-10-13 09:12:37 -0700420 << caller_dex_file.PrettyMethod(method_index)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100421 << " could not be statically determined";
422 return false;
423}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000424
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000425HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
426 HInstruction* receiver,
427 uint32_t dex_pc) const {
428 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
429 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000430 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000431 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000432 field,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000433 Primitive::kPrimNot,
434 field->GetOffset(),
435 field->IsVolatile(),
436 field->GetDexFieldIndex(),
437 field->GetDeclaringClass()->GetDexClassDefIndex(),
438 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000439 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000440 // The class of a field is effectively final, and does not have any memory dependencies.
441 result->SetSideEffects(SideEffects::None());
442 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000443}
444
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100445bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
446 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000447 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000448 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
449 << invoke_instruction->DebugName();
450
Andreas Gampea5b09a62016-11-17 15:21:22 -0800451 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Markoec786222016-12-20 16:24:13 +0000452 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800453 if (!class_index.IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700454 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100455 << " from inline cache is not inlined because its class is not"
456 << " accessible to the caller";
457 return false;
458 }
459
460 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700461 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100462 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000463 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForInterface(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100464 resolved_method, pointer_size);
465 } else {
466 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000467 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForVirtual(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100468 resolved_method, pointer_size);
469 }
470 DCHECK(resolved_method != nullptr);
471 HInstruction* receiver = invoke_instruction->InputAt(0);
472 HInstruction* cursor = invoke_instruction->GetPrevious();
473 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000474 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
Mingyao Yang063fc772016-08-02 11:02:54 -0700475 if (!TryInlineAndReplace(invoke_instruction,
476 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000477 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700478 /* do_rtp */ false,
479 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100480 return false;
481 }
482
483 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000484 AddTypeGuard(receiver,
485 cursor,
486 bb_cursor,
487 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000488 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000489 invoke_instruction,
490 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100491
492 // Run type propagation to get the guard typed, and eventually propagate the
493 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000494 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Markoec786222016-12-20 16:24:13 +0000495 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000496 outer_compilation_unit_.GetDexCache(),
497 handles_,
498 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100499 rtp_fixup.Run();
500
501 MaybeRecordStat(kInlinedMonomorphicCall);
502 return true;
503}
504
Mingyao Yang063fc772016-08-02 11:02:54 -0700505void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
506 uint32_t dex_pc,
507 HInstruction* cursor,
508 HBasicBlock* bb_cursor) {
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800509 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetArena())
510 HShouldDeoptimizeFlag(graph_->GetArena(), dex_pc);
511 HInstruction* compare = new (graph_->GetArena()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700512 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800513 HInstruction* deopt = new (graph_->GetArena()) HDeoptimize(compare, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700514
515 if (cursor != nullptr) {
516 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
517 } else {
518 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
519 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800520 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
521 bb_cursor->InsertInstructionAfter(deopt, compare);
522
523 // Add receiver as input to aid CHA guard optimization later.
524 deopt_flag->AddInput(invoke_instruction->InputAt(0));
525 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700526 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800527 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700528}
529
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000530HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
531 HInstruction* cursor,
532 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800533 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000534 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000535 HInstruction* invoke_instruction,
536 bool with_deoptimization) {
537 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
538 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
539 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000540 if (cursor != nullptr) {
541 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
542 } else {
543 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
544 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000545
546 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000547 bool is_referrer = (klass.Get() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray56876342016-12-16 16:09:08 +0000548 // Note that we will just compare the classes, so we don't need Java semantics access checks.
549 // Note that the type index and the dex file are relative to the method this type guard is
550 // inlined into.
551 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
552 class_index,
553 caller_dex_file,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000554 klass,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000555 is_referrer,
556 invoke_instruction->GetDexPc(),
557 /* needs_access_check */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000558 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Nicolas Geoffray56876342016-12-16 16:09:08 +0000559 // Sharpen after adding the instruction, as the sharpening may remove inputs.
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000560 HSharpening::SharpenClass(load_class, codegen_, compiler_driver_);
Nicolas Geoffray56876342016-12-16 16:09:08 +0000561
562 // TODO: Extend reference type propagation to understand the guard.
563 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000564 bb_cursor->InsertInstructionAfter(compare, load_class);
565 if (with_deoptimization) {
566 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
567 compare, invoke_instruction->GetDexPc());
568 bb_cursor->InsertInstructionAfter(deoptimize, compare);
569 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
570 }
571 return compare;
572}
573
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000574bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100575 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000576 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000577 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
578 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000579
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000580 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000581 return true;
582 }
583
584 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700585 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000586
587 bool all_targets_inlined = true;
588 bool one_target_inlined = false;
589 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000590 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000591 break;
592 }
593 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000594
595 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000596 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000597 method = handle->FindVirtualMethodForInterface(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000598 } else {
599 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000600 method = handle->FindVirtualMethodForVirtual(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000601 }
602
603 HInstruction* receiver = invoke_instruction->InputAt(0);
604 HInstruction* cursor = invoke_instruction->GetPrevious();
605 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
606
Vladimir Markoec786222016-12-20 16:24:13 +0000607 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000608 HInstruction* return_replacement = nullptr;
Andreas Gampea5b09a62016-11-17 15:21:22 -0800609 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000610 !TryBuildAndInline(invoke_instruction,
611 method,
612 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
613 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000614 all_targets_inlined = false;
615 } else {
616 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000617
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000618 VLOG(compiler) << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
619 << " has inlined " << ArtMethod::PrettyMethod(method);
620
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000621 // If we have inlined all targets before, and this receiver is the last seen,
622 // we deoptimize instead of keeping the original invoke instruction.
623 bool deoptimize = all_targets_inlined &&
624 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000625 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100626
627 if (outermost_graph_->IsCompilingOsr()) {
628 // We do not support HDeoptimize in OSR methods.
629 deoptimize = false;
630 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000631 HInstruction* compare = AddTypeGuard(receiver,
632 cursor,
633 bb_cursor,
634 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000635 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000636 invoke_instruction,
637 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000638 if (deoptimize) {
639 if (return_replacement != nullptr) {
640 invoke_instruction->ReplaceWith(return_replacement);
641 }
642 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
643 // Because the inline cache data can be populated concurrently, we force the end of the
644 // iteration. Otherhwise, we could see a new receiver type.
645 break;
646 } else {
647 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
648 }
649 }
650 }
651
652 if (!one_target_inlined) {
David Sehr709b0702016-10-13 09:12:37 -0700653 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000654 << " from inline cache is not inlined because none"
655 << " of its targets could be inlined";
656 return false;
657 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000658
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000659 MaybeRecordStat(kInlinedPolymorphicCall);
660
661 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000662 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Markoec786222016-12-20 16:24:13 +0000663 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000664 outer_compilation_unit_.GetDexCache(),
665 handles_,
666 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000667 rtp_fixup.Run();
668 return true;
669}
670
671void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
672 HInstruction* return_replacement,
673 HInstruction* invoke_instruction) {
674 uint32_t dex_pc = invoke_instruction->GetDexPc();
675 HBasicBlock* cursor_block = compare->GetBlock();
676 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
677 ArenaAllocator* allocator = graph_->GetArena();
678
679 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
680 // and the returned block is the start of the then branch (that could contain multiple blocks).
681 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
682
683 // Split the block containing the invoke before and after the invoke. The returned block
684 // of the split before will contain the invoke and will be the otherwise branch of
685 // the diamond. The returned block of the split after will be the merge block
686 // of the diamond.
687 HBasicBlock* end_then = invoke_instruction->GetBlock();
688 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
689 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
690
691 // If the methods we are inlining return a value, we create a phi in the merge block
692 // that will have the `invoke_instruction and the `return_replacement` as inputs.
693 if (return_replacement != nullptr) {
694 HPhi* phi = new (allocator) HPhi(
695 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
696 merge->AddPhi(phi);
697 invoke_instruction->ReplaceWith(phi);
698 phi->AddInput(return_replacement);
699 phi->AddInput(invoke_instruction);
700 }
701
702 // Add the control flow instructions.
703 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
704 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
705 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
706
707 // Add the newly created blocks to the graph.
708 graph_->AddBlock(then);
709 graph_->AddBlock(otherwise);
710 graph_->AddBlock(merge);
711
712 // Set up successor (and implictly predecessor) relations.
713 cursor_block->AddSuccessor(otherwise);
714 cursor_block->AddSuccessor(then);
715 end_then->AddSuccessor(merge);
716 otherwise->AddSuccessor(merge);
717
718 // Set up dominance information.
719 then->SetDominator(cursor_block);
720 cursor_block->AddDominatedBlock(then);
721 otherwise->SetDominator(cursor_block);
722 cursor_block->AddDominatedBlock(otherwise);
723 merge->SetDominator(cursor_block);
724 cursor_block->AddDominatedBlock(merge);
725
726 // Update the revert post order.
727 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
728 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
729 graph_->reverse_post_order_[++index] = then;
730 index = IndexOfElement(graph_->reverse_post_order_, end_then);
731 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
732 graph_->reverse_post_order_[++index] = otherwise;
733 graph_->reverse_post_order_[++index] = merge;
734
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000735
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000736 graph_->UpdateLoopAndTryInformationOfNewBlock(
737 then, original_invoke_block, /* replace_if_back_edge */ false);
738 graph_->UpdateLoopAndTryInformationOfNewBlock(
739 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
740
741 // In case the original invoke location was a back edge, we need to update
742 // the loop to now have the merge block as a back edge.
743 graph_->UpdateLoopAndTryInformationOfNewBlock(
744 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000745}
746
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000747bool HInliner::TryInlinePolymorphicCallToSameTarget(
748 HInvoke* invoke_instruction,
749 ArtMethod* resolved_method,
750 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000751 // This optimization only works under JIT for now.
Calin Juravleffc87072016-04-20 14:22:09 +0100752 DCHECK(Runtime::Current()->UseJitCompilation());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000753 if (graph_->GetInstructionSet() == kMips64) {
754 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000755 return false;
756 }
757 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700758 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000759
760 DCHECK(resolved_method != nullptr);
761 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000762 size_t method_index = invoke_instruction->IsInvokeVirtual()
763 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
764 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
765
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000766 // Check whether we are actually calling the same method among
767 // the different types seen.
768 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000769 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000770 break;
771 }
772 ArtMethod* new_method = nullptr;
773 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000774 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +0000775 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000776 if (new_method->IsRuntimeMethod()) {
777 // Bail out as soon as we see a conflict trampoline in one of the target's
778 // interface table.
779 return false;
780 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000781 } else {
782 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000783 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000784 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000785 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000786 if (actual_method == nullptr) {
787 actual_method = new_method;
788 } else if (actual_method != new_method) {
789 // Different methods, bailout.
David Sehr709b0702016-10-13 09:12:37 -0700790 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000791 << " from inline cache is not inlined because it resolves"
792 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000793 return false;
794 }
795 }
796
797 HInstruction* receiver = invoke_instruction->InputAt(0);
798 HInstruction* cursor = invoke_instruction->GetPrevious();
799 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
800
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100801 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000802 if (!TryBuildAndInline(invoke_instruction,
803 actual_method,
804 ReferenceTypeInfo::CreateInvalid(),
805 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000806 return false;
807 }
808
809 // We successfully inlined, now add a guard.
810 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
811 class_linker, receiver, invoke_instruction->GetDexPc());
812
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000813 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
814 ? Primitive::kPrimLong
815 : Primitive::kPrimInt;
816 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
817 receiver_class,
818 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000819 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
820 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000821 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000822 invoke_instruction->GetDexPc());
823
824 HConstant* constant;
825 if (type == Primitive::kPrimLong) {
826 constant = graph_->GetLongConstant(
827 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
828 } else {
829 constant = graph_->GetIntConstant(
830 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
831 }
832
833 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000834 if (cursor != nullptr) {
835 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
836 } else {
837 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
838 }
839 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
840 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100841
842 if (outermost_graph_->IsCompilingOsr()) {
843 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
844 } else {
845 // TODO: Extend reference type propagation to understand the guard.
846 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
847 compare, invoke_instruction->GetDexPc());
848 bb_cursor->InsertInstructionAfter(deoptimize, compare);
849 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
850 if (return_replacement != nullptr) {
851 invoke_instruction->ReplaceWith(return_replacement);
852 }
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +0100853 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100854 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000855
856 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000857 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Markoec786222016-12-20 16:24:13 +0000858 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000859 outer_compilation_unit_.GetDexCache(),
860 handles_,
861 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000862 rtp_fixup.Run();
863
864 MaybeRecordStat(kInlinedPolymorphicCall);
865
866 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100867}
868
Mingyao Yang063fc772016-08-02 11:02:54 -0700869bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
870 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000871 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -0700872 bool do_rtp,
873 bool cha_devirtualize) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000874 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -0700875 uint32_t dex_pc = invoke_instruction->GetDexPc();
876 HInstruction* cursor = invoke_instruction->GetPrevious();
877 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000878 if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000879 if (invoke_instruction->IsInvokeInterface()) {
880 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
881 // better than an invoke-interface because:
882 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
883 // 2) We will not go to the conflict trampoline with an invoke-virtual.
884 // TODO: Consider sharpening once it is not dependent on the compiler driver.
885 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100886 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000887 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100888 if (dex_method_index == DexFile::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000889 return false;
890 }
891 HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual(
892 graph_->GetArena(),
893 invoke_instruction->GetNumberOfArguments(),
894 invoke_instruction->GetType(),
895 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100896 dex_method_index,
897 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000898 method->GetMethodIndex());
899 HInputsRef inputs = invoke_instruction->GetInputs();
900 for (size_t index = 0; index != inputs.size(); ++index) {
901 new_invoke->SetArgumentAt(index, inputs[index]);
902 }
903 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
904 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
905 if (invoke_instruction->GetType() == Primitive::kPrimNot) {
906 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
907 }
908 return_replacement = new_invoke;
909 } else {
910 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
911 // compiler driver.
912 return false;
913 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000914 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700915 if (cha_devirtualize) {
916 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
917 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000918 if (return_replacement != nullptr) {
919 invoke_instruction->ReplaceWith(return_replacement);
920 }
921 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +0100922 FixUpReturnReferenceType(method, return_replacement);
923 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
924 // Actual return value has a more specific type than the method's declared
925 // return type. Run RTP again on the outer graph to propagate it.
926 ReferenceTypePropagation(graph_,
Vladimir Markoec786222016-12-20 16:24:13 +0000927 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +0100928 outer_compilation_unit_.GetDexCache(),
929 handles_,
930 /* is_first_run */ false).Run();
931 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000932 return true;
933}
934
935bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
936 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000937 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000938 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100939 if (method->IsProxyMethod()) {
David Sehr709b0702016-10-13 09:12:37 -0700940 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100941 << " is not inlined because of unimplemented inline support for proxy methods.";
942 return false;
943 }
944
Jeff Haodcdc85b2015-12-04 14:06:18 -0800945 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
946 // dex file here (though the transitivity of an inline chain would allow checking the calller).
947 if (!compiler_driver_->MayInline(method->GetDexFile(),
948 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000949 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
David Sehr709b0702016-10-13 09:12:37 -0700950 VLOG(compiler) << "Successfully replaced pattern of invoke "
951 << method->PrettyMethod();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000952 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
953 return true;
954 }
David Sehr709b0702016-10-13 09:12:37 -0700955 VLOG(compiler) << "Won't inline " << method->PrettyMethod() << " in "
Jeff Haodcdc85b2015-12-04 14:06:18 -0800956 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
957 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
958 << method->GetDexFile()->GetLocation();
959 return false;
960 }
961
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100962 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
963
964 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000965
966 if (code_item == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700967 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000968 << " is not inlined because it is native";
969 return false;
970 }
971
Calin Juravleec748352015-07-29 13:52:12 +0100972 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
973 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
David Sehr709b0702016-10-13 09:12:37 -0700974 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000975 << " is too big to inline: "
976 << code_item->insns_size_in_code_units_
977 << " > "
978 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000979 return false;
980 }
981
982 if (code_item->tries_size_ != 0) {
David Sehr709b0702016-10-13 09:12:37 -0700983 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000984 << " is not inlined because of try block";
985 return false;
986 }
987
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100988 if (!method->IsCompilable()) {
David Sehr709b0702016-10-13 09:12:37 -0700989 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100990 << " has soft failures un-handled by the compiler, so it cannot be inlined";
991 }
992
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100993 if (!method->GetDeclaringClass()->IsVerified()) {
994 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +0100995 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000996 !compiler_driver_->IsMethodVerifiedWithoutFailures(
997 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
David Sehr709b0702016-10-13 09:12:37 -0700998 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100999 << " couldn't be verified, so it cannot be inlined";
1000 return false;
1001 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001002 }
1003
Roland Levillain4c0eb422015-04-24 16:43:49 +01001004 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1005 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1006 // Case of a static method that cannot be inlined because it implicitly
1007 // requires an initialization check of its declaring class.
David Sehr709b0702016-10-13 09:12:37 -07001008 VLOG(compiler) << "Method " << method->PrettyMethod()
Roland Levillain4c0eb422015-04-24 16:43:49 +01001009 << " is not inlined because it is static and requires a clinit"
1010 << " check that cannot be emitted due to Dex cache limitations";
1011 return false;
1012 }
1013
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001014 if (!TryBuildAndInlineHelper(
1015 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001016 return false;
1017 }
1018
David Sehr709b0702016-10-13 09:12:37 -07001019 VLOG(compiler) << "Successfully inlined " << method->PrettyMethod();
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001020 MaybeRecordStat(kInlinedInvoke);
1021 return true;
1022}
1023
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001024static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1025 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001026 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001027 size_t input_index = 0;
1028 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1029 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1030 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
1031 ++i;
1032 DCHECK_NE(i, arg_vreg_index);
1033 }
1034 }
1035 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1036 return invoke_instruction->InputAt(input_index);
1037}
1038
1039// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1040bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1041 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001042 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001043 InlineMethod inline_method;
1044 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1045 return false;
1046 }
1047
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001048 switch (inline_method.opcode) {
1049 case kInlineOpNop:
1050 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001051 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001052 break;
1053 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001054 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1055 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001056 break;
1057 case kInlineOpNonWideConst:
1058 if (resolved_method->GetShorty()[0] == 'L') {
1059 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001060 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001061 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001062 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001063 }
1064 break;
1065 case kInlineOpIGet: {
1066 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1067 if (data.method_is_static || data.object_arg != 0u) {
1068 // TODO: Needs null check.
1069 return false;
1070 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001071 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001072 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001073 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001074 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1075 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1076 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001077 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001078 break;
1079 }
1080 case kInlineOpIPut: {
1081 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1082 if (data.method_is_static || data.object_arg != 0u) {
1083 // TODO: Needs null check.
1084 return false;
1085 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001086 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001087 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1088 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001089 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001090 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1091 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1092 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1093 if (data.return_arg_plus1 != 0u) {
1094 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001095 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001096 }
1097 break;
1098 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001099 case kInlineOpConstructor: {
1100 const InlineConstructorData& data = inline_method.d.constructor_data;
1101 // Get the indexes to arrays for easier processing.
1102 uint16_t iput_field_indexes[] = {
1103 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1104 };
1105 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1106 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1107 // Count valid field indexes.
1108 size_t number_of_iputs = 0u;
1109 while (number_of_iputs != arraysize(iput_field_indexes) &&
1110 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1111 // Check that there are no duplicate valid field indexes.
1112 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1113 iput_field_indexes + arraysize(iput_field_indexes),
1114 iput_field_indexes[number_of_iputs]));
1115 ++number_of_iputs;
1116 }
1117 // Check that there are no valid field indexes in the rest of the array.
1118 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1119 iput_field_indexes + arraysize(iput_field_indexes),
1120 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1121
1122 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
1123 Handle<mirror::DexCache> dex_cache;
1124 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1125 bool needs_constructor_barrier = false;
1126 for (size_t i = 0; i != number_of_iputs; ++i) {
1127 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001128 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001129 if (dex_cache.GetReference() == nullptr) {
1130 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
1131 }
1132 uint16_t field_index = iput_field_indexes[i];
1133 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
1134 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1135
1136 // Check whether the field is final. If it is, we need to add a barrier.
Andreas Gampe542451c2016-07-26 09:02:02 -07001137 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Marko354efa62016-02-04 19:46:56 +00001138 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1139 DCHECK(resolved_field != nullptr);
1140 if (resolved_field->IsFinal()) {
1141 needs_constructor_barrier = true;
1142 }
1143 }
1144 }
1145 if (needs_constructor_barrier) {
1146 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
1147 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
1148 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001149 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001150 break;
1151 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001152 default:
1153 LOG(FATAL) << "UNREACHABLE";
1154 UNREACHABLE();
1155 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001156 return true;
1157}
1158
Vladimir Marko354efa62016-02-04 19:46:56 +00001159HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001160 uint32_t field_index,
1161 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001162 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001163 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001164 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1165 DCHECK(resolved_field != nullptr);
1166 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1167 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001168 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001169 resolved_field->GetTypeAsPrimitiveType(),
1170 resolved_field->GetOffset(),
1171 resolved_field->IsVolatile(),
1172 field_index,
1173 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001174 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001175 // Read barrier generates a runtime call in slow path and we need a valid
1176 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1177 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001178 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001179 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markoec786222016-12-20 16:24:13 +00001180 ReferenceTypePropagation rtp(graph_,
1181 outer_compilation_unit_.GetClassLoader(),
1182 dex_cache,
1183 handles_,
1184 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001185 rtp.Visit(iget);
1186 }
1187 return iget;
1188}
1189
Vladimir Marko354efa62016-02-04 19:46:56 +00001190HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001191 uint32_t field_index,
1192 HInstruction* obj,
1193 HInstruction* value)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001194 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001195 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001196 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1197 DCHECK(resolved_field != nullptr);
1198 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1199 obj,
1200 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001201 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001202 resolved_field->GetTypeAsPrimitiveType(),
1203 resolved_field->GetOffset(),
1204 resolved_field->IsVolatile(),
1205 field_index,
1206 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001207 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001208 // Read barrier generates a runtime call in slow path and we need a valid
1209 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1210 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001211 return iput;
1212}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001213
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001214bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1215 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001216 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001217 bool same_dex_file,
1218 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001219 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001220 ScopedObjectAccess soa(Thread::Current());
1221 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001222 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1223 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001224 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001225 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001226 Handle<mirror::ClassLoader> class_loader(handles_->NewHandle(
1227 resolved_method->GetDeclaringClass()->GetClassLoader()));
1228
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001229 DexCompilationUnit dex_compilation_unit(
Vladimir Markoec786222016-12-20 16:24:13 +00001230 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001231 class_linker,
1232 callee_dex_file,
1233 code_item,
1234 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1235 method_index,
1236 resolved_method->GetAccessFlags(),
1237 /* verified_method */ nullptr,
1238 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001239
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001240 bool requires_ctor_barrier = false;
1241
1242 if (dex_compilation_unit.IsConstructor()) {
1243 // If it's a super invocation and we already generate a barrier there's no need
1244 // to generate another one.
1245 // We identify super calls by looking at the "this" pointer. If its value is the
1246 // same as the local "this" pointer then we must have a super invocation.
1247 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1248 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1249 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1250 requires_ctor_barrier = false;
1251 } else {
1252 Thread* self = Thread::Current();
1253 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1254 dex_compilation_unit.GetDexFile(),
1255 dex_compilation_unit.GetClassDefIndex());
1256 }
1257 }
1258
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001259 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001260 if (invoke_type == kInterface) {
1261 // We have statically resolved the dispatch. To please the class linker
1262 // at runtime, we change this call as if it was a virtual call.
1263 invoke_type = kVirtual;
1264 }
David Brazdil3f523062016-02-29 16:53:33 +00001265
1266 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001267 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001268 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001269 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001270 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001271 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001272 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001273 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001274 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001275 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001276 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001277 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001278
Roland Levillaina8013fd2016-04-04 15:34:31 +01001279 // When they are needed, allocate `inline_stats` on the heap instead
1280 // of on the stack, as Clang might produce a stack frame too large
1281 // for this function, that would not fit the requirements of the
1282 // `-Wframe-larger-than` option.
1283 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1284 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001285 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001286 &dex_compilation_unit,
1287 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001288 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001289 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001290 compiler_driver_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001291 inline_stats.get(),
Vladimir Marko97d7e1c2016-10-04 14:44:28 +01001292 resolved_method->GetQuickenedInfo(class_linker->GetImagePointerSize()),
David Brazdildee58d62016-04-07 09:54:26 +00001293 dex_cache,
1294 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001295
David Brazdildee58d62016-04-07 09:54:26 +00001296 if (builder.BuildGraph() != kAnalysisSuccess) {
David Sehr709b0702016-10-13 09:12:37 -07001297 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001298 << " could not be built, so cannot be inlined";
1299 return false;
1300 }
1301
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001302 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1303 compiler_driver_->GetInstructionSet())) {
David Sehr709b0702016-10-13 09:12:37 -07001304 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001305 << " cannot be inlined because of the register allocator";
1306 return false;
1307 }
1308
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001309 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001310 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001311 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1312 !instructions.Done();
1313 instructions.Advance()) {
1314 HInstruction* current = instructions.Current();
1315 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001316 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001317 if (argument->IsNullConstant()) {
1318 current->ReplaceWith(callee_graph->GetNullConstant());
1319 } else if (argument->IsIntConstant()) {
1320 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1321 } else if (argument->IsLongConstant()) {
1322 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1323 } else if (argument->IsFloatConstant()) {
1324 current->ReplaceWith(
1325 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1326 } else if (argument->IsDoubleConstant()) {
1327 current->ReplaceWith(
1328 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1329 } else if (argument->GetType() == Primitive::kPrimNot) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001330 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1331 run_rtp = true;
1332 current->SetReferenceTypeInfo(receiver_type);
1333 } else {
1334 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1335 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001336 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1337 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001338 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001339 }
1340 }
1341
David Brazdil94ab38f2016-06-21 17:48:19 +01001342 // We have replaced formal arguments with actual arguments. If actual types
1343 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001344 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001345 ReferenceTypePropagation(callee_graph,
Vladimir Markoec786222016-12-20 16:24:13 +00001346 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001347 dex_compilation_unit.GetDexCache(),
1348 handles_,
1349 /* is_first_run */ false).Run();
1350 }
1351
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001352 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001353 size_t number_of_inlined_instructions =
1354 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1355 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001356
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001357 // TODO: We should abort only if all predecessors throw. However,
1358 // HGraph::InlineInto currently does not handle an exit block with
1359 // a throw predecessor.
1360 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1361 if (exit_block == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -07001362 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001363 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001364 return false;
1365 }
1366
1367 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001368 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1369 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001370 has_throw_predecessor = true;
1371 break;
1372 }
1373 }
1374 if (has_throw_predecessor) {
David Sehr709b0702016-10-13 09:12:37 -07001375 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001376 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001377 return false;
1378 }
1379
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001380 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001381
1382 bool can_inline_environment =
1383 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1384
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001385 // Skip the entry block, it does not contain instructions that prevent inlining.
1386 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001387 if (block->IsLoopHeader()) {
1388 if (block->GetLoopInformation()->IsIrreducible()) {
1389 // Don't inline methods with irreducible loops, they could prevent some
1390 // optimizations to run.
1391 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1392 << " could not be inlined because it contains an irreducible loop";
1393 return false;
1394 }
1395 if (!block->GetLoopInformation()->HasExitEdge()) {
1396 // Don't inline methods with loops without exit, since they cause the
1397 // loop information to be computed incorrectly when updating after
1398 // inlining.
1399 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1400 << " could not be inlined because it contains a loop with no exit";
1401 return false;
1402 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001403 }
1404
1405 for (HInstructionIterator instr_it(block->GetInstructions());
1406 !instr_it.Done();
1407 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001408 if (number_of_instructions++ == number_of_instructions_budget) {
David Sehr709b0702016-10-13 09:12:37 -07001409 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001410 << " is not inlined because its caller has reached"
1411 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001412 return false;
1413 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001414 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001415 if (!can_inline_environment && current->NeedsEnvironment()) {
David Sehr709b0702016-10-13 09:12:37 -07001416 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001417 << " is not inlined because its caller has reached"
1418 << " its environment budget limit.";
1419 return false;
1420 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001421
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001422 if (!same_dex_file && current->NeedsEnvironment()) {
David Sehr709b0702016-10-13 09:12:37 -07001423 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001424 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001425 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001426 return false;
1427 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001428
Vladimir Markodc151b22015-10-15 18:02:30 +01001429 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
David Sehr709b0702016-10-13 09:12:37 -07001430 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001431 << " could not be inlined because " << current->DebugName()
1432 << " it is in a different dex file and requires access to the dex cache";
1433 return false;
1434 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001435
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001436 if (current->IsUnresolvedStaticFieldGet() ||
1437 current->IsUnresolvedInstanceFieldGet() ||
1438 current->IsUnresolvedStaticFieldSet() ||
1439 current->IsUnresolvedInstanceFieldSet()) {
1440 // Entrypoint for unresolved fields does not handle inlined frames.
David Sehr709b0702016-10-13 09:12:37 -07001441 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001442 << " could not be inlined because it is using an unresolved"
1443 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001444 return false;
1445 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001446 }
1447 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001448 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001449
David Brazdil3f523062016-02-29 16:53:33 +00001450 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1451 << "No instructions can be added to the outer graph while inner graph is being built";
1452
1453 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1454 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001455 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001456
1457 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1458 << "No instructions can be added to the inner graph during inlining into the outer graph";
1459
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001460 return true;
1461}
Calin Juravle2e768302015-07-28 14:41:11 +00001462
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001463size_t HInliner::RunOptimizations(HGraph* callee_graph,
1464 const DexFile::CodeItem* code_item,
1465 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001466 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1467 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Andreas Gampeca620d72016-11-08 08:09:33 -08001468 HDeadCodeElimination dce(callee_graph, stats_, "dead_code_elimination$inliner");
1469 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001470 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_, handles_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001471 InstructionSimplifier simplify(callee_graph, stats_);
Nicolas Geoffray762869d2016-07-15 15:28:35 +01001472 IntrinsicsRecognizer intrinsics(callee_graph, stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001473
1474 HOptimization* optimizations[] = {
1475 &intrinsics,
1476 &sharpening,
1477 &simplify,
1478 &fold,
1479 &dce,
1480 };
1481
1482 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1483 HOptimization* optimization = optimizations[i];
1484 optimization->Run();
1485 }
1486
1487 size_t number_of_inlined_instructions = 0u;
1488 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1489 HInliner inliner(callee_graph,
1490 outermost_graph_,
1491 codegen_,
1492 outer_compilation_unit_,
1493 dex_compilation_unit,
1494 compiler_driver_,
1495 handles_,
1496 stats_,
1497 total_number_of_dex_registers_ + code_item->registers_size_,
1498 depth_ + 1);
1499 inliner.Run();
1500 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1501 }
1502
1503 return number_of_inlined_instructions;
1504}
1505
David Brazdil94ab38f2016-06-21 17:48:19 +01001506static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1507 bool declared_can_be_null,
1508 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001509 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001510 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1511 return true;
1512 }
1513
1514 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1515 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001516 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01001517}
1518
1519ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1520 return ReferenceTypePropagation::IsAdmissible(klass)
1521 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1522 : graph_->GetInexactObjectRti();
1523}
1524
1525bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1526 // If this is an instance call, test whether the type of the `this` argument
1527 // is more specific than the class which declares the method.
1528 if (!resolved_method->IsStatic()) {
1529 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1530 /* declared_can_be_null */ false,
1531 invoke_instruction->InputAt(0u))) {
1532 return true;
1533 }
1534 }
1535
David Brazdil94ab38f2016-06-21 17:48:19 +01001536 // Iterate over the list of parameter types and test whether any of the
1537 // actual inputs has a more specific reference type than the type declared in
1538 // the signature.
1539 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1540 for (size_t param_idx = 0,
1541 input_idx = resolved_method->IsStatic() ? 0 : 1,
1542 e = (param_list == nullptr ? 0 : param_list->Size());
1543 param_idx < e;
1544 ++param_idx, ++input_idx) {
1545 HInstruction* input = invoke_instruction->InputAt(input_idx);
1546 if (input->GetType() == Primitive::kPrimNot) {
Vladimir Marko942fd312017-01-16 20:52:19 +00001547 mirror::Class* param_cls = resolved_method->GetClassFromTypeIndex(
David Brazdil94ab38f2016-06-21 17:48:19 +01001548 param_list->GetTypeItem(param_idx).type_idx_,
Vladimir Marko942fd312017-01-16 20:52:19 +00001549 /* resolve */ false);
David Brazdil94ab38f2016-06-21 17:48:19 +01001550 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1551 /* declared_can_be_null */ true,
1552 input)) {
1553 return true;
1554 }
1555 }
1556 }
1557
1558 return false;
1559}
1560
1561bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1562 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001563 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001564 if (return_replacement != nullptr) {
1565 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001566 // Test if the return type is a refinement of the declared return type.
1567 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1568 /* declared_can_be_null */ true,
1569 return_replacement)) {
1570 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001571 } else if (return_replacement->IsInstanceFieldGet()) {
1572 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
1573 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1574 if (field_get->GetFieldInfo().GetField() ==
1575 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
1576 return true;
1577 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001578 }
1579 } else if (return_replacement->IsInstanceOf()) {
1580 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1581 return true;
1582 }
1583 }
1584
1585 return false;
1586}
1587
1588void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1589 HInstruction* return_replacement) {
1590 if (return_replacement != nullptr) {
1591 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001592 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1593 // Make sure that we have a valid type for the return. We may get an invalid one when
1594 // we inline invokes with multiple branches and create a Phi for the result.
1595 // TODO: we could be more precise by merging the phi inputs but that requires
1596 // some functionality from the reference type propagation.
1597 DCHECK(return_replacement->IsPhi());
Vladimir Marko942fd312017-01-16 20:52:19 +00001598 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */);
David Brazdil94ab38f2016-06-21 17:48:19 +01001599 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001600 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001601 }
Calin Juravle2e768302015-07-28 14:41:11 +00001602 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001603}
1604
1605} // namespace art