blob: fc96075a8d31bd60ca9cac17b9888fe7d8699ca6 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100429 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100430 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100431 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700432 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800433 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100435 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
436 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100437 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
438 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800439 }
buzbee311ca162013-02-28 15:56:43 -0800440 while (bb != NULL) {
441 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
442 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800443 if (use_lvn) {
444 local_valnum->GetValueNumber(mir);
445 }
buzbee311ca162013-02-28 15:56:43 -0800446 // Look for interesting opcodes, skip otherwise
447 Instruction::Code opcode = mir->dalvikInsn.opcode;
448 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000449 case Instruction::IF_EQ:
450 case Instruction::IF_NE:
451 case Instruction::IF_LT:
452 case Instruction::IF_GE:
453 case Instruction::IF_GT:
454 case Instruction::IF_LE:
455 if (!IsConst(mir->ssa_rep->uses[1])) {
456 break;
457 }
458 FALLTHROUGH_INTENDED;
459 case Instruction::IF_EQZ:
460 case Instruction::IF_NEZ:
461 case Instruction::IF_LTZ:
462 case Instruction::IF_GEZ:
463 case Instruction::IF_GTZ:
464 case Instruction::IF_LEZ:
465 // Result known at compile time?
466 if (IsConst(mir->ssa_rep->uses[0])) {
467 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
468 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
469 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
470 if (is_taken) {
471 // Replace with GOTO.
472 bb->fall_through = NullBasicBlockId;
473 mir->dalvikInsn.opcode = Instruction::GOTO;
474 mir->dalvikInsn.vA =
475 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
476 } else {
477 // Make NOP.
478 bb->taken = NullBasicBlockId;
479 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
480 }
481 mir->ssa_rep->num_uses = 0;
482 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
483 successor_to_unlink->ErasePredecessor(bb->id);
484 if (successor_to_unlink->predecessors.empty()) {
485 successor_to_unlink->KillUnreachable(this);
486 }
487 }
488 break;
buzbee311ca162013-02-28 15:56:43 -0800489 case Instruction::CMPL_FLOAT:
490 case Instruction::CMPL_DOUBLE:
491 case Instruction::CMPG_FLOAT:
492 case Instruction::CMPG_DOUBLE:
493 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700494 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800495 // Bitcode doesn't allow this optimization.
496 break;
497 }
498 if (mir->next != NULL) {
499 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800500 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700501 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800502 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
503 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000504 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700505 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800506 case Instruction::CMPL_FLOAT:
507 mir_next->dalvikInsn.opcode =
508 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
509 break;
510 case Instruction::CMPL_DOUBLE:
511 mir_next->dalvikInsn.opcode =
512 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
513 break;
514 case Instruction::CMPG_FLOAT:
515 mir_next->dalvikInsn.opcode =
516 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
517 break;
518 case Instruction::CMPG_DOUBLE:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
521 break;
522 case Instruction::CMP_LONG:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
525 break;
526 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
527 }
528 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800529 // Clear use count of temp VR.
530 use_counts_[mir->ssa_rep->defs[0]] = 0;
531 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700532 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800533 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
534 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
535 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
536 mir_next->ssa_rep->num_defs = 0;
537 mir->ssa_rep->num_uses = 0;
538 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700539 // Copy in the decoded instruction information for potential SSA re-creation.
540 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
541 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800542 }
543 }
544 break;
buzbee311ca162013-02-28 15:56:43 -0800545 default:
546 break;
547 }
548 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800549 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800550 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000551 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100552 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
553 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000554 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700555 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800556 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700557 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
558 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800559
buzbee0d829482013-10-11 15:24:55 -0700560 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800561 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700562 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
563 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800564
565 /*
566 * In the select pattern, the taken edge goes to a block that unconditionally
567 * transfers to the rejoin block and the fall_though edge goes to a block that
568 * unconditionally falls through to the rejoin block.
569 */
570 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
571 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
572 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000573 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800574 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100575
576 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800577 // Are the block bodies something we can handle?
578 if ((ft->first_mir_insn == ft->last_mir_insn) &&
579 (tk->first_mir_insn != tk->last_mir_insn) &&
580 (tk->first_mir_insn->next == tk->last_mir_insn) &&
581 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
582 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
583 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
584 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
585 // Almost there. Are the instructions targeting the same vreg?
586 MIR* if_true = tk->first_mir_insn;
587 MIR* if_false = ft->first_mir_insn;
588 // It's possible that the target of the select isn't used - skip those (rare) cases.
589 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
590 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
591 /*
592 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
593 * Phi node in the merge block and delete it (while using the SSA name
594 * of the merge as the target of the SELECT. Delete both taken and
595 * fallthrough blocks, and set fallthrough to merge block.
596 * NOTE: not updating other dataflow info (no longer used at this point).
597 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
598 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000599 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800600 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
601 bool const_form = (SelectKind(if_true) == kSelectConst);
602 if ((SelectKind(if_true) == kSelectMove)) {
603 if (IsConst(if_true->ssa_rep->uses[0]) &&
604 IsConst(if_false->ssa_rep->uses[0])) {
605 const_form = true;
606 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
607 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
608 }
609 }
610 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800611 /*
612 * TODO: If both constants are the same value, then instead of generating
613 * a select, we should simply generate a const bytecode. This should be
614 * considered after inlining which can lead to CFG of this form.
615 */
buzbee311ca162013-02-28 15:56:43 -0800616 // "true" set val in vB
617 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
618 // "false" set val in vC
619 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
620 } else {
621 DCHECK_EQ(SelectKind(if_true), kSelectMove);
622 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700623 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000624 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800625 src_ssa[0] = mir->ssa_rep->uses[0];
626 src_ssa[1] = if_true->ssa_rep->uses[0];
627 src_ssa[2] = if_false->ssa_rep->uses[0];
628 mir->ssa_rep->uses = src_ssa;
629 mir->ssa_rep->num_uses = 3;
630 }
631 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700632 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000633 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700634 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000635 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800636 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700637 // Match type of uses to def.
638 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700639 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000640 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700641 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
642 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
643 }
buzbee311ca162013-02-28 15:56:43 -0800644 /*
645 * There is usually a Phi node in the join block for our two cases. If the
646 * Phi node only contains our two cases as input, we will use the result
647 * SSA name of the Phi node as our select result and delete the Phi. If
648 * the Phi node has more than two operands, we will arbitrarily use the SSA
649 * name of the "true" path, delete the SSA name of the "false" path from the
650 * Phi node (and fix up the incoming arc list).
651 */
652 if (phi->ssa_rep->num_uses == 2) {
653 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
654 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
655 } else {
656 int dead_def = if_false->ssa_rep->defs[0];
657 int live_def = if_true->ssa_rep->defs[0];
658 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700659 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800660 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
661 if (phi->ssa_rep->uses[i] == live_def) {
662 incoming[i] = bb->id;
663 }
664 }
665 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
666 if (phi->ssa_rep->uses[i] == dead_def) {
667 int last_slot = phi->ssa_rep->num_uses - 1;
668 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
669 incoming[i] = incoming[last_slot];
670 }
671 }
672 }
673 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700674 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800675 tk->block_type = kDead;
676 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
677 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
678 }
679 }
680 }
681 }
682 }
683 }
buzbee1da1e2f2013-11-15 13:37:01 -0800684 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800685 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100686 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100687 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
688 }
buzbee311ca162013-02-28 15:56:43 -0800689
buzbee311ca162013-02-28 15:56:43 -0800690 return true;
691}
692
buzbee311ca162013-02-28 15:56:43 -0800693/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700694void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700695 if (bb->data_flow_info != NULL) {
696 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
697 if (mir->ssa_rep == NULL) {
698 continue;
buzbee311ca162013-02-28 15:56:43 -0800699 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700700 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700701 if (df_attributes & DF_HAS_NULL_CHKS) {
702 checkstats_->null_checks++;
703 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
704 checkstats_->null_checks_eliminated++;
705 }
706 }
707 if (df_attributes & DF_HAS_RANGE_CHKS) {
708 checkstats_->range_checks++;
709 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
710 checkstats_->range_checks_eliminated++;
711 }
buzbee311ca162013-02-28 15:56:43 -0800712 }
713 }
714 }
buzbee311ca162013-02-28 15:56:43 -0800715}
716
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700717/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700718bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700719 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800720 if (!bb->explicit_throw) {
721 return false;
722 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700723
724 // If we visited it, we are done.
725 if (bb->visited) {
726 return false;
727 }
728 bb->visited = true;
729
buzbee311ca162013-02-28 15:56:43 -0800730 BasicBlock* walker = bb;
731 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700732 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800733 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
734 break;
735 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100736 DCHECK(!walker->predecessors.empty());
737 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700738
739 // If we visited the predecessor, we are done.
740 if (prev->visited) {
741 return false;
742 }
743 prev->visited = true;
744
buzbee311ca162013-02-28 15:56:43 -0800745 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700746 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700747 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800748 break;
749 }
buzbee0d829482013-10-11 15:24:55 -0700750 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700751 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800752 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
753 switch (opcode) {
754 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
755 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
756 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
757 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
758 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
759 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
760 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
761 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
762 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
763 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
764 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
765 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
766 default: LOG(FATAL) << "Unexpected opcode " << opcode;
767 }
768 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700769 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800770 prev->taken = prev->fall_through;
771 prev->fall_through = t_bb;
772 break;
773 }
774 walker = prev;
775 }
776 return false;
777}
778
779/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700780void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800781 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100782 while ((bb->block_type == kDalvikByteCode) &&
783 (bb->last_mir_insn != nullptr) &&
784 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
785 MIR* mir = bb->last_mir_insn;
786 DCHECK(bb->first_mir_insn != nullptr);
787
788 // Grab the attributes from the paired opcode.
789 MIR* throw_insn = mir->meta.throw_insn;
790 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
791
792 // Don't combine if the throw_insn can still throw NPE.
793 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
794 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
795 break;
796 }
797 // Now whitelist specific instructions.
798 bool ok = false;
799 if ((df_attributes & DF_IFIELD) != 0) {
800 // Combine only if fast, otherwise weird things can happen.
801 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600802 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100803 } else if ((df_attributes & DF_SFIELD) != 0) {
804 // Combine only if fast, otherwise weird things can happen.
805 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600806 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100807 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100808 bool clinit = !field_info.IsClassInitialized() &&
809 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100810 ok = fast && !clinit;
811 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
812 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
813 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
814 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
815 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
816 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
817 ok = true;
818 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
819 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
820 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
821 // No more checks for these (null check was processed above).
822 ok = true;
823 }
824 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800825 break;
826 }
827
buzbee311ca162013-02-28 15:56:43 -0800828 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700829 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800830 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100831 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700832
833 // Now move instructions from bb_next to bb. Start off with doing a sanity check
834 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800835 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700836 // Now move all instructions (throw instruction to last one) from bb_next to bb.
837 MIR* last_to_move = bb_next->last_mir_insn;
838 bb_next->RemoveMIRList(throw_insn, last_to_move);
839 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
840 // The kMirOpCheck instruction is not needed anymore.
841 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
842 bb->RemoveMIR(mir);
843
Vladimir Marko312eb252014-10-07 15:01:57 +0100844 // Before we overwrite successors, remove their predecessor links to bb.
845 bb_next->ErasePredecessor(bb->id);
846 if (bb->taken != NullBasicBlockId) {
847 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
848 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
849 // bb->taken will be overwritten below.
850 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
851 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
852 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
853 bb_taken->predecessors.clear();
854 bb_taken->block_type = kDead;
855 DCHECK(bb_taken->data_flow_info == nullptr);
856 } else {
857 DCHECK_EQ(bb->successor_block_list_type, kCatch);
858 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
859 if (succ_info->block != NullBasicBlockId) {
860 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
861 DCHECK(succ_bb->catch_entry);
862 succ_bb->ErasePredecessor(bb->id);
863 if (succ_bb->predecessors.empty()) {
864 succ_bb->KillUnreachable(this);
865 }
866 }
867 }
868 }
buzbee311ca162013-02-28 15:56:43 -0800869 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700870 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100871 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100872 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800873 // Use the ending block linkage from the next block
874 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100875 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800876 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100877 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800878 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900879 * If lower-half of pair of blocks to combine contained
880 * a return or a conditional branch or an explicit throw,
881 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800882 */
883 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900884 bb->conditional_branch = bb_next->conditional_branch;
885 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100886 // Merge the use_lvn flag.
887 bb->use_lvn |= bb_next->use_lvn;
888
889 // Kill the unused block.
890 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800891
892 /*
893 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
894 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100895 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800896 */
897
Vladimir Marko312eb252014-10-07 15:01:57 +0100898 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800899 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100900 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700901 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100902 // Update predecessors in children.
903 ChildBlockIterator iter(bb, this);
904 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
905 child->UpdatePredecessor(bb_next->id, bb->id);
906 }
907
908 // DFS orders are not up to date anymore.
909 dfs_orders_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800910
911 // Now, loop back and see if we can keep going
912 }
buzbee311ca162013-02-28 15:56:43 -0800913}
914
Vladimir Marko67c72b82014-10-09 12:26:10 +0100915bool MIRGraph::EliminateNullChecksGate() {
916 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
917 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
918 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000919 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100920
Vladimir Marko67c72b82014-10-09 12:26:10 +0100921 DCHECK(temp_scoped_alloc_.get() == nullptr);
922 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700923 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000924 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
925 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
926 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100927 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000928 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700929
930 // reset MIR_MARK
931 AllNodesIterator iter(this);
932 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
933 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
934 mir->optimization_flags &= ~MIR_MARK;
935 }
936 }
937
Vladimir Marko67c72b82014-10-09 12:26:10 +0100938 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000939}
940
buzbee1da1e2f2013-11-15 13:37:01 -0800941/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100942 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800943 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100944bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100945 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
946 // Ignore the kExitBlock as well.
947 DCHECK(bb->first_mir_insn == nullptr);
948 return false;
949 }
buzbee311ca162013-02-28 15:56:43 -0800950
Vladimir Markof585e542014-11-21 13:41:32 +0000951 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100952 /*
953 * Set initial state. Catch blocks don't need any special treatment.
954 */
955 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100956 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100957 // Assume all ins are objects.
958 for (uint16_t in_reg = GetFirstInVR();
959 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100960 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100961 }
962 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100963 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100964 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100965 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100966 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100967 } else {
968 DCHECK_EQ(bb->block_type, kDalvikByteCode);
969 // Starting state is union of all incoming arcs.
970 bool copied_first = false;
971 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000972 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100973 continue;
974 }
975 BasicBlock* pred_bb = GetBasicBlock(pred_id);
976 DCHECK(pred_bb != nullptr);
977 MIR* null_check_insn = nullptr;
978 if (pred_bb->block_type == kDalvikByteCode) {
979 // Check to see if predecessor had an explicit null-check.
980 MIR* last_insn = pred_bb->last_mir_insn;
981 if (last_insn != nullptr) {
982 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
983 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
984 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
985 // Remember the null check insn if there's no other predecessor requiring null check.
986 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
987 null_check_insn = last_insn;
988 }
buzbee1da1e2f2013-11-15 13:37:01 -0800989 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700990 }
991 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100992 if (!copied_first) {
993 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000994 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100995 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000996 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100997 }
998 if (null_check_insn != nullptr) {
999 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001000 }
1001 }
1002 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -08001003 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001004 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +01001005 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -08001006
1007 // Walk through the instruction in the block, updating as necessary
1008 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -07001009 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -08001010
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -07001011 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
1012 // The algorithm was written in a phi agnostic way.
1013 continue;
1014 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001015
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001016 // Might need a null check?
1017 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001018 int src_vreg;
1019 if (df_attributes & DF_NULL_CHK_OUT0) {
1020 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
1021 src_vreg = mir->dalvikInsn.vC;
1022 } else if (df_attributes & DF_NULL_CHK_B) {
1023 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1024 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001025 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001026 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1027 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1028 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001029 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001030 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001031 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001032 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001033 } else {
1034 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001035 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001036 // Mark src_vreg as null-checked.
1037 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001038 }
1039 }
1040
1041 if ((df_attributes & DF_A_WIDE) ||
1042 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1043 continue;
1044 }
1045
1046 /*
1047 * First, mark all object definitions as requiring null check.
1048 * Note: we can't tell if a CONST definition might be used as an object, so treat
1049 * them all as object definitions.
1050 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001051 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001052 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001053 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001054 }
1055
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001056 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001057 if (df_attributes & DF_NON_NULL_DST) {
1058 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001059 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1060 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001061 }
1062
buzbee311ca162013-02-28 15:56:43 -08001063 // Mark non-null returns from invoke-style NEW*
1064 if (df_attributes & DF_NON_NULL_RET) {
1065 MIR* next_mir = mir->next;
1066 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001067 if (UNLIKELY(next_mir == nullptr)) {
1068 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1069 // target, so the MOVE_RESULT cannot be broken away into another block.
1070 LOG(WARNING) << "Unexpected end of block following new";
1071 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1072 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001073 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001074 // Mark as null checked.
1075 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001076 }
1077 }
1078
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001079 // Propagate null check state on register copies.
1080 if (df_attributes & DF_NULL_TRANSFER_0) {
1081 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1082 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1083 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001084 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001085 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001086 }
1087 }
buzbee311ca162013-02-28 15:56:43 -08001088 }
1089
1090 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001091 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001092 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001093 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001094 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001095 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001096 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001097 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001098 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1099 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001100 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001101 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001102 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1103 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001104 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001105 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001106}
1107
Vladimir Marko67c72b82014-10-09 12:26:10 +01001108void MIRGraph::EliminateNullChecksEnd() {
1109 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001110 temp_.nce.num_vregs = 0u;
1111 temp_.nce.work_vregs_to_check = nullptr;
1112 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001113 DCHECK(temp_scoped_alloc_.get() != nullptr);
1114 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001115
1116 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001117 AllNodesIterator iter(this);
1118 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1119 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001120 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001121 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001122 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001123 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001124 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1125 }
1126 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001127}
1128
1129/*
1130 * Perform type and size inference for a basic block.
1131 */
1132bool MIRGraph::InferTypes(BasicBlock* bb) {
1133 if (bb->data_flow_info == nullptr) return false;
1134
1135 bool infer_changed = false;
1136 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1137 if (mir->ssa_rep == NULL) {
1138 continue;
1139 }
1140
1141 // Propagate type info.
1142 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1143 }
1144
1145 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001146}
1147
1148bool MIRGraph::EliminateClassInitChecksGate() {
1149 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001150 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001151 return false;
1152 }
1153
Vladimir Markobfea9c22014-01-17 17:49:33 +00001154 DCHECK(temp_scoped_alloc_.get() == nullptr);
1155 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1156
1157 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001158 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001159 temp_.cice.indexes = static_cast<uint16_t*>(
1160 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1161 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001162
1163 uint32_t unique_class_count = 0u;
1164 {
1165 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1166 // ScopedArenaAllocator.
1167
1168 // Embed the map value in the entry to save space.
1169 struct MapEntry {
1170 // Map key: the class identified by the declaring dex file and type index.
1171 const DexFile* declaring_dex_file;
1172 uint16_t declaring_class_idx;
1173 // Map value: index into bit vectors of classes requiring initialization checks.
1174 uint16_t index;
1175 };
1176 struct MapEntryComparator {
1177 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1178 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1179 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1180 }
1181 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1182 }
1183 };
1184
Vladimir Markobfea9c22014-01-17 17:49:33 +00001185 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001186 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1187 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001188
1189 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1190 AllNodesIterator iter(this);
1191 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001192 if (bb->block_type == kDalvikByteCode) {
1193 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001194 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001195 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001196 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001197 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1198 MapEntry entry = {
1199 // Treat unresolved fields as if each had its own class.
1200 field_info.IsResolved() ? field_info.DeclaringDexFile()
1201 : nullptr,
1202 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1203 : field_info.FieldIndex(),
1204 static_cast<uint16_t>(class_to_index_map.size())
1205 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001206 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001207 // Using offset/2 for index into temp_.cice.indexes.
1208 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001209 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001210 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001211 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1212 DCHECK(method_info.IsStatic());
1213 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1214 MapEntry entry = {
1215 method_info.DeclaringDexFile(),
1216 method_info.DeclaringClassIndex(),
1217 static_cast<uint16_t>(class_to_index_map.size())
1218 };
1219 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001220 // Using offset/2 for index into temp_.cice.indexes.
1221 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001222 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001223 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001224 }
1225 }
1226 }
1227 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1228 }
1229
1230 if (unique_class_count == 0u) {
1231 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001232 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001233 temp_scoped_alloc_.reset();
1234 return false;
1235 }
1236
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001237 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001238 temp_.cice.num_class_bits = 2u * unique_class_count;
1239 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1240 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1241 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001242 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001243 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1244 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001245 return true;
1246}
1247
1248/*
1249 * Eliminate unnecessary class initialization checks for a basic block.
1250 */
1251bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1252 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001253 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1254 // Ignore the kExitBlock as well.
1255 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001256 return false;
1257 }
1258
1259 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001260 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001261 */
Vladimir Markof585e542014-11-21 13:41:32 +00001262 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001263 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001264 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001265 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001266 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001267 // Starting state is union of all incoming arcs.
1268 bool copied_first = false;
1269 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001270 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001271 continue;
1272 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001273 if (!copied_first) {
1274 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001275 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001276 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001277 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001278 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001279 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001280 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001281 }
1282 // At this point, classes_to_check shows which classes need clinit checks.
1283
1284 // Walk through the instruction in the block, updating as necessary
1285 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001286 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001287 if (index != 0xffffu) {
1288 bool check_initialization = false;
1289 bool check_dex_cache = false;
1290
1291 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1292 // Dex instructions with width 1 can have the same offset/2.
1293
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001294 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001295 check_initialization = true;
1296 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001297 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001298 check_initialization = true;
1299 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1300 }
1301
1302 if (check_dex_cache) {
1303 uint32_t check_dex_cache_index = 2u * index + 1u;
1304 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1305 // Eliminate the class init check.
1306 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1307 } else {
1308 // Do the class init check.
1309 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1310 }
1311 classes_to_check->ClearBit(check_dex_cache_index);
1312 }
1313 if (check_initialization) {
1314 uint32_t check_clinit_index = 2u * index;
1315 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1316 // Eliminate the class init check.
1317 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1318 } else {
1319 // Do the class init check.
1320 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001321 }
1322 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001323 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001324 }
1325 }
1326 }
1327
1328 // Did anything change?
1329 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001330 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001331 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001332 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001333 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001334 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001335 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001336 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1337 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001338 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001339 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001340 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1341 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001342 }
1343 return changed;
1344}
1345
1346void MIRGraph::EliminateClassInitChecksEnd() {
1347 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001348 temp_.cice.num_class_bits = 0u;
1349 temp_.cice.work_classes_to_check = nullptr;
1350 temp_.cice.ending_classes_to_check_matrix = nullptr;
1351 DCHECK(temp_.cice.indexes != nullptr);
1352 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001353 DCHECK(temp_scoped_alloc_.get() != nullptr);
1354 temp_scoped_alloc_.reset();
1355}
1356
Vladimir Marko95a05972014-05-30 10:01:32 +01001357bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001358 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001359 return false;
1360 }
1361
1362 DCHECK(temp_scoped_alloc_ == nullptr);
1363 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001364 temp_.gvn.ifield_ids_ =
1365 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1366 temp_.gvn.sfield_ids_ =
1367 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001368 DCHECK(temp_.gvn.gvn == nullptr);
1369 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1370 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001371 return true;
1372}
1373
1374bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001375 DCHECK(temp_.gvn.gvn != nullptr);
1376 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001377 if (lvn != nullptr) {
1378 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1379 lvn->GetValueNumber(mir);
1380 }
1381 }
Vladimir Markof585e542014-11-21 13:41:32 +00001382 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001383 return change;
1384}
1385
1386void MIRGraph::ApplyGlobalValueNumberingEnd() {
1387 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001388 DCHECK(temp_.gvn.gvn != nullptr);
1389 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001390 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001391 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001392 TopologicalSortIterator iter(this);
1393 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1394 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001395 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001396 if (lvn != nullptr) {
1397 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1398 lvn->GetValueNumber(mir);
1399 }
Vladimir Markof585e542014-11-21 13:41:32 +00001400 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001401 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001402 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001403 }
1404 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001405 // GVN was successful, running the LVN would be useless.
1406 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001407 } else {
1408 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1409 }
1410
Vladimir Markof585e542014-11-21 13:41:32 +00001411 delete temp_.gvn.gvn;
1412 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001413 temp_.gvn.ifield_ids_ = nullptr;
1414 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001415 DCHECK(temp_scoped_alloc_ != nullptr);
1416 temp_scoped_alloc_.reset();
1417}
1418
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001419void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1420 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001421 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1422 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001423 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1424 return;
1425 }
1426
1427 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1428 MethodReference target = method_info.GetTargetMethod();
1429 DexCompilationUnit inlined_unit(
1430 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1431 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1432 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001433 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1434 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001435 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1436 DCHECK(inlined_field_info.IsResolved());
1437
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001438 uint32_t field_info_index = ifield_lowering_infos_.size();
1439 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001440 temp_.smi.processed_indexes->SetBit(method_index);
1441 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001442 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1443}
1444
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001445bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001446 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001447 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001448 return false;
1449 }
1450 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1451 // This isn't the Quick compiler.
1452 return false;
1453 }
1454 return true;
1455}
1456
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001457void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001458 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1459 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1460
1461 DCHECK(temp_scoped_alloc_.get() == nullptr);
1462 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001463 temp_.smi.num_indexes = method_lowering_infos_.size();
1464 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1465 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1466 temp_.smi.processed_indexes->ClearAllBits();
1467 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1468 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001469}
1470
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001471void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001472 if (bb->block_type != kDalvikByteCode) {
1473 return;
1474 }
1475 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001476 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001477 continue;
1478 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001479 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001480 continue;
1481 }
1482 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1483 if (!method_info.FastPath()) {
1484 continue;
1485 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001486
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001487 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001488 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001489 continue;
1490 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001491
1492 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001493 bool needs_clinit = !method_info.IsClassInitialized() &&
1494 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001495 if (needs_clinit) {
1496 continue;
1497 }
1498 }
1499
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001500 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1501 MethodReference target = method_info.GetTargetMethod();
1502 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1503 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001504 if (cu_->verbose || cu_->print_pass) {
1505 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1506 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1507 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1508 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001509 }
1510 }
1511 }
1512}
1513
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001514void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001515 // Clean up temporaries.
1516 DCHECK(temp_.smi.lowering_infos != nullptr);
1517 temp_.smi.lowering_infos = nullptr;
1518 temp_.smi.num_indexes = 0u;
1519 DCHECK(temp_.smi.processed_indexes != nullptr);
1520 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001521 DCHECK(temp_scoped_alloc_.get() != nullptr);
1522 temp_scoped_alloc_.reset();
1523}
1524
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001525void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001526 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001527 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001528 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001529 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001530 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1531 CountChecks(bb);
1532 }
1533 if (stats->null_checks > 0) {
1534 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1535 float checks = static_cast<float>(stats->null_checks);
1536 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1537 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1538 << (eliminated/checks) * 100.0 << "%";
1539 }
1540 if (stats->range_checks > 0) {
1541 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1542 float checks = static_cast<float>(stats->range_checks);
1543 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1544 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1545 << (eliminated/checks) * 100.0 << "%";
1546 }
1547}
1548
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001549bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001550 if (bb->visited) return false;
1551 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1552 || (bb->block_type == kExitBlock))) {
1553 // Ignore special blocks
1554 bb->visited = true;
1555 return false;
1556 }
1557 // Must be head of extended basic block.
1558 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001559 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001560 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001561 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001562 // Visit blocks strictly dominated by this head.
1563 while (bb != NULL) {
1564 bb->visited = true;
1565 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001566 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001567 bb = NextDominatedBlock(bb);
1568 }
buzbee1da1e2f2013-11-15 13:37:01 -08001569 if (terminated_by_return || do_local_value_numbering) {
1570 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001571 bb = start_bb;
1572 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001573 bb->use_lvn = do_local_value_numbering;
1574 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001575 bb = NextDominatedBlock(bb);
1576 }
1577 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001578 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001579}
1580
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001581void MIRGraph::BasicBlockOptimization() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001582 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1583 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1584 temp_.gvn.ifield_ids_ =
1585 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1586 temp_.gvn.sfield_ids_ =
1587 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1588 }
1589
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001590 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1591 ClearAllVisitedFlags();
1592 PreOrderDfsIterator iter2(this);
1593 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1594 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001595 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001596 // Perform extended basic block optimizations.
1597 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1598 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1599 }
1600 } else {
1601 PreOrderDfsIterator iter(this);
1602 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1603 BasicBlockOpt(bb);
1604 }
buzbee311ca162013-02-28 15:56:43 -08001605 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001606
1607 // Clean up after LVN.
1608 temp_.gvn.ifield_ids_ = nullptr;
1609 temp_.gvn.sfield_ids_ = nullptr;
1610 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001611}
1612
Vladimir Marko8b858e12014-11-27 14:52:37 +00001613bool MIRGraph::EliminateSuspendChecksGate() {
1614 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1615 GetMaxNestedLoops() == 0u || // Nothing to do.
1616 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1617 // Exclude 32 as well to keep bit shifts well-defined.
1618 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1619 return false;
1620 }
1621 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1622 temp_.sce.inliner =
1623 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1624 }
1625 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1626 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1627 return true;
1628}
1629
1630bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1631 if (bb->block_type != kDalvikByteCode) {
1632 return false;
1633 }
1634 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1635 if (bb->nesting_depth == 0u) {
1636 // Out of loops.
1637 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1638 return false;
1639 }
1640 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1641 bool found_invoke = false;
1642 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1643 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1644 (temp_.sce.inliner == nullptr ||
1645 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1646 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1647 found_invoke = true;
1648 break;
1649 }
1650 }
1651 if (!found_invoke) {
1652 // Intersect suspend checks from predecessors.
1653 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1654 uint32_t pred_mask_union = 0u;
1655 for (BasicBlockId pred_id : bb->predecessors) {
1656 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1657 if (pred_topo_idx < bb_topo_idx) {
1658 // Determine the loop depth of the predecessors relative to this block.
1659 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1660 while (pred_loop_depth != 0u &&
1661 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1662 --pred_loop_depth;
1663 }
1664 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1665 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1666 // Intersect pred_mask bits in suspend_checks_in_loops with
1667 // suspend_checks_in_loops_[pred_id].
1668 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1669 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1670 pred_mask_union |= pred_mask;
1671 }
1672 }
1673 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1674 pred_mask_union);
1675 suspend_checks_in_loops &= pred_mask_union;
1676 }
1677 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1678 if (suspend_checks_in_loops == 0u) {
1679 return false;
1680 }
1681 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1682 if (bb->taken != NullBasicBlockId) {
1683 DCHECK(bb->last_mir_insn != nullptr);
1684 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1685 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1686 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1687 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1688 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1689 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1690 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1691 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1692 }
1693 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1694 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1695 MIR* mir = NewMIR();
1696 mir->dalvikInsn.opcode = Instruction::GOTO;
1697 mir->dalvikInsn.vA = 0; // Branch offset.
1698 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1699 mir->m_unit_index = current_method_;
1700 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1701 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1702 bb->AppendMIR(mir);
1703 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1704 }
1705 return true;
1706}
1707
1708void MIRGraph::EliminateSuspendChecksEnd() {
1709 temp_.sce.inliner = nullptr;
1710}
1711
buzbee311ca162013-02-28 15:56:43 -08001712} // namespace art