blob: 41f63c15a070cc26205f1b1bc0c9d512315944cf [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010019#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080020#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070021#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010022#include "dex/global_value_numbering.h"
Vladimir Marko9820b7c2014-01-02 16:40:37 +000023#include "dex/quick/dex_file_method_inliner.h"
24#include "dex/quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800189 switch (mir->dalvikInsn.opcode) {
190 case Instruction::MOVE:
191 case Instruction::MOVE_OBJECT:
192 case Instruction::MOVE_16:
193 case Instruction::MOVE_OBJECT_16:
194 case Instruction::MOVE_FROM16:
195 case Instruction::MOVE_OBJECT_FROM16:
196 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700197 case Instruction::CONST:
198 case Instruction::CONST_4:
199 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800200 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::GOTO:
202 case Instruction::GOTO_16:
203 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700205 default:
206 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800207 }
buzbee311ca162013-02-28 15:56:43 -0800208}
209
Vladimir Markoa1a70742014-03-03 10:28:05 +0000210static constexpr ConditionCode kIfCcZConditionCodes[] = {
211 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
212};
213
214COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
215 if_ccz_ccodes_size1);
216
217static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
218 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
219}
220
221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
225COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
226COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
227COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
228COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
229COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
230COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
402/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700403bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800404 if (bb->block_type == kDead) {
405 return true;
406 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100407 // Don't do a separate LVN if we did the GVN.
Vladimir Marko55fff042014-07-10 12:42:52 +0100408 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kGlobalValueNumbering)) != 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100409 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100410 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700411 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800412 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100413 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko95a05972014-05-30 10:01:32 +0100414 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get()));
Vladimir Markob19955d2014-07-29 12:04:10 +0100415 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
416 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800417 }
buzbee311ca162013-02-28 15:56:43 -0800418 while (bb != NULL) {
419 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
420 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800421 if (use_lvn) {
422 local_valnum->GetValueNumber(mir);
423 }
buzbee311ca162013-02-28 15:56:43 -0800424 // Look for interesting opcodes, skip otherwise
425 Instruction::Code opcode = mir->dalvikInsn.opcode;
426 switch (opcode) {
427 case Instruction::CMPL_FLOAT:
428 case Instruction::CMPL_DOUBLE:
429 case Instruction::CMPG_FLOAT:
430 case Instruction::CMPG_DOUBLE:
431 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700432 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800433 // Bitcode doesn't allow this optimization.
434 break;
435 }
436 if (mir->next != NULL) {
437 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800438 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700439 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800440 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
441 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000442 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700443 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800444 case Instruction::CMPL_FLOAT:
445 mir_next->dalvikInsn.opcode =
446 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
447 break;
448 case Instruction::CMPL_DOUBLE:
449 mir_next->dalvikInsn.opcode =
450 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
451 break;
452 case Instruction::CMPG_FLOAT:
453 mir_next->dalvikInsn.opcode =
454 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
455 break;
456 case Instruction::CMPG_DOUBLE:
457 mir_next->dalvikInsn.opcode =
458 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
459 break;
460 case Instruction::CMP_LONG:
461 mir_next->dalvikInsn.opcode =
462 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
463 break;
464 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
465 }
466 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700467 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800468 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
469 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
470 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
471 mir_next->ssa_rep->num_defs = 0;
472 mir->ssa_rep->num_uses = 0;
473 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700474 // Copy in the decoded instruction information for potential SSA re-creation.
475 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
476 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800477 }
478 }
479 break;
480 case Instruction::GOTO:
481 case Instruction::GOTO_16:
482 case Instruction::GOTO_32:
483 case Instruction::IF_EQ:
484 case Instruction::IF_NE:
485 case Instruction::IF_LT:
486 case Instruction::IF_GE:
487 case Instruction::IF_GT:
488 case Instruction::IF_LE:
489 case Instruction::IF_EQZ:
490 case Instruction::IF_NEZ:
491 case Instruction::IF_LTZ:
492 case Instruction::IF_GEZ:
493 case Instruction::IF_GTZ:
494 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700495 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700496 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
497 (IsBackedge(bb, bb->fall_through) &&
498 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800499 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
500 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700501 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
502 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800503 }
504 }
505 break;
506 default:
507 break;
508 }
509 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800510 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800511 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000512 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100513 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
514 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000515 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700516 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800517 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700518 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
519 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800520
buzbee0d829482013-10-11 15:24:55 -0700521 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800522 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700523 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
524 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800525
526 /*
527 * In the select pattern, the taken edge goes to a block that unconditionally
528 * transfers to the rejoin block and the fall_though edge goes to a block that
529 * unconditionally falls through to the rejoin block.
530 */
531 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
532 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
533 /*
534 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
535 * suspend check on the taken-taken branch back to the join point.
536 */
537 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
538 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
539 }
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100540
541 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800542 // Are the block bodies something we can handle?
543 if ((ft->first_mir_insn == ft->last_mir_insn) &&
544 (tk->first_mir_insn != tk->last_mir_insn) &&
545 (tk->first_mir_insn->next == tk->last_mir_insn) &&
546 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
547 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
548 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
549 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
550 // Almost there. Are the instructions targeting the same vreg?
551 MIR* if_true = tk->first_mir_insn;
552 MIR* if_false = ft->first_mir_insn;
553 // It's possible that the target of the select isn't used - skip those (rare) cases.
554 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
555 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
556 /*
557 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
558 * Phi node in the merge block and delete it (while using the SSA name
559 * of the merge as the target of the SELECT. Delete both taken and
560 * fallthrough blocks, and set fallthrough to merge block.
561 * NOTE: not updating other dataflow info (no longer used at this point).
562 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
563 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000564 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800565 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
566 bool const_form = (SelectKind(if_true) == kSelectConst);
567 if ((SelectKind(if_true) == kSelectMove)) {
568 if (IsConst(if_true->ssa_rep->uses[0]) &&
569 IsConst(if_false->ssa_rep->uses[0])) {
570 const_form = true;
571 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
572 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
573 }
574 }
575 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800576 /*
577 * TODO: If both constants are the same value, then instead of generating
578 * a select, we should simply generate a const bytecode. This should be
579 * considered after inlining which can lead to CFG of this form.
580 */
buzbee311ca162013-02-28 15:56:43 -0800581 // "true" set val in vB
582 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
583 // "false" set val in vC
584 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
585 } else {
586 DCHECK_EQ(SelectKind(if_true), kSelectMove);
587 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700588 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000589 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800590 src_ssa[0] = mir->ssa_rep->uses[0];
591 src_ssa[1] = if_true->ssa_rep->uses[0];
592 src_ssa[2] = if_false->ssa_rep->uses[0];
593 mir->ssa_rep->uses = src_ssa;
594 mir->ssa_rep->num_uses = 3;
595 }
596 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700597 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000598 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700599 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000600 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800601 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700602 // Match type of uses to def.
603 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700604 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000605 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700606 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
607 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
608 }
buzbee311ca162013-02-28 15:56:43 -0800609 /*
610 * There is usually a Phi node in the join block for our two cases. If the
611 * Phi node only contains our two cases as input, we will use the result
612 * SSA name of the Phi node as our select result and delete the Phi. If
613 * the Phi node has more than two operands, we will arbitrarily use the SSA
614 * name of the "true" path, delete the SSA name of the "false" path from the
615 * Phi node (and fix up the incoming arc list).
616 */
617 if (phi->ssa_rep->num_uses == 2) {
618 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
619 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
620 } else {
621 int dead_def = if_false->ssa_rep->defs[0];
622 int live_def = if_true->ssa_rep->defs[0];
623 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700624 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800625 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
626 if (phi->ssa_rep->uses[i] == live_def) {
627 incoming[i] = bb->id;
628 }
629 }
630 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
631 if (phi->ssa_rep->uses[i] == dead_def) {
632 int last_slot = phi->ssa_rep->num_uses - 1;
633 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
634 incoming[i] = incoming[last_slot];
635 }
636 }
637 }
638 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700639 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800640 tk->block_type = kDead;
641 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
642 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
643 }
644 }
645 }
646 }
647 }
648 }
buzbee1da1e2f2013-11-15 13:37:01 -0800649 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800650 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100651 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100652 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
653 }
buzbee311ca162013-02-28 15:56:43 -0800654
buzbee311ca162013-02-28 15:56:43 -0800655 return true;
656}
657
buzbee311ca162013-02-28 15:56:43 -0800658/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700659void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700660 if (bb->data_flow_info != NULL) {
661 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
662 if (mir->ssa_rep == NULL) {
663 continue;
buzbee311ca162013-02-28 15:56:43 -0800664 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700665 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700666 if (df_attributes & DF_HAS_NULL_CHKS) {
667 checkstats_->null_checks++;
668 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
669 checkstats_->null_checks_eliminated++;
670 }
671 }
672 if (df_attributes & DF_HAS_RANGE_CHKS) {
673 checkstats_->range_checks++;
674 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
675 checkstats_->range_checks_eliminated++;
676 }
buzbee311ca162013-02-28 15:56:43 -0800677 }
678 }
679 }
buzbee311ca162013-02-28 15:56:43 -0800680}
681
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700682/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700683bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700684 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800685 if (!bb->explicit_throw) {
686 return false;
687 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700688
689 // If we visited it, we are done.
690 if (bb->visited) {
691 return false;
692 }
693 bb->visited = true;
694
buzbee311ca162013-02-28 15:56:43 -0800695 BasicBlock* walker = bb;
696 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700697 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800698 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
699 break;
700 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100701 DCHECK(!walker->predecessors.empty());
702 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700703
704 // If we visited the predecessor, we are done.
705 if (prev->visited) {
706 return false;
707 }
708 prev->visited = true;
709
buzbee311ca162013-02-28 15:56:43 -0800710 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700711 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700712 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800713 break;
714 }
buzbee0d829482013-10-11 15:24:55 -0700715 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700716 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800717 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
718 switch (opcode) {
719 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
720 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
721 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
722 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
723 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
724 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
725 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
726 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
727 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
728 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
729 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
730 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
731 default: LOG(FATAL) << "Unexpected opcode " << opcode;
732 }
733 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700734 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800735 prev->taken = prev->fall_through;
736 prev->fall_through = t_bb;
737 break;
738 }
739 walker = prev;
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700740
741 if (walker->visited) {
742 break;
743 }
buzbee311ca162013-02-28 15:56:43 -0800744 }
745 return false;
746}
747
748/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800749void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800750 // Loop here to allow combining a sequence of blocks
751 while (true) {
752 // Check termination conditions
753 if ((bb->first_mir_insn == NULL)
754 || (bb->data_flow_info == NULL)
755 || (bb->block_type == kExceptionHandling)
756 || (bb->block_type == kExitBlock)
757 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700758 || (bb->taken == NullBasicBlockId)
759 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
760 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800761 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
762 break;
763 }
764
765 // Test the kMirOpCheck instruction
766 MIR* mir = bb->last_mir_insn;
767 // Grab the attributes from the paired opcode
768 MIR* throw_insn = mir->meta.throw_insn;
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700769 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
buzbee311ca162013-02-28 15:56:43 -0800770 bool can_combine = true;
771 if (df_attributes & DF_HAS_NULL_CHKS) {
772 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
773 }
774 if (df_attributes & DF_HAS_RANGE_CHKS) {
775 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
776 }
777 if (!can_combine) {
778 break;
779 }
780 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700781 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800782 DCHECK(!bb_next->catch_entry);
783 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800784 // Overwrite the kOpCheck insn with the paired opcode
785 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
786 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800787 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700788 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100789 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
buzbee311ca162013-02-28 15:56:43 -0800790 // Use the ending block linkage from the next block
791 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700792 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800793 bb->taken = bb_next->taken;
794 // Include the rest of the instructions
795 bb->last_mir_insn = bb_next->last_mir_insn;
796 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900797 * If lower-half of pair of blocks to combine contained
798 * a return or a conditional branch or an explicit throw,
799 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800800 */
801 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900802 bb->conditional_branch = bb_next->conditional_branch;
803 bb->explicit_throw = bb_next->explicit_throw;
buzbee311ca162013-02-28 15:56:43 -0800804
805 /*
806 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
807 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
808 */
809
810 // Kill bb_next and remap now-dead id to parent
811 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700812 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800813
814 // Now, loop back and see if we can keep going
815 }
buzbee311ca162013-02-28 15:56:43 -0800816}
817
Vladimir Markobfea9c22014-01-17 17:49:33 +0000818void MIRGraph::EliminateNullChecksAndInferTypesStart() {
819 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
820 if (kIsDebugBuild) {
821 AllNodesIterator iter(this);
822 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
823 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
824 }
825 }
826
827 DCHECK(temp_scoped_alloc_.get() == nullptr);
828 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
829 temp_bit_vector_size_ = GetNumSSARegs();
830 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
831 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
832 }
833}
834
buzbee1da1e2f2013-11-15 13:37:01 -0800835/*
836 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
837 * an iterative walk go ahead and perform type and size inference.
838 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800839bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800840 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800841 bool infer_changed = false;
842 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800843
Vladimir Markobfea9c22014-01-17 17:49:33 +0000844 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800845 if (do_nce) {
846 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +0100847 * Set initial state. Catch blocks don't need any special treatment.
buzbee1da1e2f2013-11-15 13:37:01 -0800848 */
Vladimir Marko0a810d22014-07-11 14:44:36 +0100849 if (bb->block_type == kEntryBlock) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000850 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800851 // Assume all ins are objects.
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700852 for (uint16_t in_reg = GetFirstInVR();
853 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000854 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800855 }
856 if ((cu_->access_flags & kAccStatic) == 0) {
857 // If non-static method, mark "this" as non-null
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700858 int this_reg = GetFirstInVR();
Vladimir Markobfea9c22014-01-17 17:49:33 +0000859 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800860 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100861 } else if (bb->predecessors.size() == 1) {
862 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors[0]);
Vladimir Markobfea9c22014-01-17 17:49:33 +0000863 // pred_bb must have already been processed at least once.
864 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
865 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800866 if (pred_bb->block_type == kDalvikByteCode) {
867 // Check to see if predecessor had an explicit null-check.
868 MIR* last_insn = pred_bb->last_mir_insn;
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -0700869 if (last_insn != nullptr) {
870 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
871 if (last_opcode == Instruction::IF_EQZ) {
872 if (pred_bb->fall_through == bb->id) {
873 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
874 // it can't be null.
875 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
876 }
877 } else if (last_opcode == Instruction::IF_NEZ) {
878 if (pred_bb->taken == bb->id) {
879 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
880 // null.
881 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
882 }
buzbee1da1e2f2013-11-15 13:37:01 -0800883 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700884 }
885 }
buzbee1da1e2f2013-11-15 13:37:01 -0800886 } else {
887 // Starting state is union of all incoming arcs
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100888 bool copied_first = false;
889 for (BasicBlockId pred_id : bb->predecessors) {
890 BasicBlock* pred_bb = GetBasicBlock(pred_id);
Vladimir Markobfea9c22014-01-17 17:49:33 +0000891 DCHECK(pred_bb != nullptr);
892 DCHECK(pred_bb->data_flow_info != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +0000893 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800894 continue;
895 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100896 if (!copied_first) {
897 copied_first = true;
898 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
899 } else {
900 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
901 }
buzbee311ca162013-02-28 15:56:43 -0800902 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100903 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800904 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000905 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800906 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800907 }
908
909 // Walk through the instruction in the block, updating as necessary
910 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
911 if (mir->ssa_rep == NULL) {
912 continue;
913 }
buzbee1da1e2f2013-11-15 13:37:01 -0800914
915 // Propagate type info.
916 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
917 if (!do_nce) {
918 continue;
919 }
920
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700921 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800922
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000923 // Might need a null check?
924 if (df_attributes & DF_HAS_NULL_CHKS) {
925 int src_idx;
926 if (df_attributes & DF_NULL_CHK_1) {
927 src_idx = 1;
928 } else if (df_attributes & DF_NULL_CHK_2) {
929 src_idx = 2;
930 } else {
931 src_idx = 0;
932 }
933 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000934 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000935 // Eliminate the null check.
936 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
937 } else {
938 // Do the null check.
939 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
940 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000941 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000942 }
943 }
944
945 if ((df_attributes & DF_A_WIDE) ||
946 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
947 continue;
948 }
949
950 /*
951 * First, mark all object definitions as requiring null check.
952 * Note: we can't tell if a CONST definition might be used as an object, so treat
953 * them all as object definitions.
954 */
955 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
956 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000957 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700958 }
959
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000960 // Now, remove mark from all object definitions we know are non-null.
961 if (df_attributes & DF_NON_NULL_DST) {
962 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000963 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000964 }
965
buzbee311ca162013-02-28 15:56:43 -0800966 // Mark non-null returns from invoke-style NEW*
967 if (df_attributes & DF_NON_NULL_RET) {
968 MIR* next_mir = mir->next;
969 // Next should be an MOVE_RESULT_OBJECT
970 if (next_mir &&
971 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
972 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000973 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800974 } else {
975 if (next_mir) {
976 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700977 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800978 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700979 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800980 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
981 tmir =tmir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700982 if (MIR::DecodedInstruction::IsPseudoMirOp(tmir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800983 continue;
984 }
985 // First non-pseudo should be MOVE_RESULT_OBJECT
986 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
987 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000988 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800989 } else {
990 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
991 }
992 break;
993 }
994 }
995 }
996 }
997
998 /*
999 * Propagate nullcheck state on register copies (including
1000 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001001 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -08001002 */
1003 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
1004 int tgt_sreg = mir->ssa_rep->defs[0];
1005 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
1006 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001007 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -08001008 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001009 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -08001010 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001011 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001012 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001013 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001014 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -08001015 }
1016 }
buzbee311ca162013-02-28 15:56:43 -08001017 }
1018
1019 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001020 bool nce_changed = false;
1021 if (do_nce) {
1022 if (bb->data_flow_info->ending_check_v == nullptr) {
1023 DCHECK(temp_scoped_alloc_.get() != nullptr);
1024 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1025 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
1026 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
1027 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
Jean Christophe Beylerb5c9b402014-04-30 14:52:00 -07001028 } else if (!ssa_regs_to_check->SameBitsSet(bb->data_flow_info->ending_check_v)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001029 nce_changed = true;
1030 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
1031 }
buzbee311ca162013-02-28 15:56:43 -08001032 }
buzbee1da1e2f2013-11-15 13:37:01 -08001033 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001034}
1035
Vladimir Markobfea9c22014-01-17 17:49:33 +00001036void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
1037 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
1038 // Clean up temporaries.
1039 temp_bit_vector_size_ = 0u;
1040 temp_bit_vector_ = nullptr;
1041 AllNodesIterator iter(this);
1042 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1043 if (bb->data_flow_info != nullptr) {
1044 bb->data_flow_info->ending_check_v = nullptr;
1045 }
1046 }
1047 DCHECK(temp_scoped_alloc_.get() != nullptr);
1048 temp_scoped_alloc_.reset();
1049 }
1050}
1051
1052bool MIRGraph::EliminateClassInitChecksGate() {
1053 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
1054 !cu_->mir_graph->HasStaticFieldAccess()) {
1055 return false;
1056 }
1057
1058 if (kIsDebugBuild) {
1059 AllNodesIterator iter(this);
1060 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1061 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
1062 }
1063 }
1064
1065 DCHECK(temp_scoped_alloc_.get() == nullptr);
1066 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1067
1068 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
1069 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
1070 temp_insn_data_ = static_cast<uint16_t*>(
1071 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1072
1073 uint32_t unique_class_count = 0u;
1074 {
1075 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1076 // ScopedArenaAllocator.
1077
1078 // Embed the map value in the entry to save space.
1079 struct MapEntry {
1080 // Map key: the class identified by the declaring dex file and type index.
1081 const DexFile* declaring_dex_file;
1082 uint16_t declaring_class_idx;
1083 // Map value: index into bit vectors of classes requiring initialization checks.
1084 uint16_t index;
1085 };
1086 struct MapEntryComparator {
1087 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1088 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1089 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1090 }
1091 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1092 }
1093 };
1094
Vladimir Markobfea9c22014-01-17 17:49:33 +00001095 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001096 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1097 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001098
1099 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1100 AllNodesIterator iter(this);
1101 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1102 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1103 DCHECK(bb->data_flow_info != nullptr);
1104 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1105 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1106 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
1107 uint16_t index = 0xffffu;
Vladimir Markof418f322014-07-09 14:45:36 +01001108 if (!field_info.IsInitialized()) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001109 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1110 MapEntry entry = {
Vladimir Markof418f322014-07-09 14:45:36 +01001111 // Treat unresolved fields as if each had its own class.
1112 field_info.IsResolved() ? field_info.DeclaringDexFile()
1113 : nullptr,
1114 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1115 : field_info.FieldIndex(),
Vladimir Markobfea9c22014-01-17 17:49:33 +00001116 static_cast<uint16_t>(class_to_index_map.size())
1117 };
1118 index = class_to_index_map.insert(entry).first->index;
1119 }
1120 // Using offset/2 for index into temp_insn_data_.
1121 temp_insn_data_[mir->offset / 2u] = index;
1122 }
1123 }
1124 }
1125 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1126 }
1127
1128 if (unique_class_count == 0u) {
1129 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1130 temp_insn_data_ = nullptr;
1131 temp_scoped_alloc_.reset();
1132 return false;
1133 }
1134
1135 temp_bit_vector_size_ = unique_class_count;
1136 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1137 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1138 DCHECK_GT(temp_bit_vector_size_, 0u);
1139 return true;
1140}
1141
1142/*
1143 * Eliminate unnecessary class initialization checks for a basic block.
1144 */
1145bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1146 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1147 if (bb->data_flow_info == NULL) {
1148 return false;
1149 }
1150
1151 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001152 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001153 */
1154 ArenaBitVector* classes_to_check = temp_bit_vector_;
1155 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001156 if (bb->block_type == kEntryBlock) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001157 classes_to_check->SetInitialBits(temp_bit_vector_size_);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001158 } else if (bb->predecessors.size() == 1) {
1159 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors[0]);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001160 // pred_bb must have already been processed at least once.
1161 DCHECK(pred_bb != nullptr);
1162 DCHECK(pred_bb->data_flow_info != nullptr);
1163 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1164 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1165 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001166 // Starting state is union of all incoming arcs.
1167 bool copied_first = false;
1168 for (BasicBlockId pred_id : bb->predecessors) {
1169 BasicBlock* pred_bb = GetBasicBlock(pred_id);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001170 DCHECK(pred_bb != nullptr);
1171 DCHECK(pred_bb->data_flow_info != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001172 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1173 continue;
1174 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001175 if (!copied_first) {
1176 copied_first = true;
1177 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1178 } else {
1179 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1180 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001181 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001182 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001183 }
1184 // At this point, classes_to_check shows which classes need clinit checks.
1185
1186 // Walk through the instruction in the block, updating as necessary
1187 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1188 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1189 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1190 uint16_t index = temp_insn_data_[mir->offset / 2u];
1191 if (index != 0xffffu) {
1192 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1193 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1194 if (!classes_to_check->IsBitSet(index)) {
1195 // Eliminate the class init check.
1196 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1197 } else {
1198 // Do the class init check.
1199 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1200 }
1201 }
1202 // Mark the class as initialized.
1203 classes_to_check->ClearBit(index);
1204 }
1205 }
1206 }
1207
1208 // Did anything change?
1209 bool changed = false;
1210 if (bb->data_flow_info->ending_check_v == nullptr) {
1211 DCHECK(temp_scoped_alloc_.get() != nullptr);
1212 DCHECK(bb->data_flow_info != nullptr);
1213 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1214 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1215 changed = classes_to_check->GetHighestBitSet() != -1;
1216 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1217 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1218 changed = true;
1219 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1220 }
1221 return changed;
1222}
1223
1224void MIRGraph::EliminateClassInitChecksEnd() {
1225 // Clean up temporaries.
1226 temp_bit_vector_size_ = 0u;
1227 temp_bit_vector_ = nullptr;
1228 AllNodesIterator iter(this);
1229 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1230 if (bb->data_flow_info != nullptr) {
1231 bb->data_flow_info->ending_check_v = nullptr;
1232 }
1233 }
1234
1235 DCHECK(temp_insn_data_ != nullptr);
1236 temp_insn_data_ = nullptr;
1237 DCHECK(temp_scoped_alloc_.get() != nullptr);
1238 temp_scoped_alloc_.reset();
1239}
1240
Vladimir Marko95a05972014-05-30 10:01:32 +01001241bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko55fff042014-07-10 12:42:52 +01001242 if ((cu_->disable_opt & (1u << kGlobalValueNumbering)) != 0u) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001243 return false;
1244 }
1245
1246 DCHECK(temp_scoped_alloc_ == nullptr);
1247 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1248 DCHECK(temp_gvn_ == nullptr);
1249 temp_gvn_.reset(
1250 new (temp_scoped_alloc_.get()) GlobalValueNumbering(cu_, temp_scoped_alloc_.get()));
1251 return true;
1252}
1253
1254bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
1255 DCHECK(temp_gvn_ != nullptr);
1256 LocalValueNumbering* lvn = temp_gvn_->PrepareBasicBlock(bb);
1257 if (lvn != nullptr) {
1258 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1259 lvn->GetValueNumber(mir);
1260 }
1261 }
1262 bool change = (lvn != nullptr) && temp_gvn_->FinishBasicBlock(bb);
1263 return change;
1264}
1265
1266void MIRGraph::ApplyGlobalValueNumberingEnd() {
1267 // Perform modifications.
1268 if (temp_gvn_->Good()) {
1269 temp_gvn_->AllowModifications();
1270 PreOrderDfsIterator iter(this);
1271 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Markob19955d2014-07-29 12:04:10 +01001272 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
1273 LocalValueNumbering* lvn = temp_gvn_->PrepareBasicBlock(bb, &allocator);
Vladimir Marko95a05972014-05-30 10:01:32 +01001274 if (lvn != nullptr) {
1275 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1276 lvn->GetValueNumber(mir);
1277 }
1278 bool change = temp_gvn_->FinishBasicBlock(bb);
Vladimir Marko55fff042014-07-10 12:42:52 +01001279 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001280 }
1281 }
1282 } else {
1283 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1284 }
1285
1286 DCHECK(temp_gvn_ != nullptr);
1287 temp_gvn_.reset();
1288 DCHECK(temp_scoped_alloc_ != nullptr);
1289 temp_scoped_alloc_.reset();
1290}
1291
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001292void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1293 uint32_t method_index = invoke->meta.method_lowering_info;
1294 if (temp_bit_vector_->IsBitSet(method_index)) {
1295 iget_or_iput->meta.ifield_lowering_info = temp_insn_data_[method_index];
1296 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1297 return;
1298 }
1299
1300 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1301 MethodReference target = method_info.GetTargetMethod();
1302 DexCompilationUnit inlined_unit(
1303 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1304 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1305 0u /* access_flags not used */, nullptr /* verified_method not used */);
1306 MirIFieldLoweringInfo inlined_field_info(field_idx);
1307 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1308 DCHECK(inlined_field_info.IsResolved());
1309
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001310 uint32_t field_info_index = ifield_lowering_infos_.size();
1311 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001312 temp_bit_vector_->SetBit(method_index);
1313 temp_insn_data_[method_index] = field_info_index;
1314 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1315}
1316
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001317bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001318 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001319 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001320 return false;
1321 }
1322 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1323 // This isn't the Quick compiler.
1324 return false;
1325 }
1326 return true;
1327}
1328
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001329void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001330 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1331 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1332
1333 DCHECK(temp_scoped_alloc_.get() == nullptr);
1334 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001335 temp_bit_vector_size_ = method_lowering_infos_.size();
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001336 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1337 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapMisc);
1338 temp_bit_vector_->ClearAllBits();
1339 temp_insn_data_ = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1340 temp_bit_vector_size_ * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1341}
1342
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001343void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001344 if (bb->block_type != kDalvikByteCode) {
1345 return;
1346 }
1347 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001348 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001349 continue;
1350 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001351 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001352 continue;
1353 }
1354 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1355 if (!method_info.FastPath()) {
1356 continue;
1357 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001358
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001359 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001360 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001361 continue;
1362 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001363
1364 if (sharp_type == kStatic) {
1365 bool needs_clinit = method_info.NeedsClassInitialization() &&
1366 ((mir->optimization_flags & MIR_IGNORE_CLINIT_CHECK) == 0);
1367 if (needs_clinit) {
1368 continue;
1369 }
1370 }
1371
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001372 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1373 MethodReference target = method_info.GetTargetMethod();
1374 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1375 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001376 if (cu_->verbose || cu_->print_pass) {
1377 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1378 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1379 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1380 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001381 }
1382 }
1383 }
1384}
1385
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001386void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001387 DCHECK(temp_insn_data_ != nullptr);
1388 temp_insn_data_ = nullptr;
1389 DCHECK(temp_bit_vector_ != nullptr);
1390 temp_bit_vector_ = nullptr;
1391 DCHECK(temp_scoped_alloc_.get() != nullptr);
1392 temp_scoped_alloc_.reset();
1393}
1394
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001395void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001396 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001397 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001398 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001399 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001400 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1401 CountChecks(bb);
1402 }
1403 if (stats->null_checks > 0) {
1404 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1405 float checks = static_cast<float>(stats->null_checks);
1406 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1407 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1408 << (eliminated/checks) * 100.0 << "%";
1409 }
1410 if (stats->range_checks > 0) {
1411 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1412 float checks = static_cast<float>(stats->range_checks);
1413 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1414 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1415 << (eliminated/checks) * 100.0 << "%";
1416 }
1417}
1418
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001419bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001420 if (bb->visited) return false;
1421 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1422 || (bb->block_type == kExitBlock))) {
1423 // Ignore special blocks
1424 bb->visited = true;
1425 return false;
1426 }
1427 // Must be head of extended basic block.
1428 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001429 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001430 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001431 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001432 // Visit blocks strictly dominated by this head.
1433 while (bb != NULL) {
1434 bb->visited = true;
1435 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001436 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001437 bb = NextDominatedBlock(bb);
1438 }
buzbee1da1e2f2013-11-15 13:37:01 -08001439 if (terminated_by_return || do_local_value_numbering) {
1440 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001441 bb = start_bb;
1442 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001443 bb->use_lvn = do_local_value_numbering;
1444 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001445 bb = NextDominatedBlock(bb);
1446 }
1447 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001448 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001449}
1450
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001451void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001452 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1453 ClearAllVisitedFlags();
1454 PreOrderDfsIterator iter2(this);
1455 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1456 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001457 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001458 // Perform extended basic block optimizations.
1459 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1460 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1461 }
1462 } else {
1463 PreOrderDfsIterator iter(this);
1464 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1465 BasicBlockOpt(bb);
1466 }
buzbee311ca162013-02-28 15:56:43 -08001467 }
1468}
1469
1470} // namespace art