blob: 6e9844cb7fb1bd3c3dbe06a7bda90e4d48e89e29 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800429 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
430 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
431 MultiplyAddOpt(bb);
432 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100433 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100435 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700436 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800437 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100438 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100439 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
440 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100441 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
442 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800443 }
buzbee311ca162013-02-28 15:56:43 -0800444 while (bb != NULL) {
445 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
446 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800447 if (use_lvn) {
448 local_valnum->GetValueNumber(mir);
449 }
buzbee311ca162013-02-28 15:56:43 -0800450 // Look for interesting opcodes, skip otherwise
451 Instruction::Code opcode = mir->dalvikInsn.opcode;
452 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000453 case Instruction::IF_EQ:
454 case Instruction::IF_NE:
455 case Instruction::IF_LT:
456 case Instruction::IF_GE:
457 case Instruction::IF_GT:
458 case Instruction::IF_LE:
459 if (!IsConst(mir->ssa_rep->uses[1])) {
460 break;
461 }
462 FALLTHROUGH_INTENDED;
463 case Instruction::IF_EQZ:
464 case Instruction::IF_NEZ:
465 case Instruction::IF_LTZ:
466 case Instruction::IF_GEZ:
467 case Instruction::IF_GTZ:
468 case Instruction::IF_LEZ:
469 // Result known at compile time?
470 if (IsConst(mir->ssa_rep->uses[0])) {
471 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
472 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
473 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
474 if (is_taken) {
475 // Replace with GOTO.
476 bb->fall_through = NullBasicBlockId;
477 mir->dalvikInsn.opcode = Instruction::GOTO;
478 mir->dalvikInsn.vA =
479 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
480 } else {
481 // Make NOP.
482 bb->taken = NullBasicBlockId;
483 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
484 }
485 mir->ssa_rep->num_uses = 0;
486 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
487 successor_to_unlink->ErasePredecessor(bb->id);
488 if (successor_to_unlink->predecessors.empty()) {
489 successor_to_unlink->KillUnreachable(this);
490 }
491 }
492 break;
buzbee311ca162013-02-28 15:56:43 -0800493 case Instruction::CMPL_FLOAT:
494 case Instruction::CMPL_DOUBLE:
495 case Instruction::CMPG_FLOAT:
496 case Instruction::CMPG_DOUBLE:
497 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700498 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800499 // Bitcode doesn't allow this optimization.
500 break;
501 }
502 if (mir->next != NULL) {
503 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800504 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700505 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800506 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
507 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000508 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700509 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800510 case Instruction::CMPL_FLOAT:
511 mir_next->dalvikInsn.opcode =
512 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
513 break;
514 case Instruction::CMPL_DOUBLE:
515 mir_next->dalvikInsn.opcode =
516 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
517 break;
518 case Instruction::CMPG_FLOAT:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
521 break;
522 case Instruction::CMPG_DOUBLE:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
525 break;
526 case Instruction::CMP_LONG:
527 mir_next->dalvikInsn.opcode =
528 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
529 break;
530 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
531 }
532 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800533 // Clear use count of temp VR.
534 use_counts_[mir->ssa_rep->defs[0]] = 0;
535 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700536 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800537 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
538 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
539 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
540 mir_next->ssa_rep->num_defs = 0;
541 mir->ssa_rep->num_uses = 0;
542 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700543 // Copy in the decoded instruction information for potential SSA re-creation.
544 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
545 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800546 }
547 }
548 break;
buzbee311ca162013-02-28 15:56:43 -0800549 default:
550 break;
551 }
552 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800553 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800554 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800555 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100556 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000557 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700558 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800559 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700560 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
561 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800562
buzbee0d829482013-10-11 15:24:55 -0700563 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800564 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700565 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
566 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800567
568 /*
569 * In the select pattern, the taken edge goes to a block that unconditionally
570 * transfers to the rejoin block and the fall_though edge goes to a block that
571 * unconditionally falls through to the rejoin block.
572 */
573 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
574 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
575 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000576 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800577 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100578
579 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800580 // Are the block bodies something we can handle?
581 if ((ft->first_mir_insn == ft->last_mir_insn) &&
582 (tk->first_mir_insn != tk->last_mir_insn) &&
583 (tk->first_mir_insn->next == tk->last_mir_insn) &&
584 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
585 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
586 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
587 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
588 // Almost there. Are the instructions targeting the same vreg?
589 MIR* if_true = tk->first_mir_insn;
590 MIR* if_false = ft->first_mir_insn;
591 // It's possible that the target of the select isn't used - skip those (rare) cases.
592 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
593 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
594 /*
595 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
596 * Phi node in the merge block and delete it (while using the SSA name
597 * of the merge as the target of the SELECT. Delete both taken and
598 * fallthrough blocks, and set fallthrough to merge block.
599 * NOTE: not updating other dataflow info (no longer used at this point).
600 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
601 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000602 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800603 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
604 bool const_form = (SelectKind(if_true) == kSelectConst);
605 if ((SelectKind(if_true) == kSelectMove)) {
606 if (IsConst(if_true->ssa_rep->uses[0]) &&
607 IsConst(if_false->ssa_rep->uses[0])) {
608 const_form = true;
609 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
610 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
611 }
612 }
613 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800614 /*
615 * TODO: If both constants are the same value, then instead of generating
616 * a select, we should simply generate a const bytecode. This should be
617 * considered after inlining which can lead to CFG of this form.
618 */
buzbee311ca162013-02-28 15:56:43 -0800619 // "true" set val in vB
620 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
621 // "false" set val in vC
622 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
623 } else {
624 DCHECK_EQ(SelectKind(if_true), kSelectMove);
625 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700626 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000627 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800628 src_ssa[0] = mir->ssa_rep->uses[0];
629 src_ssa[1] = if_true->ssa_rep->uses[0];
630 src_ssa[2] = if_false->ssa_rep->uses[0];
631 mir->ssa_rep->uses = src_ssa;
632 mir->ssa_rep->num_uses = 3;
633 }
634 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700635 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000636 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700637 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000638 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800639 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700640 // Match type of uses to def.
641 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700642 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000643 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700644 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
645 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
646 }
buzbee311ca162013-02-28 15:56:43 -0800647 /*
648 * There is usually a Phi node in the join block for our two cases. If the
649 * Phi node only contains our two cases as input, we will use the result
650 * SSA name of the Phi node as our select result and delete the Phi. If
651 * the Phi node has more than two operands, we will arbitrarily use the SSA
652 * name of the "true" path, delete the SSA name of the "false" path from the
653 * Phi node (and fix up the incoming arc list).
654 */
655 if (phi->ssa_rep->num_uses == 2) {
656 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
657 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
658 } else {
659 int dead_def = if_false->ssa_rep->defs[0];
660 int live_def = if_true->ssa_rep->defs[0];
661 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700662 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800663 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
664 if (phi->ssa_rep->uses[i] == live_def) {
665 incoming[i] = bb->id;
666 }
667 }
668 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
669 if (phi->ssa_rep->uses[i] == dead_def) {
670 int last_slot = phi->ssa_rep->num_uses - 1;
671 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
672 incoming[i] = incoming[last_slot];
673 }
674 }
675 }
676 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700677 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800678 tk->block_type = kDead;
679 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
680 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
681 }
682 }
683 }
684 }
685 }
686 }
buzbee1da1e2f2013-11-15 13:37:01 -0800687 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800688 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100689 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100690 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
691 }
buzbee311ca162013-02-28 15:56:43 -0800692
buzbee311ca162013-02-28 15:56:43 -0800693 return true;
694}
695
buzbee311ca162013-02-28 15:56:43 -0800696/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700697void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700698 if (bb->data_flow_info != NULL) {
699 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
700 if (mir->ssa_rep == NULL) {
701 continue;
buzbee311ca162013-02-28 15:56:43 -0800702 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700703 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700704 if (df_attributes & DF_HAS_NULL_CHKS) {
705 checkstats_->null_checks++;
706 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
707 checkstats_->null_checks_eliminated++;
708 }
709 }
710 if (df_attributes & DF_HAS_RANGE_CHKS) {
711 checkstats_->range_checks++;
712 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
713 checkstats_->range_checks_eliminated++;
714 }
buzbee311ca162013-02-28 15:56:43 -0800715 }
716 }
717 }
buzbee311ca162013-02-28 15:56:43 -0800718}
719
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700720/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700721bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700722 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800723 if (!bb->explicit_throw) {
724 return false;
725 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700726
727 // If we visited it, we are done.
728 if (bb->visited) {
729 return false;
730 }
731 bb->visited = true;
732
buzbee311ca162013-02-28 15:56:43 -0800733 BasicBlock* walker = bb;
734 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700735 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800736 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
737 break;
738 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100739 DCHECK(!walker->predecessors.empty());
740 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700741
742 // If we visited the predecessor, we are done.
743 if (prev->visited) {
744 return false;
745 }
746 prev->visited = true;
747
buzbee311ca162013-02-28 15:56:43 -0800748 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700749 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700750 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800751 break;
752 }
buzbee0d829482013-10-11 15:24:55 -0700753 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700754 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800755 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
756 switch (opcode) {
757 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
758 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
759 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
760 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
761 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
762 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
763 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
764 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
765 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
766 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
767 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
768 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
769 default: LOG(FATAL) << "Unexpected opcode " << opcode;
770 }
771 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700772 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800773 prev->taken = prev->fall_through;
774 prev->fall_through = t_bb;
775 break;
776 }
777 walker = prev;
778 }
779 return false;
780}
781
782/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700783void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800784 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100785 while ((bb->block_type == kDalvikByteCode) &&
786 (bb->last_mir_insn != nullptr) &&
787 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
788 MIR* mir = bb->last_mir_insn;
789 DCHECK(bb->first_mir_insn != nullptr);
790
791 // Grab the attributes from the paired opcode.
792 MIR* throw_insn = mir->meta.throw_insn;
793 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
794
795 // Don't combine if the throw_insn can still throw NPE.
796 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
797 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
798 break;
799 }
800 // Now whitelist specific instructions.
801 bool ok = false;
802 if ((df_attributes & DF_IFIELD) != 0) {
803 // Combine only if fast, otherwise weird things can happen.
804 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600805 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100806 } else if ((df_attributes & DF_SFIELD) != 0) {
807 // Combine only if fast, otherwise weird things can happen.
808 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600809 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100810 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100811 bool clinit = !field_info.IsClassInitialized() &&
812 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100813 ok = fast && !clinit;
814 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
815 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
816 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
817 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
818 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
819 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
820 ok = true;
821 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
822 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
823 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
824 // No more checks for these (null check was processed above).
825 ok = true;
826 }
827 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800828 break;
829 }
830
buzbee311ca162013-02-28 15:56:43 -0800831 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700832 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800833 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100834 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700835
836 // Now move instructions from bb_next to bb. Start off with doing a sanity check
837 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800838 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700839 // Now move all instructions (throw instruction to last one) from bb_next to bb.
840 MIR* last_to_move = bb_next->last_mir_insn;
841 bb_next->RemoveMIRList(throw_insn, last_to_move);
842 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
843 // The kMirOpCheck instruction is not needed anymore.
844 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
845 bb->RemoveMIR(mir);
846
Vladimir Marko312eb252014-10-07 15:01:57 +0100847 // Before we overwrite successors, remove their predecessor links to bb.
848 bb_next->ErasePredecessor(bb->id);
849 if (bb->taken != NullBasicBlockId) {
850 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
851 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
852 // bb->taken will be overwritten below.
853 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
854 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
855 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
856 bb_taken->predecessors.clear();
857 bb_taken->block_type = kDead;
858 DCHECK(bb_taken->data_flow_info == nullptr);
859 } else {
860 DCHECK_EQ(bb->successor_block_list_type, kCatch);
861 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
862 if (succ_info->block != NullBasicBlockId) {
863 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
864 DCHECK(succ_bb->catch_entry);
865 succ_bb->ErasePredecessor(bb->id);
866 if (succ_bb->predecessors.empty()) {
867 succ_bb->KillUnreachable(this);
868 }
869 }
870 }
871 }
buzbee311ca162013-02-28 15:56:43 -0800872 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700873 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100874 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100875 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800876 // Use the ending block linkage from the next block
877 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100878 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800879 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100880 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800881 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900882 * If lower-half of pair of blocks to combine contained
883 * a return or a conditional branch or an explicit throw,
884 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800885 */
886 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900887 bb->conditional_branch = bb_next->conditional_branch;
888 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100889 // Merge the use_lvn flag.
890 bb->use_lvn |= bb_next->use_lvn;
891
892 // Kill the unused block.
893 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800894
895 /*
896 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
897 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100898 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800899 */
900
Vladimir Marko312eb252014-10-07 15:01:57 +0100901 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800902 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100903 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700904 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100905 // Update predecessors in children.
906 ChildBlockIterator iter(bb, this);
907 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
908 child->UpdatePredecessor(bb_next->id, bb->id);
909 }
910
911 // DFS orders are not up to date anymore.
912 dfs_orders_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800913
914 // Now, loop back and see if we can keep going
915 }
buzbee311ca162013-02-28 15:56:43 -0800916}
917
Vladimir Marko67c72b82014-10-09 12:26:10 +0100918bool MIRGraph::EliminateNullChecksGate() {
919 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
920 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
921 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000922 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100923
Vladimir Marko67c72b82014-10-09 12:26:10 +0100924 DCHECK(temp_scoped_alloc_.get() == nullptr);
925 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700926 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000927 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
928 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
929 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100930 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000931 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700932
933 // reset MIR_MARK
934 AllNodesIterator iter(this);
935 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
936 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
937 mir->optimization_flags &= ~MIR_MARK;
938 }
939 }
940
Vladimir Marko67c72b82014-10-09 12:26:10 +0100941 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000942}
943
buzbee1da1e2f2013-11-15 13:37:01 -0800944/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100945 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800946 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100947bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100948 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
949 // Ignore the kExitBlock as well.
950 DCHECK(bb->first_mir_insn == nullptr);
951 return false;
952 }
buzbee311ca162013-02-28 15:56:43 -0800953
Vladimir Markof585e542014-11-21 13:41:32 +0000954 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100955 /*
956 * Set initial state. Catch blocks don't need any special treatment.
957 */
958 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100959 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100960 // Assume all ins are objects.
961 for (uint16_t in_reg = GetFirstInVR();
962 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100963 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100964 }
965 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100966 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100967 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100968 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100969 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100970 } else {
971 DCHECK_EQ(bb->block_type, kDalvikByteCode);
972 // Starting state is union of all incoming arcs.
973 bool copied_first = false;
974 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000975 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100976 continue;
977 }
978 BasicBlock* pred_bb = GetBasicBlock(pred_id);
979 DCHECK(pred_bb != nullptr);
980 MIR* null_check_insn = nullptr;
981 if (pred_bb->block_type == kDalvikByteCode) {
982 // Check to see if predecessor had an explicit null-check.
983 MIR* last_insn = pred_bb->last_mir_insn;
984 if (last_insn != nullptr) {
985 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
986 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
987 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
988 // Remember the null check insn if there's no other predecessor requiring null check.
989 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
990 null_check_insn = last_insn;
991 }
buzbee1da1e2f2013-11-15 13:37:01 -0800992 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700993 }
994 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100995 if (!copied_first) {
996 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000997 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100998 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000999 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001000 }
1001 if (null_check_insn != nullptr) {
1002 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001003 }
1004 }
1005 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -08001006 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001007 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +01001008 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -08001009
1010 // Walk through the instruction in the block, updating as necessary
1011 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -07001012 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -08001013
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -07001014 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
1015 // The algorithm was written in a phi agnostic way.
1016 continue;
1017 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001018
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001019 // Might need a null check?
1020 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001021 int src_vreg;
1022 if (df_attributes & DF_NULL_CHK_OUT0) {
1023 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
1024 src_vreg = mir->dalvikInsn.vC;
1025 } else if (df_attributes & DF_NULL_CHK_B) {
1026 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1027 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001028 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001029 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1030 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1031 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001032 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001033 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001035 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001036 } else {
1037 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001038 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001039 // Mark src_vreg as null-checked.
1040 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001041 }
1042 }
1043
1044 if ((df_attributes & DF_A_WIDE) ||
1045 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1046 continue;
1047 }
1048
1049 /*
1050 * First, mark all object definitions as requiring null check.
1051 * Note: we can't tell if a CONST definition might be used as an object, so treat
1052 * them all as object definitions.
1053 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001054 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001055 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001056 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001057 }
1058
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001059 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001060 if (df_attributes & DF_NON_NULL_DST) {
1061 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001062 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1063 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001064 }
1065
buzbee311ca162013-02-28 15:56:43 -08001066 // Mark non-null returns from invoke-style NEW*
1067 if (df_attributes & DF_NON_NULL_RET) {
1068 MIR* next_mir = mir->next;
1069 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001070 if (UNLIKELY(next_mir == nullptr)) {
1071 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1072 // target, so the MOVE_RESULT cannot be broken away into another block.
1073 LOG(WARNING) << "Unexpected end of block following new";
1074 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1075 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001076 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001077 // Mark as null checked.
1078 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001079 }
1080 }
1081
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001082 // Propagate null check state on register copies.
1083 if (df_attributes & DF_NULL_TRANSFER_0) {
1084 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1085 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1086 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001087 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001088 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001089 }
1090 }
buzbee311ca162013-02-28 15:56:43 -08001091 }
1092
1093 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001094 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001095 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001096 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001097 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001098 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001099 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001100 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001101 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1102 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001103 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001104 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001105 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1106 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001107 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001108 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001109}
1110
Vladimir Marko67c72b82014-10-09 12:26:10 +01001111void MIRGraph::EliminateNullChecksEnd() {
1112 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001113 temp_.nce.num_vregs = 0u;
1114 temp_.nce.work_vregs_to_check = nullptr;
1115 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001116 DCHECK(temp_scoped_alloc_.get() != nullptr);
1117 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001118
1119 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001120 AllNodesIterator iter(this);
1121 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1122 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001123 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001124 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001125 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001126 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001127 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1128 }
1129 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001130}
1131
1132/*
1133 * Perform type and size inference for a basic block.
1134 */
1135bool MIRGraph::InferTypes(BasicBlock* bb) {
1136 if (bb->data_flow_info == nullptr) return false;
1137
1138 bool infer_changed = false;
1139 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1140 if (mir->ssa_rep == NULL) {
1141 continue;
1142 }
1143
1144 // Propagate type info.
1145 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1146 }
1147
1148 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001149}
1150
1151bool MIRGraph::EliminateClassInitChecksGate() {
1152 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001153 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001154 return false;
1155 }
1156
Vladimir Markobfea9c22014-01-17 17:49:33 +00001157 DCHECK(temp_scoped_alloc_.get() == nullptr);
1158 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1159
1160 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001161 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001162 temp_.cice.indexes = static_cast<uint16_t*>(
1163 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1164 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001165
1166 uint32_t unique_class_count = 0u;
1167 {
1168 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1169 // ScopedArenaAllocator.
1170
1171 // Embed the map value in the entry to save space.
1172 struct MapEntry {
1173 // Map key: the class identified by the declaring dex file and type index.
1174 const DexFile* declaring_dex_file;
1175 uint16_t declaring_class_idx;
1176 // Map value: index into bit vectors of classes requiring initialization checks.
1177 uint16_t index;
1178 };
1179 struct MapEntryComparator {
1180 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1181 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1182 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1183 }
1184 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1185 }
1186 };
1187
Vladimir Markobfea9c22014-01-17 17:49:33 +00001188 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001189 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1190 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001191
1192 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1193 AllNodesIterator iter(this);
1194 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001195 if (bb->block_type == kDalvikByteCode) {
1196 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001197 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001198 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001199 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001200 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1201 MapEntry entry = {
1202 // Treat unresolved fields as if each had its own class.
1203 field_info.IsResolved() ? field_info.DeclaringDexFile()
1204 : nullptr,
1205 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1206 : field_info.FieldIndex(),
1207 static_cast<uint16_t>(class_to_index_map.size())
1208 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001209 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001210 // Using offset/2 for index into temp_.cice.indexes.
1211 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001212 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001213 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001214 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1215 DCHECK(method_info.IsStatic());
1216 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1217 MapEntry entry = {
1218 method_info.DeclaringDexFile(),
1219 method_info.DeclaringClassIndex(),
1220 static_cast<uint16_t>(class_to_index_map.size())
1221 };
1222 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001223 // Using offset/2 for index into temp_.cice.indexes.
1224 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001225 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001226 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001227 }
1228 }
1229 }
1230 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1231 }
1232
1233 if (unique_class_count == 0u) {
1234 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001235 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001236 temp_scoped_alloc_.reset();
1237 return false;
1238 }
1239
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001240 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001241 temp_.cice.num_class_bits = 2u * unique_class_count;
1242 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1243 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1244 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001245 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001246 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1247 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001248 return true;
1249}
1250
1251/*
1252 * Eliminate unnecessary class initialization checks for a basic block.
1253 */
1254bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1255 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001256 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1257 // Ignore the kExitBlock as well.
1258 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001259 return false;
1260 }
1261
1262 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001263 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001264 */
Vladimir Markof585e542014-11-21 13:41:32 +00001265 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001266 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001267 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001268 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001269 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001270 // Starting state is union of all incoming arcs.
1271 bool copied_first = false;
1272 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001273 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001274 continue;
1275 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001276 if (!copied_first) {
1277 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001278 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001279 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001280 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001281 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001282 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001283 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001284 }
1285 // At this point, classes_to_check shows which classes need clinit checks.
1286
1287 // Walk through the instruction in the block, updating as necessary
1288 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001289 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001290 if (index != 0xffffu) {
1291 bool check_initialization = false;
1292 bool check_dex_cache = false;
1293
1294 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1295 // Dex instructions with width 1 can have the same offset/2.
1296
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001297 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001298 check_initialization = true;
1299 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001300 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001301 check_initialization = true;
1302 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1303 }
1304
1305 if (check_dex_cache) {
1306 uint32_t check_dex_cache_index = 2u * index + 1u;
1307 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1308 // Eliminate the class init check.
1309 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1310 } else {
1311 // Do the class init check.
1312 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1313 }
1314 classes_to_check->ClearBit(check_dex_cache_index);
1315 }
1316 if (check_initialization) {
1317 uint32_t check_clinit_index = 2u * index;
1318 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1319 // Eliminate the class init check.
1320 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1321 } else {
1322 // Do the class init check.
1323 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001324 }
1325 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001326 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001327 }
1328 }
1329 }
1330
1331 // Did anything change?
1332 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001333 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001334 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001335 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001336 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001337 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001338 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001339 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1340 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001341 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001342 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001343 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1344 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001345 }
1346 return changed;
1347}
1348
1349void MIRGraph::EliminateClassInitChecksEnd() {
1350 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001351 temp_.cice.num_class_bits = 0u;
1352 temp_.cice.work_classes_to_check = nullptr;
1353 temp_.cice.ending_classes_to_check_matrix = nullptr;
1354 DCHECK(temp_.cice.indexes != nullptr);
1355 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001356 DCHECK(temp_scoped_alloc_.get() != nullptr);
1357 temp_scoped_alloc_.reset();
1358}
1359
Vladimir Marko95a05972014-05-30 10:01:32 +01001360bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001361 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001362 return false;
1363 }
1364
1365 DCHECK(temp_scoped_alloc_ == nullptr);
1366 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001367 temp_.gvn.ifield_ids_ =
1368 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1369 temp_.gvn.sfield_ids_ =
1370 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001371 DCHECK(temp_.gvn.gvn == nullptr);
1372 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1373 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001374 return true;
1375}
1376
1377bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001378 DCHECK(temp_.gvn.gvn != nullptr);
1379 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001380 if (lvn != nullptr) {
1381 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1382 lvn->GetValueNumber(mir);
1383 }
1384 }
Vladimir Markof585e542014-11-21 13:41:32 +00001385 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001386 return change;
1387}
1388
1389void MIRGraph::ApplyGlobalValueNumberingEnd() {
1390 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001391 DCHECK(temp_.gvn.gvn != nullptr);
1392 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001393 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001394 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001395 TopologicalSortIterator iter(this);
1396 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1397 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001398 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001399 if (lvn != nullptr) {
1400 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1401 lvn->GetValueNumber(mir);
1402 }
Vladimir Markof585e542014-11-21 13:41:32 +00001403 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001404 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001405 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001406 }
1407 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001408 // GVN was successful, running the LVN would be useless.
1409 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001410 } else {
1411 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1412 }
1413
Vladimir Markof585e542014-11-21 13:41:32 +00001414 delete temp_.gvn.gvn;
1415 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001416 temp_.gvn.ifield_ids_ = nullptr;
1417 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001418 DCHECK(temp_scoped_alloc_ != nullptr);
1419 temp_scoped_alloc_.reset();
1420}
1421
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001422void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1423 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001424 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1425 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001426 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1427 return;
1428 }
1429
1430 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1431 MethodReference target = method_info.GetTargetMethod();
1432 DexCompilationUnit inlined_unit(
1433 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1434 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1435 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001436 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1437 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001438 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1439 DCHECK(inlined_field_info.IsResolved());
1440
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001441 uint32_t field_info_index = ifield_lowering_infos_.size();
1442 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001443 temp_.smi.processed_indexes->SetBit(method_index);
1444 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001445 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1446}
1447
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001448bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001449 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001450 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001451 return false;
1452 }
1453 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1454 // This isn't the Quick compiler.
1455 return false;
1456 }
1457 return true;
1458}
1459
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001460void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001461 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1462 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1463
1464 DCHECK(temp_scoped_alloc_.get() == nullptr);
1465 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001466 temp_.smi.num_indexes = method_lowering_infos_.size();
1467 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1468 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1469 temp_.smi.processed_indexes->ClearAllBits();
1470 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1471 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001472}
1473
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001474void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001475 if (bb->block_type != kDalvikByteCode) {
1476 return;
1477 }
1478 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001479 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001480 continue;
1481 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001482 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001483 continue;
1484 }
1485 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1486 if (!method_info.FastPath()) {
1487 continue;
1488 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001489
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001490 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001491 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001492 continue;
1493 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001494
1495 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001496 bool needs_clinit = !method_info.IsClassInitialized() &&
1497 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001498 if (needs_clinit) {
1499 continue;
1500 }
1501 }
1502
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001503 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1504 MethodReference target = method_info.GetTargetMethod();
1505 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1506 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001507 if (cu_->verbose || cu_->print_pass) {
1508 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1509 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1510 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1511 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001512 }
1513 }
1514 }
1515}
1516
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001517void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001518 // Clean up temporaries.
1519 DCHECK(temp_.smi.lowering_infos != nullptr);
1520 temp_.smi.lowering_infos = nullptr;
1521 temp_.smi.num_indexes = 0u;
1522 DCHECK(temp_.smi.processed_indexes != nullptr);
1523 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001524 DCHECK(temp_scoped_alloc_.get() != nullptr);
1525 temp_scoped_alloc_.reset();
1526}
1527
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001528void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001529 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001530 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001531 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001532 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001533 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1534 CountChecks(bb);
1535 }
1536 if (stats->null_checks > 0) {
1537 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1538 float checks = static_cast<float>(stats->null_checks);
1539 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1540 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1541 << (eliminated/checks) * 100.0 << "%";
1542 }
1543 if (stats->range_checks > 0) {
1544 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1545 float checks = static_cast<float>(stats->range_checks);
1546 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1547 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1548 << (eliminated/checks) * 100.0 << "%";
1549 }
1550}
1551
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001552bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001553 if (bb->visited) return false;
1554 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1555 || (bb->block_type == kExitBlock))) {
1556 // Ignore special blocks
1557 bb->visited = true;
1558 return false;
1559 }
1560 // Must be head of extended basic block.
1561 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001562 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001563 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001564 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001565 // Visit blocks strictly dominated by this head.
1566 while (bb != NULL) {
1567 bb->visited = true;
1568 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001569 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001570 bb = NextDominatedBlock(bb);
1571 }
buzbee1da1e2f2013-11-15 13:37:01 -08001572 if (terminated_by_return || do_local_value_numbering) {
1573 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001574 bb = start_bb;
1575 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001576 bb->use_lvn = do_local_value_numbering;
1577 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001578 bb = NextDominatedBlock(bb);
1579 }
1580 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001581 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001582}
1583
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001584void MIRGraph::BasicBlockOptimization() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001585 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1586 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1587 temp_.gvn.ifield_ids_ =
1588 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1589 temp_.gvn.sfield_ids_ =
1590 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1591 }
1592
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001593 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1594 ClearAllVisitedFlags();
1595 PreOrderDfsIterator iter2(this);
1596 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1597 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001598 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001599 // Perform extended basic block optimizations.
1600 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1601 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1602 }
1603 } else {
1604 PreOrderDfsIterator iter(this);
1605 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1606 BasicBlockOpt(bb);
1607 }
buzbee311ca162013-02-28 15:56:43 -08001608 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001609
1610 // Clean up after LVN.
1611 temp_.gvn.ifield_ids_ = nullptr;
1612 temp_.gvn.sfield_ids_ = nullptr;
1613 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001614}
1615
Vladimir Marko8b858e12014-11-27 14:52:37 +00001616bool MIRGraph::EliminateSuspendChecksGate() {
1617 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1618 GetMaxNestedLoops() == 0u || // Nothing to do.
1619 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1620 // Exclude 32 as well to keep bit shifts well-defined.
1621 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1622 return false;
1623 }
1624 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1625 temp_.sce.inliner =
1626 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1627 }
1628 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1629 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1630 return true;
1631}
1632
1633bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1634 if (bb->block_type != kDalvikByteCode) {
1635 return false;
1636 }
1637 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1638 if (bb->nesting_depth == 0u) {
1639 // Out of loops.
1640 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1641 return false;
1642 }
1643 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1644 bool found_invoke = false;
1645 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1646 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1647 (temp_.sce.inliner == nullptr ||
1648 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1649 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1650 found_invoke = true;
1651 break;
1652 }
1653 }
1654 if (!found_invoke) {
1655 // Intersect suspend checks from predecessors.
1656 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1657 uint32_t pred_mask_union = 0u;
1658 for (BasicBlockId pred_id : bb->predecessors) {
1659 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1660 if (pred_topo_idx < bb_topo_idx) {
1661 // Determine the loop depth of the predecessors relative to this block.
1662 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1663 while (pred_loop_depth != 0u &&
1664 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1665 --pred_loop_depth;
1666 }
1667 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1668 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1669 // Intersect pred_mask bits in suspend_checks_in_loops with
1670 // suspend_checks_in_loops_[pred_id].
1671 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1672 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1673 pred_mask_union |= pred_mask;
1674 }
1675 }
1676 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1677 pred_mask_union);
1678 suspend_checks_in_loops &= pred_mask_union;
1679 }
1680 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1681 if (suspend_checks_in_loops == 0u) {
1682 return false;
1683 }
1684 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1685 if (bb->taken != NullBasicBlockId) {
1686 DCHECK(bb->last_mir_insn != nullptr);
1687 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1688 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1689 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1690 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1691 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1692 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1693 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1694 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1695 }
1696 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1697 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1698 MIR* mir = NewMIR();
1699 mir->dalvikInsn.opcode = Instruction::GOTO;
1700 mir->dalvikInsn.vA = 0; // Branch offset.
1701 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1702 mir->m_unit_index = current_method_;
1703 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1704 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1705 bb->AppendMIR(mir);
1706 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1707 }
1708 return true;
1709}
1710
1711void MIRGraph::EliminateSuspendChecksEnd() {
1712 temp_.sce.inliner = nullptr;
1713}
1714
Ningsheng Jiana262f772014-11-25 16:48:07 +08001715bool MIRGraph::CanThrow(MIR* mir) {
1716 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1717 return false;
1718 }
1719 const int opt_flags = mir->optimization_flags;
1720 uint64_t df_attributes = GetDataFlowAttributes(mir);
1721
1722 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1723 return true;
1724 }
1725 if ((df_attributes & DF_IFIELD) != 0) {
1726 // The IGET/IPUT family.
1727 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
1728 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1729 // Already processed null check above.
1730 if (fast) {
1731 return false;
1732 }
1733 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1734 // The AGET/APUT family.
1735 // Already processed null check above.
1736 if ((opt_flags & MIR_IGNORE_RANGE_CHECK) != 0) {
1737 return false;
1738 }
1739 } else if ((df_attributes & DF_SFIELD) != 0) {
1740 // The SGET/SPUT family.
1741 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
1742 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1743 bool is_class_initialized = field_info.IsClassInitialized() ||
1744 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
1745 if (fast && is_class_initialized) {
1746 return false;
1747 }
1748 }
1749 return true;
1750}
1751
1752bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1753 DCHECK(first->ssa_rep != nullptr);
1754 DCHECK(second->ssa_rep != nullptr);
1755 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1756 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1757 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1758 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1759 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1760 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1761 if (use == vreg0 || use == vreg1) {
1762 return true;
1763 }
1764 }
1765 }
1766 return false;
1767}
1768
1769void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1770 bool is_wide, bool is_sub) {
1771 if (is_wide) {
1772 if (is_sub) {
1773 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1774 } else {
1775 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1776 }
1777 } else {
1778 if (is_sub) {
1779 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1780 } else {
1781 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1782 }
1783 }
1784 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1785 int32_t addend0 = INVALID_SREG;
1786 int32_t addend1 = INVALID_SREG;
1787 if (is_wide) {
1788 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1789 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1790 } else {
1791 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1792 }
1793
1794 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1795 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1796 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1797 // Clear the original multiply product ssa use count, as it is not used anymore.
1798 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1799 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1800 if (is_wide) {
1801 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1802 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1803 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1804 add_mir->ssa_rep->uses[4] = addend0;
1805 add_mir->ssa_rep->uses[5] = addend1;
1806 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1807 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1808 } else {
1809 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1810 add_mir->ssa_rep->uses[2] = addend0;
1811 }
1812 // Copy in the decoded instruction information.
1813 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1814 if (is_wide) {
1815 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1816 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1817 } else {
1818 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1819 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1820 }
1821 // Original multiply MIR is set to Nop.
1822 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1823}
1824
1825void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1826 if (bb->block_type == kDead) {
1827 return;
1828 }
1829 ScopedArenaAllocator allocator(&cu_->arena_stack);
1830 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1831 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1832 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1833 Instruction::Code opcode = mir->dalvikInsn.opcode;
1834 bool is_sub = true;
1835 bool is_candidate_multiply = false;
1836 switch (opcode) {
1837 case Instruction::MUL_INT:
1838 case Instruction::MUL_INT_2ADDR:
1839 is_candidate_multiply = true;
1840 break;
1841 case Instruction::MUL_LONG:
1842 case Instruction::MUL_LONG_2ADDR:
1843 if (cu_->target64) {
1844 is_candidate_multiply = true;
1845 }
1846 break;
1847 case Instruction::ADD_INT:
1848 case Instruction::ADD_INT_2ADDR:
1849 is_sub = false;
1850 FALLTHROUGH_INTENDED;
1851 case Instruction::SUB_INT:
1852 case Instruction::SUB_INT_2ADDR:
1853 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1854 // a*b+c
1855 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1856 false /* is_wide */, false /* is_sub */);
1857 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1858 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1859 // c+a*b or c-a*b
1860 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1861 false /* is_wide */, is_sub);
1862 ssa_mul_map.erase(map_it);
1863 }
1864 break;
1865 case Instruction::ADD_LONG:
1866 case Instruction::ADD_LONG_2ADDR:
1867 is_sub = false;
1868 FALLTHROUGH_INTENDED;
1869 case Instruction::SUB_LONG:
1870 case Instruction::SUB_LONG_2ADDR:
1871 if (!cu_->target64) {
1872 break;
1873 }
1874 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1875 // a*b+c
1876 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1877 true /* is_wide */, false /* is_sub */);
1878 ssa_mul_map.erase(map_it);
1879 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1880 // c+a*b or c-a*b
1881 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1882 true /* is_wide */, is_sub);
1883 ssa_mul_map.erase(map_it);
1884 }
1885 break;
1886 default:
1887 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1888 // Should not combine multiply and add MIRs across potential exception.
1889 ssa_mul_map.clear();
1890 }
1891 break;
1892 }
1893
1894 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1895 // It is because that current RA may allocate the same physical register to them. For this
1896 // kind of cases, the multiplier has been updated, we should not use updated value to the
1897 // multiply-add insn.
1898 if (ssa_mul_map.size() > 0) {
1899 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1900 MIR* mul = it->second;
1901 if (HasAntiDependency(mul, mir)) {
1902 it = ssa_mul_map.erase(it);
1903 } else {
1904 ++it;
1905 }
1906 }
1907 }
1908
1909 if (is_candidate_multiply &&
1910 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1911 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1912 }
1913 }
1914}
1915
buzbee311ca162013-02-28 15:56:43 -08001916} // namespace art