blob: 8674e727bbc2f39d5affa32906c920efcd1bd08c [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
24#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070025#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000026#include "dex/verified_method.h"
27#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000028#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010029#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000030#include "driver/dex_compilation_unit.h"
31#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010032#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000033#include "jit/jit.h"
34#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000035#include "mirror/class_loader.h"
36#include "mirror/dex_cache.h"
37#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010038#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010039#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070040#include "register_allocator_linear_scan.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010041#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000042#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000043#include "ssa_phi_elimination.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070044#include "scoped_thread_state_change-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "thread.h"
46
47namespace art {
48
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000049// Instruction limit to control memory.
50static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
51
52// Maximum number of instructions for considering a method small,
53// which we will always try to inline if the other non-instruction limits
54// are not reached.
55static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000056
57// Limit the number of dex registers that we accumulate while inlining
58// to avoid creating large amount of nested environments.
59static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
60
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000061// Limit recursive call inlining, which do not benefit from too
62// much inlining compared to code locality.
63static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070064
Calin Juravlee2492d42017-03-20 11:42:13 -070065// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070066static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070067
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000068// We check for line numbers to make sure the DepthString implementation
69// aligns the output nicely.
70#define LOG_INTERNAL(msg) \
71 static_assert(__LINE__ > 10, "Unhandled line number"); \
72 static_assert(__LINE__ < 10000, "Unhandled line number"); \
73 VLOG(compiler) << DepthString(__LINE__) << msg
74
75#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
76#define LOG_NOTE() LOG_INTERNAL("Note: ")
77#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
78#define LOG_FAIL(stat) MaybeRecordStat(stat); LOG_INTERNAL("Fail: ")
79#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
80
81std::string HInliner::DepthString(int line) const {
82 std::string value;
83 // Indent according to the inlining depth.
84 size_t count = depth_;
85 // Line numbers get printed in the log, so add a space if the log's line is less
86 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
87 if (!kIsTargetBuild) {
88 if (line < 100) {
89 value += " ";
90 }
91 if (line < 1000) {
92 value += " ";
93 }
94 // Safeguard if this file reaches more than 10000 lines.
95 DCHECK_LT(line, 10000);
96 }
97 for (size_t i = 0; i < count; ++i) {
98 value += " ";
99 }
100 return value;
101}
102
103static size_t CountNumberOfInstructions(HGraph* graph) {
104 size_t number_of_instructions = 0;
105 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
106 for (HInstructionIterator instr_it(block->GetInstructions());
107 !instr_it.Done();
108 instr_it.Advance()) {
109 ++number_of_instructions;
110 }
111 }
112 return number_of_instructions;
113}
114
115void HInliner::UpdateInliningBudget() {
116 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
117 // Always try to inline small methods.
118 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
119 } else {
120 inlining_budget_ = std::max(
121 kMaximumNumberOfInstructionsForSmallMethod,
122 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
123 }
124}
125
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000126void HInliner::Run() {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000127 if (graph_->IsDebuggable()) {
128 // For simplicity, we currently never inline when the graph is debuggable. This avoids
129 // doing some logic in the runtime to discover if a method could have been inlined.
130 return;
131 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000132
133 // Initialize the number of instructions for the method being compiled. Recursive calls
134 // to HInliner::Run have already updated the instruction count.
135 if (outermost_graph_ == graph_) {
136 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
137 }
138
139 UpdateInliningBudget();
140 DCHECK_NE(total_number_of_instructions_, 0u);
141 DCHECK_NE(inlining_budget_, 0u);
142
Roland Levillain6c3af162017-04-27 11:18:56 +0100143 // If we're compiling with a core image (which is only used for
144 // test purposes), honor inlining directives in method names:
145 // - if a method's name contains the substring "$inline$", ensure
146 // that this method is actually inlined;
147 // - if a method's name contains the substring "$noinline$", do not
148 // inline that method.
149 const bool honor_inlining_directives = IsCompilingWithCoreImage();
150
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000151 // Keep a copy of all blocks when starting the visit.
152 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100153 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000154 // Because we are changing the graph when inlining,
155 // we just iterate over the blocks of the outer method.
156 // This avoids doing the inlining work again on the inlined blocks.
157 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000158 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
159 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100160 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700161 // As long as the call is not intrinsified, it is worth trying to inline.
162 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Roland Levillain6c3af162017-04-27 11:18:56 +0100163 if (honor_inlining_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000164 // Debugging case: directives in method names control or assert on inlining.
165 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
166 call->GetDexMethodIndex(), /* with_signature */ false);
167 // Tests prevent inlining by having $noinline$ in their method names.
168 if (callee_name.find("$noinline$") == std::string::npos) {
169 if (!TryInline(call)) {
170 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
171 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
172 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000173 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100174 } else {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000175 // Normal case: try to inline.
176 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000177 }
178 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000179 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000180 }
181 }
182}
183
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100184static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700185 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100186 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
187}
188
189/**
190 * Given the `resolved_method` looked up in the dex cache, try to find
191 * the actual runtime target of an interface or virtual call.
192 * Return nullptr if the runtime target cannot be proven.
193 */
194static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700195 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100196 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
197 // No need to lookup further, the resolved method will be the target.
198 return resolved_method;
199 }
200
201 HInstruction* receiver = invoke->InputAt(0);
202 if (receiver->IsNullCheck()) {
203 // Due to multiple levels of inlining within the same pass, it might be that
204 // null check does not have the reference type of the actual receiver.
205 receiver = receiver->InputAt(0);
206 }
207 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000208 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
209 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100210 // We currently only support inlining with known receivers.
211 // TODO: Remove this check, we should be able to inline final methods
212 // on unknown receivers.
213 return nullptr;
214 } else if (info.GetTypeHandle()->IsInterface()) {
215 // Statically knowing that the receiver has an interface type cannot
216 // help us find what is the target method.
217 return nullptr;
218 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
219 // The method that we're trying to call is not in the receiver's class or super classes.
220 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000221 } else if (info.GetTypeHandle()->IsErroneous()) {
222 // If the type is erroneous, do not go further, as we are going to query the vtable or
223 // imt table, that we can only safely do on non-erroneous classes.
224 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100225 }
226
227 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700228 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 if (invoke->IsInvokeInterface()) {
230 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
231 resolved_method, pointer_size);
232 } else {
233 DCHECK(invoke->IsInvokeVirtual());
234 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
235 resolved_method, pointer_size);
236 }
237
238 if (resolved_method == nullptr) {
239 // The information we had on the receiver was not enough to find
240 // the target method. Since we check above the exact type of the receiver,
241 // the only reason this can happen is an IncompatibleClassChangeError.
242 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700243 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100244 // The information we had on the receiver was not enough to find
245 // the target method. Since we check above the exact type of the receiver,
246 // the only reason this can happen is an IncompatibleClassChangeError.
247 return nullptr;
248 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
249 // A final method has to be the target method.
250 return resolved_method;
251 } else if (info.IsExact()) {
252 // If we found a method and the receiver's concrete type is statically
253 // known, we know for sure the target.
254 return resolved_method;
255 } else {
256 // Even if we did find a method, the receiver type was not enough to
257 // statically find the runtime target.
258 return nullptr;
259 }
260}
261
262static uint32_t FindMethodIndexIn(ArtMethod* method,
263 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000264 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700265 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100266 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100267 return method->GetDexMethodIndex();
268 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000269 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100270 }
271}
272
Andreas Gampea5b09a62016-11-17 15:21:22 -0800273static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000274 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700275 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000276 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800277 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100278 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700279 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000280 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800281 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700282 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100283 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100284 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000285 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000286 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100287 } else {
288 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000289 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100290 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000291 // the right class already resolved with the class loader.
292 if (index.IsValid()) {
293 ObjPtr<mirror::Class> resolved = ClassLinker::LookupResolvedType(
294 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
295 if (resolved != cls) {
296 index = dex::TypeIndex::Invalid();
297 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100298 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100299 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000300
301 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100302}
303
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000304class ScopedProfilingInfoInlineUse {
305 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000306 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
307 : method_(method),
308 self_(self),
309 // Fetch the profiling info ahead of using it. If it's null when fetching,
310 // we should not call JitCodeCache::DoneInlining.
311 profiling_info_(
312 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000313 }
314
315 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000316 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700317 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000318 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
319 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
320 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000321 }
322
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000323 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
324
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000325 private:
326 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000327 Thread* const self_;
328 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000329};
330
Calin Juravle13439f02017-02-21 01:17:21 -0800331HInliner::InlineCacheType HInliner::GetInlineCacheType(
332 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
333 REQUIRES_SHARED(Locks::mutator_lock_) {
334 uint8_t number_of_types = 0;
335 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
336 if (classes->Get(number_of_types) == nullptr) {
337 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000338 }
339 }
Calin Juravle13439f02017-02-21 01:17:21 -0800340
341 if (number_of_types == 0) {
342 return kInlineCacheUninitialized;
343 } else if (number_of_types == 1) {
344 return kInlineCacheMonomorphic;
345 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
346 return kInlineCacheMegamorphic;
347 } else {
348 return kInlineCachePolymorphic;
349 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000350}
351
352static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
353 REQUIRES_SHARED(Locks::mutator_lock_) {
354 DCHECK(classes->Get(0) != nullptr);
355 return classes->Get(0);
356}
357
Mingyao Yang063fc772016-08-02 11:02:54 -0700358ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
359 if (!resolved_method->HasSingleImplementation()) {
360 return nullptr;
361 }
362 if (Runtime::Current()->IsAotCompiler()) {
363 // No CHA-based devirtulization for AOT compiler (yet).
364 return nullptr;
365 }
366 if (outermost_graph_->IsCompilingOsr()) {
367 // We do not support HDeoptimize in OSR methods.
368 return nullptr;
369 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800370 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000371 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
372 if (single_impl == nullptr) {
373 return nullptr;
374 }
375 if (single_impl->IsProxyMethod()) {
376 // Proxy method is a generic invoker that's not worth
377 // devirtualizing/inlining. It also causes issues when the proxy
378 // method is in another dex file if we try to rewrite invoke-interface to
379 // invoke-virtual because a proxy method doesn't have a real dex file.
380 return nullptr;
381 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100382 if (!single_impl->GetDeclaringClass()->IsResolved()) {
383 // There's a race with the class loading, which updates the CHA info
384 // before setting the class to resolved. So we just bail for this
385 // rare occurence.
386 return nullptr;
387 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000388 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700389}
390
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700391bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000392 if (invoke_instruction->IsInvokeUnresolved() ||
393 invoke_instruction->IsInvokePolymorphic()) {
394 return false; // Don't bother to move further if we know the method is unresolved or an
395 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100396 }
397
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000398 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100399 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000400 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000401 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000402
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100403 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100404 if (resolved_method == nullptr) {
405 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
406 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000407 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100408 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000409 }
410 ArtMethod* actual_method = nullptr;
411
412 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800413 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000414 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100415 // Check if we can statically find the method.
416 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000417 }
418
Mingyao Yang063fc772016-08-02 11:02:54 -0700419 bool cha_devirtualize = false;
420 if (actual_method == nullptr) {
421 ArtMethod* method = TryCHADevirtualization(resolved_method);
422 if (method != nullptr) {
423 cha_devirtualize = true;
424 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000425 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700426 }
427 }
428
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100429 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700430 bool result = TryInlineAndReplace(invoke_instruction,
431 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000432 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700433 /* do_rtp */ true,
434 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000435 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700436 if (cha_devirtualize) {
437 // Add dependency due to devirtulization. We've assumed resolved_method
438 // has single implementation.
439 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
440 MaybeRecordStat(kCHAInline);
441 } else {
442 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
443 }
Calin Juravle69158982016-03-16 11:53:41 +0000444 }
445 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100446 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800447 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100448
Calin Juravle13439f02017-02-21 01:17:21 -0800449 // Try using inline caches.
450 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
451}
452
453static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
454 const DexCompilationUnit& compilation_unit,
455 StackHandleScope<1>* hs)
456 REQUIRES_SHARED(Locks::mutator_lock_) {
457 Thread* self = Thread::Current();
458 ClassLinker* class_linker = compilation_unit.GetClassLinker();
459 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
460 mirror::ObjectArray<mirror::Class>::Alloc(
461 self,
462 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
463 InlineCache::kIndividualCacheSize));
464 if (inline_cache == nullptr) {
465 // We got an OOME. Just clear the exception, and don't inline.
466 DCHECK(self->IsExceptionPending());
467 self->ClearException();
468 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
469 }
470 return inline_cache;
471}
472
473bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
474 HInvoke* invoke_instruction,
475 ArtMethod* resolved_method)
476 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700477 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
478 return false;
479 }
480
Calin Juravle13439f02017-02-21 01:17:21 -0800481 StackHandleScope<1> hs(Thread::Current());
482 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
483 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
484 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
485 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
486
487 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000488 case kInlineCacheNoData: {
489 LOG_FAIL_NO_STAT()
490 << "Interface or virtual call to "
491 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
492 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800493 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000494 }
Calin Juravle13439f02017-02-21 01:17:21 -0800495
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000496 case kInlineCacheUninitialized: {
497 LOG_FAIL_NO_STAT()
498 << "Interface or virtual call to "
499 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
500 << " is not hit and not inlined";
501 return false;
502 }
503
504 case kInlineCacheMonomorphic: {
Calin Juravle13439f02017-02-21 01:17:21 -0800505 MaybeRecordStat(kMonomorphicCall);
506 if (outermost_graph_->IsCompilingOsr()) {
507 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
508 // interpreter and it may have seen different receiver types.
509 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000510 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800511 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000512 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000513 }
Calin Juravle13439f02017-02-21 01:17:21 -0800514
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000515 case kInlineCachePolymorphic: {
Calin Juravle13439f02017-02-21 01:17:21 -0800516 MaybeRecordStat(kPolymorphicCall);
517 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000518 }
Calin Juravle13439f02017-02-21 01:17:21 -0800519
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000520 case kInlineCacheMegamorphic: {
521 LOG_FAIL_NO_STAT()
522 << "Interface or virtual call to "
523 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
524 << " is megamorphic and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800525 MaybeRecordStat(kMegamorphicCall);
526 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000527 }
Calin Juravle13439f02017-02-21 01:17:21 -0800528
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000529 case kInlineCacheMissingTypes: {
530 LOG_FAIL_NO_STAT()
531 << "Interface or virtual call to "
532 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
533 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800534 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000535 }
Calin Juravle13439f02017-02-21 01:17:21 -0800536 }
537 UNREACHABLE();
538}
539
540HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
541 HInvoke* invoke_instruction,
542 StackHandleScope<1>* hs,
543 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
544 REQUIRES_SHARED(Locks::mutator_lock_) {
545 DCHECK(Runtime::Current()->UseJitCompilation());
546
547 ArtMethod* caller = graph_->GetArtMethod();
548 // Under JIT, we should always know the caller.
549 DCHECK(caller != nullptr);
550 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
551 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
552
553 if (profiling_info == nullptr) {
554 return kInlineCacheNoData;
555 }
556
557 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
558 if (inline_cache->Get() == nullptr) {
559 // We can't extract any data if we failed to allocate;
560 return kInlineCacheNoData;
561 } else {
562 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
563 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
564 *inline_cache);
565 return GetInlineCacheType(*inline_cache);
566 }
567}
568
569HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
570 const DexFile& caller_dex_file,
571 HInvoke* invoke_instruction,
572 StackHandleScope<1>* hs,
573 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
574 REQUIRES_SHARED(Locks::mutator_lock_) {
575 DCHECK(Runtime::Current()->IsAotCompiler());
576 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
577 if (pci == nullptr) {
578 return kInlineCacheNoData;
579 }
580
581 ProfileCompilationInfo::OfflineProfileMethodInfo offline_profile;
582 bool found = pci->GetMethod(caller_dex_file.GetLocation(),
583 caller_dex_file.GetLocationChecksum(),
584 caller_compilation_unit_.GetDexMethodIndex(),
585 &offline_profile);
586 if (!found) {
587 return kInlineCacheNoData; // no profile information for this invocation.
588 }
589
590 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
591 if (inline_cache == nullptr) {
592 // We can't extract any data if we failed to allocate;
593 return kInlineCacheNoData;
594 } else {
595 return ExtractClassesFromOfflineProfile(invoke_instruction,
596 offline_profile,
597 *inline_cache);
598 }
599}
600
601HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
602 const HInvoke* invoke_instruction,
603 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
604 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
605 REQUIRES_SHARED(Locks::mutator_lock_) {
606 const auto it = offline_profile.inline_caches.find(invoke_instruction->GetDexPc());
607 if (it == offline_profile.inline_caches.end()) {
608 return kInlineCacheUninitialized;
609 }
610
611 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
612
613 if (dex_pc_data.is_missing_types) {
614 return kInlineCacheMissingTypes;
615 }
616 if (dex_pc_data.is_megamorphic) {
617 return kInlineCacheMegamorphic;
618 }
619
620 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
621 Thread* self = Thread::Current();
622 // We need to resolve the class relative to the containing dex file.
623 // So first, build a mapping from the index of dex file in the profile to
624 // its dex cache. This will avoid repeating the lookup when walking over
625 // the inline cache types.
626 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
627 offline_profile.dex_references.size());
628 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
629 bool found = false;
630 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
631 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
632 dex_profile_index_to_dex_cache[i] =
633 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
634 found = true;
635 }
636 }
637 if (!found) {
638 VLOG(compiler) << "Could not find profiled dex file: "
639 << offline_profile.dex_references[i].dex_location;
640 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100641 }
642 }
643
Calin Juravle13439f02017-02-21 01:17:21 -0800644 // Walk over the classes and resolve them. If we cannot find a type we return
645 // kInlineCacheMissingTypes.
646 int ic_index = 0;
647 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
648 ObjPtr<mirror::DexCache> dex_cache =
649 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
650 DCHECK(dex_cache != nullptr);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000651 ObjPtr<mirror::Class> clazz = ClassLinker::LookupResolvedType(
652 class_ref.type_index,
653 dex_cache,
654 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800655 if (clazz != nullptr) {
656 inline_cache->Set(ic_index++, clazz);
657 } else {
658 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
659 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
660 invoke_instruction->GetDexMethodIndex()) << " : "
661 << caller_compilation_unit_
662 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
663 return kInlineCacheMissingTypes;
664 }
665 }
666 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100667}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000668
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000669HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
670 HInstruction* receiver,
671 uint32_t dex_pc) const {
672 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
673 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000674 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000675 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000676 field,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000677 Primitive::kPrimNot,
678 field->GetOffset(),
679 field->IsVolatile(),
680 field->GetDexFieldIndex(),
681 field->GetDeclaringClass()->GetDexClassDefIndex(),
682 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000683 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000684 // The class of a field is effectively final, and does not have any memory dependencies.
685 result->SetSideEffects(SideEffects::None());
686 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000687}
688
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000689static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
690 ArtMethod* resolved_method,
691 HInstruction* invoke_instruction,
692 PointerSize pointer_size)
693 REQUIRES_SHARED(Locks::mutator_lock_) {
694 if (Runtime::Current()->IsAotCompiler()) {
695 // We can get unrelated types when working with profiles (corruption,
696 // systme updates, or anyone can write to it). So first check if the class
697 // actually implements the declaring class of the method that is being
698 // called in bytecode.
699 // Note: the lookup methods used below require to have assignable types.
700 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
701 return nullptr;
702 }
703 }
704
705 if (invoke_instruction->IsInvokeInterface()) {
706 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
707 } else {
708 DCHECK(invoke_instruction->IsInvokeVirtual());
709 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
710 }
711 DCHECK(resolved_method != nullptr);
712 return resolved_method;
713}
714
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100715bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
716 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000717 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000718 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
719 << invoke_instruction->DebugName();
720
Andreas Gampea5b09a62016-11-17 15:21:22 -0800721 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000722 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800723 if (!class_index.IsValid()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000724 LOG_FAIL(kNotInlinedDexCache)
725 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
726 << " from inline cache is not inlined because its class is not"
727 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100728 return false;
729 }
730
731 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700732 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000733 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
734 resolved_method = ResolveMethodFromInlineCache(
735 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
736
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000737 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000738 if (resolved_method == nullptr) {
739 // Bogus AOT profile, bail.
740 DCHECK(Runtime::Current()->IsAotCompiler());
741 return false;
742 }
743
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100744 HInstruction* receiver = invoke_instruction->InputAt(0);
745 HInstruction* cursor = invoke_instruction->GetPrevious();
746 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700747 if (!TryInlineAndReplace(invoke_instruction,
748 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000749 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700750 /* do_rtp */ false,
751 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100752 return false;
753 }
754
755 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000756 AddTypeGuard(receiver,
757 cursor,
758 bb_cursor,
759 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000760 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000761 invoke_instruction,
762 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100763
764 // Run type propagation to get the guard typed, and eventually propagate the
765 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000766 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000767 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000768 outer_compilation_unit_.GetDexCache(),
769 handles_,
770 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100771 rtp_fixup.Run();
772
773 MaybeRecordStat(kInlinedMonomorphicCall);
774 return true;
775}
776
Mingyao Yang063fc772016-08-02 11:02:54 -0700777void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
778 uint32_t dex_pc,
779 HInstruction* cursor,
780 HBasicBlock* bb_cursor) {
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800781 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetArena())
782 HShouldDeoptimizeFlag(graph_->GetArena(), dex_pc);
783 HInstruction* compare = new (graph_->GetArena()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700784 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000785 HInstruction* deopt = new (graph_->GetArena()) HDeoptimize(
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100786 graph_->GetArena(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700787
788 if (cursor != nullptr) {
789 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
790 } else {
791 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
792 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800793 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
794 bb_cursor->InsertInstructionAfter(deopt, compare);
795
796 // Add receiver as input to aid CHA guard optimization later.
797 deopt_flag->AddInput(invoke_instruction->InputAt(0));
798 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700799 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800800 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700801}
802
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000803HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
804 HInstruction* cursor,
805 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800806 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000807 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000808 HInstruction* invoke_instruction,
809 bool with_deoptimization) {
810 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
811 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
812 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000813 if (cursor != nullptr) {
814 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
815 } else {
816 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
817 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000818
819 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700820 bool is_referrer;
821 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
822 if (outermost_art_method == nullptr) {
823 DCHECK(Runtime::Current()->IsAotCompiler());
824 // We are in AOT mode and we don't have an ART method to determine
825 // if the inlined method belongs to the referrer. Assume it doesn't.
826 is_referrer = false;
827 } else {
828 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
829 }
830
Nicolas Geoffray56876342016-12-16 16:09:08 +0000831 // Note that we will just compare the classes, so we don't need Java semantics access checks.
832 // Note that the type index and the dex file are relative to the method this type guard is
833 // inlined into.
834 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
835 class_index,
836 caller_dex_file,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000837 klass,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000838 is_referrer,
839 invoke_instruction->GetDexPc(),
840 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000841 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000842 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
843 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
844 << "We should always be able to reference a class for inline caches";
845 // Insert before setting the kind, as setting the kind affects the inputs.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000846 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000847 load_class->SetLoadKind(kind);
Calin Juravle13439f02017-02-21 01:17:21 -0800848 // In AOT mode, we will most likely load the class from BSS, which will involve a call
849 // to the runtime. In this case, the load instruction will need an environment so copy
850 // it from the invoke instruction.
851 if (load_class->NeedsEnvironment()) {
852 DCHECK(Runtime::Current()->IsAotCompiler());
853 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
854 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000855
Nicolas Geoffray56876342016-12-16 16:09:08 +0000856 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000857 bb_cursor->InsertInstructionAfter(compare, load_class);
858 if (with_deoptimization) {
859 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000860 graph_->GetArena(),
861 compare,
862 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100863 Runtime::Current()->IsAotCompiler()
864 ? DeoptimizationKind::kAotInlineCache
865 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000866 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000867 bb_cursor->InsertInstructionAfter(deoptimize, compare);
868 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000869 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
870 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
871 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000872 }
873 return compare;
874}
875
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000876bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100877 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000878 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000879 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
880 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000881
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000882 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000883 return true;
884 }
885
886 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700887 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000888
889 bool all_targets_inlined = true;
890 bool one_target_inlined = false;
891 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000892 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000893 break;
894 }
895 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000896
897 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000898 method = ResolveMethodFromInlineCache(
899 handle, resolved_method, invoke_instruction, pointer_size);
900 if (method == nullptr) {
901 DCHECK(Runtime::Current()->IsAotCompiler());
902 // AOT profile is bogus. This loop expects to iterate over all entries,
903 // so just just continue.
904 all_targets_inlined = false;
905 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000906 }
907
908 HInstruction* receiver = invoke_instruction->InputAt(0);
909 HInstruction* cursor = invoke_instruction->GetPrevious();
910 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
911
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000912 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000913 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000914 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800915 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000916 !TryBuildAndInline(invoke_instruction,
917 method,
918 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
919 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000920 all_targets_inlined = false;
921 } else {
922 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000923
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000924 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
925 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000926
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000927 // If we have inlined all targets before, and this receiver is the last seen,
928 // we deoptimize instead of keeping the original invoke instruction.
929 bool deoptimize = all_targets_inlined &&
930 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000931 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100932
933 if (outermost_graph_->IsCompilingOsr()) {
934 // We do not support HDeoptimize in OSR methods.
935 deoptimize = false;
936 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000937 HInstruction* compare = AddTypeGuard(receiver,
938 cursor,
939 bb_cursor,
940 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000941 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000942 invoke_instruction,
943 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000944 if (deoptimize) {
945 if (return_replacement != nullptr) {
946 invoke_instruction->ReplaceWith(return_replacement);
947 }
948 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
949 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000950 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000951 break;
952 } else {
953 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
954 }
955 }
956 }
957
958 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000959 LOG_FAIL_NO_STAT()
960 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
961 << " from inline cache is not inlined because none"
962 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000963 return false;
964 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000965
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000966 MaybeRecordStat(kInlinedPolymorphicCall);
967
968 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000969 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000970 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000971 outer_compilation_unit_.GetDexCache(),
972 handles_,
973 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000974 rtp_fixup.Run();
975 return true;
976}
977
978void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
979 HInstruction* return_replacement,
980 HInstruction* invoke_instruction) {
981 uint32_t dex_pc = invoke_instruction->GetDexPc();
982 HBasicBlock* cursor_block = compare->GetBlock();
983 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
984 ArenaAllocator* allocator = graph_->GetArena();
985
986 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
987 // and the returned block is the start of the then branch (that could contain multiple blocks).
988 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
989
990 // Split the block containing the invoke before and after the invoke. The returned block
991 // of the split before will contain the invoke and will be the otherwise branch of
992 // the diamond. The returned block of the split after will be the merge block
993 // of the diamond.
994 HBasicBlock* end_then = invoke_instruction->GetBlock();
995 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
996 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
997
998 // If the methods we are inlining return a value, we create a phi in the merge block
999 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1000 if (return_replacement != nullptr) {
1001 HPhi* phi = new (allocator) HPhi(
1002 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1003 merge->AddPhi(phi);
1004 invoke_instruction->ReplaceWith(phi);
1005 phi->AddInput(return_replacement);
1006 phi->AddInput(invoke_instruction);
1007 }
1008
1009 // Add the control flow instructions.
1010 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1011 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1012 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1013
1014 // Add the newly created blocks to the graph.
1015 graph_->AddBlock(then);
1016 graph_->AddBlock(otherwise);
1017 graph_->AddBlock(merge);
1018
1019 // Set up successor (and implictly predecessor) relations.
1020 cursor_block->AddSuccessor(otherwise);
1021 cursor_block->AddSuccessor(then);
1022 end_then->AddSuccessor(merge);
1023 otherwise->AddSuccessor(merge);
1024
1025 // Set up dominance information.
1026 then->SetDominator(cursor_block);
1027 cursor_block->AddDominatedBlock(then);
1028 otherwise->SetDominator(cursor_block);
1029 cursor_block->AddDominatedBlock(otherwise);
1030 merge->SetDominator(cursor_block);
1031 cursor_block->AddDominatedBlock(merge);
1032
1033 // Update the revert post order.
1034 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1035 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1036 graph_->reverse_post_order_[++index] = then;
1037 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1038 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1039 graph_->reverse_post_order_[++index] = otherwise;
1040 graph_->reverse_post_order_[++index] = merge;
1041
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001042
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001043 graph_->UpdateLoopAndTryInformationOfNewBlock(
1044 then, original_invoke_block, /* replace_if_back_edge */ false);
1045 graph_->UpdateLoopAndTryInformationOfNewBlock(
1046 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1047
1048 // In case the original invoke location was a back edge, we need to update
1049 // the loop to now have the merge block as a back edge.
1050 graph_->UpdateLoopAndTryInformationOfNewBlock(
1051 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001052}
1053
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001054bool HInliner::TryInlinePolymorphicCallToSameTarget(
1055 HInvoke* invoke_instruction,
1056 ArtMethod* resolved_method,
1057 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001058 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001059 if (!Runtime::Current()->UseJitCompilation()) {
1060 return false;
1061 }
1062
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001063 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001064 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001065
1066 DCHECK(resolved_method != nullptr);
1067 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001068 size_t method_index = invoke_instruction->IsInvokeVirtual()
1069 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1070 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1071
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001072 // Check whether we are actually calling the same method among
1073 // the different types seen.
1074 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001075 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001076 break;
1077 }
1078 ArtMethod* new_method = nullptr;
1079 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001080 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001081 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001082 if (new_method->IsRuntimeMethod()) {
1083 // Bail out as soon as we see a conflict trampoline in one of the target's
1084 // interface table.
1085 return false;
1086 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001087 } else {
1088 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001089 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001090 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001091 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001092 if (actual_method == nullptr) {
1093 actual_method = new_method;
1094 } else if (actual_method != new_method) {
1095 // Different methods, bailout.
1096 return false;
1097 }
1098 }
1099
1100 HInstruction* receiver = invoke_instruction->InputAt(0);
1101 HInstruction* cursor = invoke_instruction->GetPrevious();
1102 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1103
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001104 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001105 if (!TryBuildAndInline(invoke_instruction,
1106 actual_method,
1107 ReferenceTypeInfo::CreateInvalid(),
1108 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001109 return false;
1110 }
1111
1112 // We successfully inlined, now add a guard.
1113 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1114 class_linker, receiver, invoke_instruction->GetDexPc());
1115
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001116 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1117 ? Primitive::kPrimLong
1118 : Primitive::kPrimInt;
1119 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
1120 receiver_class,
1121 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001122 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1123 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001124 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001125 invoke_instruction->GetDexPc());
1126
1127 HConstant* constant;
1128 if (type == Primitive::kPrimLong) {
1129 constant = graph_->GetLongConstant(
1130 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1131 } else {
1132 constant = graph_->GetIntConstant(
1133 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1134 }
1135
1136 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001137 if (cursor != nullptr) {
1138 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1139 } else {
1140 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1141 }
1142 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1143 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001144
1145 if (outermost_graph_->IsCompilingOsr()) {
1146 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1147 } else {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001148 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001149 graph_->GetArena(),
1150 compare,
1151 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001152 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001153 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001154 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1155 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1156 if (return_replacement != nullptr) {
1157 invoke_instruction->ReplaceWith(return_replacement);
1158 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001159 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001160 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001161 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001162 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001163
1164 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001165 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001166 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001167 outer_compilation_unit_.GetDexCache(),
1168 handles_,
1169 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001170 rtp_fixup.Run();
1171
1172 MaybeRecordStat(kInlinedPolymorphicCall);
1173
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001174 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001175 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001176}
1177
Mingyao Yang063fc772016-08-02 11:02:54 -07001178bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1179 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001180 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001181 bool do_rtp,
1182 bool cha_devirtualize) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001183 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001184 uint32_t dex_pc = invoke_instruction->GetDexPc();
1185 HInstruction* cursor = invoke_instruction->GetPrevious();
1186 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001187 if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001188 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001189 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001190 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1191 // better than an invoke-interface because:
1192 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1193 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1194 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001195
1196 if (method->IsDefault() && !method->IsCopied()) {
1197 // Changing to invoke-virtual cannot be done on an original default method
1198 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1199 // always uses a method in the iftable which is never an original default
1200 // method.
1201 // On the other hand, inlining an original default method by CHA is fine.
1202 DCHECK(cha_devirtualize);
1203 return false;
1204 }
1205
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001206 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001207 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001208 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001209 if (dex_method_index == DexFile::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001210 return false;
1211 }
1212 HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual(
1213 graph_->GetArena(),
1214 invoke_instruction->GetNumberOfArguments(),
1215 invoke_instruction->GetType(),
1216 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001217 dex_method_index,
1218 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001219 method->GetMethodIndex());
1220 HInputsRef inputs = invoke_instruction->GetInputs();
1221 for (size_t index = 0; index != inputs.size(); ++index) {
1222 new_invoke->SetArgumentAt(index, inputs[index]);
1223 }
1224 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1225 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1226 if (invoke_instruction->GetType() == Primitive::kPrimNot) {
1227 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1228 }
1229 return_replacement = new_invoke;
1230 } else {
1231 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1232 // compiler driver.
1233 return false;
1234 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001235 }
Mingyao Yang063fc772016-08-02 11:02:54 -07001236 if (cha_devirtualize) {
1237 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1238 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001239 if (return_replacement != nullptr) {
1240 invoke_instruction->ReplaceWith(return_replacement);
1241 }
1242 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +01001243 FixUpReturnReferenceType(method, return_replacement);
1244 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1245 // Actual return value has a more specific type than the method's declared
1246 // return type. Run RTP again on the outer graph to propagate it.
1247 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001248 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001249 outer_compilation_unit_.GetDexCache(),
1250 handles_,
1251 /* is_first_run */ false).Run();
1252 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001253 return true;
1254}
1255
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001256size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1257 const HInliner* current = this;
1258 size_t count = 0;
1259 do {
1260 if (current->graph_->GetArtMethod() == method) {
1261 ++count;
1262 }
1263 current = current->parent_;
1264 } while (current != nullptr);
1265 return count;
1266}
1267
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001268bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1269 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001270 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001271 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001272 if (method->IsProxyMethod()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001273 LOG_FAIL(kNotInlinedProxy)
1274 << "Method " << method->PrettyMethod()
1275 << " is not inlined because of unimplemented inline support for proxy methods.";
1276 return false;
1277 }
1278
1279 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
1280 LOG_FAIL(kNotInlinedRecursiveBudget)
1281 << "Method "
1282 << method->PrettyMethod()
1283 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001284 return false;
1285 }
1286
Jeff Haodcdc85b2015-12-04 14:06:18 -08001287 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1288 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1289 if (!compiler_driver_->MayInline(method->GetDexFile(),
1290 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001291 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001292 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1293 << method->PrettyMethod();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001294 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
1295 return true;
1296 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001297 LOG_FAIL(kNotInlinedWont)
1298 << "Won't inline " << method->PrettyMethod() << " in "
1299 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1300 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1301 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001302 return false;
1303 }
1304
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001305 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1306
1307 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001308
1309 if (code_item == nullptr) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001310 LOG_FAIL_NO_STAT()
1311 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001312 return false;
1313 }
1314
Calin Juravleec748352015-07-29 13:52:12 +01001315 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
1316 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001317 LOG_FAIL(kNotInlinedCodeItem)
1318 << "Method " << method->PrettyMethod()
1319 << " is not inlined because its code item is too big: "
1320 << code_item->insns_size_in_code_units_
1321 << " > "
1322 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001323 return false;
1324 }
1325
1326 if (code_item->tries_size_ != 0) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001327 LOG_FAIL(kNotInlinedTryCatch)
1328 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001329 return false;
1330 }
1331
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001332 if (!method->IsCompilable()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001333 LOG_FAIL(kNotInlinedNotVerified)
1334 << "Method " << method->PrettyMethod()
1335 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001336 }
1337
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001338 if (!method->GetDeclaringClass()->IsVerified()) {
1339 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +01001340 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001341 !compiler_driver_->IsMethodVerifiedWithoutFailures(
1342 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001343 LOG_FAIL(kNotInlinedNotVerified)
1344 << "Method " << method->PrettyMethod()
1345 << " couldn't be verified, so it cannot be inlined";
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001346 return false;
1347 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001348 }
1349
Roland Levillain4c0eb422015-04-24 16:43:49 +01001350 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1351 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1352 // Case of a static method that cannot be inlined because it implicitly
1353 // requires an initialization check of its declaring class.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001354 LOG_FAIL(kNotInlinedDexCache) << "Method " << method->PrettyMethod()
1355 << " is not inlined because it is static and requires a clinit"
1356 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001357 return false;
1358 }
1359
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001360 if (!TryBuildAndInlineHelper(
1361 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001362 return false;
1363 }
1364
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001365 LOG_SUCCESS() << method->PrettyMethod();
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001366 MaybeRecordStat(kInlinedInvoke);
1367 return true;
1368}
1369
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001370static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1371 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001372 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001373 size_t input_index = 0;
1374 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1375 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1376 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
1377 ++i;
1378 DCHECK_NE(i, arg_vreg_index);
1379 }
1380 }
1381 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1382 return invoke_instruction->InputAt(input_index);
1383}
1384
1385// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1386bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1387 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001388 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001389 InlineMethod inline_method;
1390 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1391 return false;
1392 }
1393
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001394 switch (inline_method.opcode) {
1395 case kInlineOpNop:
1396 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001397 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001398 break;
1399 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001400 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1401 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001402 break;
1403 case kInlineOpNonWideConst:
1404 if (resolved_method->GetShorty()[0] == 'L') {
1405 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001406 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001407 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001408 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001409 }
1410 break;
1411 case kInlineOpIGet: {
1412 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1413 if (data.method_is_static || data.object_arg != 0u) {
1414 // TODO: Needs null check.
1415 return false;
1416 }
1417 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001418 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001419 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1420 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1421 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001422 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001423 break;
1424 }
1425 case kInlineOpIPut: {
1426 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1427 if (data.method_is_static || data.object_arg != 0u) {
1428 // TODO: Needs null check.
1429 return false;
1430 }
1431 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1432 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001433 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001434 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1435 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1436 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1437 if (data.return_arg_plus1 != 0u) {
1438 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001439 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001440 }
1441 break;
1442 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001443 case kInlineOpConstructor: {
1444 const InlineConstructorData& data = inline_method.d.constructor_data;
1445 // Get the indexes to arrays for easier processing.
1446 uint16_t iput_field_indexes[] = {
1447 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1448 };
1449 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1450 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1451 // Count valid field indexes.
1452 size_t number_of_iputs = 0u;
1453 while (number_of_iputs != arraysize(iput_field_indexes) &&
1454 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1455 // Check that there are no duplicate valid field indexes.
1456 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1457 iput_field_indexes + arraysize(iput_field_indexes),
1458 iput_field_indexes[number_of_iputs]));
1459 ++number_of_iputs;
1460 }
1461 // Check that there are no valid field indexes in the rest of the array.
1462 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1463 iput_field_indexes + arraysize(iput_field_indexes),
1464 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1465
1466 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001467 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1468 bool needs_constructor_barrier = false;
1469 for (size_t i = 0; i != number_of_iputs; ++i) {
1470 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001471 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001472 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001473 bool is_final;
1474 HInstanceFieldSet* iput =
1475 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001476 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1477
1478 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001479 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001480 needs_constructor_barrier = true;
1481 }
1482 }
1483 }
1484 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001485 // See CompilerDriver::RequiresConstructorBarrier for more details.
1486 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1487
1488 HConstructorFence* constructor_fence =
1489 new (graph_->GetArena()) HConstructorFence(obj, kNoDexPc, graph_->GetArena());
1490 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1491 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001492 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001493 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001494 break;
1495 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001496 default:
1497 LOG(FATAL) << "UNREACHABLE";
1498 UNREACHABLE();
1499 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001500 return true;
1501}
1502
Vladimir Markof44d36c2017-03-14 14:18:46 +00001503HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1504 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001505 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001506 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001507 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1508 ArtField* resolved_field =
1509 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001510 DCHECK(resolved_field != nullptr);
1511 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1512 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001513 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001514 resolved_field->GetTypeAsPrimitiveType(),
1515 resolved_field->GetOffset(),
1516 resolved_field->IsVolatile(),
1517 field_index,
1518 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001519 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001520 // Read barrier generates a runtime call in slow path and we need a valid
1521 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1522 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001523 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001524 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001525 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001526 ReferenceTypePropagation rtp(graph_,
1527 outer_compilation_unit_.GetClassLoader(),
1528 dex_cache,
1529 handles_,
1530 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001531 rtp.Visit(iget);
1532 }
1533 return iget;
1534}
1535
Vladimir Markof44d36c2017-03-14 14:18:46 +00001536HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1537 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001538 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001539 HInstruction* value,
1540 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001541 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001542 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1543 ArtField* resolved_field =
1544 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001545 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001546 if (is_final != nullptr) {
1547 // This information is needed only for constructors.
1548 DCHECK(referrer->IsConstructor());
1549 *is_final = resolved_field->IsFinal();
1550 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001551 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1552 obj,
1553 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001554 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001555 resolved_field->GetTypeAsPrimitiveType(),
1556 resolved_field->GetOffset(),
1557 resolved_field->IsVolatile(),
1558 field_index,
1559 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001560 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001561 // Read barrier generates a runtime call in slow path and we need a valid
1562 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1563 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001564 return iput;
1565}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001566
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001567template <typename T>
1568static inline Handle<T> NewHandleIfDifferent(T* object,
1569 Handle<T> hint,
1570 VariableSizedHandleScope* handles)
1571 REQUIRES_SHARED(Locks::mutator_lock_) {
1572 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1573}
1574
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001575bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1576 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001577 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001578 bool same_dex_file,
1579 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001580 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001581 ScopedObjectAccess soa(Thread::Current());
1582 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001583 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1584 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001585 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001586 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1587 caller_compilation_unit_.GetDexCache(),
1588 handles_);
1589 Handle<mirror::ClassLoader> class_loader =
1590 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1591 caller_compilation_unit_.GetClassLoader(),
1592 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001593
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001594 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001595 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001596 class_linker,
1597 callee_dex_file,
1598 code_item,
1599 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1600 method_index,
1601 resolved_method->GetAccessFlags(),
1602 /* verified_method */ nullptr,
1603 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001604
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001605 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001606 if (invoke_type == kInterface) {
1607 // We have statically resolved the dispatch. To please the class linker
1608 // at runtime, we change this call as if it was a virtual call.
1609 invoke_type = kVirtual;
1610 }
David Brazdil3f523062016-02-29 16:53:33 +00001611
1612 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001613 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001614 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001615 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001616 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001617 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001618 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001619 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001620 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001621 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001622 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001623
Vladimir Marko438709f2017-02-23 18:56:13 +00001624 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001625 // of on the stack, as Clang might produce a stack frame too large
1626 // for this function, that would not fit the requirements of the
1627 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001628 if (stats_ != nullptr) {
1629 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1630 if (inline_stats_ == nullptr) {
1631 void* storage = graph_->GetArena()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
1632 inline_stats_ = new (storage) OptimizingCompilerStats;
1633 } else {
1634 inline_stats_->Reset();
1635 }
1636 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001637 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001638 &dex_compilation_unit,
1639 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001640 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001641 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001642 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001643 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001644 inline_stats_,
Vladimir Marko97d7e1c2016-10-04 14:44:28 +01001645 resolved_method->GetQuickenedInfo(class_linker->GetImagePointerSize()),
David Brazdildee58d62016-04-07 09:54:26 +00001646 dex_cache,
1647 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001648
David Brazdildee58d62016-04-07 09:54:26 +00001649 if (builder.BuildGraph() != kAnalysisSuccess) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001650 LOG_FAIL(kNotInlinedCannotBuild)
1651 << "Method " << callee_dex_file.PrettyMethod(method_index)
1652 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001653 return false;
1654 }
1655
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001656 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1657 compiler_driver_->GetInstructionSet())) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001658 LOG_FAIL(kNotInlinedRegisterAllocator)
1659 << "Method " << callee_dex_file.PrettyMethod(method_index)
1660 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001661 return false;
1662 }
1663
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001664 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001665 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001666 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1667 !instructions.Done();
1668 instructions.Advance()) {
1669 HInstruction* current = instructions.Current();
1670 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001671 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001672 if (argument->IsNullConstant()) {
1673 current->ReplaceWith(callee_graph->GetNullConstant());
1674 } else if (argument->IsIntConstant()) {
1675 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1676 } else if (argument->IsLongConstant()) {
1677 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1678 } else if (argument->IsFloatConstant()) {
1679 current->ReplaceWith(
1680 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1681 } else if (argument->IsDoubleConstant()) {
1682 current->ReplaceWith(
1683 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1684 } else if (argument->GetType() == Primitive::kPrimNot) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001685 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1686 run_rtp = true;
1687 current->SetReferenceTypeInfo(receiver_type);
1688 } else {
1689 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1690 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001691 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1692 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001693 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001694 }
1695 }
1696
David Brazdil94ab38f2016-06-21 17:48:19 +01001697 // We have replaced formal arguments with actual arguments. If actual types
1698 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001699 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001700 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001701 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001702 dex_compilation_unit.GetDexCache(),
1703 handles_,
1704 /* is_first_run */ false).Run();
1705 }
1706
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001707 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001708
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001709 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1710 if (exit_block == nullptr) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001711 LOG_FAIL(kNotInlinedInfiniteLoop)
1712 << "Method " << callee_dex_file.PrettyMethod(method_index)
1713 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001714 return false;
1715 }
1716
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001717 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001718 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1719 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001720 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1721 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001722 LOG_FAIL(kNotInlinedTryCatch)
1723 << "Method " << callee_dex_file.PrettyMethod(method_index)
1724 << " could not be inlined because one branch always throws and"
1725 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001726 return false;
1727 } else if (graph_->GetExitBlock() == nullptr) {
1728 // TODO(ngeoffray): Support adding HExit in the caller graph.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001729 LOG_FAIL(kNotInlinedInfiniteLoop)
1730 << "Method " << callee_dex_file.PrettyMethod(method_index)
1731 << " could not be inlined because one branch always throws and"
1732 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001733 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001734 } else if (graph_->HasIrreducibleLoops()) {
1735 // TODO(ngeoffray): Support re-computing loop information to graphs with
1736 // irreducible loops?
1737 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1738 << " could not be inlined because one branch always throws and"
1739 << " caller has irreducible loops";
1740 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001741 }
1742 } else {
1743 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001744 }
1745 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001746
1747 if (!has_one_return) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001748 LOG_FAIL(kNotInlinedAlwaysThrows)
1749 << "Method " << callee_dex_file.PrettyMethod(method_index)
1750 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001751 return false;
1752 }
1753
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001754 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001755 // Skip the entry block, it does not contain instructions that prevent inlining.
1756 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001757 if (block->IsLoopHeader()) {
1758 if (block->GetLoopInformation()->IsIrreducible()) {
1759 // Don't inline methods with irreducible loops, they could prevent some
1760 // optimizations to run.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001761 LOG_FAIL(kNotInlinedIrreducibleLoop)
1762 << "Method " << callee_dex_file.PrettyMethod(method_index)
1763 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001764 return false;
1765 }
1766 if (!block->GetLoopInformation()->HasExitEdge()) {
1767 // Don't inline methods with loops without exit, since they cause the
1768 // loop information to be computed incorrectly when updating after
1769 // inlining.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001770 LOG_FAIL(kNotInlinedLoopWithoutExit)
1771 << "Method " << callee_dex_file.PrettyMethod(method_index)
1772 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001773 return false;
1774 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001775 }
1776
1777 for (HInstructionIterator instr_it(block->GetInstructions());
1778 !instr_it.Done();
1779 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001780 if (++number_of_instructions >= inlining_budget_) {
1781 LOG_FAIL(kNotInlinedInstructionBudget)
1782 << "Method " << callee_dex_file.PrettyMethod(method_index)
1783 << " is not inlined because the outer method has reached"
1784 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001785 return false;
1786 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001787 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001788 if (current->NeedsEnvironment() &&
1789 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
1790 LOG_FAIL(kNotInlinedEnvironmentBudget)
1791 << "Method " << callee_dex_file.PrettyMethod(method_index)
1792 << " is not inlined because its caller has reached"
1793 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001794 return false;
1795 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001796
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001797 if (current->NeedsEnvironment() &&
1798 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1799 resolved_method)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001800 LOG_FAIL(kNotInlinedStackMaps)
1801 << "Method " << callee_dex_file.PrettyMethod(method_index)
1802 << " could not be inlined because " << current->DebugName()
1803 << " needs an environment, is in a different dex file"
1804 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001805 return false;
1806 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001807
Vladimir Markodc151b22015-10-15 18:02:30 +01001808 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001809 LOG_FAIL(kNotInlinedDexCache)
1810 << "Method " << callee_dex_file.PrettyMethod(method_index)
1811 << " could not be inlined because " << current->DebugName()
1812 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001813 return false;
1814 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001815
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001816 if (current->IsUnresolvedStaticFieldGet() ||
1817 current->IsUnresolvedInstanceFieldGet() ||
1818 current->IsUnresolvedStaticFieldSet() ||
1819 current->IsUnresolvedInstanceFieldSet()) {
1820 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001821 LOG_FAIL(kNotInlinedUnresolvedEntrypoint)
1822 << "Method " << callee_dex_file.PrettyMethod(method_index)
1823 << " could not be inlined because it is using an unresolved"
1824 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001825 return false;
1826 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001827 }
1828 }
David Brazdil3f523062016-02-29 16:53:33 +00001829 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1830 << "No instructions can be added to the outer graph while inner graph is being built";
1831
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001832 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001833 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1834 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001835 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001836 // Update our budget for other inlining attempts in `caller_graph`.
1837 total_number_of_instructions_ += number_of_instructions;
1838 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001839
1840 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1841 << "No instructions can be added to the inner graph during inlining into the outer graph";
1842
Vladimir Marko438709f2017-02-23 18:56:13 +00001843 if (stats_ != nullptr) {
1844 DCHECK(inline_stats_ != nullptr);
1845 inline_stats_->AddTo(stats_);
1846 }
1847
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001848 return true;
1849}
Calin Juravle2e768302015-07-28 14:41:11 +00001850
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001851void HInliner::RunOptimizations(HGraph* callee_graph,
1852 const DexFile::CodeItem* code_item,
1853 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001854 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1855 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00001856 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08001857 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001858 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_, handles_);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +00001859 InstructionSimplifier simplify(callee_graph, codegen_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00001860 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001861
1862 HOptimization* optimizations[] = {
1863 &intrinsics,
1864 &sharpening,
1865 &simplify,
1866 &fold,
1867 &dce,
1868 };
1869
1870 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1871 HOptimization* optimization = optimizations[i];
1872 optimization->Run();
1873 }
1874
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001875 // Bail early for pathological cases on the environment (for example recursive calls,
1876 // or too large environment).
1877 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
1878 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1879 << " will not be inlined because the outer method has reached"
1880 << " its environment budget limit.";
1881 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001882 }
1883
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001884 // Bail early if we know we already are over the limit.
1885 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
1886 if (number_of_instructions > inlining_budget_) {
1887 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1888 << " will not be inlined because the outer method has reached"
1889 << " its instruction budget limit. " << number_of_instructions;
1890 return;
1891 }
1892
1893 HInliner inliner(callee_graph,
1894 outermost_graph_,
1895 codegen_,
1896 outer_compilation_unit_,
1897 dex_compilation_unit,
1898 compiler_driver_,
1899 handles_,
1900 inline_stats_,
1901 total_number_of_dex_registers_ + code_item->registers_size_,
1902 total_number_of_instructions_ + number_of_instructions,
1903 this,
1904 depth_ + 1);
1905 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001906}
1907
David Brazdil94ab38f2016-06-21 17:48:19 +01001908static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1909 bool declared_can_be_null,
1910 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001911 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001912 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1913 return true;
1914 }
1915
1916 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1917 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001918 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01001919}
1920
1921ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1922 return ReferenceTypePropagation::IsAdmissible(klass)
1923 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1924 : graph_->GetInexactObjectRti();
1925}
1926
1927bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1928 // If this is an instance call, test whether the type of the `this` argument
1929 // is more specific than the class which declares the method.
1930 if (!resolved_method->IsStatic()) {
1931 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1932 /* declared_can_be_null */ false,
1933 invoke_instruction->InputAt(0u))) {
1934 return true;
1935 }
1936 }
1937
David Brazdil94ab38f2016-06-21 17:48:19 +01001938 // Iterate over the list of parameter types and test whether any of the
1939 // actual inputs has a more specific reference type than the type declared in
1940 // the signature.
1941 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1942 for (size_t param_idx = 0,
1943 input_idx = resolved_method->IsStatic() ? 0 : 1,
1944 e = (param_list == nullptr ? 0 : param_list->Size());
1945 param_idx < e;
1946 ++param_idx, ++input_idx) {
1947 HInstruction* input = invoke_instruction->InputAt(input_idx);
1948 if (input->GetType() == Primitive::kPrimNot) {
Vladimir Marko942fd312017-01-16 20:52:19 +00001949 mirror::Class* param_cls = resolved_method->GetClassFromTypeIndex(
David Brazdil94ab38f2016-06-21 17:48:19 +01001950 param_list->GetTypeItem(param_idx).type_idx_,
Vladimir Marko942fd312017-01-16 20:52:19 +00001951 /* resolve */ false);
David Brazdil94ab38f2016-06-21 17:48:19 +01001952 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1953 /* declared_can_be_null */ true,
1954 input)) {
1955 return true;
1956 }
1957 }
1958 }
1959
1960 return false;
1961}
1962
1963bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1964 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001965 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001966 if (return_replacement != nullptr) {
1967 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001968 // Test if the return type is a refinement of the declared return type.
1969 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1970 /* declared_can_be_null */ true,
1971 return_replacement)) {
1972 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001973 } else if (return_replacement->IsInstanceFieldGet()) {
1974 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
1975 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1976 if (field_get->GetFieldInfo().GetField() ==
1977 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
1978 return true;
1979 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001980 }
1981 } else if (return_replacement->IsInstanceOf()) {
1982 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1983 return true;
1984 }
1985 }
1986
1987 return false;
1988}
1989
1990void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1991 HInstruction* return_replacement) {
1992 if (return_replacement != nullptr) {
1993 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001994 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1995 // Make sure that we have a valid type for the return. We may get an invalid one when
1996 // we inline invokes with multiple branches and create a Phi for the result.
1997 // TODO: we could be more precise by merging the phi inputs but that requires
1998 // some functionality from the reference type propagation.
1999 DCHECK(return_replacement->IsPhi());
Vladimir Marko942fd312017-01-16 20:52:19 +00002000 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */);
David Brazdil94ab38f2016-06-21 17:48:19 +01002001 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002002 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002003 }
Calin Juravle2e768302015-07-28 14:41:11 +00002004 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002005}
2006
2007} // namespace art