blob: 41e4bbe4ff6a5b43abf00502292f48c1f794b8e5 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010024#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070026#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000027#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070028#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010030#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "driver/dex_compilation_unit.h"
32#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010033#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000034#include "jit/jit.h"
35#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "mirror/class_loader.h"
37#include "mirror/dex_cache.h"
38#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010039#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010040#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070041#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070042#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010043#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000044#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "thread.h"
47
48namespace art {
49
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000050// Instruction limit to control memory.
51static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
52
53// Maximum number of instructions for considering a method small,
54// which we will always try to inline if the other non-instruction limits
55// are not reached.
56static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000057
58// Limit the number of dex registers that we accumulate while inlining
59// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010060static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000062// Limit recursive call inlining, which do not benefit from too
63// much inlining compared to code locality.
64static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070065
Calin Juravlee2492d42017-03-20 11:42:13 -070066// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070067static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070068
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000069// We check for line numbers to make sure the DepthString implementation
70// aligns the output nicely.
71#define LOG_INTERNAL(msg) \
72 static_assert(__LINE__ > 10, "Unhandled line number"); \
73 static_assert(__LINE__ < 10000, "Unhandled line number"); \
74 VLOG(compiler) << DepthString(__LINE__) << msg
75
76#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
77#define LOG_NOTE() LOG_INTERNAL("Note: ")
78#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070079#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000080#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
81
82std::string HInliner::DepthString(int line) const {
83 std::string value;
84 // Indent according to the inlining depth.
85 size_t count = depth_;
86 // Line numbers get printed in the log, so add a space if the log's line is less
87 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
88 if (!kIsTargetBuild) {
89 if (line < 100) {
90 value += " ";
91 }
92 if (line < 1000) {
93 value += " ";
94 }
95 // Safeguard if this file reaches more than 10000 lines.
96 DCHECK_LT(line, 10000);
97 }
98 for (size_t i = 0; i < count; ++i) {
99 value += " ";
100 }
101 return value;
102}
103
104static size_t CountNumberOfInstructions(HGraph* graph) {
105 size_t number_of_instructions = 0;
106 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
107 for (HInstructionIterator instr_it(block->GetInstructions());
108 !instr_it.Done();
109 instr_it.Advance()) {
110 ++number_of_instructions;
111 }
112 }
113 return number_of_instructions;
114}
115
116void HInliner::UpdateInliningBudget() {
117 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
118 // Always try to inline small methods.
119 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
120 } else {
121 inlining_budget_ = std::max(
122 kMaximumNumberOfInstructionsForSmallMethod,
123 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
124 }
125}
126
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000127void HInliner::Run() {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000128 if (graph_->IsDebuggable()) {
129 // For simplicity, we currently never inline when the graph is debuggable. This avoids
130 // doing some logic in the runtime to discover if a method could have been inlined.
131 return;
132 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000133
134 // Initialize the number of instructions for the method being compiled. Recursive calls
135 // to HInliner::Run have already updated the instruction count.
136 if (outermost_graph_ == graph_) {
137 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
138 }
139
140 UpdateInliningBudget();
141 DCHECK_NE(total_number_of_instructions_, 0u);
142 DCHECK_NE(inlining_budget_, 0u);
143
Roland Levillain6c3af162017-04-27 11:18:56 +0100144 // If we're compiling with a core image (which is only used for
145 // test purposes), honor inlining directives in method names:
146 // - if a method's name contains the substring "$inline$", ensure
147 // that this method is actually inlined;
148 // - if a method's name contains the substring "$noinline$", do not
149 // inline that method.
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100150 // We limit this to AOT compilation, as the JIT may or may not inline
151 // depending on the state of classes at runtime.
152 const bool honor_inlining_directives =
153 IsCompilingWithCoreImage() && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100154
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000155 // Keep a copy of all blocks when starting the visit.
156 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100157 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000158 // Because we are changing the graph when inlining,
159 // we just iterate over the blocks of the outer method.
160 // This avoids doing the inlining work again on the inlined blocks.
161 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000162 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
163 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100164 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700165 // As long as the call is not intrinsified, it is worth trying to inline.
166 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Roland Levillain6c3af162017-04-27 11:18:56 +0100167 if (honor_inlining_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000168 // Debugging case: directives in method names control or assert on inlining.
169 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
170 call->GetDexMethodIndex(), /* with_signature */ false);
171 // Tests prevent inlining by having $noinline$ in their method names.
172 if (callee_name.find("$noinline$") == std::string::npos) {
173 if (!TryInline(call)) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000174 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
175 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000176 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000177 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100178 } else {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000179 // Normal case: try to inline.
180 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000181 }
182 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000183 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000184 }
185 }
186}
187
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100188static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700189 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100190 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
191}
192
193/**
194 * Given the `resolved_method` looked up in the dex cache, try to find
195 * the actual runtime target of an interface or virtual call.
196 * Return nullptr if the runtime target cannot be proven.
197 */
198static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700199 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100200 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
201 // No need to lookup further, the resolved method will be the target.
202 return resolved_method;
203 }
204
205 HInstruction* receiver = invoke->InputAt(0);
206 if (receiver->IsNullCheck()) {
207 // Due to multiple levels of inlining within the same pass, it might be that
208 // null check does not have the reference type of the actual receiver.
209 receiver = receiver->InputAt(0);
210 }
211 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000212 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
213 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100214 // We currently only support inlining with known receivers.
215 // TODO: Remove this check, we should be able to inline final methods
216 // on unknown receivers.
217 return nullptr;
218 } else if (info.GetTypeHandle()->IsInterface()) {
219 // Statically knowing that the receiver has an interface type cannot
220 // help us find what is the target method.
221 return nullptr;
222 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
223 // The method that we're trying to call is not in the receiver's class or super classes.
224 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000225 } else if (info.GetTypeHandle()->IsErroneous()) {
226 // If the type is erroneous, do not go further, as we are going to query the vtable or
227 // imt table, that we can only safely do on non-erroneous classes.
228 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 }
230
231 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700232 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100233 if (invoke->IsInvokeInterface()) {
234 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
235 resolved_method, pointer_size);
236 } else {
237 DCHECK(invoke->IsInvokeVirtual());
238 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
239 resolved_method, pointer_size);
240 }
241
242 if (resolved_method == nullptr) {
243 // The information we had on the receiver was not enough to find
244 // the target method. Since we check above the exact type of the receiver,
245 // the only reason this can happen is an IncompatibleClassChangeError.
246 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700247 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100248 // The information we had on the receiver was not enough to find
249 // the target method. Since we check above the exact type of the receiver,
250 // the only reason this can happen is an IncompatibleClassChangeError.
251 return nullptr;
252 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
253 // A final method has to be the target method.
254 return resolved_method;
255 } else if (info.IsExact()) {
256 // If we found a method and the receiver's concrete type is statically
257 // known, we know for sure the target.
258 return resolved_method;
259 } else {
260 // Even if we did find a method, the receiver type was not enough to
261 // statically find the runtime target.
262 return nullptr;
263 }
264}
265
266static uint32_t FindMethodIndexIn(ArtMethod* method,
267 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000268 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700269 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100270 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100271 return method->GetDexMethodIndex();
272 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000273 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100274 }
275}
276
Andreas Gampea5b09a62016-11-17 15:21:22 -0800277static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000278 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700279 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000280 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800281 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100282 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700283 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000284 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800285 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700286 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100287 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100288 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000289 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000290 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100291 } else {
292 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100294 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 // the right class already resolved with the class loader.
296 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000297 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000298 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
299 if (resolved != cls) {
300 index = dex::TypeIndex::Invalid();
301 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100302 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100303 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000304
305 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100306}
307
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000308class ScopedProfilingInfoInlineUse {
309 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000310 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
311 : method_(method),
312 self_(self),
313 // Fetch the profiling info ahead of using it. If it's null when fetching,
314 // we should not call JitCodeCache::DoneInlining.
315 profiling_info_(
316 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000317 }
318
319 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000320 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700321 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000322 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
323 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
324 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000325 }
326
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000327 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
328
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000329 private:
330 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000331 Thread* const self_;
332 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000333};
334
Calin Juravle13439f02017-02-21 01:17:21 -0800335HInliner::InlineCacheType HInliner::GetInlineCacheType(
336 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
337 REQUIRES_SHARED(Locks::mutator_lock_) {
338 uint8_t number_of_types = 0;
339 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
340 if (classes->Get(number_of_types) == nullptr) {
341 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000342 }
343 }
Calin Juravle13439f02017-02-21 01:17:21 -0800344
345 if (number_of_types == 0) {
346 return kInlineCacheUninitialized;
347 } else if (number_of_types == 1) {
348 return kInlineCacheMonomorphic;
349 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
350 return kInlineCacheMegamorphic;
351 } else {
352 return kInlineCachePolymorphic;
353 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000354}
355
356static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
357 REQUIRES_SHARED(Locks::mutator_lock_) {
358 DCHECK(classes->Get(0) != nullptr);
359 return classes->Get(0);
360}
361
Mingyao Yang063fc772016-08-02 11:02:54 -0700362ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
363 if (!resolved_method->HasSingleImplementation()) {
364 return nullptr;
365 }
366 if (Runtime::Current()->IsAotCompiler()) {
367 // No CHA-based devirtulization for AOT compiler (yet).
368 return nullptr;
369 }
370 if (outermost_graph_->IsCompilingOsr()) {
371 // We do not support HDeoptimize in OSR methods.
372 return nullptr;
373 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800374 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000375 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
376 if (single_impl == nullptr) {
377 return nullptr;
378 }
379 if (single_impl->IsProxyMethod()) {
380 // Proxy method is a generic invoker that's not worth
381 // devirtualizing/inlining. It also causes issues when the proxy
382 // method is in another dex file if we try to rewrite invoke-interface to
383 // invoke-virtual because a proxy method doesn't have a real dex file.
384 return nullptr;
385 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100386 if (!single_impl->GetDeclaringClass()->IsResolved()) {
387 // There's a race with the class loading, which updates the CHA info
388 // before setting the class to resolved. So we just bail for this
389 // rare occurence.
390 return nullptr;
391 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000392 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700393}
394
Aart Bika8b8e9b2018-01-09 11:01:02 -0800395static bool AlwaysThrows(ArtMethod* method) {
396 CodeItemDataAccessor accessor(method);
397 // Skip native methods, methods with try blocks, and methods that are too large.
398 if (!accessor.HasCodeItem() ||
399 accessor.TriesSize() != 0 ||
400 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
401 return false;
402 }
403 // Scan for exits.
404 bool throw_seen = false;
405 for (const DexInstructionPcPair& pair : accessor) {
406 switch (pair.Inst().Opcode()) {
407 case Instruction::RETURN:
408 case Instruction::RETURN_VOID:
409 case Instruction::RETURN_WIDE:
410 case Instruction::RETURN_OBJECT:
411 case Instruction::RETURN_VOID_NO_BARRIER:
412 return false; // found regular control flow back
413 case Instruction::THROW:
414 throw_seen = true;
415 break;
416 default:
417 break;
418 }
419 }
420 return throw_seen;
421}
422
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700423bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000424 if (invoke_instruction->IsInvokeUnresolved() ||
425 invoke_instruction->IsInvokePolymorphic()) {
426 return false; // Don't bother to move further if we know the method is unresolved or an
427 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100428 }
429
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000430 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100431 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000432 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000433 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000434
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100435 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100436 if (resolved_method == nullptr) {
437 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
438 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000439 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100440 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000441 }
442 ArtMethod* actual_method = nullptr;
443
444 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800445 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000446 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100447 // Check if we can statically find the method.
448 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000449 }
450
Mingyao Yang063fc772016-08-02 11:02:54 -0700451 bool cha_devirtualize = false;
452 if (actual_method == nullptr) {
453 ArtMethod* method = TryCHADevirtualization(resolved_method);
454 if (method != nullptr) {
455 cha_devirtualize = true;
456 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000457 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700458 }
459 }
460
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100461 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700462 bool result = TryInlineAndReplace(invoke_instruction,
463 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000464 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700465 /* do_rtp */ true,
466 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000467 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700468 if (cha_devirtualize) {
469 // Add dependency due to devirtulization. We've assumed resolved_method
470 // has single implementation.
471 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000472 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
Mingyao Yang063fc772016-08-02 11:02:54 -0700473 } else {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000474 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
Mingyao Yang063fc772016-08-02 11:02:54 -0700475 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800476 } else if (!result && invoke_instruction->IsInvokeStaticOrDirect()) {
477 // Analyze always throws property for static/direct method call with single target.
478 if (AlwaysThrows(actual_method)) {
479 invoke_instruction->SetAlwaysThrows(true);
480 }
Calin Juravle69158982016-03-16 11:53:41 +0000481 }
482 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100483 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800484 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100485
Calin Juravle13439f02017-02-21 01:17:21 -0800486 // Try using inline caches.
487 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
488}
489
490static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
491 const DexCompilationUnit& compilation_unit,
492 StackHandleScope<1>* hs)
493 REQUIRES_SHARED(Locks::mutator_lock_) {
494 Thread* self = Thread::Current();
495 ClassLinker* class_linker = compilation_unit.GetClassLinker();
496 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
497 mirror::ObjectArray<mirror::Class>::Alloc(
498 self,
499 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
500 InlineCache::kIndividualCacheSize));
501 if (inline_cache == nullptr) {
502 // We got an OOME. Just clear the exception, and don't inline.
503 DCHECK(self->IsExceptionPending());
504 self->ClearException();
505 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
506 }
507 return inline_cache;
508}
509
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700510bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
511 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
512 // do not generate a deopt.
513 //
514 // For AOT:
515 // Generating a deopt does not ensure that we will actually capture the new types;
516 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
517 // Take for example the following scenario:
518 // - we capture the inline cache in one run
519 // - the next run, we deoptimize because we miss a type check, but the method
520 // never becomes hot again
521 // In this case, the inline cache will not be updated in the profile and the AOT code
522 // will keep deoptimizing.
523 // Another scenario is if we use profile compilation for a process which is not allowed
524 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
525 // rest of the lifetime.
526 // TODO(calin):
527 // This is a compromise because we will most likely never update the inline cache
528 // in the profile (unless there's another reason to deopt). So we might be stuck with
529 // a sub-optimal inline cache.
530 // We could be smarter when capturing inline caches to mitigate this.
531 // (e.g. by having different thresholds for new and old methods).
532 //
533 // For OSR:
534 // We may come from the interpreter and it may have seen different receiver types.
535 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
536}
Calin Juravle13439f02017-02-21 01:17:21 -0800537bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
538 HInvoke* invoke_instruction,
539 ArtMethod* resolved_method)
540 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700541 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
542 return false;
543 }
544
Calin Juravle13439f02017-02-21 01:17:21 -0800545 StackHandleScope<1> hs(Thread::Current());
546 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
547 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
548 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
549 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
550
551 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000552 case kInlineCacheNoData: {
553 LOG_FAIL_NO_STAT()
554 << "Interface or virtual call to "
555 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
556 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800557 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000558 }
Calin Juravle13439f02017-02-21 01:17:21 -0800559
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000560 case kInlineCacheUninitialized: {
561 LOG_FAIL_NO_STAT()
562 << "Interface or virtual call to "
563 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
564 << " is not hit and not inlined";
565 return false;
566 }
567
568 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000569 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700570 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800571 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000572 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800573 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000574 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000575 }
Calin Juravle13439f02017-02-21 01:17:21 -0800576
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000577 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000578 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800579 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000580 }
Calin Juravle13439f02017-02-21 01:17:21 -0800581
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000582 case kInlineCacheMegamorphic: {
583 LOG_FAIL_NO_STAT()
584 << "Interface or virtual call to "
585 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
586 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000587 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800588 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000589 }
Calin Juravle13439f02017-02-21 01:17:21 -0800590
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000591 case kInlineCacheMissingTypes: {
592 LOG_FAIL_NO_STAT()
593 << "Interface or virtual call to "
594 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
595 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800596 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000597 }
Calin Juravle13439f02017-02-21 01:17:21 -0800598 }
599 UNREACHABLE();
600}
601
602HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
603 HInvoke* invoke_instruction,
604 StackHandleScope<1>* hs,
605 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
606 REQUIRES_SHARED(Locks::mutator_lock_) {
607 DCHECK(Runtime::Current()->UseJitCompilation());
608
609 ArtMethod* caller = graph_->GetArtMethod();
610 // Under JIT, we should always know the caller.
611 DCHECK(caller != nullptr);
612 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
613 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
614
615 if (profiling_info == nullptr) {
616 return kInlineCacheNoData;
617 }
618
619 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
620 if (inline_cache->Get() == nullptr) {
621 // We can't extract any data if we failed to allocate;
622 return kInlineCacheNoData;
623 } else {
624 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
625 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
626 *inline_cache);
627 return GetInlineCacheType(*inline_cache);
628 }
629}
630
631HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
632 const DexFile& caller_dex_file,
633 HInvoke* invoke_instruction,
634 StackHandleScope<1>* hs,
635 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
636 REQUIRES_SHARED(Locks::mutator_lock_) {
637 DCHECK(Runtime::Current()->IsAotCompiler());
638 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
639 if (pci == nullptr) {
640 return kInlineCacheNoData;
641 }
642
Calin Juravlecc3171a2017-05-19 16:47:53 -0700643 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
644 pci->GetMethod(caller_dex_file.GetLocation(),
645 caller_dex_file.GetLocationChecksum(),
646 caller_compilation_unit_.GetDexMethodIndex());
647 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800648 return kInlineCacheNoData; // no profile information for this invocation.
649 }
650
651 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
652 if (inline_cache == nullptr) {
653 // We can't extract any data if we failed to allocate;
654 return kInlineCacheNoData;
655 } else {
656 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700657 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800658 *inline_cache);
659 }
660}
661
662HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
663 const HInvoke* invoke_instruction,
664 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
665 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
666 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700667 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
668 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800669 return kInlineCacheUninitialized;
670 }
671
672 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
673
674 if (dex_pc_data.is_missing_types) {
675 return kInlineCacheMissingTypes;
676 }
677 if (dex_pc_data.is_megamorphic) {
678 return kInlineCacheMegamorphic;
679 }
680
681 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
682 Thread* self = Thread::Current();
683 // We need to resolve the class relative to the containing dex file.
684 // So first, build a mapping from the index of dex file in the profile to
685 // its dex cache. This will avoid repeating the lookup when walking over
686 // the inline cache types.
687 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
688 offline_profile.dex_references.size());
689 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
690 bool found = false;
691 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
692 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
693 dex_profile_index_to_dex_cache[i] =
694 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
695 found = true;
696 }
697 }
698 if (!found) {
699 VLOG(compiler) << "Could not find profiled dex file: "
700 << offline_profile.dex_references[i].dex_location;
701 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100702 }
703 }
704
Calin Juravle13439f02017-02-21 01:17:21 -0800705 // Walk over the classes and resolve them. If we cannot find a type we return
706 // kInlineCacheMissingTypes.
707 int ic_index = 0;
708 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
709 ObjPtr<mirror::DexCache> dex_cache =
710 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
711 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700712
713 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
714 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
715 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
716 return kInlineCacheNoData;
717 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000718 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000719 class_ref.type_index,
720 dex_cache,
721 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800722 if (clazz != nullptr) {
723 inline_cache->Set(ic_index++, clazz);
724 } else {
725 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
726 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
727 invoke_instruction->GetDexMethodIndex()) << " : "
728 << caller_compilation_unit_
729 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
730 return kInlineCacheMissingTypes;
731 }
732 }
733 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100734}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000735
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000736HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
737 HInstruction* receiver,
738 uint32_t dex_pc) const {
739 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
740 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100741 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000742 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000743 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100744 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000745 field->GetOffset(),
746 field->IsVolatile(),
747 field->GetDexFieldIndex(),
748 field->GetDeclaringClass()->GetDexClassDefIndex(),
749 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000750 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000751 // The class of a field is effectively final, and does not have any memory dependencies.
752 result->SetSideEffects(SideEffects::None());
753 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000754}
755
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000756static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
757 ArtMethod* resolved_method,
758 HInstruction* invoke_instruction,
759 PointerSize pointer_size)
760 REQUIRES_SHARED(Locks::mutator_lock_) {
761 if (Runtime::Current()->IsAotCompiler()) {
762 // We can get unrelated types when working with profiles (corruption,
763 // systme updates, or anyone can write to it). So first check if the class
764 // actually implements the declaring class of the method that is being
765 // called in bytecode.
766 // Note: the lookup methods used below require to have assignable types.
767 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
768 return nullptr;
769 }
770 }
771
772 if (invoke_instruction->IsInvokeInterface()) {
773 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
774 } else {
775 DCHECK(invoke_instruction->IsInvokeVirtual());
776 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
777 }
778 DCHECK(resolved_method != nullptr);
779 return resolved_method;
780}
781
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100782bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
783 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000784 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000785 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
786 << invoke_instruction->DebugName();
787
Andreas Gampea5b09a62016-11-17 15:21:22 -0800788 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000789 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800790 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000791 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000792 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
793 << " from inline cache is not inlined because its class is not"
794 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100795 return false;
796 }
797
798 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700799 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000800 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
801 resolved_method = ResolveMethodFromInlineCache(
802 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
803
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000804 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000805 if (resolved_method == nullptr) {
806 // Bogus AOT profile, bail.
807 DCHECK(Runtime::Current()->IsAotCompiler());
808 return false;
809 }
810
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100811 HInstruction* receiver = invoke_instruction->InputAt(0);
812 HInstruction* cursor = invoke_instruction->GetPrevious();
813 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700814 if (!TryInlineAndReplace(invoke_instruction,
815 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000816 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700817 /* do_rtp */ false,
818 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100819 return false;
820 }
821
822 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000823 AddTypeGuard(receiver,
824 cursor,
825 bb_cursor,
826 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000827 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000828 invoke_instruction,
829 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100830
831 // Run type propagation to get the guard typed, and eventually propagate the
832 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000833 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000834 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000835 outer_compilation_unit_.GetDexCache(),
836 handles_,
837 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100838 rtp_fixup.Run();
839
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000840 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100841 return true;
842}
843
Mingyao Yang063fc772016-08-02 11:02:54 -0700844void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
845 uint32_t dex_pc,
846 HInstruction* cursor,
847 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100848 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
849 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
850 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700851 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100852 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
853 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700854
855 if (cursor != nullptr) {
856 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
857 } else {
858 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
859 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800860 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
861 bb_cursor->InsertInstructionAfter(deopt, compare);
862
863 // Add receiver as input to aid CHA guard optimization later.
864 deopt_flag->AddInput(invoke_instruction->InputAt(0));
865 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700866 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800867 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700868}
869
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000870HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
871 HInstruction* cursor,
872 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800873 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000874 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000875 HInstruction* invoke_instruction,
876 bool with_deoptimization) {
877 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
878 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
879 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000880 if (cursor != nullptr) {
881 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
882 } else {
883 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
884 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000885
886 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700887 bool is_referrer;
888 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
889 if (outermost_art_method == nullptr) {
890 DCHECK(Runtime::Current()->IsAotCompiler());
891 // We are in AOT mode and we don't have an ART method to determine
892 // if the inlined method belongs to the referrer. Assume it doesn't.
893 is_referrer = false;
894 } else {
895 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
896 }
897
Nicolas Geoffray56876342016-12-16 16:09:08 +0000898 // Note that we will just compare the classes, so we don't need Java semantics access checks.
899 // Note that the type index and the dex file are relative to the method this type guard is
900 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100901 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
902 class_index,
903 caller_dex_file,
904 klass,
905 is_referrer,
906 invoke_instruction->GetDexPc(),
907 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000908 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000909 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
910 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
911 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000912 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000913 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000914 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800915 // In AOT mode, we will most likely load the class from BSS, which will involve a call
916 // to the runtime. In this case, the load instruction will need an environment so copy
917 // it from the invoke instruction.
918 if (load_class->NeedsEnvironment()) {
919 DCHECK(Runtime::Current()->IsAotCompiler());
920 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
921 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000922
Vladimir Markoca6fff82017-10-03 14:49:14 +0100923 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000924 bb_cursor->InsertInstructionAfter(compare, load_class);
925 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100926 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
927 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000928 compare,
929 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100930 Runtime::Current()->IsAotCompiler()
931 ? DeoptimizationKind::kAotInlineCache
932 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000933 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000934 bb_cursor->InsertInstructionAfter(deoptimize, compare);
935 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000936 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
937 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
938 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000939 }
940 return compare;
941}
942
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000943bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100944 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000945 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000946 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
947 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000948
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000949 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000950 return true;
951 }
952
953 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700954 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000955
956 bool all_targets_inlined = true;
957 bool one_target_inlined = false;
958 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000959 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000960 break;
961 }
962 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000963
964 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000965 method = ResolveMethodFromInlineCache(
966 handle, resolved_method, invoke_instruction, pointer_size);
967 if (method == nullptr) {
968 DCHECK(Runtime::Current()->IsAotCompiler());
969 // AOT profile is bogus. This loop expects to iterate over all entries,
970 // so just just continue.
971 all_targets_inlined = false;
972 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000973 }
974
975 HInstruction* receiver = invoke_instruction->InputAt(0);
976 HInstruction* cursor = invoke_instruction->GetPrevious();
977 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
978
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000979 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000980 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000981 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800982 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000983 !TryBuildAndInline(invoke_instruction,
984 method,
985 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
986 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000987 all_targets_inlined = false;
988 } else {
989 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000990
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000991 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
992 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000993
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000994 // If we have inlined all targets before, and this receiver is the last seen,
995 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700996 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
997 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000998 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000999 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001000
Nicolas Geoffray56876342016-12-16 16:09:08 +00001001 HInstruction* compare = AddTypeGuard(receiver,
1002 cursor,
1003 bb_cursor,
1004 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001005 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001006 invoke_instruction,
1007 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001008 if (deoptimize) {
1009 if (return_replacement != nullptr) {
1010 invoke_instruction->ReplaceWith(return_replacement);
1011 }
1012 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1013 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001014 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001015 break;
1016 } else {
1017 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1018 }
1019 }
1020 }
1021
1022 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001023 LOG_FAIL_NO_STAT()
1024 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1025 << " from inline cache is not inlined because none"
1026 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001027 return false;
1028 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001029
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001030 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001031
1032 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001033 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001034 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001035 outer_compilation_unit_.GetDexCache(),
1036 handles_,
1037 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001038 rtp_fixup.Run();
1039 return true;
1040}
1041
1042void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1043 HInstruction* return_replacement,
1044 HInstruction* invoke_instruction) {
1045 uint32_t dex_pc = invoke_instruction->GetDexPc();
1046 HBasicBlock* cursor_block = compare->GetBlock();
1047 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001048 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001049
1050 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1051 // and the returned block is the start of the then branch (that could contain multiple blocks).
1052 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1053
1054 // Split the block containing the invoke before and after the invoke. The returned block
1055 // of the split before will contain the invoke and will be the otherwise branch of
1056 // the diamond. The returned block of the split after will be the merge block
1057 // of the diamond.
1058 HBasicBlock* end_then = invoke_instruction->GetBlock();
1059 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1060 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1061
1062 // If the methods we are inlining return a value, we create a phi in the merge block
1063 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1064 if (return_replacement != nullptr) {
1065 HPhi* phi = new (allocator) HPhi(
1066 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1067 merge->AddPhi(phi);
1068 invoke_instruction->ReplaceWith(phi);
1069 phi->AddInput(return_replacement);
1070 phi->AddInput(invoke_instruction);
1071 }
1072
1073 // Add the control flow instructions.
1074 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1075 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1076 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1077
1078 // Add the newly created blocks to the graph.
1079 graph_->AddBlock(then);
1080 graph_->AddBlock(otherwise);
1081 graph_->AddBlock(merge);
1082
1083 // Set up successor (and implictly predecessor) relations.
1084 cursor_block->AddSuccessor(otherwise);
1085 cursor_block->AddSuccessor(then);
1086 end_then->AddSuccessor(merge);
1087 otherwise->AddSuccessor(merge);
1088
1089 // Set up dominance information.
1090 then->SetDominator(cursor_block);
1091 cursor_block->AddDominatedBlock(then);
1092 otherwise->SetDominator(cursor_block);
1093 cursor_block->AddDominatedBlock(otherwise);
1094 merge->SetDominator(cursor_block);
1095 cursor_block->AddDominatedBlock(merge);
1096
1097 // Update the revert post order.
1098 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1099 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1100 graph_->reverse_post_order_[++index] = then;
1101 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1102 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1103 graph_->reverse_post_order_[++index] = otherwise;
1104 graph_->reverse_post_order_[++index] = merge;
1105
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001106
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001107 graph_->UpdateLoopAndTryInformationOfNewBlock(
1108 then, original_invoke_block, /* replace_if_back_edge */ false);
1109 graph_->UpdateLoopAndTryInformationOfNewBlock(
1110 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1111
1112 // In case the original invoke location was a back edge, we need to update
1113 // the loop to now have the merge block as a back edge.
1114 graph_->UpdateLoopAndTryInformationOfNewBlock(
1115 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001116}
1117
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001118bool HInliner::TryInlinePolymorphicCallToSameTarget(
1119 HInvoke* invoke_instruction,
1120 ArtMethod* resolved_method,
1121 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001122 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001123 if (!Runtime::Current()->UseJitCompilation()) {
1124 return false;
1125 }
1126
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001127 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001128 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001129
1130 DCHECK(resolved_method != nullptr);
1131 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001132 size_t method_index = invoke_instruction->IsInvokeVirtual()
1133 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1134 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1135
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001136 // Check whether we are actually calling the same method among
1137 // the different types seen.
1138 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001139 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001140 break;
1141 }
1142 ArtMethod* new_method = nullptr;
1143 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001144 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001145 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001146 if (new_method->IsRuntimeMethod()) {
1147 // Bail out as soon as we see a conflict trampoline in one of the target's
1148 // interface table.
1149 return false;
1150 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001151 } else {
1152 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001153 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001154 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001155 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001156 if (actual_method == nullptr) {
1157 actual_method = new_method;
1158 } else if (actual_method != new_method) {
1159 // Different methods, bailout.
1160 return false;
1161 }
1162 }
1163
1164 HInstruction* receiver = invoke_instruction->InputAt(0);
1165 HInstruction* cursor = invoke_instruction->GetPrevious();
1166 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1167
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001168 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001169 if (!TryBuildAndInline(invoke_instruction,
1170 actual_method,
1171 ReferenceTypeInfo::CreateInvalid(),
1172 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001173 return false;
1174 }
1175
1176 // We successfully inlined, now add a guard.
1177 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1178 class_linker, receiver, invoke_instruction->GetDexPc());
1179
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001180 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1181 ? DataType::Type::kInt64
1182 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001183 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001184 receiver_class,
1185 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001186 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1187 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001188 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001189 invoke_instruction->GetDexPc());
1190
1191 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001192 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001193 constant = graph_->GetLongConstant(
1194 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1195 } else {
1196 constant = graph_->GetIntConstant(
1197 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1198 }
1199
Vladimir Markoca6fff82017-10-03 14:49:14 +01001200 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001201 if (cursor != nullptr) {
1202 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1203 } else {
1204 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1205 }
1206 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1207 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001208
1209 if (outermost_graph_->IsCompilingOsr()) {
1210 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1211 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001212 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1213 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001214 compare,
1215 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001216 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001217 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001218 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1219 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1220 if (return_replacement != nullptr) {
1221 invoke_instruction->ReplaceWith(return_replacement);
1222 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001223 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001224 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001225 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001226 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001227
1228 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001229 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001230 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001231 outer_compilation_unit_.GetDexCache(),
1232 handles_,
1233 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001234 rtp_fixup.Run();
1235
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001236 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001237
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001238 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001239 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001240}
1241
Mingyao Yang063fc772016-08-02 11:02:54 -07001242bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1243 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001244 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001245 bool do_rtp,
1246 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001247 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001248 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001249 uint32_t dex_pc = invoke_instruction->GetDexPc();
1250 HInstruction* cursor = invoke_instruction->GetPrevious();
1251 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001252 bool should_remove_invoke_instruction = false;
1253
1254 // If invoke_instruction is devirtualized to a different method, give intrinsics
1255 // another chance before we try to inline it.
1256 bool wrong_invoke_type = false;
1257 if (invoke_instruction->GetResolvedMethod() != method &&
1258 IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) {
1259 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1260 if (invoke_instruction->IsInvokeInterface()) {
1261 // We don't intrinsify an invoke-interface directly.
1262 // Replace the invoke-interface with an invoke-virtual.
1263 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1264 graph_->GetAllocator(),
1265 invoke_instruction->GetNumberOfArguments(),
1266 invoke_instruction->GetType(),
1267 invoke_instruction->GetDexPc(),
1268 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1269 method,
1270 method->GetMethodIndex());
1271 HInputsRef inputs = invoke_instruction->GetInputs();
1272 for (size_t index = 0; index != inputs.size(); ++index) {
1273 new_invoke->SetArgumentAt(index, inputs[index]);
1274 }
1275 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1276 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1277 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1278 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1279 }
1280 // Run intrinsic recognizer again to set new_invoke's intrinsic.
1281 IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type);
1282 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
1283 return_replacement = new_invoke;
1284 // invoke_instruction is replaced with new_invoke.
1285 should_remove_invoke_instruction = true;
1286 } else {
1287 // invoke_instruction is intrinsified and stays.
1288 }
1289 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001290 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001291 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001292 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1293 // better than an invoke-interface because:
1294 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1295 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1296 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001297
1298 if (method->IsDefault() && !method->IsCopied()) {
1299 // Changing to invoke-virtual cannot be done on an original default method
1300 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1301 // always uses a method in the iftable which is never an original default
1302 // method.
1303 // On the other hand, inlining an original default method by CHA is fine.
1304 DCHECK(cha_devirtualize);
1305 return false;
1306 }
1307
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001308 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001309 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001310 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001311 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001312 return false;
1313 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001314 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1315 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001316 invoke_instruction->GetNumberOfArguments(),
1317 invoke_instruction->GetType(),
1318 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001319 dex_method_index,
1320 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001321 method->GetMethodIndex());
1322 HInputsRef inputs = invoke_instruction->GetInputs();
1323 for (size_t index = 0; index != inputs.size(); ++index) {
1324 new_invoke->SetArgumentAt(index, inputs[index]);
1325 }
1326 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1327 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001328 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001329 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1330 }
1331 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001332 // invoke_instruction is replaced with new_invoke.
1333 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001334 } else {
1335 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1336 // compiler driver.
1337 return false;
1338 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001339 } else {
1340 // invoke_instruction is inlined.
1341 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001342 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001343
Mingyao Yang063fc772016-08-02 11:02:54 -07001344 if (cha_devirtualize) {
1345 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1346 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001347 if (return_replacement != nullptr) {
1348 invoke_instruction->ReplaceWith(return_replacement);
1349 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001350 if (should_remove_invoke_instruction) {
1351 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1352 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001353 FixUpReturnReferenceType(method, return_replacement);
1354 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1355 // Actual return value has a more specific type than the method's declared
1356 // return type. Run RTP again on the outer graph to propagate it.
1357 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001358 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001359 outer_compilation_unit_.GetDexCache(),
1360 handles_,
1361 /* is_first_run */ false).Run();
1362 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001363 return true;
1364}
1365
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001366size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1367 const HInliner* current = this;
1368 size_t count = 0;
1369 do {
1370 if (current->graph_->GetArtMethod() == method) {
1371 ++count;
1372 }
1373 current = current->parent_;
1374 } while (current != nullptr);
1375 return count;
1376}
1377
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001378bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1379 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001380 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001381 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001382 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001383 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001384 << "Method " << method->PrettyMethod()
1385 << " is not inlined because of unimplemented inline support for proxy methods.";
1386 return false;
1387 }
1388
1389 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001390 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001391 << "Method "
1392 << method->PrettyMethod()
1393 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001394 return false;
1395 }
1396
Jeff Haodcdc85b2015-12-04 14:06:18 -08001397 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1398 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1399 if (!compiler_driver_->MayInline(method->GetDexFile(),
1400 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001401 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001402 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1403 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001404 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001405 return true;
1406 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001407 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001408 << "Won't inline " << method->PrettyMethod() << " in "
1409 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1410 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1411 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001412 return false;
1413 }
1414
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001415 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1416
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001417 CodeItemDataAccessor accessor(method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001418
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001419 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001420 LOG_FAIL_NO_STAT()
1421 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001422 return false;
1423 }
1424
Calin Juravleec748352015-07-29 13:52:12 +01001425 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001426 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001427 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001428 << "Method " << method->PrettyMethod()
1429 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001430 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001431 << " > "
1432 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001433 return false;
1434 }
1435
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001436 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001437 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001438 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001439 return false;
1440 }
1441
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001442 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001443 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001444 << "Method " << method->PrettyMethod()
1445 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001446 }
1447
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001448 if (!method->GetDeclaringClass()->IsVerified()) {
1449 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +01001450 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001451 !compiler_driver_->IsMethodVerifiedWithoutFailures(
1452 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001453 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001454 << "Method " << method->PrettyMethod()
1455 << " couldn't be verified, so it cannot be inlined";
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001456 return false;
1457 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001458 }
1459
Roland Levillain4c0eb422015-04-24 16:43:49 +01001460 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1461 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1462 // Case of a static method that cannot be inlined because it implicitly
1463 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001464 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1465 << "Method " << method->PrettyMethod()
1466 << " is not inlined because it is static and requires a clinit"
1467 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001468 return false;
1469 }
1470
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001471 if (!TryBuildAndInlineHelper(
1472 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001473 return false;
1474 }
1475
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001476 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001477 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001478 return true;
1479}
1480
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001481static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1482 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001483 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001484 size_t input_index = 0;
1485 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1486 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001487 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001488 ++i;
1489 DCHECK_NE(i, arg_vreg_index);
1490 }
1491 }
1492 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1493 return invoke_instruction->InputAt(input_index);
1494}
1495
1496// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1497bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1498 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001499 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001500 InlineMethod inline_method;
1501 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1502 return false;
1503 }
1504
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001505 switch (inline_method.opcode) {
1506 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001507 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001508 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001509 break;
1510 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001511 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1512 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001513 break;
1514 case kInlineOpNonWideConst:
1515 if (resolved_method->GetShorty()[0] == 'L') {
1516 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001517 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001518 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001519 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001520 }
1521 break;
1522 case kInlineOpIGet: {
1523 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1524 if (data.method_is_static || data.object_arg != 0u) {
1525 // TODO: Needs null check.
1526 return false;
1527 }
1528 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001529 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001530 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1531 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1532 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001533 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001534 break;
1535 }
1536 case kInlineOpIPut: {
1537 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1538 if (data.method_is_static || data.object_arg != 0u) {
1539 // TODO: Needs null check.
1540 return false;
1541 }
1542 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1543 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001544 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001545 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1546 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1547 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1548 if (data.return_arg_plus1 != 0u) {
1549 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001550 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001551 }
1552 break;
1553 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001554 case kInlineOpConstructor: {
1555 const InlineConstructorData& data = inline_method.d.constructor_data;
1556 // Get the indexes to arrays for easier processing.
1557 uint16_t iput_field_indexes[] = {
1558 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1559 };
1560 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1561 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1562 // Count valid field indexes.
1563 size_t number_of_iputs = 0u;
1564 while (number_of_iputs != arraysize(iput_field_indexes) &&
1565 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1566 // Check that there are no duplicate valid field indexes.
1567 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1568 iput_field_indexes + arraysize(iput_field_indexes),
1569 iput_field_indexes[number_of_iputs]));
1570 ++number_of_iputs;
1571 }
1572 // Check that there are no valid field indexes in the rest of the array.
1573 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1574 iput_field_indexes + arraysize(iput_field_indexes),
1575 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1576
1577 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001578 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1579 bool needs_constructor_barrier = false;
1580 for (size_t i = 0; i != number_of_iputs; ++i) {
1581 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001582 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001583 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001584 bool is_final;
1585 HInstanceFieldSet* iput =
1586 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001587 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1588
1589 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001590 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001591 needs_constructor_barrier = true;
1592 }
1593 }
1594 }
1595 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001596 // See CompilerDriver::RequiresConstructorBarrier for more details.
1597 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1598
1599 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001600 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001601 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1602 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001603 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001604 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001605 break;
1606 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001607 default:
1608 LOG(FATAL) << "UNREACHABLE";
1609 UNREACHABLE();
1610 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001611 return true;
1612}
1613
Vladimir Markof44d36c2017-03-14 14:18:46 +00001614HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1615 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001616 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001617 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001618 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1619 ArtField* resolved_field =
1620 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001621 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001622 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001623 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001624 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001625 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001626 resolved_field->GetOffset(),
1627 resolved_field->IsVolatile(),
1628 field_index,
1629 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001630 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001631 // Read barrier generates a runtime call in slow path and we need a valid
1632 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1633 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001634 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001635 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001636 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001637 ReferenceTypePropagation rtp(graph_,
1638 outer_compilation_unit_.GetClassLoader(),
1639 dex_cache,
1640 handles_,
1641 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001642 rtp.Visit(iget);
1643 }
1644 return iget;
1645}
1646
Vladimir Markof44d36c2017-03-14 14:18:46 +00001647HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1648 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001649 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001650 HInstruction* value,
1651 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001652 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001653 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1654 ArtField* resolved_field =
1655 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001656 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001657 if (is_final != nullptr) {
1658 // This information is needed only for constructors.
1659 DCHECK(referrer->IsConstructor());
1660 *is_final = resolved_field->IsFinal();
1661 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001662 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001663 obj,
1664 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001665 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001666 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001667 resolved_field->GetOffset(),
1668 resolved_field->IsVolatile(),
1669 field_index,
1670 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001671 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001672 // Read barrier generates a runtime call in slow path and we need a valid
1673 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1674 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001675 return iput;
1676}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001677
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001678template <typename T>
1679static inline Handle<T> NewHandleIfDifferent(T* object,
1680 Handle<T> hint,
1681 VariableSizedHandleScope* handles)
1682 REQUIRES_SHARED(Locks::mutator_lock_) {
1683 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1684}
1685
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001686bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1687 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001688 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001689 bool same_dex_file,
1690 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001691 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001692 ScopedObjectAccess soa(Thread::Current());
1693 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001694 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1695 uint32_t method_index = resolved_method->GetDexMethodIndex();
Mathieu Chartier8892c6b2018-01-09 15:10:17 -08001696 CodeItemDebugInfoAccessor code_item_accessor(resolved_method);
Calin Juravle2e768302015-07-28 14:41:11 +00001697 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001698 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1699 caller_compilation_unit_.GetDexCache(),
1700 handles_);
1701 Handle<mirror::ClassLoader> class_loader =
1702 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1703 caller_compilation_unit_.GetClassLoader(),
1704 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001705
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001706 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001707 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001708 class_linker,
1709 callee_dex_file,
1710 code_item,
1711 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1712 method_index,
1713 resolved_method->GetAccessFlags(),
1714 /* verified_method */ nullptr,
1715 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001716
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001717 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001718 if (invoke_type == kInterface) {
1719 // We have statically resolved the dispatch. To please the class linker
1720 // at runtime, we change this call as if it was a virtual call.
1721 invoke_type = kVirtual;
1722 }
David Brazdil3f523062016-02-29 16:53:33 +00001723
1724 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001725 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1726 graph_->GetAllocator(),
1727 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001728 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001729 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001730 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001731 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001732 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001733 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001734 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001735 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001736
Vladimir Marko438709f2017-02-23 18:56:13 +00001737 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001738 // of on the stack, as Clang might produce a stack frame too large
1739 // for this function, that would not fit the requirements of the
1740 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001741 if (stats_ != nullptr) {
1742 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1743 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001744 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001745 inline_stats_ = new (storage) OptimizingCompilerStats;
1746 } else {
1747 inline_stats_->Reset();
1748 }
1749 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001750 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001751 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001752 &dex_compilation_unit,
1753 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001754 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001755 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001756 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001757 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001758 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001759
David Brazdildee58d62016-04-07 09:54:26 +00001760 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001761 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001762 << "Method " << callee_dex_file.PrettyMethod(method_index)
1763 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001764 return false;
1765 }
1766
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001767 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1768 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001769 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001770 << "Method " << callee_dex_file.PrettyMethod(method_index)
1771 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001772 return false;
1773 }
1774
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001775 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001776 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001777 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1778 !instructions.Done();
1779 instructions.Advance()) {
1780 HInstruction* current = instructions.Current();
1781 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001782 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001783 if (argument->IsNullConstant()) {
1784 current->ReplaceWith(callee_graph->GetNullConstant());
1785 } else if (argument->IsIntConstant()) {
1786 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1787 } else if (argument->IsLongConstant()) {
1788 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1789 } else if (argument->IsFloatConstant()) {
1790 current->ReplaceWith(
1791 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1792 } else if (argument->IsDoubleConstant()) {
1793 current->ReplaceWith(
1794 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001795 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001796 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1797 run_rtp = true;
1798 current->SetReferenceTypeInfo(receiver_type);
1799 } else {
1800 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1801 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001802 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1803 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001804 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001805 }
1806 }
1807
David Brazdil94ab38f2016-06-21 17:48:19 +01001808 // We have replaced formal arguments with actual arguments. If actual types
1809 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001810 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001811 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001812 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001813 dex_compilation_unit.GetDexCache(),
1814 handles_,
1815 /* is_first_run */ false).Run();
1816 }
1817
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001818 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001819
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001820 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1821 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001822 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001823 << "Method " << callee_dex_file.PrettyMethod(method_index)
1824 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001825 return false;
1826 }
1827
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001828 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001829 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1830 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001831 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1832 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001833 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001834 << "Method " << callee_dex_file.PrettyMethod(method_index)
1835 << " could not be inlined because one branch always throws and"
1836 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001837 return false;
1838 } else if (graph_->GetExitBlock() == nullptr) {
1839 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001840 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001841 << "Method " << callee_dex_file.PrettyMethod(method_index)
1842 << " could not be inlined because one branch always throws and"
1843 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001844 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001845 } else if (graph_->HasIrreducibleLoops()) {
1846 // TODO(ngeoffray): Support re-computing loop information to graphs with
1847 // irreducible loops?
1848 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1849 << " could not be inlined because one branch always throws and"
1850 << " caller has irreducible loops";
1851 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001852 }
1853 } else {
1854 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001855 }
1856 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001857
1858 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001859 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001860 << "Method " << callee_dex_file.PrettyMethod(method_index)
1861 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001862 return false;
1863 }
1864
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001865 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001866 // Skip the entry block, it does not contain instructions that prevent inlining.
1867 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001868 if (block->IsLoopHeader()) {
1869 if (block->GetLoopInformation()->IsIrreducible()) {
1870 // Don't inline methods with irreducible loops, they could prevent some
1871 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001872 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001873 << "Method " << callee_dex_file.PrettyMethod(method_index)
1874 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001875 return false;
1876 }
1877 if (!block->GetLoopInformation()->HasExitEdge()) {
1878 // Don't inline methods with loops without exit, since they cause the
1879 // loop information to be computed incorrectly when updating after
1880 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001881 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001882 << "Method " << callee_dex_file.PrettyMethod(method_index)
1883 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001884 return false;
1885 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001886 }
1887
1888 for (HInstructionIterator instr_it(block->GetInstructions());
1889 !instr_it.Done();
1890 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001891 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001892 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001893 << "Method " << callee_dex_file.PrettyMethod(method_index)
1894 << " is not inlined because the outer method has reached"
1895 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001896 return false;
1897 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001898 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001899 if (current->NeedsEnvironment() &&
1900 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001901 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001902 << "Method " << callee_dex_file.PrettyMethod(method_index)
1903 << " is not inlined because its caller has reached"
1904 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001905 return false;
1906 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001907
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001908 if (current->NeedsEnvironment() &&
1909 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1910 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001911 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001912 << "Method " << callee_dex_file.PrettyMethod(method_index)
1913 << " could not be inlined because " << current->DebugName()
1914 << " needs an environment, is in a different dex file"
1915 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001916 return false;
1917 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001918
Vladimir Markodc151b22015-10-15 18:02:30 +01001919 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001920 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001921 << "Method " << callee_dex_file.PrettyMethod(method_index)
1922 << " could not be inlined because " << current->DebugName()
1923 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001924 return false;
1925 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001926
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001927 if (current->IsUnresolvedStaticFieldGet() ||
1928 current->IsUnresolvedInstanceFieldGet() ||
1929 current->IsUnresolvedStaticFieldSet() ||
1930 current->IsUnresolvedInstanceFieldSet()) {
1931 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001932 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001933 << "Method " << callee_dex_file.PrettyMethod(method_index)
1934 << " could not be inlined because it is using an unresolved"
1935 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001936 return false;
1937 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001938 }
1939 }
David Brazdil3f523062016-02-29 16:53:33 +00001940 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1941 << "No instructions can be added to the outer graph while inner graph is being built";
1942
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001943 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001944 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1945 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001946 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001947 // Update our budget for other inlining attempts in `caller_graph`.
1948 total_number_of_instructions_ += number_of_instructions;
1949 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001950
1951 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1952 << "No instructions can be added to the inner graph during inlining into the outer graph";
1953
Vladimir Marko438709f2017-02-23 18:56:13 +00001954 if (stats_ != nullptr) {
1955 DCHECK(inline_stats_ != nullptr);
1956 inline_stats_->AddTo(stats_);
1957 }
1958
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001959 return true;
1960}
Calin Juravle2e768302015-07-28 14:41:11 +00001961
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001962void HInliner::RunOptimizations(HGraph* callee_graph,
1963 const DexFile::CodeItem* code_item,
1964 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001965 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1966 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00001967 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08001968 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Marko28e012a2017-12-07 11:22:59 +00001969 HSharpening sharpening(callee_graph, codegen_, compiler_driver_);
Vladimir Marko65979462017-05-19 17:25:12 +01001970 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00001971 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001972
1973 HOptimization* optimizations[] = {
1974 &intrinsics,
1975 &sharpening,
1976 &simplify,
1977 &fold,
1978 &dce,
1979 };
1980
1981 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1982 HOptimization* optimization = optimizations[i];
1983 optimization->Run();
1984 }
1985
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001986 // Bail early for pathological cases on the environment (for example recursive calls,
1987 // or too large environment).
1988 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
1989 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1990 << " will not be inlined because the outer method has reached"
1991 << " its environment budget limit.";
1992 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001993 }
1994
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001995 // Bail early if we know we already are over the limit.
1996 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
1997 if (number_of_instructions > inlining_budget_) {
1998 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1999 << " will not be inlined because the outer method has reached"
2000 << " its instruction budget limit. " << number_of_instructions;
2001 return;
2002 }
2003
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002004 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002005 HInliner inliner(callee_graph,
2006 outermost_graph_,
2007 codegen_,
2008 outer_compilation_unit_,
2009 dex_compilation_unit,
2010 compiler_driver_,
2011 handles_,
2012 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002013 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002014 total_number_of_instructions_ + number_of_instructions,
2015 this,
2016 depth_ + 1);
2017 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002018}
2019
David Brazdil94ab38f2016-06-21 17:48:19 +01002020static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2021 bool declared_can_be_null,
2022 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002023 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002024 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2025 return true;
2026 }
2027
2028 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2029 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002030 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002031}
2032
Vladimir Markob45528c2017-07-27 14:14:28 +01002033ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002034 return ReferenceTypePropagation::IsAdmissible(klass)
2035 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2036 : graph_->GetInexactObjectRti();
2037}
2038
2039bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2040 // If this is an instance call, test whether the type of the `this` argument
2041 // is more specific than the class which declares the method.
2042 if (!resolved_method->IsStatic()) {
2043 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
2044 /* declared_can_be_null */ false,
2045 invoke_instruction->InputAt(0u))) {
2046 return true;
2047 }
2048 }
2049
David Brazdil94ab38f2016-06-21 17:48:19 +01002050 // Iterate over the list of parameter types and test whether any of the
2051 // actual inputs has a more specific reference type than the type declared in
2052 // the signature.
2053 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
2054 for (size_t param_idx = 0,
2055 input_idx = resolved_method->IsStatic() ? 0 : 1,
2056 e = (param_list == nullptr ? 0 : param_list->Size());
2057 param_idx < e;
2058 ++param_idx, ++input_idx) {
2059 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002060 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002061 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2062 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002063 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
2064 /* declared_can_be_null */ true,
2065 input)) {
2066 return true;
2067 }
2068 }
2069 }
2070
2071 return false;
2072}
2073
2074bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2075 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002076 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002077 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002078 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002079 // Test if the return type is a refinement of the declared return type.
2080 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2081 /* declared_can_be_null */ true,
2082 return_replacement)) {
2083 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002084 } else if (return_replacement->IsInstanceFieldGet()) {
2085 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
2086 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2087 if (field_get->GetFieldInfo().GetField() ==
2088 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
2089 return true;
2090 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002091 }
2092 } else if (return_replacement->IsInstanceOf()) {
2093 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2094 return true;
2095 }
2096 }
2097
2098 return false;
2099}
2100
2101void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2102 HInstruction* return_replacement) {
2103 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002104 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002105 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2106 // Make sure that we have a valid type for the return. We may get an invalid one when
2107 // we inline invokes with multiple branches and create a Phi for the result.
2108 // TODO: we could be more precise by merging the phi inputs but that requires
2109 // some functionality from the reference type propagation.
2110 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002111 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002112 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002113 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002114 }
Calin Juravle2e768302015-07-28 14:41:11 +00002115 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002116}
2117
2118} // namespace art