blob: 15b83413b78d7b97e4109727fbbbbe3c37bbc8be [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800429 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
430 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
431 MultiplyAddOpt(bb);
432 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100433 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100435 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700436 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800437 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100438 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100439 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
440 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100441 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
442 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800443 }
buzbee311ca162013-02-28 15:56:43 -0800444 while (bb != NULL) {
445 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
446 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800447 if (use_lvn) {
448 local_valnum->GetValueNumber(mir);
449 }
buzbee311ca162013-02-28 15:56:43 -0800450 // Look for interesting opcodes, skip otherwise
451 Instruction::Code opcode = mir->dalvikInsn.opcode;
452 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000453 case Instruction::IF_EQ:
454 case Instruction::IF_NE:
455 case Instruction::IF_LT:
456 case Instruction::IF_GE:
457 case Instruction::IF_GT:
458 case Instruction::IF_LE:
459 if (!IsConst(mir->ssa_rep->uses[1])) {
460 break;
461 }
462 FALLTHROUGH_INTENDED;
463 case Instruction::IF_EQZ:
464 case Instruction::IF_NEZ:
465 case Instruction::IF_LTZ:
466 case Instruction::IF_GEZ:
467 case Instruction::IF_GTZ:
468 case Instruction::IF_LEZ:
469 // Result known at compile time?
470 if (IsConst(mir->ssa_rep->uses[0])) {
471 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
472 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
473 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
474 if (is_taken) {
475 // Replace with GOTO.
476 bb->fall_through = NullBasicBlockId;
477 mir->dalvikInsn.opcode = Instruction::GOTO;
478 mir->dalvikInsn.vA =
479 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
480 } else {
481 // Make NOP.
482 bb->taken = NullBasicBlockId;
483 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
484 }
485 mir->ssa_rep->num_uses = 0;
486 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
487 successor_to_unlink->ErasePredecessor(bb->id);
Vladimir Marko341e4252014-12-19 10:29:51 +0000488 // We have changed the graph structure.
489 dfs_orders_up_to_date_ = false;
490 domination_up_to_date_ = false;
491 topological_order_up_to_date_ = false;
492 // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input.
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000493 }
494 break;
buzbee311ca162013-02-28 15:56:43 -0800495 case Instruction::CMPL_FLOAT:
496 case Instruction::CMPL_DOUBLE:
497 case Instruction::CMPG_FLOAT:
498 case Instruction::CMPG_DOUBLE:
499 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700500 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800501 // Bitcode doesn't allow this optimization.
502 break;
503 }
504 if (mir->next != NULL) {
505 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800506 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700507 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800508 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
509 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000510 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700511 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800512 case Instruction::CMPL_FLOAT:
513 mir_next->dalvikInsn.opcode =
514 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
515 break;
516 case Instruction::CMPL_DOUBLE:
517 mir_next->dalvikInsn.opcode =
518 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
519 break;
520 case Instruction::CMPG_FLOAT:
521 mir_next->dalvikInsn.opcode =
522 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
523 break;
524 case Instruction::CMPG_DOUBLE:
525 mir_next->dalvikInsn.opcode =
526 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
527 break;
528 case Instruction::CMP_LONG:
529 mir_next->dalvikInsn.opcode =
530 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
531 break;
532 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
533 }
534 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800535 // Clear use count of temp VR.
536 use_counts_[mir->ssa_rep->defs[0]] = 0;
537 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700538 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800539 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
540 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
541 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
542 mir_next->ssa_rep->num_defs = 0;
543 mir->ssa_rep->num_uses = 0;
544 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700545 // Copy in the decoded instruction information for potential SSA re-creation.
546 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
547 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800548 }
549 }
550 break;
buzbee311ca162013-02-28 15:56:43 -0800551 default:
552 break;
553 }
554 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800555 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800556 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800557 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100558 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000559 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700560 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800561 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700562 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
563 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800564
buzbee0d829482013-10-11 15:24:55 -0700565 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800566 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700567 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
568 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800569
570 /*
571 * In the select pattern, the taken edge goes to a block that unconditionally
572 * transfers to the rejoin block and the fall_though edge goes to a block that
573 * unconditionally falls through to the rejoin block.
574 */
575 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
576 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
577 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000578 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800579 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100580
581 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800582 // Are the block bodies something we can handle?
583 if ((ft->first_mir_insn == ft->last_mir_insn) &&
584 (tk->first_mir_insn != tk->last_mir_insn) &&
585 (tk->first_mir_insn->next == tk->last_mir_insn) &&
586 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
587 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
588 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
589 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
590 // Almost there. Are the instructions targeting the same vreg?
591 MIR* if_true = tk->first_mir_insn;
592 MIR* if_false = ft->first_mir_insn;
593 // It's possible that the target of the select isn't used - skip those (rare) cases.
594 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
595 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
596 /*
597 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
598 * Phi node in the merge block and delete it (while using the SSA name
599 * of the merge as the target of the SELECT. Delete both taken and
600 * fallthrough blocks, and set fallthrough to merge block.
601 * NOTE: not updating other dataflow info (no longer used at this point).
602 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
603 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000604 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800605 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
606 bool const_form = (SelectKind(if_true) == kSelectConst);
607 if ((SelectKind(if_true) == kSelectMove)) {
608 if (IsConst(if_true->ssa_rep->uses[0]) &&
609 IsConst(if_false->ssa_rep->uses[0])) {
610 const_form = true;
611 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
612 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
613 }
614 }
615 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800616 /*
617 * TODO: If both constants are the same value, then instead of generating
618 * a select, we should simply generate a const bytecode. This should be
619 * considered after inlining which can lead to CFG of this form.
620 */
buzbee311ca162013-02-28 15:56:43 -0800621 // "true" set val in vB
622 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
623 // "false" set val in vC
624 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
625 } else {
626 DCHECK_EQ(SelectKind(if_true), kSelectMove);
627 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700628 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000629 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800630 src_ssa[0] = mir->ssa_rep->uses[0];
631 src_ssa[1] = if_true->ssa_rep->uses[0];
632 src_ssa[2] = if_false->ssa_rep->uses[0];
633 mir->ssa_rep->uses = src_ssa;
634 mir->ssa_rep->num_uses = 3;
635 }
636 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700637 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000638 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700639 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000640 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800641 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700642 // Match type of uses to def.
643 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700644 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000645 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700646 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
647 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
648 }
buzbee311ca162013-02-28 15:56:43 -0800649 /*
650 * There is usually a Phi node in the join block for our two cases. If the
651 * Phi node only contains our two cases as input, we will use the result
652 * SSA name of the Phi node as our select result and delete the Phi. If
653 * the Phi node has more than two operands, we will arbitrarily use the SSA
Vladimir Marko341e4252014-12-19 10:29:51 +0000654 * name of the "false" path, delete the SSA name of the "true" path from the
buzbee311ca162013-02-28 15:56:43 -0800655 * Phi node (and fix up the incoming arc list).
656 */
657 if (phi->ssa_rep->num_uses == 2) {
658 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000659 // Rather than changing the Phi to kMirOpNop, remove it completely.
660 // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn.
661 tk_tk->RemoveMIR(phi);
662 int dead_false_def = if_false->ssa_rep->defs[0];
663 raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0;
buzbee311ca162013-02-28 15:56:43 -0800664 } else {
Vladimir Marko341e4252014-12-19 10:29:51 +0000665 int live_def = if_false->ssa_rep->defs[0];
buzbee311ca162013-02-28 15:56:43 -0800666 mir->ssa_rep->defs[0] = live_def;
buzbee311ca162013-02-28 15:56:43 -0800667 }
Vladimir Marko341e4252014-12-19 10:29:51 +0000668 int dead_true_def = if_true->ssa_rep->defs[0];
669 raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0;
670 // We want to remove ft and tk and link bb directly to ft_ft. First, we need
671 // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id)
672 // since the live_def above comes from ft->first_mir_insn (if_false).
673 DCHECK(if_false == ft->first_mir_insn);
674 ft_ft->UpdatePredecessor(ft->id, bb->id);
675 // Correct the rest of the links between bb, ft and ft_ft.
676 ft->ErasePredecessor(bb->id);
677 ft->fall_through = NullBasicBlockId;
678 bb->fall_through = ft_ft->id;
679 // Now we can kill tk and ft.
680 tk->Kill(this);
681 ft->Kill(this);
682 // NOTE: DFS order, domination info and topological order are still usable
683 // despite the newly dead blocks.
buzbee311ca162013-02-28 15:56:43 -0800684 }
685 }
686 }
687 }
688 }
buzbee1da1e2f2013-11-15 13:37:01 -0800689 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800690 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100691 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100692 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
693 }
buzbee311ca162013-02-28 15:56:43 -0800694
buzbee311ca162013-02-28 15:56:43 -0800695 return true;
696}
697
buzbee311ca162013-02-28 15:56:43 -0800698/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700699void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700700 if (bb->data_flow_info != NULL) {
701 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
702 if (mir->ssa_rep == NULL) {
703 continue;
buzbee311ca162013-02-28 15:56:43 -0800704 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700705 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700706 if (df_attributes & DF_HAS_NULL_CHKS) {
707 checkstats_->null_checks++;
708 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
709 checkstats_->null_checks_eliminated++;
710 }
711 }
712 if (df_attributes & DF_HAS_RANGE_CHKS) {
713 checkstats_->range_checks++;
714 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
715 checkstats_->range_checks_eliminated++;
716 }
buzbee311ca162013-02-28 15:56:43 -0800717 }
718 }
719 }
buzbee311ca162013-02-28 15:56:43 -0800720}
721
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700722/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700723bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700724 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800725 if (!bb->explicit_throw) {
726 return false;
727 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700728
729 // If we visited it, we are done.
730 if (bb->visited) {
731 return false;
732 }
733 bb->visited = true;
734
buzbee311ca162013-02-28 15:56:43 -0800735 BasicBlock* walker = bb;
736 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700737 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800738 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
739 break;
740 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100741 DCHECK(!walker->predecessors.empty());
742 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700743
744 // If we visited the predecessor, we are done.
745 if (prev->visited) {
746 return false;
747 }
748 prev->visited = true;
749
buzbee311ca162013-02-28 15:56:43 -0800750 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700751 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700752 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800753 break;
754 }
buzbee0d829482013-10-11 15:24:55 -0700755 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700756 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800757 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
758 switch (opcode) {
759 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
760 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
761 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
762 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
763 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
764 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
765 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
766 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
767 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
768 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
769 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
770 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
771 default: LOG(FATAL) << "Unexpected opcode " << opcode;
772 }
773 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700774 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800775 prev->taken = prev->fall_through;
776 prev->fall_through = t_bb;
777 break;
778 }
779 walker = prev;
780 }
781 return false;
782}
783
784/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700785void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800786 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100787 while ((bb->block_type == kDalvikByteCode) &&
788 (bb->last_mir_insn != nullptr) &&
789 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
790 MIR* mir = bb->last_mir_insn;
791 DCHECK(bb->first_mir_insn != nullptr);
792
Vladimir Marko315cc202014-12-18 17:01:02 +0000793 // Get the paired insn and check if it can still throw.
Vladimir Marko312eb252014-10-07 15:01:57 +0100794 MIR* throw_insn = mir->meta.throw_insn;
Vladimir Marko315cc202014-12-18 17:01:02 +0000795 if (CanThrow(throw_insn)) {
buzbee311ca162013-02-28 15:56:43 -0800796 break;
797 }
798
buzbee311ca162013-02-28 15:56:43 -0800799 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700800 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800801 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100802 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700803
804 // Now move instructions from bb_next to bb. Start off with doing a sanity check
805 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800806 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700807 // Now move all instructions (throw instruction to last one) from bb_next to bb.
808 MIR* last_to_move = bb_next->last_mir_insn;
809 bb_next->RemoveMIRList(throw_insn, last_to_move);
810 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
811 // The kMirOpCheck instruction is not needed anymore.
812 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
813 bb->RemoveMIR(mir);
814
Vladimir Marko312eb252014-10-07 15:01:57 +0100815 // Before we overwrite successors, remove their predecessor links to bb.
816 bb_next->ErasePredecessor(bb->id);
817 if (bb->taken != NullBasicBlockId) {
818 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
819 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
820 // bb->taken will be overwritten below.
821 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
822 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
823 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
824 bb_taken->predecessors.clear();
825 bb_taken->block_type = kDead;
826 DCHECK(bb_taken->data_flow_info == nullptr);
827 } else {
828 DCHECK_EQ(bb->successor_block_list_type, kCatch);
829 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
830 if (succ_info->block != NullBasicBlockId) {
831 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
832 DCHECK(succ_bb->catch_entry);
833 succ_bb->ErasePredecessor(bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100834 }
835 }
836 }
buzbee311ca162013-02-28 15:56:43 -0800837 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700838 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100839 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100840 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800841 // Use the ending block linkage from the next block
842 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100843 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800844 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100845 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800846 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900847 * If lower-half of pair of blocks to combine contained
848 * a return or a conditional branch or an explicit throw,
849 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800850 */
851 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900852 bb->conditional_branch = bb_next->conditional_branch;
853 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100854 // Merge the use_lvn flag.
855 bb->use_lvn |= bb_next->use_lvn;
856
857 // Kill the unused block.
858 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800859
860 /*
861 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
862 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100863 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800864 */
865
Vladimir Marko312eb252014-10-07 15:01:57 +0100866 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800867 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100868 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700869 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100870 // Update predecessors in children.
871 ChildBlockIterator iter(bb, this);
872 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
873 child->UpdatePredecessor(bb_next->id, bb->id);
874 }
875
Vladimir Markoffda4992014-12-18 17:05:58 +0000876 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100877 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000878 domination_up_to_date_ = false;
879 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800880
881 // Now, loop back and see if we can keep going
882 }
buzbee311ca162013-02-28 15:56:43 -0800883}
884
Vladimir Marko67c72b82014-10-09 12:26:10 +0100885bool MIRGraph::EliminateNullChecksGate() {
886 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
887 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
888 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000889 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100890
Vladimir Marko67c72b82014-10-09 12:26:10 +0100891 DCHECK(temp_scoped_alloc_.get() == nullptr);
892 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700893 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000894 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
895 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
896 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100897 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000898 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700899
900 // reset MIR_MARK
901 AllNodesIterator iter(this);
902 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
903 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
904 mir->optimization_flags &= ~MIR_MARK;
905 }
906 }
907
Vladimir Marko67c72b82014-10-09 12:26:10 +0100908 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000909}
910
buzbee1da1e2f2013-11-15 13:37:01 -0800911/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100912 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800913 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100914bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100915 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
916 // Ignore the kExitBlock as well.
917 DCHECK(bb->first_mir_insn == nullptr);
918 return false;
919 }
buzbee311ca162013-02-28 15:56:43 -0800920
Vladimir Markof585e542014-11-21 13:41:32 +0000921 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100922 /*
923 * Set initial state. Catch blocks don't need any special treatment.
924 */
925 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100926 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100927 // Assume all ins are objects.
928 for (uint16_t in_reg = GetFirstInVR();
929 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100930 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100931 }
932 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100933 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100934 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100935 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100936 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100937 } else {
938 DCHECK_EQ(bb->block_type, kDalvikByteCode);
939 // Starting state is union of all incoming arcs.
940 bool copied_first = false;
941 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000942 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100943 continue;
944 }
945 BasicBlock* pred_bb = GetBasicBlock(pred_id);
946 DCHECK(pred_bb != nullptr);
947 MIR* null_check_insn = nullptr;
948 if (pred_bb->block_type == kDalvikByteCode) {
949 // Check to see if predecessor had an explicit null-check.
950 MIR* last_insn = pred_bb->last_mir_insn;
951 if (last_insn != nullptr) {
952 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
953 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
954 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
955 // Remember the null check insn if there's no other predecessor requiring null check.
956 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
957 null_check_insn = last_insn;
958 }
buzbee1da1e2f2013-11-15 13:37:01 -0800959 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700960 }
961 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100962 if (!copied_first) {
963 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000964 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100965 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000966 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100967 }
968 if (null_check_insn != nullptr) {
969 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100970 }
971 }
972 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800973 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100974 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100975 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800976
977 // Walk through the instruction in the block, updating as necessary
978 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700979 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800980
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700981 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
982 // The algorithm was written in a phi agnostic way.
983 continue;
984 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100985
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000986 // Might need a null check?
987 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100988 int src_vreg;
989 if (df_attributes & DF_NULL_CHK_OUT0) {
990 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
991 src_vreg = mir->dalvikInsn.vC;
992 } else if (df_attributes & DF_NULL_CHK_B) {
993 DCHECK_NE(df_attributes & DF_REF_B, 0u);
994 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000995 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100996 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
997 DCHECK_NE(df_attributes & DF_REF_A, 0u);
998 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000999 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001000 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001001 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001002 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001003 } else {
1004 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001005 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001006 // Mark src_vreg as null-checked.
1007 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001008 }
1009 }
1010
1011 if ((df_attributes & DF_A_WIDE) ||
1012 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1013 continue;
1014 }
1015
1016 /*
1017 * First, mark all object definitions as requiring null check.
1018 * Note: we can't tell if a CONST definition might be used as an object, so treat
1019 * them all as object definitions.
1020 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001021 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001022 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001023 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001024 }
1025
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001026 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001027 if (df_attributes & DF_NON_NULL_DST) {
1028 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001029 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1030 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001031 }
1032
buzbee311ca162013-02-28 15:56:43 -08001033 // Mark non-null returns from invoke-style NEW*
1034 if (df_attributes & DF_NON_NULL_RET) {
1035 MIR* next_mir = mir->next;
1036 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001037 if (UNLIKELY(next_mir == nullptr)) {
1038 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1039 // target, so the MOVE_RESULT cannot be broken away into another block.
1040 LOG(WARNING) << "Unexpected end of block following new";
1041 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1042 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001043 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001044 // Mark as null checked.
1045 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001046 }
1047 }
1048
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001049 // Propagate null check state on register copies.
1050 if (df_attributes & DF_NULL_TRANSFER_0) {
1051 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1052 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1053 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001054 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001055 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001056 }
1057 }
buzbee311ca162013-02-28 15:56:43 -08001058 }
1059
1060 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001061 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001062 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001063 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001064 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001065 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001066 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001067 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001068 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1069 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001070 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001071 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001072 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1073 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001074 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001075 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001076}
1077
Vladimir Marko67c72b82014-10-09 12:26:10 +01001078void MIRGraph::EliminateNullChecksEnd() {
1079 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001080 temp_.nce.num_vregs = 0u;
1081 temp_.nce.work_vregs_to_check = nullptr;
1082 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001083 DCHECK(temp_scoped_alloc_.get() != nullptr);
1084 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001085
1086 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001087 AllNodesIterator iter(this);
1088 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1089 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001090 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001091 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001092 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001093 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001094 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1095 }
1096 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001097}
1098
1099/*
1100 * Perform type and size inference for a basic block.
1101 */
1102bool MIRGraph::InferTypes(BasicBlock* bb) {
1103 if (bb->data_flow_info == nullptr) return false;
1104
1105 bool infer_changed = false;
1106 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1107 if (mir->ssa_rep == NULL) {
1108 continue;
1109 }
1110
1111 // Propagate type info.
1112 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1113 }
1114
1115 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001116}
1117
1118bool MIRGraph::EliminateClassInitChecksGate() {
1119 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001120 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001121 return false;
1122 }
1123
Vladimir Markobfea9c22014-01-17 17:49:33 +00001124 DCHECK(temp_scoped_alloc_.get() == nullptr);
1125 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1126
1127 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001128 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001129 temp_.cice.indexes = static_cast<uint16_t*>(
1130 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1131 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001132
1133 uint32_t unique_class_count = 0u;
1134 {
1135 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1136 // ScopedArenaAllocator.
1137
1138 // Embed the map value in the entry to save space.
1139 struct MapEntry {
1140 // Map key: the class identified by the declaring dex file and type index.
1141 const DexFile* declaring_dex_file;
1142 uint16_t declaring_class_idx;
1143 // Map value: index into bit vectors of classes requiring initialization checks.
1144 uint16_t index;
1145 };
1146 struct MapEntryComparator {
1147 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1148 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1149 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1150 }
1151 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1152 }
1153 };
1154
Vladimir Markobfea9c22014-01-17 17:49:33 +00001155 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001156 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1157 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001158
1159 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1160 AllNodesIterator iter(this);
1161 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001162 if (bb->block_type == kDalvikByteCode) {
1163 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001164 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001165 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001166 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001167 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1168 MapEntry entry = {
1169 // Treat unresolved fields as if each had its own class.
1170 field_info.IsResolved() ? field_info.DeclaringDexFile()
1171 : nullptr,
1172 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1173 : field_info.FieldIndex(),
1174 static_cast<uint16_t>(class_to_index_map.size())
1175 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001176 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001177 // Using offset/2 for index into temp_.cice.indexes.
1178 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001179 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001180 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001181 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1182 DCHECK(method_info.IsStatic());
1183 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1184 MapEntry entry = {
1185 method_info.DeclaringDexFile(),
1186 method_info.DeclaringClassIndex(),
1187 static_cast<uint16_t>(class_to_index_map.size())
1188 };
1189 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001190 // Using offset/2 for index into temp_.cice.indexes.
1191 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001192 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001193 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001194 }
1195 }
1196 }
1197 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1198 }
1199
1200 if (unique_class_count == 0u) {
1201 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001202 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001203 temp_scoped_alloc_.reset();
1204 return false;
1205 }
1206
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001207 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001208 temp_.cice.num_class_bits = 2u * unique_class_count;
1209 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1210 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1211 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001212 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001213 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1214 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001215 return true;
1216}
1217
1218/*
1219 * Eliminate unnecessary class initialization checks for a basic block.
1220 */
1221bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1222 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001223 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1224 // Ignore the kExitBlock as well.
1225 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001226 return false;
1227 }
1228
1229 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001230 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001231 */
Vladimir Markof585e542014-11-21 13:41:32 +00001232 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001233 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001234 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001235 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001236 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001237 // Starting state is union of all incoming arcs.
1238 bool copied_first = false;
1239 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001240 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001241 continue;
1242 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001243 if (!copied_first) {
1244 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001245 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001246 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001247 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001248 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001249 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001250 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001251 }
1252 // At this point, classes_to_check shows which classes need clinit checks.
1253
1254 // Walk through the instruction in the block, updating as necessary
1255 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001256 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001257 if (index != 0xffffu) {
1258 bool check_initialization = false;
1259 bool check_dex_cache = false;
1260
1261 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1262 // Dex instructions with width 1 can have the same offset/2.
1263
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001264 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001265 check_initialization = true;
1266 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001267 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001268 check_initialization = true;
1269 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1270 }
1271
1272 if (check_dex_cache) {
1273 uint32_t check_dex_cache_index = 2u * index + 1u;
1274 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1275 // Eliminate the class init check.
1276 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1277 } else {
1278 // Do the class init check.
1279 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1280 }
1281 classes_to_check->ClearBit(check_dex_cache_index);
1282 }
1283 if (check_initialization) {
1284 uint32_t check_clinit_index = 2u * index;
1285 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1286 // Eliminate the class init check.
1287 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1288 } else {
1289 // Do the class init check.
1290 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001291 }
1292 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001293 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001294 }
1295 }
1296 }
1297
1298 // Did anything change?
1299 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001300 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001301 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001302 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001303 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001304 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001305 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001306 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1307 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001308 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001309 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001310 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1311 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001312 }
1313 return changed;
1314}
1315
1316void MIRGraph::EliminateClassInitChecksEnd() {
1317 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001318 temp_.cice.num_class_bits = 0u;
1319 temp_.cice.work_classes_to_check = nullptr;
1320 temp_.cice.ending_classes_to_check_matrix = nullptr;
1321 DCHECK(temp_.cice.indexes != nullptr);
1322 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001323 DCHECK(temp_scoped_alloc_.get() != nullptr);
1324 temp_scoped_alloc_.reset();
1325}
1326
Vladimir Marko95a05972014-05-30 10:01:32 +01001327bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001328 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001329 return false;
1330 }
1331
1332 DCHECK(temp_scoped_alloc_ == nullptr);
1333 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001334 temp_.gvn.ifield_ids_ =
1335 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1336 temp_.gvn.sfield_ids_ =
1337 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001338 DCHECK(temp_.gvn.gvn == nullptr);
1339 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1340 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001341 return true;
1342}
1343
1344bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001345 DCHECK(temp_.gvn.gvn != nullptr);
1346 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001347 if (lvn != nullptr) {
1348 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1349 lvn->GetValueNumber(mir);
1350 }
1351 }
Vladimir Markof585e542014-11-21 13:41:32 +00001352 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001353 return change;
1354}
1355
1356void MIRGraph::ApplyGlobalValueNumberingEnd() {
1357 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001358 DCHECK(temp_.gvn.gvn != nullptr);
1359 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001360 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001361 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001362 TopologicalSortIterator iter(this);
1363 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1364 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001365 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001366 if (lvn != nullptr) {
1367 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1368 lvn->GetValueNumber(mir);
1369 }
Vladimir Markof585e542014-11-21 13:41:32 +00001370 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001371 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001372 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001373 }
1374 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001375 // GVN was successful, running the LVN would be useless.
1376 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001377 } else {
1378 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1379 }
1380
Vladimir Markof585e542014-11-21 13:41:32 +00001381 delete temp_.gvn.gvn;
1382 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001383 temp_.gvn.ifield_ids_ = nullptr;
1384 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001385 DCHECK(temp_scoped_alloc_ != nullptr);
1386 temp_scoped_alloc_.reset();
1387}
1388
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001389void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1390 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001391 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1392 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001393 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1394 return;
1395 }
1396
1397 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1398 MethodReference target = method_info.GetTargetMethod();
1399 DexCompilationUnit inlined_unit(
1400 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1401 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1402 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001403 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1404 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001405 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1406 DCHECK(inlined_field_info.IsResolved());
1407
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001408 uint32_t field_info_index = ifield_lowering_infos_.size();
1409 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001410 temp_.smi.processed_indexes->SetBit(method_index);
1411 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001412 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1413}
1414
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001415bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001416 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001417 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001418 return false;
1419 }
1420 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1421 // This isn't the Quick compiler.
1422 return false;
1423 }
1424 return true;
1425}
1426
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001427void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001428 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1429 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1430
1431 DCHECK(temp_scoped_alloc_.get() == nullptr);
1432 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001433 temp_.smi.num_indexes = method_lowering_infos_.size();
1434 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1435 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1436 temp_.smi.processed_indexes->ClearAllBits();
1437 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1438 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001439}
1440
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001441void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001442 if (bb->block_type != kDalvikByteCode) {
1443 return;
1444 }
1445 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001446 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001447 continue;
1448 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001449 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001450 continue;
1451 }
1452 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1453 if (!method_info.FastPath()) {
1454 continue;
1455 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001456
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001457 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001458 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001459 continue;
1460 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001461
1462 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001463 bool needs_clinit = !method_info.IsClassInitialized() &&
1464 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001465 if (needs_clinit) {
1466 continue;
1467 }
1468 }
1469
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001470 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1471 MethodReference target = method_info.GetTargetMethod();
1472 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1473 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001474 if (cu_->verbose || cu_->print_pass) {
1475 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1476 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1477 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1478 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001479 }
1480 }
1481 }
1482}
1483
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001484void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001485 // Clean up temporaries.
1486 DCHECK(temp_.smi.lowering_infos != nullptr);
1487 temp_.smi.lowering_infos = nullptr;
1488 temp_.smi.num_indexes = 0u;
1489 DCHECK(temp_.smi.processed_indexes != nullptr);
1490 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001491 DCHECK(temp_scoped_alloc_.get() != nullptr);
1492 temp_scoped_alloc_.reset();
1493}
1494
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001495void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001496 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001497 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001498 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001499 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001500 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1501 CountChecks(bb);
1502 }
1503 if (stats->null_checks > 0) {
1504 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1505 float checks = static_cast<float>(stats->null_checks);
1506 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1507 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1508 << (eliminated/checks) * 100.0 << "%";
1509 }
1510 if (stats->range_checks > 0) {
1511 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1512 float checks = static_cast<float>(stats->range_checks);
1513 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1514 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1515 << (eliminated/checks) * 100.0 << "%";
1516 }
1517}
1518
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001519bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001520 if (bb->visited) return false;
1521 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1522 || (bb->block_type == kExitBlock))) {
1523 // Ignore special blocks
1524 bb->visited = true;
1525 return false;
1526 }
1527 // Must be head of extended basic block.
1528 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001529 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001530 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001531 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001532 // Visit blocks strictly dominated by this head.
1533 while (bb != NULL) {
1534 bb->visited = true;
1535 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001536 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001537 bb = NextDominatedBlock(bb);
1538 }
buzbee1da1e2f2013-11-15 13:37:01 -08001539 if (terminated_by_return || do_local_value_numbering) {
1540 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001541 bb = start_bb;
1542 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001543 bb->use_lvn = do_local_value_numbering;
1544 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001545 bb = NextDominatedBlock(bb);
1546 }
1547 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001548 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001549}
1550
Vladimir Markoffda4992014-12-18 17:05:58 +00001551void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001552 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1553 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1554 temp_.gvn.ifield_ids_ =
1555 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1556 temp_.gvn.sfield_ids_ =
1557 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1558 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001559}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001560
Vladimir Markoffda4992014-12-18 17:05:58 +00001561void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001562 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1563 ClearAllVisitedFlags();
1564 PreOrderDfsIterator iter2(this);
1565 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1566 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001567 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001568 // Perform extended basic block optimizations.
1569 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1570 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1571 }
1572 } else {
1573 PreOrderDfsIterator iter(this);
1574 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1575 BasicBlockOpt(bb);
1576 }
buzbee311ca162013-02-28 15:56:43 -08001577 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001578}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001579
Vladimir Markoffda4992014-12-18 17:05:58 +00001580void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001581 // Clean up after LVN.
1582 temp_.gvn.ifield_ids_ = nullptr;
1583 temp_.gvn.sfield_ids_ = nullptr;
1584 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001585}
1586
Vladimir Marko8b858e12014-11-27 14:52:37 +00001587bool MIRGraph::EliminateSuspendChecksGate() {
1588 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1589 GetMaxNestedLoops() == 0u || // Nothing to do.
1590 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1591 // Exclude 32 as well to keep bit shifts well-defined.
1592 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1593 return false;
1594 }
1595 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1596 temp_.sce.inliner =
1597 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1598 }
1599 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1600 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1601 return true;
1602}
1603
1604bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1605 if (bb->block_type != kDalvikByteCode) {
1606 return false;
1607 }
1608 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1609 if (bb->nesting_depth == 0u) {
1610 // Out of loops.
1611 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1612 return false;
1613 }
1614 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1615 bool found_invoke = false;
1616 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1617 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1618 (temp_.sce.inliner == nullptr ||
1619 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1620 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1621 found_invoke = true;
1622 break;
1623 }
1624 }
1625 if (!found_invoke) {
1626 // Intersect suspend checks from predecessors.
1627 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1628 uint32_t pred_mask_union = 0u;
1629 for (BasicBlockId pred_id : bb->predecessors) {
1630 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1631 if (pred_topo_idx < bb_topo_idx) {
1632 // Determine the loop depth of the predecessors relative to this block.
1633 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1634 while (pred_loop_depth != 0u &&
1635 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1636 --pred_loop_depth;
1637 }
1638 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1639 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1640 // Intersect pred_mask bits in suspend_checks_in_loops with
1641 // suspend_checks_in_loops_[pred_id].
1642 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1643 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1644 pred_mask_union |= pred_mask;
1645 }
1646 }
1647 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1648 pred_mask_union);
1649 suspend_checks_in_loops &= pred_mask_union;
1650 }
1651 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1652 if (suspend_checks_in_loops == 0u) {
1653 return false;
1654 }
1655 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1656 if (bb->taken != NullBasicBlockId) {
1657 DCHECK(bb->last_mir_insn != nullptr);
1658 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1659 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1660 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1661 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1662 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1663 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1664 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1665 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1666 }
1667 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1668 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1669 MIR* mir = NewMIR();
1670 mir->dalvikInsn.opcode = Instruction::GOTO;
1671 mir->dalvikInsn.vA = 0; // Branch offset.
1672 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1673 mir->m_unit_index = current_method_;
1674 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1675 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1676 bb->AppendMIR(mir);
1677 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1678 }
1679 return true;
1680}
1681
1682void MIRGraph::EliminateSuspendChecksEnd() {
1683 temp_.sce.inliner = nullptr;
1684}
1685
Ningsheng Jiana262f772014-11-25 16:48:07 +08001686bool MIRGraph::CanThrow(MIR* mir) {
1687 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1688 return false;
1689 }
1690 const int opt_flags = mir->optimization_flags;
1691 uint64_t df_attributes = GetDataFlowAttributes(mir);
1692
Vladimir Marko315cc202014-12-18 17:01:02 +00001693 // First, check if the insn can still throw NPE.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001694 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1695 return true;
1696 }
Vladimir Marko315cc202014-12-18 17:01:02 +00001697
1698 // Now process specific instructions.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001699 if ((df_attributes & DF_IFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001700 // The IGET/IPUT family. We have processed the IGET/IPUT null check above.
1701 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1702 // If not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001703 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001704 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
1705 return !fast;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001706 } else if ((df_attributes & DF_SFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001707 // The SGET/SPUT family. Check for potentially throwing class initialization.
1708 // Also, if not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001709 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001710 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
Ningsheng Jiana262f772014-11-25 16:48:07 +08001711 bool is_class_initialized = field_info.IsClassInitialized() ||
1712 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
Vladimir Marko315cc202014-12-18 17:01:02 +00001713 return !(fast && is_class_initialized);
1714 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1715 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
1716 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1717 // Non-throwing only if range check has been eliminated.
1718 return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0);
1719 } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
1720 mir->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
1721 static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) {
1722 // No more checks for these (null check was processed above).
1723 return false;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001724 }
1725 return true;
1726}
1727
1728bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1729 DCHECK(first->ssa_rep != nullptr);
1730 DCHECK(second->ssa_rep != nullptr);
1731 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1732 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1733 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1734 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1735 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1736 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1737 if (use == vreg0 || use == vreg1) {
1738 return true;
1739 }
1740 }
1741 }
1742 return false;
1743}
1744
1745void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1746 bool is_wide, bool is_sub) {
1747 if (is_wide) {
1748 if (is_sub) {
1749 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1750 } else {
1751 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1752 }
1753 } else {
1754 if (is_sub) {
1755 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1756 } else {
1757 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1758 }
1759 }
1760 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1761 int32_t addend0 = INVALID_SREG;
1762 int32_t addend1 = INVALID_SREG;
1763 if (is_wide) {
1764 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1765 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1766 } else {
1767 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1768 }
1769
1770 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1771 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1772 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1773 // Clear the original multiply product ssa use count, as it is not used anymore.
1774 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1775 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1776 if (is_wide) {
1777 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1778 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1779 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1780 add_mir->ssa_rep->uses[4] = addend0;
1781 add_mir->ssa_rep->uses[5] = addend1;
1782 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1783 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1784 } else {
1785 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1786 add_mir->ssa_rep->uses[2] = addend0;
1787 }
1788 // Copy in the decoded instruction information.
1789 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1790 if (is_wide) {
1791 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1792 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1793 } else {
1794 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1795 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1796 }
1797 // Original multiply MIR is set to Nop.
1798 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1799}
1800
1801void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1802 if (bb->block_type == kDead) {
1803 return;
1804 }
1805 ScopedArenaAllocator allocator(&cu_->arena_stack);
1806 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1807 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1808 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1809 Instruction::Code opcode = mir->dalvikInsn.opcode;
1810 bool is_sub = true;
1811 bool is_candidate_multiply = false;
1812 switch (opcode) {
1813 case Instruction::MUL_INT:
1814 case Instruction::MUL_INT_2ADDR:
1815 is_candidate_multiply = true;
1816 break;
1817 case Instruction::MUL_LONG:
1818 case Instruction::MUL_LONG_2ADDR:
1819 if (cu_->target64) {
1820 is_candidate_multiply = true;
1821 }
1822 break;
1823 case Instruction::ADD_INT:
1824 case Instruction::ADD_INT_2ADDR:
1825 is_sub = false;
1826 FALLTHROUGH_INTENDED;
1827 case Instruction::SUB_INT:
1828 case Instruction::SUB_INT_2ADDR:
1829 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1830 // a*b+c
1831 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1832 false /* is_wide */, false /* is_sub */);
1833 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1834 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1835 // c+a*b or c-a*b
1836 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1837 false /* is_wide */, is_sub);
1838 ssa_mul_map.erase(map_it);
1839 }
1840 break;
1841 case Instruction::ADD_LONG:
1842 case Instruction::ADD_LONG_2ADDR:
1843 is_sub = false;
1844 FALLTHROUGH_INTENDED;
1845 case Instruction::SUB_LONG:
1846 case Instruction::SUB_LONG_2ADDR:
1847 if (!cu_->target64) {
1848 break;
1849 }
1850 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1851 // a*b+c
1852 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1853 true /* is_wide */, false /* is_sub */);
1854 ssa_mul_map.erase(map_it);
1855 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1856 // c+a*b or c-a*b
1857 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1858 true /* is_wide */, is_sub);
1859 ssa_mul_map.erase(map_it);
1860 }
1861 break;
1862 default:
1863 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1864 // Should not combine multiply and add MIRs across potential exception.
1865 ssa_mul_map.clear();
1866 }
1867 break;
1868 }
1869
1870 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1871 // It is because that current RA may allocate the same physical register to them. For this
1872 // kind of cases, the multiplier has been updated, we should not use updated value to the
1873 // multiply-add insn.
1874 if (ssa_mul_map.size() > 0) {
1875 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1876 MIR* mul = it->second;
1877 if (HasAntiDependency(mul, mir)) {
1878 it = ssa_mul_map.erase(it);
1879 } else {
1880 ++it;
1881 }
1882 }
1883 }
1884
1885 if (is_candidate_multiply &&
1886 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1887 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1888 }
1889 }
1890}
1891
buzbee311ca162013-02-28 15:56:43 -08001892} // namespace art