blob: e00dea718de91dd659aa9924c0f760c8c6b7b11b [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800429 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
430 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
431 MultiplyAddOpt(bb);
432 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100433 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100435 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700436 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800437 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100438 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100439 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
440 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100441 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
442 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800443 }
buzbee311ca162013-02-28 15:56:43 -0800444 while (bb != NULL) {
445 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
446 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800447 if (use_lvn) {
448 local_valnum->GetValueNumber(mir);
449 }
buzbee311ca162013-02-28 15:56:43 -0800450 // Look for interesting opcodes, skip otherwise
451 Instruction::Code opcode = mir->dalvikInsn.opcode;
452 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000453 case Instruction::IF_EQ:
454 case Instruction::IF_NE:
455 case Instruction::IF_LT:
456 case Instruction::IF_GE:
457 case Instruction::IF_GT:
458 case Instruction::IF_LE:
459 if (!IsConst(mir->ssa_rep->uses[1])) {
460 break;
461 }
462 FALLTHROUGH_INTENDED;
463 case Instruction::IF_EQZ:
464 case Instruction::IF_NEZ:
465 case Instruction::IF_LTZ:
466 case Instruction::IF_GEZ:
467 case Instruction::IF_GTZ:
468 case Instruction::IF_LEZ:
469 // Result known at compile time?
470 if (IsConst(mir->ssa_rep->uses[0])) {
471 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
472 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
473 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
474 if (is_taken) {
475 // Replace with GOTO.
476 bb->fall_through = NullBasicBlockId;
477 mir->dalvikInsn.opcode = Instruction::GOTO;
478 mir->dalvikInsn.vA =
479 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
480 } else {
481 // Make NOP.
482 bb->taken = NullBasicBlockId;
483 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
484 }
485 mir->ssa_rep->num_uses = 0;
486 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
487 successor_to_unlink->ErasePredecessor(bb->id);
488 if (successor_to_unlink->predecessors.empty()) {
489 successor_to_unlink->KillUnreachable(this);
490 }
491 }
492 break;
buzbee311ca162013-02-28 15:56:43 -0800493 case Instruction::CMPL_FLOAT:
494 case Instruction::CMPL_DOUBLE:
495 case Instruction::CMPG_FLOAT:
496 case Instruction::CMPG_DOUBLE:
497 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700498 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800499 // Bitcode doesn't allow this optimization.
500 break;
501 }
502 if (mir->next != NULL) {
503 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800504 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700505 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800506 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
507 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000508 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700509 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800510 case Instruction::CMPL_FLOAT:
511 mir_next->dalvikInsn.opcode =
512 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
513 break;
514 case Instruction::CMPL_DOUBLE:
515 mir_next->dalvikInsn.opcode =
516 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
517 break;
518 case Instruction::CMPG_FLOAT:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
521 break;
522 case Instruction::CMPG_DOUBLE:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
525 break;
526 case Instruction::CMP_LONG:
527 mir_next->dalvikInsn.opcode =
528 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
529 break;
530 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
531 }
532 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800533 // Clear use count of temp VR.
534 use_counts_[mir->ssa_rep->defs[0]] = 0;
535 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700536 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800537 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
538 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
539 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
540 mir_next->ssa_rep->num_defs = 0;
541 mir->ssa_rep->num_uses = 0;
542 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700543 // Copy in the decoded instruction information for potential SSA re-creation.
544 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
545 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800546 }
547 }
548 break;
buzbee311ca162013-02-28 15:56:43 -0800549 default:
550 break;
551 }
552 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800553 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800554 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800555 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100556 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000557 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700558 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800559 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700560 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
561 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800562
buzbee0d829482013-10-11 15:24:55 -0700563 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800564 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700565 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
566 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800567
568 /*
569 * In the select pattern, the taken edge goes to a block that unconditionally
570 * transfers to the rejoin block and the fall_though edge goes to a block that
571 * unconditionally falls through to the rejoin block.
572 */
573 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
574 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
575 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000576 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800577 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100578
579 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800580 // Are the block bodies something we can handle?
581 if ((ft->first_mir_insn == ft->last_mir_insn) &&
582 (tk->first_mir_insn != tk->last_mir_insn) &&
583 (tk->first_mir_insn->next == tk->last_mir_insn) &&
584 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
585 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
586 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
587 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
588 // Almost there. Are the instructions targeting the same vreg?
589 MIR* if_true = tk->first_mir_insn;
590 MIR* if_false = ft->first_mir_insn;
591 // It's possible that the target of the select isn't used - skip those (rare) cases.
592 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
593 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
594 /*
595 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
596 * Phi node in the merge block and delete it (while using the SSA name
597 * of the merge as the target of the SELECT. Delete both taken and
598 * fallthrough blocks, and set fallthrough to merge block.
599 * NOTE: not updating other dataflow info (no longer used at this point).
600 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
601 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000602 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800603 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
604 bool const_form = (SelectKind(if_true) == kSelectConst);
605 if ((SelectKind(if_true) == kSelectMove)) {
606 if (IsConst(if_true->ssa_rep->uses[0]) &&
607 IsConst(if_false->ssa_rep->uses[0])) {
608 const_form = true;
609 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
610 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
611 }
612 }
613 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800614 /*
615 * TODO: If both constants are the same value, then instead of generating
616 * a select, we should simply generate a const bytecode. This should be
617 * considered after inlining which can lead to CFG of this form.
618 */
buzbee311ca162013-02-28 15:56:43 -0800619 // "true" set val in vB
620 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
621 // "false" set val in vC
622 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
623 } else {
624 DCHECK_EQ(SelectKind(if_true), kSelectMove);
625 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700626 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000627 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800628 src_ssa[0] = mir->ssa_rep->uses[0];
629 src_ssa[1] = if_true->ssa_rep->uses[0];
630 src_ssa[2] = if_false->ssa_rep->uses[0];
631 mir->ssa_rep->uses = src_ssa;
632 mir->ssa_rep->num_uses = 3;
633 }
634 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700635 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000636 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700637 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000638 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800639 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700640 // Match type of uses to def.
641 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700642 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000643 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700644 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
645 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
646 }
buzbee311ca162013-02-28 15:56:43 -0800647 /*
648 * There is usually a Phi node in the join block for our two cases. If the
649 * Phi node only contains our two cases as input, we will use the result
650 * SSA name of the Phi node as our select result and delete the Phi. If
651 * the Phi node has more than two operands, we will arbitrarily use the SSA
652 * name of the "true" path, delete the SSA name of the "false" path from the
653 * Phi node (and fix up the incoming arc list).
654 */
655 if (phi->ssa_rep->num_uses == 2) {
656 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
657 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
658 } else {
659 int dead_def = if_false->ssa_rep->defs[0];
660 int live_def = if_true->ssa_rep->defs[0];
661 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700662 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800663 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
664 if (phi->ssa_rep->uses[i] == live_def) {
665 incoming[i] = bb->id;
666 }
667 }
668 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
669 if (phi->ssa_rep->uses[i] == dead_def) {
670 int last_slot = phi->ssa_rep->num_uses - 1;
671 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
672 incoming[i] = incoming[last_slot];
673 }
674 }
675 }
676 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700677 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800678 tk->block_type = kDead;
679 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
680 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
681 }
682 }
683 }
684 }
685 }
686 }
buzbee1da1e2f2013-11-15 13:37:01 -0800687 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800688 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100689 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100690 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
691 }
buzbee311ca162013-02-28 15:56:43 -0800692
buzbee311ca162013-02-28 15:56:43 -0800693 return true;
694}
695
buzbee311ca162013-02-28 15:56:43 -0800696/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700697void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700698 if (bb->data_flow_info != NULL) {
699 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
700 if (mir->ssa_rep == NULL) {
701 continue;
buzbee311ca162013-02-28 15:56:43 -0800702 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700703 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700704 if (df_attributes & DF_HAS_NULL_CHKS) {
705 checkstats_->null_checks++;
706 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
707 checkstats_->null_checks_eliminated++;
708 }
709 }
710 if (df_attributes & DF_HAS_RANGE_CHKS) {
711 checkstats_->range_checks++;
712 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
713 checkstats_->range_checks_eliminated++;
714 }
buzbee311ca162013-02-28 15:56:43 -0800715 }
716 }
717 }
buzbee311ca162013-02-28 15:56:43 -0800718}
719
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700720/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700721bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700722 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800723 if (!bb->explicit_throw) {
724 return false;
725 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700726
727 // If we visited it, we are done.
728 if (bb->visited) {
729 return false;
730 }
731 bb->visited = true;
732
buzbee311ca162013-02-28 15:56:43 -0800733 BasicBlock* walker = bb;
734 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700735 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800736 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
737 break;
738 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100739 DCHECK(!walker->predecessors.empty());
740 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700741
742 // If we visited the predecessor, we are done.
743 if (prev->visited) {
744 return false;
745 }
746 prev->visited = true;
747
buzbee311ca162013-02-28 15:56:43 -0800748 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700749 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700750 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800751 break;
752 }
buzbee0d829482013-10-11 15:24:55 -0700753 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700754 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800755 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
756 switch (opcode) {
757 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
758 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
759 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
760 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
761 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
762 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
763 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
764 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
765 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
766 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
767 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
768 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
769 default: LOG(FATAL) << "Unexpected opcode " << opcode;
770 }
771 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700772 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800773 prev->taken = prev->fall_through;
774 prev->fall_through = t_bb;
775 break;
776 }
777 walker = prev;
778 }
779 return false;
780}
781
782/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700783void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800784 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100785 while ((bb->block_type == kDalvikByteCode) &&
786 (bb->last_mir_insn != nullptr) &&
787 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
788 MIR* mir = bb->last_mir_insn;
789 DCHECK(bb->first_mir_insn != nullptr);
790
791 // Grab the attributes from the paired opcode.
792 MIR* throw_insn = mir->meta.throw_insn;
793 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
794
795 // Don't combine if the throw_insn can still throw NPE.
796 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
797 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
798 break;
799 }
800 // Now whitelist specific instructions.
801 bool ok = false;
802 if ((df_attributes & DF_IFIELD) != 0) {
803 // Combine only if fast, otherwise weird things can happen.
804 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600805 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100806 } else if ((df_attributes & DF_SFIELD) != 0) {
807 // Combine only if fast, otherwise weird things can happen.
808 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600809 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100810 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100811 bool clinit = !field_info.IsClassInitialized() &&
812 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100813 ok = fast && !clinit;
814 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
815 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
816 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
817 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
818 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
819 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
820 ok = true;
821 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
822 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
823 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
824 // No more checks for these (null check was processed above).
825 ok = true;
826 }
827 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800828 break;
829 }
830
buzbee311ca162013-02-28 15:56:43 -0800831 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700832 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800833 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100834 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700835
836 // Now move instructions from bb_next to bb. Start off with doing a sanity check
837 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800838 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700839 // Now move all instructions (throw instruction to last one) from bb_next to bb.
840 MIR* last_to_move = bb_next->last_mir_insn;
841 bb_next->RemoveMIRList(throw_insn, last_to_move);
842 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
843 // The kMirOpCheck instruction is not needed anymore.
844 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
845 bb->RemoveMIR(mir);
846
Vladimir Marko312eb252014-10-07 15:01:57 +0100847 // Before we overwrite successors, remove their predecessor links to bb.
848 bb_next->ErasePredecessor(bb->id);
849 if (bb->taken != NullBasicBlockId) {
850 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
851 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
852 // bb->taken will be overwritten below.
853 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
854 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
855 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
856 bb_taken->predecessors.clear();
857 bb_taken->block_type = kDead;
858 DCHECK(bb_taken->data_flow_info == nullptr);
859 } else {
860 DCHECK_EQ(bb->successor_block_list_type, kCatch);
861 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
862 if (succ_info->block != NullBasicBlockId) {
863 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
864 DCHECK(succ_bb->catch_entry);
865 succ_bb->ErasePredecessor(bb->id);
866 if (succ_bb->predecessors.empty()) {
867 succ_bb->KillUnreachable(this);
868 }
869 }
870 }
871 }
buzbee311ca162013-02-28 15:56:43 -0800872 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700873 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100874 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100875 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800876 // Use the ending block linkage from the next block
877 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100878 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800879 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100880 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800881 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900882 * If lower-half of pair of blocks to combine contained
883 * a return or a conditional branch or an explicit throw,
884 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800885 */
886 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900887 bb->conditional_branch = bb_next->conditional_branch;
888 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100889 // Merge the use_lvn flag.
890 bb->use_lvn |= bb_next->use_lvn;
891
892 // Kill the unused block.
893 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800894
895 /*
896 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
897 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100898 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800899 */
900
Vladimir Marko312eb252014-10-07 15:01:57 +0100901 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800902 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100903 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700904 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100905 // Update predecessors in children.
906 ChildBlockIterator iter(bb, this);
907 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
908 child->UpdatePredecessor(bb_next->id, bb->id);
909 }
910
Vladimir Markoffda4992014-12-18 17:05:58 +0000911 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100912 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000913 domination_up_to_date_ = false;
914 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800915
916 // Now, loop back and see if we can keep going
917 }
buzbee311ca162013-02-28 15:56:43 -0800918}
919
Vladimir Marko67c72b82014-10-09 12:26:10 +0100920bool MIRGraph::EliminateNullChecksGate() {
921 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
922 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
923 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000924 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100925
Vladimir Marko67c72b82014-10-09 12:26:10 +0100926 DCHECK(temp_scoped_alloc_.get() == nullptr);
927 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700928 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000929 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
930 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
931 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100932 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000933 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700934
935 // reset MIR_MARK
936 AllNodesIterator iter(this);
937 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
938 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
939 mir->optimization_flags &= ~MIR_MARK;
940 }
941 }
942
Vladimir Marko67c72b82014-10-09 12:26:10 +0100943 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000944}
945
buzbee1da1e2f2013-11-15 13:37:01 -0800946/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100947 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800948 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100949bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100950 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
951 // Ignore the kExitBlock as well.
952 DCHECK(bb->first_mir_insn == nullptr);
953 return false;
954 }
buzbee311ca162013-02-28 15:56:43 -0800955
Vladimir Markof585e542014-11-21 13:41:32 +0000956 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100957 /*
958 * Set initial state. Catch blocks don't need any special treatment.
959 */
960 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100961 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100962 // Assume all ins are objects.
963 for (uint16_t in_reg = GetFirstInVR();
964 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100965 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100966 }
967 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100968 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100969 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100970 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100971 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100972 } else {
973 DCHECK_EQ(bb->block_type, kDalvikByteCode);
974 // Starting state is union of all incoming arcs.
975 bool copied_first = false;
976 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000977 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100978 continue;
979 }
980 BasicBlock* pred_bb = GetBasicBlock(pred_id);
981 DCHECK(pred_bb != nullptr);
982 MIR* null_check_insn = nullptr;
983 if (pred_bb->block_type == kDalvikByteCode) {
984 // Check to see if predecessor had an explicit null-check.
985 MIR* last_insn = pred_bb->last_mir_insn;
986 if (last_insn != nullptr) {
987 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
988 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
989 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
990 // Remember the null check insn if there's no other predecessor requiring null check.
991 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
992 null_check_insn = last_insn;
993 }
buzbee1da1e2f2013-11-15 13:37:01 -0800994 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700995 }
996 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100997 if (!copied_first) {
998 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000999 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001000 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001001 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001002 }
1003 if (null_check_insn != nullptr) {
1004 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001005 }
1006 }
1007 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -08001008 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001009 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +01001010 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -08001011
1012 // Walk through the instruction in the block, updating as necessary
1013 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -07001014 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -08001015
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -07001016 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
1017 // The algorithm was written in a phi agnostic way.
1018 continue;
1019 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001020
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001021 // Might need a null check?
1022 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001023 int src_vreg;
1024 if (df_attributes & DF_NULL_CHK_OUT0) {
1025 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
1026 src_vreg = mir->dalvikInsn.vC;
1027 } else if (df_attributes & DF_NULL_CHK_B) {
1028 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1029 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001030 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001031 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1032 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1033 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001035 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001036 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001037 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001038 } else {
1039 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001040 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001041 // Mark src_vreg as null-checked.
1042 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001043 }
1044 }
1045
1046 if ((df_attributes & DF_A_WIDE) ||
1047 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1048 continue;
1049 }
1050
1051 /*
1052 * First, mark all object definitions as requiring null check.
1053 * Note: we can't tell if a CONST definition might be used as an object, so treat
1054 * them all as object definitions.
1055 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001056 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001057 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001058 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001059 }
1060
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001061 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001062 if (df_attributes & DF_NON_NULL_DST) {
1063 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001064 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1065 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001066 }
1067
buzbee311ca162013-02-28 15:56:43 -08001068 // Mark non-null returns from invoke-style NEW*
1069 if (df_attributes & DF_NON_NULL_RET) {
1070 MIR* next_mir = mir->next;
1071 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001072 if (UNLIKELY(next_mir == nullptr)) {
1073 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1074 // target, so the MOVE_RESULT cannot be broken away into another block.
1075 LOG(WARNING) << "Unexpected end of block following new";
1076 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1077 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001078 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001079 // Mark as null checked.
1080 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001081 }
1082 }
1083
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001084 // Propagate null check state on register copies.
1085 if (df_attributes & DF_NULL_TRANSFER_0) {
1086 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1087 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1088 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001089 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001090 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001091 }
1092 }
buzbee311ca162013-02-28 15:56:43 -08001093 }
1094
1095 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001096 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001097 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001098 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001099 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001100 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001101 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001102 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001103 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1104 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001105 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001106 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001107 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1108 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001109 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001110 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001111}
1112
Vladimir Marko67c72b82014-10-09 12:26:10 +01001113void MIRGraph::EliminateNullChecksEnd() {
1114 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001115 temp_.nce.num_vregs = 0u;
1116 temp_.nce.work_vregs_to_check = nullptr;
1117 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001118 DCHECK(temp_scoped_alloc_.get() != nullptr);
1119 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001120
1121 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001122 AllNodesIterator iter(this);
1123 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1124 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001125 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001126 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001127 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001128 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001129 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1130 }
1131 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001132}
1133
1134/*
1135 * Perform type and size inference for a basic block.
1136 */
1137bool MIRGraph::InferTypes(BasicBlock* bb) {
1138 if (bb->data_flow_info == nullptr) return false;
1139
1140 bool infer_changed = false;
1141 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1142 if (mir->ssa_rep == NULL) {
1143 continue;
1144 }
1145
1146 // Propagate type info.
1147 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1148 }
1149
1150 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001151}
1152
1153bool MIRGraph::EliminateClassInitChecksGate() {
1154 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001155 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001156 return false;
1157 }
1158
Vladimir Markobfea9c22014-01-17 17:49:33 +00001159 DCHECK(temp_scoped_alloc_.get() == nullptr);
1160 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1161
1162 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001163 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001164 temp_.cice.indexes = static_cast<uint16_t*>(
1165 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1166 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001167
1168 uint32_t unique_class_count = 0u;
1169 {
1170 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1171 // ScopedArenaAllocator.
1172
1173 // Embed the map value in the entry to save space.
1174 struct MapEntry {
1175 // Map key: the class identified by the declaring dex file and type index.
1176 const DexFile* declaring_dex_file;
1177 uint16_t declaring_class_idx;
1178 // Map value: index into bit vectors of classes requiring initialization checks.
1179 uint16_t index;
1180 };
1181 struct MapEntryComparator {
1182 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1183 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1184 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1185 }
1186 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1187 }
1188 };
1189
Vladimir Markobfea9c22014-01-17 17:49:33 +00001190 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001191 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1192 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001193
1194 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1195 AllNodesIterator iter(this);
1196 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001197 if (bb->block_type == kDalvikByteCode) {
1198 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001199 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001200 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001201 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001202 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1203 MapEntry entry = {
1204 // Treat unresolved fields as if each had its own class.
1205 field_info.IsResolved() ? field_info.DeclaringDexFile()
1206 : nullptr,
1207 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1208 : field_info.FieldIndex(),
1209 static_cast<uint16_t>(class_to_index_map.size())
1210 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001211 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001212 // Using offset/2 for index into temp_.cice.indexes.
1213 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001214 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001215 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001216 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1217 DCHECK(method_info.IsStatic());
1218 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1219 MapEntry entry = {
1220 method_info.DeclaringDexFile(),
1221 method_info.DeclaringClassIndex(),
1222 static_cast<uint16_t>(class_to_index_map.size())
1223 };
1224 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001225 // Using offset/2 for index into temp_.cice.indexes.
1226 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001227 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001228 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001229 }
1230 }
1231 }
1232 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1233 }
1234
1235 if (unique_class_count == 0u) {
1236 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001237 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001238 temp_scoped_alloc_.reset();
1239 return false;
1240 }
1241
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001242 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001243 temp_.cice.num_class_bits = 2u * unique_class_count;
1244 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1245 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1246 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001247 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001248 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1249 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001250 return true;
1251}
1252
1253/*
1254 * Eliminate unnecessary class initialization checks for a basic block.
1255 */
1256bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1257 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001258 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1259 // Ignore the kExitBlock as well.
1260 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001261 return false;
1262 }
1263
1264 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001265 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001266 */
Vladimir Markof585e542014-11-21 13:41:32 +00001267 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001268 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001269 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001270 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001271 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001272 // Starting state is union of all incoming arcs.
1273 bool copied_first = false;
1274 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001275 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001276 continue;
1277 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001278 if (!copied_first) {
1279 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001280 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001281 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001282 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001283 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001284 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001285 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001286 }
1287 // At this point, classes_to_check shows which classes need clinit checks.
1288
1289 // Walk through the instruction in the block, updating as necessary
1290 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001291 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001292 if (index != 0xffffu) {
1293 bool check_initialization = false;
1294 bool check_dex_cache = false;
1295
1296 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1297 // Dex instructions with width 1 can have the same offset/2.
1298
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001299 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001300 check_initialization = true;
1301 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001302 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001303 check_initialization = true;
1304 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1305 }
1306
1307 if (check_dex_cache) {
1308 uint32_t check_dex_cache_index = 2u * index + 1u;
1309 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1310 // Eliminate the class init check.
1311 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1312 } else {
1313 // Do the class init check.
1314 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1315 }
1316 classes_to_check->ClearBit(check_dex_cache_index);
1317 }
1318 if (check_initialization) {
1319 uint32_t check_clinit_index = 2u * index;
1320 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1321 // Eliminate the class init check.
1322 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1323 } else {
1324 // Do the class init check.
1325 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001326 }
1327 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001328 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001329 }
1330 }
1331 }
1332
1333 // Did anything change?
1334 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001335 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001336 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001337 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001338 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001339 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001340 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001341 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1342 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001343 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001344 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001345 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1346 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001347 }
1348 return changed;
1349}
1350
1351void MIRGraph::EliminateClassInitChecksEnd() {
1352 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001353 temp_.cice.num_class_bits = 0u;
1354 temp_.cice.work_classes_to_check = nullptr;
1355 temp_.cice.ending_classes_to_check_matrix = nullptr;
1356 DCHECK(temp_.cice.indexes != nullptr);
1357 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001358 DCHECK(temp_scoped_alloc_.get() != nullptr);
1359 temp_scoped_alloc_.reset();
1360}
1361
Vladimir Marko95a05972014-05-30 10:01:32 +01001362bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001363 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001364 return false;
1365 }
1366
1367 DCHECK(temp_scoped_alloc_ == nullptr);
1368 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001369 temp_.gvn.ifield_ids_ =
1370 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1371 temp_.gvn.sfield_ids_ =
1372 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001373 DCHECK(temp_.gvn.gvn == nullptr);
1374 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1375 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001376 return true;
1377}
1378
1379bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001380 DCHECK(temp_.gvn.gvn != nullptr);
1381 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001382 if (lvn != nullptr) {
1383 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1384 lvn->GetValueNumber(mir);
1385 }
1386 }
Vladimir Markof585e542014-11-21 13:41:32 +00001387 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001388 return change;
1389}
1390
1391void MIRGraph::ApplyGlobalValueNumberingEnd() {
1392 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001393 DCHECK(temp_.gvn.gvn != nullptr);
1394 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001395 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001396 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001397 TopologicalSortIterator iter(this);
1398 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1399 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001400 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001401 if (lvn != nullptr) {
1402 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1403 lvn->GetValueNumber(mir);
1404 }
Vladimir Markof585e542014-11-21 13:41:32 +00001405 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001406 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001407 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001408 }
1409 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001410 // GVN was successful, running the LVN would be useless.
1411 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001412 } else {
1413 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1414 }
1415
Vladimir Markof585e542014-11-21 13:41:32 +00001416 delete temp_.gvn.gvn;
1417 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001418 temp_.gvn.ifield_ids_ = nullptr;
1419 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001420 DCHECK(temp_scoped_alloc_ != nullptr);
1421 temp_scoped_alloc_.reset();
1422}
1423
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001424void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1425 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001426 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1427 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001428 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1429 return;
1430 }
1431
1432 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1433 MethodReference target = method_info.GetTargetMethod();
1434 DexCompilationUnit inlined_unit(
1435 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1436 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1437 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001438 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1439 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001440 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1441 DCHECK(inlined_field_info.IsResolved());
1442
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001443 uint32_t field_info_index = ifield_lowering_infos_.size();
1444 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001445 temp_.smi.processed_indexes->SetBit(method_index);
1446 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001447 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1448}
1449
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001450bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001451 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001452 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001453 return false;
1454 }
1455 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1456 // This isn't the Quick compiler.
1457 return false;
1458 }
1459 return true;
1460}
1461
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001462void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001463 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1464 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1465
1466 DCHECK(temp_scoped_alloc_.get() == nullptr);
1467 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001468 temp_.smi.num_indexes = method_lowering_infos_.size();
1469 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1470 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1471 temp_.smi.processed_indexes->ClearAllBits();
1472 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1473 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001474}
1475
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001476void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001477 if (bb->block_type != kDalvikByteCode) {
1478 return;
1479 }
1480 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001481 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001482 continue;
1483 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001484 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001485 continue;
1486 }
1487 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1488 if (!method_info.FastPath()) {
1489 continue;
1490 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001491
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001492 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001493 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001494 continue;
1495 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001496
1497 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001498 bool needs_clinit = !method_info.IsClassInitialized() &&
1499 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001500 if (needs_clinit) {
1501 continue;
1502 }
1503 }
1504
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001505 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1506 MethodReference target = method_info.GetTargetMethod();
1507 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1508 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001509 if (cu_->verbose || cu_->print_pass) {
1510 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1511 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1512 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1513 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001514 }
1515 }
1516 }
1517}
1518
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001519void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001520 // Clean up temporaries.
1521 DCHECK(temp_.smi.lowering_infos != nullptr);
1522 temp_.smi.lowering_infos = nullptr;
1523 temp_.smi.num_indexes = 0u;
1524 DCHECK(temp_.smi.processed_indexes != nullptr);
1525 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001526 DCHECK(temp_scoped_alloc_.get() != nullptr);
1527 temp_scoped_alloc_.reset();
1528}
1529
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001530void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001531 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001532 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001533 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001534 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001535 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1536 CountChecks(bb);
1537 }
1538 if (stats->null_checks > 0) {
1539 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1540 float checks = static_cast<float>(stats->null_checks);
1541 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1542 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1543 << (eliminated/checks) * 100.0 << "%";
1544 }
1545 if (stats->range_checks > 0) {
1546 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1547 float checks = static_cast<float>(stats->range_checks);
1548 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1549 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1550 << (eliminated/checks) * 100.0 << "%";
1551 }
1552}
1553
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001554bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001555 if (bb->visited) return false;
1556 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1557 || (bb->block_type == kExitBlock))) {
1558 // Ignore special blocks
1559 bb->visited = true;
1560 return false;
1561 }
1562 // Must be head of extended basic block.
1563 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001564 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001565 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001566 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001567 // Visit blocks strictly dominated by this head.
1568 while (bb != NULL) {
1569 bb->visited = true;
1570 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001571 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001572 bb = NextDominatedBlock(bb);
1573 }
buzbee1da1e2f2013-11-15 13:37:01 -08001574 if (terminated_by_return || do_local_value_numbering) {
1575 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001576 bb = start_bb;
1577 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001578 bb->use_lvn = do_local_value_numbering;
1579 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001580 bb = NextDominatedBlock(bb);
1581 }
1582 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001583 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001584}
1585
Vladimir Markoffda4992014-12-18 17:05:58 +00001586void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001587 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1588 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1589 temp_.gvn.ifield_ids_ =
1590 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1591 temp_.gvn.sfield_ids_ =
1592 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1593 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001594}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001595
Vladimir Markoffda4992014-12-18 17:05:58 +00001596void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001597 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1598 ClearAllVisitedFlags();
1599 PreOrderDfsIterator iter2(this);
1600 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1601 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001602 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001603 // Perform extended basic block optimizations.
1604 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1605 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1606 }
1607 } else {
1608 PreOrderDfsIterator iter(this);
1609 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1610 BasicBlockOpt(bb);
1611 }
buzbee311ca162013-02-28 15:56:43 -08001612 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001613}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001614
Vladimir Markoffda4992014-12-18 17:05:58 +00001615void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001616 // Clean up after LVN.
1617 temp_.gvn.ifield_ids_ = nullptr;
1618 temp_.gvn.sfield_ids_ = nullptr;
1619 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001620}
1621
Vladimir Marko8b858e12014-11-27 14:52:37 +00001622bool MIRGraph::EliminateSuspendChecksGate() {
1623 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1624 GetMaxNestedLoops() == 0u || // Nothing to do.
1625 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1626 // Exclude 32 as well to keep bit shifts well-defined.
1627 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1628 return false;
1629 }
1630 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1631 temp_.sce.inliner =
1632 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1633 }
1634 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1635 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1636 return true;
1637}
1638
1639bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1640 if (bb->block_type != kDalvikByteCode) {
1641 return false;
1642 }
1643 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1644 if (bb->nesting_depth == 0u) {
1645 // Out of loops.
1646 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1647 return false;
1648 }
1649 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1650 bool found_invoke = false;
1651 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1652 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1653 (temp_.sce.inliner == nullptr ||
1654 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1655 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1656 found_invoke = true;
1657 break;
1658 }
1659 }
1660 if (!found_invoke) {
1661 // Intersect suspend checks from predecessors.
1662 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1663 uint32_t pred_mask_union = 0u;
1664 for (BasicBlockId pred_id : bb->predecessors) {
1665 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1666 if (pred_topo_idx < bb_topo_idx) {
1667 // Determine the loop depth of the predecessors relative to this block.
1668 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1669 while (pred_loop_depth != 0u &&
1670 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1671 --pred_loop_depth;
1672 }
1673 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1674 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1675 // Intersect pred_mask bits in suspend_checks_in_loops with
1676 // suspend_checks_in_loops_[pred_id].
1677 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1678 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1679 pred_mask_union |= pred_mask;
1680 }
1681 }
1682 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1683 pred_mask_union);
1684 suspend_checks_in_loops &= pred_mask_union;
1685 }
1686 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1687 if (suspend_checks_in_loops == 0u) {
1688 return false;
1689 }
1690 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1691 if (bb->taken != NullBasicBlockId) {
1692 DCHECK(bb->last_mir_insn != nullptr);
1693 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1694 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1695 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1696 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1697 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1698 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1699 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1700 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1701 }
1702 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1703 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1704 MIR* mir = NewMIR();
1705 mir->dalvikInsn.opcode = Instruction::GOTO;
1706 mir->dalvikInsn.vA = 0; // Branch offset.
1707 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1708 mir->m_unit_index = current_method_;
1709 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1710 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1711 bb->AppendMIR(mir);
1712 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1713 }
1714 return true;
1715}
1716
1717void MIRGraph::EliminateSuspendChecksEnd() {
1718 temp_.sce.inliner = nullptr;
1719}
1720
Ningsheng Jiana262f772014-11-25 16:48:07 +08001721bool MIRGraph::CanThrow(MIR* mir) {
1722 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1723 return false;
1724 }
1725 const int opt_flags = mir->optimization_flags;
1726 uint64_t df_attributes = GetDataFlowAttributes(mir);
1727
1728 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1729 return true;
1730 }
1731 if ((df_attributes & DF_IFIELD) != 0) {
1732 // The IGET/IPUT family.
1733 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
1734 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1735 // Already processed null check above.
1736 if (fast) {
1737 return false;
1738 }
1739 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1740 // The AGET/APUT family.
1741 // Already processed null check above.
1742 if ((opt_flags & MIR_IGNORE_RANGE_CHECK) != 0) {
1743 return false;
1744 }
1745 } else if ((df_attributes & DF_SFIELD) != 0) {
1746 // The SGET/SPUT family.
1747 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
1748 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1749 bool is_class_initialized = field_info.IsClassInitialized() ||
1750 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
1751 if (fast && is_class_initialized) {
1752 return false;
1753 }
1754 }
1755 return true;
1756}
1757
1758bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1759 DCHECK(first->ssa_rep != nullptr);
1760 DCHECK(second->ssa_rep != nullptr);
1761 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1762 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1763 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1764 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1765 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1766 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1767 if (use == vreg0 || use == vreg1) {
1768 return true;
1769 }
1770 }
1771 }
1772 return false;
1773}
1774
1775void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1776 bool is_wide, bool is_sub) {
1777 if (is_wide) {
1778 if (is_sub) {
1779 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1780 } else {
1781 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1782 }
1783 } else {
1784 if (is_sub) {
1785 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1786 } else {
1787 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1788 }
1789 }
1790 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1791 int32_t addend0 = INVALID_SREG;
1792 int32_t addend1 = INVALID_SREG;
1793 if (is_wide) {
1794 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1795 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1796 } else {
1797 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1798 }
1799
1800 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1801 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1802 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1803 // Clear the original multiply product ssa use count, as it is not used anymore.
1804 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1805 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1806 if (is_wide) {
1807 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1808 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1809 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1810 add_mir->ssa_rep->uses[4] = addend0;
1811 add_mir->ssa_rep->uses[5] = addend1;
1812 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1813 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1814 } else {
1815 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1816 add_mir->ssa_rep->uses[2] = addend0;
1817 }
1818 // Copy in the decoded instruction information.
1819 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1820 if (is_wide) {
1821 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1822 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1823 } else {
1824 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1825 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1826 }
1827 // Original multiply MIR is set to Nop.
1828 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1829}
1830
1831void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1832 if (bb->block_type == kDead) {
1833 return;
1834 }
1835 ScopedArenaAllocator allocator(&cu_->arena_stack);
1836 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1837 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1838 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1839 Instruction::Code opcode = mir->dalvikInsn.opcode;
1840 bool is_sub = true;
1841 bool is_candidate_multiply = false;
1842 switch (opcode) {
1843 case Instruction::MUL_INT:
1844 case Instruction::MUL_INT_2ADDR:
1845 is_candidate_multiply = true;
1846 break;
1847 case Instruction::MUL_LONG:
1848 case Instruction::MUL_LONG_2ADDR:
1849 if (cu_->target64) {
1850 is_candidate_multiply = true;
1851 }
1852 break;
1853 case Instruction::ADD_INT:
1854 case Instruction::ADD_INT_2ADDR:
1855 is_sub = false;
1856 FALLTHROUGH_INTENDED;
1857 case Instruction::SUB_INT:
1858 case Instruction::SUB_INT_2ADDR:
1859 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1860 // a*b+c
1861 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1862 false /* is_wide */, false /* is_sub */);
1863 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1864 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1865 // c+a*b or c-a*b
1866 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1867 false /* is_wide */, is_sub);
1868 ssa_mul_map.erase(map_it);
1869 }
1870 break;
1871 case Instruction::ADD_LONG:
1872 case Instruction::ADD_LONG_2ADDR:
1873 is_sub = false;
1874 FALLTHROUGH_INTENDED;
1875 case Instruction::SUB_LONG:
1876 case Instruction::SUB_LONG_2ADDR:
1877 if (!cu_->target64) {
1878 break;
1879 }
1880 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1881 // a*b+c
1882 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1883 true /* is_wide */, false /* is_sub */);
1884 ssa_mul_map.erase(map_it);
1885 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1886 // c+a*b or c-a*b
1887 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1888 true /* is_wide */, is_sub);
1889 ssa_mul_map.erase(map_it);
1890 }
1891 break;
1892 default:
1893 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1894 // Should not combine multiply and add MIRs across potential exception.
1895 ssa_mul_map.clear();
1896 }
1897 break;
1898 }
1899
1900 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1901 // It is because that current RA may allocate the same physical register to them. For this
1902 // kind of cases, the multiplier has been updated, we should not use updated value to the
1903 // multiply-add insn.
1904 if (ssa_mul_map.size() > 0) {
1905 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1906 MIR* mul = it->second;
1907 if (HasAntiDependency(mul, mir)) {
1908 it = ssa_mul_map.erase(it);
1909 } else {
1910 ++it;
1911 }
1912 }
1913 }
1914
1915 if (is_candidate_multiply &&
1916 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1917 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1918 }
1919 }
1920}
1921
buzbee311ca162013-02-28 15:56:43 -08001922} // namespace art