blob: ebbd28f6c48dfa9e061e57f6776455bba717ed5b [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
Vladimir Marko066f9e42015-01-16 16:04:43 +000038 reg_location_[ssa_reg].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080039}
40
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070041void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070042 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070043 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080044 constant_values_[ssa_reg] = Low32Bits(value);
45 constant_values_[ssa_reg + 1] = High32Bits(value);
Vladimir Marko066f9e42015-01-16 16:04:43 +000046 reg_location_[ssa_reg].is_const = true;
47 reg_location_[ssa_reg + 1].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080048}
49
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080050void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080051 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080052
53 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070054 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070055 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070056 return;
57 }
58
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070059 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080060
Ian Rogers29a26482014-05-02 15:27:29 -070061 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080062
63 if (!(df_attributes & DF_HAS_DEFS)) continue;
64
65 /* Handle instructions that set up constants directly */
66 if (df_attributes & DF_SETS_CONST) {
67 if (df_attributes & DF_DA) {
68 int32_t vB = static_cast<int32_t>(d_insn->vB);
69 switch (d_insn->opcode) {
70 case Instruction::CONST_4:
71 case Instruction::CONST_16:
72 case Instruction::CONST:
73 SetConstant(mir->ssa_rep->defs[0], vB);
74 break;
75 case Instruction::CONST_HIGH16:
76 SetConstant(mir->ssa_rep->defs[0], vB << 16);
77 break;
78 case Instruction::CONST_WIDE_16:
79 case Instruction::CONST_WIDE_32:
80 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
81 break;
82 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070083 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080084 break;
85 case Instruction::CONST_WIDE_HIGH16:
86 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
87 break;
88 default:
89 break;
90 }
91 }
92 /* Handle instructions that set up constants directly */
93 } else if (df_attributes & DF_IS_MOVE) {
94 int i;
95
96 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070097 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080098 }
99 /* Move a register holding a constant to another register */
100 if (i == mir->ssa_rep->num_uses) {
101 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
102 if (df_attributes & DF_A_WIDE) {
103 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
104 }
105 }
106 }
107 }
108 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800109}
110
buzbee311ca162013-02-28 15:56:43 -0800111/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700112MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800113 BasicBlock* bb = *p_bb;
114 if (mir != NULL) {
115 mir = mir->next;
116 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700117 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800118 if ((bb == NULL) || Predecessors(bb) != 1) {
119 mir = NULL;
120 } else {
121 *p_bb = bb;
122 mir = bb->first_mir_insn;
123 }
124 }
125 }
126 return mir;
127}
128
129/*
130 * To be used at an invoke mir. If the logically next mir node represents
131 * a move-result, return it. Else, return NULL. If a move-result exists,
132 * it is required to immediately follow the invoke with no intervening
133 * opcodes or incoming arcs. However, if the result of the invoke is not
134 * used, a move-result may not be present.
135 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700136MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800137 BasicBlock* tbb = bb;
138 mir = AdvanceMIR(&tbb, mir);
139 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800140 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
141 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
142 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
143 break;
144 }
145 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700146 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800147 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700148 } else {
149 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800150 }
151 }
152 return mir;
153}
154
buzbee0d829482013-10-11 15:24:55 -0700155BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800156 if (bb->block_type == kDead) {
157 return NULL;
158 }
159 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
160 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700161 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
162 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800163 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700164 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700165 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700166 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 } else {
168 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700169 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700170 }
buzbee311ca162013-02-28 15:56:43 -0800171 if (bb == NULL || (Predecessors(bb) != 1)) {
172 return NULL;
173 }
174 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
175 return bb;
176}
177
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700178static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800179 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
180 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
181 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
182 if (mir->ssa_rep->uses[i] == ssa_name) {
183 return mir;
184 }
185 }
186 }
187 }
188 return NULL;
189}
190
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700191static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700192 // Work with the case when mir is nullptr.
193 if (mir == nullptr) {
194 return kSelectNone;
195 }
buzbee311ca162013-02-28 15:56:43 -0800196 switch (mir->dalvikInsn.opcode) {
197 case Instruction::MOVE:
198 case Instruction::MOVE_OBJECT:
199 case Instruction::MOVE_16:
200 case Instruction::MOVE_OBJECT_16:
201 case Instruction::MOVE_FROM16:
202 case Instruction::MOVE_OBJECT_FROM16:
203 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700204 case Instruction::CONST:
205 case Instruction::CONST_4:
206 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800207 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700208 case Instruction::GOTO:
209 case Instruction::GOTO_16:
210 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800211 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700212 default:
213 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800214 }
buzbee311ca162013-02-28 15:56:43 -0800215}
216
Vladimir Markoa1a70742014-03-03 10:28:05 +0000217static constexpr ConditionCode kIfCcZConditionCodes[] = {
218 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
219};
220
Andreas Gampe785d2f22014-11-03 22:57:30 -0800221static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
222 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000223
Vladimir Markoa1a70742014-03-03 10:28:05 +0000224static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
225 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
226}
227
Andreas Gampe785d2f22014-11-03 22:57:30 -0800228static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
231static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
232static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
233static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000234
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700235int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100236 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
237 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800238}
239
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700240size_t MIRGraph::GetNumBytesForSpecialTemps() const {
241 // This logic is written with assumption that Method* is only special temp.
242 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
243 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800244}
245
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700246size_t MIRGraph::GetNumAvailableVRTemps() {
247 // First take into account all temps reserved for backend.
248 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
249 return 0;
250 }
251
252 // Calculate remaining ME temps available.
253 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
254
255 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
256 return 0;
257 } else {
258 return remaining_me_temps - num_non_special_compiler_temps_;
259 }
260}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000261
262// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700264 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000265 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800266
267CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700268 // Once the compiler temps have been committed, new ones cannot be requested anymore.
269 DCHECK_EQ(compiler_temps_committed_, false);
270 // Make sure that reserved for BE set is sane.
271 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
272
273 bool verbose = cu_->verbose;
274 const char* ct_type_str = nullptr;
275
276 if (verbose) {
277 switch (ct_type) {
278 case kCompilerTempBackend:
279 ct_type_str = "backend";
280 break;
281 case kCompilerTempSpecialMethodPtr:
282 ct_type_str = "method*";
283 break;
284 case kCompilerTempVR:
285 ct_type_str = "VR";
286 break;
287 default:
288 ct_type_str = "unknown";
289 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700291 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
292 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800293 }
294
295 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000296 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800297
298 // Create the type of temp requested. Special temps need special handling because
299 // they have a specific virtual register assignment.
300 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700301 // This has a special location on stack which is 32-bit or 64-bit depending
302 // on mode. However, we don't want to overlap with non-special section
303 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800304 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800305
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700306 // The vreg is always the first special temp for method ptr.
307 compiler_temp->v_reg = GetFirstSpecialTempVR();
308
309 } else if (ct_type == kCompilerTempBackend) {
310 requested_backend_temp_ = true;
311
312 // Make sure that we are not exceeding temps reserved for BE.
313 // Since VR temps cannot be requested once the BE temps are requested, we
314 // allow reservation of VR temps as well for BE. We
315 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
316 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
317 if (verbose) {
318 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
319 }
320 return nullptr;
321 }
322
323 // Update the remaining reserved temps since we have now used them.
324 // Note that the code below is actually subtracting to remove them from reserve
325 // once they have been claimed. It is careful to not go below zero.
326 if (reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329 if (wide && reserved_temps_for_backend_ >= 1) {
330 reserved_temps_for_backend_--;
331 }
332
333 // The new non-special compiler temp must receive a unique v_reg.
334 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
335 num_non_special_compiler_temps_++;
336 } else if (ct_type == kCompilerTempVR) {
337 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
338 // This is done in order to prevent problems with ssa since these structures are allocated
339 // and managed by the ME.
340 DCHECK_EQ(requested_backend_temp_, false);
341
342 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
343 size_t available_temps = GetNumAvailableVRTemps();
344 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
345 if (verbose) {
346 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
347 }
348 return nullptr;
349 }
350
351 // The new non-special compiler temp must receive a unique v_reg.
352 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
353 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
356 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800357
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700358 // We allocate an sreg as well to make developer life easier.
359 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
360 // this sreg is no longer valid. The caller should be aware of this.
361 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
362
363 if (verbose) {
364 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
365 << " and s" << compiler_temp->s_reg_low << " has been created.";
366 }
367
368 if (wide) {
369 // Only non-special temps are handled as wide for now.
370 // Note that the number of non special temps is incremented below.
371 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
372
373 // Ensure that the two registers are consecutive.
374 int ssa_reg_low = compiler_temp->s_reg_low;
375 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800376 num_non_special_compiler_temps_++;
377
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700378 if (verbose) {
379 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
380 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
381 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700382
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700383 if (reg_location_ != nullptr) {
384 reg_location_[ssa_reg_high] = temp_loc;
385 reg_location_[ssa_reg_high].high_word = true;
386 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
387 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800388 }
389 }
390
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700391 // If the register locations have already been allocated, add the information
392 // about the temp. We will not overflow because they have been initialized
393 // to support the maximum number of temps. For ME temps that have multiple
394 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800395 if (reg_location_ != nullptr) {
396 int ssa_reg_low = compiler_temp->s_reg_low;
397 reg_location_[ssa_reg_low] = temp_loc;
398 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
399 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800400 }
401
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800402 return compiler_temp;
403}
buzbee311ca162013-02-28 15:56:43 -0800404
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000405static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
406 bool is_taken;
407 switch (opcode) {
408 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
409 case Instruction::IF_NE: is_taken = (src1 != src2); break;
410 case Instruction::IF_LT: is_taken = (src1 < src2); break;
411 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
412 case Instruction::IF_GT: is_taken = (src1 > src2); break;
413 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
414 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
415 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
416 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
417 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
418 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
419 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
420 default:
421 LOG(FATAL) << "Unexpected opcode " << opcode;
422 UNREACHABLE();
423 }
424 return is_taken;
425}
426
buzbee311ca162013-02-28 15:56:43 -0800427/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700428bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800429 if (bb->block_type == kDead) {
430 return true;
431 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800432 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
433 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
434 MultiplyAddOpt(bb);
435 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100436 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100437 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100438 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700439 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800440 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100441 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100442 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
443 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100444 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
445 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800446 }
buzbee311ca162013-02-28 15:56:43 -0800447 while (bb != NULL) {
448 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
449 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800450 if (use_lvn) {
451 local_valnum->GetValueNumber(mir);
452 }
buzbee311ca162013-02-28 15:56:43 -0800453 // Look for interesting opcodes, skip otherwise
454 Instruction::Code opcode = mir->dalvikInsn.opcode;
455 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000456 case Instruction::IF_EQ:
457 case Instruction::IF_NE:
458 case Instruction::IF_LT:
459 case Instruction::IF_GE:
460 case Instruction::IF_GT:
461 case Instruction::IF_LE:
462 if (!IsConst(mir->ssa_rep->uses[1])) {
463 break;
464 }
465 FALLTHROUGH_INTENDED;
466 case Instruction::IF_EQZ:
467 case Instruction::IF_NEZ:
468 case Instruction::IF_LTZ:
469 case Instruction::IF_GEZ:
470 case Instruction::IF_GTZ:
471 case Instruction::IF_LEZ:
472 // Result known at compile time?
473 if (IsConst(mir->ssa_rep->uses[0])) {
474 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
475 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
476 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
477 if (is_taken) {
478 // Replace with GOTO.
479 bb->fall_through = NullBasicBlockId;
480 mir->dalvikInsn.opcode = Instruction::GOTO;
481 mir->dalvikInsn.vA =
482 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
483 } else {
484 // Make NOP.
485 bb->taken = NullBasicBlockId;
486 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
487 }
488 mir->ssa_rep->num_uses = 0;
489 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
490 successor_to_unlink->ErasePredecessor(bb->id);
Vladimir Marko341e4252014-12-19 10:29:51 +0000491 // We have changed the graph structure.
492 dfs_orders_up_to_date_ = false;
493 domination_up_to_date_ = false;
494 topological_order_up_to_date_ = false;
495 // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input.
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000496 }
497 break;
buzbee311ca162013-02-28 15:56:43 -0800498 case Instruction::CMPL_FLOAT:
499 case Instruction::CMPL_DOUBLE:
500 case Instruction::CMPG_FLOAT:
501 case Instruction::CMPG_DOUBLE:
502 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700503 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800504 // Bitcode doesn't allow this optimization.
505 break;
506 }
507 if (mir->next != NULL) {
508 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800509 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700510 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800511 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
512 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000513 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700514 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800515 case Instruction::CMPL_FLOAT:
516 mir_next->dalvikInsn.opcode =
517 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
518 break;
519 case Instruction::CMPL_DOUBLE:
520 mir_next->dalvikInsn.opcode =
521 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
522 break;
523 case Instruction::CMPG_FLOAT:
524 mir_next->dalvikInsn.opcode =
525 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
526 break;
527 case Instruction::CMPG_DOUBLE:
528 mir_next->dalvikInsn.opcode =
529 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
530 break;
531 case Instruction::CMP_LONG:
532 mir_next->dalvikInsn.opcode =
533 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
534 break;
535 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
536 }
537 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800538 // Clear use count of temp VR.
539 use_counts_[mir->ssa_rep->defs[0]] = 0;
540 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700541 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800542 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
543 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
544 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
545 mir_next->ssa_rep->num_defs = 0;
546 mir->ssa_rep->num_uses = 0;
547 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700548 // Copy in the decoded instruction information for potential SSA re-creation.
549 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
550 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800551 }
552 }
553 break;
buzbee311ca162013-02-28 15:56:43 -0800554 default:
555 break;
556 }
557 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800558 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800559 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800560 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100561 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000562 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700563 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800564 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700565 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
566 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800567
buzbee0d829482013-10-11 15:24:55 -0700568 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800569 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700570 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
571 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800572
573 /*
574 * In the select pattern, the taken edge goes to a block that unconditionally
575 * transfers to the rejoin block and the fall_though edge goes to a block that
576 * unconditionally falls through to the rejoin block.
577 */
578 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
579 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
580 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000581 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800582 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100583
584 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800585 // Are the block bodies something we can handle?
586 if ((ft->first_mir_insn == ft->last_mir_insn) &&
587 (tk->first_mir_insn != tk->last_mir_insn) &&
588 (tk->first_mir_insn->next == tk->last_mir_insn) &&
589 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
590 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
591 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
592 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
593 // Almost there. Are the instructions targeting the same vreg?
594 MIR* if_true = tk->first_mir_insn;
595 MIR* if_false = ft->first_mir_insn;
596 // It's possible that the target of the select isn't used - skip those (rare) cases.
597 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
598 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
599 /*
600 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
601 * Phi node in the merge block and delete it (while using the SSA name
602 * of the merge as the target of the SELECT. Delete both taken and
603 * fallthrough blocks, and set fallthrough to merge block.
604 * NOTE: not updating other dataflow info (no longer used at this point).
605 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
606 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000607 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800608 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
609 bool const_form = (SelectKind(if_true) == kSelectConst);
610 if ((SelectKind(if_true) == kSelectMove)) {
611 if (IsConst(if_true->ssa_rep->uses[0]) &&
612 IsConst(if_false->ssa_rep->uses[0])) {
613 const_form = true;
614 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
615 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
616 }
617 }
618 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800619 /*
620 * TODO: If both constants are the same value, then instead of generating
621 * a select, we should simply generate a const bytecode. This should be
622 * considered after inlining which can lead to CFG of this form.
623 */
buzbee311ca162013-02-28 15:56:43 -0800624 // "true" set val in vB
625 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
626 // "false" set val in vC
627 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
628 } else {
629 DCHECK_EQ(SelectKind(if_true), kSelectMove);
630 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700631 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000632 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800633 src_ssa[0] = mir->ssa_rep->uses[0];
634 src_ssa[1] = if_true->ssa_rep->uses[0];
635 src_ssa[2] = if_false->ssa_rep->uses[0];
636 mir->ssa_rep->uses = src_ssa;
637 mir->ssa_rep->num_uses = 3;
638 }
639 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700640 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000641 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700642 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000643 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800644 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700645 // Match type of uses to def.
646 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700647 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000648 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700649 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
650 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
651 }
buzbee311ca162013-02-28 15:56:43 -0800652 /*
653 * There is usually a Phi node in the join block for our two cases. If the
654 * Phi node only contains our two cases as input, we will use the result
655 * SSA name of the Phi node as our select result and delete the Phi. If
656 * the Phi node has more than two operands, we will arbitrarily use the SSA
Vladimir Marko341e4252014-12-19 10:29:51 +0000657 * name of the "false" path, delete the SSA name of the "true" path from the
buzbee311ca162013-02-28 15:56:43 -0800658 * Phi node (and fix up the incoming arc list).
659 */
660 if (phi->ssa_rep->num_uses == 2) {
661 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000662 // Rather than changing the Phi to kMirOpNop, remove it completely.
663 // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn.
664 tk_tk->RemoveMIR(phi);
665 int dead_false_def = if_false->ssa_rep->defs[0];
666 raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0;
buzbee311ca162013-02-28 15:56:43 -0800667 } else {
Vladimir Marko341e4252014-12-19 10:29:51 +0000668 int live_def = if_false->ssa_rep->defs[0];
buzbee311ca162013-02-28 15:56:43 -0800669 mir->ssa_rep->defs[0] = live_def;
buzbee311ca162013-02-28 15:56:43 -0800670 }
Vladimir Marko341e4252014-12-19 10:29:51 +0000671 int dead_true_def = if_true->ssa_rep->defs[0];
672 raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0;
673 // We want to remove ft and tk and link bb directly to ft_ft. First, we need
674 // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id)
675 // since the live_def above comes from ft->first_mir_insn (if_false).
676 DCHECK(if_false == ft->first_mir_insn);
677 ft_ft->UpdatePredecessor(ft->id, bb->id);
678 // Correct the rest of the links between bb, ft and ft_ft.
679 ft->ErasePredecessor(bb->id);
680 ft->fall_through = NullBasicBlockId;
681 bb->fall_through = ft_ft->id;
682 // Now we can kill tk and ft.
683 tk->Kill(this);
684 ft->Kill(this);
685 // NOTE: DFS order, domination info and topological order are still usable
686 // despite the newly dead blocks.
buzbee311ca162013-02-28 15:56:43 -0800687 }
688 }
689 }
690 }
691 }
buzbee1da1e2f2013-11-15 13:37:01 -0800692 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800693 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100694 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100695 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
696 }
buzbee311ca162013-02-28 15:56:43 -0800697
buzbee311ca162013-02-28 15:56:43 -0800698 return true;
699}
700
buzbee311ca162013-02-28 15:56:43 -0800701/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700702void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700703 if (bb->data_flow_info != NULL) {
704 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
705 if (mir->ssa_rep == NULL) {
706 continue;
buzbee311ca162013-02-28 15:56:43 -0800707 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700708 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700709 if (df_attributes & DF_HAS_NULL_CHKS) {
710 checkstats_->null_checks++;
711 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
712 checkstats_->null_checks_eliminated++;
713 }
714 }
715 if (df_attributes & DF_HAS_RANGE_CHKS) {
716 checkstats_->range_checks++;
717 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
718 checkstats_->range_checks_eliminated++;
719 }
buzbee311ca162013-02-28 15:56:43 -0800720 }
721 }
722 }
buzbee311ca162013-02-28 15:56:43 -0800723}
724
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700725/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700726bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700727 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800728 if (!bb->explicit_throw) {
729 return false;
730 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700731
732 // If we visited it, we are done.
733 if (bb->visited) {
734 return false;
735 }
736 bb->visited = true;
737
buzbee311ca162013-02-28 15:56:43 -0800738 BasicBlock* walker = bb;
739 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700740 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800741 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
742 break;
743 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100744 DCHECK(!walker->predecessors.empty());
745 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700746
747 // If we visited the predecessor, we are done.
748 if (prev->visited) {
749 return false;
750 }
751 prev->visited = true;
752
buzbee311ca162013-02-28 15:56:43 -0800753 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700754 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700755 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800756 break;
757 }
buzbee0d829482013-10-11 15:24:55 -0700758 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700759 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800760 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
761 switch (opcode) {
762 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
763 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
764 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
765 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
766 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
767 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
768 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
769 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
770 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
771 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
772 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
773 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
774 default: LOG(FATAL) << "Unexpected opcode " << opcode;
775 }
776 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700777 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800778 prev->taken = prev->fall_through;
779 prev->fall_through = t_bb;
780 break;
781 }
782 walker = prev;
783 }
784 return false;
785}
786
787/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700788void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800789 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100790 while ((bb->block_type == kDalvikByteCode) &&
791 (bb->last_mir_insn != nullptr) &&
792 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
793 MIR* mir = bb->last_mir_insn;
794 DCHECK(bb->first_mir_insn != nullptr);
795
Vladimir Marko315cc202014-12-18 17:01:02 +0000796 // Get the paired insn and check if it can still throw.
Vladimir Marko312eb252014-10-07 15:01:57 +0100797 MIR* throw_insn = mir->meta.throw_insn;
Vladimir Marko315cc202014-12-18 17:01:02 +0000798 if (CanThrow(throw_insn)) {
buzbee311ca162013-02-28 15:56:43 -0800799 break;
800 }
801
buzbee311ca162013-02-28 15:56:43 -0800802 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700803 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800804 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100805 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700806
807 // Now move instructions from bb_next to bb. Start off with doing a sanity check
808 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800809 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700810 // Now move all instructions (throw instruction to last one) from bb_next to bb.
811 MIR* last_to_move = bb_next->last_mir_insn;
812 bb_next->RemoveMIRList(throw_insn, last_to_move);
813 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
814 // The kMirOpCheck instruction is not needed anymore.
815 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
816 bb->RemoveMIR(mir);
817
Vladimir Marko312eb252014-10-07 15:01:57 +0100818 // Before we overwrite successors, remove their predecessor links to bb.
819 bb_next->ErasePredecessor(bb->id);
820 if (bb->taken != NullBasicBlockId) {
821 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
822 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
823 // bb->taken will be overwritten below.
824 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
825 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
826 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
827 bb_taken->predecessors.clear();
828 bb_taken->block_type = kDead;
829 DCHECK(bb_taken->data_flow_info == nullptr);
830 } else {
831 DCHECK_EQ(bb->successor_block_list_type, kCatch);
832 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
833 if (succ_info->block != NullBasicBlockId) {
834 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
835 DCHECK(succ_bb->catch_entry);
836 succ_bb->ErasePredecessor(bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100837 }
838 }
839 }
buzbee311ca162013-02-28 15:56:43 -0800840 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700841 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100842 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100843 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800844 // Use the ending block linkage from the next block
845 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100846 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800847 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100848 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800849 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900850 * If lower-half of pair of blocks to combine contained
851 * a return or a conditional branch or an explicit throw,
852 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800853 */
854 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900855 bb->conditional_branch = bb_next->conditional_branch;
856 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100857 // Merge the use_lvn flag.
858 bb->use_lvn |= bb_next->use_lvn;
859
860 // Kill the unused block.
861 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800862
863 /*
864 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
865 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100866 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800867 */
868
Vladimir Marko312eb252014-10-07 15:01:57 +0100869 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800870 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100871 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700872 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100873 // Update predecessors in children.
874 ChildBlockIterator iter(bb, this);
875 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
876 child->UpdatePredecessor(bb_next->id, bb->id);
877 }
878
Vladimir Markoffda4992014-12-18 17:05:58 +0000879 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100880 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000881 domination_up_to_date_ = false;
882 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800883
884 // Now, loop back and see if we can keep going
885 }
buzbee311ca162013-02-28 15:56:43 -0800886}
887
Vladimir Marko67c72b82014-10-09 12:26:10 +0100888bool MIRGraph::EliminateNullChecksGate() {
889 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
890 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
891 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000892 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100893
Vladimir Marko67c72b82014-10-09 12:26:10 +0100894 DCHECK(temp_scoped_alloc_.get() == nullptr);
895 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700896 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000897 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
898 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
899 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100900 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000901 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700902
903 // reset MIR_MARK
904 AllNodesIterator iter(this);
905 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
906 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
907 mir->optimization_flags &= ~MIR_MARK;
908 }
909 }
910
Vladimir Marko67c72b82014-10-09 12:26:10 +0100911 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000912}
913
buzbee1da1e2f2013-11-15 13:37:01 -0800914/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100915 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800916 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100917bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100918 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
919 // Ignore the kExitBlock as well.
920 DCHECK(bb->first_mir_insn == nullptr);
921 return false;
922 }
buzbee311ca162013-02-28 15:56:43 -0800923
Vladimir Markof585e542014-11-21 13:41:32 +0000924 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100925 /*
926 * Set initial state. Catch blocks don't need any special treatment.
927 */
928 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100929 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100930 // Assume all ins are objects.
931 for (uint16_t in_reg = GetFirstInVR();
932 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100933 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100934 }
935 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100936 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100937 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100938 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100939 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100940 } else {
941 DCHECK_EQ(bb->block_type, kDalvikByteCode);
942 // Starting state is union of all incoming arcs.
943 bool copied_first = false;
944 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000945 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100946 continue;
947 }
948 BasicBlock* pred_bb = GetBasicBlock(pred_id);
949 DCHECK(pred_bb != nullptr);
950 MIR* null_check_insn = nullptr;
951 if (pred_bb->block_type == kDalvikByteCode) {
952 // Check to see if predecessor had an explicit null-check.
953 MIR* last_insn = pred_bb->last_mir_insn;
954 if (last_insn != nullptr) {
955 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
956 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
957 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
958 // Remember the null check insn if there's no other predecessor requiring null check.
959 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
960 null_check_insn = last_insn;
961 }
buzbee1da1e2f2013-11-15 13:37:01 -0800962 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700963 }
964 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100965 if (!copied_first) {
966 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000967 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100968 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000969 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100970 }
971 if (null_check_insn != nullptr) {
972 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100973 }
974 }
975 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800976 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100977 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100978 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800979
980 // Walk through the instruction in the block, updating as necessary
981 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700982 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800983
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700984 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
985 // The algorithm was written in a phi agnostic way.
986 continue;
987 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100988
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000989 // Might need a null check?
990 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100991 int src_vreg;
992 if (df_attributes & DF_NULL_CHK_OUT0) {
993 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
994 src_vreg = mir->dalvikInsn.vC;
995 } else if (df_attributes & DF_NULL_CHK_B) {
996 DCHECK_NE(df_attributes & DF_REF_B, 0u);
997 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000998 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100999 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1000 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1001 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001002 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001003 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001004 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001005 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001006 } else {
1007 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001008 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001009 // Mark src_vreg as null-checked.
1010 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001011 }
1012 }
1013
1014 if ((df_attributes & DF_A_WIDE) ||
1015 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1016 continue;
1017 }
1018
1019 /*
1020 * First, mark all object definitions as requiring null check.
1021 * Note: we can't tell if a CONST definition might be used as an object, so treat
1022 * them all as object definitions.
1023 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001024 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001025 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001026 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001027 }
1028
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001029 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001030 if (df_attributes & DF_NON_NULL_DST) {
1031 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001032 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1033 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 }
1035
buzbee311ca162013-02-28 15:56:43 -08001036 // Mark non-null returns from invoke-style NEW*
1037 if (df_attributes & DF_NON_NULL_RET) {
1038 MIR* next_mir = mir->next;
1039 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001040 if (UNLIKELY(next_mir == nullptr)) {
1041 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1042 // target, so the MOVE_RESULT cannot be broken away into another block.
1043 LOG(WARNING) << "Unexpected end of block following new";
1044 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1045 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001046 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001047 // Mark as null checked.
1048 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001049 }
1050 }
1051
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001052 // Propagate null check state on register copies.
1053 if (df_attributes & DF_NULL_TRANSFER_0) {
1054 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1055 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1056 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001057 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001058 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001059 }
1060 }
buzbee311ca162013-02-28 15:56:43 -08001061 }
1062
1063 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001064 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001065 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001066 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001067 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001068 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001069 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001070 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001071 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1072 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001073 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001074 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001075 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1076 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001077 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001078 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001079}
1080
Vladimir Marko67c72b82014-10-09 12:26:10 +01001081void MIRGraph::EliminateNullChecksEnd() {
1082 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001083 temp_.nce.num_vregs = 0u;
1084 temp_.nce.work_vregs_to_check = nullptr;
1085 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001086 DCHECK(temp_scoped_alloc_.get() != nullptr);
1087 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001088
1089 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001090 AllNodesIterator iter(this);
1091 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1092 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001093 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001094 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001095 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001096 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001097 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1098 }
1099 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001100}
1101
1102/*
1103 * Perform type and size inference for a basic block.
1104 */
1105bool MIRGraph::InferTypes(BasicBlock* bb) {
1106 if (bb->data_flow_info == nullptr) return false;
1107
1108 bool infer_changed = false;
1109 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1110 if (mir->ssa_rep == NULL) {
1111 continue;
1112 }
1113
1114 // Propagate type info.
1115 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1116 }
1117
1118 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001119}
1120
1121bool MIRGraph::EliminateClassInitChecksGate() {
1122 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001123 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001124 return false;
1125 }
1126
Vladimir Markobfea9c22014-01-17 17:49:33 +00001127 DCHECK(temp_scoped_alloc_.get() == nullptr);
1128 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1129
1130 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001131 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001132 temp_.cice.indexes = static_cast<uint16_t*>(
1133 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1134 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001135
1136 uint32_t unique_class_count = 0u;
1137 {
1138 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1139 // ScopedArenaAllocator.
1140
1141 // Embed the map value in the entry to save space.
1142 struct MapEntry {
1143 // Map key: the class identified by the declaring dex file and type index.
1144 const DexFile* declaring_dex_file;
1145 uint16_t declaring_class_idx;
1146 // Map value: index into bit vectors of classes requiring initialization checks.
1147 uint16_t index;
1148 };
1149 struct MapEntryComparator {
1150 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1151 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1152 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1153 }
1154 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1155 }
1156 };
1157
Vladimir Markobfea9c22014-01-17 17:49:33 +00001158 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001159 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1160 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001161
1162 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1163 AllNodesIterator iter(this);
1164 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001165 if (bb->block_type == kDalvikByteCode) {
1166 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001167 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001168 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001169 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001170 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1171 MapEntry entry = {
1172 // Treat unresolved fields as if each had its own class.
1173 field_info.IsResolved() ? field_info.DeclaringDexFile()
1174 : nullptr,
1175 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1176 : field_info.FieldIndex(),
1177 static_cast<uint16_t>(class_to_index_map.size())
1178 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001179 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001180 // Using offset/2 for index into temp_.cice.indexes.
1181 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001182 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001183 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001184 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1185 DCHECK(method_info.IsStatic());
1186 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1187 MapEntry entry = {
1188 method_info.DeclaringDexFile(),
1189 method_info.DeclaringClassIndex(),
1190 static_cast<uint16_t>(class_to_index_map.size())
1191 };
1192 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001193 // Using offset/2 for index into temp_.cice.indexes.
1194 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001195 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001196 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001197 }
1198 }
1199 }
1200 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1201 }
1202
1203 if (unique_class_count == 0u) {
1204 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001205 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001206 temp_scoped_alloc_.reset();
1207 return false;
1208 }
1209
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001210 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001211 temp_.cice.num_class_bits = 2u * unique_class_count;
1212 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1213 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1214 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001215 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001216 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1217 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001218 return true;
1219}
1220
1221/*
1222 * Eliminate unnecessary class initialization checks for a basic block.
1223 */
1224bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1225 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001226 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1227 // Ignore the kExitBlock as well.
1228 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001229 return false;
1230 }
1231
1232 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001233 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001234 */
Vladimir Markof585e542014-11-21 13:41:32 +00001235 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001236 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001237 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001238 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001239 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001240 // Starting state is union of all incoming arcs.
1241 bool copied_first = false;
1242 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001243 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001244 continue;
1245 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001246 if (!copied_first) {
1247 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001248 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001249 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001250 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001251 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001252 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001253 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001254 }
1255 // At this point, classes_to_check shows which classes need clinit checks.
1256
1257 // Walk through the instruction in the block, updating as necessary
1258 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001259 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001260 if (index != 0xffffu) {
1261 bool check_initialization = false;
1262 bool check_dex_cache = false;
1263
1264 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1265 // Dex instructions with width 1 can have the same offset/2.
1266
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001267 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001268 check_initialization = true;
1269 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001270 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001271 check_initialization = true;
1272 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1273 }
1274
1275 if (check_dex_cache) {
1276 uint32_t check_dex_cache_index = 2u * index + 1u;
1277 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1278 // Eliminate the class init check.
1279 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1280 } else {
1281 // Do the class init check.
1282 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1283 }
1284 classes_to_check->ClearBit(check_dex_cache_index);
1285 }
1286 if (check_initialization) {
1287 uint32_t check_clinit_index = 2u * index;
1288 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1289 // Eliminate the class init check.
1290 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1291 } else {
1292 // Do the class init check.
1293 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001294 }
1295 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001296 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001297 }
1298 }
1299 }
1300
1301 // Did anything change?
1302 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001303 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001304 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001305 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001306 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001307 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001308 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001309 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1310 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001311 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001312 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001313 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1314 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001315 }
1316 return changed;
1317}
1318
1319void MIRGraph::EliminateClassInitChecksEnd() {
1320 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001321 temp_.cice.num_class_bits = 0u;
1322 temp_.cice.work_classes_to_check = nullptr;
1323 temp_.cice.ending_classes_to_check_matrix = nullptr;
1324 DCHECK(temp_.cice.indexes != nullptr);
1325 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001326 DCHECK(temp_scoped_alloc_.get() != nullptr);
1327 temp_scoped_alloc_.reset();
1328}
1329
Vladimir Marko95a05972014-05-30 10:01:32 +01001330bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001331 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001332 return false;
1333 }
1334
1335 DCHECK(temp_scoped_alloc_ == nullptr);
1336 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001337 temp_.gvn.ifield_ids_ =
1338 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1339 temp_.gvn.sfield_ids_ =
1340 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001341 DCHECK(temp_.gvn.gvn == nullptr);
1342 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1343 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001344 return true;
1345}
1346
1347bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001348 DCHECK(temp_.gvn.gvn != nullptr);
1349 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001350 if (lvn != nullptr) {
1351 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1352 lvn->GetValueNumber(mir);
1353 }
1354 }
Vladimir Markof585e542014-11-21 13:41:32 +00001355 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001356 return change;
1357}
1358
1359void MIRGraph::ApplyGlobalValueNumberingEnd() {
1360 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001361 DCHECK(temp_.gvn.gvn != nullptr);
1362 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001363 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001364 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001365 TopologicalSortIterator iter(this);
1366 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1367 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001368 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001369 if (lvn != nullptr) {
1370 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1371 lvn->GetValueNumber(mir);
1372 }
Vladimir Markof585e542014-11-21 13:41:32 +00001373 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001374 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001375 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001376 }
1377 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001378 // GVN was successful, running the LVN would be useless.
1379 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001380 } else {
1381 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1382 }
1383
Vladimir Markof585e542014-11-21 13:41:32 +00001384 delete temp_.gvn.gvn;
1385 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001386 temp_.gvn.ifield_ids_ = nullptr;
1387 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001388 DCHECK(temp_scoped_alloc_ != nullptr);
1389 temp_scoped_alloc_.reset();
1390}
1391
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001392void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1393 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001394 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1395 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001396 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1397 return;
1398 }
1399
1400 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1401 MethodReference target = method_info.GetTargetMethod();
1402 DexCompilationUnit inlined_unit(
1403 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1404 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1405 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001406 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1407 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001408 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1409 DCHECK(inlined_field_info.IsResolved());
1410
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001411 uint32_t field_info_index = ifield_lowering_infos_.size();
1412 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001413 temp_.smi.processed_indexes->SetBit(method_index);
1414 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001415 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1416}
1417
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001418bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001419 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001420 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001421 return false;
1422 }
1423 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1424 // This isn't the Quick compiler.
1425 return false;
1426 }
1427 return true;
1428}
1429
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001430void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001431 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1432 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1433
1434 DCHECK(temp_scoped_alloc_.get() == nullptr);
1435 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001436 temp_.smi.num_indexes = method_lowering_infos_.size();
1437 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1438 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1439 temp_.smi.processed_indexes->ClearAllBits();
1440 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1441 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001442}
1443
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001444void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001445 if (bb->block_type != kDalvikByteCode) {
1446 return;
1447 }
1448 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001449 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001450 continue;
1451 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001452 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001453 continue;
1454 }
1455 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1456 if (!method_info.FastPath()) {
1457 continue;
1458 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001459
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001460 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001461 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001462 continue;
1463 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001464
1465 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001466 bool needs_clinit = !method_info.IsClassInitialized() &&
1467 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001468 if (needs_clinit) {
1469 continue;
1470 }
1471 }
1472
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001473 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1474 MethodReference target = method_info.GetTargetMethod();
1475 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1476 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001477 if (cu_->verbose || cu_->print_pass) {
1478 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1479 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1480 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1481 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001482 }
1483 }
1484 }
1485}
1486
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001487void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001488 // Clean up temporaries.
1489 DCHECK(temp_.smi.lowering_infos != nullptr);
1490 temp_.smi.lowering_infos = nullptr;
1491 temp_.smi.num_indexes = 0u;
1492 DCHECK(temp_.smi.processed_indexes != nullptr);
1493 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001494 DCHECK(temp_scoped_alloc_.get() != nullptr);
1495 temp_scoped_alloc_.reset();
1496}
1497
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001498void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001499 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001500 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001501 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001502 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001503 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1504 CountChecks(bb);
1505 }
1506 if (stats->null_checks > 0) {
1507 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1508 float checks = static_cast<float>(stats->null_checks);
1509 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1510 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1511 << (eliminated/checks) * 100.0 << "%";
1512 }
1513 if (stats->range_checks > 0) {
1514 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1515 float checks = static_cast<float>(stats->range_checks);
1516 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1517 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1518 << (eliminated/checks) * 100.0 << "%";
1519 }
1520}
1521
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001522bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001523 if (bb->visited) return false;
1524 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1525 || (bb->block_type == kExitBlock))) {
1526 // Ignore special blocks
1527 bb->visited = true;
1528 return false;
1529 }
1530 // Must be head of extended basic block.
1531 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001532 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001533 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001534 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001535 // Visit blocks strictly dominated by this head.
1536 while (bb != NULL) {
1537 bb->visited = true;
1538 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001539 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001540 bb = NextDominatedBlock(bb);
1541 }
buzbee1da1e2f2013-11-15 13:37:01 -08001542 if (terminated_by_return || do_local_value_numbering) {
1543 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001544 bb = start_bb;
1545 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001546 bb->use_lvn = do_local_value_numbering;
1547 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001548 bb = NextDominatedBlock(bb);
1549 }
1550 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001551 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001552}
1553
Vladimir Markoffda4992014-12-18 17:05:58 +00001554void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001555 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1556 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1557 temp_.gvn.ifield_ids_ =
1558 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1559 temp_.gvn.sfield_ids_ =
1560 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1561 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001562}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001563
Vladimir Markoffda4992014-12-18 17:05:58 +00001564void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001565 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1566 ClearAllVisitedFlags();
1567 PreOrderDfsIterator iter2(this);
1568 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1569 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001570 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001571 // Perform extended basic block optimizations.
1572 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1573 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1574 }
1575 } else {
1576 PreOrderDfsIterator iter(this);
1577 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1578 BasicBlockOpt(bb);
1579 }
buzbee311ca162013-02-28 15:56:43 -08001580 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001581}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001582
Vladimir Markoffda4992014-12-18 17:05:58 +00001583void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001584 // Clean up after LVN.
1585 temp_.gvn.ifield_ids_ = nullptr;
1586 temp_.gvn.sfield_ids_ = nullptr;
1587 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001588}
1589
Vladimir Marko8b858e12014-11-27 14:52:37 +00001590bool MIRGraph::EliminateSuspendChecksGate() {
1591 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1592 GetMaxNestedLoops() == 0u || // Nothing to do.
1593 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1594 // Exclude 32 as well to keep bit shifts well-defined.
1595 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1596 return false;
1597 }
1598 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1599 temp_.sce.inliner =
1600 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1601 }
1602 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1603 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1604 return true;
1605}
1606
1607bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1608 if (bb->block_type != kDalvikByteCode) {
1609 return false;
1610 }
1611 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1612 if (bb->nesting_depth == 0u) {
1613 // Out of loops.
1614 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1615 return false;
1616 }
1617 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1618 bool found_invoke = false;
1619 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1620 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1621 (temp_.sce.inliner == nullptr ||
1622 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1623 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1624 found_invoke = true;
1625 break;
1626 }
1627 }
1628 if (!found_invoke) {
1629 // Intersect suspend checks from predecessors.
1630 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1631 uint32_t pred_mask_union = 0u;
1632 for (BasicBlockId pred_id : bb->predecessors) {
1633 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1634 if (pred_topo_idx < bb_topo_idx) {
1635 // Determine the loop depth of the predecessors relative to this block.
1636 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1637 while (pred_loop_depth != 0u &&
1638 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1639 --pred_loop_depth;
1640 }
1641 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1642 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1643 // Intersect pred_mask bits in suspend_checks_in_loops with
1644 // suspend_checks_in_loops_[pred_id].
1645 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1646 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1647 pred_mask_union |= pred_mask;
1648 }
1649 }
1650 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1651 pred_mask_union);
1652 suspend_checks_in_loops &= pred_mask_union;
1653 }
1654 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1655 if (suspend_checks_in_loops == 0u) {
1656 return false;
1657 }
1658 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1659 if (bb->taken != NullBasicBlockId) {
1660 DCHECK(bb->last_mir_insn != nullptr);
1661 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1662 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1663 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1664 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1665 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1666 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1667 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1668 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1669 }
1670 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1671 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1672 MIR* mir = NewMIR();
1673 mir->dalvikInsn.opcode = Instruction::GOTO;
1674 mir->dalvikInsn.vA = 0; // Branch offset.
1675 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1676 mir->m_unit_index = current_method_;
1677 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1678 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1679 bb->AppendMIR(mir);
1680 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1681 }
1682 return true;
1683}
1684
1685void MIRGraph::EliminateSuspendChecksEnd() {
1686 temp_.sce.inliner = nullptr;
1687}
1688
Ningsheng Jiana262f772014-11-25 16:48:07 +08001689bool MIRGraph::CanThrow(MIR* mir) {
1690 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1691 return false;
1692 }
1693 const int opt_flags = mir->optimization_flags;
1694 uint64_t df_attributes = GetDataFlowAttributes(mir);
1695
Vladimir Marko315cc202014-12-18 17:01:02 +00001696 // First, check if the insn can still throw NPE.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001697 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1698 return true;
1699 }
Vladimir Marko315cc202014-12-18 17:01:02 +00001700
1701 // Now process specific instructions.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001702 if ((df_attributes & DF_IFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001703 // The IGET/IPUT family. We have processed the IGET/IPUT null check above.
1704 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1705 // If not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001706 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001707 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
1708 return !fast;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001709 } else if ((df_attributes & DF_SFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001710 // The SGET/SPUT family. Check for potentially throwing class initialization.
1711 // Also, if not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001712 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001713 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
Ningsheng Jiana262f772014-11-25 16:48:07 +08001714 bool is_class_initialized = field_info.IsClassInitialized() ||
1715 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
Vladimir Marko315cc202014-12-18 17:01:02 +00001716 return !(fast && is_class_initialized);
1717 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1718 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
1719 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1720 // Non-throwing only if range check has been eliminated.
1721 return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0);
1722 } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
1723 mir->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
1724 static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) {
1725 // No more checks for these (null check was processed above).
1726 return false;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001727 }
1728 return true;
1729}
1730
1731bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1732 DCHECK(first->ssa_rep != nullptr);
1733 DCHECK(second->ssa_rep != nullptr);
1734 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1735 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1736 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1737 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1738 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1739 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1740 if (use == vreg0 || use == vreg1) {
1741 return true;
1742 }
1743 }
1744 }
1745 return false;
1746}
1747
1748void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1749 bool is_wide, bool is_sub) {
1750 if (is_wide) {
1751 if (is_sub) {
1752 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1753 } else {
1754 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1755 }
1756 } else {
1757 if (is_sub) {
1758 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1759 } else {
1760 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1761 }
1762 }
1763 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1764 int32_t addend0 = INVALID_SREG;
1765 int32_t addend1 = INVALID_SREG;
1766 if (is_wide) {
1767 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1768 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1769 } else {
1770 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1771 }
1772
1773 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1774 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1775 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1776 // Clear the original multiply product ssa use count, as it is not used anymore.
1777 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1778 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1779 if (is_wide) {
1780 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1781 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1782 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1783 add_mir->ssa_rep->uses[4] = addend0;
1784 add_mir->ssa_rep->uses[5] = addend1;
1785 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1786 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1787 } else {
1788 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1789 add_mir->ssa_rep->uses[2] = addend0;
1790 }
1791 // Copy in the decoded instruction information.
1792 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1793 if (is_wide) {
1794 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1795 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1796 } else {
1797 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1798 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1799 }
1800 // Original multiply MIR is set to Nop.
1801 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1802}
1803
1804void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1805 if (bb->block_type == kDead) {
1806 return;
1807 }
1808 ScopedArenaAllocator allocator(&cu_->arena_stack);
1809 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1810 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1811 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1812 Instruction::Code opcode = mir->dalvikInsn.opcode;
1813 bool is_sub = true;
1814 bool is_candidate_multiply = false;
1815 switch (opcode) {
1816 case Instruction::MUL_INT:
1817 case Instruction::MUL_INT_2ADDR:
1818 is_candidate_multiply = true;
1819 break;
1820 case Instruction::MUL_LONG:
1821 case Instruction::MUL_LONG_2ADDR:
1822 if (cu_->target64) {
1823 is_candidate_multiply = true;
1824 }
1825 break;
1826 case Instruction::ADD_INT:
1827 case Instruction::ADD_INT_2ADDR:
1828 is_sub = false;
1829 FALLTHROUGH_INTENDED;
1830 case Instruction::SUB_INT:
1831 case Instruction::SUB_INT_2ADDR:
1832 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1833 // a*b+c
1834 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1835 false /* is_wide */, false /* is_sub */);
1836 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1837 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1838 // c+a*b or c-a*b
1839 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1840 false /* is_wide */, is_sub);
1841 ssa_mul_map.erase(map_it);
1842 }
1843 break;
1844 case Instruction::ADD_LONG:
1845 case Instruction::ADD_LONG_2ADDR:
1846 is_sub = false;
1847 FALLTHROUGH_INTENDED;
1848 case Instruction::SUB_LONG:
1849 case Instruction::SUB_LONG_2ADDR:
1850 if (!cu_->target64) {
1851 break;
1852 }
1853 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1854 // a*b+c
1855 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1856 true /* is_wide */, false /* is_sub */);
1857 ssa_mul_map.erase(map_it);
1858 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1859 // c+a*b or c-a*b
1860 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1861 true /* is_wide */, is_sub);
1862 ssa_mul_map.erase(map_it);
1863 }
1864 break;
1865 default:
1866 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1867 // Should not combine multiply and add MIRs across potential exception.
1868 ssa_mul_map.clear();
1869 }
1870 break;
1871 }
1872
1873 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1874 // It is because that current RA may allocate the same physical register to them. For this
1875 // kind of cases, the multiplier has been updated, we should not use updated value to the
1876 // multiply-add insn.
1877 if (ssa_mul_map.size() > 0) {
1878 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1879 MIR* mul = it->second;
1880 if (HasAntiDependency(mul, mir)) {
1881 it = ssa_mul_map.erase(it);
1882 } else {
1883 ++it;
1884 }
1885 }
1886 }
1887
1888 if (is_candidate_multiply &&
1889 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1890 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1891 }
1892 }
1893}
1894
buzbee311ca162013-02-28 15:56:43 -08001895} // namespace art