blob: 035e5ce3e1939eb2b5566b51faffd8ef9f4069ca [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010024#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070026#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000027#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070028#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010030#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "driver/dex_compilation_unit.h"
32#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010033#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000034#include "jit/jit.h"
35#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "mirror/class_loader.h"
37#include "mirror/dex_cache.h"
38#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010039#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010040#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070041#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070042#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010043#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000044#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "thread.h"
47
48namespace art {
49
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000050// Instruction limit to control memory.
51static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
52
53// Maximum number of instructions for considering a method small,
54// which we will always try to inline if the other non-instruction limits
55// are not reached.
56static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000057
58// Limit the number of dex registers that we accumulate while inlining
59// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010060static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000062// Limit recursive call inlining, which do not benefit from too
63// much inlining compared to code locality.
64static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070065
Calin Juravlee2492d42017-03-20 11:42:13 -070066// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070067static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070068
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000069// We check for line numbers to make sure the DepthString implementation
70// aligns the output nicely.
71#define LOG_INTERNAL(msg) \
72 static_assert(__LINE__ > 10, "Unhandled line number"); \
73 static_assert(__LINE__ < 10000, "Unhandled line number"); \
74 VLOG(compiler) << DepthString(__LINE__) << msg
75
76#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
77#define LOG_NOTE() LOG_INTERNAL("Note: ")
78#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070079#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000080#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
81
82std::string HInliner::DepthString(int line) const {
83 std::string value;
84 // Indent according to the inlining depth.
85 size_t count = depth_;
86 // Line numbers get printed in the log, so add a space if the log's line is less
87 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
88 if (!kIsTargetBuild) {
89 if (line < 100) {
90 value += " ";
91 }
92 if (line < 1000) {
93 value += " ";
94 }
95 // Safeguard if this file reaches more than 10000 lines.
96 DCHECK_LT(line, 10000);
97 }
98 for (size_t i = 0; i < count; ++i) {
99 value += " ";
100 }
101 return value;
102}
103
104static size_t CountNumberOfInstructions(HGraph* graph) {
105 size_t number_of_instructions = 0;
106 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
107 for (HInstructionIterator instr_it(block->GetInstructions());
108 !instr_it.Done();
109 instr_it.Advance()) {
110 ++number_of_instructions;
111 }
112 }
113 return number_of_instructions;
114}
115
116void HInliner::UpdateInliningBudget() {
117 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
118 // Always try to inline small methods.
119 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
120 } else {
121 inlining_budget_ = std::max(
122 kMaximumNumberOfInstructionsForSmallMethod,
123 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
124 }
125}
126
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000127void HInliner::Run() {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000128 if (graph_->IsDebuggable()) {
129 // For simplicity, we currently never inline when the graph is debuggable. This avoids
130 // doing some logic in the runtime to discover if a method could have been inlined.
131 return;
132 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000133
134 // Initialize the number of instructions for the method being compiled. Recursive calls
135 // to HInliner::Run have already updated the instruction count.
136 if (outermost_graph_ == graph_) {
137 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
138 }
139
140 UpdateInliningBudget();
141 DCHECK_NE(total_number_of_instructions_, 0u);
142 DCHECK_NE(inlining_budget_, 0u);
143
Roland Levillain6c3af162017-04-27 11:18:56 +0100144 // If we're compiling with a core image (which is only used for
145 // test purposes), honor inlining directives in method names:
146 // - if a method's name contains the substring "$inline$", ensure
147 // that this method is actually inlined;
148 // - if a method's name contains the substring "$noinline$", do not
149 // inline that method.
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100150 // We limit this to AOT compilation, as the JIT may or may not inline
151 // depending on the state of classes at runtime.
152 const bool honor_inlining_directives =
153 IsCompilingWithCoreImage() && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100154
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000155 // Keep a copy of all blocks when starting the visit.
156 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100157 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000158 // Because we are changing the graph when inlining,
159 // we just iterate over the blocks of the outer method.
160 // This avoids doing the inlining work again on the inlined blocks.
161 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000162 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
163 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100164 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700165 // As long as the call is not intrinsified, it is worth trying to inline.
166 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Roland Levillain6c3af162017-04-27 11:18:56 +0100167 if (honor_inlining_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000168 // Debugging case: directives in method names control or assert on inlining.
169 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
170 call->GetDexMethodIndex(), /* with_signature */ false);
171 // Tests prevent inlining by having $noinline$ in their method names.
172 if (callee_name.find("$noinline$") == std::string::npos) {
173 if (!TryInline(call)) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000174 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
175 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000176 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000177 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100178 } else {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000179 // Normal case: try to inline.
180 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000181 }
182 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000183 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000184 }
185 }
186}
187
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100188static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700189 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100190 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
191}
192
193/**
194 * Given the `resolved_method` looked up in the dex cache, try to find
195 * the actual runtime target of an interface or virtual call.
196 * Return nullptr if the runtime target cannot be proven.
197 */
198static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700199 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100200 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
201 // No need to lookup further, the resolved method will be the target.
202 return resolved_method;
203 }
204
205 HInstruction* receiver = invoke->InputAt(0);
206 if (receiver->IsNullCheck()) {
207 // Due to multiple levels of inlining within the same pass, it might be that
208 // null check does not have the reference type of the actual receiver.
209 receiver = receiver->InputAt(0);
210 }
211 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000212 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
213 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100214 // We currently only support inlining with known receivers.
215 // TODO: Remove this check, we should be able to inline final methods
216 // on unknown receivers.
217 return nullptr;
218 } else if (info.GetTypeHandle()->IsInterface()) {
219 // Statically knowing that the receiver has an interface type cannot
220 // help us find what is the target method.
221 return nullptr;
222 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
223 // The method that we're trying to call is not in the receiver's class or super classes.
224 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000225 } else if (info.GetTypeHandle()->IsErroneous()) {
226 // If the type is erroneous, do not go further, as we are going to query the vtable or
227 // imt table, that we can only safely do on non-erroneous classes.
228 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 }
230
231 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700232 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100233 if (invoke->IsInvokeInterface()) {
234 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
235 resolved_method, pointer_size);
236 } else {
237 DCHECK(invoke->IsInvokeVirtual());
238 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
239 resolved_method, pointer_size);
240 }
241
242 if (resolved_method == nullptr) {
243 // The information we had on the receiver was not enough to find
244 // the target method. Since we check above the exact type of the receiver,
245 // the only reason this can happen is an IncompatibleClassChangeError.
246 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700247 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100248 // The information we had on the receiver was not enough to find
249 // the target method. Since we check above the exact type of the receiver,
250 // the only reason this can happen is an IncompatibleClassChangeError.
251 return nullptr;
252 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
253 // A final method has to be the target method.
254 return resolved_method;
255 } else if (info.IsExact()) {
256 // If we found a method and the receiver's concrete type is statically
257 // known, we know for sure the target.
258 return resolved_method;
259 } else {
260 // Even if we did find a method, the receiver type was not enough to
261 // statically find the runtime target.
262 return nullptr;
263 }
264}
265
266static uint32_t FindMethodIndexIn(ArtMethod* method,
267 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000268 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700269 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100270 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100271 return method->GetDexMethodIndex();
272 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000273 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100274 }
275}
276
Andreas Gampea5b09a62016-11-17 15:21:22 -0800277static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000278 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700279 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000280 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800281 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100282 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700283 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000284 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800285 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700286 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100287 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100288 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000289 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000290 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100291 } else {
292 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100294 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 // the right class already resolved with the class loader.
296 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000297 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000298 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
299 if (resolved != cls) {
300 index = dex::TypeIndex::Invalid();
301 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100302 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100303 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000304
305 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100306}
307
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000308class ScopedProfilingInfoInlineUse {
309 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000310 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
311 : method_(method),
312 self_(self),
313 // Fetch the profiling info ahead of using it. If it's null when fetching,
314 // we should not call JitCodeCache::DoneInlining.
315 profiling_info_(
316 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000317 }
318
319 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000320 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700321 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000322 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
323 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
324 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000325 }
326
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000327 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
328
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000329 private:
330 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000331 Thread* const self_;
332 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000333};
334
Calin Juravle13439f02017-02-21 01:17:21 -0800335HInliner::InlineCacheType HInliner::GetInlineCacheType(
336 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
337 REQUIRES_SHARED(Locks::mutator_lock_) {
338 uint8_t number_of_types = 0;
339 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
340 if (classes->Get(number_of_types) == nullptr) {
341 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000342 }
343 }
Calin Juravle13439f02017-02-21 01:17:21 -0800344
345 if (number_of_types == 0) {
346 return kInlineCacheUninitialized;
347 } else if (number_of_types == 1) {
348 return kInlineCacheMonomorphic;
349 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
350 return kInlineCacheMegamorphic;
351 } else {
352 return kInlineCachePolymorphic;
353 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000354}
355
356static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
357 REQUIRES_SHARED(Locks::mutator_lock_) {
358 DCHECK(classes->Get(0) != nullptr);
359 return classes->Get(0);
360}
361
Mingyao Yang063fc772016-08-02 11:02:54 -0700362ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
363 if (!resolved_method->HasSingleImplementation()) {
364 return nullptr;
365 }
366 if (Runtime::Current()->IsAotCompiler()) {
367 // No CHA-based devirtulization for AOT compiler (yet).
368 return nullptr;
369 }
370 if (outermost_graph_->IsCompilingOsr()) {
371 // We do not support HDeoptimize in OSR methods.
372 return nullptr;
373 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800374 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000375 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
376 if (single_impl == nullptr) {
377 return nullptr;
378 }
379 if (single_impl->IsProxyMethod()) {
380 // Proxy method is a generic invoker that's not worth
381 // devirtualizing/inlining. It also causes issues when the proxy
382 // method is in another dex file if we try to rewrite invoke-interface to
383 // invoke-virtual because a proxy method doesn't have a real dex file.
384 return nullptr;
385 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100386 if (!single_impl->GetDeclaringClass()->IsResolved()) {
387 // There's a race with the class loading, which updates the CHA info
388 // before setting the class to resolved. So we just bail for this
389 // rare occurence.
390 return nullptr;
391 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000392 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700393}
394
David Sehr0225f8e2018-01-31 08:52:24 +0000395static bool AlwaysThrows(ArtMethod* method)
396 REQUIRES_SHARED(Locks::mutator_lock_) {
397 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800398 // Skip native methods, methods with try blocks, and methods that are too large.
399 if (!accessor.HasCodeItem() ||
400 accessor.TriesSize() != 0 ||
401 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
402 return false;
403 }
404 // Scan for exits.
405 bool throw_seen = false;
406 for (const DexInstructionPcPair& pair : accessor) {
407 switch (pair.Inst().Opcode()) {
408 case Instruction::RETURN:
409 case Instruction::RETURN_VOID:
410 case Instruction::RETURN_WIDE:
411 case Instruction::RETURN_OBJECT:
412 case Instruction::RETURN_VOID_NO_BARRIER:
413 return false; // found regular control flow back
414 case Instruction::THROW:
415 throw_seen = true;
416 break;
417 default:
418 break;
419 }
420 }
421 return throw_seen;
422}
423
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700424bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000425 if (invoke_instruction->IsInvokeUnresolved() ||
426 invoke_instruction->IsInvokePolymorphic()) {
427 return false; // Don't bother to move further if we know the method is unresolved or an
428 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100429 }
430
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000431 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100432 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000433 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000434 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000435
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100436 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100437 if (resolved_method == nullptr) {
438 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
439 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000440 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100441 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000442 }
443 ArtMethod* actual_method = nullptr;
444
445 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800446 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000447 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100448 // Check if we can statically find the method.
449 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000450 }
451
Mingyao Yang063fc772016-08-02 11:02:54 -0700452 bool cha_devirtualize = false;
453 if (actual_method == nullptr) {
454 ArtMethod* method = TryCHADevirtualization(resolved_method);
455 if (method != nullptr) {
456 cha_devirtualize = true;
457 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000458 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700459 }
460 }
461
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100462 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800463 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700464 bool result = TryInlineAndReplace(invoke_instruction,
465 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000466 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700467 /* do_rtp */ true,
468 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800469 if (result) {
470 // Successfully inlined.
471 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
472 if (cha_devirtualize) {
473 // Add dependency due to devirtualization. We've assumed resolved_method
474 // has single implementation.
475 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
476 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
477 } else {
478 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
479 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700480 }
Aart Bikd4e328f2018-01-16 14:14:34 -0800481 } else if (!cha_devirtualize && AlwaysThrows(actual_method)) {
482 // Set always throws property for non-inlined method call with single target
483 // (unless it was obtained through CHA, because that would imply we have
484 // to add the CHA dependency, which seems not worth it).
485 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000486 }
487 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100488 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800489 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100490
Calin Juravle13439f02017-02-21 01:17:21 -0800491 // Try using inline caches.
492 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
493}
494
495static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
496 const DexCompilationUnit& compilation_unit,
497 StackHandleScope<1>* hs)
498 REQUIRES_SHARED(Locks::mutator_lock_) {
499 Thread* self = Thread::Current();
500 ClassLinker* class_linker = compilation_unit.GetClassLinker();
501 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
502 mirror::ObjectArray<mirror::Class>::Alloc(
503 self,
504 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
505 InlineCache::kIndividualCacheSize));
506 if (inline_cache == nullptr) {
507 // We got an OOME. Just clear the exception, and don't inline.
508 DCHECK(self->IsExceptionPending());
509 self->ClearException();
510 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
511 }
512 return inline_cache;
513}
514
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700515bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
516 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
517 // do not generate a deopt.
518 //
519 // For AOT:
520 // Generating a deopt does not ensure that we will actually capture the new types;
521 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
522 // Take for example the following scenario:
523 // - we capture the inline cache in one run
524 // - the next run, we deoptimize because we miss a type check, but the method
525 // never becomes hot again
526 // In this case, the inline cache will not be updated in the profile and the AOT code
527 // will keep deoptimizing.
528 // Another scenario is if we use profile compilation for a process which is not allowed
529 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
530 // rest of the lifetime.
531 // TODO(calin):
532 // This is a compromise because we will most likely never update the inline cache
533 // in the profile (unless there's another reason to deopt). So we might be stuck with
534 // a sub-optimal inline cache.
535 // We could be smarter when capturing inline caches to mitigate this.
536 // (e.g. by having different thresholds for new and old methods).
537 //
538 // For OSR:
539 // We may come from the interpreter and it may have seen different receiver types.
540 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
541}
Calin Juravle13439f02017-02-21 01:17:21 -0800542bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
543 HInvoke* invoke_instruction,
544 ArtMethod* resolved_method)
545 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700546 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
547 return false;
548 }
549
Calin Juravle13439f02017-02-21 01:17:21 -0800550 StackHandleScope<1> hs(Thread::Current());
551 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
552 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
553 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
554 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
555
556 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000557 case kInlineCacheNoData: {
558 LOG_FAIL_NO_STAT()
559 << "Interface or virtual call to "
560 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
561 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800562 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000563 }
Calin Juravle13439f02017-02-21 01:17:21 -0800564
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000565 case kInlineCacheUninitialized: {
566 LOG_FAIL_NO_STAT()
567 << "Interface or virtual call to "
568 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
569 << " is not hit and not inlined";
570 return false;
571 }
572
573 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000574 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700575 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800576 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000577 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800578 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000579 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000580 }
Calin Juravle13439f02017-02-21 01:17:21 -0800581
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000582 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000583 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800584 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000585 }
Calin Juravle13439f02017-02-21 01:17:21 -0800586
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000587 case kInlineCacheMegamorphic: {
588 LOG_FAIL_NO_STAT()
589 << "Interface or virtual call to "
590 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
591 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000592 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800593 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000594 }
Calin Juravle13439f02017-02-21 01:17:21 -0800595
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000596 case kInlineCacheMissingTypes: {
597 LOG_FAIL_NO_STAT()
598 << "Interface or virtual call to "
599 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
600 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800601 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000602 }
Calin Juravle13439f02017-02-21 01:17:21 -0800603 }
604 UNREACHABLE();
605}
606
607HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
608 HInvoke* invoke_instruction,
609 StackHandleScope<1>* hs,
610 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
611 REQUIRES_SHARED(Locks::mutator_lock_) {
612 DCHECK(Runtime::Current()->UseJitCompilation());
613
614 ArtMethod* caller = graph_->GetArtMethod();
615 // Under JIT, we should always know the caller.
616 DCHECK(caller != nullptr);
617 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
618 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
619
620 if (profiling_info == nullptr) {
621 return kInlineCacheNoData;
622 }
623
624 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
625 if (inline_cache->Get() == nullptr) {
626 // We can't extract any data if we failed to allocate;
627 return kInlineCacheNoData;
628 } else {
629 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
630 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
631 *inline_cache);
632 return GetInlineCacheType(*inline_cache);
633 }
634}
635
636HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
637 const DexFile& caller_dex_file,
638 HInvoke* invoke_instruction,
639 StackHandleScope<1>* hs,
640 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
641 REQUIRES_SHARED(Locks::mutator_lock_) {
642 DCHECK(Runtime::Current()->IsAotCompiler());
643 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
644 if (pci == nullptr) {
645 return kInlineCacheNoData;
646 }
647
Calin Juravlecc3171a2017-05-19 16:47:53 -0700648 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
649 pci->GetMethod(caller_dex_file.GetLocation(),
650 caller_dex_file.GetLocationChecksum(),
651 caller_compilation_unit_.GetDexMethodIndex());
652 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800653 return kInlineCacheNoData; // no profile information for this invocation.
654 }
655
656 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
657 if (inline_cache == nullptr) {
658 // We can't extract any data if we failed to allocate;
659 return kInlineCacheNoData;
660 } else {
661 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700662 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800663 *inline_cache);
664 }
665}
666
667HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
668 const HInvoke* invoke_instruction,
669 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
670 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
671 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700672 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
673 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800674 return kInlineCacheUninitialized;
675 }
676
677 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
678
679 if (dex_pc_data.is_missing_types) {
680 return kInlineCacheMissingTypes;
681 }
682 if (dex_pc_data.is_megamorphic) {
683 return kInlineCacheMegamorphic;
684 }
685
686 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
687 Thread* self = Thread::Current();
688 // We need to resolve the class relative to the containing dex file.
689 // So first, build a mapping from the index of dex file in the profile to
690 // its dex cache. This will avoid repeating the lookup when walking over
691 // the inline cache types.
692 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
693 offline_profile.dex_references.size());
694 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
695 bool found = false;
696 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
697 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
698 dex_profile_index_to_dex_cache[i] =
699 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
700 found = true;
701 }
702 }
703 if (!found) {
704 VLOG(compiler) << "Could not find profiled dex file: "
705 << offline_profile.dex_references[i].dex_location;
706 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100707 }
708 }
709
Calin Juravle13439f02017-02-21 01:17:21 -0800710 // Walk over the classes and resolve them. If we cannot find a type we return
711 // kInlineCacheMissingTypes.
712 int ic_index = 0;
713 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
714 ObjPtr<mirror::DexCache> dex_cache =
715 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
716 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700717
718 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
719 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
720 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
721 return kInlineCacheNoData;
722 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000723 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000724 class_ref.type_index,
725 dex_cache,
726 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800727 if (clazz != nullptr) {
728 inline_cache->Set(ic_index++, clazz);
729 } else {
730 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
731 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
732 invoke_instruction->GetDexMethodIndex()) << " : "
733 << caller_compilation_unit_
734 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
735 return kInlineCacheMissingTypes;
736 }
737 }
738 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100739}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000740
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000741HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
742 HInstruction* receiver,
743 uint32_t dex_pc) const {
744 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
745 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100746 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000747 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000748 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100749 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000750 field->GetOffset(),
751 field->IsVolatile(),
752 field->GetDexFieldIndex(),
753 field->GetDeclaringClass()->GetDexClassDefIndex(),
754 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000755 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000756 // The class of a field is effectively final, and does not have any memory dependencies.
757 result->SetSideEffects(SideEffects::None());
758 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000759}
760
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000761static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
762 ArtMethod* resolved_method,
763 HInstruction* invoke_instruction,
764 PointerSize pointer_size)
765 REQUIRES_SHARED(Locks::mutator_lock_) {
766 if (Runtime::Current()->IsAotCompiler()) {
767 // We can get unrelated types when working with profiles (corruption,
768 // systme updates, or anyone can write to it). So first check if the class
769 // actually implements the declaring class of the method that is being
770 // called in bytecode.
771 // Note: the lookup methods used below require to have assignable types.
772 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
773 return nullptr;
774 }
775 }
776
777 if (invoke_instruction->IsInvokeInterface()) {
778 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
779 } else {
780 DCHECK(invoke_instruction->IsInvokeVirtual());
781 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
782 }
783 DCHECK(resolved_method != nullptr);
784 return resolved_method;
785}
786
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100787bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
788 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000789 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000790 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
791 << invoke_instruction->DebugName();
792
Andreas Gampea5b09a62016-11-17 15:21:22 -0800793 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000794 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800795 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000796 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000797 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
798 << " from inline cache is not inlined because its class is not"
799 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100800 return false;
801 }
802
803 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700804 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000805 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
806 resolved_method = ResolveMethodFromInlineCache(
807 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
808
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000809 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000810 if (resolved_method == nullptr) {
811 // Bogus AOT profile, bail.
812 DCHECK(Runtime::Current()->IsAotCompiler());
813 return false;
814 }
815
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100816 HInstruction* receiver = invoke_instruction->InputAt(0);
817 HInstruction* cursor = invoke_instruction->GetPrevious();
818 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700819 if (!TryInlineAndReplace(invoke_instruction,
820 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000821 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700822 /* do_rtp */ false,
823 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100824 return false;
825 }
826
827 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000828 AddTypeGuard(receiver,
829 cursor,
830 bb_cursor,
831 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000832 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000833 invoke_instruction,
834 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100835
836 // Run type propagation to get the guard typed, and eventually propagate the
837 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000838 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000839 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000840 outer_compilation_unit_.GetDexCache(),
841 handles_,
842 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100843 rtp_fixup.Run();
844
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000845 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100846 return true;
847}
848
Mingyao Yang063fc772016-08-02 11:02:54 -0700849void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
850 uint32_t dex_pc,
851 HInstruction* cursor,
852 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100853 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
854 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
855 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700856 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100857 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
858 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700859
860 if (cursor != nullptr) {
861 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
862 } else {
863 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
864 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800865 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
866 bb_cursor->InsertInstructionAfter(deopt, compare);
867
868 // Add receiver as input to aid CHA guard optimization later.
869 deopt_flag->AddInput(invoke_instruction->InputAt(0));
870 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700871 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800872 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700873}
874
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000875HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
876 HInstruction* cursor,
877 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800878 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000879 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000880 HInstruction* invoke_instruction,
881 bool with_deoptimization) {
882 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
883 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
884 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000885 if (cursor != nullptr) {
886 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
887 } else {
888 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
889 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000890
891 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700892 bool is_referrer;
893 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
894 if (outermost_art_method == nullptr) {
895 DCHECK(Runtime::Current()->IsAotCompiler());
896 // We are in AOT mode and we don't have an ART method to determine
897 // if the inlined method belongs to the referrer. Assume it doesn't.
898 is_referrer = false;
899 } else {
900 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
901 }
902
Nicolas Geoffray56876342016-12-16 16:09:08 +0000903 // Note that we will just compare the classes, so we don't need Java semantics access checks.
904 // Note that the type index and the dex file are relative to the method this type guard is
905 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100906 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
907 class_index,
908 caller_dex_file,
909 klass,
910 is_referrer,
911 invoke_instruction->GetDexPc(),
912 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000913 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000914 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
915 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
916 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000917 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000918 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000919 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800920 // In AOT mode, we will most likely load the class from BSS, which will involve a call
921 // to the runtime. In this case, the load instruction will need an environment so copy
922 // it from the invoke instruction.
923 if (load_class->NeedsEnvironment()) {
924 DCHECK(Runtime::Current()->IsAotCompiler());
925 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
926 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000927
Vladimir Markoca6fff82017-10-03 14:49:14 +0100928 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000929 bb_cursor->InsertInstructionAfter(compare, load_class);
930 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100931 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
932 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000933 compare,
934 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100935 Runtime::Current()->IsAotCompiler()
936 ? DeoptimizationKind::kAotInlineCache
937 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000938 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000939 bb_cursor->InsertInstructionAfter(deoptimize, compare);
940 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000941 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
942 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
943 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000944 }
945 return compare;
946}
947
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000948bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100949 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000950 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000951 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
952 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000953
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000954 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000955 return true;
956 }
957
958 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700959 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000960
961 bool all_targets_inlined = true;
962 bool one_target_inlined = false;
963 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000964 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000965 break;
966 }
967 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000968
969 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000970 method = ResolveMethodFromInlineCache(
971 handle, resolved_method, invoke_instruction, pointer_size);
972 if (method == nullptr) {
973 DCHECK(Runtime::Current()->IsAotCompiler());
974 // AOT profile is bogus. This loop expects to iterate over all entries,
975 // so just just continue.
976 all_targets_inlined = false;
977 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000978 }
979
980 HInstruction* receiver = invoke_instruction->InputAt(0);
981 HInstruction* cursor = invoke_instruction->GetPrevious();
982 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
983
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000984 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000985 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000986 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800987 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000988 !TryBuildAndInline(invoke_instruction,
989 method,
990 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
991 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000992 all_targets_inlined = false;
993 } else {
994 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000995
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000996 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
997 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000998
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000999 // If we have inlined all targets before, and this receiver is the last seen,
1000 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001001 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1002 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001003 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001004 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001005
Nicolas Geoffray56876342016-12-16 16:09:08 +00001006 HInstruction* compare = AddTypeGuard(receiver,
1007 cursor,
1008 bb_cursor,
1009 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001010 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001011 invoke_instruction,
1012 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001013 if (deoptimize) {
1014 if (return_replacement != nullptr) {
1015 invoke_instruction->ReplaceWith(return_replacement);
1016 }
1017 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1018 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001019 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001020 break;
1021 } else {
1022 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1023 }
1024 }
1025 }
1026
1027 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001028 LOG_FAIL_NO_STAT()
1029 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1030 << " from inline cache is not inlined because none"
1031 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001032 return false;
1033 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001034
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001035 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001036
1037 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001038 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001039 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001040 outer_compilation_unit_.GetDexCache(),
1041 handles_,
1042 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001043 rtp_fixup.Run();
1044 return true;
1045}
1046
1047void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1048 HInstruction* return_replacement,
1049 HInstruction* invoke_instruction) {
1050 uint32_t dex_pc = invoke_instruction->GetDexPc();
1051 HBasicBlock* cursor_block = compare->GetBlock();
1052 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001053 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001054
1055 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1056 // and the returned block is the start of the then branch (that could contain multiple blocks).
1057 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1058
1059 // Split the block containing the invoke before and after the invoke. The returned block
1060 // of the split before will contain the invoke and will be the otherwise branch of
1061 // the diamond. The returned block of the split after will be the merge block
1062 // of the diamond.
1063 HBasicBlock* end_then = invoke_instruction->GetBlock();
1064 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1065 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1066
1067 // If the methods we are inlining return a value, we create a phi in the merge block
1068 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1069 if (return_replacement != nullptr) {
1070 HPhi* phi = new (allocator) HPhi(
1071 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1072 merge->AddPhi(phi);
1073 invoke_instruction->ReplaceWith(phi);
1074 phi->AddInput(return_replacement);
1075 phi->AddInput(invoke_instruction);
1076 }
1077
1078 // Add the control flow instructions.
1079 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1080 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1081 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1082
1083 // Add the newly created blocks to the graph.
1084 graph_->AddBlock(then);
1085 graph_->AddBlock(otherwise);
1086 graph_->AddBlock(merge);
1087
1088 // Set up successor (and implictly predecessor) relations.
1089 cursor_block->AddSuccessor(otherwise);
1090 cursor_block->AddSuccessor(then);
1091 end_then->AddSuccessor(merge);
1092 otherwise->AddSuccessor(merge);
1093
1094 // Set up dominance information.
1095 then->SetDominator(cursor_block);
1096 cursor_block->AddDominatedBlock(then);
1097 otherwise->SetDominator(cursor_block);
1098 cursor_block->AddDominatedBlock(otherwise);
1099 merge->SetDominator(cursor_block);
1100 cursor_block->AddDominatedBlock(merge);
1101
1102 // Update the revert post order.
1103 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1104 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1105 graph_->reverse_post_order_[++index] = then;
1106 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1107 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1108 graph_->reverse_post_order_[++index] = otherwise;
1109 graph_->reverse_post_order_[++index] = merge;
1110
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001111
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001112 graph_->UpdateLoopAndTryInformationOfNewBlock(
1113 then, original_invoke_block, /* replace_if_back_edge */ false);
1114 graph_->UpdateLoopAndTryInformationOfNewBlock(
1115 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1116
1117 // In case the original invoke location was a back edge, we need to update
1118 // the loop to now have the merge block as a back edge.
1119 graph_->UpdateLoopAndTryInformationOfNewBlock(
1120 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001121}
1122
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001123bool HInliner::TryInlinePolymorphicCallToSameTarget(
1124 HInvoke* invoke_instruction,
1125 ArtMethod* resolved_method,
1126 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001127 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001128 if (!Runtime::Current()->UseJitCompilation()) {
1129 return false;
1130 }
1131
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001132 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001133 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001134
1135 DCHECK(resolved_method != nullptr);
1136 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001137 size_t method_index = invoke_instruction->IsInvokeVirtual()
1138 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1139 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1140
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001141 // Check whether we are actually calling the same method among
1142 // the different types seen.
1143 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001144 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001145 break;
1146 }
1147 ArtMethod* new_method = nullptr;
1148 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001149 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001150 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001151 if (new_method->IsRuntimeMethod()) {
1152 // Bail out as soon as we see a conflict trampoline in one of the target's
1153 // interface table.
1154 return false;
1155 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001156 } else {
1157 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001158 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001159 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001160 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001161 if (actual_method == nullptr) {
1162 actual_method = new_method;
1163 } else if (actual_method != new_method) {
1164 // Different methods, bailout.
1165 return false;
1166 }
1167 }
1168
1169 HInstruction* receiver = invoke_instruction->InputAt(0);
1170 HInstruction* cursor = invoke_instruction->GetPrevious();
1171 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1172
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001173 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001174 if (!TryBuildAndInline(invoke_instruction,
1175 actual_method,
1176 ReferenceTypeInfo::CreateInvalid(),
1177 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001178 return false;
1179 }
1180
1181 // We successfully inlined, now add a guard.
1182 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1183 class_linker, receiver, invoke_instruction->GetDexPc());
1184
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001185 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1186 ? DataType::Type::kInt64
1187 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001188 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001189 receiver_class,
1190 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001191 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1192 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001193 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001194 invoke_instruction->GetDexPc());
1195
1196 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001197 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001198 constant = graph_->GetLongConstant(
1199 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1200 } else {
1201 constant = graph_->GetIntConstant(
1202 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1203 }
1204
Vladimir Markoca6fff82017-10-03 14:49:14 +01001205 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001206 if (cursor != nullptr) {
1207 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1208 } else {
1209 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1210 }
1211 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1212 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001213
1214 if (outermost_graph_->IsCompilingOsr()) {
1215 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1216 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001217 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1218 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001219 compare,
1220 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001221 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001222 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001223 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1224 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1225 if (return_replacement != nullptr) {
1226 invoke_instruction->ReplaceWith(return_replacement);
1227 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001228 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001229 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001230 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001231 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001232
1233 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001234 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001235 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001236 outer_compilation_unit_.GetDexCache(),
1237 handles_,
1238 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001239 rtp_fixup.Run();
1240
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001241 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001242
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001243 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001244 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001245}
1246
Mingyao Yang063fc772016-08-02 11:02:54 -07001247bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1248 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001249 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001250 bool do_rtp,
1251 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001252 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001253 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001254 uint32_t dex_pc = invoke_instruction->GetDexPc();
1255 HInstruction* cursor = invoke_instruction->GetPrevious();
1256 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001257 bool should_remove_invoke_instruction = false;
1258
1259 // If invoke_instruction is devirtualized to a different method, give intrinsics
1260 // another chance before we try to inline it.
1261 bool wrong_invoke_type = false;
1262 if (invoke_instruction->GetResolvedMethod() != method &&
1263 IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) {
1264 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1265 if (invoke_instruction->IsInvokeInterface()) {
1266 // We don't intrinsify an invoke-interface directly.
1267 // Replace the invoke-interface with an invoke-virtual.
1268 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1269 graph_->GetAllocator(),
1270 invoke_instruction->GetNumberOfArguments(),
1271 invoke_instruction->GetType(),
1272 invoke_instruction->GetDexPc(),
1273 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1274 method,
1275 method->GetMethodIndex());
1276 HInputsRef inputs = invoke_instruction->GetInputs();
1277 for (size_t index = 0; index != inputs.size(); ++index) {
1278 new_invoke->SetArgumentAt(index, inputs[index]);
1279 }
1280 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1281 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1282 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1283 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1284 }
1285 // Run intrinsic recognizer again to set new_invoke's intrinsic.
1286 IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type);
1287 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
1288 return_replacement = new_invoke;
1289 // invoke_instruction is replaced with new_invoke.
1290 should_remove_invoke_instruction = true;
1291 } else {
1292 // invoke_instruction is intrinsified and stays.
1293 }
1294 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001295 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001296 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001297 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1298 // better than an invoke-interface because:
1299 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1300 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1301 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001302
1303 if (method->IsDefault() && !method->IsCopied()) {
1304 // Changing to invoke-virtual cannot be done on an original default method
1305 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1306 // always uses a method in the iftable which is never an original default
1307 // method.
1308 // On the other hand, inlining an original default method by CHA is fine.
1309 DCHECK(cha_devirtualize);
1310 return false;
1311 }
1312
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001313 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001314 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001315 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001316 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001317 return false;
1318 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001319 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1320 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001321 invoke_instruction->GetNumberOfArguments(),
1322 invoke_instruction->GetType(),
1323 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001324 dex_method_index,
1325 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001326 method->GetMethodIndex());
1327 HInputsRef inputs = invoke_instruction->GetInputs();
1328 for (size_t index = 0; index != inputs.size(); ++index) {
1329 new_invoke->SetArgumentAt(index, inputs[index]);
1330 }
1331 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1332 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001333 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001334 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1335 }
1336 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001337 // invoke_instruction is replaced with new_invoke.
1338 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001339 } else {
1340 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1341 // compiler driver.
1342 return false;
1343 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001344 } else {
1345 // invoke_instruction is inlined.
1346 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001347 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001348
Mingyao Yang063fc772016-08-02 11:02:54 -07001349 if (cha_devirtualize) {
1350 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1351 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001352 if (return_replacement != nullptr) {
1353 invoke_instruction->ReplaceWith(return_replacement);
1354 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001355 if (should_remove_invoke_instruction) {
1356 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1357 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001358 FixUpReturnReferenceType(method, return_replacement);
1359 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1360 // Actual return value has a more specific type than the method's declared
1361 // return type. Run RTP again on the outer graph to propagate it.
1362 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001363 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001364 outer_compilation_unit_.GetDexCache(),
1365 handles_,
1366 /* is_first_run */ false).Run();
1367 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001368 return true;
1369}
1370
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001371size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1372 const HInliner* current = this;
1373 size_t count = 0;
1374 do {
1375 if (current->graph_->GetArtMethod() == method) {
1376 ++count;
1377 }
1378 current = current->parent_;
1379 } while (current != nullptr);
1380 return count;
1381}
1382
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001383bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1384 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001385 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001386 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001387 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001388 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001389 << "Method " << method->PrettyMethod()
1390 << " is not inlined because of unimplemented inline support for proxy methods.";
1391 return false;
1392 }
1393
1394 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001395 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001396 << "Method "
1397 << method->PrettyMethod()
1398 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001399 return false;
1400 }
1401
Jeff Haodcdc85b2015-12-04 14:06:18 -08001402 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1403 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1404 if (!compiler_driver_->MayInline(method->GetDexFile(),
1405 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001406 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001407 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1408 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001409 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001410 return true;
1411 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001412 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001413 << "Won't inline " << method->PrettyMethod() << " in "
1414 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1415 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1416 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001417 return false;
1418 }
1419
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001420 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1421
David Sehr0225f8e2018-01-31 08:52:24 +00001422 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001423
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001424 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001425 LOG_FAIL_NO_STAT()
1426 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001427 return false;
1428 }
1429
Calin Juravleec748352015-07-29 13:52:12 +01001430 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001431 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001432 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001433 << "Method " << method->PrettyMethod()
1434 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001435 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001436 << " > "
1437 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001438 return false;
1439 }
1440
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001441 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001442 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001443 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001444 return false;
1445 }
1446
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001447 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001448 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001449 << "Method " << method->PrettyMethod()
1450 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001451 }
1452
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001453 if (!method->GetDeclaringClass()->IsVerified()) {
1454 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +01001455 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001456 !compiler_driver_->IsMethodVerifiedWithoutFailures(
1457 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001458 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001459 << "Method " << method->PrettyMethod()
1460 << " couldn't be verified, so it cannot be inlined";
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001461 return false;
1462 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001463 }
1464
Roland Levillain4c0eb422015-04-24 16:43:49 +01001465 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1466 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1467 // Case of a static method that cannot be inlined because it implicitly
1468 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001469 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1470 << "Method " << method->PrettyMethod()
1471 << " is not inlined because it is static and requires a clinit"
1472 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001473 return false;
1474 }
1475
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001476 if (!TryBuildAndInlineHelper(
1477 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001478 return false;
1479 }
1480
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001481 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001482 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001483 return true;
1484}
1485
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001486static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1487 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001488 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001489 size_t input_index = 0;
1490 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1491 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001492 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001493 ++i;
1494 DCHECK_NE(i, arg_vreg_index);
1495 }
1496 }
1497 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1498 return invoke_instruction->InputAt(input_index);
1499}
1500
1501// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1502bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1503 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001504 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001505 InlineMethod inline_method;
1506 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1507 return false;
1508 }
1509
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001510 switch (inline_method.opcode) {
1511 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001512 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001513 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001514 break;
1515 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001516 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1517 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001518 break;
1519 case kInlineOpNonWideConst:
1520 if (resolved_method->GetShorty()[0] == 'L') {
1521 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001522 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001523 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001524 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001525 }
1526 break;
1527 case kInlineOpIGet: {
1528 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1529 if (data.method_is_static || data.object_arg != 0u) {
1530 // TODO: Needs null check.
1531 return false;
1532 }
1533 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001534 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001535 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1536 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1537 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001538 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001539 break;
1540 }
1541 case kInlineOpIPut: {
1542 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1543 if (data.method_is_static || data.object_arg != 0u) {
1544 // TODO: Needs null check.
1545 return false;
1546 }
1547 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1548 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001549 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001550 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1551 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1552 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1553 if (data.return_arg_plus1 != 0u) {
1554 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001555 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001556 }
1557 break;
1558 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001559 case kInlineOpConstructor: {
1560 const InlineConstructorData& data = inline_method.d.constructor_data;
1561 // Get the indexes to arrays for easier processing.
1562 uint16_t iput_field_indexes[] = {
1563 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1564 };
1565 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1566 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1567 // Count valid field indexes.
1568 size_t number_of_iputs = 0u;
1569 while (number_of_iputs != arraysize(iput_field_indexes) &&
1570 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1571 // Check that there are no duplicate valid field indexes.
1572 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1573 iput_field_indexes + arraysize(iput_field_indexes),
1574 iput_field_indexes[number_of_iputs]));
1575 ++number_of_iputs;
1576 }
1577 // Check that there are no valid field indexes in the rest of the array.
1578 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1579 iput_field_indexes + arraysize(iput_field_indexes),
1580 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1581
1582 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001583 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1584 bool needs_constructor_barrier = false;
1585 for (size_t i = 0; i != number_of_iputs; ++i) {
1586 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001587 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001588 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001589 bool is_final;
1590 HInstanceFieldSet* iput =
1591 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001592 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1593
1594 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001595 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001596 needs_constructor_barrier = true;
1597 }
1598 }
1599 }
1600 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001601 // See CompilerDriver::RequiresConstructorBarrier for more details.
1602 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1603
1604 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001605 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001606 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1607 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001608 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001609 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001610 break;
1611 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001612 default:
1613 LOG(FATAL) << "UNREACHABLE";
1614 UNREACHABLE();
1615 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001616 return true;
1617}
1618
Vladimir Markof44d36c2017-03-14 14:18:46 +00001619HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1620 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001621 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001622 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001623 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1624 ArtField* resolved_field =
1625 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001626 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001627 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001628 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001629 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001630 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001631 resolved_field->GetOffset(),
1632 resolved_field->IsVolatile(),
1633 field_index,
1634 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001635 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001636 // Read barrier generates a runtime call in slow path and we need a valid
1637 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1638 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001639 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001640 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001641 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001642 ReferenceTypePropagation rtp(graph_,
1643 outer_compilation_unit_.GetClassLoader(),
1644 dex_cache,
1645 handles_,
1646 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001647 rtp.Visit(iget);
1648 }
1649 return iget;
1650}
1651
Vladimir Markof44d36c2017-03-14 14:18:46 +00001652HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1653 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001654 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001655 HInstruction* value,
1656 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001657 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001658 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1659 ArtField* resolved_field =
1660 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001661 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001662 if (is_final != nullptr) {
1663 // This information is needed only for constructors.
1664 DCHECK(referrer->IsConstructor());
1665 *is_final = resolved_field->IsFinal();
1666 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001667 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001668 obj,
1669 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001670 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001671 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001672 resolved_field->GetOffset(),
1673 resolved_field->IsVolatile(),
1674 field_index,
1675 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001676 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001677 // Read barrier generates a runtime call in slow path and we need a valid
1678 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1679 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001680 return iput;
1681}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001682
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001683template <typename T>
1684static inline Handle<T> NewHandleIfDifferent(T* object,
1685 Handle<T> hint,
1686 VariableSizedHandleScope* handles)
1687 REQUIRES_SHARED(Locks::mutator_lock_) {
1688 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1689}
1690
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001691bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1692 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001693 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001694 bool same_dex_file,
1695 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001696 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001697 ScopedObjectAccess soa(Thread::Current());
1698 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001699 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1700 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001701 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001702 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001703 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1704 caller_compilation_unit_.GetDexCache(),
1705 handles_);
1706 Handle<mirror::ClassLoader> class_loader =
1707 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1708 caller_compilation_unit_.GetClassLoader(),
1709 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001710
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001711 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001712 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001713 class_linker,
1714 callee_dex_file,
1715 code_item,
1716 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1717 method_index,
1718 resolved_method->GetAccessFlags(),
1719 /* verified_method */ nullptr,
1720 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001721
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001722 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001723 if (invoke_type == kInterface) {
1724 // We have statically resolved the dispatch. To please the class linker
1725 // at runtime, we change this call as if it was a virtual call.
1726 invoke_type = kVirtual;
1727 }
David Brazdil3f523062016-02-29 16:53:33 +00001728
1729 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001730 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1731 graph_->GetAllocator(),
1732 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001733 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001734 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001735 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001736 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001737 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001738 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001739 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001740 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001741
Vladimir Marko438709f2017-02-23 18:56:13 +00001742 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001743 // of on the stack, as Clang might produce a stack frame too large
1744 // for this function, that would not fit the requirements of the
1745 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001746 if (stats_ != nullptr) {
1747 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1748 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001749 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001750 inline_stats_ = new (storage) OptimizingCompilerStats;
1751 } else {
1752 inline_stats_->Reset();
1753 }
1754 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001755 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001756 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001757 &dex_compilation_unit,
1758 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001759 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001760 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001761 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001762 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001763 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001764
David Brazdildee58d62016-04-07 09:54:26 +00001765 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001766 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001767 << "Method " << callee_dex_file.PrettyMethod(method_index)
1768 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001769 return false;
1770 }
1771
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001772 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1773 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001774 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001775 << "Method " << callee_dex_file.PrettyMethod(method_index)
1776 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001777 return false;
1778 }
1779
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001780 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001781 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001782 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1783 !instructions.Done();
1784 instructions.Advance()) {
1785 HInstruction* current = instructions.Current();
1786 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001787 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001788 if (argument->IsNullConstant()) {
1789 current->ReplaceWith(callee_graph->GetNullConstant());
1790 } else if (argument->IsIntConstant()) {
1791 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1792 } else if (argument->IsLongConstant()) {
1793 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1794 } else if (argument->IsFloatConstant()) {
1795 current->ReplaceWith(
1796 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1797 } else if (argument->IsDoubleConstant()) {
1798 current->ReplaceWith(
1799 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001800 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001801 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1802 run_rtp = true;
1803 current->SetReferenceTypeInfo(receiver_type);
1804 } else {
1805 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1806 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001807 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1808 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001809 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001810 }
1811 }
1812
David Brazdil94ab38f2016-06-21 17:48:19 +01001813 // We have replaced formal arguments with actual arguments. If actual types
1814 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001815 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001816 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001817 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001818 dex_compilation_unit.GetDexCache(),
1819 handles_,
1820 /* is_first_run */ false).Run();
1821 }
1822
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001823 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001824
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001825 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1826 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001827 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001828 << "Method " << callee_dex_file.PrettyMethod(method_index)
1829 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001830 return false;
1831 }
1832
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001833 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001834 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1835 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001836 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1837 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001838 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001839 << "Method " << callee_dex_file.PrettyMethod(method_index)
1840 << " could not be inlined because one branch always throws and"
1841 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001842 return false;
1843 } else if (graph_->GetExitBlock() == nullptr) {
1844 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001845 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001846 << "Method " << callee_dex_file.PrettyMethod(method_index)
1847 << " could not be inlined because one branch always throws and"
1848 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001849 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001850 } else if (graph_->HasIrreducibleLoops()) {
1851 // TODO(ngeoffray): Support re-computing loop information to graphs with
1852 // irreducible loops?
1853 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1854 << " could not be inlined because one branch always throws and"
1855 << " caller has irreducible loops";
1856 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001857 }
1858 } else {
1859 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001860 }
1861 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001862
1863 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001864 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001865 << "Method " << callee_dex_file.PrettyMethod(method_index)
1866 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001867 return false;
1868 }
1869
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001870 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001871 // Skip the entry block, it does not contain instructions that prevent inlining.
1872 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001873 if (block->IsLoopHeader()) {
1874 if (block->GetLoopInformation()->IsIrreducible()) {
1875 // Don't inline methods with irreducible loops, they could prevent some
1876 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001877 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001878 << "Method " << callee_dex_file.PrettyMethod(method_index)
1879 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001880 return false;
1881 }
1882 if (!block->GetLoopInformation()->HasExitEdge()) {
1883 // Don't inline methods with loops without exit, since they cause the
1884 // loop information to be computed incorrectly when updating after
1885 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001886 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001887 << "Method " << callee_dex_file.PrettyMethod(method_index)
1888 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001889 return false;
1890 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001891 }
1892
1893 for (HInstructionIterator instr_it(block->GetInstructions());
1894 !instr_it.Done();
1895 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001896 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001897 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001898 << "Method " << callee_dex_file.PrettyMethod(method_index)
1899 << " is not inlined because the outer method has reached"
1900 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001901 return false;
1902 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001903 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001904 if (current->NeedsEnvironment() &&
1905 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001906 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001907 << "Method " << callee_dex_file.PrettyMethod(method_index)
1908 << " is not inlined because its caller has reached"
1909 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001910 return false;
1911 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001912
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001913 if (current->NeedsEnvironment() &&
1914 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1915 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001916 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001917 << "Method " << callee_dex_file.PrettyMethod(method_index)
1918 << " could not be inlined because " << current->DebugName()
1919 << " needs an environment, is in a different dex file"
1920 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001921 return false;
1922 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001923
Vladimir Markodc151b22015-10-15 18:02:30 +01001924 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001925 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001926 << "Method " << callee_dex_file.PrettyMethod(method_index)
1927 << " could not be inlined because " << current->DebugName()
1928 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001929 return false;
1930 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001931
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001932 if (current->IsUnresolvedStaticFieldGet() ||
1933 current->IsUnresolvedInstanceFieldGet() ||
1934 current->IsUnresolvedStaticFieldSet() ||
1935 current->IsUnresolvedInstanceFieldSet()) {
1936 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001937 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001938 << "Method " << callee_dex_file.PrettyMethod(method_index)
1939 << " could not be inlined because it is using an unresolved"
1940 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001941 return false;
1942 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001943 }
1944 }
David Brazdil3f523062016-02-29 16:53:33 +00001945 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1946 << "No instructions can be added to the outer graph while inner graph is being built";
1947
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001948 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001949 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1950 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001951 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001952 // Update our budget for other inlining attempts in `caller_graph`.
1953 total_number_of_instructions_ += number_of_instructions;
1954 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001955
1956 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1957 << "No instructions can be added to the inner graph during inlining into the outer graph";
1958
Vladimir Marko438709f2017-02-23 18:56:13 +00001959 if (stats_ != nullptr) {
1960 DCHECK(inline_stats_ != nullptr);
1961 inline_stats_->AddTo(stats_);
1962 }
1963
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001964 return true;
1965}
Calin Juravle2e768302015-07-28 14:41:11 +00001966
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001967void HInliner::RunOptimizations(HGraph* callee_graph,
1968 const DexFile::CodeItem* code_item,
1969 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001970 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1971 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00001972 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08001973 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Marko28e012a2017-12-07 11:22:59 +00001974 HSharpening sharpening(callee_graph, codegen_, compiler_driver_);
Vladimir Marko65979462017-05-19 17:25:12 +01001975 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00001976 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001977
1978 HOptimization* optimizations[] = {
1979 &intrinsics,
1980 &sharpening,
1981 &simplify,
1982 &fold,
1983 &dce,
1984 };
1985
1986 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1987 HOptimization* optimization = optimizations[i];
1988 optimization->Run();
1989 }
1990
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001991 // Bail early for pathological cases on the environment (for example recursive calls,
1992 // or too large environment).
1993 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
1994 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
1995 << " will not be inlined because the outer method has reached"
1996 << " its environment budget limit.";
1997 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001998 }
1999
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002000 // Bail early if we know we already are over the limit.
2001 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2002 if (number_of_instructions > inlining_budget_) {
2003 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2004 << " will not be inlined because the outer method has reached"
2005 << " its instruction budget limit. " << number_of_instructions;
2006 return;
2007 }
2008
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002009 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002010 HInliner inliner(callee_graph,
2011 outermost_graph_,
2012 codegen_,
2013 outer_compilation_unit_,
2014 dex_compilation_unit,
2015 compiler_driver_,
2016 handles_,
2017 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002018 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002019 total_number_of_instructions_ + number_of_instructions,
2020 this,
2021 depth_ + 1);
2022 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002023}
2024
David Brazdil94ab38f2016-06-21 17:48:19 +01002025static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2026 bool declared_can_be_null,
2027 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002028 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002029 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2030 return true;
2031 }
2032
2033 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2034 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002035 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002036}
2037
Vladimir Markob45528c2017-07-27 14:14:28 +01002038ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002039 return ReferenceTypePropagation::IsAdmissible(klass)
2040 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2041 : graph_->GetInexactObjectRti();
2042}
2043
2044bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2045 // If this is an instance call, test whether the type of the `this` argument
2046 // is more specific than the class which declares the method.
2047 if (!resolved_method->IsStatic()) {
2048 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
2049 /* declared_can_be_null */ false,
2050 invoke_instruction->InputAt(0u))) {
2051 return true;
2052 }
2053 }
2054
David Brazdil94ab38f2016-06-21 17:48:19 +01002055 // Iterate over the list of parameter types and test whether any of the
2056 // actual inputs has a more specific reference type than the type declared in
2057 // the signature.
2058 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
2059 for (size_t param_idx = 0,
2060 input_idx = resolved_method->IsStatic() ? 0 : 1,
2061 e = (param_list == nullptr ? 0 : param_list->Size());
2062 param_idx < e;
2063 ++param_idx, ++input_idx) {
2064 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002065 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002066 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2067 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002068 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
2069 /* declared_can_be_null */ true,
2070 input)) {
2071 return true;
2072 }
2073 }
2074 }
2075
2076 return false;
2077}
2078
2079bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2080 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002081 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002082 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002083 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002084 // Test if the return type is a refinement of the declared return type.
2085 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2086 /* declared_can_be_null */ true,
2087 return_replacement)) {
2088 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002089 } else if (return_replacement->IsInstanceFieldGet()) {
2090 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
2091 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2092 if (field_get->GetFieldInfo().GetField() ==
2093 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
2094 return true;
2095 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002096 }
2097 } else if (return_replacement->IsInstanceOf()) {
2098 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2099 return true;
2100 }
2101 }
2102
2103 return false;
2104}
2105
2106void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2107 HInstruction* return_replacement) {
2108 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002109 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002110 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2111 // Make sure that we have a valid type for the return. We may get an invalid one when
2112 // we inline invokes with multiple branches and create a Phi for the result.
2113 // TODO: we could be more precise by merging the phi inputs but that requires
2114 // some functionality from the reference type propagation.
2115 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002116 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002117 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002118 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002119 }
Calin Juravle2e768302015-07-28 14:41:11 +00002120 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002121}
2122
2123} // namespace art