blob: 8b10a78212e8ff130be50e763aff34e22c5af485 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010024#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070026#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000027#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070028#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010030#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "driver/dex_compilation_unit.h"
32#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010033#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000034#include "jit/jit.h"
35#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "mirror/class_loader.h"
37#include "mirror/dex_cache.h"
38#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010039#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010040#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070041#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070042#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010043#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000044#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "thread.h"
47
48namespace art {
49
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000050// Instruction limit to control memory.
51static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
52
53// Maximum number of instructions for considering a method small,
54// which we will always try to inline if the other non-instruction limits
55// are not reached.
56static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000057
58// Limit the number of dex registers that we accumulate while inlining
59// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010060static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000062// Limit recursive call inlining, which do not benefit from too
63// much inlining compared to code locality.
64static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070065
Calin Juravlee2492d42017-03-20 11:42:13 -070066// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070067static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070068
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000069// We check for line numbers to make sure the DepthString implementation
70// aligns the output nicely.
71#define LOG_INTERNAL(msg) \
72 static_assert(__LINE__ > 10, "Unhandled line number"); \
73 static_assert(__LINE__ < 10000, "Unhandled line number"); \
74 VLOG(compiler) << DepthString(__LINE__) << msg
75
76#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
77#define LOG_NOTE() LOG_INTERNAL("Note: ")
78#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070079#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000080#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
81
82std::string HInliner::DepthString(int line) const {
83 std::string value;
84 // Indent according to the inlining depth.
85 size_t count = depth_;
86 // Line numbers get printed in the log, so add a space if the log's line is less
87 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
88 if (!kIsTargetBuild) {
89 if (line < 100) {
90 value += " ";
91 }
92 if (line < 1000) {
93 value += " ";
94 }
95 // Safeguard if this file reaches more than 10000 lines.
96 DCHECK_LT(line, 10000);
97 }
98 for (size_t i = 0; i < count; ++i) {
99 value += " ";
100 }
101 return value;
102}
103
104static size_t CountNumberOfInstructions(HGraph* graph) {
105 size_t number_of_instructions = 0;
106 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
107 for (HInstructionIterator instr_it(block->GetInstructions());
108 !instr_it.Done();
109 instr_it.Advance()) {
110 ++number_of_instructions;
111 }
112 }
113 return number_of_instructions;
114}
115
116void HInliner::UpdateInliningBudget() {
117 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
118 // Always try to inline small methods.
119 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
120 } else {
121 inlining_budget_ = std::max(
122 kMaximumNumberOfInstructionsForSmallMethod,
123 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
124 }
125}
126
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000127void HInliner::Run() {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000128 if (graph_->IsDebuggable()) {
129 // For simplicity, we currently never inline when the graph is debuggable. This avoids
130 // doing some logic in the runtime to discover if a method could have been inlined.
131 return;
132 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000133
134 // Initialize the number of instructions for the method being compiled. Recursive calls
135 // to HInliner::Run have already updated the instruction count.
136 if (outermost_graph_ == graph_) {
137 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
138 }
139
140 UpdateInliningBudget();
141 DCHECK_NE(total_number_of_instructions_, 0u);
142 DCHECK_NE(inlining_budget_, 0u);
143
Roland Levillain6c3af162017-04-27 11:18:56 +0100144 // If we're compiling with a core image (which is only used for
145 // test purposes), honor inlining directives in method names:
146 // - if a method's name contains the substring "$inline$", ensure
147 // that this method is actually inlined;
148 // - if a method's name contains the substring "$noinline$", do not
149 // inline that method.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000150 // We limit the latter to AOT compilation, as the JIT may or may not inline
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100151 // depending on the state of classes at runtime.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000152 const bool honor_noinline_directives = IsCompilingWithCoreImage();
153 const bool honor_inline_directives =
154 honor_noinline_directives && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100155
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000156 // Keep a copy of all blocks when starting the visit.
157 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100158 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000159 // Because we are changing the graph when inlining,
160 // we just iterate over the blocks of the outer method.
161 // This avoids doing the inlining work again on the inlined blocks.
162 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000163 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
164 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100165 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700166 // As long as the call is not intrinsified, it is worth trying to inline.
167 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000168 if (honor_noinline_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000169 // Debugging case: directives in method names control or assert on inlining.
170 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
171 call->GetDexMethodIndex(), /* with_signature */ false);
172 // Tests prevent inlining by having $noinline$ in their method names.
173 if (callee_name.find("$noinline$") == std::string::npos) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000174 if (!TryInline(call) && honor_inline_directives) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000175 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
176 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000177 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000178 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100179 } else {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000180 DCHECK(!honor_inline_directives);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000181 // Normal case: try to inline.
182 TryInline(call);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000183 }
184 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000185 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000186 }
187 }
188}
189
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100190static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700191 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100192 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
193}
194
195/**
196 * Given the `resolved_method` looked up in the dex cache, try to find
197 * the actual runtime target of an interface or virtual call.
198 * Return nullptr if the runtime target cannot be proven.
199 */
200static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700201 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100202 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
203 // No need to lookup further, the resolved method will be the target.
204 return resolved_method;
205 }
206
207 HInstruction* receiver = invoke->InputAt(0);
208 if (receiver->IsNullCheck()) {
209 // Due to multiple levels of inlining within the same pass, it might be that
210 // null check does not have the reference type of the actual receiver.
211 receiver = receiver->InputAt(0);
212 }
213 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000214 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
215 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100216 // We currently only support inlining with known receivers.
217 // TODO: Remove this check, we should be able to inline final methods
218 // on unknown receivers.
219 return nullptr;
220 } else if (info.GetTypeHandle()->IsInterface()) {
221 // Statically knowing that the receiver has an interface type cannot
222 // help us find what is the target method.
223 return nullptr;
224 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
225 // The method that we're trying to call is not in the receiver's class or super classes.
226 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000227 } else if (info.GetTypeHandle()->IsErroneous()) {
228 // If the type is erroneous, do not go further, as we are going to query the vtable or
229 // imt table, that we can only safely do on non-erroneous classes.
230 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100231 }
232
233 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700234 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100235 if (invoke->IsInvokeInterface()) {
236 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
237 resolved_method, pointer_size);
238 } else {
239 DCHECK(invoke->IsInvokeVirtual());
240 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
241 resolved_method, pointer_size);
242 }
243
244 if (resolved_method == nullptr) {
245 // The information we had on the receiver was not enough to find
246 // the target method. Since we check above the exact type of the receiver,
247 // the only reason this can happen is an IncompatibleClassChangeError.
248 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700249 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100250 // The information we had on the receiver was not enough to find
251 // the target method. Since we check above the exact type of the receiver,
252 // the only reason this can happen is an IncompatibleClassChangeError.
253 return nullptr;
254 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
255 // A final method has to be the target method.
256 return resolved_method;
257 } else if (info.IsExact()) {
258 // If we found a method and the receiver's concrete type is statically
259 // known, we know for sure the target.
260 return resolved_method;
261 } else {
262 // Even if we did find a method, the receiver type was not enough to
263 // statically find the runtime target.
264 return nullptr;
265 }
266}
267
268static uint32_t FindMethodIndexIn(ArtMethod* method,
269 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000270 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700271 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100272 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100273 return method->GetDexMethodIndex();
274 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000275 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100276 }
277}
278
Andreas Gampea5b09a62016-11-17 15:21:22 -0800279static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000280 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700281 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000282 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800283 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100284 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700285 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000286 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800287 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700288 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100289 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100290 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000291 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000292 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100293 } else {
294 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100296 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000297 // the right class already resolved with the class loader.
298 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000299 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000300 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
301 if (resolved != cls) {
302 index = dex::TypeIndex::Invalid();
303 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100304 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100305 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000306
307 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100308}
309
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000310class ScopedProfilingInfoInlineUse {
311 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000312 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
313 : method_(method),
314 self_(self),
315 // Fetch the profiling info ahead of using it. If it's null when fetching,
316 // we should not call JitCodeCache::DoneInlining.
317 profiling_info_(
318 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000319 }
320
321 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000322 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700323 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000324 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
325 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
326 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000327 }
328
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000329 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
330
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000331 private:
332 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000333 Thread* const self_;
334 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000335};
336
Calin Juravle13439f02017-02-21 01:17:21 -0800337HInliner::InlineCacheType HInliner::GetInlineCacheType(
338 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
339 REQUIRES_SHARED(Locks::mutator_lock_) {
340 uint8_t number_of_types = 0;
341 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
342 if (classes->Get(number_of_types) == nullptr) {
343 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000344 }
345 }
Calin Juravle13439f02017-02-21 01:17:21 -0800346
347 if (number_of_types == 0) {
348 return kInlineCacheUninitialized;
349 } else if (number_of_types == 1) {
350 return kInlineCacheMonomorphic;
351 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
352 return kInlineCacheMegamorphic;
353 } else {
354 return kInlineCachePolymorphic;
355 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000356}
357
358static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
359 REQUIRES_SHARED(Locks::mutator_lock_) {
360 DCHECK(classes->Get(0) != nullptr);
361 return classes->Get(0);
362}
363
Mingyao Yang063fc772016-08-02 11:02:54 -0700364ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
365 if (!resolved_method->HasSingleImplementation()) {
366 return nullptr;
367 }
368 if (Runtime::Current()->IsAotCompiler()) {
369 // No CHA-based devirtulization for AOT compiler (yet).
370 return nullptr;
371 }
372 if (outermost_graph_->IsCompilingOsr()) {
373 // We do not support HDeoptimize in OSR methods.
374 return nullptr;
375 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800376 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000377 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
378 if (single_impl == nullptr) {
379 return nullptr;
380 }
381 if (single_impl->IsProxyMethod()) {
382 // Proxy method is a generic invoker that's not worth
383 // devirtualizing/inlining. It also causes issues when the proxy
384 // method is in another dex file if we try to rewrite invoke-interface to
385 // invoke-virtual because a proxy method doesn't have a real dex file.
386 return nullptr;
387 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100388 if (!single_impl->GetDeclaringClass()->IsResolved()) {
389 // There's a race with the class loading, which updates the CHA info
390 // before setting the class to resolved. So we just bail for this
391 // rare occurence.
392 return nullptr;
393 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000394 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700395}
396
Aart Bik2c148f02018-02-02 14:30:35 -0800397static bool IsMethodUnverified(CompilerDriver* const compiler_driver, ArtMethod* method)
David Sehr0225f8e2018-01-31 08:52:24 +0000398 REQUIRES_SHARED(Locks::mutator_lock_) {
Aart Bik2c148f02018-02-02 14:30:35 -0800399 if (!method->GetDeclaringClass()->IsVerified()) {
400 if (Runtime::Current()->UseJitCompilation()) {
401 // We're at runtime, we know this is cold code if the class
402 // is not verified, so don't bother analyzing.
403 return true;
404 }
405 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
406 if (!compiler_driver->IsMethodVerifiedWithoutFailures(
407 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
408 // Method has soft or hard failures, don't analyze.
409 return true;
410 }
411 }
412 return false;
413}
414
415static bool AlwaysThrows(CompilerDriver* const compiler_driver, ArtMethod* method)
416 REQUIRES_SHARED(Locks::mutator_lock_) {
417 DCHECK(method != nullptr);
418 // Skip non-compilable and unverified methods.
419 if (!method->IsCompilable() || IsMethodUnverified(compiler_driver, method)) {
420 return false;
421 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800422 // Skip native methods, methods with try blocks, and methods that are too large.
Aart Bik2c148f02018-02-02 14:30:35 -0800423 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800424 if (!accessor.HasCodeItem() ||
425 accessor.TriesSize() != 0 ||
426 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
427 return false;
428 }
429 // Scan for exits.
430 bool throw_seen = false;
431 for (const DexInstructionPcPair& pair : accessor) {
432 switch (pair.Inst().Opcode()) {
433 case Instruction::RETURN:
434 case Instruction::RETURN_VOID:
435 case Instruction::RETURN_WIDE:
436 case Instruction::RETURN_OBJECT:
437 case Instruction::RETURN_VOID_NO_BARRIER:
438 return false; // found regular control flow back
439 case Instruction::THROW:
440 throw_seen = true;
441 break;
442 default:
443 break;
444 }
445 }
446 return throw_seen;
447}
448
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700449bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000450 if (invoke_instruction->IsInvokeUnresolved() ||
451 invoke_instruction->IsInvokePolymorphic()) {
452 return false; // Don't bother to move further if we know the method is unresolved or an
453 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100454 }
455
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000456 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100457 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000458 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000459 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000460
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100461 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100462 if (resolved_method == nullptr) {
463 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
464 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000465 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100466 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000467 }
468 ArtMethod* actual_method = nullptr;
469
470 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800471 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000472 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100473 // Check if we can statically find the method.
474 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000475 }
476
Mingyao Yang063fc772016-08-02 11:02:54 -0700477 bool cha_devirtualize = false;
478 if (actual_method == nullptr) {
479 ArtMethod* method = TryCHADevirtualization(resolved_method);
480 if (method != nullptr) {
481 cha_devirtualize = true;
482 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000483 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700484 }
485 }
486
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100487 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800488 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700489 bool result = TryInlineAndReplace(invoke_instruction,
490 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000491 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700492 /* do_rtp */ true,
493 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800494 if (result) {
495 // Successfully inlined.
496 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
497 if (cha_devirtualize) {
498 // Add dependency due to devirtualization. We've assumed resolved_method
499 // has single implementation.
500 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
501 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
502 } else {
503 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
504 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700505 }
Aart Bik2c148f02018-02-02 14:30:35 -0800506 } else if (!cha_devirtualize && AlwaysThrows(compiler_driver_, actual_method)) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800507 // Set always throws property for non-inlined method call with single target
508 // (unless it was obtained through CHA, because that would imply we have
509 // to add the CHA dependency, which seems not worth it).
510 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000511 }
512 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100513 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800514 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100515
Calin Juravle13439f02017-02-21 01:17:21 -0800516 // Try using inline caches.
517 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
518}
519
520static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
521 const DexCompilationUnit& compilation_unit,
522 StackHandleScope<1>* hs)
523 REQUIRES_SHARED(Locks::mutator_lock_) {
524 Thread* self = Thread::Current();
525 ClassLinker* class_linker = compilation_unit.GetClassLinker();
526 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
527 mirror::ObjectArray<mirror::Class>::Alloc(
528 self,
529 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
530 InlineCache::kIndividualCacheSize));
531 if (inline_cache == nullptr) {
532 // We got an OOME. Just clear the exception, and don't inline.
533 DCHECK(self->IsExceptionPending());
534 self->ClearException();
535 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
536 }
537 return inline_cache;
538}
539
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700540bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
541 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
542 // do not generate a deopt.
543 //
544 // For AOT:
545 // Generating a deopt does not ensure that we will actually capture the new types;
546 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
547 // Take for example the following scenario:
548 // - we capture the inline cache in one run
549 // - the next run, we deoptimize because we miss a type check, but the method
550 // never becomes hot again
551 // In this case, the inline cache will not be updated in the profile and the AOT code
552 // will keep deoptimizing.
553 // Another scenario is if we use profile compilation for a process which is not allowed
554 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
555 // rest of the lifetime.
556 // TODO(calin):
557 // This is a compromise because we will most likely never update the inline cache
558 // in the profile (unless there's another reason to deopt). So we might be stuck with
559 // a sub-optimal inline cache.
560 // We could be smarter when capturing inline caches to mitigate this.
561 // (e.g. by having different thresholds for new and old methods).
562 //
563 // For OSR:
564 // We may come from the interpreter and it may have seen different receiver types.
565 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
566}
Calin Juravle13439f02017-02-21 01:17:21 -0800567bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
568 HInvoke* invoke_instruction,
569 ArtMethod* resolved_method)
570 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700571 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
572 return false;
573 }
574
Calin Juravle13439f02017-02-21 01:17:21 -0800575 StackHandleScope<1> hs(Thread::Current());
576 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
577 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
578 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
579 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
580
581 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000582 case kInlineCacheNoData: {
583 LOG_FAIL_NO_STAT()
584 << "Interface or virtual call to "
585 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
586 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800587 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000588 }
Calin Juravle13439f02017-02-21 01:17:21 -0800589
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000590 case kInlineCacheUninitialized: {
591 LOG_FAIL_NO_STAT()
592 << "Interface or virtual call to "
593 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
594 << " is not hit and not inlined";
595 return false;
596 }
597
598 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000599 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700600 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800601 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000602 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800603 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000604 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000605 }
Calin Juravle13439f02017-02-21 01:17:21 -0800606
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000607 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000608 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800609 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000610 }
Calin Juravle13439f02017-02-21 01:17:21 -0800611
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000612 case kInlineCacheMegamorphic: {
613 LOG_FAIL_NO_STAT()
614 << "Interface or virtual call to "
615 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
616 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000617 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800618 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000619 }
Calin Juravle13439f02017-02-21 01:17:21 -0800620
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000621 case kInlineCacheMissingTypes: {
622 LOG_FAIL_NO_STAT()
623 << "Interface or virtual call to "
624 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
625 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800626 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000627 }
Calin Juravle13439f02017-02-21 01:17:21 -0800628 }
629 UNREACHABLE();
630}
631
632HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
633 HInvoke* invoke_instruction,
634 StackHandleScope<1>* hs,
635 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
636 REQUIRES_SHARED(Locks::mutator_lock_) {
637 DCHECK(Runtime::Current()->UseJitCompilation());
638
639 ArtMethod* caller = graph_->GetArtMethod();
640 // Under JIT, we should always know the caller.
641 DCHECK(caller != nullptr);
642 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
643 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
644
645 if (profiling_info == nullptr) {
646 return kInlineCacheNoData;
647 }
648
649 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
650 if (inline_cache->Get() == nullptr) {
651 // We can't extract any data if we failed to allocate;
652 return kInlineCacheNoData;
653 } else {
654 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
655 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
656 *inline_cache);
657 return GetInlineCacheType(*inline_cache);
658 }
659}
660
661HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
662 const DexFile& caller_dex_file,
663 HInvoke* invoke_instruction,
664 StackHandleScope<1>* hs,
665 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
666 REQUIRES_SHARED(Locks::mutator_lock_) {
667 DCHECK(Runtime::Current()->IsAotCompiler());
668 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
669 if (pci == nullptr) {
670 return kInlineCacheNoData;
671 }
672
Calin Juravlecc3171a2017-05-19 16:47:53 -0700673 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
674 pci->GetMethod(caller_dex_file.GetLocation(),
675 caller_dex_file.GetLocationChecksum(),
676 caller_compilation_unit_.GetDexMethodIndex());
677 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800678 return kInlineCacheNoData; // no profile information for this invocation.
679 }
680
681 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
682 if (inline_cache == nullptr) {
683 // We can't extract any data if we failed to allocate;
684 return kInlineCacheNoData;
685 } else {
686 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700687 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800688 *inline_cache);
689 }
690}
691
692HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
693 const HInvoke* invoke_instruction,
694 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
695 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
696 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700697 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
698 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800699 return kInlineCacheUninitialized;
700 }
701
702 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
703
704 if (dex_pc_data.is_missing_types) {
705 return kInlineCacheMissingTypes;
706 }
707 if (dex_pc_data.is_megamorphic) {
708 return kInlineCacheMegamorphic;
709 }
710
711 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
712 Thread* self = Thread::Current();
713 // We need to resolve the class relative to the containing dex file.
714 // So first, build a mapping from the index of dex file in the profile to
715 // its dex cache. This will avoid repeating the lookup when walking over
716 // the inline cache types.
717 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
718 offline_profile.dex_references.size());
719 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
720 bool found = false;
721 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
722 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
723 dex_profile_index_to_dex_cache[i] =
724 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
725 found = true;
726 }
727 }
728 if (!found) {
729 VLOG(compiler) << "Could not find profiled dex file: "
730 << offline_profile.dex_references[i].dex_location;
731 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100732 }
733 }
734
Calin Juravle13439f02017-02-21 01:17:21 -0800735 // Walk over the classes and resolve them. If we cannot find a type we return
736 // kInlineCacheMissingTypes.
737 int ic_index = 0;
738 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
739 ObjPtr<mirror::DexCache> dex_cache =
740 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
741 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700742
743 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
744 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
745 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
746 return kInlineCacheNoData;
747 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000748 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000749 class_ref.type_index,
750 dex_cache,
751 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800752 if (clazz != nullptr) {
753 inline_cache->Set(ic_index++, clazz);
754 } else {
755 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
756 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
757 invoke_instruction->GetDexMethodIndex()) << " : "
758 << caller_compilation_unit_
759 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
760 return kInlineCacheMissingTypes;
761 }
762 }
763 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100764}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000765
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000766HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
767 HInstruction* receiver,
768 uint32_t dex_pc) const {
769 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
770 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100771 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000772 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000773 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100774 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000775 field->GetOffset(),
776 field->IsVolatile(),
777 field->GetDexFieldIndex(),
778 field->GetDeclaringClass()->GetDexClassDefIndex(),
779 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000780 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000781 // The class of a field is effectively final, and does not have any memory dependencies.
782 result->SetSideEffects(SideEffects::None());
783 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000784}
785
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000786static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
787 ArtMethod* resolved_method,
788 HInstruction* invoke_instruction,
789 PointerSize pointer_size)
790 REQUIRES_SHARED(Locks::mutator_lock_) {
791 if (Runtime::Current()->IsAotCompiler()) {
792 // We can get unrelated types when working with profiles (corruption,
793 // systme updates, or anyone can write to it). So first check if the class
794 // actually implements the declaring class of the method that is being
795 // called in bytecode.
796 // Note: the lookup methods used below require to have assignable types.
797 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
798 return nullptr;
799 }
800 }
801
802 if (invoke_instruction->IsInvokeInterface()) {
803 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
804 } else {
805 DCHECK(invoke_instruction->IsInvokeVirtual());
806 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
807 }
808 DCHECK(resolved_method != nullptr);
809 return resolved_method;
810}
811
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100812bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
813 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000814 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000815 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
816 << invoke_instruction->DebugName();
817
Andreas Gampea5b09a62016-11-17 15:21:22 -0800818 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000819 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800820 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000821 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000822 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
823 << " from inline cache is not inlined because its class is not"
824 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100825 return false;
826 }
827
828 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700829 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000830 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
831 resolved_method = ResolveMethodFromInlineCache(
832 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
833
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000834 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000835 if (resolved_method == nullptr) {
836 // Bogus AOT profile, bail.
837 DCHECK(Runtime::Current()->IsAotCompiler());
838 return false;
839 }
840
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100841 HInstruction* receiver = invoke_instruction->InputAt(0);
842 HInstruction* cursor = invoke_instruction->GetPrevious();
843 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700844 if (!TryInlineAndReplace(invoke_instruction,
845 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000846 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700847 /* do_rtp */ false,
848 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100849 return false;
850 }
851
852 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000853 AddTypeGuard(receiver,
854 cursor,
855 bb_cursor,
856 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000857 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000858 invoke_instruction,
859 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100860
861 // Run type propagation to get the guard typed, and eventually propagate the
862 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000863 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000864 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000865 outer_compilation_unit_.GetDexCache(),
866 handles_,
867 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100868 rtp_fixup.Run();
869
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000870 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100871 return true;
872}
873
Mingyao Yang063fc772016-08-02 11:02:54 -0700874void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
875 uint32_t dex_pc,
876 HInstruction* cursor,
877 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100878 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
879 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
880 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700881 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100882 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
883 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700884
885 if (cursor != nullptr) {
886 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
887 } else {
888 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
889 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800890 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
891 bb_cursor->InsertInstructionAfter(deopt, compare);
892
893 // Add receiver as input to aid CHA guard optimization later.
894 deopt_flag->AddInput(invoke_instruction->InputAt(0));
895 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700896 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800897 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700898}
899
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000900HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
901 HInstruction* cursor,
902 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800903 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000904 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000905 HInstruction* invoke_instruction,
906 bool with_deoptimization) {
907 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
908 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
909 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000910 if (cursor != nullptr) {
911 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
912 } else {
913 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
914 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000915
916 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700917 bool is_referrer;
918 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
919 if (outermost_art_method == nullptr) {
920 DCHECK(Runtime::Current()->IsAotCompiler());
921 // We are in AOT mode and we don't have an ART method to determine
922 // if the inlined method belongs to the referrer. Assume it doesn't.
923 is_referrer = false;
924 } else {
925 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
926 }
927
Nicolas Geoffray56876342016-12-16 16:09:08 +0000928 // Note that we will just compare the classes, so we don't need Java semantics access checks.
929 // Note that the type index and the dex file are relative to the method this type guard is
930 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100931 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
932 class_index,
933 caller_dex_file,
934 klass,
935 is_referrer,
936 invoke_instruction->GetDexPc(),
937 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000938 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000939 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
940 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
941 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000942 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000943 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000944 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800945 // In AOT mode, we will most likely load the class from BSS, which will involve a call
946 // to the runtime. In this case, the load instruction will need an environment so copy
947 // it from the invoke instruction.
948 if (load_class->NeedsEnvironment()) {
949 DCHECK(Runtime::Current()->IsAotCompiler());
950 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
951 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000952
Vladimir Markoca6fff82017-10-03 14:49:14 +0100953 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000954 bb_cursor->InsertInstructionAfter(compare, load_class);
955 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100956 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
957 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000958 compare,
959 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100960 Runtime::Current()->IsAotCompiler()
961 ? DeoptimizationKind::kAotInlineCache
962 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000963 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000964 bb_cursor->InsertInstructionAfter(deoptimize, compare);
965 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000966 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
967 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
968 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000969 }
970 return compare;
971}
972
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000973bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100974 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000975 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000976 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
977 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000978
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000979 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000980 return true;
981 }
982
983 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700984 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000985
986 bool all_targets_inlined = true;
987 bool one_target_inlined = false;
988 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000989 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000990 break;
991 }
992 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000993
994 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000995 method = ResolveMethodFromInlineCache(
996 handle, resolved_method, invoke_instruction, pointer_size);
997 if (method == nullptr) {
998 DCHECK(Runtime::Current()->IsAotCompiler());
999 // AOT profile is bogus. This loop expects to iterate over all entries,
1000 // so just just continue.
1001 all_targets_inlined = false;
1002 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001003 }
1004
1005 HInstruction* receiver = invoke_instruction->InputAt(0);
1006 HInstruction* cursor = invoke_instruction->GetPrevious();
1007 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1008
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001009 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001010 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001011 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -08001012 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001013 !TryBuildAndInline(invoke_instruction,
1014 method,
1015 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
1016 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001017 all_targets_inlined = false;
1018 } else {
1019 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001020
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001021 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
1022 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001023
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001024 // If we have inlined all targets before, and this receiver is the last seen,
1025 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001026 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1027 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001028 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001029 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001030
Nicolas Geoffray56876342016-12-16 16:09:08 +00001031 HInstruction* compare = AddTypeGuard(receiver,
1032 cursor,
1033 bb_cursor,
1034 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001035 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001036 invoke_instruction,
1037 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001038 if (deoptimize) {
1039 if (return_replacement != nullptr) {
1040 invoke_instruction->ReplaceWith(return_replacement);
1041 }
1042 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1043 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001044 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001045 break;
1046 } else {
1047 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1048 }
1049 }
1050 }
1051
1052 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001053 LOG_FAIL_NO_STAT()
1054 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1055 << " from inline cache is not inlined because none"
1056 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001057 return false;
1058 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001059
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001060 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001061
1062 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001063 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001064 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001065 outer_compilation_unit_.GetDexCache(),
1066 handles_,
1067 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001068 rtp_fixup.Run();
1069 return true;
1070}
1071
1072void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1073 HInstruction* return_replacement,
1074 HInstruction* invoke_instruction) {
1075 uint32_t dex_pc = invoke_instruction->GetDexPc();
1076 HBasicBlock* cursor_block = compare->GetBlock();
1077 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001078 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001079
1080 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1081 // and the returned block is the start of the then branch (that could contain multiple blocks).
1082 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1083
1084 // Split the block containing the invoke before and after the invoke. The returned block
1085 // of the split before will contain the invoke and will be the otherwise branch of
1086 // the diamond. The returned block of the split after will be the merge block
1087 // of the diamond.
1088 HBasicBlock* end_then = invoke_instruction->GetBlock();
1089 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1090 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1091
1092 // If the methods we are inlining return a value, we create a phi in the merge block
1093 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1094 if (return_replacement != nullptr) {
1095 HPhi* phi = new (allocator) HPhi(
1096 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1097 merge->AddPhi(phi);
1098 invoke_instruction->ReplaceWith(phi);
1099 phi->AddInput(return_replacement);
1100 phi->AddInput(invoke_instruction);
1101 }
1102
1103 // Add the control flow instructions.
1104 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1105 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1106 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1107
1108 // Add the newly created blocks to the graph.
1109 graph_->AddBlock(then);
1110 graph_->AddBlock(otherwise);
1111 graph_->AddBlock(merge);
1112
1113 // Set up successor (and implictly predecessor) relations.
1114 cursor_block->AddSuccessor(otherwise);
1115 cursor_block->AddSuccessor(then);
1116 end_then->AddSuccessor(merge);
1117 otherwise->AddSuccessor(merge);
1118
1119 // Set up dominance information.
1120 then->SetDominator(cursor_block);
1121 cursor_block->AddDominatedBlock(then);
1122 otherwise->SetDominator(cursor_block);
1123 cursor_block->AddDominatedBlock(otherwise);
1124 merge->SetDominator(cursor_block);
1125 cursor_block->AddDominatedBlock(merge);
1126
1127 // Update the revert post order.
1128 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1129 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1130 graph_->reverse_post_order_[++index] = then;
1131 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1132 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1133 graph_->reverse_post_order_[++index] = otherwise;
1134 graph_->reverse_post_order_[++index] = merge;
1135
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001136
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001137 graph_->UpdateLoopAndTryInformationOfNewBlock(
1138 then, original_invoke_block, /* replace_if_back_edge */ false);
1139 graph_->UpdateLoopAndTryInformationOfNewBlock(
1140 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1141
1142 // In case the original invoke location was a back edge, we need to update
1143 // the loop to now have the merge block as a back edge.
1144 graph_->UpdateLoopAndTryInformationOfNewBlock(
1145 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001146}
1147
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001148bool HInliner::TryInlinePolymorphicCallToSameTarget(
1149 HInvoke* invoke_instruction,
1150 ArtMethod* resolved_method,
1151 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001152 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001153 if (!Runtime::Current()->UseJitCompilation()) {
1154 return false;
1155 }
1156
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001157 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001158 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001159
1160 DCHECK(resolved_method != nullptr);
1161 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001162 size_t method_index = invoke_instruction->IsInvokeVirtual()
1163 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1164 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1165
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001166 // Check whether we are actually calling the same method among
1167 // the different types seen.
1168 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001169 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001170 break;
1171 }
1172 ArtMethod* new_method = nullptr;
1173 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001174 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001175 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001176 if (new_method->IsRuntimeMethod()) {
1177 // Bail out as soon as we see a conflict trampoline in one of the target's
1178 // interface table.
1179 return false;
1180 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001181 } else {
1182 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001183 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001184 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001185 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001186 if (actual_method == nullptr) {
1187 actual_method = new_method;
1188 } else if (actual_method != new_method) {
1189 // Different methods, bailout.
1190 return false;
1191 }
1192 }
1193
1194 HInstruction* receiver = invoke_instruction->InputAt(0);
1195 HInstruction* cursor = invoke_instruction->GetPrevious();
1196 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1197
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001198 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001199 if (!TryBuildAndInline(invoke_instruction,
1200 actual_method,
1201 ReferenceTypeInfo::CreateInvalid(),
1202 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001203 return false;
1204 }
1205
1206 // We successfully inlined, now add a guard.
1207 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1208 class_linker, receiver, invoke_instruction->GetDexPc());
1209
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001210 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1211 ? DataType::Type::kInt64
1212 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001213 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001214 receiver_class,
1215 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001216 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1217 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001218 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001219 invoke_instruction->GetDexPc());
1220
1221 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001222 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001223 constant = graph_->GetLongConstant(
1224 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1225 } else {
1226 constant = graph_->GetIntConstant(
1227 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1228 }
1229
Vladimir Markoca6fff82017-10-03 14:49:14 +01001230 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001231 if (cursor != nullptr) {
1232 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1233 } else {
1234 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1235 }
1236 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1237 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001238
1239 if (outermost_graph_->IsCompilingOsr()) {
1240 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1241 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001242 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1243 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001244 compare,
1245 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001246 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001247 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001248 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1249 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1250 if (return_replacement != nullptr) {
1251 invoke_instruction->ReplaceWith(return_replacement);
1252 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001253 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001254 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001255 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001256 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001257
1258 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001259 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001260 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001261 outer_compilation_unit_.GetDexCache(),
1262 handles_,
1263 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001264 rtp_fixup.Run();
1265
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001266 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001267
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001268 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001269 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001270}
1271
Mingyao Yang063fc772016-08-02 11:02:54 -07001272bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1273 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001274 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001275 bool do_rtp,
1276 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001277 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001278 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001279 uint32_t dex_pc = invoke_instruction->GetDexPc();
1280 HInstruction* cursor = invoke_instruction->GetPrevious();
1281 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001282 bool should_remove_invoke_instruction = false;
1283
1284 // If invoke_instruction is devirtualized to a different method, give intrinsics
1285 // another chance before we try to inline it.
1286 bool wrong_invoke_type = false;
1287 if (invoke_instruction->GetResolvedMethod() != method &&
1288 IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) {
1289 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1290 if (invoke_instruction->IsInvokeInterface()) {
1291 // We don't intrinsify an invoke-interface directly.
1292 // Replace the invoke-interface with an invoke-virtual.
1293 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1294 graph_->GetAllocator(),
1295 invoke_instruction->GetNumberOfArguments(),
1296 invoke_instruction->GetType(),
1297 invoke_instruction->GetDexPc(),
1298 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1299 method,
1300 method->GetMethodIndex());
1301 HInputsRef inputs = invoke_instruction->GetInputs();
1302 for (size_t index = 0; index != inputs.size(); ++index) {
1303 new_invoke->SetArgumentAt(index, inputs[index]);
1304 }
1305 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1306 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1307 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1308 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1309 }
1310 // Run intrinsic recognizer again to set new_invoke's intrinsic.
1311 IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type);
1312 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
1313 return_replacement = new_invoke;
1314 // invoke_instruction is replaced with new_invoke.
1315 should_remove_invoke_instruction = true;
1316 } else {
1317 // invoke_instruction is intrinsified and stays.
1318 }
1319 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001320 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001321 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001322 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1323 // better than an invoke-interface because:
1324 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1325 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1326 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001327
1328 if (method->IsDefault() && !method->IsCopied()) {
1329 // Changing to invoke-virtual cannot be done on an original default method
1330 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1331 // always uses a method in the iftable which is never an original default
1332 // method.
1333 // On the other hand, inlining an original default method by CHA is fine.
1334 DCHECK(cha_devirtualize);
1335 return false;
1336 }
1337
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001338 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001339 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001340 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001341 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001342 return false;
1343 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001344 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1345 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001346 invoke_instruction->GetNumberOfArguments(),
1347 invoke_instruction->GetType(),
1348 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001349 dex_method_index,
1350 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001351 method->GetMethodIndex());
1352 HInputsRef inputs = invoke_instruction->GetInputs();
1353 for (size_t index = 0; index != inputs.size(); ++index) {
1354 new_invoke->SetArgumentAt(index, inputs[index]);
1355 }
1356 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1357 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001358 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001359 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1360 }
1361 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001362 // invoke_instruction is replaced with new_invoke.
1363 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001364 } else {
1365 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1366 // compiler driver.
1367 return false;
1368 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001369 } else {
1370 // invoke_instruction is inlined.
1371 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001372 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001373
Mingyao Yang063fc772016-08-02 11:02:54 -07001374 if (cha_devirtualize) {
1375 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1376 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001377 if (return_replacement != nullptr) {
1378 invoke_instruction->ReplaceWith(return_replacement);
1379 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001380 if (should_remove_invoke_instruction) {
1381 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1382 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001383 FixUpReturnReferenceType(method, return_replacement);
1384 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1385 // Actual return value has a more specific type than the method's declared
1386 // return type. Run RTP again on the outer graph to propagate it.
1387 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001388 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001389 outer_compilation_unit_.GetDexCache(),
1390 handles_,
1391 /* is_first_run */ false).Run();
1392 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001393 return true;
1394}
1395
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001396size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1397 const HInliner* current = this;
1398 size_t count = 0;
1399 do {
1400 if (current->graph_->GetArtMethod() == method) {
1401 ++count;
1402 }
1403 current = current->parent_;
1404 } while (current != nullptr);
1405 return count;
1406}
1407
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001408bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1409 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001410 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001411 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001412 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001413 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001414 << "Method " << method->PrettyMethod()
1415 << " is not inlined because of unimplemented inline support for proxy methods.";
1416 return false;
1417 }
1418
1419 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001420 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001421 << "Method "
1422 << method->PrettyMethod()
1423 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001424 return false;
1425 }
1426
Jeff Haodcdc85b2015-12-04 14:06:18 -08001427 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1428 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1429 if (!compiler_driver_->MayInline(method->GetDexFile(),
1430 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001431 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001432 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1433 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001434 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001435 return true;
1436 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001437 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001438 << "Won't inline " << method->PrettyMethod() << " in "
1439 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1440 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1441 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001442 return false;
1443 }
1444
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001445 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1446
David Sehr0225f8e2018-01-31 08:52:24 +00001447 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001448
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001449 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001450 LOG_FAIL_NO_STAT()
1451 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001452 return false;
1453 }
1454
Calin Juravleec748352015-07-29 13:52:12 +01001455 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001456 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001457 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001458 << "Method " << method->PrettyMethod()
1459 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001460 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001461 << " > "
1462 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001463 return false;
1464 }
1465
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001466 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001467 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001468 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001469 return false;
1470 }
1471
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001472 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001473 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001474 << "Method " << method->PrettyMethod()
1475 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Aart Bik897df032018-02-07 13:29:11 -08001476 return false;
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001477 }
1478
Aart Bik2c148f02018-02-02 14:30:35 -08001479 if (IsMethodUnverified(compiler_driver_, method)) {
1480 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
1481 << "Method " << method->PrettyMethod()
1482 << " couldn't be verified, so it cannot be inlined";
1483 return false;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001484 }
1485
Roland Levillain4c0eb422015-04-24 16:43:49 +01001486 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1487 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1488 // Case of a static method that cannot be inlined because it implicitly
1489 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001490 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1491 << "Method " << method->PrettyMethod()
1492 << " is not inlined because it is static and requires a clinit"
1493 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001494 return false;
1495 }
1496
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001497 if (!TryBuildAndInlineHelper(
1498 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001499 return false;
1500 }
1501
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001502 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001503 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001504 return true;
1505}
1506
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001507static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1508 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001509 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001510 size_t input_index = 0;
1511 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1512 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001513 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001514 ++i;
1515 DCHECK_NE(i, arg_vreg_index);
1516 }
1517 }
1518 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1519 return invoke_instruction->InputAt(input_index);
1520}
1521
1522// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1523bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1524 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001525 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001526 InlineMethod inline_method;
1527 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1528 return false;
1529 }
1530
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001531 switch (inline_method.opcode) {
1532 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001533 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001534 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001535 break;
1536 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001537 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1538 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001539 break;
1540 case kInlineOpNonWideConst:
1541 if (resolved_method->GetShorty()[0] == 'L') {
1542 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001543 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001544 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001545 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001546 }
1547 break;
1548 case kInlineOpIGet: {
1549 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1550 if (data.method_is_static || data.object_arg != 0u) {
1551 // TODO: Needs null check.
1552 return false;
1553 }
1554 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001555 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001556 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1557 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1558 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001559 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001560 break;
1561 }
1562 case kInlineOpIPut: {
1563 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1564 if (data.method_is_static || data.object_arg != 0u) {
1565 // TODO: Needs null check.
1566 return false;
1567 }
1568 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1569 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001570 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001571 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1572 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1573 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1574 if (data.return_arg_plus1 != 0u) {
1575 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001576 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001577 }
1578 break;
1579 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001580 case kInlineOpConstructor: {
1581 const InlineConstructorData& data = inline_method.d.constructor_data;
1582 // Get the indexes to arrays for easier processing.
1583 uint16_t iput_field_indexes[] = {
1584 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1585 };
1586 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1587 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1588 // Count valid field indexes.
1589 size_t number_of_iputs = 0u;
1590 while (number_of_iputs != arraysize(iput_field_indexes) &&
1591 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1592 // Check that there are no duplicate valid field indexes.
1593 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1594 iput_field_indexes + arraysize(iput_field_indexes),
1595 iput_field_indexes[number_of_iputs]));
1596 ++number_of_iputs;
1597 }
1598 // Check that there are no valid field indexes in the rest of the array.
1599 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1600 iput_field_indexes + arraysize(iput_field_indexes),
1601 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1602
1603 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001604 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1605 bool needs_constructor_barrier = false;
1606 for (size_t i = 0; i != number_of_iputs; ++i) {
1607 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001608 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001609 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001610 bool is_final;
1611 HInstanceFieldSet* iput =
1612 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001613 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1614
1615 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001616 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001617 needs_constructor_barrier = true;
1618 }
1619 }
1620 }
1621 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001622 // See CompilerDriver::RequiresConstructorBarrier for more details.
1623 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1624
1625 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001626 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001627 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1628 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001629 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001630 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001631 break;
1632 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001633 default:
1634 LOG(FATAL) << "UNREACHABLE";
1635 UNREACHABLE();
1636 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001637 return true;
1638}
1639
Vladimir Markof44d36c2017-03-14 14:18:46 +00001640HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1641 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001642 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001643 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001644 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1645 ArtField* resolved_field =
1646 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001647 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001648 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001649 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001650 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001651 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001652 resolved_field->GetOffset(),
1653 resolved_field->IsVolatile(),
1654 field_index,
1655 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001656 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001657 // Read barrier generates a runtime call in slow path and we need a valid
1658 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1659 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001660 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001661 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001662 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001663 ReferenceTypePropagation rtp(graph_,
1664 outer_compilation_unit_.GetClassLoader(),
1665 dex_cache,
1666 handles_,
1667 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001668 rtp.Visit(iget);
1669 }
1670 return iget;
1671}
1672
Vladimir Markof44d36c2017-03-14 14:18:46 +00001673HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1674 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001675 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001676 HInstruction* value,
1677 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001678 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001679 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1680 ArtField* resolved_field =
1681 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001682 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001683 if (is_final != nullptr) {
1684 // This information is needed only for constructors.
1685 DCHECK(referrer->IsConstructor());
1686 *is_final = resolved_field->IsFinal();
1687 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001688 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001689 obj,
1690 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001691 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001692 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001693 resolved_field->GetOffset(),
1694 resolved_field->IsVolatile(),
1695 field_index,
1696 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001697 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001698 // Read barrier generates a runtime call in slow path and we need a valid
1699 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1700 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001701 return iput;
1702}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001703
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001704template <typename T>
1705static inline Handle<T> NewHandleIfDifferent(T* object,
1706 Handle<T> hint,
1707 VariableSizedHandleScope* handles)
1708 REQUIRES_SHARED(Locks::mutator_lock_) {
1709 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1710}
1711
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001712bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1713 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001714 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001715 bool same_dex_file,
1716 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001717 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001718 ScopedObjectAccess soa(Thread::Current());
1719 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001720 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1721 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001722 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001723 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001724 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1725 caller_compilation_unit_.GetDexCache(),
1726 handles_);
1727 Handle<mirror::ClassLoader> class_loader =
1728 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1729 caller_compilation_unit_.GetClassLoader(),
1730 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001731
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001732 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001733 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001734 class_linker,
1735 callee_dex_file,
1736 code_item,
1737 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1738 method_index,
1739 resolved_method->GetAccessFlags(),
1740 /* verified_method */ nullptr,
1741 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001742
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001743 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001744 if (invoke_type == kInterface) {
1745 // We have statically resolved the dispatch. To please the class linker
1746 // at runtime, we change this call as if it was a virtual call.
1747 invoke_type = kVirtual;
1748 }
David Brazdil3f523062016-02-29 16:53:33 +00001749
1750 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001751 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1752 graph_->GetAllocator(),
1753 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001754 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001755 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001756 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001757 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001758 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001759 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001760 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001761 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001762
Vladimir Marko438709f2017-02-23 18:56:13 +00001763 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001764 // of on the stack, as Clang might produce a stack frame too large
1765 // for this function, that would not fit the requirements of the
1766 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001767 if (stats_ != nullptr) {
1768 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1769 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001770 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001771 inline_stats_ = new (storage) OptimizingCompilerStats;
1772 } else {
1773 inline_stats_->Reset();
1774 }
1775 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001776 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001777 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001778 &dex_compilation_unit,
1779 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001780 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001781 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001782 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001783 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001784 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001785
David Brazdildee58d62016-04-07 09:54:26 +00001786 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001787 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001788 << "Method " << callee_dex_file.PrettyMethod(method_index)
1789 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001790 return false;
1791 }
1792
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001793 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1794 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001795 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001796 << "Method " << callee_dex_file.PrettyMethod(method_index)
1797 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001798 return false;
1799 }
1800
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001801 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001802 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001803 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1804 !instructions.Done();
1805 instructions.Advance()) {
1806 HInstruction* current = instructions.Current();
1807 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001808 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001809 if (argument->IsNullConstant()) {
1810 current->ReplaceWith(callee_graph->GetNullConstant());
1811 } else if (argument->IsIntConstant()) {
1812 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1813 } else if (argument->IsLongConstant()) {
1814 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1815 } else if (argument->IsFloatConstant()) {
1816 current->ReplaceWith(
1817 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1818 } else if (argument->IsDoubleConstant()) {
1819 current->ReplaceWith(
1820 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001821 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001822 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1823 run_rtp = true;
1824 current->SetReferenceTypeInfo(receiver_type);
1825 } else {
1826 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1827 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001828 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1829 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001830 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001831 }
1832 }
1833
David Brazdil94ab38f2016-06-21 17:48:19 +01001834 // We have replaced formal arguments with actual arguments. If actual types
1835 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001836 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001837 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001838 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001839 dex_compilation_unit.GetDexCache(),
1840 handles_,
1841 /* is_first_run */ false).Run();
1842 }
1843
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001844 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001845
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001846 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1847 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001848 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001849 << "Method " << callee_dex_file.PrettyMethod(method_index)
1850 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001851 return false;
1852 }
1853
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001854 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001855 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1856 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001857 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1858 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001859 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001860 << "Method " << callee_dex_file.PrettyMethod(method_index)
1861 << " could not be inlined because one branch always throws and"
1862 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001863 return false;
1864 } else if (graph_->GetExitBlock() == nullptr) {
1865 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001866 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001867 << "Method " << callee_dex_file.PrettyMethod(method_index)
1868 << " could not be inlined because one branch always throws and"
1869 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001870 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001871 } else if (graph_->HasIrreducibleLoops()) {
1872 // TODO(ngeoffray): Support re-computing loop information to graphs with
1873 // irreducible loops?
1874 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1875 << " could not be inlined because one branch always throws and"
1876 << " caller has irreducible loops";
1877 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001878 }
1879 } else {
1880 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001881 }
1882 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001883
1884 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001885 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001886 << "Method " << callee_dex_file.PrettyMethod(method_index)
1887 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001888 return false;
1889 }
1890
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001891 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001892 // Skip the entry block, it does not contain instructions that prevent inlining.
1893 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001894 if (block->IsLoopHeader()) {
1895 if (block->GetLoopInformation()->IsIrreducible()) {
1896 // Don't inline methods with irreducible loops, they could prevent some
1897 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001898 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001899 << "Method " << callee_dex_file.PrettyMethod(method_index)
1900 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001901 return false;
1902 }
1903 if (!block->GetLoopInformation()->HasExitEdge()) {
1904 // Don't inline methods with loops without exit, since they cause the
1905 // loop information to be computed incorrectly when updating after
1906 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001907 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001908 << "Method " << callee_dex_file.PrettyMethod(method_index)
1909 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001910 return false;
1911 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001912 }
1913
1914 for (HInstructionIterator instr_it(block->GetInstructions());
1915 !instr_it.Done();
1916 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001917 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001918 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001919 << "Method " << callee_dex_file.PrettyMethod(method_index)
1920 << " is not inlined because the outer method has reached"
1921 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001922 return false;
1923 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001924 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001925 if (current->NeedsEnvironment() &&
1926 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001927 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001928 << "Method " << callee_dex_file.PrettyMethod(method_index)
1929 << " is not inlined because its caller has reached"
1930 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001931 return false;
1932 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001933
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001934 if (current->NeedsEnvironment() &&
1935 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1936 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001937 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001938 << "Method " << callee_dex_file.PrettyMethod(method_index)
1939 << " could not be inlined because " << current->DebugName()
1940 << " needs an environment, is in a different dex file"
1941 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001942 return false;
1943 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001944
Vladimir Markodc151b22015-10-15 18:02:30 +01001945 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001946 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001947 << "Method " << callee_dex_file.PrettyMethod(method_index)
1948 << " could not be inlined because " << current->DebugName()
1949 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001950 return false;
1951 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001952
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001953 if (current->IsUnresolvedStaticFieldGet() ||
1954 current->IsUnresolvedInstanceFieldGet() ||
1955 current->IsUnresolvedStaticFieldSet() ||
1956 current->IsUnresolvedInstanceFieldSet()) {
1957 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001958 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001959 << "Method " << callee_dex_file.PrettyMethod(method_index)
1960 << " could not be inlined because it is using an unresolved"
1961 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001962 return false;
1963 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001964 }
1965 }
David Brazdil3f523062016-02-29 16:53:33 +00001966 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1967 << "No instructions can be added to the outer graph while inner graph is being built";
1968
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001969 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001970 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1971 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001972 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001973 // Update our budget for other inlining attempts in `caller_graph`.
1974 total_number_of_instructions_ += number_of_instructions;
1975 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001976
1977 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1978 << "No instructions can be added to the inner graph during inlining into the outer graph";
1979
Vladimir Marko438709f2017-02-23 18:56:13 +00001980 if (stats_ != nullptr) {
1981 DCHECK(inline_stats_ != nullptr);
1982 inline_stats_->AddTo(stats_);
1983 }
1984
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001985 return true;
1986}
Calin Juravle2e768302015-07-28 14:41:11 +00001987
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001988void HInliner::RunOptimizations(HGraph* callee_graph,
1989 const DexFile::CodeItem* code_item,
1990 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001991 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1992 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00001993 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08001994 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Marko28e012a2017-12-07 11:22:59 +00001995 HSharpening sharpening(callee_graph, codegen_, compiler_driver_);
Vladimir Marko65979462017-05-19 17:25:12 +01001996 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00001997 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001998
1999 HOptimization* optimizations[] = {
2000 &intrinsics,
2001 &sharpening,
2002 &simplify,
2003 &fold,
2004 &dce,
2005 };
2006
2007 for (size_t i = 0; i < arraysize(optimizations); ++i) {
2008 HOptimization* optimization = optimizations[i];
2009 optimization->Run();
2010 }
2011
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002012 // Bail early for pathological cases on the environment (for example recursive calls,
2013 // or too large environment).
2014 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
2015 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2016 << " will not be inlined because the outer method has reached"
2017 << " its environment budget limit.";
2018 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002019 }
2020
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002021 // Bail early if we know we already are over the limit.
2022 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2023 if (number_of_instructions > inlining_budget_) {
2024 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2025 << " will not be inlined because the outer method has reached"
2026 << " its instruction budget limit. " << number_of_instructions;
2027 return;
2028 }
2029
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002030 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002031 HInliner inliner(callee_graph,
2032 outermost_graph_,
2033 codegen_,
2034 outer_compilation_unit_,
2035 dex_compilation_unit,
2036 compiler_driver_,
2037 handles_,
2038 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002039 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002040 total_number_of_instructions_ + number_of_instructions,
2041 this,
2042 depth_ + 1);
2043 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002044}
2045
David Brazdil94ab38f2016-06-21 17:48:19 +01002046static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2047 bool declared_can_be_null,
2048 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002049 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002050 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2051 return true;
2052 }
2053
2054 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2055 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002056 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002057}
2058
Vladimir Markob45528c2017-07-27 14:14:28 +01002059ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002060 return ReferenceTypePropagation::IsAdmissible(klass)
2061 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2062 : graph_->GetInexactObjectRti();
2063}
2064
2065bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2066 // If this is an instance call, test whether the type of the `this` argument
2067 // is more specific than the class which declares the method.
2068 if (!resolved_method->IsStatic()) {
2069 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
2070 /* declared_can_be_null */ false,
2071 invoke_instruction->InputAt(0u))) {
2072 return true;
2073 }
2074 }
2075
David Brazdil94ab38f2016-06-21 17:48:19 +01002076 // Iterate over the list of parameter types and test whether any of the
2077 // actual inputs has a more specific reference type than the type declared in
2078 // the signature.
2079 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
2080 for (size_t param_idx = 0,
2081 input_idx = resolved_method->IsStatic() ? 0 : 1,
2082 e = (param_list == nullptr ? 0 : param_list->Size());
2083 param_idx < e;
2084 ++param_idx, ++input_idx) {
2085 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002086 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002087 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2088 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002089 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
2090 /* declared_can_be_null */ true,
2091 input)) {
2092 return true;
2093 }
2094 }
2095 }
2096
2097 return false;
2098}
2099
2100bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2101 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002102 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002103 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002104 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002105 // Test if the return type is a refinement of the declared return type.
2106 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2107 /* declared_can_be_null */ true,
2108 return_replacement)) {
2109 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002110 } else if (return_replacement->IsInstanceFieldGet()) {
2111 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
2112 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2113 if (field_get->GetFieldInfo().GetField() ==
2114 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
2115 return true;
2116 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002117 }
2118 } else if (return_replacement->IsInstanceOf()) {
2119 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2120 return true;
2121 }
2122 }
2123
2124 return false;
2125}
2126
2127void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2128 HInstruction* return_replacement) {
2129 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002130 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002131 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2132 // Make sure that we have a valid type for the return. We may get an invalid one when
2133 // we inline invokes with multiple branches and create a Phi for the result.
2134 // TODO: we could be more precise by merging the phi inputs but that requires
2135 // some functionality from the reference type propagation.
2136 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002137 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002138 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002139 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002140 }
Calin Juravle2e768302015-07-28 14:41:11 +00002141 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002142}
2143
2144} // namespace art