blob: 18784da72ce07f985ed4e6b8da690b33a05c7c9a [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Andreas Gampe85f1c572018-11-21 13:52:48 -080021#include "base/logging.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000022#include "builder.h"
23#include "class_linker.h"
Vladimir Markob4eb1b12018-05-24 11:09:38 +010024#include "class_root.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010026#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070028#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000029#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070030#include "dex/verified_method.h"
Calin Juravleec748352015-07-29 13:52:12 +010031#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000032#include "driver/dex_compilation_unit.h"
33#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010034#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000035#include "jit/jit.h"
36#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000037#include "mirror/class_loader.h"
38#include "mirror/dex_cache.h"
Andreas Gampe52ecb652018-10-24 15:18:21 -070039#include "mirror/object_array-alloc-inl.h"
40#include "mirror/object_array-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000041#include "nodes.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010042#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070043#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070044#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010045#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000046#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000047#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000048#include "thread.h"
49
50namespace art {
51
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000052// Instruction limit to control memory.
53static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
54
55// Maximum number of instructions for considering a method small,
56// which we will always try to inline if the other non-instruction limits
57// are not reached.
58static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000059
60// Limit the number of dex registers that we accumulate while inlining
61// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010062static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000063
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000064// Limit recursive call inlining, which do not benefit from too
65// much inlining compared to code locality.
66static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070067
Calin Juravlee2492d42017-03-20 11:42:13 -070068// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070069static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070070
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000071// We check for line numbers to make sure the DepthString implementation
72// aligns the output nicely.
73#define LOG_INTERNAL(msg) \
74 static_assert(__LINE__ > 10, "Unhandled line number"); \
75 static_assert(__LINE__ < 10000, "Unhandled line number"); \
76 VLOG(compiler) << DepthString(__LINE__) << msg
77
78#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
79#define LOG_NOTE() LOG_INTERNAL("Note: ")
80#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070081#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000082#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
83
84std::string HInliner::DepthString(int line) const {
85 std::string value;
86 // Indent according to the inlining depth.
87 size_t count = depth_;
88 // Line numbers get printed in the log, so add a space if the log's line is less
89 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
90 if (!kIsTargetBuild) {
91 if (line < 100) {
92 value += " ";
93 }
94 if (line < 1000) {
95 value += " ";
96 }
97 // Safeguard if this file reaches more than 10000 lines.
98 DCHECK_LT(line, 10000);
99 }
100 for (size_t i = 0; i < count; ++i) {
101 value += " ";
102 }
103 return value;
104}
105
106static size_t CountNumberOfInstructions(HGraph* graph) {
107 size_t number_of_instructions = 0;
108 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
109 for (HInstructionIterator instr_it(block->GetInstructions());
110 !instr_it.Done();
111 instr_it.Advance()) {
112 ++number_of_instructions;
113 }
114 }
115 return number_of_instructions;
116}
117
118void HInliner::UpdateInliningBudget() {
119 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
120 // Always try to inline small methods.
121 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
122 } else {
123 inlining_budget_ = std::max(
124 kMaximumNumberOfInstructionsForSmallMethod,
125 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
126 }
127}
128
Aart Bik24773202018-04-26 10:28:51 -0700129bool HInliner::Run() {
Vladimir Marko213ee2d2018-06-22 11:56:34 +0100130 if (codegen_->GetCompilerOptions().GetInlineMaxCodeUnits() == 0) {
Aart Bik24773202018-04-26 10:28:51 -0700131 // Inlining effectively disabled.
132 return false;
133 } else if (graph_->IsDebuggable()) {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000134 // For simplicity, we currently never inline when the graph is debuggable. This avoids
135 // doing some logic in the runtime to discover if a method could have been inlined.
Aart Bik24773202018-04-26 10:28:51 -0700136 return false;
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000137 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000138
Aart Bik24773202018-04-26 10:28:51 -0700139 bool didInline = false;
140
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000141 // Initialize the number of instructions for the method being compiled. Recursive calls
142 // to HInliner::Run have already updated the instruction count.
143 if (outermost_graph_ == graph_) {
144 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
145 }
146
147 UpdateInliningBudget();
148 DCHECK_NE(total_number_of_instructions_, 0u);
149 DCHECK_NE(inlining_budget_, 0u);
150
Roland Levillain6c3af162017-04-27 11:18:56 +0100151 // If we're compiling with a core image (which is only used for
152 // test purposes), honor inlining directives in method names:
Roland Levillain6c3af162017-04-27 11:18:56 +0100153 // - if a method's name contains the substring "$noinline$", do not
Vladimir Marko6be1dbd2018-11-13 13:09:51 +0000154 // inline that method;
155 // - if a method's name contains the substring "$inline$", ensure
156 // that this method is actually inlined.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000157 // We limit the latter to AOT compilation, as the JIT may or may not inline
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100158 // depending on the state of classes at runtime.
Vladimir Marko6be1dbd2018-11-13 13:09:51 +0000159 const bool honor_noinline_directives = codegen_->GetCompilerOptions().CompilingWithCoreImage();
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000160 const bool honor_inline_directives =
161 honor_noinline_directives && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100162
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000163 // Keep a copy of all blocks when starting the visit.
164 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100165 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000166 // Because we are changing the graph when inlining,
167 // we just iterate over the blocks of the outer method.
168 // This avoids doing the inlining work again on the inlined blocks.
169 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000170 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
171 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100172 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700173 // As long as the call is not intrinsified, it is worth trying to inline.
174 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000175 if (honor_noinline_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000176 // Debugging case: directives in method names control or assert on inlining.
177 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
Andreas Gampe3db70682018-12-26 15:12:03 -0800178 call->GetDexMethodIndex(), /* with_signature= */ false);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000179 // Tests prevent inlining by having $noinline$ in their method names.
180 if (callee_name.find("$noinline$") == std::string::npos) {
Aart Bik24773202018-04-26 10:28:51 -0700181 if (TryInline(call)) {
182 didInline = true;
Aart Bik54e45c52018-04-27 13:57:21 -0700183 } else if (honor_inline_directives) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000184 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
185 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000186 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000187 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100188 } else {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000189 DCHECK(!honor_inline_directives);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000190 // Normal case: try to inline.
Aart Bik24773202018-04-26 10:28:51 -0700191 if (TryInline(call)) {
192 didInline = true;
193 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000194 }
195 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000196 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000197 }
198 }
Aart Bik24773202018-04-26 10:28:51 -0700199
200 return didInline;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000201}
202
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100203static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700204 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100205 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
206}
207
208/**
209 * Given the `resolved_method` looked up in the dex cache, try to find
210 * the actual runtime target of an interface or virtual call.
211 * Return nullptr if the runtime target cannot be proven.
212 */
213static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700214 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100215 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
216 // No need to lookup further, the resolved method will be the target.
217 return resolved_method;
218 }
219
220 HInstruction* receiver = invoke->InputAt(0);
221 if (receiver->IsNullCheck()) {
222 // Due to multiple levels of inlining within the same pass, it might be that
223 // null check does not have the reference type of the actual receiver.
224 receiver = receiver->InputAt(0);
225 }
226 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000227 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
228 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 // We currently only support inlining with known receivers.
230 // TODO: Remove this check, we should be able to inline final methods
231 // on unknown receivers.
232 return nullptr;
233 } else if (info.GetTypeHandle()->IsInterface()) {
234 // Statically knowing that the receiver has an interface type cannot
235 // help us find what is the target method.
236 return nullptr;
237 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
238 // The method that we're trying to call is not in the receiver's class or super classes.
239 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000240 } else if (info.GetTypeHandle()->IsErroneous()) {
241 // If the type is erroneous, do not go further, as we are going to query the vtable or
242 // imt table, that we can only safely do on non-erroneous classes.
243 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100244 }
245
246 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700247 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100248 if (invoke->IsInvokeInterface()) {
249 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
250 resolved_method, pointer_size);
251 } else {
252 DCHECK(invoke->IsInvokeVirtual());
253 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
254 resolved_method, pointer_size);
255 }
256
257 if (resolved_method == nullptr) {
258 // The information we had on the receiver was not enough to find
259 // the target method. Since we check above the exact type of the receiver,
260 // the only reason this can happen is an IncompatibleClassChangeError.
261 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700262 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100263 // The information we had on the receiver was not enough to find
264 // the target method. Since we check above the exact type of the receiver,
265 // the only reason this can happen is an IncompatibleClassChangeError.
266 return nullptr;
267 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
268 // A final method has to be the target method.
269 return resolved_method;
270 } else if (info.IsExact()) {
271 // If we found a method and the receiver's concrete type is statically
272 // known, we know for sure the target.
273 return resolved_method;
274 } else {
275 // Even if we did find a method, the receiver type was not enough to
276 // statically find the runtime target.
277 return nullptr;
278 }
279}
280
281static uint32_t FindMethodIndexIn(ArtMethod* method,
282 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000283 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700284 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100285 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100286 return method->GetDexMethodIndex();
287 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000288 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100289 }
290}
291
Andreas Gampea5b09a62016-11-17 15:21:22 -0800292static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700294 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800296 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100297 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700298 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000299 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800300 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700301 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100302 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100303 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000304 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000305 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100306 } else {
307 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000308 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100309 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000310 // the right class already resolved with the class loader.
311 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000312 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000313 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
314 if (resolved != cls) {
315 index = dex::TypeIndex::Invalid();
316 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100317 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100318 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000319
320 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100321}
322
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000323class ScopedProfilingInfoInlineUse {
324 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000325 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
326 : method_(method),
327 self_(self),
328 // Fetch the profiling info ahead of using it. If it's null when fetching,
329 // we should not call JitCodeCache::DoneInlining.
330 profiling_info_(
331 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000332 }
333
334 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000335 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700336 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000337 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
338 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
339 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000340 }
341
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000342 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
343
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000344 private:
345 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000346 Thread* const self_;
347 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000348};
349
Calin Juravle13439f02017-02-21 01:17:21 -0800350HInliner::InlineCacheType HInliner::GetInlineCacheType(
351 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
352 REQUIRES_SHARED(Locks::mutator_lock_) {
353 uint8_t number_of_types = 0;
354 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
355 if (classes->Get(number_of_types) == nullptr) {
356 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000357 }
358 }
Calin Juravle13439f02017-02-21 01:17:21 -0800359
360 if (number_of_types == 0) {
361 return kInlineCacheUninitialized;
362 } else if (number_of_types == 1) {
363 return kInlineCacheMonomorphic;
364 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
365 return kInlineCacheMegamorphic;
366 } else {
367 return kInlineCachePolymorphic;
368 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000369}
370
371static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
372 REQUIRES_SHARED(Locks::mutator_lock_) {
373 DCHECK(classes->Get(0) != nullptr);
374 return classes->Get(0);
375}
376
Mingyao Yang063fc772016-08-02 11:02:54 -0700377ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
378 if (!resolved_method->HasSingleImplementation()) {
379 return nullptr;
380 }
381 if (Runtime::Current()->IsAotCompiler()) {
382 // No CHA-based devirtulization for AOT compiler (yet).
383 return nullptr;
384 }
385 if (outermost_graph_->IsCompilingOsr()) {
386 // We do not support HDeoptimize in OSR methods.
387 return nullptr;
388 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800389 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000390 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
391 if (single_impl == nullptr) {
392 return nullptr;
393 }
394 if (single_impl->IsProxyMethod()) {
395 // Proxy method is a generic invoker that's not worth
396 // devirtualizing/inlining. It also causes issues when the proxy
397 // method is in another dex file if we try to rewrite invoke-interface to
398 // invoke-virtual because a proxy method doesn't have a real dex file.
399 return nullptr;
400 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100401 if (!single_impl->GetDeclaringClass()->IsResolved()) {
402 // There's a race with the class loading, which updates the CHA info
403 // before setting the class to resolved. So we just bail for this
404 // rare occurence.
405 return nullptr;
406 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000407 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700408}
409
Vladimir Marko2afaff72018-11-30 17:01:50 +0000410static bool IsMethodUnverified(const CompilerOptions& compiler_options, ArtMethod* method)
David Sehr0225f8e2018-01-31 08:52:24 +0000411 REQUIRES_SHARED(Locks::mutator_lock_) {
Aart Bik2c148f02018-02-02 14:30:35 -0800412 if (!method->GetDeclaringClass()->IsVerified()) {
413 if (Runtime::Current()->UseJitCompilation()) {
414 // We're at runtime, we know this is cold code if the class
415 // is not verified, so don't bother analyzing.
416 return true;
417 }
418 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Vladimir Marko2afaff72018-11-30 17:01:50 +0000419 if (!compiler_options.IsMethodVerifiedWithoutFailures(method->GetDexMethodIndex(),
420 class_def_idx,
421 *method->GetDexFile())) {
Aart Bik2c148f02018-02-02 14:30:35 -0800422 // Method has soft or hard failures, don't analyze.
423 return true;
424 }
425 }
426 return false;
427}
428
Vladimir Marko2afaff72018-11-30 17:01:50 +0000429static bool AlwaysThrows(const CompilerOptions& compiler_options, ArtMethod* method)
Aart Bik2c148f02018-02-02 14:30:35 -0800430 REQUIRES_SHARED(Locks::mutator_lock_) {
431 DCHECK(method != nullptr);
432 // Skip non-compilable and unverified methods.
Vladimir Marko2afaff72018-11-30 17:01:50 +0000433 if (!method->IsCompilable() || IsMethodUnverified(compiler_options, method)) {
Aart Bik2c148f02018-02-02 14:30:35 -0800434 return false;
435 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800436 // Skip native methods, methods with try blocks, and methods that are too large.
Aart Bik2c148f02018-02-02 14:30:35 -0800437 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800438 if (!accessor.HasCodeItem() ||
439 accessor.TriesSize() != 0 ||
440 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
441 return false;
442 }
443 // Scan for exits.
444 bool throw_seen = false;
445 for (const DexInstructionPcPair& pair : accessor) {
446 switch (pair.Inst().Opcode()) {
447 case Instruction::RETURN:
448 case Instruction::RETURN_VOID:
449 case Instruction::RETURN_WIDE:
450 case Instruction::RETURN_OBJECT:
451 case Instruction::RETURN_VOID_NO_BARRIER:
452 return false; // found regular control flow back
453 case Instruction::THROW:
454 throw_seen = true;
455 break;
456 default:
457 break;
458 }
459 }
460 return throw_seen;
461}
462
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700463bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000464 if (invoke_instruction->IsInvokeUnresolved() ||
Orion Hodson4c8e12e2018-05-18 08:33:20 +0100465 invoke_instruction->IsInvokePolymorphic() ||
466 invoke_instruction->IsInvokeCustom()) {
467 return false; // Don't bother to move further if we know the method is unresolved or the
468 // invocation is polymorphic (invoke-{polymorphic,custom}).
Calin Juravle175dc732015-08-25 15:42:32 +0100469 }
470
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000471 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100472 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000473 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000474 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000475
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100476 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100477 if (resolved_method == nullptr) {
478 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
479 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000480 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100481 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000482 }
483 ArtMethod* actual_method = nullptr;
484
485 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800486 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000487 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100488 // Check if we can statically find the method.
489 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000490 }
491
Mingyao Yang063fc772016-08-02 11:02:54 -0700492 bool cha_devirtualize = false;
493 if (actual_method == nullptr) {
494 ArtMethod* method = TryCHADevirtualization(resolved_method);
495 if (method != nullptr) {
496 cha_devirtualize = true;
497 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000498 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700499 }
500 }
501
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100502 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800503 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700504 bool result = TryInlineAndReplace(invoke_instruction,
505 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000506 ReferenceTypeInfo::CreateInvalid(),
Andreas Gampe3db70682018-12-26 15:12:03 -0800507 /* do_rtp= */ true,
Mingyao Yang063fc772016-08-02 11:02:54 -0700508 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800509 if (result) {
510 // Successfully inlined.
511 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
512 if (cha_devirtualize) {
513 // Add dependency due to devirtualization. We've assumed resolved_method
514 // has single implementation.
515 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
516 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
517 } else {
518 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
519 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700520 }
Vladimir Marko2afaff72018-11-30 17:01:50 +0000521 } else if (!cha_devirtualize && AlwaysThrows(codegen_->GetCompilerOptions(), actual_method)) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800522 // Set always throws property for non-inlined method call with single target
523 // (unless it was obtained through CHA, because that would imply we have
524 // to add the CHA dependency, which seems not worth it).
525 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000526 }
527 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100528 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800529 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100530
Calin Juravle13439f02017-02-21 01:17:21 -0800531 // Try using inline caches.
532 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
533}
534
535static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
536 const DexCompilationUnit& compilation_unit,
537 StackHandleScope<1>* hs)
538 REQUIRES_SHARED(Locks::mutator_lock_) {
539 Thread* self = Thread::Current();
540 ClassLinker* class_linker = compilation_unit.GetClassLinker();
541 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
542 mirror::ObjectArray<mirror::Class>::Alloc(
543 self,
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100544 GetClassRoot<mirror::ObjectArray<mirror::Class>>(class_linker),
Calin Juravle13439f02017-02-21 01:17:21 -0800545 InlineCache::kIndividualCacheSize));
546 if (inline_cache == nullptr) {
547 // We got an OOME. Just clear the exception, and don't inline.
548 DCHECK(self->IsExceptionPending());
549 self->ClearException();
550 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
551 }
552 return inline_cache;
553}
554
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700555bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
556 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
557 // do not generate a deopt.
558 //
559 // For AOT:
560 // Generating a deopt does not ensure that we will actually capture the new types;
561 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
562 // Take for example the following scenario:
563 // - we capture the inline cache in one run
564 // - the next run, we deoptimize because we miss a type check, but the method
565 // never becomes hot again
566 // In this case, the inline cache will not be updated in the profile and the AOT code
567 // will keep deoptimizing.
568 // Another scenario is if we use profile compilation for a process which is not allowed
569 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
570 // rest of the lifetime.
571 // TODO(calin):
572 // This is a compromise because we will most likely never update the inline cache
573 // in the profile (unless there's another reason to deopt). So we might be stuck with
574 // a sub-optimal inline cache.
575 // We could be smarter when capturing inline caches to mitigate this.
576 // (e.g. by having different thresholds for new and old methods).
577 //
578 // For OSR:
579 // We may come from the interpreter and it may have seen different receiver types.
580 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
581}
Calin Juravle13439f02017-02-21 01:17:21 -0800582bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
583 HInvoke* invoke_instruction,
584 ArtMethod* resolved_method)
585 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700586 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
587 return false;
588 }
589
Calin Juravle13439f02017-02-21 01:17:21 -0800590 StackHandleScope<1> hs(Thread::Current());
591 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
Nicolas Geoffray7417ce92019-02-01 10:52:42 +0000592 // The Zygote JIT compiles based on a profile, so we shouldn't use runtime inline caches
593 // for it.
594 InlineCacheType inline_cache_type =
595 (Runtime::Current()->IsAotCompiler() || Runtime::Current()->IsZygote())
596 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
597 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
Calin Juravle13439f02017-02-21 01:17:21 -0800598
599 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000600 case kInlineCacheNoData: {
601 LOG_FAIL_NO_STAT()
602 << "Interface or virtual call to "
603 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
604 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800605 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000606 }
Calin Juravle13439f02017-02-21 01:17:21 -0800607
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000608 case kInlineCacheUninitialized: {
609 LOG_FAIL_NO_STAT()
610 << "Interface or virtual call to "
611 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
612 << " is not hit and not inlined";
613 return false;
614 }
615
616 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000617 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700618 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800619 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000620 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800621 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000622 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000623 }
Calin Juravle13439f02017-02-21 01:17:21 -0800624
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000625 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000626 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800627 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000628 }
Calin Juravle13439f02017-02-21 01:17:21 -0800629
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000630 case kInlineCacheMegamorphic: {
631 LOG_FAIL_NO_STAT()
632 << "Interface or virtual call to "
633 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
634 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000635 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800636 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000637 }
Calin Juravle13439f02017-02-21 01:17:21 -0800638
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000639 case kInlineCacheMissingTypes: {
640 LOG_FAIL_NO_STAT()
641 << "Interface or virtual call to "
642 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
643 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800644 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000645 }
Calin Juravle13439f02017-02-21 01:17:21 -0800646 }
647 UNREACHABLE();
648}
649
650HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
651 HInvoke* invoke_instruction,
652 StackHandleScope<1>* hs,
653 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
654 REQUIRES_SHARED(Locks::mutator_lock_) {
655 DCHECK(Runtime::Current()->UseJitCompilation());
656
657 ArtMethod* caller = graph_->GetArtMethod();
658 // Under JIT, we should always know the caller.
659 DCHECK(caller != nullptr);
660 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
661 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
662
663 if (profiling_info == nullptr) {
664 return kInlineCacheNoData;
665 }
666
667 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
668 if (inline_cache->Get() == nullptr) {
669 // We can't extract any data if we failed to allocate;
670 return kInlineCacheNoData;
671 } else {
672 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
673 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
674 *inline_cache);
675 return GetInlineCacheType(*inline_cache);
676 }
677}
678
679HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
680 const DexFile& caller_dex_file,
681 HInvoke* invoke_instruction,
682 StackHandleScope<1>* hs,
683 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
684 REQUIRES_SHARED(Locks::mutator_lock_) {
685 DCHECK(Runtime::Current()->IsAotCompiler());
Vladimir Marko1a2a5cd2018-11-07 15:39:48 +0000686 const ProfileCompilationInfo* pci = codegen_->GetCompilerOptions().GetProfileCompilationInfo();
Calin Juravle13439f02017-02-21 01:17:21 -0800687 if (pci == nullptr) {
688 return kInlineCacheNoData;
689 }
690
Calin Juravlecc3171a2017-05-19 16:47:53 -0700691 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
692 pci->GetMethod(caller_dex_file.GetLocation(),
693 caller_dex_file.GetLocationChecksum(),
694 caller_compilation_unit_.GetDexMethodIndex());
695 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800696 return kInlineCacheNoData; // no profile information for this invocation.
697 }
698
699 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
700 if (inline_cache == nullptr) {
701 // We can't extract any data if we failed to allocate;
702 return kInlineCacheNoData;
703 } else {
704 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700705 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800706 *inline_cache);
707 }
708}
709
710HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
711 const HInvoke* invoke_instruction,
712 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
713 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
714 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700715 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
716 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800717 return kInlineCacheUninitialized;
718 }
719
720 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
721
722 if (dex_pc_data.is_missing_types) {
723 return kInlineCacheMissingTypes;
724 }
725 if (dex_pc_data.is_megamorphic) {
726 return kInlineCacheMegamorphic;
727 }
728
729 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
730 Thread* self = Thread::Current();
731 // We need to resolve the class relative to the containing dex file.
732 // So first, build a mapping from the index of dex file in the profile to
733 // its dex cache. This will avoid repeating the lookup when walking over
734 // the inline cache types.
735 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
736 offline_profile.dex_references.size());
737 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
738 bool found = false;
Vladimir Marko213ee2d2018-06-22 11:56:34 +0100739 for (const DexFile* dex_file : codegen_->GetCompilerOptions().GetDexFilesForOatFile()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800740 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
741 dex_profile_index_to_dex_cache[i] =
742 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
743 found = true;
744 }
745 }
746 if (!found) {
747 VLOG(compiler) << "Could not find profiled dex file: "
748 << offline_profile.dex_references[i].dex_location;
749 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100750 }
751 }
752
Calin Juravle13439f02017-02-21 01:17:21 -0800753 // Walk over the classes and resolve them. If we cannot find a type we return
754 // kInlineCacheMissingTypes.
755 int ic_index = 0;
756 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
757 ObjPtr<mirror::DexCache> dex_cache =
758 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
759 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700760
761 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
762 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
763 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
764 return kInlineCacheNoData;
765 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000766 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000767 class_ref.type_index,
768 dex_cache,
769 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800770 if (clazz != nullptr) {
771 inline_cache->Set(ic_index++, clazz);
772 } else {
773 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
774 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
775 invoke_instruction->GetDexMethodIndex()) << " : "
776 << caller_compilation_unit_
777 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
778 return kInlineCacheMissingTypes;
779 }
780 }
781 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100782}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000783
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000784HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
785 HInstruction* receiver,
786 uint32_t dex_pc) const {
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100787 ArtField* field = GetClassRoot<mirror::Object>(class_linker)->GetInstanceField(0);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000788 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100789 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000790 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000791 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100792 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000793 field->GetOffset(),
794 field->IsVolatile(),
795 field->GetDexFieldIndex(),
796 field->GetDeclaringClass()->GetDexClassDefIndex(),
797 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000798 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000799 // The class of a field is effectively final, and does not have any memory dependencies.
800 result->SetSideEffects(SideEffects::None());
801 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000802}
803
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000804static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
805 ArtMethod* resolved_method,
806 HInstruction* invoke_instruction,
807 PointerSize pointer_size)
808 REQUIRES_SHARED(Locks::mutator_lock_) {
809 if (Runtime::Current()->IsAotCompiler()) {
810 // We can get unrelated types when working with profiles (corruption,
811 // systme updates, or anyone can write to it). So first check if the class
812 // actually implements the declaring class of the method that is being
813 // called in bytecode.
814 // Note: the lookup methods used below require to have assignable types.
815 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
816 return nullptr;
817 }
818 }
819
820 if (invoke_instruction->IsInvokeInterface()) {
821 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
822 } else {
823 DCHECK(invoke_instruction->IsInvokeVirtual());
824 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
825 }
826 DCHECK(resolved_method != nullptr);
827 return resolved_method;
828}
829
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100830bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
831 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000832 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000833 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
834 << invoke_instruction->DebugName();
835
Andreas Gampea5b09a62016-11-17 15:21:22 -0800836 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000837 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800838 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000839 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000840 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
841 << " from inline cache is not inlined because its class is not"
842 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100843 return false;
844 }
845
846 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700847 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000848 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
849 resolved_method = ResolveMethodFromInlineCache(
850 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
851
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000852 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000853 if (resolved_method == nullptr) {
854 // Bogus AOT profile, bail.
855 DCHECK(Runtime::Current()->IsAotCompiler());
856 return false;
857 }
858
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100859 HInstruction* receiver = invoke_instruction->InputAt(0);
860 HInstruction* cursor = invoke_instruction->GetPrevious();
861 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700862 if (!TryInlineAndReplace(invoke_instruction,
863 resolved_method,
Andreas Gampe3db70682018-12-26 15:12:03 -0800864 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact= */ true),
865 /* do_rtp= */ false,
866 /* cha_devirtualize= */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100867 return false;
868 }
869
870 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000871 AddTypeGuard(receiver,
872 cursor,
873 bb_cursor,
874 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000875 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000876 invoke_instruction,
Andreas Gampe3db70682018-12-26 15:12:03 -0800877 /* with_deoptimization= */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100878
879 // Run type propagation to get the guard typed, and eventually propagate the
880 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000881 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000882 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000883 outer_compilation_unit_.GetDexCache(),
884 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -0800885 /* is_first_run= */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100886 rtp_fixup.Run();
887
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000888 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100889 return true;
890}
891
Mingyao Yang063fc772016-08-02 11:02:54 -0700892void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
893 uint32_t dex_pc,
894 HInstruction* cursor,
895 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100896 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
897 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
898 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700899 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100900 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
901 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700902
903 if (cursor != nullptr) {
904 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
905 } else {
906 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
907 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800908 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
909 bb_cursor->InsertInstructionAfter(deopt, compare);
910
911 // Add receiver as input to aid CHA guard optimization later.
912 deopt_flag->AddInput(invoke_instruction->InputAt(0));
913 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700914 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800915 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700916}
917
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000918HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
919 HInstruction* cursor,
920 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800921 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000922 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000923 HInstruction* invoke_instruction,
924 bool with_deoptimization) {
925 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
926 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
927 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000928 if (cursor != nullptr) {
929 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
930 } else {
931 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
932 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000933
934 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700935 bool is_referrer;
936 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
937 if (outermost_art_method == nullptr) {
938 DCHECK(Runtime::Current()->IsAotCompiler());
939 // We are in AOT mode and we don't have an ART method to determine
940 // if the inlined method belongs to the referrer. Assume it doesn't.
941 is_referrer = false;
942 } else {
943 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
944 }
945
Nicolas Geoffray56876342016-12-16 16:09:08 +0000946 // Note that we will just compare the classes, so we don't need Java semantics access checks.
947 // Note that the type index and the dex file are relative to the method this type guard is
948 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100949 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
950 class_index,
951 caller_dex_file,
952 klass,
953 is_referrer,
954 invoke_instruction->GetDexPc(),
Andreas Gampe3db70682018-12-26 15:12:03 -0800955 /* needs_access_check= */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000956 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Vladimir Markobb089b62018-06-28 17:30:16 +0100957 load_class, codegen_, caller_compilation_unit_);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000958 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
959 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000960 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000961 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000962 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800963 // In AOT mode, we will most likely load the class from BSS, which will involve a call
964 // to the runtime. In this case, the load instruction will need an environment so copy
965 // it from the invoke instruction.
966 if (load_class->NeedsEnvironment()) {
967 DCHECK(Runtime::Current()->IsAotCompiler());
968 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
969 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000970
Vladimir Markoca6fff82017-10-03 14:49:14 +0100971 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000972 bb_cursor->InsertInstructionAfter(compare, load_class);
973 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100974 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
975 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000976 compare,
977 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100978 Runtime::Current()->IsAotCompiler()
979 ? DeoptimizationKind::kAotInlineCache
980 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000981 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000982 bb_cursor->InsertInstructionAfter(deoptimize, compare);
983 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000984 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
985 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
986 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000987 }
988 return compare;
989}
990
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000991bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100992 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000993 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000994 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
995 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000996
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000997 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000998 return true;
999 }
1000
1001 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001002 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001003
1004 bool all_targets_inlined = true;
1005 bool one_target_inlined = false;
1006 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001007 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001008 break;
1009 }
1010 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001011
1012 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001013 method = ResolveMethodFromInlineCache(
1014 handle, resolved_method, invoke_instruction, pointer_size);
1015 if (method == nullptr) {
1016 DCHECK(Runtime::Current()->IsAotCompiler());
1017 // AOT profile is bogus. This loop expects to iterate over all entries,
1018 // so just just continue.
1019 all_targets_inlined = false;
1020 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001021 }
1022
1023 HInstruction* receiver = invoke_instruction->InputAt(0);
1024 HInstruction* cursor = invoke_instruction->GetPrevious();
1025 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1026
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001027 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001028 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001029 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -08001030 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001031 !TryBuildAndInline(invoke_instruction,
1032 method,
Andreas Gampe3db70682018-12-26 15:12:03 -08001033 ReferenceTypeInfo::Create(handle, /* is_exact= */ true),
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001034 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001035 all_targets_inlined = false;
1036 } else {
1037 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001038
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001039 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
1040 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001041
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001042 // If we have inlined all targets before, and this receiver is the last seen,
1043 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001044 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1045 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001046 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001047 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001048
Nicolas Geoffray56876342016-12-16 16:09:08 +00001049 HInstruction* compare = AddTypeGuard(receiver,
1050 cursor,
1051 bb_cursor,
1052 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001053 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001054 invoke_instruction,
1055 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001056 if (deoptimize) {
1057 if (return_replacement != nullptr) {
1058 invoke_instruction->ReplaceWith(return_replacement);
1059 }
1060 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1061 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001062 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001063 break;
1064 } else {
1065 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1066 }
1067 }
1068 }
1069
1070 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001071 LOG_FAIL_NO_STAT()
1072 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1073 << " from inline cache is not inlined because none"
1074 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001075 return false;
1076 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001077
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001078 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001079
1080 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001081 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001082 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001083 outer_compilation_unit_.GetDexCache(),
1084 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001085 /* is_first_run= */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001086 rtp_fixup.Run();
1087 return true;
1088}
1089
1090void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1091 HInstruction* return_replacement,
1092 HInstruction* invoke_instruction) {
1093 uint32_t dex_pc = invoke_instruction->GetDexPc();
1094 HBasicBlock* cursor_block = compare->GetBlock();
1095 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001096 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001097
1098 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1099 // and the returned block is the start of the then branch (that could contain multiple blocks).
1100 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1101
1102 // Split the block containing the invoke before and after the invoke. The returned block
1103 // of the split before will contain the invoke and will be the otherwise branch of
1104 // the diamond. The returned block of the split after will be the merge block
1105 // of the diamond.
1106 HBasicBlock* end_then = invoke_instruction->GetBlock();
1107 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1108 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1109
1110 // If the methods we are inlining return a value, we create a phi in the merge block
1111 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1112 if (return_replacement != nullptr) {
1113 HPhi* phi = new (allocator) HPhi(
1114 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1115 merge->AddPhi(phi);
1116 invoke_instruction->ReplaceWith(phi);
1117 phi->AddInput(return_replacement);
1118 phi->AddInput(invoke_instruction);
1119 }
1120
1121 // Add the control flow instructions.
1122 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1123 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1124 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1125
1126 // Add the newly created blocks to the graph.
1127 graph_->AddBlock(then);
1128 graph_->AddBlock(otherwise);
1129 graph_->AddBlock(merge);
1130
1131 // Set up successor (and implictly predecessor) relations.
1132 cursor_block->AddSuccessor(otherwise);
1133 cursor_block->AddSuccessor(then);
1134 end_then->AddSuccessor(merge);
1135 otherwise->AddSuccessor(merge);
1136
1137 // Set up dominance information.
1138 then->SetDominator(cursor_block);
1139 cursor_block->AddDominatedBlock(then);
1140 otherwise->SetDominator(cursor_block);
1141 cursor_block->AddDominatedBlock(otherwise);
1142 merge->SetDominator(cursor_block);
1143 cursor_block->AddDominatedBlock(merge);
1144
1145 // Update the revert post order.
1146 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1147 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1148 graph_->reverse_post_order_[++index] = then;
1149 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1150 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1151 graph_->reverse_post_order_[++index] = otherwise;
1152 graph_->reverse_post_order_[++index] = merge;
1153
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001154
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001155 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001156 then, original_invoke_block, /* replace_if_back_edge= */ false);
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001157 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001158 otherwise, original_invoke_block, /* replace_if_back_edge= */ false);
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001159
1160 // In case the original invoke location was a back edge, we need to update
1161 // the loop to now have the merge block as a back edge.
1162 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001163 merge, original_invoke_block, /* replace_if_back_edge= */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001164}
1165
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001166bool HInliner::TryInlinePolymorphicCallToSameTarget(
1167 HInvoke* invoke_instruction,
1168 ArtMethod* resolved_method,
1169 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001170 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001171 if (!Runtime::Current()->UseJitCompilation()) {
1172 return false;
1173 }
1174
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001175 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001176 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001177
1178 DCHECK(resolved_method != nullptr);
1179 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001180 size_t method_index = invoke_instruction->IsInvokeVirtual()
1181 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1182 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1183
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001184 // Check whether we are actually calling the same method among
1185 // the different types seen.
1186 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001187 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001188 break;
1189 }
1190 ArtMethod* new_method = nullptr;
1191 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001192 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001193 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001194 if (new_method->IsRuntimeMethod()) {
1195 // Bail out as soon as we see a conflict trampoline in one of the target's
1196 // interface table.
1197 return false;
1198 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001199 } else {
1200 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001201 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001202 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001203 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001204 if (actual_method == nullptr) {
1205 actual_method = new_method;
1206 } else if (actual_method != new_method) {
1207 // Different methods, bailout.
1208 return false;
1209 }
1210 }
1211
1212 HInstruction* receiver = invoke_instruction->InputAt(0);
1213 HInstruction* cursor = invoke_instruction->GetPrevious();
1214 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1215
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001216 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001217 if (!TryBuildAndInline(invoke_instruction,
1218 actual_method,
1219 ReferenceTypeInfo::CreateInvalid(),
1220 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001221 return false;
1222 }
1223
1224 // We successfully inlined, now add a guard.
1225 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1226 class_linker, receiver, invoke_instruction->GetDexPc());
1227
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001228 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1229 ? DataType::Type::kInt64
1230 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001231 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001232 receiver_class,
1233 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001234 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1235 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001236 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001237 invoke_instruction->GetDexPc());
1238
1239 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001240 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001241 constant = graph_->GetLongConstant(
1242 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1243 } else {
1244 constant = graph_->GetIntConstant(
1245 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1246 }
1247
Vladimir Markoca6fff82017-10-03 14:49:14 +01001248 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001249 if (cursor != nullptr) {
1250 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1251 } else {
1252 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1253 }
1254 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1255 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001256
1257 if (outermost_graph_->IsCompilingOsr()) {
1258 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1259 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001260 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1261 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001262 compare,
1263 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001264 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001265 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001266 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1267 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1268 if (return_replacement != nullptr) {
1269 invoke_instruction->ReplaceWith(return_replacement);
1270 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001271 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001272 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001273 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001274 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001275
1276 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001277 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001278 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001279 outer_compilation_unit_.GetDexCache(),
1280 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001281 /* is_first_run= */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001282 rtp_fixup.Run();
1283
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001284 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001285
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001286 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001287 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001288}
1289
Mingyao Yang063fc772016-08-02 11:02:54 -07001290bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1291 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001292 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001293 bool do_rtp,
1294 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001295 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001296 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001297 uint32_t dex_pc = invoke_instruction->GetDexPc();
1298 HInstruction* cursor = invoke_instruction->GetPrevious();
1299 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001300 bool should_remove_invoke_instruction = false;
1301
1302 // If invoke_instruction is devirtualized to a different method, give intrinsics
1303 // another chance before we try to inline it.
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001304 if (invoke_instruction->GetResolvedMethod() != method && method->IsIntrinsic()) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001305 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1306 if (invoke_instruction->IsInvokeInterface()) {
1307 // We don't intrinsify an invoke-interface directly.
1308 // Replace the invoke-interface with an invoke-virtual.
1309 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1310 graph_->GetAllocator(),
1311 invoke_instruction->GetNumberOfArguments(),
1312 invoke_instruction->GetType(),
1313 invoke_instruction->GetDexPc(),
1314 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1315 method,
1316 method->GetMethodIndex());
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001317 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001318 HInputsRef inputs = invoke_instruction->GetInputs();
1319 for (size_t index = 0; index != inputs.size(); ++index) {
1320 new_invoke->SetArgumentAt(index, inputs[index]);
1321 }
1322 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1323 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1324 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1325 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1326 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001327 return_replacement = new_invoke;
1328 // invoke_instruction is replaced with new_invoke.
1329 should_remove_invoke_instruction = true;
1330 } else {
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001331 invoke_instruction->SetResolvedMethod(method);
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001332 }
1333 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001334 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001335 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001336 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1337 // better than an invoke-interface because:
1338 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1339 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1340 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001341
1342 if (method->IsDefault() && !method->IsCopied()) {
1343 // Changing to invoke-virtual cannot be done on an original default method
1344 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1345 // always uses a method in the iftable which is never an original default
1346 // method.
1347 // On the other hand, inlining an original default method by CHA is fine.
1348 DCHECK(cha_devirtualize);
1349 return false;
1350 }
1351
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001352 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001353 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001354 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001355 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001356 return false;
1357 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001358 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1359 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001360 invoke_instruction->GetNumberOfArguments(),
1361 invoke_instruction->GetType(),
1362 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001363 dex_method_index,
1364 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001365 method->GetMethodIndex());
1366 HInputsRef inputs = invoke_instruction->GetInputs();
1367 for (size_t index = 0; index != inputs.size(); ++index) {
1368 new_invoke->SetArgumentAt(index, inputs[index]);
1369 }
1370 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1371 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001372 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001373 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1374 }
1375 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001376 // invoke_instruction is replaced with new_invoke.
1377 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001378 } else {
1379 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1380 // compiler driver.
1381 return false;
1382 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001383 } else {
1384 // invoke_instruction is inlined.
1385 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001386 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001387
Mingyao Yang063fc772016-08-02 11:02:54 -07001388 if (cha_devirtualize) {
1389 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1390 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001391 if (return_replacement != nullptr) {
1392 invoke_instruction->ReplaceWith(return_replacement);
1393 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001394 if (should_remove_invoke_instruction) {
1395 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1396 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001397 FixUpReturnReferenceType(method, return_replacement);
1398 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1399 // Actual return value has a more specific type than the method's declared
1400 // return type. Run RTP again on the outer graph to propagate it.
1401 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001402 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001403 outer_compilation_unit_.GetDexCache(),
1404 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001405 /* is_first_run= */ false).Run();
David Brazdil94ab38f2016-06-21 17:48:19 +01001406 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001407 return true;
1408}
1409
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001410size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1411 const HInliner* current = this;
1412 size_t count = 0;
1413 do {
1414 if (current->graph_->GetArtMethod() == method) {
1415 ++count;
1416 }
1417 current = current->parent_;
1418 } while (current != nullptr);
1419 return count;
1420}
1421
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001422static inline bool MayInline(const CompilerOptions& compiler_options,
1423 const DexFile& inlined_from,
1424 const DexFile& inlined_into) {
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001425 // We're not allowed to inline across dex files if we're the no-inline-from dex file.
1426 if (!IsSameDexFile(inlined_from, inlined_into) &&
1427 ContainsElement(compiler_options.GetNoInlineFromDexFile(), &inlined_from)) {
1428 return false;
1429 }
1430
1431 return true;
1432}
1433
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001434bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1435 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001436 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001437 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001438 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001439 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001440 << "Method " << method->PrettyMethod()
1441 << " is not inlined because of unimplemented inline support for proxy methods.";
1442 return false;
1443 }
1444
1445 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001446 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001447 << "Method "
1448 << method->PrettyMethod()
1449 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001450 return false;
1451 }
1452
Jeff Haodcdc85b2015-12-04 14:06:18 -08001453 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1454 // dex file here (though the transitivity of an inline chain would allow checking the calller).
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001455 if (!MayInline(codegen_->GetCompilerOptions(),
1456 *method->GetDexFile(),
1457 *outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001458 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001459 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1460 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001461 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001462 return true;
1463 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001464 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001465 << "Won't inline " << method->PrettyMethod() << " in "
1466 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1467 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1468 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001469 return false;
1470 }
1471
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001472 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1473
David Sehr0225f8e2018-01-31 08:52:24 +00001474 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001475
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001476 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001477 LOG_FAIL_NO_STAT()
1478 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001479 return false;
1480 }
1481
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001482 size_t inline_max_code_units = codegen_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001483 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001484 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001485 << "Method " << method->PrettyMethod()
1486 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001487 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001488 << " > "
1489 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001490 return false;
1491 }
1492
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001493 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001494 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001495 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001496 return false;
1497 }
1498
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001499 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001500 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001501 << "Method " << method->PrettyMethod()
1502 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Aart Bik897df032018-02-07 13:29:11 -08001503 return false;
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001504 }
1505
Vladimir Marko2afaff72018-11-30 17:01:50 +00001506 if (IsMethodUnverified(codegen_->GetCompilerOptions(), method)) {
Aart Bik2c148f02018-02-02 14:30:35 -08001507 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
1508 << "Method " << method->PrettyMethod()
1509 << " couldn't be verified, so it cannot be inlined";
1510 return false;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001511 }
1512
Roland Levillain4c0eb422015-04-24 16:43:49 +01001513 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1514 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1515 // Case of a static method that cannot be inlined because it implicitly
1516 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001517 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1518 << "Method " << method->PrettyMethod()
1519 << " is not inlined because it is static and requires a clinit"
1520 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001521 return false;
1522 }
1523
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001524 if (!TryBuildAndInlineHelper(
1525 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001526 return false;
1527 }
1528
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001529 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001530 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001531 return true;
1532}
1533
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001534static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1535 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001536 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001537 size_t input_index = 0;
1538 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1539 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001540 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001541 ++i;
1542 DCHECK_NE(i, arg_vreg_index);
1543 }
1544 }
1545 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1546 return invoke_instruction->InputAt(input_index);
1547}
1548
1549// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1550bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1551 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001552 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001553 InlineMethod inline_method;
1554 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1555 return false;
1556 }
1557
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001558 switch (inline_method.opcode) {
1559 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001560 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001561 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001562 break;
1563 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001564 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1565 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001566 break;
1567 case kInlineOpNonWideConst:
1568 if (resolved_method->GetShorty()[0] == 'L') {
1569 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001570 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001571 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001572 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001573 }
1574 break;
1575 case kInlineOpIGet: {
1576 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1577 if (data.method_is_static || data.object_arg != 0u) {
1578 // TODO: Needs null check.
1579 return false;
1580 }
1581 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001582 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001583 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1584 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1585 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001586 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001587 break;
1588 }
1589 case kInlineOpIPut: {
1590 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1591 if (data.method_is_static || data.object_arg != 0u) {
1592 // TODO: Needs null check.
1593 return false;
1594 }
1595 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1596 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001597 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001598 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1599 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1600 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1601 if (data.return_arg_plus1 != 0u) {
1602 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001603 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001604 }
1605 break;
1606 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001607 case kInlineOpConstructor: {
1608 const InlineConstructorData& data = inline_method.d.constructor_data;
1609 // Get the indexes to arrays for easier processing.
1610 uint16_t iput_field_indexes[] = {
1611 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1612 };
1613 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1614 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1615 // Count valid field indexes.
1616 size_t number_of_iputs = 0u;
1617 while (number_of_iputs != arraysize(iput_field_indexes) &&
1618 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1619 // Check that there are no duplicate valid field indexes.
1620 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1621 iput_field_indexes + arraysize(iput_field_indexes),
1622 iput_field_indexes[number_of_iputs]));
1623 ++number_of_iputs;
1624 }
1625 // Check that there are no valid field indexes in the rest of the array.
1626 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1627 iput_field_indexes + arraysize(iput_field_indexes),
1628 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1629
1630 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Andreas Gampe3db70682018-12-26 15:12:03 -08001631 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction,
1632 /* arg_vreg_index= */ 0u);
Vladimir Marko354efa62016-02-04 19:46:56 +00001633 bool needs_constructor_barrier = false;
1634 for (size_t i = 0; i != number_of_iputs; ++i) {
1635 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001636 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001637 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001638 bool is_final;
1639 HInstanceFieldSet* iput =
1640 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001641 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1642
1643 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001644 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001645 needs_constructor_barrier = true;
1646 }
1647 }
1648 }
1649 if (needs_constructor_barrier) {
Vladimir Marko1a2a5cd2018-11-07 15:39:48 +00001650 // See DexCompilationUnit::RequiresConstructorBarrier for more details.
Igor Murashkind01745e2017-04-05 16:40:31 -07001651 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1652
1653 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001654 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001655 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1656 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001657 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001658 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001659 break;
1660 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001661 default:
1662 LOG(FATAL) << "UNREACHABLE";
1663 UNREACHABLE();
1664 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001665 return true;
1666}
1667
Vladimir Markof44d36c2017-03-14 14:18:46 +00001668HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1669 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001670 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001671 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001672 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1673 ArtField* resolved_field =
Andreas Gampe3db70682018-12-26 15:12:03 -08001674 class_linker->LookupResolvedField(field_index, referrer, /* is_static= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001675 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001676 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001677 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001678 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001679 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001680 resolved_field->GetOffset(),
1681 resolved_field->IsVolatile(),
1682 field_index,
1683 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001684 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001685 // Read barrier generates a runtime call in slow path and we need a valid
1686 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
Andreas Gampe3db70682018-12-26 15:12:03 -08001687 /* dex_pc= */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001688 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001689 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001690 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001691 ReferenceTypePropagation rtp(graph_,
1692 outer_compilation_unit_.GetClassLoader(),
1693 dex_cache,
1694 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001695 /* is_first_run= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001696 rtp.Visit(iget);
1697 }
1698 return iget;
1699}
1700
Vladimir Markof44d36c2017-03-14 14:18:46 +00001701HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1702 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001703 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001704 HInstruction* value,
1705 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001706 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001707 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1708 ArtField* resolved_field =
Andreas Gampe3db70682018-12-26 15:12:03 -08001709 class_linker->LookupResolvedField(field_index, referrer, /* is_static= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001710 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001711 if (is_final != nullptr) {
1712 // This information is needed only for constructors.
1713 DCHECK(referrer->IsConstructor());
1714 *is_final = resolved_field->IsFinal();
1715 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001716 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001717 obj,
1718 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001719 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001720 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001721 resolved_field->GetOffset(),
1722 resolved_field->IsVolatile(),
1723 field_index,
1724 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001725 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001726 // Read barrier generates a runtime call in slow path and we need a valid
1727 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
Andreas Gampe3db70682018-12-26 15:12:03 -08001728 /* dex_pc= */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001729 return iput;
1730}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001731
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001732template <typename T>
1733static inline Handle<T> NewHandleIfDifferent(T* object,
1734 Handle<T> hint,
1735 VariableSizedHandleScope* handles)
1736 REQUIRES_SHARED(Locks::mutator_lock_) {
1737 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1738}
1739
Vladimir Marko6be1dbd2018-11-13 13:09:51 +00001740static bool CanEncodeInlinedMethodInStackMap(const DexFile& caller_dex_file, ArtMethod* callee)
1741 REQUIRES_SHARED(Locks::mutator_lock_) {
1742 if (!Runtime::Current()->IsAotCompiler()) {
1743 // JIT can always encode methods in stack maps.
1744 return true;
1745 }
1746 if (IsSameDexFile(caller_dex_file, *callee->GetDexFile())) {
1747 return true;
1748 }
1749 // TODO(ngeoffray): Support more AOT cases for inlining:
1750 // - methods in multidex
1751 // - methods in boot image for on-device non-PIC compilation.
1752 return false;
1753}
1754
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001755bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1756 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001757 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001758 bool same_dex_file,
1759 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001760 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001761 ScopedObjectAccess soa(Thread::Current());
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08001762 const dex::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001763 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1764 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001765 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001766 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001767 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1768 caller_compilation_unit_.GetDexCache(),
1769 handles_);
1770 Handle<mirror::ClassLoader> class_loader =
1771 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1772 caller_compilation_unit_.GetClassLoader(),
1773 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001774
Vladimir Markoa2c211c2018-11-01 09:50:52 +00001775 Handle<mirror::Class> compiling_class = handles_->NewHandle(resolved_method->GetDeclaringClass());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001776 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001777 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001778 class_linker,
1779 callee_dex_file,
1780 code_item,
1781 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1782 method_index,
1783 resolved_method->GetAccessFlags(),
Andreas Gampe3db70682018-12-26 15:12:03 -08001784 /* verified_method= */ nullptr,
Vladimir Markoa2c211c2018-11-01 09:50:52 +00001785 dex_cache,
1786 compiling_class);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001787
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001788 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001789 if (invoke_type == kInterface) {
1790 // We have statically resolved the dispatch. To please the class linker
1791 // at runtime, we change this call as if it was a virtual call.
1792 invoke_type = kVirtual;
1793 }
David Brazdil3f523062016-02-29 16:53:33 +00001794
Hans Boehm206348c2018-12-05 11:11:33 -08001795 bool caller_dead_reference_safe = graph_->IsDeadReferenceSafe();
1796 const dex::ClassDef& callee_class = resolved_method->GetClassDef();
1797 // MethodContainsRSensitiveAccess is currently slow, but HasDeadReferenceSafeAnnotation()
1798 // is currently rarely true.
1799 bool callee_dead_reference_safe =
1800 annotations::HasDeadReferenceSafeAnnotation(callee_dex_file, callee_class)
1801 && !annotations::MethodContainsRSensitiveAccess(callee_dex_file, callee_class, method_index);
1802
David Brazdil3f523062016-02-29 16:53:33 +00001803 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001804 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1805 graph_->GetAllocator(),
1806 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001807 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001808 method_index,
Vladimir Markoa0431112018-06-25 09:32:54 +01001809 codegen_->GetCompilerOptions().GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001810 invoke_type,
Hans Boehm206348c2018-12-05 11:11:33 -08001811 callee_dead_reference_safe,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001812 graph_->IsDebuggable(),
Andreas Gampe3db70682018-12-26 15:12:03 -08001813 /* osr= */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001814 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001815 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001816
Vladimir Marko438709f2017-02-23 18:56:13 +00001817 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001818 // of on the stack, as Clang might produce a stack frame too large
1819 // for this function, that would not fit the requirements of the
1820 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001821 if (stats_ != nullptr) {
1822 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1823 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001824 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001825 inline_stats_ = new (storage) OptimizingCompilerStats;
1826 } else {
1827 inline_stats_->Reset();
1828 }
1829 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001830 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001831 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001832 &dex_compilation_unit,
1833 &outer_compilation_unit_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001834 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001835 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001836 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001837 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001838
David Brazdildee58d62016-04-07 09:54:26 +00001839 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001840 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001841 << "Method " << callee_dex_file.PrettyMethod(method_index)
1842 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001843 return false;
1844 }
1845
Vladimir Markoa0431112018-06-25 09:32:54 +01001846 if (!RegisterAllocator::CanAllocateRegistersFor(
1847 *callee_graph, codegen_->GetCompilerOptions().GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001848 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001849 << "Method " << callee_dex_file.PrettyMethod(method_index)
1850 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001851 return false;
1852 }
1853
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001854 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001855 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001856 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1857 !instructions.Done();
1858 instructions.Advance()) {
1859 HInstruction* current = instructions.Current();
1860 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001861 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001862 if (argument->IsNullConstant()) {
1863 current->ReplaceWith(callee_graph->GetNullConstant());
1864 } else if (argument->IsIntConstant()) {
1865 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1866 } else if (argument->IsLongConstant()) {
1867 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1868 } else if (argument->IsFloatConstant()) {
1869 current->ReplaceWith(
1870 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1871 } else if (argument->IsDoubleConstant()) {
1872 current->ReplaceWith(
1873 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001874 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001875 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1876 run_rtp = true;
1877 current->SetReferenceTypeInfo(receiver_type);
1878 } else {
1879 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1880 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001881 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1882 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001883 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001884 }
1885 }
1886
David Brazdil94ab38f2016-06-21 17:48:19 +01001887 // We have replaced formal arguments with actual arguments. If actual types
1888 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001889 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001890 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001891 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001892 dex_compilation_unit.GetDexCache(),
1893 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001894 /* is_first_run= */ false).Run();
David Brazdil94ab38f2016-06-21 17:48:19 +01001895 }
1896
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001897 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001898
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001899 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1900 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001901 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001902 << "Method " << callee_dex_file.PrettyMethod(method_index)
1903 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001904 return false;
1905 }
1906
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001907 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001908 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1909 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001910 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1911 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001912 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001913 << "Method " << callee_dex_file.PrettyMethod(method_index)
1914 << " could not be inlined because one branch always throws and"
1915 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001916 return false;
1917 } else if (graph_->GetExitBlock() == nullptr) {
1918 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001919 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001920 << "Method " << callee_dex_file.PrettyMethod(method_index)
1921 << " could not be inlined because one branch always throws and"
1922 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001923 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001924 } else if (graph_->HasIrreducibleLoops()) {
1925 // TODO(ngeoffray): Support re-computing loop information to graphs with
1926 // irreducible loops?
1927 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1928 << " could not be inlined because one branch always throws and"
1929 << " caller has irreducible loops";
1930 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001931 }
1932 } else {
1933 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001934 }
1935 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001936
1937 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001938 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001939 << "Method " << callee_dex_file.PrettyMethod(method_index)
1940 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001941 return false;
1942 }
1943
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001944 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001945 // Skip the entry block, it does not contain instructions that prevent inlining.
1946 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001947 if (block->IsLoopHeader()) {
1948 if (block->GetLoopInformation()->IsIrreducible()) {
1949 // Don't inline methods with irreducible loops, they could prevent some
1950 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001951 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001952 << "Method " << callee_dex_file.PrettyMethod(method_index)
1953 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001954 return false;
1955 }
1956 if (!block->GetLoopInformation()->HasExitEdge()) {
1957 // Don't inline methods with loops without exit, since they cause the
1958 // loop information to be computed incorrectly when updating after
1959 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001960 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001961 << "Method " << callee_dex_file.PrettyMethod(method_index)
1962 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001963 return false;
1964 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001965 }
1966
1967 for (HInstructionIterator instr_it(block->GetInstructions());
1968 !instr_it.Done();
1969 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001970 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001971 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001972 << "Method " << callee_dex_file.PrettyMethod(method_index)
1973 << " is not inlined because the outer method has reached"
1974 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001975 return false;
1976 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001977 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001978 if (current->NeedsEnvironment() &&
1979 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001980 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001981 << "Method " << callee_dex_file.PrettyMethod(method_index)
1982 << " is not inlined because its caller has reached"
1983 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001984 return false;
1985 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001986
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001987 if (current->NeedsEnvironment() &&
1988 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1989 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001990 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001991 << "Method " << callee_dex_file.PrettyMethod(method_index)
1992 << " could not be inlined because " << current->DebugName()
1993 << " needs an environment, is in a different dex file"
1994 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001995 return false;
1996 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001997
Vladimir Markodc151b22015-10-15 18:02:30 +01001998 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001999 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002000 << "Method " << callee_dex_file.PrettyMethod(method_index)
2001 << " could not be inlined because " << current->DebugName()
2002 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002003 return false;
2004 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002005
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002006 if (current->IsUnresolvedStaticFieldGet() ||
2007 current->IsUnresolvedInstanceFieldGet() ||
2008 current->IsUnresolvedStaticFieldSet() ||
2009 current->IsUnresolvedInstanceFieldSet()) {
2010 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00002011 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002012 << "Method " << callee_dex_file.PrettyMethod(method_index)
2013 << " could not be inlined because it is using an unresolved"
2014 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002015 return false;
2016 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002017 }
2018 }
David Brazdil3f523062016-02-29 16:53:33 +00002019 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
2020 << "No instructions can be added to the outer graph while inner graph is being built";
2021
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002022 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00002023 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
2024 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00002025 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002026 // Update our budget for other inlining attempts in `caller_graph`.
2027 total_number_of_instructions_ += number_of_instructions;
2028 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00002029
2030 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
2031 << "No instructions can be added to the inner graph during inlining into the outer graph";
2032
Vladimir Marko438709f2017-02-23 18:56:13 +00002033 if (stats_ != nullptr) {
2034 DCHECK(inline_stats_ != nullptr);
2035 inline_stats_->AddTo(stats_);
2036 }
2037
Hans Boehm206348c2018-12-05 11:11:33 -08002038 if (caller_dead_reference_safe && !callee_dead_reference_safe) {
2039 // Caller was dead reference safe, but is not anymore, since we inlined dead
2040 // reference unsafe code. Prior transformations remain valid, since they did not
2041 // affect the inlined code.
2042 graph_->MarkDeadReferenceUnsafe();
2043 }
2044
Vladimir Markobe10e8e2016-01-22 12:09:44 +00002045 return true;
2046}
Calin Juravle2e768302015-07-28 14:41:11 +00002047
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002048void HInliner::RunOptimizations(HGraph* callee_graph,
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08002049 const dex::CodeItem* code_item,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002050 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01002051 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
2052 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00002053 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08002054 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Markobb089b62018-06-28 17:30:16 +01002055 InstructionSimplifier simplify(callee_graph, codegen_, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002056
2057 HOptimization* optimizations[] = {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002058 &simplify,
2059 &fold,
2060 &dce,
2061 };
2062
2063 for (size_t i = 0; i < arraysize(optimizations); ++i) {
2064 HOptimization* optimization = optimizations[i];
2065 optimization->Run();
2066 }
2067
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002068 // Bail early for pathological cases on the environment (for example recursive calls,
2069 // or too large environment).
2070 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
2071 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2072 << " will not be inlined because the outer method has reached"
2073 << " its environment budget limit.";
2074 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002075 }
2076
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002077 // Bail early if we know we already are over the limit.
2078 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2079 if (number_of_instructions > inlining_budget_) {
2080 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2081 << " will not be inlined because the outer method has reached"
2082 << " its instruction budget limit. " << number_of_instructions;
2083 return;
2084 }
2085
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002086 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002087 HInliner inliner(callee_graph,
2088 outermost_graph_,
2089 codegen_,
2090 outer_compilation_unit_,
2091 dex_compilation_unit,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002092 handles_,
2093 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002094 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002095 total_number_of_instructions_ + number_of_instructions,
2096 this,
2097 depth_ + 1);
2098 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002099}
2100
David Brazdil94ab38f2016-06-21 17:48:19 +01002101static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2102 bool declared_can_be_null,
2103 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002104 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002105 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2106 return true;
2107 }
2108
2109 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2110 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002111 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002112}
2113
Vladimir Markob45528c2017-07-27 14:14:28 +01002114ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002115 return ReferenceTypePropagation::IsAdmissible(klass)
2116 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2117 : graph_->GetInexactObjectRti();
2118}
2119
2120bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2121 // If this is an instance call, test whether the type of the `this` argument
2122 // is more specific than the class which declares the method.
2123 if (!resolved_method->IsStatic()) {
2124 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
Andreas Gampe3db70682018-12-26 15:12:03 -08002125 /* declared_can_be_null= */ false,
David Brazdil94ab38f2016-06-21 17:48:19 +01002126 invoke_instruction->InputAt(0u))) {
2127 return true;
2128 }
2129 }
2130
David Brazdil94ab38f2016-06-21 17:48:19 +01002131 // Iterate over the list of parameter types and test whether any of the
2132 // actual inputs has a more specific reference type than the type declared in
2133 // the signature.
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08002134 const dex::TypeList* param_list = resolved_method->GetParameterTypeList();
David Brazdil94ab38f2016-06-21 17:48:19 +01002135 for (size_t param_idx = 0,
2136 input_idx = resolved_method->IsStatic() ? 0 : 1,
2137 e = (param_list == nullptr ? 0 : param_list->Size());
2138 param_idx < e;
2139 ++param_idx, ++input_idx) {
2140 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002141 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002142 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2143 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002144 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
Andreas Gampe3db70682018-12-26 15:12:03 -08002145 /* declared_can_be_null= */ true,
David Brazdil94ab38f2016-06-21 17:48:19 +01002146 input)) {
2147 return true;
2148 }
2149 }
2150 }
2151
2152 return false;
2153}
2154
2155bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2156 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002157 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002158 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002159 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002160 // Test if the return type is a refinement of the declared return type.
2161 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
Andreas Gampe3db70682018-12-26 15:12:03 -08002162 /* declared_can_be_null= */ true,
David Brazdil94ab38f2016-06-21 17:48:19 +01002163 return_replacement)) {
2164 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002165 } else if (return_replacement->IsInstanceFieldGet()) {
2166 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002167 if (field_get->GetFieldInfo().GetField() ==
Vladimir Markob4eb1b12018-05-24 11:09:38 +01002168 GetClassRoot<mirror::Object>()->GetInstanceField(0)) {
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002169 return true;
2170 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002171 }
2172 } else if (return_replacement->IsInstanceOf()) {
2173 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2174 return true;
2175 }
2176 }
2177
2178 return false;
2179}
2180
2181void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2182 HInstruction* return_replacement) {
2183 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002184 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002185 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2186 // Make sure that we have a valid type for the return. We may get an invalid one when
2187 // we inline invokes with multiple branches and create a Phi for the result.
2188 // TODO: we could be more precise by merging the phi inputs but that requires
2189 // some functionality from the reference type propagation.
2190 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002191 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002192 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002193 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002194 }
Calin Juravle2e768302015-07-28 14:41:11 +00002195 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002196}
2197
2198} // namespace art