blob: 3800c96937b61f7d90c404f9cbefb46035ad3093 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010024#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070026#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000027#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070028#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010030#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "driver/dex_compilation_unit.h"
32#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010033#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000034#include "jit/jit.h"
35#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "mirror/class_loader.h"
37#include "mirror/dex_cache.h"
38#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010039#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010040#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070041#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070042#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010043#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000044#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "thread.h"
47
48namespace art {
49
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000050// Instruction limit to control memory.
51static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
52
53// Maximum number of instructions for considering a method small,
54// which we will always try to inline if the other non-instruction limits
55// are not reached.
56static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000057
58// Limit the number of dex registers that we accumulate while inlining
59// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010060static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000062// Limit recursive call inlining, which do not benefit from too
63// much inlining compared to code locality.
64static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070065
Calin Juravlee2492d42017-03-20 11:42:13 -070066// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070067static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070068
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000069// We check for line numbers to make sure the DepthString implementation
70// aligns the output nicely.
71#define LOG_INTERNAL(msg) \
72 static_assert(__LINE__ > 10, "Unhandled line number"); \
73 static_assert(__LINE__ < 10000, "Unhandled line number"); \
74 VLOG(compiler) << DepthString(__LINE__) << msg
75
76#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
77#define LOG_NOTE() LOG_INTERNAL("Note: ")
78#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070079#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000080#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
81
82std::string HInliner::DepthString(int line) const {
83 std::string value;
84 // Indent according to the inlining depth.
85 size_t count = depth_;
86 // Line numbers get printed in the log, so add a space if the log's line is less
87 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
88 if (!kIsTargetBuild) {
89 if (line < 100) {
90 value += " ";
91 }
92 if (line < 1000) {
93 value += " ";
94 }
95 // Safeguard if this file reaches more than 10000 lines.
96 DCHECK_LT(line, 10000);
97 }
98 for (size_t i = 0; i < count; ++i) {
99 value += " ";
100 }
101 return value;
102}
103
104static size_t CountNumberOfInstructions(HGraph* graph) {
105 size_t number_of_instructions = 0;
106 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
107 for (HInstructionIterator instr_it(block->GetInstructions());
108 !instr_it.Done();
109 instr_it.Advance()) {
110 ++number_of_instructions;
111 }
112 }
113 return number_of_instructions;
114}
115
116void HInliner::UpdateInliningBudget() {
117 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
118 // Always try to inline small methods.
119 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
120 } else {
121 inlining_budget_ = std::max(
122 kMaximumNumberOfInstructionsForSmallMethod,
123 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
124 }
125}
126
Aart Bik24773202018-04-26 10:28:51 -0700127bool HInliner::Run() {
128 if (compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits() == 0) {
129 // Inlining effectively disabled.
130 return false;
131 } else if (graph_->IsDebuggable()) {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000132 // For simplicity, we currently never inline when the graph is debuggable. This avoids
133 // doing some logic in the runtime to discover if a method could have been inlined.
Aart Bik24773202018-04-26 10:28:51 -0700134 return false;
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000135 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000136
Aart Bik24773202018-04-26 10:28:51 -0700137 bool didInline = false;
138
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000139 // Initialize the number of instructions for the method being compiled. Recursive calls
140 // to HInliner::Run have already updated the instruction count.
141 if (outermost_graph_ == graph_) {
142 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
143 }
144
145 UpdateInliningBudget();
146 DCHECK_NE(total_number_of_instructions_, 0u);
147 DCHECK_NE(inlining_budget_, 0u);
148
Roland Levillain6c3af162017-04-27 11:18:56 +0100149 // If we're compiling with a core image (which is only used for
150 // test purposes), honor inlining directives in method names:
151 // - if a method's name contains the substring "$inline$", ensure
152 // that this method is actually inlined;
153 // - if a method's name contains the substring "$noinline$", do not
154 // inline that method.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000155 // We limit the latter to AOT compilation, as the JIT may or may not inline
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100156 // depending on the state of classes at runtime.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000157 const bool honor_noinline_directives = IsCompilingWithCoreImage();
158 const bool honor_inline_directives =
159 honor_noinline_directives && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100160
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000161 // Keep a copy of all blocks when starting the visit.
162 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100163 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000164 // Because we are changing the graph when inlining,
165 // we just iterate over the blocks of the outer method.
166 // This avoids doing the inlining work again on the inlined blocks.
167 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000168 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
169 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100170 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700171 // As long as the call is not intrinsified, it is worth trying to inline.
172 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000173 if (honor_noinline_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000174 // Debugging case: directives in method names control or assert on inlining.
175 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
176 call->GetDexMethodIndex(), /* with_signature */ false);
177 // Tests prevent inlining by having $noinline$ in their method names.
178 if (callee_name.find("$noinline$") == std::string::npos) {
Aart Bik24773202018-04-26 10:28:51 -0700179 if (TryInline(call)) {
180 didInline = true;
181 } else {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000182 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
183 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000184 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000185 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100186 } else {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000187 DCHECK(!honor_inline_directives);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000188 // Normal case: try to inline.
Aart Bik24773202018-04-26 10:28:51 -0700189 if (TryInline(call)) {
190 didInline = true;
191 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000192 }
193 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000194 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000195 }
196 }
Aart Bik24773202018-04-26 10:28:51 -0700197
198 return didInline;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000199}
200
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100201static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700202 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100203 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
204}
205
206/**
207 * Given the `resolved_method` looked up in the dex cache, try to find
208 * the actual runtime target of an interface or virtual call.
209 * Return nullptr if the runtime target cannot be proven.
210 */
211static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700212 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100213 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
214 // No need to lookup further, the resolved method will be the target.
215 return resolved_method;
216 }
217
218 HInstruction* receiver = invoke->InputAt(0);
219 if (receiver->IsNullCheck()) {
220 // Due to multiple levels of inlining within the same pass, it might be that
221 // null check does not have the reference type of the actual receiver.
222 receiver = receiver->InputAt(0);
223 }
224 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000225 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
226 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100227 // We currently only support inlining with known receivers.
228 // TODO: Remove this check, we should be able to inline final methods
229 // on unknown receivers.
230 return nullptr;
231 } else if (info.GetTypeHandle()->IsInterface()) {
232 // Statically knowing that the receiver has an interface type cannot
233 // help us find what is the target method.
234 return nullptr;
235 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
236 // The method that we're trying to call is not in the receiver's class or super classes.
237 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000238 } else if (info.GetTypeHandle()->IsErroneous()) {
239 // If the type is erroneous, do not go further, as we are going to query the vtable or
240 // imt table, that we can only safely do on non-erroneous classes.
241 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100242 }
243
244 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700245 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100246 if (invoke->IsInvokeInterface()) {
247 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
248 resolved_method, pointer_size);
249 } else {
250 DCHECK(invoke->IsInvokeVirtual());
251 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
252 resolved_method, pointer_size);
253 }
254
255 if (resolved_method == nullptr) {
256 // The information we had on the receiver was not enough to find
257 // the target method. Since we check above the exact type of the receiver,
258 // the only reason this can happen is an IncompatibleClassChangeError.
259 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700260 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100261 // The information we had on the receiver was not enough to find
262 // the target method. Since we check above the exact type of the receiver,
263 // the only reason this can happen is an IncompatibleClassChangeError.
264 return nullptr;
265 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
266 // A final method has to be the target method.
267 return resolved_method;
268 } else if (info.IsExact()) {
269 // If we found a method and the receiver's concrete type is statically
270 // known, we know for sure the target.
271 return resolved_method;
272 } else {
273 // Even if we did find a method, the receiver type was not enough to
274 // statically find the runtime target.
275 return nullptr;
276 }
277}
278
279static uint32_t FindMethodIndexIn(ArtMethod* method,
280 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000281 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700282 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100283 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100284 return method->GetDexMethodIndex();
285 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000286 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100287 }
288}
289
Andreas Gampea5b09a62016-11-17 15:21:22 -0800290static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000291 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700292 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800294 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100295 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700296 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000297 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800298 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700299 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100300 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100301 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000302 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000303 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100304 } else {
305 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000306 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100307 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000308 // the right class already resolved with the class loader.
309 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000310 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000311 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
312 if (resolved != cls) {
313 index = dex::TypeIndex::Invalid();
314 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100315 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100316 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000317
318 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100319}
320
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000321class ScopedProfilingInfoInlineUse {
322 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000323 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
324 : method_(method),
325 self_(self),
326 // Fetch the profiling info ahead of using it. If it's null when fetching,
327 // we should not call JitCodeCache::DoneInlining.
328 profiling_info_(
329 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000330 }
331
332 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000333 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700334 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000335 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
336 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
337 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000338 }
339
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000340 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
341
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000342 private:
343 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000344 Thread* const self_;
345 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000346};
347
Calin Juravle13439f02017-02-21 01:17:21 -0800348HInliner::InlineCacheType HInliner::GetInlineCacheType(
349 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
350 REQUIRES_SHARED(Locks::mutator_lock_) {
351 uint8_t number_of_types = 0;
352 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
353 if (classes->Get(number_of_types) == nullptr) {
354 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000355 }
356 }
Calin Juravle13439f02017-02-21 01:17:21 -0800357
358 if (number_of_types == 0) {
359 return kInlineCacheUninitialized;
360 } else if (number_of_types == 1) {
361 return kInlineCacheMonomorphic;
362 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
363 return kInlineCacheMegamorphic;
364 } else {
365 return kInlineCachePolymorphic;
366 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000367}
368
369static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
370 REQUIRES_SHARED(Locks::mutator_lock_) {
371 DCHECK(classes->Get(0) != nullptr);
372 return classes->Get(0);
373}
374
Mingyao Yang063fc772016-08-02 11:02:54 -0700375ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
376 if (!resolved_method->HasSingleImplementation()) {
377 return nullptr;
378 }
379 if (Runtime::Current()->IsAotCompiler()) {
380 // No CHA-based devirtulization for AOT compiler (yet).
381 return nullptr;
382 }
383 if (outermost_graph_->IsCompilingOsr()) {
384 // We do not support HDeoptimize in OSR methods.
385 return nullptr;
386 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800387 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000388 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
389 if (single_impl == nullptr) {
390 return nullptr;
391 }
392 if (single_impl->IsProxyMethod()) {
393 // Proxy method is a generic invoker that's not worth
394 // devirtualizing/inlining. It also causes issues when the proxy
395 // method is in another dex file if we try to rewrite invoke-interface to
396 // invoke-virtual because a proxy method doesn't have a real dex file.
397 return nullptr;
398 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100399 if (!single_impl->GetDeclaringClass()->IsResolved()) {
400 // There's a race with the class loading, which updates the CHA info
401 // before setting the class to resolved. So we just bail for this
402 // rare occurence.
403 return nullptr;
404 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000405 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700406}
407
Aart Bik2c148f02018-02-02 14:30:35 -0800408static bool IsMethodUnverified(CompilerDriver* const compiler_driver, ArtMethod* method)
David Sehr0225f8e2018-01-31 08:52:24 +0000409 REQUIRES_SHARED(Locks::mutator_lock_) {
Aart Bik2c148f02018-02-02 14:30:35 -0800410 if (!method->GetDeclaringClass()->IsVerified()) {
411 if (Runtime::Current()->UseJitCompilation()) {
412 // We're at runtime, we know this is cold code if the class
413 // is not verified, so don't bother analyzing.
414 return true;
415 }
416 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
417 if (!compiler_driver->IsMethodVerifiedWithoutFailures(
418 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
419 // Method has soft or hard failures, don't analyze.
420 return true;
421 }
422 }
423 return false;
424}
425
426static bool AlwaysThrows(CompilerDriver* const compiler_driver, ArtMethod* method)
427 REQUIRES_SHARED(Locks::mutator_lock_) {
428 DCHECK(method != nullptr);
429 // Skip non-compilable and unverified methods.
430 if (!method->IsCompilable() || IsMethodUnverified(compiler_driver, method)) {
431 return false;
432 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800433 // Skip native methods, methods with try blocks, and methods that are too large.
Aart Bik2c148f02018-02-02 14:30:35 -0800434 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800435 if (!accessor.HasCodeItem() ||
436 accessor.TriesSize() != 0 ||
437 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
438 return false;
439 }
440 // Scan for exits.
441 bool throw_seen = false;
442 for (const DexInstructionPcPair& pair : accessor) {
443 switch (pair.Inst().Opcode()) {
444 case Instruction::RETURN:
445 case Instruction::RETURN_VOID:
446 case Instruction::RETURN_WIDE:
447 case Instruction::RETURN_OBJECT:
448 case Instruction::RETURN_VOID_NO_BARRIER:
449 return false; // found regular control flow back
450 case Instruction::THROW:
451 throw_seen = true;
452 break;
453 default:
454 break;
455 }
456 }
457 return throw_seen;
458}
459
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700460bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000461 if (invoke_instruction->IsInvokeUnresolved() ||
462 invoke_instruction->IsInvokePolymorphic()) {
463 return false; // Don't bother to move further if we know the method is unresolved or an
464 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100465 }
466
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000467 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100468 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000469 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000470 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000471
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100472 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100473 if (resolved_method == nullptr) {
474 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
475 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000476 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100477 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000478 }
479 ArtMethod* actual_method = nullptr;
480
481 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800482 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000483 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100484 // Check if we can statically find the method.
485 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000486 }
487
Mingyao Yang063fc772016-08-02 11:02:54 -0700488 bool cha_devirtualize = false;
489 if (actual_method == nullptr) {
490 ArtMethod* method = TryCHADevirtualization(resolved_method);
491 if (method != nullptr) {
492 cha_devirtualize = true;
493 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000494 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700495 }
496 }
497
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100498 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800499 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700500 bool result = TryInlineAndReplace(invoke_instruction,
501 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000502 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700503 /* do_rtp */ true,
504 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800505 if (result) {
506 // Successfully inlined.
507 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
508 if (cha_devirtualize) {
509 // Add dependency due to devirtualization. We've assumed resolved_method
510 // has single implementation.
511 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
512 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
513 } else {
514 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
515 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700516 }
Aart Bik2c148f02018-02-02 14:30:35 -0800517 } else if (!cha_devirtualize && AlwaysThrows(compiler_driver_, actual_method)) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800518 // Set always throws property for non-inlined method call with single target
519 // (unless it was obtained through CHA, because that would imply we have
520 // to add the CHA dependency, which seems not worth it).
521 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000522 }
523 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100524 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800525 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100526
Calin Juravle13439f02017-02-21 01:17:21 -0800527 // Try using inline caches.
528 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
529}
530
531static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
532 const DexCompilationUnit& compilation_unit,
533 StackHandleScope<1>* hs)
534 REQUIRES_SHARED(Locks::mutator_lock_) {
535 Thread* self = Thread::Current();
536 ClassLinker* class_linker = compilation_unit.GetClassLinker();
537 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
538 mirror::ObjectArray<mirror::Class>::Alloc(
539 self,
540 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
541 InlineCache::kIndividualCacheSize));
542 if (inline_cache == nullptr) {
543 // We got an OOME. Just clear the exception, and don't inline.
544 DCHECK(self->IsExceptionPending());
545 self->ClearException();
546 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
547 }
548 return inline_cache;
549}
550
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700551bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
552 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
553 // do not generate a deopt.
554 //
555 // For AOT:
556 // Generating a deopt does not ensure that we will actually capture the new types;
557 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
558 // Take for example the following scenario:
559 // - we capture the inline cache in one run
560 // - the next run, we deoptimize because we miss a type check, but the method
561 // never becomes hot again
562 // In this case, the inline cache will not be updated in the profile and the AOT code
563 // will keep deoptimizing.
564 // Another scenario is if we use profile compilation for a process which is not allowed
565 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
566 // rest of the lifetime.
567 // TODO(calin):
568 // This is a compromise because we will most likely never update the inline cache
569 // in the profile (unless there's another reason to deopt). So we might be stuck with
570 // a sub-optimal inline cache.
571 // We could be smarter when capturing inline caches to mitigate this.
572 // (e.g. by having different thresholds for new and old methods).
573 //
574 // For OSR:
575 // We may come from the interpreter and it may have seen different receiver types.
576 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
577}
Calin Juravle13439f02017-02-21 01:17:21 -0800578bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
579 HInvoke* invoke_instruction,
580 ArtMethod* resolved_method)
581 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700582 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
583 return false;
584 }
585
Calin Juravle13439f02017-02-21 01:17:21 -0800586 StackHandleScope<1> hs(Thread::Current());
587 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
588 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
589 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
590 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
591
592 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000593 case kInlineCacheNoData: {
594 LOG_FAIL_NO_STAT()
595 << "Interface or virtual call to "
596 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
597 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800598 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000599 }
Calin Juravle13439f02017-02-21 01:17:21 -0800600
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000601 case kInlineCacheUninitialized: {
602 LOG_FAIL_NO_STAT()
603 << "Interface or virtual call to "
604 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
605 << " is not hit and not inlined";
606 return false;
607 }
608
609 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000610 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700611 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800612 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000613 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800614 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000615 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000616 }
Calin Juravle13439f02017-02-21 01:17:21 -0800617
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000618 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000619 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800620 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000621 }
Calin Juravle13439f02017-02-21 01:17:21 -0800622
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000623 case kInlineCacheMegamorphic: {
624 LOG_FAIL_NO_STAT()
625 << "Interface or virtual call to "
626 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
627 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000628 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800629 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000630 }
Calin Juravle13439f02017-02-21 01:17:21 -0800631
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000632 case kInlineCacheMissingTypes: {
633 LOG_FAIL_NO_STAT()
634 << "Interface or virtual call to "
635 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
636 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800637 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000638 }
Calin Juravle13439f02017-02-21 01:17:21 -0800639 }
640 UNREACHABLE();
641}
642
643HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
644 HInvoke* invoke_instruction,
645 StackHandleScope<1>* hs,
646 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
647 REQUIRES_SHARED(Locks::mutator_lock_) {
648 DCHECK(Runtime::Current()->UseJitCompilation());
649
650 ArtMethod* caller = graph_->GetArtMethod();
651 // Under JIT, we should always know the caller.
652 DCHECK(caller != nullptr);
653 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
654 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
655
656 if (profiling_info == nullptr) {
657 return kInlineCacheNoData;
658 }
659
660 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
661 if (inline_cache->Get() == nullptr) {
662 // We can't extract any data if we failed to allocate;
663 return kInlineCacheNoData;
664 } else {
665 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
666 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
667 *inline_cache);
668 return GetInlineCacheType(*inline_cache);
669 }
670}
671
672HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
673 const DexFile& caller_dex_file,
674 HInvoke* invoke_instruction,
675 StackHandleScope<1>* hs,
676 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
677 REQUIRES_SHARED(Locks::mutator_lock_) {
678 DCHECK(Runtime::Current()->IsAotCompiler());
679 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
680 if (pci == nullptr) {
681 return kInlineCacheNoData;
682 }
683
Calin Juravlecc3171a2017-05-19 16:47:53 -0700684 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
685 pci->GetMethod(caller_dex_file.GetLocation(),
686 caller_dex_file.GetLocationChecksum(),
687 caller_compilation_unit_.GetDexMethodIndex());
688 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800689 return kInlineCacheNoData; // no profile information for this invocation.
690 }
691
692 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
693 if (inline_cache == nullptr) {
694 // We can't extract any data if we failed to allocate;
695 return kInlineCacheNoData;
696 } else {
697 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700698 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800699 *inline_cache);
700 }
701}
702
703HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
704 const HInvoke* invoke_instruction,
705 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
706 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
707 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700708 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
709 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800710 return kInlineCacheUninitialized;
711 }
712
713 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
714
715 if (dex_pc_data.is_missing_types) {
716 return kInlineCacheMissingTypes;
717 }
718 if (dex_pc_data.is_megamorphic) {
719 return kInlineCacheMegamorphic;
720 }
721
722 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
723 Thread* self = Thread::Current();
724 // We need to resolve the class relative to the containing dex file.
725 // So first, build a mapping from the index of dex file in the profile to
726 // its dex cache. This will avoid repeating the lookup when walking over
727 // the inline cache types.
728 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
729 offline_profile.dex_references.size());
730 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
731 bool found = false;
732 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
733 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
734 dex_profile_index_to_dex_cache[i] =
735 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
736 found = true;
737 }
738 }
739 if (!found) {
740 VLOG(compiler) << "Could not find profiled dex file: "
741 << offline_profile.dex_references[i].dex_location;
742 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100743 }
744 }
745
Calin Juravle13439f02017-02-21 01:17:21 -0800746 // Walk over the classes and resolve them. If we cannot find a type we return
747 // kInlineCacheMissingTypes.
748 int ic_index = 0;
749 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
750 ObjPtr<mirror::DexCache> dex_cache =
751 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
752 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700753
754 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
755 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
756 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
757 return kInlineCacheNoData;
758 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000759 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000760 class_ref.type_index,
761 dex_cache,
762 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800763 if (clazz != nullptr) {
764 inline_cache->Set(ic_index++, clazz);
765 } else {
766 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
767 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
768 invoke_instruction->GetDexMethodIndex()) << " : "
769 << caller_compilation_unit_
770 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
771 return kInlineCacheMissingTypes;
772 }
773 }
774 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100775}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000776
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000777HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
778 HInstruction* receiver,
779 uint32_t dex_pc) const {
780 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
781 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100782 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000783 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000784 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100785 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000786 field->GetOffset(),
787 field->IsVolatile(),
788 field->GetDexFieldIndex(),
789 field->GetDeclaringClass()->GetDexClassDefIndex(),
790 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000791 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000792 // The class of a field is effectively final, and does not have any memory dependencies.
793 result->SetSideEffects(SideEffects::None());
794 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000795}
796
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000797static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
798 ArtMethod* resolved_method,
799 HInstruction* invoke_instruction,
800 PointerSize pointer_size)
801 REQUIRES_SHARED(Locks::mutator_lock_) {
802 if (Runtime::Current()->IsAotCompiler()) {
803 // We can get unrelated types when working with profiles (corruption,
804 // systme updates, or anyone can write to it). So first check if the class
805 // actually implements the declaring class of the method that is being
806 // called in bytecode.
807 // Note: the lookup methods used below require to have assignable types.
808 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
809 return nullptr;
810 }
811 }
812
813 if (invoke_instruction->IsInvokeInterface()) {
814 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
815 } else {
816 DCHECK(invoke_instruction->IsInvokeVirtual());
817 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
818 }
819 DCHECK(resolved_method != nullptr);
820 return resolved_method;
821}
822
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100823bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
824 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000825 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000826 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
827 << invoke_instruction->DebugName();
828
Andreas Gampea5b09a62016-11-17 15:21:22 -0800829 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000830 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800831 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000832 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000833 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
834 << " from inline cache is not inlined because its class is not"
835 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100836 return false;
837 }
838
839 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700840 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000841 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
842 resolved_method = ResolveMethodFromInlineCache(
843 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
844
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000845 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000846 if (resolved_method == nullptr) {
847 // Bogus AOT profile, bail.
848 DCHECK(Runtime::Current()->IsAotCompiler());
849 return false;
850 }
851
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100852 HInstruction* receiver = invoke_instruction->InputAt(0);
853 HInstruction* cursor = invoke_instruction->GetPrevious();
854 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700855 if (!TryInlineAndReplace(invoke_instruction,
856 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000857 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700858 /* do_rtp */ false,
859 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100860 return false;
861 }
862
863 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000864 AddTypeGuard(receiver,
865 cursor,
866 bb_cursor,
867 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000868 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000869 invoke_instruction,
870 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100871
872 // Run type propagation to get the guard typed, and eventually propagate the
873 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000874 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000875 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000876 outer_compilation_unit_.GetDexCache(),
877 handles_,
878 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100879 rtp_fixup.Run();
880
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000881 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100882 return true;
883}
884
Mingyao Yang063fc772016-08-02 11:02:54 -0700885void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
886 uint32_t dex_pc,
887 HInstruction* cursor,
888 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100889 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
890 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
891 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700892 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100893 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
894 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700895
896 if (cursor != nullptr) {
897 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
898 } else {
899 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
900 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800901 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
902 bb_cursor->InsertInstructionAfter(deopt, compare);
903
904 // Add receiver as input to aid CHA guard optimization later.
905 deopt_flag->AddInput(invoke_instruction->InputAt(0));
906 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700907 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800908 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700909}
910
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000911HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
912 HInstruction* cursor,
913 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800914 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000915 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000916 HInstruction* invoke_instruction,
917 bool with_deoptimization) {
918 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
919 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
920 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000921 if (cursor != nullptr) {
922 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
923 } else {
924 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
925 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000926
927 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700928 bool is_referrer;
929 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
930 if (outermost_art_method == nullptr) {
931 DCHECK(Runtime::Current()->IsAotCompiler());
932 // We are in AOT mode and we don't have an ART method to determine
933 // if the inlined method belongs to the referrer. Assume it doesn't.
934 is_referrer = false;
935 } else {
936 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
937 }
938
Nicolas Geoffray56876342016-12-16 16:09:08 +0000939 // Note that we will just compare the classes, so we don't need Java semantics access checks.
940 // Note that the type index and the dex file are relative to the method this type guard is
941 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100942 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
943 class_index,
944 caller_dex_file,
945 klass,
946 is_referrer,
947 invoke_instruction->GetDexPc(),
948 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000949 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000950 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
951 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
952 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000953 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000954 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000955 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800956 // In AOT mode, we will most likely load the class from BSS, which will involve a call
957 // to the runtime. In this case, the load instruction will need an environment so copy
958 // it from the invoke instruction.
959 if (load_class->NeedsEnvironment()) {
960 DCHECK(Runtime::Current()->IsAotCompiler());
961 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
962 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000963
Vladimir Markoca6fff82017-10-03 14:49:14 +0100964 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000965 bb_cursor->InsertInstructionAfter(compare, load_class);
966 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100967 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
968 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000969 compare,
970 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100971 Runtime::Current()->IsAotCompiler()
972 ? DeoptimizationKind::kAotInlineCache
973 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000974 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000975 bb_cursor->InsertInstructionAfter(deoptimize, compare);
976 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000977 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
978 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
979 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000980 }
981 return compare;
982}
983
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000984bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100985 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000986 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000987 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
988 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000989
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000990 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000991 return true;
992 }
993
994 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700995 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000996
997 bool all_targets_inlined = true;
998 bool one_target_inlined = false;
999 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001000 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001001 break;
1002 }
1003 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001004
1005 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001006 method = ResolveMethodFromInlineCache(
1007 handle, resolved_method, invoke_instruction, pointer_size);
1008 if (method == nullptr) {
1009 DCHECK(Runtime::Current()->IsAotCompiler());
1010 // AOT profile is bogus. This loop expects to iterate over all entries,
1011 // so just just continue.
1012 all_targets_inlined = false;
1013 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001014 }
1015
1016 HInstruction* receiver = invoke_instruction->InputAt(0);
1017 HInstruction* cursor = invoke_instruction->GetPrevious();
1018 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1019
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001020 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001021 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001022 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -08001023 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001024 !TryBuildAndInline(invoke_instruction,
1025 method,
1026 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
1027 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001028 all_targets_inlined = false;
1029 } else {
1030 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001031
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001032 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
1033 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001034
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001035 // If we have inlined all targets before, and this receiver is the last seen,
1036 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001037 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1038 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001039 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001040 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001041
Nicolas Geoffray56876342016-12-16 16:09:08 +00001042 HInstruction* compare = AddTypeGuard(receiver,
1043 cursor,
1044 bb_cursor,
1045 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001046 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001047 invoke_instruction,
1048 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001049 if (deoptimize) {
1050 if (return_replacement != nullptr) {
1051 invoke_instruction->ReplaceWith(return_replacement);
1052 }
1053 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1054 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001055 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001056 break;
1057 } else {
1058 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1059 }
1060 }
1061 }
1062
1063 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001064 LOG_FAIL_NO_STAT()
1065 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1066 << " from inline cache is not inlined because none"
1067 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001068 return false;
1069 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001070
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001071 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001072
1073 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001074 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001075 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001076 outer_compilation_unit_.GetDexCache(),
1077 handles_,
1078 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001079 rtp_fixup.Run();
1080 return true;
1081}
1082
1083void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1084 HInstruction* return_replacement,
1085 HInstruction* invoke_instruction) {
1086 uint32_t dex_pc = invoke_instruction->GetDexPc();
1087 HBasicBlock* cursor_block = compare->GetBlock();
1088 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001089 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001090
1091 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1092 // and the returned block is the start of the then branch (that could contain multiple blocks).
1093 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1094
1095 // Split the block containing the invoke before and after the invoke. The returned block
1096 // of the split before will contain the invoke and will be the otherwise branch of
1097 // the diamond. The returned block of the split after will be the merge block
1098 // of the diamond.
1099 HBasicBlock* end_then = invoke_instruction->GetBlock();
1100 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1101 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1102
1103 // If the methods we are inlining return a value, we create a phi in the merge block
1104 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1105 if (return_replacement != nullptr) {
1106 HPhi* phi = new (allocator) HPhi(
1107 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1108 merge->AddPhi(phi);
1109 invoke_instruction->ReplaceWith(phi);
1110 phi->AddInput(return_replacement);
1111 phi->AddInput(invoke_instruction);
1112 }
1113
1114 // Add the control flow instructions.
1115 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1116 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1117 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1118
1119 // Add the newly created blocks to the graph.
1120 graph_->AddBlock(then);
1121 graph_->AddBlock(otherwise);
1122 graph_->AddBlock(merge);
1123
1124 // Set up successor (and implictly predecessor) relations.
1125 cursor_block->AddSuccessor(otherwise);
1126 cursor_block->AddSuccessor(then);
1127 end_then->AddSuccessor(merge);
1128 otherwise->AddSuccessor(merge);
1129
1130 // Set up dominance information.
1131 then->SetDominator(cursor_block);
1132 cursor_block->AddDominatedBlock(then);
1133 otherwise->SetDominator(cursor_block);
1134 cursor_block->AddDominatedBlock(otherwise);
1135 merge->SetDominator(cursor_block);
1136 cursor_block->AddDominatedBlock(merge);
1137
1138 // Update the revert post order.
1139 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1140 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1141 graph_->reverse_post_order_[++index] = then;
1142 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1143 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1144 graph_->reverse_post_order_[++index] = otherwise;
1145 graph_->reverse_post_order_[++index] = merge;
1146
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001147
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001148 graph_->UpdateLoopAndTryInformationOfNewBlock(
1149 then, original_invoke_block, /* replace_if_back_edge */ false);
1150 graph_->UpdateLoopAndTryInformationOfNewBlock(
1151 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1152
1153 // In case the original invoke location was a back edge, we need to update
1154 // the loop to now have the merge block as a back edge.
1155 graph_->UpdateLoopAndTryInformationOfNewBlock(
1156 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001157}
1158
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001159bool HInliner::TryInlinePolymorphicCallToSameTarget(
1160 HInvoke* invoke_instruction,
1161 ArtMethod* resolved_method,
1162 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001163 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001164 if (!Runtime::Current()->UseJitCompilation()) {
1165 return false;
1166 }
1167
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001168 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001169 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001170
1171 DCHECK(resolved_method != nullptr);
1172 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001173 size_t method_index = invoke_instruction->IsInvokeVirtual()
1174 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1175 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1176
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001177 // Check whether we are actually calling the same method among
1178 // the different types seen.
1179 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001180 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001181 break;
1182 }
1183 ArtMethod* new_method = nullptr;
1184 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001185 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001186 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001187 if (new_method->IsRuntimeMethod()) {
1188 // Bail out as soon as we see a conflict trampoline in one of the target's
1189 // interface table.
1190 return false;
1191 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001192 } else {
1193 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001194 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001195 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001196 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001197 if (actual_method == nullptr) {
1198 actual_method = new_method;
1199 } else if (actual_method != new_method) {
1200 // Different methods, bailout.
1201 return false;
1202 }
1203 }
1204
1205 HInstruction* receiver = invoke_instruction->InputAt(0);
1206 HInstruction* cursor = invoke_instruction->GetPrevious();
1207 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1208
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001209 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001210 if (!TryBuildAndInline(invoke_instruction,
1211 actual_method,
1212 ReferenceTypeInfo::CreateInvalid(),
1213 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001214 return false;
1215 }
1216
1217 // We successfully inlined, now add a guard.
1218 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1219 class_linker, receiver, invoke_instruction->GetDexPc());
1220
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001221 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1222 ? DataType::Type::kInt64
1223 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001224 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001225 receiver_class,
1226 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001227 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1228 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001229 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001230 invoke_instruction->GetDexPc());
1231
1232 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001233 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001234 constant = graph_->GetLongConstant(
1235 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1236 } else {
1237 constant = graph_->GetIntConstant(
1238 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1239 }
1240
Vladimir Markoca6fff82017-10-03 14:49:14 +01001241 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001242 if (cursor != nullptr) {
1243 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1244 } else {
1245 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1246 }
1247 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1248 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001249
1250 if (outermost_graph_->IsCompilingOsr()) {
1251 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1252 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001253 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1254 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001255 compare,
1256 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001257 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001258 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001259 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1260 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1261 if (return_replacement != nullptr) {
1262 invoke_instruction->ReplaceWith(return_replacement);
1263 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001264 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001265 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001266 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001267 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001268
1269 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001270 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001271 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001272 outer_compilation_unit_.GetDexCache(),
1273 handles_,
1274 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001275 rtp_fixup.Run();
1276
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001277 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001278
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001279 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001280 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001281}
1282
Mingyao Yang063fc772016-08-02 11:02:54 -07001283bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1284 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001285 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001286 bool do_rtp,
1287 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001288 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001289 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001290 uint32_t dex_pc = invoke_instruction->GetDexPc();
1291 HInstruction* cursor = invoke_instruction->GetPrevious();
1292 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001293 bool should_remove_invoke_instruction = false;
1294
1295 // If invoke_instruction is devirtualized to a different method, give intrinsics
1296 // another chance before we try to inline it.
1297 bool wrong_invoke_type = false;
1298 if (invoke_instruction->GetResolvedMethod() != method &&
1299 IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) {
1300 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1301 if (invoke_instruction->IsInvokeInterface()) {
1302 // We don't intrinsify an invoke-interface directly.
1303 // Replace the invoke-interface with an invoke-virtual.
1304 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1305 graph_->GetAllocator(),
1306 invoke_instruction->GetNumberOfArguments(),
1307 invoke_instruction->GetType(),
1308 invoke_instruction->GetDexPc(),
1309 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1310 method,
1311 method->GetMethodIndex());
1312 HInputsRef inputs = invoke_instruction->GetInputs();
1313 for (size_t index = 0; index != inputs.size(); ++index) {
1314 new_invoke->SetArgumentAt(index, inputs[index]);
1315 }
1316 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1317 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1318 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1319 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1320 }
1321 // Run intrinsic recognizer again to set new_invoke's intrinsic.
1322 IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type);
1323 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
1324 return_replacement = new_invoke;
1325 // invoke_instruction is replaced with new_invoke.
1326 should_remove_invoke_instruction = true;
1327 } else {
1328 // invoke_instruction is intrinsified and stays.
1329 }
1330 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001331 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001332 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001333 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1334 // better than an invoke-interface because:
1335 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1336 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1337 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001338
1339 if (method->IsDefault() && !method->IsCopied()) {
1340 // Changing to invoke-virtual cannot be done on an original default method
1341 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1342 // always uses a method in the iftable which is never an original default
1343 // method.
1344 // On the other hand, inlining an original default method by CHA is fine.
1345 DCHECK(cha_devirtualize);
1346 return false;
1347 }
1348
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001349 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001350 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001351 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001352 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001353 return false;
1354 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001355 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1356 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001357 invoke_instruction->GetNumberOfArguments(),
1358 invoke_instruction->GetType(),
1359 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001360 dex_method_index,
1361 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001362 method->GetMethodIndex());
1363 HInputsRef inputs = invoke_instruction->GetInputs();
1364 for (size_t index = 0; index != inputs.size(); ++index) {
1365 new_invoke->SetArgumentAt(index, inputs[index]);
1366 }
1367 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1368 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001369 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001370 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1371 }
1372 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001373 // invoke_instruction is replaced with new_invoke.
1374 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001375 } else {
1376 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1377 // compiler driver.
1378 return false;
1379 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001380 } else {
1381 // invoke_instruction is inlined.
1382 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001383 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001384
Mingyao Yang063fc772016-08-02 11:02:54 -07001385 if (cha_devirtualize) {
1386 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1387 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001388 if (return_replacement != nullptr) {
1389 invoke_instruction->ReplaceWith(return_replacement);
1390 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001391 if (should_remove_invoke_instruction) {
1392 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1393 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001394 FixUpReturnReferenceType(method, return_replacement);
1395 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1396 // Actual return value has a more specific type than the method's declared
1397 // return type. Run RTP again on the outer graph to propagate it.
1398 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001399 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001400 outer_compilation_unit_.GetDexCache(),
1401 handles_,
1402 /* is_first_run */ false).Run();
1403 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001404 return true;
1405}
1406
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001407size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1408 const HInliner* current = this;
1409 size_t count = 0;
1410 do {
1411 if (current->graph_->GetArtMethod() == method) {
1412 ++count;
1413 }
1414 current = current->parent_;
1415 } while (current != nullptr);
1416 return count;
1417}
1418
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001419bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1420 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001421 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001422 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001423 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001424 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001425 << "Method " << method->PrettyMethod()
1426 << " is not inlined because of unimplemented inline support for proxy methods.";
1427 return false;
1428 }
1429
1430 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001431 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001432 << "Method "
1433 << method->PrettyMethod()
1434 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001435 return false;
1436 }
1437
Jeff Haodcdc85b2015-12-04 14:06:18 -08001438 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1439 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1440 if (!compiler_driver_->MayInline(method->GetDexFile(),
1441 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001442 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001443 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1444 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001445 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001446 return true;
1447 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001448 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001449 << "Won't inline " << method->PrettyMethod() << " in "
1450 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1451 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1452 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001453 return false;
1454 }
1455
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001456 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1457
David Sehr0225f8e2018-01-31 08:52:24 +00001458 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001459
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001460 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001461 LOG_FAIL_NO_STAT()
1462 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001463 return false;
1464 }
1465
Calin Juravleec748352015-07-29 13:52:12 +01001466 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001467 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001468 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001469 << "Method " << method->PrettyMethod()
1470 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001471 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001472 << " > "
1473 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001474 return false;
1475 }
1476
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001477 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001478 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001479 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001480 return false;
1481 }
1482
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001483 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001484 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001485 << "Method " << method->PrettyMethod()
1486 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Aart Bik897df032018-02-07 13:29:11 -08001487 return false;
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001488 }
1489
Aart Bik2c148f02018-02-02 14:30:35 -08001490 if (IsMethodUnverified(compiler_driver_, method)) {
1491 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
1492 << "Method " << method->PrettyMethod()
1493 << " couldn't be verified, so it cannot be inlined";
1494 return false;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001495 }
1496
Roland Levillain4c0eb422015-04-24 16:43:49 +01001497 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1498 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1499 // Case of a static method that cannot be inlined because it implicitly
1500 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001501 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1502 << "Method " << method->PrettyMethod()
1503 << " is not inlined because it is static and requires a clinit"
1504 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001505 return false;
1506 }
1507
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001508 if (!TryBuildAndInlineHelper(
1509 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001510 return false;
1511 }
1512
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001513 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001514 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001515 return true;
1516}
1517
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001518static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1519 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001520 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001521 size_t input_index = 0;
1522 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1523 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001524 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001525 ++i;
1526 DCHECK_NE(i, arg_vreg_index);
1527 }
1528 }
1529 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1530 return invoke_instruction->InputAt(input_index);
1531}
1532
1533// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1534bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1535 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001536 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001537 InlineMethod inline_method;
1538 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1539 return false;
1540 }
1541
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001542 switch (inline_method.opcode) {
1543 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001544 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001545 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001546 break;
1547 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001548 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1549 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001550 break;
1551 case kInlineOpNonWideConst:
1552 if (resolved_method->GetShorty()[0] == 'L') {
1553 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001554 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001555 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001556 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001557 }
1558 break;
1559 case kInlineOpIGet: {
1560 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1561 if (data.method_is_static || data.object_arg != 0u) {
1562 // TODO: Needs null check.
1563 return false;
1564 }
1565 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001566 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001567 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1568 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1569 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001570 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001571 break;
1572 }
1573 case kInlineOpIPut: {
1574 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1575 if (data.method_is_static || data.object_arg != 0u) {
1576 // TODO: Needs null check.
1577 return false;
1578 }
1579 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1580 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001581 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001582 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1583 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1584 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1585 if (data.return_arg_plus1 != 0u) {
1586 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001587 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001588 }
1589 break;
1590 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001591 case kInlineOpConstructor: {
1592 const InlineConstructorData& data = inline_method.d.constructor_data;
1593 // Get the indexes to arrays for easier processing.
1594 uint16_t iput_field_indexes[] = {
1595 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1596 };
1597 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1598 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1599 // Count valid field indexes.
1600 size_t number_of_iputs = 0u;
1601 while (number_of_iputs != arraysize(iput_field_indexes) &&
1602 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1603 // Check that there are no duplicate valid field indexes.
1604 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1605 iput_field_indexes + arraysize(iput_field_indexes),
1606 iput_field_indexes[number_of_iputs]));
1607 ++number_of_iputs;
1608 }
1609 // Check that there are no valid field indexes in the rest of the array.
1610 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1611 iput_field_indexes + arraysize(iput_field_indexes),
1612 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1613
1614 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001615 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1616 bool needs_constructor_barrier = false;
1617 for (size_t i = 0; i != number_of_iputs; ++i) {
1618 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001619 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001620 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001621 bool is_final;
1622 HInstanceFieldSet* iput =
1623 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001624 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1625
1626 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001627 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001628 needs_constructor_barrier = true;
1629 }
1630 }
1631 }
1632 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001633 // See CompilerDriver::RequiresConstructorBarrier for more details.
1634 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1635
1636 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001637 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001638 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1639 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001640 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001641 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001642 break;
1643 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001644 default:
1645 LOG(FATAL) << "UNREACHABLE";
1646 UNREACHABLE();
1647 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001648 return true;
1649}
1650
Vladimir Markof44d36c2017-03-14 14:18:46 +00001651HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1652 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001653 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001654 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001655 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1656 ArtField* resolved_field =
1657 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001658 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001659 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001660 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001661 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001662 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001663 resolved_field->GetOffset(),
1664 resolved_field->IsVolatile(),
1665 field_index,
1666 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001667 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001668 // Read barrier generates a runtime call in slow path and we need a valid
1669 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1670 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001671 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001672 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001673 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001674 ReferenceTypePropagation rtp(graph_,
1675 outer_compilation_unit_.GetClassLoader(),
1676 dex_cache,
1677 handles_,
1678 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001679 rtp.Visit(iget);
1680 }
1681 return iget;
1682}
1683
Vladimir Markof44d36c2017-03-14 14:18:46 +00001684HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1685 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001686 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001687 HInstruction* value,
1688 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001689 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001690 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1691 ArtField* resolved_field =
1692 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001693 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001694 if (is_final != nullptr) {
1695 // This information is needed only for constructors.
1696 DCHECK(referrer->IsConstructor());
1697 *is_final = resolved_field->IsFinal();
1698 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001699 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001700 obj,
1701 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001702 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001703 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001704 resolved_field->GetOffset(),
1705 resolved_field->IsVolatile(),
1706 field_index,
1707 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001708 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001709 // Read barrier generates a runtime call in slow path and we need a valid
1710 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1711 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001712 return iput;
1713}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001714
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001715template <typename T>
1716static inline Handle<T> NewHandleIfDifferent(T* object,
1717 Handle<T> hint,
1718 VariableSizedHandleScope* handles)
1719 REQUIRES_SHARED(Locks::mutator_lock_) {
1720 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1721}
1722
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001723bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1724 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001725 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001726 bool same_dex_file,
1727 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001728 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001729 ScopedObjectAccess soa(Thread::Current());
1730 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001731 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1732 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001733 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001734 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001735 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1736 caller_compilation_unit_.GetDexCache(),
1737 handles_);
1738 Handle<mirror::ClassLoader> class_loader =
1739 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1740 caller_compilation_unit_.GetClassLoader(),
1741 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001742
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001743 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001744 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001745 class_linker,
1746 callee_dex_file,
1747 code_item,
1748 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1749 method_index,
1750 resolved_method->GetAccessFlags(),
1751 /* verified_method */ nullptr,
1752 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001753
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001754 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001755 if (invoke_type == kInterface) {
1756 // We have statically resolved the dispatch. To please the class linker
1757 // at runtime, we change this call as if it was a virtual call.
1758 invoke_type = kVirtual;
1759 }
David Brazdil3f523062016-02-29 16:53:33 +00001760
1761 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001762 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1763 graph_->GetAllocator(),
1764 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001765 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001766 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001767 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001768 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001769 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001770 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001771 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001772 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001773
Vladimir Marko438709f2017-02-23 18:56:13 +00001774 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001775 // of on the stack, as Clang might produce a stack frame too large
1776 // for this function, that would not fit the requirements of the
1777 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001778 if (stats_ != nullptr) {
1779 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1780 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001781 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001782 inline_stats_ = new (storage) OptimizingCompilerStats;
1783 } else {
1784 inline_stats_->Reset();
1785 }
1786 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001787 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001788 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001789 &dex_compilation_unit,
1790 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001791 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001792 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001793 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001794 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001795 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001796
David Brazdildee58d62016-04-07 09:54:26 +00001797 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001798 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001799 << "Method " << callee_dex_file.PrettyMethod(method_index)
1800 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001801 return false;
1802 }
1803
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001804 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1805 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001806 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001807 << "Method " << callee_dex_file.PrettyMethod(method_index)
1808 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001809 return false;
1810 }
1811
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001812 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001813 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001814 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1815 !instructions.Done();
1816 instructions.Advance()) {
1817 HInstruction* current = instructions.Current();
1818 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001819 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001820 if (argument->IsNullConstant()) {
1821 current->ReplaceWith(callee_graph->GetNullConstant());
1822 } else if (argument->IsIntConstant()) {
1823 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1824 } else if (argument->IsLongConstant()) {
1825 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1826 } else if (argument->IsFloatConstant()) {
1827 current->ReplaceWith(
1828 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1829 } else if (argument->IsDoubleConstant()) {
1830 current->ReplaceWith(
1831 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001832 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001833 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1834 run_rtp = true;
1835 current->SetReferenceTypeInfo(receiver_type);
1836 } else {
1837 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1838 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001839 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1840 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001841 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001842 }
1843 }
1844
David Brazdil94ab38f2016-06-21 17:48:19 +01001845 // We have replaced formal arguments with actual arguments. If actual types
1846 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001847 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001848 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001849 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001850 dex_compilation_unit.GetDexCache(),
1851 handles_,
1852 /* is_first_run */ false).Run();
1853 }
1854
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001855 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001856
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001857 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1858 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001859 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001860 << "Method " << callee_dex_file.PrettyMethod(method_index)
1861 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001862 return false;
1863 }
1864
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001865 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001866 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1867 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001868 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1869 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001870 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001871 << "Method " << callee_dex_file.PrettyMethod(method_index)
1872 << " could not be inlined because one branch always throws and"
1873 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001874 return false;
1875 } else if (graph_->GetExitBlock() == nullptr) {
1876 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001877 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001878 << "Method " << callee_dex_file.PrettyMethod(method_index)
1879 << " could not be inlined because one branch always throws and"
1880 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001881 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001882 } else if (graph_->HasIrreducibleLoops()) {
1883 // TODO(ngeoffray): Support re-computing loop information to graphs with
1884 // irreducible loops?
1885 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1886 << " could not be inlined because one branch always throws and"
1887 << " caller has irreducible loops";
1888 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001889 }
1890 } else {
1891 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001892 }
1893 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001894
1895 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001896 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001897 << "Method " << callee_dex_file.PrettyMethod(method_index)
1898 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001899 return false;
1900 }
1901
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001902 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001903 // Skip the entry block, it does not contain instructions that prevent inlining.
1904 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001905 if (block->IsLoopHeader()) {
1906 if (block->GetLoopInformation()->IsIrreducible()) {
1907 // Don't inline methods with irreducible loops, they could prevent some
1908 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001909 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001910 << "Method " << callee_dex_file.PrettyMethod(method_index)
1911 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001912 return false;
1913 }
1914 if (!block->GetLoopInformation()->HasExitEdge()) {
1915 // Don't inline methods with loops without exit, since they cause the
1916 // loop information to be computed incorrectly when updating after
1917 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001918 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001919 << "Method " << callee_dex_file.PrettyMethod(method_index)
1920 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001921 return false;
1922 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001923 }
1924
1925 for (HInstructionIterator instr_it(block->GetInstructions());
1926 !instr_it.Done();
1927 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001928 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001929 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001930 << "Method " << callee_dex_file.PrettyMethod(method_index)
1931 << " is not inlined because the outer method has reached"
1932 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001933 return false;
1934 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001935 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001936 if (current->NeedsEnvironment() &&
1937 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001938 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001939 << "Method " << callee_dex_file.PrettyMethod(method_index)
1940 << " is not inlined because its caller has reached"
1941 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001942 return false;
1943 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001944
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001945 if (current->NeedsEnvironment() &&
1946 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1947 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001948 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001949 << "Method " << callee_dex_file.PrettyMethod(method_index)
1950 << " could not be inlined because " << current->DebugName()
1951 << " needs an environment, is in a different dex file"
1952 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001953 return false;
1954 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001955
Vladimir Markodc151b22015-10-15 18:02:30 +01001956 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001957 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001958 << "Method " << callee_dex_file.PrettyMethod(method_index)
1959 << " could not be inlined because " << current->DebugName()
1960 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001961 return false;
1962 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001963
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001964 if (current->IsUnresolvedStaticFieldGet() ||
1965 current->IsUnresolvedInstanceFieldGet() ||
1966 current->IsUnresolvedStaticFieldSet() ||
1967 current->IsUnresolvedInstanceFieldSet()) {
1968 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001969 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001970 << "Method " << callee_dex_file.PrettyMethod(method_index)
1971 << " could not be inlined because it is using an unresolved"
1972 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001973 return false;
1974 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001975 }
1976 }
David Brazdil3f523062016-02-29 16:53:33 +00001977 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1978 << "No instructions can be added to the outer graph while inner graph is being built";
1979
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001980 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001981 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1982 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001983 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001984 // Update our budget for other inlining attempts in `caller_graph`.
1985 total_number_of_instructions_ += number_of_instructions;
1986 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001987
1988 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1989 << "No instructions can be added to the inner graph during inlining into the outer graph";
1990
Vladimir Marko438709f2017-02-23 18:56:13 +00001991 if (stats_ != nullptr) {
1992 DCHECK(inline_stats_ != nullptr);
1993 inline_stats_->AddTo(stats_);
1994 }
1995
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001996 return true;
1997}
Calin Juravle2e768302015-07-28 14:41:11 +00001998
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001999void HInliner::RunOptimizations(HGraph* callee_graph,
2000 const DexFile::CodeItem* code_item,
2001 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01002002 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
2003 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00002004 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08002005 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Marko28e012a2017-12-07 11:22:59 +00002006 HSharpening sharpening(callee_graph, codegen_, compiler_driver_);
Vladimir Marko65979462017-05-19 17:25:12 +01002007 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00002008 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002009
2010 HOptimization* optimizations[] = {
2011 &intrinsics,
2012 &sharpening,
2013 &simplify,
2014 &fold,
2015 &dce,
2016 };
2017
2018 for (size_t i = 0; i < arraysize(optimizations); ++i) {
2019 HOptimization* optimization = optimizations[i];
2020 optimization->Run();
2021 }
2022
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002023 // Bail early for pathological cases on the environment (for example recursive calls,
2024 // or too large environment).
2025 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
2026 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2027 << " will not be inlined because the outer method has reached"
2028 << " its environment budget limit.";
2029 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002030 }
2031
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002032 // Bail early if we know we already are over the limit.
2033 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2034 if (number_of_instructions > inlining_budget_) {
2035 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2036 << " will not be inlined because the outer method has reached"
2037 << " its instruction budget limit. " << number_of_instructions;
2038 return;
2039 }
2040
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002041 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002042 HInliner inliner(callee_graph,
2043 outermost_graph_,
2044 codegen_,
2045 outer_compilation_unit_,
2046 dex_compilation_unit,
2047 compiler_driver_,
2048 handles_,
2049 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002050 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002051 total_number_of_instructions_ + number_of_instructions,
2052 this,
2053 depth_ + 1);
2054 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002055}
2056
David Brazdil94ab38f2016-06-21 17:48:19 +01002057static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2058 bool declared_can_be_null,
2059 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002060 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002061 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2062 return true;
2063 }
2064
2065 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2066 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002067 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002068}
2069
Vladimir Markob45528c2017-07-27 14:14:28 +01002070ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002071 return ReferenceTypePropagation::IsAdmissible(klass)
2072 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2073 : graph_->GetInexactObjectRti();
2074}
2075
2076bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2077 // If this is an instance call, test whether the type of the `this` argument
2078 // is more specific than the class which declares the method.
2079 if (!resolved_method->IsStatic()) {
2080 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
2081 /* declared_can_be_null */ false,
2082 invoke_instruction->InputAt(0u))) {
2083 return true;
2084 }
2085 }
2086
David Brazdil94ab38f2016-06-21 17:48:19 +01002087 // Iterate over the list of parameter types and test whether any of the
2088 // actual inputs has a more specific reference type than the type declared in
2089 // the signature.
2090 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
2091 for (size_t param_idx = 0,
2092 input_idx = resolved_method->IsStatic() ? 0 : 1,
2093 e = (param_list == nullptr ? 0 : param_list->Size());
2094 param_idx < e;
2095 ++param_idx, ++input_idx) {
2096 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002097 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002098 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2099 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002100 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
2101 /* declared_can_be_null */ true,
2102 input)) {
2103 return true;
2104 }
2105 }
2106 }
2107
2108 return false;
2109}
2110
2111bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2112 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002113 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002114 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002115 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002116 // Test if the return type is a refinement of the declared return type.
2117 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2118 /* declared_can_be_null */ true,
2119 return_replacement)) {
2120 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002121 } else if (return_replacement->IsInstanceFieldGet()) {
2122 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
2123 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
2124 if (field_get->GetFieldInfo().GetField() ==
2125 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
2126 return true;
2127 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002128 }
2129 } else if (return_replacement->IsInstanceOf()) {
2130 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2131 return true;
2132 }
2133 }
2134
2135 return false;
2136}
2137
2138void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2139 HInstruction* return_replacement) {
2140 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002141 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002142 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2143 // Make sure that we have a valid type for the return. We may get an invalid one when
2144 // we inline invokes with multiple branches and create a Phi for the result.
2145 // TODO: we could be more precise by merging the phi inputs but that requires
2146 // some functionality from the reference type propagation.
2147 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002148 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002149 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002150 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002151 }
Calin Juravle2e768302015-07-28 14:41:11 +00002152 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002153}
2154
2155} // namespace art