blob: 6900cd883acaefccb8fedd45de71c7fa0ab1c24f [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
Vladimir Markob4eb1b12018-05-24 11:09:38 +010023#include "class_root.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000024#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010025#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070027#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000028#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070029#include "dex/verified_method.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000030#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010031#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000032#include "driver/dex_compilation_unit.h"
33#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010034#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000035#include "jit/jit.h"
36#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000037#include "mirror/class_loader.h"
38#include "mirror/dex_cache.h"
39#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010040#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010041#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070042#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070043#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010044#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000045#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000047#include "thread.h"
48
49namespace art {
50
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000051// Instruction limit to control memory.
52static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
53
54// Maximum number of instructions for considering a method small,
55// which we will always try to inline if the other non-instruction limits
56// are not reached.
57static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000058
59// Limit the number of dex registers that we accumulate while inlining
60// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010061static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000062
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000063// Limit recursive call inlining, which do not benefit from too
64// much inlining compared to code locality.
65static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070066
Calin Juravlee2492d42017-03-20 11:42:13 -070067// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070068static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070069
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000070// We check for line numbers to make sure the DepthString implementation
71// aligns the output nicely.
72#define LOG_INTERNAL(msg) \
73 static_assert(__LINE__ > 10, "Unhandled line number"); \
74 static_assert(__LINE__ < 10000, "Unhandled line number"); \
75 VLOG(compiler) << DepthString(__LINE__) << msg
76
77#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
78#define LOG_NOTE() LOG_INTERNAL("Note: ")
79#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070080#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000081#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
82
83std::string HInliner::DepthString(int line) const {
84 std::string value;
85 // Indent according to the inlining depth.
86 size_t count = depth_;
87 // Line numbers get printed in the log, so add a space if the log's line is less
88 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
89 if (!kIsTargetBuild) {
90 if (line < 100) {
91 value += " ";
92 }
93 if (line < 1000) {
94 value += " ";
95 }
96 // Safeguard if this file reaches more than 10000 lines.
97 DCHECK_LT(line, 10000);
98 }
99 for (size_t i = 0; i < count; ++i) {
100 value += " ";
101 }
102 return value;
103}
104
105static size_t CountNumberOfInstructions(HGraph* graph) {
106 size_t number_of_instructions = 0;
107 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
108 for (HInstructionIterator instr_it(block->GetInstructions());
109 !instr_it.Done();
110 instr_it.Advance()) {
111 ++number_of_instructions;
112 }
113 }
114 return number_of_instructions;
115}
116
117void HInliner::UpdateInliningBudget() {
118 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
119 // Always try to inline small methods.
120 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
121 } else {
122 inlining_budget_ = std::max(
123 kMaximumNumberOfInstructionsForSmallMethod,
124 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
125 }
126}
127
Aart Bik24773202018-04-26 10:28:51 -0700128bool HInliner::Run() {
129 if (compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits() == 0) {
130 // Inlining effectively disabled.
131 return false;
132 } else if (graph_->IsDebuggable()) {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000133 // For simplicity, we currently never inline when the graph is debuggable. This avoids
134 // doing some logic in the runtime to discover if a method could have been inlined.
Aart Bik24773202018-04-26 10:28:51 -0700135 return false;
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000136 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000137
Aart Bik24773202018-04-26 10:28:51 -0700138 bool didInline = false;
139
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000140 // Initialize the number of instructions for the method being compiled. Recursive calls
141 // to HInliner::Run have already updated the instruction count.
142 if (outermost_graph_ == graph_) {
143 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
144 }
145
146 UpdateInliningBudget();
147 DCHECK_NE(total_number_of_instructions_, 0u);
148 DCHECK_NE(inlining_budget_, 0u);
149
Roland Levillain6c3af162017-04-27 11:18:56 +0100150 // If we're compiling with a core image (which is only used for
151 // test purposes), honor inlining directives in method names:
152 // - if a method's name contains the substring "$inline$", ensure
153 // that this method is actually inlined;
154 // - if a method's name contains the substring "$noinline$", do not
155 // inline that method.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000156 // We limit the latter to AOT compilation, as the JIT may or may not inline
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100157 // depending on the state of classes at runtime.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000158 const bool honor_noinline_directives = IsCompilingWithCoreImage();
159 const bool honor_inline_directives =
160 honor_noinline_directives && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100161
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000162 // Keep a copy of all blocks when starting the visit.
163 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100164 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000165 // Because we are changing the graph when inlining,
166 // we just iterate over the blocks of the outer method.
167 // This avoids doing the inlining work again on the inlined blocks.
168 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000169 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
170 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100171 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700172 // As long as the call is not intrinsified, it is worth trying to inline.
173 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000174 if (honor_noinline_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000175 // Debugging case: directives in method names control or assert on inlining.
176 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
177 call->GetDexMethodIndex(), /* with_signature */ false);
178 // Tests prevent inlining by having $noinline$ in their method names.
179 if (callee_name.find("$noinline$") == std::string::npos) {
Aart Bik24773202018-04-26 10:28:51 -0700180 if (TryInline(call)) {
181 didInline = true;
Aart Bik54e45c52018-04-27 13:57:21 -0700182 } else if (honor_inline_directives) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000183 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
184 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000185 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000186 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100187 } else {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000188 DCHECK(!honor_inline_directives);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000189 // Normal case: try to inline.
Aart Bik24773202018-04-26 10:28:51 -0700190 if (TryInline(call)) {
191 didInline = true;
192 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000193 }
194 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000195 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000196 }
197 }
Aart Bik24773202018-04-26 10:28:51 -0700198
199 return didInline;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000200}
201
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100202static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700203 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100204 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
205}
206
207/**
208 * Given the `resolved_method` looked up in the dex cache, try to find
209 * the actual runtime target of an interface or virtual call.
210 * Return nullptr if the runtime target cannot be proven.
211 */
212static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700213 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100214 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
215 // No need to lookup further, the resolved method will be the target.
216 return resolved_method;
217 }
218
219 HInstruction* receiver = invoke->InputAt(0);
220 if (receiver->IsNullCheck()) {
221 // Due to multiple levels of inlining within the same pass, it might be that
222 // null check does not have the reference type of the actual receiver.
223 receiver = receiver->InputAt(0);
224 }
225 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000226 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
227 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100228 // We currently only support inlining with known receivers.
229 // TODO: Remove this check, we should be able to inline final methods
230 // on unknown receivers.
231 return nullptr;
232 } else if (info.GetTypeHandle()->IsInterface()) {
233 // Statically knowing that the receiver has an interface type cannot
234 // help us find what is the target method.
235 return nullptr;
236 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
237 // The method that we're trying to call is not in the receiver's class or super classes.
238 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000239 } else if (info.GetTypeHandle()->IsErroneous()) {
240 // If the type is erroneous, do not go further, as we are going to query the vtable or
241 // imt table, that we can only safely do on non-erroneous classes.
242 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100243 }
244
245 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700246 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100247 if (invoke->IsInvokeInterface()) {
248 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
249 resolved_method, pointer_size);
250 } else {
251 DCHECK(invoke->IsInvokeVirtual());
252 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
253 resolved_method, pointer_size);
254 }
255
256 if (resolved_method == nullptr) {
257 // The information we had on the receiver was not enough to find
258 // the target method. Since we check above the exact type of the receiver,
259 // the only reason this can happen is an IncompatibleClassChangeError.
260 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700261 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100262 // The information we had on the receiver was not enough to find
263 // the target method. Since we check above the exact type of the receiver,
264 // the only reason this can happen is an IncompatibleClassChangeError.
265 return nullptr;
266 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
267 // A final method has to be the target method.
268 return resolved_method;
269 } else if (info.IsExact()) {
270 // If we found a method and the receiver's concrete type is statically
271 // known, we know for sure the target.
272 return resolved_method;
273 } else {
274 // Even if we did find a method, the receiver type was not enough to
275 // statically find the runtime target.
276 return nullptr;
277 }
278}
279
280static uint32_t FindMethodIndexIn(ArtMethod* method,
281 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000282 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700283 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100284 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100285 return method->GetDexMethodIndex();
286 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000287 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100288 }
289}
290
Andreas Gampea5b09a62016-11-17 15:21:22 -0800291static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000292 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700293 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000294 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800295 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100296 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700297 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000298 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800299 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700300 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100301 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100302 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000303 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000304 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100305 } else {
306 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000307 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100308 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000309 // the right class already resolved with the class loader.
310 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000311 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000312 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
313 if (resolved != cls) {
314 index = dex::TypeIndex::Invalid();
315 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100316 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100317 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000318
319 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100320}
321
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000322class ScopedProfilingInfoInlineUse {
323 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000324 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
325 : method_(method),
326 self_(self),
327 // Fetch the profiling info ahead of using it. If it's null when fetching,
328 // we should not call JitCodeCache::DoneInlining.
329 profiling_info_(
330 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000331 }
332
333 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000334 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700335 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000336 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
337 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
338 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000339 }
340
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000341 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
342
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000343 private:
344 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000345 Thread* const self_;
346 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000347};
348
Calin Juravle13439f02017-02-21 01:17:21 -0800349HInliner::InlineCacheType HInliner::GetInlineCacheType(
350 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
351 REQUIRES_SHARED(Locks::mutator_lock_) {
352 uint8_t number_of_types = 0;
353 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
354 if (classes->Get(number_of_types) == nullptr) {
355 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000356 }
357 }
Calin Juravle13439f02017-02-21 01:17:21 -0800358
359 if (number_of_types == 0) {
360 return kInlineCacheUninitialized;
361 } else if (number_of_types == 1) {
362 return kInlineCacheMonomorphic;
363 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
364 return kInlineCacheMegamorphic;
365 } else {
366 return kInlineCachePolymorphic;
367 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000368}
369
370static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
371 REQUIRES_SHARED(Locks::mutator_lock_) {
372 DCHECK(classes->Get(0) != nullptr);
373 return classes->Get(0);
374}
375
Mingyao Yang063fc772016-08-02 11:02:54 -0700376ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
377 if (!resolved_method->HasSingleImplementation()) {
378 return nullptr;
379 }
380 if (Runtime::Current()->IsAotCompiler()) {
381 // No CHA-based devirtulization for AOT compiler (yet).
382 return nullptr;
383 }
384 if (outermost_graph_->IsCompilingOsr()) {
385 // We do not support HDeoptimize in OSR methods.
386 return nullptr;
387 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800388 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000389 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
390 if (single_impl == nullptr) {
391 return nullptr;
392 }
393 if (single_impl->IsProxyMethod()) {
394 // Proxy method is a generic invoker that's not worth
395 // devirtualizing/inlining. It also causes issues when the proxy
396 // method is in another dex file if we try to rewrite invoke-interface to
397 // invoke-virtual because a proxy method doesn't have a real dex file.
398 return nullptr;
399 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100400 if (!single_impl->GetDeclaringClass()->IsResolved()) {
401 // There's a race with the class loading, which updates the CHA info
402 // before setting the class to resolved. So we just bail for this
403 // rare occurence.
404 return nullptr;
405 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000406 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700407}
408
Aart Bik2c148f02018-02-02 14:30:35 -0800409static bool IsMethodUnverified(CompilerDriver* const compiler_driver, ArtMethod* method)
David Sehr0225f8e2018-01-31 08:52:24 +0000410 REQUIRES_SHARED(Locks::mutator_lock_) {
Aart Bik2c148f02018-02-02 14:30:35 -0800411 if (!method->GetDeclaringClass()->IsVerified()) {
412 if (Runtime::Current()->UseJitCompilation()) {
413 // We're at runtime, we know this is cold code if the class
414 // is not verified, so don't bother analyzing.
415 return true;
416 }
417 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
418 if (!compiler_driver->IsMethodVerifiedWithoutFailures(
419 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
420 // Method has soft or hard failures, don't analyze.
421 return true;
422 }
423 }
424 return false;
425}
426
427static bool AlwaysThrows(CompilerDriver* const compiler_driver, ArtMethod* method)
428 REQUIRES_SHARED(Locks::mutator_lock_) {
429 DCHECK(method != nullptr);
430 // Skip non-compilable and unverified methods.
431 if (!method->IsCompilable() || IsMethodUnverified(compiler_driver, method)) {
432 return false;
433 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800434 // Skip native methods, methods with try blocks, and methods that are too large.
Aart Bik2c148f02018-02-02 14:30:35 -0800435 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800436 if (!accessor.HasCodeItem() ||
437 accessor.TriesSize() != 0 ||
438 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
439 return false;
440 }
441 // Scan for exits.
442 bool throw_seen = false;
443 for (const DexInstructionPcPair& pair : accessor) {
444 switch (pair.Inst().Opcode()) {
445 case Instruction::RETURN:
446 case Instruction::RETURN_VOID:
447 case Instruction::RETURN_WIDE:
448 case Instruction::RETURN_OBJECT:
449 case Instruction::RETURN_VOID_NO_BARRIER:
450 return false; // found regular control flow back
451 case Instruction::THROW:
452 throw_seen = true;
453 break;
454 default:
455 break;
456 }
457 }
458 return throw_seen;
459}
460
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700461bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000462 if (invoke_instruction->IsInvokeUnresolved() ||
463 invoke_instruction->IsInvokePolymorphic()) {
464 return false; // Don't bother to move further if we know the method is unresolved or an
465 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100466 }
467
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000468 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100469 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000470 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000471 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000472
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100473 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100474 if (resolved_method == nullptr) {
475 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
476 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000477 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100478 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000479 }
480 ArtMethod* actual_method = nullptr;
481
482 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800483 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000484 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100485 // Check if we can statically find the method.
486 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000487 }
488
Mingyao Yang063fc772016-08-02 11:02:54 -0700489 bool cha_devirtualize = false;
490 if (actual_method == nullptr) {
491 ArtMethod* method = TryCHADevirtualization(resolved_method);
492 if (method != nullptr) {
493 cha_devirtualize = true;
494 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000495 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700496 }
497 }
498
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100499 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800500 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700501 bool result = TryInlineAndReplace(invoke_instruction,
502 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000503 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700504 /* do_rtp */ true,
505 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800506 if (result) {
507 // Successfully inlined.
508 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
509 if (cha_devirtualize) {
510 // Add dependency due to devirtualization. We've assumed resolved_method
511 // has single implementation.
512 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
513 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
514 } else {
515 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
516 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700517 }
Aart Bik2c148f02018-02-02 14:30:35 -0800518 } else if (!cha_devirtualize && AlwaysThrows(compiler_driver_, actual_method)) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800519 // Set always throws property for non-inlined method call with single target
520 // (unless it was obtained through CHA, because that would imply we have
521 // to add the CHA dependency, which seems not worth it).
522 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000523 }
524 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100525 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800526 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100527
Calin Juravle13439f02017-02-21 01:17:21 -0800528 // Try using inline caches.
529 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
530}
531
532static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
533 const DexCompilationUnit& compilation_unit,
534 StackHandleScope<1>* hs)
535 REQUIRES_SHARED(Locks::mutator_lock_) {
536 Thread* self = Thread::Current();
537 ClassLinker* class_linker = compilation_unit.GetClassLinker();
538 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
539 mirror::ObjectArray<mirror::Class>::Alloc(
540 self,
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100541 GetClassRoot<mirror::ObjectArray<mirror::Class>>(class_linker),
Calin Juravle13439f02017-02-21 01:17:21 -0800542 InlineCache::kIndividualCacheSize));
543 if (inline_cache == nullptr) {
544 // We got an OOME. Just clear the exception, and don't inline.
545 DCHECK(self->IsExceptionPending());
546 self->ClearException();
547 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
548 }
549 return inline_cache;
550}
551
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700552bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
553 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
554 // do not generate a deopt.
555 //
556 // For AOT:
557 // Generating a deopt does not ensure that we will actually capture the new types;
558 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
559 // Take for example the following scenario:
560 // - we capture the inline cache in one run
561 // - the next run, we deoptimize because we miss a type check, but the method
562 // never becomes hot again
563 // In this case, the inline cache will not be updated in the profile and the AOT code
564 // will keep deoptimizing.
565 // Another scenario is if we use profile compilation for a process which is not allowed
566 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
567 // rest of the lifetime.
568 // TODO(calin):
569 // This is a compromise because we will most likely never update the inline cache
570 // in the profile (unless there's another reason to deopt). So we might be stuck with
571 // a sub-optimal inline cache.
572 // We could be smarter when capturing inline caches to mitigate this.
573 // (e.g. by having different thresholds for new and old methods).
574 //
575 // For OSR:
576 // We may come from the interpreter and it may have seen different receiver types.
577 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
578}
Calin Juravle13439f02017-02-21 01:17:21 -0800579bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
580 HInvoke* invoke_instruction,
581 ArtMethod* resolved_method)
582 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700583 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
584 return false;
585 }
586
Calin Juravle13439f02017-02-21 01:17:21 -0800587 StackHandleScope<1> hs(Thread::Current());
588 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
589 InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler()
590 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
591 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
592
593 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000594 case kInlineCacheNoData: {
595 LOG_FAIL_NO_STAT()
596 << "Interface or virtual call to "
597 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
598 << " could not be statically determined";
Calin Juravle13439f02017-02-21 01:17:21 -0800599 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000600 }
Calin Juravle13439f02017-02-21 01:17:21 -0800601
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000602 case kInlineCacheUninitialized: {
603 LOG_FAIL_NO_STAT()
604 << "Interface or virtual call to "
605 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
606 << " is not hit and not inlined";
607 return false;
608 }
609
610 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000611 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700612 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800613 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000614 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800615 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000616 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000617 }
Calin Juravle13439f02017-02-21 01:17:21 -0800618
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000619 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000620 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800621 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000622 }
Calin Juravle13439f02017-02-21 01:17:21 -0800623
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000624 case kInlineCacheMegamorphic: {
625 LOG_FAIL_NO_STAT()
626 << "Interface or virtual call to "
627 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
628 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000629 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800630 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000631 }
Calin Juravle13439f02017-02-21 01:17:21 -0800632
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000633 case kInlineCacheMissingTypes: {
634 LOG_FAIL_NO_STAT()
635 << "Interface or virtual call to "
636 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
637 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800638 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000639 }
Calin Juravle13439f02017-02-21 01:17:21 -0800640 }
641 UNREACHABLE();
642}
643
644HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
645 HInvoke* invoke_instruction,
646 StackHandleScope<1>* hs,
647 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
648 REQUIRES_SHARED(Locks::mutator_lock_) {
649 DCHECK(Runtime::Current()->UseJitCompilation());
650
651 ArtMethod* caller = graph_->GetArtMethod();
652 // Under JIT, we should always know the caller.
653 DCHECK(caller != nullptr);
654 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
655 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
656
657 if (profiling_info == nullptr) {
658 return kInlineCacheNoData;
659 }
660
661 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
662 if (inline_cache->Get() == nullptr) {
663 // We can't extract any data if we failed to allocate;
664 return kInlineCacheNoData;
665 } else {
666 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
667 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
668 *inline_cache);
669 return GetInlineCacheType(*inline_cache);
670 }
671}
672
673HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
674 const DexFile& caller_dex_file,
675 HInvoke* invoke_instruction,
676 StackHandleScope<1>* hs,
677 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
678 REQUIRES_SHARED(Locks::mutator_lock_) {
679 DCHECK(Runtime::Current()->IsAotCompiler());
680 const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo();
681 if (pci == nullptr) {
682 return kInlineCacheNoData;
683 }
684
Calin Juravlecc3171a2017-05-19 16:47:53 -0700685 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
686 pci->GetMethod(caller_dex_file.GetLocation(),
687 caller_dex_file.GetLocationChecksum(),
688 caller_compilation_unit_.GetDexMethodIndex());
689 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800690 return kInlineCacheNoData; // no profile information for this invocation.
691 }
692
693 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
694 if (inline_cache == nullptr) {
695 // We can't extract any data if we failed to allocate;
696 return kInlineCacheNoData;
697 } else {
698 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700699 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800700 *inline_cache);
701 }
702}
703
704HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
705 const HInvoke* invoke_instruction,
706 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
707 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
708 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700709 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
710 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800711 return kInlineCacheUninitialized;
712 }
713
714 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
715
716 if (dex_pc_data.is_missing_types) {
717 return kInlineCacheMissingTypes;
718 }
719 if (dex_pc_data.is_megamorphic) {
720 return kInlineCacheMegamorphic;
721 }
722
723 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
724 Thread* self = Thread::Current();
725 // We need to resolve the class relative to the containing dex file.
726 // So first, build a mapping from the index of dex file in the profile to
727 // its dex cache. This will avoid repeating the lookup when walking over
728 // the inline cache types.
729 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
730 offline_profile.dex_references.size());
731 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
732 bool found = false;
733 for (const DexFile* dex_file : compiler_driver_->GetDexFilesForOatFile()) {
734 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
735 dex_profile_index_to_dex_cache[i] =
736 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
737 found = true;
738 }
739 }
740 if (!found) {
741 VLOG(compiler) << "Could not find profiled dex file: "
742 << offline_profile.dex_references[i].dex_location;
743 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100744 }
745 }
746
Calin Juravle13439f02017-02-21 01:17:21 -0800747 // Walk over the classes and resolve them. If we cannot find a type we return
748 // kInlineCacheMissingTypes.
749 int ic_index = 0;
750 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
751 ObjPtr<mirror::DexCache> dex_cache =
752 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
753 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700754
755 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
756 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
757 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
758 return kInlineCacheNoData;
759 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000760 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000761 class_ref.type_index,
762 dex_cache,
763 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800764 if (clazz != nullptr) {
765 inline_cache->Set(ic_index++, clazz);
766 } else {
767 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
768 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
769 invoke_instruction->GetDexMethodIndex()) << " : "
770 << caller_compilation_unit_
771 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
772 return kInlineCacheMissingTypes;
773 }
774 }
775 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100776}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000777
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000778HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
779 HInstruction* receiver,
780 uint32_t dex_pc) const {
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100781 ArtField* field = GetClassRoot<mirror::Object>(class_linker)->GetInstanceField(0);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000782 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100783 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000784 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000785 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100786 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000787 field->GetOffset(),
788 field->IsVolatile(),
789 field->GetDexFieldIndex(),
790 field->GetDeclaringClass()->GetDexClassDefIndex(),
791 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000792 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000793 // The class of a field is effectively final, and does not have any memory dependencies.
794 result->SetSideEffects(SideEffects::None());
795 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000796}
797
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000798static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
799 ArtMethod* resolved_method,
800 HInstruction* invoke_instruction,
801 PointerSize pointer_size)
802 REQUIRES_SHARED(Locks::mutator_lock_) {
803 if (Runtime::Current()->IsAotCompiler()) {
804 // We can get unrelated types when working with profiles (corruption,
805 // systme updates, or anyone can write to it). So first check if the class
806 // actually implements the declaring class of the method that is being
807 // called in bytecode.
808 // Note: the lookup methods used below require to have assignable types.
809 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
810 return nullptr;
811 }
812 }
813
814 if (invoke_instruction->IsInvokeInterface()) {
815 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
816 } else {
817 DCHECK(invoke_instruction->IsInvokeVirtual());
818 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
819 }
820 DCHECK(resolved_method != nullptr);
821 return resolved_method;
822}
823
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100824bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
825 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000826 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000827 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
828 << invoke_instruction->DebugName();
829
Andreas Gampea5b09a62016-11-17 15:21:22 -0800830 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000831 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800832 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000833 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000834 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
835 << " from inline cache is not inlined because its class is not"
836 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100837 return false;
838 }
839
840 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700841 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000842 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
843 resolved_method = ResolveMethodFromInlineCache(
844 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
845
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000846 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000847 if (resolved_method == nullptr) {
848 // Bogus AOT profile, bail.
849 DCHECK(Runtime::Current()->IsAotCompiler());
850 return false;
851 }
852
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100853 HInstruction* receiver = invoke_instruction->InputAt(0);
854 HInstruction* cursor = invoke_instruction->GetPrevious();
855 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700856 if (!TryInlineAndReplace(invoke_instruction,
857 resolved_method,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000858 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700859 /* do_rtp */ false,
860 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100861 return false;
862 }
863
864 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000865 AddTypeGuard(receiver,
866 cursor,
867 bb_cursor,
868 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000869 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000870 invoke_instruction,
871 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100872
873 // Run type propagation to get the guard typed, and eventually propagate the
874 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000875 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000876 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000877 outer_compilation_unit_.GetDexCache(),
878 handles_,
879 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100880 rtp_fixup.Run();
881
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000882 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100883 return true;
884}
885
Mingyao Yang063fc772016-08-02 11:02:54 -0700886void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
887 uint32_t dex_pc,
888 HInstruction* cursor,
889 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100890 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
891 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
892 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700893 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100894 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
895 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700896
897 if (cursor != nullptr) {
898 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
899 } else {
900 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
901 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800902 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
903 bb_cursor->InsertInstructionAfter(deopt, compare);
904
905 // Add receiver as input to aid CHA guard optimization later.
906 deopt_flag->AddInput(invoke_instruction->InputAt(0));
907 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700908 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800909 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700910}
911
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000912HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
913 HInstruction* cursor,
914 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800915 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000916 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000917 HInstruction* invoke_instruction,
918 bool with_deoptimization) {
919 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
920 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
921 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000922 if (cursor != nullptr) {
923 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
924 } else {
925 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
926 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000927
928 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700929 bool is_referrer;
930 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
931 if (outermost_art_method == nullptr) {
932 DCHECK(Runtime::Current()->IsAotCompiler());
933 // We are in AOT mode and we don't have an ART method to determine
934 // if the inlined method belongs to the referrer. Assume it doesn't.
935 is_referrer = false;
936 } else {
937 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
938 }
939
Nicolas Geoffray56876342016-12-16 16:09:08 +0000940 // Note that we will just compare the classes, so we don't need Java semantics access checks.
941 // Note that the type index and the dex file are relative to the method this type guard is
942 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100943 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
944 class_index,
945 caller_dex_file,
946 klass,
947 is_referrer,
948 invoke_instruction->GetDexPc(),
949 /* needs_access_check */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000950 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000951 load_class, codegen_, compiler_driver_, caller_compilation_unit_);
952 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
953 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000954 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000955 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000956 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800957 // In AOT mode, we will most likely load the class from BSS, which will involve a call
958 // to the runtime. In this case, the load instruction will need an environment so copy
959 // it from the invoke instruction.
960 if (load_class->NeedsEnvironment()) {
961 DCHECK(Runtime::Current()->IsAotCompiler());
962 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
963 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000964
Vladimir Markoca6fff82017-10-03 14:49:14 +0100965 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000966 bb_cursor->InsertInstructionAfter(compare, load_class);
967 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100968 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
969 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000970 compare,
971 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100972 Runtime::Current()->IsAotCompiler()
973 ? DeoptimizationKind::kAotInlineCache
974 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000975 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000976 bb_cursor->InsertInstructionAfter(deoptimize, compare);
977 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000978 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
979 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
980 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000981 }
982 return compare;
983}
984
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000985bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100986 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000987 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000988 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
989 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000990
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000991 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000992 return true;
993 }
994
995 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700996 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000997
998 bool all_targets_inlined = true;
999 bool one_target_inlined = false;
1000 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001001 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001002 break;
1003 }
1004 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001005
1006 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001007 method = ResolveMethodFromInlineCache(
1008 handle, resolved_method, invoke_instruction, pointer_size);
1009 if (method == nullptr) {
1010 DCHECK(Runtime::Current()->IsAotCompiler());
1011 // AOT profile is bogus. This loop expects to iterate over all entries,
1012 // so just just continue.
1013 all_targets_inlined = false;
1014 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001015 }
1016
1017 HInstruction* receiver = invoke_instruction->InputAt(0);
1018 HInstruction* cursor = invoke_instruction->GetPrevious();
1019 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1020
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001021 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001022 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001023 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -08001024 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001025 !TryBuildAndInline(invoke_instruction,
1026 method,
1027 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
1028 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001029 all_targets_inlined = false;
1030 } else {
1031 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001032
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001033 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
1034 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001035
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001036 // If we have inlined all targets before, and this receiver is the last seen,
1037 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001038 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1039 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001040 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001041 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001042
Nicolas Geoffray56876342016-12-16 16:09:08 +00001043 HInstruction* compare = AddTypeGuard(receiver,
1044 cursor,
1045 bb_cursor,
1046 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001047 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001048 invoke_instruction,
1049 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001050 if (deoptimize) {
1051 if (return_replacement != nullptr) {
1052 invoke_instruction->ReplaceWith(return_replacement);
1053 }
1054 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1055 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001056 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001057 break;
1058 } else {
1059 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1060 }
1061 }
1062 }
1063
1064 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001065 LOG_FAIL_NO_STAT()
1066 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1067 << " from inline cache is not inlined because none"
1068 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001069 return false;
1070 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001071
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001072 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001073
1074 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001075 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001076 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001077 outer_compilation_unit_.GetDexCache(),
1078 handles_,
1079 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001080 rtp_fixup.Run();
1081 return true;
1082}
1083
1084void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1085 HInstruction* return_replacement,
1086 HInstruction* invoke_instruction) {
1087 uint32_t dex_pc = invoke_instruction->GetDexPc();
1088 HBasicBlock* cursor_block = compare->GetBlock();
1089 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001090 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001091
1092 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1093 // and the returned block is the start of the then branch (that could contain multiple blocks).
1094 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1095
1096 // Split the block containing the invoke before and after the invoke. The returned block
1097 // of the split before will contain the invoke and will be the otherwise branch of
1098 // the diamond. The returned block of the split after will be the merge block
1099 // of the diamond.
1100 HBasicBlock* end_then = invoke_instruction->GetBlock();
1101 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1102 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1103
1104 // If the methods we are inlining return a value, we create a phi in the merge block
1105 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1106 if (return_replacement != nullptr) {
1107 HPhi* phi = new (allocator) HPhi(
1108 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1109 merge->AddPhi(phi);
1110 invoke_instruction->ReplaceWith(phi);
1111 phi->AddInput(return_replacement);
1112 phi->AddInput(invoke_instruction);
1113 }
1114
1115 // Add the control flow instructions.
1116 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1117 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1118 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1119
1120 // Add the newly created blocks to the graph.
1121 graph_->AddBlock(then);
1122 graph_->AddBlock(otherwise);
1123 graph_->AddBlock(merge);
1124
1125 // Set up successor (and implictly predecessor) relations.
1126 cursor_block->AddSuccessor(otherwise);
1127 cursor_block->AddSuccessor(then);
1128 end_then->AddSuccessor(merge);
1129 otherwise->AddSuccessor(merge);
1130
1131 // Set up dominance information.
1132 then->SetDominator(cursor_block);
1133 cursor_block->AddDominatedBlock(then);
1134 otherwise->SetDominator(cursor_block);
1135 cursor_block->AddDominatedBlock(otherwise);
1136 merge->SetDominator(cursor_block);
1137 cursor_block->AddDominatedBlock(merge);
1138
1139 // Update the revert post order.
1140 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1141 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1142 graph_->reverse_post_order_[++index] = then;
1143 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1144 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1145 graph_->reverse_post_order_[++index] = otherwise;
1146 graph_->reverse_post_order_[++index] = merge;
1147
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001148
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001149 graph_->UpdateLoopAndTryInformationOfNewBlock(
1150 then, original_invoke_block, /* replace_if_back_edge */ false);
1151 graph_->UpdateLoopAndTryInformationOfNewBlock(
1152 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
1153
1154 // In case the original invoke location was a back edge, we need to update
1155 // the loop to now have the merge block as a back edge.
1156 graph_->UpdateLoopAndTryInformationOfNewBlock(
1157 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001158}
1159
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001160bool HInliner::TryInlinePolymorphicCallToSameTarget(
1161 HInvoke* invoke_instruction,
1162 ArtMethod* resolved_method,
1163 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001164 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001165 if (!Runtime::Current()->UseJitCompilation()) {
1166 return false;
1167 }
1168
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001169 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001170 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001171
1172 DCHECK(resolved_method != nullptr);
1173 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001174 size_t method_index = invoke_instruction->IsInvokeVirtual()
1175 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1176 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1177
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001178 // Check whether we are actually calling the same method among
1179 // the different types seen.
1180 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001181 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001182 break;
1183 }
1184 ArtMethod* new_method = nullptr;
1185 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001186 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001187 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001188 if (new_method->IsRuntimeMethod()) {
1189 // Bail out as soon as we see a conflict trampoline in one of the target's
1190 // interface table.
1191 return false;
1192 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001193 } else {
1194 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001195 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001196 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001197 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001198 if (actual_method == nullptr) {
1199 actual_method = new_method;
1200 } else if (actual_method != new_method) {
1201 // Different methods, bailout.
1202 return false;
1203 }
1204 }
1205
1206 HInstruction* receiver = invoke_instruction->InputAt(0);
1207 HInstruction* cursor = invoke_instruction->GetPrevious();
1208 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1209
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001210 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001211 if (!TryBuildAndInline(invoke_instruction,
1212 actual_method,
1213 ReferenceTypeInfo::CreateInvalid(),
1214 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001215 return false;
1216 }
1217
1218 // We successfully inlined, now add a guard.
1219 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1220 class_linker, receiver, invoke_instruction->GetDexPc());
1221
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001222 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1223 ? DataType::Type::kInt64
1224 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001225 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001226 receiver_class,
1227 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001228 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1229 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001230 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001231 invoke_instruction->GetDexPc());
1232
1233 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001234 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001235 constant = graph_->GetLongConstant(
1236 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1237 } else {
1238 constant = graph_->GetIntConstant(
1239 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1240 }
1241
Vladimir Markoca6fff82017-10-03 14:49:14 +01001242 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001243 if (cursor != nullptr) {
1244 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1245 } else {
1246 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1247 }
1248 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1249 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001250
1251 if (outermost_graph_->IsCompilingOsr()) {
1252 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1253 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001254 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1255 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001256 compare,
1257 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001258 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001259 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001260 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1261 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1262 if (return_replacement != nullptr) {
1263 invoke_instruction->ReplaceWith(return_replacement);
1264 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001265 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001266 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001267 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001268 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001269
1270 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001271 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001272 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001273 outer_compilation_unit_.GetDexCache(),
1274 handles_,
1275 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001276 rtp_fixup.Run();
1277
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001278 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001279
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001280 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001281 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001282}
1283
Mingyao Yang063fc772016-08-02 11:02:54 -07001284bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1285 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001286 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001287 bool do_rtp,
1288 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001289 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001290 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001291 uint32_t dex_pc = invoke_instruction->GetDexPc();
1292 HInstruction* cursor = invoke_instruction->GetPrevious();
1293 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001294 bool should_remove_invoke_instruction = false;
1295
1296 // If invoke_instruction is devirtualized to a different method, give intrinsics
1297 // another chance before we try to inline it.
1298 bool wrong_invoke_type = false;
1299 if (invoke_instruction->GetResolvedMethod() != method &&
1300 IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) {
1301 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1302 if (invoke_instruction->IsInvokeInterface()) {
1303 // We don't intrinsify an invoke-interface directly.
1304 // Replace the invoke-interface with an invoke-virtual.
1305 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1306 graph_->GetAllocator(),
1307 invoke_instruction->GetNumberOfArguments(),
1308 invoke_instruction->GetType(),
1309 invoke_instruction->GetDexPc(),
1310 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1311 method,
1312 method->GetMethodIndex());
1313 HInputsRef inputs = invoke_instruction->GetInputs();
1314 for (size_t index = 0; index != inputs.size(); ++index) {
1315 new_invoke->SetArgumentAt(index, inputs[index]);
1316 }
1317 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1318 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1319 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1320 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1321 }
1322 // Run intrinsic recognizer again to set new_invoke's intrinsic.
1323 IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type);
1324 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
1325 return_replacement = new_invoke;
1326 // invoke_instruction is replaced with new_invoke.
1327 should_remove_invoke_instruction = true;
1328 } else {
1329 // invoke_instruction is intrinsified and stays.
1330 }
1331 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001332 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001333 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001334 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1335 // better than an invoke-interface because:
1336 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1337 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1338 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001339
1340 if (method->IsDefault() && !method->IsCopied()) {
1341 // Changing to invoke-virtual cannot be done on an original default method
1342 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1343 // always uses a method in the iftable which is never an original default
1344 // method.
1345 // On the other hand, inlining an original default method by CHA is fine.
1346 DCHECK(cha_devirtualize);
1347 return false;
1348 }
1349
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001350 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001351 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001352 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001353 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001354 return false;
1355 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001356 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1357 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001358 invoke_instruction->GetNumberOfArguments(),
1359 invoke_instruction->GetType(),
1360 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001361 dex_method_index,
1362 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001363 method->GetMethodIndex());
1364 HInputsRef inputs = invoke_instruction->GetInputs();
1365 for (size_t index = 0; index != inputs.size(); ++index) {
1366 new_invoke->SetArgumentAt(index, inputs[index]);
1367 }
1368 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1369 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001370 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001371 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1372 }
1373 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001374 // invoke_instruction is replaced with new_invoke.
1375 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001376 } else {
1377 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1378 // compiler driver.
1379 return false;
1380 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001381 } else {
1382 // invoke_instruction is inlined.
1383 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001384 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001385
Mingyao Yang063fc772016-08-02 11:02:54 -07001386 if (cha_devirtualize) {
1387 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1388 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001389 if (return_replacement != nullptr) {
1390 invoke_instruction->ReplaceWith(return_replacement);
1391 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001392 if (should_remove_invoke_instruction) {
1393 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1394 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001395 FixUpReturnReferenceType(method, return_replacement);
1396 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1397 // Actual return value has a more specific type than the method's declared
1398 // return type. Run RTP again on the outer graph to propagate it.
1399 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001400 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001401 outer_compilation_unit_.GetDexCache(),
1402 handles_,
1403 /* is_first_run */ false).Run();
1404 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001405 return true;
1406}
1407
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001408size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1409 const HInliner* current = this;
1410 size_t count = 0;
1411 do {
1412 if (current->graph_->GetArtMethod() == method) {
1413 ++count;
1414 }
1415 current = current->parent_;
1416 } while (current != nullptr);
1417 return count;
1418}
1419
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001420bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1421 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001422 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001423 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001424 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001425 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001426 << "Method " << method->PrettyMethod()
1427 << " is not inlined because of unimplemented inline support for proxy methods.";
1428 return false;
1429 }
1430
1431 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001432 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001433 << "Method "
1434 << method->PrettyMethod()
1435 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001436 return false;
1437 }
1438
Jeff Haodcdc85b2015-12-04 14:06:18 -08001439 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1440 // dex file here (though the transitivity of an inline chain would allow checking the calller).
1441 if (!compiler_driver_->MayInline(method->GetDexFile(),
1442 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001443 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001444 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1445 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001446 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001447 return true;
1448 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001449 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001450 << "Won't inline " << method->PrettyMethod() << " in "
1451 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1452 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1453 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001454 return false;
1455 }
1456
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001457 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1458
David Sehr0225f8e2018-01-31 08:52:24 +00001459 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001460
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001461 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001462 LOG_FAIL_NO_STAT()
1463 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001464 return false;
1465 }
1466
Calin Juravleec748352015-07-29 13:52:12 +01001467 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001468 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001469 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001470 << "Method " << method->PrettyMethod()
1471 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001472 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001473 << " > "
1474 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001475 return false;
1476 }
1477
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001478 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001479 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001480 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001481 return false;
1482 }
1483
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001484 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001485 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001486 << "Method " << method->PrettyMethod()
1487 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Aart Bik897df032018-02-07 13:29:11 -08001488 return false;
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001489 }
1490
Aart Bik2c148f02018-02-02 14:30:35 -08001491 if (IsMethodUnverified(compiler_driver_, method)) {
1492 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
1493 << "Method " << method->PrettyMethod()
1494 << " couldn't be verified, so it cannot be inlined";
1495 return false;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001496 }
1497
Roland Levillain4c0eb422015-04-24 16:43:49 +01001498 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1499 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1500 // Case of a static method that cannot be inlined because it implicitly
1501 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001502 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1503 << "Method " << method->PrettyMethod()
1504 << " is not inlined because it is static and requires a clinit"
1505 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001506 return false;
1507 }
1508
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001509 if (!TryBuildAndInlineHelper(
1510 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001511 return false;
1512 }
1513
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001514 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001515 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001516 return true;
1517}
1518
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001519static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1520 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001521 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001522 size_t input_index = 0;
1523 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1524 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001525 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001526 ++i;
1527 DCHECK_NE(i, arg_vreg_index);
1528 }
1529 }
1530 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1531 return invoke_instruction->InputAt(input_index);
1532}
1533
1534// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1535bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1536 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001537 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001538 InlineMethod inline_method;
1539 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1540 return false;
1541 }
1542
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001543 switch (inline_method.opcode) {
1544 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001545 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001546 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001547 break;
1548 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001549 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1550 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001551 break;
1552 case kInlineOpNonWideConst:
1553 if (resolved_method->GetShorty()[0] == 'L') {
1554 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001555 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001556 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001557 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001558 }
1559 break;
1560 case kInlineOpIGet: {
1561 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1562 if (data.method_is_static || data.object_arg != 0u) {
1563 // TODO: Needs null check.
1564 return false;
1565 }
1566 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001567 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001568 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1569 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1570 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001571 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001572 break;
1573 }
1574 case kInlineOpIPut: {
1575 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1576 if (data.method_is_static || data.object_arg != 0u) {
1577 // TODO: Needs null check.
1578 return false;
1579 }
1580 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1581 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001582 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001583 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1584 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1585 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1586 if (data.return_arg_plus1 != 0u) {
1587 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001588 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001589 }
1590 break;
1591 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001592 case kInlineOpConstructor: {
1593 const InlineConstructorData& data = inline_method.d.constructor_data;
1594 // Get the indexes to arrays for easier processing.
1595 uint16_t iput_field_indexes[] = {
1596 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1597 };
1598 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1599 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1600 // Count valid field indexes.
1601 size_t number_of_iputs = 0u;
1602 while (number_of_iputs != arraysize(iput_field_indexes) &&
1603 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1604 // Check that there are no duplicate valid field indexes.
1605 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1606 iput_field_indexes + arraysize(iput_field_indexes),
1607 iput_field_indexes[number_of_iputs]));
1608 ++number_of_iputs;
1609 }
1610 // Check that there are no valid field indexes in the rest of the array.
1611 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1612 iput_field_indexes + arraysize(iput_field_indexes),
1613 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1614
1615 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Vladimir Marko354efa62016-02-04 19:46:56 +00001616 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1617 bool needs_constructor_barrier = false;
1618 for (size_t i = 0; i != number_of_iputs; ++i) {
1619 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001620 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001621 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001622 bool is_final;
1623 HInstanceFieldSet* iput =
1624 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001625 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1626
1627 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001628 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001629 needs_constructor_barrier = true;
1630 }
1631 }
1632 }
1633 if (needs_constructor_barrier) {
Igor Murashkind01745e2017-04-05 16:40:31 -07001634 // See CompilerDriver::RequiresConstructorBarrier for more details.
1635 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1636
1637 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001638 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001639 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1640 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001641 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001642 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001643 break;
1644 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001645 default:
1646 LOG(FATAL) << "UNREACHABLE";
1647 UNREACHABLE();
1648 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001649 return true;
1650}
1651
Vladimir Markof44d36c2017-03-14 14:18:46 +00001652HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1653 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001654 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001655 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001656 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1657 ArtField* resolved_field =
1658 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001659 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001660 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001661 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001662 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001663 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001664 resolved_field->GetOffset(),
1665 resolved_field->IsVolatile(),
1666 field_index,
1667 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001668 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001669 // Read barrier generates a runtime call in slow path and we need a valid
1670 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1671 /* dex_pc */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001672 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001673 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001674 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001675 ReferenceTypePropagation rtp(graph_,
1676 outer_compilation_unit_.GetClassLoader(),
1677 dex_cache,
1678 handles_,
1679 /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001680 rtp.Visit(iget);
1681 }
1682 return iget;
1683}
1684
Vladimir Markof44d36c2017-03-14 14:18:46 +00001685HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1686 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001687 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001688 HInstruction* value,
1689 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001690 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001691 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1692 ArtField* resolved_field =
1693 class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001694 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001695 if (is_final != nullptr) {
1696 // This information is needed only for constructors.
1697 DCHECK(referrer->IsConstructor());
1698 *is_final = resolved_field->IsFinal();
1699 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001700 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001701 obj,
1702 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001703 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001704 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001705 resolved_field->GetOffset(),
1706 resolved_field->IsVolatile(),
1707 field_index,
1708 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001709 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001710 // Read barrier generates a runtime call in slow path and we need a valid
1711 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1712 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001713 return iput;
1714}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001715
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001716template <typename T>
1717static inline Handle<T> NewHandleIfDifferent(T* object,
1718 Handle<T> hint,
1719 VariableSizedHandleScope* handles)
1720 REQUIRES_SHARED(Locks::mutator_lock_) {
1721 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1722}
1723
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001724bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1725 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001726 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001727 bool same_dex_file,
1728 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001729 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001730 ScopedObjectAccess soa(Thread::Current());
1731 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001732 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1733 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001734 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001735 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001736 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1737 caller_compilation_unit_.GetDexCache(),
1738 handles_);
1739 Handle<mirror::ClassLoader> class_loader =
1740 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1741 caller_compilation_unit_.GetClassLoader(),
1742 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001743
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001744 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001745 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001746 class_linker,
1747 callee_dex_file,
1748 code_item,
1749 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1750 method_index,
1751 resolved_method->GetAccessFlags(),
1752 /* verified_method */ nullptr,
1753 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001754
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001755 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001756 if (invoke_type == kInterface) {
1757 // We have statically resolved the dispatch. To please the class linker
1758 // at runtime, we change this call as if it was a virtual call.
1759 invoke_type = kVirtual;
1760 }
David Brazdil3f523062016-02-29 16:53:33 +00001761
1762 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001763 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1764 graph_->GetAllocator(),
1765 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001766 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001767 method_index,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001768 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001769 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001770 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001771 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001772 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001773 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001774
Vladimir Marko438709f2017-02-23 18:56:13 +00001775 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001776 // of on the stack, as Clang might produce a stack frame too large
1777 // for this function, that would not fit the requirements of the
1778 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001779 if (stats_ != nullptr) {
1780 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1781 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001782 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001783 inline_stats_ = new (storage) OptimizingCompilerStats;
1784 } else {
1785 inline_stats_->Reset();
1786 }
1787 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001788 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001789 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001790 &dex_compilation_unit,
1791 &outer_compilation_unit_,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001792 compiler_driver_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001793 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001794 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001795 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001796 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001797
David Brazdildee58d62016-04-07 09:54:26 +00001798 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001799 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001800 << "Method " << callee_dex_file.PrettyMethod(method_index)
1801 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001802 return false;
1803 }
1804
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001805 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1806 compiler_driver_->GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001807 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001808 << "Method " << callee_dex_file.PrettyMethod(method_index)
1809 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001810 return false;
1811 }
1812
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001813 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001814 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001815 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1816 !instructions.Done();
1817 instructions.Advance()) {
1818 HInstruction* current = instructions.Current();
1819 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001820 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001821 if (argument->IsNullConstant()) {
1822 current->ReplaceWith(callee_graph->GetNullConstant());
1823 } else if (argument->IsIntConstant()) {
1824 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1825 } else if (argument->IsLongConstant()) {
1826 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1827 } else if (argument->IsFloatConstant()) {
1828 current->ReplaceWith(
1829 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1830 } else if (argument->IsDoubleConstant()) {
1831 current->ReplaceWith(
1832 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001833 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001834 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1835 run_rtp = true;
1836 current->SetReferenceTypeInfo(receiver_type);
1837 } else {
1838 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1839 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001840 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1841 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001842 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001843 }
1844 }
1845
David Brazdil94ab38f2016-06-21 17:48:19 +01001846 // We have replaced formal arguments with actual arguments. If actual types
1847 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001848 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001849 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001850 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001851 dex_compilation_unit.GetDexCache(),
1852 handles_,
1853 /* is_first_run */ false).Run();
1854 }
1855
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001856 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001857
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001858 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1859 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001860 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001861 << "Method " << callee_dex_file.PrettyMethod(method_index)
1862 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001863 return false;
1864 }
1865
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001866 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001867 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1868 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001869 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1870 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001871 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001872 << "Method " << callee_dex_file.PrettyMethod(method_index)
1873 << " could not be inlined because one branch always throws and"
1874 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001875 return false;
1876 } else if (graph_->GetExitBlock() == nullptr) {
1877 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001878 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001879 << "Method " << callee_dex_file.PrettyMethod(method_index)
1880 << " could not be inlined because one branch always throws and"
1881 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001882 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001883 } else if (graph_->HasIrreducibleLoops()) {
1884 // TODO(ngeoffray): Support re-computing loop information to graphs with
1885 // irreducible loops?
1886 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1887 << " could not be inlined because one branch always throws and"
1888 << " caller has irreducible loops";
1889 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001890 }
1891 } else {
1892 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001893 }
1894 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001895
1896 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001897 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001898 << "Method " << callee_dex_file.PrettyMethod(method_index)
1899 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001900 return false;
1901 }
1902
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001903 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001904 // Skip the entry block, it does not contain instructions that prevent inlining.
1905 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001906 if (block->IsLoopHeader()) {
1907 if (block->GetLoopInformation()->IsIrreducible()) {
1908 // Don't inline methods with irreducible loops, they could prevent some
1909 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001910 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001911 << "Method " << callee_dex_file.PrettyMethod(method_index)
1912 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001913 return false;
1914 }
1915 if (!block->GetLoopInformation()->HasExitEdge()) {
1916 // Don't inline methods with loops without exit, since they cause the
1917 // loop information to be computed incorrectly when updating after
1918 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001919 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001920 << "Method " << callee_dex_file.PrettyMethod(method_index)
1921 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001922 return false;
1923 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001924 }
1925
1926 for (HInstructionIterator instr_it(block->GetInstructions());
1927 !instr_it.Done();
1928 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001929 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001930 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001931 << "Method " << callee_dex_file.PrettyMethod(method_index)
1932 << " is not inlined because the outer method has reached"
1933 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001934 return false;
1935 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001936 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001937 if (current->NeedsEnvironment() &&
1938 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001939 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001940 << "Method " << callee_dex_file.PrettyMethod(method_index)
1941 << " is not inlined because its caller has reached"
1942 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001943 return false;
1944 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001945
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001946 if (current->NeedsEnvironment() &&
1947 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1948 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001949 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001950 << "Method " << callee_dex_file.PrettyMethod(method_index)
1951 << " could not be inlined because " << current->DebugName()
1952 << " needs an environment, is in a different dex file"
1953 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001954 return false;
1955 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001956
Vladimir Markodc151b22015-10-15 18:02:30 +01001957 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001958 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001959 << "Method " << callee_dex_file.PrettyMethod(method_index)
1960 << " could not be inlined because " << current->DebugName()
1961 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001962 return false;
1963 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001964
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001965 if (current->IsUnresolvedStaticFieldGet() ||
1966 current->IsUnresolvedInstanceFieldGet() ||
1967 current->IsUnresolvedStaticFieldSet() ||
1968 current->IsUnresolvedInstanceFieldSet()) {
1969 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001970 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001971 << "Method " << callee_dex_file.PrettyMethod(method_index)
1972 << " could not be inlined because it is using an unresolved"
1973 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001974 return false;
1975 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001976 }
1977 }
David Brazdil3f523062016-02-29 16:53:33 +00001978 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1979 << "No instructions can be added to the outer graph while inner graph is being built";
1980
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001981 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00001982 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1983 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001984 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001985 // Update our budget for other inlining attempts in `caller_graph`.
1986 total_number_of_instructions_ += number_of_instructions;
1987 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00001988
1989 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1990 << "No instructions can be added to the inner graph during inlining into the outer graph";
1991
Vladimir Marko438709f2017-02-23 18:56:13 +00001992 if (stats_ != nullptr) {
1993 DCHECK(inline_stats_ != nullptr);
1994 inline_stats_->AddTo(stats_);
1995 }
1996
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001997 return true;
1998}
Calin Juravle2e768302015-07-28 14:41:11 +00001999
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002000void HInliner::RunOptimizations(HGraph* callee_graph,
2001 const DexFile::CodeItem* code_item,
2002 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01002003 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
2004 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00002005 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08002006 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Marko28e012a2017-12-07 11:22:59 +00002007 HSharpening sharpening(callee_graph, codegen_, compiler_driver_);
Vladimir Marko65979462017-05-19 17:25:12 +01002008 InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_);
Vladimir Marko438709f2017-02-23 18:56:13 +00002009 IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002010
2011 HOptimization* optimizations[] = {
2012 &intrinsics,
2013 &sharpening,
2014 &simplify,
2015 &fold,
2016 &dce,
2017 };
2018
2019 for (size_t i = 0; i < arraysize(optimizations); ++i) {
2020 HOptimization* optimization = optimizations[i];
2021 optimization->Run();
2022 }
2023
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002024 // Bail early for pathological cases on the environment (for example recursive calls,
2025 // or too large environment).
2026 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
2027 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2028 << " will not be inlined because the outer method has reached"
2029 << " its environment budget limit.";
2030 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002031 }
2032
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002033 // Bail early if we know we already are over the limit.
2034 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2035 if (number_of_instructions > inlining_budget_) {
2036 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2037 << " will not be inlined because the outer method has reached"
2038 << " its instruction budget limit. " << number_of_instructions;
2039 return;
2040 }
2041
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002042 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002043 HInliner inliner(callee_graph,
2044 outermost_graph_,
2045 codegen_,
2046 outer_compilation_unit_,
2047 dex_compilation_unit,
2048 compiler_driver_,
2049 handles_,
2050 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002051 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002052 total_number_of_instructions_ + number_of_instructions,
2053 this,
2054 depth_ + 1);
2055 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002056}
2057
David Brazdil94ab38f2016-06-21 17:48:19 +01002058static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2059 bool declared_can_be_null,
2060 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002061 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002062 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2063 return true;
2064 }
2065
2066 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2067 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002068 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002069}
2070
Vladimir Markob45528c2017-07-27 14:14:28 +01002071ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002072 return ReferenceTypePropagation::IsAdmissible(klass)
2073 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2074 : graph_->GetInexactObjectRti();
2075}
2076
2077bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2078 // If this is an instance call, test whether the type of the `this` argument
2079 // is more specific than the class which declares the method.
2080 if (!resolved_method->IsStatic()) {
2081 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
2082 /* declared_can_be_null */ false,
2083 invoke_instruction->InputAt(0u))) {
2084 return true;
2085 }
2086 }
2087
David Brazdil94ab38f2016-06-21 17:48:19 +01002088 // Iterate over the list of parameter types and test whether any of the
2089 // actual inputs has a more specific reference type than the type declared in
2090 // the signature.
2091 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
2092 for (size_t param_idx = 0,
2093 input_idx = resolved_method->IsStatic() ? 0 : 1,
2094 e = (param_list == nullptr ? 0 : param_list->Size());
2095 param_idx < e;
2096 ++param_idx, ++input_idx) {
2097 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002098 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002099 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2100 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002101 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
2102 /* declared_can_be_null */ true,
2103 input)) {
2104 return true;
2105 }
2106 }
2107 }
2108
2109 return false;
2110}
2111
2112bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2113 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002114 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002115 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002116 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002117 // Test if the return type is a refinement of the declared return type.
2118 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
2119 /* declared_can_be_null */ true,
2120 return_replacement)) {
2121 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002122 } else if (return_replacement->IsInstanceFieldGet()) {
2123 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002124 if (field_get->GetFieldInfo().GetField() ==
Vladimir Markob4eb1b12018-05-24 11:09:38 +01002125 GetClassRoot<mirror::Object>()->GetInstanceField(0)) {
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002126 return true;
2127 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002128 }
2129 } else if (return_replacement->IsInstanceOf()) {
2130 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2131 return true;
2132 }
2133 }
2134
2135 return false;
2136}
2137
2138void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2139 HInstruction* return_replacement) {
2140 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002141 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002142 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2143 // Make sure that we have a valid type for the return. We may get an invalid one when
2144 // we inline invokes with multiple branches and create a Phi for the result.
2145 // TODO: we could be more precise by merging the phi inputs but that requires
2146 // some functionality from the reference type propagation.
2147 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002148 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002149 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002150 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002151 }
Calin Juravle2e768302015-07-28 14:41:11 +00002152 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002153}
2154
2155} // namespace art