blob: 05414b32c7b4af079570217b64722482c1f069db [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080018#include "base/logging.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080020#include "dex_flags.h"
21#include "driver/compiler_driver.h"
22#include "driver/dex_compilation_unit.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010023#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080024#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000025#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070026#include "quick/dex_file_method_inliner.h"
27#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070028#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010029#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080030
31namespace art {
32
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070033static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010034 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080035}
36
37/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070038void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070039 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080040 constant_values_[ssa_reg] = value;
Vladimir Marko066f9e42015-01-16 16:04:43 +000041 reg_location_[ssa_reg].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080042}
43
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070044void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070045 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070046 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080047 constant_values_[ssa_reg] = Low32Bits(value);
48 constant_values_[ssa_reg + 1] = High32Bits(value);
Vladimir Marko066f9e42015-01-16 16:04:43 +000049 reg_location_[ssa_reg].is_const = true;
50 reg_location_[ssa_reg + 1].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080051}
52
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080053void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080054 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080055
56 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070057 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070058 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070059 return;
60 }
61
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070062 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080063
Ian Rogers29a26482014-05-02 15:27:29 -070064 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080065
66 if (!(df_attributes & DF_HAS_DEFS)) continue;
67
68 /* Handle instructions that set up constants directly */
69 if (df_attributes & DF_SETS_CONST) {
70 if (df_attributes & DF_DA) {
71 int32_t vB = static_cast<int32_t>(d_insn->vB);
72 switch (d_insn->opcode) {
73 case Instruction::CONST_4:
74 case Instruction::CONST_16:
75 case Instruction::CONST:
76 SetConstant(mir->ssa_rep->defs[0], vB);
77 break;
78 case Instruction::CONST_HIGH16:
79 SetConstant(mir->ssa_rep->defs[0], vB << 16);
80 break;
81 case Instruction::CONST_WIDE_16:
82 case Instruction::CONST_WIDE_32:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
84 break;
85 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070086 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080087 break;
88 case Instruction::CONST_WIDE_HIGH16:
89 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
90 break;
91 default:
92 break;
93 }
94 }
95 /* Handle instructions that set up constants directly */
96 } else if (df_attributes & DF_IS_MOVE) {
97 int i;
98
99 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -0700100 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -0800101 }
102 /* Move a register holding a constant to another register */
103 if (i == mir->ssa_rep->num_uses) {
104 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
105 if (df_attributes & DF_A_WIDE) {
106 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
107 }
108 }
109 }
110 }
111 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800112}
113
buzbee311ca162013-02-28 15:56:43 -0800114/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700115MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800116 BasicBlock* bb = *p_bb;
117 if (mir != NULL) {
118 mir = mir->next;
119 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700120 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800121 if ((bb == NULL) || Predecessors(bb) != 1) {
122 mir = NULL;
123 } else {
124 *p_bb = bb;
125 mir = bb->first_mir_insn;
126 }
127 }
128 }
129 return mir;
130}
131
132/*
133 * To be used at an invoke mir. If the logically next mir node represents
134 * a move-result, return it. Else, return NULL. If a move-result exists,
135 * it is required to immediately follow the invoke with no intervening
136 * opcodes or incoming arcs. However, if the result of the invoke is not
137 * used, a move-result may not be present.
138 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700139MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800140 BasicBlock* tbb = bb;
141 mir = AdvanceMIR(&tbb, mir);
142 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800143 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
144 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
145 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
146 break;
147 }
148 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700149 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800150 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700151 } else {
152 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800153 }
154 }
155 return mir;
156}
157
buzbee0d829482013-10-11 15:24:55 -0700158BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800159 if (bb->block_type == kDead) {
160 return NULL;
161 }
162 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
163 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700164 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
165 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800166 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700167 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700168 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700169 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700170 } else {
171 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700172 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700173 }
buzbee311ca162013-02-28 15:56:43 -0800174 if (bb == NULL || (Predecessors(bb) != 1)) {
175 return NULL;
176 }
177 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
178 return bb;
179}
180
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700181static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800182 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
183 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
184 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
185 if (mir->ssa_rep->uses[i] == ssa_name) {
186 return mir;
187 }
188 }
189 }
190 }
191 return NULL;
192}
193
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700194static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700195 // Work with the case when mir is nullptr.
196 if (mir == nullptr) {
197 return kSelectNone;
198 }
buzbee311ca162013-02-28 15:56:43 -0800199 switch (mir->dalvikInsn.opcode) {
200 case Instruction::MOVE:
201 case Instruction::MOVE_OBJECT:
202 case Instruction::MOVE_16:
203 case Instruction::MOVE_OBJECT_16:
204 case Instruction::MOVE_FROM16:
205 case Instruction::MOVE_OBJECT_FROM16:
206 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700207 case Instruction::CONST:
208 case Instruction::CONST_4:
209 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800210 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700211 case Instruction::GOTO:
212 case Instruction::GOTO_16:
213 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800214 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700215 default:
216 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800217 }
buzbee311ca162013-02-28 15:56:43 -0800218}
219
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220static constexpr ConditionCode kIfCcZConditionCodes[] = {
221 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
222};
223
Andreas Gampe785d2f22014-11-03 22:57:30 -0800224static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
225 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000226
Vladimir Markoa1a70742014-03-03 10:28:05 +0000227static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
228 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
229}
230
Andreas Gampe785d2f22014-11-03 22:57:30 -0800231static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
232static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
233static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
234static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
235static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
236static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000237
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700238int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100239 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
240 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumBytesForSpecialTemps() const {
244 // This logic is written with assumption that Method* is only special temp.
245 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
246 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800247}
248
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700249size_t MIRGraph::GetNumAvailableVRTemps() {
250 // First take into account all temps reserved for backend.
251 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
252 return 0;
253 }
254
255 // Calculate remaining ME temps available.
256 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
257
258 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
259 return 0;
260 } else {
261 return remaining_me_temps - num_non_special_compiler_temps_;
262 }
263}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000264
265// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800266static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700267 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000268 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800269
270CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700271 // Once the compiler temps have been committed, new ones cannot be requested anymore.
272 DCHECK_EQ(compiler_temps_committed_, false);
273 // Make sure that reserved for BE set is sane.
274 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
275
276 bool verbose = cu_->verbose;
277 const char* ct_type_str = nullptr;
278
279 if (verbose) {
280 switch (ct_type) {
281 case kCompilerTempBackend:
282 ct_type_str = "backend";
283 break;
284 case kCompilerTempSpecialMethodPtr:
285 ct_type_str = "method*";
286 break;
287 case kCompilerTempVR:
288 ct_type_str = "VR";
289 break;
290 default:
291 ct_type_str = "unknown";
292 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800293 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700294 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
295 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800296 }
297
298 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000299 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800300
301 // Create the type of temp requested. Special temps need special handling because
302 // they have a specific virtual register assignment.
303 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700304 // This has a special location on stack which is 32-bit or 64-bit depending
305 // on mode. However, we don't want to overlap with non-special section
306 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800307 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800308
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700309 // The vreg is always the first special temp for method ptr.
310 compiler_temp->v_reg = GetFirstSpecialTempVR();
311
312 } else if (ct_type == kCompilerTempBackend) {
313 requested_backend_temp_ = true;
314
315 // Make sure that we are not exceeding temps reserved for BE.
316 // Since VR temps cannot be requested once the BE temps are requested, we
317 // allow reservation of VR temps as well for BE. We
318 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
319 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
320 if (verbose) {
321 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
322 }
323 return nullptr;
324 }
325
326 // Update the remaining reserved temps since we have now used them.
327 // Note that the code below is actually subtracting to remove them from reserve
328 // once they have been claimed. It is careful to not go below zero.
329 if (reserved_temps_for_backend_ >= 1) {
330 reserved_temps_for_backend_--;
331 }
332 if (wide && reserved_temps_for_backend_ >= 1) {
333 reserved_temps_for_backend_--;
334 }
335
336 // The new non-special compiler temp must receive a unique v_reg.
337 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
338 num_non_special_compiler_temps_++;
339 } else if (ct_type == kCompilerTempVR) {
340 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
341 // This is done in order to prevent problems with ssa since these structures are allocated
342 // and managed by the ME.
343 DCHECK_EQ(requested_backend_temp_, false);
344
345 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
346 size_t available_temps = GetNumAvailableVRTemps();
347 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
348 if (verbose) {
349 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
350 }
351 return nullptr;
352 }
353
354 // The new non-special compiler temp must receive a unique v_reg.
355 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
356 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800357 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700358 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
359 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800360
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700361 // We allocate an sreg as well to make developer life easier.
362 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
363 // this sreg is no longer valid. The caller should be aware of this.
364 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
365
366 if (verbose) {
367 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
368 << " and s" << compiler_temp->s_reg_low << " has been created.";
369 }
370
371 if (wide) {
372 // Only non-special temps are handled as wide for now.
373 // Note that the number of non special temps is incremented below.
374 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
375
376 // Ensure that the two registers are consecutive.
377 int ssa_reg_low = compiler_temp->s_reg_low;
378 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800379 num_non_special_compiler_temps_++;
380
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700381 if (verbose) {
382 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
383 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
384 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700385
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700386 if (reg_location_ != nullptr) {
387 reg_location_[ssa_reg_high] = temp_loc;
388 reg_location_[ssa_reg_high].high_word = true;
389 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
390 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800391 }
392 }
393
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700394 // If the register locations have already been allocated, add the information
395 // about the temp. We will not overflow because they have been initialized
396 // to support the maximum number of temps. For ME temps that have multiple
397 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800398 if (reg_location_ != nullptr) {
399 int ssa_reg_low = compiler_temp->s_reg_low;
400 reg_location_[ssa_reg_low] = temp_loc;
401 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
402 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800403 }
404
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800405 return compiler_temp;
406}
buzbee311ca162013-02-28 15:56:43 -0800407
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000408static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
409 bool is_taken;
410 switch (opcode) {
411 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
412 case Instruction::IF_NE: is_taken = (src1 != src2); break;
413 case Instruction::IF_LT: is_taken = (src1 < src2); break;
414 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
415 case Instruction::IF_GT: is_taken = (src1 > src2); break;
416 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
417 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
418 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
419 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
420 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
421 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
422 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
423 default:
424 LOG(FATAL) << "Unexpected opcode " << opcode;
425 UNREACHABLE();
426 }
427 return is_taken;
428}
429
buzbee311ca162013-02-28 15:56:43 -0800430/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700431bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800432 if (bb->block_type == kDead) {
433 return true;
434 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800435 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
436 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
437 MultiplyAddOpt(bb);
438 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100439 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100440 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100441 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700442 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800443 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100444 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100445 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
446 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100447 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
448 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800449 }
buzbee311ca162013-02-28 15:56:43 -0800450 while (bb != NULL) {
451 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
452 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800453 if (use_lvn) {
454 local_valnum->GetValueNumber(mir);
455 }
buzbee311ca162013-02-28 15:56:43 -0800456 // Look for interesting opcodes, skip otherwise
457 Instruction::Code opcode = mir->dalvikInsn.opcode;
458 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000459 case Instruction::IF_EQ:
460 case Instruction::IF_NE:
461 case Instruction::IF_LT:
462 case Instruction::IF_GE:
463 case Instruction::IF_GT:
464 case Instruction::IF_LE:
465 if (!IsConst(mir->ssa_rep->uses[1])) {
466 break;
467 }
468 FALLTHROUGH_INTENDED;
469 case Instruction::IF_EQZ:
470 case Instruction::IF_NEZ:
471 case Instruction::IF_LTZ:
472 case Instruction::IF_GEZ:
473 case Instruction::IF_GTZ:
474 case Instruction::IF_LEZ:
475 // Result known at compile time?
476 if (IsConst(mir->ssa_rep->uses[0])) {
477 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
478 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
479 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
480 if (is_taken) {
481 // Replace with GOTO.
482 bb->fall_through = NullBasicBlockId;
483 mir->dalvikInsn.opcode = Instruction::GOTO;
484 mir->dalvikInsn.vA =
485 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
486 } else {
487 // Make NOP.
488 bb->taken = NullBasicBlockId;
489 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
490 }
491 mir->ssa_rep->num_uses = 0;
492 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
493 successor_to_unlink->ErasePredecessor(bb->id);
Vladimir Marko341e4252014-12-19 10:29:51 +0000494 // We have changed the graph structure.
495 dfs_orders_up_to_date_ = false;
496 domination_up_to_date_ = false;
497 topological_order_up_to_date_ = false;
498 // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input.
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000499 }
500 break;
buzbee311ca162013-02-28 15:56:43 -0800501 case Instruction::CMPL_FLOAT:
502 case Instruction::CMPL_DOUBLE:
503 case Instruction::CMPG_FLOAT:
504 case Instruction::CMPG_DOUBLE:
505 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700506 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800507 // Bitcode doesn't allow this optimization.
508 break;
509 }
510 if (mir->next != NULL) {
511 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800512 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700513 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800514 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
515 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000516 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700517 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800518 case Instruction::CMPL_FLOAT:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
521 break;
522 case Instruction::CMPL_DOUBLE:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
525 break;
526 case Instruction::CMPG_FLOAT:
527 mir_next->dalvikInsn.opcode =
528 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
529 break;
530 case Instruction::CMPG_DOUBLE:
531 mir_next->dalvikInsn.opcode =
532 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
533 break;
534 case Instruction::CMP_LONG:
535 mir_next->dalvikInsn.opcode =
536 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
537 break;
538 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
539 }
540 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800541 // Clear use count of temp VR.
542 use_counts_[mir->ssa_rep->defs[0]] = 0;
543 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700544 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800545 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
546 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
547 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
548 mir_next->ssa_rep->num_defs = 0;
549 mir->ssa_rep->num_uses = 0;
550 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700551 // Copy in the decoded instruction information for potential SSA re-creation.
552 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
553 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800554 }
555 }
556 break;
buzbee311ca162013-02-28 15:56:43 -0800557 default:
558 break;
559 }
560 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800561 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800562 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800563 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100564 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000565 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700566 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800567 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700568 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
569 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800570
buzbee0d829482013-10-11 15:24:55 -0700571 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800572 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700573 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
574 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800575
576 /*
577 * In the select pattern, the taken edge goes to a block that unconditionally
578 * transfers to the rejoin block and the fall_though edge goes to a block that
579 * unconditionally falls through to the rejoin block.
580 */
581 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
582 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
583 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000584 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800585 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100586
587 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800588 // Are the block bodies something we can handle?
589 if ((ft->first_mir_insn == ft->last_mir_insn) &&
590 (tk->first_mir_insn != tk->last_mir_insn) &&
591 (tk->first_mir_insn->next == tk->last_mir_insn) &&
592 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
593 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
594 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
595 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
596 // Almost there. Are the instructions targeting the same vreg?
597 MIR* if_true = tk->first_mir_insn;
598 MIR* if_false = ft->first_mir_insn;
599 // It's possible that the target of the select isn't used - skip those (rare) cases.
600 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
601 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
602 /*
603 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
604 * Phi node in the merge block and delete it (while using the SSA name
605 * of the merge as the target of the SELECT. Delete both taken and
606 * fallthrough blocks, and set fallthrough to merge block.
607 * NOTE: not updating other dataflow info (no longer used at this point).
608 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
609 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000610 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800611 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
612 bool const_form = (SelectKind(if_true) == kSelectConst);
613 if ((SelectKind(if_true) == kSelectMove)) {
614 if (IsConst(if_true->ssa_rep->uses[0]) &&
615 IsConst(if_false->ssa_rep->uses[0])) {
616 const_form = true;
617 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
618 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
619 }
620 }
621 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800622 /*
623 * TODO: If both constants are the same value, then instead of generating
624 * a select, we should simply generate a const bytecode. This should be
625 * considered after inlining which can lead to CFG of this form.
626 */
buzbee311ca162013-02-28 15:56:43 -0800627 // "true" set val in vB
628 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
629 // "false" set val in vC
630 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
631 } else {
632 DCHECK_EQ(SelectKind(if_true), kSelectMove);
633 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700634 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000635 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800636 src_ssa[0] = mir->ssa_rep->uses[0];
637 src_ssa[1] = if_true->ssa_rep->uses[0];
638 src_ssa[2] = if_false->ssa_rep->uses[0];
639 mir->ssa_rep->uses = src_ssa;
640 mir->ssa_rep->num_uses = 3;
641 }
642 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700643 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000644 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700645 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000646 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800647 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700648 // Match type of uses to def.
649 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700650 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000651 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700652 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
653 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
654 }
buzbee311ca162013-02-28 15:56:43 -0800655 /*
656 * There is usually a Phi node in the join block for our two cases. If the
657 * Phi node only contains our two cases as input, we will use the result
658 * SSA name of the Phi node as our select result and delete the Phi. If
659 * the Phi node has more than two operands, we will arbitrarily use the SSA
Vladimir Marko341e4252014-12-19 10:29:51 +0000660 * name of the "false" path, delete the SSA name of the "true" path from the
buzbee311ca162013-02-28 15:56:43 -0800661 * Phi node (and fix up the incoming arc list).
662 */
663 if (phi->ssa_rep->num_uses == 2) {
664 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000665 // Rather than changing the Phi to kMirOpNop, remove it completely.
666 // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn.
667 tk_tk->RemoveMIR(phi);
668 int dead_false_def = if_false->ssa_rep->defs[0];
669 raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0;
buzbee311ca162013-02-28 15:56:43 -0800670 } else {
Vladimir Marko341e4252014-12-19 10:29:51 +0000671 int live_def = if_false->ssa_rep->defs[0];
buzbee311ca162013-02-28 15:56:43 -0800672 mir->ssa_rep->defs[0] = live_def;
buzbee311ca162013-02-28 15:56:43 -0800673 }
Vladimir Marko341e4252014-12-19 10:29:51 +0000674 int dead_true_def = if_true->ssa_rep->defs[0];
675 raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0;
676 // We want to remove ft and tk and link bb directly to ft_ft. First, we need
677 // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id)
678 // since the live_def above comes from ft->first_mir_insn (if_false).
679 DCHECK(if_false == ft->first_mir_insn);
680 ft_ft->UpdatePredecessor(ft->id, bb->id);
681 // Correct the rest of the links between bb, ft and ft_ft.
682 ft->ErasePredecessor(bb->id);
683 ft->fall_through = NullBasicBlockId;
684 bb->fall_through = ft_ft->id;
685 // Now we can kill tk and ft.
686 tk->Kill(this);
687 ft->Kill(this);
688 // NOTE: DFS order, domination info and topological order are still usable
689 // despite the newly dead blocks.
buzbee311ca162013-02-28 15:56:43 -0800690 }
691 }
692 }
693 }
694 }
buzbee1da1e2f2013-11-15 13:37:01 -0800695 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800696 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100697 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100698 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
699 }
buzbee311ca162013-02-28 15:56:43 -0800700
buzbee311ca162013-02-28 15:56:43 -0800701 return true;
702}
703
buzbee311ca162013-02-28 15:56:43 -0800704/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700705void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700706 if (bb->data_flow_info != NULL) {
707 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
708 if (mir->ssa_rep == NULL) {
709 continue;
buzbee311ca162013-02-28 15:56:43 -0800710 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700711 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700712 if (df_attributes & DF_HAS_NULL_CHKS) {
713 checkstats_->null_checks++;
714 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
715 checkstats_->null_checks_eliminated++;
716 }
717 }
718 if (df_attributes & DF_HAS_RANGE_CHKS) {
719 checkstats_->range_checks++;
720 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
721 checkstats_->range_checks_eliminated++;
722 }
buzbee311ca162013-02-28 15:56:43 -0800723 }
724 }
725 }
buzbee311ca162013-02-28 15:56:43 -0800726}
727
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700728/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700729bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700730 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800731 if (!bb->explicit_throw) {
732 return false;
733 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700734
735 // If we visited it, we are done.
736 if (bb->visited) {
737 return false;
738 }
739 bb->visited = true;
740
buzbee311ca162013-02-28 15:56:43 -0800741 BasicBlock* walker = bb;
742 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700743 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800744 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
745 break;
746 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100747 DCHECK(!walker->predecessors.empty());
748 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700749
750 // If we visited the predecessor, we are done.
751 if (prev->visited) {
752 return false;
753 }
754 prev->visited = true;
755
buzbee311ca162013-02-28 15:56:43 -0800756 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700757 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700758 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800759 break;
760 }
buzbee0d829482013-10-11 15:24:55 -0700761 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700762 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800763 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
764 switch (opcode) {
765 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
766 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
767 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
768 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
769 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
770 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
771 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
772 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
773 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
774 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
775 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
776 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
777 default: LOG(FATAL) << "Unexpected opcode " << opcode;
778 }
779 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700780 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800781 prev->taken = prev->fall_through;
782 prev->fall_through = t_bb;
783 break;
784 }
785 walker = prev;
786 }
787 return false;
788}
789
790/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700791void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800792 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100793 while ((bb->block_type == kDalvikByteCode) &&
794 (bb->last_mir_insn != nullptr) &&
795 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
796 MIR* mir = bb->last_mir_insn;
797 DCHECK(bb->first_mir_insn != nullptr);
798
Vladimir Marko315cc202014-12-18 17:01:02 +0000799 // Get the paired insn and check if it can still throw.
Vladimir Marko312eb252014-10-07 15:01:57 +0100800 MIR* throw_insn = mir->meta.throw_insn;
Vladimir Marko315cc202014-12-18 17:01:02 +0000801 if (CanThrow(throw_insn)) {
buzbee311ca162013-02-28 15:56:43 -0800802 break;
803 }
804
buzbee311ca162013-02-28 15:56:43 -0800805 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700806 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800807 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100808 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700809
810 // Now move instructions from bb_next to bb. Start off with doing a sanity check
811 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800812 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700813 // Now move all instructions (throw instruction to last one) from bb_next to bb.
814 MIR* last_to_move = bb_next->last_mir_insn;
815 bb_next->RemoveMIRList(throw_insn, last_to_move);
816 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
817 // The kMirOpCheck instruction is not needed anymore.
818 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
819 bb->RemoveMIR(mir);
820
Vladimir Marko312eb252014-10-07 15:01:57 +0100821 // Before we overwrite successors, remove their predecessor links to bb.
822 bb_next->ErasePredecessor(bb->id);
823 if (bb->taken != NullBasicBlockId) {
824 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
825 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
826 // bb->taken will be overwritten below.
827 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
828 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
829 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
830 bb_taken->predecessors.clear();
831 bb_taken->block_type = kDead;
832 DCHECK(bb_taken->data_flow_info == nullptr);
833 } else {
834 DCHECK_EQ(bb->successor_block_list_type, kCatch);
835 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
836 if (succ_info->block != NullBasicBlockId) {
837 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
838 DCHECK(succ_bb->catch_entry);
839 succ_bb->ErasePredecessor(bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100840 }
841 }
842 }
buzbee311ca162013-02-28 15:56:43 -0800843 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700844 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100845 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100846 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800847 // Use the ending block linkage from the next block
848 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100849 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800850 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100851 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800852 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900853 * If lower-half of pair of blocks to combine contained
854 * a return or a conditional branch or an explicit throw,
855 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800856 */
857 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900858 bb->conditional_branch = bb_next->conditional_branch;
859 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100860 // Merge the use_lvn flag.
861 bb->use_lvn |= bb_next->use_lvn;
862
863 // Kill the unused block.
864 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800865
866 /*
867 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
868 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100869 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800870 */
871
Vladimir Marko312eb252014-10-07 15:01:57 +0100872 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800873 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100874 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700875 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100876 // Update predecessors in children.
877 ChildBlockIterator iter(bb, this);
878 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
879 child->UpdatePredecessor(bb_next->id, bb->id);
880 }
881
Vladimir Markoffda4992014-12-18 17:05:58 +0000882 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100883 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000884 domination_up_to_date_ = false;
885 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800886
887 // Now, loop back and see if we can keep going
888 }
buzbee311ca162013-02-28 15:56:43 -0800889}
890
Vladimir Marko67c72b82014-10-09 12:26:10 +0100891bool MIRGraph::EliminateNullChecksGate() {
892 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
893 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
894 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000895 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100896
Vladimir Marko67c72b82014-10-09 12:26:10 +0100897 DCHECK(temp_scoped_alloc_.get() == nullptr);
898 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700899 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000900 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
901 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
902 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100903 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000904 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700905
906 // reset MIR_MARK
907 AllNodesIterator iter(this);
908 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
909 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
910 mir->optimization_flags &= ~MIR_MARK;
911 }
912 }
913
Vladimir Marko67c72b82014-10-09 12:26:10 +0100914 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000915}
916
buzbee1da1e2f2013-11-15 13:37:01 -0800917/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100918 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800919 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100920bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100921 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
922 // Ignore the kExitBlock as well.
923 DCHECK(bb->first_mir_insn == nullptr);
924 return false;
925 }
buzbee311ca162013-02-28 15:56:43 -0800926
Vladimir Markof585e542014-11-21 13:41:32 +0000927 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100928 /*
929 * Set initial state. Catch blocks don't need any special treatment.
930 */
931 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100932 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100933 // Assume all ins are objects.
934 for (uint16_t in_reg = GetFirstInVR();
935 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100936 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100937 }
938 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100939 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100940 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100941 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100942 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100943 } else {
944 DCHECK_EQ(bb->block_type, kDalvikByteCode);
945 // Starting state is union of all incoming arcs.
946 bool copied_first = false;
947 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000948 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100949 continue;
950 }
951 BasicBlock* pred_bb = GetBasicBlock(pred_id);
952 DCHECK(pred_bb != nullptr);
953 MIR* null_check_insn = nullptr;
954 if (pred_bb->block_type == kDalvikByteCode) {
955 // Check to see if predecessor had an explicit null-check.
956 MIR* last_insn = pred_bb->last_mir_insn;
957 if (last_insn != nullptr) {
958 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
959 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
960 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
961 // Remember the null check insn if there's no other predecessor requiring null check.
962 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
963 null_check_insn = last_insn;
964 }
buzbee1da1e2f2013-11-15 13:37:01 -0800965 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700966 }
967 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100968 if (!copied_first) {
969 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000970 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100971 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000972 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100973 }
974 if (null_check_insn != nullptr) {
975 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100976 }
977 }
978 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800979 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100980 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100981 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800982
983 // Walk through the instruction in the block, updating as necessary
984 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700985 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800986
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700987 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
988 // The algorithm was written in a phi agnostic way.
989 continue;
990 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100991
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000992 // Might need a null check?
993 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100994 int src_vreg;
995 if (df_attributes & DF_NULL_CHK_OUT0) {
996 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
997 src_vreg = mir->dalvikInsn.vC;
998 } else if (df_attributes & DF_NULL_CHK_B) {
999 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1000 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001001 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001002 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1003 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1004 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001005 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001006 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001007 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001008 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001009 } else {
1010 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001011 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001012 // Mark src_vreg as null-checked.
1013 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001014 }
1015 }
1016
1017 if ((df_attributes & DF_A_WIDE) ||
1018 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1019 continue;
1020 }
1021
1022 /*
1023 * First, mark all object definitions as requiring null check.
1024 * Note: we can't tell if a CONST definition might be used as an object, so treat
1025 * them all as object definitions.
1026 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001027 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001028 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001029 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001030 }
1031
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001032 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001033 if (df_attributes & DF_NON_NULL_DST) {
1034 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001035 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1036 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001037 }
1038
buzbee311ca162013-02-28 15:56:43 -08001039 // Mark non-null returns from invoke-style NEW*
1040 if (df_attributes & DF_NON_NULL_RET) {
1041 MIR* next_mir = mir->next;
1042 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001043 if (UNLIKELY(next_mir == nullptr)) {
1044 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1045 // target, so the MOVE_RESULT cannot be broken away into another block.
1046 LOG(WARNING) << "Unexpected end of block following new";
1047 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1048 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001049 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001050 // Mark as null checked.
1051 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001052 }
1053 }
1054
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001055 // Propagate null check state on register copies.
1056 if (df_attributes & DF_NULL_TRANSFER_0) {
1057 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1058 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1059 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001060 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001061 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001062 }
1063 }
buzbee311ca162013-02-28 15:56:43 -08001064 }
1065
1066 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001067 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001068 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001069 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001070 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001071 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001072 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001073 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001074 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1075 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001076 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001077 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001078 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1079 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001080 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001081 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001082}
1083
Vladimir Marko67c72b82014-10-09 12:26:10 +01001084void MIRGraph::EliminateNullChecksEnd() {
1085 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001086 temp_.nce.num_vregs = 0u;
1087 temp_.nce.work_vregs_to_check = nullptr;
1088 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001089 DCHECK(temp_scoped_alloc_.get() != nullptr);
1090 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001091
1092 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001093 AllNodesIterator iter(this);
1094 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1095 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001096 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001097 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001098 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001099 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001100 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1101 }
1102 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001103}
1104
1105/*
1106 * Perform type and size inference for a basic block.
1107 */
1108bool MIRGraph::InferTypes(BasicBlock* bb) {
1109 if (bb->data_flow_info == nullptr) return false;
1110
1111 bool infer_changed = false;
1112 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1113 if (mir->ssa_rep == NULL) {
1114 continue;
1115 }
1116
1117 // Propagate type info.
1118 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1119 }
1120
1121 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001122}
1123
1124bool MIRGraph::EliminateClassInitChecksGate() {
1125 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001126 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001127 return false;
1128 }
1129
Vladimir Markobfea9c22014-01-17 17:49:33 +00001130 DCHECK(temp_scoped_alloc_.get() == nullptr);
1131 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1132
1133 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001134 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001135 temp_.cice.indexes = static_cast<uint16_t*>(
1136 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1137 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001138
1139 uint32_t unique_class_count = 0u;
1140 {
1141 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1142 // ScopedArenaAllocator.
1143
1144 // Embed the map value in the entry to save space.
1145 struct MapEntry {
1146 // Map key: the class identified by the declaring dex file and type index.
1147 const DexFile* declaring_dex_file;
1148 uint16_t declaring_class_idx;
1149 // Map value: index into bit vectors of classes requiring initialization checks.
1150 uint16_t index;
1151 };
1152 struct MapEntryComparator {
1153 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1154 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1155 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1156 }
1157 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1158 }
1159 };
1160
Vladimir Markobfea9c22014-01-17 17:49:33 +00001161 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001162 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1163 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001164
1165 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1166 AllNodesIterator iter(this);
1167 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001168 if (bb->block_type == kDalvikByteCode) {
1169 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001170 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001171 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001172 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001173 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1174 MapEntry entry = {
1175 // Treat unresolved fields as if each had its own class.
1176 field_info.IsResolved() ? field_info.DeclaringDexFile()
1177 : nullptr,
1178 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1179 : field_info.FieldIndex(),
1180 static_cast<uint16_t>(class_to_index_map.size())
1181 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001182 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001183 // Using offset/2 for index into temp_.cice.indexes.
1184 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001185 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001186 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001187 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1188 DCHECK(method_info.IsStatic());
1189 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1190 MapEntry entry = {
1191 method_info.DeclaringDexFile(),
1192 method_info.DeclaringClassIndex(),
1193 static_cast<uint16_t>(class_to_index_map.size())
1194 };
1195 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001196 // Using offset/2 for index into temp_.cice.indexes.
1197 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001198 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001199 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001200 }
1201 }
1202 }
1203 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1204 }
1205
1206 if (unique_class_count == 0u) {
1207 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001208 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001209 temp_scoped_alloc_.reset();
1210 return false;
1211 }
1212
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001213 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001214 temp_.cice.num_class_bits = 2u * unique_class_count;
1215 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1216 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1217 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001218 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001219 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1220 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001221 return true;
1222}
1223
1224/*
1225 * Eliminate unnecessary class initialization checks for a basic block.
1226 */
1227bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1228 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001229 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1230 // Ignore the kExitBlock as well.
1231 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001232 return false;
1233 }
1234
1235 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001236 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001237 */
Vladimir Markof585e542014-11-21 13:41:32 +00001238 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001239 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001240 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001241 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001242 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001243 // Starting state is union of all incoming arcs.
1244 bool copied_first = false;
1245 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001246 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001247 continue;
1248 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001249 if (!copied_first) {
1250 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001251 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001252 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001253 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001254 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001255 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001256 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001257 }
1258 // At this point, classes_to_check shows which classes need clinit checks.
1259
1260 // Walk through the instruction in the block, updating as necessary
1261 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001262 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001263 if (index != 0xffffu) {
1264 bool check_initialization = false;
1265 bool check_dex_cache = false;
1266
1267 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1268 // Dex instructions with width 1 can have the same offset/2.
1269
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001270 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001271 check_initialization = true;
1272 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001273 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001274 check_initialization = true;
1275 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1276 }
1277
1278 if (check_dex_cache) {
1279 uint32_t check_dex_cache_index = 2u * index + 1u;
1280 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1281 // Eliminate the class init check.
1282 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1283 } else {
1284 // Do the class init check.
1285 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1286 }
1287 classes_to_check->ClearBit(check_dex_cache_index);
1288 }
1289 if (check_initialization) {
1290 uint32_t check_clinit_index = 2u * index;
1291 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1292 // Eliminate the class init check.
1293 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1294 } else {
1295 // Do the class init check.
1296 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001297 }
1298 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001299 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001300 }
1301 }
1302 }
1303
1304 // Did anything change?
1305 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001306 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001307 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001308 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001309 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001310 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001311 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001312 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1313 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001314 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001315 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001316 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1317 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001318 }
1319 return changed;
1320}
1321
1322void MIRGraph::EliminateClassInitChecksEnd() {
1323 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001324 temp_.cice.num_class_bits = 0u;
1325 temp_.cice.work_classes_to_check = nullptr;
1326 temp_.cice.ending_classes_to_check_matrix = nullptr;
1327 DCHECK(temp_.cice.indexes != nullptr);
1328 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001329 DCHECK(temp_scoped_alloc_.get() != nullptr);
1330 temp_scoped_alloc_.reset();
1331}
1332
Vladimir Marko95a05972014-05-30 10:01:32 +01001333bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001334 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001335 return false;
1336 }
1337
1338 DCHECK(temp_scoped_alloc_ == nullptr);
1339 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001340 temp_.gvn.ifield_ids_ =
1341 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1342 temp_.gvn.sfield_ids_ =
1343 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001344 DCHECK(temp_.gvn.gvn == nullptr);
1345 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1346 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001347 return true;
1348}
1349
1350bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001351 DCHECK(temp_.gvn.gvn != nullptr);
1352 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001353 if (lvn != nullptr) {
1354 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1355 lvn->GetValueNumber(mir);
1356 }
1357 }
Vladimir Markof585e542014-11-21 13:41:32 +00001358 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001359 return change;
1360}
1361
1362void MIRGraph::ApplyGlobalValueNumberingEnd() {
1363 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001364 DCHECK(temp_.gvn.gvn != nullptr);
1365 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001366 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001367 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001368 TopologicalSortIterator iter(this);
1369 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1370 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001371 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001372 if (lvn != nullptr) {
1373 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1374 lvn->GetValueNumber(mir);
1375 }
Vladimir Markof585e542014-11-21 13:41:32 +00001376 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001377 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001378 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001379 }
1380 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001381 // GVN was successful, running the LVN would be useless.
1382 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001383 } else {
1384 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1385 }
1386
Vladimir Markof585e542014-11-21 13:41:32 +00001387 delete temp_.gvn.gvn;
1388 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001389 temp_.gvn.ifield_ids_ = nullptr;
1390 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001391 DCHECK(temp_scoped_alloc_ != nullptr);
1392 temp_scoped_alloc_.reset();
1393}
1394
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001395void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1396 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001397 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1398 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001399 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1400 return;
1401 }
1402
1403 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1404 MethodReference target = method_info.GetTargetMethod();
1405 DexCompilationUnit inlined_unit(
1406 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1407 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1408 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001409 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1410 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001411 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1412 DCHECK(inlined_field_info.IsResolved());
1413
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001414 uint32_t field_info_index = ifield_lowering_infos_.size();
1415 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001416 temp_.smi.processed_indexes->SetBit(method_index);
1417 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001418 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1419}
1420
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001421bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001422 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001423 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001424 return false;
1425 }
1426 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1427 // This isn't the Quick compiler.
1428 return false;
1429 }
1430 return true;
1431}
1432
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001433void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001434 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1435 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1436
1437 DCHECK(temp_scoped_alloc_.get() == nullptr);
1438 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001439 temp_.smi.num_indexes = method_lowering_infos_.size();
1440 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1441 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1442 temp_.smi.processed_indexes->ClearAllBits();
1443 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1444 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001445}
1446
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001447void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001448 if (bb->block_type != kDalvikByteCode) {
1449 return;
1450 }
1451 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001452 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001453 continue;
1454 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001455 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001456 continue;
1457 }
1458 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1459 if (!method_info.FastPath()) {
1460 continue;
1461 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001462
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001463 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001464 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001465 continue;
1466 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001467
1468 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001469 bool needs_clinit = !method_info.IsClassInitialized() &&
1470 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001471 if (needs_clinit) {
1472 continue;
1473 }
1474 }
1475
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001476 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1477 MethodReference target = method_info.GetTargetMethod();
1478 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1479 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001480 if (cu_->verbose || cu_->print_pass) {
1481 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1482 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1483 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1484 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001485 }
1486 }
1487 }
1488}
1489
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001490void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001491 // Clean up temporaries.
1492 DCHECK(temp_.smi.lowering_infos != nullptr);
1493 temp_.smi.lowering_infos = nullptr;
1494 temp_.smi.num_indexes = 0u;
1495 DCHECK(temp_.smi.processed_indexes != nullptr);
1496 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001497 DCHECK(temp_scoped_alloc_.get() != nullptr);
1498 temp_scoped_alloc_.reset();
1499}
1500
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001501void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001502 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001503 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001504 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001505 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001506 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1507 CountChecks(bb);
1508 }
1509 if (stats->null_checks > 0) {
1510 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1511 float checks = static_cast<float>(stats->null_checks);
1512 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1513 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1514 << (eliminated/checks) * 100.0 << "%";
1515 }
1516 if (stats->range_checks > 0) {
1517 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1518 float checks = static_cast<float>(stats->range_checks);
1519 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1520 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1521 << (eliminated/checks) * 100.0 << "%";
1522 }
1523}
1524
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001525bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001526 if (bb->visited) return false;
1527 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1528 || (bb->block_type == kExitBlock))) {
1529 // Ignore special blocks
1530 bb->visited = true;
1531 return false;
1532 }
1533 // Must be head of extended basic block.
1534 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001535 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001536 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001537 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001538 // Visit blocks strictly dominated by this head.
1539 while (bb != NULL) {
1540 bb->visited = true;
1541 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001542 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001543 bb = NextDominatedBlock(bb);
1544 }
buzbee1da1e2f2013-11-15 13:37:01 -08001545 if (terminated_by_return || do_local_value_numbering) {
1546 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001547 bb = start_bb;
1548 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001549 bb->use_lvn = do_local_value_numbering;
1550 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001551 bb = NextDominatedBlock(bb);
1552 }
1553 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001554 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001555}
1556
Vladimir Markoffda4992014-12-18 17:05:58 +00001557void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001558 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1559 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1560 temp_.gvn.ifield_ids_ =
1561 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1562 temp_.gvn.sfield_ids_ =
1563 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1564 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001565}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001566
Vladimir Markoffda4992014-12-18 17:05:58 +00001567void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001568 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1569 ClearAllVisitedFlags();
1570 PreOrderDfsIterator iter2(this);
1571 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1572 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001573 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001574 // Perform extended basic block optimizations.
1575 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1576 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1577 }
1578 } else {
1579 PreOrderDfsIterator iter(this);
1580 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1581 BasicBlockOpt(bb);
1582 }
buzbee311ca162013-02-28 15:56:43 -08001583 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001584}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001585
Vladimir Markoffda4992014-12-18 17:05:58 +00001586void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001587 // Clean up after LVN.
1588 temp_.gvn.ifield_ids_ = nullptr;
1589 temp_.gvn.sfield_ids_ = nullptr;
1590 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001591}
1592
Vladimir Marko8b858e12014-11-27 14:52:37 +00001593bool MIRGraph::EliminateSuspendChecksGate() {
1594 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1595 GetMaxNestedLoops() == 0u || // Nothing to do.
1596 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1597 // Exclude 32 as well to keep bit shifts well-defined.
1598 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1599 return false;
1600 }
1601 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1602 temp_.sce.inliner =
1603 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1604 }
1605 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1606 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1607 return true;
1608}
1609
1610bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1611 if (bb->block_type != kDalvikByteCode) {
1612 return false;
1613 }
1614 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1615 if (bb->nesting_depth == 0u) {
1616 // Out of loops.
1617 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1618 return false;
1619 }
1620 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1621 bool found_invoke = false;
1622 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1623 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1624 (temp_.sce.inliner == nullptr ||
1625 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1626 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1627 found_invoke = true;
1628 break;
1629 }
1630 }
1631 if (!found_invoke) {
1632 // Intersect suspend checks from predecessors.
1633 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1634 uint32_t pred_mask_union = 0u;
1635 for (BasicBlockId pred_id : bb->predecessors) {
1636 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1637 if (pred_topo_idx < bb_topo_idx) {
1638 // Determine the loop depth of the predecessors relative to this block.
1639 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1640 while (pred_loop_depth != 0u &&
1641 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1642 --pred_loop_depth;
1643 }
1644 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1645 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1646 // Intersect pred_mask bits in suspend_checks_in_loops with
1647 // suspend_checks_in_loops_[pred_id].
1648 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1649 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1650 pred_mask_union |= pred_mask;
1651 }
1652 }
1653 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1654 pred_mask_union);
1655 suspend_checks_in_loops &= pred_mask_union;
1656 }
1657 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1658 if (suspend_checks_in_loops == 0u) {
1659 return false;
1660 }
1661 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1662 if (bb->taken != NullBasicBlockId) {
1663 DCHECK(bb->last_mir_insn != nullptr);
1664 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1665 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1666 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1667 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1668 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1669 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1670 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1671 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1672 }
1673 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1674 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1675 MIR* mir = NewMIR();
1676 mir->dalvikInsn.opcode = Instruction::GOTO;
1677 mir->dalvikInsn.vA = 0; // Branch offset.
1678 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1679 mir->m_unit_index = current_method_;
1680 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1681 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1682 bb->AppendMIR(mir);
1683 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1684 }
1685 return true;
1686}
1687
1688void MIRGraph::EliminateSuspendChecksEnd() {
1689 temp_.sce.inliner = nullptr;
1690}
1691
Ningsheng Jiana262f772014-11-25 16:48:07 +08001692bool MIRGraph::CanThrow(MIR* mir) {
1693 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1694 return false;
1695 }
1696 const int opt_flags = mir->optimization_flags;
1697 uint64_t df_attributes = GetDataFlowAttributes(mir);
1698
Vladimir Marko315cc202014-12-18 17:01:02 +00001699 // First, check if the insn can still throw NPE.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001700 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1701 return true;
1702 }
Vladimir Marko315cc202014-12-18 17:01:02 +00001703
1704 // Now process specific instructions.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001705 if ((df_attributes & DF_IFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001706 // The IGET/IPUT family. We have processed the IGET/IPUT null check above.
1707 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1708 // If not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001709 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001710 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
1711 return !fast;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001712 } else if ((df_attributes & DF_SFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001713 // The SGET/SPUT family. Check for potentially throwing class initialization.
1714 // Also, if not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001715 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001716 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
Ningsheng Jiana262f772014-11-25 16:48:07 +08001717 bool is_class_initialized = field_info.IsClassInitialized() ||
1718 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
Vladimir Marko315cc202014-12-18 17:01:02 +00001719 return !(fast && is_class_initialized);
1720 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1721 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
1722 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1723 // Non-throwing only if range check has been eliminated.
1724 return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0);
1725 } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
1726 mir->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
1727 static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) {
1728 // No more checks for these (null check was processed above).
1729 return false;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001730 }
1731 return true;
1732}
1733
1734bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1735 DCHECK(first->ssa_rep != nullptr);
1736 DCHECK(second->ssa_rep != nullptr);
1737 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1738 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1739 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1740 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1741 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1742 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1743 if (use == vreg0 || use == vreg1) {
1744 return true;
1745 }
1746 }
1747 }
1748 return false;
1749}
1750
1751void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1752 bool is_wide, bool is_sub) {
1753 if (is_wide) {
1754 if (is_sub) {
1755 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1756 } else {
1757 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1758 }
1759 } else {
1760 if (is_sub) {
1761 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1762 } else {
1763 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1764 }
1765 }
1766 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1767 int32_t addend0 = INVALID_SREG;
1768 int32_t addend1 = INVALID_SREG;
1769 if (is_wide) {
1770 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1771 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1772 } else {
1773 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1774 }
1775
1776 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1777 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1778 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1779 // Clear the original multiply product ssa use count, as it is not used anymore.
1780 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1781 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1782 if (is_wide) {
1783 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1784 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1785 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1786 add_mir->ssa_rep->uses[4] = addend0;
1787 add_mir->ssa_rep->uses[5] = addend1;
1788 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1789 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1790 } else {
1791 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1792 add_mir->ssa_rep->uses[2] = addend0;
1793 }
1794 // Copy in the decoded instruction information.
1795 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1796 if (is_wide) {
1797 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1798 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1799 } else {
1800 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1801 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1802 }
1803 // Original multiply MIR is set to Nop.
1804 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1805}
1806
1807void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1808 if (bb->block_type == kDead) {
1809 return;
1810 }
1811 ScopedArenaAllocator allocator(&cu_->arena_stack);
1812 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1813 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1814 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1815 Instruction::Code opcode = mir->dalvikInsn.opcode;
1816 bool is_sub = true;
1817 bool is_candidate_multiply = false;
1818 switch (opcode) {
1819 case Instruction::MUL_INT:
1820 case Instruction::MUL_INT_2ADDR:
1821 is_candidate_multiply = true;
1822 break;
1823 case Instruction::MUL_LONG:
1824 case Instruction::MUL_LONG_2ADDR:
1825 if (cu_->target64) {
1826 is_candidate_multiply = true;
1827 }
1828 break;
1829 case Instruction::ADD_INT:
1830 case Instruction::ADD_INT_2ADDR:
1831 is_sub = false;
1832 FALLTHROUGH_INTENDED;
1833 case Instruction::SUB_INT:
1834 case Instruction::SUB_INT_2ADDR:
1835 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1836 // a*b+c
1837 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1838 false /* is_wide */, false /* is_sub */);
1839 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1840 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1841 // c+a*b or c-a*b
1842 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1843 false /* is_wide */, is_sub);
1844 ssa_mul_map.erase(map_it);
1845 }
1846 break;
1847 case Instruction::ADD_LONG:
1848 case Instruction::ADD_LONG_2ADDR:
1849 is_sub = false;
1850 FALLTHROUGH_INTENDED;
1851 case Instruction::SUB_LONG:
1852 case Instruction::SUB_LONG_2ADDR:
1853 if (!cu_->target64) {
1854 break;
1855 }
1856 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1857 // a*b+c
1858 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1859 true /* is_wide */, false /* is_sub */);
1860 ssa_mul_map.erase(map_it);
1861 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1862 // c+a*b or c-a*b
1863 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1864 true /* is_wide */, is_sub);
1865 ssa_mul_map.erase(map_it);
1866 }
1867 break;
1868 default:
1869 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1870 // Should not combine multiply and add MIRs across potential exception.
1871 ssa_mul_map.clear();
1872 }
1873 break;
1874 }
1875
1876 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1877 // It is because that current RA may allocate the same physical register to them. For this
1878 // kind of cases, the multiplier has been updated, we should not use updated value to the
1879 // multiply-add insn.
1880 if (ssa_mul_map.size() > 0) {
1881 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1882 MIR* mul = it->second;
1883 if (HasAntiDependency(mul, mir)) {
1884 it = ssa_mul_map.erase(it);
1885 } else {
1886 ++it;
1887 }
1888 }
1889 }
1890
1891 if (is_candidate_multiply &&
1892 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1893 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1894 }
1895 }
1896}
1897
buzbee311ca162013-02-28 15:56:43 -08001898} // namespace art