blob: 87181910693d2410c1f11bf79741eafe0c3b08f0 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080018#include "base/logging.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080020#include "dex_flags.h"
21#include "driver/compiler_driver.h"
22#include "driver/dex_compilation_unit.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010023#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080024#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000025#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070026#include "quick/dex_file_method_inliner.h"
27#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070028#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010029#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080030
31namespace art {
32
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070033static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010034 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080035}
36
37/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070038void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070039 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080040 constant_values_[ssa_reg] = value;
Vladimir Marko066f9e42015-01-16 16:04:43 +000041 reg_location_[ssa_reg].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080042}
43
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070044void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070045 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070046 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080047 constant_values_[ssa_reg] = Low32Bits(value);
48 constant_values_[ssa_reg + 1] = High32Bits(value);
Vladimir Marko066f9e42015-01-16 16:04:43 +000049 reg_location_[ssa_reg].is_const = true;
50 reg_location_[ssa_reg + 1].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080051}
52
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080053void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080054 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080055
56 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070057 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070058 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070059 return;
60 }
61
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070062 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080063
Ian Rogers29a26482014-05-02 15:27:29 -070064 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080065
66 if (!(df_attributes & DF_HAS_DEFS)) continue;
67
68 /* Handle instructions that set up constants directly */
69 if (df_attributes & DF_SETS_CONST) {
70 if (df_attributes & DF_DA) {
71 int32_t vB = static_cast<int32_t>(d_insn->vB);
72 switch (d_insn->opcode) {
73 case Instruction::CONST_4:
74 case Instruction::CONST_16:
75 case Instruction::CONST:
76 SetConstant(mir->ssa_rep->defs[0], vB);
77 break;
78 case Instruction::CONST_HIGH16:
79 SetConstant(mir->ssa_rep->defs[0], vB << 16);
80 break;
81 case Instruction::CONST_WIDE_16:
82 case Instruction::CONST_WIDE_32:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
84 break;
85 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070086 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080087 break;
88 case Instruction::CONST_WIDE_HIGH16:
89 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
90 break;
91 default:
92 break;
93 }
94 }
95 /* Handle instructions that set up constants directly */
96 } else if (df_attributes & DF_IS_MOVE) {
97 int i;
98
99 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -0700100 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -0800101 }
102 /* Move a register holding a constant to another register */
103 if (i == mir->ssa_rep->num_uses) {
104 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
105 if (df_attributes & DF_A_WIDE) {
106 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
107 }
108 }
109 }
110 }
111 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800112}
113
buzbee311ca162013-02-28 15:56:43 -0800114/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700115MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800116 BasicBlock* bb = *p_bb;
117 if (mir != NULL) {
118 mir = mir->next;
Serguei Katkovea392162015-01-29 17:08:05 +0600119 while (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700120 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800121 if ((bb == NULL) || Predecessors(bb) != 1) {
Serguei Katkovea392162015-01-29 17:08:05 +0600122 // mir is null and we cannot proceed further.
123 break;
buzbee311ca162013-02-28 15:56:43 -0800124 } else {
Serguei Katkovea392162015-01-29 17:08:05 +0600125 *p_bb = bb;
126 mir = bb->first_mir_insn;
buzbee311ca162013-02-28 15:56:43 -0800127 }
128 }
129 }
130 return mir;
131}
132
133/*
134 * To be used at an invoke mir. If the logically next mir node represents
135 * a move-result, return it. Else, return NULL. If a move-result exists,
136 * it is required to immediately follow the invoke with no intervening
137 * opcodes or incoming arcs. However, if the result of the invoke is not
138 * used, a move-result may not be present.
139 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700140MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800141 BasicBlock* tbb = bb;
142 mir = AdvanceMIR(&tbb, mir);
143 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800144 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
145 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
146 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
147 break;
148 }
149 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700150 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800151 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700152 } else {
153 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800154 }
155 }
156 return mir;
157}
158
buzbee0d829482013-10-11 15:24:55 -0700159BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800160 if (bb->block_type == kDead) {
161 return NULL;
162 }
163 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
164 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700165 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
166 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800167 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700168 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700169 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700170 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700171 } else {
172 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700173 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700174 }
buzbee311ca162013-02-28 15:56:43 -0800175 if (bb == NULL || (Predecessors(bb) != 1)) {
176 return NULL;
177 }
178 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
179 return bb;
180}
181
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700182static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800183 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
184 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
185 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
186 if (mir->ssa_rep->uses[i] == ssa_name) {
187 return mir;
188 }
189 }
190 }
191 }
192 return NULL;
193}
194
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700195static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700196 // Work with the case when mir is nullptr.
197 if (mir == nullptr) {
198 return kSelectNone;
199 }
buzbee311ca162013-02-28 15:56:43 -0800200 switch (mir->dalvikInsn.opcode) {
201 case Instruction::MOVE:
202 case Instruction::MOVE_OBJECT:
203 case Instruction::MOVE_16:
204 case Instruction::MOVE_OBJECT_16:
205 case Instruction::MOVE_FROM16:
206 case Instruction::MOVE_OBJECT_FROM16:
207 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700208 case Instruction::CONST:
209 case Instruction::CONST_4:
210 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800211 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700212 case Instruction::GOTO:
213 case Instruction::GOTO_16:
214 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800215 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700216 default:
217 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800218 }
buzbee311ca162013-02-28 15:56:43 -0800219}
220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode kIfCcZConditionCodes[] = {
222 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
223};
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
226 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000227
Vladimir Markoa1a70742014-03-03 10:28:05 +0000228static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
229 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
230}
231
Andreas Gampe785d2f22014-11-03 22:57:30 -0800232static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
233static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
234static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
235static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
236static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
237static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000238
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700239int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100240 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
241 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800242}
243
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700244size_t MIRGraph::GetNumBytesForSpecialTemps() const {
245 // This logic is written with assumption that Method* is only special temp.
246 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
247 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800248}
249
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700250size_t MIRGraph::GetNumAvailableVRTemps() {
251 // First take into account all temps reserved for backend.
252 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
253 return 0;
254 }
255
256 // Calculate remaining ME temps available.
257 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
258
259 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
260 return 0;
261 } else {
262 return remaining_me_temps - num_non_special_compiler_temps_;
263 }
264}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000265
266// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800267static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700268 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000269 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800270
271CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700272 // Once the compiler temps have been committed, new ones cannot be requested anymore.
273 DCHECK_EQ(compiler_temps_committed_, false);
274 // Make sure that reserved for BE set is sane.
275 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
276
277 bool verbose = cu_->verbose;
278 const char* ct_type_str = nullptr;
279
280 if (verbose) {
281 switch (ct_type) {
282 case kCompilerTempBackend:
283 ct_type_str = "backend";
284 break;
285 case kCompilerTempSpecialMethodPtr:
286 ct_type_str = "method*";
287 break;
288 case kCompilerTempVR:
289 ct_type_str = "VR";
290 break;
291 default:
292 ct_type_str = "unknown";
293 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700295 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
296 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800297 }
298
299 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000300 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301
302 // Create the type of temp requested. Special temps need special handling because
303 // they have a specific virtual register assignment.
304 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700305 // This has a special location on stack which is 32-bit or 64-bit depending
306 // on mode. However, we don't want to overlap with non-special section
307 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800308 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800309
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700310 // The vreg is always the first special temp for method ptr.
311 compiler_temp->v_reg = GetFirstSpecialTempVR();
312
313 } else if (ct_type == kCompilerTempBackend) {
314 requested_backend_temp_ = true;
315
316 // Make sure that we are not exceeding temps reserved for BE.
317 // Since VR temps cannot be requested once the BE temps are requested, we
318 // allow reservation of VR temps as well for BE. We
319 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
320 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
321 if (verbose) {
322 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
323 }
324 return nullptr;
325 }
326
327 // Update the remaining reserved temps since we have now used them.
328 // Note that the code below is actually subtracting to remove them from reserve
329 // once they have been claimed. It is careful to not go below zero.
330 if (reserved_temps_for_backend_ >= 1) {
331 reserved_temps_for_backend_--;
332 }
333 if (wide && reserved_temps_for_backend_ >= 1) {
334 reserved_temps_for_backend_--;
335 }
336
337 // The new non-special compiler temp must receive a unique v_reg.
338 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
339 num_non_special_compiler_temps_++;
340 } else if (ct_type == kCompilerTempVR) {
341 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
342 // This is done in order to prevent problems with ssa since these structures are allocated
343 // and managed by the ME.
344 DCHECK_EQ(requested_backend_temp_, false);
345
346 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
347 size_t available_temps = GetNumAvailableVRTemps();
348 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
349 if (verbose) {
350 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
351 }
352 return nullptr;
353 }
354
355 // The new non-special compiler temp must receive a unique v_reg.
356 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
357 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800358 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700359 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
360 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800361
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700362 // We allocate an sreg as well to make developer life easier.
363 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
364 // this sreg is no longer valid. The caller should be aware of this.
365 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
366
367 if (verbose) {
368 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
369 << " and s" << compiler_temp->s_reg_low << " has been created.";
370 }
371
372 if (wide) {
373 // Only non-special temps are handled as wide for now.
374 // Note that the number of non special temps is incremented below.
375 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
376
377 // Ensure that the two registers are consecutive.
378 int ssa_reg_low = compiler_temp->s_reg_low;
379 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800380 num_non_special_compiler_temps_++;
381
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700382 if (verbose) {
383 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
384 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
385 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700386
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700387 if (reg_location_ != nullptr) {
388 reg_location_[ssa_reg_high] = temp_loc;
389 reg_location_[ssa_reg_high].high_word = true;
390 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
391 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 }
393 }
394
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700395 // If the register locations have already been allocated, add the information
396 // about the temp. We will not overflow because they have been initialized
397 // to support the maximum number of temps. For ME temps that have multiple
398 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 if (reg_location_ != nullptr) {
400 int ssa_reg_low = compiler_temp->s_reg_low;
401 reg_location_[ssa_reg_low] = temp_loc;
402 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
403 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800404 }
405
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800406 return compiler_temp;
407}
buzbee311ca162013-02-28 15:56:43 -0800408
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000409static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
410 bool is_taken;
411 switch (opcode) {
412 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
413 case Instruction::IF_NE: is_taken = (src1 != src2); break;
414 case Instruction::IF_LT: is_taken = (src1 < src2); break;
415 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
416 case Instruction::IF_GT: is_taken = (src1 > src2); break;
417 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
418 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
419 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
420 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
421 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
422 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
423 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
424 default:
425 LOG(FATAL) << "Unexpected opcode " << opcode;
426 UNREACHABLE();
427 }
428 return is_taken;
429}
430
buzbee311ca162013-02-28 15:56:43 -0800431/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700432bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800433 if (bb->block_type == kDead) {
434 return true;
435 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800436 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
437 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
438 MultiplyAddOpt(bb);
439 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100440 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100441 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100442 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700443 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800444 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100445 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100446 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
447 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100448 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
449 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800450 }
buzbee311ca162013-02-28 15:56:43 -0800451 while (bb != NULL) {
452 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
453 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800454 if (use_lvn) {
455 local_valnum->GetValueNumber(mir);
456 }
buzbee311ca162013-02-28 15:56:43 -0800457 // Look for interesting opcodes, skip otherwise
458 Instruction::Code opcode = mir->dalvikInsn.opcode;
459 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000460 case Instruction::IF_EQ:
461 case Instruction::IF_NE:
462 case Instruction::IF_LT:
463 case Instruction::IF_GE:
464 case Instruction::IF_GT:
465 case Instruction::IF_LE:
466 if (!IsConst(mir->ssa_rep->uses[1])) {
467 break;
468 }
469 FALLTHROUGH_INTENDED;
470 case Instruction::IF_EQZ:
471 case Instruction::IF_NEZ:
472 case Instruction::IF_LTZ:
473 case Instruction::IF_GEZ:
474 case Instruction::IF_GTZ:
475 case Instruction::IF_LEZ:
476 // Result known at compile time?
477 if (IsConst(mir->ssa_rep->uses[0])) {
478 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
479 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
480 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
481 if (is_taken) {
482 // Replace with GOTO.
483 bb->fall_through = NullBasicBlockId;
484 mir->dalvikInsn.opcode = Instruction::GOTO;
485 mir->dalvikInsn.vA =
486 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
487 } else {
488 // Make NOP.
489 bb->taken = NullBasicBlockId;
490 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
491 }
492 mir->ssa_rep->num_uses = 0;
493 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
494 successor_to_unlink->ErasePredecessor(bb->id);
Vladimir Marko341e4252014-12-19 10:29:51 +0000495 // We have changed the graph structure.
496 dfs_orders_up_to_date_ = false;
497 domination_up_to_date_ = false;
498 topological_order_up_to_date_ = false;
499 // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input.
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000500 }
501 break;
buzbee311ca162013-02-28 15:56:43 -0800502 case Instruction::CMPL_FLOAT:
503 case Instruction::CMPL_DOUBLE:
504 case Instruction::CMPG_FLOAT:
505 case Instruction::CMPG_DOUBLE:
506 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700507 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800508 // Bitcode doesn't allow this optimization.
509 break;
510 }
511 if (mir->next != NULL) {
512 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800513 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700514 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800515 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
516 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000517 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700518 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800519 case Instruction::CMPL_FLOAT:
520 mir_next->dalvikInsn.opcode =
521 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
522 break;
523 case Instruction::CMPL_DOUBLE:
524 mir_next->dalvikInsn.opcode =
525 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
526 break;
527 case Instruction::CMPG_FLOAT:
528 mir_next->dalvikInsn.opcode =
529 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
530 break;
531 case Instruction::CMPG_DOUBLE:
532 mir_next->dalvikInsn.opcode =
533 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
534 break;
535 case Instruction::CMP_LONG:
536 mir_next->dalvikInsn.opcode =
537 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
538 break;
539 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
540 }
541 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800542 // Clear use count of temp VR.
543 use_counts_[mir->ssa_rep->defs[0]] = 0;
544 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700545 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800546 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
547 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
548 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
549 mir_next->ssa_rep->num_defs = 0;
550 mir->ssa_rep->num_uses = 0;
551 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700552 // Copy in the decoded instruction information for potential SSA re-creation.
553 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
554 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800555 }
556 }
557 break;
buzbee311ca162013-02-28 15:56:43 -0800558 default:
559 break;
560 }
561 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800562 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800563 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800564 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100565 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000566 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700567 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800568 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700569 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
570 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800571
buzbee0d829482013-10-11 15:24:55 -0700572 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800573 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700574 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
575 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800576
577 /*
578 * In the select pattern, the taken edge goes to a block that unconditionally
579 * transfers to the rejoin block and the fall_though edge goes to a block that
580 * unconditionally falls through to the rejoin block.
581 */
582 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
583 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
584 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000585 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800586 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100587
588 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800589 // Are the block bodies something we can handle?
590 if ((ft->first_mir_insn == ft->last_mir_insn) &&
591 (tk->first_mir_insn != tk->last_mir_insn) &&
592 (tk->first_mir_insn->next == tk->last_mir_insn) &&
593 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
594 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
595 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
596 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
597 // Almost there. Are the instructions targeting the same vreg?
598 MIR* if_true = tk->first_mir_insn;
599 MIR* if_false = ft->first_mir_insn;
600 // It's possible that the target of the select isn't used - skip those (rare) cases.
601 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
602 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
603 /*
604 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
605 * Phi node in the merge block and delete it (while using the SSA name
606 * of the merge as the target of the SELECT. Delete both taken and
607 * fallthrough blocks, and set fallthrough to merge block.
608 * NOTE: not updating other dataflow info (no longer used at this point).
609 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
610 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000611 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800612 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
613 bool const_form = (SelectKind(if_true) == kSelectConst);
614 if ((SelectKind(if_true) == kSelectMove)) {
615 if (IsConst(if_true->ssa_rep->uses[0]) &&
616 IsConst(if_false->ssa_rep->uses[0])) {
617 const_form = true;
618 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
619 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
620 }
621 }
622 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800623 /*
624 * TODO: If both constants are the same value, then instead of generating
625 * a select, we should simply generate a const bytecode. This should be
626 * considered after inlining which can lead to CFG of this form.
627 */
buzbee311ca162013-02-28 15:56:43 -0800628 // "true" set val in vB
629 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
630 // "false" set val in vC
631 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
632 } else {
633 DCHECK_EQ(SelectKind(if_true), kSelectMove);
634 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700635 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000636 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800637 src_ssa[0] = mir->ssa_rep->uses[0];
638 src_ssa[1] = if_true->ssa_rep->uses[0];
639 src_ssa[2] = if_false->ssa_rep->uses[0];
640 mir->ssa_rep->uses = src_ssa;
641 mir->ssa_rep->num_uses = 3;
642 }
643 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700644 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000645 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700646 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000647 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800648 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700649 // Match type of uses to def.
650 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700651 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000652 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700653 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
654 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
655 }
buzbee311ca162013-02-28 15:56:43 -0800656 /*
657 * There is usually a Phi node in the join block for our two cases. If the
658 * Phi node only contains our two cases as input, we will use the result
659 * SSA name of the Phi node as our select result and delete the Phi. If
660 * the Phi node has more than two operands, we will arbitrarily use the SSA
Vladimir Marko341e4252014-12-19 10:29:51 +0000661 * name of the "false" path, delete the SSA name of the "true" path from the
buzbee311ca162013-02-28 15:56:43 -0800662 * Phi node (and fix up the incoming arc list).
663 */
664 if (phi->ssa_rep->num_uses == 2) {
665 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000666 // Rather than changing the Phi to kMirOpNop, remove it completely.
667 // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn.
668 tk_tk->RemoveMIR(phi);
669 int dead_false_def = if_false->ssa_rep->defs[0];
670 raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0;
buzbee311ca162013-02-28 15:56:43 -0800671 } else {
Vladimir Marko341e4252014-12-19 10:29:51 +0000672 int live_def = if_false->ssa_rep->defs[0];
buzbee311ca162013-02-28 15:56:43 -0800673 mir->ssa_rep->defs[0] = live_def;
buzbee311ca162013-02-28 15:56:43 -0800674 }
Vladimir Marko341e4252014-12-19 10:29:51 +0000675 int dead_true_def = if_true->ssa_rep->defs[0];
676 raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0;
677 // We want to remove ft and tk and link bb directly to ft_ft. First, we need
678 // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id)
679 // since the live_def above comes from ft->first_mir_insn (if_false).
680 DCHECK(if_false == ft->first_mir_insn);
681 ft_ft->UpdatePredecessor(ft->id, bb->id);
682 // Correct the rest of the links between bb, ft and ft_ft.
683 ft->ErasePredecessor(bb->id);
684 ft->fall_through = NullBasicBlockId;
685 bb->fall_through = ft_ft->id;
686 // Now we can kill tk and ft.
687 tk->Kill(this);
688 ft->Kill(this);
689 // NOTE: DFS order, domination info and topological order are still usable
690 // despite the newly dead blocks.
buzbee311ca162013-02-28 15:56:43 -0800691 }
692 }
693 }
694 }
695 }
buzbee1da1e2f2013-11-15 13:37:01 -0800696 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800697 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100698 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100699 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
700 }
buzbee311ca162013-02-28 15:56:43 -0800701
buzbee311ca162013-02-28 15:56:43 -0800702 return true;
703}
704
buzbee311ca162013-02-28 15:56:43 -0800705/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700706void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700707 if (bb->data_flow_info != NULL) {
708 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
709 if (mir->ssa_rep == NULL) {
710 continue;
buzbee311ca162013-02-28 15:56:43 -0800711 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700712 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700713 if (df_attributes & DF_HAS_NULL_CHKS) {
714 checkstats_->null_checks++;
715 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
716 checkstats_->null_checks_eliminated++;
717 }
718 }
719 if (df_attributes & DF_HAS_RANGE_CHKS) {
720 checkstats_->range_checks++;
721 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
722 checkstats_->range_checks_eliminated++;
723 }
buzbee311ca162013-02-28 15:56:43 -0800724 }
725 }
726 }
buzbee311ca162013-02-28 15:56:43 -0800727}
728
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700729/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700730bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700731 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800732 if (!bb->explicit_throw) {
733 return false;
734 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700735
736 // If we visited it, we are done.
737 if (bb->visited) {
738 return false;
739 }
740 bb->visited = true;
741
buzbee311ca162013-02-28 15:56:43 -0800742 BasicBlock* walker = bb;
743 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700744 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800745 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
746 break;
747 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100748 DCHECK(!walker->predecessors.empty());
749 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700750
751 // If we visited the predecessor, we are done.
752 if (prev->visited) {
753 return false;
754 }
755 prev->visited = true;
756
buzbee311ca162013-02-28 15:56:43 -0800757 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700758 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700759 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800760 break;
761 }
buzbee0d829482013-10-11 15:24:55 -0700762 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700763 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800764 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
765 switch (opcode) {
766 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
767 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
768 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
769 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
770 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
771 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
772 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
773 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
774 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
775 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
776 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
777 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
778 default: LOG(FATAL) << "Unexpected opcode " << opcode;
779 }
780 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700781 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800782 prev->taken = prev->fall_through;
783 prev->fall_through = t_bb;
784 break;
785 }
786 walker = prev;
787 }
788 return false;
789}
790
791/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700792void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800793 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100794 while ((bb->block_type == kDalvikByteCode) &&
795 (bb->last_mir_insn != nullptr) &&
796 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
797 MIR* mir = bb->last_mir_insn;
798 DCHECK(bb->first_mir_insn != nullptr);
799
Vladimir Marko315cc202014-12-18 17:01:02 +0000800 // Get the paired insn and check if it can still throw.
Vladimir Marko312eb252014-10-07 15:01:57 +0100801 MIR* throw_insn = mir->meta.throw_insn;
Vladimir Marko315cc202014-12-18 17:01:02 +0000802 if (CanThrow(throw_insn)) {
buzbee311ca162013-02-28 15:56:43 -0800803 break;
804 }
805
buzbee311ca162013-02-28 15:56:43 -0800806 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700807 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800808 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100809 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700810
811 // Now move instructions from bb_next to bb. Start off with doing a sanity check
812 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800813 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700814 // Now move all instructions (throw instruction to last one) from bb_next to bb.
815 MIR* last_to_move = bb_next->last_mir_insn;
816 bb_next->RemoveMIRList(throw_insn, last_to_move);
817 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
818 // The kMirOpCheck instruction is not needed anymore.
819 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
820 bb->RemoveMIR(mir);
821
Vladimir Marko312eb252014-10-07 15:01:57 +0100822 // Before we overwrite successors, remove their predecessor links to bb.
823 bb_next->ErasePredecessor(bb->id);
824 if (bb->taken != NullBasicBlockId) {
825 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
826 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
827 // bb->taken will be overwritten below.
828 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
829 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
830 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
831 bb_taken->predecessors.clear();
832 bb_taken->block_type = kDead;
833 DCHECK(bb_taken->data_flow_info == nullptr);
834 } else {
835 DCHECK_EQ(bb->successor_block_list_type, kCatch);
836 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
837 if (succ_info->block != NullBasicBlockId) {
838 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
839 DCHECK(succ_bb->catch_entry);
840 succ_bb->ErasePredecessor(bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100841 }
842 }
843 }
buzbee311ca162013-02-28 15:56:43 -0800844 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700845 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100846 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100847 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800848 // Use the ending block linkage from the next block
849 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100850 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800851 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100852 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800853 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900854 * If lower-half of pair of blocks to combine contained
855 * a return or a conditional branch or an explicit throw,
856 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800857 */
858 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900859 bb->conditional_branch = bb_next->conditional_branch;
860 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100861 // Merge the use_lvn flag.
862 bb->use_lvn |= bb_next->use_lvn;
863
864 // Kill the unused block.
865 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800866
867 /*
868 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
869 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100870 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800871 */
872
Vladimir Marko312eb252014-10-07 15:01:57 +0100873 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800874 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100875 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700876 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100877 // Update predecessors in children.
878 ChildBlockIterator iter(bb, this);
879 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
880 child->UpdatePredecessor(bb_next->id, bb->id);
881 }
882
Vladimir Markoffda4992014-12-18 17:05:58 +0000883 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100884 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000885 domination_up_to_date_ = false;
886 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800887
888 // Now, loop back and see if we can keep going
889 }
buzbee311ca162013-02-28 15:56:43 -0800890}
891
Vladimir Marko67c72b82014-10-09 12:26:10 +0100892bool MIRGraph::EliminateNullChecksGate() {
893 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
894 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
895 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000896 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100897
Vladimir Marko67c72b82014-10-09 12:26:10 +0100898 DCHECK(temp_scoped_alloc_.get() == nullptr);
899 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700900 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000901 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
902 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
903 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100904 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000905 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700906
907 // reset MIR_MARK
908 AllNodesIterator iter(this);
909 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
910 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
911 mir->optimization_flags &= ~MIR_MARK;
912 }
913 }
914
Vladimir Marko67c72b82014-10-09 12:26:10 +0100915 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000916}
917
buzbee1da1e2f2013-11-15 13:37:01 -0800918/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100919 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800920 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100921bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100922 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
923 // Ignore the kExitBlock as well.
924 DCHECK(bb->first_mir_insn == nullptr);
925 return false;
926 }
buzbee311ca162013-02-28 15:56:43 -0800927
Vladimir Markof585e542014-11-21 13:41:32 +0000928 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100929 /*
930 * Set initial state. Catch blocks don't need any special treatment.
931 */
932 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100933 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100934 // Assume all ins are objects.
935 for (uint16_t in_reg = GetFirstInVR();
936 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100937 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100938 }
939 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100940 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100941 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100942 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100943 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100944 } else {
945 DCHECK_EQ(bb->block_type, kDalvikByteCode);
946 // Starting state is union of all incoming arcs.
947 bool copied_first = false;
948 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000949 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100950 continue;
951 }
952 BasicBlock* pred_bb = GetBasicBlock(pred_id);
953 DCHECK(pred_bb != nullptr);
954 MIR* null_check_insn = nullptr;
955 if (pred_bb->block_type == kDalvikByteCode) {
956 // Check to see if predecessor had an explicit null-check.
957 MIR* last_insn = pred_bb->last_mir_insn;
958 if (last_insn != nullptr) {
959 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
960 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
961 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
962 // Remember the null check insn if there's no other predecessor requiring null check.
963 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
964 null_check_insn = last_insn;
965 }
buzbee1da1e2f2013-11-15 13:37:01 -0800966 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700967 }
968 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100969 if (!copied_first) {
970 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000971 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100972 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000973 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100974 }
975 if (null_check_insn != nullptr) {
976 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100977 }
978 }
979 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800980 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100981 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100982 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800983
984 // Walk through the instruction in the block, updating as necessary
985 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700986 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800987
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700988 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
989 // The algorithm was written in a phi agnostic way.
990 continue;
991 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100992
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000993 // Might need a null check?
994 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100995 int src_vreg;
996 if (df_attributes & DF_NULL_CHK_OUT0) {
997 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
998 src_vreg = mir->dalvikInsn.vC;
999 } else if (df_attributes & DF_NULL_CHK_B) {
1000 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1001 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001002 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001003 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1004 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1005 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001006 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001007 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001008 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001009 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001010 } else {
1011 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001012 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001013 // Mark src_vreg as null-checked.
1014 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001015 }
1016 }
1017
1018 if ((df_attributes & DF_A_WIDE) ||
1019 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1020 continue;
1021 }
1022
1023 /*
1024 * First, mark all object definitions as requiring null check.
1025 * Note: we can't tell if a CONST definition might be used as an object, so treat
1026 * them all as object definitions.
1027 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001028 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001029 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001030 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001031 }
1032
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001033 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 if (df_attributes & DF_NON_NULL_DST) {
1035 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001036 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1037 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001038 }
1039
buzbee311ca162013-02-28 15:56:43 -08001040 // Mark non-null returns from invoke-style NEW*
1041 if (df_attributes & DF_NON_NULL_RET) {
1042 MIR* next_mir = mir->next;
1043 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001044 if (UNLIKELY(next_mir == nullptr)) {
1045 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1046 // target, so the MOVE_RESULT cannot be broken away into another block.
1047 LOG(WARNING) << "Unexpected end of block following new";
1048 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1049 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001050 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001051 // Mark as null checked.
1052 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001053 }
1054 }
1055
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001056 // Propagate null check state on register copies.
1057 if (df_attributes & DF_NULL_TRANSFER_0) {
1058 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1059 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1060 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001061 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001062 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001063 }
1064 }
buzbee311ca162013-02-28 15:56:43 -08001065 }
1066
1067 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001068 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001069 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001070 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001071 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001072 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001073 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001074 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001075 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1076 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001077 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001078 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001079 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1080 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001081 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001082 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001083}
1084
Vladimir Marko67c72b82014-10-09 12:26:10 +01001085void MIRGraph::EliminateNullChecksEnd() {
1086 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001087 temp_.nce.num_vregs = 0u;
1088 temp_.nce.work_vregs_to_check = nullptr;
1089 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001090 DCHECK(temp_scoped_alloc_.get() != nullptr);
1091 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001092
1093 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001094 AllNodesIterator iter(this);
1095 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1096 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001097 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001098 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001099 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001100 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001101 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1102 }
1103 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001104}
1105
1106/*
1107 * Perform type and size inference for a basic block.
1108 */
1109bool MIRGraph::InferTypes(BasicBlock* bb) {
1110 if (bb->data_flow_info == nullptr) return false;
1111
1112 bool infer_changed = false;
1113 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1114 if (mir->ssa_rep == NULL) {
1115 continue;
1116 }
1117
1118 // Propagate type info.
1119 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1120 }
1121
1122 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001123}
1124
1125bool MIRGraph::EliminateClassInitChecksGate() {
1126 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001127 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001128 return false;
1129 }
1130
Vladimir Markobfea9c22014-01-17 17:49:33 +00001131 DCHECK(temp_scoped_alloc_.get() == nullptr);
1132 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1133
1134 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001135 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001136 temp_.cice.indexes = static_cast<uint16_t*>(
1137 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1138 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001139
1140 uint32_t unique_class_count = 0u;
1141 {
1142 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1143 // ScopedArenaAllocator.
1144
1145 // Embed the map value in the entry to save space.
1146 struct MapEntry {
1147 // Map key: the class identified by the declaring dex file and type index.
1148 const DexFile* declaring_dex_file;
1149 uint16_t declaring_class_idx;
1150 // Map value: index into bit vectors of classes requiring initialization checks.
1151 uint16_t index;
1152 };
1153 struct MapEntryComparator {
1154 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1155 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1156 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1157 }
1158 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1159 }
1160 };
1161
Vladimir Markobfea9c22014-01-17 17:49:33 +00001162 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001163 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1164 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001165
1166 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1167 AllNodesIterator iter(this);
1168 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001169 if (bb->block_type == kDalvikByteCode) {
1170 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001171 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001172 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001173 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001174 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1175 MapEntry entry = {
1176 // Treat unresolved fields as if each had its own class.
1177 field_info.IsResolved() ? field_info.DeclaringDexFile()
1178 : nullptr,
1179 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1180 : field_info.FieldIndex(),
1181 static_cast<uint16_t>(class_to_index_map.size())
1182 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001183 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001184 // Using offset/2 for index into temp_.cice.indexes.
1185 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001186 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001187 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001188 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1189 DCHECK(method_info.IsStatic());
1190 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1191 MapEntry entry = {
1192 method_info.DeclaringDexFile(),
1193 method_info.DeclaringClassIndex(),
1194 static_cast<uint16_t>(class_to_index_map.size())
1195 };
1196 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001197 // Using offset/2 for index into temp_.cice.indexes.
1198 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001199 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001200 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001201 }
1202 }
1203 }
1204 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1205 }
1206
1207 if (unique_class_count == 0u) {
1208 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001209 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001210 temp_scoped_alloc_.reset();
1211 return false;
1212 }
1213
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001214 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001215 temp_.cice.num_class_bits = 2u * unique_class_count;
1216 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1217 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1218 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001219 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001220 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1221 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001222 return true;
1223}
1224
1225/*
1226 * Eliminate unnecessary class initialization checks for a basic block.
1227 */
1228bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1229 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001230 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1231 // Ignore the kExitBlock as well.
1232 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001233 return false;
1234 }
1235
1236 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001237 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001238 */
Vladimir Markof585e542014-11-21 13:41:32 +00001239 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001240 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001241 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001242 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001243 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001244 // Starting state is union of all incoming arcs.
1245 bool copied_first = false;
1246 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001247 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001248 continue;
1249 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001250 if (!copied_first) {
1251 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001252 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001253 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001254 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001255 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001256 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001257 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001258 }
1259 // At this point, classes_to_check shows which classes need clinit checks.
1260
1261 // Walk through the instruction in the block, updating as necessary
1262 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001263 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001264 if (index != 0xffffu) {
1265 bool check_initialization = false;
1266 bool check_dex_cache = false;
1267
1268 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1269 // Dex instructions with width 1 can have the same offset/2.
1270
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001271 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001272 check_initialization = true;
1273 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001274 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001275 check_initialization = true;
1276 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1277 }
1278
1279 if (check_dex_cache) {
1280 uint32_t check_dex_cache_index = 2u * index + 1u;
1281 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1282 // Eliminate the class init check.
1283 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1284 } else {
1285 // Do the class init check.
1286 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1287 }
1288 classes_to_check->ClearBit(check_dex_cache_index);
1289 }
1290 if (check_initialization) {
1291 uint32_t check_clinit_index = 2u * index;
1292 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1293 // Eliminate the class init check.
1294 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1295 } else {
1296 // Do the class init check.
1297 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001298 }
1299 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001300 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001301 }
1302 }
1303 }
1304
1305 // Did anything change?
1306 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001307 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001308 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001309 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001310 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001311 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001312 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001313 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1314 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001315 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001316 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001317 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1318 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001319 }
1320 return changed;
1321}
1322
1323void MIRGraph::EliminateClassInitChecksEnd() {
1324 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001325 temp_.cice.num_class_bits = 0u;
1326 temp_.cice.work_classes_to_check = nullptr;
1327 temp_.cice.ending_classes_to_check_matrix = nullptr;
1328 DCHECK(temp_.cice.indexes != nullptr);
1329 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001330 DCHECK(temp_scoped_alloc_.get() != nullptr);
1331 temp_scoped_alloc_.reset();
1332}
1333
Vladimir Marko95a05972014-05-30 10:01:32 +01001334bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001335 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001336 return false;
1337 }
1338
1339 DCHECK(temp_scoped_alloc_ == nullptr);
1340 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001341 temp_.gvn.ifield_ids_ =
1342 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1343 temp_.gvn.sfield_ids_ =
1344 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001345 DCHECK(temp_.gvn.gvn == nullptr);
1346 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1347 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001348 return true;
1349}
1350
1351bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001352 DCHECK(temp_.gvn.gvn != nullptr);
1353 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001354 if (lvn != nullptr) {
1355 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1356 lvn->GetValueNumber(mir);
1357 }
1358 }
Vladimir Markof585e542014-11-21 13:41:32 +00001359 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001360 return change;
1361}
1362
1363void MIRGraph::ApplyGlobalValueNumberingEnd() {
1364 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001365 DCHECK(temp_.gvn.gvn != nullptr);
1366 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001367 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001368 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001369 TopologicalSortIterator iter(this);
1370 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1371 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001372 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001373 if (lvn != nullptr) {
1374 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1375 lvn->GetValueNumber(mir);
1376 }
Vladimir Markof585e542014-11-21 13:41:32 +00001377 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001378 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001379 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001380 }
1381 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001382 // GVN was successful, running the LVN would be useless.
1383 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001384 } else {
1385 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1386 }
1387
Vladimir Markof585e542014-11-21 13:41:32 +00001388 delete temp_.gvn.gvn;
1389 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001390 temp_.gvn.ifield_ids_ = nullptr;
1391 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001392 DCHECK(temp_scoped_alloc_ != nullptr);
1393 temp_scoped_alloc_.reset();
1394}
1395
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001396void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1397 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001398 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1399 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001400 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1401 return;
1402 }
1403
1404 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1405 MethodReference target = method_info.GetTargetMethod();
1406 DexCompilationUnit inlined_unit(
1407 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1408 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1409 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001410 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1411 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001412 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1413 DCHECK(inlined_field_info.IsResolved());
1414
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001415 uint32_t field_info_index = ifield_lowering_infos_.size();
1416 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001417 temp_.smi.processed_indexes->SetBit(method_index);
1418 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001419 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1420}
1421
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001422bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001423 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001424 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001425 return false;
1426 }
1427 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1428 // This isn't the Quick compiler.
1429 return false;
1430 }
1431 return true;
1432}
1433
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001434void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001435 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1436 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1437
1438 DCHECK(temp_scoped_alloc_.get() == nullptr);
1439 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001440 temp_.smi.num_indexes = method_lowering_infos_.size();
1441 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1442 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1443 temp_.smi.processed_indexes->ClearAllBits();
1444 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1445 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001446}
1447
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001448void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001449 if (bb->block_type != kDalvikByteCode) {
1450 return;
1451 }
1452 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001453 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001454 continue;
1455 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001456 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001457 continue;
1458 }
1459 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1460 if (!method_info.FastPath()) {
1461 continue;
1462 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001463
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001464 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001465 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001466 continue;
1467 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001468
1469 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001470 bool needs_clinit = !method_info.IsClassInitialized() &&
1471 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001472 if (needs_clinit) {
1473 continue;
1474 }
1475 }
1476
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001477 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1478 MethodReference target = method_info.GetTargetMethod();
1479 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1480 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001481 if (cu_->verbose || cu_->print_pass) {
1482 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1483 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1484 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1485 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001486 }
1487 }
1488 }
1489}
1490
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001491void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001492 // Clean up temporaries.
1493 DCHECK(temp_.smi.lowering_infos != nullptr);
1494 temp_.smi.lowering_infos = nullptr;
1495 temp_.smi.num_indexes = 0u;
1496 DCHECK(temp_.smi.processed_indexes != nullptr);
1497 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001498 DCHECK(temp_scoped_alloc_.get() != nullptr);
1499 temp_scoped_alloc_.reset();
1500}
1501
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001502void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001503 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001504 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001505 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001506 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001507 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1508 CountChecks(bb);
1509 }
1510 if (stats->null_checks > 0) {
1511 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1512 float checks = static_cast<float>(stats->null_checks);
1513 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1514 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1515 << (eliminated/checks) * 100.0 << "%";
1516 }
1517 if (stats->range_checks > 0) {
1518 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1519 float checks = static_cast<float>(stats->range_checks);
1520 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1521 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1522 << (eliminated/checks) * 100.0 << "%";
1523 }
1524}
1525
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001526bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001527 if (bb->visited) return false;
1528 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1529 || (bb->block_type == kExitBlock))) {
1530 // Ignore special blocks
1531 bb->visited = true;
1532 return false;
1533 }
1534 // Must be head of extended basic block.
1535 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001536 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001537 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001538 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001539 // Visit blocks strictly dominated by this head.
1540 while (bb != NULL) {
1541 bb->visited = true;
1542 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001543 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001544 bb = NextDominatedBlock(bb);
1545 }
buzbee1da1e2f2013-11-15 13:37:01 -08001546 if (terminated_by_return || do_local_value_numbering) {
1547 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001548 bb = start_bb;
1549 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001550 bb->use_lvn = do_local_value_numbering;
1551 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001552 bb = NextDominatedBlock(bb);
1553 }
1554 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001555 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001556}
1557
Vladimir Markoffda4992014-12-18 17:05:58 +00001558void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001559 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1560 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1561 temp_.gvn.ifield_ids_ =
1562 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1563 temp_.gvn.sfield_ids_ =
1564 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1565 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001566}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001567
Vladimir Markoffda4992014-12-18 17:05:58 +00001568void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001569 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1570 ClearAllVisitedFlags();
1571 PreOrderDfsIterator iter2(this);
1572 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1573 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001574 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001575 // Perform extended basic block optimizations.
1576 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1577 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1578 }
1579 } else {
1580 PreOrderDfsIterator iter(this);
1581 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1582 BasicBlockOpt(bb);
1583 }
buzbee311ca162013-02-28 15:56:43 -08001584 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001585}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001586
Vladimir Markoffda4992014-12-18 17:05:58 +00001587void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001588 // Clean up after LVN.
1589 temp_.gvn.ifield_ids_ = nullptr;
1590 temp_.gvn.sfield_ids_ = nullptr;
1591 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001592}
1593
Vladimir Marko8b858e12014-11-27 14:52:37 +00001594bool MIRGraph::EliminateSuspendChecksGate() {
1595 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1596 GetMaxNestedLoops() == 0u || // Nothing to do.
1597 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1598 // Exclude 32 as well to keep bit shifts well-defined.
1599 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1600 return false;
1601 }
1602 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1603 temp_.sce.inliner =
1604 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1605 }
1606 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1607 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1608 return true;
1609}
1610
1611bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1612 if (bb->block_type != kDalvikByteCode) {
1613 return false;
1614 }
1615 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1616 if (bb->nesting_depth == 0u) {
1617 // Out of loops.
1618 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1619 return false;
1620 }
1621 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1622 bool found_invoke = false;
1623 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1624 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1625 (temp_.sce.inliner == nullptr ||
1626 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1627 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1628 found_invoke = true;
1629 break;
1630 }
1631 }
1632 if (!found_invoke) {
1633 // Intersect suspend checks from predecessors.
1634 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1635 uint32_t pred_mask_union = 0u;
1636 for (BasicBlockId pred_id : bb->predecessors) {
1637 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1638 if (pred_topo_idx < bb_topo_idx) {
1639 // Determine the loop depth of the predecessors relative to this block.
1640 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1641 while (pred_loop_depth != 0u &&
1642 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1643 --pred_loop_depth;
1644 }
1645 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1646 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1647 // Intersect pred_mask bits in suspend_checks_in_loops with
1648 // suspend_checks_in_loops_[pred_id].
1649 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1650 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1651 pred_mask_union |= pred_mask;
1652 }
1653 }
1654 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1655 pred_mask_union);
1656 suspend_checks_in_loops &= pred_mask_union;
1657 }
1658 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1659 if (suspend_checks_in_loops == 0u) {
1660 return false;
1661 }
1662 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1663 if (bb->taken != NullBasicBlockId) {
1664 DCHECK(bb->last_mir_insn != nullptr);
1665 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1666 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1667 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1668 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1669 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1670 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1671 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1672 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1673 }
1674 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1675 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1676 MIR* mir = NewMIR();
1677 mir->dalvikInsn.opcode = Instruction::GOTO;
1678 mir->dalvikInsn.vA = 0; // Branch offset.
1679 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1680 mir->m_unit_index = current_method_;
1681 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1682 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1683 bb->AppendMIR(mir);
1684 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1685 }
1686 return true;
1687}
1688
1689void MIRGraph::EliminateSuspendChecksEnd() {
1690 temp_.sce.inliner = nullptr;
1691}
1692
Ningsheng Jiana262f772014-11-25 16:48:07 +08001693bool MIRGraph::CanThrow(MIR* mir) {
1694 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1695 return false;
1696 }
1697 const int opt_flags = mir->optimization_flags;
1698 uint64_t df_attributes = GetDataFlowAttributes(mir);
1699
Vladimir Marko315cc202014-12-18 17:01:02 +00001700 // First, check if the insn can still throw NPE.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001701 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1702 return true;
1703 }
Vladimir Marko315cc202014-12-18 17:01:02 +00001704
1705 // Now process specific instructions.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001706 if ((df_attributes & DF_IFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001707 // The IGET/IPUT family. We have processed the IGET/IPUT null check above.
1708 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1709 // If not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001710 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001711 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
1712 return !fast;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001713 } else if ((df_attributes & DF_SFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001714 // The SGET/SPUT family. Check for potentially throwing class initialization.
1715 // Also, if not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001716 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001717 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
Ningsheng Jiana262f772014-11-25 16:48:07 +08001718 bool is_class_initialized = field_info.IsClassInitialized() ||
1719 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
Vladimir Marko315cc202014-12-18 17:01:02 +00001720 return !(fast && is_class_initialized);
1721 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1722 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
1723 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1724 // Non-throwing only if range check has been eliminated.
1725 return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0);
1726 } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
1727 mir->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
1728 static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) {
1729 // No more checks for these (null check was processed above).
1730 return false;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001731 }
1732 return true;
1733}
1734
1735bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1736 DCHECK(first->ssa_rep != nullptr);
1737 DCHECK(second->ssa_rep != nullptr);
1738 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1739 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1740 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1741 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1742 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1743 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1744 if (use == vreg0 || use == vreg1) {
1745 return true;
1746 }
1747 }
1748 }
1749 return false;
1750}
1751
1752void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1753 bool is_wide, bool is_sub) {
1754 if (is_wide) {
1755 if (is_sub) {
1756 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1757 } else {
1758 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1759 }
1760 } else {
1761 if (is_sub) {
1762 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1763 } else {
1764 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1765 }
1766 }
1767 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1768 int32_t addend0 = INVALID_SREG;
1769 int32_t addend1 = INVALID_SREG;
1770 if (is_wide) {
1771 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1772 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1773 } else {
1774 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1775 }
1776
1777 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1778 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1779 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1780 // Clear the original multiply product ssa use count, as it is not used anymore.
1781 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1782 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1783 if (is_wide) {
1784 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1785 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1786 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1787 add_mir->ssa_rep->uses[4] = addend0;
1788 add_mir->ssa_rep->uses[5] = addend1;
1789 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1790 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1791 } else {
1792 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1793 add_mir->ssa_rep->uses[2] = addend0;
1794 }
1795 // Copy in the decoded instruction information.
1796 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1797 if (is_wide) {
1798 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1799 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1800 } else {
1801 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1802 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1803 }
1804 // Original multiply MIR is set to Nop.
1805 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1806}
1807
1808void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1809 if (bb->block_type == kDead) {
1810 return;
1811 }
1812 ScopedArenaAllocator allocator(&cu_->arena_stack);
1813 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1814 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1815 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1816 Instruction::Code opcode = mir->dalvikInsn.opcode;
1817 bool is_sub = true;
1818 bool is_candidate_multiply = false;
1819 switch (opcode) {
1820 case Instruction::MUL_INT:
1821 case Instruction::MUL_INT_2ADDR:
1822 is_candidate_multiply = true;
1823 break;
1824 case Instruction::MUL_LONG:
1825 case Instruction::MUL_LONG_2ADDR:
1826 if (cu_->target64) {
1827 is_candidate_multiply = true;
1828 }
1829 break;
1830 case Instruction::ADD_INT:
1831 case Instruction::ADD_INT_2ADDR:
1832 is_sub = false;
1833 FALLTHROUGH_INTENDED;
1834 case Instruction::SUB_INT:
1835 case Instruction::SUB_INT_2ADDR:
1836 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1837 // a*b+c
1838 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1839 false /* is_wide */, false /* is_sub */);
1840 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1841 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1842 // c+a*b or c-a*b
1843 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1844 false /* is_wide */, is_sub);
1845 ssa_mul_map.erase(map_it);
1846 }
1847 break;
1848 case Instruction::ADD_LONG:
1849 case Instruction::ADD_LONG_2ADDR:
1850 is_sub = false;
1851 FALLTHROUGH_INTENDED;
1852 case Instruction::SUB_LONG:
1853 case Instruction::SUB_LONG_2ADDR:
1854 if (!cu_->target64) {
1855 break;
1856 }
1857 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1858 // a*b+c
1859 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1860 true /* is_wide */, false /* is_sub */);
1861 ssa_mul_map.erase(map_it);
1862 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1863 // c+a*b or c-a*b
1864 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1865 true /* is_wide */, is_sub);
1866 ssa_mul_map.erase(map_it);
1867 }
1868 break;
1869 default:
1870 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1871 // Should not combine multiply and add MIRs across potential exception.
1872 ssa_mul_map.clear();
1873 }
1874 break;
1875 }
1876
1877 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1878 // It is because that current RA may allocate the same physical register to them. For this
1879 // kind of cases, the multiplier has been updated, we should not use updated value to the
1880 // multiply-add insn.
1881 if (ssa_mul_map.size() > 0) {
1882 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1883 MIR* mul = it->second;
1884 if (HasAntiDependency(mul, mir)) {
1885 it = ssa_mul_map.erase(it);
1886 } else {
1887 ++it;
1888 }
1889 }
1890 }
1891
1892 if (is_candidate_multiply &&
1893 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1894 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1895 }
1896 }
1897}
1898
buzbee311ca162013-02-28 15:56:43 -08001899} // namespace art