blob: c85c3b6f2124c7339ad5ee6741d146dc56c9c3ad [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080018#include "base/logging.h"
Mathieu Chartierb666f482015-02-18 14:33:14 -080019#include "base/scoped_arena_containers.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070020#include "dataflow_iterator-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080021#include "dex_flags.h"
22#include "driver/compiler_driver.h"
23#include "driver/dex_compilation_unit.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010024#include "global_value_numbering.h"
Vladimir Marko7a01dc22015-01-02 17:00:44 +000025#include "gvn_dead_code_elimination.h"
buzbee311ca162013-02-28 15:56:43 -080026#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000027#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070028#include "quick/dex_file_method_inliner.h"
29#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070030#include "stack.h"
buzbee311ca162013-02-28 15:56:43 -080031
32namespace art {
33
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070034static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010035 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080036}
37
38/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070039void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070040 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080041 constant_values_[ssa_reg] = value;
Vladimir Marko066f9e42015-01-16 16:04:43 +000042 reg_location_[ssa_reg].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080043}
44
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070045void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070046 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070047 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080048 constant_values_[ssa_reg] = Low32Bits(value);
49 constant_values_[ssa_reg + 1] = High32Bits(value);
Vladimir Marko066f9e42015-01-16 16:04:43 +000050 reg_location_[ssa_reg].is_const = true;
51 reg_location_[ssa_reg + 1].is_const = true;
buzbee311ca162013-02-28 15:56:43 -080052}
53
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080054void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080055 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080056
57 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070058 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070059 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070060 return;
61 }
62
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070063 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080064
Ian Rogers29a26482014-05-02 15:27:29 -070065 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080066
67 if (!(df_attributes & DF_HAS_DEFS)) continue;
68
69 /* Handle instructions that set up constants directly */
70 if (df_attributes & DF_SETS_CONST) {
71 if (df_attributes & DF_DA) {
72 int32_t vB = static_cast<int32_t>(d_insn->vB);
73 switch (d_insn->opcode) {
74 case Instruction::CONST_4:
75 case Instruction::CONST_16:
76 case Instruction::CONST:
77 SetConstant(mir->ssa_rep->defs[0], vB);
78 break;
79 case Instruction::CONST_HIGH16:
80 SetConstant(mir->ssa_rep->defs[0], vB << 16);
81 break;
82 case Instruction::CONST_WIDE_16:
83 case Instruction::CONST_WIDE_32:
84 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
85 break;
86 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070087 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080088 break;
89 case Instruction::CONST_WIDE_HIGH16:
90 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
91 break;
92 default:
93 break;
94 }
95 }
96 /* Handle instructions that set up constants directly */
97 } else if (df_attributes & DF_IS_MOVE) {
98 int i;
99
100 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -0700101 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -0800102 }
103 /* Move a register holding a constant to another register */
104 if (i == mir->ssa_rep->num_uses) {
105 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
106 if (df_attributes & DF_A_WIDE) {
107 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
108 }
109 }
110 }
111 }
112 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800113}
114
buzbee311ca162013-02-28 15:56:43 -0800115/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700116MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800117 BasicBlock* bb = *p_bb;
118 if (mir != NULL) {
119 mir = mir->next;
Serguei Katkovea392162015-01-29 17:08:05 +0600120 while (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700121 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800122 if ((bb == NULL) || Predecessors(bb) != 1) {
Serguei Katkovea392162015-01-29 17:08:05 +0600123 // mir is null and we cannot proceed further.
124 break;
buzbee311ca162013-02-28 15:56:43 -0800125 } else {
Serguei Katkovea392162015-01-29 17:08:05 +0600126 *p_bb = bb;
127 mir = bb->first_mir_insn;
buzbee311ca162013-02-28 15:56:43 -0800128 }
129 }
130 }
131 return mir;
132}
133
134/*
135 * To be used at an invoke mir. If the logically next mir node represents
136 * a move-result, return it. Else, return NULL. If a move-result exists,
137 * it is required to immediately follow the invoke with no intervening
138 * opcodes or incoming arcs. However, if the result of the invoke is not
139 * used, a move-result may not be present.
140 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700141MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800142 BasicBlock* tbb = bb;
143 mir = AdvanceMIR(&tbb, mir);
144 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800145 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
146 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
147 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
148 break;
149 }
150 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700151 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800152 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700153 } else {
154 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800155 }
156 }
157 return mir;
158}
159
buzbee0d829482013-10-11 15:24:55 -0700160BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800161 if (bb->block_type == kDead) {
162 return NULL;
163 }
164 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
165 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700166 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
167 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800168 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700169 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700170 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700171 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700172 } else {
173 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700174 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700175 }
buzbee311ca162013-02-28 15:56:43 -0800176 if (bb == NULL || (Predecessors(bb) != 1)) {
177 return NULL;
178 }
179 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
180 return bb;
181}
182
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700183static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800184 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
185 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
186 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
187 if (mir->ssa_rep->uses[i] == ssa_name) {
188 return mir;
189 }
190 }
191 }
192 }
193 return NULL;
194}
195
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700196static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700197 // Work with the case when mir is nullptr.
198 if (mir == nullptr) {
199 return kSelectNone;
200 }
buzbee311ca162013-02-28 15:56:43 -0800201 switch (mir->dalvikInsn.opcode) {
202 case Instruction::MOVE:
203 case Instruction::MOVE_OBJECT:
204 case Instruction::MOVE_16:
205 case Instruction::MOVE_OBJECT_16:
206 case Instruction::MOVE_FROM16:
207 case Instruction::MOVE_OBJECT_FROM16:
208 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700209 case Instruction::CONST:
210 case Instruction::CONST_4:
211 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800212 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700213 case Instruction::GOTO:
214 case Instruction::GOTO_16:
215 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800216 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700217 default:
218 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800219 }
buzbee311ca162013-02-28 15:56:43 -0800220}
221
Vladimir Markoa1a70742014-03-03 10:28:05 +0000222static constexpr ConditionCode kIfCcZConditionCodes[] = {
223 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
224};
225
Andreas Gampe785d2f22014-11-03 22:57:30 -0800226static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
227 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000228
Vladimir Markoa1a70742014-03-03 10:28:05 +0000229static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
230 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
231}
232
Andreas Gampe785d2f22014-11-03 22:57:30 -0800233static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
234static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
235static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
236static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
237static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
238static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000239
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700240int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100241 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
242 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800243}
244
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700245size_t MIRGraph::GetNumBytesForSpecialTemps() const {
246 // This logic is written with assumption that Method* is only special temp.
247 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
248 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800249}
250
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700251size_t MIRGraph::GetNumAvailableVRTemps() {
252 // First take into account all temps reserved for backend.
253 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
254 return 0;
255 }
256
257 // Calculate remaining ME temps available.
258 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
259
260 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
261 return 0;
262 } else {
263 return remaining_me_temps - num_non_special_compiler_temps_;
264 }
265}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000266
267// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800268static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700269 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000270 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800271
272CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700273 // Once the compiler temps have been committed, new ones cannot be requested anymore.
274 DCHECK_EQ(compiler_temps_committed_, false);
275 // Make sure that reserved for BE set is sane.
276 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
277
278 bool verbose = cu_->verbose;
279 const char* ct_type_str = nullptr;
280
281 if (verbose) {
282 switch (ct_type) {
283 case kCompilerTempBackend:
284 ct_type_str = "backend";
285 break;
286 case kCompilerTempSpecialMethodPtr:
287 ct_type_str = "method*";
288 break;
289 case kCompilerTempVR:
290 ct_type_str = "VR";
291 break;
292 default:
293 ct_type_str = "unknown";
294 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800295 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700296 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
297 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800298 }
299
300 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000301 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
303 // Create the type of temp requested. Special temps need special handling because
304 // they have a specific virtual register assignment.
305 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700306 // This has a special location on stack which is 32-bit or 64-bit depending
307 // on mode. However, we don't want to overlap with non-special section
308 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800309 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800310
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700311 // The vreg is always the first special temp for method ptr.
312 compiler_temp->v_reg = GetFirstSpecialTempVR();
313
314 } else if (ct_type == kCompilerTempBackend) {
315 requested_backend_temp_ = true;
316
317 // Make sure that we are not exceeding temps reserved for BE.
318 // Since VR temps cannot be requested once the BE temps are requested, we
319 // allow reservation of VR temps as well for BE. We
320 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
321 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
322 if (verbose) {
323 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
324 }
325 return nullptr;
326 }
327
328 // Update the remaining reserved temps since we have now used them.
329 // Note that the code below is actually subtracting to remove them from reserve
330 // once they have been claimed. It is careful to not go below zero.
331 if (reserved_temps_for_backend_ >= 1) {
332 reserved_temps_for_backend_--;
333 }
334 if (wide && reserved_temps_for_backend_ >= 1) {
335 reserved_temps_for_backend_--;
336 }
337
338 // The new non-special compiler temp must receive a unique v_reg.
339 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
340 num_non_special_compiler_temps_++;
341 } else if (ct_type == kCompilerTempVR) {
342 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
343 // This is done in order to prevent problems with ssa since these structures are allocated
344 // and managed by the ME.
345 DCHECK_EQ(requested_backend_temp_, false);
346
347 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
348 size_t available_temps = GetNumAvailableVRTemps();
349 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
350 if (verbose) {
351 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
352 }
353 return nullptr;
354 }
355
356 // The new non-special compiler temp must receive a unique v_reg.
357 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
358 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800359 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700360 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
361 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800362
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700363 // We allocate an sreg as well to make developer life easier.
364 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
365 // this sreg is no longer valid. The caller should be aware of this.
366 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
367
368 if (verbose) {
369 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
370 << " and s" << compiler_temp->s_reg_low << " has been created.";
371 }
372
373 if (wide) {
374 // Only non-special temps are handled as wide for now.
375 // Note that the number of non special temps is incremented below.
376 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
377
378 // Ensure that the two registers are consecutive.
379 int ssa_reg_low = compiler_temp->s_reg_low;
380 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800381 num_non_special_compiler_temps_++;
382
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700383 if (verbose) {
384 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
385 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
386 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 if (reg_location_ != nullptr) {
389 reg_location_[ssa_reg_high] = temp_loc;
390 reg_location_[ssa_reg_high].high_word = true;
391 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
392 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800393 }
394 }
395
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700396 // If the register locations have already been allocated, add the information
397 // about the temp. We will not overflow because they have been initialized
398 // to support the maximum number of temps. For ME temps that have multiple
399 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800400 if (reg_location_ != nullptr) {
401 int ssa_reg_low = compiler_temp->s_reg_low;
402 reg_location_[ssa_reg_low] = temp_loc;
403 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
404 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800405 }
406
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800407 return compiler_temp;
408}
buzbee311ca162013-02-28 15:56:43 -0800409
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000410static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
411 bool is_taken;
412 switch (opcode) {
413 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
414 case Instruction::IF_NE: is_taken = (src1 != src2); break;
415 case Instruction::IF_LT: is_taken = (src1 < src2); break;
416 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
417 case Instruction::IF_GT: is_taken = (src1 > src2); break;
418 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
419 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
420 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
421 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
422 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
423 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
424 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
425 default:
426 LOG(FATAL) << "Unexpected opcode " << opcode;
427 UNREACHABLE();
428 }
429 return is_taken;
430}
431
buzbee311ca162013-02-28 15:56:43 -0800432/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700433bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800434 if (bb->block_type == kDead) {
435 return true;
436 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800437 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
438 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
439 MultiplyAddOpt(bb);
440 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100441 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100442 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100443 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700444 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800445 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100446 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100447 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
448 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100449 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
450 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800451 }
buzbee311ca162013-02-28 15:56:43 -0800452 while (bb != NULL) {
453 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
454 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800455 if (use_lvn) {
456 local_valnum->GetValueNumber(mir);
457 }
buzbee311ca162013-02-28 15:56:43 -0800458 // Look for interesting opcodes, skip otherwise
459 Instruction::Code opcode = mir->dalvikInsn.opcode;
460 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000461 case Instruction::IF_EQ:
462 case Instruction::IF_NE:
463 case Instruction::IF_LT:
464 case Instruction::IF_GE:
465 case Instruction::IF_GT:
466 case Instruction::IF_LE:
467 if (!IsConst(mir->ssa_rep->uses[1])) {
468 break;
469 }
470 FALLTHROUGH_INTENDED;
471 case Instruction::IF_EQZ:
472 case Instruction::IF_NEZ:
473 case Instruction::IF_LTZ:
474 case Instruction::IF_GEZ:
475 case Instruction::IF_GTZ:
476 case Instruction::IF_LEZ:
477 // Result known at compile time?
478 if (IsConst(mir->ssa_rep->uses[0])) {
479 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
480 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
481 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
482 if (is_taken) {
483 // Replace with GOTO.
484 bb->fall_through = NullBasicBlockId;
485 mir->dalvikInsn.opcode = Instruction::GOTO;
486 mir->dalvikInsn.vA =
487 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
488 } else {
489 // Make NOP.
490 bb->taken = NullBasicBlockId;
491 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
492 }
493 mir->ssa_rep->num_uses = 0;
494 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
495 successor_to_unlink->ErasePredecessor(bb->id);
Vladimir Marko341e4252014-12-19 10:29:51 +0000496 // We have changed the graph structure.
497 dfs_orders_up_to_date_ = false;
498 domination_up_to_date_ = false;
499 topological_order_up_to_date_ = false;
500 // Keep MIR SSA rep, the worst that can happen is a Phi with just 1 input.
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000501 }
502 break;
buzbee311ca162013-02-28 15:56:43 -0800503 case Instruction::CMPL_FLOAT:
504 case Instruction::CMPL_DOUBLE:
505 case Instruction::CMPG_FLOAT:
506 case Instruction::CMPG_DOUBLE:
507 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700508 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800509 // Bitcode doesn't allow this optimization.
510 break;
511 }
512 if (mir->next != NULL) {
513 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800514 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700515 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800516 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
517 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000518 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700519 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800520 case Instruction::CMPL_FLOAT:
521 mir_next->dalvikInsn.opcode =
522 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
523 break;
524 case Instruction::CMPL_DOUBLE:
525 mir_next->dalvikInsn.opcode =
526 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
527 break;
528 case Instruction::CMPG_FLOAT:
529 mir_next->dalvikInsn.opcode =
530 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
531 break;
532 case Instruction::CMPG_DOUBLE:
533 mir_next->dalvikInsn.opcode =
534 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
535 break;
536 case Instruction::CMP_LONG:
537 mir_next->dalvikInsn.opcode =
538 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
539 break;
540 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
541 }
542 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800543 // Clear use count of temp VR.
544 use_counts_[mir->ssa_rep->defs[0]] = 0;
545 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700546 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800547 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
548 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
549 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
550 mir_next->ssa_rep->num_defs = 0;
551 mir->ssa_rep->num_uses = 0;
552 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700553 // Copy in the decoded instruction information for potential SSA re-creation.
554 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
555 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800556 }
557 }
558 break;
buzbee311ca162013-02-28 15:56:43 -0800559 default:
560 break;
561 }
562 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800563 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800564 // TUNING: expand to support IF_xx compare & branches
Elliott Hughes956af0f2014-12-11 14:34:28 -0800565 if ((cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100566 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000567 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700568 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800569 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700570 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
571 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800572
buzbee0d829482013-10-11 15:24:55 -0700573 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800574 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700575 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
576 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800577
578 /*
579 * In the select pattern, the taken edge goes to a block that unconditionally
580 * transfers to the rejoin block and the fall_though edge goes to a block that
581 * unconditionally falls through to the rejoin block.
582 */
583 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
584 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
585 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000586 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800587 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100588
589 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800590 // Are the block bodies something we can handle?
591 if ((ft->first_mir_insn == ft->last_mir_insn) &&
592 (tk->first_mir_insn != tk->last_mir_insn) &&
593 (tk->first_mir_insn->next == tk->last_mir_insn) &&
594 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
595 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
596 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
597 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
598 // Almost there. Are the instructions targeting the same vreg?
599 MIR* if_true = tk->first_mir_insn;
600 MIR* if_false = ft->first_mir_insn;
601 // It's possible that the target of the select isn't used - skip those (rare) cases.
602 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
603 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
604 /*
605 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
606 * Phi node in the merge block and delete it (while using the SSA name
607 * of the merge as the target of the SELECT. Delete both taken and
608 * fallthrough blocks, and set fallthrough to merge block.
609 * NOTE: not updating other dataflow info (no longer used at this point).
610 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
611 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000612 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800613 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
614 bool const_form = (SelectKind(if_true) == kSelectConst);
615 if ((SelectKind(if_true) == kSelectMove)) {
616 if (IsConst(if_true->ssa_rep->uses[0]) &&
617 IsConst(if_false->ssa_rep->uses[0])) {
618 const_form = true;
619 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
620 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
621 }
622 }
623 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800624 /*
625 * TODO: If both constants are the same value, then instead of generating
626 * a select, we should simply generate a const bytecode. This should be
627 * considered after inlining which can lead to CFG of this form.
628 */
buzbee311ca162013-02-28 15:56:43 -0800629 // "true" set val in vB
630 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
631 // "false" set val in vC
632 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
633 } else {
634 DCHECK_EQ(SelectKind(if_true), kSelectMove);
635 DCHECK_EQ(SelectKind(if_false), kSelectMove);
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000636 int32_t* src_ssa = arena_->AllocArray<int32_t>(3, kArenaAllocDFInfo);
buzbee311ca162013-02-28 15:56:43 -0800637 src_ssa[0] = mir->ssa_rep->uses[0];
638 src_ssa[1] = if_true->ssa_rep->uses[0];
639 src_ssa[2] = if_false->ssa_rep->uses[0];
640 mir->ssa_rep->uses = src_ssa;
641 mir->ssa_rep->num_uses = 3;
642 }
643 mir->ssa_rep->num_defs = 1;
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000644 mir->ssa_rep->defs = arena_->AllocArray<int32_t>(1, kArenaAllocDFInfo);
645 mir->ssa_rep->fp_def = arena_->AllocArray<bool>(1, kArenaAllocDFInfo);
buzbee311ca162013-02-28 15:56:43 -0800646 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700647 // Match type of uses to def.
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000648 mir->ssa_rep->fp_use = arena_->AllocArray<bool>(mir->ssa_rep->num_uses,
649 kArenaAllocDFInfo);
buzbee817e45a2013-05-30 18:59:12 -0700650 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
651 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
652 }
buzbee311ca162013-02-28 15:56:43 -0800653 /*
654 * There is usually a Phi node in the join block for our two cases. If the
655 * Phi node only contains our two cases as input, we will use the result
656 * SSA name of the Phi node as our select result and delete the Phi. If
657 * the Phi node has more than two operands, we will arbitrarily use the SSA
Vladimir Marko341e4252014-12-19 10:29:51 +0000658 * name of the "false" path, delete the SSA name of the "true" path from the
buzbee311ca162013-02-28 15:56:43 -0800659 * Phi node (and fix up the incoming arc list).
660 */
661 if (phi->ssa_rep->num_uses == 2) {
662 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000663 // Rather than changing the Phi to kMirOpNop, remove it completely.
664 // This avoids leaving other Phis after kMirOpNop (i.e. a non-Phi) insn.
665 tk_tk->RemoveMIR(phi);
666 int dead_false_def = if_false->ssa_rep->defs[0];
667 raw_use_counts_[dead_false_def] = use_counts_[dead_false_def] = 0;
buzbee311ca162013-02-28 15:56:43 -0800668 } else {
Vladimir Marko341e4252014-12-19 10:29:51 +0000669 int live_def = if_false->ssa_rep->defs[0];
buzbee311ca162013-02-28 15:56:43 -0800670 mir->ssa_rep->defs[0] = live_def;
buzbee311ca162013-02-28 15:56:43 -0800671 }
Vladimir Marko341e4252014-12-19 10:29:51 +0000672 int dead_true_def = if_true->ssa_rep->defs[0];
673 raw_use_counts_[dead_true_def] = use_counts_[dead_true_def] = 0;
Vladimir Marko6e071832015-03-25 11:13:39 +0000674 // Update ending vreg->sreg map for GC maps generation.
675 int def_vreg = SRegToVReg(mir->ssa_rep->defs[0]);
676 bb->data_flow_info->vreg_to_ssa_map_exit[def_vreg] = mir->ssa_rep->defs[0];
Vladimir Marko341e4252014-12-19 10:29:51 +0000677 // We want to remove ft and tk and link bb directly to ft_ft. First, we need
678 // to update all Phi inputs correctly with UpdatePredecessor(ft->id, bb->id)
679 // since the live_def above comes from ft->first_mir_insn (if_false).
680 DCHECK(if_false == ft->first_mir_insn);
681 ft_ft->UpdatePredecessor(ft->id, bb->id);
682 // Correct the rest of the links between bb, ft and ft_ft.
683 ft->ErasePredecessor(bb->id);
684 ft->fall_through = NullBasicBlockId;
685 bb->fall_through = ft_ft->id;
686 // Now we can kill tk and ft.
687 tk->Kill(this);
688 ft->Kill(this);
689 // NOTE: DFS order, domination info and topological order are still usable
690 // despite the newly dead blocks.
buzbee311ca162013-02-28 15:56:43 -0800691 }
692 }
693 }
694 }
695 }
buzbee1da1e2f2013-11-15 13:37:01 -0800696 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800697 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100698 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100699 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
700 }
buzbee311ca162013-02-28 15:56:43 -0800701
buzbee311ca162013-02-28 15:56:43 -0800702 return true;
703}
704
buzbee311ca162013-02-28 15:56:43 -0800705/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700706void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700707 if (bb->data_flow_info != NULL) {
708 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
709 if (mir->ssa_rep == NULL) {
710 continue;
buzbee311ca162013-02-28 15:56:43 -0800711 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700712 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700713 if (df_attributes & DF_HAS_NULL_CHKS) {
714 checkstats_->null_checks++;
715 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
716 checkstats_->null_checks_eliminated++;
717 }
718 }
719 if (df_attributes & DF_HAS_RANGE_CHKS) {
720 checkstats_->range_checks++;
721 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
722 checkstats_->range_checks_eliminated++;
723 }
buzbee311ca162013-02-28 15:56:43 -0800724 }
725 }
726 }
buzbee311ca162013-02-28 15:56:43 -0800727}
728
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700729/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700730bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700731 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800732 if (!bb->explicit_throw) {
733 return false;
734 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700735
736 // If we visited it, we are done.
737 if (bb->visited) {
738 return false;
739 }
740 bb->visited = true;
741
buzbee311ca162013-02-28 15:56:43 -0800742 BasicBlock* walker = bb;
743 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700744 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800745 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
746 break;
747 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100748 DCHECK(!walker->predecessors.empty());
749 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700750
751 // If we visited the predecessor, we are done.
752 if (prev->visited) {
753 return false;
754 }
755 prev->visited = true;
756
buzbee311ca162013-02-28 15:56:43 -0800757 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700758 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700759 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800760 break;
761 }
buzbee0d829482013-10-11 15:24:55 -0700762 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700763 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800764 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
765 switch (opcode) {
766 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
767 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
768 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
769 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
770 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
771 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
772 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
773 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
774 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
775 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
776 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
777 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
778 default: LOG(FATAL) << "Unexpected opcode " << opcode;
779 }
780 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700781 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800782 prev->taken = prev->fall_through;
783 prev->fall_through = t_bb;
784 break;
785 }
786 walker = prev;
787 }
788 return false;
789}
790
791/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700792void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800793 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100794 while ((bb->block_type == kDalvikByteCode) &&
795 (bb->last_mir_insn != nullptr) &&
796 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
797 MIR* mir = bb->last_mir_insn;
798 DCHECK(bb->first_mir_insn != nullptr);
799
Vladimir Marko315cc202014-12-18 17:01:02 +0000800 // Get the paired insn and check if it can still throw.
Vladimir Marko312eb252014-10-07 15:01:57 +0100801 MIR* throw_insn = mir->meta.throw_insn;
Vladimir Marko315cc202014-12-18 17:01:02 +0000802 if (CanThrow(throw_insn)) {
buzbee311ca162013-02-28 15:56:43 -0800803 break;
804 }
805
buzbee311ca162013-02-28 15:56:43 -0800806 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700807 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800808 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100809 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700810
811 // Now move instructions from bb_next to bb. Start off with doing a sanity check
812 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800813 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700814 // Now move all instructions (throw instruction to last one) from bb_next to bb.
815 MIR* last_to_move = bb_next->last_mir_insn;
816 bb_next->RemoveMIRList(throw_insn, last_to_move);
817 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
818 // The kMirOpCheck instruction is not needed anymore.
819 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
820 bb->RemoveMIR(mir);
821
Vladimir Marko312eb252014-10-07 15:01:57 +0100822 // Before we overwrite successors, remove their predecessor links to bb.
823 bb_next->ErasePredecessor(bb->id);
824 if (bb->taken != NullBasicBlockId) {
825 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
826 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
827 // bb->taken will be overwritten below.
828 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
829 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
830 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
831 bb_taken->predecessors.clear();
832 bb_taken->block_type = kDead;
833 DCHECK(bb_taken->data_flow_info == nullptr);
834 } else {
835 DCHECK_EQ(bb->successor_block_list_type, kCatch);
836 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
837 if (succ_info->block != NullBasicBlockId) {
838 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
839 DCHECK(succ_bb->catch_entry);
840 succ_bb->ErasePredecessor(bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100841 }
842 }
843 }
buzbee311ca162013-02-28 15:56:43 -0800844 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700845 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100846 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100847 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800848 // Use the ending block linkage from the next block
849 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100850 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800851 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100852 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800853 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900854 * If lower-half of pair of blocks to combine contained
855 * a return or a conditional branch or an explicit throw,
856 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800857 */
858 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900859 bb->conditional_branch = bb_next->conditional_branch;
860 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100861 // Merge the use_lvn flag.
862 bb->use_lvn |= bb_next->use_lvn;
863
864 // Kill the unused block.
865 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800866
867 /*
868 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
869 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100870 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800871 */
872
Vladimir Marko312eb252014-10-07 15:01:57 +0100873 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800874 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100875 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700876 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100877 // Update predecessors in children.
878 ChildBlockIterator iter(bb, this);
879 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
880 child->UpdatePredecessor(bb_next->id, bb->id);
881 }
882
Vladimir Markoffda4992014-12-18 17:05:58 +0000883 // DFS orders, domination and topological order are not up to date anymore.
Vladimir Marko312eb252014-10-07 15:01:57 +0100884 dfs_orders_up_to_date_ = false;
Vladimir Markoffda4992014-12-18 17:05:58 +0000885 domination_up_to_date_ = false;
886 topological_order_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800887
888 // Now, loop back and see if we can keep going
889 }
buzbee311ca162013-02-28 15:56:43 -0800890}
891
Vladimir Marko67c72b82014-10-09 12:26:10 +0100892bool MIRGraph::EliminateNullChecksGate() {
893 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
894 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
895 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000896 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100897
Vladimir Marko67c72b82014-10-09 12:26:10 +0100898 DCHECK(temp_scoped_alloc_.get() == nullptr);
899 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700900 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000901 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
902 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000903 temp_.nce.ending_vregs_to_check_matrix =
904 temp_scoped_alloc_->AllocArray<ArenaBitVector*>(GetNumBlocks(), kArenaAllocMisc);
Vladimir Markof585e542014-11-21 13:41:32 +0000905 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700906
907 // reset MIR_MARK
908 AllNodesIterator iter(this);
909 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
910 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
911 mir->optimization_flags &= ~MIR_MARK;
912 }
913 }
914
Vladimir Marko67c72b82014-10-09 12:26:10 +0100915 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000916}
917
buzbee1da1e2f2013-11-15 13:37:01 -0800918/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100919 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800920 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100921bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100922 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
923 // Ignore the kExitBlock as well.
924 DCHECK(bb->first_mir_insn == nullptr);
925 return false;
926 }
buzbee311ca162013-02-28 15:56:43 -0800927
Vladimir Markof585e542014-11-21 13:41:32 +0000928 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100929 /*
930 * Set initial state. Catch blocks don't need any special treatment.
931 */
932 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100933 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100934 // Assume all ins are objects.
935 for (uint16_t in_reg = GetFirstInVR();
936 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100937 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100938 }
939 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100940 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100941 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100942 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100943 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100944 } else {
945 DCHECK_EQ(bb->block_type, kDalvikByteCode);
946 // Starting state is union of all incoming arcs.
947 bool copied_first = false;
948 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000949 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100950 continue;
951 }
952 BasicBlock* pred_bb = GetBasicBlock(pred_id);
953 DCHECK(pred_bb != nullptr);
954 MIR* null_check_insn = nullptr;
955 if (pred_bb->block_type == kDalvikByteCode) {
956 // Check to see if predecessor had an explicit null-check.
957 MIR* last_insn = pred_bb->last_mir_insn;
958 if (last_insn != nullptr) {
959 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
960 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
961 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
962 // Remember the null check insn if there's no other predecessor requiring null check.
963 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
964 null_check_insn = last_insn;
965 }
buzbee1da1e2f2013-11-15 13:37:01 -0800966 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700967 }
968 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100969 if (!copied_first) {
970 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000971 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100972 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000973 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100974 }
975 if (null_check_insn != nullptr) {
976 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100977 }
978 }
979 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800980 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100981 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100982 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800983
984 // Walk through the instruction in the block, updating as necessary
985 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700986 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800987
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700988 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
989 // The algorithm was written in a phi agnostic way.
990 continue;
991 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100992
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000993 // Might need a null check?
994 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100995 int src_vreg;
996 if (df_attributes & DF_NULL_CHK_OUT0) {
997 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
998 src_vreg = mir->dalvikInsn.vC;
999 } else if (df_attributes & DF_NULL_CHK_B) {
1000 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1001 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001002 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001003 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1004 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1005 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001006 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001007 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001008 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001009 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001010 } else {
1011 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001012 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001013 // Mark src_vreg as null-checked.
1014 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001015 }
1016 }
1017
1018 if ((df_attributes & DF_A_WIDE) ||
1019 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1020 continue;
1021 }
1022
1023 /*
1024 * First, mark all object definitions as requiring null check.
1025 * Note: we can't tell if a CONST definition might be used as an object, so treat
1026 * them all as object definitions.
1027 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001028 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001029 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001030 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001031 }
1032
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001033 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 if (df_attributes & DF_NON_NULL_DST) {
1035 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001036 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1037 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001038 }
1039
buzbee311ca162013-02-28 15:56:43 -08001040 // Mark non-null returns from invoke-style NEW*
1041 if (df_attributes & DF_NON_NULL_RET) {
1042 MIR* next_mir = mir->next;
1043 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001044 if (UNLIKELY(next_mir == nullptr)) {
1045 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1046 // target, so the MOVE_RESULT cannot be broken away into another block.
1047 LOG(WARNING) << "Unexpected end of block following new";
1048 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1049 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001050 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001051 // Mark as null checked.
1052 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001053 }
1054 }
1055
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001056 // Propagate null check state on register copies.
1057 if (df_attributes & DF_NULL_TRANSFER_0) {
1058 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1059 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1060 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001061 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001062 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001063 }
1064 }
buzbee311ca162013-02-28 15:56:43 -08001065 }
1066
1067 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001068 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001069 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001070 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001071 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001072 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001073 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001074 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001075 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1076 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001077 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001078 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001079 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1080 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001081 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001082 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001083}
1084
Vladimir Marko67c72b82014-10-09 12:26:10 +01001085void MIRGraph::EliminateNullChecksEnd() {
1086 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001087 temp_.nce.num_vregs = 0u;
1088 temp_.nce.work_vregs_to_check = nullptr;
1089 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001090 DCHECK(temp_scoped_alloc_.get() != nullptr);
1091 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001092
1093 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001094 AllNodesIterator iter(this);
1095 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1096 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001097 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001098 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001099 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001100 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001101 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1102 }
1103 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001104}
1105
1106/*
1107 * Perform type and size inference for a basic block.
1108 */
1109bool MIRGraph::InferTypes(BasicBlock* bb) {
1110 if (bb->data_flow_info == nullptr) return false;
1111
1112 bool infer_changed = false;
1113 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1114 if (mir->ssa_rep == NULL) {
1115 continue;
1116 }
1117
1118 // Propagate type info.
1119 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1120 }
1121
1122 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001123}
1124
1125bool MIRGraph::EliminateClassInitChecksGate() {
1126 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001127 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001128 return false;
1129 }
1130
Vladimir Markobfea9c22014-01-17 17:49:33 +00001131 DCHECK(temp_scoped_alloc_.get() == nullptr);
1132 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1133
1134 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001135 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +00001136 temp_.cice.indexes = temp_scoped_alloc_->AllocArray<uint16_t>(end, kArenaAllocGrowableArray);
Vladimir Markof585e542014-11-21 13:41:32 +00001137 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001138
1139 uint32_t unique_class_count = 0u;
1140 {
1141 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1142 // ScopedArenaAllocator.
1143
1144 // Embed the map value in the entry to save space.
1145 struct MapEntry {
1146 // Map key: the class identified by the declaring dex file and type index.
1147 const DexFile* declaring_dex_file;
1148 uint16_t declaring_class_idx;
1149 // Map value: index into bit vectors of classes requiring initialization checks.
1150 uint16_t index;
1151 };
1152 struct MapEntryComparator {
1153 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1154 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1155 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1156 }
1157 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1158 }
1159 };
1160
Vladimir Markobfea9c22014-01-17 17:49:33 +00001161 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001162 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1163 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001164
1165 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1166 AllNodesIterator iter(this);
1167 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001168 if (bb->block_type == kDalvikByteCode) {
1169 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001170 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001171 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001172 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001173 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1174 MapEntry entry = {
1175 // Treat unresolved fields as if each had its own class.
1176 field_info.IsResolved() ? field_info.DeclaringDexFile()
1177 : nullptr,
1178 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1179 : field_info.FieldIndex(),
1180 static_cast<uint16_t>(class_to_index_map.size())
1181 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001182 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001183 // Using offset/2 for index into temp_.cice.indexes.
1184 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001185 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001186 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001187 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1188 DCHECK(method_info.IsStatic());
1189 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1190 MapEntry entry = {
1191 method_info.DeclaringDexFile(),
1192 method_info.DeclaringClassIndex(),
1193 static_cast<uint16_t>(class_to_index_map.size())
1194 };
1195 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001196 // Using offset/2 for index into temp_.cice.indexes.
1197 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001198 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001199 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001200 }
1201 }
1202 }
1203 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1204 }
1205
1206 if (unique_class_count == 0u) {
1207 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001208 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001209 temp_scoped_alloc_.reset();
1210 return false;
1211 }
1212
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001213 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001214 temp_.cice.num_class_bits = 2u * unique_class_count;
1215 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1216 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +00001217 temp_.cice.ending_classes_to_check_matrix =
1218 temp_scoped_alloc_->AllocArray<ArenaBitVector*>(GetNumBlocks(), kArenaAllocMisc);
Vladimir Markof585e542014-11-21 13:41:32 +00001219 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1220 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001221 return true;
1222}
1223
1224/*
1225 * Eliminate unnecessary class initialization checks for a basic block.
1226 */
1227bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1228 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001229 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1230 // Ignore the kExitBlock as well.
1231 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001232 return false;
1233 }
1234
1235 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001236 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001237 */
Vladimir Markof585e542014-11-21 13:41:32 +00001238 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001239 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001240 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001241 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001242 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001243 // Starting state is union of all incoming arcs.
1244 bool copied_first = false;
1245 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001246 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001247 continue;
1248 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001249 if (!copied_first) {
1250 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001251 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001252 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001253 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001254 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001255 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001256 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001257 }
1258 // At this point, classes_to_check shows which classes need clinit checks.
1259
1260 // Walk through the instruction in the block, updating as necessary
1261 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001262 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001263 if (index != 0xffffu) {
1264 bool check_initialization = false;
1265 bool check_dex_cache = false;
1266
1267 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1268 // Dex instructions with width 1 can have the same offset/2.
1269
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001270 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001271 check_initialization = true;
1272 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001273 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001274 check_initialization = true;
1275 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1276 }
1277
1278 if (check_dex_cache) {
1279 uint32_t check_dex_cache_index = 2u * index + 1u;
1280 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1281 // Eliminate the class init check.
1282 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1283 } else {
1284 // Do the class init check.
1285 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1286 }
1287 classes_to_check->ClearBit(check_dex_cache_index);
1288 }
1289 if (check_initialization) {
1290 uint32_t check_clinit_index = 2u * index;
1291 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1292 // Eliminate the class init check.
1293 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1294 } else {
1295 // Do the class init check.
1296 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001297 }
1298 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001299 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001300 }
1301 }
1302 }
1303
1304 // Did anything change?
1305 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001306 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001307 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001308 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001309 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001310 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001311 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001312 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1313 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001314 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001315 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001316 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1317 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001318 }
1319 return changed;
1320}
1321
1322void MIRGraph::EliminateClassInitChecksEnd() {
1323 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001324 temp_.cice.num_class_bits = 0u;
1325 temp_.cice.work_classes_to_check = nullptr;
1326 temp_.cice.ending_classes_to_check_matrix = nullptr;
1327 DCHECK(temp_.cice.indexes != nullptr);
1328 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001329 DCHECK(temp_scoped_alloc_.get() != nullptr);
1330 temp_scoped_alloc_.reset();
1331}
1332
Vladimir Marko95a05972014-05-30 10:01:32 +01001333bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001334 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001335 return false;
1336 }
1337
1338 DCHECK(temp_scoped_alloc_ == nullptr);
1339 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001340 temp_.gvn.ifield_ids =
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001341 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001342 temp_.gvn.sfield_ids =
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001343 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001344 DCHECK(temp_.gvn.gvn == nullptr);
1345 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1346 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001347 return true;
1348}
1349
1350bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001351 DCHECK(temp_.gvn.gvn != nullptr);
1352 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001353 if (lvn != nullptr) {
1354 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1355 lvn->GetValueNumber(mir);
1356 }
1357 }
Vladimir Markof585e542014-11-21 13:41:32 +00001358 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001359 return change;
1360}
1361
1362void MIRGraph::ApplyGlobalValueNumberingEnd() {
1363 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001364 DCHECK(temp_.gvn.gvn != nullptr);
1365 if (temp_.gvn.gvn->Good()) {
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001366 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001367 if (max_nested_loops_ != 0u) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001368 TopologicalSortIterator iter(this);
1369 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1370 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001371 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001372 if (lvn != nullptr) {
1373 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1374 lvn->GetValueNumber(mir);
1375 }
Vladimir Markof585e542014-11-21 13:41:32 +00001376 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001377 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001378 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001379 }
1380 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001381 // GVN was successful, running the LVN would be useless.
1382 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001383 } else {
1384 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001385 cu_->disable_opt |= (1u << kGvnDeadCodeElimination);
Vladimir Marko95a05972014-05-30 10:01:32 +01001386 }
1387
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001388 if ((cu_->disable_opt & (1 << kGvnDeadCodeElimination)) != 0) {
1389 EliminateDeadCodeEnd();
1390 } // else preserve GVN data for CSE.
1391}
1392
1393bool MIRGraph::EliminateDeadCodeGate() {
1394 if ((cu_->disable_opt & (1 << kGvnDeadCodeElimination)) != 0) {
1395 return false;
1396 }
1397 DCHECK(temp_scoped_alloc_ != nullptr);
1398 temp_.gvn.dce = new (temp_scoped_alloc_.get()) GvnDeadCodeElimination(temp_.gvn.gvn,
1399 temp_scoped_alloc_.get());
1400 return true;
1401}
1402
1403bool MIRGraph::EliminateDeadCode(BasicBlock* bb) {
1404 DCHECK(temp_scoped_alloc_ != nullptr);
1405 DCHECK(temp_.gvn.gvn != nullptr);
1406 if (bb->block_type != kDalvikByteCode) {
1407 return false;
1408 }
1409 DCHECK(temp_.gvn.dce != nullptr);
1410 temp_.gvn.dce->Apply(bb);
1411 return false; // No need to repeat.
1412}
1413
1414void MIRGraph::EliminateDeadCodeEnd() {
1415 DCHECK_EQ(temp_.gvn.dce != nullptr, (cu_->disable_opt & (1 << kGvnDeadCodeElimination)) == 0);
1416 if (temp_.gvn.dce != nullptr) {
1417 delete temp_.gvn.dce;
1418 temp_.gvn.dce = nullptr;
1419 }
Vladimir Markof585e542014-11-21 13:41:32 +00001420 delete temp_.gvn.gvn;
1421 temp_.gvn.gvn = nullptr;
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001422 temp_.gvn.ifield_ids = nullptr;
1423 temp_.gvn.sfield_ids = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001424 DCHECK(temp_scoped_alloc_ != nullptr);
1425 temp_scoped_alloc_.reset();
1426}
1427
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001428void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1429 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001430 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1431 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001432 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1433 return;
1434 }
1435
1436 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1437 MethodReference target = method_info.GetTargetMethod();
1438 DexCompilationUnit inlined_unit(
1439 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1440 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1441 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001442 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
Mathieu Chartiere5f13e52015-02-24 09:37:21 -08001443 MirIFieldLoweringInfo inlined_field_info(field_idx, type, false);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001444 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1445 DCHECK(inlined_field_info.IsResolved());
1446
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001447 uint32_t field_info_index = ifield_lowering_infos_.size();
1448 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001449 temp_.smi.processed_indexes->SetBit(method_index);
1450 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001451 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1452}
1453
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001454bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001455 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001456 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001457 return false;
1458 }
1459 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1460 // This isn't the Quick compiler.
1461 return false;
1462 }
1463 return true;
1464}
1465
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001466void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001467 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1468 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1469
1470 DCHECK(temp_scoped_alloc_.get() == nullptr);
1471 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001472 temp_.smi.num_indexes = method_lowering_infos_.size();
1473 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1474 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1475 temp_.smi.processed_indexes->ClearAllBits();
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +00001476 temp_.smi.lowering_infos =
1477 temp_scoped_alloc_->AllocArray<uint16_t>(temp_.smi.num_indexes, kArenaAllocGrowableArray);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001478}
1479
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001480void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001481 if (bb->block_type != kDalvikByteCode) {
1482 return;
1483 }
1484 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001485 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001486 continue;
1487 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001488 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001489 continue;
1490 }
1491 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1492 if (!method_info.FastPath()) {
1493 continue;
1494 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001495
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001496 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001497 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001498 continue;
1499 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001500
1501 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001502 bool needs_clinit = !method_info.IsClassInitialized() &&
1503 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001504 if (needs_clinit) {
1505 continue;
1506 }
1507 }
1508
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001509 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1510 MethodReference target = method_info.GetTargetMethod();
1511 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1512 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001513 if (cu_->verbose || cu_->print_pass) {
1514 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1515 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1516 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1517 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001518 }
1519 }
1520 }
1521}
1522
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001523void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001524 // Clean up temporaries.
1525 DCHECK(temp_.smi.lowering_infos != nullptr);
1526 temp_.smi.lowering_infos = nullptr;
1527 temp_.smi.num_indexes = 0u;
1528 DCHECK(temp_.smi.processed_indexes != nullptr);
1529 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001530 DCHECK(temp_scoped_alloc_.get() != nullptr);
1531 temp_scoped_alloc_.reset();
1532}
1533
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001534void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001535 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001536 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001537 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001538 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001539 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1540 CountChecks(bb);
1541 }
1542 if (stats->null_checks > 0) {
1543 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1544 float checks = static_cast<float>(stats->null_checks);
1545 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1546 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1547 << (eliminated/checks) * 100.0 << "%";
1548 }
1549 if (stats->range_checks > 0) {
1550 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1551 float checks = static_cast<float>(stats->range_checks);
1552 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1553 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1554 << (eliminated/checks) * 100.0 << "%";
1555 }
1556}
1557
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001558bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001559 if (bb->visited) return false;
1560 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1561 || (bb->block_type == kExitBlock))) {
1562 // Ignore special blocks
1563 bb->visited = true;
1564 return false;
1565 }
1566 // Must be head of extended basic block.
1567 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001568 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001569 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001570 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001571 // Visit blocks strictly dominated by this head.
1572 while (bb != NULL) {
1573 bb->visited = true;
1574 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001575 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001576 bb = NextDominatedBlock(bb);
1577 }
buzbee1da1e2f2013-11-15 13:37:01 -08001578 if (terminated_by_return || do_local_value_numbering) {
1579 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001580 bb = start_bb;
1581 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001582 bb->use_lvn = do_local_value_numbering;
1583 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001584 bb = NextDominatedBlock(bb);
1585 }
1586 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001587 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001588}
1589
Vladimir Markoffda4992014-12-18 17:05:58 +00001590void MIRGraph::BasicBlockOptimizationStart() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001591 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1592 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001593 temp_.gvn.ifield_ids =
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001594 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001595 temp_.gvn.sfield_ids =
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001596 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1597 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001598}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001599
Vladimir Markoffda4992014-12-18 17:05:58 +00001600void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001601 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1602 ClearAllVisitedFlags();
1603 PreOrderDfsIterator iter2(this);
1604 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1605 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001606 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001607 // Perform extended basic block optimizations.
1608 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1609 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1610 }
1611 } else {
1612 PreOrderDfsIterator iter(this);
1613 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1614 BasicBlockOpt(bb);
1615 }
buzbee311ca162013-02-28 15:56:43 -08001616 }
Vladimir Markoffda4992014-12-18 17:05:58 +00001617}
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001618
Vladimir Markoffda4992014-12-18 17:05:58 +00001619void MIRGraph::BasicBlockOptimizationEnd() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001620 // Clean up after LVN.
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001621 temp_.gvn.ifield_ids = nullptr;
1622 temp_.gvn.sfield_ids = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001623 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001624}
1625
Vladimir Marko8b858e12014-11-27 14:52:37 +00001626bool MIRGraph::EliminateSuspendChecksGate() {
1627 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1628 GetMaxNestedLoops() == 0u || // Nothing to do.
1629 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1630 // Exclude 32 as well to keep bit shifts well-defined.
1631 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1632 return false;
1633 }
1634 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1635 temp_.sce.inliner =
1636 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1637 }
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +00001638 suspend_checks_in_loops_ = arena_->AllocArray<uint32_t>(GetNumBlocks(), kArenaAllocMisc);
Vladimir Marko8b858e12014-11-27 14:52:37 +00001639 return true;
1640}
1641
1642bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1643 if (bb->block_type != kDalvikByteCode) {
1644 return false;
1645 }
1646 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1647 if (bb->nesting_depth == 0u) {
1648 // Out of loops.
1649 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1650 return false;
1651 }
1652 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1653 bool found_invoke = false;
1654 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1655 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1656 (temp_.sce.inliner == nullptr ||
1657 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1658 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1659 found_invoke = true;
1660 break;
1661 }
1662 }
1663 if (!found_invoke) {
1664 // Intersect suspend checks from predecessors.
1665 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1666 uint32_t pred_mask_union = 0u;
1667 for (BasicBlockId pred_id : bb->predecessors) {
1668 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1669 if (pred_topo_idx < bb_topo_idx) {
1670 // Determine the loop depth of the predecessors relative to this block.
1671 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1672 while (pred_loop_depth != 0u &&
1673 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1674 --pred_loop_depth;
1675 }
1676 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1677 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1678 // Intersect pred_mask bits in suspend_checks_in_loops with
1679 // suspend_checks_in_loops_[pred_id].
1680 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1681 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1682 pred_mask_union |= pred_mask;
1683 }
1684 }
1685 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1686 pred_mask_union);
1687 suspend_checks_in_loops &= pred_mask_union;
1688 }
1689 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1690 if (suspend_checks_in_loops == 0u) {
1691 return false;
1692 }
1693 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1694 if (bb->taken != NullBasicBlockId) {
1695 DCHECK(bb->last_mir_insn != nullptr);
1696 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1697 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1698 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1699 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1700 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1701 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1702 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1703 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1704 }
1705 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1706 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1707 MIR* mir = NewMIR();
1708 mir->dalvikInsn.opcode = Instruction::GOTO;
1709 mir->dalvikInsn.vA = 0; // Branch offset.
1710 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1711 mir->m_unit_index = current_method_;
1712 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1713 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1714 bb->AppendMIR(mir);
1715 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1716 }
1717 return true;
1718}
1719
1720void MIRGraph::EliminateSuspendChecksEnd() {
1721 temp_.sce.inliner = nullptr;
1722}
1723
Vladimir Marko7a01dc22015-01-02 17:00:44 +00001724bool MIRGraph::CanThrow(MIR* mir) const {
Ningsheng Jiana262f772014-11-25 16:48:07 +08001725 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1726 return false;
1727 }
1728 const int opt_flags = mir->optimization_flags;
1729 uint64_t df_attributes = GetDataFlowAttributes(mir);
1730
Vladimir Marko315cc202014-12-18 17:01:02 +00001731 // First, check if the insn can still throw NPE.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001732 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1733 return true;
1734 }
Vladimir Marko315cc202014-12-18 17:01:02 +00001735
1736 // Now process specific instructions.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001737 if ((df_attributes & DF_IFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001738 // The IGET/IPUT family. We have processed the IGET/IPUT null check above.
1739 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1740 // If not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001741 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001742 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
1743 return !fast;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001744 } else if ((df_attributes & DF_SFIELD) != 0) {
Vladimir Marko315cc202014-12-18 17:01:02 +00001745 // The SGET/SPUT family. Check for potentially throwing class initialization.
1746 // Also, if not fast, weird things can happen and the insn can throw.
Ningsheng Jiana262f772014-11-25 16:48:07 +08001747 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko315cc202014-12-18 17:01:02 +00001748 bool fast = (df_attributes & DF_DA) != 0 ? field_info.FastGet() : field_info.FastPut();
Ningsheng Jiana262f772014-11-25 16:48:07 +08001749 bool is_class_initialized = field_info.IsClassInitialized() ||
1750 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
Vladimir Marko315cc202014-12-18 17:01:02 +00001751 return !(fast && is_class_initialized);
1752 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1753 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
1754 DCHECK_NE(opt_flags & MIR_IGNORE_NULL_CHECK, 0);
1755 // Non-throwing only if range check has been eliminated.
1756 return ((opt_flags & MIR_IGNORE_RANGE_CHECK) == 0);
Vladimir Marko22fe45d2015-03-18 11:33:58 +00001757 } else if (mir->dalvikInsn.opcode == Instruction::CHECK_CAST &&
1758 (opt_flags & MIR_IGNORE_CHECK_CAST) != 0) {
1759 return false;
Vladimir Marko315cc202014-12-18 17:01:02 +00001760 } else if (mir->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
Vladimir Marko315cc202014-12-18 17:01:02 +00001761 static_cast<int>(mir->dalvikInsn.opcode) == kMirOpNullCheck) {
1762 // No more checks for these (null check was processed above).
1763 return false;
Ningsheng Jiana262f772014-11-25 16:48:07 +08001764 }
1765 return true;
1766}
1767
1768bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1769 DCHECK(first->ssa_rep != nullptr);
1770 DCHECK(second->ssa_rep != nullptr);
1771 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1772 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1773 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1774 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1775 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1776 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1777 if (use == vreg0 || use == vreg1) {
1778 return true;
1779 }
1780 }
1781 }
1782 return false;
1783}
1784
1785void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1786 bool is_wide, bool is_sub) {
1787 if (is_wide) {
1788 if (is_sub) {
1789 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1790 } else {
1791 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1792 }
1793 } else {
1794 if (is_sub) {
1795 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1796 } else {
1797 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1798 }
1799 }
1800 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1801 int32_t addend0 = INVALID_SREG;
1802 int32_t addend1 = INVALID_SREG;
1803 if (is_wide) {
1804 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1805 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1806 } else {
1807 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1808 }
1809
1810 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1811 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1812 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1813 // Clear the original multiply product ssa use count, as it is not used anymore.
1814 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1815 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1816 if (is_wide) {
1817 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1818 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1819 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1820 add_mir->ssa_rep->uses[4] = addend0;
1821 add_mir->ssa_rep->uses[5] = addend1;
1822 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1823 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1824 } else {
1825 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1826 add_mir->ssa_rep->uses[2] = addend0;
1827 }
1828 // Copy in the decoded instruction information.
1829 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1830 if (is_wide) {
1831 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1832 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1833 } else {
1834 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1835 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1836 }
1837 // Original multiply MIR is set to Nop.
1838 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1839}
1840
1841void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1842 if (bb->block_type == kDead) {
1843 return;
1844 }
1845 ScopedArenaAllocator allocator(&cu_->arena_stack);
1846 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1847 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1848 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1849 Instruction::Code opcode = mir->dalvikInsn.opcode;
1850 bool is_sub = true;
1851 bool is_candidate_multiply = false;
1852 switch (opcode) {
1853 case Instruction::MUL_INT:
1854 case Instruction::MUL_INT_2ADDR:
1855 is_candidate_multiply = true;
1856 break;
1857 case Instruction::MUL_LONG:
1858 case Instruction::MUL_LONG_2ADDR:
1859 if (cu_->target64) {
1860 is_candidate_multiply = true;
1861 }
1862 break;
1863 case Instruction::ADD_INT:
1864 case Instruction::ADD_INT_2ADDR:
1865 is_sub = false;
1866 FALLTHROUGH_INTENDED;
1867 case Instruction::SUB_INT:
1868 case Instruction::SUB_INT_2ADDR:
1869 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1870 // a*b+c
1871 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1872 false /* is_wide */, false /* is_sub */);
1873 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1874 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1875 // c+a*b or c-a*b
1876 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1877 false /* is_wide */, is_sub);
1878 ssa_mul_map.erase(map_it);
1879 }
1880 break;
1881 case Instruction::ADD_LONG:
1882 case Instruction::ADD_LONG_2ADDR:
1883 is_sub = false;
1884 FALLTHROUGH_INTENDED;
1885 case Instruction::SUB_LONG:
1886 case Instruction::SUB_LONG_2ADDR:
1887 if (!cu_->target64) {
1888 break;
1889 }
1890 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1891 // a*b+c
1892 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1893 true /* is_wide */, false /* is_sub */);
1894 ssa_mul_map.erase(map_it);
1895 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1896 // c+a*b or c-a*b
1897 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1898 true /* is_wide */, is_sub);
1899 ssa_mul_map.erase(map_it);
1900 }
1901 break;
1902 default:
1903 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1904 // Should not combine multiply and add MIRs across potential exception.
1905 ssa_mul_map.clear();
1906 }
1907 break;
1908 }
1909
1910 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1911 // It is because that current RA may allocate the same physical register to them. For this
1912 // kind of cases, the multiplier has been updated, we should not use updated value to the
1913 // multiply-add insn.
1914 if (ssa_mul_map.size() > 0) {
1915 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1916 MIR* mul = it->second;
1917 if (HasAntiDependency(mul, mir)) {
1918 it = ssa_mul_map.erase(it);
1919 } else {
1920 ++it;
1921 }
1922 }
1923 }
1924
1925 if (is_candidate_multiply &&
1926 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1927 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1928 }
1929 }
1930}
1931
buzbee311ca162013-02-28 15:56:43 -08001932} // namespace art